16645 commits

Author	SHA1	Message	Date
Mathieu Velten	d372ab3280	Add cancel_task API to the task scheduler (#19310) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2026-01-08 18:21:24 +00:00
Lukas Tautz	8ff1960878	Fix: use correct parameter when calling get_local_current_membership_for_user_in_room (#19353) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2026-01-07 18:32:16 +00:00
Hugh Nimmo-Smith	4dcf113bff	Support for stable m.oauth UIA stage for MSC4312 (#19273)	2026-01-07 12:52:21 +00:00
Patrice Brend'amour	a094d922c9	Implement synapse issue #16751: Treat local_media_directory as optional storage provider (#19204)	2026-01-06 23:29:58 +00:00
Devon Hudson	987b61a92b	Revert "Add an Admin API endpoint for listing quarantined media (#19268)" (#19351) ... Fixes #19349 This reverts commit 3f636386a6 (https://github.com/element-hq/synapse/pull/19268) as the DB migration was taking too long and blocking media access while it happened. See https://github.com/element-hq/synapse/issues/19349 for further information. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Travis Ralston <travpc@gmail.com>	2026-01-06 21:37:23 +00:00
Tulir Asokan	ac6463c6da	Fix media creation being ratelimited for appservices (#19335) ... Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>	2026-01-06 17:34:38 +00:00
Olivier 'reivilibre	cd252db3f5	Transform events with client metadata before serialising in /event response. (#19340) ... Fix /event/ endpoint not transforming event with per-requester metadata Pass notif_event through filter_events_for_client \ Not aware of an actual issue here, but seems silly to bypass it Call it filter_and_transform_events_for_client to make it more obvious --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>	2026-01-06 15:53:13 +00:00
Mathieu Velten	444bc56cda	Add rate limit conf to user directory endpoint (#19291) ... The goal is to avoid that an user could scrape the user directory too quickly.	2026-01-05 13:35:11 -06:00
Eric Eastwood	9dae6cc595	Add a way to expose metrics from the Docker image (SYNAPSE_ENABLE_METRICS) (#19324) ... Spawning from wanting to [run a load test](https://github.com/element-hq/synapse-rust-apps/pull/397) against the Complement Docker image of Synapse and see metrics from the homeserver. ### Why not just provide your own homeserver config? Probably possible but it gets tricky when you try to use the workers variant of the Docker image (`docker/Dockerfile-workers`). The way to workaround it would probably be to `yq` edit everything in a script and change `/data/homeserver.yaml` and `/conf/workers/*.yaml` to add the `metrics` listener. And then modify `/conf/workers/shared.yaml` to add `enable_metrics: true`. Doesn't spark much joy.	2026-01-01 14:00:00 -06:00
Eric Eastwood	41938d6fd2	Log the original bind exception when encountering Failed to listen on 0.0.0.0, continuing because listening on [::] (#19297) ... **Before:** ``` WARNING - call_when_running - Failed to listen on 0.0.0.0, continuing because listening on [::] ``` **After:** ``` WARNING - call_when_running - Failed to listen on 0.0.0.0, continuing because listening on [::]. Original exception: CannotListenError: Couldn't listen on 0.0.0.0:8008: [Errno 98] Address already in use. ```	2025-12-19 14:29:04 -06:00
Andrew Ferrazzutti	f4320b5a49	Admin API: worker support for Query User Account (#19281)	2025-12-16 17:42:08 +00:00
Tulir Asokan	3989d22a37	Implement pagination for MSC2666 (#19279) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2025-12-16 15:24:36 +00:00
Joshua Goins	0395b71e25	Fix Mastodon URL previews not showing anything useful (#19231) ... Fixes #18444. Inside of UrlPreviewer, we need to combine two dicts (one from oEmbed, and one from OpenGraph metadata in the HTML) and in Mastodon's case they were very different. Single Page Applications (SPAs) seem to sometimes provide better information in the OpenGraph tags than the oEmbed stubs, because the oEmbed stubs are filled in with JavaScript that Synapse does not execute. This change improves previews on Mastodon and YouTube (for the same reason). Tested to not regress previews of Twitter or GitHub.	2025-12-16 13:02:29 +00:00
Travis Ralston	0f2b29511f	Allow admins to bypass the quarantine check on media downloads (#19275) ... Co-authored-by: turt2live <1190097+turt2live@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2025-12-15 17:23:33 +00:00
Devon Hudson	df24e0f302	Fix support for older versions of zope-interface (#19274) ... Fixes #19269 Versions of zope-interface from RHEL, Ubuntu LTS 22 & 24 and OpenSuse don't support the new python union `X | Y` syntax for interfaces. This PR partially reverts the change over to fully use the new syntax, adds a minimum supported version of zope-interface to Synapse's dependency list, and removes the linter auto-upgrades which prefer the newer syntax. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2025-12-12 15:34:13 +00:00
Mathieu Velten	7347cc436e	Add memberships admin API (#19260) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2025-12-12 13:35:46 +00:00
Travis Ralston	3f636386a6	Add an Admin API endpoint for listing quarantined media (#19268) ... Co-authored-by: turt2live <1190097+turt2live@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2025-12-12 13:30:21 +00:00
Erik Johnston	dfd00a986f	Fix sliding sync performance slow down for long lived connections. (#19206) ... Fixes https://github.com/element-hq/synapse/issues/19175 This PR moves tracking of what lazy loaded membership we've sent to each room out of the required state table. This avoids that table from continuously growing, which massively helps performance as we pull out all matching rows for the connection when we receive a request. The new table is only read when we have data in a room to send, so we end up reading a lot fewer rows from the DB. Though we now read from that table for every room we have events to return in, rather than once at the start of the request. For an explanation of how the new table works, see the [comment](https://github.com/element-hq/synapse/blob/erikj/sss_better_membership_storage2/synapse/storage/schema/main/delta/93/02_sliding_sync_members.sql#L15-L38) on the table schema. The table is designed so that we can later prune old entries if we wish, but that is not implemented in this PR. Reviewable commit-by-commit. --------- Co-authored-by: Eric Eastwood <erice@element.io>	2025-12-12 10:02:57 +00:00
Devon Hudson	8b0083cad9	Respond with useful error codes when Content-Length header/s are invalid (#19212) ... Related to https://github.com/element-hq/synapse/issues/17035, when Synapse receives a request that is larger than the maximum size allowed, it aborts the connection without ever sending back a HTTP response. I dug into our usage of twisted and how best to try and report such an error and this is what I came up with. It would be ideal to be able to report the status from within `handleContentChunk` but that is called too early on in the twisted http handling code, before things have been setup enough to be able to properly write a response. I tested this change out locally (both with C-S and S-S apis) and they do receive a 413 response now in addition to the connection being closed. Hopefully this will aid in being able to quickly detect when https://github.com/element-hq/synapse/issues/17035 is occurring as the current situation makes it very hard to narrow things down to that specific issue without making a lot of assumptions. This PR also responds with more meaningful error codes now in the case of: - multiple `Content-Length` headers - invalid `Content-Length` header value - request content size being larger than the `Content-Length` value ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Eric Eastwood <erice@element.io>	2025-12-08 21:39:18 +00:00
dependabot[bot]	891983f3f4	Bump the minor-and-patches group with 3 updates (#19280) ... Bumps the minor-and-patches group with 3 updates: [mypy](https://github.com/python/mypy), [mypy-zope](https://github.com/Shoobx/mypy-zope) and [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers). Updates `mypy` from 1.17.1 to 1.18.2 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/python/mypy/blob/master/CHANGELOG.md">mypy's changelog</a>.</em></p> <blockquote> <h3>Mypy 1.18.2</h3> <ul> <li>Fix crash on recursive alias (Ivan Levkivskyi, PR <a href="https://redirect.github.com/python/mypy/pull/19845">19845</a>)</li> <li>Add additional guidance for stubtest errors when runtime is <code>object.__init__</code> (Stephen Morton, PR <a href="https://redirect.github.com/python/mypy/pull/19733">19733</a>)</li> <li>Fix handling of None values in f-string expressions in mypyc (BobTheBuidler, PR <a href="https://redirect.github.com/python/mypy/pull/19846">19846</a>)</li> </ul> <h3>Acknowledgements</h3> <p>Thanks to all mypy contributors who contributed to this release:</p> <ul> <li>Ali Hamdan</li> <li>Anthony Sottile</li> <li>BobTheBuidler</li> <li>Brian Schubert</li> <li>Chainfire</li> <li>Charlie Denton</li> <li>Christoph Tyralla</li> <li>CoolCat467</li> <li>Daniel Hnyk</li> <li>Emily</li> <li>Emma Smith</li> <li>Ethan Sarp</li> <li>Ivan Levkivskyi</li> <li>Jahongir Qurbonov</li> <li>Jelle Zijlstra</li> <li>Joren Hammudoglu</li> <li>Jukka Lehtosalo</li> <li>Marc Mueller</li> <li>Omer Hadari</li> <li>Piotr Sawicki</li> <li>PrinceNaroliya</li> <li>Randolf Scholz</li> <li>Robsdedude</li> <li>Saul Shanabrook</li> <li>Shantanu</li> <li>Stanislav Terliakov</li> <li>Stephen Morton</li> <li>wyattscarpenter</li> </ul> <p>I’d also like to thank my employer, Dropbox, for supporting mypy development.</p> <h2>Mypy 1.17</h2> <p>We’ve just uploaded mypy 1.17 to the Python Package Index (<a href="https://pypi.org/project/mypy/">PyPI</a>). Mypy is a static type checker for Python. This release includes new features and bug fixes. You can install it as follows:</p> <pre><code>python3 -m pip install -U mypy </code></pre> <p>You can read the full documentation for this release on <a href="http://mypy.readthedocs.io">Read the Docs</a>.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="df05f05555"><code>df05f05</code></a> remove +dev from version</li> <li><a href="01a7a1285d"><code>01a7a12</code></a> Update changelog for 1.18.2 (<a href="https://redirect.github.com/python/mypy/issues/19873">#19873</a>)</li> <li><a href="ca5abf09f3"><code>ca5abf0</code></a> Typeshed cherry-pick: Make type of <code>unitest.mock.Any</code> a subclass of <code>Any</code> (<a href="https://redirect.github.com/python/mypy/issues/1">#1</a>...</li> <li><a href="9d794b57d9"><code>9d794b5</code></a> [mypyc] fix: inappropriate <code>None</code>s in f-strings (<a href="https://redirect.github.com/python/mypy/issues/19846">#19846</a>)</li> <li><a href="2c0510c848"><code>2c0510c</code></a> stubtest: additional guidance on errors when runtime is object.<strong>init</strong> (<a href="https://redirect.github.com/python/mypy/issues/19733">#19733</a>)</li> <li><a href="2f3f03c3e3"><code>2f3f03c</code></a> Bump version to 1.18.2+dev for point release</li> <li><a href="76698412bc"><code>7669841</code></a> Fix crash on recursive alias in indirection.py (<a href="https://redirect.github.com/python/mypy/issues/19845">#19845</a>)</li> <li><a href="03fbaa941b"><code>03fbaa9</code></a> bump version to 1.18.1 due to wheels failure</li> <li><a href="b44a1fbf0c"><code>b44a1fb</code></a> removed +dev from version</li> <li><a href="7197a99d1a"><code>7197a99</code></a> Removed Unreleased in the Changelog for Release 1.18 (<a href="https://redirect.github.com/python/mypy/issues/19827">#19827</a>)</li> <li>Additional commits viewable in <a href="https://github.com/python/mypy/compare/v1.17.1...v1.18.2">compare view</a></li> </ul> </details> <br /> Updates `mypy-zope` from 1.0.13 to 1.0.14 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Shoobx/mypy-zope/blob/master/CHANGELOG.md">mypy-zope's changelog</a>.</em></p> <blockquote> <h2>1.0.14 (2025-12-01)</h2> <hr /> <ul> <li>Support mypy-1.19</li> <li>Support mypy-1.18</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="38d22f3f4f"><code>38d22f3</code></a> Preparing release 1.0.14</li> <li><a href="76762ec861"><code>76762ec</code></a> Maintain changelog</li> <li><a href="4971d98ab8"><code>4971d98</code></a> Merge pull request <a href="https://redirect.github.com/Shoobx/mypy-zope/issues/134">#134</a> from Shoobx/dependabot/pip/mypy-gte-1.0.0-and-lt-1.20.0</li> <li><a href="47af89d2c7"><code>47af89d</code></a> Update mypy requirement from &lt;1.19.0,&gt;=1.0.0 to &gt;=1.0.0,&lt;1.20.0</li> <li><a href="0c596ff804"><code>0c596ff</code></a> Maintain changelog</li> <li><a href="dcaa27841d"><code>dcaa278</code></a> Merge pull request <a href="https://redirect.github.com/Shoobx/mypy-zope/issues/132">#132</a> from Shoobx/dependabot/pip/mypy-gte-1.0.0-and-lt-1.19.0</li> <li><a href="8f7b6778df"><code>8f7b677</code></a> Update mypy requirement from &lt;1.18.0,&gt;=1.0.0 to &gt;=1.0.0,&lt;1.19.0</li> <li><a href="91b275b364"><code>91b275b</code></a> Back to development: 1.0.14</li> <li>See full diff in <a href="https://github.com/Shoobx/mypy-zope/compare/1.0.13...1.0.14">compare view</a></li> </ul> </details> <br /> Updates `phonenumbers` from 9.0.18 to 9.0.19 <details> <summary>Commits</summary> <ul> <li><a href="38f2ffe1e8"><code>38f2ffe</code></a> Prep for 9.0.19 release</li> <li><a href="cd7f0cc64f"><code>cd7f0cc</code></a> Generated files for metadata</li> <li><a href="40ae18f50a"><code>40ae18f</code></a> Merge metadata changes from upstream 9.0.19</li> <li>See full diff in <a href="https://github.com/daviddrysdale/python-phonenumbers/compare/v9.0.18...v9.0.19">compare view</a></li> </ul> </details> <br /> **Does not** update `pysaml2` from 7.5.0 to 7.5.4 since this would downgrade pyOpenSSL <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/IdentityPython/pysaml2/releases">pysaml2's releases</a>.</em></p> <blockquote> <h2>Version v7.5.4</h2> <h2>v7.5.4 (2025-10-07)</h2> <ul> <li>Minor refactor to handle <code>shelve.open</code> and <code>dbm</code> errors</li> <li>Remove import of deprecated <code>cgi</code> module</li> <li>Replace deprecated <code>datetime.utcnow()</code> by <code>datetime.now(timezone.utc)</code></li> <li>deps: Remove the <code>importlib_metadata</code> dependency</li> <li>deps: Remove the <code>importlib_resources</code> dependency</li> <li>deps: Update dependency versions and lockfile</li> <li>build: Update pyproject and lockfile to be compatible with PEP 621</li> <li>docs: Correct spelling mistakes</li> <li>docs: Fix interal references/links</li> <li>docs: Clarify units for accepted_time_diff config param</li> <li>docs: Correct documentation for contact_person</li> </ul> <h2>Version 7.5.3</h2> <h2>7.5.3 (2025-10-04)</h2> <ul> <li><a href="https://redirect.github.com/IdentityPython/pysaml2/issues/973">#973</a> Fix prepare_for_negotiated_authenticate to avoid double signing redirect requests</li> </ul> <h2>Version 7.5.2</h2> <h2>7.5.2 (2025-02-10)</h2> <ul> <li>Include the XSD of the XML Encryption Syntax and Processing Version 1.1 to the schema validator</li> </ul> <h2>Version 7.5.1</h2> <h2>7.5.1 (2025-02-10)</h2> <ul> <li>deps: restrict pyOpenSSL up to v24.2.1 until it is replaced</li> <li>deps: update dependncies for the lockfile and examples</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/IdentityPython/pysaml2/blob/master/CHANGELOG.md">pysaml2's changelog</a>.</em></p> <blockquote> <h2>v7.5.4 (2025-10-07)</h2> <ul> <li>Minor refactor to handle <code>shelve.open</code> and <code>dbm</code> errors</li> <li>Remove import of deprecated <code>cgi</code> module</li> <li>Replace deprecated <code>datetime.utcnow()</code> by <code>datetime.now(timezone.utc)</code></li> <li>deps: Remove the <code>importlib_metadata</code> dependency</li> <li>deps: Remove the <code>importlib_resources</code> dependency</li> <li>deps: Update dependency versions and lockfile</li> <li>build: Update pyproject and lockfile to be compatible with PEP 621</li> <li>docs: Correct spelling mistakes</li> <li>docs: Fix interal references/links</li> <li>docs: Clarify units for accepted_time_diff config param</li> <li>docs: Correct documentation for contact_person</li> </ul> <h2>7.5.3 (2025-10-04)</h2> <ul> <li><a href="https://redirect.github.com/IdentityPython/pysaml2/issues/973">#973</a> Fix prepare_for_negotiated_authenticate to avoid double signing redirect requests</li> </ul> <h2>7.5.2 (2025-02-10)</h2> <ul> <li>Include the XSD of the XML Encryption Syntax and Processing Version 1.1 to the schema validator</li> </ul> <h2>7.5.1 (2025-02-10)</h2> <ul> <li>deps: restrict pyOpenSSL up to v24.2.1 until it is replaced</li> <li>deps: update dependencies for the lockfile and examples</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="9cf71f7f9e"><code>9cf71f7</code></a> Release version 7.5.4</li> <li><a href="c3ec7199d1"><code>c3ec719</code></a> Refactor _shelve_compat</li> <li><a href="1d6ea6024e"><code>1d6ea60</code></a> Remove import of deprecated cgi module</li> <li><a href="c45eb9df82"><code>c45eb9d</code></a> Replace deprecated datetime.utcnow() by datetime.now(timezone.utc)</li> <li><a href="178f6d12b4"><code>178f6d1</code></a> Remove unneeded dependencies</li> <li><a href="1f0a25a5cf"><code>1f0a25a</code></a> remove importlib_metadata import</li> <li><a href="099f716ae7"><code>099f716</code></a> remove importlib_resources imports</li> <li><a href="3fa11ee15d"><code>3fa11ee</code></a> spelling updates.</li> <li><a href="4b7887f59a"><code>4b7887f</code></a> update link.</li> <li><a href="bc8d3b4ecc"><code>bc8d3b4</code></a> update link.</li> <li>Additional commits viewable in <a href="https://github.com/IdentityPython/pysaml2/compare/v7.5.0...v7.5.4">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Devon Hudson <devonhudson@librem.one>	2025-12-05 22:11:58 +00:00
Devon Hudson	e8710e7c5e	Don't include debug logs in Clock unless explicitly enabled (#19278) ... Fixes #19276 This log with stack traces results in a ton of noise in the logs and is confusing to users since it looks like it's an error in the logs. This PR removes the stack trace from the log. This can be re-enabled on demand if it is deemed necessary in the future. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-12-04 23:49:24 +00:00
Devon Hudson	d688daf41c	Fix bug where Duration was logged incorrectly (#19267) ... ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-12-02 20:08:32 +00:00
Eric Eastwood	83023ce1e0	Be able to shutdown homeserver that failed to start (#19232) ... For example, a homeserver can fail to `start` if the port is already in use or the port number is invalid (not 0-65535) Fix https://github.com/element-hq/synapse/issues/19189 Follow-up to https://github.com/element-hq/synapse/pull/18828 ### Background As part of Element's plan to support a light form of vhosting (virtual host) (multiple instances of Synapse in the same Python process) (c.f [Synapse Pro for small hosts](https://docs.element.io/latest/element-server-suite-pro/synapse-pro-for-small-hosts/overview/)), we're currently diving into the details and implications of running multiple instances of Synapse in the same Python process. "Clean tenant deprovisioning" tracked internally by https://github.com/element-hq/synapse-small-hosts/issues/50	2025-12-02 11:28:46 -06:00
Eric Eastwood	39316672da	Be able to shutdown homeserver that hasn't setup (#19187) ... For example, a homeserver can fail to `setup` if it fails to connect to the database. Fix https://github.com/element-hq/synapse/issues/19188 Follow-up to https://github.com/element-hq/synapse/pull/18828 ### Background As part of Element's plan to support a light form of vhosting (virtual host) (multiple instances of Synapse in the same Python process) (c.f Synapse Pro for small hosts), we're currently diving into the details and implications of running multiple instances of Synapse in the same Python process. "Clean tenant deprovisioning" tracked internally by https://github.com/element-hq/synapse-small-hosts/issues/50	2025-12-02 10:58:06 -06:00
Eric Eastwood	88310fe7ed	Add log to determine whether clients are using /messages as expected (#19226) ... Spawning from wanting some better homeserver logs to debug https://github.com/element-hq/synapse/issues/19153. We can check whether we are returning a `/messages` response with an `end` pagination token and then check to see whether the client is making another `/messages` request with that token. Although clients should also have similar logs and debugging capabilities to determine this info as well. This just makes it easier for us when someone creates an issue claiming backend issue and we can ask them for homeserver logs.	2025-12-01 17:10:22 -06:00
Devon Hudson	08e1b63b30	Fix v12 rooms when using frozen dicts (#19235) ... Fix #19233 Synapse fails to handle events in v12 rooms when the server is run with the `{use_frozen_dicts: True}` config. This PR fixes the issue, and adds tests which cover room creation, joining, and joining over federation, with both frozen and not frozen config settings, by extending the existing `test_send_join` federation tests. This approach to testing was chosen as it is a simple way to get high level integration style test coverage, without going through all our existing tests and trying to retroactively add in coverage when using frozen dicts. This should provide an easy place for future room versions to extend the suite of tests and reduce the chance of introducing subtle bugs like this in the future. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-12-01 18:26:43 +00:00
Andre Klärner	c20dd888bd	Document how merging config files works - see #11203 (#19243) ... --------- Signed-off-by: Andre Klärner <kandre@ak-online.be> Co-authored-by: Olivier 'reivilibre <olivier@librepush.net>	2025-12-01 16:05:07 +00:00
Devon Hudson	119f02e3b3	Return 400 when canonical_alias content invalid (#19240) ... Fixes #19198 Returns HTTP 400 when `alias` or `alt_alias` inside of `m.room.canonical_alias` `content` are not of type string. Previously this resulted in HTTP 500 errors as Synapse assumed they were strings and would raise an exception when it tried to treat them as such if they actually weren't. With the changes implemented: <img width="800" height="616" alt="Screenshot from 2025-11-28 16-48-06" src="https://github.com/user-attachments/assets/1333a4b3-7b4f-435f-bbff-f48870bc4d96" /> <img width="800" height="316" alt="Screenshot from 2025-11-28 16-47-42" src="https://github.com/user-attachments/assets/5928abf8-88a2-4bd9-9420-9a1f743f66f5" /> ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-12-01 15:24:26 +00:00
Erik Johnston	1bddd25a85	Port Clock functions to use Duration class (#19229) ... This changes the arguments in clock functions to be `Duration` and converts call sites and constants into `Duration`. There are still some more functions around that should be converted (e.g. `timeout_deferred`), but we leave that to another PR. We also changes `.as_secs()` to return a float, as the rounding broke things subtly. The only reason to keep it (its the same as `timedelta.total_seconds()`) is for symmetry with `as_millis()`. Follows on from https://github.com/element-hq/synapse/pull/19223	2025-12-01 13:55:06 +00:00
Erik Johnston	d143276bda	Fix rust source check when using .egg-info (#19251) ... We have checks to try and catch the case where Synapse is being run from a source directory, but the compiled Rust code is out-of-date. This commonly happens when Synapse is updated without running `poetry install` (or equivalent). These checks did not correctly handle `.egg-info` installs, and so were not run. Currently, the `.egg-info` directory is created automatically by poetry (due to using setuptools to build Rust).	2025-12-01 13:34:21 +00:00
Andrew Morgan	034c5e625c	Move call invite filtering logic to filter_events_for_client (#17782)	2025-11-28 17:41:56 +00:00
Andrew Morgan	566670c363	Move RestartDelayedEventServlet to workers (#19207)	2025-11-27 16:44:17 +00:00
Andrew Morgan	703464c1f7	Fix case where get_partial_current_state_deltas could return >100 rows (#18960)	2025-11-26 17:17:04 +00:00
Richard van der Hoff	c928347779	Implement MSC4380: Invite blocking (#19203) ... MSC4380 aims to be a simplified implementation of MSC4155; the hope is that we can get it specced and rolled out rapidly, so that we can resolve the fact that `matrix.org` has enabled MSC4155. The implementation leans heavily on what's already there for MSC4155. It has its own `experimental_features` flag. If both MSC4155 and MSC4380 are enabled, and a user has both configurations set, then we prioritise the MSC4380 one. Contributed wearing my 🎩 Spec Core Team hat.	2025-11-26 16:12:14 +00:00
Erik Johnston	b74c29f694	Move towards a dedicated Duration class (#19223) ... We have various constants to try and avoid mistyping of durations, e.g. `ONE_HOUR_SECONDS * MILLISECONDS_PER_SECOND`, however this can get a little verbose and doesn't help with typing. Instead, let's move towards a dedicated `Duration` class (basically a [`timedelta`](https://docs.python.org/3/library/datetime.html#timedelta-objects) with helper methods). This PR introduces the new types and converts all usages of the existing constants with it. Future PRs may work to move the clock methods to also use it (e.g. `call_later` and `looping_call`). Reviewable commit-by-commit.	2025-11-26 10:56:59 +00:00
Andrew Morgan	ba65d8c351	Put MSC2666 endpoint behind an experimental flag (#19219)	2025-11-25 18:03:33 +00:00
Erik Johnston	db975ea10d	Expire sliding sync connections (#19211) ... We add some logic to expire sliding sync connections if they get old or if there is too much pending data to return. The values of the constants are picked fairly arbitrarily, these are currently: 1. More than 100 rooms with pending events if the connection hasn't been used in over an hour 2. The connection hasn't been used for over a week Reviewable commit-by-commit --------- Co-authored-by: Eric Eastwood <erice@element.io>	2025-11-25 10:20:47 +00:00
Devon Hudson	bc42899008	Allow subpaths in MAS endpoints (#19186) ... Fixes #19184 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-11-18 18:45:33 +00:00
Devon Hudson	322481cd2d	Run background updates on all databases (#19181) ... Fixes #18322 This PR changes synapse startup to run background updates against all databases instead of just the "main" database. This follows [what the admin api does](https://github.com/element-hq/synapse/blob/develop/synapse/rest/admin/background_updates.py#L71-L77). See the above linked issue for further details of why this is beneficial. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-11-17 15:32:21 +00:00
Eric Eastwood	edc0de9fa0	Fix bad deferred logcontext handling (#19180) ... These aren't really something personally experienced but I just went around the codebase looking for all of the Deferred `.callback`, `.errback`, and `.cancel` and wrapped them with `PreserveLoggingContext()` Spawning from wanting to solve https://github.com/element-hq/synapse/issues/19165 but unconfirmed whether this has any effect. To explain the fix, see the [*Deferred callbacks*](3b59ac3b69/docs/log_contexts.md (deferred-callbacks)) section of our logcontext docs for more info (specifically using solution 2).	2025-11-14 11:21:15 -06:00
Eric Eastwood	408a05ebbc	Fix potential lost logcontext when PerDestinationQueue.shutdown(...) (#19178) ... Spawning from looking at the logs in https://github.com/element-hq/synapse/issues/19165#issuecomment-3527452941 which mention the `federation_transaction_transmission_loop`. I don't think it's the source of the lost logcontext that person in the issue is experiencing because this only applies when you try to `shutdown` the homeserver. Problem code introduced in https://github.com/element-hq/synapse/pull/18828 To explain the fix, see the [*Deferred callbacks*](3b59ac3b69/docs/log_contexts.md (deferred-callbacks)) section of our logcontext docs for more info (specifically using solution 2).	2025-11-13 15:17:15 -06:00
Devon Hudson	5d545d1626	Remove support for PostgreSQL 13 (#19170) ... This PR removes support for PostgreSQL 13 as it is deprecated (tomorrow). Uses https://github.com/element-hq/synapse/pull/18034 as a reference of where to look, and also found a few other places that needed updating. I didn't see anywhere in Complement that needs updating. There is a companion Sytest PR deprecating psql13 over there: https://github.com/matrix-org/sytest/pull/1418 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))	2025-11-13 19:38:59 +00:00
Andrew Ferrazzutti	9e23cded8f	MSC4140: Remove auth from delayed event management endpoints (#19152) ... As per recent proposals in MSC4140, remove authentication for restarting/cancelling/sending a delayed event, and give each of those actions its own endpoint. (The original consolidated endpoint is still supported for backwards compatibility.) ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Half-Shot <will@half-shot.uk>	2025-11-13 18:56:17 +00:00
Eric Eastwood	4494cc0694	Point out which event caused the exception when checking MSC4293 redactions (#19169) ... Spawning from looking at the stack trace in https://github.com/element-hq/synapse/issues/19128 which has no useful information on how to dig in deeper.	2025-11-13 12:08:22 -06:00
Eric Eastwood	47d24bd234	Add debug logs to track Clock callbacks (#19173) ... Spawning from wanting to find the source of a `Clock.call_later()` callback, https://github.com/element-hq/synapse/issues/19165	2025-11-13 12:07:23 -06:00
Eric Eastwood	b9dda0ff22	Restore printing sentinel for log_record.request (#19172) ... This was unintentionally changed in https://github.com/element-hq/synapse/pull/19068. There is no real bug here. Without this PR, we just printed an empty string for the `sentinel` logcontext whereas the prior art behavior was to print `sentinel` which this PR restores. Found while staring at the logs in https://github.com/element-hq/synapse/issues/19165 ### Reproduction strategy 1. Configure Synapse with [logging](df802882bb/docs/sample_log_config.yaml) 1. Start Synapse: `poetry run synapse_homeserver --config-path homeserver.yaml` 1. Notice the `asyncio - 64 - DEBUG - - Using selector: EpollSelector` log line (notice empty string `- -`) 1. With this PR, the log line will be `asyncio - 64 - DEBUG - sentinel - Using selector: EpollSelector` (notice `sentinel`)	2025-11-13 09:57:56 -06:00
reivilibre	938c97416d	Add a shortcut return when there are no events to purge. (#19093) ... Fixes: #13417 --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>	2025-11-13 14:26:37 +00:00
Jason Volk	e67ba69f20	Provide same servers list in s2s alias results as c2s. (#18970) ... Signed-off-by: Jason Volk <jason@zemos.net> Co-authored-by: dasha_uwu <dasha@linuxping.win>	2025-11-13 11:12:03 +00:00
Erik Johnston	df802882bb	Further reduce cardinality of metrics on event persister (#19168) ... Follow on from #19133 to only track a subset of event types.	2025-11-12 16:40:38 +00:00
Erik Johnston	3ba3c7fe7d	Reduce cardinality of metrics on event persister (#19133) ... This reduces the size of metrics by ~80%. Responding with the metrics takes significant amounts of time.	2025-11-12 13:41:58 +00:00