From 0a6a5cb73eb1000af25d2de9bc394ae2bc960377 Mon Sep 17 00:00:00 2001 From: 0ko <0ko@noreply.codeberg.org> Date: Wed, 31 Dec 2025 03:13:05 +0100 Subject: [PATCH] chore: remove obsolete code from button-legacy.css (#10581) Fixes #10580 Remove obsolete styles so that people do not trip over them. I went through the codebase with `rg` and made sure that the only elements which had potential to use such mix of classes were doing so accidentally, and removed all the unused code. ### A small fix for Forgejo themes Ref https://codeberg.org/forgejo/forgejo/pulls/10581#issuecomment-9245399. The missing variable was used in one place outside of devtest. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10581 Reviewed-by: Michael Kriese Reviewed-by: Beowulf Reviewed-by: Gusted Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org> --- templates/devtest/gitea-ui.tmpl | 2 - templates/repo/issue/filters.tmpl | 2 +- .../notification_subscriptions.tmpl | 2 +- web_src/css/modules/button-legacy.css | 41 ------------------- web_src/css/repo.css | 4 +- web_src/css/themes/theme-gitea-dark.css | 1 - web_src/css/themes/theme-gitea-light.css | 1 - 7 files changed, 4 insertions(+), 49 deletions(-) diff --git a/templates/devtest/gitea-ui.tmpl b/templates/devtest/gitea-ui.tmpl index 1c88333520..6daf6d74c7 100644 --- a/templates/devtest/gitea-ui.tmpl +++ b/templates/devtest/gitea-ui.tmpl @@ -48,8 +48,6 @@

  • Supported but not recommended:

    Do not use if there is no strong requirement. Do not use grey/black buttons, they don't work well with dark theme.

    - - diff --git a/templates/repo/issue/filters.tmpl b/templates/repo/issue/filters.tmpl index 06e7c1aa6c..d69a8439ba 100644 --- a/templates/repo/issue/filters.tmpl +++ b/templates/repo/issue/filters.tmpl @@ -15,7 +15,7 @@ {{end}}
    -
    +
    {{if .PageIsMilestones}} {{template "repo/issue/milestone/filter_list" .}} {{else}} diff --git a/templates/user/notification/notification_subscriptions.tmpl b/templates/user/notification/notification_subscriptions.tmpl index 9e4685b849..49c1baad92 100644 --- a/templates/user/notification/notification_subscriptions.tmpl +++ b/templates/user/notification/notification_subscriptions.tmpl @@ -31,7 +31,7 @@
    -
    +
    diff --git a/web_src/css/modules/button-legacy.css b/web_src/css/modules/button-legacy.css index 469a309a11..8683d9ed58 100644 --- a/web_src/css/modules/button-legacy.css +++ b/web_src/css/modules/button-legacy.css @@ -185,47 +185,6 @@ It needs some tricks to tweak the left/right borders with active state */ border-color: var(--color-primary-active); } -/* secondary */ - -.ui.secondary.labels .label, -.ui.ui.ui.secondary.label, -.ui.secondary.button, -.ui.secondary.buttons .button, -.ui.secondary.button:focus, -.ui.secondary.buttons .button:focus { - background: var(--color-secondary-button); -} - -.ui.secondary.button:hover, -.ui.secondary.buttons .button:hover { - background: var(--color-secondary-hover); -} - -.ui.secondary.button:active, -.ui.secondary.buttons .button:active { - background: var(--color-secondary-active); -} - -.ui.basic.secondary.buttons .button, -.ui.basic.secondary.button { - color: var(--color-secondary-button); - border-color: var(--color-secondary-button); -} - -.ui.basic.secondary.buttons .button:hover, -.ui.basic.secondary.button:hover, -.ui.basic.secondary.button:focus, -.ui.basic.secondary.buttons .button:focus { - color: var(--color-secondary-hover); - border-color: var(--color-secondary-hover); -} - -.ui.basic.secondary.buttons .button:active, -.ui.basic.secondary.button:active { - color: var(--color-secondary-active); - border-color: var(--color-secondary-active); -} - /* red */ .ui.red.labels .label, diff --git a/web_src/css/repo.css b/web_src/css/repo.css index d51b340e0f..4234c07bf0 100644 --- a/web_src/css/repo.css +++ b/web_src/css/repo.css @@ -80,7 +80,7 @@ overflow-x: auto; } -.repository .filter.menu.labels .label-filter .menu .info { +.repository .filter.menu .label-filter .menu .info { display: inline-block; padding: 0.5rem 0; font-size: 12px; @@ -91,7 +91,7 @@ text-align: left; } -.repository .filter.menu.labels .label-filter .menu .info code { +.repository .filter.menu .label-filter .menu .info code { border: 1px solid var(--color-secondary); border-radius: var(--border-radius); padding: 1px 2px; diff --git a/web_src/css/themes/theme-gitea-dark.css b/web_src/css/themes/theme-gitea-dark.css index 58e3a21f9a..0fbe7ba4ec 100644 --- a/web_src/css/themes/theme-gitea-dark.css +++ b/web_src/css/themes/theme-gitea-dark.css @@ -58,7 +58,6 @@ --color-secondary-alpha-70: #3b444ab3; --color-secondary-alpha-80: #3b444acc; --color-secondary-alpha-90: #3b444ae1; - --color-secondary-button: var(--color-secondary-dark-4); --color-secondary-hover: var(--color-secondary-dark-3); --color-secondary-active: var(--color-secondary-dark-2); /* console colors - used for actions console and console files */ diff --git a/web_src/css/themes/theme-gitea-light.css b/web_src/css/themes/theme-gitea-light.css index f889cac568..c9ca759472 100644 --- a/web_src/css/themes/theme-gitea-light.css +++ b/web_src/css/themes/theme-gitea-light.css @@ -58,7 +58,6 @@ --color-secondary-alpha-70: #d0d7deb3; --color-secondary-alpha-80: #d0d7decc; --color-secondary-alpha-90: #d0d7dee1; - --color-secondary-button: var(--color-secondary-dark-4); --color-secondary-hover: var(--color-secondary-dark-5); --color-secondary-active: var(--color-secondary-dark-6); /* console colors - used for actions console and console files */