bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER

Currently, we disallow BRDGSIFVLANSET when IFBRF_VLANFILTER is disabled.
There's no particular reason to do this, and it causes some undesirable
behaviour such as not being able to remove the tagged config on a member
after disabling vlanfilter on the bridge.

Remove the restriction so BRDGSIFVLANSET is always accepted.

PR:	292019
MFC after:	1 week
Reviewed by:	zlei, p.mousavizadeh_protonmail.com
Sponsored by:	https://www.patreon.com/bsdivy
Differential Revision:	https://reviews.freebsd.org/D54435
This commit is contained in:
Lexi Winter 2026-01-03 01:13:22 +00:00
parent 3e6e4e4a0d
commit 2e92aeede8

View file

@ -1990,9 +1990,6 @@ bridge_ioctl_sifvlanset(struct bridge_softc *sc, void *arg)
struct ifbif_vlan_req *req = arg;
struct bridge_iflist *bif;
if ((sc->sc_flags & IFBRF_VLANFILTER) == 0)
return (EXTERROR(EINVAL, "VLAN filtering not enabled"));
bif = bridge_lookup_member(sc, req->bv_ifname);
if (bif == NULL)
return (EXTERROR(ENOENT, "Interface is not a bridge member"));