freebsd-src/lib/libifconfig/libifconfig_bridge.c
Lexi Winter ce06c1921e bridge: Add a vlanfilter bridge option
vlanfilter was originally a per-interface flag to allow more flexible
configurations where some interfaces had VLAN filtering enabled and
some didn't.  In practice, this just makes the configuration more
confusing without any real benefit, so remove it, and make vlanfilter
a bridge flag instead.

Add a new bridge option "defuntagged", which sets the automatically
assigned PVID for new members.  If set to 0 (the default) then no
PVID is assigned, which matches the current behaviour.

While here, add some more atf_checks to the bridge VLAN tests to
make debugging easier.

Differential Revision:	https://reviews.freebsd.org/D51600
2025-08-03 23:55:10 +01:00

174 lines
5 KiB
C

/*
* Copyright (c) 2020, Ryan Moeller <freqlabs@FreeBSD.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/param.h>
#include <sys/ioctl.h>
#include <net/ethernet.h>
#include <net/if.h>
#include <net/if_bridgevar.h>
#include <net/route.h>
#include <assert.h>
#include <errno.h>
#include <stdbool.h>
#include <stdlib.h>
#include <string.h>
#include "libifconfig.h"
#include "libifconfig_internal.h"
/* Internal structure used for allocations and frees */
struct _ifconfig_bridge_status {
struct ifconfig_bridge_status inner; /* wrapped bridge status */
struct ifbropreq params; /* operational parameters */
};
static int
ifconfig_bridge_ioctlwrap(ifconfig_handle_t *h, const char *name,
unsigned long cmd, void *arg, size_t arglen, bool set)
{
struct ifdrv ifd = { 0 };
unsigned long req = set ? SIOCSDRVSPEC : SIOCGDRVSPEC;
strlcpy(ifd.ifd_name, name, sizeof(ifd.ifd_name));
ifd.ifd_cmd = cmd;
ifd.ifd_data = arg;
ifd.ifd_len = arglen;
return (ifconfig_ioctlwrap(h, AF_LOCAL, req, &ifd));
}
int
ifconfig_bridge_get_bridge_status(ifconfig_handle_t *h,
const char *name, struct ifconfig_bridge_status **bridgep)
{
struct ifbifconf members;
struct ifbrparam cache_param;
struct _ifconfig_bridge_status *bridge = NULL;
char *buf = NULL;
members.ifbic_buf = NULL;
*bridgep = NULL;
bridge = calloc(1, sizeof(struct _ifconfig_bridge_status));
if (bridge == NULL) {
h->error.errtype = OTHER;
h->error.errcode = ENOMEM;
goto err;
}
bridge->inner.params = &bridge->params;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGCACHE,
&cache_param, sizeof(cache_param), false) != 0) {
goto err;
}
bridge->inner.cache_size = cache_param.ifbrp_csize;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGTO,
&cache_param, sizeof(cache_param), false) != 0) {
goto err;
}
bridge->inner.cache_lifetime = cache_param.ifbrp_ctime;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGFLAGS,
&cache_param, sizeof(cache_param), false) != 0) {
goto err;
}
bridge->inner.flags = cache_param.ifbrp_flags;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGDEFPVID,
&cache_param, sizeof(cache_param), false) != 0) {
goto err;
}
bridge->inner.defpvid = cache_param.ifbrp_defpvid;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGPARAM,
&bridge->params, sizeof(bridge->params), false) != 0) {
goto err;
}
for (size_t len = 8192;
(buf = realloc(members.ifbic_buf, len)) != NULL;
len *= 2) {
members.ifbic_buf = buf;
members.ifbic_len = len;
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGIFS,
&members, sizeof(members), false) != 0) {
goto err;
}
if ((members.ifbic_len + sizeof(*members.ifbic_req)) < len)
break;
}
if (buf == NULL) {
h->error.errtype = OTHER;
h->error.errcode = ENOMEM;
goto err;
}
bridge->inner.members = members.ifbic_req;
bridge->inner.members_count =
members.ifbic_len / sizeof(*members.ifbic_req);
bridge->inner.member_vlans = calloc(bridge->inner.members_count,
sizeof(ifbvlan_set_t));
if (bridge->inner.member_vlans == NULL) {
h->error.errtype = OTHER;
h->error.errcode = ENOMEM;
goto err;
}
for (size_t i = 0; i < bridge->inner.members_count; ++i) {
struct ifbif_vlan_req vreq;
memset(&vreq, 0, sizeof(vreq));
strlcpy(vreq.bv_ifname, bridge->inner.members[i].ifbr_ifsname,
sizeof(vreq.bv_ifname));
if (ifconfig_bridge_ioctlwrap(h, name, BRDGGIFVLANSET, &vreq,
sizeof(vreq), false) != 0) {
goto err;
}
__BIT_COPY(BRVLAN_SETSIZE, &vreq.bv_set,
&bridge->inner.member_vlans[i]);
}
*bridgep = &bridge->inner;
return (0);
err:
free(members.ifbic_buf);
if (bridge)
free(bridge->inner.member_vlans);
free(bridge);
return (-1);
}
void
ifconfig_bridge_free_bridge_status(struct ifconfig_bridge_status *bridge)
{
if (bridge != NULL) {
free(bridge->members);
free(bridge);
}
}