kgess-mirror/oneuptime
1
0
Fork 0
mirror of https://github.com/OneUptime/oneuptime.git synced 2026-01-11 19:56:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

feat: Refactor navigation in delete components to utilize RouteUtil for parameterized routing

Browse source
This commit is contained in:
Nawaz Dhandala 2026-01-09 14:34:23 +00:00
parent 491e6341a9
commit 1c6d243457
No known key found for this signature in database
GPG key ID: 96C5DCA24769DBCA
12 changed files with 69 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Common/Server/Infrastructure/Postgres/SchemaMigrations/1767966850199-RenameServiceCatalogToService.ts
View file

@ -61,9 +61,7 @@ export class RenameServiceCatalogToService1767966850199
*/
// Rename main ServiceCatalog table to Service
await queryRunner.query(
`ALTER TABLE "ServiceCatalog" RENAME TO "Service"`,
);
await queryRunner.query(`ALTER TABLE "ServiceCatalog" RENAME TO "Service"`);
// Rename ServiceCatalogMonitor to ServiceMonitor
await queryRunner.query(
@ -131,9 +129,7 @@ export class RenameServiceCatalogToService1767966850199
`ALTER TABLE "ServiceMonitor" RENAME TO "ServiceCatalogMonitor"`,
);
await queryRunner.query(
`ALTER TABLE "Service" RENAME TO "ServiceCatalog"`,
);
await queryRunner.query(`ALTER TABLE "Service" RENAME TO "ServiceCatalog"`);
// Step 2: Rename columns back to original names
await queryRunner.query(

6
Dashboard/src/Components/Exceptions/ExceptionExplorer.tsx
View file

@ -503,7 +503,11 @@ const ExceptionExplorer: FunctionComponent<ComponentProps> = (
modelType={TelemetryException}
modelId={props.telemetryExceptionId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.EXCEPTIONS] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.EXCEPTIONS] as Route,
),
);
}}
/>
</div>

9
Dashboard/src/Pages/CodeRepository/View/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../Utils/PageMap";
import RouteMap from "../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../Utils/RouteMap";
import PageComponentProps from "../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const CodeRepositoryDelete: FunctionComponent<
modelType={CodeRepository}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.CODE_REPOSITORY] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.CODE_REPOSITORY] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/Dashboards/View/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../Utils/PageMap";
import RouteMap from "../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../Utils/RouteMap";
import PageComponentProps from "../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const DashboardDelete: FunctionComponent<
modelType={Dashboard}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.DASHBOARDS] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.DASHBOARDS] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/OnCallDuty/OnCallDutyPolicy/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../Utils/PageMap";
import RouteMap from "../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../Utils/RouteMap";
import PageComponentProps from "../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const OnCallPolicyDelete: FunctionComponent<
modelType={OnCallDutyPolicy}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.ON_CALL_DUTY] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.ON_CALL_DUTY] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/OnCallDuty/OnCallDutySchedule/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../Utils/PageMap";
import RouteMap from "../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../Utils/RouteMap";
import PageComponentProps from "../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const OnCallScheduleDelete: FunctionComponent<
modelType={OnCallDutySchedule}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.ON_CALL_DUTY] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.ON_CALL_DUTY] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

3
Dashboard/src/Pages/Service/Services.tsx
View file

@ -59,8 +59,7 @@ const ServicesPage: FunctionComponent<
labels: true,
},
title: "Labels",
description:
"Labels help you categorize and organize your services.",
description: "Labels help you categorize and organize your services.",
fieldType: FormFieldSchemaType.MultiSelectDropdown,
required: false,
placeholder: "Labels",

9
Dashboard/src/Pages/Settings/AIAgentView.tsx
View file

@ -3,7 +3,7 @@ import UserElement from "../../Components/User/User";
import ProjectUtil from "Common/UI/Utils/Project";
import PageMap from "../../Utils/PageMap";
import ProjectUser from "../../Utils/ProjectUser";
import RouteMap from "../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../Utils/RouteMap";
import PageComponentProps from "../PageComponentProps";
import Route from "Common/Types/API/Route";
import BadDataException from "Common/Types/Exception/BadDataException";
@ -453,7 +453,12 @@ const AIAgentView: FunctionComponent<PageComponentProps> = (
modelType={AIAgent}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.SETTINGS_AI_AGENTS] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.SETTINGS_AI_AGENTS] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/Settings/ProbeView.tsx
View file

@ -3,7 +3,7 @@ import UserElement from "../../Components/User/User";
import ProjectUtil from "Common/UI/Utils/Project";
import PageMap from "../../Utils/PageMap";
import ProjectUser from "../../Utils/ProjectUser";
import RouteMap from "../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../Utils/RouteMap";
import PageComponentProps from "../PageComponentProps";
import Route from "Common/Types/API/Route";
import BadDataException from "Common/Types/Exception/BadDataException";
@ -433,7 +433,12 @@ const TeamView: FunctionComponent<PageComponentProps> = (
modelType={Probe}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.SETTINGS_PROBES] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.SETTINGS_PROBES] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

6
Dashboard/src/Pages/Settings/TeamView.tsx
View file

@ -629,7 +629,11 @@ const TeamView: FunctionComponent<PageComponentProps> = (
modelType={Team}
modelId={Navigation.getLastParamAsObjectID()}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.SETTINGS_TEAMS] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.SETTINGS_TEAMS] as Route,
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/StatusPages/View/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../Utils/PageMap";
import RouteMap from "../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../Utils/RouteMap";
import PageComponentProps from "../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const StatusPageDelete: FunctionComponent<
modelType={StatusPage}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.STATUS_PAGES] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.STATUS_PAGES] as Route,
{ modelId },
),
);
}}
/>
</Fragment>

9
Dashboard/src/Pages/Telemetry/Services/View/Delete.tsx
View file

@ -1,5 +1,5 @@
import PageMap from "../../../../Utils/PageMap";
import RouteMap from "../../../../Utils/RouteMap";
import RouteMap, { RouteUtil } from "../../../../Utils/RouteMap";
import PageComponentProps from "../../../PageComponentProps";
import Route from "Common/Types/API/Route";
import ObjectID from "Common/Types/ObjectID";
@ -19,7 +19,12 @@ const ServiceDelete: FunctionComponent<
modelType={TelemetryService}
modelId={modelId}
onDeleteSuccess={() => {
Navigation.navigate(RouteMap[PageMap.TELEMETRY_SERVICES] as Route);
Navigation.navigate(
RouteUtil.populateRouteParams(
RouteMap[PageMap.TELEMETRY_SERVICES] as Route,
{ modelId },
),
);
}}
/>
</Fragment>