fix redfish inspect system product name

The intention of this code is to read the system product name which is
stored in the model field per the Redfish spec and not in the name field
which will always store the name of the object we are working with. This
results in the value always being 'System'.

Closes-Bug: 2136233
Change-Id: I375fbe27253d7965e458be7b147d5b72cffa4e89
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

ironic/drivers/modules/redfish/inspect.py

@@ -153,8 +153,8 @@ class RedfishInspect(base.InspectInterface):
             inventory['pci_devices'] = pcie_devices
 
         system_vendor = {}
-        if system.name:
-            system_vendor['product_name'] = str(system.name)
+        if system.model:
+            system_vendor['product_name'] = str(system.model)
 
         if system.serial_number:
             system_vendor['serial_number'] = str(system.serial_number)

ironic/tests/unit/drivers/modules/redfish/test_inspect.py

@@ -218,7 +218,7 @@ class RedfishInspectTestCase(db_base.DbTestCase):
                                                       self.context)
 
         system_vendor = inventory['inventory']['system_vendor']
-        expected_product_name = 'System1'
+        expected_product_name = 'PowerEdge R1234'
         expected_serial_number = '123456'
         expected_manufacturer = 'Sushy Emulator'
         expected_sku = 'DELL123456'

releasenotes/notes/redfish-inspect-product-name-bd537f417d35b254.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    When using the redfish inspection driver, the system product name in the
+    data was always the value 'System' due to the wrong field being read.
+    See `bug 2136233 <https://bugs.launchpad.net/ironic/+bug/2136233>`_