Commit graph

509 commits

Author SHA1 Message Date
Aeva Black
9f75bbd938 Add my new address to .mailmap
This commit updates the mailmap file and changes my alias
in a few places within old comments.

Change-Id: Ica0e184109d794b8e129d567b5606d7fe84ff384
2020-04-13 07:29:37 -07:00
Ilya Etingof
c428a51ddc Fix gunicorn name on Py3@CentOS7 in devstack
On non-Ubuntu systems, when gunicorn is pip-installed on Py3,
command name remains `gunicorn` rather than `gunicorn3`.

Change-Id: I5b8cb974d900bd3bdf7ec08adb3e6586494a26a2
2020-04-07 18:57:22 +02:00
Zuul
20fdad0884 Merge "Default IRONIC_RAMDISK_TYPE to dib" 2020-03-31 12:34:37 +00:00
Zuul
05ea0d1842 Merge "Signal agent token is required" 2020-03-28 08:54:27 +00:00
Riccardo Pittau
bc654814f8 Default IRONIC_RAMDISK_TYPE to dib
We limit the use of tinyipa to the most intensive jobs:
standalone
grenade
multinode

Also leaving ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa
running for now as there could be an issue with the
ironic-python-agent

Story: 2007356
Task: 38908

Change-Id: Ieb1ea1dbeeb68b15e9281d154358336006b62214
2020-03-26 09:45:00 +01:00
Julia Kreger
deca07de3c Signal agent token is required
The agent needs to be able to understand
if the agent token is supported and is a
mandatory feature of the ironic deployment
as that can alter some of the behavior of
the agent itself.

Also adds documentation on the subject for
administrators.

Story: 2007025
Task: 37821

Change-Id: Ic635e0ed6d378d6a34a4a82e66ca647eee33bc26
2020-03-20 17:26:51 +00:00
michaeltchapman
bee537a4a3 Support centos 7 rootwrap data directory
Centos 7 pip seems to install the rootwrap filters to /usr/local
despite its data path resolving to /usr.

Change-Id: If2496e9c143400dcce017a79cf179768951eb137
2020-03-19 11:11:06 +11:00
Zuul
9dcfa6c388 Merge "Drop rootwrap.d/ironic-lib.filters file" 2020-03-17 12:59:01 +00:00
Thomas Bechtold
bfb41571b2 Drop rootwrap.d/ironic-lib.filters file
The file is included in the ironic-lib module and there is no
difference (beside some comments) in the files.

For packagers, this solves the problem that ironic-lib and ironic are
currently not installable together given that both packages contain
the same file.

Story: 2006604
Task: 36772
Depends-On: https://review.opendev.org/684771
Change-Id: I2d800d4c2616ccd9d9f12a2fe59e259def15dc6b
2020-03-16 23:05:36 +01:00
Kaifeng Wang
34d34b3a9d Finalize removal of ipxe_enabled option
Remove the dynamically registered ipxe_enabled option and say goodbye.
Further extracts common bits to the PXEBaseMixin, tuning tests here and
there.

Story: 2007003
Task: 37779

Change-Id: I7c1b2a984d45bd63b4e95b62ce02960924c2ce17
2020-02-21 14:25:01 +08:00
Zuul
ab8212b23e Merge "Fix bash comparisons for grenade multinode switch" 2020-02-12 13:23:28 +00:00
Dmitry Tantsur
25db126071 Actually use ironic-python-agent from source in source builds
Currently the DIB element unconditionally clones it.

Change-Id: I096940d6e0801200276f952ae5afc05402f9e473
2020-02-10 15:48:35 +01:00
Julia Kreger
b44eb6f34b Fix bash comparisons for grenade multinode switch
It seems, however variables are getting set with grenade
in native zuulv3 jobs, the environment variables are no
longer comparing as they once did in standard bash jobs.

What worked previously, was [ "$VAR" == 'value' ], however
when comparing the newer grenade node jobs we see things like
[[ subnode != \s\u\b\n\o\d\e ]] returning true when single
quotes are used.

Comparison in the logs to where double quotes were used for
functionally the same comparision, revealed proper processing
and execution as expected.

As such, changing our single quotes to double quotes where
applicable.

For the record, I also quickly checked codesearch and it looks
like we were the only project to use single quotes for this
comparison.

Change-Id: I2db2e870e2c5f32aa061af025ee7ce12c4f7c049
2020-02-04 14:09:44 -08:00
Zuul
a37898d704 Merge "devstack: install bindep for diskimage-builder" 2020-01-09 16:44:30 +00:00
Zuul
9669948732 Merge "devstack: switch to using CentOS 8 DIB ramdisks by default" 2020-01-09 12:32:24 +00:00
Dmitry Tantsur
ca355adb70 devstack: install bindep for diskimage-builder
Building images may not work without it, and it's only automatically
installed in the CI if diskimage-builder is in required-projects.

Change-Id: Ic0198bc02b1aa9a960aa08c224598d7e1e809012
2020-01-08 19:18:23 +01:00
Zuul
b39ca69061 Merge "Explicitly use ipxe as boot interface for iPXE testing" 2020-01-07 16:09:04 +00:00
Zuul
7783981e2b Merge "Add logic to determine Ironic node is HW or not into configure_ironic_dirs" 2020-01-07 13:51:45 +00:00
Dmitry Tantsur
f110afc4f9 devstack: switch to using CentOS 8 DIB ramdisks by default
The CentOS 7 ones no longer work because of the Python 3 transition.

Change-Id: I68fc6f87879a53198810ad64f9570c41ccf8ce7f
2020-01-03 16:28:54 +01:00
Kaifeng Wang
697048b47e Explicitly use ipxe as boot interface for iPXE testing
We are about to drop pxe + ipxe_enabled=True combination for iPXE
testing, so let's make it explicit in the jobs.

Change-Id: I0e99e6336aa47857c06ba2f6869e66580159a9be
Story: 2007003
Task: 37779
2020-01-02 14:00:42 +08:00
ankit
2d5a8cf967 Fixes issue with checking whether ISO is passed
This patch fixes the issue if IRONIC_BUILD_DEPLOY_RAMDISK
is set to false and IRONIC_DEPLOY_ISO is passed then it
will not throw the error.

Change-Id: Ic95f6e75d51db5cb60098bb131698cf44e772366
Story: 2007002
Task: 37777
2019-12-09 07:50:52 +00:00
Iury Gregory Melo Ferreira
b869b46c63 Drop python 2.7 support and testing
OpenStack is dropping the py2.7 support in ussuri cycle.

Ironic is ready with python 3 and ok to drop the
python 2.7 support.

Complete discussion & schedule can be found in
- http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
- https://etherpad.openstack.org/p/drop-python2-support

Ussuri Communtiy-wide goal - https://review.opendev.org/#/c/691178/

Change-Id: I3cc36d79ffabf31607d503dada9e7512c639647c
2019-11-22 14:06:45 +01:00
Zuul
306aaccca6 Merge "Ensure text-only console in devstack" 2019-11-20 13:22:37 +00:00
Zuul
0ee99def0b Merge "Ensure isolinux.bin is present and configured in devstack" 2019-11-20 05:06:40 +00:00
Ilya Etingof
c7a42bdbff Ensure text-only console in devstack
Apparently, now days system boot chain is tempted to display
fancy things on the console. While enjoyable, in non-text mode
libvirt guest console can't make it to the log file.

This change tries to ensure pure text mode kernel console in
PXE and Redfish booting by disabling any graphics in the VM
and in guest kernel.

Note that it's not only kernel that can control display mode,
but EFI boot loader as well.

For getting on VM's text console in devstack one could use
`virsh console --devname serial1 node-0` or just add `<graphics>`
section to `virsh edit node-0` XML.

Change-Id: I14f78bcef4173eeaf659ee589ca938e2698e3505
2019-11-19 16:36:21 +01:00
Riccardo Pittau
f8c4f7b1e4 Fix variable name in cleanup_baremetal_basic_ops func
Correcting the variable name for virtual bmc instances during
devstack unstack ironic cleanup phase.

Change-Id: Ie35a45e0806f9da07d121900831c6a61e33d23e5
2019-11-13 18:06:01 +01:00
Ilya Etingof
1e25f60fd3 Ensure isolinux.bin is present and configured in devstack
When devstack boots a node over virtual media in BIOS boot mode,
`isolinux.bin` boot loader needs to be present for grilling hybrid
ISO images.

This patch makes devstack pulling necessary packages and configure
ironic accordingly.

Change-Id: I2f4e582aa05fc54610a4c43695124219714368c2
2019-11-11 15:53:49 +01:00
Dmitry Tantsur
a2472c1518 CI: limit rescue testing to only two jobs
This feature is time-consuming and prone to race conditions. This
changes switches it off by default, leaving it on in two jobs:
the one running on Nova and the standalone one.

Change-Id: I7c50cb12065da05dad4ece0918883748ee4617e0
2019-10-22 17:20:51 +02:00
Zuul
6a054eb692 Merge "Fix EFIBOOT image upload in devstack" 2019-10-18 10:20:42 +00:00
Iury Gregory Melo Ferreira
8dc0a96414 Setup ipa-builder before building ramdisk
Extracted the logic to setup the ironic-python-agent-builder
to a separate function that is called before building ithe ramdisk,
this is to avoid errors when deploying locally see [1]

[1] http://paste.openstack.org/show/783890/

Change-Id: I8ce4ac2f1b59fc682feea3a183c7d0e3d075f30d
2019-10-15 15:39:20 +02:00
Ilya Etingof
e339c30a57 Fix EFIBOOT image upload in devstack
On restacking devstack, if EFIBOOT image file already exists on the
file system, ironic devstack plugin would not re-upload it to Glance
failing further ISO image build for Redfish virtual media boot.

This change makes Glance upload unconditional.

Also in this patch: fixed UEFI firmware configuration in Redfish
emulator configuration file produced by devstack plugin.

Change-Id: Idf1d2ccc54e1bf60a1df249d0e3fb08fbb98a51c
2019-10-14 19:29:10 +02:00
Zuul
7c9bbb61ba Merge "Fix devstack installation failure" 2019-10-04 18:36:13 +00:00
Zuul
b6211b255d Merge "Use correct function to stop service" 2019-10-04 12:41:04 +00:00
Iury Gregory Melo Ferreira
a5297da941 Use correct function to stop service
DevStack provides a function to stop services[1],
the `stop_redfish` function wasn't using this one.

[1] https://opendev.org/openstack/devstack/src/branch/master/functions-common#L2252

Change-Id: I9e7be1d3ade0d2743893de6565e5dc427d5e1f71
2019-10-03 11:15:49 +02:00
Christopher Dearborn
dab47f9ce1 Fix devstack installation failure
This patch fixes an exception that occurs when deploying devstack with
the DIB ramdisk.

Change-Id: Ia4499291b6dff1e8c8b6cd1ac544a1e3787ccf83
Story: #2006645
Task: #36881
2019-10-01 19:29:40 -04:00
Dmitry Tantsur
78e763c61b Add a CI job with a DIB-built ramdisk
Also updates the devstack plugin to support pre-built DIB images
and removes the explicit mention of dhcp-all-interfaces element,
which is already a dependency of ironic-python-agent-ramdisk.

Change-Id: I564016528e80c738d6004c47f8df502a7748b311
2019-09-30 20:14:19 +02:00
Dmitry Tantsur
de85baaa95 Run DIB with tracing enabled and increase the DHCP timeout
We seem to be hitting occasional failures to DHCP in time, although
DHCP itself seems working. Try increasing timeout from 30 to 60.

Also enable tracing when building the image, so that this sort of
issues is a bit easier to debug without unpacking the image.

Change-Id: If3f00ba39daf72739802c46c5c6c64cfbb6ab0ae
2019-09-25 16:50:58 +02:00
Zuul
0450c4f2fd Merge "Allow retrying PXE boot if it takes too long" 2019-09-23 12:58:26 +00:00
Zuul
bd835b671b Merge "Devstack: Fix iPXE apache log location bug" 2019-09-21 18:24:58 +00:00
Dmitry Tantsur
3f3508f0d0 devstack: wait for conductor to start and register itself
Change-Id: I5e026754ed5aa6fb0ffaff086cda0bfa0aca2211
2019-09-20 16:15:55 +02:00
Dmitry Tantsur
b2834e6661 Allow retrying PXE boot if it takes too long
PXE is inherently unreliable and sometimes times out without an
obvious reason. It happens particularly often in resource constrained
environments, such as the CI. This change allows an operator to
set a timeout, after which the boot is retried again.

The _add_node_filters call had to be refactored to avoid hitting
the complexity limit.

Change-Id: I34a11f52e8e98e5b64f2d21f7190468a9e4b030d
Story: #2005167
Task: #29901
2019-09-20 15:24:28 +02:00
Zuul
a2b05332f2 Merge "CI: move libvirt images to /opt for standalone and multinode jobs" 2019-09-20 03:06:29 +00:00
Michael Davies
c9349c194a Devstack: Fix iPXE apache log location bug
Make the apache log directory configurable, based upon which
operating system this is running on. This is needed as ironic
devstack is broken on Red Hat-related operating systems as a
result.

Change-Id: I22e04d886219755a38b1e895c2c6f9d756535cab
Story: 2006577
Task: 36689
2019-09-20 06:16:30 +09:30
Zuul
0ea2aa07cb Merge "Remove support for CoreOS images" 2019-09-18 07:59:29 +00:00
Dmitry Tantsur
625c71d48d CI: move libvirt images to /opt for standalone and multinode jobs
Moves the volume pool from / to /opt for the standalone and multinode
jobs, since on smaller nodes /opt is mounted from a larger ephemeral disk.

Change-Id: Idb4e235fd40ecd9829c3ad8a9dd1224f1c29a12e
2019-09-16 18:57:22 +02:00
Ruby Loo
7c5839064f Remove cisco references and add release note
The cisco hardware types and interfaces were removed in
Ie12eaf7572ce4d66f6a68025b7fe2d294185ce28. This removes the
last few references to them, and adds a release note about
their removal.

Change-Id: I6d11dda0132d999b2dbf6bbd47cac55336e1d079
Story: 2005033
Task: 29522
2019-09-13 19:58:36 +00:00
Dmitry Tantsur
cbeb9cc79f Remove support for CoreOS images
Also remove the remaining elilo test template instead of updating it.

Change-Id: I79a49837f4d0dd6a432895e8997158a51feb99c3
2019-09-09 15:59:34 +02:00
Zuul
3c9f2a834e Merge "Adding file uri support for ipa image location" 2019-08-29 01:14:45 +00:00
Michael Davies
b560bade60 Adding file uri support for ipa image location
Allow ipa kernel/disk images to be specified via file:// designator
so they can be locally hosted in addition to being available over
http.

Change-Id: If3e32f30a7df27113721e15bff9ecaae16bfe8d4
2019-08-27 15:33:29 +09:30
Julia Kreger
dd02a21633 Adjust placement query for reserved nodes
Minor timing changes in an attempt to:
a) Make the logs less noisy
b) Wait a little bit longer for placement
   records to be updated.

Change-Id: I4f64a2f5ab2d1696f244f083d5dc387c75cc1175
2019-08-26 16:56:50 -04:00