Commit graph

1891 commits

Author SHA1 Message Date
Zuul
00194b4e20 Merge "Do not require port argument when updating floating IP" 2018-07-24 00:53:33 +00:00
Monty Taylor
3dd9613b21 Pass volume snapshot size to volume create
When creating a volume from a snapshot, the size parameter is required
and type is checked. Since we have to pass something and it needs to be
a valid data type (None is not acceptable) grab the size from the
snapshot object and pass it.

Change-Id: Ie23e3d23828919234e40336b5c65b22e140d337c
2018-07-23 13:38:35 -05:00
Zuul
ee35409069 Merge "Slow down and retry aggregate create/delete to lessen race" 2018-07-13 17:57:25 +00:00
Pavlo Shchelokovskyy
b9fab849f7 Skip calls to glance and nova when got no servers
save (potentially many) HTTP calls to Glance API for image list
and a call to Nova API for flavor list when the server list
actually returned no servers.

Change-Id: I93a56138c50b82fb4dce67a2f788107f71c5f423
Story: #2002039
Task: #19681
2018-07-09 15:07:24 +03:00
Dean Troyer
26c268a910 Slow down and retry aggregate create/delete to lessen race
Change-Id: I676894c1bfd3156313d88e6457250b9ff226118b
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2018-07-06 13:15:59 -05:00
Zuul
c5a0c3ad5d Merge "Retry floating IP tests" 2018-07-06 14:04:38 +00:00
Dean Troyer
83a9db280d Retry floating IP tests
test_server_attach_detach_floating_ip() has a test for server
add/remove floating IP that seems to be racy, add a retry loop
to let neutron and nova do their thing before calling it bad.

Change-Id: I999a0d7dae1706d746053bafb7ab4e3b791d0042
2018-07-06 10:24:16 +00:00
Zuul
e4b8c31cd3 Merge "Adding api_version to FakeApp" 2018-06-29 18:17:47 +00:00
Zuul
7d7a429685 Merge "Add ability to filter image list by tag" 2018-06-29 02:47:41 +00:00
Zuul
7b8873dc6b Merge "Compute: Add description support for flavor" 2018-06-28 17:26:03 +00:00
Adam Harwell
9edbab8c90 Add ability to filter image list by tag
Change-Id: I2e222d3e69df9d8d7cd472663caaee31bedd848c
2018-06-28 16:17:14 +00:00
Zuul
4bde9af892 Merge "Network: Add tag support for security group" 2018-06-25 15:16:05 +00:00
Zuul
5d2bd2a738 Merge "compute: limit the service's force down command above 2.10" 2018-06-24 13:28:44 +00:00
Zuul
4ffb3a905a Merge "Fix subnet host_routes error" 2018-06-24 05:03:04 +00:00
Telles Nobrega
412ee7f1d8 Adding api_version to FakeApp
In order to use app.api_version['<some_service>'] we need to have the
api_version on FakeApp otherwise the test will fail.

Patch that will benefit from this:
https://review.openstack.org/#/c/572536/

Change-Id: Ibb3c548daf2a62b6c4aefb5e257372dd5c56521e
2018-06-24 03:47:23 +00:00
Sami MAKKI
08dbd154e5 Fix the role implies list command.
The code was calling an unexisting function which never existed.
The module refers now to the correct `InferenceRuleManager`. It
also allows the compatibility with the future python-keystoneclient
in which the compatibility method will be removed from the
RoleManager.

Change-Id: I08f785dc9e840da2e16915683eecfe49189c44b3
2018-06-24 02:17:02 +02:00
Dean Troyer
15a079faa6 Fix volume type functional tests
Convert functional VolumeTypeTests to not use class methods for setup.

Depends-On: https://review.openstack.org/577147
Change-Id: I855583ad1a50bf5f5046acdb85e977ab9e3c45d2
2018-06-22 10:05:28 -05:00
tianhui
4a68ba625c Compute: Add description support for flavor
Co-Authored-By: Fan Zhang <zh.f@outlook.com>
Change-Id: I0dc80bee3ba6ff4ec8cc3fc113b6de7807e0bf2a
Story: 2002196
Task: 21681
2018-06-20 09:11:05 +00:00
He Jie Xu
956eabe967 compute: limit the service's force down command above 2.10
The force down action is added in Microversion 2.11, we should limit
the command only can be executed when the microversion is above 2.10.

Change-Id: I0a87e02e71ff025d30181fc17ebcd003a590f110
2018-06-19 12:59:03 +00:00
Huang Cheng
5bb5585aa9 Fix subnet host_routes error
When updating subnet with "no-host-route" option, set host_routes to an empty list as neutron_lib.api.validators expected.

Change-Id: I6fe039793d813758429c7a104fd40172b4f8122b
Closes-Bug: #1747101
2018-06-14 13:03:46 +00:00
yanpuqing
402c9a21b3 Do not require port argument when updating floating IP
When setting floating ip other properties, port argument is
force to use.
The patch modifies the command, when setting floating ip other
properties, like tags, no need port argument.

Change-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de
Story: 1751431
Task: 13865
2018-06-13 23:05:30 -04:00
Dongcan Ye
aaed4b315f Network: Add tag support for security group
Change-Id: Icccb23429913724c6a8bd15d4737672b47a5f13a
Closes-Bug: #1750983
2018-06-14 01:01:58 +00:00
Zuul
9766eb23e7 Merge "Fix server show for microversion 2.47" 2018-06-12 04:44:38 +00:00
Zuul
4c4c0ae2da Merge "Optimize _prep_server_detail to avoid redundant find_resource" 2018-06-12 01:14:16 +00:00
Zuul
0226eb7fd9 Merge "Add system role functionality" 2018-06-09 17:11:26 +00:00
Matt Riedemann
da7572a5ff Fix server show for microversion 2.47
Compute API version 2.47 embeds the server's internal
flavor in the response. The original flavor id is not
preserved since it could have changed if the flavor
was deleted and re-created after the server was created,
which was the dreaded Horizon "Edit Flavor" issue.
So the flavor dict in the server response is a dict of
information about the flavor representing the server
"right now" excluding the id. The original flavor name
is shown though along with the ram/disk/vcpu etc
information.

The server list command has a similar issue which
will be fixed in a follow up change.

Change-Id: I1a92999758006d02567c542b6be8902a049899cc
Task: 13864
Story: 1751104
2018-06-08 15:52:31 -04:00
Matt Riedemann
752a2db332 Optimize _prep_server_detail to avoid redundant find_resource
When showing a server or doing a rebuild, we already have
the latest version of the server so _prep_server_detail
getting the server again is an unnecessary performance hit.

ShowServer is pretty obvious here. For RebuildServer, the
compute API actually refreshes the server before returning
it in the response, so the client already gets the latest
when the rebuild call returns.

The only other usage of _prep_server_detail that does require
a refresh is CreateServer since the POST /servers response is
a minimal version of the server object.

This adds a new refresh kwarg, backward compatible by default,
to _prep_server_detail but changes ShowServer and RebuildServer
to no longer refresh.

Change-Id: Ib1c9c424ed1cafc2dfd8be90af8de8a774bdfbf0
2018-06-08 11:46:29 -04:00
Harald Jensas
e8c731547d Allow setting network-segment on subnet update
To enable the possibility to migrate a non-routed network to a
routed network allow updating the segment_id of a subnet.

Change-Id: I3ebae2ff28d5d4e5373ebd1f52194f8c52071b88
Partial-Bug: bug/1692490
Depends-On: I1aee29dfb59e9769ec0f1cb1f5d2933bc5dc0dc5
2018-06-06 11:56:39 +02:00
Lance Bragstad
8bfa180430 Add system role functionality
This commit adds the necessary bits to expose system role
assignments to openstackclient via python-keystoneclient.

bp system-scope

Depends-On: Iecbcbf020a15f2bec777334c648d4477f89f3b2c
Change-Id: I261e84700b51e8715eaebdc3f8f8bc46b68542c2
2018-06-04 20:09:14 +00:00
Sławek Kapłoński
9b6d02d5f9 Make max_burst_kbps option as optional for bw limit QoS rule
Attribute max_burst_kbps of QoS bandwidth limit rule in Neutron's
is optional in API so it should be also optional on client's side.

Change-Id: Ie085b73fa885ff12f9ac080666cf3ca6a09b632a
Related-Bug:#1770622
Task: 19658
Story: 2002017
2018-05-25 12:54:41 -07:00
Monty Taylor
f7e4d31820
Update command test for volume.v3
The default cinder version in devstack changed to v3 in
https://review.openstack.org/#/c/566747/which breaks this
test. Change the test to test what's going to happen.

Change-Id: Iff4d8b47812a86d21bf5dbdddbd642b9d63ff8fe
2018-05-18 07:12:04 -05:00
Zuul
06263bd585 Merge "Fix limits show command without Nova and Cinder" 2018-04-23 09:49:35 +00:00
Zuul
b59de7b849 Merge "Network: Add tag support for floating ip" 2018-04-23 08:12:25 +00:00
Dongcan Ye
b776f7099a Fix functional job failed
After Neutron patch I3c93818002c2d7753454547231ba08544b6fa1c0 merged,
the default value of segment description is an empty string.

This patch will determine whether the Neuron shim extension
standard-attr-segment supported.

Change-Id: I68a3c018f03e5bb53bd637844ac9d7742a765db0
2018-04-20 01:47:17 +00:00
Dongcan Ye
09a0916dae Network: Add tag support for floating ip
Change-Id: I7a500a4ff6cec2442b4050df26c0b017d9f71903
Closes-Bug: #1750985
2018-04-17 15:52:52 +00:00
Sean McGinnis
d601415259 Clean up W503 and E402 pep8 errors
pycodestyle 2.40 and later enforce these rules that were not previously
enforced. Rather than just skipping them, this cleans up the trivial
instances of these violations.

This does also include some other updates that were not triggering errors
in an attempt to keep some of the style consistent.

Change-Id: Id7c0a6b8f1f835e69d844b000e3ed751852ada63
Closes-bug: #1762803
2018-04-15 12:23:06 +09:00
Jude Cross
24b06ef273 Fix limits show command without Nova and Cinder
This patch implements an endpoint lookup when showing limits. This
addresses the issue when showing limits without both Nova and Cinder
and will display limits if one is missing.

Change-Id: I2214b281e0206f8fe117aae52de2bf4c4e2c6525
Closes-bug: #1707960
2018-04-03 00:47:00 -07:00
Zuul
972a345014 Merge "Add support to list image members" 2018-04-02 19:05:15 +00:00
Zuul
5ed81c5a77 Merge "Add --image-property parameter in 'server create'" 2018-03-31 17:20:27 +00:00
Zuul
f21b0a073f Merge "Fix additional output encoding issues" 2018-03-29 04:23:16 +00:00
Chen Hanxiao
447d5d9e34 Add --image-property parameter in 'server create'
add --image-property option, just like --image-with of novaclient did.

Change-Id: Ic1a8976559255529a8785b1b301a0307812433cb
Signed-off-by: Chen Hanxiao <chenhx@certusnet.com.cn>
2018-03-28 16:03:45 +08:00
Zuul
29d4dd7a61 Merge "neutron: add --mtu for create/set network" 2018-03-23 14:31:39 +00:00
Zuul
350b545201 Merge "Remove duplicated network attributes" 2018-03-23 14:10:42 +00:00
Mohammed Naser
79577681d8 Add support to list image members
The OpenStack client presently has support to add or remove members
from an image, but no way to list image members.  This patch addreses
this issue.

Change-Id: Ie85c5de23c6beb21fd6b4c04c83ddf2a116606ef
2018-03-21 08:56:08 -04:00
Dean Troyer
6df58b6366 Fix additional output encoding issues
This is a followup to https://review.openstack.org/#/c/541609/ that
changes most outstanding direct uses of sys.stdout to use the encoded
stdout set up by cliff.

Change-Id: I07cfc418385fc787d3b7d3c32d39676cf81bb91f
2018-03-20 15:40:23 -05:00
Emilien Macchi
18563b4132 neutron: add --mtu for create/set network
Support Neutron network mtu configuration with a new argument, --mtu
that allows CLI users to set MTU for Neutron networks.

Change-Id: I93d23581c7e8c84eaf9bb3b293360036f60f456b
2018-03-15 13:50:59 +00:00
Zuul
e78c9bc00d Merge "Add CRUD support for application credentials" 2018-03-14 02:16:35 +00:00
Dongcan Ye
f6688986fc Remove duplicated network attributes
Change-Id: If77609d06e7d80c8da5111b8a30036b58fbfa187
2018-03-14 01:33:21 +00:00
Zuul
0dfb690e21 Merge "Cleanup error messages on failure" 2018-03-14 00:37:30 +00:00
Dean Troyer
53e7aab7ed Re-implement novaclient bits removed in 10.0
a)

/os-floating-ips was removed in Compute API 2.36 and from novaclient's
Python API in 10.0

Add to api.computev2:
floating_ip_add()
floating_ip_remove()

Convert add floating IP command to nova-net/neutron split:
"server add floating ip"
"server remove floating ip"

b)

/os-hosts was removed in Compute API 2.43 and from novaclient's
Python API in 10.0.

Add to api.computev2:
host_list()
host_set()
host_show()

Convert host commands to use intenal api:
"host list"
"host set"
"host show"

c)

The introduction of the Network-style commands into the server group
broke cliff's autoprogram directive as it executes the get_parser() methods
without fully initializing the Command object.

NOTE: This is really three reviews squashed to get through the gate in one pass.

Depends-on: Id6de87211d6c4ea8fd14aa9203d8d5b17e9e2f04
Change-Id: I5116086f9a9e4b2b31a744bf8f4558c79f0bfe59
2018-03-13 09:10:45 -05:00