Commit graph

200 commits

Author SHA1 Message Date
Huanxuan Ao
3ef7e29dd0 Implement "volume transfer request show/accept" command
Add "volume transfer request show" and
"volume transfer accept" commands in
volume v1 and v2. Also add the unit tests,
docs, release note and functional tests

Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>

Change-Id: I5787fc486b3401307125caa316f517b9c96a95a5
2016-09-22 17:11:53 +08:00
Jenkins
69c4f605ec Merge "Fix "volume unset" command pass normally when nothing specified" 2016-09-22 02:35:13 +00:00
Huanxuan Ao
bba5c9047f Fix "volume unset" command pass normally when nothing specified
When nothing specified in "volume unset" command, there
will be an error message says that the "--properties"
option is required, it is unusual behaviour, this patch
fix it and also add unit test for it.
Also, this patch add unit test for "volume show" command
by the way.

Change-Id: I5b5d587670acf0af4262b8521292455bf9f60fe5
Partial-bug: #1588588
2016-09-21 15:47:55 +08:00
Shu Yingya
b30a7b795f replace metavar "volume-id" with "volume" to avoid ambiguity
The help message of command "openstack volume show" accepts either
volume-name or volume-ID. But the metavar is "volume-id" as below.
It can easily lead to misunderstanding.

usage: openstack volume show [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>]
                             [--noindent][--prefix PREFIX]
                             <volume-id>

Change-Id: I57576ea23868b1026cf268be69b39e98a53aafd4
2016-09-21 12:33:01 +08:00
Jenkins
276675f352 Merge "Support mark volume as bootable in volume set" 2016-09-14 18:48:28 +00:00
Jenkins
3b0e648041 Merge "Multi REST API calls error handling of "volume unset" command" 2016-09-14 17:02:04 +00:00
Jenkins
c381193214 Merge "Do not show "os-volume-type-access:is_public" property of volume type" 2016-09-14 16:55:03 +00:00
qtang
6a914d0056 Support mark volume as bootable in volume set
Add --bootable | --non-bootable option in volume set
to mark or unmark volume as bootable.

Change-Id: Ifa6c2dd1642202f55b6d50e3b8614d3513d488f6
Closes-Bug:#1535704
2016-09-14 16:35:49 +00:00
Tang Chen
1a78c76250 Trivial: Rename ListTransferRequests to ListTransferRequest
The class name should use plural.

Change-Id: I2de2489ff9aa60c2d1bf12743cbd41f2091739ca
2016-09-12 10:44:54 +08:00
Huanxuan Ao
d2273ecea5 Implement "volume transfer request delete" command
Add "volume transfer request delete" command in
volume v1 and v2. Also add the unit tests, docs,
release note and functional tests

Change-Id: Ic3d375bc8df3312fac53c1800d75f48376b8c91c
Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-11 14:08:27 +08:00
Huanxuan Ao
6f4acc45c6 Implement "volume transfer request create" command
Add "volume transfer request create" command in
volume v1 and v2. Also add the unit tests, docs,
release note and functional tests

Change-Id: If362df1acf214efdf6ba129cd917d33eb54e1030
Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-11 14:08:19 +08:00
Jenkins
30afdb9684 Merge "Error handling of multi REST API calls for "snapshot set" command" 2016-09-11 05:50:40 +00:00
Jenkins
cc5379b55c Merge "Add "--limit" and "--marker" options to "volume list" command" 2016-09-11 05:22:58 +00:00
Huanxuan Ao
10e665a148 Error handling of multi REST API calls for "snapshot set" command
Support multi REST API calls error handling for
"snapshot set" command follow the rule in
doc/source/command-errors.rst. Also add a unit
test for testing the error handling

Change-Id: I0c6214271bc54a25b051c0a62438c3344c8b51d7
2016-09-11 11:41:05 +08:00
Huanxuan Ao
6986a32e1c Add "--limit" and "--marker" options to "volume list" command
Add ``--limit`` option to ``volume list`` command in volume v1,
add ``--limit`` and ``--marker`` options to ``volume list``
command in volume v2.

Change-Id: I327a252aa83ed84166da99cf6aa80334e0e6dd44
Partial-Bug: #1612484
2016-09-11 11:23:25 +08:00
Huanxuan Ao
af81a92c37 Support error handling for delete commands in volume v1
Some delete commands in volume v1 support multi delete
but do not support error handling, this patch fixes them,
and this patch also refactor (or add new) unit tests for
some delete commands in volume v1.

Change-Id: Ia8177698f8733cfe75ea0ff00eee8fdc0820f62e
2016-09-11 11:08:14 +08:00
Huanxuan Ao
cb6c11b0a8 Multi REST API calls error handling of "volume unset" command
Support multi REST API calls error handling for "volume unset"
command follow the rule in doc/source/command-errors.rst.
Also add a unit test for testing the error handling

Change-Id: I2de7a7bd5a7a5e39817ed5cf6952abf4afba75e4
2016-09-11 11:00:09 +08:00
Huanxuan Ao
5231ade27c Do not show "os-volume-type-access:is_public" property of volume type
"os-volume-type-access:is_public" property is the
same as "is_public" property in volume type object.
So stop showing "os-volume-type-access:is_public"
property and leave "is_public" property only.

Change-Id: Ic78a9ee69b0ab356edff18cdb4c46fc24b495d2b
Closes-Bug: #1620922
2016-09-07 16:40:54 +08:00
Huanxuan Ao
81431d24a9 Add "volume service set" command
Add "volume service set" command in volume v1 and v2
(v1 is the same as v2) to disable or enable volume service.

Change-Id: Ibb2db7e93b24cb2e0d2a7c28b6fd8bcc851b8d2f
Closes-Bug: #1613597
2016-08-17 10:42:28 +08:00
Huanxuan Ao
39c5eb9e3f Rename backup commands in volume v1 and v2
Backup commands are used only in volume service now,
but "backup" is too generic, users may not know the
commands are used for volume from the commands name.
By seeing the command name, users can only see the
"backup" but do not know which object the backup
commands work for. It may confuse users. I think
rename "backup" to "volume backup" can depict resource
relation and will be helpful for users to know the
commands clearly.

So add new commands ``volume backup create/delete/
list/show/restore`` to replace the old commands
``backup create/delete/list/show/restore``. And also
deprecate old commands.

Change-Id: I4f844d9bc48573eb4d17288ce6b8a90cea00d16a
Implements: bp backup-snapshot-renamed-for-volume-resource
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-08-11 09:32:10 +08:00
Jenkins
80fd9b2bd4 Merge "Support multi REST API calls error handling for "volume set" command" 2016-08-06 12:02:29 +00:00
Jenkins
3692a2a91a Merge "osc-lib: shell" 2016-08-06 08:01:52 +00:00
Huanxuan Ao
3202fefc65 Support multi REST API calls error handling for "volume set" command
Support the error handling follow the rule in
doc/source/command-errors.rst
Also add a unit test for testing the error handling

Change-Id: I98064f4b8c1dc17eb3874f7b25c827a568463c0f
2016-08-06 09:15:21 +08:00
Dean Troyer
6a15f90dae osc-lib: shell
Convert to using ClientManager and OpenStackShell from osc-lib.
* Change all internal uses of ClientManager private attributes that are
  now public in osc-lib's ClientManager.  Leave back-compat copies in
  place in OSC's clientManager so we don't break plugins.
* Put some work-arounds in place for changes in osc-lib that we need until
  a new release makes it through the g-r and u-c change process.
* Add a test for Unicode decoding of argv in shell.main() to parallel
  the one in osc-lib.

Change-Id: I85289740d4ca081f2aca8c9b40ec422ad25d302c
2016-08-05 13:48:55 -05:00
Xi Yang
20ae54045c Add support of setting volume's state
OSC does not support to set volume's state, this
patch is going to add this functionality.

Closes-Bug:#1535213
Change-Id: I5bc1c7e81b8ba61c37f4bfd209fc86c5857fb050
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
2016-08-03 12:19:16 +08:00
wuyuting
954c28dfa2 Add support for deleting volumes with associated snapshots
OSC doesn't support deleting volumes with associated snapshots.
This patch provides support for deleting volumes with associated
snapshots by adding an optional argument.

Change-Id: I7e74f251574993ff13a38e508fd2f9debeda8d0a
Closes-Bug: #1589332
Co-Authored-By: Rui Chen <chenrui.momo@gmail.com>
2016-07-27 11:30:52 +08:00
Jenkins
6da7a127af Merge "Add options to "volume type list" command" 2016-07-26 10:53:40 +00:00
Jenkins
566b8566c0 Merge "Standardize import format" 2016-07-26 07:22:27 +00:00
Huanxuan Ao
e31408d2a4 Add options to "volume type list" command
Add "--public" and "--private" options to
"volume type command" in volumev2 (v2 only)
to list optional volume types

Change-Id: I8605990d62116c10d89ce192c14e550657dabee5
Closes-Bug: #1597198
2016-07-23 11:26:49 +08:00
Huanxuan Ao
61b9d9fe2d Add "--marker" and "--limit" options to "snapshot list"
Add "--marker" and "--limit" options to
"snapshot list" command in volume v2 (v2 only).

Change-Id: Ib60840b9b83dfe5e599e4037e8ec308844a9448b
Closes-Bug: #1605475
2016-07-23 10:41:28 +08:00
shizhihui
f996138a0d Standardize import format
According to the rule in
http://docs.openstack.org/developer/hacking/#imports
I modify some irregular import format.

Change-Id: Ibf29ccaf3ddec4a956334cc3368ebee7a66e282c
2016-07-22 19:24:02 +08:00
Sheel Rana
5e8957ef7f Show project access for volume type
OSC does not support to show project access details for
private volume types. This patch will provide support
for showing project access details for private volume types.

Closes-Bug:#1554891

Implements: bp cinder-command-support

Change-Id: I218fb07a6e69033e9f8570748eee1df8df9d6fdc
2016-07-20 16:54:58 +08:00
Jenkins
6ce53fed83 Merge "Support error handling for delete commands in volumev2" 2016-07-18 22:41:07 +00:00
Jenkins
099c3bbd82 Merge "Add "--project" option to "volume type create" command" 2016-07-18 19:38:02 +00:00
Huanxuan Ao
9b51127ecc Support error handling for delete commands in volumev2
Some delete conmmands in volumev2 did not support
error handling, this patch add them and also add
the unit tests for bulk deletion

Change-Id: I56ade6f9c7396c78fb989547476c4d94ccd76eae
2016-07-14 17:49:26 +08:00
Jenkins
1620964cfe Merge "Remove useless dest of option in volume v1&v2" 2016-07-14 04:06:56 +00:00
Huanxuan Ao
e310682235 Add "--project" option to "volume type create" command
Add "--project" and "--project-domain" options to
"volume type create" command. We can use these options
to add the type access to a given project when we
create the volume type.

Change-Id: I483a6b61dae137682c3d1f7527531b40e508ba92
Closes-Bug: #1602169
2016-07-12 19:23:47 +08:00
Paul Bourke
34812655a5 Add "--incremental" option to "backup create" command in volume v2
Cinder V2 API supports creating volume backup with "--incremental"
option. However, OSC doesn't support this argument. So this patch adds
the "--incremental" option to allow users to create incremental style
backups.

Change-Id: Iefac5f1a6c9ef006ad9c22d4250ae6df50504781
Closes-Bug: 1600196
2016-07-11 13:29:59 -04:00
Huanxuan Ao
cd189860e5 Remove useless dest of option in volume v1&v2
some "dest" argument is useless because they are
the same as the option name. So remove them.

Change-Id: Idd37e8816cf8b0833c94a5e741fdfe56602551f9
2016-07-11 10:10:59 +08:00
Jenkins
e0b63e64c1 Merge "Add "--property" option to "snapshot create" command in volumev2" 2016-07-06 15:31:39 +00:00
Huanxuan Ao
f5aef9ac36 Add '--force' option to 'backup delete' command in volumev2
Add '--force' option to 'backup delete' command in
volumev2 (v2 only) to allow delete in state other
than error or available.

Change-Id: I661ea0d465db227e374cbacdde0206fa1a6dd3d5
Closes-Bug: #1597188
2016-07-06 20:51:01 +08:00
Huanxuan Ao
3222ffc157 Add "--property" option to "snapshot create" command in volumev2
Add "--property" option to "snapshot create" command
in volumev2 (v2 only) to support adding properties to
a new snapshot.

Change-Id: Ie0e90c9ccc2ac89b3b7b0ac89751fd864aada9a4
Closes-Bug: #1597192
2016-07-06 20:46:31 +08:00
Huanxuan Ao
8aa00894ef Remove useless dest of option in "snapshot create" command
The option is '--force' and the default argument is
'force', so the 'dest=force' is useless and unnecessary.
This patch remove it.

Change-Id: If8fd5270e4e36b5361127f4a91bdf347f29341c2
2016-07-04 16:46:28 +08:00
Huanxuan Ao
6364df4cbd Add "--snapshot" option to "backup create" command in volumev2
Add "--snapshot" option to "backup create" command to support
backing up a snapshot.

Change-Id: Ibecbf1902599875f422d372d529835f73211d3ec
Closes-Bug: #1597184
2016-07-01 10:06:10 +08:00
Jenkins
9422f8bdea Merge "Add "--force" option to "volume qos delete" command" 2016-06-28 18:26:03 +00:00
Jenkins
30bcaebd00 Merge "Make set/unset command in volume pass normally when nothing specified" 2016-06-28 08:38:51 +00:00
Jenkins
161d37b42a Merge "Add "--force" option to "backup create" command in volumev2" 2016-06-28 08:35:31 +00:00
Huanxuan Ao
4e46c04f92 Add "--force" option to "volume qos delete" command
Add ``--force`` option to ``volume qos delete`` command in volume
v1 and v2 to allow users to delete in-use QoS specification(s).

Change-Id: I46036e5f55ced8b8a1be54c521f2a5c242b89160
Closes-Bug: #1596821
2016-06-28 08:12:40 +00:00
Huanxuan Ao
1d85a3f089 Change "ID only" to "name or ID" for backup commands
Tested "find_resulce()" can find a backup by name or ID.
But some help messages and doc were "ID only", this patch
modify them.

Change-Id: I22dcc3a0b40f2bafabb6d26498158e2468037312
2016-06-27 20:00:50 +08:00
Huanxuan Ao
fc719f998c Add "--force" option to "backup create" command in volumev2
Cinder V2 API supports creating volume backup with "--force"
option. However, OSC doesn't support this argument. So this
patch add the "--force" option to allow users to back up a
in-use volume.

Change-Id: I326f8d6172b2830da4cf1317348af50142cc5490
Closes-Bug: #1596443
2016-06-27 16:59:51 +08:00