Commit graph

2270 commits

Author SHA1 Message Date
judy-yu
151c161a5e Avoid duplicated project_id when show network
Project_id appear twice when show network. This
patch check and not append if it already has one.

Change-Id: I4400239f454522101b639a0412050dd60eb6a612
Closes-Bug: #1636123
Partially-Implements: blueprint duplicated-project-id
2016-10-24 17:16:48 +08:00
Yan Xing'an
65a08d6af6 Improve a network testcase
Fix a typo networ to network, and add assertEqual lines.

Change-Id: I13c0c775c1d5f7a8f579d387cd9bea1bdd74aebc
2016-10-20 21:56:00 -07:00
Yan Xing'an
e6fb658606 Correct help string of the subnet pool list options
Correct help string of subnet pool list options, from
"subnets" to "subnet pools".

Change-Id: Ic6dd6649f411748cd0c6e6b08f0451c8a0fa220f
Partially-Implements: blueprint network-commands-options
2016-10-20 06:25:58 -07:00
Carl Baldwin
d373d76d1d Reset allocation pools to [] instead of ''
the sdk expects subnet allocation pools to be reset to an empty array,
not an empty string.

Currently this results in an error message:

  "Invalid input for allocation_pools. Reason: Invalid data format
   for IP pool"

Change-Id: I7cc84b9c8e4abdbd2c91e5d591ad31f0849c1a83
Closes-Bug: #1634672
2016-10-19 00:27:49 +00:00
Jenkins
5e3ec1b42f Merge "Fix --shared/block-migration options in server migrate command" 2016-10-17 21:43:15 +00:00
Jenkins
ed8e918519 Merge "properly format error messages for volume resizing" 2016-10-17 20:41:32 +00:00
Jenkins
528f7a76d0 Merge "Add necessary info to Floating IP list" 2016-10-17 20:30:30 +00:00
Jenkins
ab9cfc4dc4 Merge "Add security groups options to "port create/set/unset"" 2016-10-17 08:27:58 +00:00
Reedip
bae09c3c3f Add support make a router HA
Currently router set CLI does not provide the
support make a router highly available. The following
patch enables the same.
Checking for setting a router as HA is left on the
neutron server itself.
Partially-Implements: blueprint network-commands-options
Change-Id: I0d0548cf037a14e5ccb2f732918ee9d1f63f43b4
Closes-Bug:#1631492
2016-10-16 05:05:23 +00:00
Reedip
8f8a8448a4 Add necessary info to Floating IP list
This patch adds the Network ID and Project ID
for the listed floating IPs when Neutron is enabled
for OpenstackClient.

Change-Id: I823090f2e6d30acd72247d30956f48f4d7672a50
Closes-Bug:#1566090
2016-10-16 05:04:38 +00:00
Steve Martinelli
82af038bb0 properly format error messages for volume resizing
The error messages are tuples and not substituting variables.

Before:
$ openstack volume set vol1 --size 1
Failed to set volume size: (u'New size must be greater than %s GB', 2)

$ openstack volume set vol1 --size 1
Failed to set volume size: (u'Volume is in %s state, it must be available
before size can be extended', u'error')

After:
$ openstack volume set vol2 --size 3
Failed to set volume size: New size must be greater than 4 GB

$ openstack volume set vol2 --size 3
Failed to set volume size: Volume is in error state, it must be available
before size can be extended

Change-Id: Ide6e644b1c6d1c11a9dc2f3f53c1a1837380b8d5
2016-10-15 20:29:54 -07:00
Jenkins
fd60e579c8 Merge "Add a new column and a new option the 'os port list' cmd" 2016-10-12 22:10:40 +00:00
Jenkins
a2e520c29c Merge "Add translation markers for object commands" 2016-10-12 21:26:47 +00:00
Nam Nguyen Hoai
2c1282cecf Add a new column and a new option the 'os port list' cmd
This patch will add a new column called status to the
result of the 'os port list' command and --long option
to 'os port list' command.

Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I4f942414e969687304b578ed7f003dd219c0f2f8
Closes-Bug: #1613995
Closes-Bug: #1614321
Partially-Implements: blueprint network-commands-options
2016-10-12 20:40:46 +00:00
Nguyen Phuong An
66a04abd58 Add security groups options to "port create/set/unset"
This patch adds '--security-group' and '--no-security-group'
options to "port create", "port set" and "port unset" commands.

Change-Id: Iff60d8f29227017b0a3966efca6cdecba69abcea
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2016-10-12 09:03:07 +07:00
Cedric Brandily
694a24c309 Fix --shared/block-migration options in server migrate command
Currently, --shared-migration and --block-migration options effects are
reversed: --block-migration requests a migration with share,
--shared-migration a block-migration.

This change corrects OSC implementation and clarifies arguments passed
to novaclient (the root cause of the bug).

Change-Id: Ib682cff0c44d3b1304670f8606907b1762d8b1e7
Closes-Bug: #1518059
2016-10-11 22:01:16 +02:00
Jenkins
0f02f7ea1e Merge "Add network support for Network QoS policies" 2016-10-11 18:14:00 +00:00
Rodolfo Alonso Hernandez
3205dad161 Add network support for Network QoS policies
Added following commands:
  - network qos policy create
  - network qos policy delete
  - network qos policy set
  - network qos policy show
  - network qos policy list

Closes-Bug: 1609037
Depends-On: I33bafeca979410d329ae10a82772ccdb48c10daa

Change-Id: I63a8f63702514ff5814481bb021e2aa9d5f3d4b1
2016-10-11 15:08:36 +00:00
Jenkins
6f60817cd4 Merge "Refactor image v1 unit tests with FakeImage class" 2016-10-11 12:42:47 +00:00
Choe, Cheng-Dae
2bbb482106 Fix router unset --route option
Fix the "--route" option one the "os route unset" command. The option
did not convert gateway to nexthop which results "Router does not contain
route" error.

Change-Id: Ia57bc7ea77ad7c6030535180a6ce42b4928c9e56
Closes-Bug: 1631471
2016-10-10 23:57:22 +09:00
Huanxuan Ao
407e164c95 Refactor image v1 unit tests with FakeImage class
Add FakeImage class, and refactor the unit tests
with it in image v1.

Change-Id: I9024ca5eca5c604e7588c1d905562bf6838309f1
Implements: bp improve-image-unittest-framework
2016-10-09 16:41:00 +08:00
Jenkins
12ed93e3d1 Merge "Improve output of supported API versions" 2016-10-07 17:54:07 +00:00
Kyrylo Romanenko
42f9317360 Improve output of supported API versions
Sort supported versions properly for better look.

Change-Id: I6c2f5ecc04cf14ea5bf1b214cb303fcc9783af3f
Closes-Bug: #1630962
2016-10-07 11:02:53 +00:00
Matt Riedemann
cd1a412408 Mask passwords in debug logs for auth_config_hook
The auth config hook can have credentials in it so
we have to mask the config before logging it. To
avoid doing the work of masking the password if we
aren't going to log it, there is a conditional put
around the actual debug statement.

Change-Id: I8e626672ec94fc837610216bccb4354dbdedca17
Closes-Bug: #1630822
2016-10-05 21:11:16 -04:00
Huanxuan Ao
ea7f28fb4a Refactor qos spec unit test in volume v1
Refactor qos spec unit test with FakeQos class
in volume v1.

Change-Id: Ia76bf41a911457282b293dfaf0af311b1a9194ce
2016-10-04 23:07:51 +08:00
Jenkins
0f5fde430c Merge "Add --ha option to os router create command" 2016-09-30 14:14:23 +00:00
Nam Nguyen Hoai
e2fc436d53 Add --ha option to os router create command
This patch added --ha option which the 'os router create'
command was missed.

Change-Id: I77635fb17af32beb0d8ed9aa080ef79285719fdc
Closes-Bug: #1610161
2016-10-01 14:55:23 +07:00
Jenkins
8031cd25d4 Merge "Replace 'MagicMock' with 'Mock'" 2016-09-30 11:13:09 +00:00
Jenkins
15069ef50e Merge "Support "--no" option in aggregate set" 2016-09-29 19:22:31 +00:00
Jenkins
2026dee17e Merge "Remove beta label for network segment resource" 2016-09-29 04:50:25 +00:00
Jenkins
fe879b5bd1 Merge "Add and modify options for "volume create" command" 2016-09-29 02:38:37 +00:00
Jenkins
08df1d0afc Merge "Implement "consistency group list" command" 2016-09-29 02:38:12 +00:00
Jenkins
ace3603ae9 Merge "Update default nova api version to 2.1" 2016-09-28 17:06:13 +00:00
qtang
c9fd35a496 Update default nova api version to 2.1
Ref:https://review.openstack.org/#/c/311653/
We should use 2.1 as the default nova version now

The API_MIN_VERSION of novaclient has already changed to 2.1

Change-Id: I9ff16cf052556e5d3756f81e02a8e76e8f315df5
Closes-bug: #1588171
2016-09-28 14:02:00 +00:00
Richard Theis
256ec66f79 Remove beta label for network segment resource
With Ocata development opened, neutron network segments are no
longer beta resources.

Change-Id: I25be51c30df17c746136471b88840f64a03187b9
Partially-Implements: blueprint routed-networks
2016-09-28 08:44:34 -05:00
Huanxuan Ao
c9e0c01f67 Add and modify options for "volume create" command
1.Add mutually exclusive options into a mutually
exclusive group.
2.Add "--source-replicated", "--consistency-group",
"--hint" and "multi-attach" options
3.Make --size option to be optional under some cases

Closes-Bug: #1568005
Closes-Bug: #1627913
Implements: bp implement-cinder-features
Co-Authored-By: Roman Vasilets <rvasilets@mirantis.com>
Change-Id: I2c4c3073195d33774e477f4d7f22e383b14b41dd
2016-09-28 10:13:56 +08:00
Huanxuan Ao
8d63b8b263 Implement "consistency group list" command
Add "consistency group" object in volume v2 (v2 only)
and implement "consistency group list" command

Change-Id: Ifa90d97f4b223f9a5b00708cff07fa2c5e2635f0
Implements: bp cinder-command-support
Partial-Bug: #1613964
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-28 09:31:04 +08:00
Nguyen Phuong An
3e9749149b Replace 'MagicMock' with 'Mock'
Change-Id: I35ebb2f0c83ec4300e26a72d9217ed0208f526eb
Closes-Bug: #1475722
2016-09-27 09:52:41 +07:00
Rajasi Kulkarni
28b66459db Add translation markers for object commands
None of the help messages for the object commands
are marked for translation. This patch adds the
necessary support.

Co-Authored-By: Steve Martinelli <s.martinelli@gmail.com>
Change-Id: Ibf472d8f7d5ab6c876f60cddcab8833b28f042e0
2016-09-26 22:52:14 -04:00
Rajasi Kulkarni
78312ca9af Add option "--name" to command "openstack object create"
Option "--name" can be used to set as the object name of
the file to be uploaded in the container. Similar to option
"--object-name" in command "swift upload". Added unit test case
to ensure an exception is raised when using option "--name" for
uploading multiple objects.

Change-Id: Ied7827841f6ca1cf9d4b48e304cbe5d62eda38ab
Closes-Bug: #1607972
2016-09-26 22:42:10 -04:00
Jenkins
f19240fc29 Merge "Add default limit for container/object" 2016-09-27 02:34:08 +00:00
zheng yin
9912fdd7ff Add default limit for container/object
Default container name length less than or equal to 256 in link[1],
as the same time,default object name length less than or equal to 1024
in link[2]. Thereforce, I check the length of container and object in take_action.
and if it's greater than 256/1024 I warn the user.

[1] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L39
[2] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L35

Change-Id: I304b77cbc464eaba041321654cc29248cbe4b9a6
2016-09-26 20:42:26 +08:00
Huanxuan Ao
3ebc7520a6 Add warning message for --state option of set command in volume
There are some set commands can set object state, it maybe
a danger behavor for users, so add explanation and warning
in the help message of the "--state" option to talk users
be caution when using (cinderclient have done this too)

Change-Id: I6a902887ea98879999c9972f36b1b7ef332173c3
2016-09-26 02:42:47 +00:00
Huanxuan Ao
52eaec1189 Add functional test for snapshot in volume v1
Add functional test for snapshot commands in volume v1.
Tests can always help to find or avoid bugs.

Change-Id: Ieb0ab9c763d381a6343b4c4a8a5874f3e682f24f
2016-09-25 09:30:45 +08:00
Rui Chen
6371556916 Support "--no" option in aggregate set
Supporting "--no-property" option will apply user a convenience
way to clean all properties of aggregate in a short command,
and this kind of behavior is the recommended way to devref.
The patch add "--no-property" option in "aggregate set" command,
and update related test cases and devref document.

Change-Id: I7614a23c0db05144562330dc600dbab7d003d5d8
Implements: blueprint support-no-property-in-aggregate
2016-09-24 15:59:13 +08:00
Jenkins
e90ba0dfb4 Merge "Add unit tests for backup commands in volume v1" 2016-09-23 21:36:37 +00:00
Jenkins
ab6b9dc389 Merge "Fix unset commands to pass normally when nothing specified" 2016-09-23 21:36:14 +00:00
Jenkins
578cd12dfb Merge "Add --description to Neutron commands" 2016-09-23 18:26:55 +00:00
Ankur Gupta
0981931628 Add --description to Neutron commands
Added simple option for floating ip description when creating
a floating ip.

Added option for create and set router as well.

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: Ib8cd8af449e9ff33b980017b2527a6b196894a00
2016-09-23 16:09:17 +00:00
Jenkins
b0750c76ec Merge "Use assertGreater replace assertTrue" 2016-09-23 12:33:12 +00:00