Commit graph

2249 commits

Author SHA1 Message Date
Choe, Cheng-Dae
2bbb482106 Fix router unset --route option
Fix the "--route" option one the "os route unset" command. The option
did not convert gateway to nexthop which results "Router does not contain
route" error.

Change-Id: Ia57bc7ea77ad7c6030535180a6ce42b4928c9e56
Closes-Bug: 1631471
2016-10-10 23:57:22 +09:00
Jenkins
12ed93e3d1 Merge "Improve output of supported API versions" 2016-10-07 17:54:07 +00:00
Kyrylo Romanenko
42f9317360 Improve output of supported API versions
Sort supported versions properly for better look.

Change-Id: I6c2f5ecc04cf14ea5bf1b214cb303fcc9783af3f
Closes-Bug: #1630962
2016-10-07 11:02:53 +00:00
Matt Riedemann
cd1a412408 Mask passwords in debug logs for auth_config_hook
The auth config hook can have credentials in it so
we have to mask the config before logging it. To
avoid doing the work of masking the password if we
aren't going to log it, there is a conditional put
around the actual debug statement.

Change-Id: I8e626672ec94fc837610216bccb4354dbdedca17
Closes-Bug: #1630822
2016-10-05 21:11:16 -04:00
Huanxuan Ao
ea7f28fb4a Refactor qos spec unit test in volume v1
Refactor qos spec unit test with FakeQos class
in volume v1.

Change-Id: Ia76bf41a911457282b293dfaf0af311b1a9194ce
2016-10-04 23:07:51 +08:00
Jenkins
0f5fde430c Merge "Add --ha option to os router create command" 2016-09-30 14:14:23 +00:00
Nam Nguyen Hoai
e2fc436d53 Add --ha option to os router create command
This patch added --ha option which the 'os router create'
command was missed.

Change-Id: I77635fb17af32beb0d8ed9aa080ef79285719fdc
Closes-Bug: #1610161
2016-10-01 14:55:23 +07:00
Jenkins
8031cd25d4 Merge "Replace 'MagicMock' with 'Mock'" 2016-09-30 11:13:09 +00:00
Jenkins
15069ef50e Merge "Support "--no" option in aggregate set" 2016-09-29 19:22:31 +00:00
Jenkins
2026dee17e Merge "Remove beta label for network segment resource" 2016-09-29 04:50:25 +00:00
Jenkins
fe879b5bd1 Merge "Add and modify options for "volume create" command" 2016-09-29 02:38:37 +00:00
Jenkins
08df1d0afc Merge "Implement "consistency group list" command" 2016-09-29 02:38:12 +00:00
Jenkins
ace3603ae9 Merge "Update default nova api version to 2.1" 2016-09-28 17:06:13 +00:00
qtang
c9fd35a496 Update default nova api version to 2.1
Ref:https://review.openstack.org/#/c/311653/
We should use 2.1 as the default nova version now

The API_MIN_VERSION of novaclient has already changed to 2.1

Change-Id: I9ff16cf052556e5d3756f81e02a8e76e8f315df5
Closes-bug: #1588171
2016-09-28 14:02:00 +00:00
Richard Theis
256ec66f79 Remove beta label for network segment resource
With Ocata development opened, neutron network segments are no
longer beta resources.

Change-Id: I25be51c30df17c746136471b88840f64a03187b9
Partially-Implements: blueprint routed-networks
2016-09-28 08:44:34 -05:00
Huanxuan Ao
c9e0c01f67 Add and modify options for "volume create" command
1.Add mutually exclusive options into a mutually
exclusive group.
2.Add "--source-replicated", "--consistency-group",
"--hint" and "multi-attach" options
3.Make --size option to be optional under some cases

Closes-Bug: #1568005
Closes-Bug: #1627913
Implements: bp implement-cinder-features
Co-Authored-By: Roman Vasilets <rvasilets@mirantis.com>
Change-Id: I2c4c3073195d33774e477f4d7f22e383b14b41dd
2016-09-28 10:13:56 +08:00
Huanxuan Ao
8d63b8b263 Implement "consistency group list" command
Add "consistency group" object in volume v2 (v2 only)
and implement "consistency group list" command

Change-Id: Ifa90d97f4b223f9a5b00708cff07fa2c5e2635f0
Implements: bp cinder-command-support
Partial-Bug: #1613964
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-28 09:31:04 +08:00
Nguyen Phuong An
3e9749149b Replace 'MagicMock' with 'Mock'
Change-Id: I35ebb2f0c83ec4300e26a72d9217ed0208f526eb
Closes-Bug: #1475722
2016-09-27 09:52:41 +07:00
Rajasi Kulkarni
78312ca9af Add option "--name" to command "openstack object create"
Option "--name" can be used to set as the object name of
the file to be uploaded in the container. Similar to option
"--object-name" in command "swift upload". Added unit test case
to ensure an exception is raised when using option "--name" for
uploading multiple objects.

Change-Id: Ied7827841f6ca1cf9d4b48e304cbe5d62eda38ab
Closes-Bug: #1607972
2016-09-26 22:42:10 -04:00
Jenkins
f19240fc29 Merge "Add default limit for container/object" 2016-09-27 02:34:08 +00:00
zheng yin
9912fdd7ff Add default limit for container/object
Default container name length less than or equal to 256 in link[1],
as the same time,default object name length less than or equal to 1024
in link[2]. Thereforce, I check the length of container and object in take_action.
and if it's greater than 256/1024 I warn the user.

[1] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L39
[2] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L35

Change-Id: I304b77cbc464eaba041321654cc29248cbe4b9a6
2016-09-26 20:42:26 +08:00
Huanxuan Ao
3ebc7520a6 Add warning message for --state option of set command in volume
There are some set commands can set object state, it maybe
a danger behavor for users, so add explanation and warning
in the help message of the "--state" option to talk users
be caution when using (cinderclient have done this too)

Change-Id: I6a902887ea98879999c9972f36b1b7ef332173c3
2016-09-26 02:42:47 +00:00
Huanxuan Ao
52eaec1189 Add functional test for snapshot in volume v1
Add functional test for snapshot commands in volume v1.
Tests can always help to find or avoid bugs.

Change-Id: Ieb0ab9c763d381a6343b4c4a8a5874f3e682f24f
2016-09-25 09:30:45 +08:00
Rui Chen
6371556916 Support "--no" option in aggregate set
Supporting "--no-property" option will apply user a convenience
way to clean all properties of aggregate in a short command,
and this kind of behavior is the recommended way to devref.
The patch add "--no-property" option in "aggregate set" command,
and update related test cases and devref document.

Change-Id: I7614a23c0db05144562330dc600dbab7d003d5d8
Implements: blueprint support-no-property-in-aggregate
2016-09-24 15:59:13 +08:00
Jenkins
e90ba0dfb4 Merge "Add unit tests for backup commands in volume v1" 2016-09-23 21:36:37 +00:00
Jenkins
ab6b9dc389 Merge "Fix unset commands to pass normally when nothing specified" 2016-09-23 21:36:14 +00:00
Jenkins
578cd12dfb Merge "Add --description to Neutron commands" 2016-09-23 18:26:55 +00:00
Ankur Gupta
0981931628 Add --description to Neutron commands
Added simple option for floating ip description when creating
a floating ip.

Added option for create and set router as well.

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: Ib8cd8af449e9ff33b980017b2527a6b196894a00
2016-09-23 16:09:17 +00:00
Jenkins
b0750c76ec Merge "Use assertGreater replace assertTrue" 2016-09-23 12:33:12 +00:00
Jenkins
1fc41f3837 Merge "Introduce overwrite functionality in `osc port set`" 2016-09-23 12:33:06 +00:00
Jenkins
40cc493b78 Merge "Overwrite/Clear support for subnets" 2016-09-23 12:24:16 +00:00
Huanxuan Ao
df8ef60603 Add unit tests for backup commands in volume v1
There was not any unit tests for backup commands
in volume v1 so that sometimes some small bugs
maybe ignored, this patch add unit tests for them.

Change-Id: Ic67c1b80243f7b3d15dabd25e4e4a1b1517a8b59
2016-09-23 17:22:44 +08:00
zheng yin
2e5d6a67f6 Use assertGreater replace assertTrue
we can use assertGreater(a,b) to replace assertTrue(a>b)

Change-Id: Idd92a99bf5fd25785a47645d46bcfcad23ed870a
2016-09-23 13:49:04 +08:00
Huanxuan Ao
fd876e4cc6 Fix unset commands to pass normally when nothing specified
After I found this problem appear in "volume unset",
I checked all the volume command and also found some
same problems. This patch fix them all.
The main reason of we ignored this problem before is
there was not any tests for it. So I add tests for
"nothing unset" for them all to test and aviod this
problem.
Also, I add unit tests for all snapshot commands
in volume v1 by the way in this patch. We will
need more tests to avoid some ignored problem.

Change-Id: I46775f24643d715e168b30785b8b531c0431a55b
Partial-bug: #1588588
2016-09-23 13:20:51 +08:00
Jenkins
9440509fa0 Merge "Add "volume backup set" command in volume v2" 2016-09-22 17:57:54 +00:00
Jenkins
bce740d5ff Merge "Add filtering options to os network list command" 2016-09-22 12:47:38 +00:00
Jenkins
80ce3bee6f Merge "Implement "volume transfer request show/accept" command" 2016-09-22 11:19:28 +00:00
Huanxuan Ao
3ef7e29dd0 Implement "volume transfer request show/accept" command
Add "volume transfer request show" and
"volume transfer accept" commands in
volume v1 and v2. Also add the unit tests,
docs, release note and functional tests

Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>

Change-Id: I5787fc486b3401307125caa316f517b9c96a95a5
2016-09-22 17:11:53 +08:00
Jenkins
5dc8151b58 Merge "Add network segment create, delete and set support" 2016-09-22 07:27:06 +00:00
Huanxuan Ao
ddf84429f2 Add "volume backup set" command in volume v2
Add "volume backup set" command in volume v2 (v2 only)
to set backup name, description and state

Change-Id: If17e8457db9a4704fb5bb9c75921ed82fd0069cf
Closes-Bug: #1613261
2016-09-22 13:55:12 +08:00
Jenkins
69c4f605ec Merge "Fix "volume unset" command pass normally when nothing specified" 2016-09-22 02:35:13 +00:00
Jenkins
0c6a46ab5c Merge "Refactor volume unit test with FakeVolume class in volume v1" 2016-09-22 02:33:59 +00:00
Ha Van Tu
9c473f475d Add filtering options to os network list command
This patch adds the following filtering options: '--name', '--internal',
'--share' and '--no-share', '--enable' and '--disable', '--project'
and '--project-domain', '--status'.

Change-Id: I7e9dd372ee572c6ee8cdba7fac3182f9dc0a137b
Partially-Implements: blueprint network-commands-options
Closes-Bug: #1578819
2016-09-22 09:33:48 +07:00
Jenkins
80d9c2a9b0 Merge "Use correct router add/remove interface methods" 2016-09-21 15:49:22 +00:00
Jenkins
813eba519a Merge "replace metavar "volume-id" with "volume" to avoid ambiguity" 2016-09-21 07:48:45 +00:00
Huanxuan Ao
bba5c9047f Fix "volume unset" command pass normally when nothing specified
When nothing specified in "volume unset" command, there
will be an error message says that the "--properties"
option is required, it is unusual behaviour, this patch
fix it and also add unit test for it.
Also, this patch add unit test for "volume show" command
by the way.

Change-Id: I5b5d587670acf0af4262b8521292455bf9f60fe5
Partial-bug: #1588588
2016-09-21 15:47:55 +08:00
rabi
47b782687f Use correct router add/remove interface methods
Use the correct openstacksdk method names.

Change-Id: I07b463753eedf41f79c6e00e9224d0f7697a1bd3
Closes-Bug: #1625954
2016-09-21 13:09:39 +05:30
Huanxuan Ao
4a8b802d6b Refactor volume unit test with FakeVolume class in volume v1
FakeVolume class has been added in the fake.py in
volume v1, this patch refactors the volume command
unit tests with the FakeVolume class.

Change-Id: Ic3c1a46d5bff9048d0095f5739ae9e5a34ca6b5b
2016-09-21 15:33:37 +08:00
Shu Yingya
b30a7b795f replace metavar "volume-id" with "volume" to avoid ambiguity
The help message of command "openstack volume show" accepts either
volume-name or volume-ID. But the metavar is "volume-id" as below.
It can easily lead to misunderstanding.

usage: openstack volume show [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>]
                             [--noindent][--prefix PREFIX]
                             <volume-id>

Change-Id: I57576ea23868b1026cf268be69b39e98a53aafd4
2016-09-21 12:33:01 +08:00
Jenkins
682c2bfb8b Merge "Remove unnecessary setUp" 2016-09-21 04:30:29 +00:00