Commit graph

558 commits

Author SHA1 Message Date
Zuul
4e6f47e28e Merge "Add metavar for name parameter in subnet create" 2018-10-03 01:30:11 +00:00
Brian Haley
3c5824415f Fix some spaces in help messages
Fix some missing and not necessary trailing spaces in
the network v2 API files.  Also fixed one block indent
that was different from all its friends.

Trivialfix

Change-Id: Ic6491203c2fb9085543d69f0bb5f38e5a96039da
2018-09-27 17:54:40 -04:00
Wenran Xiao
01c3548dc8 Fix help message for subnetpool default-quota value
Default pre-project quota is the number of IP addresses that can be
allocated from the subnet pool. For example, with a quota of 128,
I might get a 64 addresses subnet1, and 16 addresses subnet2,
and still have room to allocate 48 more addresses in the future.

Change-Id: Ia0ba827790b190647aed990e47347560fc9e9f0c
2018-09-19 10:11:47 +08:00
David Rabel
14ceb6307f Add metavar for name parameter in subnet create
Change-Id: I2511677006687fff3166441c51e91191492962f1
Closes-Bug: #1747731
2018-09-12 17:25:10 +02:00
Zuul
a84aa492a6 Merge "Detailed help message for QoS max-burst-kbps value" 2018-08-14 17:44:18 +00:00
Lajos Katona
5c0de6edc2 Detailed help message for QoS max-burst-kbps value
For QoS rule type bandwidth-limit the max-burst-kbps value for ovs and
linuxbridge is suggested to be 80% of the maxkbps value, let's give a
detailed help message for the CLI user.
For details see https://docs.openstack.org/neutron/queens/admin/
config-qos.html#user-workflow

Change-Id: Ia6e38ec7052b7af64880c2f4c5e242d7cb980df5
Closes-Bug: #1777866
2018-08-10 07:37:57 +02:00
Zuul
a051bda111 Merge "Add DNS support to floating IP commands" 2018-08-08 20:15:07 +00:00
Zuul
c387f83af1 Merge "Add dns-domain support to Network object" 2018-08-07 22:10:41 +00:00
Jens Harbott
ed09f28a9d Add DNS support to floating IP commands
Add the DNS domain and name options to the ``floating ip create``
command. Also add these two columns to the output of the
``floating ip list --long`` command.

Change-Id: Id4cb18b51b252f19b87b24ec5d77183771189d17
Story: 1547736
Task: 13114
2018-08-06 08:14:48 +00:00
Brian Haley
6cb0f0f79c Fix missing trailing spaces in network help messages
Trivialfix

Change-Id: I1eeab576e7f50d858860a19c045f24a33449dc92
2018-08-03 12:29:34 -04:00
Zuul
d838c69605 Merge "Support filtering port with IP address substring" 2018-07-25 00:42:32 +00:00
Zuul
00194b4e20 Merge "Do not require port argument when updating floating IP" 2018-07-24 00:53:33 +00:00
Zuul
d6cf027be1 Merge "Make Profile fallback go bye-bye" 2018-07-10 14:21:48 +00:00
Hongbin Lu
4a9cb8eea8 Support filtering port with IP address substring
Change-Id: I9559f1c0a6db943705bd32aefb60d7ea7054dd1b
Related-Bug: #1718605
2018-06-29 20:15:28 +00:00
Zuul
3493948d13 Merge "Format port_details field of Floating IP" 2018-06-28 17:26:06 +00:00
Zuul
4bde9af892 Merge "Network: Add tag support for security group" 2018-06-25 15:16:05 +00:00
Huang Cheng
5bb5585aa9 Fix subnet host_routes error
When updating subnet with "no-host-route" option, set host_routes to an empty list as neutron_lib.api.validators expected.

Change-Id: I6fe039793d813758429c7a104fd40172b4f8122b
Closes-Bug: #1747101
2018-06-14 13:03:46 +00:00
yanpuqing
402c9a21b3 Do not require port argument when updating floating IP
When setting floating ip other properties, port argument is
force to use.
The patch modifies the command, when setting floating ip other
properties, like tags, no need port argument.

Change-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de
Story: 1751431
Task: 13865
2018-06-13 23:05:30 -04:00
Dongcan Ye
aaed4b315f Network: Add tag support for security group
Change-Id: Icccb23429913724c6a8bd15d4737672b47a5f13a
Closes-Bug: #1750983
2018-06-14 01:01:58 +00:00
Zuul
a7973d927d Merge "Remove deprecated ip floating commands" 2018-06-09 18:43:45 +00:00
Harald Jensas
e8c731547d Allow setting network-segment on subnet update
To enable the possibility to migrate a non-routed network to a
routed network allow updating the segment_id of a subnet.

Change-Id: I3ebae2ff28d5d4e5373ebd1f52194f8c52071b88
Partial-Bug: bug/1692490
Depends-On: I1aee29dfb59e9769ec0f1cb1f5d2933bc5dc0dc5
2018-06-06 11:56:39 +02:00
Sławek Kapłoński
9b6d02d5f9 Make max_burst_kbps option as optional for bw limit QoS rule
Attribute max_burst_kbps of QoS bandwidth limit rule in Neutron's
is optional in API so it should be also optional on client's side.

Change-Id: Ie085b73fa885ff12f9ac080666cf3ca6a09b632a
Related-Bug:#1770622
Task: 19658
Story: 2002017
2018-05-25 12:54:41 -07:00
Hongbin Lu
46f8614da8 Format port_details field of Floating IP
Depends-On: I31e940d2986278d2fbee6fdfea4ff15f7c07ebaa
Change-Id: I115739ea253ce26e075cd3f10e719b13f18afa5b
Partial-Bug: #1723026
2018-04-27 20:29:35 +00:00
Pierre Hanselmann
b8754e15e7 Add dns-domain support to Network object
Add "dns-domain" parameter to Network class. Also check
backend extensions and send an error message in case of
an argument (like dns-domain) is sent and the extension is
missing (dns-integration in this case).

Change-Id: I7303658c27d9b9f2d8381ccea0b29e96909cab54
Closes-Bug: 1633214
Partial-Bug: 1547736
2018-04-23 08:37:27 +00:00
Zuul
b59de7b849 Merge "Network: Add tag support for floating ip" 2018-04-23 08:12:25 +00:00
Dongcan Ye
09a0916dae Network: Add tag support for floating ip
Change-Id: I7a500a4ff6cec2442b4050df26c0b017d9f71903
Closes-Bug: #1750985
2018-04-17 15:52:52 +00:00
Sean McGinnis
d601415259 Clean up W503 and E402 pep8 errors
pycodestyle 2.40 and later enforce these rules that were not previously
enforced. Rather than just skipping them, this cleans up the trivial
instances of these violations.

This does also include some other updates that were not triggering errors
in an attempt to keep some of the style consistent.

Change-Id: Id7c0a6b8f1f835e69d844b000e3ed751852ada63
Closes-bug: #1762803
2018-04-15 12:23:06 +09:00
Dongcan Ye
ea89065dab Remove deprecated ip floating commands
We had already implemented floating ip(pool) commands more
than two cycles, we can remove those deprecated commands.

Change-Id: Ib98a7403a63bb0c48c03de4c79795737de2aa84c
2018-04-08 11:37:42 +00:00
Zuul
29d4dd7a61 Merge "neutron: add --mtu for create/set network" 2018-03-23 14:31:39 +00:00
Brian Haley
2ed1b24c71 Fix typo in 'floating ip associate' command and doc
Assocaite -> Associate

Trivialfix

Change-Id: I432e35ddcd80ef77c865bee9a54ac2777f5b6386
2018-03-15 16:30:43 -04:00
Emilien Macchi
18563b4132 neutron: add --mtu for create/set network
Support Neutron network mtu configuration with a new argument, --mtu
that allows CLI users to set MTU for Neutron networks.

Change-Id: I93d23581c7e8c84eaf9bb3b293360036f60f456b
2018-03-15 13:50:59 +00:00
Monty Taylor
372f7caa08 Make Profile fallback go bye-bye
It's time to move on with life.

(dtroyer) This requires sdk >= 0.10.0 (0.9.19 is in
global-requirements.txt) and osc-lib >= 1.8.0 (1.8.0 is already in g-r).
Once we have sdk bumped make_client() becomes just a pass-through for
the plugin interface and existing code compatibility.

Change-Id: Ie3d7c442da4257b11140c109e9df69b629336f42
2018-03-14 10:57:13 -05:00
Dean Troyer
53e7aab7ed Re-implement novaclient bits removed in 10.0
a)

/os-floating-ips was removed in Compute API 2.36 and from novaclient's
Python API in 10.0

Add to api.computev2:
floating_ip_add()
floating_ip_remove()

Convert add floating IP command to nova-net/neutron split:
"server add floating ip"
"server remove floating ip"

b)

/os-hosts was removed in Compute API 2.43 and from novaclient's
Python API in 10.0.

Add to api.computev2:
host_list()
host_set()
host_show()

Convert host commands to use intenal api:
"host list"
"host set"
"host show"

c)

The introduction of the Network-style commands into the server group
broke cliff's autoprogram directive as it executes the get_parser() methods
without fully initializing the Command object.

NOTE: This is really three reviews squashed to get through the gate in one pass.

Depends-on: Id6de87211d6c4ea8fd14aa9203d8d5b17e9e2f04
Change-Id: I5116086f9a9e4b2b31a744bf8f4558c79f0bfe59
2018-03-13 09:10:45 -05:00
Zuul
1b5cab40b5 Merge "Add support for "--dns-domain" argument" 2018-02-24 10:59:41 +00:00
Tytus Kurek
4a9e84be99 Add support for "--dns-domain" argument
This patchset implements support for "--dns-domain" argument to the
following commands: "openstack port create" / "openstack port set".

Change-Id: I4bb001054b00a969b74db3bb310e567033bf589b
Depends-On: https://review.openstack.org/#/c/500660/
Closes-Bug: #1714878
Partial-Bug: #1704769
2018-02-23 20:30:37 +00:00
Monty Taylor
a742e47ecf
Use find_ip from openstacksdk
The find_ip from openstacksdk started being usable by OSC back in 0.9.15
but the local method never got replaced.

Change-Id: I18a334280e5f384f8bb96198cdad79c612a02290
2018-01-29 12:05:22 -06:00
Monty Taylor
5e411fbce7
Fix use of new openstacksdk connection
We store the created conn on the instance, but we never pull it back off
if there is already one present.

Change-Id: I2d890dd206d4ddf67fa42d798e6fd2c652799785
2018-01-23 08:08:26 -06:00
Dean Troyer
a018c6d5d8
Rework Network client config for new SDK Connection
network.client.make_client() has always put a copy of it's SDK Connection
directly into ClientManager, the new-style Connection create will move
into osc-lib ClientManager, do it here too until then.

Change-Id: I1edfd19c9e73320768fb9640931fafe857c980b4
2018-01-22 16:51:03 -06:00
Zuul
8abf6bf5ba Merge "Add floating IP qos_policy actions" 2018-01-11 21:03:18 +00:00
LIU Yulong
cf91d7a2f4 Add floating IP qos_policy actions
Now we can associate a qos policy to the floating IP, and
dissociate it. The commands are:

  $ openstack floating ip create --qos-policy ...
  $ openstack floating ip set --qos-policy ...
  $ openstack floating ip set --no-qos-policy ...
  $ openstack floating ip unset --qos-policy

These commands are based on the neutron change:
I4efe9e49d268dffeb3df4de4ea1780152218633b

Partially-Implements blueprint: floating-ip-rate-limit

Change-Id: I932b32f78cc5a2b53926feaec1a0b392cf7e8b57
2018-01-11 18:10:11 +00:00
Hongbin Lu
5fdd0730c8 Allow ports filtering with device_id
Right now, if a neutron port is owned by a container powered by
Kuryr, there is no way to list and filter those ports because
OSC assumed a neutron port is owned by either a server or router.
This patch adds support for that by introducing an option '--device-id'
to the 'port list' command.

Change-Id: Ib1fd27e8d843a99fb02ccabd8a12a24ac27cec9c
2018-01-03 21:11:02 +00:00
Zuul
e157365d86 Merge "Allow port list to shown undefined attributes" 2017-12-31 13:00:26 +00:00
Dean Troyer
1d914dd9ad Fix SDK Connection creation alternative to Profile
Do a dummy import to determine which SDK is installed (Pre/post merge).

This solves the DevStack error "Cloud defaults was not found" in -tips jobs.

Depends-On: Ia111f127fbdceac2afe20fd9d1fe032145cdd72c
Change-Id: I60c2d418dd5a393eee2cc2a5c2fdebfffdabf2d3
2017-12-07 08:10:23 -06:00
Carlos Konstanski
dab49df461 openstack subnet create fails when tags is None
In network/v2/_tag.py lines 105 and 110: obj.tags can be None, in
which case set(obj.tags) throws a NoneType exception.

Change-Id: I1e965ec947844cbf84676fab27a2261fc0c0ea49
Closes-Bug: #1735836
2017-12-01 15:17:03 -07:00
Akihiro Motoki
0626f95579 Allow port list to shown undefined attributes
At now, OSC command implementation extracts resource attributes based on
a predefined column list, so if a user specifies an unknown attribute
not defined in the column lists, such attribute will be ignored.

In case of 'port list', the neutron port defines many attributes and
it is not a good idea to show all attributes even in the long mode
from the perspective of user experience.

This commit consumes osc_lib.utils.calculate_headers_and_attrs()
function to show undefined port attributes if requested in -c option.

Closes-Bug: #1707848
Depends-On: I6c6bc3c6e3c769c96869fd76b9d9c1661280850e
Change-Id: I130a6aed41d80603698b6cab0c9a1d1dc59df743
2017-11-24 22:45:06 +00:00
Monty Taylor
80da4d6cf8
Add logic to handle old and new sdk constructor
SDK is removing Profile, but currently has compat code to support this
invocation in OSC. While the intent is to protect people from upgrade
breakage, it's python, and packaging things have a tendency to get
strange. By putting in a little belt and suspenders if block here, we
can hopefully protect folks who upgrade sdk for some reason without
upgrading python-openstackclient.

Change-Id: Id678e97a2b99dbbfc772acc8c6ba283db551723d
2017-11-16 08:09:11 -06:00
Zuul
c161a76a5f Merge "Network: Add interfaces info in router show" 2017-11-16 01:45:55 +00:00
ycx
e7ef9e8556 Network: Add interfaces info in router show
Add a list of interfaces info in the output of
'openstack router show'.
The information of router interface are:
IP address, subnet ID and port ID.

Co-Authored-By: Dongcan Ye <hellochosen@gmail.com>

Change-Id: I1252986122122defffe795292b83dc4e84481c7e
Closes-Bug: #1675489
2017-11-15 22:28:46 +00:00
Hongbin Lu
8b31e2bc48 Show detailed message of neutron exception
This patch improves the error message by retrieving the more details
from the exception instance. Otherwise, the real error message won't
be displayed (unless using --debug in the command).

Change-Id: I8ba694bda86f7cc8362e301b2044d9b610dde49c
2017-11-14 23:25:52 +00:00
Zuul
d12fd10cc1 Merge "Neutron agent delete: remove the wrong argument" 2017-11-07 06:59:54 +00:00