Commit graph

60 commits

Author SHA1 Message Date
Cedric Brandily
53ba05325a Enable to create legacy router
Some deployments create by default HA routers, this change enables to
force the creation of a legacy router using:

 openstack router create --no-ha ...

Closes-Bug: #1675514
Change-Id: I78f7dc3640a2acfdaf085e0e387b30373e8415f1
2017-03-31 13:01:00 +00:00
Gábor Antal
c9b1c2ad96 Handle log message interpolation by the logger in network/
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
Related-Bug: #1596829

Change-Id: I17467d01420750c004fbbf2a07730fc2badd62b8
2017-02-13 18:14:34 +01:00
Jenkins
317cbe2c6e Merge "Fix a spelling error" 2016-12-28 03:16:01 +00:00
JingLiu
6929c50a13 Fix a spelling error
Change-Id: Ic14c769d99986d5c51d26fc276f4d47d6fba3265
2016-12-26 17:01:48 +08:00
Jenkins
5d62981beb Merge "Introduce overwrite functionality in `osc router set`" 2016-12-21 22:09:50 +00:00
Reedip
4a5bf8d2a5 Add support for clearing router gateway
This patch adds the support to clear the gateway information
from a router.

Change-Id: I446c556750f080a6fc21fea8f531fd71838d648a
Implements: blueprint neutron-client-advanced-router
Partially-Implements: blueprint network-commands-options
2016-12-19 17:30:19 -05:00
Reedip
25104c7d4a Introduce overwrite functionality in `osc router set`
The overwrite functionality allows user to overwrite
the routes of a specific router.

Change-Id: I8d3cfe5cab2ffbfa046371c3adcd2cf446c91cbc
partially-implements: blueprint allow-overwrite-set-options
2016-12-19 16:57:02 -05:00
Jenkins
e51a2b3b17 Merge "Add support for setting router gateway" 2016-12-19 14:31:11 +00:00
Reedip
841d9d8dbd Add support for setting router gateway
This patch adds the support to set the gateway information
for a router.

Implements: blueprint neutron-client-advanced-router
Partially-Implements: blueprint network-commands-options
Change-Id: Ifb5a4d1965cd7e75c0c8cf2cfb677e0628b699dc
Depends-On: I2bda0dd40afd64b6cecca5f64ef2326bda4fac92
2016-12-17 18:22:45 +00:00
Yan Xing'an
083e155ae5 SDK Refactor: Prepare router commands
Prepare the OSC "router" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I2fa12943a65e3981b924e6cea9ed041682ec54b2
Partially-Implements: blueprint network-command-sdk-support
2016-12-12 19:23:27 -08:00
Jenkins
158dbe124a Merge "Add '--project' and '--project-domain' options to os cmds" 2016-12-05 22:28:21 +00:00
judy-yu
83675e9ee0 Avoid duplicated project_id when show network resources
Project_id appear twice when show network resources. This
patch check and not append if it already has one.

Change-Id: I744988f3f52d4a744e397a6a82fefdc4c17eacbf
Closes-Bug: #1636123
Partially-Implements: blueprint duplicated-project-id
2016-12-04 18:03:33 +08:00
Nam Nguyen Hoai
ce079d2261 Add '--project' and '--project-domain' options to os cmds
This patch added '--project' and '--project-domain' options to
filter subnets resulted by 'os subnet list',
'os floating ip create' and 'os security group list' commands.

Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I727663d49ffa6aa042fdeb60797f18bb753b0372
Closes-Bug: #1613231
Closes-Bug: #1610909
Closes-Bug: #1613629
Partially-Implements: blueprint network-commands-options
2016-12-01 14:59:10 +07:00
Steve Martinelli
0ef8535036 translate all command help strings
Leverage the new cliff command class attribute (_description)
to get the help of a command, this allows us to mark strings
for translation. We could not do this before since the help
was grabbed from the docstring.

This also depends on a new release of cliff and a bump to the
minimum level in osc's requirements.

Closes-Bug: 1636209
Depends-On: Id915f6aa7d95a0ff3dc6e2ceaac5decb3f3bf0da
Change-Id: I8673080bb5625e8e3c499feaefd42dfc7121e96f
2016-11-17 02:33:42 +00:00
Yi Zhao
84beac5994 Add filtering options --name,--enable,--disable to router list
Change-Id: I171b6be4501b02c3df66589c45177200919117db
Closes-Bug: #1637945
Partially-Implements: blueprint network-commands-options
2016-10-31 16:54:08 +08:00
Reedip
bae09c3c3f Add support make a router HA
Currently router set CLI does not provide the
support make a router highly available. The following
patch enables the same.
Checking for setting a router as HA is left on the
neutron server itself.
Partially-Implements: blueprint network-commands-options
Change-Id: I0d0548cf037a14e5ccb2f732918ee9d1f63f43b4
Closes-Bug:#1631492
2016-10-16 05:05:23 +00:00
Choe, Cheng-Dae
2bbb482106 Fix router unset --route option
Fix the "--route" option one the "os route unset" command. The option
did not convert gateway to nexthop which results "Router does not contain
route" error.

Change-Id: Ia57bc7ea77ad7c6030535180a6ce42b4928c9e56
Closes-Bug: 1631471
2016-10-10 23:57:22 +09:00
Nam Nguyen Hoai
e2fc436d53 Add --ha option to os router create command
This patch added --ha option which the 'os router create'
command was missed.

Change-Id: I77635fb17af32beb0d8ed9aa080ef79285719fdc
Closes-Bug: #1610161
2016-10-01 14:55:23 +07:00
Jenkins
578cd12dfb Merge "Add --description to Neutron commands" 2016-09-23 18:26:55 +00:00
Ankur Gupta
0981931628 Add --description to Neutron commands
Added simple option for floating ip description when creating
a floating ip.

Added option for create and set router as well.

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: Ib8cd8af449e9ff33b980017b2527a6b196894a00
2016-09-23 16:09:17 +00:00
rabi
47b782687f Use correct router add/remove interface methods
Use the correct openstacksdk method names.

Change-Id: I07b463753eedf41f79c6e00e9224d0f7697a1bd3
Closes-Bug: #1625954
2016-09-21 13:09:39 +05:30
Ukesh Kumar Vasudevan
e04e389da2 router list if availability_zone ext not enabled
when calling router list with --long OSC expects the availability_zone
field in the response, even if this extension is not loaded:

As per the document, http://developer.openstack.org/api-ref/networking/
v2/?expanded=list-routers-detail, The availability zone(s) for the router
is available when router_availability_zone extension is enabled.

Added testcase to test router list without availability zone

Change-Id: Ic9abb06140eb310b797ade8b0463a876d8bea1b8
Closes-bug: #1622565
2016-09-15 16:24:15 +05:30
Jenkins
6920c9e839 Merge "Add command to unset information from Routers" 2016-06-28 22:29:31 +00:00
reedip
ed64788cf1 Add command to unset information from Routers
This patch introduces the ``router unset`` command to
clear the routing information from the routers.
Implements: blueprint network-property-unset

Change-Id: Iac8d32ca42fb28878805b4b58ab411b67fa6555b
2016-06-27 10:41:13 +00:00
SongmingYan
ee156b5fe3 Fix the problem of router delete
Change "Remove" to "Delete" when using it in route-interface-delete.

Change-Id: I9ebc38c787acbcb42d2f8efeee41f6cb943e4b9b
Related-bug: #1560446
2016-06-24 03:52:49 +00:00
Huanxuan Ao
8b6626e9b6 Error handling of "router delete" command
"Router delete" command supports multi deletion but no error
handling. This patch add the error handling follow the rule
in doc/source/command-error.rst

Change-Id: I3376d957b4dc28d8282599dc909ecc5ed2b5f46a
2016-06-20 18:05:20 +08:00
Dean Troyer
9e2b8e6730 osc-lib: command
Leave command.py and test_command.py as a sanity check during the
deprecation period.

Change-Id: I24e1b755cbfbcbcaeb5273ec0c9706b82384fc85
2016-06-13 11:00:22 -05:00
Dean Troyer
be192676bd osc-lib: parseractions
Leave parseractions.py and test_parseractions.py as a sanity check during the
deprecation period.

Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83
2016-06-13 10:55:44 -05:00
Dean Troyer
e5e29a8fef osc-lib: utils
Use osc-lib directly for utils.

Leave openstackclient.common.utils for deprecation period.

Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
2016-06-13 10:50:44 -05:00
Jenkins
ada6abb30e Merge "Make set/unset commands in network return normally when nothing specified" 2016-06-09 14:58:17 +00:00
sunyajing
aefd2195b1 Fix network
modify ``columns, data`` to ``(columns, data)`` in network,
to keep code consistence.

Change-Id: I0522c499d1651b4ea948bebccbdfd520934e8e6a
2016-06-08 17:08:36 +08:00
Tang Chen
e3270cdfd8 Make set/unset commands in network return normally when nothing specified
set/unset commands should ends up normally instead of raising
an exception when nothing is specified to modify. The main
reason is: When nothing is specified, the command sets/unsets
nothing, which is a normal behavior, and ends up normally.
No API call fails. No error happens.

This patch also adds a releasenote for both network, and volume
commands that fix patch has been merged.

Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef
Partial-bug: #1588588
2016-06-08 14:31:17 +08:00
Jenkins
cb068d8c68 Merge "Fix i18n support for help and error msg in network" 2016-05-16 23:33:23 +00:00
Tang Chen
40f51c32ac Fix i18n support for help and error msg in network
Change-Id: Iab0dc489226601ac4ff123bb758f84ff16989395
2016-05-16 16:15:46 +08:00
Hideki Saito
bc93ebfe5c Added --no-route to the router set command
Deprecated --clear-routes

Closes-Bug #1565034

Change-Id: I4a8975edc026aecd2a362fd1929c984cfab8ade6
2016-05-16 12:02:00 +09:00
Richard Theis
a90c824e04 Fix router set --route option
Fix the "--route" option on the "os router set" command. The
option did not properly format the new routes to set which
resulted in a "HttpException: Bad Request" error. In addition,
the output for routes was fixed to improve readability and to
align with the "--route" option on the "os router set" command.

Change-Id: I9c514153ec201e2feae32be6dd281771e3298b9c
Closes-Bug: #1564460
2016-04-18 13:35:38 -05:00
Tang Chen
89445855ac State i18() changes and help messages improved
Add _() to wrap help message in network commands.
And also some improvement for help message.

Change-Id: Ib3e498f5976ba98c44fd4eec2d1623263b3db53e
Partial-bug: 1570924
2016-04-18 10:31:01 +08:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
Jenkins
6c73946623 Merge "Add Subnet add/remove support to router" 2016-04-09 04:52:09 +00:00
Jenkins
b70afef9d5 Merge "Add "router remove port" to osc" 2016-04-09 04:43:35 +00:00
Dean Troyer
0ea80a92f0 Fix pep8 fail that crept in
Not sure how, but this crept in via https://review.openstack.org/#/c/281691/

Change-Id: I919276ee5204277dbc5e96f4de4b98381142423a
2016-04-08 19:33:15 -05:00
Jenkins
5d2f4107b4 Merge "Add "router add port" to osc" 2016-04-08 18:24:46 +00:00
reedip
c5c15a0135 Follow Boolean Option rule
OSC has a specific rule for handling boolean based options
in  [1]. This patch modifies the exisiting code so that it
matches the criteria that have been specified in [1].

[1]: http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

Closes-Bug: #1559418
Change-Id: I182381d5579efbc75a5d3e8a91f412398abf5c3c
2016-03-31 13:06:45 +09:00
reedip
9e42daa577 Add Subnet add/remove support to router
The following patch adds the support for
"router add subnet" and "router remove subnet"
to the OSC as a part of migration of Neutron's
CLI commands.

Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
Change-Id: Ia3770c41026194bdb1543d4e67446f81936d44d1
2016-03-22 01:55:19 +00:00
reedip
8ecdc57ea6 Add "router remove port" to osc
This patch proposes the migration of port
deletion of Neutron's "router-interface-delete"
to OSC's "router remove port".

Change-Id: Ifceabce080aacac9f6410c809fcc097760e0c5ee
Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:08:16 +00:00
reedip
2e94f2803f Add "router add port" to osc
This patch proposes the migration of port addition of
Neutron's "router-interface-add" to OSC's "router add port".

Change-Id: I3a8a76d384caa32975f8e77f50f3cf3c3be13786
Closes-Bug: #1546849
Depends-On: I9783bc4ccceae3d361dce52d51483ef2187920a9
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:07:21 +00:00
Tang Chen
dc7e4fc15d Fix dict.keys() compatibility for python 3
In Python 2, dict.keys() will return a list.
But in Python 3, it will return an iterator.
So we need to fix all the places that assuming
dict.keys() is a list.

Change-Id: I8d1cc536377b3e5c644cfaa0892e40d0bd7c11b1
Closes-Bug: #1556350
2016-03-12 10:58:28 +08:00
Tang Chen
50443127c5 Fix incorrect unit test for router
Command "router show" will display router's "tenant_id" as
"project_id". But in the unit test, it checks "tenant_id",
which is incorrect.

This patch fix this problem, and add a _get_columns() helper
function to simplify the code.

Change-Id: I0087ef7dfd0130b6c47222495848c4f2b9804b1b
2016-03-03 20:50:17 +08:00
Tang Chen
01c19ef0bc Router: Add --route and --clear-routes options to "router set" command
--route option is used to set routes to the router.

It is used like this:

    --route destination=subnet,gateway=ip-address

destination: destination subnet CIDR
gateway: nexthop IP address

--clear-routes is used to clear all routes on the router.

Change-Id: I97ce4871113c684b29c98cdad4dec9cc80ed20f7
Implements: blueprint neutron-client
Partial-bug: #1519503
2016-02-27 04:53:10 +08:00
Jenkins
95263a0b8c Merge "Minor typo in help text" 2016-02-04 00:43:09 +00:00