Commit graph

211 commits

Author SHA1 Message Date
Fang Zhen
b92cf77fb5 Add network support for "quota set"
The "quota set" command support compute and volume quotas previously.
This patch add support network.

Partially-implements: blueprint neutron-client-quota
Closes-bug: 1489441

Change-Id: I9d297f52bc30614b3493f09ed15f8f1d3f8ff952
2016-05-19 20:42:59 +08:00
Jenkins
c655569628 Merge "Add ip version filter to subnet list" 2016-05-17 22:28:06 +00:00
Jenkins
5dfedd6445 Merge "Enhance exception handling for "network delete" command" 2016-05-17 03:04:42 +00:00
Jenkins
3d12ae8e03 Merge "Add VLAN Transparent option to `osc network`" 2016-05-16 22:57:25 +00:00
Jenkins
11be59db8c Merge "Added --no-route to the router set command" 2016-05-16 22:51:15 +00:00
Jenkins
c471a97aef Merge "Fix network router type display" 2016-05-16 22:39:53 +00:00
Manjeet Singh Bhatia
668bc028d1 Add ip version filter to subnet list
This patch will add argument ip-version to command
subnet list

Change-Id: If7458d4979e53aec7e2633c4f1779c3810f9a3f1
Closes-Bug: #1581179
2016-05-16 22:37:14 +00:00
reedip
00c149a28f Add VLAN Transparent option to `osc network`
osc network set and network create now support
--transparent-vlan|--no-transparent-vlan options
to add/remove vlan transparency from the network.

Change-Id: I845eb8f541cd32a4c4b28f929a63b205e7e31756
Closes-Bug: 1545537
2016-05-16 08:32:07 +00:00
Hideki Saito
bc93ebfe5c Added --no-route to the router set command
Deprecated --clear-routes

Closes-Bug #1565034

Change-Id: I4a8975edc026aecd2a362fd1929c984cfab8ade6
2016-05-16 12:02:00 +09:00
Richard Theis
fd5fd924d1 Additional network protocol support
Add the following network protocol support to the
"os security group rule create" command:
  - Add "--icmp-type" and "--icmp-code" options
    for Network v2 only. These options can be used to set
    the ICMP type and code for ICMP IP protocols.
  - Change the "--proto" option to "--protocol". Using the
    "--proto" option is still supported, but is no longer
    documented and may be deprecated in a future release.
  - Add the following Network v2 IP protocols to the
    "--protocol" option: "ah", "dccp", "egp", "esp", "gre",
    "igmp", "ipv6-encap", "ipv6-frag", "ipv6-icmp",
    "ipv6-nonxt", "ipv6-opts", "ipv6-route", "ospf", "pgm",
    "rsvp", "sctp", "udplite", "vrrp" and integer
    representations [0-255].

The "os security group rule list" command now supports
displaying the ICMP type and code for security group rules
with the ICMP IP protocols.

Change-Id: Ic84bc92bc7aa5ac08f6ef91660eb6c125a200eb3
Closes-Bug: #1519512
Implements: blueprint neutron-client
2016-05-14 07:54:41 -05:00
Jenkins
fe02162bd3 Merge "Implement "address scope set" command" 2016-05-11 07:59:04 +00:00
Jenkins
94de0d3ebd Merge "Implement "address scope show" command" 2016-05-11 07:11:43 +00:00
Jenkins
0acb743611 Merge "Implement "address scope list" command" 2016-05-11 07:11:36 +00:00
Jenkins
b503267616 Merge "Implement "address scope delete" command" 2016-05-11 06:53:56 +00:00
Jenkins
2aa99b4d50 Merge "Implement "address scope create" command" 2016-05-11 06:42:25 +00:00
Huanxuan Ao
cc78d48a28 Implement "address scope set" command
This patch add a command that supports
setting address scope properties.

Change-Id: I9c4b5068a8abb986a9dc18b167b48b924d16ff42
Closes-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
32da111c17 Implement "address scope show" command
This patch add a command that supports
showing address scope details

Change-Id: Ic0b41c1cab8c618904c7a6046d7493db5b74b430
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
aa5ff67e3f Implement "address scope list" command
This patch add a command that supports
listing address scopes

Change-Id: Id14757011560cacf28011ba51841a8e23b824f33
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
4cb5e0bc79 Implement "address scope delete" command
This patch add a command that supports
deleting a address scope

Change-Id: Ie028058c759b9511d105a530d7e89b841865e7d6
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
98bee08e0f Implement "address scope create" command
This patch supports creating a new address scope,
with --ip-version,--project,--project-domain
and --share or --no-share options.

Change-Id: I37c73391a41ac239dd72d55dbc0adbebd7701f4a
Partial-Bug: #1566269
2016-05-11 10:08:35 +08:00
Tang Chen
15c9576817 Trivial: Remove unuseful comments for assertRaise() checking
"Missing required args should bail here" is not understandable
and not necessary. The code is obvious enough. And some of the
comments are misused because of code copy. So remove them.

Change-Id: I031395f2c882386c7a708db5cf4eee75393dc639
2016-05-06 19:55:50 +08:00
Tang Chen
f91685f391 Remove unnecessary type conversions in network unit tests
In some tests, when comparing the results data with the
expected ones, many unnecessary type conversions are used.
So remove them to clean up.

Change-Id: I560ca78a3ab5e7b99087bfe1667de500f92c68de
Partial-bug: #1550633
2016-05-06 03:42:27 +00:00
Richard Theis
9f3fa5ee3b Fix network router type display
The OpenStack SDK maps the network "router:external" field to
"is_router_external". However, OSC was using the incorrect
mapping, "router_external".  This caused OSC to display router
type as "Internal" for all networks.

Change-Id: Ifcd1349ab7c5881baee751936d076bf6aa058852
Closes-Bug: #1572228
2016-05-05 15:01:36 -05:00
Jenkins
bf9b0e5ff4 Merge "Fix router set --route option" 2016-05-03 12:54:58 +00:00
Michael McCune
b33ee3daf6 remove assert in favor an if/else
the assert usage in the NonNegativeAction has the potential to allow
unexpected behavior when the python is byte-compiled with optimization
turned on.

Changes
* remove assert in favor of if/else in NonNegativeAction class
* add type specifier to parser arguments for non-negative actions
* correct tests for new int based values

Change-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e
Closes-Bug: #1576375
2016-05-02 15:11:45 -04:00
Inessa Vasilevskaya
08759b853a Fixes BadRequest when no --pool-prefix given
--pool-prefix is made required on subnetpool creation.
Closes-bug: #1536479

Change-Id: I3d183e45e9b96bc08011c36f45ec2b7a9c01b627
2016-04-27 18:38:35 +03:00
Jenkins
a0a29df3e6 Merge "Add new share and default parms to subnet pool cmds" 2016-04-21 17:18:01 +00:00
Brad Behle
48ebc49f20 Add new share and default parms to subnet pool cmds
Add the "share" and "default" parms to subnet pool create command.
Add the "default" and "no-default" parms to subnet pool set command.
Note that "share" can not be modified once subnet pool has been
created, so do not add this to the set command.

Change-Id: I1eecad69527a1cde7fb234669f4aff2be2db491e
Partial-Bug: #1544591
Partial-Bug: #1544586
2016-04-20 20:12:02 -05:00
Tang Chen
09c20b2b5c Fix mutable default arguments in tests
Python’s default arguments are evaluated only once
when the function is defined, not each time the
function is called. This means that if you use a
mutable default argument (like list and dict) and
mutate it, you will and have mutated that object
for all future calls to the function as well.

More details about this wrong usage here:
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments

In unit tests, most FakeXXX classes' methods take
mutable arguments with default values [] or {}.
We should change them to None.

Change-Id: Iea833b66aa1379829511ad5c6d4432b72f3488e2
Closed-bug: #1550320
2016-04-20 11:15:17 +08:00
Jenkins
7f20efc57c Merge "Add provider network options to osc network set" 2016-04-19 16:19:30 +00:00
reedip
aa1495e241 Add provider network options to osc network set
The following patch adds the provider network options
to OSC "network set".

Change-Id: I23b617077eda25d16164172a8e280082750eaf18
Partial-Bug: #1545537
2016-04-19 11:18:13 +09:00
Richard Theis
94c9cd5c66 Add options to security group rule list
Add the following options to the 'os security group rule list'
command:
  --long: Display direction and ethertype for Network v2
  --all-projects: Display information from all projects for Compute v2

Change-Id: If8a1cbd7669cdfa6577d6d2f6fffd9e999a39a82
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-18 14:03:22 -05:00
Richard Theis
a90c824e04 Fix router set --route option
Fix the "--route" option on the "os router set" command. The
option did not properly format the new routes to set which
resulted in a "HttpException: Bad Request" error. In addition,
the output for routes was fixed to improve readability and to
align with the "--route" option on the "os router set" command.

Change-Id: I9c514153ec201e2feae32be6dd281771e3298b9c
Closes-Bug: #1564460
2016-04-18 13:35:38 -05:00
Jenkins
f66f989d83 Merge "Append existing information during port set" 2016-04-15 16:30:48 +00:00
Jenkins
881c836030 Merge "Add external network options to osc network set" 2016-04-15 16:26:44 +00:00
reedip
67f8b898eb Add external network options to osc network set
The following patch adds the options "--external" & "--internal"
and the suboptions to "external": "--default" & "--no-default",
to "osc network set" CLI to provide the user an option to set
a network as an external network or remove the setting.

Change-Id: I3a7f2cb249bc8101cbb01322d7732e913237d6cd
Partial-Bug: #1545537
2016-04-15 00:28:09 +00:00
Jenkins
52a12e743e Merge "Add project options to security group rule create" 2016-04-14 21:45:03 +00:00
Jenkins
ef68f23de3 Merge "Add network options to security group rule create" 2016-04-14 19:55:54 +00:00
Tang Chen
56f9227063 Enhance exception handling for "network delete" command
This patch rework "network delete" command following the
rules in doc/source/command-errors.rst.

In "network delete" command, there are multiple REST API
calls, and we should make as many of them as possible.
And log error for each one, give a better error message.
Also return a non-zero exit code.

Change-Id: I39ae087dd7bd08d049d513abfa6c5cab2bd13b2b
Partial-Bug: #1556719
2016-04-14 13:54:14 +08:00
reedip
c92ac9d911 Append existing information during port set
Existing --fixed-ip and --binding-profile information is
currently overwritten when a user executes 'port set', but
actually that data should be appended.
This patch fixes the issue.

Closes-Bug: #1564453
Change-Id: I62500c10ccbbc68167f24e9d4fa49e85345d82c4
2016-04-14 00:48:09 +00:00
Jenkins
883f8208d3 Merge "Append existing information during subnet set" 2016-04-13 15:51:44 +00:00
Jenkins
1819edf733 Merge "Add --address-scope option "subnet pool create/set"" 2016-04-13 02:06:59 +00:00
Richard Theis
3a4d53a93b Fix prefixes output for subnet pool list
Fixed "os subnet pool list" command to properly disply the
list of subnet pool prefixes in the "Prefixes" column. This
fix is consistent with the "os subnet pool create" and
"os subnet pool show" command output.

Change-Id: I431d85c3b7f5bf8a327500decf3a15063fc5b120
Closes-Bug: #1569480
2016-04-12 12:42:13 -05:00
Richard Theis
a5a9caea2b Add project options to security group rule create
Add the --project and --project-domain options to the
'os security group rule create' command. These options
are for Network v2 only.

Change-Id: Ie3e136be076f0f2c22fbe7048d1d6eaebf5aa655
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 10:05:24 -05:00
Richard Theis
3a3f33b926 Add network options to security group rule create
Add the following network options to the "os security group rule"
command:
  (1) --ingress and --egress
  (2) --ethertype
These options enable egress and IPv6 security group rules for
Network v2.

Change-Id: Ie30b5e95f94e0c087b0ce81e518de72d2dda25ad
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 09:49:21 -05:00
Tang Chen
827be8fb8c Move keys() methods in each resource class to FakeResource
FakeXXX classes in network don't need to fake any method,
except keys(). But keys() can be put in FakeResource since
it just returns all attributes in _info.

This patch moves removes all unnecessary fake methods code,
moves keys() method to FakeResource.

This patch also finds out some missing attributes in
network and router tests.

Change-Id: I799822c8715b9ac4f95b98f8350f196757d79d3e
2016-04-11 18:07:50 +08:00
Jenkins
cb8f757779 Merge "Refactor security group rule list to use SDK" 2016-04-11 03:01:13 +00:00
Tang Chen
b3649a54cd Add --address-scope option "subnet pool create/set"
This patch adds --address-scope option to "subnet pool create/set"
commands, and --no-address-scope option to "subnet pool set"
command to clear the address scope setting.

Change-Id: Ie2c370a50b52574fa6ec268083ad013b7544361e
Partial-Bug: #1544586
Partial-Bug: #1544591
2016-04-09 16:25:50 +08:00
Jenkins
6c73946623 Merge "Add Subnet add/remove support to router" 2016-04-09 04:52:09 +00:00
Jenkins
b70afef9d5 Merge "Add "router remove port" to osc" 2016-04-09 04:43:35 +00:00