Commit graph

133 commits

Author SHA1 Message Date
Sheel Rana
62ec00ff3a i18n support for leftover exception messages in volume
Change-Id: I7be168fc587cb717075095cf6e12db19b0884dda
2016-05-27 17:05:10 +05:30
Sheel Rana
53e05e7c2d i18n support for help and error messages in cinder
Change-Id: I98fbc959034fe0530966291643b381855801de20
2016-05-23 18:04:36 +00:00
Jenkins
7a0845ec11 Merge "Add support of setting snapshot state" 2016-05-18 16:49:07 +00:00
Jenkins
941217a5f3 Merge "Support for volume service list" 2016-04-28 16:13:46 +00:00
Sheel Rana
4072554608 Support for volume service list
OSC does not support to list volume services.
This patch will provide support for adding volume service related
support.

Closes-bug:#1550999

Implements: bp cinder-command-support

Change-Id: I50ac14aeb96c4b8ddbf7b33e519feea0d126f752
2016-04-25 17:42:12 +00:00
Sheel Rana
92950b6f5f Add support for removing volume-type-access
OSC does not support to remove volume type access to project.
This feature will provide support to remove volume type access
from project.

Closes-Bug:#1554890

Implements: bp cinder-command-support

Change-Id: I029a4292da05f028e8937962cb845ec6e00b0279
2016-04-16 23:01:19 +05:30
Jenkins
5b18e110a9 Merge "use correct manager for volume snapshots" 2016-04-14 13:54:20 +00:00
Tang Chen
46decfbd7a Trivial: Fix incorrect comment text
Change-Id: Ia6ec15f11a535a8de5769569d75e81094caed171
2016-04-14 17:21:53 +08:00
Jenkins
be6027e09b Merge "Doc: Unify repeatable option comments" 2016-04-13 21:22:50 +00:00
Jenkins
85c47b76fb Merge "Add support for setting volume-type-access" 2016-04-12 22:27:07 +00:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
Sheel Rana
be2d2a1b8d Add support for setting volume-type-access
OSC does not support to set volume type access to project.
This patch will provide support for adding volume type access
to existing project.

Closes-Bug:#1554889

Implements: bp cinder-command-support

Change-Id: Ie36e202bdde7de36eb263a476eb66699d82f7565
2016-04-11 12:53:15 +00:00
Steve Martinelli
f3f8c20a8c use correct manager for volume snapshots
the snapshot manager is volume_snapshots, not snapshots.

Closes-Bug: #1567895
Change-Id: I12c0238fc04507c97e92089fda3bec816171a973
2016-04-08 10:36:54 -04:00
Jenkins
418793edbe Merge "Make snapshot and backup name optional" 2016-04-07 16:20:49 +00:00
Ivan Kolodyazhny
311e775c81 Make snapshot and backup name optional
Cinder does not require snapshot and backup name. These arguments are
optional.

Change-Id: I05d59efc9642205a25684bf0b77758328296d959
2016-04-06 23:25:38 +03:00
Jenkins
8233b923f1 Merge "Docs cleanup: volume type" 2016-03-29 13:22:10 +00:00
Dean Troyer
a3a2a7e9f0 Docs cleanup: volume command help
This formats the volume command help text consistent with the rest of OSC,
adds some reference targets and some explanation text to some commands.

No functional changes have been made, only cosmetic/help output.

Change-Id: Ib86ec3ca58bdea5f33078ced3ec3583b2be0e89a
2016-03-28 18:25:58 -05:00
Dean Troyer
b4402a0468 Docs cleanup: volume type
Clean up volume type command help, add volume type show to doc, sort
command classes in v1/volume_type.py.

Change-Id: I1f8e5c047d9c08f5704fc23cfb694f23d32e3caf
2016-03-28 14:33:24 -05:00
root
9bafea555d Add support for deleting Image-property
OSC does not support to delete volume's image property.
This patch will provide support for deleting image property
to existing volume.

Closes-Bug:#1554879
Change-Id: I9256913948fae9e9a03fed173b826dfa918f78e9
Implements: bp cinder-command-support
2016-03-16 10:22:00 -04:00
root
4d5c5d9dcb Add support for setting Image-property
OSC does not support to set volume's image property.
This patch will provide support for adding image property
to existing volume.

Closes-Bug:#1554877

Implements: bp cinder-command-support

Change-Id: I4ff5532c228f010789b81c7587dd4a2838a90f20
2016-03-16 14:17:34 +00:00
Xi Yang
189e4774f8 Add support of setting snapshot state
This patch is going to add the functionality of
setting snapshot state which OSC currently lacks.

Closes-Bug:#1535239
Change-Id: I2afd6567416e75ba0c70b73351cf1eb5394b3373
2016-03-09 00:13:55 +08:00
Brandon Palm
f49f0fead2 Fixed a bunch of spacing
Nothing too complicated here.  I fixed a bunch of spacing issues
that I saw in OSC.

Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
2016-02-23 10:38:58 -06:00
Tang Chen
acc0297fa6 Add functional tests for "volume" commands v2
The tests for v2 "volume" commands are quite similar to v1.

This patch also map 'metadata' to 'properties', 'volume_type' to 'type'
to align to the v1 output.

Change-Id: Icf2c5463b186fc78c890ccd96453090c4a2c2eb6
Partial-bug: #1519503
2016-02-21 09:10:15 +08:00
Akihiro Motoki
258c1102cc log take_action parameters in a single place
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
2016-02-02 09:58:32 +09:00
Tang Chen
f552302b61 Trivial: Remove useless return from files in image and volume
Change-Id: I3526ecd202d0908d91305a066ad72d03cee794b5
2015-12-18 23:25:05 +08:00
Jenkins
74283637ce Merge "Fix exception when doing volume set operation" 2015-12-03 16:15:56 +00:00
Xi Yang
197d86dffa Fix exception when doing volume set operation
The v2 SetVolume extends from show.ShowOne and returns None
after setting volume operation. It will raise an exception.
This patch is going to fix the issue by changing the parent
class of SetVolume to command.Command.

Change-Id: Iefa453fe4adad06f2a0601a052c01e74004be5b7
Closes-bug: 1521896
2015-12-03 15:25:12 +08:00
Jean-Philippe Evrard
9168373b3d Consistency of the --all argument for snapshots
This change is inspired by the volume.py.
It allow the user to use openstack snapshot list --all.

Closes-Bug: #1517386

Change-Id: I72a53fcd0c5c5af539cd88b37e71b4331fa67473
2015-11-30 12:54:19 +00:00
Jenkins
12cc6347e5 Merge "Use is_public to set access of volume type" 2015-11-30 10:39:16 +00:00
xiexs
c27f9e3c6c Fix a bug of "openstack volume delete"
While multi volumes specified for the osc "openstack volume delete",
only the last volume is deleted.
This patch tries to fix it.

Change-Id: I171b2869f85b29c88fda16eaf5bf163c55795df0
Closes-Bug: #1520541
2015-11-27 11:17:22 +00:00
Xi Yang
d1a58653ab Use is_public to set access of volume type
Currently the 'public' and 'private' keys does not work
when creating volume type, 'is_public' should be used.

Change-Id: If34a66053ea6c192882a1b9d8bbb1d3666be3f83
Closes-bug: 1520115
2015-11-26 16:30:05 +08:00
Tang Chen
ed82312bcb Trivial: Fix wrong param name in comment.
"volume" should be "attachments".

Change-Id: Id1e9a733e18db595d8981b5b3a7735313a346787
2015-11-13 11:44:14 +08:00
Tang Chen
c396b69d37 Trivial: Fix wrong param name in comment.
"volume" should be "attachments".

Change-Id: I41c797f0c7cccb2727e9e6cd6424ea2f740624b7
2015-11-12 17:02:24 +08:00
xiexs
176735f4aa Change method to get the user_id
Instead of "find_project", using "find_user" to get the user_id
while the option --user is specified for "openstack volume list"

Change-Id: Iea8472b7b8e709a8792a56575e00003a9cbdaa39
Closes-Bug: #1514145
2015-11-08 03:57:23 +00:00
Dean Troyer
195a0edeb7 Follow-on for volume list - add tests, clean help
* Add volume list tests for v1 (a copy of the v2 tests)
* Converts volume v2 tests to use Identity v3 so domains can be tested
* Add volume list (v2) tests for new options
* Re-orders volume list options (both v1 and v2) to match
* MArks the new volume list (v2) options as v2-only in doc

Change-Id: I2181b2c48cfde2147d7d0ef135322df8a81e7ce8
2015-10-16 16:08:27 -05:00
kafka
9f51ccdf8c Add filtering by project/user for 'openstack volume list'
added project, user and domain options for filtering results,
also cleaned up the order to match the docs.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closed-bug: #1483976
Change-Id: I9d955094d31d4a28e215d24f7521a11c62bee8db
2015-10-15 15:51:01 -04:00
Atsushi SAKAI
a2786fa88b Add one parenthesis
In the following help message, last parenthesis is missing.

 $ openstack --os-volume-api-version 2 help volume delete
usage: openstack volume delete [-h] [--force] <volume> [<volume> ...]

Delete volume(s)

positional arguments:
  <volume>    Volume(s) to delete (name or ID)

optional arguments:
  -h, --help  show this help message and exit
  --force     Attempt forced removal of volume(s), regardless of state
              (defaults to False

Change-Id: I45c4030abf076cba14450019c379d333eb6530d6
2015-10-02 11:56:22 +09:00
Jenkins
0daa096939 Merge "Use a common decorator to log 'take_action' activation" 2015-09-11 02:43:54 +00:00
Joshua Harlow
e3c46ece4a Use a common decorator to log 'take_action' activation
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
2015-09-01 16:49:54 -07:00
TerryHowe
14a714f2a2 Volume v2 list does not show server name
The volume v2 list was using the volume id rather than
the server id.

Change-Id: Ibe03d34b5b503af2d00202dabd640f796449cf9a
Closes-Bug: #1489954
2015-08-28 11:11:37 -06:00
Steve Martinelli
f14251669f default OS_VOLUME_API_VERSION to v2
Cinder is trying to deprecate/remove support for v1, so we should,
as a client library default to v2 and keep support for v1.

Related-Bug: 1467589

Change-Id: I732448a57fc3fd06a8d82ec0f0d2ace671036ca2
2015-08-24 10:38:43 -05:00
Jenkins
35833c94ef Merge "Add set feature to volume type v2" 2015-08-07 05:00:18 +00:00
heha
429ceef0c6 Add set feature to volume type v2
"volume type set" and "volume type unset" is not in the v2.

Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>

implements bp: volume-v2

Change-Id: Ia804787d76d2029726c030b43c61eac3b411f66a
2015-08-06 19:35:01 -07:00
heha
dc6fe04895 Add list feature to volume v2
"volume list" is not in the v2.

Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>

implements bp: volume-v2

Change-Id: I9f4585202f5f9ec5f4c091278fc6c4036efb1290
2015-08-06 17:02:46 -07:00
Jenkins
cc6c4e5c39 Merge "Add support for volume v2 commands" 2015-07-25 03:25:57 +00:00
Amey Bhide
96afb8b1b7 Add support for volume v2 commands
Adds the following commands:
openstack volume create
openstack volume set
openstack volume unset

Implements: blueprint volume-v2
Change-Id: Icb7404815763aa88550112fb42f5200ce05c2486
2015-07-24 13:16:38 -07:00
Jenkins
55d9eba093 Merge "Do not set default versions in parsed args" 2015-07-24 19:51:30 +00:00
Jenkins
26ea98b30e Merge "Add create and list for volume type v2" 2015-07-20 22:28:10 +00:00
Jenkins
7442c018d2 Merge "Format volume type properties when showing" 2015-07-20 21:03:29 +00:00
chengkunye
659abf4928 Add create and list for volume type v2
Volume API v2 is missing create and list features.

implements bp: volume-v2

Change-Id: I34a1ae440e9620b1c65546f4f43b369c8661250d
2015-07-20 12:59:57 -07:00