Commit graph

55 commits

Author SHA1 Message Date
jeckxie
74360e00f5 [TrivialFix] Fix typo error
Change-Id: Iaba9ba22de044b34b4b77f81bcdccda13af81405
2016-12-14 14:39:24 +08:00
Jenkins
b8f976871a Merge "Add "dns-name" option to "os port create" and "os port set"" 2016-12-08 17:37:38 +00:00
judy-yu
83675e9ee0 Avoid duplicated project_id when show network resources
Project_id appear twice when show network resources. This
patch check and not append if it already has one.

Change-Id: I744988f3f52d4a744e397a6a82fefdc4c17eacbf
Closes-Bug: #1636123
Partially-Implements: blueprint duplicated-project-id
2016-12-04 18:03:33 +08:00
Nam Nguyen Hoai
df5f12b135 Add "dns-name" option to "os port create" and "os port set"
This patch added a "dns-name" option to
"os port create" and "os port set" command.

Change-Id: I360e2c9a1970e64fe17e4561d7618f860b937373
Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2016-12-03 17:08:17 +07:00
Jenkins
9b19a35bb7 Merge "Add --enable/disable-port-security option to port set and port create" 2016-12-02 05:28:21 +00:00
Sindhu Devale
246f60ab13 Add --enable/disable-port-security option to port set and port create
This patch adds the currently missing options
`--enable-port-security` and `--disable-port-security`
in the `os port set` and `os port create` commands.

Partially-Implements: blueprint network-commands-options

Change-Id: I4dc11cdf32bf482a5937f5464fe8a3b418644ec3
2016-11-28 16:33:34 -06:00
Steve Martinelli
0ef8535036 translate all command help strings
Leverage the new cliff command class attribute (_description)
to get the help of a command, this allows us to mark strings
for translation. We could not do this before since the help
was grabbed from the docstring.

This also depends on a new release of cliff and a bump to the
minimum level in osc's requirements.

Closes-Bug: 1636209
Depends-On: Id915f6aa7d95a0ff3dc6e2ceaac5decb3f3bf0da
Change-Id: I8673080bb5625e8e3c499feaefd42dfc7121e96f
2016-11-17 02:33:42 +00:00
Jenkins
85f2afdad0 Merge "Add description field port create & port set" 2016-11-10 18:10:27 +00:00
Yan Xing'an
a1e3056414 Add option to allow filtering by mac-address on port list
Added support to allow filtering ports via --mac-address
option to the port list command.

Change-Id: I903e443f2f9057571d46520c4cafb88d1972c0cb
Partial-bug: #1634333
Partially-Implements: blueprint network-commands-options
2016-10-19 02:50:47 -07:00
Aradhana Singh
c99ec284db Add description field port create & port set
This patchset
1. adds description field to openstack port create and
 openstack port set.
2. updates method _add_updatable_args with 4 spaces instead
 of existing 8 spaces

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: I4598e555722b1de7bc47f3a9be0fd81eacfcb572
2016-10-17 22:21:34 +00:00
Jenkins
ab9cfc4dc4 Merge "Add security groups options to "port create/set/unset"" 2016-10-17 08:27:58 +00:00
Nam Nguyen Hoai
2c1282cecf Add a new column and a new option the 'os port list' cmd
This patch will add a new column called status to the
result of the 'os port list' command and --long option
to 'os port list' command.

Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I4f942414e969687304b578ed7f003dd219c0f2f8
Closes-Bug: #1613995
Closes-Bug: #1614321
Partially-Implements: blueprint network-commands-options
2016-10-12 20:40:46 +00:00
Nguyen Phuong An
66a04abd58 Add security groups options to "port create/set/unset"
This patch adds '--security-group' and '--no-security-group'
options to "port create", "port set" and "port unset" commands.

Change-Id: Iff60d8f29227017b0a3966efca6cdecba69abcea
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2016-10-12 09:03:07 +07:00
Jenkins
1fc41f3837 Merge "Introduce overwrite functionality in `osc port set`" 2016-09-23 12:33:06 +00:00
reedip
b38be94a5d Introduce overwrite functionality in `osc port set`
The overwrite functionality allows user to overwrite
either the binding-profile or the fixed-ips of a
specific port.

Change-Id: I8ec3d04eeaf28972ee545fcdda4d5f7bd9deb915
partially-implements: blueprint allow-overwrite-set-options
2016-09-21 04:19:28 +00:00
Reedip
554607eb3d Provide support to list ports by network
The new --network option provides a list of ports
connected with the current network.

Change-Id: I6a45184887b3e65f792391cb7e91f4ad85f29e03
Partial-Bug:#1562067
Partially-Implements: blueprint network-commands-options
2016-09-19 09:25:10 +00:00
Rui Chen
96a8ed435c Support listing specified server's ports
Add new option "--server" for "port list" command to
list all of the ports that are attached on the specified
server.

Change-Id: I8b5550ea5068405b163711303465b704b5207410
Closes-Bug: #1614385
2016-09-14 15:11:56 +08:00
reedip
230d38fb4c Add command to unset information from ports
This patch introduces the ``port unset`` command to
clear the fixed-ip and binding:profile information
from the ports.
Implements: blueprint network-property-unset

Change-Id: I9dba309234105af477e7618a8a437b7fa3b13cd7
2016-07-01 08:40:07 +05:30
Jenkins
4b61efe3f9 Merge "Add "--device-owner" option to "port list"" 2016-06-29 17:28:39 +00:00
Jenkins
5b144334bf Merge "Support JSON data for port binding profile" 2016-06-23 21:31:05 +00:00
Richard Theis
c7fb3b3655 Add "--device-owner" option to "port list"
Add "--device-owner" option to the "port list" command to enable
listing ports based on device owner.

Change-Id: I0a538ec41800b9f842e86dceb6ca4180ef239c95
Implements: blueprint neutron-client
2016-06-20 16:32:20 -05:00
Richard Theis
5cc62d90b0 Support JSON data for port binding profile
Update the "--binding-profile" option on the "port create" and
"port set" commands to support both <key>=<value> and JSON input
for the port custom binding profile data. The JSON input is
sometimes needed to maintain the value type (e.g. integer) for
more advanced data.

The port custom binding profile data is unique across neutron
so a custom argparse.Action class was created instead of
writting a generic class in osc-lib.

Change-Id: I82ac6d4f95afdc866f5282fc00d390f850f54d21
Implements: blueprint neutron-client
2016-06-20 15:42:56 -05:00
Tang Chen
047cb68493 Standardize logger usage
Use file logger for all command specific logs.

This patch also fixes some usage that doesn't
follow rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html

After this patch, all self.log and self.app.log
will be standardized to LOG().

NOTE: In shell.py, we got the log in class OpenStackShell,
      which is also known as self.app.log in other classes.
      This logger is used to record non-command-specific logs.
      So we leave it as-is.

Change-Id: I114f73ee6c7e84593d71e724bc1ad00d343c1896
Implements: blueprint log-usage
2016-06-20 15:16:51 +00:00
Dean Troyer
9e2b8e6730 osc-lib: command
Leave command.py and test_command.py as a sanity check during the
deprecation period.

Change-Id: I24e1b755cbfbcbcaeb5273ec0c9706b82384fc85
2016-06-13 11:00:22 -05:00
Dean Troyer
be192676bd osc-lib: parseractions
Leave parseractions.py and test_parseractions.py as a sanity check during the
deprecation period.

Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83
2016-06-13 10:55:44 -05:00
Dean Troyer
e5e29a8fef osc-lib: utils
Use osc-lib directly for utils.

Leave openstackclient.common.utils for deprecation period.

Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
2016-06-13 10:50:44 -05:00
Dean Troyer
d20c863ebc osc-lib: exceptions
Use osc-lib directly for exceptions.

Leave openstackclient.common.exceptions for deprecation period.

Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828
2016-06-13 10:50:01 -05:00
Jenkins
ada6abb30e Merge "Make set/unset commands in network return normally when nothing specified" 2016-06-09 14:58:17 +00:00
sunyajing
aefd2195b1 Fix network
modify ``columns, data`` to ``(columns, data)`` in network,
to keep code consistence.

Change-Id: I0522c499d1651b4ea948bebccbdfd520934e8e6a
2016-06-08 17:08:36 +08:00
Tang Chen
e3270cdfd8 Make set/unset commands in network return normally when nothing specified
set/unset commands should ends up normally instead of raising
an exception when nothing is specified to modify. The main
reason is: When nothing is specified, the command sets/unsets
nothing, which is a normal behavior, and ends up normally.
No API call fails. No error happens.

This patch also adds a releasenote for both network, and volume
commands that fix patch has been merged.

Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef
Partial-bug: #1588588
2016-06-08 14:31:17 +08:00
Huanxuan Ao
eb421f6dab Support error handling for "port delete" command
"Port delete" command supported deleting multi ports
before but didn't support error handing, This patch
add the error handling following the rules in
doc/source/command-errors.rst.

Change-Id: I4ea69f2279763626d6a27cad1ca0ee99822d016d
Partially-Implements: blueprint multi-argument-network
2016-06-07 16:00:54 +08:00
Jenkins
35ea7a9baa Merge "remove #noqa from i18n imports" 2016-05-19 09:08:57 +00:00
Tang Chen
40f51c32ac Fix i18n support for help and error msg in network
Change-Id: Iab0dc489226601ac4ff123bb758f84ff16989395
2016-05-16 16:15:46 +08:00
Steve Martinelli
ebcbd6ba71 remove #noqa from i18n imports
hacking checks no longer fail on `import _`

Change-Id: Idd60f0a0e71e5081691eacb39e5091ab08fcce6d
2016-05-13 13:14:02 -07:00
Tang Chen
f995185c10 Trivial: Fix an omited i18n issue
Change-Id: I064ae79d31f96021dfb5d7cd16a3ace9725803f6
2016-04-20 15:21:29 +08:00
Tang Chen
89445855ac State i18() changes and help messages improved
Add _() to wrap help message in network commands.
And also some improvement for help message.

Change-Id: Ib3e498f5976ba98c44fd4eec2d1623263b3db53e
Partial-bug: 1570924
2016-04-18 10:31:01 +08:00
Jenkins
f66f989d83 Merge "Append existing information during port set" 2016-04-15 16:30:48 +00:00
reedip
c92ac9d911 Append existing information during port set
Existing --fixed-ip and --binding-profile information is
currently overwritten when a user executes 'port set', but
actually that data should be appended.
This patch fixes the issue.

Closes-Bug: #1564453
Change-Id: I62500c10ccbbc68167f24e9d4fa49e85345d82c4
2016-04-14 00:48:09 +00:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
reedip
73d15e3768 Add option to clear information from ports
This patch adds the option of "no-fixed-ip" and
"no-binding-profile" which is used to clear the
fixed-ip and binding:profile information from the
ports.

Change-Id: I946301eaf6c647bae55e4f416aa0d98e5f06e699
2016-04-07 10:59:15 +09:00
reedip
66f94dca5c Add name option to 'port set'
Port's name can be updated in NeutronClient and it is a very
good feature for a user to have the ability to rename a port.
This was missing in the openstackclient, and the same has been
added in this patch.

Change-Id: I6e712ef08ab1c0a23786c4bb6972d3e0f8f0f999
Implements: blueprint neutron-client
2016-04-05 01:35:00 +00:00
reedip
c5c15a0135 Follow Boolean Option rule
OSC has a specific rule for handling boolean based options
in  [1]. This patch modifies the exisiting code so that it
matches the criteria that have been specified in [1].

[1]: http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

Closes-Bug: #1559418
Change-Id: I182381d5579efbc75a5d3e8a91f412398abf5c3c
2016-03-31 13:06:45 +09:00
Jenkins
d42bb4f7e2 Merge "Fix options in port create/set" 2016-03-17 22:58:36 +00:00
Dean Troyer
aeef568189 Fix options in port create/set
* --device-id should have been --device
* --host-id should have been --host

Old options are deprecated and retained for compatibility since they
appear in a release.

Closes-Bug: 1558677

Change-Id: Ic733523c8d57060f2cb5d420fdb1f7598e7d5e71
2016-03-17 21:00:26 +00:00
Jenkins
a60e31ad4b Merge "Add option to allow filtering by router on port list" 2016-03-17 06:05:34 +00:00
Jas
62a02466c3 Add option to allow filtering by router on port list
Added support to allow filtering ports via --router
option to list ports that are applicable to specific router.

Partial-bug: #1519909
Partially-implements: blueprint neutron-client

Change-Id: I6dd958603909f641735c821a62fc0d45afd5c7ec
2016-03-16 13:20:40 -05:00
Tang Chen
dc7e4fc15d Fix dict.keys() compatibility for python 3
In Python 2, dict.keys() will return a list.
But in Python 3, it will return an iterator.
So we need to fix all the places that assuming
dict.keys() is a list.

Change-Id: I8d1cc536377b3e5c644cfaa0892e40d0bd7c11b1
Closes-Bug: #1556350
2016-03-12 10:58:28 +08:00
Jas
e0d58641bb Add 'port set' command
Add CLI support for the 'port set' command

Change-Id: I2bea508e11290284aa64b1ab548a0bb61e7290d3
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-08 09:48:50 -06:00
Jas
d548942645 Add port list command
This patch adds the ability to list all created ports

Change-Id: Ie1a48c203cabc96346a4950f21b83493d58a66a5
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-07 11:17:31 -06:00
Jas
d1d4a40808 Add 'port create' command
This patch adds usage of 'port create' in CLI

Change-Id: I888af50784c3b6c7ec30552ade79f05a5e974711
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-04 10:41:26 -06:00