Commit graph

1628 commits

Author SHA1 Message Date
Tang Chen
df3ee61be3 Remove methods argument from FakeHypervisorStats
methods argument is not necessary in FakeHypervisorStats class.
Remove it.

Change-Id: I288f71b412beb3e583e957a9fd99210bc6f3f543
2016-04-15 16:10:09 +08:00
Jenkins
52a12e743e Merge "Add project options to security group rule create" 2016-04-14 21:45:03 +00:00
Jenkins
ef68f23de3 Merge "Add network options to security group rule create" 2016-04-14 19:55:54 +00:00
Jenkins
83fbce496a Merge "Remove fake methods code from compute network" 2016-04-14 16:47:00 +00:00
Jenkins
5b18e110a9 Merge "use correct manager for volume snapshots" 2016-04-14 13:54:20 +00:00
Tang Chen
46decfbd7a Trivial: Fix incorrect comment text
Change-Id: Ia6ec15f11a535a8de5769569d75e81094caed171
2016-04-14 17:21:53 +08:00
Jenkins
be6027e09b Merge "Doc: Unify repeatable option comments" 2016-04-13 21:22:50 +00:00
Jenkins
883f8208d3 Merge "Append existing information during subnet set" 2016-04-13 15:51:44 +00:00
Jenkins
7b7620ab84 Merge "Fix SSL/TLS verification for network commands" 2016-04-13 08:31:37 +00:00
Jenkins
1819edf733 Merge "Add --address-scope option "subnet pool create/set"" 2016-04-13 02:06:59 +00:00
Jenkins
85c47b76fb Merge "Add support for setting volume-type-access" 2016-04-12 22:27:07 +00:00
Richard Theis
3a4d53a93b Fix prefixes output for subnet pool list
Fixed "os subnet pool list" command to properly disply the
list of subnet pool prefixes in the "Prefixes" column. This
fix is consistent with the "os subnet pool create" and
"os subnet pool show" command output.

Change-Id: I431d85c3b7f5bf8a327500decf3a15063fc5b120
Closes-Bug: #1569480
2016-04-12 12:42:13 -05:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
Tang Chen
a281ef89a5 Remove fake methods code from compute network
Network objects don't have any method needs to fake.

keys() method is only used by _get_columns() helper
to obtain all attributes of an object. But in compute
network implementation, attributes are obtained from
obj._info directly, which is a dictionary itself. So
there is no need to fake this method.

Change-Id: Ie6a46ef6a3042641e55a7002573ef501db7b60e1
2016-04-12 13:41:52 +08:00
Jenkins
3be49a8abe Merge "Move keys() methods in each resource class to FakeResource" 2016-04-11 15:07:34 +00:00
Richard Theis
a5a9caea2b Add project options to security group rule create
Add the --project and --project-domain options to the
'os security group rule create' command. These options
are for Network v2 only.

Change-Id: Ie3e136be076f0f2c22fbe7048d1d6eaebf5aa655
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 10:05:24 -05:00
Richard Theis
3a3f33b926 Add network options to security group rule create
Add the following network options to the "os security group rule"
command:
  (1) --ingress and --egress
  (2) --ethertype
These options enable egress and IPv6 security group rules for
Network v2.

Change-Id: Ie30b5e95f94e0c087b0ce81e518de72d2dda25ad
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 09:49:21 -05:00
Jenkins
cba37d0031 Merge "Doc: Fix network command documentation issues" 2016-04-11 13:17:12 +00:00
Sheel Rana
be2d2a1b8d Add support for setting volume-type-access
OSC does not support to set volume type access to project.
This patch will provide support for adding volume type access
to existing project.

Closes-Bug:#1554889

Implements: bp cinder-command-support

Change-Id: Ie36e202bdde7de36eb263a476eb66699d82f7565
2016-04-11 12:53:15 +00:00
Tang Chen
827be8fb8c Move keys() methods in each resource class to FakeResource
FakeXXX classes in network don't need to fake any method,
except keys(). But keys() can be put in FakeResource since
it just returns all attributes in _info.

This patch moves removes all unnecessary fake methods code,
moves keys() method to FakeResource.

This patch also finds out some missing attributes in
network and router tests.

Change-Id: I799822c8715b9ac4f95b98f8350f196757d79d3e
2016-04-11 18:07:50 +08:00
Jenkins
cb8f757779 Merge "Refactor security group rule list to use SDK" 2016-04-11 03:01:13 +00:00
Tang Chen
b3649a54cd Add --address-scope option "subnet pool create/set"
This patch adds --address-scope option to "subnet pool create/set"
commands, and --no-address-scope option to "subnet pool set"
command to clear the address scope setting.

Change-Id: Ie2c370a50b52574fa6ec268083ad013b7544361e
Partial-Bug: #1544586
Partial-Bug: #1544591
2016-04-09 16:25:50 +08:00
Jenkins
6c73946623 Merge "Add Subnet add/remove support to router" 2016-04-09 04:52:09 +00:00
Jenkins
b70afef9d5 Merge "Add "router remove port" to osc" 2016-04-09 04:43:35 +00:00
Dean Troyer
0ea80a92f0 Fix pep8 fail that crept in
Not sure how, but this crept in via https://review.openstack.org/#/c/281691/

Change-Id: I919276ee5204277dbc5e96f4de4b98381142423a
2016-04-08 19:33:15 -05:00
Jenkins
5d2f4107b4 Merge "Add "router add port" to osc" 2016-04-08 18:24:46 +00:00
Steve Martinelli
f3f8c20a8c use correct manager for volume snapshots
the snapshot manager is volume_snapshots, not snapshots.

Closes-Bug: #1567895
Change-Id: I12c0238fc04507c97e92089fda3bec816171a973
2016-04-08 10:36:54 -04:00
Richard Theis
b5f10f43eb Fix SSL/TLS verification for network commands
The network commands ignored the --insecure and --os-cacert
options and OS_CACERT environment variable which prevented
them from properly completing SSL/TLS verification. This
resulted in the network commands failing with
"An SSL error occurred."

Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1
Closes-Bug: #1560157
2016-04-08 09:33:33 -05:00
Richard Theis
6b76860c45 Doc: Fix network command documentation issues
Fix the following network command documentation issues:
  - Fix format of subnet pool positional arguments
  - Update port set options to match help
  - Fix network command documentation for Network v2
    versus Compute v2 options and commands
  - Fix subnet command documentation errors and formatting
    problems in help text

Change-Id: I808c2a70ca62eafc9e42d6873539cdd142ffe50c
Related-Bug: #1558677
2016-04-08 08:00:17 -05:00
reedip
03d932ea0b Append existing information during subnet set
Existing values of --dns-nameserver, --allocation-pool and --houst-routes
is currently overwritten when a user executes 'port set', but
actually that data should be appended.
This patch fixes the issue.

Closes-Bug: #1564447
Change-Id: I3dba9afa68d869abb3960b55a6880401a10eebf7
2016-04-08 06:19:09 +00:00
Jenkins
9f2e7039e1 Merge "TrivialFix: Rename provider segment option" 2016-04-08 04:23:22 +00:00
reedip
a8c085fdd5 TrivialFix: Rename provider segment option
As per [1], provider-segmentation-id is changed to provider-segment
as segments may soon have a "name" support as well.

[1]: https://review.openstack.org/#/c/294422/12/doc/source/command-objects/network.rst

Change-Id: I74d4366301b41fa181faccbc12cff9530df60353
2016-04-08 01:46:06 +00:00
Jenkins
418793edbe Merge "Make snapshot and backup name optional" 2016-04-07 16:20:49 +00:00
reedip
73d15e3768 Add option to clear information from ports
This patch adds the option of "no-fixed-ip" and
"no-binding-profile" which is used to clear the
fixed-ip and binding:profile information from the
ports.

Change-Id: I946301eaf6c647bae55e4f416aa0d98e5f06e699
2016-04-07 10:59:15 +09:00
Jenkins
0edab95fd1 Merge "Support client certificate/key" 2016-04-06 21:42:56 +00:00
Ivan Kolodyazhny
311e775c81 Make snapshot and backup name optional
Cinder does not require snapshot and backup name. These arguments are
optional.

Change-Id: I05d59efc9642205a25684bf0b77758328296d959
2016-04-06 23:25:38 +03:00
Jenkins
bd7e1d3a3e Merge "Add provider network options to osc network create" 2016-04-06 19:23:45 +00:00
Jenkins
60a91a6572 Merge "Add external network options to osc network create" 2016-04-06 19:20:56 +00:00
Jenkins
523ab58fb6 Merge "Log hint when --enable present with --disable-reason" 2016-04-06 18:46:14 +00:00
Cedric Brandily
3a8320a1d7 Support client certificate/key
This change enables to specify a client certificate/key with:
 * usual CLI options (--os-cert/--os-key)
 * usual environment variables ($OS_CERT/$OS_KEY)
 * os-client-config

Change-Id: Ibeaaa5897ae37b37c1e91f3e47076e4e8e4a8ded
Closes-Bug: #1565112
2016-04-06 20:21:19 +02:00
reedip
1b351e1695 Add provider network options to osc network create
The following patch adds the provider network options
to OSC "network create".

Change-Id: Ib8449c00ee4b4285889588f03ddd7a686ce8f987
Partial-Bug: #1545537
2016-04-06 16:52:47 +00:00
reedip
107bc5164f Add external network options to osc network create
The following patch adds the options "--external" & "--internal"
and the suboptions to "external": "--default" & "--no-default",
to "osc network create" CLI to provide the user an option to create
a network as an external network.

Change-Id: Idf73714bb94c0610ea164131140a51848908b00b
Partial-Bug: #1545537
2016-04-06 16:01:24 +00:00
Jenkins
492aa74fed Merge "Use fixtures and addCleanup instead of tearDown" 2016-04-06 14:05:18 +00:00
Jenkins
05495d508c Merge "Fix typos in docstrings and comments" 2016-04-06 06:07:35 +00:00
Jenkins
b1b5a2acdd Merge "Add name option to 'port set'" 2016-04-06 06:02:06 +00:00
Dao Cong Tien
67a8947ea2 Fix typos in docstrings and comments
Change-Id: Ic2dc057dca87212f715970f8325956c42f62ea9f
2016-04-06 10:30:39 +07:00
Cedric Brandily
bad21594be Use fixtures and addCleanup instead of tearDown
Nothing ensures tearDown call as tearDown is called only if test
succeeds. This change replaces tearDown use with:

* addCleanup use to stop mocks
* EnvFixture which ensures to unmock environment thanks to useFixture.

Change-Id: I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc
2016-04-05 17:57:55 +02:00
Rui Chen
4d3f996e7c Log hint when --enable present with --disable-reason
--enable and --disable-reason should be mutually exclusive in "compute
service set" command, but now when they are present at the same time,
--disable-reason would be ignored silently. Fix these and add some hints
about --disable-reason argument is ignored in this situation.

Change-Id: I43254b6bc40fcae4fd0dc3457f26fad84c267072
Closes-Bug: #1556801
2016-04-05 21:22:27 +08:00
Tang Chen
c3f6ee9570 Trivial: Rename FakehypervisorStats to FakeHypervisorStats
Change-Id: I138b1b8a3327947b8cd032d8d0c32d98548ce2ad
2016-04-05 19:43:33 +08:00
reedip
66f94dca5c Add name option to 'port set'
Port's name can be updated in NeutronClient and it is a very
good feature for a user to have the ability to rename a port.
This was missing in the openstackclient, and the same has been
added in this patch.

Change-Id: I6e712ef08ab1c0a23786c4bb6972d3e0f8f0f999
Implements: blueprint neutron-client
2016-04-05 01:35:00 +00:00