Commit graph

2838 commits

Author SHA1 Message Date
Jenkins
e22fc1fb6b Merge "Use instance variables for subnet tests" 2017-07-27 17:35:22 +00:00
Gary Kotton
1134249a5e Use instance variables for subnet tests
Commit 78a832441a let to random
failures of test_create_with_tags. This addresses that issue.

Change-Id: I470da7a1863a8c22257b1c27bc6d2b1c45c9cca3
2017-07-26 23:54:35 -07:00
Dean Troyer
022fdb10eb Skip object-store functional tests when Swift is not available
Specifically, in the py3 jobs Swift is not (yet) properly starting as
a py2 service, so we disabled swift in those OSC jobs and need to
skip the object-store functional tests in that case.

Change-Id: I073551c41b7636f04b3ee97dc6fe69630e207b67
2017-07-26 19:17:46 -05:00
Jenkins
86bda36963 Merge "Use *_as_ids instead *_as_list" 2017-07-26 03:58:57 +00:00
Jenkins
f67ebce530 Merge "wrong values in openstack quota show command" 2017-07-25 17:41:46 +00:00
Jenkins
80a9779601 Merge "Add optional parameter "user_id" and "type" to list credentials" 2017-07-25 17:41:39 +00:00
zhanghongtao
470a1f1acf Add optional parameter "user_id" and "type" to list credentials
In keystone version 3.5, "type" optional attribute has been added
to list credentials. This patch add "user_id" and "type" optional
parameter in openstack client.

Change-Id: Ia09ee7c39204fdff2dfd7b9b606d888d007caac5
2017-07-25 09:56:50 -05:00
Akihiro Motoki
78a832441a network tag UT: avoid using mix-in test class
This is a follow-up patch on https://review.openstack.org/#/c/461195/
There is a suggestion to keep test code more straight-forward
and avoid using mix-in to reduce the code complexity.
This commit moves all logic implemented in _test_tag.py
into individual network tests.

Change-Id: I0a9f8c6cd758db9035b0fd60ce4b9bfc791b6cbd
2017-07-25 09:22:29 +00:00
nidhimittalhada
925776565e wrong values in openstack quota show command
"openstack quota show" shows wrong value in field project
and project_id. project UUID is shown in field project.
and project is coming as None.

Corrected it.

Change-Id: I237e49858feab14ec5e5bc6d8cb79c9f6f5ea9c0
Closes-Bug: #1679906
2017-07-24 11:28:28 +05:30
Akihiro Motoki
57e5840710 Network tag support
Neutron tag mechanism now supports network, subnet, port,
subnetpool and router. Tag support for more resources is planned.

This commit introduces a common mixin class to implement
tag operation and individual resource consumes it.

To support tag remove, network unset command is added.

Implements blueprint neutron-client-tag
Change-Id: Iad59d052f46896d27d73c22d6d4bb3df889f2352
2017-07-23 21:54:32 +00:00
Jenkins
e0d7119c6d Merge "Start using 'cliff.sphinxext'" 2017-07-21 21:46:10 +00:00
Kristi Nikolla
77ff011ced Add domain parameter to Identity Provider
Identity providers are now associated with domains. This change
allows a user to specify a domain by ID or by name when creating
an identity provider. [0]

This also adds the column for Domain ID in listing.
Updating a domain for an identity provider is not supported, so
that isn't changed.

[0]. Id18b8b2fe853b97631bc990df8188ed64a6e1275

Closes-Bug: 1698390

Change-Id: Icc408e2fe88f257d5863bd3df716a777d52befcc
2017-07-21 11:28:57 -04:00
Stephen Finucane
9cfa12df2a Start using 'cliff.sphinxext'
'cliff', the command line library used by 'osc_lib' (and, thus,
'python-openstackclient') recently gained a Sphinx extension to
automatically document cliff commands. This allows us to use the
documentation we already have in code instead of duplicating it in the
documentation.

Introduce the use of this, starting with the 'server' commands. This
requires extending the descriptions for two commands to ensure no
information is lost.

Change-Id: If701af8d5a3f78f4b173ceb476dd0c163be4b6ca
2017-07-21 14:48:44 +00:00
Jenkins
d04a7cf92a Merge "Clean up the changes of os.environ in functional tests" 2017-07-21 00:10:54 +00:00
Jenkins
57e7d9fdb3 Merge "Now OSC server create check keys in --nic" 2017-07-20 18:43:18 +00:00
Jenkins
813e49db93 Merge "Enable some off-by-default checks" 2017-07-20 18:08:32 +00:00
Jenkins
e954fe4eed Merge "Add support for virtio-forwarder VNIC type" 2017-07-20 17:15:53 +00:00
Rui Chen
f1d32dbe9b Clean up the changes of os.environ in functional tests
Use fixtures to restore the API version changes of os.environ
in each functional tests, aims to avoid the following test cases
failing in unexpected context.

And make sure setUpClass/tearDownClass call super class's
corresponding methods first.

Change-Id: Ie248fe9d3a9e25f1b076c9f2c363200f29a83817
Closes-Bug: #1696080
2017-07-20 16:39:32 +00:00
Jenkins
ac8cac4b63 Merge "Network L3 Router Commands for OSC" 2017-07-20 16:35:14 +00:00
Jenkins
39673217dc Merge "Fix 'domain' filter not work well in some commands" 2017-07-20 06:16:09 +00:00
Jenkins
b9daff23b9 Merge "Fix column names for server list --no-name-lookup" 2017-07-20 05:17:53 +00:00
Jenkins
6f2d6063ff Merge "Fix dynamic names in network functional tests" 2017-07-20 05:15:03 +00:00
Jenkins
4493740171 Merge "Add server list -n and --no-name-lookup arguments" 2017-07-20 03:43:15 +00:00
Dean Troyer
8d7ee8da0e Fix dynamic names in network functional tests
Move all of the dynamic resource naming in Network functional tests into
setUpClass() methods (if they exist) rather than assigning those names
at load-time.

Change-Id: Ic550ff7d40c2b3ca5128cacccbe331790d6ae340
2017-07-19 16:33:54 -05:00
Jan Gutter
cf5dfa77e1 Add support for virtio-forwarder VNIC type
* This patch adds support for the virtio-forwarder VNIC type.
  * The virtio-forwarder VNIC type has been added as another option for
    setting the --vnic-type property on the "port set" and
    "port create" commands. This requests a low-latency virtio port inside
    the instance, likely backed by hardware acceleration. Currently the
    Agilio OVS external plugin provides support for this, with support from
    other vendors following soon.
  * Corresponding neutron-lib change:
    https://review.openstack.org/#/c/483530/
  * Nova spec for Agilio OVS enablement:
    https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/netronome-smartnic-enablement.html

Change-Id: Idbc8071afe95f8594b40e2f93e5411e7185f946f
Signed-off-by: Jan Gutter <jan.gutter@netronome.com>
2017-07-19 14:41:04 +02:00
jiangpch
a01bf55d20 Fix 'domain' filter not work well in some commands
The 'domain' filter not work well in commands 'project show',
'user show' and 'user set'.

Depends-On: I490900d6249f01654d4cba43bddd3e7af7928a84
Closes-Bug: #1704097
Change-Id: Ib4f47cbaba27eb56c4a41d187fee74a995e62dc7
2017-07-18 23:01:22 +00:00
Dean Troyer
2689984ba7 Fix column names for server list --no-name-lookup
When --long is not present change the 'Image Name' column to
'Image' and add the 'Flavor' column.  These columns will contain
Names unless --no-name-lookup is specified when they will contain IDs.

Change-Id: I92cfb22136aee32616894e60e9227b4da185da99
2017-07-17 16:51:10 -05:00
Jenkins
894df67c67 Merge "Add 'data_plane_status' option to Port classes" 2017-07-13 02:44:35 +00:00
nidhimittalhada
bca8d57eb3 image-list should support filters 'name','status'
nova api support parameters like 'name', 'server', 'status',
etc in image-list(). So openstackclient should support this too.

DocImpact
Closes-Bug: #1698742
Change-Id: Ice66b409f989e6785aa3b2d42f2fdbf6e23fa0aa
2017-07-12 22:50:17 +00:00
Carlos Goncalves
1ae904a491 Add 'data_plane_status' option to Port classes
Adds 'data_plane_status' option to SetPort and UnsetPort classes.

Closes-Bug: #1684989
Change-Id: I26e23b551afb8c37e6babdea1655efb7c5c6873b
2017-07-12 22:50:09 +00:00
Akihiro Motoki
3cba09e767 Fix unit test failures related to new os-client-config and osc-lib
[breakage related to os-client-config 1.28.0]
os-client-config 1.28.0 add a check if filebased and envvars are
both used. This check causes OSC unit test failure.

OSC now instantiates OpenStackConfig twice as a workaround.
The unit test mocks _load_config_file() and it returns a config dict,
but os-client-config OpenStackConfig.__init__ updates the dict returned.
As a result, when OpenStackConfig is instantiated second time,
the mock of _load_config_file returns a modified version of the config
dict. This hits the new check in os-client-config 1.28.0.

This commit changes the mock to use side_effect rather than return_value
to ensure the original dict is used.

[breakage related to osc-lib 1.7.0]
The change in osc-lib 1.7.0 added "if" logic to avoid calling get() twice.
In tests.unit.volume.test_find_resource, kwargs is empty dict in find_resource(),
so the second call to get() is NOT called now.
Removing the second elements of side_effect addresses the unit failure.

Co-Authored-By: Rui Chen <chenrui.momo@gmail.com>
Change-Id: Ib9d14661b2755bbd6619e15c0d9023fbc9d27d70
Closes-Bug: #1703782
Closes-Bug: #1703783
2017-07-12 12:26:00 +00:00
Ankur Gupta
18c532377a Network L3 Router Commands for OSC
Implements: blueprint network-l3-commands

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: Ia24d76227e164062e89a74c1621b8acb830b26cf
2017-07-11 08:17:09 +00:00
Boris Pavlovic
2c57f7bfb2 Add server list -n and --no-name-lookup arguments
Remove translation of Image ID and Flavor ID to Image and Flavor names

In large environments amount of images can be very large (thousands)
Which requires ~hundreds of requests to Glance to get all images
(by default client request only 20 images)
As a result listing even few servers is going to take minutes

This patch allows to avoid these queries by not doing translation,
which allows one to get information about servers in seconds.

Change-Id: I4ae00e6324a41c4c79bf5b620179dae99aea5431
2017-07-10 16:20:45 -07:00
Jenkins
91cc731187 Merge "Allow objects to be streamed to stdout" 2017-07-06 15:24:31 +00:00
Honza Pokorny
ae35a29169 Allow objects to be streamed to stdout
Change-Id: Icd8de6b2122fe77926d93da9bda08f56c3672a7a
2017-07-05 20:08:18 -03:00
Rodolfo Alonso Hernandez
c17819ab58 Add new parameter "is_default" to Network QoS policy.
Add a set of exclusive parameters to the Network QoS policy:
  --default: makes this policy the default policy for
             the project to which the qos policy belongs.
  --no-default: unset the property.

Closes-Bug: #1639220
Depends-On: If5ff2b00fa828f93aa089e275ddbd1ff542b79d4
Depends-On: Ibe7b7881cb190bfd5582f35b6de51a8bc21135de
Change-Id: I0269b837dc29bbd8ee2089d847cadb72d800fa30
2017-07-05 13:34:33 +00:00
Jenkins
52af8fbc05 Merge "Added 'openstack image set --visibility'" 2017-07-01 00:26:36 +00:00
Jenkins
1cb08a099c Merge "Show neutron tags in OSC network show" 2017-06-30 21:21:37 +00:00
M V P Nitesh
3468ea1ca4 Added 'openstack image set --visibility'
This feature will allow image owners to share images across multiple
tenants/projects without explicitly creating members individually
through the glance API V2. “Community images” will not appear iu
user's default image listings

Change-Id: Ic02bf44cca5d6d793d68a8737d3cfe3f44407d88
Closes-Bug: #1626837
2017-06-30 20:35:01 +00:00
blue55
20c23d8ccb Enable some off-by-default checks
Some of the available checks are disabled by default, like:
[H203] Use assertIs(Not)None to check for None

Change-Id: I59dafb62cedc5217b6e5eb6efb997a9ee3c29bbb
2017-06-23 16:31:48 +08:00
M V P Nitesh
fcafd987b0 Now OSC server create check keys in --nic
Now OSC command to create server will check all the keys in --nic
and throws an exception if the key is invalid key.

Change-Id: I5482da0ae63d6d4298aa614e4d09bb0547da9ec3
Closes-Bug: #1681411
2017-06-23 13:20:43 +05:30
Jenkins
19c8cabeca Merge "When creating a trust, send role_ids instead or role_names" 2017-06-22 19:53:03 +00:00
Jenkins
fe82f4b281 Merge "Add direction field to QoS bandwidth limit." 2017-06-22 19:02:35 +00:00
Jenkins
ef25135e7a Merge "Add project purge command to osc" 2017-06-22 18:10:37 +00:00
Jenkins
244ac70ae9 Merge "Don't show hint about vlan transparent in network set" 2017-06-22 17:10:23 +00:00
Kristi Nikolla
da53c2b334 When creating a trust, send role_ids instead or role_names
This changes create a trust to use ids instead of names because of
the possibility of roles sharing a name. Even if the user
uniquely identified a role by inputting the id, the request sent
to the identity service would used the name, therefore the command
would fail in the case that two roles share a name.

This does not change how trusts are displayed during trust list or
trust show, a name will still be shown instead of an id.

Depends-On: I38e0ac35946ee6e53128babac3ea759a380572e0

Change-Id: I5bdf89f1e288954a7f5c2704231f270bc7d196f5
Closes-Bug: 1696111
2017-06-22 17:08:01 +00:00
Rodolfo Alonso Hernandez
ccb743cf0f Add direction field to QoS bandwidth limit.
This patch enables the direction ('ingress'/'egress') field
on the QoS bandwidth limit rule object and CRUD commands.

Closes-Bug: #1614121
Depends-On: Ia13568879c2b6f80fb190ccafe7e19ca05b0c6a8
Depends-On: I90c412a5c8757b3ffe8abfc1165a70bdb8744702
Change-Id: Ic6981474f22efbf294ac11c2e0304b04494a1bbe
2017-06-22 15:59:37 +00:00
M V P Nitesh
4c2eb2bd8b Show neutron tags in OSC network show
Now tag information of the network is displayed when the user
tries to see the network details using the command
openstack network show <net-id>

Change-Id: I587d2bca37b8dbef4400db3d8ace3c81d87e2db3
Closes-Bug: #1695783
2017-06-22 12:58:18 +05:30
Steve Martinelli
227d4c64ef Add project purge command to osc
See the initial implementation:
  https://github.com/openstack/ospurge/blob/master/ospurge/client.py

Partial-Bug: 1584596

Change-Id: I3aa86af7c85e7ca3b7f04b43e8e07125f7d956d1
2017-06-13 10:26:35 -04:00
Hong Hui Xiao
2b66c71a7c Don't show hint about vlan transparent in network set
Update this attribute is not allowed in neutron.

Change-Id: I38010b26e116246c13dbb6cc6a777d2f22f6dc30
Closes-Bug: #1691776
2017-06-12 19:20:30 +08:00