mirror of
https://opendev.org/openstack/python-openstackclient.git
synced 2026-01-17 07:20:45 +00:00
7741347041
If a required service is not enabled then we skip the test. The discovery is done by tests/functional/base.py:is_service_enabled but this method is broken, credentials are not passed to the 'openstack service show' command so every call will fail and every test that relies on it will be skipped. This commit fixed that method and the issues that popped up when re-enabling tests. Network segment range: - issue where we assumed network-segment-range extension is always present - issue where we compare integers and string representations of numbers Subnet: - issue where we try to deepcopy an uncopyable object in UnsetSubnet Change-Id: Id3cc907c1ed2a25b49cf6f4a7233e0401a02383a Story: 2005169 Task: 29908
103 lines
4.2 KiB
Python
103 lines
4.2 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import json
|
|
import uuid
|
|
|
|
from openstackclient.tests.functional import base
|
|
|
|
|
|
class NetworkTests(base.TestCase):
|
|
"""Functional tests for Network commands"""
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(NetworkTests, cls).setUpClass()
|
|
cls.haz_network = cls.is_service_enabled('network')
|
|
|
|
|
|
class NetworkTagTests(NetworkTests):
|
|
"""Functional tests with tag operation"""
|
|
|
|
base_command = None
|
|
|
|
def test_tag_operation(self):
|
|
# Get project IDs
|
|
cmd_output = json.loads(self.openstack('token issue -f json '))
|
|
auth_project_id = cmd_output['project_id']
|
|
|
|
# Network create with no options
|
|
name1 = self._create_resource_and_tag_check('', [])
|
|
# Network create with tags
|
|
name2 = self._create_resource_and_tag_check('--tag red --tag blue',
|
|
['red', 'blue'])
|
|
# Network create with no tag explicitly
|
|
name3 = self._create_resource_and_tag_check('--no-tag', [])
|
|
|
|
self._set_resource_and_tag_check('set', name1, '--tag red --tag green',
|
|
['red', 'green'])
|
|
|
|
list_expected = ((name1, ['red', 'green']),
|
|
(name2, ['red', 'blue']),
|
|
(name3, []))
|
|
self._list_tag_check(auth_project_id, list_expected)
|
|
|
|
self._set_resource_and_tag_check('set', name1, '--tag blue',
|
|
['red', 'green', 'blue'])
|
|
self._set_resource_and_tag_check(
|
|
'set', name1,
|
|
'--no-tag --tag yellow --tag orange --tag purple',
|
|
['yellow', 'orange', 'purple'])
|
|
self._set_resource_and_tag_check('unset', name1, '--tag yellow',
|
|
['orange', 'purple'])
|
|
self._set_resource_and_tag_check('unset', name1, '--all-tag', [])
|
|
self._set_resource_and_tag_check('set', name2, '--no-tag', [])
|
|
|
|
def _assertTagsEqual(self, expected, actual):
|
|
# TODO(amotoki): Should migrate to cliff format columns.
|
|
# At now, unit test assert method needs to be replaced
|
|
# to handle format columns, so format_list() is used.
|
|
# NOTE: The order of tag is undeterminestic.
|
|
actual_tags = filter(bool, actual.split(', '))
|
|
self.assertEqual(set(expected), set(actual_tags))
|
|
|
|
def _list_tag_check(self, project_id, expected):
|
|
cmd_output = json.loads(self.openstack(
|
|
'{} list --long --project {} -f json'.format(self.base_command,
|
|
project_id)))
|
|
for name, tags in expected:
|
|
net = [n for n in cmd_output if n['Name'] == name][0]
|
|
self._assertTagsEqual(tags, net['Tags'])
|
|
|
|
def _create_resource_for_tag_test(self, name, args):
|
|
return json.loads(self.openstack(
|
|
'{} create -f json {} {}'.format(self.base_command, args, name)
|
|
))
|
|
|
|
def _create_resource_and_tag_check(self, args, expected):
|
|
name = uuid.uuid4().hex
|
|
cmd_output = self._create_resource_for_tag_test(name, args)
|
|
self.addCleanup(
|
|
self.openstack, '{} delete {}'.format(self.base_command, name))
|
|
self.assertIsNotNone(cmd_output["id"])
|
|
self._assertTagsEqual(expected, cmd_output['tags'])
|
|
return name
|
|
|
|
def _set_resource_and_tag_check(self, command, name, args, expected):
|
|
cmd_output = self.openstack(
|
|
'{} {} {} {}'.format(self.base_command, command, args, name)
|
|
)
|
|
self.assertFalse(cmd_output)
|
|
cmd_output = json.loads(self.openstack(
|
|
'{} show -f json {}'.format(self.base_command, name)
|
|
))
|
|
self._assertTagsEqual(expected, cmd_output['tags'])
|