kgess-mirror/openstack-python-openstackclient
1
0
Fork 0
mirror of https://opendev.org/openstack/python-openstackclient.git synced 2026-01-17 15:31:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
openstack-python-openstackc.../openstackclient/tests/common
History
Tang Chen e69b88ef52 Fix DisplayCommandBase comments for cliff Lister subclass tests 
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 2 in all but identity tests. There are too many
such comments in identity tests. So fix them all in another patch.

Change-Id: I00f38d12f55abe20fa708f6349073da658622f8d
Partial-bug: #1477199
2016-02-09 20:28:18 +08:00
..
__init__.py Remove copyright from empty files 2014-01-20 17:28:13 +04:00
test_availability_zone.py Fix DisplayCommandBase comments for cliff Lister subclass tests 2016-02-09 20:28:18 +08:00
test_clientmanager.py Refactor network endpoint enablement checking 2016-01-04 13:49:49 -06:00
test_command.py Set up logger of each command by metaclass 2016-01-20 22:02:19 +09:00
test_commandmanager.py fix the wrong order of assertEqual args 2015-01-27 17:02:41 +08:00
test_configuration.py Changed the abstract columns and datalists from test cases of common and Identity 2016-01-12 17:25:33 +05:30
test_extension.py Fix DisplayCommandBase comments for cliff Lister subclass tests 2016-02-09 20:28:18 +08:00
test_logs.py Use assertTrue/False instead of assertEqual(T/F) 2016-01-07 12:40:09 +05:30
test_module.py Fix DisplayCommandBase comments for cliff Lister subclass tests 2016-02-09 20:28:18 +08:00
test_parseractions.py Refactor: Initialize parser in setUp() in TestNonNegativeAction 2015-12-28 20:01:13 +08:00
test_quota.py Fix showing network quotas for a project 2016-02-02 02:02:53 +00:00
test_timing.py Fix DisplayCommandBase comments for cliff Lister subclass tests 2016-02-09 20:28:18 +08:00
test_utils.py Merge "Use assert_not_called() in common tests" 2016-02-04 22:56:57 +00:00