mirror of
https://opendev.org/openstack/python-openstackclient.git
synced 2026-01-17 07:20:45 +00:00
e3270cdfd8
set/unset commands should ends up normally instead of raising an exception when nothing is specified to modify. The main reason is: When nothing is specified, the command sets/unsets nothing, which is a normal behavior, and ends up normally. No API call fails. No error happens. This patch also adds a releasenote for both network, and volume commands that fix patch has been merged. Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef Partial-bug: #1588588
415 lines
13 KiB
Python
415 lines
13 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import copy
|
|
import mock
|
|
|
|
from mock import call
|
|
from openstackclient.common import exceptions
|
|
from openstackclient.network.v2 import address_scope
|
|
from openstackclient.tests import fakes
|
|
from openstackclient.tests.identity.v3 import fakes as identity_fakes_v3
|
|
from openstackclient.tests.network.v2 import fakes as network_fakes
|
|
from openstackclient.tests import utils as tests_utils
|
|
|
|
|
|
class TestAddressScope(network_fakes.TestNetworkV2):
|
|
|
|
def setUp(self):
|
|
super(TestAddressScope, self).setUp()
|
|
|
|
# Get a shortcut to the network client
|
|
self.network = self.app.client_manager.network
|
|
|
|
|
|
class TestCreateAddressScope(TestAddressScope):
|
|
|
|
# The new address scope created.
|
|
new_address_scope = (
|
|
network_fakes.FakeAddressScope.create_one_address_scope(
|
|
attrs={
|
|
'tenant_id': identity_fakes_v3.project_id,
|
|
}
|
|
))
|
|
columns = (
|
|
'id',
|
|
'ip_version',
|
|
'name',
|
|
'project_id',
|
|
'shared'
|
|
)
|
|
data = (
|
|
new_address_scope.id,
|
|
new_address_scope.ip_version,
|
|
new_address_scope.name,
|
|
new_address_scope.project_id,
|
|
new_address_scope.shared,
|
|
)
|
|
|
|
def setUp(self):
|
|
super(TestCreateAddressScope, self).setUp()
|
|
self.network.create_address_scope = mock.Mock(
|
|
return_value=self.new_address_scope)
|
|
|
|
# Get the command object to test
|
|
self.cmd = address_scope.CreateAddressScope(self.app, self.namespace)
|
|
|
|
# Set identity client v3. And get a shortcut to Identity client.
|
|
identity_client = identity_fakes_v3.FakeIdentityv3Client(
|
|
endpoint=fakes.AUTH_URL,
|
|
token=fakes.AUTH_TOKEN,
|
|
)
|
|
self.app.client_manager.identity = identity_client
|
|
self.identity = self.app.client_manager.identity
|
|
|
|
# Get a shortcut to the ProjectManager Mock
|
|
self.projects_mock = self.identity.projects
|
|
self.projects_mock.get.return_value = fakes.FakeResource(
|
|
None,
|
|
copy.deepcopy(identity_fakes_v3.PROJECT),
|
|
loaded=True,
|
|
)
|
|
|
|
# Get a shortcut to the DomainManager Mock
|
|
self.domains_mock = self.identity.domains
|
|
self.domains_mock.get.return_value = fakes.FakeResource(
|
|
None,
|
|
copy.deepcopy(identity_fakes_v3.DOMAIN),
|
|
loaded=True,
|
|
)
|
|
|
|
def test_create_no_options(self):
|
|
arglist = []
|
|
verifylist = []
|
|
|
|
# Missing required args should bail here
|
|
self.assertRaises(tests_utils.ParserException, self.check_parser,
|
|
self.cmd, arglist, verifylist)
|
|
|
|
def test_create_default_options(self):
|
|
arglist = [
|
|
self.new_address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('project', None),
|
|
('ip_version', self.new_address_scope.ip_version),
|
|
('name', self.new_address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = (self.cmd.take_action(parsed_args))
|
|
|
|
self.network.create_address_scope.assert_called_once_with(**{
|
|
'ip_version': self.new_address_scope.ip_version,
|
|
'name': self.new_address_scope.name,
|
|
})
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
def test_create_all_options(self):
|
|
arglist = [
|
|
'--ip-version', str(self.new_address_scope.ip_version),
|
|
'--share',
|
|
'--project', identity_fakes_v3.project_name,
|
|
'--project-domain', identity_fakes_v3.domain_name,
|
|
self.new_address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('ip_version', self.new_address_scope.ip_version),
|
|
('share', True),
|
|
('project', identity_fakes_v3.project_name),
|
|
('project_domain', identity_fakes_v3.domain_name),
|
|
('name', self.new_address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = (self.cmd.take_action(parsed_args))
|
|
|
|
self.network.create_address_scope.assert_called_once_with(**{
|
|
'ip_version': self.new_address_scope.ip_version,
|
|
'shared': True,
|
|
'tenant_id': identity_fakes_v3.project_id,
|
|
'name': self.new_address_scope.name,
|
|
})
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
def test_create_no_share(self):
|
|
arglist = [
|
|
'--no-share',
|
|
self.new_address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('no_share', True),
|
|
('name', self.new_address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.network.create_address_scope.assert_called_once_with(**{
|
|
'ip_version': self.new_address_scope.ip_version,
|
|
'shared': False,
|
|
'name': self.new_address_scope.name,
|
|
})
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
|
|
class TestDeleteAddressScope(TestAddressScope):
|
|
|
|
# The address scope to delete.
|
|
_address_scopes = (
|
|
network_fakes.FakeAddressScope.create_address_scopes(count=2))
|
|
|
|
def setUp(self):
|
|
super(TestDeleteAddressScope, self).setUp()
|
|
self.network.delete_address_scope = mock.Mock(return_value=None)
|
|
self.network.find_address_scope = (
|
|
network_fakes.FakeAddressScope.get_address_scopes(
|
|
address_scopes=self._address_scopes)
|
|
)
|
|
|
|
# Get the command object to test
|
|
self.cmd = address_scope.DeleteAddressScope(self.app, self.namespace)
|
|
|
|
def test_address_scope_delete(self):
|
|
arglist = [
|
|
self._address_scopes[0].name,
|
|
]
|
|
verifylist = [
|
|
('address_scope', [self._address_scopes[0].name]),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
self.network.find_address_scope.assert_called_once_with(
|
|
self._address_scopes[0].name, ignore_missing=False)
|
|
self.network.delete_address_scope.assert_called_once_with(
|
|
self._address_scopes[0])
|
|
self.assertIsNone(result)
|
|
|
|
def test_multi_address_scopes_delete(self):
|
|
arglist = []
|
|
verifylist = []
|
|
|
|
for a in self._address_scopes:
|
|
arglist.append(a.name)
|
|
verifylist = [
|
|
('address_scope', arglist),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
calls = []
|
|
for a in self._address_scopes:
|
|
calls.append(call(a))
|
|
self.network.delete_address_scope.assert_has_calls(calls)
|
|
self.assertIsNone(result)
|
|
|
|
def test_multi_address_scopes_delete_with_exception(self):
|
|
arglist = [
|
|
self._address_scopes[0].name,
|
|
'unexist_address_scope',
|
|
]
|
|
verifylist = [
|
|
('address_scope',
|
|
[self._address_scopes[0].name, 'unexist_address_scope']),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
find_mock_result = [self._address_scopes[0], exceptions.CommandError]
|
|
self.network.find_address_scope = (
|
|
mock.MagicMock(side_effect=find_mock_result)
|
|
)
|
|
|
|
try:
|
|
self.cmd.take_action(parsed_args)
|
|
self.fail('CommandError should be raised.')
|
|
except exceptions.CommandError as e:
|
|
self.assertEqual('1 of 2 address scopes failed to delete.', str(e))
|
|
|
|
self.network.find_address_scope.assert_any_call(
|
|
self._address_scopes[0].name, ignore_missing=False)
|
|
self.network.find_address_scope.assert_any_call(
|
|
'unexist_address_scope', ignore_missing=False)
|
|
self.network.delete_address_scope.assert_called_once_with(
|
|
self._address_scopes[0]
|
|
)
|
|
|
|
|
|
class TestListAddressScope(TestAddressScope):
|
|
|
|
# The address scopes to list up.
|
|
address_scopes = (
|
|
network_fakes.FakeAddressScope.create_address_scopes(count=3))
|
|
columns = (
|
|
'ID',
|
|
'Name',
|
|
'IP Version',
|
|
'Shared',
|
|
'Project',
|
|
)
|
|
data = []
|
|
for scope in address_scopes:
|
|
data.append((
|
|
scope.id,
|
|
scope.name,
|
|
scope.ip_version,
|
|
scope.shared,
|
|
scope.project_id,
|
|
))
|
|
|
|
def setUp(self):
|
|
super(TestListAddressScope, self).setUp()
|
|
self.network.address_scopes = mock.Mock(
|
|
return_value=self.address_scopes)
|
|
|
|
# Get the command object to test
|
|
self.cmd = address_scope.ListAddressScope(self.app, self.namespace)
|
|
|
|
def test_address_scope_list(self):
|
|
arglist = []
|
|
verifylist = []
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.network.address_scopes.assert_called_once_with(**{})
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, list(data))
|
|
|
|
|
|
class TestSetAddressScope(TestAddressScope):
|
|
|
|
# The address scope to set.
|
|
_address_scope = network_fakes.FakeAddressScope.create_one_address_scope()
|
|
|
|
def setUp(self):
|
|
super(TestSetAddressScope, self).setUp()
|
|
self.network.update_address_scope = mock.Mock(return_value=None)
|
|
self.network.find_address_scope = mock.Mock(
|
|
return_value=self._address_scope)
|
|
|
|
# Get the command object to test
|
|
self.cmd = address_scope.SetAddressScope(self.app, self.namespace)
|
|
|
|
def test_set_nothing(self):
|
|
arglist = [self._address_scope.name, ]
|
|
verifylist = [
|
|
('address_scope', self._address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
attrs = {}
|
|
self.network.update_address_scope.assert_called_with(
|
|
self._address_scope, **attrs)
|
|
self.assertIsNone(result)
|
|
|
|
def test_set_name_and_share(self):
|
|
arglist = [
|
|
'--name', 'new_address_scope',
|
|
'--share',
|
|
self._address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('name', 'new_address_scope'),
|
|
('share', True),
|
|
('address_scope', self._address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
result = self.cmd.take_action(parsed_args)
|
|
attrs = {
|
|
'name': "new_address_scope",
|
|
'shared': True,
|
|
}
|
|
self.network.update_address_scope.assert_called_with(
|
|
self._address_scope, **attrs)
|
|
self.assertIsNone(result)
|
|
|
|
def test_set_no_share(self):
|
|
arglist = [
|
|
'--no-share',
|
|
self._address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('no_share', True),
|
|
('address_scope', self._address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
result = self.cmd.take_action(parsed_args)
|
|
attrs = {
|
|
'shared': False,
|
|
}
|
|
self.network.update_address_scope.assert_called_with(
|
|
self._address_scope, **attrs)
|
|
self.assertIsNone(result)
|
|
|
|
|
|
class TestShowAddressScope(TestAddressScope):
|
|
|
|
# The address scope to show.
|
|
_address_scope = (
|
|
network_fakes.FakeAddressScope.create_one_address_scope())
|
|
columns = (
|
|
'id',
|
|
'ip_version',
|
|
'name',
|
|
'project_id',
|
|
'shared',
|
|
)
|
|
data = (
|
|
_address_scope.id,
|
|
_address_scope.ip_version,
|
|
_address_scope.name,
|
|
_address_scope.project_id,
|
|
_address_scope.shared,
|
|
)
|
|
|
|
def setUp(self):
|
|
super(TestShowAddressScope, self).setUp()
|
|
self.network.find_address_scope = mock.Mock(
|
|
return_value=self._address_scope)
|
|
|
|
# Get the command object to test
|
|
self.cmd = address_scope.ShowAddressScope(self.app, self.namespace)
|
|
|
|
def test_show_no_options(self):
|
|
arglist = []
|
|
verifylist = []
|
|
|
|
# Missing required args should bail here
|
|
self.assertRaises(tests_utils.ParserException, self.check_parser,
|
|
self.cmd, arglist, verifylist)
|
|
|
|
def test_show_all_options(self):
|
|
arglist = [
|
|
self._address_scope.name,
|
|
]
|
|
verifylist = [
|
|
('address_scope', self._address_scope.name),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.network.find_address_scope.assert_called_once_with(
|
|
self._address_scope.name, ignore_missing=False)
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(list(self.data), list(data))
|