kgess-mirror/proton-protoncore_ios
1
0
Fork 0
mirror of https://github.com/ProtonMail/protoncore_ios.git synced 2026-01-16 23:00:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(unleash): Fix a bug in cleaning the flags

Browse source 
Co-authored-by: magohamote <cedric.rolland@proton.ch>

Refs: https://gitlab.protontech.ch/apple/shared/protoncore/-/merge_requests/1516

Changelog:
This commit is contained in:
MargeBot 2023-11-10 14:23:34 +00:00
commit a4683aaaaa
2 changed files with 84 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/FeatureFlags/Sources/DataSources/DefaultLocalFeatureFlagsDatasource.swift
View file

@ -71,7 +71,7 @@ public class DefaultLocalFeatureFlagsDatasource: LocalFeatureFlagsProtocol {
serialAccessQueue.sync {
var flagsToClean: [String: FeatureFlags]? = userDefaults.decodableValue(forKey: DefaultLocalFeatureFlagsDatasource.featureFlagsKey)
flagsToClean?[userId] = nil
userDefaults.set(flagsToClean, forKey: DefaultLocalFeatureFlagsDatasource.featureFlagsKey)
userDefaults.setEncodableValue(flagsToClean, forKey: DefaultLocalFeatureFlagsDatasource.featureFlagsKey)
}
}
}

83
libraries/FeatureFlags/Tests/FeatureFlagsTests/FeatureFlagsTests.swift
View file

@ -410,4 +410,87 @@ final class FeatureFlagsTests: XCTestCase {
// Then BlackFriday flag is returned and true, but isEnabled still returns the first returned value
XCTAssertFalse(sut.isEnabled(TestFlagsType.blackFriday, for: userId))
}
func test_resetFlagsForUserId_resetsFlagsForuserId() async throws {
// Given
let userId1 = "userId1"
let flagResponse1 = FeatureFlagResponse(
code: 1000,
toggles: [.init(
name: "BlackFriday",
enabled: true,
variant: nil
)]
)
let userId2 = "userId2"
let flagResponse2 = FeatureFlagResponse(
code: 1000,
toggles: [.init(
name: "BlackFriday",
enabled: true,
variant: nil
)]
)
let apiService = APIServiceMock()
apiService.requestDecodableStub.bodyIs { count, _, _, _, _, _, _, _, _, _, _, completion in
if count == 1 {
completion(nil, .success(flagResponse1))
} else {
completion(nil, .success(flagResponse2))
}
}
// When
try await sut.fetchFlags(for: userId1, with: apiService)
try await sut.fetchFlags(for: userId2, with: apiService)
// Then
let flags = try await sut.localDatasource.value.getFeatureFlags(userId: userId1)
XCTAssertEqual(flags, FeatureFlags(flags: flagResponse1.toggles))
// When
sut.resetFlags(for: userId1)
// Then
let emptyFlags: [String: FeatureFlags]? = featureFlagUserDefaults.decodableValue(forKey: DefaultLocalFeatureFlagsDatasource.featureFlagsKey)
XCTAssertNil(emptyFlags?[userId1])
XCTAssertNotNil(emptyFlags?[userId2])
}
func test_resetFlags_resetsFlags() async throws {
// Given
let userId = "userId"
let flagResponse = FeatureFlagResponse(
code: 1000,
toggles: [.init(
name: "BlackFriday",
enabled: true,
variant: nil
)]
)
let apiService = APIServiceMock()
apiService.requestDecodableStub.bodyIs { _, _, _, _, _, _, _, _, _, _, _, completion in
completion(nil, .success(flagResponse))
}
// When
try await sut.fetchFlags(for: userId, with: apiService)
// Then
let flags = try await sut.localDatasource.value.getFeatureFlags(userId: userId)
XCTAssertEqual(flags, FeatureFlags(flags: flagResponse.toggles))
// When
sut.resetFlags()
// Then
let emptyFlags: [String: FeatureFlags]? = featureFlagUserDefaults.decodableValue(forKey: DefaultLocalFeatureFlagsDatasource.featureFlagsKey)
XCTAssertNil(emptyFlags)
}
}