chore: revert digicert changes (#2946)

* Revert "chore: collect key locker logs (#2945)"

This reverts commit 935be1c019.

* Revert "chore: fix signing algorithms (#2944)"

This reverts commit 0bcac5e387.

* Revert "chore: add Signing Manager health checks before certificate sign (#2943)"

This reverts commit 184d4008cf.
This commit is contained in:
Karol Sójko 2025-10-16 15:39:51 +02:00 committed by GitHub
parent 935be1c019
commit 00f951451f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 35 deletions

View file

@ -326,42 +326,12 @@ jobs:
- name: Certificates Sync - name: Certificates Sync
run: | run: |
smctl windows certsync --keypair-alias=${{ secrets.SM_KEYPAIR_ALIAS }} smctl windows certsync
shell: cmd
- name: Health Check Signing Manager
run: smctl healthcheck
shell: cmd shell: cmd
- name: Build & Sign With Electron Builder - name: Build & Sign With Electron Builder
run: yarn run electron-builder --windows --x64 --ia32 --publish=never --c.extraMetadata.version=$(node -p "require('./../web/package.json').version") run: yarn run electron-builder --windows --x64 --ia32 --publish=never --c.extraMetadata.version=$(node -p "require('./../web/package.json').version")
- name: Collect KeyLocker Logs
run: |
echo "Collecting DigiCert KeyLocker logs..."
echo "USERPROFILE: %USERPROFILE%"
echo "HOME: %HOME%"
if exist "%USERPROFILE%\.signingmanager\logs\smksp.log" (
echo "Found KeyLocker log file at %USERPROFILE%\.signingmanager\logs\smksp.log"
type "%USERPROFILE%\.signingmanager\logs\smksp.log"
) else (
echo "KeyLocker log file not found at %USERPROFILE%\.signingmanager\logs\smksp.log"
echo "Checking if .signingmanager directory exists..."
if exist "%USERPROFILE%\.signingmanager" (
echo ".signingmanager directory exists, checking for logs subdirectory..."
if exist "%USERPROFILE%\.signingmanager\logs" (
echo "logs directory exists, listing contents:"
dir "%USERPROFILE%\.signingmanager\logs"
) else (
echo "logs subdirectory does not exist"
)
) else (
echo ".signingmanager directory does not exist"
)
)
shell: cmd
- name: Upload - name: Upload
uses: actions/upload-artifact@v4.0.0 uses: actions/upload-artifact@v4.0.0
with: with:
@ -371,7 +341,6 @@ jobs:
packages/desktop/dist/*.exe packages/desktop/dist/*.exe
packages/desktop/dist/*.yml packages/desktop/dist/*.yml
packages/desktop/dist/*.yaml packages/desktop/dist/*.yaml
${{ env.USERPROFILE }}\.signingmanager\logs\smksp.log
Publish: Publish:
runs-on: ubuntu-latest runs-on: ubuntu-latest

View file

@ -23,4 +23,4 @@ runs:
RELEASE_NOTES="${RELEASE_NOTES//'%'/'%25'}" RELEASE_NOTES="${RELEASE_NOTES//'%'/'%25'}"
RELEASE_NOTES="${RELEASE_NOTES//$'\n'/'%0A'}" RELEASE_NOTES="${RELEASE_NOTES//$'\n'/'%0A'}"
RELEASE_NOTES="${RELEASE_NOTES//$'\r'/'%0D'}" RELEASE_NOTES="${RELEASE_NOTES//$'\r'/'%0D'}"
{ echo 'result<<EOF'; printf '%s\n' "$RELEASE_NOTES"; echo 'EOF'; } >> "$GITHUB_OUTPUT" echo "::set-output name=result::$RELEASE_NOTES"

View file

@ -123,8 +123,7 @@
"certificateSubjectName": "Standard Notes Ltd.", "certificateSubjectName": "Standard Notes Ltd.",
"publisherName": "Standard Notes Ltd.", "publisherName": "Standard Notes Ltd.",
"signDlls": true, "signDlls": true,
"sign": "./scripts/windowsSign.js", "sign": "./scripts/windowsSign.js"
"signingHashAlgorithms": ["sha1", "sha256"]
}, },
"nsis": { "nsis": {
"deleteAppDataOnUninstall": true "deleteAppDataOnUninstall": true