chore: remove obsolete code from button-legacy.css (#10581)

Fixes #10580

Remove obsolete styles so that people do not trip over them.

I went through the codebase with `rg` and made sure that the only elements which had potential to use such mix of classes were doing so accidentally, and removed all the unused code.

### A small fix for Forgejo themes

Ref https://codeberg.org/forgejo/forgejo/pulls/10581#issuecomment-9245399. The missing variable was used in one place outside of devtest.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10581
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Beowulf <beowulf@beocode.eu>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Co-committed-by: 0ko <0ko@noreply.codeberg.org>

templates/devtest/gitea-ui.tmpl

@@ -48,8 +48,6 @@
 				<li class="sample-group">
 					<h2>Supported but not recommended:</h2>
 					<p>Do not use if there is no strong requirement. Do not use grey/black buttons, they don't work well with dark theme.</p>
-					<button class="ui secondary button">Secondary</button>
-					<button class="ui basic secondary button">Basic Secondary</button>
 					<button class="ui teal button">Teal</button>
 					<button class="ui basic teal button">Basic Teal</button>
 					<button class="ui purple button">Purple</button>

templates/repo/issue/filters.tmpl

@@ -15,7 +15,7 @@
 		{{end}}
 	</div>
 	<div class="issue-list-toolbar-right">
-		<div class="ui secondary filter menu labels">
+		<div class="ui secondary filter menu">
 			{{if .PageIsMilestones}}
 				{{template "repo/issue/milestone/filter_list" .}}
 			{{else}}

templates/user/notification/notification_subscriptions.tmpl

@@ -31,7 +31,7 @@
 						</a>
 					</div>
 					<div class="tw-flex">
-						<div class="ui right aligned secondary filter menu labels">
+						<div class="ui right aligned secondary filter menu">
 							<!-- Type -->
 								<div class="ui dropdown type jump item">
 									<span class="text">

web_src/css/modules/button-legacy.css

@@ -185,47 +185,6 @@ It needs some tricks to tweak the left/right borders with active state */
   border-color: var(--color-primary-active);
 }
 
-/* secondary */
-
-.ui.secondary.labels .label,
-.ui.ui.ui.secondary.label,
-.ui.secondary.button,
-.ui.secondary.buttons .button,
-.ui.secondary.button:focus,
-.ui.secondary.buttons .button:focus {
-  background: var(--color-secondary-button);
-}
-
-.ui.secondary.button:hover,
-.ui.secondary.buttons .button:hover {
-  background: var(--color-secondary-hover);
-}
-
-.ui.secondary.button:active,
-.ui.secondary.buttons .button:active {
-  background: var(--color-secondary-active);
-}
-
-.ui.basic.secondary.buttons .button,
-.ui.basic.secondary.button {
-  color: var(--color-secondary-button);
-  border-color: var(--color-secondary-button);
-}
-
-.ui.basic.secondary.buttons .button:hover,
-.ui.basic.secondary.button:hover,
-.ui.basic.secondary.button:focus,
-.ui.basic.secondary.buttons .button:focus {
-  color: var(--color-secondary-hover);
-  border-color: var(--color-secondary-hover);
-}
-
-.ui.basic.secondary.buttons .button:active,
-.ui.basic.secondary.button:active {
-  color: var(--color-secondary-active);
-  border-color: var(--color-secondary-active);
-}
-
 /* red */
 
 .ui.red.labels .label,

web_src/css/repo.css

@@ -80,7 +80,7 @@
   overflow-x: auto;
 }
 
-.repository .filter.menu.labels .label-filter .menu .info {
+.repository .filter.menu .label-filter .menu .info {
   display: inline-block;
   padding: 0.5rem 0;
   font-size: 12px;
@@ -91,7 +91,7 @@
   text-align: left;
 }
 
-.repository .filter.menu.labels .label-filter .menu .info code {
+.repository .filter.menu .label-filter .menu .info code {
   border: 1px solid var(--color-secondary);
   border-radius: var(--border-radius);
   padding: 1px 2px;

web_src/css/themes/theme-gitea-dark.css

@@ -58,7 +58,6 @@
   --color-secondary-alpha-70: #3b444ab3;
   --color-secondary-alpha-80: #3b444acc;
   --color-secondary-alpha-90: #3b444ae1;
-  --color-secondary-button: var(--color-secondary-dark-4);
   --color-secondary-hover: var(--color-secondary-dark-3);
   --color-secondary-active: var(--color-secondary-dark-2);
   /* console colors - used for actions console and console files */

web_src/css/themes/theme-gitea-light.css

@@ -58,7 +58,6 @@
   --color-secondary-alpha-70: #d0d7deb3;
   --color-secondary-alpha-80: #d0d7decc;
   --color-secondary-alpha-90: #d0d7dee1;
-  --color-secondary-button: var(--color-secondary-dark-4);
   --color-secondary-hover: var(--color-secondary-dark-5);
   --color-secondary-active: var(--color-secondary-dark-6);
   /* console colors - used for actions console and console files */