Commit graph

2656 commits

Author SHA1 Message Date
Jenkins
6cae88fa2b Merge "Add a validation about options for server migrate command" 2017-03-16 15:52:50 +00:00
Jenkins
c1503492cd Merge "Fix "security group list" command to display project ID properly" 2017-03-16 13:02:17 +00:00
Jenkins
3d4750cdc8 Merge "Narrow expected responses for CheckUserInGroup" 2017-03-16 13:02:02 +00:00
Jenkins
9184e19288 Merge "Add sort support to project list" 2017-03-16 13:01:56 +00:00
Jenkins
66246561d8 Merge "Switch to use cleanup method in functional test" 2017-03-16 13:01:49 +00:00
Jenkins
b6f51cdfa0 Merge "Add the bgp agent type to network agent command" 2017-03-16 08:58:49 +00:00
Colleen Murphy
853ea5ab59 Narrow expected responses for CheckUserInGroup
When checking whether a given user is in a given group, keystone will
return a 404 Not Found if all went well but the user was not in the
group. It may also return a 403 if the user and the group are in
different backends, which would also mean that the user was not in the
group[1]. Any other 400 response is a client error and any 500 response
is a server error to which the user should be alerted.

Without this patch, openstackclient treats any exception as a valid "not
found" and may end up hiding server errors. This patch reduces the
caught exceptions to 403 and 404 responses and treats everything else as
an error.

[1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group

Closes-bug: #1672634

Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f
2017-03-14 09:23:19 +01:00
Huanxuan Ao
888022f8c0 Fix "security group list" command to display project ID properly
The "Project" column of the output of
"security group list" command is blank
since the new attribute name is "project_id"
not "tenant_id" in network resource, so change
it to display project IDs properly

Change-Id: Ie2a071afac3b5a8aaa2c6f1c50d44ae06905d916
Closes-bug: #1659967
2017-03-10 10:55:58 +08:00
Jenkins
9ffcd0dca7 Merge "Fix handling the use_default_subnet_pool attribute" 2017-03-10 02:52:15 +00:00
Jens Rosenboom
3e6356a4d8 Fix handling the use_default_subnet_pool attribute
The attribute formerly wasn't working because it is lacking support in
the SDK. The patch to add it[1] introduced a modified spelling, so we
should be matching this here.

Also make sure that the attribute is not shown when displaying subnet
objects, as it is meant to be invisible[2].

[1] I72c0be77d96f3891748cdd69c382211dc20dbf5e
[2] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/default_subnetpools.py#n23

Change-Id: Ic125b818a6082d76a1114fe89e0b1fcf4c7356b0
Partial-Bug: 1668223
2017-03-09 08:21:13 +01:00
Tom Jose Kalapura
6c1b03bf73 Add sort support to project list
Add sort support to project list by sorting items in the client side.
By default list will be sorted by name.

Change-Id: I00011406846b4003aff075eeeb88ac18fa5e2820
Closes-Bug: #1596818
2017-03-08 08:47:35 -08:00
Jenkins
37b5d0d45e Merge "command list: Move network meter appropriately" 2017-03-08 15:42:22 +00:00
Jens Rosenboom
8c6cfb518b Add the bgp agent type to network agent command
The neutron-dynamic-routing project provides an agent called
neutron-bgp-dragent with type "BGP dynamic routing agent". So we need to
add this option and can avoid using the deprecated neutron CLI e.g. in
[1].

[1] https://docs.openstack.org/ocata/networking-guide/config-bgp-dynamic-routing.html#verify-service-operation

Change-Id: I9af1e09d122806b56b966295817d8d31393e0283
Closes-Bug: 1671040
2017-03-08 14:40:23 +01:00
Jenkins
dcb2de9db2 Merge "Add "--private-key" option for "keypair create"" 2017-03-08 02:51:48 +00:00
Akihiro Motoki
f4d3810c3e command list: Move network meter appropriately
'network meter' commands are not placed alphabetically
in the command list. It was due to the incorrect filename.

Trivial Fix

Change-Id: I7a76d3133915883cf41be8c7430def284d292d6e
2017-03-08 05:56:32 +09:00
Rui Chen
c03b9a871c Add server event list and show commands
OSC server event is similar to nova's instance action commands.

Server event is the event record that had been done on a server,
include: event type(create, delete, reboot and so on),
event result(success, error), start time, finish time and so on.
These are important information for server maintains.

Change-Id: I8111091f46a0d2755728d8f9d43cc0dfe8842d13
Closes-Bug: #1642030
2017-03-07 15:25:43 +08:00
Jenkins
ca6f733f0f Merge "Trivial Fix" 2017-03-06 21:38:28 +00:00
Rui Chen
dee22d8faa Add "--private-key" option for "keypair create"
Aim to specify the private key file to save when keypair
is created. That is a convenient way to save private key
in OSC interactive mode, avoid to copy CLI output, then
paste it into file.

Change-Id: I119d2f2a3323d17ecbe3de4e27f35e1ceef6e0a5
Closes-Bug: #1549410
2017-03-06 08:34:28 +00:00
Jenkins
69b7b9b059 Merge "Support --no-property in "volume set" command" 2017-03-06 03:47:49 +00:00
Reedip
33b092fb9a Trivial Fix
Add a space in the quota error message

Change-Id: I159708b42e86f6b02f8733103a687561d550f650
2017-03-05 18:21:46 +00:00
Anindita Das
6abd38cd46 Jsonify network flavor functional tests
Some functional tests try to parse the CLI table output format, that cause much
work on parse string by using regular expression. Using json format in
functional tests is better and easier way, this patch reworks for network
flavor related tests.

Change-Id: I2bc5675409945c9ae79ac65df2d5d10781fe595a
2017-03-02 17:10:53 +00:00
Jenkins
8bff11582d Merge "Functional test for subnet" 2017-03-02 14:38:07 +00:00
Jenkins
3ec0bc9179 Merge "Add Cinder v3 client support for volumes" 2017-03-01 19:10:48 +00:00
Jenkins
3816433b53 Merge "Auto allocated topology for OSC" 2017-03-01 18:03:19 +00:00
Rikimaru Honjo
7063ffb3ca Add a validation about options for server migrate command
The behavior of server migrate command are different depending on
whether user specify --live option or not.
server migrate command will call live migration API if user specify
--live option.
Ohterwise server migrate command will call migration(cold migration)
API.

Now then, "--block-migraiton" option and "--disk-overcommit" option
only affect live-migration.
But, openstackclient doesn't warn user if user specify these options
without "--live".
But, user can't recognize that specifying options are ignored.

This patch adds a validation that checks whether or not user specify
these options without "--live".

Change-Id: Ifa278abb23ecdba4b13f3742998359ac74eb7ad4
Closes-bug: #1662755
2017-03-01 17:37:39 +09:00
Jenkins
264f81f6fc Merge "Port set/unset SecGroup Bug Fix" 2017-02-27 17:18:00 +00:00
Jenkins
c6059bed4a Merge "openstack image create : --file and --volume exclude each other" 2017-02-27 05:00:57 +00:00
Jenkins
e5ee4b8ca3 Merge "Support list commands by group name keyword" 2017-02-27 03:47:11 +00:00
Ankur Gupta
9d946f0f45 Port set/unset SecGroup Bug Fix
Throwing error 'Port' object has no attribute 'security_groups'
Fix for set and unset.

Change-Id: I1a0625b5a432c7a91cf40249ce4f7c883f53d704
Closes-Bug: #1656788
2017-02-26 15:39:36 -05:00
Jens Rosenboom
f63a9f402d Fix output of ListSecurityGroupRule
The Ethertype column was always left empty because a wrong column name
was being used.

Change-Id: I7fc0f8d5eb7bac1efb234faba454dad0a45a7e6a
Closes-Bug: 1667699
2017-02-24 21:21:43 +01:00
David Rabel
4ea4f6fabb openstack image create : --file and --volume exclude each other
Added parser.add_mutually_exclusive_group() for --file and --volume
in openstack image create.

Change-Id: I4d9fc6314801d569354e5644e231ddd6c7f1853d
Closes-Bug: 1666551
2017-02-24 08:50:37 +01:00
Jenkins
1450e8ff4f Merge "Fix can not set is_default in network" 2017-02-24 04:13:38 +00:00
jiahui.qiang
7d93db21e5 Fix can not set is_default in network
The value of is_default always be None, can not be set by
"network set" command. Allow "--default" and "--no-default"
options to be recognized when ``--external`` is not present.

Closes-bug:#1665231

Change-Id: I7a05fc7734a15994f72ca4e47997b4952f1f72f8
2017-02-23 15:51:48 +00:00
zhiyong.dai
40ec7a9c96 Support --no-property in "volume set" command
Add "--no-property" option to "volume set" command in v1 and v2
and update the test cases.

Change-Id: Id5660f23b3b2d9aa72f4c16b19ce83f3f7ed2fa4
2017-02-23 21:49:11 +08:00
Huanxuan Ao
ef2a8f4d11 Revert unit tests for quota commands
quota set and quota show command have been fixed
by [1] [2], now can revert the unit test as well

[1] https://review.openstack.org/435574
[2] https://review.openstack.org/435735

Change-Id: I3d592df6ea4e96770dac4dba91819b5c4bcb0561
2017-02-23 20:44:28 +08:00
Rui Chen
0898ebacb8 Support list commands by group name keyword
The output of current "command list" is so long, it's
very difficult for users to find out the commands
they care about.

Add "--group <group-keyword>" option to filter the commands by group
name keyword, like: --group volume, list all openstack.volume.v2
(cinder) commands

That support the scenario that users need to know the current support
commands of some OpenStack services(nova, neutron, cinder and so on) in
OSC.

Change-Id: Id673042729ad36a0cac0b81fb31a3537c24f03fc
Closes-Bug: #1666780
2017-02-23 12:13:06 +08:00
Jenkins
c8435f2d5a Merge "Show openstacksdk version info in "module list"" 2017-02-22 22:51:28 +00:00
Ankur Gupta
1169434f42 Auto allocated topology for OSC
Implementation of Auto-allocated topology into OSC.
Dependency merged and released in SDK v. 0.9.11

Partially Implements: blueprint network-auto-allocated-topology

Change-Id: I16120910893b0b26b0f7f77a184b0378448458c5
2017-02-22 15:38:16 -05:00
Jenkins
3746fd2caf Merge "OSC Network Flavor" 2017-02-22 18:40:37 +00:00
Rui Chen
c828216e2b Fix "endpoint list" help message
OSC support to filter OpenStack endpoints by service type, name and ID,
but help message and document don't contain "type" for "--service"
option of "endpoint list" command.

Change-Id: I5c8bc28e037b4c6f96ec83525a319353f01f256a
Closes-Bug: #1666841
2017-02-22 17:56:03 +08:00
Rui Chen
10f0300f70 Show openstacksdk version info in "module list"
openstacksdk bug/1588823 exist, no good way to add __version__ for
openstack module properly, fix the issue in osc side, make openstacksdk
module information be available.

Change-Id: I27ff61792443d1aa07f31598bed3aa32f924ff40
Partial-Bug: #1662058
2017-02-22 16:40:22 +08:00
Anindita Das
edaeece7f1 OSC Network Flavor
Implements Neutron feature of Network Flavor into OpenstackClient
This patch implements the following commands:
network flavor create
network flavor delete
network flavor list
network flavor show
network flavor set

Works with openstacksdk version 0.9.8

Change-Id: I29d7a62341010a1d067a8ca93bccb7d9b8d4c425
Partially-Implements: blueprint neutron-client-flavors
Partially-Implements: blueprint network-commands-options
2017-02-22 02:45:51 +00:00
Jenkins
62938c02e0 Merge "Fix properties format for volume qos in volume v1" 2017-02-21 19:49:16 +00:00
Jenkins
7bf68577e6 Merge "Rework port functional tests on json output format" 2017-02-21 16:44:00 +00:00
Jenkins
35c308ebad Merge "Remove remaining uses of SDK Proxy.session" 2017-02-21 14:00:03 +00:00
Huanxuan Ao
1be6c2d92f Fix properties format for volume qos in volume v1
Notice that patch [1] fixed the error of properties
format for volume qos in volume v2, but there is the
same bug in volume v1, and the patch missed that, so
fix the problem in v1 as well

[1] https://review.openstack.org/#/c/421065/

Partial-Bug: #1656767
Change-Id: I156bf13d164dbd0d0a7ce394964176718c4ff0e5
2017-02-21 19:34:15 +08:00
Rui Chen
c7e0948a2d Rework port functional tests on json output format
Some functional tests try to parse the CLI table output
format, that cause much work on parse string by using
regular expression. Using json format in functional tests
is better and easier way, the patch rework for port related
tests.

Change-Id: I0ec997bf63da4925742848c593db09d89655ca34
2017-02-21 07:35:02 +00:00
Jenkins
bc4a3f467f Merge "TODO cleanup: osc-lib" 2017-02-21 05:40:26 +00:00
Justin A Wilson
4d5f2c3925 Add Cinder v3 client support for volumes
Initial Cinder v3 support

Change-Id: Idd5074832e80697ed0671f06d3291dfd92dbfb08
2017-02-20 20:37:36 +00:00
Jenkins
477694db49 Merge "Use public and unified method get_console_url()" 2017-02-20 19:46:15 +00:00