Commit graph

1719 commits

Author SHA1 Message Date
Jenkins
f0e64eb55a Merge "Refactor TestRemoveProjectImage with FakeImage class" 2016-05-16 22:51:21 +00:00
Jenkins
11be59db8c Merge "Added --no-route to the router set command" 2016-05-16 22:51:15 +00:00
Jenkins
22e738c751 Merge "Refactor TestImageList with FakeImage class" 2016-05-16 22:46:09 +00:00
Jenkins
91fcca271e Merge "Refactor TestAddProjectToImage with FakeImage class" 2016-05-16 22:46:02 +00:00
Jenkins
c471a97aef Merge "Fix network router type display" 2016-05-16 22:39:53 +00:00
ting wang
69be96ae72 Refactor TestRemoveProjectImage with FakeImage class
Change-Id: Id40ea8a3cf59738fa254da0bca4ad6551565f5de
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-image-unittest-framework
2016-05-16 13:02:44 +08:00
Hideki Saito
bc93ebfe5c Added --no-route to the router set command
Deprecated --clear-routes

Closes-Bug #1565034

Change-Id: I4a8975edc026aecd2a362fd1929c984cfab8ade6
2016-05-16 12:02:00 +09:00
Richard Theis
fd5fd924d1 Additional network protocol support
Add the following network protocol support to the
"os security group rule create" command:
  - Add "--icmp-type" and "--icmp-code" options
    for Network v2 only. These options can be used to set
    the ICMP type and code for ICMP IP protocols.
  - Change the "--proto" option to "--protocol". Using the
    "--proto" option is still supported, but is no longer
    documented and may be deprecated in a future release.
  - Add the following Network v2 IP protocols to the
    "--protocol" option: "ah", "dccp", "egp", "esp", "gre",
    "igmp", "ipv6-encap", "ipv6-frag", "ipv6-icmp",
    "ipv6-nonxt", "ipv6-opts", "ipv6-route", "ospf", "pgm",
    "rsvp", "sctp", "udplite", "vrrp" and integer
    representations [0-255].

The "os security group rule list" command now supports
displaying the ICMP type and code for security group rules
with the ICMP IP protocols.

Change-Id: Ic84bc92bc7aa5ac08f6ef91660eb6c125a200eb3
Closes-Bug: #1519512
Implements: blueprint neutron-client
2016-05-14 07:54:41 -05:00
ting.wang
2724eaac5d Refactor TestImageList with FakeImage class
Change-Id: Ia60f75f65bba4c25a0a87b570b081424f982efca
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-image-unittest-framework
2016-05-14 14:20:56 +08:00
xiexs
2b4c543cdd Refactor TestAddProjectToImage with FakeImage class
Change-Id: I6733601f12389eb744dbf0be64b7c556356b4730
Co-Authored-By: ting wang <bx_wang@outlook.com>
Implements: blueprint improve-image-unittest-framework
2016-05-14 14:17:01 +08:00
Jenkins
e1c53250bc Merge "Refactor TestVolumeList with FakeVolume" 2016-05-12 12:23:34 +00:00
Jenkins
56680c83fe Merge "Add unit tests for "server show" command" 2016-05-11 13:26:55 +00:00
Jenkins
b60ff95edf Merge "Use find_resource() instead of get() in _prep_server_detail()" 2016-05-11 13:26:30 +00:00
ting.wang
553e154960 Refactor TestVolumeList with FakeVolume
Change-Id: Idbe7ee1d9688ea5937852cce1a746016bf98fa74
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-volume-unittest-framework
2016-05-11 17:25:48 +08:00
Jenkins
fe02162bd3 Merge "Implement "address scope set" command" 2016-05-11 07:59:04 +00:00
Jenkins
94de0d3ebd Merge "Implement "address scope show" command" 2016-05-11 07:11:43 +00:00
Jenkins
0acb743611 Merge "Implement "address scope list" command" 2016-05-11 07:11:36 +00:00
Jenkins
b503267616 Merge "Implement "address scope delete" command" 2016-05-11 06:53:56 +00:00
Jenkins
2aa99b4d50 Merge "Implement "address scope create" command" 2016-05-11 06:42:25 +00:00
Huanxuan Ao
cc78d48a28 Implement "address scope set" command
This patch add a command that supports
setting address scope properties.

Change-Id: I9c4b5068a8abb986a9dc18b167b48b924d16ff42
Closes-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
32da111c17 Implement "address scope show" command
This patch add a command that supports
showing address scope details

Change-Id: Ic0b41c1cab8c618904c7a6046d7493db5b74b430
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
aa5ff67e3f Implement "address scope list" command
This patch add a command that supports
listing address scopes

Change-Id: Id14757011560cacf28011ba51841a8e23b824f33
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
4cb5e0bc79 Implement "address scope delete" command
This patch add a command that supports
deleting a address scope

Change-Id: Ie028058c759b9511d105a530d7e89b841865e7d6
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
98bee08e0f Implement "address scope create" command
This patch supports creating a new address scope,
with --ip-version,--project,--project-domain
and --share or --no-share options.

Change-Id: I37c73391a41ac239dd72d55dbc0adbebd7701f4a
Partial-Bug: #1566269
2016-05-11 10:08:35 +08:00
Tang Chen
06780dd880 Add unit tests for "server show" command
Change-Id: I6eb0c4e7d5d3e677764b253e3324720a784a110b
2016-05-11 09:33:51 +08:00
Jenkins
c3acc4175b Merge "Ignore domain related config when using with keystone v2" 2016-05-09 15:52:24 +00:00
Jenkins
3f5fd2f9e1 Merge "Map server power state num to meanful string" 2016-05-09 13:36:56 +00:00
Tang Chen
d58280a279 Use find_resource() instead of get() in _prep_server_detail()
There is such a comment in test_server.py:

    # Call .get() to retrieve all of the server information
    # as findall(name=blah) and REST /details are not the same
    # and do not return flavor and image information.

This is an out of date comment. There is no function named
findall() in OSC now. So use find_resource() instead of get(),
and remove this comment.

Change-Id: I8d79afc5f341fb5caf771d905506b7f1c7a41ae8
2016-05-09 14:59:39 +08:00
Hieu LE
b8432408e6 Ignore domain related config when using with keystone v2
Currently, "/usr/bin/openstack --insecure token issue"
fails when OS_AUTH_URL and OS_IDENTITY_API_VERSION
indicate keystone v2 if OS_PROJECT_DOMAIN_NAME or
OS_USER_DOMAIN_NAME are set. This patchset ignore domain
related configs if using with keystone v2 and print warning
for each ignored config.

Change-Id: I8afbda787df7855c3f8e868b0f07cbf3b9cd97fd
Closes-bug: #1447704
2016-05-09 12:29:44 +07:00
Jenkins
fbd48be2ac Merge "Trivial: Remove unuseful comments for assertRaise() checking" 2016-05-07 11:35:05 +00:00
Tang Chen
809239ca1e Map server power state num to meanful string
In _prep_server_detail(), power_state is not formatted
by _format_servers_list_power_state(). So when executing
"server show" or "server create", the power state is
represented by number. This patch map the numbers to
meanful strings.

This patch also adds power_state attribute to FakeServer,
and improves unit tests for this attribute.

Change-Id: I2ec674327de4e5133b8712ba6bb53fa5ce55e3f4
2016-05-07 14:54:44 +08:00
Jenkins
467ed54d6d Merge "Make "flavor show" command to show a private flavor properly" 2016-05-06 14:07:54 +00:00
Tang Chen
15c9576817 Trivial: Remove unuseful comments for assertRaise() checking
"Missing required args should bail here" is not understandable
and not necessary. The code is obvious enough. And some of the
comments are misused because of code copy. So remove them.

Change-Id: I031395f2c882386c7a708db5cf4eee75393dc639
2016-05-06 19:55:50 +08:00
Jenkins
5df18843b7 Merge "Ignore domain related config when using with keystone v2" 2016-05-06 10:20:16 +00:00
Tang Chen
f91685f391 Remove unnecessary type conversions in network unit tests
In some tests, when comparing the results data with the
expected ones, many unnecessary type conversions are used.
So remove them to clean up.

Change-Id: I560ca78a3ab5e7b99087bfe1667de500f92c68de
Partial-bug: #1550633
2016-05-06 03:42:27 +00:00
Hieu LE
59de9c477c Ignore domain related config when using with keystone v2
Currently, "/usr/bin/openstack --insecure token issue"
fails when OS_AUTH_URL and OS_IDENTITY_API_VERSION
indicate keystone v2 if OS_PROJECT_DOMAIN_NAME or
OS_USER_DOMAIN_NAME are set. This patchset ignore domain
related configs if using with keystone v2.

Change-Id: If7eea2ed1a4877c60d055ed0114a5e5f31e282a0
Closes-bug: #1447704
2016-05-06 03:42:15 +00:00
Richard Theis
9f3fa5ee3b Fix network router type display
The OpenStack SDK maps the network "router:external" field to
"is_router_external". However, OSC was using the incorrect
mapping, "router_external".  This caused OSC to display router
type as "Internal" for all networks.

Change-Id: Ifcd1349ab7c5881baee751936d076bf6aa058852
Closes-Bug: #1572228
2016-05-05 15:01:36 -05:00
Jenkins
9f91eadb2b Merge "Add a unit test for "flavor create" command" 2016-05-05 15:44:36 +00:00
sharat.sharma
f924fa39e1 Added "name" parameter to the help message.
In OS_IDENTITY_API_VERSION=3, the "openstack help service delete"
allows the user to remove a service based on the name of the
service. So, this patch includes name as positional argument.

Change-Id: Iae7cb0a82af3cdd4d88e0ed2eb651abf9af30fd9
Closes-Bug: #1566909
2016-05-04 12:57:07 +00:00
Huanxuan Ao
68224eafc3 Add a unit test for "flavor create" command
There was not a unit test for "flavor create" command
in the "test_flavor.py".So I add the unit test.

Change-Id: Ib1e821ea524eb33c0ba73643164228c7b83253b4
2016-05-04 18:55:49 +08:00
Jenkins
bf9b0e5ff4 Merge "Fix router set --route option" 2016-05-03 12:54:58 +00:00
Michael McCune
b33ee3daf6 remove assert in favor an if/else
the assert usage in the NonNegativeAction has the potential to allow
unexpected behavior when the python is byte-compiled with optimization
turned on.

Changes
* remove assert in favor of if/else in NonNegativeAction class
* add type specifier to parser arguments for non-negative actions
* correct tests for new int based values

Change-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e
Closes-Bug: #1576375
2016-05-02 15:11:45 -04:00
Jenkins
9d7ccd9385 Merge "Fixes BadRequest when no --pool-prefix given" 2016-05-02 16:37:54 +00:00
Huanxuan Ao
681d6dc2de Make "flavor show" command to show a private flavor properly
The "flavor show" command could not show a
private flavor by flavor name becauce it could
not find a private flavor by flavor name.
In "until.find_resource(parsed_args.flavor)",
If parsed_args.falvor is a name of a flavor,
"flavors.find(name=parsed_args.flavor)"will be
called to find a flavor.But the default value of
"is_public" is "Ture" in "flavors.find()" so that
we can only find public flavors.If we want to find
all flaovrs by flavor name,we should add
"is_public=None" in "flavors.find()".

So I tried to change
"until.find_resource(parsed_args.flavor)" to
"until.find_resource(parsed_args.flavor, is_public=None)",
but then I could not find any flavor by flavor id
because "is_public" is an unexpected argument of
"flavors.get()" in "until.find_resource()".

In this case,I think "until.find_resource()"
can not find a private flavor properly,and
we should combine "manager.get(flavor.id)" and
"manager.find(name=flavor.name, is_public=None)"
by ourselve to find a flavor.

Also,this bug affects other flavor commands like
"flavor set/unset/delete",so I fix them in this patch too.

Change-Id: I4a4ed7b0a2f522ee04d1c3270afcda7064285c39
Closes-Bug: #1575478
2016-05-02 16:47:53 +08:00
Jenkins
6bf60180a2 Merge "Fix error in flavor set/unset command" 2016-04-28 16:14:13 +00:00
Jenkins
941217a5f3 Merge "Support for volume service list" 2016-04-28 16:13:46 +00:00
Huanxuan Ao
4524b3605f Fix error in flavor set/unset command
In the "flavor set/unset" command,the "flavor" parameter
can be a name but can not be a id of a flavor.
I think we should find a flavor by using "utils.find_resource()"
in these commands.

Change-Id: I5836788f7ed18813f1ebde31bb808b7c3f932b80
Closes-Bug: #1575624
2016-04-28 19:59:53 +08:00
Inessa Vasilevskaya
08759b853a Fixes BadRequest when no --pool-prefix given
--pool-prefix is made required on subnetpool creation.
Closes-bug: #1536479

Change-Id: I3d183e45e9b96bc08011c36f45ec2b7a9c01b627
2016-04-27 18:38:35 +03:00
Jenkins
74162fa31a Merge "Support quota show for current project" 2016-04-25 21:15:43 +00:00
Sheel Rana
4072554608 Support for volume service list
OSC does not support to list volume services.
This patch will provide support for adding volume service related
support.

Closes-bug:#1550999

Implements: bp cinder-command-support

Change-Id: I50ac14aeb96c4b8ddbf7b33e519feea0d126f752
2016-04-25 17:42:12 +00:00