Compare commits

...

6101 commits

Author SHA1 Message Date
Andriy Kurilin
0a93733293 Fix quota usage and reservation display
Fix `openstack quota show --usage` to correctly display resource usage
and reservations by applying proper name normalization for corresponding
sections of data.
Previously, name normalization was applied only for "limits" which is
the root section, leaving 'usage' and 'reservation' sections untouched.

Change-Id: Id14fe894b30a74b9b8d78b00c3d4ff151f8b4210
Closes-bug: #2137636
Signed-off-by: Andriy Kurilin <andr.kurilin@gmail.com>
2026-01-07 13:29:49 +01:00
Zuul
d1a0ede7db Merge "zuul: Make openstackclient-check-plugins voting" 2025-12-19 19:38:24 +00:00
Abhishek Kekane
ed2dc692dd Fix image owner change when accepting membership with --project
When using 'openstack image set --project <project> --accept <image>',
the command incorrectly changed the image owner. The --project parameter
when used with membership flags should only identify which member's
status to update, not change ownership.

Closes-Bug: #2136795
Change-Id: I1044b51f38000fb5339740bc40c7f8645c794402
Signed-off-by: Abhishek Kekane <akekane@redhat.com>
2025-12-18 14:01:45 +00:00
Zuul
85fccc7a91 Merge "typing: Fixups for typed osc-lib" 2025-12-16 18:13:51 +00:00
Zuul
08b1bb70dd Merge "taas: Use custom command classes" 2025-12-16 18:13:48 +00:00
Zuul
58210a141a Merge "fix(keystone): correct the args submitted on user creation" 2025-12-15 19:56:34 +00:00
Doug Goldstein
0b05fd8968
fix(keystone): correct the args submitted on user creation
When a user is created without a password then no parameter called
'password' should be submitted to the keystone API. This removes the
incorrect 'password' with null being supplied.

Closes-Bug: 2136148
Change-Id: If1c2eb5db360764a5f7660ce4e5353da85b6d3da
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
2025-12-15 10:14:41 -06:00
Stephen Finucane
e8ae075c38 typing: Fixups for typed osc-lib
Change-Id: I436983a13e8812d704af2f1eb3f600277ef8a531
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-15 11:38:36 +00:00
Stephen Finucane
7246a07834 taas: Use custom command classes
In change I53d9058273748ecd4d4eecec5f7291d5f38ce5ab we added custom
Command classes for typing purposes. However, the Tap-as-a-Service code
merged around the same time and was missed. Correct this.

Change-Id: I3a9fe20b5b8eb54708644527538f27396f29b476
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-15 11:27:56 +00:00
Stephen Finucane
8dbb7126c6 identity: Use plural dest for append opts
Change-Id: I73a263a309e022b7606ced43a814a1d1914bc751
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-15 11:25:43 +00:00
Zuul
43ffea5c4d Merge "Remove functional testenv for py38/py39" 2025-12-12 17:59:10 +00:00
Koya Watanabe
f2f0f92d41 Remove functional testenv for py38/py39
Python 3.8 and 3.9 are no longer supported.
Refer to pyproject.toml for the current supported versions.

Change-Id: Ie7f917c26299509050294037cc27e1fd9c20e78b
Signed-off-by: Koya Watanabe <koywatan@lycorp.co.jp>
2025-12-12 14:49:33 +00:00
Stephen Finucane
748cff5914 zuul: Make openstackclient-check-plugins voting
This will ensure we do not forget to ignore a module when migrating
plugins in-tree.

Change-Id: Id4dd657746f7c5f8ebf5ef55964593123303b996
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstackclient/+/970618
2025-12-12 11:39:24 +00:00
Stephen Finucane
841d95b095 common: Remove references to pkg_resources
Even though the comment here attributed this to stevedore, it was in
fact the use of pkg_resources that changed things.

Change-Id: I35377dd7d773024aa6423b72b1412e11b1b6f2e4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-12 10:32:12 +00:00
Stephen Finucane
a7e2f31ecc volume: Remove negotiation for v1 API
Change Ibe1cd6461d2cb78826467078aa17272f171746aa removed support for the
v1 volume API. We should have removed this check at the same time.

We also remove some god-awful monkey patching that references v1
cinderclient but in practice modified all clients.

Change-Id: I3727fd9238df966b3bc59812c5efcf3398da5c72
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-12 10:32:12 +00:00
Zuul
de4e119272 Merge "typing: Add types to custom formatters" 2025-12-11 21:56:06 +00:00
Zuul
30f3192b8d Merge "Add custom command classes" 2025-12-11 21:42:13 +00:00
Zuul
cc36d929b3 Merge "clientmanager: Remove legacy cruft" 2025-12-11 21:32:52 +00:00
Stephen Finucane
e799a4a676 typing: Add types to custom formatters
We make a lot of use of typing.Any just to get this over the line. We
can come back to this later.

Change-Id: I03c18b0b44f210b2ad3e4012344d521fb85cae97
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 18:55:15 +00:00
Stephen Finucane
3cd544df53 Add custom command classes
These are effectively identical to the osc-lib variants except they
include the attributes that the OSC shell implementation will set on
this during shell init. This helps from a typing perspective.

Change-Id: I53d9058273748ecd4d4eecec5f7291d5f38ce5ab
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 18:55:13 +00:00
Zuul
c59bf71fb7 Merge "Use openstacksdk test generate_fake_resources factory" 2025-12-11 15:50:51 +00:00
Zuul
924822507a Merge "Implement conflict resolution" 2025-12-11 15:50:49 +00:00
Zuul
65801e7e58 Merge "Improve help strings for tap services" 2025-12-11 15:03:09 +00:00
Zuul
f2810a83b0 Merge "Moving tapas osc client code from neutronclient" 2025-12-11 15:03:06 +00:00
Stephen Finucane
3fbe41cd52 clientmanager: Remove legacy cruft
No has used Initialize functions in years, while the _auth_required
attribute has long since been handled by the base class in osc-lib.

Change-Id: I3af9a6d8c339b2170a13346b009392d51e044443
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 13:31:26 +00:00
Miro Tomaska
dedc1a342c Use openstacksdk test generate_fake_resources factory
Instead of building fake test objects in the local fakes.py file,
use existing generate_fake_resource(s) factory methods to automatically
populate class attributes. Doing this ensures that fake objects are always
build with actual attributes of the class.

Change-Id: If424b87c79e7dab102cbd8a7938df85411c9465d
Signed-off-by: Miro Tomaska <mtomaska@redhat.com>
2025-12-11 13:28:38 +00:00
Stephen Finucane
060299c749 Implement conflict resolution
Take advantage of functionality recently introduced in cliff to allow us
to prefer commands that are in-tree over those provided via plugin
packages. This will allow us to move the extensions themselves in-tree.

Change-Id: I5dd9bc9743bea779ea1b4a71264c9a77c80033b3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 13:17:24 +00:00
Takashi Kajinami
92a277ff4c ruff: Enable E5 check
... to enforce maximum line length, to keep consistent code format.

Note that E501 check is disabled in test code now, until we decide how
to update ~50 lines violating the limit due to too long names.

Change-Id: I122c8b9035d6381dafb34438517c26b01e5201f5
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
2025-12-11 02:43:20 +09:00
Miro Tomaska
9e49047ed1 Improve help strings for tap services
This is a follow up patch to feedback from[1]

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/963445/comment/8f9576d4_938391ea/

Change-Id: I1c1ee68b37ef4c87c13d18e773c19b4ca5814ead
Signed-off-by: Miro Tomaska <mtomaska@redhat.com>
2025-12-08 19:00:45 +00:00
Miro Tomaska
97c2238df1 Moving tapas osc client code from neutronclient
Proposal to move all stadium projects from neutronclient
to openstackclient repo. Tap-as-a-service is the first example.
The tapas osc client code was recently moved to neutronclient see
https://review.opendev.org/c/openstack/tap-as-a-service/+/960849
but proposal is to make openstackclient its final destination.

This change also includes automatic lint fixes required in
this repo.

Change-Id: Ied47f40c6947600d40bf675ec06f0bf88fd15f1f
Signed-off-by: Miro Tomaska <mtomaska@redhat.com>
2025-12-08 13:22:12 -05:00
Zuul
f8effe997e Merge "Change metavar name for registered limit delete" 2025-11-26 12:29:54 +00:00
Zuul
79db64f264 Merge "Remove duplicate test utilities" 2025-11-25 14:47:22 +00:00
Stephen Finucane
fb6dad48db Remove duplicate test utilities
We cannot remove them fully, but we can remove a lot of them. Further
cleanup is needed here to remove the references but that will be done
once a version of osc_lib with fixes is included.

Change-Id: Ifd200bd3d3e5c02c239a8ad0e6cee6d823e26544
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-25 12:06:49 +00:00
Luan Utimura
4132ca1818 volume: Add missing backup_id field in tests
This change also reverts commit:
  * 5f1ffe742c

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/958801
Change-Id: Icac78179bc324e6fbe762f8095f2cba490ef6aea
Signed-off-by: Luan Utimura <luan.utimura@luizalabs.com>
2025-11-24 13:50:38 -03:00
0weng
0411805608 Change metavar name for registered limit delete
Change registered limit argument to plural and remove `id` suffix for
`registered limit delete` command. Also, note that service can be
specified by name or ID in help description.

Change-Id: I16950a5ac1a197761592304dcb71dcb09d608d78
Signed-off-by: 0weng <oweng@osuosl.org>
2025-11-19 14:29:31 -08:00
Brian Haley
c17c5f0df6 Try to make help text of network code consistent
Just change all text to be as consistent as possible.

TrivialFix

Change-Id: I959cda9b0688f0fcec0f55ce4c8cadf209d3537f
Signed-off-by: Brian Haley <haleyb.dev@gmail.com>
2025-11-18 19:39:15 -05:00
Zuul
d6b2f42cfb Merge "hacking: Check for missing ignore_missing calls" 2025-11-17 10:58:12 +00:00
Zuul
e9b720e1c7 Merge "trivial: Add missing ignore_missing arguments" 2025-11-17 10:57:14 +00:00
Zuul
0b88ea4fab Merge "identity: Remove duplicated _find_sdk_id method" 2025-11-17 10:28:13 +00:00
Zuul
d7e71480d4 Merge "identity: Fix filtering endpoints by project with domain" 2025-11-17 10:28:11 +00:00
Zuul
351d537cb0 Merge "trivial: Normalize some client usage" 2025-11-17 10:26:43 +00:00
Stephen Finucane
db6c34c2c7 hacking: Check for missing ignore_missing calls
This comes up in reviews frequently. Let's automate it.

Change-Id: Ia7ebd7cf29fe4550b22921e898bebaaa5f7bb4f6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-14 11:54:41 +00:00
Stephen Finucane
73021165ff trivial: Add missing ignore_missing arguments
This prevents a class of bugs.

Change-Id: I96e1cd8ed4a682ef5c95f67f3d1246f7026eada9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-14 11:54:40 +00:00
Stephen Finucane
55fd501657 identity: Remove duplicated _find_sdk_id method
We have a few instances of this. Settle on one.

Change-Id: Id115fea1c59ad75ec8e00d665e587020f7177a55
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-14 11:51:02 +00:00
Stephen Finucane
a5e4d5f0fa identity: Fix filtering endpoints by project with domain
We were incorrectly passing domain_id as a positional argument, causing
it to get picked up as the ignore_missing argument instead. Correct
this, fixing another bug where the look of projects or domains could be
forbidden by policy, in the process. The latter is unlikely to happen,
given endpoint lookup is typically an admin-only operation, but it's
better to be safe.

Change-Id: Idd3300040967d781b7743accd62298cb24c62872
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-14 11:47:18 +00:00
Stephen Finucane
db2c1a5e2b trivial: Normalize some client usage
Ahead of rework in this area.

Change-Id: I1b1c2370967381903970870da8cbe0868b1e23e1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-13 15:20:35 +00:00
Zuul
0e8aa79f9f Merge "Add functional tests for image metadef resource type list" 2025-11-13 15:17:36 +00:00
Zuul
3b6f9ee7ba Merge "Add functional test for cached image command" 2025-11-13 13:34:57 +00:00
Zuul
7505186a41 Merge "ruff: Use more specific name to enable pyupgrade rule" 2025-11-11 20:10:45 +00:00
Takashi Kajinami
188737c69c ruff: Use more specific name to enable pyupgrade rule
UP is the exact name of the rule, instead of U. Use the exact name to
avoid potential problems caused by any UX rules which can be added
in the future.

Change-Id: I5fa59181fcd3e28bf3c87ce2a5e610561b2ee8a8
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
2025-11-12 01:41:37 +09:00
Zuul
1b6df0b5bb Merge "Add new hacking rules" 2025-11-07 18:17:29 +00:00
Zuul
232a0ab68d Merge "tests: Avoid more unnecessary mocks" 2025-11-07 17:18:53 +00:00
Zuul
23f47e0dab Merge "tests: Remove duplicated fake network client" 2025-11-07 17:18:50 +00:00
Stephen Finucane
eb7c4c61a9 Add new hacking rules
To catch some obvious issues.

Change-Id: Ic0ddc95100811e7b313b519aad7d687a1415020b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-07 15:45:51 +00:00
Stephen Finucane
33d34bdfe8 Remove tests for other osc-lib
These are already found in osc-lib itself.

Change-Id: I51114a5a79d6cd6ea46f60284066132b2e54a1a5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-07 14:14:05 +00:00
Stephen Finucane
7116449190 tests: Avoid more unnecessary mocks
Change-Id: I04672d46595e93b19f873a54d5be9363d262370b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-07 14:06:36 +00:00
Stephen Finucane
44dfa157e4 tests: Remove duplicated fake network client
This must have crept in some time after [1] merged.

[1] Ic203964c7dede7dd80ae2d93b8fa1b7e6634a758

Change-Id: Ic0603db8b1a59b7704c51b0e0ffceb7db2e781d3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-07 12:43:11 +00:00
OpenStack Release Bot
3cc6b24bb5 reno: Update master for unmaintained/2024.1
Update the 2024.1 release notes configuration to build from
unmaintained/2024.1.

Change-Id: Ia4fff2a8e0f9bb083423c2e5c7339a46aaccd271
Signed-off-by: OpenStack Release Bot <infra-root@openstack.org>
Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/change_reno_branch_to_unmaintained.sh
2025-10-31 12:05:25 +00:00
Zuul
492a184add Merge "Add option to filter for projects when listing volume backups" 2025-10-22 17:51:49 +00:00
Jan Ueberacker
305e037df2 Add option to filter for projects when listing volume backups
Change-Id: Idb07c1be90a98b65b6c1b8f888d0ca5309f8cbc4
Signed-off-by: Jan Ueberacker <jan.ueberacker@inovex.de>
2025-10-22 16:33:09 +02:00
Zuul
b0763f9f9a Merge "Extend project delete command description" 2025-10-14 18:46:12 +00:00
Stephen Finucane
20ad83bf84 pre-commit: Bump versions
We need to rename two hooks.

Change-Id: I15582a23da6ea6babf2b277ff443b7cdb764c9f9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-10-10 10:40:55 +01:00
Zuul
b28b3249de Merge "Fix openstack quota show without cinder" 2025-10-02 13:40:36 +00:00
Zuul
4282a512c0 Merge "identity: Fix 'user list --project' option" 2025-10-02 12:29:02 +00:00
Stephen Finucane
0ed122094a identity: Fix 'user list --project' option
The 'role_assignments_filter' identity proxy method requires either a
user or group, which defeats the entire purpose of the command when used
with this option. Use 'role_assignments' instead.

Change-Id: I8fb705c55fb4e81fa82d4a7dbe4c5bf7e1edd98a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #1616104
2025-10-02 09:58:46 +00:00
Matt Anson
fb8cdd4441 Ensure show on absent appcreds raises exception
Currently, running ``application credential show`` on a
non-existent appcred will exit normally and display a
formatted application credential with no data, despite
the Keystone API returning a 404.

Ensure that querying a non-existent application
credential raises an exception message and an exit-code
1 to the user.

Closes-Bug: #2126565
Change-Id: I597d2d4064f1020c5ac40862ecc556f3c94b53eb
Signed-off-by: Matt Anson <matta@stackhpc.com>
2025-10-01 14:36:17 +01:00
Thomas Goirand
de88853de2 Fix openstack quota show without cinder
Per this Debian bug [1], 'openstack quota show --default' fails when
cinder is NOT installed. This is also true of other services.

[1] https://bugs.debian.org/1109288

Change-Id: I361da44b9f1d09ba3a454632d41e2110a3815395
Signed-off-by: Svein-Erik Skjelbred <svein-erik@skjelbred.com>
Signed-off-by: Thomas Goirand <zigo@debian.org>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-09-30 10:32:44 +01:00
wonjun0120
4cf70113d2 Add functional test for cached image command
Implements tests for cache clear operations including queue,
cache, and combined clearing functionality.

Change-Id: I71056bb5db6c3de4f9294ac1b661ab927f59c867
Signed-off-by: wonjun0120 <wonjundero@gmail.com>
2025-09-25 23:44:09 +09:00
jiwonjang
6b6a9bafd8 Add functional tests for image metadef resource type list
Implements functional tests for 'image metadef resource type list' command.

Change-Id: If645a04d4b8800da44041769f08b1e81332af33c
Signed-off-by: jiwonjang <kooriangman@gmail.com>
2025-09-25 21:12:10 +09:00
Alexey Stupnikov
c0ada2d6ab Extend project delete command description
"openstack project delete" command doesn't try to figure out if
other services are using specified project somehow before trying
to delete it. This patch extends command description to ensure
that this is clearly communicated to users.

Related-bug: #2118900
Change-Id: I3ae0b2a8f04d4f791cab46ccd89f400549d24ecd
Signed-off-by: Alexey Stupnikov <aleksey.stupnikov@gmail.com>
2025-09-19 19:37:28 +02:00
OpenStack Release Bot
3c3ea30bd3 Update master for stable/2025.2
Add file to the reno documentation build to show release notes for
stable/2025.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2025.2.

Sem-Ver: feature
Change-Id: I6aec2d1f91ed7fc2dba466574b4efb92b4bd7c88
Signed-off-by: OpenStack Release Bot <infra-root@openstack.org>
Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/add_release_note_page.sh
2025-09-16 08:11:27 +00:00
Zuul
8f3277326c Merge "Validation: Cannot create network with segmentation id alone" 2025-09-11 17:49:10 +00:00
dlawton
b808b82dfb Validation: Cannot create network with segmentation id alone
Change-Id: I7d98921fe6f2819a6427bc826d640a6685a00da7
Signed-off-by: Dan lawton <dlawton@redhat.com>
Closes-bug: #1693106
2025-09-11 15:28:51 +00:00
Zuul
afcce59c8d Merge "Add functional tests for role assignment list" 2025-09-10 11:02:58 +00:00
doburn
a5a6ec27e5 Add functional tests for role assignment list
Implements tests for `role assignment list` domain options.

The options covered are:
- `--user-domain`
- `--group-domain`
- `--project-domain`
- `--role-domain`

Change-Id: Ia42dcc337df0de7d5a93250696b807038a2d9d0e
Signed-off-by: doburn <kwon2852@gmail.com>
2025-09-10 16:07:25 +09:00
Zuul
bc98e21559 Merge "tests: Simplify catalog functional tests" 2025-09-09 22:48:09 +00:00
Zuul
475d69efad Merge "Bug Fix: Skip invalid server ID during multi-server delete" 2025-09-08 19:43:25 +00:00
dlawton
3dfeb5ed08 Bug Fix: Skip invalid server ID during multi-server delete
Change-Id: I8e5339f07b43dd0a9422eaf33346bbfdf2c9b328
Signed-off-by: Dan Lawton <dlawton@redhat.com>
Closes-Bug: #2122056
2025-09-08 17:13:47 +01:00
Rajesh Tailor
e7554603ac Fix microversion 2.100
This change fixes missing conditional logic for microversion
2.100 which adds support for showing `scheduler_hints` field
to `openstack server list --long` output.

Change-Id: I2820e02a91deb73850f37dc737dbec79dea99e8d
Signed-off-by: Rajesh Tailor <ratailor@redhat.com>
2025-09-03 16:53:35 +05:30
Stephen Finucane
5f1ffe742c volume: Temporarily ignore Volume.backup_id column
We really need a better way to do this.

Change-Id: I631748e2dfe3c136156d7987eab952370a88d35b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related: https://review.opendev.org/c/openstack/openstacksdk/+/958801
2025-08-29 13:31:58 +01:00
minkyukim
68d1d01b2a tests: Simplify catalog functional tests
Combine multiple test cases into a single test case, in order to
speed up execution.

Change-Id: Idcfd0c8c5b7418046601d222248c0cd16886e079
Signed-off-by: minkyukim <mj110602@gmail.com>
2025-08-24 04:29:44 +09:00
Stephen Finucane
94e447af80 tests: Remove use of namedtuple
Change-Id: I19a272ffd260bab263dd63cb920802b792e192eb
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-08-20 17:41:21 +01:00
Rajesh Tailor
dbddbf9760 Fix microversion 2.96
This change fixes missing conditional logic for
microversion 2.96 which adds `pinned_availability_zone`
field to `openstack server list` output.

Change-Id: I1e398bb3379fa6443b0a44db76baaf6241a945e7
Signed-off-by: Rajesh Tailor <ratailor@redhat.com>
2025-08-20 18:19:13 +05:30
Zuul
34f431bade Merge "compute: Fix flavor create --id auto" 2025-08-18 16:59:33 +00:00
Artem Goncharov
a312e9cdad Adopt sdk_fakes for compute.test_flavor
Use sdk_fakes inside test_flavor. The only left fake is for
flavor_access, for which there is no resource in SDK.

Change-Id: I8fcfb734eb45308b80aa1478c2935c9881fee928
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
2025-08-18 13:57:56 +01:00
Stephen Finucane
5feaa952ad compute: Fix flavor create --id auto
This was inadvertently broken during the switch from novaclient to SDK.
Fix it for now but also deprecate it since it is an unnecessary alias.

Change-Id: Iaf136d82e00defc86e57ae4ea7e848246f2ade2c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2120833
2025-08-18 12:20:44 +01:00
Zuul
d90e18b08c Merge "Support image save with chunk-size option" 2025-08-15 13:37:16 +00:00
Zuul
6ba9473cdb Merge "Adds CLI support for `glance md-namespace-properties-delete`" 2025-08-15 13:37:13 +00:00
Zuul
ae7e8448ba Merge "image: Add hashing-related fields" 2025-08-15 13:18:10 +00:00
Mridula Joshi
2177f07dfb Adds CLI support for `glance md-namespace-properties-delete`
This patch modifies the command to delete all metadef properties
inside a namespace. This operation can be called by `image metadef
property delete`

Change-Id: Iff9bda0dddfa157be0438a66d1d05da7b0b437c3
Signed-off-by: Mridula Joshi <mrjoshi@redhat.com>
2025-08-15 11:16:46 +00:00
Artem Goncharov
a73698490a image: Add hashing-related fields
Add support for the 'os_hash_algo' and 'os_hash_value' image attributes
added with Image API 2.7.

Change-Id: Id8fe6f3fecf77f537587e9088b207ef2077a9def
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
2025-08-15 12:01:58 +01:00
Hang Yang
13fe801968 Support image save with chunk-size option
Add '--chunk-size' option to 'image save' command to control the size of
bytes to read at one time.

Change-Id: I0a02323384433010b8c6804a4337040acb13da8f
Signed-off-by: Hang Yang <hangyang@verizonmedia.com>
2025-08-15 11:59:30 +01:00
Stephen Finucane
81db99b32b doc: Indicate md-namespace-import as WONTFIX
This is a meta command that can be easily achieved via some shell
scripting. We don't need it in OSC.

Change-Id: Ia3fc8d0458cb0c0dc4695347ef953028112a9c49
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-08-15 11:47:12 +01:00
Zuul
37228ae2d3 Merge "tests: Avoid unnecessary mocks" 2025-08-15 04:48:40 +00:00
Zuul
87fe04ae08 Merge "tests: Simplify mocking in server tests" 2025-08-15 04:48:26 +00:00
Zuul
7bb5857081 Merge "Remap custom named Image attributes when unsetting" 2025-08-15 04:48:23 +00:00
Zuul
a8751b00fe Merge "Add device ID and device owner to port unset" 2025-08-15 03:29:28 +00:00
Zuul
2a492fb58a Merge "Remove leading empty line from server create with --wait" 2025-08-15 03:29:22 +00:00
Zuul
ad2a511434 Merge "Replace deprecated assertItemsEqual" 2025-08-14 13:34:42 +00:00
Zuul
8a88d65a67 Merge "docs: Add note about scoping on tokens" 2025-08-14 11:10:19 +00:00
Stephen Finucane
a99ae364fc tests: Avoid unnecessary mocks
Change-Id: Ibb1bf5c29bf37d3f31889b091a055d0308e8cd85
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-08-14 12:03:16 +01:00
dna
e8a7db5858 tests: Simplify mocking in server tests
Replace assignments of `Mock` objects to methods that are already
mocked in the class functions within test_server.py

Change-Id: I446632301c1b9f94545a0b8314e54e761d5d296f
Signed-off-by: dna <la18byeol@gmail.com>
Story: 2011459
Task: 52211
2025-08-14 12:03:00 +01:00
Mridula Joshi
9f55b253a3 Adds CLI support for `glance md-namespace-objects-delete`
This patch adds operation which delete all metadef object inside a
namespace.
This can be implemented by `image metadef object delete`

Change-Id: Ib196e295aad1921d8bc0c451522e0ad530389134
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/901671
Signed-off-by: Cyril Roelandt <cyril@redhat.com>
2025-08-07 20:25:50 +02:00
Alexey Stupnikov
e37148484c Remap custom named Image attributes when unsetting
Some Image attributes defined in openstacksdk are named differently
from actual properties managed by Glance. Because openstackclient
checked property names to be unset against Image object properties,
it was impossible to unset such properties.

This patch introduces a IMAGE_ATTRIBUTES_CUSTOM_NAMES dictionary
mapping real property names with custom attribute names.

Closes-bug: #2115732
Change-Id: I7296fc293dff9208464c9a07f58ce3e9ffabd3e9
Signed-off-by: Alexey Stupnikov <aleksey.stupnikov@gmail.com>
2025-07-29 18:24:57 +02:00
Alexey Stupnikov
46b25c7c0b network: Add '--project' to SG rule list command
Include '--project' and '--project-domain' filtering options to the
'security group rule list'.

Closes-Bug: #1648317
Change-Id: I19e423906846073cfa1e45b4a295b3a8f5d11970
Signed-off-by: Alexey Stupnikov <aleksey.stupnikov@gmail.com>
2025-07-24 18:06:03 +02:00
Stephen Finucane
c7d465a221 volume: Migrate 'volume show' to SDK
Change-Id: Ibd9d7a62c2500a1f31aa2d3d13ac7e8bad4e6964
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-07-18 11:38:26 +01:00
Stephen Finucane
5e5f12ba40 volume: Migrate 'volume migrate' to SDK
Change-Id: I99af5fce0c2c184e300dfbf5624b91eeed38c94b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-07-18 11:20:42 +01:00
Stephen Finucane
504cbd24e2 volume: Migrate 'volume create' to SDK
We need a shim for consistency group support, which we may eventually
port to SDK but have not yet. Otherwise, this is rather straightforward.

Change-Id: Ic880b7a64cde2148c266d549c4768c669ba3f501
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/943800
2025-07-17 16:41:46 +01:00
Doug Goldstein
51ecb5f984
volume: fix volume service set call
The command line operation could never work due to the incorrect call of
the openstacksdk API. This is updated to make it work and report errors
back to the user.

Closes-Bug: #2116969
Change-Id: I87cc410853c03b00dd1549d67cb1b9a8145bcfaa
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
2025-07-16 08:48:45 -05:00
Zuul
ffa37bab12 Merge "Add is_shared to security_groups" 2025-07-15 15:32:51 +00:00
elajkat
1b2dfeacf4 Add is_shared to security_groups
Change-Id: I1ff4aa9c6579699e6b479fdb429668de894cd012
Related-Bug: #1999774
Signed-off-by: elajkat <lajos.katona@est.tech>
2025-07-15 14:27:46 +01:00
Zuul
9d3a956a54 Merge "Add metadata as a filter condition when listing volumes" 2025-07-04 11:51:51 +00:00
ohjiwoo
572eeb6d38 Add metadata as a filter condition when listing volumes
When listing volumes, the API provides metadata as a query parameter, but this feature is not implemented in the client code. So add parameter.

story: 2011487
task: 52446
Change-Id: I4bf66d4e073c86296fa96ee29c2b33d771e18293
Signed-off-by: ohjiwoo <jiwooo.oh@samsung.com>
2025-07-04 09:28:40 +00:00
Takashi Kajinami
b6af7883b7 Replace deprecated assertItemsEqual
It has been provided by testtools to ease migration from python 2, but
was deprecated in 2.7.2[1] and will be removed in 2.8.0[2].

[1] https://github.com/testing-cabal/testtools/commit/e0d56b7ce65ae5b3d
[2] https://github.com/testing-cabal/testtools/commit/f01e86084e6a858d1

Change-Id: I8b68212a88553aff5c3b4182c246b3c0f7365cf6
2025-06-27 23:46:22 +09:00
Stephen Finucane
4ea3deda61 Remove duplicate Python version declarations
ruff can automatically detect this [1] now that it is defined in
pyproject.toml. mypy defaults to the version of Python used to run mypy
[2][3] so we need to keep its configuration around a while longer.

[1] https://docs.astral.sh/ruff/settings/#target-version
[2] https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version
[3] https://github.com/python/mypy/issues/19349

Change-Id: If5b3e6ff2483d73d5ff54cc28c1558cb9852b464
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-06-27 09:23:06 +01:00
Stephen Finucane
1b4fe6fac1 Migrate setup configuration to pyproject.toml
Change-Id: If7a6252ce751e875881654965762f6f514a15342
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-06-27 09:22:45 +01:00
Takashi Kajinami
ea85c7aa4d Replace deprecated datetime.utcfromtimestamp
It was deprecated in Python 3.12 in favor of datetime.fromtimestamp[1].

[1] https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp

Change-Id: Ia805157eaecac0c61d4c5f88daa430ec6d69a9d4
2025-06-18 18:15:52 +09:00
psnew14
edb17881d0 Remove leading empty line from server create with --wait
The "openstack server create" with "--wait" args was priting an extra empty line character before the server ID.
This commit removes the extra empty line.

story: 2010947
task: 48984
Change-Id: Ib5ba1c9f23e7655ddfae0e5b644ed167ecd6485e
2025-06-01 22:50:55 +09:00
Zuul
f4c4a7343c Merge "Fix openstack image import --method web-download --uri 'invalid value'" 2025-05-30 17:15:43 +00:00
Zuul
d5e6392454 Merge "identity: Remove unnecessary helper" 2025-05-30 14:37:41 +00:00
djp
9ad18c4967
Fix openstack image import --method web-download --uri 'invalid value'
although python-openstackclient run command(image import) with invalid uri,
but the request succeeds. Fixed it to throw an exception
when requesting with an invalid URI.

unit test added. the test cover --uri 'invalid value'

Task: 52251
Story: 2011468
Closes-Bug: 2111777
Change-Id: I62cd8cdf054b6a5e07d664a543b0923ce5f20f83
2025-05-30 22:47:29 +09:00
Stephen Finucane
2e301857af docs: Add note about scoping on tokens
Change-Id: I4df74eaa1aa82fb8666bc1e6728b55a3e81bc76a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-29 19:13:21 +01:00
Zuul
c923ed5893 Merge "Security-groups: Temporarily ignore is_shared" 2025-05-29 15:59:21 +00:00
elajkat
5f602475cd Security-groups: Temporarily ignore is_shared
[1] introduces is_shared field to SDK security-groups.
Till that is merged and released temporary skip the new field.

[1]: https://review.opendev.org/c/openstack/openstacksdk/+/950305
Related-Bug: #1999774

Change-Id: I71cdf96460bbb21ee61105ef9ccc23170b0b5460
2025-05-29 07:53:58 +00:00
Zuul
a8d2c56337 Merge "bug fix volume group show command." 2025-05-26 16:28:16 +00:00
Zuul
606fd132bc Merge "identity: Normalise output of application credentials commands" 2025-05-26 16:03:37 +00:00
Stephen Finucane
2f03c3ea3c identity: Remove unnecessary helper
Make better use of argparse and eliminate the need for a helper in the
process.

Change-Id: Ibdc9b4bfbb4d532ddb05bce9b49bcf0580cce76d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-26 16:12:28 +01:00
hongp
1c70e264a4 bug fix volume group show command.
There is no "show" function in the "group" class of python-cinderclient. Instead, there is a "get" function, so I fixed it.
0125495f92/cinderclient/v3/groups.py (L134)

Closes-Bug: #2111539
Change-Id: If61d8cf115c9ff04d172d7344565e693774e7a21
2025-05-23 10:08:39 +09:00
Zuul
88b59d8975 Merge "evacuate: respect original SHUTOFF state in --wait completion" 2025-05-21 10:29:33 +00:00
waf
3909e93301 evacuate: respect original SHUTOFF state in --wait completion
When running `openstack server evacuate --wait`, the command would hang
indefinitely if the instance was originally in SHUTOFF state, because
only “ACTIVE” was treated as a successful completion. We now capture
the server’s status before evacuation and dynamically include
“SHUTOFF” in the `success_status` list if the instance was already
shut off. This ensures that a shutoff instance is accepted as a valid
completion without requiring manual intervention.

Unit tests have been added and updated to cover both:
- pre-evacuation ACTIVE → success_status=['active']
- pre-evacuation SHUTOFF → success_status=['active','shutoff']

Closes-Bug: #2103426
Change-Id: I86ad1cd173a144b16fde1dbac87819fab2d7a50a
2025-05-21 16:52:24 +09:00
Zuul
5a565ca1ce Merge "Fix missing 'options' field in 'user show' command" 2025-05-20 18:08:26 +00:00
Chaemin-Lim
9bcb1c5c00 Fix missing 'options' field in 'user show' command
This patch fixes a bug where the 'options' field was missing from
the output of the 'openstack user show' command since v7.0.0.

The issue was caused by the 'options' field not being included in
the column list in the _format_user function. This field is important
as it contains various user settings such as multi-factor authentication
configurations and password policy exemptions.

This patch:
1. Adds 'options' field to the column list in _format_user function
2. Updates all affected unit tests to include this field
3. Uses getattr() to safely handle cases where the options field may be absent

Without this fix, users cannot see important options like multi-factor
authentication settings through the CLI, which could lead to security
configuration issues being overlooked.

Closes-Bug: #2084946
Change-Id: I4319268ad4310e6164eb8e65664d73f9b32cdd78
2025-05-20 23:46:39 +09:00
0weng
a2be1b014e Identity: Migrate 'group' commands to SDK
Change-Id: I5a477426318d77021c0430efa1d1f9a7b1ee2633
2025-05-19 15:39:18 -07:00
Zuul
5fb4559a1f Merge "tests: Simplify mocking in image tests" 2025-05-19 16:25:49 +00:00
Zuul
50dd542519 Merge "network: Allow multiple FIP filter opts" 2025-05-19 16:05:20 +00:00
Zuul
de7762f9b8 Merge "volume: Migrate 'volume delete' to SDK" 2025-05-19 15:54:41 +00:00
Zuul
bea4d834ce Merge "volume: Temporarily ignore new volume columns" 2025-05-19 15:54:38 +00:00
Zuul
47a2596b39 Merge "volume: Split v2, v3 create, delete commands" 2025-05-19 15:54:36 +00:00
Zuul
07909a6a6c Merge "volume: Migrate 'snapshot show', 'snapshot list' to SDK" 2025-05-19 15:47:53 +00:00
Zuul
803c3c6d6a Merge "volume: Migrate 'snapshot set', 'snapshot unset' to SDK" 2025-05-19 15:47:50 +00:00
Zuul
110cd9faae Merge "volume: Migrate 'snapshot create' to SDK" 2025-05-19 15:45:04 +00:00
Zuul
2e0318629d Merge "volume: Migrate 'snapshot delete' to SDK" 2025-05-19 15:45:01 +00:00
Zuul
0e47fc4e45 Merge "volume: Add v3-specific volume snapshot module" 2025-05-19 15:37:26 +00:00
Zuul
5c9c4e3dd7 Merge "tests: Use SDK mocks for SDK-based commands" 2025-05-19 15:15:38 +00:00
Zuul
ff7497689c Merge "volume: Migrate 'backup set', 'backup unset' to SDK" 2025-05-19 15:15:35 +00:00
Zuul
d27ff5a650 Merge "volume: Migrate 'service *' to SDK" 2025-05-19 15:15:32 +00:00
Zuul
82170be8d6 Merge "volume: Add v3-specific volume service module" 2025-05-19 15:15:29 +00:00
Zuul
e3bd9a4c01 Merge "volume: Migrate 'block storage log level *' to SDK" 2025-05-19 15:14:29 +00:00
Zuul
d5238d1dab Merge "Add a column to all_projects tag of server list cmd" 2025-05-19 14:17:25 +00:00
Zuul
5f2145d102 Merge "Add filters to search for enabled/disabled users and projects" 2025-05-19 14:17:22 +00:00
Zuul
51305d06f7 Merge "identity: Migrate 'domain' commands to SDK" 2025-05-19 14:17:19 +00:00
djp
444a1df705 tests: Simplify mocking in image tests
Replace assignment of `Mock` objects to methods that are already mocked
in tests/unit/v1/test_image.py, tests/unit/v2/test_image.py

story: 2011459
task: 52210
Change-Id: I0a4644c27066c26cf0ee0f3613c174f141fe94ed
2025-05-19 13:46:27 +00:00
Stephen Finucane
f1cd38aabf identity: Normalise output of application credentials commands
cliff is now smarter (I9155763eee15e19eab23b48989dfcc19ea2c5d34), so we
can effectively revert change I6b4f1b793dc383856bfdf9a01514381be3cd2bf1.
We bump the dependencies to ensure this.

Change-Id: I2af19043fd66b5be0826a774baeabeac7110a4aa
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 14:14:14 +01:00
Stephen Finucane
01c1b1e36f network: Allow multiple FIP filter opts
This is allowed by the neutron API. Allow it in OSC.

Change-Id: I7642ecd686d11c5af9e11cc80896243e853e33f3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 14:07:37 +01:00
Zuul
5e1fc3db05 Merge "Fix incorrect warning with --password-prompt option" 2025-05-19 12:48:49 +00:00
Stephen Finucane
082aca89d6 volume: Migrate 'volume delete' to SDK
Change-Id: Ia7d2bfb14945cb5c185daa820f699a4cfe4a3e7f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:22 +01:00
Stephen Finucane
125133d056 volume: Temporarily ignore new volume columns
Change-Id: I4296766a1576c64eb3927cb0557aef5346b2d6f6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:22 +01:00
Stephen Finucane
03aa172fd0 volume: Split v2, v3 create, delete commands
Change-Id: I42616b9586fede3b775bc0fdbba73df90b555d46
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:21 +01:00
Stephen Finucane
267a29d594 volume: Migrate 'snapshot show', 'snapshot list' to SDK
Change-Id: I40de24012363f496e46c3dddc31a3e2563ccf443
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:20 +01:00
Stephen Finucane
3c6fa42642 volume: Migrate 'snapshot set', 'snapshot unset' to SDK
Change-Id: Id34d460c8c5656bf43f48717b13a002508562e4e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:19 +01:00
Stephen Finucane
e0020aec6a volume: Migrate 'snapshot create' to SDK
Change-Id: I0c2811b8518c41658803a7b2053f0f5d5114ed67
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:18 +01:00
Stephen Finucane
fc42f12eb2 volume: Migrate 'snapshot delete' to SDK
Change-Id: Iba89d521ec17a642c5905b0cff908b5a4a9dafd0
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:16 +01:00
Stephen Finucane
e1ff450e34 volume: Add v3-specific volume snapshot module
Change-Id: I23026abbb909c082fbc0fe0c9b2efcc89f4d464a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:15 +01:00
Stephen Finucane
a9b9984973 tests: Use SDK mocks for SDK-based commands
Change-Id: I7e781875d4467ed097196771144e25cee38ce678
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:13 +01:00
Stephen Finucane
8eb1a183fe volume: Migrate 'backup set', 'backup unset' to SDK
Change-Id: Iced346df828faab1ff08a2645ff64f4cfea25cb1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:12 +01:00
Stephen Finucane
b933330d55 volume: Migrate 'service *' to SDK
Change-Id: I81254c6cde8783be371ccdcface5027eb247b1ce
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:10 +01:00
Stephen Finucane
1ee3ef33d7 volume: Add v3-specific volume service module
Ease migration.

Change-Id: Ibcdb157ba1bf370c63320d3a1afcf3c400370624
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:09 +01:00
Stephen Finucane
00f4cf9c17 volume: Migrate 'block storage log level *' to SDK
Change-Id: Ic03f65fee197a85518df448c18a0fd2c11d51993
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-19 13:20:07 +01:00
xfrnk2
a74850d2c4 Add a column to all_projects tag of server list cmd
Add a Project ID column to the --all-projects tag of server list cmd
Differentiate from the basic command, add a column for Project ID
to facilitate easier identification.
Add test code for the Project ID column of --all-projects tag.

Change-Id: I12af2c91f934e7cd268d21cf76dda78646ed2ff4
2025-05-19 12:38:20 +01:00
Chaemin-Lim
eea369e73c Fix incorrect warning with --password-prompt option
When creating a user with the --password-prompt option, a warning is
incorrectly displayed stating that no password was supplied, even though
a password was entered. This occurs because the code checks parsed_args.password
instead of the password variable that actually stores the prompted password.

This patch fixes the issue by checking the 'password' variable
instead of 'parsed_args.password' in the warning condition. A test
case has been added to verify that no warning is displayed when
using --password-prompt and entering a password.

Closes-Bug: #2091836
Change-Id: Ib3ddc7e400ee7988f605c00db534bccc3617d982
2025-05-19 16:12:06 +09:00
Stephen Finucane
32762bcda6 compute: Fix key used for NIC fixed IP field
Change-Id: If099ac0e2663228681e87e2f4821b746c8113ffc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2106221
2025-05-18 15:12:17 +01:00
Zuul
79de137152 Merge "identity: Add missing user argument" 2025-05-16 02:50:39 +00:00
Zuul
f380d029df Merge "identity: Fix listing of applications credentials by user" 2025-05-16 02:50:36 +00:00
Zuul
efce69b47f Merge "Don't warn about unsupported version with SDK-based commands" 2025-05-15 16:19:20 +00:00
Stephen Finucane
e26b447925 identity: Add missing user argument
Change-Id: Ifd2b32e97d1f5fd426f333da13852a8bb6821f1b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2110765
2025-05-15 16:05:56 +01:00
Stephen Finucane
94d17b8762 identity: Fix listing of applications credentials by user
Change-Id: I71f1c4f338694e2b50e71b6907c415bbb6a768fa
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2107354
2025-05-15 15:59:34 +01:00
Zuul
9de5e58bc8 Merge "Bump Python version used for linters to 3.10" 2025-05-09 16:13:11 +00:00
Zuul
05accdde9a Merge "Drop support for Python 3.9" 2025-05-09 16:13:08 +00:00
Stephen Finucane
7c7c066096 Bump Python version used for linters to 3.10
Change-Id: I693516fc2a08218c50d83a3ab121b51254f97958
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-07 17:55:39 +01:00
Stephen Finucane
ce2a253d5a Drop support for Python 3.9
Change-Id: If7d8ce2be7081fdcd609c54a211c91439cddce6b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-05-07 17:55:31 +01:00
Michael Still
5d730f374b Add support for spice-direct console types.
This patch adds support for Nova microversion 2.99 which exposes the new
spice-direct console type and the pre-existing /os-console-auth-token/ API.

+----------+----------------------------------------------------------+
| Field    | Value                                                    |
+----------+----------------------------------------------------------+
| protocol | spice                                                    |
| type     | spice-direct                                             |
| url      | http://127.0.0.1:13002/nova?token=f78009fb-41ad-...      |
+----------+----------------------------------------------------------+

+----------------------+--------------------------------------+
| Field                | Value                                |
+----------------------+--------------------------------------+
| host                 | 127.0.0.1                            |
| instance_uuid        | f2477018-aa93-...                    |
| internal_access_path | None                                 |
| port                 | 5900                                 |
| tls_port             | 5901                                 |
+----------------------+--------------------------------------+

Change-Id: I2d33646d6ac9b25076d69be76dcef8f5c465cd1b
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/940479
2025-05-07 19:34:17 +10:00
Zuul
a49a290a2b Merge "Update README" 2025-04-17 11:04:23 +00:00
Zuul
871b2a4d80 Merge "Add labels to Dockerfile" 2025-04-17 11:04:21 +00:00
Zuul
6e4c2879d4 Merge "Update the docker image to python3.12" 2025-04-17 11:04:20 +00:00
Zuul
0208a24235 Merge "zuul: Remove osc-upload-image, osc-promote-image jobs" 2025-04-17 09:47:42 +00:00
Stephen Finucane
6cb5d8cd14 Update README
Restructure things to be a little more helpful. Also add a reference to
the Dockerfile we provide and remove an errant header that should have
been removed in change Ife108e6ae191641b56e872e4616a3f4ec78281e8.

Change-Id: I5f562a99ccee7db485b5d40ef4ea6f2e2e362c13
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-17 08:53:35 +00:00
Stephen Finucane
22eecc54f8 Add labels to Dockerfile
Change-Id: Ic2c774c4fea263c7b04d20182e3354d9ae93788b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-17 08:53:27 +00:00
Stephen Finucane
f4e97d9733 Update the docker image to python3.12
Change-Id: I2120ac8d27bcefffa0b414cb74871922ccd2ad80
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-17 08:53:19 +00:00
Stephen Finucane
e4d621d24f zuul: Remove osc-upload-image, osc-promote-image jobs
We are no longer going to publish these images to Dockerhub, given
the recent changes to quotas there coupled with the fact that no one
appears to be using them [1]. The osc-build-image job is retained to
ensure our Dockerfile keeps working.

[1] https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/BE7PPQL4DGNDZ2SIMUVSK67I5NF3TFCX/

Change-Id: I9d2ca8f90b8244a09832da673491312095520968
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-16 17:55:06 +01:00
Stephen Finucane
7d64003196 tests: Stop returning FakeResource in compute tests
This was still being used in places where we have our own API bindings
because SDK does not support the API. Those bindings should be returning
dicts, not FakeResource objects. Correct this, and in doing so fix the
bug this highlights in our cell-down output.

Change-Id: I6647d94fcf5ada8186edbf64c03abd3d8ae7ca56
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-14 16:43:22 +01:00
Stephen Finucane
abed52f106 tests: Remove sdk prefix
It is no longer necessary.

Change-Id: I6bcc14be90be7c93ec4729f241299d55885570fd
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-14 16:27:32 +01:00
Stephen Finucane
2c878ad2b7 tests: Remove dead code
None of these fakes are used anymore. Remove them.

Change-Id: I06721aa77f93b76b189901bbdc13a9825fe2fc3d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-14 16:27:31 +01:00
Stephen Finucane
b0fe724caf tests: Remove use of legacy resource helpers
This allows us to remove get_servers, create_servers, and
create_one_servers.

Change-Id: I31a86b6333fdc3da1b54407f077873511260a5df
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-14 14:10:55 +01:00
Zuul
db4739fc5c Merge "Require confirmation to reset server state." 2025-04-11 13:23:47 +00:00
Sean Mooney
25cd1178b3 Require confirmation to reset server state.
This change updates the server set state command to require confirmation
before it is applied. The same pattern as project clean is used and a
new --auto-approve flag is added to allow skipping the prompt.

Operators often use reset state in cases that are incorrect
this change updates the warning to be more explicit
about when and when not to use it.

Change-Id: Iab14739cf6043ad45ad49edff0580e81d75af2fd
2025-04-11 11:53:14 +01:00
melanie witt
d123be0819 Fix 'openstack keypair list --project <project>'
The --project option of 'openstack keypair list' is supposed to filter
keypairs by a project but has not been working and instead returns
keypairs from all projects.

The reason appears to be because it uses a request for a user list
filtered by project but tenant_id/project_id is not a valid filter for
GET /users.

This fixes the issue by requesting role assignments for the specified
project and then requesting keypairs for users with a role in the
project.

This change depends on a recent openstacksdk bug fix change
Ic552dee83d56278d2b866de0cb365a0c394fe26a which fixed the user_id query
parameter for the compute /os-keypairs APIs. The bug fix was released in
openstacksdk 4.4.0.

Closes-Bug: #2096947

Change-Id: Ibb5757766e3040e58d64388b95678fab9b2b6f23
2025-04-10 17:59:29 -07:00
Zuul
616d6f3a29 Merge "Add support for showing scheduler_hints in server details" 2025-04-10 18:37:26 +00:00
Stephen Finucane
11495e655a Don't warn about unsupported version with SDK-based commands
This doesn't make sense: SDK (and the server) will handle this for us.

Change-Id: I31b84e09eca0dc2bc5316d6727620346ae519512
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2106760
2025-04-10 18:21:17 +01:00
Rajesh Tailor
c66abfc76f Workaround for failing tests on openstacksdk change
The 'show-instance-action-finish-time' blueprint [1] adds support for
showing 'finish_time' for InstanceAction object.

This change adds 'finish_time' as hidden column, so it doesn't fail
tests.

We need to remove this from hidden_column list, once all the changes
related to blueprint are merged and show the field only if microversion
is >= 2.101

This is a workaround for failing tests on patch [2], as per suggestion
from Stephen.

[1] https://blueprints.launchpad.net/openstack/?searchtext=show-instance-action-finish-time
[2] https://review.opendev.org/c/openstack/openstacksdk/+/930562

Implements: blueprint show-instance-action-finish-time
Change-Id: Ib9294a603daed0fdb936be128dfba254b9108799
2025-04-09 12:23:38 +05:30
Douglas Viroel
c68622402e Add support for showing scheduler_hints in server details
Adds support for a new compute microversion that returns the
associated scheduler_hints in ``GET /servers/{server_id}``,
``GET /servers/detail``, ``PUT /servers/{server_id}`` and
``POST /server/{server_id}/action`` (rebuild) responses.

Change-Id: Ia5a4e0047b5123f2fb063cfc9ab1f58b2844308f
2025-04-08 19:27:29 +00:00
Zuul
7ecdb69f08 Merge "Refactor network fakes to sdk properties PART6" 2025-04-08 18:40:06 +00:00
Zuul
0874e2d33f Merge "Refactor network fakes to sdk properties PART 5" 2025-04-08 17:37:57 +00:00
Stephen Finucane
d96c81ff7f Refactor network fakes to sdk properties PART6
Included resources:
router
security_group
security_group_rule

Change-Id: I2423fc31d94f85aeefc7b0a205dfb38829417a29
2025-04-08 16:36:48 +00:00
Stephen Finucane
f870548c7f Refactor network fakes to sdk properties PART 5
Included resources:
qos_policy
qos_rule
qos_rule_type

Note: Parameters in unittests was modified
for compatibility with sdk

Change-Id: Iaa902d64ff1b29a07c28ed2100d437da506be475
2025-04-07 15:53:30 +01:00
Stephen Finucane
80eaa33ffe volume: Make better use of argparse
The latest in a series.

Change-Id: I8273c817e38120ba0b25aebdbfa1c2872222765e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-04 18:11:27 +01:00
Stephen Finucane
181bb194c7 image: Migrate 'create image' volume calls to SDK
Change-Id: Ie57a5c17a6df5a333abd6b11e28b65833740e102
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-04 18:11:27 +01:00
Zuul
30aa27b7f9 Merge "tests: Rename 'compute_sdk_client' -> 'compute_client'" 2025-04-03 18:09:11 +00:00
Zuul
dd8e4740ec Merge "compute: Migrate to 'compute' client alias" 2025-04-03 18:08:17 +00:00
Zuul
1e8d243986 Merge "Fix: extend in-use volumes check" 2025-04-03 16:40:17 +00:00
Stephen Finucane
dc68be6b7b tests: Rename 'compute_sdk_client' -> 'compute_client'
Resolve a TODO. Achieved using:

  sed -i 's/self.compute_sdk_client/self.compute_client/' \
    $(ag -w self.compute_sdk_client -l)

Change-Id: I76798058b9dee9fc7ef01ff8656543fbb1266d43
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-03 16:39:04 +01:00
Stephen Finucane
dae2539490 compute: Migrate to 'compute' client alias
This is no longer assigned to novaclient, meaning we can use it for SDK.

Change-Id: I43d9ede39d36cc29301f94fa462b9b9d9441807c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-03 16:39:03 +01:00
Zuul
54a5d2f40c Merge "Remove use of formatter function" 2025-04-02 14:40:12 +00:00
Zuul
01f9279dbf Merge "Imported Translations from Zanata" 2025-04-02 12:57:43 +00:00
Stephen Finucane
ac1ad1c4e4 Remove use of formatter function
We also update tests to use proper SDK fakes so we actually test this.

Change-Id: Ib98348cab613b7139f0faa0b5df90ff44353974f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-02 12:39:26 +01:00
Zuul
2148a86fc5 Merge "Remove use of formatter function" 2025-04-02 10:19:34 +00:00
OpenStack Proposal Bot
0554ff60b4 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I2493ee06a6d47791be683577f0a9b2c63199a67c
2025-04-02 03:07:33 +00:00
Zuul
ade7da8797 Merge "Prepare for osc-lib changes" 2025-04-01 17:57:57 +00:00
Zuul
4ba21fd6f4 Merge "pre-commit: Enable mypy" 2025-04-01 16:25:53 +00:00
Stephen Finucane
d95e23d92b Remove use of formatter function
Change-Id: I9ef88a4d69ffc3eaae183c77445ac10358d86337
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 16:42:13 +01:00
Zuul
8e95c0ed31 Merge "typing: Indicate another tuple to be extended" 2025-04-01 14:49:36 +00:00
Zuul
425e430c31 Merge "docs: Remove irrelevant TODO" 2025-04-01 14:01:24 +00:00
Zuul
1f25a2f935 Merge "volume: Remove Cinder v1 support" 2025-04-01 14:01:22 +00:00
Zuul
438878a3ed Merge "docs: Migrate remaining block storage commands to autocommand" 2025-04-01 12:44:07 +00:00
Zuul
c0521743ba Merge "Remove contributor specs" 2025-04-01 12:44:05 +00:00
Stephen Finucane
dc8596fe74 Prepare for osc-lib changes
Change-Id: I665cd61272f881dce2d387da6035a2f35c866add
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 13:39:50 +01:00
Stephen Finucane
ec4fd81c11 pre-commit: Enable mypy
To ease migration of various commands from OSC to SDK.

Change-Id: I4645237e8808239e4d605f7f45138449c9439949
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 13:14:47 +01:00
Stephen Finucane
62c8b8217e typing: Indicate another tuple to be extended
One has been introduced since Ie5907de8d60f2f39e98f6a88227cebb2e2ff565c
merged.

Change-Id: I37f7bf58a2cbecb69b370e832e56daa310cea3b6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 13:14:47 +01:00
Zuul
c9e4e5404f Merge "Permit use of tuple API_VERSIONS" 2025-04-01 12:02:24 +00:00
Zuul
77143f9bed Merge "typing: Resolve incompatible operand issues" 2025-04-01 11:50:55 +00:00
Zuul
28bd00a642 Merge "typing: Correct type for missing attributes" 2025-04-01 11:50:53 +00:00
Zuul
e6ae7d8533 Merge "typing: Remove use of optional imports" 2025-04-01 11:50:51 +00:00
Zuul
93da5f7af5 Merge "typing: Use consistent types" 2025-04-01 11:50:49 +00:00
Zuul
6e89f9da63 Merge "identity: Migrate 'endpoint' commands to SDK" 2025-04-01 10:55:58 +00:00
Zuul
514a46ee5d Merge "Remove tags from README" 2025-04-01 10:48:12 +00:00
Zuul
cf25526e94 Merge "Return the `port` column headers expected in the list command" 2025-04-01 10:48:10 +00:00
Stephen Finucane
662405e55c docs: Remove irrelevant TODO
cue is a dead project.

Change-Id: Ie860312a9ea481741bf5e7ab29610f621daba702
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 10:46:06 +01:00
Stephen Finucane
e6be9a3edf volume: Remove Cinder v1 support
The Cinder v1 API was removed in Queens [1]. Its replacement, the v2
API, has existed since Grizzly [2]. More importantly, the v1 commands
are implemented using python-cinderclient but support for the v1 API was
removed from python-cinderclient in Train [3], meaning none of these
have worked since then. Clearly if no one has noticed or cared in the 6
years or so since that happened, it's safe to say we can delete these
commands.

[1] 3e91de956e
[2] 75ca60f619
[3] 2189e5702b

Change-Id: Ibe1cd6461d2cb78826467078aa17272f171746aa
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 10:46:03 +01:00
Stephen Finucane
3eb063d4f7 docs: Migrate remaining block storage commands to autocommand
Change-Id: I6924f7053e14e843420deea1a023201fad7d4999
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 10:45:32 +01:00
Stephen Finucane
0b9c998d8a Remove contributor specs
There is only one and it was never implemented. Remove the directory.

Change-Id: Ibfffe7936556a626b407deca0e8de17b45db5313
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 10:45:32 +01:00
Stephen Finucane
b2eccdcb1a Permit use of tuple API_VERSIONS
The values of these dictionaries are not used when SDK is in use,
which should soon account for all use cases. Eventually we should
probably look for plugins to return a proper class or typeddict but
that's a job for another day.

This began as a fix for in openstackclient/object/client.py which
referenced a non-existent class and quickly snowballed.

Change-Id: I7b807ec3a97124b35828ffdecbb36f6fde11e7b5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-01 10:36:02 +01:00
Antonia Gaete
7750fc1cf4 identity: Migrate 'endpoint' commands to SDK
Change-Id: I71b5ae8a4bbcb2fdebf894d8bd5cc8322c31bdb5
Depends-On: I599ff3e88d4e1e9ffafc638bb74186f2739b5a77
Depends-On: I9aa39810fe94f7ee9b68d34050f4adb9dbdfccb8
2025-03-31 16:58:27 -07:00
Stephen Finucane
9de592ebaf typing: Resolve incompatible operand issues
Change-Id: I7f3dd908053b9ace5206d0a1bd3b8258fd0264ef
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:52:16 +01:00
Stephen Finucane
e28046cc19 typing: Correct type for missing attributes
Change-Id: I55652220ecd663fa024937646dfef92595e1cd0f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:52:16 +01:00
Stephen Finucane
9435ef825a typing: Remove use of optional imports
Do them inline instead.

Change-Id: Icab1a0452249efc79f214c4d7b369d02291e94b4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:48:36 +01:00
Stephen Finucane
2c0a3ba137 typing: Use consistent types
Resolve 'Incompatible types in assignment' errors.

Change-Id: I1ea186ff766e0f72cac384fab22d1c2f82e02ef0
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:48:36 +01:00
Stephen Finucane
7380fbe300 typing: Add types for empty dicts, tuples
In some cases, simply remove them.

Change-Id: I24a311a24eb533325dda83005777bcb2e0afc320
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:48:36 +01:00
Stephen Finucane
bdd55d989d typing: Indicate tuples to be extended
Change-Id: Ie5907de8d60f2f39e98f6a88227cebb2e2ff565c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:48:36 +01:00
Stephen Finucane
9c7a5d4e51 pre-commit: Bump versions
Apply manual changes required by ruff. Automatic changes were done
separately.

Change-Id: I7db65bd2ac3f31b0479699946398752d8d729338
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-31 17:48:31 +01:00
Zuul
ab2e68f407 Merge "Prepare for ruff bump" 2025-03-31 10:37:30 +00:00
Zuul
5918b6b478 Merge "[Neutron] Add "qos-policy" parameter to router creation command" 2025-03-28 19:27:30 +00:00
Brian Haley
107c6b143f Fix neutron typos and formatting
Just trying to make things consistent in the neutron files.

TrivialFix

Change-Id: I9c0ac838f5a956f55161e1636472cca761b14781
2025-03-26 20:02:25 -04:00
Rodolfo Alonso Hernandez
4dbfc47552 Return the `port` column headers expected in the list command
In [1], it was added the ability to print in the "port list" command
any field not defined in the hardcoded column set for this command.

But in [2], it was added a filter list in the API call in order to
reduce the CLI execution time. The unintentional drawback of this
optimization was that is no longer possible to print any field outside
the "port list" column set.

Because the optimization if preferred and it is always possible to use
"port show" to see all the port fields, the code added in [1] is
removed.

[1]https://review.opendev.org/c/openstack/python-openstackclient/+/522901
[2]https://review.opendev.org/c/openstack/python-openstackclient/+/754117

Closes-Bug: #2098980
Related-Bug: #1707848
Related-Bug: #1897100
Change-Id: Ia944b8e108c454219d642cfa595ffafdf060a57f
2025-03-26 15:57:12 +00:00
Jan Ueberacker
3483117259 Add filters to search for enabled/disabled users and projects
Change-Id: Ie7d84f9e0158018083af2156d02dc86fefd79256
Signed-off-by: Jan Ueberacker <jan.ueberacker@inovex.de>
2025-03-26 14:41:50 +01:00
Rodolfo Alonso Hernandez
07515cd160 [Neutron] Add "qos-policy" parameter to router creation command
This patch adds the parameter "qos-policy" to the router creation
command.

Closes-Bug: #2103774
Change-Id: I742b3273c5e9d3ec16e8018beddc8cdace8a57c6
2025-03-26 07:46:40 +00:00
Zuul
866009211f Merge "Fix networking quota usage show" 2025-03-25 13:13:29 +00:00
Slawek Kaplonski
6d27b2f2b6 Fix networking quota usage show
Quotas details returned from the Neutron service are in different format
then quota details returned from Nova and Cinder services. This patch
fixes helper function to convert data from Neutron to the same
format as data from Nova and Cinder is given.

Closes-Bug: #2102513
Change-Id: I18649f6c2ee179b64b7e605f4ea07d4b0c7a1635
2025-03-25 09:52:39 +01:00
Alfredo Moralejo
2e5a830276 Replace description-content-type by its underscore name
Since v78.0.0, setuptools no longer accepts options containing
uppercase or dash characters in setup.cfg [1].

[1] https://github.com/pypa/setuptools/blob/main/NEWS.rst#v7800

Closes-Bug: #2104030

Change-Id: Id88b9c73a4cd9511750f38da9393dae3adbc5c1e
2025-03-24 17:03:44 +01:00
Zuul
b01c138e9e Merge "Specifying project-domain for project" 2025-03-24 13:04:53 +00:00
Dmitriy Chubinidze
2883f3fb95 Specifying project-domain for project
The fix ensures that if a user wants to set a default project,
they must also provide the project domain. If it's missing,
an explicit error message is shown, making it clear that the
project domain is required.

Also adding some unit tests by modifying respective calls.

Change-Id: Ia6e921a53da55ab1bce85a42c8160872a9d47d64
Closes-Bug: #2102146
2025-03-23 09:38:24 +00:00
Zuul
f28f97f23f Merge "zuul: Make image job non-voting" 2025-03-21 17:16:02 +00:00
Zuul
9366405806 Merge "Update master for stable/2025.1" 2025-03-21 15:18:38 +00:00
Stephen Finucane
7ef588d695 zuul: Make image job non-voting
We may need to remove this soon enough, given the new Docker rate limits
that we keep bumping into.

Change-Id: Id4a9d8df770d107986b20e4a98835ee4e0b6117d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-21 15:03:44 +00:00
Zuul
71dbac498e Merge "Fix missing space in help messages" 2025-03-19 13:11:46 +00:00
Zuul
669a50be55 Merge "Update README for use python3" 2025-03-19 13:06:39 +00:00
Zuul
1763c11963 Merge "Fix image import --disallow-failure flag" 2025-03-19 13:06:38 +00:00
Stephen Finucane
49708f6d3f Remove tags from README
The tags framework has been discontinued [1].

[1] https://governance.openstack.org/tc/reference/tags/index.html

Change-Id: Ife108e6ae191641b56e872e4616a3f4ec78281e8
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-19 12:33:52 +00:00
Stephen Finucane
290bc580e6 Prepare for ruff bump
Change-Id: Ia9c402edebc8537d5019d18920b6679b05ea4378
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-03-19 12:04:39 +00:00
OpenStack Release Bot
f2df31387b Update master for stable/2025.1
Add file to the reno documentation build to show release notes for
stable/2025.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2025.1.

Sem-Ver: feature
Change-Id: I2789e8605f5e9bae63382ca9e822bbc3e2241f36
2025-03-18 09:01:53 +00:00
Ghanshyam Mann
702a37c7ca Add libpcre3-dev in bindep.txt for pcre.h
Doc job is going to run on Ubuntu Noble[1]
and we need libpcre3-dev package for pcre.h

[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/935459

Change-Id: I0fe73c02b093805d8eb1b15303f92633fad809cb
2025-03-17 09:23:09 -07:00
Pavlo Shchelokovskyy
1efca54465 Fix image import --disallow-failure flag
the flag should store False to 'allow_failure', not True.

Also, make the --allow-failure and --disallow-failure flags
mutually exclusive.

Change-Id: I03699e14d4d69d9f08caab647293732fc211dbad
2025-03-14 10:52:39 +00:00
Tobias Urdin
f1bd417861 Add device ID and device owner to port unset
This adds support to unset the device_id and
device_owner property on a port.

Change-Id: I43b1ea63e3a119f57162948e128a85f8ba323d41
2025-03-12 19:39:03 +00:00
Vladimir Kozhukalov
1458330d3b identity: Fix 'trust' commands to work with SDK
Closes-Bug: #2102039
Change-Id: I632937e06683cc76e78390a4e6f3de4e3c4f1f87
2025-03-11 12:31:09 -05:00
Rajesh Tailor
f65e4835d3 Fix missing space in help messages
This change fixes missing space in help messages to make those
consistent and pretty rendering when calling help.

Change-Id: I947374821a4dbb5e68651c0e72fc5fd2f938e6a1
2025-03-05 19:58:27 +05:30
Zuul
966aede8ab Merge "Add four new network agent types to the list command filter" 2025-02-28 01:43:25 +00:00
Zuul
4b7e32ca37 Merge "handle 'router create --flavor' option" 2025-02-25 22:48:45 +00:00
Tim Burke
1979c20ff0 Fix credential creation
openstacksdk's Credential expects user_id and project_id, not user and
project. Previously, we would send payloads like

   {'type': 'ec2', 'blob': '{"access": "s3-user1", "secret": "s3-secret1"}'}

which Keystone would reject with

   'user_id' is a required property

Change-Id: I0544bef7df9247395f0726ea075112d6ac992252
2025-02-25 10:30:22 -08:00
Rodolfo Alonso Hernandez
762a3b10d1 Add four new network agent types to the list command filter
Added four new network agent types to the list method filter:
* ``ovn-controller``
* ``ovn-controller-gateway``
* ``ovn-metadata``
* ``ovn-agent``

These agents are represented in the OVN network agent classes defined
in [1]. The OVN agent names are defined in [2].

[1]86f94de99a/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py
[2]86f94de99a/neutron/common/ovn/constants.py (L91-L94)

Closes-Bug: #2097124
Change-Id: I117be7e60f67fdd94677cbaa65a3aff01e57bb5e
2025-02-24 10:58:48 +00:00
Zuul
d22b7732ad Merge "[Neutron] Support `uplink-status-propagation-updatable` extension" 2025-02-24 09:05:05 +00:00
Zuul
12e264adc6 Merge "[Neutron] "uplink-status-propagation" enabled by default" 2025-02-24 08:53:02 +00:00
Rodolfo Alonso Hernandez
0ba77e6727 [Neutron] Fix the "port show" command for trunk details
In [1], the "port list --long" command received a new column, showing
the trunk subports related to a parent port. The problem of this patch
is that the ``_formatters`` definition, that is shared with the "port
show" command too, is changed. The "trunk_details" information presented
in both commands differ:
* In the "port list" command, only the subports are presented, in order
  to print a list of dictionaries without showing the ``trunk_id``.
* In the "port show" command, it is presented all the trunk information,
  including the ``trunk_id``.

This patch includes functional tests to validate the fix.

[1]https://review.opendev.org/c/openstack/python-openstackclient/+/926611

Closes-Bug: #2098950
Change-Id: Ib1107fb3dbb025b39a7c55f90f5fe51ae433a72f
2025-02-20 01:07:39 +00:00
Rodolfo Alonso Hernandez
426abbdc68 [Neutron] Support `uplink-status-propagation-updatable` extension
Added ``--enable-uplink-status-propagation`` option and
``--disable-uplink-status-propagation`` option to ``port update``
command.

Now the Neutron extension "uplink-status-propagation-updatable" allows
to update the related value in a port. That was implemented in the
following patches (during 2025.1 Epoxy release):
* https://review.opendev.org/c/openstack/neutron-lib/+/927820
* https://review.opendev.org/c/openstack/neutron-lib/+/936234
* https://review.opendev.org/c/openstack/neutron/+/931641

Related-Bug: #1722720
Change-Id: I99cdcf21438d6d85092c995b50cb10b26ae7c059
2025-02-18 12:09:37 +00:00
Doug Goldstein
1f407afe1c
handle 'router create --flavor' option
The '--flavor' option appears in the usage and arglist but is not
actually parsed. The '--flavor-id' option is what is silently parsed.
Since the goal is to allow the name or the id, this adds the '--flavor'
option to being parsed.

Closes-Bug: 2091731
Change-Id: Id83facd3825f472e7d864427699bd072d1c08779
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
2025-02-15 14:04:28 -06:00
Rodolfo Alonso Hernandez
b50ac8d2a2 [Neutron] "uplink-status-propagation" enabled by default
Since [1][2], the port flag "uplink-status-propagation" is enabled
by default.

[1]https://review.opendev.org/c/openstack/neutron-lib/+/744208
[2]https://review.opendev.org/c/openstack/neutron/+/744210

Related-Bug: #1888487
Change-Id: I522707b36c73b3c5bfe0d644bd07774918660b68
2025-02-14 14:13:26 +00:00
Slawek Kaplonski
3412147372 Add "qinq-vlan" and "no-qinq-vlan" params to the "network create" cmd
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/939703

Related-Bug: #1915151
Change-Id: Icacf83c20c3650a9d75f665f020b8818e1b4a585
2025-02-13 10:10:42 +01:00
Slawek Kaplonski
e761ef8e32 Temporary ignore "is_vlan_qinq" column in the output
We need such temporary workaround until [1] in SDK will be merged, as
without that change here py{39,312}-tips jobs are failing on that SDK
patch.

[1] https://review.opendev.org/c/openstack/openstacksdk/+/939703

Related-bug: #1915151
Change-Id: Id39a6482de54fe78e26fa33c9252253886cf1f3d
2025-02-12 16:40:37 +01:00
Zuul
0c2dee5e1f Merge "Identity: Deprecate --region None in limits/registered limits" 2025-02-12 00:22:23 +00:00
Zuul
e27fd93226 Merge "Identity: Migrate 'role' commands to SDK" 2025-02-11 18:10:57 +00:00
Zuul
5de803b39f Merge "Show final image state after image create" 2025-02-10 11:57:11 +00:00
ArtofBugs
060d706bf4 Identity: Deprecate --region None in limits/registered limits
Change-Id: I37afac1185595216e868202c861d3de719b32073
2025-01-28 17:19:05 +00:00
Ivan Anfimov
3de1ac66e0 Update README for use python3
And small change for `long_description_content_type` missing.

Change-Id: I042a319bfc5009ce625565effa7ccf634222be28
2025-01-26 11:27:13 +00:00
Fernando Royo
d2d7219231 Get "security_groups" when port list
Neutron API is accepting 'security_groups' field  in
order to return the list of security_groups attached
to a port, but openstackclient is parsing the output
over a Openstack Port object that has security_group_ids
to map. This patch sends to the Neutron API the expected
field value and replace the output key to allow the
mapping just in case '--long' argument is passed.

Closes-Bug: #2095414
Change-Id: I188edc3c620ce29d7b16497ca24fd7d972a06618
2025-01-21 18:51:32 +00:00
Zuul
146a1814b6 Merge "Add the trunk subports information to the port list command" 2025-01-18 12:01:38 +00:00
Pavlo Shchelokovskyy
4f95e0aa18 Show final image state after image create
creating the image is a 2step process, first an 'empty' image is created
and then the data is uploaded.
Currently the output of the 'image create' command is that 'empty'
image, in `queued` status etc.
A more user friendly approach would be to make a second refresh call
to show the user image as it is after data was uploaded.

Change-Id: I2f78b113dcc3c941f8cf8dd9b63262971a780a39
2025-01-16 15:35:43 +00:00
ArtofBugs
8f1382eda3 Identity: Migrate 'role' commands to SDK
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/929578
Change-Id: I22254604705080095ac852a1e03506b1552a1fd2
2025-01-13 21:55:10 +00:00
Zuul
eb0dbd5c33 Merge "Fix: Volume backup restore output" 2025-01-07 18:35:53 +00:00
Zuul
6ce1f7730c Merge "identity: Migrate 'trust' commands to SDK" 2024-12-19 21:33:28 +00:00
Rodolfo Alonso Hernandez
2a0431e825 Add the trunk subports information to the port list command
Added the subports information to the port list command, when the
"--long" qualifier is specified.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/926609

Closes-Bug: #2074187
Change-Id: I8ef66c3415279caf0ebea4ba6232ca3696188de9
2024-12-18 15:04:54 +01:00
Zuul
a631014551 Merge "Fix volume backup show by name" 2024-12-17 19:09:39 +00:00
Zuul
4e8be5aa64 Merge "tests: Stop setting attributes on class" 2024-12-17 18:47:00 +00:00
Rajat Dhasmana
03e2fdd162 Fix: Volume backup restore output
Currently the volume backup restore command returns with error
even though the restore is initiated.
This patch corrects the response received from SDK and processes
it in a human readable form.

Change-Id: I7f020631fbb39ceef8740775fd82686d90a6c703
Closes-Bug: #2063335
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/931755
2024-12-17 17:46:35 +00:00
Zuul
c74af3f01e Merge "identity: Migrate 'credential' commands to SDK" 2024-12-16 20:45:20 +00:00
Zuul
fd232a43bc Merge "identity: Migrate 'service provider' commands to SDK" 2024-12-16 19:52:03 +00:00
Antonia Gaete
769bf87d0a identity: Migrate 'trust' commands to SDK
Change-Id: Idb1fda3428ccf3022ee03c8fb7e42c7121683181
2024-12-16 18:24:10 +00:00
Stephen Finucane
38407c6a78 tests: Stop setting attributes on class
For some reason we were setting a property mock on the FakeClientManager
class. In multiple places, no less. This has a nasty habit of causing
side-effects in other tests, depending on the order that tests run in.
Resolve this simply setting the attribute as we'd expect.

Change-Id: I8bf9055e3f5b885dd5a7a6d751b774934da4a7d7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-12-16 18:23:09 +00:00
Zuul
db3d4c98f2 Merge "requirements: Remove unused test deps" 2024-12-16 18:07:15 +00:00
Stephen Finucane
32bd5d3562 Adopt sdk_fakes for compute.test_server_volume
Change-Id: I5a82ff970ebb3622e6920cdb240a3c1dbc96e27d
2024-12-12 11:19:27 +00:00
Artem Goncharov
4cef5f5549 Adopt sdk_fakes for compute.test_server_group
Change-Id: I1c97a7b2e28233a3b345a81b62c01e74a0aec914
2024-12-12 11:19:20 +00:00
Stephen Finucane
38029c6988 Adopt sdk_fakes for compute.test_hypervisor
Change-Id: Ibed4390be61c98f8c9e348835493bc714f8b9e87
2024-12-12 11:19:02 +00:00
Artem Goncharov
776b7d0c66 Adopt sdk_fakes for compute.test_usage
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/882682
Change-Id: Ia8fd2ccfd1e86749fdeeb49c2d57de64635cbb82
2024-12-12 11:18:56 +00:00
Stephen Finucane
afc0d3c252 Adopt sdk_fakes for compute.test_service
Change-Id: I331283f42914b91bd80dfca354635214fb7ba8a7
2024-12-12 11:18:49 +00:00
Artem Goncharov
42b1698e5c Adopt sdk_fakes for compute.test_keypair
Change-Id: Ifb5df852a9ae6eea3fabce13d450b16cb8348315
2024-12-12 11:18:42 +00:00
Artem Goncharov
d175dea6bc Adopt sdk_fakes for compute.test_console
Change-Id: I6181009a8b2ae7e632214364527ccc6fdd03fff9
2024-12-12 11:18:34 +00:00
Stephen Finucane
329b351cb8 Adopt sdk_fakes for compute.aggregate
Drop fakes generation for compute aggregates in favor of sdk_fakes

Change-Id: I4965a5fe8fc3d70390ca0268716519b617ca24eb
2024-12-12 10:43:24 +00:00
Antonia Gaete
56baf50655 identity: Migrate 'service provider' commands to SDK
Change-Id: I7f5fba408b7c350bb0a279f8dd17bd7bae451774
2024-12-11 22:37:44 +00:00
Zuul
52b2944b78 Merge "identity: Migrate region commands to SDK" 2024-12-10 18:32:38 +00:00
Zuul
90148ffc45 Merge "quota: Catch correct exception type for Compute quotas" 2024-12-10 18:32:36 +00:00
Zuul
6579daeac7 Merge "tests: Add functional test for adding, removing SGs" 2024-12-10 14:03:51 +00:00
Zuul
83de58fa33 Merge "compute: Workaround bug #2089821" 2024-12-10 14:03:49 +00:00
Stephen Finucane
99cef9354b quota: Catch correct exception type for Compute quotas
There is a flaw (IMO) in the design of Nova's os-quota-sets API: despite
project IDs forming the identifier for an individual resource, we get a
HTTP 400 (Bad Request) error if you pass an ID that does not exist,
rather than the HTTP 404 (Not Found) we would expect.

Correct this, noting why we're doing what we're doing for readers from
the future (hi!). Note that HTTP 400 is unfortunately quite broad and
means we'll also catch things like invalid requests but the exception
may have been translated so we can't rely on a string match.

Change-Id: I720502930d50be8ead5f2033d9dbcab5d99a37a9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2091086
2024-12-09 15:49:40 +00:00
Stephen Finucane
e736394d1b tests: Add functional test for adding, removing SGs
The fix is in openstacksdk. Let's test it here though.

Change-Id: I661e6d66c8196e8c9ca8b9cda3d08e756e3d5877
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/936947
Related-bug: #2089821
2024-12-09 13:56:58 +00:00
Stephen Finucane
22b30b99ce compute: Workaround bug #2089821
By passing a dict instead of a single value, we force SDK to populate
the correct attribute on the object.

Change-Id: I9f4c5964dc0546215474c92db567966ffad68a1a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-bug: #2089821
2024-12-09 13:56:58 +00:00
Rajat Dhasmana
03933e9a73 Fix: extend in-use volumes check
Currently we have 2 issues with extending volumes checks:

1. We don't specify explicitly that MV 3.42 needs to be passed for
in-use volumes
2. Any state of volume (error, attaching, detaching etc) can pass
this check by specifying MV 3.42

The fundamentally correct approach to these checks should be:

1. Only allow 'available' and 'in-use' volumes to be extended
2. Check MV 3.42 or greater is specified in case of 'in-use' volumes
otherwise fail

This approach is implemented in the patch.

Change-Id: I45ab9af953f7d060379f48ca429eaea7cfe857cc
2024-12-09 19:01:22 +05:30
Stephen Finucane
c888cf2556 network: Make better use of argparse
Change-Id: I7421a0ab957412a8283eee6ae9783dac9d3f6a4a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-11-29 10:33:36 +00:00
Stephen Finucane
5ef5cc9c82 compute: Add server create --no-security-group option
To allow users to create servers with no security groups associated with
the ports.

Change-Id: I91b1d9dd5c3fbba838640841d98341cd8ccb1b16
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-11-29 10:33:18 +00:00
Takashi Kajinami
ecc744a4fd Remove ceilometer service overrides
devstack no longer installs ceilometer services unlesss ceilometer
devstack plugin is enabled, so we can safely remove the options to
disable ceilometer services.

This allows us to remove references to removed services such as
ceilometer-api .

Change-Id: I4201878d0deba4490cf2a08bbabec8fe64474385
2024-11-25 00:41:46 +09:00
Antonia Gaete
4bdd51cbea identity: Migrate 'domain' commands to SDK
Change-Id: Ide9cb9491334e139482f8cf1ea1874d01da0884f
Depends-On: Id1b7b00fe5b96f0cc922716afabcc678193f0f57
2024-11-20 23:28:47 +00:00
Antonia Gaete
4c8290012d identity: Migrate region commands to SDK
Change-Id: I980693732d794f1ccbfc8d7f06d61b4a9824ef15
2024-11-20 23:26:30 +00:00
Zuul
6ff3a92089 Merge "Show Created At column for volume backups in v3" 2024-11-20 16:38:57 +00:00
OpenStack Release Bot
8f56d3f5e4 reno: Update master for unmaintained/2023.1
Update the 2023.1 release notes configuration to build from
unmaintained/2023.1.

Change-Id: Id29f0413825372df296cc123d63cc092fbba1821
2024-11-14 10:17:59 +00:00
Antonia Gaete
9c6df823e2 identity: Migrate 'credential' commands to SDK
Change-Id: I49391fec3d7b6a1b81438a2a311ac7b86173a6a4
2024-11-13 18:13:19 +00:00
Takashi Natsume
fb1f841d2d Replace deprecated datetime.utcnow()
The datetime.utcnow() is deprecated in Python 3.12.
Replace datetime.utcnow() with
datetime.now(datetime.timezone.utc).replace(tzinfo=None).

Change-Id: Ic20174a9c6cacac05471fa57b105c1f784a73057
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
2024-11-13 15:48:59 +00:00
Stephen Finucane
58e21d8e2b requirements: Remove unused test deps
oslotest is not used anywhere, while requests is already a runtime dep.

Change-Id: I852b7d8664cddf22b1314b057c42930580a1f9f4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-11-13 12:14:04 +00:00
Stephen Finucane
8890981491 Skip tips jobs on pre-commit config update
We only need to care about the unversioned tips jobs since [1] will take
care of the others.

[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/933197

Change-Id: I3d569dc496a995eee58fdbcf4a42a187143d1b24
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-11-12 14:10:50 +00:00
Zuul
79e01a5533 Merge "Add "trusted" attribute to the "port"" 2024-11-08 17:32:37 +00:00
Zuul
d17d99faa9 Merge "common: Use correct argument for volume limits" 2024-11-05 20:38:15 +00:00
Stephen Finucane
e5ccf1eb1c common: Use correct argument for volume limits
The sooner we have type hints in SDK, the better /o\

Change-Id: Iaf9596aea02f683c280ae68504a14d43dbd6134a
Closes-bug: #2077634
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-11-05 17:07:49 +00:00
Zuul
974cdd9a4e Merge "Fix ignored --user-domain in role assignment list" 2024-11-05 17:01:54 +00:00
Slawek Kaplonski
47144103ca Add "trusted" attribute to the "port"
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/927723

Related-bug: #2060916
Change-Id: I8e3d4ee2208ef6bb6c96ee430d7b550a0720431e
2024-11-04 09:12:43 +00:00
Takashi Kajinami
2e491191e5 Fix ignored --user-domain in role assignment list
Fix the wrong value assignment which made the --user-domain option
ignored. Unit tests are updated to verify usage of domain options to
avoid further regressions.

Also drop the redundant look up of domain id to avoid unnecessary API
call.

Closes-Bug: #2085604
Change-Id: I5112b8e831fb26eb6544615277f0d3fe4f15dc5a
2024-10-29 21:20:07 +09:00
Tobias Urdin
695d025f00 Show Created At column for volume backups in v3
The change in [1] erroneously only added the
created_at column for volume v2 API and not
also for the volume v3 API.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/920003

Change-Id: Iae0b4f21cbc31ae7464a79c8f5e01446ca4ff098
2024-10-17 16:25:13 +02:00
Yosef Salmalian
db115c09a2 remove project from network flavor profile
Removing project from network_flavor_profile as neutron api
does not uses project.

Closes-Bug: 2046496
Change-Id: I77b0544cf8629fb0a5b9914361a007d28b2b5662
2024-10-16 10:19:59 +03:30
Stephen Finucane
7c6b47b451 clientmanager: Check for 'block-storage' service type
This is a fun one driven by two separate changes. We recently started
checking whether the volume service was available before setting quotas
in order to allow us to use quota set for other services [1]. This
merged a number of weeks ago and was included in 7.1.0. More recently,
we modified DevStack to stop publishing a service catalog entry with a
service type of 'volumev3', preferring instead to use the correct
'block-storage' service type. Taken separately, neither of these changes
would have caused issues. Together, they mean our lookups for the volume
service now fail and we can't set volume quotas.

Fix things by checking for the block-storage service type also. A future
change will raise a warning (later an error) if the volume service is
not found and you're attempting to set a quota since this is clearly a
mistake.

Change-Id: Ibbeef52225e18757cd28d0fbfb14c1ca06975b60
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2084580
2024-10-15 18:07:26 +01:00
Rajat Dhasmana
b6b18489b0 Fix volume backup show by name
When we show a volume backup by name, it calls the get_backup
method in SDK which is only used for getting a backup by ID.
This patch modifies the approach to call find_backup method
which first tries the find by ID and then find by name logic
eventually returning the backup details.

Story: 2011234
Task: 51127
Change-Id: I926d8de9810fcf2e5335bbe35aaab15e1e36a5cb
2024-10-07 13:25:14 +00:00
Zuul
8979c00150 Merge "Always resolve domain id" 2024-10-03 11:59:16 +00:00
Takashi Kajinami
c8326b5525 Always resolve domain id
The --user-domain option and the --project-domain option may take id or
name. In case name is given it should be translated to id.

Closes-Bug: 2083390
Change-Id: Idf3f113a74452daabc80660574030cb9b24b1a15
2024-10-01 15:37:27 +00:00
Zuul
ac59673b5d Merge "Add status filtering options to port list" 2024-09-30 17:38:14 +00:00
Alfredo Moralejo
52d56b3fd9 identity: in service set command, don't pass the enable option when it is None
Currently, it is passing None value which is not accepted by keystone
parameters validation:

BadRequestException: 400: Client Error for url: ... Invalid input for field 'enabled': None is not of type 'boolean'

Failed validating 'type' in schema['properties']['enabled']:
    {'enum': [True, False, None], 'type': 'boolean'}

On instance['enabled']:
    None

Closes-Bug: #2083021
Change-Id: Ia8772560deb54e71672102157659d4eb22e6ad59
2024-09-30 13:45:03 +02:00
Zuul
2f790c319d Merge "identity: Don't pass unset options when creating user" 2024-09-25 08:22:26 +00:00
Sylvain Bauza
58d1b06fdc evacuate SDK actually uses admin_pass param
Change I0cd86675a884e6c2cbd3a861b8e111f961f0f336 was incorrect,
the SDK param name is admin_pass.

Change-Id: Ibe22c3d7d7ba0f1a5178475143e35fee5cac2ca2
2024-09-18 08:46:44 +02:00
Zuul
b92291f0aa Merge "compute: Allow adding, removing multiple SGs" 2024-09-17 13:26:47 +00:00
Stephen Finucane
033793aa0e identity: Don't pass unset options when creating user
In change I06f3848812bce60c65909f1311f36b70eba427d4, we migrated the
'user *' commands from keystoneclient to SDK. One side effect of this is
that we are no longer able to rely on keystoneclient's 'filter_none'
helper method that filters out parameters that are set to None. As such,
we now need to do this ourselves. Eventually, it would be nice if SDK
provided such functionality itself.

The same change also introduced a bug where the '--domain' argument was
being used to lookup a project rather than the '--project-domain'
argument. This is also corrected.

Change-Id: I1204ca611a74d134c879467d6c2b73f16e043213
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2080600
2024-09-17 13:26:26 +01:00
zhangoic
9c223696a0 Add status filtering options to port list
The patch adds "--status" options to list command.

Change-Id: I710437f67e9432b2b6389986bc922eac4a60c934
Partial-bug: #1672680
2024-09-17 12:56:21 +01:00
Antonia Gaete
415f68016c identity: Migrate 'access rule' commands to SDK
Change-Id: Id5740cc61474650f22f9efe8d148c8c666c3b91e
2024-09-17 11:52:46 +01:00
Stephen Finucane
bbe04238a8 tests: Add functional test for access rules
Change-Id: I0131eab2e5395ed530c05a2e9c91b348a7a34c13
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-09-17 11:51:54 +01:00
Zuul
31251e33ec Merge "Handle NotFoundException when listing floating IPs" 2024-09-13 18:58:51 +00:00
Zuul
e46a7a2adc Merge "pre-commit: Migrate pyupgrade to ruff" 2024-09-13 17:35:54 +00:00
Zuul
eaec72e2ba Merge "pre-commit: Migrate bandit to ruff" 2024-09-13 17:35:52 +00:00
Zuul
f63784606d Merge "evacuate: Fix password parameter name for SDK" 2024-09-13 17:35:50 +00:00
Zuul
86720f8a95 Merge "tests: Remove aliasing from extensions test" 2024-09-13 12:36:49 +00:00
Zuul
108aeb0bdf Merge "Remove TestServer base class" 2024-09-13 12:36:47 +00:00
Dr. Jens Harbott
8932282952 evacuate: Fix password parameter name for SDK
The parameter is called admin_password on the SDK side.

Change-Id: I0cd86675a884e6c2cbd3a861b8e111f961f0f336
2024-09-13 13:22:26 +02:00
Nate Johnston
b0936c5b30 Handle NotFoundException when listing floating IPs
Asking for floating IPs on an undercloud results in a NotFoundException.
Make openstackclient handle it gracefully.

No test is added for this because it would need to be a scenario test -
deploying a cloud without the foalting IP extension loaded.  I don't
think this edge case is worth an entire new job just to exercise it.

Change-Id: I73b544853376d98ab0dbb14e32fefc43c1a8a179
Story: 2006863
2024-09-13 11:34:05 +01:00
Zuul
067261e80d Merge "Removed the emit_duplicated_warning() funtion." 2024-09-12 19:19:48 +00:00
Zuul
e319df4726 Merge "compute: Fix --host in server list for new openstacksdk" 2024-09-12 18:37:15 +00:00
Stephen Finucane
f98006ca9d pre-commit: Migrate pyupgrade to ruff
Change-Id: Ic50d2a5e0bc9dcdfe29f382607135cab510cd396
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-09-12 18:08:23 +01:00
Stephen Finucane
fc6852cd94 pre-commit: Migrate bandit to ruff
The name of the errors change and we need to move things around a
little, but it's otherwise a straight swap.

Change-Id: I0a19765ebeaa14c0534faa1542165b76ed2bf4e2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-09-12 18:08:23 +01:00
Zuul
e60ca0f898 Merge "Drop support for Python 3.8" 2024-09-12 16:28:24 +00:00
Mohammed Al-Dokimi
2bf123f315 Removed the emit_duplicated_warning() funtion.
Since this function is called once, I moved its implementaion to where
its called.

Story: 2010344

Change-Id: Iaf06def1a06ffbb605ee42569e6f87b409a72772
2024-09-12 14:42:57 +01:00
Johannes Kulik
ffa683ab4e compute: Fix --host in server list for new openstacksdk
With `openstacksdk` 3.2.0 the `host` attribute of an Instance got added
to the `Server` class [0]. With that change, listing servers with the `host`
attribute leads to a query-filter for `compute_host` as expected, but
`openstacksdk` will also filter for the `host` attribute locally after
the results are returned. Since `compute_host` being
`OS-EXT-SRV-ATTR:host` is not the same as `host, this means no results
are returned.

Since we want to keep the old behaviour of filtering by `compute_host`
i.e. the service host name, we need to switch to filter for
`compute_host`. This is already supported in older versions of
`openstacksdk`.

[0] 0f311ff3e2

Change-Id: I0cd32c5b7d6d4d21194f3efdcfb9b205dea6a91e
Closes-bug: #2074200
2024-09-12 12:51:36 +00:00
Zuul
c2d96c5938 Merge "pre-commit: Migrate from black to ruff format" 2024-09-11 21:16:47 +00:00
Zuul
6e1a5ed5a6 Merge "trivial: Remove unnecessary trailing comma" 2024-09-11 21:16:45 +00:00
Zuul
9fca2b51ee Merge "pre-commit: Migrate from flake8 to ruff" 2024-09-11 21:16:44 +00:00
Zuul
21a384a868 Merge "pre-commit: Bump versions" 2024-09-11 21:16:42 +00:00
OpenStack Release Bot
b0c08ae29a Update master for stable/2024.2
Add file to the reno documentation build to show release notes for
stable/2024.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.2.

Sem-Ver: feature
Change-Id: I5b2c70118df024dfc9236c7e1fa39554ffccf5e0
2024-09-11 16:07:20 +00:00
Zuul
73e9dd1934 Merge "quota: Allow 'quota set' to function without volume service" 2024-09-06 15:46:49 +00:00
Stephen Finucane
519fa7aabc pre-commit: Migrate from black to ruff format
Change-Id: I28ca7d31d30272002799f3e2832105dc67c60538
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 15:55:39 +01:00
Stephen Finucane
17e6545fd4 trivial: Remove unnecessary trailing comma
Change-Id: I62402145c17f96626ec6e29598e32dee03a6038e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 15:55:39 +01:00
Stephen Finucane
2ba90581d5 pre-commit: Migrate from flake8 to ruff
Well, mostly. We still keep our own flake8 hooks and the hacking hooks
enabled. Everything else can be handled by ruff.

Doing this enables a couple of hacking checks that were previously
unaddressed. It also highlights a few cases that flake8 missed. Both are
addressed.

Change-Id: If81c7055e9ef692425da2789bae18a96d04b104f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 15:55:13 +01:00
Stephen Finucane
869b07eded pre-commit: Bump versions
We also drop the default language setting: everything is Python 3
nowadays.

Change-Id: I9dc9573a86c93416d1bbbc782dac76ecdda6effd
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 10:58:38 +01:00
Zuul
9c5fd76d9e Merge "compute: Add 'uuid' column to aggregate list" 2024-08-27 17:21:35 +00:00
Zuul
50d1e0916b Merge "Add callback on plugin load failure" 2024-08-14 11:12:03 +00:00
Zuul
bc6cff777f Merge "compute: Make 'hypervisor show' a bit faster" 2024-08-12 16:45:25 +00:00
Zuul
6312a6f452 Merge "compute: Only pass admin_password on rebuild if set" 2024-08-12 16:44:11 +00:00
Zuul
0d570cd66a Merge "identity: Use previous naming for 'service show' fields" 2024-08-12 16:01:30 +00:00
Zuul
e97e59d22d Merge "identity: Use previous naming for 'application credential show' fields" 2024-08-12 15:49:39 +00:00
Zuul
1aa077efee Merge "Add Python 3.12 classifier" 2024-08-09 13:10:32 +00:00
Zuul
d385bd1e03 Merge "Show Created At column for volume backups" 2024-08-09 12:20:45 +00:00
Zuul
f2cf938979 Merge "Bump requests minimal version" 2024-08-08 17:18:03 +00:00
Stephen Finucane
25780e80ab identity: Use previous naming for 'service show' fields
We changed these in change I37d07a6c5cdc98680b8d65d596521cad2b049500 but
the '-c/--column' option provided by cliff currently requires an
explicit match on column names. Change them back for now. We can revert
this when cliff is a little bit smarter.

Change-Id: I9180922e9da5c22ae3d8878946d1bf1ec4b8c6e1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2076212
2024-08-08 10:54:10 +01:00
Stephen Finucane
0e731cd22f identity: Use previous naming for 'application credential show' fields
We changed these in change Iba3fee2672d32266623c6f367beaabe84bd3d24e but
the '-c/--column' option provided by cliff currently requires an
explicit match on column names. Change them back for now. We can revert
this when cliff is a little bit cleverer.

Change-Id: I6b4f1b793dc383856bfdf9a01514381be3cd2bf1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-bug: #2076212
2024-08-08 10:53:25 +01:00
Stephen Finucane
4a2fd82b07 compute: Make 'hypervisor show' a bit faster
In the event that a user provides a hypervisor name rather than an ID to
the 'hypervisor show' command, passing 'details=True' (the default) to
'find_hypervisor' will ensure we get the detailed response we need.
However, this comes at the cost of retrieving reams of additional
irrelevant data for all the other hypervisors. Rather than doing this,
use a summary view and then a second call to fetch only the hypervisor
we care about.

Change-Id: I92b53802e41a962c6f916c3a111dc2de7c12d0fc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2072965
2024-08-07 13:50:28 +01:00
Stephen Finucane
04ebe0853d compute: Add 'uuid' column to aggregate list
Change-Id: I15d4a2d5980c1ba3e00f7d1bd09f11d0f42564e1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2073542
2024-08-07 13:24:23 +01:00
Stephen Finucane
b8459c57c8 compute: Only pass admin_password on rebuild if set
In SDK change I3bc3150877c6c00aa9ec4355104308d7755aa1d4, we modified the
'rebuild_server' proxy method to use a sentinel 'unset' value so that we
could distinguish between fields that were not being changed and those
that were being changed to 'null'. However, we are currently passing the
'admin_password' field to the 'rebuild_server' SDK proxy command
regardless of whether it is set or not. Resolve this conflict.

Change-Id: If7b7585aadd43cdc6d2a9358f14223e43dc21a73
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2076232
2024-08-07 13:06:13 +01:00
Stephen Finucane
6693f555bc quota: Allow 'quota set' to function without volume service
Unlike cinderclient, SDK attempts to connect to a service as soon as you
create a client. A keystoneauth1.exceptions.catalog.EndpointNotFound
exception can be raised if this service does not exist in the service
catalog. Avoid this for the quota and limits commands by first checking
if the service is enabled.

In the process, we rework the 'is_volume_endpoint_enabled' helper we are
using to check for the existence of the service to *not* require a
volume client, since this was causing a chicken and egg issue for us
(and was also pretty much unnecessary).

Change-Id: I56e68f00ea221d689eb7f668e9e5ffa7d1a20184
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2076229
2024-08-07 11:56:07 +00:00
Zuul
a59262e44d Merge "Respect --skip-resource when deleting." 2024-08-01 13:21:54 +00:00
Joel Capitao
5238394e6a Bump requests minimal version
It's a follow-up of [1].
JSONDecodeError exception was implemented in requests
since 2.27.0 [2].

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/924927
[2] db575eeedc

Change-Id: I8a6a8ac064cb0703097ed686b1fcd2983181fcfa
2024-08-01 09:38:23 +02:00
Tim Bishop
1d4aabab2e
Respect --skip-resource when deleting.
When running project cleanup and using the --skip-resource flag, this
flag is only used during the --dry-run stage. This change ensures it is
also used when deleting the resources which fixes the bug mentioned below.

Closes-Bug: #2074109
Change-Id: I8e50fd14dcde069b932cc8ec4bb4fc809f7d2eb7
2024-07-25 20:20:56 +01:00
Stephen Finucane
aa88db9448 Add callback on plugin load failure
I have seen a few cases where import errors (distutils - I am looking at you)
result in an extension not being available, but there is no indication why this
is the case. We do configure logging, but this happens too late (as part
of the 'cliff.app.App.run' call to execute a command, which calls
osc-lib's 'configure_logging' but which happens long after we've tried
to import our plugins) to be of any use. Instead, make use of a callback
to make it more obvious.

Change-Id: Id68b06161e445b79fe43f463e06cda3c4771ef02
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-24 17:00:07 +01:00
Zuul
37a22cf84c Merge "Add tests for 'default security group rule create'" 2024-07-23 15:25:51 +00:00
Zuul
965c61c90c Merge "Add volume snapshot unmanage support" 2024-07-23 12:58:03 +00:00
Zuul
e650c3eeaa Merge "Add DeleteVolumeSnapshot class to v3" 2024-07-23 12:58:02 +00:00
Zuul
c47ccb9721 Merge "Followup: Reduce LOC in volume v3 service" 2024-07-23 12:58:00 +00:00
Stephen Finucane
7a92bc4abc Drop support for Python 3.8
This goes EOL in October. We don't want to be supporting it past then.
Drop it now.

Change-Id: I6166678a35092760718d4fcd0357e7195bbe8be0
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-19 12:27:07 +01:00
Stephen Finucane
f885a47450 Add Python 3.12 classifier
We are testing this in CI and can support it going forward now. The
osc-tox-py310-tips job is removed in a favour of a new
osc-tox-py312-tips job.

Change-Id: I87a726cb65223cba9975d0505c13fe42dcd7fa14
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-19 12:24:47 +01:00
Zuul
b223156906 Merge "Remove python-novaclient" 2024-07-18 18:03:28 +00:00
Zuul
70fbf687cf Merge "quota: Migrate 'quota *' to SDK" 2024-07-18 17:53:24 +00:00
Zuul
2d59c675dd Merge "quota: Split up 'quota list' command" 2024-07-18 13:35:21 +00:00
Zuul
692b06dfd5 Merge "quota: Default network quotas to not force" 2024-07-18 13:35:19 +00:00
Stephen Finucane
f68000d772 tests: Remove aliasing from extensions test
This isn't necessary and makes migration of the compute client a little
more difficult.

Change-Id: Ib07e60171c43838935ea30f4916bf68d54cdc944
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-18 13:39:39 +01:00
Stephen Finucane
0d89f01448 Remove TestServer base class
Simplify this somewhat.

Change-Id: I4ece72344e0e671c2f190fa9200e91d72333e96d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-18 13:28:51 +01:00
Stephen Finucane
438e40db36 Remove python-novaclient
There are a few remnants left here but this is trivial to clean up now.

Change-Id: I517d906796338e64a31afa08b9ee6909b08e0115
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-18 13:28:51 +01:00
Stephen Finucane
ece30e8f70 compute: Allow adding, removing multiple SGs
We also ensure we call neutron rather than the deprecated nova proxy API
in the event that neutron is available.

Change-Id: I8315ea164fd3fa6c1d759f16677bfd6c24c4ef63
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-18 12:41:51 +01:00
Zuul
97bded1a3d Merge "quota: Add 'quota set --default' option" 2024-07-18 11:26:26 +00:00
Stephen Finucane
6127b44d0a quota: Migrate 'quota *' to SDK
This is done for both the compute and block storage services. The
network service was already using SDK.

Change-Id: Id7a6943b8b4d7d1330e7d7f13705f027d1b67189
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/923864
2024-07-15 18:19:43 +01:00
Zuul
45ac2b62fb Merge "quota: Remove deprecated quota options" 2024-07-15 16:17:47 +00:00
Zuul
cf81902402 Merge "quota: Move nova-network-related quota" 2024-07-15 16:02:25 +00:00
Zuul
716dff1052 Merge "tests: Remove references to novaclient methods" 2024-07-15 15:15:03 +00:00
Zuul
7219144dae Merge "network: Replace use of in-tree API client" 2024-07-15 15:01:18 +00:00
Zuul
e08cf1790f Merge "compute: Migrate 'server create' to SDK" 2024-07-15 15:01:16 +00:00
Zuul
c78cba654a Merge "compute: Prevent use of conflicting v*-fixed-ip for 'server create --nic'" 2024-07-15 13:12:58 +00:00
Zuul
1b8eabee4e Merge "compute: Migrate 'server evacuate' to SDK" 2024-07-15 13:05:00 +00:00
Zuul
f58f85857b Merge "compute: Migrate remaining server actions to SDK" 2024-07-15 13:04:59 +00:00
Zuul
c18eab5198 Merge "compute: Migrate 'server rebuild' to SDK" 2024-07-15 13:04:57 +00:00
Zuul
855686a881 Merge "compute: Avoid third API call during 'server show'" 2024-07-15 13:00:11 +00:00
Zuul
f1a3fc319d Merge "compute: Always use SDK client to display server" 2024-07-15 13:00:07 +00:00
Zuul
5898f13473 Merge "compute: Migrate 'server set', 'server unset' commands" 2024-07-15 13:00:02 +00:00
Zuul
816f4857dc Merge "compute: Migrate 'server migrate' to SDK" 2024-07-15 12:59:58 +00:00
Zuul
8b783fd8ad Merge "compute: Migrate 'server add/remove security group' to SDK" 2024-07-15 12:59:54 +00:00
Zuul
10b448351d Merge "common: Migrate 'limits show' to SDK" 2024-07-15 12:59:52 +00:00
Zuul
cd107ea7b6 Merge "docs: Fix indentation" 2024-07-15 12:46:12 +00:00
Zuul
2733b3413d Merge "identity: Migrate 'service' commands to SDK" 2024-07-12 14:07:22 +00:00
Zuul
7de15cee16 Merge "identity: Migrate 'application credential' commands to SDK" 2024-07-12 13:54:38 +00:00
Stephen Finucane
b4f30a1583 quota: Split up 'quota list' command
This is really three separate commands rolled into one. Split the logic
up more to simplify it somewhat.

Change-Id: Ief3c3c413f791dda076f90e5ec76a033d3a9e12b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-11 11:34:24 +01:00
Stephen Finucane
da7eda66e9 quota: Default network quotas to not force
The existing default behavior has been deprecated for over a 18 months
(change I25828a3d68e2e900f498e17a0d01fb70be77548e). It's time for a new
default.

Change-Id: Iaf4fa931dcbf16c22933f63629c6a4d443ac5310
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-11 11:34:02 +01:00
Stephen Finucane
7d8baa87bb quota: Add 'quota set --default' option
This should have been added as a counterpart to the 'quota show
--default' option way back when we added that. Better late than never!

Change-Id: I0e3719e585353664fea6f23ec658a330086db3df
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-11 11:21:24 +01:00
Stephen Finucane
ba2d2358e6 quota: Remove deprecated quota options
These are all deprecated for over 18 months (change
I0dd38e5cb252a01d5817ed168be040b21b35e348). It's time to remove them and
simplify this code.

Change-Id: I9ee3bfebbad21eec3eb1b475a813bcbc450edea4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Change-Id: Ibdd329a6db8bd176af065d7f5190f0901d3c3f8d
2024-07-11 11:10:11 +01:00
Stephen Finucane
f5f543b8de quota: Move nova-network-related quota
This was incorrectly grouped as a general compute quota, when in fact
it's a nova-network quota. Move it.

Change-Id: If93c95bc181ab766137b61943a09821810345300
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-10 12:16:16 +01:00
Stephen Finucane
75b9214f6c tests: Remove references to novaclient methods
These should have been cleaned up as we went but weren't. Fix things
now.

Change-Id: I80b29c0fd6e4f557c2efc45474279306f50c4fd7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-09 18:19:36 +01:00
Stephen Finucane
209f8e9e17 network: Replace use of in-tree API client
None of these are actually supported by openstacksdk (intentionally so)
so we add our own manual implementations.

Change-Id: Ifd24f04ae4d1e56e0ce5ba0afe63828403bb7a6f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-09 18:19:36 +01:00
Stephen Finucane
30a64579b6 compute: Migrate 'server create' to SDK
The final step. Future changes will clean up the remnants of the
novaclient usage. This is a rather large patch, owing to the number of
things that novaclient was handling for us which SDK does not, but the
combination of unit and functional tests mean we should be handling
all of these differences.

Change-Id: I623e8c772235438a3d1590e1bbd832748d6e62ea
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-09 18:17:22 +01:00
Antonia Gaete
bef8a7a630 identity: Migrate 'application credential' commands to SDK
Change-Id: Iba3fee2672d32266623c6f367beaabe84bd3d24e
2024-07-09 15:19:38 +00:00
Antonia Gaete
717f242881 identity: Migrate 'service' commands to SDK
Change-Id: I37d07a6c5cdc98680b8d65d596521cad2b049500
2024-07-09 15:09:37 +00:00
Stephen Finucane
d22f26446a compute: Prevent use of conflicting v*-fixed-ip for 'server create --nic'
Currently this check is handled by novaclient. In the future, we won't
have that so we need to do it ourselves. Do so now, fixing a typo along
the way and adding tests to prevent regressions.

Change-Id: Iaa9c087d846390b6a4f95ed3fa121dd8dc640903
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-09 14:35:05 +01:00
Stephen Finucane
e6dc0f39c0 compute: Migrate 'server evacuate' to SDK
Change-Id: I8ea2da0921c5fd306271f03fa733c0f9787afb82
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/918745
2024-07-08 16:07:07 +01:00
Stephen Finucane
b9b5e7615a compute: Migrate remaining server actions to SDK
Migrate the following commands:

- 'server delete'
- 'server rescue'
- 'server unrescue'
- 'server resize'
- 'server resize confirm'
- 'server resize revert'
- 'server migrate confirm'
- 'server migrate revert'
- 'server remove fixed ip' ('server add fixed ip' was already migrated)
- 'server ssh'

That leaves a few commands to migrate, all of which are called out with
TODOs.

Change-Id: Idb769a93609da522c458e719bc69a63ff2ab107b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 16:06:59 +01:00
Stephen Finucane
8d904a9efb compute: Migrate 'server rebuild' to SDK
Change-Id: Ic7cdb05327a4a74364f08451e531d02c631b7633
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/918730
2024-07-08 11:07:09 +00:00
Stephen Finucane
2057462120 compute: Avoid third API call during 'server show'
We can use a detailed list instead when looking up by name. We also
improve tests somewhat.

Change-Id: I18b38e7fbcac813190b304c4d67d8ea03d8c1a80
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 11:06:11 +00:00
Stephen Finucane
628ac48901 compute: Always use SDK client to display server
This affects the 'server create', 'server show', 'server rebuild' and
'server set' commands. We also fix a few mistakes around the fields
shown.

Change-Id: I9946e12146efff39f9ba1591c90a4a9bccd46919
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 12:00:49 +01:00
Stephen Finucane
bcaf2ab559 compute: Migrate 'server set', 'server unset' commands
Change-Id: I2c249e9ca3952100dcf7f97fcafa879b733d34c6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 10:30:44 +01:00
Stephen Finucane
c8621e5b8b compute: Migrate 'server migrate' to SDK
Change-Id: I56d31c2fd4f8bf19eedd8f9eecd8a41cdafc5b55
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 10:30:44 +01:00
Stephen Finucane
abef798f30 compute: Migrate 'server add/remove security group' to SDK
We need to work around SDK's (intentional) lack of support for Nova's
deprecated '/os-security-groups' API but it's nothing too crazy.

Change-Id: I03ca1a73f98aa77b288148607baff336dae69fb1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 10:30:44 +01:00
whoami-rajat
9d39437282 common: Migrate 'limits show' to SDK
This is done for both the compute and block storage services even though
the compute service hasn't supported rate limits since API v2.1 was
introduced [1].

[1] https://github.com/openstack/nova/commit/ca4ec762804

Change-Id: Idd9f4a1c23952a6087f08c03ac8b5bebd5a0c86d
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/918519
2024-07-08 10:30:36 +01:00
Stephen Finucane
55cbb84e60 volume: Migrate 'volume list' to compute SDK
Change-Id: Iae662aa6b391ba6ae5f569184c7d19fb3654be35
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
whoami-rajat
9f30ee9af2 volume: Migrate 'volume attachment *' to SDK
This patch migrates the volume attachment create, get, list,
delete, update and complete commands to SDK.

Change-Id: Ib237d25cc1c3fc72946b9d088ff3447433162130
2024-07-08 09:59:21 +01:00
Stephen Finucane
402327f2e4 tests: Migrate to 'set_xxx_api_version' helpers
Clean things up somewhat.

Change-Id: I868f496fc8285a28e8fd551377f2ae6228051d19
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
Stephen Finucane
88fffeabd7 tests: Add ability to configure fake server API version
This beats the horrible mess of mocks we have created for ourselves.

Change-Id: I8af3ce0a0b10f52e2124ec86f306327ff3474982
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
Stephen Finucane
3f624295ec volume: Add v3-specific volume transfer module
This makes testing easier.

Change-Id: I515aa54750439a6c4ad5b16cffe004ba1c7cf5b2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
Stephen Finucane
f1f390f2ae volume: add v3-specific volume type module
This makes testing easier.

Change-Id: If1ed8d5003160e45d503971ae722fd9983d3dd6d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
Stephen Finucane
65cce3943a volume: Add v3-specific volume module
This makes testing easier.

Change-Id: I6b31026ae3c9dc66d828744534b35bb0a0d2ffbe
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:21 +01:00
Stephen Finucane
ca91c826e3 volume: Add v3-specific volume backup module
This makes testing easier.

Change-Id: I71a13b34a85350af17612e12c03e6df8cb041f86
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-08 09:59:20 +01:00
Zuul
a6dcb773f1 Merge "Fix: incremental volume backup" 2024-07-05 19:55:12 +00:00
Stephen Finucane
3f781cc3f9 docs: Remove references to novaclient
Change-Id: Ieb1dc77f311a2e279036587a1f8d575a387494d0
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-02 17:52:02 +01:00
Stephen Finucane
0f006392ac compute: Migrate remaining tests to SDK objects
Change-Id: I33b80007777a0483964cc04357961bf0c5eda6e5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-02 17:52:02 +01:00
Stephen Finucane
7252a7a781 compute: Migrate 'host set' to SDK
This was the sole outstanding command to be migrated to SDK. We also
clean up the old in-tree wrappers we have in the process and add missing
error checks for the 'host list' and 'host show' commands.

Change-Id: I5635469b63ab3370fb5118e4f8a1758002381aa5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-02 17:52:02 +01:00
Stephen Finucane
0f07c97e84 compute: Migrate 'agent *' to SDK
These are not supported by SDK natively (intentionally so) so we use raw
HTTP requests to manage this migration.

Change-Id: I72fa0d6f87899537a24090995b1ba884bc5f9d4d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-02 17:52:02 +01:00
Stephen Finucane
e0f7306011 network: Migrate 'port list' to compute SDK
We use the compute client here to look up server IDs when filtering by
'device_id'.

Change-Id: I76515eaa4ce4e7c7d0173d2e0a91d7564ba7041a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-02 17:52:02 +01:00
Stephen Finucane
aa5eb881e5 compute: Migrate tests for ShowServer to SDK objects
This is a little more realistic. We fix a minor bug along the way and
start ignoring some newly added create-only fields.

Change-Id: I93eae610e16e2a3a859f684b889546ace3afa683
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2024-07-02 17:51:49 +01:00
Zuul
518420abe4 Merge "compute: Remove unnecessary try-except" 2024-07-01 22:38:55 +00:00
Rajat Dhasmana
205bac3caf Fix: incremental volume backup
The incremental volume backup stopped working after we moved from
cinderclient to SDK[1]. This happened because SDK accepts the
``is_incremental`` parameter[2] rather than the ``incremental`` parameter
which is actually passed in the API request and was previously a valid
parameter for cinderclient.

This patch fixes the issue by passing the ``is_incremental`` field instead
of ``incremental`` from the OSC side which adds the ``incremental`` parameter
in the API request.

Request body after the fix:

'{"backup": {"name": null, "description": null, "volume_id": "<vol-id>",
"force": false, "container": null, "incremental": true}}'

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/889748
[2] 10e5e20fc0/openstack/block_storage/v2/backup.py (L126-L134)

Closes-Bug: #2070080
Change-Id: I89bd3d2751267ec39f4dbd664b7873ab87a9ac6c
2024-07-01 21:11:46 +05:30
Stephen Finucane
21155be2e4 docs: Fix indentation
Additional paragraphs in a rST list should be indented by the same
number of characters as the first paragraph otherwise it renders as a
block quote. Correct this for the backwards incompatible changes guide.

Change-Id: I918c2a24aead4cc5a317201df9b12ce740612e5a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-07-01 12:38:42 +01:00
Stephen Finucane
40ce56201c compute: Remove unnecessary try-except
We don't need to transform one HTTP Forbidden-related error to another:
just use the original one. This also fixes an issue where we would end
up with an undefined variable (server_id) if a non-HTTP 403 exception
was raised, since that would be blindly ignored.

Change-Id: Icdd1764b6f2df4a635e3264ed8f93a115cc52ef2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-Bug: #2062010
2024-07-01 11:11:02 +00:00
Rajat Dhasmana
f52e888dab Followup: Reduce LOC in volume v3 service
This is a followup of[1] in which we are reducing LOC by removing
redundant definition of columns.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/922865

Change-Id: I2992d3ab678e751726906926b680e4aa9ad1d502
2024-06-28 20:40:06 +05:30
Rajat Dhasmana
ca81b1acf0 Add cluster to volume service list
This patch adds the ``Cluster`` and ``Backend State`` columns to
the ``openstack volume service list`` command. Note that you need
to provide the appropriate microversion to show these columns.

Cluster: openstack --os-volume-api-version 3.7 volume service list
Backend State: openstack --os-volume-api-version 3.49 volume service list

Change-Id: Ie7727d0001307b5d5a40d7ea0348bdb9626f9e03
2024-06-27 19:37:15 +05:30
Brian Haley
75696f8f3f Add tests for 'default security group rule create'
A previous change fixed a bug with the custom SG rule
flag, but did not add any tests to verify all the
combinations of default and custom SG flags. Let's
add them now.

Change-Id: Id74552346cfa975e3dd5eb45b8f621b365e88463
Related-bug: #2054629
2024-06-26 16:36:32 -04:00
Rajat Dhasmana
4e94c415ed Add volume snapshot unmanage support
This patch adds support for unmanaging a snapshot with
``openstack volume snapshot delete --remote`` command.

Change-Id: I3caf3471a007fcb988835d495727bbc5c66f42f8
2024-06-25 01:51:50 +05:30
Rajat Dhasmana
49c42c73a2 Add DeleteVolumeSnapshot class to v3
This is done to support the snapshot unmanage command.

Change-Id: I174ad08c7c03fe7a9206d40645a6916f104212c6
2024-06-25 01:40:55 +05:30
Zuul
dd6ac285d5 Merge "Identity: Migrate 'role assignment' commands to SDK" 2024-06-17 11:41:01 +00:00
ArtofBugs
de9d0f9e1b Identity: Migrate 'role assignment' commands to SDK
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/913448
Change-Id: I579775d2dc4110951e934e00b51bf8d7546e207b
2024-06-13 16:00:54 -07:00
Stephen Finucane
887f1e9385 tox: Add testenv descriptions
Change-Id: I0a7880d72248e94690a973d3a1fd33c176ed658e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-06-12 14:40:50 +00:00
Zuul
19c053efb8 Merge "Add support for volume unmanage" 2024-06-11 15:11:11 +00:00
Rajat Dhasmana
fdc2763ac2 Add support for volume unmanage
This patch adds support for unmanaging a volume with the
``openstack volume delete --remote`` command.

Change-Id: Id71681e817f6e56b4ef553079f0bcfac8252d3cf
2024-06-10 20:48:30 +05:30
Brian Haley
5483370981 Remove admin only text from 'port create' help text
Specifying a MAC address is only admin only for
'port set' [0], remove it from the 'port create'
help text.

[0] https://docs.openstack.org/api-ref/network/v2/index.html#ports

Change-Id: Ic3296dd03676b460b3d08b1bbaae6f1d132e839d
2024-05-24 16:38:50 -04:00
Zuul
d9b95d776a Merge "Fix tests on Python 3.12" 2024-05-21 07:41:51 +00:00
Zuul
525fabe051 Merge "Drop direct dependency on simplejson" 2024-05-20 11:45:21 +00:00
Zuul
6dbf7afe1d Merge "Remove clients of retired projects" 2024-05-20 11:45:19 +00:00
Takashi Kajinami
cf6dd62dd1 Drop direct dependency on simplejson
The simplejson library is not included by the requirements but it was
directly imported. Drop the direct inclusion and use the alias in
the requests library to avoid ImportError caused by missing simplejson
in the environment.

Also fix the missing requests library in requirements.

Change-Id: I8713f45c5f2717cc53ba043aaeb479e72f641f78
2024-05-20 09:59:32 +09:00
Tobias Urdin
7eccd403c7 Show Created At column for volume backups
The ``volume backup list`` command does not show the
created_at column for backups which doesn't really
help the end-user since a critical part of a backup
is knowing when it was taken, and fast if there is
a rush doing recovery by restoring a volume from a
backup.

Change-Id: I8d8a7f36c468c9faa2c2c47bfa9ba9e1ca5b9858
2024-05-19 22:17:06 +02:00
Takashi Kajinami
bb459d49a8 Remove clients of retired projects
Murano[1], Sahara[2] Senlin[3], and Solum[4] are being retired because
of no activity and no maintainer.

[1] https://review.opendev.org/c/openstack/governance/+/919358
[2] https://review.opendev.org/c/openstack/governance/+/919374
[3] https://review.opendev.org/c/openstack/governance/+/919347
[4] https://review.opendev.org/c/openstack/governance/+/919211

Change-Id: I20a1f55840abad810517b4f583bb1040e63b6210
2024-05-17 00:50:09 +09:00
Rajat Dhasmana
00af14b3f2 Add DeleteVolume class to v3
This is done to support the volume unmanage command.

Change-Id: Ib59b1f599be152a25c4b6a31988c28079f552ba9
2024-05-15 11:55:50 +05:30
Rajat Dhasmana
cc7773f53b Add support for managing volumes
This patch adds support for the cinder manage command to
bring a volume under OpenStack management.

Change-Id: I12b63bfc4f0c9bc29cf9d4efd9a5cd038ec00af3
2024-05-15 11:53:27 +05:30
Rajat Dhasmana
0d9ace6425 Add CreateVolume class to v3
This patch acts as a base framework to add the parameters needed
for manage volume support.
This includes 2 changes:
1. Move get_parser and take_action code to common methods which
can be utilized by both v2 and v3
2. Make _check_size_arg as a static method and move it inside
CreateVolume class since it's not used by other classes.

[2] was initially thought to be a follow up change but since we
are implementing changes into the _check_size_arg method for v3,
it makes sense to just include it in CreateVolume class to avoid
adding a new additional method. Similar changes are done for v2
as well.

Change-Id: I9315e457ebd6c5ba4cc67452f92c9dc8c139ee3c
2024-05-15 11:46:12 +05:30
Stephen Finucane
4c31284936 Fix tests on Python 3.12
We were seeing the following test failures on Python 3.12:

  openstackclient.tests.unit.common.test_module.TestModuleList.test_module_list_all
  openstackclient.tests.unit.common.test_module.TestModuleList.test_module_list_no_options

Both failures were caused by missing attributes of 'sys', e.g.

  AttributeError: module 'sys' has no attribute 'builtin_module_names'

Fix this by exposing the real 'sys' module as part of our mock of
'sys.modules'.

Change-Id: I17391a46f08896f49dccaf75ad685dab1375a03d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-05-10 11:16:56 +01:00
Zuul
5e5b89f906 Merge "Router flavor_id can be a name" 2024-05-08 19:43:44 +00:00
Zuul
1ea291167b Merge "Improve output of 'server migrate --wait'" 2024-05-07 14:52:05 +00:00
Stephen Finucane
50c595b6e0 identity: Make better use of argparse
Change-Id: I50d2d28422e609656408b9b59f330d6a78314344
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-05-07 11:20:02 +01:00
elajkat
2e7ba5e3dd Router flavor_id can be a name
Change-Id: I72fc21a1adb4790a2a51e9b37744ee1ee3d01f32
Partial-Bug: #2020823
2024-05-06 13:36:04 +02:00
Stephen Finucane
0fd107e6c7 pre-commit: Add pyupgrade hook
Another day, another useful hook. We also ignore the preceding patch
that actually did the work, renaming the incorrect named file in the
process.

Change-Id: I412827761fbdeb36702ebaf5c1b727c62e629299
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-05-03 19:18:45 +01:00
OpenStack Release Bot
25f2e22429 reno: Update master for unmaintained/zed
Update the zed release notes configuration to build from
unmaintained/zed.

Change-Id: Ia39713784cb393f5d2371922eb314720131561f1
2024-04-29 10:48:50 +00:00
Zuul
3950b4f7ce Merge "tests: Fix trivial sorting issue" 2024-04-26 13:08:00 +00:00
Stephen Finucane
837a3dc015 tests: Fix trivial sorting issue
We've seen an ordering issue pop up occasionally in the CI. Resolve it.

Change-Id: I4dd10268b673c260ac0894fac92cd8bea9e626f4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-25 10:34:36 +01:00
Stephen Finucane
c5b772db76 trivial: Prepare for pyupgrade pre-commit hook
This change is entirely automated save for the update of some mocks from
'io.open' to '__builtins__.open').

We are keeping this change separate from addition of the actual hook so
that we can ignore the commit later.

Change-Id: I0a9d8736632084473b57b57b693322447d7be519
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-23 12:24:23 +01:00
Zuul
3de6969dbe Merge "tox: Remove bandit skips, run via pre-commit" 2024-05-03 17:36:21 +00:00
Zuul
7f42cb84b7 Merge "tox: Add functional-pyNN jobs" 2024-05-03 17:36:20 +00:00
Stephen Finucane
0646f9b4e4 tox: Remove bandit skips, run via pre-commit
Most of these skips were unnecessary. The few that did generate warnings
could be skipped.

We also set 'skip_install' since there's no reason to build the package
for linting purposes.

Change-Id: I9644e5c19720b9c41c60e0a5882b7cd7f6a71f7b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-26 13:17:15 +01:00
Stephen Finucane
648d8df578 tox: Add functional-pyNN jobs
Let's us test with specific Python versions. We also merge the
'functional-tips' target in.

Change-Id: I08e1b3e2f4be57aec0c1cd01274d86dfec769666
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2024-04-26 13:16:48 +01:00
Stephen Finucane
ee23995004 pre-commit: Bump versions
We fold in the new black changes also.

Change-Id: I326a0529b6b9f2aa9fbc33862567131839460797
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-23 12:22:26 +01:00
Bence Romsics
bbe686109d
Improve output of 'server migrate --wait'
We have seen users interpret the current output ('Complete') of
'server migrate --wait' as if it meant success as well and be surprised
when later they learned that the migration was complete and failed.

This change adds a pointer to the that output, how to actually check the
success/failure of a migration, hoping to eliminate this user confusion.

Change-Id: I09030705a39405366d6202a5ac743cc4d1ddd63c
2024-04-16 10:58:42 +02:00
Zuul
a79cb608b0 Merge "Add image metadef resource type association commands 'create', 'list', 'delete'" 2024-04-15 14:01:02 +00:00
Zuul
147503f3c6 Merge "Add NUMA affinity policy options "socket"" 2024-04-15 13:00:49 +00:00
Zuul
4d30527659 Merge "Add support for showing requested az in output" 2024-04-15 13:00:47 +00:00
Zuul
c99c189ac5 Merge "Update master for stable/2024.1" 2024-04-15 13:00:45 +00:00
Zuul
c13977fd68 Merge "image cache clear: fix value of default target" 2024-04-15 13:00:43 +00:00
Zuul
7e3664ff07 Merge "Adds CLI support for `glance md-object-property-show`" 2024-04-15 13:00:41 +00:00
Zuul
54bb7477f2 Merge "Do not sort subnet dns_nameservers field" 2024-04-15 13:00:39 +00:00
Zuul
e9aa6f57c5 Merge "Identity: Properly list users in a group in 'user list' commands" 2024-04-15 13:00:37 +00:00
Zuul
07b71fc99c Merge "Tox: Fix install commands for unit-tips and functional-tips" 2024-04-15 12:52:40 +00:00
Antonia Gaete
276dbb6f56 Add image metadef resource type association commands
'create', 'list', 'delete'

Change-Id: I2c860427b0b2693076cfe57841f0e512ad1f6388
2024-04-15 11:42:45 +00:00
Zuul
9db8902c2b Merge "tests: Remove use of unnecessary fake argparse Namespace" 2024-04-12 17:28:37 +00:00
Zuul
9ca9eba624 Merge "tests: Use consistent shortcut to fake identity client" 2024-04-12 17:09:15 +00:00
Zuul
34ae192332 Merge "refectoring: remove duplicate declaration" 2024-04-12 01:55:18 +00:00
Stephen Finucane
bb6b1e38cb tests: Remove use of unnecessary fake argparse Namespace
Change-Id: I135c24d0f6450d5af4e1860218bf3a65c09e36cc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-11 11:23:20 +01:00
Stephen Finucane
ea202fe77c tests: Use consistent shortcut to fake identity client
Change-Id: I72e016b8146e38948b6ae857bf7ec0b18f4e3663
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-11 11:23:16 +01:00
ArtofBugs
948b97d09e Identity: Properly list users in a group in 'user list' commands
Change-Id: Ia4457eaea5016b2e0325c6eb704d1592058e455e
2024-04-09 12:15:00 -07:00
Zuul
57c73101a2 Merge "refectory: remove unreachable code" 2024-04-09 18:38:16 +00:00
Zuul
7c18388235 Merge "Fix typo in the list of Glanceclient/OSC commands" 2024-04-09 18:38:14 +00:00
Zuul
9467b404c7 Merge "volume: Deprecate '--retype-policy' in favor of '--migration-policy'" 2024-04-08 12:36:54 +00:00
Zuul
1a38af53eb Merge "volume list: Don't call nova if no volume is attached" 2024-04-08 11:40:41 +00:00
Rajat Dhasmana
5a18f995a8 volume: Deprecate '--retype-policy' in favor of '--migration-policy'
The '--retype-policy' option is used in the 'volume set' command to
specify the migration policy during the retype operation. The
'--retype-policy' option does not convey the correct meaning of its
usage. The migration policy determines whether we are going to perform
the migration in the retype operation or not and is not related to the
actual retype which just changes the volume type of the volume.

Change-Id: I2ea8fd3f5277bb3422ccae915d05e8ad44ff1912
2024-04-08 11:37:42 +01:00
Zuul
51f173c8cc Merge "Add router default route BFD/ECMP options" 2024-04-05 15:55:03 +00:00
Zuul
79974668b8 Merge "Add support for managing external gateways" 2024-04-05 15:55:01 +00:00
ArtofBugs
a45a3642b5 Tox: Fix install commands for unit-tips and functional-tips
Change-Id: I352ea2b18a8bdb57cd3027c2024834db091a5643
2024-04-04 17:09:28 -07:00
ArtofBugs
680e3e3011 identity: Migrate 'user' commands to SDK
Change-Id: I06f3848812bce60c65909f1311f36b70eba427d4
2024-04-04 16:22:56 -07:00
Stephen Finucane
c86b9d8cc7 tests: Add identity v2, v3 FakeClientMixin
This ensures we are speccing the identity proxy API, as we did
previously for other services.

Change-Id: I4d090bab001f9b7e1d83ca8fee9e7e1117844cd8
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-04-04 16:22:56 -07:00
Zuul
948034e6c1 Merge "router: Use plural form for storage of `--fixed_ip` argument" 2024-03-26 17:34:43 +00:00
Zuul
5f4236d7db Merge "Parse external-gateway argument in separate helper" 2024-03-26 17:34:41 +00:00
Zuul
6373c91a77 Merge " Bug Fix, Default SG Rule Custom SG" 2024-03-19 14:44:00 +00:00
OpenStack Release Bot
cb539bab24 Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.

Sem-Ver: feature
Change-Id: I13bb45d30d3dff73ca48ad8a2ed8bdc982b62d86
2024-03-18 14:04:27 +00:00
Cyril Roelandt
0970dd4096 image cache clear: fix value of default target
When using the "openstack image cache clear" command, the "clear_cache"
method from the OpenStack SDK is used. It expects its only argument to
be one of "both", "cache" or "queue". However, when passing neither
"--cache" nor "--queue", it is currently passed None as a value. Fix
this by specifying "both" as the default value to be passed.

Change-Id: I17c6e3d435a84b4ba453845086ff3fe272b54f58
2024-03-14 04:03:08 +01:00
Youngjun
a4db11c62e refectoring: remove duplicate declaration
Change-Id: I0d9e3d25bc42df56be31defaea13bbe7aaa21caa
Signed-off-by: Youngjun <yj.yoo@okestro.com>
2024-03-13 10:04:04 +09:00
Cyril Roelandt
76f234eba9 Fix typo in the list of Glanceclient/OSC commands
Change-Id: I9c5cf24e51fa8d4ab1428280f25408391c8556c8
2024-03-12 19:58:33 +01:00
Youngjun
9e4dbd1d82 refectory: remove unreachable code
Change-Id: If12a550451f5aafe3e2fb5aaa0257319ea908fe3
Signed-off-by: Youngjun <yj.yoo@okestro.com>
2024-03-12 16:41:17 +09:00
Zuul
2f9a523765 Merge "reno: Update master for unmaintained/victoria" 2024-03-07 10:13:15 +00:00
Zuul
7e7fb3923d Merge "reno: Update master for unmaintained/wallaby" 2024-03-07 10:13:13 +00:00
OpenStack Release Bot
772c27658c reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.

Change-Id: I5ffcd8daa4822fddaf48877fc1201847ec5e9340
2024-03-07 08:46:19 +00:00
OpenStack Release Bot
ff4737c1e5 reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.

Change-Id: I925f6c38bcfe315edfed129dea76d092ec9110b9
2024-03-07 08:45:23 +00:00
OpenStack Release Bot
da09a7c519 reno: Update master for unmaintained/victoria
Update the victoria release notes configuration to build from
unmaintained/victoria.

Change-Id: Ic41670b3f6c9a1b78074319f445e468827590b68
2024-03-07 08:44:17 +00:00
Frode Nordahl
7184e876a5
Add router default route BFD/ECMP options
Add the `--enable-default-route-bfd`, `--disable-default-route-bfd`
`--enable-default-route-ecmp` and `--disable-default-route-ecmp`
options for `router create` and `router set` commands.

Related-Bug: #2002687
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Change-Id: Ia5a196daa87d29445dc5514dcb91544f9d470795
2024-03-05 16:14:56 +01:00
Dmitrii Shcherbakov
16c695045c
Add support for managing external gateways
This change implements the logic to call the new API for managing
external gateways.

Relevant Neutron core change:
https://review.opendev.org/c/openstack/neutron/+/873593

Co-Authored-by: Frode Nordahl <frode.nordahl@canonical.com>
Related-Bug: #2002687
Change-Id: Ib45f30f552934a0a5c035c3b7fadfc0d522219ba
2024-03-05 16:14:56 +01:00
Frode Nordahl
58ad3cefa7
router: Use plural form for storage of `--fixed_ip` argument
The variable already takes multiple values, let's make it obvious
just by reading the code.

Related-Bug: #2002687
Change-Id: I294ee710d989d7a3a54331fca424e84708a2faab
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
2024-03-05 16:14:19 +01:00
Frode Nordahl
f696aee81d
Parse external-gateway argument in separate helper
This is to prepare for subsequent patches that will add support
for managing multiple gateways.

Related-Bug: #2002687
Change-Id: Ic088dca0b7cd83bd7568d775b4e70285ce72411d
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
2024-03-05 11:26:15 +01:00
Rodolfo Alonso Hernandez
966051cfe2 Add NUMA affinity policy options "socket"
Added a new port NUMA affinity policy option called "socket".

Depends-On: https://review.opendev.org/c/openstack/neutron/+/910594

Related-Bug: #2052786
Change-Id: Icff9070db68ba83b47b344d56ee93b235383b2f2
2024-02-24 11:15:45 +00:00
James Black
93b73e9b29 Bug Fix, Default SG Rule Custom SG
Currently the Default setting for CustomSG Rule
is set to True, this means all new SGs inherit
these rules, with no way for user to override
this behavior.

Closes Bug: #2054629

Change-Id: Icef7c91654dbced76a5492437e723c4e2a0f3102
2024-02-23 08:31:25 -08:00
Mridula Joshi
2a90a6f07b Adds CLI support for `glance md-object-property-show`
This patch adds a command "image metadef object property show" which
describe a specific metadata definitions property inside an object.

Change-Id: I738e2e3c27c9819290d5a2a8781878b81f03b5f9
2024-02-15 14:16:34 +00:00
Brian Haley
75ed315885 Do not sort subnet dns_nameservers field
When using table output format, the dns_nameservers field
of a subnet is sorted, but it should not be as the order
is important.

Created an UnsortedListColumn() class in subnet.py so the
output is correct.

Updated the unit test accordingly to verify the order is
correct when an entry is removed.

Change-Id: I60a15a944f83549738305dd025db38ff8e165be7
Closes-bug: #2053201
2024-02-14 17:28:04 -05:00
Zuul
2eea916b35 Merge "Adds CLI support for `glance md-object-update`" 2024-02-14 12:01:10 +00:00
Mridula Joshi
3cd5ad2c1b Adds CLI support for `glance md-object-update`
This patch adds a command "image metadef object update" which
update metadata definitions object inside a namespace.

Change-Id: I2dd8f54f9224abda5adc7a1b6a1c270c49d473a7
2024-02-13 18:28:00 +00:00
Stephen Finucane
c128ae1969 trivial: Don't ignore missing resources
An openstacksdk 'find_foo' proxy method will return None by default if a
resource is not found. You can change this behavior by setting
'ignore_missing=False'. We were doing this in most, but not all cases:
correct the issue.

In the event of calling 'image delete' with multiple images, it will no
longer fail on the first missing image and will instead attempt to
delete remaining images before failing.

Change-Id: I1e01d3c096dcaab731c28e496a182dd911229227
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-02-13 16:33:56 +00:00
Zuul
99c7f583df Merge "pre-commit: Bump linter versions" 2024-02-07 19:51:19 +00:00
OpenStack Release Bot
07c05d8ae5 reno: Update master for unmaintained/yoga
Update the yoga release notes configuration to build from
unmaintained/yoga.

Change-Id: Id5ecff72f0a7ebdcab32964480dc351b96beb8b0
2024-02-05 16:14:41 +00:00
Zuul
0e5802c945 Merge "trivial: Fix typo" 2024-02-02 12:38:41 +00:00
Zuul
c8ecba2a9e Merge "image: Fix the default description of image visibility" 2024-02-02 11:23:51 +00:00
Stephen Finucane
d0f81f5717 trivial: Fix typo
Change-Id: I936cc07af38bdd5d389cc5edafa93861f8fac3a6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-02-02 10:14:29 +00:00
Zuul
c29e05764b Merge "Add "hardware_offload_type" attribute to "port"" 2024-01-30 12:16:43 +00:00
Zuul
f0f811ce4b Merge "[codespell] fix typos in doc,tests and help messages" 2024-01-30 09:34:00 +00:00
Zuul
a00cc44acc Merge "doc: Drop tripleoclient" 2024-01-30 09:31:45 +00:00
Zuul
6e246f1566 Merge "doc: Remove RSD subcommand" 2024-01-30 09:31:43 +00:00
Zuul
b30135457a Merge "doc: Remove Searchlight subcommands" 2024-01-30 09:31:42 +00:00
Zuul
432f1dee73 Merge "doc: magnumclient provides a OSC plugin" 2024-01-30 08:11:49 +00:00
Takashi Kajinami
49ad528266 doc: magnumclient provides a OSC plugin
The magnumclient library now provides an OSC plugin. So update
the document accordingly.

Change-Id: Ie828f005a38a511bb0f34ab86cbf97e4a3aae2fe
2024-01-29 23:20:07 +00:00
Zuul
5435f11dd0 Merge "image: Trivial fixes" 2024-01-29 19:41:46 +00:00
Stephen Finucane
8a63b51039 image: Trivial fixes
Mostly stylistic, with the exception that we now allow deleting multiple
metadef properties in a given namespace.

Change-Id: Ib0c243f0d647ce74c0165ee666beed6eb5d5c5a7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-01-29 13:53:34 +00:00
Rafael Weingärtner
2ed10e9a72 Introduce schema_version in the federated attribute mapping API
Depends-On: https://review.opendev.org/c/openstack/keystone/+/739966
Change-Id: I276ebd49094368dd823e50ff11a6e65fa2a6dcfb
2024-01-29 08:50:48 -03:00
Zuul
dc8d9d3541 Merge "Adding CLI command for `glance member-get`" 2024-01-26 17:37:15 +00:00
Zuul
9cb8e4c3b5 Merge "Explicitly specify namespace fields for output" 2024-01-26 17:37:11 +00:00
Rodolfo Alonso Hernandez
0725bb474c Add "hardware_offload_type" attribute to "port"
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/892771
Related-Bug: #2013228

Change-Id: I2c6fd434be4ae8cc41edf45fefe150a41cbfe0bd
2024-01-24 14:33:23 +00:00
Rajesh Tailor
a1f7bd28e6 Add support for showing requested az in output
This change adds support for showing the availability zone
requested during instance create in server show and server
list --long output.

Depends-On: https://review.opendev.org/c/openstack/nova/+/904568
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/904490
Change-Id: I1772e06b4f043ef3118f036f3908ec70515144bd
2024-01-24 19:08:29 +05:30
Zuul
03da934605 Merge "Revert "Temporarily drop aodhclient from doc build"" 2024-01-23 17:47:41 +00:00
Stephen Finucane
9c2e5d5648 pre-commit: Bump linter versions
We also migrate to the native hacking pre-commit hook.

Change-Id: Idb5a825c20cb7f189997a4d6c3a9a88218fdb335
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-01-23 11:47:52 +00:00
Takashi Kajinami
03044eaf11 doc: Add manilaclient as a OSC plugin
The manilaclient library now provides OSC plugin for share API access.

Change-Id: I0afdf4d48e16191283916065719ba7cf623e7377
2024-01-22 10:01:13 +09:00
Takashi Kajinami
f2387601ee Revert "Temporarily drop aodhclient from doc build"
This reverts commit 860d636047.

Reason for revert:
The issue with aodhclient and latest pyparsing was fixed by [1].

[1] 3a36ed1774ba0bbb3ad6a3716c6c014246bc9613

Change-Id: I461edafc5be7b3afbde485f1620bff71e178b078
2024-01-21 14:20:52 +00:00
Takashi Kajinami
d4acd4b6d3 doc: Drop tripleoclient
The TripleO project has been deprecated and its master is no longer
maintained. The complete project retirement is now on-going.

Change-Id: If7b390fc2230c16ef138ceb4a7bc5d97dcf790e6
2024-01-21 13:16:24 +00:00
Takashi Kajinami
82c3474323 doc: Remove RSD subcommand
The python-rsdclient library hasn't been updated for 5 years and is no
longer maintained.

Change-Id: Ia378a9001836bbaa4f679dddf1ed743e4332a72e
2024-01-21 22:12:08 +09:00
Takashi Kajinami
810f691904 doc: Remove Searchlight subcommands
... because the project was retired. These were overlooked during
cleanup[1].

[1] a79e7db4ae

Change-Id: I8eeeb3ea8c49ed3c9405f54f0dd3be0402cd2a8a
2024-01-21 13:02:56 +00:00
Zuul
50544ae78b Merge "compute: Fix formatting of 'server show'" 2024-01-18 14:12:32 +00:00
Mridula Joshi
1517f4af21 Explicitly specify namespace fields for output
Rather than excluding the few fields we don't want, explicitly indicate
the ones we do want.

Note that this is a problem in the tests for virtually all commands
that will be seen as the SDK continues to evolve and new fields are
added to existing resources.

Change-Id: Ia8d487e1e7804fa177fce46497c0202aed8acb08
2024-01-16 15:14:55 +00:00
Ghanshyam Mann
37b4201428 Update python classifier in setup.cfg
As per the current release tested runtime, we test
python version from 3.8 to 3.11 so updating the
same in python classifier in setup.cfg

Change-Id: Ic137b2eecee65d43afeca2c936e195a8652237af
2024-01-11 15:37:00 -08:00
Zuul
4bafc32616 Merge "Fix clearing of dns_domain and description on a network by setting to empty strings" 2024-01-10 18:31:42 +00:00
Zuul
b740f2f6bd Merge "Correct error message for "create server --wait"" 2024-01-10 16:09:48 +00:00
Bence Romsics
cc2a0bab24 Correct error message for "create server --wait"
Error message should say "Error creating server" and not "unshelving".

Change-Id: I49dc6160f47a13d38128b3da1ba16437bd089c86
Closes-Bug: #2048896
2024-01-10 14:19:35 +01:00
Brian Haley
e7bc3d9b82 Fix --use-prefix-delegation subnet create argument
The --use-prefix-delegation argument when creating a
subnet should not take an argument of True/False, it
should simply trigger the code to set subnetpool_id
value to 'prefix_delegation'. Change action to correct
this.

Added unit test to cover missing checks.

Related-bug: #2028159
Change-Id: Ib7ee80100327b8611d4a354c7f4eb0e696c953da
2024-01-09 17:23:03 -05:00
Mridula Joshi
93b2e66d2d Adding CLI command for `glance member-get`
This patch adds a command ``image member get`` which displays
a particular member associated to the image.

Change-Id: I48d3151f8e204e1eb5cfff67ce1e333d1cfb9322
2023-12-20 05:03:40 +00:00
Zuul
d09aec3459 Merge "trivial: Place positional opts last" 2023-12-14 16:17:03 +00:00
Zuul
c75a5a8373 Merge "network: Clarify purpose of default sg rules" 2023-12-14 16:17:01 +00:00
Stephen Finucane
be3d438ed2 trivial: Place positional opts last
Change-Id: I5479e71223c8c224e0bba387348e740c997cc7bf
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-12-14 12:31:26 +00:00
Stephen Finucane
1b6b639c9f network: Clarify purpose of default sg rules
These only apply to newly created default security groups i.e. when you
create a new project. They do not apply to existing default security
groups.

Change-Id: Ie01bf47dd8a0392354d17d984b41c1fad504e659
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-12-14 12:30:03 +00:00
Rajat Dhasmana
ea254061c8 Doc: Fix volume snapshot commands
The snapshot commands use the "volume " prefix which was missing
from the doc. This patch adds it.

Change-Id: I2acf28eff78fb8419a4c4f00395355a6ca44a576
2023-12-13 15:10:25 +00:00
Pavlo Shchelokovskyy
f3207bdf3f Fix availability zone list command
there are two problems currently:
- SDK's `availability_zones()` returns a generator that raises errors
  only when actually accessing its items
- the error raised is the sdk exception, not nova one, and thus is not
  being handled correctly

As a result, currently nova AZs can not be listed by non-admins.

Story: 2010989
Task: 49220
Change-Id: Ia299faea85857d3fc3a9b539800f3483f84ccbc0
2023-12-07 16:24:34 +00:00
Rajat Dhasmana
c657047d7e volume list: Don't call nova if no volume is attached
Currently 'openstack volume list' calls nova to resolve server UUIDs
to server names. This is not required if:
1. no volume is attached to an instance
2. no volume exists in deployment

This patch fixes this by checking volume statuses and, if any volume has
status 'in-use', we will call nova to resolve server names.
Note that we don't check for 'reserved', 'attaching', 'detaching'
states since those are transition states and doesn't guarantee that
the volume is actually attached to the instance.

Change-Id: Ic4d89db69244d3fba44d4b69c79b3e7632ee3d53
2023-12-06 17:39:03 +05:30
Zuul
2642b070db Merge "compute: Add 'server create --server-group' option" 2023-12-05 18:43:15 +00:00
Zuul
2957f28ff1 Merge "tests: Enable logging fixture" 2023-12-05 18:43:13 +00:00
Zuul
ca0473815f Merge "tests: Remove prints" 2023-12-05 18:43:11 +00:00
Zuul
ac2bd42372 Merge "test: Ignore 'OS_' environment variables" 2023-12-05 18:43:02 +00:00
Zuul
b458e78694 Merge "tests: Remove unused flag" 2023-12-05 18:43:01 +00:00
Zuul
519596dcb7 Merge "parseactions: Use ArgumentError, not ArgumentTypeError" 2023-12-05 18:42:59 +00:00
Zuul
b1548d9f3c Merge "Remove unnecessary file" 2023-12-05 18:35:48 +00:00
Zuul
2d32d87c16 Merge "Use CommandError, not SystemExit, to exit" 2023-12-05 18:35:47 +00:00
Zuul
0ac2e2f630 Merge "compute: Address bug in shelve offload logic" 2023-12-05 18:15:08 +00:00
Zuul
1da22d0de4 Merge "tests: Handle missing extensions in network tests" 2023-11-29 18:19:43 +00:00
Florian Streibelt
ce0765facb
Fix clearing of dns_domain and description on a network by setting to empty strings
After setting a default dns_domain on a network

 openstack net set --dns-domain 'example.com.' <NETWORKID>

the setting could not be reverted back to an empty string using

 openstack net set --dns-domain '' <NETWORKID>

and the call also does not emit any error.

The same is true for the description of a network.

Reason was using the parsed argument directly as a condition instead of
comparing against None -- dropping the empty string as valid value.

The name parameter already accepted an empty string.

This change also adds a testcase for dns_domain, description and the
network name parameter, checking if the empty string is forwarded.

Change-Id: Ia7b9738205002b028c19e4f397411c86469cba1a
2023-11-24 12:36:07 +01:00
Zuul
127b49d45e Merge "tests: Check for DHCP agents first in DHCP test" 2023-11-22 13:46:42 +00:00
Zuul
19896ec720 Merge "Adds command `image metadef object delete`" 2023-11-22 11:05:26 +00:00
ArtofBugs
6d3490ed7c tests: Handle missing extensions in network tests
Some tests still assume extensions are enabled; those tests are now skipped if the extension is not enabled. Change I25b8811fe09f2a4a9fc20ca5459f5a404b88a337 addressed some but not all of these.

Change-Id: If36550650f143a7efe4190e60961c51a8cd20fb3
2023-11-21 09:50:51 -08:00
Stephen Finucane
e44d8017ec tests: Check for DHCP agents first in DHCP test
If there are no agents with type=dhcp, the neutron-dhcp-agent service is
likely not enabled on the deployment.

Change-Id: I1253f35e71cf996c559f2a2d8d1d8cde6b41a519
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-21 10:31:01 +00:00
Rajesh Tailor
71839eb5fa [codespell] fix typos in doc,tests and help messages
Change-Id: I4823782daa1af3872bc22603147e3073152cc777
2023-11-21 11:31:07 +05:30
Mridula Joshi
5d1afcee68 Adds command `image metadef object delete`
Change-Id: Ib94b7ba625ca0679ae4ae841e217ea251baff371
2023-11-17 10:46:35 +00:00
Stephen Finucane
e9d3a7bb13 test: Ignore 'OS_' environment variables
Our functional tests are inherently dependent on 'clouds.yaml' files.
The presence of 'OS_*' environment variables can cause weird test
failures. Simply don't pass them through to our test environment.

Change-Id: I7d24cdff5f1f5798118816b12d7398b87a5f5ed4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-15 11:41:13 +00:00
Stephen Finucane
c08d6e0391 parseactions: Use ArgumentError, not ArgumentTypeError
If you use the former, you get a pretty error message when there's a
failure. If you use the latter, you get an ugly traceback when used with
the '--debug' flag.

Without this change:

  $ openstack flavor create ... --property '' foo
  ...
  Traceback (most recent call last):
    File "/tmp/venv/lib/python3.11/site-packages/cliff/app.py", line 402, in run_subcommand
      parsed_args = cmd_parser.parse_args(sub_argv)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib64/python3.11/argparse.py", line 1862, in parse_args
      args, argv = self.parse_known_args(args, namespace)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib64/python3.11/argparse.py", line 1895, in parse_known_args
      namespace, args = self._parse_known_args(args, namespace)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib64/python3.11/argparse.py", line 2107, in _parse_known_args
      start_index = consume_optional(start_index)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib64/python3.11/argparse.py", line 2047, in consume_optional
      take_action(action, args, option_string)
    File "/usr/lib64/python3.11/argparse.py", line 1971, in take_action
      action(self, namespace, argument_values, option_string)
    File "/tmp/venv/lib/python3.11/site-packages/osc_lib/cli/parseractions.py", line 45, in __call__
      raise argparse.ArgumentTypeError(msg % str(values))
  argparse.ArgumentTypeError: Expected 'key=value' type, but got:
  clean_up CreateFlavor: Expected 'key=value' type, but got:

With this change:

  $ openstack flavor create ... --property '' foo
  ...
  usage: openstack flavor create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN]
                                 [--noindent] [--prefix PREFIX] [--max-width <integer>]
                                 [--fit-width] [--print-empty] [--id <id>]
                                 [--ram <size-mb>] [--disk <size-gb>]
                                 [--ephemeral <size-gb>] [--swap <size-mb>]
                                 [--vcpus <vcpus>] [--rxtx-factor <factor>]
                                 [--public | --private] [--property <key=value>]
                                 [--project <project>] [--description <description>]
                                 [--project-domain <project-domain>]
                                 <flavor-name>
  openstack flavor create: error: argument --property: Expected 'key=value' type, but got:
  clean_up CreateFlavor:

Change-Id: I9e78b35ad9d016d7a33655141ec579397c5344c0
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-15 11:33:19 +00:00
Stephen Finucane
3057997cae Remove unnecessary file
This is testing things now found in osc-lib. Remove it.

Change-Id: Iccbd540fa340c77a957486d16d352d3fe4c3ddb2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-15 11:29:06 +00:00
Stephen Finucane
432698fea2 Use CommandError, not SystemExit, to exit
Change-Id: Id2bcc18420b17cf3afed5584ef5104c3ef413830
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-15 11:28:49 +00:00
Stephen Finucane
885f5912eb compute: Address bug in shelve offload logic
We were reusing a variable from a previous loop, which meant this would
never work with multiple servers. Correct the mistake.

Change-Id: I52246e183fb2cf0d855d92058dd305b48783589d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-15 11:26:02 +00:00
Stephen Finucane
900fad5360 tests: Remove unused flag
Nothing is setting 'merge_stderr'. It looks like a carry-over from the
legacy clients.

Change-Id: I32b65830e11b27ba83dfba002bf996af561b0768
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-14 12:19:06 +00:00
Stephen Finucane
89a8f72960 tests: Enable logging fixture
Quieten the output of our test runs significantly.

Change-Id: Ie32c919bb987eb0b9bc4c5b2ec54ee20a6841c03
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-11-13 17:31:07 +00:00
Stephen Finucane
d0d4077e1d tests: Remove prints
Change-Id: I35adac1199769fd73978b6457044191d02bb5bd4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-13 17:31:07 +00:00
Stephen Finucane
1678f87d7a tests: Handle missing extensions in network tests
This is mostly a case of skipping tests where the extension is missing,
but some tests are updated to remove a reliance on optional tests.

Change-Id: I25b8811fe09f2a4a9fc20ca5459f5a404b88a337
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-12 10:35:38 +00:00
Stephen Finucane
c251cb89a5 tests: Fix API extension check
The check for extensions was not using a machine readable format for
output. This meant an API check could match on a substring, e.g. a check
for 'qos' would match on 'qos-specs'. Address this issue by switching
our command invocation to use JSON output and migrating the check
function from the general base class to the networking base class.

Change-Id: Idc6dc54503031ddf3e148f50ed53ad8898f7a7e3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-12 10:34:41 +00:00
Zuul
7dbe6e6d3d Merge "tests: Centralise check for networking service" 2023-11-10 13:55:41 +00:00
Stephen Finucane
20490dcd10 tests: Centralise check for networking service
No point duplicating this across functional tests.

Change-Id: I9502be8b4e718885c6f854c7f5b19f6cacf51055
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-10 10:06:58 +00:00
Zuul
1ac5d63c53 Merge "Adds command `image metadef object list`" 2023-11-08 18:01:44 +00:00
Zuul
8aee1a2889 Merge "Adds command `image metadef object show`" 2023-11-08 18:01:42 +00:00
Zuul
71f232aafa Merge "Add "image metadef property set" command" 2023-11-08 10:46:35 +00:00
Mridula Joshi
4bb6efa8f8 Adds command `image metadef object list`
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/858350
Change-Id: I0691f7519e8fb9f01836e6232e0bcebd2c428ac3
2023-11-08 10:44:31 +00:00
Masayoshi Mizuma
a3730afe2e image: Fix the default description of image visibility
The default image visibility was changed to 'shared' in API v2.5. Fix
the help information of image visibility, centralizing options in the
process.

Change-Id: Ib3017fc4f618c1e14e3b26b616ff9374d0e24eaa
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-08 10:41:07 +00:00
Zuul
c09c1fbf51 Merge "Add "image metadef property delete" command" 2023-11-08 10:35:38 +00:00
Mridula Joshi
78ef009a3a Adds command `image metadef object show`
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/858350
Change-Id: I97bcb0ccee9d25fb26475ec9e10660556e6072a6
2023-11-08 09:57:02 +00:00
Zuul
0439f17ed3 Merge "image: Add support for cache commands" 2023-11-07 09:31:24 +00:00
Zuul
e54bdfbba3 Merge "Adds command `image metadef object create`" 2023-11-07 09:31:21 +00:00
Zuul
0b78dfe30b Merge "Add pagination helpers" 2023-11-07 08:47:24 +00:00
Zuul
30462f57d4 Merge "Removed start, end time format. Before fix, openstack usage list command resulted 'str' object has no attribute 'isoformat' error." 2023-11-07 08:38:13 +00:00
Zuul
ce63fd88da Merge "volume: Migrate 'volume group snapshot' commands to SDK" 2023-11-04 00:10:08 +00:00
Stephen Finucane
c7e3529dea Add pagination helpers
Add some pagination helpers to configure pagination parameters for
various commands. Two pagination schemes are supported, based on what we
currently support across OSC commands: marker-based pagination and
offset-based pagination.

Change-Id: I551bb4c3ff0568c6df5244a1d0f0669497bee58f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-11-03 23:16:18 +00:00
Stephen Finucane
7708106cf0 compute: Add 'server create --server-group' option
Add an alias for requesting a server group. This is more syntactic
sugar, though it comes with the added bonus of letting users request a
server group by name instead of just ID.

Change-Id: I3d9a7ce04a02fdf374b7a8082618eccdea8c3217
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-11-02 17:48:03 +00:00
Zuul
8b253cbda8 Merge "Update the docker image to python3.11" 2023-11-01 10:49:31 +00:00
Mridula Joshi
f8c708900c Adds command `image metadef object create`
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/858350
Change-Id: Ie74231c823d6128d149d5f01c90a66ed3afa3d1a
2023-11-01 07:15:59 +00:00
Clark Boylan
4673c89154 Update the docker image to python3.11
OpenDev is trying to get consumers of these images to update to newer
iterations so that old images can be dropped from the build list. OSC
is successfully running voting python3.11 unittest jobs at this point.
This should make it safe to update the Docker container image for OSC
to python3.11 without risk of regressions.

Making this update should bring some (small) performance updates as
py311 is generally quicker than py310. As mentioned before it will also
allow OpenDev to reduce the set of images that are being built.

Change-Id: I01e3c9e27f92205979ea6562b23f0f7f3b431728
2023-10-31 18:44:00 +00:00
Zuul
dfcb8b0ee7 Merge "trivial: Make better use of argparse" 2023-10-31 15:00:24 +00:00
Zuul
5883bcecd4 Merge "volume: Add alias for volume type AZs" 2023-10-31 15:00:20 +00:00
Zuul
e13f948ae5 Merge "volume: Add aliases for common volume type props" 2023-10-31 15:00:18 +00:00
Zuul
456c66ff63 Merge "volume: Allow filtering volume types by properties" 2023-10-31 14:53:36 +00:00
Zuul
d735b6cc07 Merge "volume: Support same_host, different_host hint as list" 2023-10-31 14:53:35 +00:00
Zuul
8b019fa7ea Merge "Update from storyboard to launchpad pt. 2" 2023-10-31 12:57:08 +00:00
Zuul
c258d196a4 Merge "Migrate resource filter commands to SDK" 2023-10-31 10:25:55 +00:00
Zuul
43cec266d9 Merge "Add "image metadef property create" command" 2023-10-31 09:28:54 +00:00
Zuul
b6baa2e398 Merge "Add "image metadef property show" command" 2023-10-31 09:28:52 +00:00
Zuul
e76a66657f Merge "Add "image metadef property list" command." 2023-10-31 09:28:47 +00:00
Dr. Jens Harbott
692ee752b6 Update from storyboard to launchpad pt. 2
This was missed in [0]. Also update the mailing list link after it moved
to mailman3.

[0] Iaf93c892d211fd7465395d8830f56c2977a88f8b

Change-Id: I91168713a854be0c4348bab3fa34f4b1a924f451
2023-10-31 10:19:43 +01:00
Zuul
5711998603 Merge "Switch back to Launchpad" 2023-10-31 08:58:30 +00:00
Johannes Kulik
60a0e379a4 volume: Support same_host, different_host hint as list
When creating a volume, the scheduler hints can be supplied as strings.
The "same_host" and "different_host" hints can also be supplied as a
list if affinity/anti-affinity to multiple volumes is requested [0]

The previously-used `KeyValueAction` only supplies strings as values - the
last one if multiple --hint contain the same key. An alternative already
used in `CreateServer` would be `KeyValueAppendAction`, but only a subset of
the scheduler hints accept lists, so we cannot use that in general.

Therefore, we create `KeyValueHintAction`. It contains both a
`KeyValueAction` and a `KeyValueAppendAction` object and calls the
appropriate action based on the beginning of the given values as defined
in `APPEND_KEYS`.

[0] d96b705774/cinder/api/schemas/scheduler_hints.py (L31-L65)

Change-Id: Ida7f4662dc9fea24510758541fd4f2622b73bf31
2023-10-31 09:22:25 +01:00
Rajat Dhasmana
ae10851a68 Migrate resource filter commands to SDK
This patch migrates ``block storage resource filter list`` and
``block storage resource filter show`` commands to SDK.

Change-Id: Ibc50963954418aab0be35e120f8dcfadbe4020b8
2023-10-30 12:06:14 +05:30
cw0306-lee
6b9f40576d Removed start, end time format. Before fix, openstack usage list command resulted 'str' object has no attribute 'isoformat' error.
story: 2010943
task: 48951
Change-Id: I9ee3384cc6df9ca768ac664f01472244dd8e3267
2023-10-30 14:17:39 +09:00
Zuul
53e7d713f0 Merge "Migrate volume backend commands to SDK" 2023-10-27 17:35:06 +00:00
Stephen Finucane
2a2a6e1781 trivial: Make better use of argparse
Change-Id: Ib76c0d18bf5e44bfb4dcd9d729d9a1c5635cdba7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-10-27 17:58:36 +01:00
Stephen Finucane
a3410cd4f7 volume: Add alias for volume type AZs
Another quality of life improvements. The key for this one is weird and
the whole thing is a little more involved, hence why it's kept separate.

Change-Id: I75aa85f27905104dc84fffe823c01b4c90a6a822
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-10-27 17:58:13 +01:00
Stephen Finucane
e0c7cef434 volume: Add aliases for common volume type props
Add aliases for the enabling multiattach, caching and replication via
extra spec properties. These are useful since the syntax for setting
each of them is a bit weird and frankly not very discoverable.

Change-Id: I08b51224c66a34a9dcfcffc95847e61d9aac0e7e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-10-27 17:57:39 +01:00
Zuul
491e5b9e9a Merge "tests: Add compute v2 FakeClientMixin" 2023-10-27 16:38:55 +00:00
Zuul
f576cb62b6 Merge "tests: Use consistent shortcut to fake compute client" 2023-10-27 16:38:53 +00:00
Zuul
14a4f89030 Merge "tests: Add volume v1, v2, v3 FakeClientMixin" 2023-10-27 16:23:55 +00:00
Zuul
dd5a21ff02 Merge "tests: Use consistent shortcut to fake volume client" 2023-10-27 16:23:53 +00:00
Zuul
b884e83e37 Merge "tests: Use central SDK client fake" 2023-10-27 16:20:27 +00:00
Stephen Finucane
67bec7785c volume: Allow filtering volume types by properties
Starting in volume API microversion 3.52, it is possible to filter
volume types by extra specs (a.k.a. properties). Even non-admins can do
this for so-called "user visible" extra specs. Make it possible to do
this.

While we're here, the test file is renamed to match the name of the
module under test.

Change-Id: Ia9acc06c0c615bf24e12b63146ea97ac2505f596
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-10-27 16:37:15 +01:00
gtema
5d1d6b5a06 Switch back to Launchpad
Change the links to issue tracker.

Change-Id: Iaf93c892d211fd7465395d8830f56c2977a88f8b
2023-10-25 18:56:25 +02:00
Slawek Kaplonski
7b99b57165 Add support for default security group rule CRUDs
Change-Id: I1c18c2ec5eb4923e1ab8b3fc6199ef6f329b4a4d
2023-10-19 16:04:22 +02:00
Cyril Roelandt
705ecef7a9 Add "image metadef property set" command
Change-Id: I8fbe8ef5b5119fb500df0ed1b6e645ea00eadf01
2023-10-18 14:02:34 +00:00
Cyril Roelandt
9094e540b5 Add "image metadef property delete" command
Change-Id: I2e13b26139424c421ae609804c546a6b42add5a4
2023-10-18 13:27:02 +00:00
Cyril Roelandt
d9c4c43a40 Add "image metadef property create" command
Change-Id: Icb4fab0aef13b28212771da3a3b7c4a0775bb38e
2023-10-18 13:26:15 +00:00
Cyril Roelandt
190f06a963 Add "image metadef property show" command
Change-Id: I326735014dfcb4477b109a99aa31f71b07b91c7b
2023-10-18 12:39:39 +00:00
Cyril Roelandt
5fb922e469 Add "image metadef property list" command.
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/857727
Change-Id: I8f6692e779c4721225052d348b4b947a545bd6c0
2023-10-18 12:39:35 +00:00
Rajat Dhasmana
39a084f91c Migrate volume backend commands to SDK
This patch migrates following volume backend commands to SDK:

volume backend capability show
volume backend pool list

Change-Id: Idded38a5f87d51574426c4ac10c806af52984b7c
2023-10-12 01:14:35 +05:30
Zuul
0fb1cae1a8 Merge "Fix "server create"command with --boot-from-volume" 2023-10-11 15:59:24 +00:00
Zuul
98fbc56603 Merge "Fix --security-group for port list" 2023-10-11 15:59:22 +00:00
Mridula Joshi
c628c2dcd3 image: Add support for cache commands
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/874372
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/874940
Change-Id: I96b95cb93d298602b6d4b0cd35a213478babff5f
2023-10-10 09:28:12 +00:00
Stephen Finucane
912a21a8fd tests: Add compute v2 FakeClientMixin
This ensures we are speccing the compute proxy API.

Change-Id: I7adbf2666d71f222fbd9c1479216f72cb9893348
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-29 10:14:32 +01:00
Stephen Finucane
187a454ec0 tests: Use consistent shortcut to fake compute client
This removes the need for a number of base test case subclasses. We use
'compute_client' rather than 'client' to avoid conflicts with clients
for other services.

Change-Id: I430214cd79eca481bd8d8c53bf97eaede6766eb4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-29 10:14:32 +01:00
Stephen Finucane
98fb1678bc tests: Add volume v1, v2, v3 FakeClientMixin
This ensures we are speccing the image proxy API, as we did previously
for the network tests in Ic203964c7dede7dd80ae2d93b8fa1b7e6634a758.

Change-Id: I132ccd1170cc903f6edc505926b071170aeaa08c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-29 10:14:32 +01:00
Stephen Finucane
4cabf6f7a2 tests: Use consistent shortcut to fake volume client
This removes the need for a number of base test case subclasses. We use
'volume_client' rather than 'client' to avoid conflicts with clients for
other services.

Change-Id: I28d78f32142bb3a3fde0ba1780c504adc31cc77c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-29 10:14:30 +01:00
Stephen Finucane
02cc064258 tests: Use central SDK client fake
Avoid double mocking.

Change-Id: Ic8fadd41f3687eabd3a149681effae6883edb12e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-29 10:12:19 +01:00
Zuul
3c10b01480 Merge "Update branch regexes for tips jobs" 2023-09-28 09:48:22 +00:00
Dr. Jens Harbott
2e09b2bf3e Update branch regexes for tips jobs
Using negative lookahead is deprecated, let the jobs be run simply only
on the master branch for now.

Change-Id: Ia53fffb0a3f61cbf85edd96fbeeb5138a88d4d0a
2023-09-20 07:08:09 +02:00
Christian Rohmann
98b949646c Add is_incremental to ListVolumeBackup
It's of interest which backups are incremental or full. Returning this
information as a column to the list of backups.

Change-Id: I766330228634d5db678df11c23877077a3635372
2023-09-19 22:10:04 +02:00
Zuul
619925e45f Merge "Remove use of oslo.utils" 2023-09-19 13:14:12 +00:00
Zuul
5f4082d046 Merge "Add a warning for resizing servers booted from volumes" 2023-09-19 13:14:06 +00:00
Zuul
7c0bdd5e7e Merge "volume: Deprecate '--detailed' options" 2023-09-19 13:11:32 +00:00
Zuul
cab84d6760 Merge "tests: Explicitly specify port fields for output" 2023-09-19 13:11:31 +00:00
OpenStack Release Bot
2737e063b5 Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.

Sem-Ver: feature
Change-Id: I608edcb863038522677beb8bd2e1eb98c1eec363
2023-09-15 16:03:09 +00:00
Stephen Finucane
fb2e0ced6e tests: Explicitly specify port fields for output
Rather than excluding the few fields we don't want, explicitly indicate
the ones we do want. We were already in-effect doing this in our tests,
so this is simply moving the definition from tests to the main code.

Note that this is a problem in the tests for virtually all commands
that will be seen as the SDK continues to evolve and new fields are
added to existing resources. This is a problem that be solved over
time though, rather than in a big bang commit.

Change-Id: Iaa64e97450f5c73cab2e2c3b0c741aec1495b4f1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-12 08:33:20 +00:00
Stephen Finucane
08551106e6 Remove use of oslo.utils
While a relatively small library, this is one import that we really
don't need. Remove it.

Change-Id: I726f3c3548cbd896588ef0613222e36c529f5bcc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-11 11:02:55 +01:00
Stephen Finucane
8735b862c5 volume: Deprecate '--detailed' options
We use flags, not options with boolean-like values, for boolean
parameters. The affected commands were only introduced recently so this
should have minimal fallout.

Change-Id: I700733e750bff539806af167c9d47cec769c3343
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-09-11 11:02:55 +01:00
Zuul
08faf81d0d Merge "tests: Add image v1, v2 FakeClientMixin" 2023-09-06 12:29:14 +00:00
Zuul
6ae38b2888 Merge "tests: Use consistent shortcut to fake image client" 2023-09-06 12:26:00 +00:00
Zuul
98c62dfbe0 Merge "tests: Remove FakeImagev1Client, FakeImagev2Client" 2023-09-06 12:16:35 +00:00
Zuul
09eb21ea35 Merge "tests: Add network v2 FakeClientMixin" 2023-09-06 12:08:34 +00:00
Zuul
6423b61326 Merge "tests: Use consistent shortcut to fake network client" 2023-09-05 19:35:50 +00:00
Zuul
d69d738c74 Merge "tests: Remove FakeNetworkV2Client" 2023-09-05 19:30:07 +00:00
Zuul
9e2316fd06 Merge "Remove project purge image commands" 2023-09-05 19:30:05 +00:00
Zuul
876c120a9c Merge "Migrate 'extension list' to SDK" 2023-09-05 19:30:04 +00:00
Zuul
5ab1b13d5e Merge "Migrate 'availability zone list' to SDK" 2023-09-05 19:30:02 +00:00
Zuul
16bdb17fee Merge "tox: Bump min_version to 4.3.0" 2023-09-01 10:43:30 +00:00
Zuul
94caaa487d Merge "Migrate backup commands to SDK" 2023-09-01 02:45:27 +00:00
Artem Goncharov
c7c79c9fe4 Propocol release versions properly
On the index page we stopped updating versions table since train. Add
missing entries.

Also small rephrasement in the into on backwards compatibility not to
stick with an ancient release name.
Set oldest release on unreleased page correspondingly.

Change-Id: I4a442708a5b47f573cd2333545531499b9eae0f1
2023-08-31 09:51:41 +00:00
Artem Goncharov
010ef0fdf5 Fix ReleaseNotes build
for some reason (clearly another change somewhere in the Sphinx)
extlinks extension used in the releasenotes is failing when extlink
caption is not having substitues same as in the link itself.

>     title = caption % part
>             ~~~~~~~~^~~~~~
> TypeError: not all arguments converted during string formatting

Now the extension supports setting link capturion to None which works as
we need.

Change-Id: Ie1a61e9b3ee5d727d59525efe34aea696538e2b3
2023-08-31 10:45:01 +02:00
Stephen Finucane
e1a86368bd tests: Add image v1, v2 FakeClientMixin
This ensures we are speccing the image proxy API, as we did previously
for the network tests in Ic203964c7dede7dd80ae2d93b8fa1b7e6634a758.

Change-Id: I09539cbf35444272fb3aaabfecd5d731d1ecc4a8
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
28b1267921 tests: Use consistent shortcut to fake image client
This removes the need for a number of base test case subclasses. We use
'image_client' rather than 'client' to avoid conflicts with clients for
other services.

Note that this highlights a minor bug with the 'volume create' command
when using the v1 block storage API and creating a volume from an image.
This is corrected, though it can be assumed that no one is actually
using this code path to say it hasn't been reported in the few years
since the bug was introduced in Ussuri.

Change-Id: I571be27f68bb7669dcb883f3b4799731b4a35479
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
a823228527 tests: Remove FakeImagev1Client, FakeImagev2Client
These no longer makes any sense since all image calls use the SDK proxy
API now.

Change-Id: I48e1d90f9c0dfa904fe37caa0de60d20945f1118
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
a39bde5c3a tests: Add network v2 FakeClientMixin
This ensures we are speccing the network proxy API. Future changes will
do the same for the image proxy API and eventually the compute proxy API
(once everything has been converted).

Change-Id: Ic203964c7dede7dd80ae2d93b8fa1b7e6634a758
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
b25742499a tests: Use consistent shortcut to fake network client
This removes the need for a number of base test case subclasses. We use
'network_client' rather than 'network' for consistency with other
services.

Change-Id: I61f7c43341acf19ae16d06db34e18970297fbb93
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
84dd5b0018 tests: Remove FakeNetworkV2Client
This no longer makes any sense since all network calls uses the SDK
proxy API now.

Change-Id: I0d57d7561b697270b24acd7b8ff62db73a83f49a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
601d9717c2 Remove project purge image commands
This was still using glanceclient-style calls despite us having switched
all image command to SDK way back in 5.2.0 (Ussuri). It therefore hasn't
worked since then, so we remove without deprecation.

Change-Id: Ibea79ea10bb272cba194debfe4bcbaeebf3875b7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:52:23 +01:00
Stephen Finucane
b87b57551b Migrate 'extension list' to SDK
Migrate the block storage aspects of this command to SDK. This means the
'extension list' command, like the 'availability zone list' command
previously, is now using SDK entirely.

While we're here, we also make some fixes to the unit tests for the
network and compute aspects of the command. While we migrated the
network and compute extension commands from neutronclient and novaclient
respectively some time back, we never fully updated the tests. Do this
now.

Change-Id: I631a6a09dfd9d614b1dd7b322dcee8490a52cc43
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/885132
2023-08-28 13:51:34 +01:00
Stephen Finucane
44cf963d8e Migrate 'availability zone list' to SDK
This is a bit of an odd one. Because this is a "common" command, there
are three clients in play here: a compute client, a block storage
client, and a networking client. The networking aspects of this command
are already using SDK though the tests were mistakenly using a fake
version of the legacy neutron client (albeit one with the correct SDK
properties). We were still using legacy clients for the other two.
Correct the networking tests and migrate the compute and block storage
aspects of the command.

Change-Id: I292e1a712bca97e1270e8a97606e02a8a44c2954
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-08-28 13:51:33 +01:00
Zuul
78988d1786 Merge "Add --skip-resource option to project cleanup" 2023-08-26 12:44:20 +00:00
rladntjr4
89e5d67a16 Fix "server create"command with --boot-from-volume
This patch modifes the "server create --boot-from-volume" command
without image option print "'NoneType' object has no attribute 'id'"

story: 2010892
task: 48669
Change-Id: I566f81c285d4ebc1e23ea0762d67492fb6b3bcbe
2023-08-25 23:09:28 +09:00
Stephen Finucane
564e4f76fb volume: Migrate 'volume group snapshot' commands to SDK
Change-Id: Ie49e1f4b63de8b3bc699f7a9ef6eaa72801b9d05
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/892974
2023-08-25 15:09:00 +01:00
Zuul
fd4ed3be8e Merge "doc: Split image command documentation" 2023-08-25 12:08:21 +00:00
Zuul
8a070b852d Merge "docs: Add examples of common auth methods" 2023-08-25 12:08:19 +00:00
Zuul
d10185380b Merge "volume: Make better use of argparse" 2023-08-25 12:08:16 +00:00
Zuul
356bc2566e Merge "volume: Add 'volume type set --private/--public'" 2023-08-25 12:08:10 +00:00
Zuul
0183e7203c Merge "docs: Migrate volume commands to autoprogram-cliff" 2023-08-25 12:08:09 +00:00
Stephen Finucane
194f59bea3 tox: Bump min_version to 4.3.0
tox 4 is significantly faster when it comes to creating virtualenvs and
is far better and detecting e.g. changes to requirements. tox 4.3.0
includes many of the fixes for bugs introduced by tox 4.0 and is a good
default candidate.

Change-Id: I0bb7f75ed3e03965ecd4d260c1299b46dcbf4b1b
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-08-25 11:35:16 +01:00
Zuul
29f2444866 Merge "Add the flavor-id option to router create" 2023-08-22 16:05:20 +00:00
Jan Hartkopf
f29e3ccc37 Add --skip-resource option to project cleanup
Story: 2010370
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/878646
Change-Id: I9eb10cfd8612fa9faf2a734a517078b12a9ca3c3
Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de>
2023-08-21 11:47:24 +02:00
Miguel Lavalle
f8f174c458 Add the flavor-id option to router create
The --flavor-id option is added to the router create command. The
flavor_id attribute has been supported by the Neutron API for router
POST operations since a long time ago [0].

Partial-Bug: #2020823

[0] https://review.opendev.org/c/openstack/neutron-lib/+/494289

Change-Id: If88499533a92c09e67b0827d1d64156682a3bb8e
2023-08-17 10:03:28 -05:00
whoami-rajat
bfd6170b03 Migrate backup commands to SDK
This patch migrates the following backup commands to SDK:

* Create Backup
* Show Backup
* List Backup
* Restore Backup
* Delete Backup

Change-Id: Icfadd65b92f4cd343bc327d33e29767bc9b969f9
2023-08-17 11:04:46 +05:30
Rodolfo Alonso Hernandez
335bfdc38f Check the default role list before adding a new one
The default role list now adds "manager" by default. This new
default role was added in Keystone 24.0.0.0rc1, that includes
[1].

[1]https://review.opendev.org/c/openstack/keystone/+/822601

Story: #2010923
Task: #48787

Change-Id: I3eeca1a0296137eef777770bff4993a56e2fcc5c
2023-08-16 00:30:30 +00:00
Mridula Joshi
18a6199ed0 Adding image stores info command
This is an equivalent for ``glance stores-info``.

Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/883493
Change-Id: I15d2c2c523ace1cfb32045328ecee8ce8beea63f
2023-08-10 07:34:19 +00:00
Zuul
7dc1276f40 Merge "Adding `image delete --store and image import info` commands" 2023-08-09 19:01:35 +00:00
Zuul
afdec1d2ca Merge "Add image metadef resource type command 'list'" 2023-08-09 19:01:33 +00:00
Mridula Joshi
b347347986 Adding `image delete --store and image import info` commands
Change-Id: Ia5fc44c6738f8ee3a0781d824c7f7fa458185e0c
2023-08-07 17:13:33 +00:00
Zuul
9846092b33 Merge "Neutron port hints" 2023-08-07 13:27:49 +00:00
Chengen Du
2ae621f098 Add a warning for resizing servers booted from volumes
Story: 2010858
Task: 48521
Change-Id: Ib72da4d2c2b4bfbbdbc1e8302b65d240e4e1d459
2023-08-01 17:36:00 +08:00
Zuul
7ea78b6ef6 Merge "Migrate 'volume summary' command to SDK" 2023-07-24 12:29:14 +00:00
Tony Breeds
deab1a7ad8 Update the underlying python containers to "3.10-bookworm"
The existing 3.9 is based on debian buster and isn't getting security
updates ... or any updates really.  This change updates to a base
container that will get updates for a while.

I picked 3.10 rather than 3.11 as 3.10 is part of the bobcat[1]

[1] https://governance.openstack.org/tc/reference/runtimes/2023.2.html

Change-Id: I606389a81ab189b1abf2c700acf5c5543a09165a
2023-07-18 20:24:53 +10:00
Stephen Finucane
c05be82de0 docs: Add examples of common auth methods
Took me a bit to figure out how to do token auth today. Document it.

Change-Id: I3edce59efd5ca5a6e31eef8c7cf3cf255234c82e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-07-10 13:50:34 +01:00
Stephen Finucane
9cd6204a5d doc: Split image command documentation
This document is growing a bit too big now.

Change-Id: Iadf7f28d2307d1598e378bd49a09e75e1235d779
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-07-06 17:35:56 +01:00
Antonia Gaete
52bf194741 Add image metadef resource type command 'list'
This patch will add ``image metadef resource type list`` using
SDK, output matches glance client output.

Change-Id: I29850abdbb06d5a4eaf8a9a60f565b46f4009f85
2023-07-06 17:27:21 +01:00
Zuul
46431ed203 Merge "Allow multiple --remove-tag in project set" 2023-07-05 11:07:48 +00:00
whoami-rajat
4dfbc5011e Migrate 'volume summary' command to SDK
This patch modifies the existing volume summary call from
cinderclient to SDK.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/884397
Change-Id: I364211a597b6ec155b154fa9d3c67239e750b5ad
2023-07-05 10:04:01 +00:00
Stephen Finucane
717837153b tests: Use a new project for quota tests
These mess with quotas on the main project, which can have knock-on
effects for other tests. Use a new project.

Change-Id: I687ec3a0985eab4d01c918dae73d2fbdc7ac25fa
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-06-09 14:35:58 +01:00
Jake Yip
b4ba04698b Allow multiple --remove-tag in project set
The help text for this arg says 'repeat option to delete multiple tags'.
Fix to reflect what docs says.

Also add missing test for this argument.

Change-Id: Ib1069ce7a441c1ff10d2dca05095eb6bf53e7fb6
2023-06-08 18:22:48 +10:00
Zuul
a0971501a9 Merge "tox: Disable E501" 2023-06-06 17:24:00 +00:00
Douglas Mendizábal
bc60e3bb90 Fix "access rule" commands to only use ID
This patch modifies the access rule commands to use only the resource
ID.  The previous logic incorrectly assumed that access rules have a
"name" property, which resulted in unexpected behaviors.

For example, "access rule delete {non-existent-id}" now results in a
"not found" error instead of sometimes deleting an unrelated rule.

Story: 2010775
Task: 48163
Change-Id: Ib5c3b7f86acf1dfe7cc76dfa99fa4c118388bd71
2023-06-05 12:03:15 -04:00
Stephen Finucane
3ba55118eb tox: Disable E501
This is more trouble than it's worth now. Black takes care of this for
us. I wish I'd decided this before the blackify series :(

Change-Id: Ifee786c96b6f0bcd96008fed2b3ed3257d02c07c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-05-31 17:39:59 +01:00
Bence Romsics
22d1a26d1d Neutron port hints
Introduce the hints port attribute that allows passing in backend
specific hints mainly to allow backend specific performance tuning.

Enable:
  openstack port create --hint ALIAS=VALUE
  openstack port set --hint ALIAS=VALUE
  openstack port unset --hints

Required neutron extension:
  port-hints
  port-hint-ovs-tx-steering

Valid hint aliases and values:
  ovs-tx-steering=hash
  ovs-tx-steering=thread

The same hints in JSON format, as expected by the Neutron API:
  {"openvswitch": {"other_config": {"tx-steering": "hash"}}}
  {"openvswitch": {"other_config": {"tx-steering": "thread"}}}

Change-Id: I4c7142909b1e4fb26fc77ad9ba08ec994cc450b2
Depends-On: https://review.opendev.org/c/openstack/neutron/+/873113
Partial-Bug: #1990842
Related-Change (server side): https://review.opendev.org/c/openstack/neutron/+/873113
Related-Change (spec): https://review.opendev.org/c/openstack/neutron-specs/+/862133
2023-05-24 13:08:15 +02:00
Zuul
f3a51b0051 Merge "trivial: Remove duplicate definitions" 2023-05-18 12:33:01 +00:00
Zuul
90fe18e51b Merge "Dropping the use of 'addFixedIp' server action" 2023-05-18 11:52:56 +00:00
Stephen Finucane
e984ca18a4 trivial: Remove duplicate definitions
These are already set in the 'TestServer' super class.

Change-Id: I90cfd9ff004c59cadc3e760eb120a460687701fe
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-18 10:14:12 +00:00
Zuul
4a62c73992 Merge "volume: Add 'volume qos set --no-property' option" 2023-05-17 23:20:28 +00:00
Zuul
d0a17d48a9 Merge "compute: Fix bug with start/stop server" 2023-05-17 23:20:17 +00:00
Zuul
a2728356af Merge "Allow server rebuild --wait for SHUTOFF servers" 2023-05-17 23:20:11 +00:00
Zuul
938850bae1 Merge "Migrate 'volume revert' command to SDK" 2023-05-17 17:09:20 +00:00
Stephen Finucane
e91844dd0e Dropping the use of 'addFixedIp' server action
Dropping the use of 'AddFixedIp' server action entirely in favour of
creating an interface with a fixed IP using the 'os-interface' API. The
reason for doing this is because this mechanism allows us to request an
explicit fixed IP.

Adds back support for using the --fixed-ip-address argument for users
who use older nova-api versions.

Change-Id: Ieac4b0fbcb38fe7207eaaa6a79e0c6770ee11d80
2023-05-17 17:47:05 +01:00
Stephen Finucane
f43e2ed20d compute: Fix formatting of 'server show'
In change Ic253184ee5f911ec2052419d328260dc4664b273, we switched to
using the SDK for the 'server show' command. There were a couple of
issues with this change, which we address here:

- openstacksdk uses different names for fields than the nova API. We
  opted to output both the original names and the openstacksdk aliases
  in the output. With testing, however, it's become obvious that the
  resulting output is very long and rather unfriendly from a UX
  perspective. We opt to only show fields with their original names.

- A number of fields included in the output are only valid in requests
  and will never be present in responses. These are removed.

- A number of fields are not present in later API microversions or are
  only present under certain conditions. These are removed from output
  when not included in responses.

- The image and flavor fields both had errant logic that resulted in
  unnecessary or incorrect information being show. This logic is
  corrected.

With these changes, the output now resembles the output seen before the
migration to openstacksdk. In the future we may wish to build on this
further and switch from a blacklist model (removing the fields we do not
wish to show from output) to a whitelist model (specifically stating
which fields to show) but that's a change for another day.

Change-Id: I7e3eaa0149bff202c8fd4538356cbc75b4f7e708
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-05-17 17:24:44 +01:00
Stephen Finucane
6e773f68cf docs: Migrate volume commands to autoprogram-cliff
There are a few outstanding commands. Migrate them in one fell swoop. We
do lose a small bit of information about commands that are only
supported in block storage API version 2.0 or later, but who cares about
block storage API version 1.0 these days?

On a related note, we also use the 'openstack.volume.v3' entrypoint
rather than the v2 one since that's more relevant nowadays and the code
is pretty much identical.

Change-Id: Ide9d65596847d3f855981ff4ec57eeaeea6667a7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-05-17 16:50:23 +01:00
Stephen Finucane
629eb33c4d volume: Add 'volume qos set --no-property' option
Supporting "--no-property" option will apply user a convenient way to
clean all properties of volume qos in a short command. The patch adds
"--no-property" option in "volume qos set" command and update related
test cases and docs.

Change-Id: I1fb5b4f0a923bbf557a3af3f63809bde9e84ffd4
2023-05-17 16:50:16 +01:00
Stephen Finucane
6dcef7c3ec volume: Make better use of argparse
Change-Id: Ifeab60aaf18a9163465d4968c53e3ed66dad769b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2023-05-17 16:38:56 +01:00
Takashi Kajinami
83f5c8033f volume: Add 'volume type set --private/--public'
We also rename the test file and fixup some of the tests.

Change-Id: I3731255648dc91c023a1390c3b37e68b6608f850
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
Story: 2008478
Task: 41518
2023-05-17 16:38:38 +01:00
Stephen Finucane
0a63f8603e compute: Fix bug with start/stop server
A mistake was introduced during the conversion from novaclient to SDK in
change I5ebfa6b2468d5f20b99ea0eab1aea9377be09b8c. Fix the issue and add
functional tests to prevent it being reintroduced.

Change-Id: I6b314eab31bcf452e88b8b6a239ac2e296497cb9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Story: 2010750
Task: 48004
2023-05-17 15:59:33 +01:00
Pavlo Shchelokovskyy
417a7ad203 Allow server rebuild --wait for SHUTOFF servers
currently the command is waiting only for ACTIVE server status,
but if the server was SHUTOFF before, it will be SHUTOFF after
rebuild as well, so the command is stuck in waiting forever.

Additionally, we now also pre-validate the server status on client side,
and raise an error if the server to be rebuilt is not in ACTIVE, ERROR
or SHUTOFF state.

Change-Id: If90a4bbba9a7ecd972f8b594c52fee4f75a0ae5e
Co-Authored-By: Oleksiy Molchanov <omolchanov@mirantis.com>
Story: 2010751
Task: 48005
2023-05-17 11:38:37 +00:00
Stephen Finucane
31ae635ffe tests: Use SDK objects where expected
We had not migrated a number of tests to use SDK objects instead of fake
novaclient-like objects when migrating the commands themselves. Address
this now.

Change-Id: Ib0da07fd9d793968b111986bd36a6d4311469d4e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-16 16:55:08 +00:00
Stephen Finucane
19be070204 tests: Remove unnecessary nesting of compute resources
Change-Id: I27326b8f2e0d84d3ef2c2fbdcb5c96a5ac1d79e4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-16 16:21:44 +01:00
Stephen Finucane
347b444feb tests: Reorder compute fakes
This will make future changes slightly less complex.

Change-Id: Ia69fd9d05796cce5ed48a8d12902cb54caec9779
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-16 16:21:02 +01:00
whoami-rajat
aaeda25e28 Migrate 'volume revert' command to SDK
This patch modifies the existing revert volume to snapshot call
from cinderclient to SDK.

Change-Id: Iaa9708ebae5d6ab3dfc73e4e2376af32ed098688
2023-05-16 17:38:10 +05:30
Stephen Finucane
3c9afe69bb pre-commit: Enable black
Since our pep8 tox env now runs pre-commit, we can ensure that black
styling will be maintained.

Change-Id: Ifad1d67a83c4979b4f4de71de0124613d1133560
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
229791cdb4 Ignore black changes
Add a .git-blame-ignore-revs file to ignore the black changes. File was
generated with the following command:

   git log --pretty=format:"%H  # %s" --no-merges --grep='Blacken'

Change-Id: I4c5c06a8d194cce4d490dc2b01040c68853451c2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
d3f4a3d7f5 Blacken everything else
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I356643d06b2cd408ccaedfe02b858aea55388949
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
a6f81a736c Blacken openstackclient.api
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I1df5bc4c35f02147fe5ac5b4073f0e01e7d51c2f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
7d80f9e962 Blacken openstack.common
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: Ifcb3c798666d74d596b8ecb3d6d507f782de7ba5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
7ca43885c2 Blacken openstackclient.image
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I6420ec6fd550903b03083b9b1f8391511913c86f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
329296cedd Blacken openstackclient.object
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I6658e76d7d1f93149f24fcab28d593195b37779f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
aed521d426 Blacken openstackclient.identity
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I2eeade1ce6653be8e9179ecc40105182c5ff5f16
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
6475dc58e8 Blacken openstackclient.network
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I8048746dbc2ef0cb582f68934734db4c1153d779
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
35ba1d8f13 Blacken openstackclient.volume
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: Ic318617c67ab7ce6527f9016b759a1d4b0b80802
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
28ffa2bf9f Blacken openstackclient.compute
Black used with the '-l 79 -S' flags.

A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.

Change-Id: I9af45c062d179ab3dc2a5e969e1c467932753a2b
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:30 +01:00
Stephen Finucane
5cb16aebcc Use pre-commit for 'pep8' tox target, bump versions
We want to bump the versions of hacking, but doing so requires changes
in two places: '.pre-commit-config.yaml' and 'tox.ini'. This is silly:
we can simply use tox to handle pre-commit and leave all other
dependencies to pre-commit. Do this, migrating bandit to pre-commit and
bumping the other dependencies in the process.

We remove the 'fast8' target and tool, since pre-commit is plenty fast
here.

Change-Id: Ifdc582ecc3b4479ea9ed9abcb16577c6e8b2f5c1
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:51:00 +01:00
Stephen Finucane
379db31ea2 Address pre-commit issues
We'd like to use pre-commit as our 'pep8' target. Before we do that, we
need to address some issues that have crept in over the time since
pre-commit was first added.

Change-Id: I3bb383a00a44007eaa241e037e38aea16bd517b2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-05-10 10:48:53 +01:00
Zuul
43f0e1090a Merge "compute: Generate SSH keypairs ourselves" 2023-05-04 15:06:03 +00:00
Zuul
83016780c7 Merge "Silence warnings from openstacksdk" 2023-05-03 16:51:35 +00:00
Stephen Finucane
2454636386 compute: Generate SSH keypairs ourselves
Starting with the 2.92 microversion, nova will no longer generate SSH
keys. Avoid breaking users by generating keypairs ourselves using the
cryptography library, which was already an indirect dependency through
openstacksdk.

Change-Id: I3ad2732f70854ab72da0947f00847351dda23944
Implements: blueprint keypair-generation-removal
2023-05-02 12:18:52 +01:00
Zuul
a2f877f70c Merge "Migrate 'server event *' commands to SDK" 2023-04-21 17:30:11 +00:00
Huda Irshad
737540cca0 Migrate 'server event *' commands to SDK
This one is tricky since the ServerAction resources includes a nested
ServerActionEvent resource which requires a custom formatter in order
for things to render as expected.

Change-Id: I3d24851303222af9efcee8d7e1565278b1018efd
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
2023-04-20 12:09:59 +01:00
Artem Goncharov
a675c61e46 Fix pep issue in the network service provider
pep gods started complaining (correctfully) about spacing in the old
command. Apply `black -l 79` on the file to make it looking nice and
passing checks.

Change-Id: I716f6a1496fc552b32809c7eb744283f3a3cd5a4
2023-04-20 11:15:37 +02:00
Mridula Joshi
16c78fef15 Adding `image import` command
Change-Id: I7254d30431894879c8bd20e2263d83b12c99d5c8
2023-04-12 09:42:43 +00:00
Stephen Finucane
23da7b73a2 Silence warnings from openstacksdk
OSC has historically relied on project-specific clients like novaclient
for library bindings. These did not support auto-negotiation of
versions. Instead, users were advised to set the requested microversion
to e.g. '2.latest' to opt into the latest API version supported by the
client.

We're slowly migrating everything to SDK which *does* support
auto-negotiation (well, of sorts). This makes versions like '2.latest'
unecessary and SDK correctly warns the user about this.

  You have a configured API_VERSION with 'latest' in it. In the context
  of openstacksdk this doesn't make any sense.

Unfortunately, we have not yet migrated all commands to SDK, meaning we
have a mix of SDK and legacy client-based commands. So long as there are
any command using the legacy client, we can't insist on users removing
this configuration. This makes the warning both annoying and something
the user can't do anything about. We also don't want to remove the
warning from SDK so instead we opt to filter it out, along with all
other warnings from openstacksdk (which similarly a user can't do
anything about).

Change-Id: If8a7cf9bc876f84864d66f5aed5f2f61c5d0696a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-04-11 16:45:56 +02:00
Stephen Finucane
864f51f427 compute: Migrate 'reboot server' to SDK
Change-Id: Ibad4078f680d3b2615b9ca6f6c72c4fd28030b55
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-04-04 13:40:38 +01:00
Zuul
5282bd2622 Merge ""hypervisor list --matching" showed the wrong result" 2023-04-04 08:10:09 +00:00
Zuul
72034196ca Merge "Add an updated tips job running on py310" 2023-04-04 08:10:07 +00:00
Zuul
ad992486fb Merge "Remove unused helpers for legacy novaclient" 2023-04-03 20:36:15 +00:00
Zuul
5d2687bfc4 Merge "Switch server shelve, unshelve to SDK" 2023-04-03 20:36:13 +00:00
Zuul
eafe579534 Merge "compute: Switch server restore to SDK" 2023-04-03 20:36:11 +00:00
Dr. Jens Harbott
00af88cf74 Add an updated tips job running on py310
Change-Id: Iadc32b4e8ea10561784208cdc8bf05ff3b3ca59d
2023-03-31 19:19:20 +02:00
Zuul
0a9a1753b5 Merge "Remove unnecessary 'self.methods'" 2023-03-30 19:05:04 +00:00
Zuul
17d03f49aa Merge "Switch server start, server stop to SDK" 2023-03-30 19:05:02 +00:00
Zuul
4e9181aa1e Merge "Switch server lock, unlock to sdk" 2023-03-30 19:05:00 +00:00
Zuul
55f2819cef Merge "Show Network QoS rules one per line" 2023-03-29 14:31:25 +00:00
Rodolfo Alonso Hernandez
f1cf3a10b5 Show Network QoS rules one per line
The command "network show qos policy <qos>" now shows the QoS rules
printed one per line.

Example: https://paste.opendev.org/show/bgam6amfLUVheAMhDxB3/
Change-Id: I65a99da16056902a822804e29b2dd9376a72e091
2023-03-28 18:18:49 +02:00
devMuscle
e74f2d94fe "hypervisor list --matching" showed the wrong result
Previously, using the "--matching" option shows empty results.
Previously, the "--matching" option called the "find_hypervisor method",
so we used to call the "hypervisor method"
like any other "--limit, --marker" options.

Depending on the nova api version, the api that is basically
called is as follows
2.53 >= : /os-hypervisors/detail?hypervisor_hostname_pattern=$HOSTNAME
2.53 < : /os-hypervisors/{pattern}/search

Hypervisor Type and Host IP are not returned
when using microversion 2.52 or lower

Co-authored-by: Jipyo Hong <hongsbien@naver.com>
Co-authored-by: Jieon Lee <dlwldjs7544@naver.com>
Co-authored-by: YoonSoo LIM <msdbtjd123@naver.com>

story: 2010670
task: 47726
Change-Id: I7b47acf48def7d4c5f4b74e4dba1c23d8ac7abf2
2023-03-26 14:06:36 +09:00
yaeeee
4e5e3cff5d Docs: Update glance command mapping
Update missing command in glance Mapping Guide.

List of updated command
[Glance CLI / OSC]
md-namespace-create / image metadef namespace create
md-namespace-delete / image metadef namespace delete
md-namespace-list / image metadef namespace list
md-namespace-show / image metadef namespace show

Co-authored-by: sujin01 <a5870771@gmail.com>
Co-authored-by: heesom <heesom.hs@gmail.com>
Co-authored-by: mpicea <jjh77745997@gmail.com>

Change-Id: I4d50b0ae820ea0c8feb1719bbbd9eb06d22cbe20
2023-03-25 10:53:23 +00:00
Johannes Kulik
aa227f8d16 Fix --security-group for port list
"openstack port list --security-group <id>" was using a filter that
didn't exist in `openstacksdk`: "security_groups". Up until version
1.0.1, `openstacksdk` did not support filtering `Port` objects by
security groups. Later versions will support the filtering (via [1]),
but the filter is called the same way the attribute on the `Port` object
is called: `security_group_ids`.

We're not bumping the `openstacksdk` version here, because the feature
we're using [1] is merged too recently and a bump of min requirements
thus unlikely. `openstackclient` continue to work with older versions of
`openstacksdk` - the "--security-group" filter will just do nothing like
before.

[1] https://review.opendev.org/c/openstack/openstacksdk/+/866008

Change-Id: I07088484592e99ce0a12b67d68a3e47ae7c7af81
2023-03-20 15:19:46 +01:00
Zuul
65b667af20 Merge "Add auto-approve option to project cleanup" 2023-03-20 12:07:44 +00:00
OpenStack Release Bot
5eb89e4ca1 Update master for stable/2023.1
Add file to the reno documentation build to show release notes for
stable/2023.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.

Sem-Ver: feature
Change-Id: I248bcb0342afb8276ba9605963287f620b62b6c5
2023-03-09 16:42:30 +00:00
Zuul
05d34ffce9 Merge "zuul: Merge osc-functional-devstack-base into only child" 2023-02-23 21:40:10 +00:00
Zuul
7c85f840f6 Merge "Add missing documentation for state options for "image set"" 2023-02-22 12:53:01 +00:00
Zuul
43f04c874f Merge "Drop default from ask_user_yesno question" 2023-02-22 12:32:22 +00:00
Zuul
cfd728108c Merge "Wait for volume being available to set bootable or readonly" 2023-02-22 12:32:20 +00:00
Zuul
a7e091c329 Merge "Update 'host list' and 'host show' command to use sdk" 2023-02-22 12:32:18 +00:00
Zuul
14dff075ff Merge "Fix really long help strings" 2023-02-22 12:32:16 +00:00
Zuul
02acd27c6a Merge "Add port ranges on floating ip portforwardings cli" 2023-02-22 12:32:14 +00:00
Zuul
3478873cff Merge "volume: Remove duplication from 'consistency group create' opts" 2023-02-22 12:32:11 +00:00
Zuul
365a7a24f5 Merge "Deprecate positional args for 'volume group create'" 2023-02-22 12:32:09 +00:00
lsmman
e53f706d0b Add missing documentation for state options for "image set"
The current "image set" with the state option behaves as follows: if you
use --project, it updates the membership status of the given project.

When this command was first added, it had the following description:

  If --project is passed, update the membership status for the given project

However, the description was missed when moving the documentation for
which command to the parser for each command method in commit f055fe67c.
Correct this oversight.

Co-authored-by: JAE YONG LEE <jaeljy135@gmail.com>
Change-Id: I18a29a19ce973971f68a52cbf4020cfa324c7a35
2023-02-22 10:14:21 +00:00
Stephen Finucane
5f19711720 zuul: Merge osc-functional-devstack-base into only child
Since we removed the osc-functional-devstack-n-net job in change
I76efeccec04937c3a68108e2654872e00fadcec4, there's no need to maintain
separate osc-functional-devstack-base and osc-functional-devstack jobs.
Merge them.

Change-Id: Id3dcd3c4f9f47a4020faf0787f44bd5509a2b5a2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-02-22 10:03:54 +00:00
Zuul
36ba614ba9 Merge "doc: Update nova command mapping" 2023-02-22 10:03:02 +00:00
matbu
5c9c1c77a0 Wait for volume being available to set bootable or readonly
This patch add a check to be sure that the volume created is in a
available state before trying to set bootable or readonly flag.

Story: 2002158
Change-Id: I8db71fd8cf5bd14eb67880f76d2e9135edeb3ed2
2023-02-22 09:52:43 +00:00
Zuul
861e1a8eee Merge "Finish switching server migration to sdk" 2023-02-21 13:28:47 +00:00
Zuul
8786767851 Merge "tests: Use fake SDK Migration object" 2023-02-21 13:28:44 +00:00
Zuul
dfe2bc9fbd Merge "compute: 'server volume update' -> 'server volume set'" 2023-02-21 13:28:40 +00:00
Zuul
2249d0026d Merge "Switch server volume update to sdk" 2023-02-21 13:28:37 +00:00
Zuul
fa90ad1392 Merge "Switch list server volume to sdk" 2023-02-21 13:28:35 +00:00
Stephen Finucane
674e4e620b doc: Update nova command mapping
There are a number of commands we're never going to implement:

  host-evacuate
  host-evacuate-live
  host-servers-migrate
    As noted in Dan Smith's blog [1], these are wrapper commands or meta
    operations that call a particular action - namely 'evacuate',
    'live-migration', and 'migrate' in old novaclient parlance - for
    each server on a particular host.

    These commands have historically been confusing. The underlying
    server commands have been implemented as 'server evacuate', 'server
    migrate --live', and 'server migrate', respectively. If a user wants
    to call these for each server on the host, they can do so with a
    little bit of shell scripting (hint: you want 'server list --host')
    or use something more suitable for this kind of task such as Puppet
    or Ansible.

  host-meta
    As above, this is equivalent to calling 'meta' for all servers on
    the host. Combine 'server set --property' with 'server list --host'
    instead (or use Ansible).

  instance-usage-audit-log
    This corresponds to the '/os-instance_usage_audit_log' API which is
    intended for use by OpenStack Telemetry. There's no user-facing
    application of this.

The remaining entries are updated to include their implementations. We
simply missed updating the mapping doc when implementing them.

With this, the OSC implementation of the nova API is *documented* as
being complete, as opposed to merely actually being complete 😉

[1] https://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/

Change-Id: If08d501dd66c561956266d3b3f21dfd3559d8394
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-02-21 12:31:11 +00:00
Stephen Finucane
0d57f3f367 Deprecate positional args for 'volume group create'
There are now many ways to create a new volume group, thus the
positional arguments don't make sense. Deprecate them.

Change-Id: Id0b212426861719db1812b7d07b82613cf591de4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-02-17 13:50:50 +00:00
whoami-rajat
ec01268ea9 Add options to create volume group from source
This patch adds ``--source-group`` and ``--group-snapshot`` options
to the ``volume group create`` command to allow creating group from
a source group or a group snapshot.

Change-Id: I87482a5dd43c519dfdcf981635aa879914a70a5c
2023-02-17 12:17:22 +00:00
whoami-rajat
73b4ce88eb Add block storage manageable list commands
This patch adds the ``block storage volume manageable list`` and
``block storage snapshot manageable list`` commands that
allow operators to list the volumes and snapshots on a
particular host or cluster for management under OpenStack.

Change-Id: I328dada5a0dc4e9e44c0d51db5cf3f224e27f88f
2023-02-17 10:03:01 +00:00
whoami-rajat
2be3596779 Add block storage cleanup command
This patch adds the ``block storage cleanup`` command that
allow operators to cleanup resources (volumes and snapshots) with
failed operations by requesting services in other hosts in the
same cluster to cleanup resources of a failed service.

Change-Id: I1375223f525021db5201fa0a9f9a647d17dd01f7
2023-02-17 10:02:22 +00:00
whoami-rajat
a9e3049e9c Add block storage log level {list, set} commands
This patch adds the ``block storage log level list`` and
``block storage log level set`` commands that allow
operators to list the current log levels of cinder services
and also enables them to set a particular log level.

Change-Id: I16cd8084fb505a9e68a35a936ef3b8b1f3cdc712
2023-02-16 04:33:40 +00:00
whoami-rajat
e7ebf7544b Add volume revert command
This command allows users to revert a volume to a given snapshot.

Change-Id: If35ee394d654f5264558a281c835affff524ca50
2023-02-16 04:33:40 +00:00
Dr. Jens Harbott
7506eb8e0c Add auto-approve option to project cleanup
Sometimes it is useful to be able to use the project cleanup function in
scripts and having to add "echo y | openstack" isn't really nice.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I3ded9982769b4568b6dcfc49bc31ba67a6227839
2023-02-15 09:42:45 +01:00
Stephen Finucane
4106926fa6 volume: Remove duplication from 'consistency group create' opts
The '--consistency-group-source' and '--consistency-group-snapshot' opts
are unnecessarily verbose. Shorten them to '--source' and '--snapshot',
respectively, maintaining aliases to avoid breaking users.

Change-Id: I2b6656a8a09d953eb4406f1d4fd1e804743a8963
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-02-14 16:42:22 +00:00
Zuul
1e0880eda8 Merge "Add volume summary command" 2023-01-31 12:43:33 +00:00
Zuul
f9b025e4cb Merge "Move network trunk commands from python-neutronclient" 2023-01-31 12:40:59 +00:00
Zuul
f1da522cc3 Merge "image: Add support for additional image import methods" 2023-01-25 18:04:00 +00:00
elajkat
7f1c21b27a Move network trunk commands from python-neutronclient
Network trunk commands originally were added to python-neutronclient,
although we can long consider these operations core Networking operations.
This patch is not a blind copy but also changes the original code to use
openstacksdk python bindings instead of the binding code in
python-neutronclient as that is already deprecated.

Change-Id: Ic4bc35c296a95d5dae92e9fc1cab3a3fa8f103cd
Related-Bug: #1999774
2023-01-16 14:07:55 +01:00
whoami-rajat
77266bd9c3 Add volume summary command
This patch adds the ``volume summary`` command which shows the total
size, total count and metadata of all volumes.
This command is available from microversion 3.12 and the metadata
info is available from microversion 3.36.

Change-Id: I6472337e8b1dc91aad5fbe416673a5d5a5d5fa88
2023-01-13 21:18:15 +05:30
Stephen Finucane
88672d22c4 tests: Use fake SDK Migration object
We missed this when migrating the 'server migration list' command
across.

Change-Id: Ide05a0289020764829f1dbc416be5336fdf37d84
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2023-01-04 13:20:29 +00:00
Jiri Podivin
7985d49689 Excluding test code from coverage reports
Coverage report should not include statiststics on test modules
which is not only unnecessary, but also pollutes the coverage
statistics and pollutes the final report.

Requesting the path to tests to be omitted in .coveragerc resolves the issue.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Ifedaa1c8bfab23d92958e58c69c03e778454a408
2023-01-04 11:00:47 +00:00
Dr. Jens Harbott
69182a04b2 Drop default from ask_user_yesno question
There is no default for ask_user_yesno() since an empty answer instead
just repeats the question. Drop the unnecessary parameter.

Change-Id: I207bccbcbd31f831765e74a20c503b695790c0f5
2022-12-27 13:03:14 +01:00
Dr. Jens Harbott
5501ac7d1d Fix tox v4 compatibility
Various changes to tox.ini to support v4

Change-Id: Iee2bceb78f5b03c559f23b99cde57fd598ce981a
2022-12-26 15:56:28 +01:00
Zuul
1c2191bf3a Merge "Add plugin doc page for cyborg" 2022-12-20 15:03:25 +00:00
Zuul
a8d1ee709e Merge "Add qos rule type filtering" 2022-12-20 13:36:46 +00:00
Zuul
21c3c33087 Merge "image: Fail if we can't find an image" 2022-12-20 13:36:43 +00:00
Zuul
1d96a899f8 Merge "docs: Fix typos" 2022-12-20 13:20:13 +00:00
Zuul
a805f7ebb1 Merge "image: Rename import" 2022-12-20 13:20:11 +00:00
Shogo Saito
7f89b109cf Add plugin doc page for cyborg
This patch add cyborg (accelerator) doc page.

Change-Id: I0f3e5419ce522e620be805c0fcd829c8dfb2e317
2022-12-20 12:33:00 +00:00
Harsh Mutha
ecc6aeeede Update 'host list' and 'host show' command to use sdk
Change-Id: I3813ff604ba46112ebd358509ea4f28ee38ca3ee
2022-12-20 12:11:13 +00:00
Stephen Finucane
1701768c2d Remove unused helpers for legacy novaclient
These are no longer used.

Change-Id: I9514e98a5549130c12f3b785e90debf3437e6933
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-19 17:25:25 +00:00
Stephen Finucane
f56f0e333e Switch server shelve, unshelve to SDK
This one is a little more complicated because we support waiting.

Change-Id: I5bd65b44c23bfee1e0144dbd060563ecc3cfb942
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-19 17:25:23 +00:00
Stephen Finucane
004b2ab2fb compute: Switch server restore to SDK
Change-Id: I8df9711b736991c01136988aa06c8540d640f52f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/868108
2022-12-19 17:02:48 +00:00
Stephen Finucane
29fafabeed Remove unnecessary 'self.methods'
This was used by 'run_method_with_servers', not the SDK-equivalent.

Change-Id: Ia3333a95e406f430beb4f2cfb887e81ab7b72cfe
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-19 16:56:45 +00:00
Thrivikram Mudunuri
9241514137 Switch server start, server stop to SDK
Switch the server start and server stop commands from novaclient to SDK.

Change-Id: I5ebfa6b2468d5f20b99ea0eab1aea9377be09b8c
2022-12-19 16:56:20 +00:00
suneethravi
ce8171bad9 Switch server lock, unlock to sdk
Switch server lock commands from novaclient to SDK.

Change-Id: I042db99c9d7a0d8d207f8cdf69d786bd4fe904e7
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/867890
2022-12-19 16:55:46 +00:00
Zuul
b2c9a4cd40 Merge "Switch server dump create to using sdk" 2022-12-15 20:14:43 +00:00
Stephen Finucane
e0577e7ebe compute: 'server volume update' -> 'server volume set'
We use 'set', not 'update', in command names. An alias is provided.

Change-Id: I7864599e06df055999b975aabf101611cd482753
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-15 18:22:08 +00:00
Zuul
e00400eff5 Merge "Use the SDK in server migration list" 2022-12-15 18:05:11 +00:00
Ritvik Vinodkumar
25b4714f1c Switch server volume update to sdk
Switch the server volume update command from novaclient to SDK.

Change-Id: Ib9876775bcf8268344da1a58ab0dd1695cb83ece
2022-12-15 17:54:06 +00:00
Zuul
d297f11b87 Merge "Add baremetal agent type list filtering" 2022-12-15 17:45:33 +00:00
Zuul
db6909bc63 Merge "Add image metadef namespace command" 2022-12-15 17:45:31 +00:00
Zuul
a103b6ca34 Merge "Use the SDK for server show" 2022-12-15 17:45:29 +00:00
Zuul
3f7663a00e Merge "Fix parameter handling in server add fixed ip cmd" 2022-12-15 17:45:27 +00:00
Zuul
34bf2533a7 Merge "Updating the glanceclient reference doc" 2022-12-15 17:45:25 +00:00
Zuul
3aff444386 Merge "Migrate hypervisor stats commands to SDK" 2022-12-15 17:45:23 +00:00
Zuul
240bbe7239 Merge "Create a functional test case for hypervisor list and show" 2022-12-15 17:45:19 +00:00
Ritvik Vinodkumar
d47e432005 Switch list server volume to sdk
Switch the server volume list command from novaclient to SDK.
Modified functional test for server add/remove volume.

Change-Id: I5b4ab7d0275aec2e02451c5371319ac350af6a5f
2022-12-15 17:39:16 +00:00
Diwei Zhu
c47998c59a Switch server dump create to using sdk
Change-Id: I8e2a4651bff1f739fa98533cd47074b143b2e3d6
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
2022-12-15 17:19:44 +00:00
Violet Kurtz
d1c1c36af1 Finish switching server migration to sdk
Change-Id: Ic0e6dfdc986989599bfc73b8c274631232161c25
2022-12-14 22:07:47 +00:00
Thobias Salazar Trevisan
794334ec24 Fix server list error with --long and -c options
Using options --long and -c and specifying same columns added
by --long option, it passes duplicated column names to prettytable and
report the following error:

Field names must be unique!

This patch removes duplicated columns.

Change-Id: I9c0bd09c50dac568ca1980a6b53a6c544b85c2aa
2022-12-14 15:19:08 -03:00
Ariel-Berkowicz
318df521ed Create a functional test case for hypervisor list and show
This functional test case for hypervisor list and show makes sure it
works with the openstackclient sdk.

Change-Id: Ibaeaf68d6056fcf904b546f30287c65173b5a368
2022-12-14 16:50:42 +00:00
Stephen Finucane
b52ae93cd2 Fix functional-tips job
A recent change to cliff [1] means we're now stripping periods when
generating the summary line of command help strings. Account for this.

[1] https://review.opendev.org/c/openstack/cliff/+/867274

Change-Id: I45b39b9fe38914497505f157e91d84cd2f84f547
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-14 10:39:44 +00:00
Ariel-Berkowicz
992cfdfb57 Migrate hypervisor stats commands to SDK
Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa
2022-12-12 18:58:16 -05:00
Stephen Finucane
5afe48040c Fix really long help strings
Each command should have a summary line followed by a longer
description, if needed. Some commands were not following this. Fix them.

Change-Id: If1ce7654037d192626460f34c069ea0979919b9b
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-12 18:04:01 +00:00
Dr. Jens Harbott
f23322c5ef Fix parameter handling in server add fixed ip cmd
The fixed_ip_address parameter needs to be passed in a hash with key
"ip_address" in order to be processed by the server, the previous arg
was simply being ignored.

Added a functional test for better coverage.

Closes-Bug: 1998927

Change-Id: I6956d2642d8e80fc10c3739f0a571aa7ba276b1a
2022-12-12 12:27:48 -05:00
Daniel Wilson
70dbb01ea3 Use the SDK for server show
Use the SDK for the server show command. This change modifies a helper
function that is used by server show as well as other commands that
print information about an individual server. The helper still uses
novaclient APIs when additional OpenStack requests are needed since some
of its callers are still using the nova client.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/864340
Change-Id: Ic253184ee5f911ec2052419d328260dc4664b273
2022-12-11 18:04:29 -05:00
Rodolfo Alonso Hernandez
bfab0199be Add qos rule type filtering
Added two new filter flags to ``openstack network qos rule type list``:
- "--all-supported", to return any QoS rule type supported by at least
  one loaded driver.
- "--all-rules", to return all QoS rule types supported by the current
  version of Neutron server, regardless of the loaded drivers.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/827671
Depends-On: https://review.opendev.org/c/openstack/neutron/+/827683

Related-Bug: #1959749
Change-Id: Ie0622e79ecf7dadd6560fea142352f5a2ed66b74
2022-12-10 17:01:11 +01:00
hoosa
38f972fa63 Add image metadef namespace command
add image metadef namespace create, delete, set, show command

Change-Id: I35b1cb8ff2b1735ae3a1b405d8f2071fe449ea6e
2022-12-07 21:35:39 +09:00
Mridula Joshi
576e9a01a5 Updating the glanceclient reference doc
Added the missing commands from glanceclient, updated the OSC
equivalent and removed the deprecated commands.

Change-Id: I3cee7882f6712e80c6f6e568337c1f96439aa1a5
2022-12-06 07:45:34 +00:00
Zuul
29129a7715 Merge "image: Add 'image import' command" 2022-12-05 12:59:52 +00:00
Zuul
8248efa8d9 Merge "compute: Allow users to manually specify bootable volumes" 2022-12-05 12:59:46 +00:00
Zuul
5b42583cb1 Merge "tests: Add test for multiple blocks devices" 2022-12-05 12:59:43 +00:00
Zuul
747811fad5 Merge "docs: Document how we manage API versions" 2022-12-05 12:30:01 +00:00
Zuul
65484b5a28 Merge "docs: Describe common actions found in OSC" 2022-12-05 12:29:58 +00:00
Stephen Finucane
4cf22b3d76 docs: Fix typos
Change-Id: I902e8b35d4423f91dd8cdeecbcc7e60af877da75
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-05 10:18:56 +00:00
Zuul
10453e085f Merge "Revert "Don't look up project by id if given id"" 2022-12-02 14:21:51 +00:00
Zuul
3cb4e9c714 Merge "tests: Convert network tests to use 'parse_output'" 2022-12-02 14:21:49 +00:00
Zuul
f9d2d69ed2 Merge "tests: Convert compute tests to use 'parse_output'" 2022-12-02 14:21:47 +00:00
Zuul
cc481f568b Merge "tests: Convert identity tests to use 'parse_output'" 2022-12-02 14:21:45 +00:00
Zuul
a5f207b657 Merge "tests: Convert volume tests to use 'parse_output'" 2022-12-02 14:21:43 +00:00
Zuul
5aecefe911 Merge "tests: Convert image tests to use 'parse_output'" 2022-12-02 14:21:40 +00:00
Zuul
70f05a6610 Merge "Use the compute SDK in server list" 2022-12-02 14:21:38 +00:00
Stephen Finucane
91277e7e51 compute: Allow users to manually specify bootable volumes
When creating a server with an attached volume, you can specify a block
device with a 'boot_index' of '0' and this will become the bootable
device. OSC allows users to do this by using either the '--volume'
option or a combination of the '--image' and '--boot-from-volume'
options, but we should also allow them to do it the "hard way" via the
'--block-device' option. For example:

  openstack server create \
    --block-device uuid=0a89ecd8-1fe2-45f0-94da-7789067911c9,boot_index=0 \
    --block-device uuid=589266ef-fd88-46e9-b7b2-94503ce8f88f,boot_index=1 \
    ... \
    my-server

Make this possible.

Change-Id: Ia48449fecbc590346630807b1c7da40102d53b33
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2010376
Task: 46617
2022-12-01 15:24:08 +00:00
Stephen Finucane
e7bc68735f tests: Add test for multiple blocks devices
The 'server create' command should support multiple '--block-device'
parameters. Prove it.

Change-Id: I1bd83287efdbbe11774053b694bae99b6a4ebdf5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-01 15:13:17 +00:00
Stephen Finucane
799a073b68 image: Fail if we can't find an image
Whenever we attempt to find a provided image, we generally want to fail
fast if they can't be found. This wasn't happening. Fix it.

Change-Id: Ibea38354a78381cb87d287f03726ecd03ecd246d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-01 10:04:02 +00:00
Stephen Finucane
a538104a94 image: Rename import
This makes the code a little clearer.

Change-Id: Ib552d510ca484571e59363ef15fe5e2cc0a2f4e1
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-12-01 10:02:44 +00:00
Stephen Finucane
6dea276e5a image: Add support for additional image import methods
These are now supported in openstacksdk so we can use them.

Change-Id: Ie3107ba2155f9008e6065171298f85978957a172
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/864029
2022-11-30 17:15:29 +00:00
Stephen Finucane
85254fbeb4 Revert "Don't look up project by id if given id"
This reverts commit 042be7c7fe. This
solution worked but it was confusing. The issue that the author was
seeing was presumably due to users not being able to list projects but in
theory the 'openstackclient.image.common.find_project' function that was
being called here should have already handle this. It transpires however
that there was a bug in this and we weren't correctly handling HTTP 403
errors correctly. This bug has since been fixed in change
I2ea2def607ec5be112e42d53a1e660fef0cdd69c meaning this change is no
longer necessary. Remove it and simplify the code somewhat.

Change-Id: I108efec2c8deda50fcb9cc84f313602bed2ac15c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-30 12:35:17 +00:00
Daniel Wilson
86c5470134 Use the SDK in server migration list
Update server migration list to use the OpenStack SDK instead of
directly using the nova interface.

Change-Id: I40dc95ee47e7c33ebf596f8ad437228b4bb0ab33
2022-11-30 12:18:31 +00:00
Stephen Finucane
199ba0bcf8 docs: Document how we manage API versions
Document that microversion auto-negotiation is acceptable. Heck, it's
downright desirable.

Change-Id: Ib256e064d1e8b6dc8273e482276dce243f9991cb
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-30 12:07:33 +00:00
Stephen Finucane
bb5b290478 docs: Describe common actions found in OSC
Off the back of a recent post to openstack-discuss [1], list the common
actions used in OSC along with some conditions around their expected
use and implementation.

[1] https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031284.html

Change-Id: Id6610d678e7b3b12afdd89a674fbbe7090f64444
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-30 12:07:33 +00:00
Daniel Wilson
c97f73ce2a Use the compute SDK in server list
Update server list to use the compute component of the OpenStack SDK
instead of directly using the nova interface. This change depends on SDK
version 0.102.0 for automatic client-side query filters.

Change-Id: Ib9985812bfd98320b75f3a82bb594a0daa6e4d93
2022-11-29 20:24:45 -05:00
Zuul
6cd72f6182 Merge "Adding volume backend commands to volume v3" 2022-11-29 23:03:59 +00:00
Zuul
0a9533709f Merge "Improve server dump create helptext" 2022-11-29 20:52:23 +00:00
Zuul
6413b25dec Merge "Add note about microversion 2.87 in server rescue help" 2022-11-29 20:49:50 +00:00
Zuul
92a1c854bb Merge "Add test for creating volume from source" 2022-11-29 20:49:48 +00:00
Stephen Finucane
50aed3fea2 tests: Convert network tests to use 'parse_output'
Change-Id: I93e2a4e0a4c7ec07da0c78a171f3d787125af053
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-29 16:21:29 +00:00
Stephen Finucane
874519e980 tests: Convert compute tests to use 'parse_output'
Change-Id: Ib5b2f46639f14877a9ec295b26cae01a05395d4d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-29 16:21:29 +00:00
Stephen Finucane
6daa6be392 tests: Convert identity tests to use 'parse_output'
Change-Id: I10711b911986af0348946f6254cf36773110b0ab
2022-11-29 16:21:29 +00:00
Stephen Finucane
686fabef31 tests: Convert volume tests to use 'parse_output'
Change-Id: Iec8ca873f6bc3993e0ba557f68895d9aefb6f9c6
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-29 16:21:29 +00:00
Stephen Finucane
dc03ce98de tests: Convert image tests to use 'parse_output'
Change-Id: I5f256d466d503d70d1f380016f9c8f5a0d9e395f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-29 16:20:03 +00:00
Ilya Popov
f0f54f0100 Adding volume backend commands to volume v3
Task: 46959
Story: 2010454
Change-Id: I6ed5f54079b88bc9fdfa24474a480a2786eda745
2022-11-29 16:44:59 +03:00
Stephen Finucane
948198643f docs: Typo fix
Change-Id: I2d55747b1226207946f80f04b80b4685e3eea3f9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-25 17:28:50 +00:00
Stephen Finucane
abf1a7cc4b docs: Small cleanup of human interface guide
Before we add more content.

Change-Id: I6cf28bdd217326db991466a21221b685124d4b99
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-24 13:02:10 +00:00
whoami-rajat
4710cbeca6 Add test for creating volume from source
This patch adds a test to create a new volume from source.
We also include code changes to pass the right size i.e. either
size passed by the user via --size argument or the source volume
size. This case is already handled at the API layer[1] but it
helps being consistent with passing the right size value as in case
of creating a volume from snapshot or backup.

[1] 7c1a5ce7b1/cinder/api/v3/volumes.py (L381-L382)

Change-Id: Idc71636dad6bb678fe24f19b0836d2e9bd92d7d2
2022-11-23 14:20:06 +05:30
whoami-rajat
96162c24ea Change --size helptext to include backup
Followup from [1]. Modifying help text of --size
argument to include --backup option.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/864893

Change-Id: I12cf60079ebcfe1cd059602fbfc1a13c8fe86803
2022-11-22 21:20:19 +05:30
whoami-rajat
bd0727c4f8 Add option to create volume from backup
Support for creating a volume from backup was added in
microversio 3.47. This patch adds a --backup option
to the volume create command to add that support.

Change-Id: Ib26d2d335475d9aacbf77c0fd7b7cda2ba743943
2022-11-21 20:30:09 +05:30
Zuul
56b0f6de0e Merge "image: Add 'image stage' command" 2022-11-16 12:38:10 +00:00
Zuul
222ea8def2 Merge "image: Simplify handling of data provided via stdin" 2022-11-16 12:37:58 +00:00
Zuul
a2706f5a80 Merge "image: Ignore '--progress' if providing image data from stdin" 2022-11-16 12:27:47 +00:00
Zuul
e708ddc2a3 Merge "Moved hypervisor to the SDK" 2022-11-16 11:18:32 +00:00
Zuul
06afa9b8cf Merge "Use the compute SDK in usage commands" 2022-11-16 09:46:59 +00:00
Zuul
d09aef5a01 Merge "compute: Add missing microversion check for networks" 2022-11-16 09:43:55 +00:00
Zuul
16f18d4a80 Merge "compute: Fix '--network none/auto' handling" 2022-11-16 09:20:21 +00:00
Jadon Naas
348eb79632 Docstring fix for CreateVolumeAttachment class
The command "volume attachment create" has a typo in the docstring.
The docstring says to use "server add volume", but the command is
actually "server volume add". This
change fixes the typo in the docstring.

Task: 46781
Story: 2010401
Change-Id: Ie19a24ead100dd9177669653a7a9997772ef4538
2022-11-10 11:51:18 -05:00
Zuul
50015b9608 Merge "tests: Convert more functional tests to use 'parse_output'" 2022-11-10 13:10:21 +00:00
Zuul
d5b6f5a183 Merge "tests: Move json decoding to base test class" 2022-11-10 13:00:50 +00:00
Violet Kurtz
006e35509d Moved hypervisor to the SDK
Change-Id: Ie955fb4d27c30e044626732a1f3e0f141cb85aa5
2022-11-09 19:33:54 +00:00
Stephen Finucane
4eea3408dc image: Add 'image import' command
Note that we require some additional functionality in SDK for this to
work properly, but it's a start.

Change-Id: I87f94db6cced67f36f71685e791416f9eed16bd0
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-09 16:51:54 +00:00
Stephen Finucane
1fb8d1f48b image: Add 'image stage' command
This is the equivalent of the 'image-stage' glanceclient command.

Change-Id: I10b01ef145740a2f7ffe5a8c7ce0296df0ece0bd
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-09 16:51:54 +00:00
Stephen Finucane
3d9a9df935 image: Simplify handling of data provided via stdin
This was unnecessarily complex.

Change-Id: I8289d5ce7356d8bc89425590a7f71bca91a6d396
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-09 16:51:54 +00:00
Stephen Finucane
bafece762a image: Ignore '--progress' if providing image data from stdin
You can provide data via stdin when creating an image. Using this with
'--progress' makes no sense and causes an error currently. Fix this.

Change-Id: I3c2d658b72a7c62931b779b0d19bb97f60a0c655
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-09 16:51:54 +00:00
Maksim Malchuk
b7d01833d0 Add baremetal agent type list filtering
This change adds and ability to filter out the baremetal nodes in
'network agent list' command.

Related-Story: 2008590
Related-Task: 41746
Related-Bug: #1658964
Change-Id: I01ffbd82662abbc1c2f56eb8f1e700f392bc063c
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2022-11-09 17:38:06 +03:00
Zuul
31881c0b2b Merge "zuul: Remove nova-network tests" 2022-11-08 19:48:42 +00:00
Stephen Finucane
38e39b6dc1 tests: Convert more functional tests to use 'parse_output'
Change-Id: I1d968181eb196c6df4583c772c67ed58bc7ba585
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-08 16:39:05 +00:00
Stephen Finucane
a244bb84e0 tests: Move json decoding to base test class
We do this everywhere. Add a simple knob to simplify the pattern. Only
one use is migrated initially. The rest will be done separately.

Change-Id: Ic3b8958bd4fb1459a8ac3adaff216c2a26628491
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-08 16:39:02 +00:00
Stephen Finucane
ffb69116b3 compute: Add missing microversion check for networks
The 'auto' and 'none' network allocation policies are only supported on
compute API microversion 2.37 or later. Enforce this in the code.

Change-Id: I90f8fb1e61ead4bd406ea76bbeb731b913805b13
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2010385
Task: 46657
2022-11-08 11:28:31 +00:00
Stephen Finucane
ed0d568b94 compute: Fix '--network none/auto' handling
This should lookup a network called 'none' or 'auto', not do the
equivalent on '--nic none' or '--nic auto'. Correct this.

Change-Id: I3c5acc49bfe8162d8fb6110603da56d56090b78f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2010385
Task: 46658
2022-11-08 11:25:19 +00:00
Zuul
681934a96a Merge "compute: Add '--no-network', '--auto-network' flags" 2022-11-08 10:48:36 +00:00
Stephen Finucane
1d71479a4c zuul: Remove nova-network tests
nova-network has been removed from nova for a very long time now and
we've no way to test it in CI save for installing old versions of
OpenStack. We don't care about this enough to do that, so just remove
the thing.

In the vein of things that have been removed, we also remove
configuration that was supposed to enable cinder's v1 API but doesn't
since the related knob was removed over 5 years ago [1].

[1] 3e91de956e

Change-Id: I76efeccec04937c3a68108e2654872e00fadcec4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-11-08 10:20:30 +00:00
melanie witt
d7aa53b9a2 Add note about microversion 2.87 in server rescue help
The ability to rescue a volume-backed server was added in compute
microversion 2.87 [1].

This adds a note to the command help to improve user experience.

[1] https://docs.openstack.org/nova/latest/user/rescue.html

Change-Id: I5f40c3ca28e13bd1f979bc5f8c337302a3b9a5be
2022-11-07 22:54:55 +00:00
Zuul
70de31755d Merge "Run swift in -tips job" 2022-11-07 22:53:03 +00:00
Zuul
837cbfbcdb Merge "quota: Deprecate "force" behavior for network quotas" 2022-11-05 09:24:51 +00:00
Zuul
b0b47472d8 Merge "quota: Fix issues with delete quota command" 2022-11-05 09:24:49 +00:00
Zuul
ae5f20c1ab Merge "tests: Remove unnecessary nesting of volume resources" 2022-11-05 09:10:14 +00:00
Zuul
495e7fa907 Merge "tests: Remove duplicate FakeImagev1Client" 2022-11-05 09:10:11 +00:00
Zuul
841c54229d Merge "tests: Move fake clients to top of file" 2022-11-05 09:09:23 +00:00
Zuul
c458ad4692 Merge "quota: Trivial style fixups" 2022-11-05 09:09:21 +00:00
Zuul
6898bc0ae3 Merge "quota: Deprecate 'quota show --class', 'quota set --class' arguments" 2022-11-05 09:09:19 +00:00
Zuul
1e37c12b16 Merge "quota: Allow showing project-specific quotas" 2022-11-05 09:09:16 +00:00
Stephen Finucane
a7975c4200 compute: Add '--no-network', '--auto-network' flags
These are aliases for '--nic none' and '--nic auto', respectively.

Change-Id: I7b4f7e5c3769a813bd8b2b9cd6090c6fe501e13d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-10-26 17:12:57 +03:00
Artom Lifshitz
e76609650f Improve server dump create helptext
The `server dump create` command instructs Nova to trigger a crash
dump in the guest OS. Assuming the guest supports this, the resulting
dump file will be located in the guest, in a location dependent on the
guest OS. Explain all that in the helptext.

Story: 2010384

Change-Id: If940ed5cce6c5ab4193ab1494738149370da9aad
2022-10-26 09:50:44 -04:00
Zuul
a03b2352d9 Merge "Added "openstack image metadefs namespace list" command" 2022-10-26 11:31:12 +00:00
Zuul
27479104e7 Merge "volume: Volume names are optional" 2022-10-26 10:11:28 +00:00
Areg Grigoryan
a726d84f4b Added "openstack image metadefs namespace list" command
Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612
2022-10-26 12:26:10 +03:00
Daniel Wilson
ce4cbeab67 Use the compute SDK in usage commands
Update usage list and usage show to use the compute component of the
OpenStack SDK instead of directly using the nova interface.

Change-Id: I1c4d2247c9c1a577ed9efad7e8332e7c9b974ad5
2022-10-25 22:51:48 -04:00
Zuul
ccd9356550 Merge "quota: Add 'quota show --usage' option" 2022-10-12 11:22:09 +00:00
Zuul
351b2b1074 Merge "quota: Simplify logic used to list, show quotas" 2022-10-12 11:14:20 +00:00
Stephen Finucane
09ff9a0f4c quota: Deprecate "force" behavior for network quotas
In change Idc1b99492d609eb699d0a6bef6cd760458a774f6, we added a
'--check-limit' option to enable "no force" behavior for network quotas.
This was already the default for compute quotas. Provide a path for
harmonizing the behavior of the two options by instead using a
'--no-force' option which will become the eventual default for the
network quotas also.

Change-Id: I25828a3d68e2e900f498e17a0d01fb70be77548e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-10-11 16:52:08 +01:00
Stephen Finucane
2da4aa99aa quota: Fix issues with delete quota command
We were passing a project object rather than just the ID. Also correct a
typo in the call to delete network quotas.

Change-Id: I2292db7932ec01026f0e54014e3d02218792617a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-10-11 16:41:28 +01:00
Zuul
8be0c641e1 Merge "quota: Add support for detailed volume quotas" 2022-10-07 17:05:55 +00:00
Zuul
eac38feef0 Merge "quota: Add 'quota delete' command" 2022-10-07 16:37:20 +00:00
Zuul
7d67a0be7f Merge "doc: Update cinder command mapping" 2022-10-07 16:32:15 +00:00
Zuul
71ef203cc6 Merge "Remove invalid note from requirements files" 2022-10-05 17:08:23 +00:00
Zuul
03051ce697 Merge "Bump python-novaclient version" 2022-10-05 17:08:21 +00:00
Zuul
f1cb66a476 Merge "Fix server evacuate command" 2022-09-30 13:12:07 +00:00
Zuul
adac63efe1 Merge "Speed up standard flavor list command" 2022-09-30 13:12:00 +00:00
Zuul
ec43d63182 Merge "docs: Add missing command mappings" 2022-09-30 12:31:55 +00:00
Zuul
bd4e67452e Merge "compute: Only retrieve necessary images" 2022-09-30 12:31:53 +00:00
Zuul
36f58c2ad7 Merge "Add authorization_ttl for identity providers" 2022-09-30 12:31:51 +00:00
Zuul
5826802793 Merge "Fix wrong assertion methods" 2022-09-30 12:23:19 +00:00
Zuul
cd27f0dd48 Merge "Improve help text for network create --external" 2022-09-30 12:23:17 +00:00
Zuul
26946d5670 Merge "Add trustor and trustee filtering to trusts list" 2022-09-30 12:23:14 +00:00
Zuul
5043626c80 Merge "config: Also mask non-prefix config" 2022-09-30 12:10:36 +00:00
Zuul
38dda16639 Merge "network: Add tenant project filter for RBAC list" 2022-09-30 12:10:29 +00:00
Zuul
db3610b533 Merge "remove unicode prefix from code" 2022-09-30 12:01:24 +00:00
Zuul
c7bb7f806c Merge "Fix missing closing brackets in metavar" 2022-09-30 12:01:22 +00:00
Zuul
217654e16c Merge "Replace assertItemsEqual with assertCountEqual" 2022-09-30 12:01:19 +00:00
Zuul
46ead4abea Merge "image: Add 'image task list' command" 2022-09-30 11:59:21 +00:00
Zuul
97af1b661e Merge "image: Add 'image task show' commands" 2022-09-30 11:59:18 +00:00
Stephen Finucane
1aaaa6f1d1 tests: Remove unnecessary nesting of volume resources
Change-Id: I210ce7534d161e89115e5cb96e42ab7f27170aa1
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 11:42:07 +00:00
Stephen Finucane
d7f431be50 tests: Remove duplicate FakeImagev1Client
I guess this was defined to avoid a circular import. There are easier
ways to do this.

Change-Id: Iab215a53691298413ea9d10def792008ab9edbce
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 11:41:57 +00:00
Stephen Finucane
e2940eea18 tests: Move fake clients to top of file
These are important and they're easier to identify at the top of the
file than nested deep inside.

Change-Id: I1569c855fadfe4cdacf83ee07d08922bf3edefbc
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 11:41:48 +00:00
Stephen Finucane
1ff839da76 quota: Trivial style fixups
Change-Id: I4522b54676033dced2b47477238ceb551e11d04a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 12:40:18 +01:00
Stephen Finucane
b62021260c quota: Deprecate 'quota show --class', 'quota set --class' arguments
This doesn't do anything special in nova and cinder and is not supported
in neutron. For the 'quota show' command, people should use the
'--default' argument instead.

Change-Id: I0dd38e5cb252a01d5817ed168be040b21b35e348
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 12:40:18 +01:00
Stephen Finucane
00e7019022 quota: Allow showing project-specific quotas
Add '--compute', '--network' and '--volume' options to the 'quota show'
command, along with a default '--all' option, allowing us to restrict
quotas shown to an individual service.

Change-Id: I122b765df01887b8d916ee6567ffb7768fcb4392
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 12:40:18 +01:00
Stephen Finucane
04e68e0d5a quota: Add 'quota show --usage' option
Provide an more sane way to get usage information for a particular
project's quotas. This requires using the 'Lister' command type since
the 'ShowOne' command type only allows for simple key-value pair output.

We also add a note indicating that the '<project>' argument is optional.

Change-Id: Ic7342cf08f024cc690049414c5eef5b9a7594677
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 12:40:15 +01:00
Stephen Finucane
47e667e71d quota: Simplify logic used to list, show quotas
This is prep work for some changes we're introducing in a later change.

Change-Id: I27a59bc1d57e6815fb166fb99ea2af88f08b68a9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 12:33:29 +01:00
Pavlo Shchelokovskyy
4592d2c78f Fix server evacuate command
I don't think it has ever worked in fact..

The server.evacuate() in novaclient returns not a Server() instance,
but a TupleWithMeta() object, that has no .to_dict() method [0]
used in _prep_server_detail() function.

[0] https://review.opendev.org/c/openstack/python-novaclient/+/276639

Change-Id: I22f9ac072eb1b0bfd1263a256e9bea4500c03290
Story: 2010204
Task: 45928
2022-09-30 11:04:45 +00:00
Pavlo Shchelokovskyy
ec8dba29f9 Speed up standard flavor list command
currently this command tries to fetch extra_specs for any flavor
that does not have them (which is quite usual), regardless if the
command was even asked to display them (--long) at all.
This significantly slows down this command as it makes a lot of
unnecessary REST calls, one per each flavor to fetch extra_specs for.

With this patch, client only attempts to fetch flavor extra_specs if
the user actually called the client with --long.

Change-Id: Ia36414d891a41b641d7a9a04f0a1e7d43cfee351
Story: 2010343
Task: 46484
2022-09-30 11:53:00 +01:00
Stephen Finucane
44443f7856 quota: Add support for detailed volume quotas
We were stating that this was not supported. That is not true. Correct
the oversight.

Change-Id: Ib9d9db641a18e142be0a1eccff783e7cccdf2db5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 10:55:47 +01:00
Stephen Finucane
45bec041b2 quota: Add 'quota delete' command
We had previously indicated that people use 'quota set' for unsetting a
project's quotas, however, there was nothing that actually allowed us to
do this. Correct that oversight.

Change-Id: I04057e766b8ccf94bf219972249b68dc2bb796d4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 10:54:11 +01:00
Stephen Finucane
bfdf900d0a doc: Update cinder command mapping
I had incorrectly marked the 'api-version' command as WONTFIX. Turns out
we already support this, albeit via keystone as opposed to a
cinder-specific API.

Change-Id: I804ef1ca5a0f4df844d8c2229688c4edbac45aa9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-30 10:53:31 +01:00
Bence Romsics
390f8135bd Improve help text for network create --external
Change-Id: Ie802fbb8a35e53dcb79b5581f64caa2db1609480
Closes-Bug: #1990285
2022-09-26 12:40:08 +02:00
OpenStack Release Bot
00d8d945a1 Switch to 2023.1 Python3 unit tests and generic template name
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for antelope. Also,
updating the template name to generic one.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Ie3677749177a32507007833717b9bc484ce2c493
2022-09-23 14:15:54 +00:00
OpenStack Release Bot
1b0d2dde13 Update master for stable/zed
Add file to the reno documentation build to show release notes for
stable/zed.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.

Sem-Ver: feature
Change-Id: Ie570af5ce752d91190ebf6aa3c5ff2329afa36d3
2022-09-23 14:15:52 +00:00
Takashi Natsume
ff273909da Fix wrong assertion methods
Change-Id: Iebf4840662e87e59a06b56f1b5248728cba03c24
Story: 2010288
Task: 46261
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
2022-09-23 10:49:43 +00:00
Stephen Finucane
c9d445fc4b image: Add 'image task list' command
This replaces the 'glance task-list' command.

  $ openstack image task list

We also indicate that the 'image task create' command will never be
implemented. This is an admin-only API that isn't really intended to be
used by humans thus it does not need an OSC command implementation.

Change-Id: Id8a943a5443782fc70c0fbf3639f5aa17b9d30af
2022-09-21 10:43:35 +01:00
lsmman
d163a20904 image: Add 'image task show' commands
This replaces and the 'glance task-show' command. For example:

  $ image task show <TASK_ID>

Change-Id: I74cb23e436c373fe238804b903bbeb28f643d5af
2022-09-21 10:34:15 +01:00
Dr. Jens Harbott
28ac0141b5 Run swift in -tips job
Since there is only py3 left, swift has learned to live with it, so we
might as well test it.

Change-Id: Iab5232858e4a67e356680d169a885875d574c3cc
2022-09-20 20:20:11 +02:00
Takashi Natsume
7e5b528e2e Replace assertItemsEqual with assertCountEqual
The assertItemsEqual were replaced with assertCountEqual in
I0bbffbec8889b8b3067cfe17d258f5cb16624f38.
However the following changes add assertItemsEqual after that.

* I1095100efb27b8559412469f0a9d07fc0a3db9d5
* Ic230c2c5cda8255d8f2c422880aeac81670b2df3
* Ica3320242a38901c1180b2b29109c9474366fde0

So Replace assertItemsEqual with assertCountEqual again.

Change-Id: I11ff1748225e434f64dbaf7b88dc80ba28a5e2a0
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
2022-09-19 01:14:50 +00:00
zeze
a9b9252da3 Adding missing command mapping in docs
nova command: version-list
openstack command: versions show --service compute

cinder command: version-list
openstack command: versions show --service block-storage

glance command: member-list
openstack command: image member list

Change-Id: I3c68dbd47dc92ed190ae9abaa90dfcddef072728
2022-09-16 01:28:46 +09:00
Stephen Finucane
3fc585332f volume: Volume names are optional
Who knew?

Change-Id: I1c1a811c0db59250e8a20a87f25c2662bc3ab3e8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-09-14 13:44:02 +01:00
whoami-rajat
4024bdb393 compute: Add support for microversion 2.93
Add '--reimage-boot-volume' and '--no-reimage-boot-volume parameters'
to the rebuild command to allow rebuilding of volume backed instances.

Change-Id: I4a6e30b2cf12f32202a2d9ef1ced347e1dd139f3
2022-09-14 11:24:10 +01:00
whoami-rajat
1f63034441 compute: Require image when rebuilding a volume-backed server
A volume-backed server will have no image attribute (or rather the image
property will be set to the empty string). As such, if you want to try
rebuild you will need to specify an image [*]. Enforce this.

[*] Before microversion 2.93, this must be the same image. However, we
don't touch on that here. This will be addressed later.

Change-Id: I6842dabd7acb4e3a78f894e55e616625757eb6a4
Story: 2010297
Task: 46290
2022-09-14 11:22:43 +01:00
elajkat
c6065c7a47 Add address-scope to NDP proxy tests
Related-Bug: #1987410
Change-Id: I61df81381803ca289f295ab8d7a8f495bb169447
2022-09-09 09:18:36 +02:00
Jan Hartkopf
4d7d7e627e network: Add tenant project filter for RBAC list
Implements a new parser argument "--target-project" to
list RBAC policies for a specific tenant project only.
This uses the already existing server-side query
parameter "target_tenant".

Story: 2009937
Task: 44824
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/834442
Change-Id: I83ff07041a022e8795e3c5550c6a7aabb0c0d8c8
Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de>
2022-09-06 14:13:10 +02:00
Zuul
7df94c9f82 Merge "Microversion 2.91: Support specifying destination host to unshelve" 2022-09-01 18:15:52 +00:00
Zuul
5cf8f37a93 Merge "Fix documents for replaced configuration name" 2022-08-31 02:34:31 +00:00
Yang JianFeng
b36cd0f4c0 Add router ndp proxy commands
Depends-on: https://review.opendev.org/749036
Change-Id: I77e12cc2dfe4000bd5ae6511878c6591f52d9791
Related-Bug: #1877301
2022-08-26 08:15:43 +08:00
Takashi Kajinami
2093a5b681 Fix missing closing brackets in metavar
... to display the complete format in --help output.

Change-Id: I4d0f044072b206f6205b4b4f4992fd08f01729d6
2022-08-26 01:07:04 +09:00
Stephen Finucane
8b0e467355 Remove invalid note from requirements files
This isn't true with the new dependency resolver introduced in pip 20.3.

Change-Id: Ie28fe625663c960fbffa12efb1503b8c9f8c0581
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-08-24 11:03:52 +01:00
Stephen Finucane
84003aa6fe Bump python-novaclient version
The recently added support for nova API microversions 2.91 and 2.92
necessitate a newer version of python-novaclient. Make it so.

Change-Id: I40a77334e4aee2e196062c38a0bb70f8f3079b44
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-08-24 11:03:47 +01:00
René Ribaud
6e0699c1cf Microversion 2.91: Support specifying destination host to unshelve
This patch adds a new parameter ``--host`` to
``openstack server unshelve`` command. This can help administrators to specify
an ``host`` to unshelve a shelve offloaded server.
And add new parameter ``--no-availability-zone`` to unpin a server availability

These parameters are available in the 2.91 microversion.

Depends-On: https://review.opendev.org/c/openstack/python-novaclient/+/831651
Implements: blueprint unshelve-to-host
Change-Id: I7986adc7563f63bcd4b3caf5eb7bc4329b4e1eca
2022-08-22 15:03:24 +02:00
niuke
dd648dcb5c remove unicode prefix from code
Change-Id: I0b1ca4237de61b70c694f36e1956e71a2a6b39a4
2022-08-15 12:20:20 +08:00
Zuul
27b2496e03 Merge "Migrate server_groups to the new API" 2022-08-09 17:33:39 +00:00
Snow Kim
701dd67d6c Fix documents for replaced configuration name
Since 4.0, '--os-url' global option is no longer supported.
And this option had been replaced to '--os-endpoint'

- Refer Change-Id: I1b9fbb96e447889a41b705324725a2ffc8ecfd9f
- Refer Docs: doc/source/cli/backwards-incompatible.rs

I fixed in documents as below
- OPTIONS: '--os-url' to '--os-endpoint'
- ENVIRONMENT VARIABLES: 'OS_URL' to 'OS_ENDPOINT'
- and relevant sentence

Change-Id: Ibb0cddf34375df941678ee07a005d81399ec7195
2022-08-05 19:51:32 +09:00
Violet Kurtz
a9f8133274 Migrate server_groups to the new API
Moved the server_groups to the new API.

Change-Id: Ied7bd6f56e277f0c5efcd5ba028765f9be65050f
2022-08-02 20:39:19 +00:00
ryanKor
62c52f5e61 config: Also mask non-prefix config
The 'config show' command will show information about your current
configuration. When using a 'cloud.yaml' file and the 'OS_CLOUD'
environment variable, the output of this will look like so:

  $ openstack config show
  +---------------------------------------------+----------------------------------+
  | Field                                       | Value                            |
  +---------------------------------------------+----------------------------------+
  | additional_user_agent                       | [('osc-lib', '2.6.0')]           |
  | api_timeout                                 | None                             |
  | auth.auth_url                               | https://example.com:13000        |
  | auth.password                               | <redacted>                       |
  | auth.project_domain_id                      | default                          |
  | auth.project_id                             | c73b7097d07c46f78eb4b4dcfbac5ca8 |
  | auth.project_name                           | test-project                     |
  | auth.user_domain_name                       | example.com                      |
  | auth.username                               | john-doe                         |
  ...

All of the 'auth.'-prefixed values are extracted from the corresponding
entry in the 'clouds.yaml' file. You'll note that the 'auth.password'
value is not shown. Instead, it is masked and replaced with
'<redacted>'.

However, a 'clouds.yaml' file is not the only way to configure these
tools. You can also use old school environment variables. By using an
openrc file from Horizon (or the clouds2env tool [1]), we will set
various 'OS_'-prefixed environment variables. When you use the 'config
show' command with these environment variables set, we will see all of
these values appear in the output *without* an 'auth.' prefix. Scanning
down we will see the password value is not redacted.

  $ openstack config show
  +---------------------------------------------+----------------------------------+
  | Field                                       | Value                            |
  +---------------------------------------------+----------------------------------+
  | additional_user_agent                       | [('osc-lib', '2.6.0')]           |
  | api_timeout                                 | None                             |
  ...
  | password                                    | secret-password                  |
  ...

This will also happen if using tokens. This is obviously incorrect.
These should be masked also. Make it so. This involves enhancing our
fake config generation code to generate config that looks like it came
from environment variables.

Change-Id: I560b928e5e6bcdcd89c409e0678dfc0d0b056c0e
Story: 2008816
Task: 42260
2022-08-01 19:54:44 +09:00
Yoonsoo Lim
e6adf37d12 Update the Nova CLI Mapping Guide
Update missing command in Mapping Guide.

List of updated command
[Nova CLI / OSC]
instance-action-list / server event list

Change-Id: I1436a6c1bdd881890e015cf0f1829c38378b36fa
2022-07-31 14:20:22 +09:00
Zuul
60dd6e6257 Merge "Drop support for Python 3.6, 3.7" 2022-07-27 11:45:06 +00:00
Zuul
b3ae3f5552 Merge "Add support for CRUD operations for QoS minimum packet rate rule" 2022-07-20 14:13:42 +00:00
Pavlo Shchelokovskyy
167cf11e82 Add authorization_ttl for identity providers
this is supported since Ussuri (Keystone API version 3.14) but was
lacking from openstackclient.

Change-Id: Ifac818b9a4eff66d9a68455ada1ddfe67cb46b3b
2022-07-13 22:28:07 +03:00
Pedro Martins
bced4852c7 Add port ranges on floating ip portforwardings cli
This patch is one of a series of patches
to implement floating ip port forwarding with
port ranges.

The specification is defined in:
https://github.com/openstack/neutron-specs/blob/master/specs/wallaby/port-forwarding-port-ranges.rst

Change-Id: If9679c87fd8b770fcd960048e091ee8d59205285
Implements: blueprint floatingips-portforwarding-ranges
Related-Bug: #1885921
2022-07-13 16:24:15 -03:00
Stephen Finucane
722d3216a4 docs: Add missing command mappings
The 'neutron tag-replace' command is equivalent to the 'openstack
network set --no-tag --tag <tag> [--tag <tag> ...]' command. '--no-tag'
will unset all tags while '--tag <tag>' will set a new tag and can be
specified multiple times.

The 'nova hypervisor-uptime' command is equivalent to the 'openstack
hypervisor show' command. Before compute microversion 2.88, the nova
command was using a different API that returned an almost identical
output to 'nova hypervisor-show' except it included an 'uptime' field.
Since 2.88, this field is returned in the standard call. OSC abstracts
this detail away so the 'uptime' field is always present, removing the
need for a separate command.

The 'nova migration-list' command is implemented as 'openstack server
migration list' (simply omit the '--server' filter).

The 'nova volume-update' command is implemented as 'openstack server
volume update'.

The 'nova volume-attachments' command is actually available as
'openstack server volume list', though you can also use 'server show'.

The 'nova aggregate-cache-images' corresponds to an internal API that
only glance should be using. It doesn't need to be exposed via
openstackclient.

Change-Id: Icdbc42762230954f6f7f2064b6228416af41d45a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-07-07 13:47:53 +01:00
likui
4e769f0ed0 Drop support for Python 3.6, 3.7
Python 3.6 and Python 3.7 support has been dropped since Zed [1]. This
necessitates changes our jobs to build and publish docker images since
those currently use Python 3.6. We now use Python 3.9.

[1] https://governance.openstack.org/tc/reference/runtimes/zed.html

Change-Id: I228b7ff6691a025f1ba9b7d9449f294868942151
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
2022-07-04 17:48:55 +01:00
Stephen Finucane
e49ad1795b pre-commit: Allow unsafe YAML
We're using tags in '.zuul.yaml', which requires use of the unsafe
parser [1].

[1] https://stackoverflow.com/a/45967047

Change-Id: Ib97480f6fcaba7406ffe284e1935744346684b8b
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-07-04 12:16:16 +01:00
Zuul
366e164738 Merge "Stop testing lower-constraints" 2022-07-01 18:01:08 +00:00
Przemyslaw Szczerbik
6ccbcdde64 Add support for CRUD operations for QoS minimum packet rate rule
Closes-Bug: #1922237
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/810364
See-Also: https://review.opendev.org/785236
Change-Id: Ie7e1eb0575fd37121d5097ecbc318d0769ab3db0
2022-07-01 13:55:41 +00:00
Stephen Finucane
14b93fec76 image: Split image creation depending on service
The 'image create' operation is actually one of two operations: it can
be either an image service (glance) operation if the '--volume' argument
is *not* passed or a block storage (cinder) operation if it is. Make
this clearer and add a log warning users about options that are
supported by the former but not the latter.

Change-Id: Id153c951a7d18403568bf67e13d5e0a4827428d4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-06-30 11:54:45 +01:00
Stephen Finucane
4776e0a5ae image: Make better use of argparse
Simplify some logic by using a common 'dest' for mutually exclusive
options.

Change-Id: Ie5f3600672953f40be52de51e84717c8912ddaf8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-06-30 11:51:33 +01:00
whoami-rajat
9eea28ba59 Fix: create image from volume command
Currently the command ``openstack image create --volume`` calls cinderclient
to upload the volume to image service (glance) but OSC passes ``visibility``
and ``protected`` fields which are only available in microversion 3.1 or
greater. This generates an error if the user is using volume microversion
< 3.1 and wants to create an image from volume.
This patch fixes that by only passing ``visibility`` and ``protected`` fields
when the volume microversion is 3.1 or greater and fail otherwise i.e. the
following 3 cases:
1) visibility/protected argument + mv >= 3.1 = pass
2) visibility/protected argument + mv < 3.1 = fail
3) not visibility/protected argument + any mv = pass

Story: 2010060
Task: 45511
Change-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc
2022-06-30 11:15:33 +01:00
Stephen Finucane
2290b38ab3 image: Trivial style changes
Change-Id: I35b7b8a80609916eb47357af4398789788d66382
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-06-30 11:15:33 +01:00
Zuul
20e7b01af8 Merge "Skip test_quota_network_set_with_force func test" 2022-06-28 09:51:10 +00:00
Dr. Jens Harbott
c6e8648786 Skip test_quota_network_set_with_force func test
This test was added in [0] and it causes a lot of failures, since
setting the network quota to 1 will result in quota errors for any other
test that is trying to create a network in parallel. We can only run
this test in a serial tempest task that would need to be created for
such a scenario.

Related-Story: 2010110
Change-Id: I6015c181ecabff26bdb1b0c11b0e33ad39e6f083
2022-06-28 06:56:14 +02:00
Zuul
30622272e3 Merge "volume: Correct output of 'volume attachment create'" 2022-06-27 15:54:20 +00:00
Dr. Jens Harbott
604ceeedf9 Don't show tenant_id in network objects
Patch [0] dropped mapping the tenant_id attribute to project_id.
However, the Neutron API still returns the tenant_id attribute in
addition to the project_id and so we still need to discard it from
the output.

[0] I5f62f2a76592eaaaed6703624e959df41a6ecc8f

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: Iba1e003bf587802f28928cb44d160b3b3fb1f840
2022-06-27 10:50:03 +02:00
Zuul
4f79def9aa Merge "Allow users to list all images" 2022-06-20 15:19:59 +00:00
Zuul
ec95b58482 Merge "Refactor "volume backup restore" command" 2022-06-20 15:19:56 +00:00
Zuul
15608a2696 Merge "Add more filter option of columns for server list -c COLUMN" 2022-06-20 15:19:49 +00:00
Cyril Roelandt
34d1e0c7eb Allow users to list all images
Add a "--all" option to "openstack image list", which allows the user to
list all of the images.

Story: 2010071
Change-Id: I56a2e4846d0380d07803305fb830d1a43dfd71b3
2022-06-07 20:22:34 +02:00
Zuul
ed304992eb Merge "Changed minversion in tox to 3.18.0" 2022-06-01 15:54:37 +00:00
Zuul
6810414e45 Merge "Migrate osc-tox-py3N-tips to Python 3.8" 2022-05-25 06:12:21 +00:00
Takashi Kajinami
8a03f3cabc Migrate osc-tox-py3N-tips to Python 3.8
python-novaclient 18.0.0 removed support for Python 3.6 and 3.7 and
can't be installed in Python 3.6.

This change migrates the osc-tox-py3N-tips from Python 3.6 to Python
3.8 as Python 3.8 is the minimum version currently supported.

This also adds Python 3.9 to supported runtime list because it has been
tested since stable/yoga.

NOTE:
The osc-tox-py36-tips job is used by cliff, so the subsequent patch
for the cliff repo should be merged timely.

Change-Id: Id7a8f3ca5b704102aa18eb6bf98ae9ada005d013
2022-05-24 09:02:16 +00:00
melanie witt
93578ef85b Add 'Host Status' to 'server list --long' with >= v2.16
Currently, the 'Host Status' field is shown only for 'server show' but
not for 'server list'. The host_status can be helpful for users who are
having issues with servers that show a status of ACTIVE, as it can show
a hint about the compute host status when nova policy is configured to
allow it.

Story: 2009689
Task: 44003

Change-Id: I6209cf52044218b7b32ab2fa5712574f12ba2f5f
2022-05-16 17:55:40 +00:00
Zuul
9fc9e8d9d7 Merge "Allow to filter multiple tags for image list" 2022-05-16 16:36:48 +00:00
Stephen Finucane
045f2e7e06 volume: Correct output of 'volume attachment create'
When adding these, we missed that the underlying cinder library call
actually returns a dictionary and not a Resource-based object. This
requires slightly different handling. Fix this.

Change-Id: Ie065fe4198ae1238830cb619220e856390d4cb6e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-05-16 12:47:39 +01:00
Zuul
ccd877dd40 Merge "Fix typos" 2022-05-16 09:36:14 +00:00
Dmitriy Rabotyagov
5cc6fc2b88 Allow to filter multiple tags for image list
Currently in case of passing `--tag` several times, only last one will
be picked up for the filtering. In the meanwhile Glance allow option to
be repeated multiple times to filter based on the multiple tags.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/789827
Change-Id: I7379d0b0014f0e3d13b02ee5ec6b642a7a5aa7d1
2022-05-16 09:16:52 +01:00
likui
c677192d51 Stop testing lower-constraints
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-October/018445.html

Change-Id: I45e9a81d451c64cdd51f9b606d94161742bacdb7
2022-05-14 11:02:12 +08:00
Zuul
4b97a85181 Merge "Refactor network fakes to sdk properties PART 4" 2022-05-13 16:30:47 +00:00
Zuul
9b399c5528 Merge "Stop using private _is_uuid_like method" 2022-05-13 16:30:44 +00:00
Zuul
644106a89c Merge "volume: Add 'block storage resource filter list' command" 2022-05-13 15:24:26 +00:00
Zuul
7fcfce486b Merge "volume: Add 'block storage cluster *' commands" 2022-05-13 14:13:07 +00:00
Zuul
4b14c400ff Merge "tests: Improve logging for executed commands" 2022-05-13 11:57:56 +00:00
Stephen Finucane
53a7e67b41 volume: Add 'block storage resource filter list' command
These are based on the 'cinder list-filters' command, which accepts an
optional '--resource {resource}' option to limit the listed filters to a
single resource type.

  block storage resource filter list
  block storage resource filter show

We used the 'block storage resource filter' terminology rather than
simply 'resource filter' to highlight the fact that this is specific to
the block storage service.

Note that while this feature is a bit weird, good documentation can be
found at [1].

[1] https://docs.openstack.org/cinder/latest/admin/generalized_filters.html

Change-Id: I21e7c0ea427aef1f6665394d4b8e9a1f30d6dbb1
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-05-13 12:42:16 +01:00
Stephen Finucane
d727a65023 volume: Add 'block storage cluster *' commands
These mirror the 'cinder cluster-*' commands, with arguments copied
across essentially verbatim. The only significant departure is the
replacement of "tenant" terminology with "project".

  block storage cluster list
  block storage cluster set
  block storage cluster show

We used the 'block storage' terminology rather than simply 'volume' to
allow us to start distinguishing between the volume service and a volume
resource.

Change-Id: I9105a9e4a139af4929e3b1f3a6de6c9a53e0b598
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-05-13 11:59:23 +01:00
Nurmatov Mamatisa
ccd84f8f2b Refactor network fakes to sdk properties PART 4
Included resources:
port
network_agent
network_flavor_profile
network_rbac

Change-Id: I2e71a3c0fefb56ddcc75865c95746550e2710aa3
2022-04-29 16:40:23 +03:00
Pavlo Shchelokovskyy
afc5f997c8 Stop using private _is_uuid_like method
currently this double-private method of a dependency library
is used in several places (openstack.cloud._utils._is_uuid_like)

openstacksdk deliberatly chose not to depend on oslo.utils to keep
dependenies to the minimum, so it just copied several methods from it,
including the is_uuid_like.

python-openstackclient however already depends on oslo.utils, so
using the public method from oslo.utils should be preferred
and more stable.

Change-Id: I578ffa36ffb00c9d47ee12a149313201973edd32
2022-04-20 17:42:02 +03:00
JIHOJU
10835a1886 Add more filter option of columns for server list -c COLUMN
In order to improve the convenient of use,
columns corresponding to the "--long" option has been added
so that it can be used in the filter.
Currently filterable columns include the following:
'ID', 'Name', 'Status', 'Networks', 'Image', 'Flavor'.

Story: 2009150
Task: 43113
Change-Id: I6760ca5da0e3707d1d746ae5eeec7d9162020d15
2022-04-19 11:17:03 +00:00
Stephen Finucane
725b7de13c compute: Only retrieve necessary images
The Glance API allows us to filter by multiple IDs using the 'in:'
operator. Take advantage of this to speed up listing of server in larger
deployments where image counts in the hundreds (or even thousands) are
not uncommon.

Unfortunately the Nova API does not support something similar for
listing flavors. Boo.

Change-Id: I7d3222d0b0b8bf72b4ff3e429bc49e621b569979
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/837613
2022-04-12 20:41:29 +01:00
Nicolas Belouin
64e4520b2a Add trustor and trustee filtering to trusts list
The keystone API supports filtering trusts by trustor and/or
trustee.

Also adds a shortcut parameter to get trusts with current
user as trustee or trustor.

Signed-off-by: Nicolas Belouin <nicolas.belouin@gandi.net>
Change-Id: I00ed2b68cf8ada214a59f640f4f0a5c9dbc37063
2022-04-12 06:26:18 +00:00
Zuul
dabaec5a7b Merge "volume: fix backup list of deleted volume" 2022-04-11 09:43:13 +00:00
Zuul
8f07476e53 Merge "volume list: don't fail when there's no compute service" 2022-03-24 21:29:04 +00:00
Zuul
fe165ef76f Merge "Refactor network fakes to sdk properties PART 3" 2022-03-24 11:31:02 +00:00
Zuul
7602451ab5 Merge "Refactor network fakes to sdk properties PART 2" 2022-03-23 17:00:17 +00:00
Zuul
65dad11108 Merge "Refactor network fakes to sdk properties PART 1" 2022-03-23 16:55:25 +00:00
Rodolfo Alonso Hernandez
1c6d396ba3 Allow "--force" flag in quota network commands
This flag allows to set a new Neutron quota resource limit without
checking first the current resource usage. The new limit will be
set anyway. This flag was used only by the compute engine.

Related-Bug: #1953170
Change-Id: I7084f8208b804236ac99e6842db7a45854ce54d7
2022-03-17 02:38:07 +00:00
Nurmatov Mamatisa
8efe863129 Refactor network fakes to sdk properties PART 3
Included resources:
network_flavor
network_segment
network_segment_range

Change-Id: If5ce0a07052d9dc0edb4f5f22806635b5bb6a523
2022-03-16 12:30:21 +03:00
Thobias Salazar Trevisan
e91e0e001c compute: Add 'Security Groups' for 'server list'
Add a column with security groups name for
--long option on server list.

Change-Id: I7062f224e18c3c8ac96a06d7ce97f9fab473bdb9
2022-03-15 08:56:59 -03:00
Nurmatov Mamatisa
6fe0ae497c Refactor network fakes to sdk properties PART 2
Included resources:
ip_availibility
network

Change-Id: I141bcb43272594da75e776a84a74158fc866ac94
2022-03-15 11:48:33 +03:00
Nurmatov Mamatisa
23ad68264b Refactor network fakes to sdk properties PART 1
Included resources:
address_group
address_scope
auto_allocated_topology
availability_zone

Change-Id: I943f988588efbe68dd3ab17a18441b25ac8c8d4d
2022-03-15 11:28:44 +03:00
Huanxuan Ao
de4a69a29f Refactor "volume backup restore" command
Make the positional argument "volume" optional and add a "--force"
option (volume v2 only) to the "volume backup restore" command.

Closes-Bug: #1597189
Change-Id: If944e10158bd18e8331be63e96187a23e23095d7
2022-03-10 12:04:11 +00:00
Stephen Finucane
c9b84106c3 compute: Move server migrations commands to their own file
The 'openstackclient.compute.v2.server' module is getting rather large.
The server migration commands don't need to be in there. Move them.

Change-Id: I8b2600cfd9f8e37d3093c52c7222d85e84e7fc89
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-03-09 17:32:30 +00:00
Stephen Finucane
cffec4517f compute: Allow retrieval of migration by UUID
The nova API doesn't allow you to retrieve migration records by UUID,
only ID. This is confusing. Work around it by listing records and
filtering this list.

Change-Id: I932c9c70420e85056509513e005bb78168e70611
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-03-09 17:31:44 +00:00
Zuul
8c975ba097 Merge "Fix 'server event list|show' for deleted servers" 2022-03-09 13:44:47 +00:00
Zuul
be1de891ac Merge "compute: Use correct command class for 'show migration'" 2022-03-09 13:44:29 +00:00
Zuul
91a963873f Merge "Fix metavars and typos in local_ip" 2022-03-09 13:44:26 +00:00
Jan Hartkopf
8acead32ee volume: fix backup list of deleted volume
When trying to list backups of a deleted volume with --volume,
openstackclient fails because the volume does not exist.
However, for listing a volume's backups, the volume itself
does not need to be present.

Fix this issue by allowing the volume of the requested backups
to not exist.

Story: 2009901
Task: 44716
Change-Id: Iea1a567151f427fa0e1ccff3af5cbeab620defcd
Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de>
2022-03-08 16:28:43 +01:00
OpenStack Release Bot
54b32a37d7 Add Python3 zed unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for zed.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Id79fecd4c4b16f2e5c3a5713be50327757346c1a
2022-03-08 12:49:48 +00:00
OpenStack Release Bot
15a7838c30 Update master for stable/yoga
Add file to the reno documentation build to show release notes for
stable/yoga.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/yoga.

Sem-Ver: feature
Change-Id: Ie1126dddd3666d3dc108190133df5e3b085a8404
2022-03-08 12:49:45 +00:00
Nurmatov Mamatisa
3e61824d4a Fix metavars and typos in local_ip
Change-Id: I2094f343e3353da25f9c5057ea5444345e271665
2022-03-02 12:52:14 +00:00
Zuul
63452f362d Merge "Add support for setting extra DHCP options on existing ports" 2022-02-25 13:26:11 +00:00
Zuul
bf71727c55 Merge "Add support for 'remote-managed' vnic type" 2022-02-23 07:55:28 +00:00
Slawek Kaplonski
47fa9ba356 Add support for setting extra DHCP options on existing ports
It is now possible to set extra DHCP option for an existing port using
"port set" command. It works in the same way like during port creation.

Story: 2009095
Task: 42927
Change-Id: I3577d4e3a303137b708ae8687c44b486aa82e296
2022-02-21 22:52:38 +01:00
Dr. Jens Harbott
077c9a77a2 volume list: don't fail when there's no compute service
There may be deployments that only have a volume service but no compute
service, possibly as an intermediate step during the initial setup.
Don't fail the "volume list" command when no compute client can be
initiated.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: Idef77bdc8753a456a4c431b0385318dff6581a65
2022-02-17 16:08:57 +01:00
melanie witt
72a2477ec0 Fix 'server event list|show' for deleted servers
As of compute microversion >= 2.21, support for list and show of server
events for deleted servers was added. This however wasn't working using
the openstackclient because the compute GET /servers/{server_id} will
not return a deleted server, so osc_lib.utils.find_resource() fails to
find the server and the command bails early.

This adds a check for a uuid-like <server> arg and uses it directly if
the <server> cannot be found via find_resource().

A note is also added to the command help to indicate that list and show
for deleted servers will only work if a server ID is passed (name will
not work).

Story: 2009841
Task: 44443

Change-Id: Icd33b3b9a3a1855d7893dd111bbb2aca059f45fd
2022-02-09 23:26:25 +00:00
Zuul
d876b41958 Merge "image: Sanity check the 'SetImage' command" 2022-02-09 21:00:49 +00:00
Zuul
811add8b58 Merge "tests: Update fake image client in tests" 2022-02-09 21:00:46 +00:00
Zuul
20500c6ac9 Merge "image: Remove FakeImage test helper" 2022-02-09 20:42:43 +00:00
Zuul
f7eaaa8408 Merge "docs: Document additional 'server migration' commands" 2022-02-09 20:42:40 +00:00
Zuul
b072118afc Merge "compute: Don't warn if disk overcommit params unset" 2022-02-09 20:42:33 +00:00
Zuul
27843fc232 Merge "Add missing command mapping in nova" 2022-02-09 12:50:18 +00:00
Zuul
5f73c527ee Merge "Support Neutron Local IP CRUD" 2022-02-09 12:50:15 +00:00
Stephen Finucane
9c5220c97b docs: Document additional 'server migration' commands
Only 'server migration list' was being documented.

Change-Id: I038ff2bcf7bb852d619004bb00306d2d388135a7
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-02-08 15:27:58 +00:00
Frode Nordahl
d565f11093
Add support for 'remote-managed' vnic type
The 'remote-managed' vnic type will be used to support off-path
SmartNIC port binding with OVN, and it is expected that the user
will create ports with this vnic type as part of the workflow.

As such the client must allow users to interact with this
vnic type and this patch addresses that.

Partial-Bug: #1932154
Depends-On: I496db96ea40da3bee5b81bcee1edc79e1f46b541
Change-Id: I566c3da594d757dd62edcf7f9ea3077db8d6b11a
2022-02-08 07:26:46 +01:00
Zuul
e000fd5f0d Merge "Add network update quota "limit_check" parameter" 2022-02-03 15:53:02 +00:00
Dr. Jens Harbott
746b91335c Don't fail on extlinks warnings for reno build
With Sphinx==4.4.0 some "helpful" warnings were introduced when an
external link could be replaced by a macro, like for :lpbug:. Sadly we
have a very high number of existing release notes that trigger these
warnings and no good way to fix them retrospectively, because would mess
up their mapping to releases. So we change the logging for the
sphinx.ext.extlinks to ignore these warnings for now.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I709de5e454434b8790a68d9e67ca1432387b21ab
2022-02-03 12:19:27 +01:00
Nurmatov Mamatisa
26144743d9 Support Neutron Local IP CRUD
Add support for Neutron Local IP CRUD operations.

Partial-Bug: #1930200
Depends-On: https://review.opendev.org/c/openstack/neutron/+/804523
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/804988
Change-Id: I1095100efb27b8559412469f0a9d07fc0a3db9d5
2022-01-28 17:24:04 +03:00
Zuul
f00dce9e2f Merge "Get rid of tenant_id in the network commands" 2022-01-17 17:39:20 +00:00
Zuul
7c7a30b3cd Merge "Skip original_name from flavor info" 2022-01-17 09:28:37 +00:00
Artem Goncharov
18dcd7c9f7 Get rid of tenant_id in the network commands
Finally drop tenant_id completely from the networking service.

Change-Id: I5f62f2a76592eaaaed6703624e959df41a6ecc8f
2022-01-17 09:31:16 +01:00
Ritvik Vinodkumar
b5a2714b83 Switch compute service list, delete and set to sdk.
Switch the compute service commands from novaclient to SDK.

Change-Id: I16498905101d6c2702a3ccbaf8cf5e3098d51992
2022-01-14 18:36:37 +00:00
Artem Goncharov
f461af0ac8 Skip original_name from flavor info
In the new SDK we are going to add additional parameter to the flavor
which make no use for OSC. Exclude it explicitly since it also cause
failing tests.

Change-Id: Ie35e60498cf18f05c878611df6f88607a04b1870
2022-01-14 17:37:59 +01:00
Zuul
0a887a4786 Merge "Add --security-group to port list" 2022-01-13 20:13:30 +00:00
Dr. Jens Harbott
f533dca520 Fix volume set functional test
Sometimes it can happen that when extending a volume it is shown as
status "extending" with the original size for a while. Wait for the
volume to enter state "available" again before checking the result.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: Ib70cfa1c241ce94426214c7a05c550213f427caa
2022-01-11 07:24:48 +01:00
Zuul
b79c0b6cfb Merge "Include hosts in aggregate list --long" 2021-12-25 10:54:27 +00:00
Zuul
eb139f6fe8 Merge "compute: Return information about fixed IP" 2021-12-25 10:54:24 +00:00
Zuul
9b49363c0d Merge "Switch add fixed IP to SDK" 2021-12-25 10:54:22 +00:00
Zuul
6a0187d47c Merge "compute: Pass through args to ssh" 2021-12-25 10:54:20 +00:00
Zuul
ba935590f4 Merge "compute: Fix weird option definition for 'server ssh'" 2021-12-25 10:54:18 +00:00
Dr. Jens Harbott
724852e66e Add location to fake network objects
Network objects returned from the SDK include a location column which
has a reference to the cloud to which the object belongs. Add this
column to our fake objects used for testing, so that we can make sure we
don't include them in CLI output where they are useless.

Change-Id: Ib09027af78e7bf2458cdc76ea9027faa3dbbfcf9
Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
2021-12-16 19:33:29 +00:00
Dr. Jens Harbott
90eb0ca4bb Hide location columns for network objects
Network objects returned from the SDK include a location column which
has a reference to the cloud to which the object belongs. We don't want
to include them in CLI output where they are useless.
The solution implemented in [0] was dropped as a sideeffect in [1].

[0] https://review.opendev.org/c/openstack/python-openstackclient/+/679445
[1] https://review.opendev.org/c/openstack/python-openstackclient/+/815032

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I9a408d9721c9c57d752afaab520cd6ee379a5184
2021-12-16 19:33:04 +00:00
Hugh Saunders
3a929611c0 compute: Pass through args to ssh
Why limit a user to preset ssh arguments? Capture them all and send
them along to ssh to deal with. This allows users to use the full range of
ssh arguments, including specifying a command to run on the
instance. For example:

  openstack server ssh -4 upg -- -l cirros -i ~/id_rsa_upg "date; uptime"

SSH arguments that openstackclient currently mirrors are deprecated
except for -4 and -6, as they are useful for retrieving the correct
instance IP.

Change-Id: Ia50786d5eee52688e180550fe16aeb8af610154b
Co-authored-by: Stephen Finucane <stephen@that.guru>
2021-12-15 17:41:58 +00:00
Stephen Finucane
ba69870d86 compute: Fix weird option definition for 'server ssh'
argparse allows you to specify multiple options for a given argument
when declaring the argument. For some reason, we weren't doing this for
the 'server ssh' command. There's no apparent reason for doing things
this way and it's been that way since the beginning (2013) so let's not
do that.

We also add unit tests since they were missing and should exist.

Change-Id: I67a9e6516d7057266210cd4083e9ddeb1cfaa5de
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-12-15 17:41:05 +00:00
Stephen Finucane
0cde82dcd8 compute: Return information about fixed IP
The compute API provides this information to us. We might as well use
it.

Change-Id: I5608fa80745975ce49712718452cfe296c0f64d2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-12-14 15:55:33 +00:00
Ritvik Vinodkumar
9971d7253e Switch add fixed IP to SDK
Switch the add fixed IP command from novaclient to SDK.

Change-Id: I4752ea7b4bfc17e04b8f46dbe9a68d938501a89e
2021-12-14 14:55:22 +00:00
Zuul
c10a4cd966 Merge "Allow unset port's host_id" 2021-12-13 10:26:18 +00:00
Stephen Finucane
b3cb85f112 tests: Improve logging for executed commands
We're seeing failures in a recently added tests,
'ServerTests.test_server_add_remove_volume' from
'openstackclient/tests/functional/compute/v2/test_server.py'. These
failures are likely the result of slow CI nodes, but we don't have
enough information in the CI logs to debug them. Starting logging the
various commands executed in tests so that we can see these logs if and
when tests fail.

Change-Id: I4584dc5e6343fe8c8544431a527d8c3c7e7b3c5b
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-12-09 17:23:32 +00:00
Dr. Jens Harbott
4e9b929842 Allow setting gateway when creating a router
These options are not only valid when modifying a router, but also when
one is created initially.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I3e12901f37cbd1639ac9dc9cc49b04114b80474c
2021-12-09 13:49:27 +00:00
Dr. Jens Harbott
32e18253fa Fix RemoveServerVolume
The nova API we're using to delete a server volume attachment needs to
be handed a volume, not a volume attachment.

Also make sure that we create an error if the volume isn't actually
attached to the server.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Co-authored-by: Stephen Finucane <sfinucan@redhat.com>
Change-Id: I12abd3787ea47acb4da282d00fdc1989405a0564
2021-12-08 17:59:27 +00:00
Rodolfo Alonso Hernandez
bef70397a3 Add network update quota "limit_check" parameter
This new parameter commands the Neutron server to first check the
resource usage before setting the new quota limit. If the resource
usage is below the new limit, the Neutron server will raise an
exception.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/806254
Depends-On: https://review.opendev.org/c/openstack/neutron/+/801470

Partial-Bug: #1936408
Change-Id: Idc1b99492d609eb699d0a6bef6cd760458a774f6
2021-12-07 17:49:26 +00:00
Rodolfo Alonso Hernandez
c8c4f76498 Add --security-group to port list
The neutron API supports filtering ports by security group.

Closes-Bug: #1405057

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/804979
Change-Id: I0f626882716c21ac200c1b929ea04664d21874d8
2021-12-02 11:12:47 +00:00
Zuul
9eb42403d3 Merge "compute: Show flavor in 'server list' with API >= 2.47" 2021-11-30 19:45:10 +00:00
Zuul
d9ad0b5d46 Merge "Switch openstack server remove port/network to using sdk" 2021-11-30 19:08:01 +00:00
Zuul
e02fd2ab18 Merge "Switch server suspend and server resume to SDK" 2021-11-30 19:07:58 +00:00
Zuul
cf02135b52 Merge "Switch server pause and server unpause to SDK" 2021-11-30 19:07:55 +00:00
Zuul
3456ee7031 Merge "compute: Reorder building of columns for 'server list'" 2021-11-30 19:07:53 +00:00
Khomesh Thakre
8e362402de compute: Show flavor in 'server list' with API >= 2.47
Fix the issue where the flavor name was empty in server list output.
This requires somewhat invasive unit test changes to reflect the changed
API response from the server, but this has the upside of meaning we
don't need new tests since what we have validates things.
Also drop the flavor ID column as it is removed from the compute API.

Change-Id: Ica3320242a38901c1180b2b29109c9474366fde0
Signed-off-by: Khomesh Thakre <khomeshthakre24@gmail.com>
Story: 2008257
Task: 41113
2021-11-30 16:52:37 +00:00
Stephen Finucane
4c3de28e83 compute: Reorder building of columns for 'server list'
This has no impact on the end result, but it should make fixing issues
introduced by API microversion 2.69 a little easier.

Change-Id: I7d70eac8aa1a6197ed05a49f071e6899ec219c03
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-30 09:34:38 -05:00
Zuul
1cd0d084f5 Merge "image: Remove dead test helper methods" 2021-11-29 21:54:49 +00:00
Thrivikram Mudunuri
ff96fea012
Switch server suspend and server resume to SDK
Switch the server suspend and server resume commands from novaclient to
SDK. Use the SDK versions of test fakes to support fake Server
resources.

Change-Id: Idd0b4f13fab0f238e42844a7d759538bbda24f68
2021-11-29 11:50:04 -05:00
Thrivikram Mudunuri
b515fe61b2
Switch server pause and server unpause to SDK
Switch the server pause and server unpause commands from novaclient to
SDK. Use the SDK versions of test fakes to support fake Server
resources.

Change-Id: Id626f06f3d7edd44b306b7fc7b9b00d04af09621
2021-11-29 11:47:58 -05:00
Diwei Zhu
f82afc7f37 Switch openstack server remove port/network to using sdk
Change-Id: I1540c1f52e9a107dba20eeea9dc323c5510fe2b1
2021-11-29 14:31:07 +00:00
Zuul
397688320d Merge "Switch server image create to SDK" 2021-11-29 13:38:51 +00:00
Slawek Kaplonski
f462933113 Allow unset port's host_id
It is supported by Neutron and needs to be done like that when e.g.
admin wants to unbound port from the host.

Task: #44043
Story: #2009705
Change-Id: I08f1bb40f4dc72cfa7c62feeb5f513455de0ca45
2021-11-28 19:58:46 +01:00
Diwei Zhu
fae293dd52 Switch command server remove volume to sdk
Change-Id: If6f6cf93b55a67e767c54de8ce21f25252cf99ca
2021-11-26 16:11:21 +00:00
Diwei Zhu
28cd5763de Add functional test for server add/remove volume.
Change-Id: I86a76f32790cafcff1d94364fb72f8890a8cb025
2021-11-26 14:11:02 +00:00
Zuul
4b3cdaf8b1 Merge "Switch command server add volume to sdk." 2021-11-25 17:46:47 +00:00
Zuul
6fb71af243 Merge "Add --subnet-pool to subnet list" 2021-11-25 17:46:44 +00:00
Dr. Jens Harbott
860d636047 Temporarily drop aodhclient from doc build
Building plugin documentation is failing for aodhclient when running
with latest pyparsing. Drop the plugin from docs for now until the issue
can be fixed.

Needed-By: https://review.opendev.org/c/openstack/requirements/+/818614/
Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I1cc1efd9ff2004dd711ed9da0b1d9e8be31175f4
2021-11-24 06:51:17 +01:00
Diwei Zhu
3078a0a121 Switch command server add volume to sdk.
File tests.unit.volume.v2.fakes is modified to provide sdk volume fakes.
File tests.unit.compute.v2.fakes is modified to provide sdk volume
attachment fakes. For test, setup_sdk_volumes_mock() method is created
so that volumes are created in similar way as servers are created.

Change-Id: I290ba83b6ba27a1377ab73fd0ae06ecced25efd1
2021-11-22 16:01:29 +00:00
JieonLee
b3d09ffc37 Add missing command mapping in nova
nova command: instance-action
openstack command: server event show

Change-Id: I8e5dad90cfd28b1f0d65be688651918869f679e4
2021-11-21 05:05:25 +00:00
Stephen Finucane
61fac5b79e image: Sanity check the 'SetImage' command
This was a very difficult command to grok, due to the layering on of
additional features over the years. Make this a little easier to follow
by grouping related logic and making use of argparse features.

Change-Id: I4e1a0aed09ea5d6a8c26ec3e888c9c7b6cefc25a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-17 11:42:07 +00:00
Stephen Finucane
1feb676469 tests: Update fake image client in tests
These clients are intended to fake out the old glanceclient client which
we no longer use. They were only "working" because we weren't actually
using any of the glancelclient-based stuff and were instead overriding
everything within the tests. Move these overrides back to the main
fake client and remove the crud.

Change-Id: I92ee74a1df72a6dd23f9d2dc04342aab0cbd3210
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-17 11:42:07 +00:00
Stephen Finucane
2135a9ea05 image: Remove FakeImage test helper
We're no longer creating fake versions of glanceclient's 'Resource'
object but rather openstacksdk objects. As such, there's no point
nesting things under a fake resource class.

Change-Id: I39cd5302622f4542db9eebcccfad0cb90d077441
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-17 11:34:42 +00:00
Stephen Finucane
690e9a13a2 image: Remove dead test helper methods
These haven't been used since we switched the image commands from
glanceclient to openstacksdk. There's more cleanup to be done here but
that can be done later.

Change-Id: I3de1f24323886b122b3a30660fb3de18eb7014e9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-17 11:34:36 +00:00
Thrivikram Mudunuri
9acbd3e105
Switch server image create to SDK
Switch the server image create command from novaclient to SDK. Use the
SDK versions of test fakes to support fake Server resources. Also,
fetch updated image *after* waiting. If a user requests that we wait
(--wait) for a server image to become active before returning, then we
should probably return the final image. If we don't then the image can
appear to be in a non-active state when it fact it's active. Correct
this by fetching the image after the wait call.

Change-Id: I83a403c035add9ab041ed6d59b5b29e42267f143
2021-11-16 11:36:02 -05:00
Zuul
8b394e5641 Merge "Switch openstack server add port/network to using sdk." 2021-11-15 16:31:15 +00:00
Diwei Zhu
2183a61147 Switch openstack server add port/network to using sdk.
The old novaclient.v2.server.Server.interface_attach() method is
replaced with proxy.create_server_interface().
In swargs, 'net_id' and 'port_id' are mutual-exclusive, if one of
them is given with value, the other one cannot be None, as the
API would responde with 400 (None is not string).
In unit test, temporary method 'setup_sdk_servers_mock' is added,
because other tests are still using the old 'setup_servers_mock'.
Functional tests are added. Releasenote is generated.

Change-Id: I9899f0509febc5143560a1859ae6344d0a6d1427
2021-11-14 15:23:36 +00:00
Stephen Finucane
163cb01e46 compute: Return details of attached volumes
The API behind the 'server add volume' command returns details of the
created volume attachment, however, we were dropping these results
rather than displaying them to the user. Correct this.

Change-Id: I3f7e121220d29422ccf4e6940de2f28bb8496c83
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-11-03 11:57:31 +00:00
Stephen Finucane
442838ed15 compute: Use correct command class for 'show migration'
We should be inheriting from 'ShowOne'. Failure to do so results in a
tuple being dumped to the screen. Not what we intended.

While we're here, we update the docstring of this command to clarify the
command's intent. Nova does not provide an API to retrieve an individual
migration record for a cold migration or completed live migration. As
such, the 'server migration show' command only works for in-progress
live-migrations.

Change-Id: I2e2fe3da7d642b9e8e3d930603dcde178cd68cde
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2009658
Task: 43837
2021-11-03 10:19:52 +00:00
Stephen Finucane
8cb0a28607 compute: Don't warn if disk overcommit params unset
Due to a small logic error, we were emitting a warning about a
deprecated option when the user tried to live migrate an instance using
microversion 2.25 even though the user hadn't actually set that option.
Correct this.

Change-Id: Ib61e817bd4ced9b5533e7c7f9d8f0b45fe81c211
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2009657
Task: 43836
2021-11-03 10:17:37 +00:00
Zuul
f824e13bc5 Merge "Switch server backup to sdk." 2021-10-27 16:52:23 +00:00
Diwei Zhu
57aad01886 Switch server backup to sdk.
Switch this command from novaclient to SDK. As this is the first command
related to server that we are migrating, we need to extend our test
fakes to support fake Server resources. The extended fakes will replace
the old ones once all commands related to server are switched.

Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e
2021-10-27 09:11:27 +00:00
Cyril Roelandt
43639e1118 Fix typos
Change-Id: Idd502c8df21da79ff3b9339870f38378f5337879
2021-10-26 15:53:51 +02:00
Stephen Finucane
728401bbd7 Remove remnants of 'six'
Just one entry left. Remove it.

Change-Id: Ia12173ecb7f3fed4a1195a46ebf9b096d917b3b6
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-10-21 17:14:45 +01:00
Stephen Finucane
30612bf622 Remove 'get_osc_show_columns_for_sdk_resource' duplicates
There were a number of 'get_osc_show_columns_for_sdk_resource' defined
in-tree. However, osc-lib has provided this method for some time (since
2.2.0, June 2020 [1] - our minimum version is currently 2.3.0) so
there's no need to provide our own copies. Remove them.

[1] https://github.com/openstack/osc-lib/commit/29a0c5a5

Change-Id: I25695f4f9a379dd691b7eaa1e3247164668ae77e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-10-21 17:14:45 +01:00
Stephen Finucane
a797c9d2a3 tox: Ignore virtualenvs for pep8 environment
Change-Id: I473d1b6c1287325566a5f5f5aadaea802c6af6f4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-10-21 17:14:45 +01:00
Zuul
c985e0a23b Merge "Update the Nova CLI docoder document" 2021-10-21 10:23:23 +00:00
Stephen Finucane
53debe7fe1 compute: Fix filtering servers by tags
The nova API expects the 'tags' and 'not-tags' filters of the 'GET
/servers' (list servers) API to be a CSV string [1]:

  tags (Optional)
    A list of tags to filter the server list by. Servers that match all
    tags in this list will be returned. Boolean expression in this case
    is 't1 AND t2'. Tags in query must be separated by comma.

    New in version 2.26

  not-tags (Optional)
    A list of tags to filter the server list by. Servers that don’t
    match all tags in this list will be returned. Boolean expression in
    this case is 'NOT (t1 AND t2)'. Tags in query must be separated by
    comma.

    New in version 2.26

We were instead providing a Python list, which was simply being URL
encoded. Correct this.

[1] https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detail#list-servers

Change-Id: Ie0251a0dccdf3385089e5bbaedf646a5e928cc48
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Closes-Bug: #1946816
2021-10-13 10:30:26 +01:00
Zuul
e0c61f0cbe Merge "Update the Nova CLI decoder document" 2021-10-08 09:06:20 +00:00
JIHOJU
e06a4f1c20 Update the Nova CLI docoder document
There are several update in CLI decoder document.
- Change flavor set/unset to flavor set/unset --property
- Update the mapping with flavor-update, interface-attach, and interface-detach

Change-Id: I1db50188b3643d3fe28689dc73b3f63806defd29
2021-10-07 21:03:25 +09:00
Zuul
30bb576d81 Merge "Fix the functional-tips tox environment" 2021-10-07 11:06:13 +00:00
choidoa-git
70fed75c85 Update the Nova CLI decoder document
In this patch, Update missing command in Mapping Guide.

List of updated commands
(Nova CLI / OSC)
- server-migration-list / server migration list
- server-migration-show / server migration show
- live-migration-abort / server migration abort
- live-migration-force-complete / server migration force complete
- migration-list / server migration list
- evacuate / server evacuate
- flavor-access-add / flavor set --project
- flavor-access-list / flavor show
- flavor-access-remove / flavor unset
- server-tag-add / server set --tag
- server-tag-delete / server unset --tag
- server-tag-delete-all / server unset --tag
- server-tag-list / server list --tag
- server-tag-set / server set --tag
- quota-class-show / quota show --class

Change-Id: Id1b4980fbc0f6e8e58bfae6f393f9336c6a7e3b1
2021-10-07 10:40:15 +00:00
Zuul
81bab3a716 Merge "Remove non-working code after method return." 2021-10-07 07:31:56 +00:00
Zuul
d79ebc5278 Merge "Add --trusted-image-cert option for server create" 2021-10-06 22:14:37 +00:00
Zuul
49d2c21366 Merge "Fix typo error in listing server's column name" 2021-10-06 17:32:24 +00:00
Zuul
5a8a3b33a1 Merge "Fix that the path of functional test" 2021-10-06 12:11:07 +00:00
Zuul
f4e4cd25c5 Merge "Replace assertItemsEqual with assertCountEqual" 2021-10-06 12:11:06 +00:00
lsmman
abed9f20f5 Remove non-working code after method return.
Delete duplicate return code.

While adding return of a new Member type, the existing return code part is not deleted.

Note the code in fakes.py in the below commit where these codes were added.
- Project: python-openstackclient
- The commit: 60e7c51df4

Change-Id: Iae44770a784732991962cd38472095f76ab2543f
2021-10-06 19:21:51 +09:00
Pavlo Shchelokovskyy
28a376bfb0 Add --trusted-image-cert option for server create
this already exists for server rebuild, but was missing for server
create.

This option is supported from Compute API version >= 2.63, and is only
available for servers booted directly from images (not from volumes,
not from snapshots, and not from images first converted to volumes).

Additionally, this patch removes mentions of
OS_TRUSTED_IMAGE_CERTIFICATE_IDS env var from similar option help string
in server rebuild command as it is not actually implemented yet.

Change-Id: I4e9faea05c499bd91034d1d284c44fdcc8e18db5
2021-09-30 19:42:26 +03:00
ryanKor
c0a0f0f3d8 Fix that the path of functional test
before change:
$ tox -e functional -- --regex functional.tests.compute.v2.test_server
after change:
$ tox -e functional -- --regex tests.functional.compute.v2.test_server

the test unit path document should be change the above line.

(fixed wrong letter)

Change-Id: I49674fb0d56ee65c1f6328b9d960b16876173e2d
2021-09-25 21:34:47 +09:00
OpenStack Release Bot
ff372ffdfb Add Python3 yoga unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for yoga.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I89cff43c0eb97c63deaba320e0fc63bd8ba31a2a
2021-09-22 10:42:18 +00:00
OpenStack Release Bot
8ef9280af9 Update master for stable/xena
Add file to the reno documentation build to show release notes for
stable/xena.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/xena.

Sem-Ver: feature
Change-Id: Iedf2c908bf5a9d87effa02717eb604ee8d15ef3b
2021-09-22 10:42:16 +00:00
Alfredo Moralejo
ed5d2a37c5 Replace assertItemsEqual with assertCountEqual
Follow-up of [1]. After this patch was sent, two more assertItemsEqual
were added in [2]. This patch is fixing it.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/789410
[2] https://review.opendev.org/c/openstack/python-openstackclient/+/781637

Change-Id: Ic2276bd0ff0f5df76505f37d8994b3384d40e9a7
2021-09-09 15:50:54 +02:00
Zuul
3a0571c4df Merge "compute: Add support for microversion 2.90" 2021-09-02 20:15:11 +00:00
Lee Yarwood
51ee17a94d compute: Add support for microversion 2.89
This microversion drops the duplicate ``id`` field while adding
``attachment_id`` and ``bdm_uuid`` to the output of the
os-volume_attachments API reflected within osc by the ``openstack server
volume list $server``command.

Depends-On: https://review.opendev.org/c/openstack/nova/+/804275
Change-Id: I8a7002d8d65d7795e106b768df868198ab8b8143
2021-09-02 14:35:17 +01:00
Stephen Finucane
8e833a3ed2 compute: Add support for microversion 2.90
Allow configuring hostname when creating a new server or updating or
rebuilding an existing server.

Change-Id: Ibe603eab78bbbec43605f56de62a20493b6aa93d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/python-novaclient/+/806917
2021-09-01 13:18:25 +01:00
Ghanshyam Mann
6ce7da8aeb [community goal] Update contributor documentation
This patch updates/adds the contributor documentation to follow
the guidelines of the Ussuri cycle community goal[1].

[1] https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html

Story: #2007236
Task: #38547
Change-Id: I0afa1796d488a96160f4a7fd615920d05fe1771c
2021-08-30 17:13:12 +00:00
LEE JAE YONG
4aad7dd779 Fix typo error in listing server's column name
openstack server list -c "Created At" command doesn't work
because the wrong variable was used here.

When we receive resp data, Created At data is saved with
the name "created". But in "server.py", we append columns
as created_at. So it seems to print an empty table.

Story: 2009149
Task: 43112
Change-Id: I06de6903d5cc427a8b0fdcd168fec47192f4365b
2021-08-28 07:17:04 +00:00
Zuul
d9c556e69a Merge "L3 conntrack helper: Use singular name consistently" 2021-08-26 08:14:22 +00:00
Zuul
eca51342c3 Merge "volume: Add 'volume transfer request create --(no-)snapshots' option" 2021-08-26 08:03:53 +00:00
Zuul
6776cec809 Merge "openstack image create: honor protection/visibility flags" 2021-08-26 08:02:34 +00:00
Zuul
2c89812714 Merge "volume: Add missing 'volume list --offset' parameter" 2021-08-26 08:00:40 +00:00
Zuul
4fc1ac2ce2 Merge "Replace assertItemsEqual with assertCountEqual" 2021-08-23 21:20:16 +00:00
Zuul
2dfaf62340 Merge "Update volume create documentation" 2021-08-19 04:32:51 +00:00
melanie witt
12c93c6d5f Show "Forced Down" compute service status with --long
Currently, the unified client does not have the ability to show the
"Forced Down" field of a GET /os-services response in microversion 2.11
even though the legacy client can.

This adds a "Forced Down" column to the 'openstack compute service list
--long' command output when microversion 2.11 is used.

Story: 2009115
Task: 43011

Change-Id: I10bc2fedbf0e867a990227962b2b6e60f5681f69
2021-08-17 01:34:05 +00:00
melanie witt
ed87f7949e Correct REST API response fields for /os-migrations API
The compute APIs are unfortunately inconsistent with regard to the
response parameters for migrations.

* GET /servers/{server_id}/migrations returns server_uuid
* GET /os-migrations returns instance_uuid

Because the 'Server UUID' column is being specified for parsing the
response from GET /os-migrations, it is always showing as an empty
string to users.

There are a few other mismatches between the column names and the REST
API response fields [1]:

* 'Old Flavor' vs 'old_instance_type_id'
* 'New Flavor' vs 'new_instance_type_id'
* 'Type' vs 'migration_type'

This adds a new list containing the REST API response field names to
pass to utils.get_item_properties so that the responses are correctly
parsed and the client output contains the response data instead of
empty strings.

Story: 2009078
Task: 42890

[1] https://docs.openstack.org/api-ref/compute/?expanded=list-migrations-detail#list-migrations

Change-Id: I8aab60619e0225047f6a1c31e44917ca8fcc799e
2021-07-28 15:25:06 +00:00
Zuul
59256becc9 Merge "compute: Note that '--password' is deployment-specific" 2021-07-27 12:13:40 +00:00
Stephen Finucane
e0dc31f32e volume: Add missing 'volume list --offset' parameter
Looking at the code for the ancient v1 cinder API, we see that this
supported offset-style pagination [1][2][3]. Add this parameter,
simplifying a future patch to standardize pagination across OSC.

[1] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/v1/volumes.py#L259
[2] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/v1/volumes.py#L292
[3] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/common.py#L120

Change-Id: Ifec208ea9ed7afb4bebced6132abb96a3af034b5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-07-27 11:15:23 +01:00
melanie witt
4f6fe1c0fd Fix TestListMigrationV223 test class MIGRATION_COLUMNS
Currently only the test_server_migration_list adds the 'Id' and 'Type'
columns to the expected output, so if the
test_server_migration_list_no_options test is run by itself, it fails
as the actual response contains 'Id' and 'Type' but the reference does
not. This example run fails:

  tox -epy38 test_server_migration_list_no_options

The reason the tests pass in the gate is because
test_server_migration_list (which adds the 'Id' and 'Type' columns to
self.MIGRATION_COLUMNS) appears to always run before
test_server_migration_list_no_options, so the latter test gets the
benefit of the former test's column additions.

This changes the test class to just include the 'Id' and 'Type' columns
all the time as they are always returned in microversion 2.23 anyway.

Story: 2009079
Task: 42891

Change-Id: I2c97e9f64790b5e978e4d04230d45b8e343b53d4
2021-07-27 02:20:39 +00:00
Stephen Finucane
c1209601b4 tests: Handle removal of block-storage v2 API
Cinder recently removed their v2 API [1] which is causing the functional
tests to fail. Improve our 'is_service_enabled' test helper to use the
'versions show' command, which queries the service catalog and can give
us information about the service version as well as answer the more
general "is this service available" question. We also resolve a
long-standing TODO in the process.

[1] https://review.opendev.org/c/openstack/cinder/+/792299

Change-Id: I381069357aa008344e15327adf3a863c0c2e1f04
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-07-23 12:51:30 +01:00
Stephen Finucane
a821d6b7c5 volume: Add 'volume transfer request create --(no-)snapshots' option
This closes a gap with cinderclient's 'transfer-create' command.

Change-Id: I7386a7be15c0e3ee87abbcfc2275ba8524c10ff8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2009054
Task: 42831
2021-07-13 20:33:35 +01:00
Ghanshyam Mann
4891bb3820 Moving IRC network reference to OFTC
Change-Id: I11e00f18fa8dca02bc0f136c0c5e9a2f040eef8f
2021-07-07 19:43:00 -05:00
Zuul
12355b8dac Merge "cinder: Remove redundant command" 2021-07-07 15:12:12 +00:00
Zuul
ab6e905353 Merge "compute: Fix typo" 2021-07-02 18:29:30 +00:00
Zuul
4f35836798 Merge "Make functional Neutron tests running fine on ML2/OVN environments" 2021-06-29 17:13:27 +00:00
Stephen Finucane
af406f33e3 cinder: Remove redundant command
There is no 'volume group unset' command nor any need for one right now.
This was mistakenly added in I3b2c0cb92b8a53cc1c0cefa3313b80f59c9e5835.

Change-Id: I9386d1350099b10659c6b0e632e4d83cae5b2bfd
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-22 18:26:54 +01:00
Zuul
19b4ce402e Merge "Correct the tox option for skipping sdist generation" 2021-06-21 13:56:44 +00:00
Zuul
a5039e7764 Merge "volume: Add more missing 'volume backup *' options" 2021-06-21 13:20:28 +00:00
Zuul
3f3d8829ce Merge "volume: Add 'volume group snapshot *' commands" 2021-06-21 13:09:41 +00:00
Zuul
6abfb01895 Merge "volume: Add 'volume group type *' commands" 2021-06-21 13:09:36 +00:00
Zuul
87369984d1 Merge "volume: Add 'volume group *' commands" 2021-06-18 18:05:39 +00:00
Zuul
779c39f616 Merge "tests: Rename 'FakeType' -> 'FakeVolumeType'" 2021-06-18 18:02:34 +00:00
Zuul
05b7049316 Merge "volume: Add missing 'volume backup *' options" 2021-06-18 16:56:06 +00:00
Zuul
ae5f3009d5 Merge "volume: Add 'volume message *' commands" 2021-06-18 16:52:05 +00:00
Zuul
673fec4f64 Merge "volume: Add 'volume attachment *' commands" 2021-06-18 16:51:59 +00:00
Jeremy Stanley
98979cfc7f Correct the tox option for skipping sdist generation
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.

See https://tox.readthedocs.io/en/latest/config.html#conf-skipsdist
and https://github.com/tox-dev/tox/issues/1388 for details.

Change-Id: I05c1cc0c2fbf77021cc1e05bc96bee03528c69f0
2021-06-17 17:07:39 +00:00
Zuul
f873428f2c Merge "volume: Allow more versions" 2021-06-17 13:06:18 +00:00
Zuul
89f6d7bf35 Merge "compute: Better help text for 'openstack server set --state'" 2021-06-16 20:55:31 +00:00
Zuul
5b4863ca11 Merge "docs: Update neutronclient comparison doc" 2021-06-16 17:34:43 +00:00
Zuul
a3227bf7f6 Merge "docs: Update glanceclient comparison doc" 2021-06-16 17:34:29 +00:00
Zuul
50dfc967df Merge "docs: Update novaclient comparison doc" 2021-06-16 17:34:20 +00:00
Zuul
82318b4137 Merge "docs: Update cinderclient comparison doc" 2021-06-16 17:34:02 +00:00
Stephen Finucane
13de349411 compute: Better help text for 'openstack server set --state'
Manually changing the server state is a potentially dangerous operation
that should only be done under limited circumstances. It's also an
admin-only operation by default. Highlight both points.

Change-Id: Ifd8aec94937764202131ba8caf6b507caa76d7e9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: 2008549
Task: 41672
2021-06-16 18:09:32 +01:00
Stephen Finucane
280b14abcd compute: Note that '--password' is deployment-specific
Password injection requires either hypervisor-support or an agent
running in the guest that will talk to the metadata service. It can be
disabled for a deployment using the '[api] enable_instance_password'
nova config option. Indicate this, albeit briefly.

Change-Id: Ief94ea07fc7ab6a487af972e8759ca6704d8f085
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-16 16:19:36 +01:00
Stephen Finucane
7f66dfe0e3 volume: Add more missing 'volume backup *' options
Add an additional '--no-property' option to the 'volume backup set'
command, along with a brand spanking new 'volume backup unset' command.

Change-Id: Id7ca925e0ada03e259f0ecaf3e02af11c900641e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-10 11:21:25 +01:00
Stephen Finucane
34de2d3352 volume: Add 'volume group snapshot *' commands
These mirror the 'cinder group-snapshot-*' commands, with arguments
copied across essentially verbatim. The only significant departure is
the replacement of "tenant" terminology with "project".

  volume group snapshot create
  volume group snapshot delete
  volume group snapshot list
  volume group snapshot show

Change-Id: Ia5084749b7c1a5a936fd6d6e8d89b9b80969f68c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-10 11:21:22 +01:00
Akihiro Motoki
02d6fe9be6 L3 conntrack helper: Use singular name consistently
We use singular form for delete command argument in all places.
This commit replaces conntrack-helper-ids with a singular form.
The only visible change is a fix for the help message below.

  openstack network l3 conntrack helper delete
      <router>
      <conntrack-helper-ids>
      [<conntrack-helper-ids> ...]

Change-Id: I50bbd9f6199071bb86cbb2f37c45ebda1de58433
2021-06-08 15:28:06 +09:00
Slawek Kaplonski
fa8c8d26a7 Add support for Neutron's L3 conntrack helper resource
Neutron has got CRUD API for L3 conntrack helper since some time.
This patch adds support for it in the OSC.
OpenStack SDK supports that since [1]

This patch also bumps minimum OpenStack SDK version to
the 0.56.0 as that version introduced support for the
Neutron's L3 conntrack helper.

[1] https://review.opendev.org/c/openstack/openstacksdk/+/782870

Change-Id: I55604182ae50b6ad70c8bc1f7efad8859f191269
2021-06-07 15:34:30 +02:00
Stephen Finucane
83551d2a0c volume: Add 'volume group type *' commands
These mirror the 'cinder group-type-*' commands, with arguments copied
across essentially verbatim. The only significant departure is the
merging of some commands, such as 'group-type-default' and
'group-type-list' into 'group type list', and 'group-type-update' and
'group-type-key' into 'group type set/unset'.

  volume group type create
  volume group type delete
  volume group type list
  volume group type show
  volume group type set
  volume group type unset

Change-Id: Iee6ee2f1f276e6ef6f75a74f8f2980f14c0d5e2f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 18:00:50 +01:00
Stephen Finucane
4c2e8523a9 volume: Add 'volume group *' commands
These mirror the 'cinder group-*' commands, with arguments copied across
essentially verbatim. The only significant departures are the
replacement of "tenant" terminology with "project" and the merging of
the various volume group replication action commands into the parent
volume group (e.g. 'openstack volume group set --enable-replication'
instead of 'cinder group enable-replication')

  volume group create
  volume group delete
  volume group list
  volume group show
  volume group set
  volume group failover

Change-Id: I3b2c0cb92b8a53cc1c0cefa3313b80f59c9e5835
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 17:58:48 +01:00
Stephen Finucane
5faa9ef805 tests: Rename 'FakeType' -> 'FakeVolumeType'
There are more types than just volume types.

Change-Id: I6af66f966a221437ff79fabcb0b81fd38586fe67
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
524af4a23e volume: Add missing 'volume backup *' options
Add a couple of missing options to each command:

  volume backup create
    --no-incremental
    --property
    --availability-zone

  volume backup set
    --property

Most of these are version dependent so we add the relevant version
checks as part of this work. While we're here, we also make the
formatting a little easier on the eye in places.

Change-Id: I328d5c981cb32b2ee9a4b1bd43aa36b22347ff63
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
0eddab36e5 volume: Add 'volume message *' commands
This patch implements the necessary commands to utilize the Messages API
introduced in Cinder API version 3.3. Version 3.5 built upon this by
implementing pagination support for these commands which is present in
this patch as well.

  volume message get
  volume message list
  volume message delete

Change-Id: I64aa0b4a8d4468baa8c63e5e30ee31de68df999d
2021-06-03 15:52:18 +01:00
Stephen Finucane
6dc94e1fb8 volume: Add 'volume attachment *' commands
These mirror the 'cinder attachment-*' commands, with arguments copied
across essentially verbatim. The only significant departure is the
replacement of "tenant" terminology with "project".

  volume attachment create
  volume attachment delete
  volume attachment list
  volume attachment complete
  volume attachment set
  volume attachment show

Full support for filtering is deferred for now since that's a more
complicated change that requires additional commands be added first.
TODOs are included to this effect.

Change-Id: If47c2b56fe65ee2cee07c000d6ae3688d5ef3b42
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
0f28588e48 volume: Allow more versions
Copy the API version checks from the 'openstackclient.compute.client'
module. These will only be necessary until we migrate everything to SDK
but it's very helpful until then.

Change-Id: I2d9c68db5bf891ffa25fd5a7fc9e8953e44b73ab
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
95f914769a docs: Update neutronclient comparison doc
Done manually by looking at the help text for the 'neutron' client
(version 7.1.1) and identifying gaps.

Change-Id: Ib029b2c236f79a0ca6f64834f069db2be4332ea8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
83e7e4ab2e docs: Update glanceclient comparison doc
Done manually by looking at the help text for the 'glance' client
(version 3.1.1) and identifying gaps.

Change-Id: Ic46bbdef7182e5f707cd5083868886ce60c7eb47
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
3751f1fdb6 docs: Update novaclient comparison doc
Done manually by looking at the help text for the 'nova' client
(version 17.0.0) and identifying gaps.

Change-Id: I23a4947a13d5e576c5aa66902686df60379ffda0
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
Stephen Finucane
8dc2a7e9f7 docs: Update cinderclient comparison doc
Done manually by looking at the help text for the 'cinder' client
(version 7.0.0) and identifying gaps.

Change-Id: Ib16c7e9dfa47a93d8b077f0e3e5bbd5bf8984ec3
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-03 15:52:18 +01:00
David Caro
eca1fcd65f
Include hosts in aggregate list --long
This makes it easier to get the total list of aggregates and the hosts
belonging to each of them (specially for scripting purposes).

Change-Id: I94833c15075ae655bc11e7c0fc47c0abad5846fc
Signed-off-by: David Caro <me@dcaro.es>
2021-06-03 09:44:39 +02:00
wu.shiming
1169a114e7 Changed minversion in tox to 3.18.0
The patch bumps min version of tox to 3.18.0 in order to
replace tox's whitelist_externals by allowlist_externals option:
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23

Change-Id: Ibb77fa2afad3f09e95f0dba243d3a096daedd787
2021-06-03 07:00:29 +00:00
Zuul
82fcf1dbe5 Merge "compute: Update 'server resize --revert', '--confirm' help" 2021-06-02 18:11:46 +00:00
Zuul
64295fcb7b Merge "setup.cfg: Replace dashes with underscores" 2021-06-02 17:57:49 +00:00
Stephen Finucane
d087952717 compute: Fix typo
Change-Id: I3795142318b63b7c8f836d78a415a2161f61164d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-06-02 12:17:35 +01:00
YuehuiLei
fe6a4fa8fc setup.cfg: Replace dashes with underscores
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I7e43e43bc5a24f49aa7b225502e5d0176fef3783
2021-05-31 00:37:06 +00:00
Slawek Kaplonski
a2375b8787 Make functional Neutron tests running fine on ML2/OVN environments
Devstack recently switched default Neutron's backend from ML2/OVS to
ML2/OVN. As OVN backend has some parity gaps and differences in some
APIs, functional tests job was failing with ML2/OVN as some tests
weren't properly skipped in case of missing some Neutron API extensions.

This patch fixes that by doing some small changes in the functional
tests:
- skip DHCP/L3 agent tests when dhcp/l3 agent scheduler extensions
aren't available,
- skip updating neutron agent as OVN agents don't allows that,
- skip service providers tests when there is no Neutron L3 agent
available,
- skip setting router as distributed as OVN backend don't supports that
router's attribute at all.

Depends-On: https://review.opendev.org/c/openstack/neutron/+/793141
Change-Id: I29a8db202086b0b49fed865409fa8ca244b98439
2021-05-27 10:13:56 +00:00
Zuul
443c311fc2 Merge "Allow to send extra attributes in Neutron related commands" 2021-05-26 19:29:11 +00:00
Zuul
84a606be67 Merge "Set ML2/OVS backend explicitly in the devstack jobs" 2021-05-26 09:41:18 +00:00
Slawek Kaplonski
b26b7f3440 Allow to send extra attributes in Neutron related commands
To deprecate and drop support for neutronclient CLI and use only
OSC we need feature parity between OSC and neutronclient.
Last missing piece here is possibility to send in POST/PUT requests
unknown parameters to the Neutron server.
This patch adds such possibility to the OSC.

Change-Id: Iba09297c2be9fb9fa0be1b3dc65755277b79230e
2021-05-26 09:29:15 +02:00
Stephen Finucane
b1a41904c3 compute: Update 'server resize --revert', '--confirm' help
Update the help strings for these two arguments to indicate their
deprecated nature. This was previously flagged via a deprecation warning
but users would only see that if they were to run the command.

Change-Id: I31a5e27ac8bd2625a6073b54a51bf3e8d6126c8c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-05-20 16:58:57 +01:00
Brian Rosmaita
b019a56187 Add check for cinderclient.v2 support
Block Storage API v2 support is being removed from the cinderclient
during the Xena development cycle [0], so add a check to determine
whether the available cinderclient has v2 support.

[0] https://wiki.openstack.org/wiki/CinderXenaPTGSummary#Removing_the_Block_Storage_API_v2

Change-Id: Id54da1704d94526071f500c36a6e38d6d84aa7b8
2021-05-20 09:20:56 -04:00
Slawek Kaplonski
05807ee0db Set ML2/OVS backend explicitly in the devstack jobs
Neutron team recently switched default backend used in Neutron
by Devstack to OVN. With that backend some tests, like e.g. related
to DHCP or L3 agents aren't working fine. So to have still the same
test coverage as we had before, let's explicitly set ML2/OVS as a
Neutron's backend in those CI jobs.

Change-Id: Idf6466a59c6cf96be2f1d53e696f0564584fa233
2021-05-13 20:43:57 +00:00
Jens Harbott
1f0fcbcd1d Fix the functional-tips tox environment
The egg for the keystoneauth project is actually called keystonauth1.
Seems newer pip actually complains about the difference and fails.

Change-Id: I1602832d33cd467745a03b36c9b1545cd069ba1d
2021-05-11 11:24:59 +00:00
Cyril Roelandt
3918622968 openstack image create: honor protection/visibility flags
The --protected, --unprotected, --public, --shared, --community,
--private flags were ignored when using --volume.

Change-Id: Id5c05ef7d7bb0a04b9d7a9d821e544e1ff7b3d28
Story: 2008882
2021-05-05 01:26:51 +02:00
Dirk Mueller
e82a05864f Replace assertItemsEqual with assertCountEqual
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277

Change-Id: I0bbffbec8889b8b3067cfe17d258f5cb16624f38
2021-05-03 22:07:39 +02:00
Zuul
6bdf030953 Merge "requirements: Drop os-testr" 2021-04-14 14:10:03 +00:00
Zuul
782e4d0f97 Merge "Add support for token caching" 2021-04-09 23:29:03 +00:00
zhangbailin
168a4e7390 requirements: Drop os-testr
os-testr has been decrepated [1], it's not necessary in a world with stestr.

[1]https://opendev.org/openstack/os-testr/src/branch/master/README.rst

Change-Id: Id2382f2c559ea7f4d4a629d137f07f0ce8841abc
2021-04-08 14:24:52 +08:00
Zuul
684be67df9 Merge "volume: Re-add accidentally deleted test" 2021-04-06 21:09:02 +00:00
Zuul
f449c59378 Merge "hacking: Remove references to encoding" 2021-04-06 21:08:40 +00:00
Zuul
03e58a4886 Merge "Add pre-commit" 2021-04-01 19:05:00 +00:00
Zuul
903bbfe9eb Merge "Add Python3 xena unit tests" 2021-04-01 18:31:35 +00:00
Zuul
f48dc562fe Merge "Update master for stable/wallaby" 2021-04-01 18:31:30 +00:00
Zuul
930ca85dcf Merge "Implements hide image" 2021-04-01 17:58:18 +00:00
Stephen Finucane
f00e14f400 hacking: Remove references to encoding
This is no longer an issue in our new Python 3-only world.

Change-Id: I25c31a0b7f76a253499d9713ba48fd7ba7168450
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-04-01 14:16:22 +00:00
Zuul
8e3dde03f9 Merge "network: Add support for vnic-type vdpa" 2021-03-31 18:40:32 +00:00
Valery Tschopp
383289edd8 Implements hide image
openstack image set [--hidden|--unhidden] IMAGE
openstack image list --hidden

Task: 41734
Story: 2008581
Change-Id: Ie84f10c0f7aa2e7b7f78bfadc70132a10673866e
2021-03-25 08:57:31 +01:00
OpenStack Release Bot
449b30981a Add Python3 xena unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I2415ec61c3580fcd43ee7d8f2a90b698ac156593
2021-03-20 09:16:55 +00:00
OpenStack Release Bot
32151b099c Update master for stable/wallaby
Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: I848e21bf2d2ea1a1a132525070e5f20d7ff8478d
2021-03-20 09:16:50 +00:00
Zuul
23e7495d44 Merge "Hides prefix_length column in subnet show output" 2021-03-20 05:55:41 +00:00
Zuul
b527ec15a9 Merge "network: Make 'network qos rule create --type' option required" 2021-03-20 05:54:26 +00:00
Zuul
7c6b689fdd Merge "Remove unnecessary test" 2021-03-20 02:27:54 +00:00
James Denton
d769ff4393 Hides prefix_length column in subnet show output
When the openstacksdk is patched to properly support defining prefix
lengths when creating subnets, the resulting subnet show output
reveals a prefix_length column with a value of 'none'. This patch
hides the prefix_length column.

Change-Id: I59dfb0b1585ed624f9d82b3557df2ff5ff9d1b3e
Partial-Bug: 1754062
Depends-On: https://review.openstack.org/#/c/550558/
2021-03-19 18:43:35 +00:00
Stephen Finucane
c58f0277a7 network: Make 'network qos rule create --type' option required
When we create a network qos rule we need specify the type so that we
can call the corresponding API. It's not possible to use the command
without the type so mark it as required. This was already being done
but inline.

Change-Id: I559f884bac198d2c69e800620aef66b200473418
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-19 18:39:08 +00:00
Stephen Finucane
bf97b5f287 volume: Re-add accidentally deleted test
This is essentially a partial revert of change
I94aa7a9824e44f9585ffb45e5e7637b9588539b4, which removed some deprecated
commands like 'openstack snapshot *' in favour of 'openstack volume
snapshot *'. Unfortunately the latter appeared to have no test coverage
and were relying on tests for the former to validate behavior. Re-add
the tests removed back then.

Change-Id: Ib2cd975221034c8997d272d43cfb18acefc319fe
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-19 16:27:13 +00:00
Sean Mooney
6f82165979 network: Add support for vnic-type vdpa
Extend 'port create' to support vinc-type vdpa as introduced by neutron
in [1].

[1] https://review.opendev.org/c/openstack/neutron/+/760047

Change-Id: I635c5269f4e8fc55f234c98e85fced87b39fce81
2021-03-19 15:19:38 +00:00
Zuul
86bca18b74 Merge "project cleanup" 2021-03-18 08:39:11 +00:00
Brian Haley
e4e9fb594d Add --subnet-pool to subnet list
The neutron API supports filtering subnets by subnet
pool id, but the CLI was missing support for it.

Change-Id: Ic230c2c5cda8255d8f2c422880aeac81670b2df3
2021-03-16 09:35:15 -04:00
Takashi Kajinami
791bed6dd2 Update the file paths mentioned in README.rst
This change fixes the outdated file paths, which were renamed by commit
9599ffe65d .

Change-Id: I9ec4c49711a2fde24f5527086e495c86af9ef1ce
2021-03-15 23:29:53 +09:00
Stephen Finucane
87e6828678 Add pre-commit
This is helpful to automate code style checks at runtime. We include
documentation on how to run this as well as a general overview of style
guidelines in OSC.

Change-Id: I2dc5a0f760ce53269ae25677560b2611cc6bfd91
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 16:20:15 +00:00
Stephen Finucane
2ccf7727a6 compute: Remove 'file://' prefix from '--block-device'
There are a couple of other (networking-related) options which accept
paths, none of which insist on a URI-style path. Let's just drop this
bit of complexity before we release the feature.

Change-Id: Ia7f781d82f3f4695b49b55a39abbb6e582cd879c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 15:56:59 +00:00
Zuul
ae1f8f888a Merge "compute: Add support for loading BDMs from files" 2021-03-11 12:51:47 +00:00
Zuul
e6b0473b8b Merge "compute: Add functional tests for --block-device" 2021-03-11 12:44:47 +00:00
Pierre Riteau
46bd6ef91f Update volume create documentation
Change I94aa7a9824e44f9585ffb45e5e7637b9588539b4 removed these options.

Change-Id: I43d84b5532ae6570e1486867c03b8ebec81e38e4
2021-03-09 14:50:26 +01:00
Zuul
274d1eeffb Merge "network: Add missing subnet unset --gateway <subnet-id>" 2021-03-06 13:57:27 +00:00
Zuul
9414435607 Merge "Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747" 2021-03-06 11:41:23 +00:00
Bharat Kunwar
ed731d6cd9 network: Add missing subnet unset --gateway <subnet-id>
Story: 2008695
Task: 42003
Change-Id: I9486a09531b11f27a9ff0d68fd4ad8c68a65cccf
2021-03-05 14:15:20 +00:00
Stephen Finucane
d3bd0146ae compute: Add support for loading BDMs from files
The syntax of the '--block-device' parameter is complex and easily
screwed up. Allow users to load a block device config from a file. For
example:

  $ openstack server create ... --block-device file:///tmp/bdm.json ...

This should alleviate the pain that is BDMv2 somewhat.

No functional tests are provided since we already have tests for the CSV
style of passing parameters and the unit tests show that the net result
is the same.

Change-Id: I3e3299bbdbbb343863b4c14fb4d9196ff3e1698d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-05 13:11:09 +00:00
Stephen Finucane
7c1d6f769c compute: Add functional tests for --block-device
This mostly reuses the existing tests for '--block-device-mapping',
which can hopefully be removed at some point in the future.

This highlights two issues with the implementation of this option.
Firstly, the 'boot_index' parameter is not required so don't mandate it.
Secondly, and more significantly, we were defaulting the destination
type for the 'image' source type to 'local'. Nova only allows you to
attach a single image to local mapping [1], which means this default
would only make sense if you were expecting users to use the
'--block-device' option exclusively and omit the '--image' option. This
is the *less common* case so this is a bad default. Default instead to a
destination type of 'volume' like everything else, and require users
specifying '--block-device' alone to pass 'destination_type=local'
explicitly.

[1] https://github.com/openstack/nova/blob/c8a6f8d2e/nova/block_device.py#L193-L206

Change-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-05 12:44:52 +00:00
Zuul
a507fb50f8 Merge "compute: Remove deprecated 'server migrate --live' option" 2021-03-04 21:29:55 +00:00
Zuul
979b4832dd Merge "compute: Deprecate 'server create --file'" 2021-03-04 21:29:48 +00:00
Zuul
8e94044710 Merge "compute: Stop silently ignore --(no-)disk-overcommit" 2021-03-04 21:29:38 +00:00
Zuul
9aad6b8f9e Merge "compute: Auto-configure shared/block live migration" 2021-03-04 21:29:26 +00:00
Zuul
e260d43d94 Merge "compute: Add 'server create --block-device' option" 2021-03-04 21:28:59 +00:00
Zuul
d94d2f1213 Merge "compute: Remove references to optional extensions" 2021-03-04 21:28:31 +00:00
Zuul
93c9b914a6 Merge "compute: Add missing 'server create' options" 2021-03-04 21:28:13 +00:00
Zuul
433ceff051 Merge "compute: Improve 'server create --block-device-mapping' option parsing" 2021-03-04 21:27:44 +00:00
Zuul
1f6104c760 Merge "compute: Rename 'server migrate (confirm|revert)'" 2021-03-04 16:51:57 +00:00
Zuul
855dc79a87 Merge "compute: Add 'server migration show' command" 2021-03-04 16:51:40 +00:00
Zuul
82770fa6c0 Merge "Rename FakeServerMigration to FakeMigration" 2021-03-04 16:51:12 +00:00
Zuul
e8a50692a0 Merge "compute: Add support for 'server boot --nic ...,tag=<tag>'" 2021-03-04 16:50:58 +00:00
Zuul
af18b514ef Merge "compute: Improve 'server create --nic' option parsing" 2021-03-04 13:21:31 +00:00
Zuul
b9f61f7b30 Merge "compute: Shuffle options for 'server create'" 2021-03-04 13:21:10 +00:00
Zuul
d4f8aa163d Merge "compute: Add missing options for 'server event list'" 2021-03-04 13:20:35 +00:00
Zuul
1c84b44ac2 Merge "Add --name to port list" 2021-03-03 17:03:02 +00:00
Zuul
2732ed3fe0 Merge "compute: Add missing options for 'server group list'" 2021-03-03 17:01:52 +00:00
Zuul
011991bcf3 Merge "compute: Add 'server * --all-projects' option" 2021-03-03 17:01:33 +00:00
Brian Haley
16c72f8642 Add --name to port list
The neutron API supports filtering ports by name, but
the CLI was missing support for it like it does for
other networking resources.

Change-Id: I4ff339e18656013218a26f045b205cb7a02dd2fb
Story: #2008654
2021-02-23 18:58:24 -05:00
Miguel Lavalle
e8509d81ee Add 'address_group' type support to rbac commands
Depends-On: https://review.opendev.org/c/openstack/neutron/+/772460
Change-Id: Icd5e96d180364b979d1e93fcb39f9133a41a06e5
2021-02-10 17:40:39 -06:00
Artem Goncharov
119d2fae25 project cleanup
New implementation of the project cleanup based on the sdk.project_cleanup.
It is implemented as an additional OSC operation and will ideally obsolete the 
`openstack project purge` giving flexibility to extend services support, 
parallelization, filters, etc.

Change-Id: Ie08877f182379f73e5ec5ad4daaf84b3092c829c
2021-02-02 08:14:34 +00:00
Zuul
01a53fa96f Merge "Add device profile to `port`" 2021-01-22 20:42:59 +00:00
Stephen Finucane
70480fa862 compute: Remove deprecated 'server migrate --live' option
It's been long enough. Time to remove this.

Change-Id: I37ef09eca0db9286544a4b0bb33f845311baa9b2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-22 13:00:46 +00:00
Stephen Finucane
6f3969a0c8 compute: Deprecate 'server create --file'
The parameter isn't actually deprecated, since we need to support older
API microversion, however, we now emit an error if someone attempts to
boot a server with the wrong microversion. This would happen server-side
anyway since this parameter was removed entirely in API microversion
2.57.

Change-Id: I73864ccbf5bf181fecf505ca168c1a35a8b0af3a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-22 13:00:46 +00:00
Stephen Finucane
8868c77a20 compute: Stop silently ignore --(no-)disk-overcommit
These options are not supported from Nova API microversion 2.25 and
above. This can be a source of confusion. Start warning, with an eye on
erroring out in the future.

Change-Id: I53f27eb3e3c1a84d0d77a1672c008d0e8bb8536f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-22 13:00:46 +00:00
Stephen Finucane
2bdf34dcc3 compute: Auto-configure shared/block live migration
API microversion 2.25 introduced the 'block_migration=auto' value for
the os-migrateLive server action. This is a sensible default that we
should use, allowing users to avoid stating one of the
'--block-migration' or '--shared-migration' parameters explicitly.

While we're here, we take the opportunity to fix up some formatting in
the function, which is really rather messy.

Change-Id: Ieedc77d6dc3d4a3cd93b29672faa97dd4e8c1185
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-22 13:00:46 +00:00
Stephen Finucane
ace4bfb640 compute: Add 'server create --block-device' option
One of the last big gaps with novaclient. As noted in the release note,
the current '--block-device-mapping' format is based on the old BDM v1
format, even though it actually results in BDM v2-style requests to the
server. It's time to replace that.

Change-Id: If4eba38ccfb208ee186b90a0eec95e5fe6cf8415
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-22 13:00:39 +00:00
Stephen Finucane
f2deabb136 compute: Remove references to optional extensions
This is no longer a thing in nova.

Change-Id: I2413b826385792a4f33ff70e75621b48de65c799
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
4da4b96296 compute: Add missing 'server create' options
Add some volume-related options, namely '--snapshot', '--swap', and
'--ephemeral'. All are shortcuts to avoid having to use
'--block-device-mapping'.

Change-Id: I450e429ade46a7103740150c90e3ba9f2894e1a5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
074e045c69 compute: Improve 'server create --block-device-mapping' option parsing
Once again, custom actions to the rescue.

Change-Id: I6b4f80882dbbeb6a2a7e877f63becae7211b7f9a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
a52beacaa6 compute: Rename 'server migrate (confirm|revert)'
We're confirming or reverting a server migration, not a server migrate.
We've a number of 'server migration *' commands now so it makes sense to
move them under here.

Change-Id: Ib95bb36511dad1aafe75f0c88d10ded382e4fa5c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
f80fe2d8cf compute: Add 'server migration show' command
This replaces the 'server-migration-show' command provided by
novaclient.

Change-Id: I413310b481cc13b70853eb579417f6e6fad10d98
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
32ae1857d1 Rename FakeServerMigration to FakeMigration
Server migrations are (confusingly) a different thing returned by a
different API.

Change-Id: Ib6b7c8f9cc3d1521a993616f832d41651dc46f73
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
9ed34aac0a compute: Add support for 'server boot --nic ...,tag=<tag>'
This has been around for a long time but was not exposed via OSC. Close
this gap.

Change-Id: I71aabf10f791f68ee7405ffb5e8317cc96cb3b38
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
c7d582379a compute: Improve 'server create --nic' option parsing
Simplify the parsing of this option by making use of a custom action.

Change-Id: I670ff5109522d533ef4e62a79116e49a35c4e8fa
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
d6c9b7f198 compute: Shuffle options for 'server create'
argparse doesn't sort options by name, meaning we can use the
opportunity to group closely related options together. Do that.

Change-Id: I6714c8db1a549bd4206d2282d2876a406af65aa2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:01:15 +00:00
Stephen Finucane
7ed4f68c68 compute: Add missing options for 'server event list'
Add pagination parameters, '--limit' and '--offset', and filtering
parameters, '--changes-since' and '--changes-before'.

Change-Id: Ieca8267c3b204ae2db580502cc8fe72c95eddf09
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 11:00:31 +00:00
Stephen Finucane
5ec4d4c718 compute: Add missing options for 'server group list'
Add pagination parameters, '--limit' and '--offset'. It's unfortunate
that we can't use '--marker' like elsewhere but that requires
server-side support to be truly effective.

Change-Id: I186adc8cdf28e9c540ad22bca6684d9dd892976a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 10:58:41 +00:00
Stephen Finucane
1a6df700be compute: Add 'server * --all-projects' option
Add an '--all-projects' option to a number of commands:

- server delete
- server start
- server stop

This is in addition to 'server list', which already supports this
option.

This option allows users to request the corresponding action on one or
more servers using the server names when that server exists in another
project. This is admin-only by default.

As part of this work, we also introduce a 'boolenv' helper function that
allows us to parse the environment variable as a boolean using
'bool_from_string' helper provided by oslo.utils. This could probably be
clever and it has the unfortunate side effect of modifying the help
text in environments where this is configured, but it's good enough for
now.  It also appears to add a new dependency, in the form of
oslo.utils, but that dependency was already required by osc-lib and
probably more.

Change-Id: I4811f8f66dcb14ed99cc1cfb80b00e2d77afe45f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-21 10:54:27 +00:00
Zuul
bfa032cb18 Merge "Support remote-address-group in SG rules" 2021-01-20 17:03:39 +00:00
Rodolfo Alonso Hernandez
0cc878e5b0 Add device profile to `port`
Added device profile parameter to ``port create`` command.

Related-Bug: #1906602

Change-Id: I4c222ac334d3a0a0ee568ed1e0bc8518baa375e1
2021-01-19 14:42:46 +00:00
Zuul
6905e97565 Merge "compute: Improve 'server migration list' options" 2021-01-15 21:34:35 +00:00
Zuul
66e33b6edb Merge "compute: Add '--force' option to 'server delete'" 2021-01-15 21:34:25 +00:00
Zuul
fb564d20a5 Merge "compute: Add missing options for 'hypervisor list'" 2021-01-15 21:34:04 +00:00
Zuul
3864ceea26 Merge "compute: Add 'server volume update' command" 2021-01-15 04:09:58 +00:00
Zuul
1febc8cd03 Merge "Remove retired Karbor support" 2021-01-14 00:24:51 +00:00
Stephen Finucane
dfa869ed1d compute: Improve 'server migration list' options
Improve both the '--user' and '--project' options to allow names as well
as UUIDs. There's no release note included since this entire command was
added in change I15b4a5aca8d0dee59dd293e7b1c7272cdfbeea20, which hasn't
been included in a release yet.

Change-Id: I7654f3ffc54d38d5cfb03d8d1b2f4dc4fb06fb3d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-12 17:08:54 +00:00
Stephen Finucane
8a164bb09c compute: Add '--force' option to 'server delete'
This is an admin-only operation by default but can be useful.

Change-Id: I25a4da697e27c0fba4d28b504377667eb18f15fe
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-12 17:07:32 +00:00
Stephen Finucane
262e525aad compute: Add missing options for 'hypervisor list'
Yet more pagination parameters.

Change-Id: I9f0145c89ddc49c1d907e6e6e294319cf80fc6ff
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-12 17:07:23 +00:00
Hang Yang
e01e59caeb Support remote-address-group in SG rules
Add support for using remote-address-group in security group rules.

Change-Id: Ib1972244d484839943bc3cda07519a6c6d4b945a
Implements: blueprint address-groups-in-sg-rules
Depends-On: https://review.opendev.org/755644
2021-01-12 10:55:24 -06:00
Stephen Finucane
ca7f23d0d1 compute: Add 'server volume update' command
We're not going to expose the ability to swap volumes since that's a
things humans should not generally use. From the API docs [1]:

  When updating volumeId, this API is typically meant to only be used
  as part of a larger orchestrated volume migration operation initiated
  in the block storage service via the os-retype or os-migrate_volume
  volume actions. Direct usage of this API to update volumeId is not
  recommended and may result in needing to hard reboot the server to
  update details within the guest such as block storage serial IDs.
  Furthermore, updating volumeId via this API is only implemented by
  certain compute drivers.

We *do* want users to have the ability to change the delete on
termination behavior though, so that's what we expose.

[1] https://docs.openstack.org/api-ref/compute/?expanded=update-a-volume-attachment-detail#update-a-volume-attachment

Change-Id: I50938e1237b4d298521b26a5f9cb90c018dfebaf
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-12 16:29:07 +00:00
Zuul
d6646d714b Merge "network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc" 2021-01-12 13:54:11 +00:00
Stephen Finucane
dd89efd5ac network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc
Address comments left in the review for $subject.

Change-Id: I69449112027736152c9fb62f5fe427efd6a25107
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-12 10:07:58 +00:00
Zuul
d828b04c9f Merge "Support Neutron Address Group CRUD" 2021-01-11 17:38:26 +00:00
Zuul
8993d32188 Merge "Add 'server unshelve --wait' option" 2021-01-11 17:37:39 +00:00
Zuul
05cb650442 Merge "Add 'server shelve --offload', 'server shelve --wait' options" 2021-01-11 17:37:32 +00:00
Stephen Finucane
bb15b29190 Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747
Change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 introduced some
validation for the 'openstack server group create --policy' command.
Call this out in the release notes.

Change-Id: I7e00851a03470364db00f0f114fc724b0f686b72
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-11 14:24:48 +00:00
Stephen Finucane
d33eb3e1da Remove retired Karbor support
The Karbor project is being retired in Wallaby [1]. Remove the docs for
its client.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018643.html

Change-Id: I52d0f6a76cc9bcfc8b33f0e2cd3751859770ac8a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 18:43:05 +00:00
Stephen Finucane
2b073c2034 Add 'server unshelve --wait' option
This was recently added to the 'server shelve' command. Add it now for
the 'unshelve' command.

Change-Id: I633dd85b60cf70b4f8610f414d82669dd6a53111
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 18:01:29 +00:00
Stephen Finucane
64c2a1a453 Add 'server shelve --offload', 'server shelve --wait' options
The '--offload' option allows us to explicitly request that the server
be offloaded once shelved or if already shelved.

The '--wait' option allows us to wait for the shelve and/or offload
operations to complete before returning. It is implied when attempting
to offload a server than is not yet shelved.

Change-Id: Id226831e3c09bc95c34b222151b27391a844b073
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 18:01:25 +00:00
Stephen Finucane
d5026278ed compute: Add 'server volume list' command
This replaces the old 'nova volume-attachments' command.

Change-Id: Icb98766f98bd1f2469bdb6df62b4624711f98422
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 12:14:43 +00:00
Stephen Finucane
958344733a compute: Add missing options for 'server image create'
Add a '--property' option to record arbitrary key/value metadata to
'meta_data.json' on the metadata server.

Change-Id: I267f3290fce3692cbd1ff6a9af146c2736ee31fe
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 12:14:43 +00:00
Stephen Finucane
b349057220 tests: Remove unused fake method
The FakeServerMigration.get_server_migrations method was added in
change I15b4a5aca8d0dee59dd293e7b1c7272cdfbeea20 but has never been
used. Remove it.

Change-Id: I6089c5200737b9319a8e96f2a2fc18b7cdd6b2c6
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 12:14:43 +00:00
Stephen Finucane
fc24142ed4 compute: Add missing options for 'keypair list'
Add pagination parameters, '--limit' and '--marker'. This isn't
compatible with our client-side '--project' parameter so we error out
for that.

Change-Id: I403cf0fb7aabad4a3dfda5adae62d47ecf7faf5c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 12:14:43 +00:00
Stephen Finucane
8a0f3fc6a8 compute: Add missing options for 'server set'
Add a new '--no-password' option to unset the password on an existing
server. In addition, add a new '--password' option that replaces the
interactive '--root-password' option. This makes sense given no other
commands uses interactive password options.

Checks that rely on specific API microversions now run before we execute
any action, to avoid situations where an update is only partially
applied.

Change-Id: Ibf8717efdd418a2d95215b4d9ab2acf0d57c4a70
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-08 12:14:41 +00:00
Zuul
9a976ada8e Merge "compute: Add missing options for 'server list'" 2021-01-08 02:26:08 +00:00
Stephen Finucane
d0112a801a compute: Add missing options for 'server list'
This accepts a large number of options that we weren't exposing. Add the
following options: '--availability-zone', '--key-name',
'--config-drive' and '--no-config-drive', '--progress', '--vm-state',
'--task-state' and '--power-state'.

In addition, refine the 'openstack server list --status' parameter to
restrict users to the actual choices supported by the server.

Change-Id: Ieeb1f22df7092e66a411b6a36eafb3e16efc2fc2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-07 14:10:54 +00:00
Stephen Finucane
bbf7de83ff trivial: Use plural for appended parameters
Multiple compute commands take a '--property' parameter or variant
thereof. These should be stored in a 'properties' (plural) dest for
sanity's sake. Correct this.

Change-Id: If393836925fa736404527d9abd212b8ac9931027
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:57 +00:00
Yongli He
f200799848 compute: Add 'server show --topology' option
Add support for compute microversion 2.78 by adding a '--topology'
option to 'openstack server show' command that retrieves server NUMA
information.

Change-Id: Ie22979df2ea9082ca64a4d43b571bd4025684825
2021-01-06 12:02:25 +00:00
Stephen Finucane
a5c6470f2d compute: Add 'server group create --rule' option
This closes the remaining gap with the 2.64 compute API microversion.

Change-Id: Ia42b23d813b7af6ddb1a41f4e9bdc8a6160b908c
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:25 +00:00
Stephen Finucane
bf834f6d75 compute: Fix 'hypervisor show -f yaml' output
The 'cpu_info' field returned by the 'os-hypervisors' API is an object
and should be formatted as such.  However, this is complicated by the
fact that the object in this field is stringified until microversion
2.28 and is only returned as an actual object on later microversions.
Handle the conversion from the string for older microversions and
display things correctly for all releases.

Change-Id: Ide31466cbb9e89c96d6bd542fe039ab5ed1fac1f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:25 +00:00
Stephen Finucane
e2a9a9607c compute: Fix 'server group * -f yaml' output
Make use of 'FormattableColumn'-derived formatters, which provide better
output than what we were using before, particularly for the YAML output
format.

Change-Id: Id6d25a0a348596d5a0430ff7afbf87b049a76bc8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:25 +00:00
Stephen Finucane
af5e9d16e8 compute: Fix 'usage * -f yaml' output
Make use of 'FormattableColumn'-derived formatters, which provide better
output than what we were using before, particularly for the YAML output
format.

Change-Id: Ic770f27cb1f74222636f05350f97400808adffbf
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:25 +00:00
Stephen Finucane
03776d82e5 compute: Fix 'server * -f yaml' output
Make use of 'FormattableColumn'-derived formatters, which provide better
output than what we were using before, particularly for the YAML output
format. For example, compare before for the 'server show' command:

  $ openstack --os-compute-api-version 2.79 server show test-server -f yaml
  ...
  addresses: private=fdff:77e3:9bb4:0:f816:3eff:fe6d:a944, 10.0.0.44
  flavor: disk='1', ephemeral='0', extra_specs.hw_rng:allowed='True', original_name='m1.tiny',
    ram='512', swap='0', vcpus='1'
  ...

To after:

  $ openstack --os-compute-api-version 2.79 server show test-server -f yaml
  ...
  addresses:
    private:
    - fdff:77e3:9bb4:0:f816:3eff:fe6d:a944
    - 10.0.0.44
  flavor:
    disk: 1
    ephemeral: 0
    extra_specs:
      hw_rng:allowed: 'True'
    original_name: m1.tiny
    ram: 512
    swap: 0
    vcpus: 1
  ...

Similarly, compare before for 'server list':

  $ openstack --os-compute-api-version 2.79 server list -f yaml
  - ...
    Networks: private=fdff:77e3:9bb4:0:f816:3eff:fe6d:a944, 10.0.0.44
    Power State: Running
    Properties: ''
    ...

To after:

  $ openstack --os-compute-api-version 2.79 server list -f yaml
  - ...
    Networks:
      private:
      - fdff:77e3:9bb4:0:f816:3eff:fe6d:a944
      - 10.0.0.44
    Power State: 1
    Properties: {}
    ...

We also fix the human-readable output for the 'tags' field.

Before:

  $ openstack --os-compute-api-version 2.79 server list
  ...
  | tags   | ['bar', 'foo']  |

After:

  $ openstack --os-compute-api-version 2.79 server list
  ...
  | tags   | bar, foo  |

Change-Id: I7a8349106e211c57c4577b75326b39b88bd9ac1e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-01-06 12:02:24 +00:00
Zuul
f2c49142f0 Merge "trivial: Cleanup docs for 'server list'" 2021-01-06 11:41:12 +00:00
Zuul
f6cad0c9d5 Merge "compute: Add missing options for 'server rebuild'" 2021-01-06 11:30:53 +00:00
Zuul
b663e8a080 Merge "Add 'flavor list --min-disk', '--min-ram' options" 2021-01-06 11:16:49 +00:00
Zuul
23afc0af92 Merge "image: Unset properties rather than setting to None" 2021-01-06 11:16:25 +00:00
youngho choi
6f616a29b3 Add support '--progress' option for 'image create'
openstack-client doesn’t support the upload progress bar.

This patch shows progressbar when create image
if you added '--progress' option like a python-glanceclient.

like this.
[=============================>] 100%
+------------------+---------------------------+
| Field            | Value                     |
+------------------+---------------------------+
| container_format | bare                      |
| created_at       | 2020-09-06T20:44:40Z      |
...

How to use
Add the'--progress' option on the 'openstack image create' command.

Code was written by referring to 'python-glanceclient' project
on stable/ussuri branch

Change-Id: Ic3035b49da10b6555066eee607a14a5b73797c00
task: 40003
story: 2007777
2021-01-04 17:25:34 +00:00
Hang Yang
f57e10b903 Support Neutron Address Group CRUD
Add support for Neutron address group CRUD operations. Subsequent patches
will be added to use address groups in security group rules.

Change-Id: I3c313fc9329837dde67815901528a34dca98ebcc
Implements: blueprint address-groups-in-sg-rules
Depends-On: https://review.opendev.org/738274
Depends-On: https://review.opendev.org/745594
2020-12-24 11:27:23 -06:00
Zuul
f083fc685b Merge "Change 'Volume' to 'Block Storage'" 2020-12-22 19:20:49 +00:00
Stephen Finucane
29a7c9afce image: Unset properties rather than setting to None
Currently, we attempt to unset an image property by setting it to None.
This doesn't work for known properties and is rightly rejected by the
Glance API with the following error:

  BadRequestException: 400: Client Error for url:
  http://172.20.4.87/image/v2/images/368c5751-2b0b-4a38-a255-fd146fe52d31,
  Bad Request

The solution is to actually unset the field by deleting it.

Change-Id: Ie156bedbe0f9244f82c81401679706f484caf9aa
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: #2008463
Task: #41493
2020-12-22 17:11:32 +00:00
Zuul
d10706a8db Merge "Add project field in image list subcommand" 2020-12-22 13:49:26 +00:00
Zuul
0fd090eff3 Merge "Add name and enabled param in ListDomain parser" 2020-12-22 13:30:59 +00:00
Zuul
b3e69a2adb Merge "Add option to filter instances by AZ" 2020-12-22 13:30:55 +00:00
okozachenko
3c80b1b3b2 Add project field in image list subcommand
The motivation is to filter the image by owner

Change-Id: I1f08da175a06e62a844f76b0ec18cb3332efef86
2020-12-15 00:45:30 +02:00
Stephen Finucane
054562238d trivial: Cleanup docs for 'server list'
Change-Id: I2f2033a8d49ee42eb21696a9cd28e63ad9712fad
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-09 18:38:26 +00:00
Stephen Finucane
f9fd3642f8 compute: Add missing options for 'server rebuild'
This accepts a large number of options that we weren't exposing. Add the
following options: '--name', '--preserve-ephemeral', '--user-data',
'--no-user-data', '--trusted-image-cert' and '--no-trusted-image-certs'.
In addition, rename the '--key-unset' parameter to '--no-key-name', to
mimic e.g. '--no-property' on other commands.

Change-Id: I61c46e18bef1f086b62a015ebdc56be91071b826
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-09 18:38:26 +00:00
Stephen Finucane
da03bd80e3 Add 'flavor list --min-disk', '--min-ram' options
Allow us to filter on minimum disk and RAM, and close another gap with
novaclient.

Change-Id: Ib3f0bdf419675e1c35c3406fbac8a4c18ac56a33
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-09 15:28:12 +00:00
Stephen Finucane
f5b185c357 Make use of comparable 'FormattableColumn' subclasses
This requires fixes found in cliff 3.5.0 [1] and osc-lib 2.3.0 [2]. With
these fixes in place, we can remove the icky, still broken
'assertItemEqual' and 'assertListItemEqual' helpers.

[1] https://review.opendev.org/761421
[2] https://review.opendev.org/761394

Change-Id: Id6c26b37c3c7d5ec6761361abca57f9219b76838
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-09 15:17:25 +00:00
Zuul
0edd055f3f Merge "Remove retired Searchlight support" 2020-12-09 12:18:55 +00:00
Ghanshyam Mann
a79e7db4ae Remove retired Searchlight support
Searchlight project is retiring in Wallaby cycle[1].
This commit removes the support/usage of Searchlight project
before its code is removed.

Needed-By: https://review.opendev.org/c/openstack/searchlight/+/764526

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018637.html

Change-Id: Idad97343b9ce66186d50ee0560a2fded66655f9b
2020-12-08 19:48:54 +00:00
Stephen Finucane
ecfda7654e Update lower-constraints
This had gotten pretty out-of-date and included a whole load of OSC
plugins which I don't think we need to track from here. This updated
version is simply generated via 'pip freeze' using pip >= 20.3, which
includes the new dependency resolver.

Change-Id: I4fb0b69dbd538f313c6fef97126c22078904c69f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-08 11:20:44 +00:00
Stephen Finucane
20769cd7b2 Fix lower-constraints job
pip 20.3 finally includes a proper dependency resolver. Its use is
causing the following error messages on the lower-constraints job:

  ERROR: Cannot install ... because these package versions have
  conflicting dependencies.

  The conflict is caused by:
      bandit 1.1.0 depends on PyYAML>=3.1.0
      cliff 3.4.0 depends on PyYAML>=3.12
      openstacksdk 0.52.0 depends on PyYAML>=3.13

Bump our lower constraint for PyYAML to resolve this issue. With that
resolved, we see a new issue:

  ERROR: Could not find a version that satisfies the requirement
  cryptography>=2.7 (from openstacksdk)
  ERROR: No matching distribution found for cryptography>=2.7

This is less self-explanatory but looking at the lower-constraints for
openstacksdk 0.52.0 shows a dependency on cryptography 2.7 [1], meaning
we need to bump this also.

Next up, flake8-import-order seems to cause the dependency resolver to
go nuts, eventually ending with the following error message in a Python
3.6 environment:

  Using cached enum34-1.1.2.zip (49 kB)
    ERROR: Command errored out with exit status 1:
     command: ...
         cwd: ...
    Complete output (9 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File ".../lib/python3.6/site-packages/setuptools/__init__.py", line 7, in <module>
        import setuptools.distutils_patch  # noqa: F401
      File ".../lib/python3.6/site-packages/setuptools/distutils_patch.py", line 9, in <module>
        import re
      File "/usr/lib64/python3.6/re.py", line 142, in <module>
        class RegexFlag(enum.IntFlag):
    AttributeError: module 'enum' has no attribute 'IntFlag'
    ----------------------------------------

A quick Google suggests this is because the enum34 package is not
complete [2]. We shouldn't even be using it since our base virtualenv
should at least use Python 3.6, but I guess some dependency doesn't
properly restrict the dependency to <= Python 3.4. This is moved from
'test-requirements.txt' to 'tox.ini' since we don't need to use our
constraints machinery for linters.

Finally, the versions of bandit and hacking that pip is bringing in both
requires in a newer version of babel, which in turn requires a new
version of pytz.

  Collecting hacking>=2.0.0
  ...
  ERROR: Cannot install oslo.i18n because these package versions have
  conflicting dependencies.
  The conflict is caused by:
      babel 2.9.0 depends on pytz>=2015.7
      babel 2.8.1 depends on pytz>=2015.7
      babel 2.8.0 depends on pytz>=2015.7
      babel 2.7.0 depends on pytz>=2015.7

Seeing as we shouldn't be tracking bandit in
lower-constraints, I'm not sure why we're want to bump these
dependencies for just that. As above, we move these dependencies out of
'test-requirements' and into 'tox.ini' since we can do that for linters.

[1] https://opendev.org/openstack/openstacksdk/src/tag/0.52.0/requirements.txt#L19
[2] https://github.com/iterative/dvc/issues/1995#issuecomment-491889669

Change-Id: I8ec738fbcabc8d8553db79a876e5592576cd18fa
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-08 10:55:57 +00:00
Zuul
fe98069c20 Merge "trivial: Cleanup docs for 'server rebuild'" 2020-12-05 21:27:53 +00:00
Artem Goncharov
30d5f14a70 Add support for token caching
SDK starts caching token in keyring (when available and configured). A
small change is required in OSC not to reject this state.
Overall this helps avoiding reauthentication upon next openstack call.
If token is not valid anymore automatically reauthentication is done.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/735352
Depends-On: https://review.opendev.org/c/openstack/osc-lib/+/765650
Change-Id: I47261a32bd3b106a589974d3de5bf2a6ebd57263
2020-12-05 15:40:24 +01:00
Zuul
d0fd1ffe0a Merge "Switch compute aggregate functions to SDK" 2020-12-05 10:04:28 +00:00
Zuul
ba6433866d Merge "Switch compute flavors from novaclient/direct to SDK" 2020-12-05 10:04:23 +00:00
Stephen Finucane
ceaba4c572 trivial: Cleanup docs for 'server rebuild'
Use consistent help strings and error messages.

Change-Id: I42647a6b7e67ce4b8dd5f826e20802ade691c266
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-12-03 11:59:21 +00:00
pedro
d688cb58a3 Add documentation about login with federation
The documentation presents the parameters necessary
to authenticate via federation (using password) and do
a brief description of each parameter used in the process.

Change-Id: Iae3b6d0b56ebd2bbbb94f9f3637b5086e75559a7
2020-12-02 08:42:39 -03:00
Artem Goncharov
f36a34b675 Switch compute aggregate functions to SDK
Continue journey towards having OSC consuming SDK for nova part.

Depends-On: https://review.opendev.org/#/c/762131/
Change-Id: Id16e6c47aa93f02f15f49e1f59f73fecaa3e3b80
2020-12-02 11:24:51 +00:00
Artem Goncharov
0f4f42b652 Switch compute flavors from novaclient/direct to SDK
Let's switch flavors from novaclient or direct API requests onto using
SDK. Microversion agreement comes out of the box.

SDK normalizes property names, while OSC uses server side names. In
order not to break OSC users continue using server-side names.

Depends-On: https://review.opendev.org/#/c/762989/
Change-Id: I62b2ed8488ee4ac9c42051311bcfb455506ddd90
2020-12-02 11:24:42 +00:00
Zuul
ea358057f8 Merge "stop image downloads to memory" 2020-12-02 04:45:15 +00:00
Zuul
d4a0bcf8b3 Merge "Add NODE and HOST parameters in "server create" help text" 2020-12-01 22:46:10 +00:00
Zuul
2d95558ac5 Merge "Let autoprogram-cliff know who's running" 2020-12-01 22:03:55 +00:00
Zuul
30828112cf Merge "Remove None valued network quota entries" 2020-12-01 13:51:20 +00:00
Zuul
c7a43773c9 Merge "Add id and enabled param in ListIdentityProvider parser" 2020-12-01 13:50:56 +00:00
Eric Fried
284c38bcf2 Let autoprogram-cliff know who's running
The autoprogram-cliff directive has a habit of producing text like

  This command is provided by the $me plugin.

which doesn't make any sense.

Cliff recently added a config option whereby consumers can let it know
who $me is so it can suppress that message where appropriate (while
still producing it for $plugin, as intended).

Depends-On: https://review.opendev.org/692464
Change-Id: I0d580fb1d34dd56740eb6d976caa795e0e951047
2020-12-01 11:54:59 +00:00
yanpuqing
3e8968af3d Add NODE and HOST parameters in "server create" help text
Add optional parameters "NODE" and "HOST" in the help text of the
server create comand for --availability-zone.

Co-Authored-By: tianhui <tianhui@awcloud.com>
Change-Id: I4faea8a3d3aecb21ec535e55c238c71745fc68cb
Task: 24274
Story: 2003313
2020-12-01 11:49:36 +00:00
Dmitriy Rabotyagov
0f02029d91 Add option to filter instances by AZ
Since nova API microversion 2.83 it is possible for users to filter
instances by AZ. However even before that this functionality was available
for admin role.

Change-Id: Ife4c8e81aad2ff1dde50d9f23913d9dd9397b00c
2020-12-01 13:44:23 +02:00
Simon Merrick
5bdcd590ec stop image downloads to memory
+ Fixes issue with large images hogging memory
 + stream image downloads
 + output to stdout if file not specified

Change-Id: Ia01ff9b21a2dac5d0ccf2bd58a8640e88c5cbb36
Story: 2007672
Task: 39776
2020-11-25 21:25:22 +13:00
Rodolfo Alonso Hernandez
8387b114e3 Add "fields" parameter to ListPort query
This new query parameter will allow to send a query to the Neutron
server filtering only by those parameters needed by the list
command: ID, name, MAC address, fixed IPs and status.

When using input parameter "long", security groups IDs, device owner
and tags will be added to the fields filter.

With 4500 ports, those are the execution times for the command
"openstack port list" (average values in a development environment):

                 Neutron API (seconds)  CLI (seconds)
Without filter:  3.05                   10.15
With filter:     2.76                   8.19

Depends-On: https://review.opendev.org/#/c/754113/

Change-Id: I1cccf0bc3533f8085e8dd61bf2fbe78c49b74b31
Closes-Bug: #1897100
2020-11-18 17:42:14 +00:00
Zuul
7146deef00 Merge "update lower-constraints.txt" 2020-11-18 13:28:59 +00:00
Zuul
73d56bc8d4 Merge "Add a few selectable fields to the "openstack server list" output" 2020-11-18 13:28:55 +00:00
Zuul
7d624cc78a Merge "trivial: Document removal of support for agents" 2020-11-18 01:22:02 +00:00
Zuul
bba5725085 Merge "Switch 'openstack keypair' ops to use SDK" 2020-11-17 14:53:12 +00:00
Zuul
2005a1e833 Merge "Allow to resize in-use volumes" 2020-11-17 14:51:42 +00:00
Stephen Finucane
a5101a4139 trivial: Document removal of support for agents
We can't remove these commands for a long time, given OSC's intention to
support multiple releases of OpenStack, but we can at least indicate to
users that this thing might not work anymore.

Change-Id: I9093cc1197a0287984d83e2020fba100d0c958b3
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-11-17 11:44:31 +00:00
Zuul
24edeb24a6 Merge "tests: Remove 'agent' functional tests" 2020-11-16 21:37:18 +00:00
Stephen Finucane
ebaf0eae2c tests: Remove 'agent' functional tests
The 'os-agents' API was recently removed from nova [1]. Remove the
functional tests, since they will always fail going forward but will
continue to run on older stable branches.

Also Squeeze https://review.opendev.org/#/c/762559/ inside, since those
2 are simultaneously blocking gate

[1] https://review.opendev.org/#/c/749309/

Change-Id: I0bf7d4c0ba2a9d4637db0d209d8d52163d772f12
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-11-16 15:54:27 +01:00
Zuul
ce31c417de Merge "Resolve issues with 'server migration list'" 2020-11-12 11:20:21 +00:00
Dmitriy Rabotyagov
4c0bfb03fc Allow to resize in-use volumes
Since Pike (microversion 3.42) [1] Cinder API allows to resize in-use
volumes. So no reason not to implement it in CLI.

[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/api/openstack/rest_api_version_history.rst#user-content-section-39

Change-Id: I22462a56d261e0a100aac3f27af7be47223edec0
2020-11-11 09:18:49 +00:00
Zuul
e2bd1530cf Merge "functional: Remove test for 'quota set --force'" 2020-11-09 18:50:43 +00:00
Zuul
4d3bad9f19 Merge "Add 'openstack server evacuate' command" 2020-11-09 16:56:19 +00:00
Stephen Finucane
1a5dd4af5b Resolve issues with 'server migration list'
The 'os-migrations' API accepts 'instance_uuid' and 'migration_type'
query string parameters, not 'server' and 'type'. For the former, as the
name would suggest, the value should be a server UUID, not a name.

In addition, this is a list command and therefore should subclass the
'Lister' base class.

Change-Id: I736f5575156fc04d7ada7783a1865ab3b438396f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-11-09 15:05:54 +00:00
Artem Goncharov
512ba114a1 Switch 'openstack keypair' ops to use SDK
Let's continue our journey and start using SDK for the keypair
operations

Depends-On: https://review.opendev.org/#/c/761883/
Change-Id: Id411e70b8e1a79c0e88a0e22be7ff37e5c30fcda
2020-11-09 13:14:53 +01:00
Stephen Finucane
ffd7e93961 functional: Remove test for 'quota set --force'
Change I1d1ac1ac46f49f64794ffc8631e166935537966c introduced the 'quota
set --force' parameter to force set nova quotas. As part of that fix, we
introduced a functional test, 'QuotaTests.test_quota_set_force' that
works by attempting to set the 'limit' of the quota for instances to the
current usage ('is_use') minus one.

This test is flawed. It doesn't create any instances so when it fires by
itself, it will always set the 'limit' to 0. When it fires at the same
time as other tests (remember, we run tests in parallel), notably tests
that rely on booting instances, it can cause other tests to fail with
the following error:

  Quota exceeded for instances: Requested 1, but already used 0 of 0
  instances (HTTP 403)

We could attempt to work around this by creating a new project and using
that project to fiddle with quotas. That's a lot of work though, and the
returns are questionable: the 'quota set' command is an admin-only
command by default and the '--force' parameter should almost never be
used. Simply remove this test.

Change-Id: Ic07ff6f4a7c1c27852c892eb906bb144aae91788
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: #2008327
Task: #41225
2020-11-06 17:40:13 +00:00
Stephen Finucane
4d3a3bb28f Remove unnecessary test
As noted, we're simply testing the default behavior of Python 3 in this
test. Remove it, now that this is the only version(s) of Python 3 we
have to worry about.

Change-Id: I5f07343df8334457d907086033d5685f59c0bf0e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-11-06 10:16:06 +00:00
Stephen Finucane
0a7f2692c6 Remove references to Python 2.7
We don't support it anymore. This is just noise now.

Change-Id: I3640e7d8e520db69f83f95e9c7759279f7c15008
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-11-05 14:15:37 +00:00
jay
311f4130d2 Add a few selectable fields to the "openstack server list" output
Added ``-c project_id | user_id | created_at`` to ``openstack server list``
    command to get these columns as an output.

Change-Id: I18991adf899c7b72c98bb89871bf0715d35943f0
Story: 2007925
2020-11-05 14:01:12 +01:00
Zuul
cb6659d7cd Merge "Compute: Add user id support for keypair" 2020-11-04 00:28:41 +00:00
Zuul
71cdb113fe Merge "Add 'openstack server migration list --type' option" 2020-11-03 12:58:49 +00:00
Zuul
a40d22f1ed Merge "Fix formatting of the flavor properties" 2020-11-03 10:07:13 +00:00
Zuul
4cdc953888 Merge "Add support for 'keypairs list --project' parameter" 2020-11-02 17:23:23 +00:00
Sean Mooney
01eb4e8393 Add 'openstack server evacuate' command
This change adds a new 'openstack server evacuate' command to provide
parity with the 'nova evacuate' command. The term "evacuate" is
notoriously poor, in that it implies the instance is moved rather than
recreated, but it is retained since people are familiar with it now.

Change-Id: I1e32ca51036c501862d8e89b3144a9695d98a06f
2020-11-02 17:08:17 +00:00
Zuul
2ffd06b3d5 Merge "Switch console url show operations to SDK" 2020-11-02 17:00:51 +00:00
Artem Goncharov
ad3369ed1f Fix formatting of the flavor properties
Do not stringify flavor properties to allow proper output formatting to
json/yaml/etc

Change-Id: I9f4c42acb85b726af87123134dd19de98fe95074
2020-11-02 15:09:09 +01:00
He Jie Xu
17f641e1c3 Compute: Add user id support for keypair
This patch adds functionality of specific the user id when create,
delete, show and list keypairs.

Change-Id: Ib826f1f4f5a73d1875ba0f02e124b3222c4d05ed
Co-Authored-By: tianhui <tianhui@awcloud.com>
2020-11-02 12:55:04 +00:00
Zuul
7fdbc6b8af Merge "Add support for 'keypairs list --user' parameter" 2020-11-02 12:06:41 +00:00
Zuul
987af4e390 Merge "trivial: Rework 'CreateServer' function" 2020-10-30 17:30:35 +00:00
Stephen Finucane
7c239403e9 trivial: Rework 'CreateServer' function
This rather complex function has had stuff tacked on over the years.
Help make working with it a bit easier through liberal application of
whitespace and some nicer indentation. Some option help text is improved
based on changes to modern nova.

Change-Id: I8154dd395dd904c3bcd180a7d0f9037b7e0be64f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-29 11:43:23 +00:00
likui
9b02f37e8f update lower-constraints.txt
We also need to change the lower-constraint requirements to make them
py3.8 compatible. See https://bugs.launchpad.net/nova/+bug/1886298

MarkupSafe==1.1.1
paramiko==2.7.1

Change-Id: I04a0fcd98327b9f41e24e19bcab97c813760f414
2020-10-29 09:54:32 +08:00
Zuul
c4e7a7e803 Merge "Replace deprecated UPPER_CONSTRAINTS_FILE variable" 2020-10-28 22:18:58 +00:00
Elod Illes
5b04a86d1f Replace deprecated UPPER_CONSTRAINTS_FILE variable
UPPER_CONSTRAINTS_FILE is deprecated and TOX_CONSTRAINTS_FILE is
the new environment variable name that replaces it [1].

[1] https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file

Change-Id: Ic0d2dcf20f7929733deb10a275e5d67f9627428f
2020-10-28 12:37:58 +01:00
Artem Goncharov
e05d39abb5 Switch console url show operations to SDK
Switch from using novaclient to SDK for openstack console url show operation.

Depends-On: https://review.opendev.org/756286
Change-Id: Ibe247825148788c549c2c1e991aae92338cdf557
2020-10-24 10:19:52 +02:00
Stephen Finucane
5f650853f7 Remove references to setuptools
Newer versions of cliff and stevedore use importlib rather than
setuptools to work with entry points. Replace any references to
"setuptools' entry points mechanism" with "Python's entry points
mechanism".

Change-Id: Iae36155685ee37ab5e38a0c173110a5ece33d05d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-22 09:52:57 +01:00
Zuul
66f5fa18d4 Merge "Remove the unused coding style modules" 2020-10-22 04:47:31 +00:00
Zuul
deae091f78 Merge "Validate 'server group create --policy' option" 2020-10-21 20:05:12 +00:00
Zuul
0228790024 Merge "Cleanup of 'server migration list' command" 2020-10-21 19:57:47 +00:00
Zuul
eb75c44656 Merge "Switch openstack console log show operation to use OpenStackSDK" 2020-10-21 16:19:21 +00:00
wu.chunyang
f464bba792 Remove the unused coding style modules
Python modules related to coding style checks (listed in blacklist.txt in
openstack/requirements repo) are dropped from lower-constraints.txt
they are not needed during installation.

Change-Id: Id735af397e8d41ad3ff583386844d4131fc9e12c
2020-10-21 23:44:33 +08:00
Zuul
77a45fe685 Merge "Compute: Add tag support for server add fixed ip" 2020-10-15 17:42:50 +00:00
Zuul
d59057ad3d Merge "Compute: Add tags support for server" 2020-10-14 17:38:33 +00:00
Zuul
96658a3116 Merge "Restore behavior of image create with same name." 2020-10-14 09:59:54 +00:00
Stephen Finucane
5645fad762 Add support for 'keypairs list --project' parameter
It would be lovely to do this server side but doing so requires a new
microversion, a blueprint and a spec. This is less performant but should
do the trick for the odd time users want to do this.

Change-Id: I26e7d38966304dd67be5da8ed0bb24f87191b82f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-14 10:27:05 +01:00
Stephen Finucane
98a0016cfa Add support for 'keypairs list --user' parameter
This has been supported by nova and novaclient since the veritable dark
ages. Add it to OSC.

Change-Id: Ifc95e7dd6c00807c80e87e10046ab154d0989014
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-14 10:25:50 +01:00
tianhui
2f76bfa3a6 Compute: Add tags support for server
Change-Id: If065602792958ff0145ae9f2e05f5b7a3177905c
Story: 2002006
Task: 19641
2020-10-14 09:53:26 +01:00
Zuul
6216025e9d Merge "Compute: Add tag support for server add volume" 2020-10-14 03:46:06 +00:00
Zuul
f083d42972 Merge "Add 'server migration force complete' command" 2020-10-14 03:46:00 +00:00
Zuul
91027a501f Merge "Add 'server migration abort' command" 2020-10-14 03:45:54 +00:00
Zuul
247ca75d26 Merge "compute: Add --password option for openstack server create" 2020-10-13 23:26:25 +00:00
Zuul
2eeab20eca Merge "Always display direction for security group rules" 2020-10-13 23:26:24 +00:00
Zuul
73765da310 Merge "Compute: Add 'keypair create --type' parameter" 2020-10-13 14:53:12 +00:00
Stephen Finucane
ab0b1fe885 Validate 'server group create --policy' option
We were documenting that some of these policies were only supported with
specific microversions, however, we weren't actually enforcing that,
leading to a poor user experience. Correct this.

Change-Id: Ic3c555226a220efd9b0f27edffccf6c4c95c2747
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-13 15:35:21 +01:00
Stephen Finucane
bf35f04682 Add 'openstack server migration list --type' option
Another gap with novaclient closed.

Change-Id: Id3ca95ceda6f438fa72496ab9ab15ac09bb64fa5
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-13 15:14:09 +01:00
Stephen Finucane
5fd399eaba Cleanup of 'server migration list' command
Address some post merge nits.

Change-Id: Ie59521d81fab191194f6c1a114b007fa17f5299f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-13 15:09:55 +01:00
jay
08b0e5855b Add 'server migration force complete' command
This is equivalent to novaclient's 'live-migration-force-complete'
command.

Change-Id: Ic4dc639afa16cdf8c5a46774895e850d92985292
Story: 2007513
Task: 39293
2020-10-13 14:17:28 +01:00
hackertron
1c3cf11331 Add 'server migration abort' command
This is equivalent to nova client's 'live-migration-abort' command.

Change-Id: I0ff520ccfdf2de52c427affad7bef4554c86a06f
Story: 2007489
Task: 39210
2020-10-13 14:17:25 +01:00
Zuul
375fe31525 Merge "Add source_ip_prefix and destination_ip_prefix to metering label rules" 2020-10-13 12:21:15 +00:00
Zuul
1a0bf01497 Merge "zuul: Stop testing against Tempest" 2020-10-13 10:23:13 +00:00
Zhaokun Fu
fd9a235de3 compute: Add --password option for openstack server create
Change-Id: Iaf923200efe023655a58ac5acac0b087d2fd5366
Story: #1708570
Task: #13780
2020-10-13 10:37:38 +01:00
Zuul
3cc81dded3 Merge "Remove oslo.utils" 2020-10-13 07:22:37 +00:00
Zuul
44f842b1f8 Merge "Add an error message when server bind floating IP" 2020-10-13 04:59:42 +00:00
Zuul
1bac625d47 Merge "Compute: Add tag support for server add network" 2020-10-13 03:42:52 +00:00
Zuul
ce563f08ba Merge "Compute: Add tag support for server add port" 2020-10-13 01:36:46 +00:00
Monty Taylor
9385113d40 Remove oslo.utils
Oslo things are really server-side oriented and are heavy-weight
for client things. Remove oslo.utils and just use iso8601 and
importlib directly. It's not actually a bad library, but pulling
it and its other deps in just for a couple of wrapper methods
is a bit much here.

oslo.i18n, fwiw, is lightweight and helpful.

Change-Id: I463993170c03a1d98c47ab6a3c19131b7fca1099
2020-10-12 17:29:57 +01:00
Stephen Finucane
671f73694a zuul: Stop testing against Tempest
Neither Tempest itself nor any of the service projects use OSC. As such,
there's no reason to run Tempest jobs here. It's simply a waste of
resources.

Change-Id: I74b0b196fe59e5e1462e3dadc659cf6680a53f80
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-10-12 17:25:03 +01:00
yanpuqing
415545ab9f Add an error message when server bind floating IP
If we add a floating IP for the server with no fixed IP, CLI doesn't
report an error and nothing happens. The patch adds an error message
when the server which don't have fixed IP bind floating IP.

Change-Id: I400f2bab08521bb7fa443d87c7f45cc79eb80694
Task: 27941
Story: 2004346
2020-10-12 17:09:19 +01:00
Zuul
ad2ac13c97 Merge "Add server migration list CLI" 2020-10-12 16:01:52 +00:00
tianhui
742c80a825 Compute: Add tag support for server add fixed ip
Change-Id: I62ed4729dead9f91630d1f568c834c9642965558
Story: 2002195
Task: 21679
2020-10-12 15:25:09 +01:00
tianhui
6f1602312b Compute: Add tag support for server add network
Change-Id: I31a66b2d4dac44052a71f43a5a67836247ccac64
Story: 2002195
Task: 21678
2020-10-12 15:19:27 +01:00
tianhui
4855fef8b8 Compute: Add 'keypair create --type' parameter
Change-Id: I2d251e1b97fb9a8069431c867fb7fc5f42d1fd6e
Story: 2002606
Task: 22225
2020-10-12 12:25:11 +01:00
tianhui
f3fbb1b648 Compute: Add tag support for server add port
Change-Id: Ice6bf5fb57afeb10862c870b42732dcf166772d1
Story: 2002195
Task: 21676
2020-10-12 11:37:20 +01:00
Zuul
a48c05b90a Merge "Remove usage of six" 2020-10-09 19:37:48 +00:00
tianhui
1c7fe3b6bd Compute: Add tag support for server add volume
Change-Id: Id9f2e09426f6824e9ca672bf7808b5165c650a69
Story: 2002195
Task: 21675
2020-10-09 17:31:14 +01:00
Zuul
960004dcc7 Merge "Add 'openstack server create --use-config-drive'" 2020-10-09 10:43:59 +00:00
songwenping
c2df9215e1 Remove usage of six
With python3.x, classes can use 'metaclass=' instead of
'six.add_metaclass', 'six.iteritems' and 'six.iterkeys' can
be replaced by 'items' and 'keys', 'six.moves.urllib.parse'
can be replaced by 'urllib.parse', 'six.StringIO' and
'six.moves.cStringIO' can be replaced by 'io.StringIO',
'six.text_type' and 'six.string_type' are just 'str'.

Change-Id: I84848c0bf8ab3c36dd821141191e2725e4e3b58b
2020-10-07 02:15:25 +00:00
Artem Goncharov
74db8dd65d Switch openstack console log show operation to use OpenStackSDK
A short switch onto SDK for fetching console logs of the server

Change-Id: I3f750ea4f13a4e72272aa67ea4506bd7182b13f9
2020-10-06 15:04:02 +02:00
pedh
f50bd40866 Fix: port attribute name propagate_uplink_status
Change the incorrect port attribute name "uplink_status_propagation"
to "propagate_uplink_status".

Change-Id: Icd7c49af8d988a6e3a52a58c784bd701b2d36faf
Closes-Bug: #1891873
2020-10-06 10:16:58 +00:00
Sam Morrison
17678c9bd6 Restore behavior of image create with same name.
With 60e7c51df4 the behaviour of
`openstack image create` changed so that you can't create an image
with the same name. This patch restores the previous functionality.

Story: 2008229
Task: 41069

Change-Id: Ia0f4920371a918e94d1ccf9fcfcbf90ff885a455
2020-10-06 14:05:11 +11:00
OpenStack Release Bot
098a3fe2de Add Python3 wallaby unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I27a03e0b51aa7ffe3dcf82ad9bedd9109b016aa1
2020-10-02 20:49:43 +00:00
OpenStack Release Bot
63b46ac5ec Update master for stable/victoria
Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: I6c1a9cdff90f7073082fc057f0f11b184de5dc32
Sem-Ver: feature
2020-10-02 20:49:41 +00:00
Zuul
7046562919 Merge "bump py37 to py38 in tox.ini" 2020-10-01 13:14:02 +00:00
Zuul
652c1bbbe0 Merge "Remove install unnecessary packages" 2020-10-01 13:14:00 +00:00
Zuul
361502d82c Merge "Update developing.rst" 2020-10-01 13:13:58 +00:00
Zuul
eb5416a257 Merge "Fix --image-property option in 'create server'" 2020-10-01 05:52:39 +00:00
Zuul
3902efc292 Merge "Add API check for server_groups.create" 2020-09-30 20:35:00 +00:00
Zuul
2308a05733 Merge "Add API check for server_groups.list" 2020-09-30 20:34:55 +00:00
Zuul
e7b2528c4a Merge "Show words indicating booted from volume for server image" 2020-09-30 20:34:53 +00:00
Zuul
ce448fa50b Merge "Remove install unnecessary packages" 2020-09-30 20:33:38 +00:00
Zuul
03b9216318 Merge "Output correct json for security groups in 'openstack server show'" 2020-09-25 09:44:41 +00:00
zhangbailin
b77c28d295 Add server migration list CLI
Add ``openstack server migration list`` to fetch server migrations.

Part of blueprint add-user-id-field-to-the-migrations-table

Change-Id: I15b4a5aca8d0dee59dd293e7b1c7272cdfbeea20
2020-09-24 18:45:13 +08:00
maaoyu
4b709a2c04 Remove install unnecessary packages
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.

Change-Id: I35a367505b2b423c345b05519e4134113cb66648
2020-09-24 17:09:49 +08:00
asarfaty
e9bd4ef007 Remove None valued network quota entries
Since the openstack SDK still has the neutron-lbaas entries in the network quota,
but those are already deprecated [1], the 'opentack quota show' command shows those
as None value.
This fix removes those empty deprecated values from the output.

[1] https://review.opendev.org/#/c/658494/
Change-Id: I8dbdba2a029ea8e6a268ddf29627e1466a7e3a8a
2020-09-22 05:12:09 +00:00
wangzihao
cbc1fb08ec bump py37 to py38 in tox.ini
in 'victoria' cycle, we should test py38 by default.
and remove redundant python env.

Change-Id: I6426cc55ee9b6bee96620a8185fbdb39c24a68a8
2020-09-18 11:15:47 +08:00
jay
bae89b3014 Output correct json for security groups in 'openstack server show'
Fixes incorrect json output for 'openstack server show -f json'.
The security group json output groups all the json as one
for e.g. "security_groups": "name='group1'\nname='group2'"
The correct output should be
"security_groups" : [{"name" : "group1"}, {"name" : "group2"}]
properties and volumes_attached fields also has similar issue.

Story: 2007755

Change-Id: I1b1cac716329e0530400aff782c08000b21d8e1d
2020-09-14 15:22:27 +02:00
wu.shiming
5aeec30701 Remove install unnecessary packages
The docs and releasenotes requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.

Change-Id: I4403cee833448beb69afaec503519d5a951f7e34
2020-09-14 10:38:09 +08:00
Zuul
51aee432d9 Merge "Support tagging Neutron ports on creation" 2020-09-13 20:34:00 +00:00
Artem Goncharov
99b5adf9c6 Fix gate due to switch to focal
In focal we do not have libffi6.
cffi and greenlet versions in lower-contraints are too old.

Change-Id: Iab3634039845adb649c7fd69d1812b405a61433c
2020-09-11 10:25:56 +02:00
Myeongchul Chae
fbd2c00b89 Fix --image-property option in 'create server'
There was a problem that the '-image-property' option, which can be used
to create an instance, did not work as intended.

I found that there were two problems with this option.

First, I cannot select an image as its metadata.

The second is that when there are multiple images available, the desired
image may not be selected depending on the situation.

This patch solves these two problems.

I wrote the test case with these two problems considered together.

Change-Id: Ib2745d7e067056ff4ca8bfaf6cff492d0dacb73a
story: #2007860
2020-09-10 16:12:11 +00:00
likui
f0642bc05f Update developing.rst
Use unittest.mock instead of mock

Change-Id: Ib573e9d217b4f18ef4e7ba3ab581164be423cb26
2020-09-08 15:44:51 +08:00
Zuul
15d0bfc185 Merge "Add NUMA affinity policy parameter to "port"" 2020-09-07 16:11:00 +00:00
Miguel Lavalle
67700e6dd9 Support tagging Neutron ports on creation
This change adds support for tagging ports on creation

Co-Authored-By: Slawek Kaplonski <skaplons@redhat.com>

Change-Id: I3148a568664588eb2f529138f984859570c0fca1
Related-Bug: #1815933
2020-09-04 14:30:07 +02:00
Zuul
0566ad66a9 Merge "Allow openstack flavor set to update flavor description using name" 2020-09-03 22:01:16 +00:00
Rafael Weingärtner
58f1c90971 Add source_ip_prefix and destination_ip_prefix to metering label rules
As proposed in the RFE and then approved in the spec, we are adding to
the neutron metering rules two new parameters. The source IP prefix, and
destination IP prefix.

Partially-Implements: https://bugs.launchpad.net/neutron/+bug/1889431
RFE: https://bugs.launchpad.net/neutron/+bug/1889431

Depends-On: https://review.opendev.org/#/c/746586/
Change-Id: Ic44d88fabea0fffef2279f2f2c3d2b1da6426d4d
2020-09-02 17:26:00 -03:00
melanie witt
4a3c5207c1 Show words indicating booted from volume for server image
For a server booted from a volume, nova API does not store an image_id
and instead returns an empty string. Currently, openstackclient
similarly shows an empty string for Image Name and Image ID for servers
booted from volumes.

To aid CLI users in understanding the meaning of no image_id, we can
display the string "N/A (booted from volume)" in the image field if the
server was booted from a volume.

Change-Id: I9c62cf6fe23b2e934dcbf5ebbf706b2705d2e424
2020-08-27 20:24:48 +00:00
Lewis Denny
51a1ea65f4 Add API check for server_groups.create
The policies field has been replaced with the
policy field since Nova API version 2.64[1]

This commit adds a check to make sure the correct field is used.

[1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59

Change-Id: I06d3211937d822c26070b7f8ad757c365dcbb1bb
Story: #2007822
Task: #40101
2020-08-26 17:11:46 +10:00
Lewis Denny
ed6d8d9411 Add API check for server_groups.list
The policies parameter has been replaced with the
policy parameter since Nova API version 2.64[1]

This commit adds a check to make sure the correct parameter is used.

[1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59

Change-Id: Ia37beb7790884d6d15bec45074f446e64af1a2aa
Story: #2008041
Task: #40703
2020-08-21 14:57:29 +10:00
Zuul
95cc05bdf6 Merge "Bypass user and group verification in RemoveRole" 2020-08-13 06:29:54 +00:00
Lance Bragstad
e246732670 Bypass user and group verification in RemoveRole
Keystone let's users remove role assignments that reference non-existent
users and groups. This is nice when keystone backs to an identity store
like LDAP and users or groups are removed.

Previously, openstackclient would validate the user and group existed in
keystone before sending the request to delete the role assignment. This
commit updates the code to bypass that validation so that users can use
IDs to forcibly cleanup role assignments.

Change-Id: I102b41677736bbe37a82abaa3c5b3e1faf2475d5
Story: 2006635
Task: 36848
2020-08-12 12:24:17 -05:00
Zuul
b1477647fa Merge "Add system role assignment tests for users and groups" 2020-08-06 13:37:03 +00:00
Zuul
af28a2f664 Merge "Fix reverted osc-lib interface change" 2020-08-03 14:52:17 +00:00
Rodolfo Alonso Hernandez
454b219564 Add NUMA affinity policy parameter to "port"
Added port NUMA affinity policy parameter to "port create",
"port set" and "port unset" commands.

Change-Id: I48cacab275856af2911829f9b7176bb87fd039b3
Related-Bug: #1886798
2020-07-31 15:18:55 +00:00
Vishakha Agarwal
1e053babf4 Add id and enabled param in ListIdentityProvider parser
when doing openstack identity provider list --name xyz_id,
and openstack identity provider list --enabled CLI raising
error unrecognized arguments, whereas in api-ref document [1],
user can pass name and enabled as optional query param. This
addresses the above issue, by adding param --id and --enabled in
parser of ListIdentityProvider.

[1] https://docs.openstack.org/api-ref/identity/v3-ext/?expanded=list-identity-providers-detail#list-identity-providers

Change-Id: I59ce3a5f54700ba5a735f0b3b4b3b73b3a8658fa
2020-07-24 19:22:39 +05:30
mb711d
4e2aefb5fa Delete the testcases that arent needed anymore
The file test_examples.py has never worked since its written and and cli in
the example directory are covered by other functional tests for container,
flavor and object lists and they have better asserts. So, deleting the file

Change-Id: Ib9af40da96e66354fe878e79a80048a58f8dd6fe
2020-07-23 17:08:42 -04:00
Roger Luethi
0a8753dc3e Fix reverted osc-lib interface change
The patch https://review.opendev.org/#/c/673389/ introduced a regression
by changing the osc-lib interface.

Two conflicting attempts to fix the regression were launched:

1) Reverting the patch.

2) The patch https://review.opendev.org/683119 changes the exception
   from the generic CommandError back to a specific Forbidden exception.

   The patch https://review.opendev.org/683118 catches this exception
   and passes on, i.e. re-implements the same behavior as before.

The first idea was implemented, the initial patch reverted. The second
idea was partially implemented. The change in python-openstackclient
(683118) was merged. The change in osc-lib was approved but failed to
merge because the initial change had been reverted.

Now we have again a situation where the exception produced in osc-lib
does not match the exception expected by the caller.

It is unclear if the osc-lib interface will ever get a rebased version
of https://review.opendev.org/683119 merged, so the safest way to
address the issue is to also catch the exception that used to be
thrown before the inital change and is again thrown after the inital
change has been reverted.

Change-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c
2020-07-23 20:35:21 +02:00
Stephen Finucane
12f1e56ebf Add 'openstack server create --use-config-drive'
Despite what the help text for this options says, the nova API only
accepts boolean values for this value and has done so since at least the
introduction of the 2.1 microversioned API. While it would be nice to
convert '--config-drive' to a boolean flag, we'd need to be able to
retain temporary support for people passing arguments. 'nargs=?' [1]
looks promising but it has an annoying tendency to swallow a positional
argument following it [2]. Since that is not an option, we have to live
with a new config option, '--use-config-drive' and a '--no-config-drive'
counterpart.

[1] https://docs.python.org/3/library/argparse.html#nargs
[2] https://bugs.python.org/issue9338

Change-Id: If9cce0ad4094cc9cef1c9136b80c3b0f35a82c7a
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: #2005468
Task: #30547
2020-07-22 10:59:07 +01:00
Vishakha Agarwal
8628e52de7 Add name and enabled param in ListDomain parser
when doing openstack domain list --name xyz_id,
and openstack domain list --enabled CLI raising
error unrecognized arguments, whereas in api-ref
document [1], user can pass name and enabled as
optional query param. This addresses the above
issue, by adding param --name and --enabled in
parser of ListDomain.

[1]https://docs.openstack.org/api-ref/identity/v3/?expanded=list-domains-detail#list-domains

Change-Id: I3cdb511d3c7059ddfb802ca025188d8976c9302c
2020-07-21 18:24:58 +05:30
Felix Yan
82ebddca00 Fix compatibility issue in 5.3
The offending entry point object looks like:
EntryPoint(name='compute', value='openstackclient.compute.client',
group='openstack.cli.base')

Story: 2007917
Task: 40323
Change-Id: I0f3cc62e23efdc14203ce6645581d5ba5dbf7fa0
2020-07-14 08:06:55 -05:00
Lance Bragstad
a8aad9fec8 Add system role assignment tests for users and groups
I was writing some additional functionality and noticed these tests were
missing. This commit adds tests for adding and removing system role
assignments for users and groups.

Change-Id: I30fdc6ec55e1eb1cfa55f4cbf92c3f001d89865f
2020-07-10 08:09:51 -05:00
Zuul
8aed5feab8 Merge "Fix uploading an signed image does not work if private signing key is encrypted" 2020-07-08 17:30:38 +00:00
Zuul
fa517fbf44 Merge "Add a command to trigger entrypoint cache creation" 2020-07-08 17:30:36 +00:00
Zuul
9fb68eca44 Merge "Expose flag for forcing use of import for images" 2020-07-08 17:01:22 +00:00
Alexander Gräb
c06d825635 Fix uploading an signed image does not work if private signing key is encrypted
Change-Id: Ia7c84aa7b840bf92aeb7db7246d14119eb727b03
Story: 2007890
Task: 40269
2020-07-07 13:26:51 +02:00
Zuul
4b5053ac89 Merge "Make volume backup record commands available in v3" 2020-07-07 10:58:15 +00:00
Zuul
42692264f7 Merge "switch to stevedore for entry points" 2020-07-07 06:23:55 +00:00
Zuul
d0741d7853 Merge "Add '--force; parameter to 'openstack quota set'" 2020-07-06 20:50:24 +00:00
Monty Taylor
5c4eb0bf9d Add a command to trigger entrypoint cache creation
stevedore will cache the entrypoint scan when needed. Since we
just installed the things here, do an openstack --help to cause
the entrypoints to get scanned at build time and for the cache
file to be written into the container image.

Change-Id: I73502be6d68c4a38561c9524b4def3c6a6f61ac6
2020-07-06 14:53:50 -05:00
Doug Hellmann
870cf01148 switch to stevedore for entry points
Importing pkg_resources scans every installed distribution to find
all of the entry points. Stevedore is adding a new caching layer using
importlib.metadata, which will not.  Switching to the stevedore should
eventually speed up load times, especially for command line apps. This
change makes the switch now to ensure API compatibility.

We were already using stevedore for tests, so this moves the dependency
from test-requirements.txt to requirements.txt and raises the minimum
version to something more recent.

Change-Id: I3e3632783bc745979b6db73e610df8a77ffaceb0
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2020-07-06 08:44:31 -04:00
Radosław Piliszek
b1fc587a6d Make volume backup record commands available in v3
They work just fine in Volume API v3 but they were limited in OSC
to v2.

Change-Id: I510383f8e0cbf05ec24caa1cad330f12f82a913d
Story: 2007896
Task: 40279
2020-07-05 09:55:49 +02:00
Zuul
1d8781a369 Merge "Remove enabling of glance v1 API" 2020-07-04 18:18:36 +00:00
Zuul
03b6f53675 Merge "Remove translation sections from setup.cfg" 2020-07-04 16:46:55 +00:00
Ghanshyam Mann
4638dbc7f3 Remove enabling of glance v1 API
devstack removing the glance v1 api enable
option[1] because there is no v1 entry point in glance
now[2].

Let's remove ths GLANCE_V1_ENABLED variable setting from
zuul job too to avoid any confusion of glance v1 is still
available.
[1] https://review.opendev.org/#/c/698808/
[2] https://review.opendev.org/#/c/532503/

Change-Id: I6d3a38eee0c75bbc795bad732fe547181d15c677
2020-07-03 10:06:12 -05:00
Monty Taylor
c04ec16cf7 Expose flag for forcing use of import for images
openstacksdk added support for using image import as a fallback
which is transparently supported here, but also provides an
override flag to allow a user to force use of import. Expose that
here.

Depends-On: https://review.opendev.org/737608
Change-Id: Ied938a8f63f305305a20ace42e9f4c84b0a5c00e
2020-06-30 07:02:23 -05:00
Zuul
d3691b81c6 Merge "Allow os quota list query to filter by project" 2020-06-29 22:22:25 +00:00
Zuul
abfca138d9 Merge "port: add --host to list command" 2020-06-26 01:13:35 +00:00
melissaml
ff2a70c418 Remove translation sections from setup.cfg
These translation sections are not needed anymore, Babel can
generate translation files without them.

Change-Id: Ic5d57186766257e9d37b3588e71f973cddad9be4
2020-06-23 12:22:58 +08:00
Mohammed Naser
307d23bb58 port: add --host to list command
This adds an option to allow filtering ports bound to a specific host
when listing them.

Change-Id: I747ed0f8b070074c51789576a158345f670fe733
2020-06-17 16:33:34 +00:00
Jens Harbott
8b7a2c8d59 Don't display Munch objects in the output
When the sdk gives us a resource that contains Munch columns, drop them
from the output as they are for programmatic usage only and have no use
in a CLI context.

Change-Id: Idd7306cd763b5a017a66e410e70e1adb02663c2a
2020-06-17 10:09:36 +00:00
Jens Harbott (frickler)
a04172969a Revert "Format location columns in network commands"
This reverts commit 6ee7b8d138.

Change-Id: I5f59959ba8a01aba49e29f4cb007397467344e58
2020-06-17 10:09:36 +00:00
Zuul
3e6874dc87 Merge "Remove os-client-config references" 2020-06-11 15:44:42 +00:00
Gabriel Ramirez
176907f70e Allow openstack flavor set to update flavor description using name
Modified take_action() method for SetFlavor to use
flavor id instead of flavor name when setting description

Closes-Bug: #1844708 
Story: #2007781
Task: #40019

Change-Id: If6798c89fef4c9feb4ebb460722b891f5655037d
2020-06-10 22:49:44 +00:00
Zuul
7f08bf7577 Merge "image: autogenerate docs" 2020-06-09 02:10:31 +00:00
Zuul
09970d48e0 Merge "identity: autogenerate docs" 2020-06-09 02:10:29 +00:00
Zuul
f6810edf41 Merge "Add cliff to libs-from-git for devstack functional tips" 2020-06-09 02:10:28 +00:00
Zuul
831dd3fe12 Merge "Make container list --all work" 2020-06-09 00:21:52 +00:00
Zuul
730a8505f6 Merge "Add OpenStack Client for Manila docs" 2020-06-08 23:17:53 +00:00
Eric Fried
da3c3bde24 image: autogenerate docs
$namespace = openstack.image.v{1|2}

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

Some reorganization happened here. The `image` subcommand name is shared
by image v1 and v2. Previously the hardcoded document had them combined
and interleaved. Attempting to preserve this with autoprogram-cliff
would have required significant additional infrastructure. However,
since most readers care completely about one and not at all about the
other, we instead split the v1 and v2 versions of these commands into
separate pages. In case links to the old pages exist in the wild, they
are preserved, but moved (with redirects) to a hidden directory, and
populated simply with links to the new version-specific generated
documents.

Change-Id: I24dc6dc10671c7f1267c27002542f61f8a3c18ae
2020-06-08 16:34:28 -05:00
Eric Fried
26878e7d53 identity: autogenerate docs
$namespace = openstack.identity.v{2|3}

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

Special things:

- Some reorganization happened here. Certain subcommand names, such as
  `endpoint` and `project`, are shared by identify v2 and v3. Previously
  the hardcoded documents had them combined and interleaved. Attempting
  to preserve this with autoprogram-cliff would have required
  significant additional infrastructure. However, since most readers
  care completely about one and not at all about the other, we instead
  split the v2 and v3 versions of these commands into separate pages. In
  case links to the old pages exist in the wild, they are preserved, but
  moved (with redirects) to a hidden directory, and populated simply
  with links to the new version-specific generated documents.

- The `federation domain` and `federation project` subcommands were
  previously absent from the docs. They are added. These are such small
  commands and they seem related, so they're put into a single document.

- Some pages were already being generated but were listing operations
  individually instead of using wildcards (possibly because they were
  created before wildcarding was supported by cliff). These are changed
  to use wildcarding. (We want to do this wherever possible as it is
  more future-proof in the event that more operations are added to a
  subcommand later.)

- The `service provider` document was incorrectly titled `identity
  provider`. Fixed.

Change-Id: I2030f9fe370038c5908b6eb6bed9692a73fe5067
2020-06-08 16:34:27 -05:00
Monty Taylor
7696593dc1 Remove os-client-config references
We've depended on openstacksdk for config for ages now, clean up
after ourselves and stop installing it in tests.

Change-Id: I66b3ec2a36bc462d2f1ac151e95ccbdc946076b8
2020-06-08 16:20:28 -05:00
Monty Taylor
2cb4193579 Add cliff to libs-from-git for devstack functional tips
We should also use cliff from git in the tips jobs so that we can
see whether changes there break things.

Change-Id: Ie3375eb7bafafef7fa8209aa6500d1254e29954e
2020-06-08 21:18:06 +00:00
Maari Tamm
aa7b84fd08 Add OpenStack Client for Manila docs
This commit includes documentation about OSC
implementation for Manila.

bp openstack-client-support

Change-Id: Ic91a81e16e506103c08ef42ed0f8634a2b70e1dd
2020-06-06 15:48:10 +00:00
Zuul
00e88822e3 Merge "Replace assertItemsEqual with assertCountEqual" 2020-06-05 19:32:08 +00:00
Zuul
57c02953ac Merge "Switch to newer openstackdocstheme and reno versions" 2020-06-05 18:32:11 +00:00
Zuul
897c6a2df3 Merge "Remove congress" 2020-06-05 16:16:38 +00:00
Zuul
dd29643c58 Merge "Add py38 package metadata" 2020-06-04 19:55:36 +00:00
Zuul
d5387bb80d Merge "Add Python3 victoria unit tests" 2020-06-04 19:55:35 +00:00
Zuul
26b3b30853 Merge "Update master for stable/ussuri" 2020-06-04 19:10:28 +00:00
Andreas Jaeger
b5389dab02 Remove congress
Congress and python-congressclient have been retired and also
removed from global requirements, thus requirements-check job fails.

Remove congress from this repo.

Change-Id: Ibf68fee49e69264a1c46b2f456901d2620befe3c
2020-06-04 18:29:49 +02:00
Alfredo Moralejo
a15b1addb4 Replace assertItemsEqual with assertCountEqual
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277

Change-Id: I1ad0da8deda3a8cbec384b5a9c88860a526eb48c
2020-06-01 16:39:54 +02:00
yanpuqing
533af9f1b2 Client should parse string to boolean for value 'is_domain'
When we use "--property" parameter, client get lists these the
value is string type, but the type of the value 'is_domain'
should be boolean, so we should judge it and parse it.
The patch parse string to boolean for value 'is_domain'.

Co-Authored-By: Lance Bragstad <lbragstad@gmail.com>

Change-Id: I37c9eb854524bde3a1530bfe2e3a03810fb1a676
Task: 30039
Story: 2005246
2020-05-29 07:53:13 -05:00
zhangboye
7049fd85fc Add py38 package metadata
Change-Id: I75ecaed730a2ef870f41812cfbf55c74fdc36b7b
2020-05-27 15:34:14 +00:00
Andreas Jaeger
709dfd9c21 Switch to newer openstackdocstheme and reno versions
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

Set openstackdocs_auto_name to use 'project' as name.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

Depends-On: https://review.opendev.org/729744
Change-Id: Id3989cabdbf2204821531b00149aa0f1cb8a4955
2020-05-20 21:54:12 +02:00
Pete Zaitcev
41a2e82939 Make container list --all work
The caller in openstackclient/object/v1/object.py passed a keyword
argument full_listing, but the eventual callee container_list()
expected all_data. So, --all did not work at all.

The issue passed undetected because --all did not have a test,
so we added a unit test.

In addition, exisiting tests were using a test set that did
not look like the real container listing, so we changed
LIST_CONTAINER_RESP to be realistic.

Change-Id: Id0604bcab25892e43c26cd6656b2b2eef5daa69b
2020-05-16 14:40:28 +00:00
Pete Zaitcev
f6ee42cd32 Cleanup: remove a useless reference to "object"
The method "object_list" does not have an argument "object",
so we were using a built-in class "object" by mistake.

Change-Id: I74687659223d31d3c3c119eee5874edff30634fd
2020-05-15 11:24:25 -05:00
Zuul
d394bac1de Merge "Resolve PEP8" 2020-05-15 07:27:35 +00:00
Pete Zaitcev
52ff421e3d Resolve PEP8
No idea how this happened, but reviews started failing the
pep8 gate job. The failures are legitimate, see the commit.
I guess the pep8 tests became smarter and found these issues.

Change-Id: Id9a0dad644134dafd68eed37fe8f41c583d7a619
2020-05-14 13:53:38 -05:00
Adam Harwell
ae67317109 Correct image lookup during server rebuild
The switch to using glance from the SDK accidentally used get_image
directly during a server rebuild, when it should have used find_image to
match existing functionality.

Bug introduced in: I36f292fb70c98f6e558f58be55d533d979c47ca7

Change-Id: I2005bd40a1bd6719670c7f7854316b4f9801b140
Story: 2007620
Task: 39643
2020-05-04 16:06:02 -07:00
OpenStack Release Bot
cc135e3b04 Add Python3 victoria unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for victoria.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I5aa55a9582127ce07efd841b15857c272bebdb9f
2020-04-28 15:18:38 +00:00
OpenStack Release Bot
662024646c Update master for stable/ussuri
Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: Ia0c7a6f2d84a7ed08514a64a73a5de577fcfb1d0
Sem-Ver: feature
2020-04-28 15:18:35 +00:00
Zuul
fdefe5558b Merge "Remove Babel from requirements" 2020-04-23 22:50:29 +00:00
Zuul
af1ffc456f Merge "Revert "Disallow setting default on internal network"" 2020-04-22 15:40:21 +00:00
Zuul
4886b02380 Merge "Use unittest.mock instead of third party mock" 2020-04-17 21:37:39 +00:00
Dmitry Tantsur
da4e1ca95f Remove Babel from requirements
It's not a runtime dependency (and even oslo.i18n has dropped it).
The translation infrastructure installs Babel explicitly. See
this mailing list thread for a full reasoning:
http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014227.html

Keeping Babel in lower-constraints since other projects still pull it.

Change-Id: Ib24d2941ac0f780f9092e48b17c343f8eb1d7151
2020-04-17 18:15:11 +02:00
Zuul
790ead00bb Merge "Add resource option immutable" 2020-04-17 10:25:30 +00:00
Zuul
92254bb0ac Merge "Add 'subnetpool' type support to rbac commands" 2020-04-15 08:44:49 +00:00
hackertron
b328cf74df Add '--force; parameter to 'openstack quota set'
The compute service allows us to to force set a quota, setting a
quota value that is less than the amount of the resource currently
consumed. Expose this feature by way of a '--force' boolean
parameter.

Change-Id: I1d1ac1ac46f49f64794ffc8631e166935537966c
2020-04-14 22:59:52 +02:00
Zuul
347c5b9df4 Merge "Add 'address_scope' type support to network rbac commands" 2020-04-10 00:18:56 +00:00
Igor Malinovskiy
557e65d8eb Add 'subnetpool' type support to rbac commands
Change-Id: Id6e528ebd1bf21ca142e60052d28371f97f629ac
Partial-Bug: #1862032
Depends-On: https://review.opendev.org/710755
2020-04-09 19:50:38 +03:00
Vishakha Agarwal
7f66273d3f Add resource option immutable
This patch adds the --immutable and --no-immutable option to the
role, project and domain CLI.

Related-Patch: https://review.opendev.org/#/c/712182/

Change-Id: I9c3bdd741f28bf558267fb217818d947597ce13e
2020-04-08 13:51:01 +00:00
Zuul
78b18030b5 Merge "Support for stateless security groups" 2020-04-08 08:31:28 +00:00
Vasyl Saienko
bdaebeb508 Revert "Disallow setting default on internal network"
The original patch assumes that both --external and --is-default are set
in the same request and broke case when --is-default is set as an
network update. The validation logic have to be moved on API side to
avoid extra API calls from openstackclient.

This reverts commit 962efd949f.

Related-Bug: #1745658

Change-Id: Idf08abb0e08a6880f89c3e9df9dd2ac82f36c432
2020-04-08 07:14:52 +00:00
Sean McGinnis
725e004d32
Use unittest.mock instead of third party mock
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: Ibd39328c27b68190e2edbf1f52fcea52db3ae791
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-04-03 17:11:40 -05:00
pedro
74a7c1d9d6 Add description field to portforwarding NAT rules
Add the `description` field to Floating IP Port Forwardings

Depends-On: https://review.opendev.org/#/c/705038/
Change-Id: I6477368e32570c96cacddba4f86455262e533277
Implements: blueprint portforwarding-description
Closes-Bug: #1850818
2020-04-02 13:15:19 -03:00
Zuul
70f1ff375a Merge "Add command: router add/remove route --route" 2020-04-01 11:03:51 +00:00
Tom Stappaerts
5e62411e5f Support for stateless security groups
Add support for stateful attribute of security groups,
using --stateful and --no-stateful flag on security group.
This allows a user to create security groups with stateful
false.

Change-Id: Ifd20b5fc47fd0ea0bb5aeda84820dcc0fb1e8847
Blueprint: stateless-security-groups
Depends-On: https://review.opendev.org/711513/
2020-03-31 12:05:18 +02:00
Andreas Jaeger
f01a0f336c Cleanup Python 2.7 support
OpenStack is dropping the py2.7 support in ussuri cycle.

Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Add python-requires to setup.cfg so that pypi and pip know
  about support Python version
- Remove ancient sections from setup.cfg
- Remove version_info setting from conf.py, openstackdocstheme does this
  automatically nowadays.

Change-Id: I5b9c159752c932f874015f20822862c70562c2bd
2020-03-30 20:00:41 +02:00
Bence Romsics
dba57c85d5 Add command: router add/remove route --route
Add commands to osc to call the two new API methods introduced by
new Neutron extension: extraroute-atomic.

Bump our openstacksdk requirement to >=0.38.0 which contains
the corresponding sdk change.

The lower-constraints of dogpile.cache and keystoneauth1 are bumped
because of requirements bumps in openstacksdk.

The lower-constraint of decorator is bumped because of problem already
fixed by amotoki here: https://review.opendev.org/701706

Change-Id: Ia9b9c216f1d1161ebedac31594a2c464d77f4ae2
Depends-On: https://review.opendev.org/674324
Partial-Bug: #1826396 (rfe)
Related-Change: https://review.opendev.org/655680 (spec)
2020-03-30 16:19:05 +02:00
Zuul
9754a67d5d Merge "Adding options to user cli" 2020-03-27 11:44:31 +00:00
Vishakha Agarwal
05da145eae Adding options to user cli
User options [1] can be set by making POST and PATCH
request for /v3/users API calls but cannot by openstack
CLI because of no user options defined in create and update
user CLI [2]. This patch adds the user options [1] in
create user and update user CLI.

[1] https://docs.openstack.org/keystone/latest/admin/resource-options.html#multi-factor-auth-rules
[2] https://docs.openstack.org/api-ref/identity/v3/#create-user

Change-Id: I4e41bae2e8cfbe92d52b14d856991bedcd44164f
2020-03-26 22:24:39 +05:30
Monty Taylor
8efb319819 Be explicit about python version in image
python-base has versions available now, defaulting to 3.7. Update
our config to 3.7 to be explicit about what we're using. This will
let us update the version as we feel like.

Change-Id: I40ffde91808a8bb95479697b9127dba16de8a8cd
2020-03-26 08:48:20 -05:00
Monty Taylor
97d027caec Add libc6-dev to bindep
The python-builder base image was updated to no longer install
recommends. This is inline with the other Infra images and keeps
image sizes smaller. gcc recommended libc6-dev - but it turns out
we need that for limits.h for one of our depends. Add it to fix
our image builds.

Change-Id: I97950d71bc455c269490812c6597fbe432641733
2020-03-26 08:46:13 -05:00
Igor Malinovskiy
f03cb68ad8 Add 'address_scope' type support to network rbac commands
Change-Id: I6a4b7219934805c1bbd1e88fcc670ae231d9ac37
Partial-Bug: #1862968
Depends-On: https://review.opendev.org/709122
2020-03-26 12:40:12 +00:00
Zuul
c5719a12b5 Merge "Don't look up project by id if given id" 2020-03-25 22:10:25 +00:00
Zuul
74616cd235 Merge "Complete switch from glanceclient to SDK for image service" 2020-03-25 15:19:21 +00:00
Zuul
21c883b3d3 Merge "Switch image to use SDK" 2020-03-25 15:19:20 +00:00
Zuul
81dcc91214 Merge "Fix faulthy state argument choice" 2020-03-24 21:34:44 +00:00
Zuul
2c8d705a24 Merge "Add unit tests and release note for dns_publish_fixed_ip" 2020-03-24 21:24:52 +00:00
Zuul
77b364942a Merge "Honor endpoint override from config for volume" 2020-03-24 18:35:59 +00:00
Zuul
215cd79bbc Merge "Bump lower constraint of MarkupSafe" 2020-03-24 17:19:08 +00:00
Zuul
a0d7f98f18 Merge "Add "fields" parameter to ListSecurityGroup query" 2020-03-24 14:07:02 +00:00
Dmitriy Rabotyagov
042be7c7fe Don't look up project by id if given id
There is a much deeper and systemic issue going on here, but let's
start with fixing the immediate issue which is that adding a project
to an image fails trying to look up project information even if the
user passes the project id by id.

_is_uuid_like from sdk isn't perfect, but it'll be good enough
for this.

Change-Id: I541416d737b961c56aa2f584c172528632fd5537
2020-03-24 13:13:12 +00:00
Artem Goncharov
768a64aac5 Complete switch from glanceclient to SDK for image service
In https://review.opendev.org/#/c/650374/ a work has been started to
switch image service support from glanceclient with all it's
dependencies to the SDK version. With this change version 1 (anyway
deprecated since ages) is also being switched to SDK.

Change-Id: Ic391500af02a73d81d64a9e9113cca85c9e24390
2020-03-24 13:13:06 +00:00
Monty Taylor
cdac869412 Honor endpoint override from config for volume
I'm guessing we should do this for everyone, but we have volume on
the brain right now. Rackspace is in the weird situation where
they do support v2 but only have v1 in the catalog (wut) So we
need to override the block-storage enpdoint by config. To do that,
we need to actually honor the config setting over here in OSC.

NOTE: We need to systemically overhaul how we're injesting config
over here - because there's too much variation. But we can leave
that for another day.

Story: 2007459
Task: 39137
Change-Id: Ifddf1ddd5abaa768ab18049c09d18bc269f3a4f5
2020-03-24 07:29:35 -05:00
Zuul
9e8960bad0 Merge "Fix network segment range "_get_ranges" function" 2020-03-23 21:41:45 +00:00
Zuul
6d89d78daa Merge "Remove trailing newline from dockerhub secret" 2020-03-23 20:47:20 +00:00
Artem Goncharov
60e7c51df4 Switch image to use SDK
This is a work to switch OSC from using glanceclient to OpenStackSDK.

With this change only v2 is using OpenStackSDK. V1 is still using
glanceclient and will be switched in a separate change.

Remove the direct depend on keystoneauth- let that flow through
openstacksdk.

Depends-on: https://review.opendev.org/#/c/698972
Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7
2020-03-23 14:38:32 -05:00
Monty Taylor
9d96a13a97 Remove trailing newline from dockerhub secret
When doing encrypt_secret, one should use echo -n not just echo.

Change-Id: Iefbf0f13cd349b05de910f95b9467877cb53e46b
2020-03-23 12:55:11 -05:00
Zuul
472abb7b63 Merge "Change dockerhub password" 2020-03-23 17:15:37 +00:00
Rodolfo Alonso Hernandez
27da238da2 Fix network segment range "_get_ranges" function
This function should return an ordered set of ranges based on an
unordered list of numbers (int or str).

Change-Id: I918c8befc51236cc33d96a5c88fb6eafdd143e9c
Story: 2007341
Task: 38878
2020-03-23 14:17:14 +00:00
Monty Taylor
42abde330e Change dockerhub password
Changed it dockerhub side.

Change-Id: I1befae9622fc1ef72cd77cfd5792aad3fa231a6a
2020-03-23 08:08:52 -05:00
Zuul
fc12033f1d Merge "Now we can add description for role creation in OSC" 2020-03-20 18:59:44 +00:00
Zuul
9277fd471a Merge "Replace port 35357 with 5000 for "auth_url"" 2020-03-20 17:07:25 +00:00
Zuul
da7226a556 Merge "Update the content about Import Format" 2020-03-20 17:07:24 +00:00
Bence Romsics
aac4f8c4f1 Bump lower constraint of MarkupSafe
setuptools 46.0.0's drop of the Features feature broke
python-openstackclient's lower-constraints job on master
via the MarkupSafe package. Bump the lower constraint of
MarkupSafe to fix lower-constraints on master.

Change-Id: Ib0a6f94a6611b221efbf76f6f25b55c43782546f
2020-03-20 12:12:22 +01:00
Monty Taylor
332457bc87 Update image building jobs
We're failing on promote but not upload. That's weird. Make sure
the secret is appropriately encoded, and copy what zuul is doing.
Also make promote a zero-node job.

Change-Id: Ifcb5b4fe2486087a5ca1ff9609f7bf09ef026974
2020-03-19 16:18:27 -05:00
Daniel Strong
d2826e89e9 Allow setting floating IP description
Change-Id: If664bfe3c9fdcb69c7046eb16c5d32602d1b3262
Story: 2007439
Task: 39094
2020-03-18 18:10:17 +00:00
Zuul
8c4ecbe35d Merge "Build utility image for using osc" 2020-03-16 21:09:01 +00:00
Daniel Bengtsson
bf2beb9e86 Stop configuring install_command in tox and stop use pip.
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value. Use the
right way when it's necessary.

Change-Id: I410173d5fdcd8c592d98eed2f48b98e06299e8b3
2020-03-16 08:00:44 +01:00
Monty Taylor
8c47b67e83 Build utility image for using osc
python-openstackclient currently has a non-zero number of dependencies,
so for admins who would like to run it on laptops or similar it can
get tricky. In opendev, for instance, admins have it installed into
a venv on a jump host, but it's really wonky to keep up with.

Use the opendev/python-builder opendev/python-base pair to make a
minimal image that contains an install of python-openstackclient
and publish it to the osclient org on dockerhub. There is an overall
policy against having binary artifacts such as this appear to be
official deliverables of the OpenStack project, which this is not.
It's also only publishing images based on master, so no warranties
should be implied. But if this makes life easier for a user somewhere,
cool.

Change-Id: I9a8bfc27c127e92b6856cb6a3e45b32c818db16c
2020-03-14 17:15:46 -05:00
Zuul
045f133f16 Merge "Add storage policy option to create container command" 2020-03-13 22:53:48 +00:00
Zuul
37240b3b83 Merge "Add qos_network_policy_id to network port tests" 2020-03-13 22:34:37 +00:00
Zuul
fdc411ad68 Merge "Update http links in docs" 2020-03-13 21:23:45 +00:00
Zuul
56f095cb2e Merge "Incorrect title for service provider" 2020-03-13 21:23:43 +00:00
Jose Castro Leon
3e83e7471b Allow os quota list query to filter by project
In the os quota list command, project parameter is completely ignored
ending up in a request to all projects and then all quotas. This patch
enables back the parameter and does a single call to quotas if specified.

Change-Id: Ie17c256e2bdc307dcd94ad5be7abdbffa776d369
Story: 2007422
Task: 39043
2020-03-12 14:43:18 +01:00
Rodolfo Alonso Hernandez
711b9c9405 Add "fields" parameter to ListSecurityGroup query
This new query parameter will allow to send a query sending the
"fields" parameter. This "fields" parameter contains the needed
API fields, translated into OVO fields in Neutron server, that
require to be retrieved from the DB.

As commented in the related bug, the OSC "list" command only
prints five parameters, none of them the security group rules. In
systems with a reasonable amount of security groups, skipping the
unnecessary rule load can save a lot of time.

Depends-On: https://review.opendev.org/#/c/710820/
Change-Id: I16f48e292997d029d68f66365db949b9f4b5a0c8
Closes-Bug: #1865223
2020-03-12 11:44:10 +00:00
huangshan
519296d762 Update http links in docs
This patch is proposed according to the Direction 10 of doc
migration(https://etherpad.openstack.org/p/doc-migration-tracking).

Change-Id: I0061bf788a8da89da0077db63f6cecf2ead0d0be
2020-03-09 21:13:29 -05:00
Hongbin Lu
962efd949f Disallow setting default on internal network
The ``--default`` option should be only used for external network.
Default internal network is not currently supported so we disallow
it for now.

Change-Id: Ia9d39b40e1e041d7bda0f6a27d058e382b572e1a
Closes-Bug: #1745658
2020-03-09 21:01:53 -05:00
yangxi
001796faa2
Change 'Volume' to 'Block Storage'
In volume*.rst files, 'Volume' should be instead of 'Block Storage'.

Change-Id: Iafc8bfa19e87edf1ffad2340c75e9d867042cae5
2020-03-09 20:45:00 -05:00
Zuul
ee0170824f Merge "Add bindep file" 2020-03-07 18:57:25 +00:00
Sam Morrison
e410e61d20 Always display direction for security group rules
The --long option is still accepted but is now ignored.

Change-Id: I23dd9fa7cff310ee9a62ce32b843b822b93b7548
Story: #2007323
2020-03-05 09:04:59 +11:00
Monty Taylor
0699df95c8 Add bindep file
We're missing one of these, which means starting from a bare node
it's not completely possible to install openstackclient based only
on bindep and pip. Add one that allows building and installing.

Change-Id: I7b297bb1485773df3d5d1cc3ba78b0b9af4b2d00
2020-03-04 15:36:18 -06:00
Zuul
acccc54e7d Merge "Fix copypaste errors in access rule command" 2020-03-03 23:40:35 +00:00
Simon Merrick
d6022f96df Add storage policy option to create container command
+ Add CLI option to specify swift storage policy
 + Add CLI flag to specify container uses public read ACLS
 + Show storage policy in container show data

Change-Id: I08ffa0d98bd39d467aa415771675f59bd77768ff
2020-02-19 10:08:48 +13:00
Rodolfo Alonso Hernandez
2745b178a4 Add qos_network_policy_id to network port tests
Added "qos_network_policy_id" to "port show" command. Because this is
just a read-only parameter and is read from the SDK port definition,
this patch only modifies the corresponding tests.

This patch is adding this new parameter to the test bench.

Change-Id: Ice7423e0e0b98a39cc36622b70eae5a8493a037c
Closes-Bug: #1851362
2020-02-18 09:18:37 +00:00
Zuul
e07324e30f Merge "Complete "Drop python2 support" goal" 2020-02-05 17:21:38 +00:00
Zuul
4f8467a039 Merge "Remove mention of meetings from docs" 2020-02-05 07:29:50 +00:00
Monty Taylor
e6e4b73efa Complete "Drop python2 support" goal
We stopped testing python2, but there are more things to be cleanup.

- Remove python2 entries from setup.cfg
- Add releasenotes
- remove universal wheel since this is only python 3 now

Change-Id: Ie2bbb4d34b8411939ad5cfd750fc76c933779542
2020-02-05 05:58:51 +00:00
Stephen Finucane
cefa571d4b Use 'KeyValueAppendAction' from osc-lib
Does what it says on the tin. This action was added to osc-lib in change
If73cab759fa09bddf1ff519923c5972c3b2052b1.

Change-Id: I51efaa096bb26e297d99634c5d9cca34c0919074
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-02-03 15:25:40 +00:00
Stephen Finucane
ea27ebb0f9 Stop silently ignoring invalid 'server create --hint' options
The '--hint' option for 'server create' expects a key-value pair like so:

  openstack server create --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ...

However, the command doesn't complain if this isn't the case, meaning
typos like the below aren't indicated to the user:

  openstack server create --hint 245e1dfe-2d0e-4139-80a9-fce124948896

Due to how we'd implemented this here, this ultimately results in us
POSTing the following as part of the body to 'os-servers':

  {
    ...
    "OS-SCH-HNT:scheduler_hints": {
      "245e1dfe-2d0e-4139-80a9-fce124948896": null
    }
    ...
  }

Which is unfortunately allowed and ignored by nova due to the use of
'additionalProperties' in the schema [1]

Do what we do for loads of other options and explicitly fail on invalid
values. This involves adding a new argparse action since none of those
defined in osc-lib work for us. This is included here to ease
backporting of the fix but will be moved to osc-lib in a future patch.

[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146

Change-Id: I9e96d2978912c8dfeadae4a782c481a17cd7e348
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Story: #2006628
Task: #36840
Related-Bug: #1845322
2020-02-03 15:25:24 +00:00
Kendall Nelson
27b16df7f8 Remove mention of meetings from docs
Since the OpenStackClient team doesn't meet anymore, I removed
the mention of meetings and added mention of the IRC channel in the
communication section of the docs..

Change-Id: Iefa95878f95bf84bd9fc22ea4c914effc30dffa7
2020-01-28 05:54:20 +00:00
Georgina Shippey
cb265774ac Incorrect title for service provider
Mistakenly changed to identity provider.

Change-Id: I0841a6e5ebd6a27a5375a54c56fc194dff65b370
2020-01-23 15:14:16 +01:00
Colleen Murphy
99b0b07392 Fix copypaste errors in access rule command
Access rules are access rules, not application credentials.

Change-Id: I74d05f11ec186283e5a86d92dcbfe4eb24130eee
2020-01-21 15:08:46 -08:00
Colleen Murphy
70ab3f9dd5 Add support for app cred access rules
This commit introduces the --access-rules option for 'application
credential create' as well as new 'access rule' commands for listing,
showing, and deleting access rules.

bp whitelist-extension-for-app-creds

Change-Id: I04834b2874ec2a70da456a380b5bef03a392effa
2020-01-17 11:14:51 -08:00
Michael Johnson
db29e28b7c Switch to using osc_lib.utils.tags
This patch updates the network modules to use the new
osc_lib.utils.tags module and removes the in tree _tag.py version.

A previous patch[1] moves the _tag.py code to osc-lib to allow other
projects to leverage the code.

[1] https://review.opendev.org/662859

Change-Id: Id0c34029e327de50c5fd2732bae5fbf45bbd16ee
2020-01-14 17:10:41 -08:00
Dean Troyer
68aa35f35f Add unit tests and release note for dns_publish_fixed_ip
Follow-up to https://review.opendev.org/#/c/679834/ which
added the options and lacked both a release note and
minimal option-handling unit tests.

Change-Id: Ibb2820add9b2fedaf5a8b1a77babf043f6641724
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2020-01-14 09:53:13 -06:00
Zuul
4a2aa4acc1 Merge "Show correct name for resource with quota set to zero" 2020-01-14 05:00:00 +00:00
Zuul
4d9f0f384b Merge "Create Volume v3 functional tests" 2020-01-13 22:31:19 +00:00
Zuul
cc93be81c9 Merge "Remove redundant OpenStackShell.prepare_to_run_command" 2020-01-13 19:27:52 +00:00
Zuul
08c57260e4 Merge "Add dns_publish_fixed_ip attribute to subnets" 2020-01-13 19:27:51 +00:00
Zuul
cf76a00251 Merge "Raise flake8-import-order version to latest" 2020-01-13 18:24:20 +00:00
Sean McGinnis
69db9fe73c
Raise flake8-import-order version to latest
We had this library capped at a release that is a few years old. Now
that we have dropped py2 testing, we can pick up the latest version.

This uncovered a few things to clean up. Mostly the fact that mock is
now a part of the StdLib unittest since Python 3.3.

Change-Id: I27484dd4c25378413ff16e97a35a1a46062357bc
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-01-10 14:21:47 -06:00
Sean McGinnis
90ca67bdae
Raise hacking to more recent 2.0.0
Change-Id: I3cf36ed4d8fb5d003acae762820a8d80f75a11e9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-01-10 11:43:07 -06:00
lihaijing
d15bbada73 Replace six.iteritems() with .items()
1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items
2020-01-09 18:41:29 +09:00
Zuul
4b575083b7 Merge "Bump tox minversion" 2020-01-08 23:14:40 +00:00
Alex Katz
780d9b49a0 Show correct name for resource with quota set to zero
In case quota for the resource is set to zero "openstack quota show"
command will not map the resource name according to one of the
following dicts:
 - COMPUTE_QUOTAS
 - NOVA_NETWORK_QUOTAS
 - VOLUME_QUOTAS
 - NETWORK_QUOTAS

For example:
$ openstack quota set --secgroups 10 admin
$ openstack quota show admin -f json|egrep "(secgroups|security_groups)"
  "secgroups": 10,
$ openstack quota set --secgroups 0 admin
$ openstack quota show admin -f json|egrep "(secgroups|security_groups)"
  "security_groups": 0,

Change-Id: I94ed9e6b41b1cc692297c01e6c7582998dcacfda
2020-01-08 18:47:51 +02:00
Zuul
2c676b60b1 Merge "Stop testing python 2 in tox and zuul." 2020-01-07 15:39:57 +00:00
Monty Taylor
32080f7a42 Bump tox minversion
ignore_basepython_conflict was introduced in tox 3.1.0.

Change-Id: I7a6049b6a4fd3ee376a3478e94837c0afe89d4df
2020-01-07 09:22:30 -05:00
Zuul
e43377bafb Merge "Fix router create/show if extraroute not supported" 2020-01-07 13:43:15 +00:00
KeithMnemonic
f5384ae16a Fix openstack server list --deleted --marker option
This patch removes using the "name" option for a marker when
--deleted is also used. The find_resource() function
that is being called does not correctly handle using the marker
as the "name" in the search when also using deleted=True.
One simple way to fix this is force the marker to only be an ID
when --deleted is used. This is how the nova client works.

Using the --deleted option is available to users with the admin
role by default. If you're an admin listing --deleted servers
with a marker by name, find_resource() is going to fail to find
it since it doesn't apply the --deleted filter to find_resource().

The find_resource() function is trying to find the marker server
by name if it's not found by id, and to find it by name it's
listing servers with the given marker as the name, but not
applying the --deleted filter so it doesn't get back any results.

In the story it was suggested modifying find_resource to include
the deleted query param when it's specified on the command line but
that didn't work because it still results in something like this:

http://192.168.1.123/compute/v2.1/servers?deleted=True&name=4cecd49f-bc25-4a7e-826e-4aea6f9267d9

It seems like there are bugs in find_resource().

Restricting the marker to be the server ID when listing deleted servers
is probably OK since if you're using --deleted you're an admin and you could
be listing across all projects and if you're filtering by a server across all
projects anyway (not that you have to, I'm just saying if you are), or even
showing a server in another project, you have to do it by id rather than name
because find_resource() won't find the server in another project by name, only ID.

story: 2006761
Task: 37258

Change-Id: Ib878982b1d469212ca3483dcfaf407a8e1d2b417
2020-01-02 20:05:56 +00:00
Bram Verschueren
69870ae439
Fix faulthy state argument choice
The correct state name for a failing volume snapshot deletion is
'error_deleting' instead of 'error-deleting'. [1]

[1] 89d6a5042f/cinder/objects/fields.py (L126)

Task: #37844
Story: #2007037

Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556
2019-12-19 09:48:17 +01:00
Daniel Bengtsson
924627678d Stop testing python 2 in tox and zuul.
Remove python 2 from envlist parameter. Check the link:

https://etherpad.openstack.org/p/drop-python2-support

The plan is drop the python 2 support from OpenStack in Ussuri release.
Remove the zuul jobs.

Note that the (non-voting) openstackclient-check-plugins job is still
running under py2 at this time. That will need to be fixed in the
python/openstackclient repository where the job is defined.

Change-Id: I3148db053b9ef0fcf7dc88e5cc075d974c93d819
2019-12-06 16:06:36 +00:00
Édouard Thuleau
509ca3ed36 Fix router create/show if extraroute not supported
If neutron does not support extraroute l3 extension, the route column
formatter fails.

Change-Id: I7b89c4f818865073947e0850e86c18d0d2415a51
2019-12-04 14:57:20 +01:00
Matt Riedemann
5b3a827a1f Provide stderr in exception when check_parser fails
For negative tests that are asserting an argparse failure
it would be useful to assert the specific reason for the
failure in the test rather than just getting an exception,
especially to avoid false positives in the tests when what
is being tested and failing isn't the actual expected reason
for the failure.

This wraps the check_parser code that parses the args and
mocks sys.stderr so we can trap that output and put it in the
exception message that gets raised to the test.

As a result, we can tighten up a test that was passing before
for the wrong reason [1].

[1] https://review.opendev.org/#/c/673725/12/openstackclient/tests/unit/compute/v2/test_server.py@605

Change-Id: I0f1dc1215bdfb3eba98ccaf66a0041d220b93812
2019-11-20 13:39:40 +00:00
zhangbailin
874a726f52 Microversion 2.79: Add delete_on_termination to volume-attach API
Added ``--disable-delete-on-termination`` and
``--enable-delete-on-termination`` options to the
``openstack server add volume`` command that enables users to mark
whether to delete the attached volume when the server is destroyed.

Depends-On: https://review.opendev.org/#/c/681267/

Part of blueprint support-delete-on-termination-in-server-attach-volume

Change-Id: I6b5cd54b82a1135335a71b9768a1a2c2012f755b
2019-11-19 21:07:20 +00:00
Dean Troyer
1c0160c8aa Create Volume v3 functional tests
Until now-ish Volume v3 has been a pass-through to v2.  In order
to prepare to make the Volume v3 commands stand-alone copy the
v2 functional tests to v3.

This is the first of a series of reviews to completely separate
Volume v2 and v3 commands.  Once these are split we can begin to
implement v3 microversion support and/or start using the
OpenStack SDK as the REST library.

Change-Id: Iefd78d8ef6bb851d7360596337a88ee8f8476767
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-11-18 14:47:56 -06:00
Zuul
c6a171f010 Merge "Refactor AggregateTests" 2019-11-06 05:59:24 +00:00
Eric Fried
3b409e4d0e Refactor AggregateTests
While investigating the referenced story/bug I noticed that
wait_for_status in
openstackclient.tests.functional.compute.v2.test_aggregate.AggregateTests
was doing a lot more than it should ever need to (it probably got copied
in from somewhere). The two places calling it only need to a) check the
output of `openstack aggregate show`, and b) try once -- since they just
got done creating the aggregate synchronously, there should never be a
need to delay/retry. So this commit removes the helper method and just
inlines the check.

At the same time, the addCleanup(aggregate delete) directives are moved
above their respective creates. This is a defensive best practice which
makes sure cleanup happens even if something fails very soon after the
actual back-end create (as was in fact the case with the referenced
bug/story).

It is unknown whether this will impact the referenced bug.

Change-Id: I0d7432f13642fbccd5ca79da9c76adfcbabb5fa9
Story: 2006811
Related-Bug: #1851391
2019-11-05 21:32:15 +00:00
Eric Fried
e2d8dc0f1c Deflate .htaccess
Use some regexes to reduce the number of lines in .htaccess and
hopefully make it slightly clearer which groupings of files redirect to
which new locations.

Also collapse one redundant double-redirect.

Change-Id: I65c4960856985d71076291f175df17f27a5ab8cc
2019-11-05 07:09:05 -06:00
Eric Fried
6f07828bf0 Add redirect testing
Adds a dependency on and invocation of the `whereto` command to validate
redirects in the .htaccess file during doc builds.

Change-Id: Ib6cc2953f0fd774de3c3a0c8a2bd6cff49667c14
2019-11-05 07:09:05 -06:00
Eric Fried
c6266b5ab2 compute: autogenerate docs
$namespace = openstack.compute.v2

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

Many of these were already being generated. Some were missing a few
sub-subcommands, so those are added.

Change-Id: I1aa4b2655bafd2f6a5d83b658742f65d180eb128
2019-11-05 07:09:05 -06:00
Eric Fried
da56b8f4cf openstack.cli: autogenerate docs
$namespace = openstack.cli

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

Change-Id: I1f7e9d0e5748f887dbc35200c3c8b4407da43e0b
2019-11-05 07:09:05 -06:00
Eric Fried
4c0f3bfa89 common: autogenerate docs
$namespace = openstack.common

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

This incorporates a correction to `openstack versions show`: The command
`openstack versions show --help` showed a copy/paste error, using
<region-name> for the metavar for both --service and --status. Fix.

Change-Id: I7658fed40d71f4c20ee27908ade433534657cfe5
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
Co-Authored-By: Matt Riedemann <mriedem.os@gmail.com>
2019-11-05 07:09:05 -06:00
Eric Fried
c7dbe85705 Update a stale doc reference to use :neutron-doc:
The help page for network auto allocated topology had a link to a
newton-era networking guide document that has been superseded and is
now maintained in the neutron repository.

This commit adds 'neutron' to the openstackdocstheme configuration so
that the :neutron-doc: role works, and updates the link to point to the
modern version therein.

Change-Id: I5bcb40e265b22f15ff2f5ca4936160e231bb4075
2019-11-05 07:09:05 -06:00
Zuul
d17a1c8039 Merge "neutron: autogenerate docs" 2019-11-05 00:41:31 +00:00
Zuul
d2f44e645e Merge "Use autoprogram-cliff for remaining plugin docs" 2019-11-04 22:09:27 +00:00
Zuul
10747754a6 Merge "Use SDK to get compute API extensions" 2019-11-04 22:09:23 +00:00
Eric Fried
cd6c285cc6 neutron: autogenerate docs
$namespace = openstack.network.v2

The subcommand documents for $namespace were hardcoded and thus prone to
drift over time. This commit removes the hardcoded content and uses the
autoprogram-cliff directive to generate them automatically from the
subcommand configuration classes.

This one turned out to be quite involved, because we support both
neutron and nova-network. When running in a real cloud, the command
classes detect whether the neutron service is present, assume
nova-network if that service is not found, and only add parser options
relevant to the detected service. But the docs need to present both sets
of options. This was easy enough when they were hardcoded, but required
a bit of additional infrastructure for generated docs.

Change-Id: I426261eb1d86bcc68656aabd61f10b7f082da402
2019-11-01 14:24:30 -05:00
Pierre Prinetti
61ad83b575
versions: Fix 'versions show' help message
The command `openstack versions show --help` shows a copy-paste nit.

Change-Id: I9e4e86429ffd630c566bbdf2929e7995c9b0dbe1
Signed-off-by: Pierre Prinetti <pierreprinetti@redhat.com>
2019-11-01 11:25:40 +01:00
Eric Fried
40f74816c1 Remove redundant OpenStackShell.prepare_to_run_command
osc-lib's OpenStackShell.prepare_to_run_command has been a superset of
python-openstackclient's since at least osc-lib 1.4.0. We require 1.14.0
now, so the redundant override can be removed.

Change-Id: I5658e3df5af1100e139623505d0375588edae63c
2019-10-31 16:53:30 +00:00
Matt Riedemann
4b393681d9 Use SDK to get compute API extensions
python-novaclient 16.0.0 removed the deprecated
list_extensions module [1] so this changes the
extensions command to use openstacksdk to get the
compute API extensions.

The functional test ExtensionTests.test_extension_list_compute
ensures this works.

[1] https://review.opendev.org/686516/

Change-Id: I9894bc395c0474aaa6494ac4534862efe4ea7984
Story: #2006769
Task: #37284
2019-10-31 16:48:29 +00:00
Eric Fried
f1d742f32a Fix functional tests for py3
Fix various things so the functional tests will work under python3:

- A hashlib.md5() can only be update()d with an encoded string in py3.
- There's no dict.iteritems(), change to dict.items() (which is already
  an iterator).
- Open temp files with 'w+' mode rather than the default 'w+b' (as an
  alternative to encoding all the write and expected-read payloads as
  bytes).
- (This is a weird one) Explicitly raise SkipTest from unittest (rather
  than unittest2, which is where cls.skipException landed). Not sure why
  this is busted, but this moves the ball.

Change-Id: Ic9b2b47848a600e87a3674289ae7ae8c3e091fee
2019-10-31 00:17:35 +00:00
Eric Fried
977b0c8591 Use autoprogram-cliff for remaining plugin docs
Sphinx errors have been fixed in the plugin projects for octavia, rsd,
trove, watcher, and zun, so we can now use autoprogram-cliff to generate
the docs for those.

Change-Id: Ia7790c5e86957afd0aec8f9a04ffc7aa968b4eeb
Story: #1735016
Task: #37241
2019-10-28 14:05:37 -05:00
Zuul
45af14ca72 Merge "Doc: launchpad => storyboard" 2019-10-22 21:54:02 +00:00
Zuul
80d2ff41fc Merge "Remove plugin projects from test-requirements.txt" 2019-10-22 21:43:09 +00:00
Zuul
aeb094e765 Merge "Link to (some) plugin doc pages" 2019-10-22 21:43:04 +00:00
Zuul
77b5e9da35 Merge "Add plugin doc page for watcher" 2019-10-22 21:43:03 +00:00
Zuul
9974eb0453 Merge "Produce complete content for plugin docs" 2019-10-22 21:16:52 +00:00
Zuul
50325ff5ca Merge "Split plugin docs per project" 2019-10-22 21:16:49 +00:00
Zuul
e27a290087 Merge "Add placement to known plugins" 2019-10-22 21:16:47 +00:00
Zuul
86eddf701b Merge "Fix plugin autodoc generation" 2019-10-22 21:16:43 +00:00
Zuul
7e98aaefa9 Merge "Add parent project filter for listing projects" 2019-10-22 21:16:40 +00:00
Zuul
f873235625 Merge "Fix osc-lib interface change: catch osc-lib Forbidden" 2019-10-22 21:16:34 +00:00
Eric Fried
d0bfef807d Doc: launchpad => storyboard
A few docs still referred to launchpad, which osc hasn't used in a
couple of years. Cut over to storyboard.

Change-Id: Ic9abf0fe1e52c255976bd7a019e999a8e610455e
2019-10-22 15:13:40 -05:00
Eric Fried
fcae62841f Link to (some) plugin doc pages
We would like to use autoprogram-cliff to generate full docs inline for
each plugin. But for the following projects, that breaks the build:

- octavia
- rsd
- trove
- watcher
- zun

For those projects, we're using list-plugins instead, because that
builds, and it's better than nothing; but it only provides summaries of
the commands.

So with this commit, we add a link to the plugin documentation from the
actual plugin project where such documentation exists, which currently
is just:

- octavia
- watcher
- zun

(For rsd, I couldn't find openstack-published docs at all; for trove,
published docs exist, but the osc plugin isn't documented.)

Change-Id: I7c826ecef4319bead239e11b5f975302b2f24d1b
Story: #1735016
Task: #37244
2019-10-22 10:27:24 -05:00
Eric Fried
67a5654d49 Add plugin doc page for watcher
This was being omitted because whenever the plugin page was produced,
python-watcherclient wasn't in global-requirements. It is now, so
include a page for it in the plugin docs.

NOTE: We would like to use autoprogram-cliff to make the documentation
complete, but that breaks the build. For now, this is better than
nothing.

Change-Id: I49822242b9a0c031a053d6c2fd9f644a585f4ba5
2019-10-21 18:08:41 -05:00
Eric Fried
3fd63c0021 Produce complete content for plugin docs
Plugin documentation previously used ``.. list-plugins::`` for each
plugin command, which just produced the summary line. This might be
useful if there were also a link to the complete (per-project) docs for
the commands; but since we have the content available, we might as well
produce the complete plugin docs inline. That's going to be most useful
to a reader anyway.

So this commit switches from ``list-plugins`` to ``autoprogram-cliff``
-- except for the following, whose docs break the build when this is
done:

- octavia
- rsd
- trove
- zun

These fixups are tracked under task #37241 under this same story.

Change-Id: I2f17e203fe3da92a709884c9052c8e39ff87f4c8
Story: #1735016
Task: #37240
2019-10-21 17:45:35 -05:00
Eric Fried
85c83530ee Split plugin docs per project
Once [1] fixed plugin doc generation, the (single) page it produced was
unusably huge. This commit splits it into one page per project.

Note that there are four plugin projects that didn't have sections
included:

- cue
- murano
- tripleo
- watcher

These were noted in hidden rst which is preserved in the (new) index
page.

[1] Id9be39971110fd2eb4519a0582c9bf2514cdcacd

Change-Id: I0214ddb00a5a292a46d7cfb539d6dcc540fdae79
Story: #1735016
Task: #37239
2019-10-21 17:44:15 -05:00
Eric Fried
abdec78fa3 Remove plugin projects from test-requirements.txt
Plugin projects were listed in test-requirements.txt ostensibly to pull
them in for autodoc building. However, test-requirements.txt wasn't
being used for that purpose -- doc/requirements.txt was, so [1] added
them there. So this commit removes them from test-requirements.txt where
they're unused.

[1] Id9be39971110fd2eb4519a0582c9bf2514cdcacd

Change-Id: Ia89888ee05e17da636ee46894232624e0178d6bc
2019-10-21 16:37:41 -05:00
Eric Fried
8cdc7348d1 Add placement to known plugins
Add the osc-placement project (osc plugin for the placement service) to
the list of known plugins.

Change-Id: I77b614b38ecf872d0d93473b834994913930b76f
2019-10-21 16:11:09 -05:00
Eric Fried
cf1006bf0e Fix plugin autodoc generation
Documentation for plugins wasn't being generated because the plugin
projects weren't being installed in the docs environment. Add them to
doc/requirements.txt to make this work.

Change-Id: Id9be39971110fd2eb4519a0582c9bf2514cdcacd
Story: #1735016
Task: #13825
2019-10-21 16:10:56 -05:00
OpenStack Release Bot
154df0d069 Update master for stable/train
Add file to the reno documentation build to show release notes for
stable/train.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/train.

Change-Id: I2cab236b14bc5eac173d815a634c8d8eb2afee04
Sem-Ver: feature
2019-10-04 13:06:18 +00:00
Zuul
371f5f5522 Merge "Add 'openstack server migrate (confirm|revert)' commands" 2019-10-03 11:19:48 +00:00
Andreas Florath
9ad3439689 Fix osc-lib interface change: catch osc-lib Forbidden
The patch https://review.opendev.org/#/c/673389/
introduced a regression by changing the osc-lib
interface.

The patch
https://review.opendev.org/683119
changes the exception from the generic CommandError
back to a specific Forbidden exception.

This patch catches this exception and passes on, i.e.
re-implements the same behavior as before.

Story: 2006547

Change-Id: I17b1ec7abaa5b0828ccbcad40bd928565c5c59fb
Signed-off-by: Andreas Florath <Andreas.Florath@telekom.de>
2019-09-19 11:59:11 +00:00
Zuul
aa64eb6b0a Merge "Update release table for Train and 4.0.0" 2019-09-11 19:35:52 +00:00
Jens Harbott
b4e9b225b4 Add dns_publish_fixed_ip attribute to subnets
With the subnet_dns_publish_fixed_ip extension Neutron has added a new
attribute to subnets, allowing to select whether DNS records should be
published for fixed IPs from that subnet. Add support for this when
creating and updating subnets.

[0] https://bugs.launchpad.net/neutron/+bug/1784879
[1] https://review.opendev.org/662405
[2] https://review.opendev.org/662409

Depends-On: https://review.opendev.org/679833
Change-Id: Ia804e878acfd1f05e1f00c2ac9202c1d260827f4
2019-09-11 08:33:16 +00:00
Zuul
06b49c03dd Merge "Clean up app initialization and config" 2019-09-11 07:08:54 +00:00
Dean Troyer
cb0c20b23c Update release table for Train and 4.0.0
Also clean up some docs and release notes.

Change-Id: I73feec747ca1bd12be5e5700c9ca608ed3a8b2c2
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-09-10 23:48:32 -05:00
Zuul
9101440c07 Merge "Add doc and relnote for review 639652" 2019-09-11 04:00:32 +00:00
Zuul
b7b124f327 Merge "More aggregate functional race chasing" 2019-09-11 02:29:28 +00:00
Zuul
71d805008b Merge "Default to Cinder v3 API" 2019-09-10 21:23:52 +00:00
Dean Troyer
de8ab5e8fd More aggregate functional race chasing
AggregateTests.wait_for_status() was a classmethod, those often
are sources of conflict in parallel testing...

Change-Id: I6211fd9c36926ca97de51a11923933d4d9d2dfda
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-09-10 14:09:29 -05:00
Stephen Finucane
609988ebac Add 'openstack server migrate (confirm|revert)' commands
While cold migration and resize are essentially the same operation under
the hood, meaning one could use the 'openstack server resize confirm'
and 'openstack server resize revert' commands instead, there is no
reason the operator needs to know this. Add these flags as syntactic
sugar to help simplify operators lives.

The help texts for both the 'openstack server resize' and 'openstack
server migrate' commands are updated to clarify the relationship between
the two operations.

Change-Id: I0cb6304c794bffaec785add9f7b8cf53ab28cacd
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2019-09-10 13:45:41 +00:00
Zuul
e8a335b233 Merge "Fix typo: "to and endpoint"" 2019-09-09 16:12:26 +00:00
Zuul
d1385971bb Merge "Add floating IP Port Forwarding commands" 2019-09-09 16:12:23 +00:00
Zuul
678167a6bf Merge "Format location columns in network commands" 2019-09-09 15:48:24 +00:00
Dean Troyer
037a800538 Add doc and relnote for review 639652
https://review.opendev.org/639652/

Change-Id: I10c0f8a0e09150e7d516ed9cb7ffb2a8e8fe4911
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-09-09 10:31:49 -05:00
Sean McGinnis
a96089ff6d Default to Cinder v3 API
This switches the default Cinder API version to v3 to prepare for v2
going away.

Change-Id: Icca1512b715409e3001c0fd2d1ea663d5e71ec02
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-09-09 09:35:44 -05:00
Dean Troyer
ee48777207 Clean up app initialization and config
* Remove unnecessary code in OpenStackShell.initialize_app() - only
  the bits it instantiate our subclass of ClientManager remain
* Remove OSC_Config - with https://review.opendev.org/#/c/678095/
  the last remaining required bit moves to osc-lib

Thos requires osc-lib 1.14.0

Change-Id: Ia4b3c737de9dc34949e74632441621014ef9eea9
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-09-09 14:01:57 +00:00
zhangbailin
dd1ce37042 Follow-up: fix the invalid releasenote link
By reviewing OSC's releasenote document [1], I found that the
blueprint index is invalid. This patch fixes this problem.

[1]https://docs.openstack.org/releasenotes/python-openstackclient/unreleased.html#new-features

Related-On: https://review.opendev.org/#/c/665336
Part of blueprint support-specifying-az-when-restore-shelved-server

Change-Id: I14066dcfff5a585d51b4f365883a86a5cc086d45
2019-09-05 11:11:26 +08:00
zhangbailin
fcd46acb69 Microversion 2.77: Support Specifying AZ to unshelve
This patch adds a new parameter ``--availability-zone`` to
``openstack server unshelve`` command. This can help users to specify
an ``availability_zone`` to unshelve a shelve offloaded server from
2.77 microversion.

Depends-On: https://review.opendev.org/679295

Implements: blueprint support-specifying-az-when-restore-shelved-server

Change-Id: Ia431e27c2a17fe16466707cc362532860ecf22df
2019-09-03 21:38:44 +00:00
Takashi Kajinami
7c1b6a799e Add parent project filter for listing projects
This patch introduces a new option --parent into project list,
to specify a parent project to filter projects which has
the given project as their parent.

Depends-on: https://review.opendev.org/#/c/677101
Change-Id: I6725262cf040e0ec6ceca9cf0462ce59224049c6
2019-09-02 09:05:37 +09:00
Hongbin Lu
7549d260aa Bump lower constraint of python-zunclient
Projects that depends on python-zunclient should use the latest
version as lower constraint.

Change-Id: Idc865788f35427cc0f2926b31089ec4097831334
2019-09-01 22:36:34 +00:00
Zuul
bdf129b15f Merge "Remove races in floating ip functional tests" 2019-08-31 19:43:14 +00:00
Dean Troyer
31c47adebb Remove races in floating ip functional tests
Multiple subnets with the same name are occasionally created when
running tests in parallel.

Change-Id: Ifb85e39ee53b529e2b97abf782c7fba93d48e9e2
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-31 09:03:46 -05:00
Dean Troyer
a88e95873e Bump min osc-lib to 1.14.0
This is required for osc4 and the movement of functions out of OSC.

Change-Id: I690954b6dccb11dd1a4f512b6777d645de5191f9
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-30 15:26:54 -05:00
Dean Troyer
6ee7b8d138 Format location columns in network commands
These return a Munch from the SDK, which can be handled exactly
like a dict so do that.

Note that the location column has a nested project dict in the
return value, this is addressed separately in osc_lib.format_columns
in https://review.opendev.org/#/c/679474/.

Change-Id: I99a6d192749a4ac76777f72be8118261c0521cb0
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-30 12:53:18 -05:00
Zuul
eed615e7d0 Merge "Remove token_endpoint auth type" 2019-08-29 00:02:31 +00:00
LIU Yulong
f044016e29 Add floating IP Port Forwarding commands
Add following commands:
  floating ip port forwarding create
  floating ip port forwarding delete
  floating ip port forwarding list
  floating ip port forwarding set
  floating ip port forwarding show

Closes-Bug: #1811352
Change-Id: I6a5642e8acce28fc830410d4fa3180597b862761
2019-08-29 07:39:42 +08:00
Zuul
fd63a909a8 Merge "Bump hacking version" 2019-08-28 02:42:06 +00:00
Stephen Finucane
6419533f43 Bump hacking version
Pick up newer versions of this library. Thankfully no serious changes
are needed.

Change-Id: I69e523844529fc1c8aa0c1ce764182dbe29cfeb6
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2019-08-27 17:12:15 -05:00
Zuul
c9cc8b0ae2 Merge "Format aggregate command fields and de-race functional tests" 2019-08-27 18:04:57 +00:00
Dean Troyer
6fcc2608b1 Remove token_endpoint auth type
The token_endpoint was a compatibility auth type to maintain support
for the --url global option that dated back to the beginning of
OpenStack CLI auth.  The common keystoneauth library implements
'admin_token' which provides the same functionality using
--endpoint rather than --url.

Change-Id: I1b9fbb96e447889a41b705324725a2ffc8ecfd9f
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-27 11:08:50 -05:00
Zuul
6c818c4925 Merge "Add CLI argument tests before making changes" 2019-08-27 00:59:46 +00:00
Dean Troyer
03a2accb2f Format aggregate command fields and de-race functional tests
Rename metadata to property in all aggregate commands

Beef up functional tests to reduce street racing

Change-Id: I4598da73b85a954f3e6a3981db21891b45d9548c
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-26 17:50:06 -05:00
Zuul
7b7488d51c Merge "Fix functional.base.TestCase.openstack() to optionally omit --os-auth-type" 2019-08-23 19:40:13 +00:00
Dean Troyer
75f0f82c41 Add CLI argument tests before making changes
Add these tests before hacking on the global args and removing
the compatibility stuff so we can clearly see what actually changes.

Change-Id: Ic86c89da1475b4914ff7cb2396199cd219a12097
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-22 23:50:24 -05:00
Zuul
0001404d7d Merge "Document 2.53 behavior for compute service list/delete" 2019-08-22 21:39:51 +00:00
Dean Troyer
3b2863e369 Fix functional.base.TestCase.openstack() to optionally omit --os-auth-type
Change the functional test TestCase.openstack() method to add a
way to not include the --os-auth-type option in order to test the
default auth-type logic.

Change-Id: I0f1ca2f7517a41278afaad5aaf4e98accb16bea2
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-22 11:05:09 -05:00
Zuul
a15e4741fa Merge "Add 'openstack server resize (confirm|revert)' commands" 2019-08-20 18:12:20 +00:00
Zuul
8ef2602447 Merge "Add openstack server create --boot-from-volume option" 2019-08-20 18:10:21 +00:00
Zuul
60da718fde Merge "Fix <id> description for --block-device-mapping" 2019-08-20 18:10:20 +00:00
Zuul
07fcb733fc Merge "Support type=image with --block-device-mapping option" 2019-08-20 17:58:30 +00:00
Zuul
b0ec909160 Merge "Fix compute service set handling for 2.53+" 2019-08-20 17:53:33 +00:00
Matt Riedemann
1557afb554 Document 2.53 behavior for compute service list/delete
With compute API microversion 2.53, nova-compute services
can only be deleted with the ID as a UUID to uniquely identify
the service in a multi-cell deployment. This documents that for
the "compute service delete <service>" argument. The description
of the "compute service list" command is also updated to mention
that the ID can be retrieved as a UUID using 2.53 or greater.

Change-Id: If7d4a27c0aaef588bcd77dd9edddec1e535fbf31
Story: 2005349
Task: 30302
2019-08-20 15:38:59 +00:00
Zuul
9042668da4 Merge "Make configuration show not require auth" 2019-08-09 17:29:40 +00:00
Matt Riedemann
b9d6310556 Add openstack server create --boot-from-volume option
This adds a --boot-from-volume option to the server create
command which is used with the --image or --image-property
option and will create a volume-backed server from the
specified image with the specified size. Similar to the
--volume option, the created root volume will not be deleted
when the server is deleted. The --boot-from-volume option
is not allowed with the --volume option since they both create
a block device mapping with boot_index=0.

Change-Id: I88c590361cb232c1df7b5bb010dcea307080d34c
Story: 2006302
Task: 36017
2019-08-09 16:44:46 +00:00
Matt Riedemann
c28ed25e3a Fix <id> description for --block-device-mapping
The <id> portion of a --block-device-mapping value can be
the resource name or id since the code uses the appropriate
type-specific find_resource utility to lookup the resource
based on the value given.

This change simply fixes the description of <id> to mention
it's name or id rather than just "UUID". My guess is the
description was originally copied from novaclient where id
must be an id since name resolution does not happen in novaclient.

Change-Id: I567f6f6efb3a3b6d387133d21aa81354b2d753bc
2019-08-09 16:44:39 +00:00
Matt Riedemann
6a199bd141 Support type=image with --block-device-mapping option
The --block-device-mapping option on the server create
command currently only supports booting from volume and
volume snapshot. A common boot-from-volume scenario is
providing an image and letting nova orchestrate the
creation of the image-backed volume and attaching it to
the server.

This adds support for type=image in the --block-device-mapping
option. The volume size is required in this case. Note that
the CLI currently says if type=snapshot that size is also required
but that's technically not true. When booting from a volume
snapshot, the compute API will use the size of the volume snapshot
to create the volume if an explicit size is not provided. For the
purposes of this patch, we need the size anyway for the image
being the block device mapping source type.

Change-Id: I57b3c261d8309f7b9f62a3e91612bce592a887a3
Story: 2006302
Task: 36016
2019-08-09 16:36:17 +00:00
Matt Riedemann
4bd53dc109 Fix compute service set handling for 2.53+
With compute API microversion 2.53 there is a single
PUT /os-services/{service_id} API which takes the service
id as a UUID. Since the openstack compute service set
command only takes --host and --service (binary) to identify
the service, this change checks if 2.53 or greater is being
used and if so, looks up the service by host and binary and
calls the appropriate methods in novaclient.

If the command cannot uniquely identify a compute service
with the given host and binary, an error is raised. A future
change could add an --id option to be used with 2.53+ to
pass the service id (as UUID) directly to avoid the host/binary
filtering.

Change-Id: I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0
Story: 2005349
Task: 30302
2019-08-09 16:00:13 +00:00
Stephen Finucane
7561e062eb Add 'openstack server resize (confirm|revert)' commands
These are currently exposed as flags on the 'openstack server resize'
command but they are in fact operation and should be exposed as commands
in their own right.

The old flag-based variants are deprecated for removal in 4.0.

Change-Id: I733796d3bda6c3755a3d3548bbe695abb474a6a0
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2019-08-09 15:48:15 +00:00
Zuul
6f60f833e8 Merge "openstack port create support --extra-dhcp-option" 2019-08-01 21:56:43 +00:00
Zuul
005a247b60 Merge "Mention compute service set --up|--down requires 2.11 or greater" 2019-08-01 21:56:42 +00:00
Zuul
daadcd79c5 Merge "Support IPv6 addresses better" 2019-08-01 21:54:02 +00:00
Dean Troyer
865e182970 Make configuration show not require auth
The configuration show should not require auth to just display the
OSC config object.  Changes to make it not require auth have
knock-on effects of needing to change a bunch of tests that use it
assuming it _does_ require auth so change those to use 'extension list'
instead.

This sets up further testing of the command line options for changes
in behaviour when we switch to straight SDK usage for configuration.

Change-Id: I6c52485341214ba401064c0f2d1e2b95fdc225c0
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-08-01 14:53:02 -05:00
Tim Burke
ba0a8e9318 Fix typo: "to and endpoint"
Change-Id: I33b7bbf7f452991d7f066aa6c17e905f5a4ddb05
2019-07-30 11:50:05 -07:00
Akihiro Motoki
1bad2cb3c3 Fix module paths for volumev3 volume backup commands
https://review.opendev.org/#/c/612751/ renamed volume.v2.backup
to volume.v2.volume_backup. volume.v3 backup commands refer
volume.v2.backup but they were not updated.
This causes "volume backup xxx" commands
when OS_VOLUME_API_VERSION=3 is specified.

Change-Id: Ib897dd483a7963763016ee3f1e8e1c3cc81d0bb0
Story:o 2006284
Task: 35990
2019-07-26 17:38:28 +09:00
zhouhenglc
68809fce5a openstack port create support --extra-dhcp-option
neutron create-port API  has extra_dhcp_opts parameter, this parameter
can set port with special extra dhcp options.

Change-Id: I199f17e95c509a33f809ac85c65f685a37acd198
2019-07-25 06:13:11 +00:00
Matt Riedemann
b52a831f6b Mention compute service set --up|--down requires 2.11 or greater
This simply updates the docs for the compute service set --up
and --down options to mention that --os-compute-api-version 2.11
or greater is required to use those options.

Change-Id: I52891fe36c84d0df3e868ab4f3c8e2357e9ba529
2019-07-24 12:03:01 -04:00
Zuul
c474319909 Merge "Add host and hypervisor_hostname to create servers" 2019-07-23 01:32:32 +00:00
Andreas Jaeger
c609b98c40 Update api-ref location
The api documentation is now published on docs.openstack.org instead
of developer.openstack.org. Update all links that are changed to the
new location.

Note that redirects will be set up as well but let's point now to the
new location.

For details, see:
http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007828.html

Change-Id: I1572a21632740b4d9a233a6a31c49e3bac5394ef
2019-07-22 20:55:43 +02:00
Zuul
5b97dfa427 Merge "Fix BFV server list handling with --name-lookup-one-by-one" 2019-07-19 17:27:59 +00:00
zhu.boxiang
340f25fa14 Add host and hypervisor_hostname to create servers
Adds the --host and --hypervisor-hostname options to
``openstack server create`` CLI.

Depends-On: https://review.opendev.org/670558

Change-Id: If188c3d96fa506dbe62ef256418f2f9bca1520c2
Blueprint: add-host-and-hypervisor-hostname-flag-to-create-server
2019-07-19 15:45:18 +00:00
Zuul
afe1f02c8b Merge "docs: clarify compute service --service option" 2019-07-16 11:49:03 +00:00
Brian Haley
969e6abd20 Support IPv6 addresses better
When adding a security group rule, if no IP address is given
we will use '0.0.0.0/0', but if the ethertype is IPv6 we will
leave it as None.  Change this to be '::/0' to match what we
do for IPv4 - use the "any" address.  The neutron server
treats them both the same when checking for duplicates.

Because there are most likely entries in the DB using None
for the IP, print them as '0.0.0.0/0' or '::/0' so it is more
obvious what address they are actually referring to.

Also change to display the Ethertype column by default
instead of with --long, since easily knowing IPv4 or IPv6
is useful.

Change-Id: Ic396fc23caa66b6b0034c5d30b27c6ed499de5a6
Closes-bug: #1735575
2019-07-15 22:35:49 -04:00
Corey Bryant
b41d7518c3 Add Python 3 Train unit tests
This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.

See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html

Change-Id: I7d0a996b33d4d1eec436f92fbd390968cd37630c
Story: #2005924
Task: #34232
2019-07-05 14:33:43 -04:00
Zuul
d270174a21 Merge "Add Python 3 Train unit tests" 2019-07-03 04:03:30 +00:00
Matt Riedemann
879f820778 docs: clarify compute service --service option
The compute service commands emit a "Binary" in the output but
the --service filter option isn't as clear that it's the binary
(for set it is but not list) nor do the docs give an example
of a binary (typically nova-compute but could be others like
nova-conductor, nova-scheduler, etc). This simply mentions that
the --service option is the binary for "compute service list"
and gives an example value for the option in both list and set
help.

Change-Id: If87fc37352c3a251cc89041723adbe04dedf4f8a
2019-07-01 15:06:56 -04:00
pengyuesheng
d16d98b27b Update the constraints url
For more detail, see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006478.html

Change-Id: Ie0a41fa97696bcd8b5fd2e670efdf9379ff1080e
2019-07-01 15:13:11 +08:00
pengyuesheng
5986f47306 Add Python 3 Train unit tests
See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html

Change-Id: I897645a4cb9f03ca464daa14f0895572212b81d9
2019-07-01 15:08:23 +08:00
melanie witt
bfc34e11b3 Fix BFV server list handling with --name-lookup-one-by-one
When the --name-lookup-one-by-one option passed to the 'server list'
command, the image and flavor names will be looked up for each
server being listed instead of fetching all image/flavor names.

The current code assumes all servers have an image attribute, but
servers booted from volumes have no image, so the following error is
raised when listing BFV servers with --name-lookup-one-by-one:

  AttributeError: ('unicode'|'str') object has no attribute 'get'

The error occurs when the code attempts server.image.get('id').

This fixes the --name-lookup-one-by-one code not to assume an image
for a server. The unit tests for 'server list' have also been
robustified to feature one BFV server to enhance our test coverage.

Story: #2006063
Task: #34777

Change-Id: I312c971346c7ded93f6fcaa515098554b8580295
2019-06-28 22:06:39 +00:00
Zuul
eada2db332 Merge "Use cliff formattable columns in identity commands" 2019-06-23 04:49:33 +00:00
Zuul
f0fafec54f Merge "Use cliff formattable columns in image commands" 2019-06-23 04:30:51 +00:00
Zuul
34a92eebfa Merge "Use cliff formattable columns in object storage commands" 2019-06-23 02:31:15 +00:00
Zuul
46ef850ce9 Merge "Use cliff formattable columns in volume v2 commands" 2019-06-23 00:45:37 +00:00
Zuul
d3df7d67d7 Merge "Use cliff formattable columns in volume v1 commands" 2019-06-23 00:45:36 +00:00
Zuul
3258b9e5e3 Merge "Change default security group protocol to 'any'" 2019-06-22 21:39:31 +00:00
Akihiro Motoki
4cd614305f Use cliff formattable columns in volume v2 commands
Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: I761ccac126208927594ad0d98a3cf5ad8b44bd48
2019-06-22 14:56:10 -05:00
Akihiro Motoki
1af3056e30 Use cliff formattable columns in volume v1 commands
Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: Ib4c5798171e32a8ddc08a37ee1d416e366a71d76
2019-06-22 14:53:28 -05:00
Akihiro Motoki
c2630ae91a Use cliff formattable columns in object storage commands
Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: I65737561c9b5ef29f5878316d2ff89f3d538158f
2019-06-22 18:44:27 +00:00
Akihiro Motoki
8d63e3f0c3 Use cliff formattable columns in image commands
Related functional tests are converted into JSON format.
Otherwise, it is not easy to check results.

Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: Ib82e15738544975fede0c54cc5eaf239f4c67277
2019-06-22 13:36:46 -05:00
Zuul
1a21f02bc7 Merge "Use cliff formattable columns in network commands" 2019-06-22 18:27:00 +00:00
Akihiro Motoki
fa5046a3db Use cliff formattable columns in identity commands
Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: Ia13314a012b3a7363ffb24a13c79c6ecdff1ed7b
2019-06-22 16:18:26 +00:00
Zuul
c20421c467 Merge "Remove deprecated volume commands and args" 2019-06-22 07:17:28 +00:00
Zuul
0bc70a344f Merge "Add server add/remove volume description for microversion 2.20" 2019-06-22 00:27:31 +00:00
Zuul
1d6e24246a Merge "Remove deprecated network options" 2019-06-21 23:00:59 +00:00
Zuul
3161f87c44 Merge "Remove deprecated image commands" 2019-06-21 23:00:57 +00:00
Zuul
377c0ce0f7 Merge "Remove deprecated identity commands and args" 2019-06-21 23:00:56 +00:00
Zuul
d103b3dc88 Merge "Remove deprecated compute commands" 2019-06-21 22:58:17 +00:00
Zuul
17611a72c5 Merge "Microversion 2.73: Support adding the reason behind a server lock" 2019-06-21 20:59:49 +00:00
Zuul
e5cb150b6f Merge "Allow "server migrate" (not live) to take "--host" option" 2019-06-21 19:26:10 +00:00
Zuul
d756f70e39 Merge "Add server event command documentation for compute API 2.21" 2019-06-21 19:26:09 +00:00
Surya Seetharaman
187be0ac22 Microversion 2.73: Support adding the reason behind a server lock
This patch adds a new parameter ``--reason`` to ``openstack server lock``
command and ``--locked``, ``unlocked`` filtering parameters to
``openstack server list`` command. This can help users to provide a
reason when locking the server and to filter instances based on their
locked value from 2.73 microversion.

Implements blueprint add-locked-reason
Depends-On: https://review.opendev.org/#/c/661785/

Change-Id: Ib2714f98b24d47e570da8a6c231e765acd2ff595
2019-06-21 11:35:51 -05:00
Martin Chlumsky
1aad94349b Allow "server migrate" (not live) to take "--host" option
Currently, doing a cold migration while specifying a target host is not
possible however nova api supports it since version 2.56.

This patch allows passing "--host" when doing a cold migration.
It runs normally if --os-compute-api-version is 2.56 or greater and
returns an error otherwise.

Change-Id: I960109008096ce8bb4e4c8ca6ffb22c33aacd995
Story: 2003325
Task: 24359
2019-06-21 14:47:07 +00:00
Zuul
82823f89f0 Merge "Rename review.openstack.org to review.opendev.org" 2019-06-14 02:25:02 +00:00
Matt Riedemann
3df5f92b44 Add server add/remove volume description for microversion 2.20
The compute API 2.20 microversion allows attaching and detaching
a volume to/from a server with status SHELVED or SHELVED_OFFLOADED.
For OSC this just means the user has to specify the appropriate
minimum microversion to make that work, so this change mentions
that in the "server add volume" and "server remove volume" command
description.

Related to nova blueprint volume-ops-when-shelved

Change-Id: I4824175e5d9e124e3bd9e9a8fd5a89277efc6cff
2019-06-12 11:39:54 -04:00
Matt Riedemann
eb399c52ad Add server event command documentation for compute API 2.21
The 2.21 compute API microversion allows listing instance
action events and getting action event details for a deleted
server (which can be useful for auditing until the deleted
server is purged). As far as OSC is concerned it's just a
matter of specifying --os-compute-api-version 2.21 or higher
when listing events or showing event details, so this change
mentions 2.21 in the description of those commands.

Related to nova blueprint os-instance-actions-read-deleted-instances

Change-Id: If276c794f448b6fa5b0845499f3507a159acab85
2019-06-12 11:23:06 -04:00
Zuul
57dec524c8 Merge "Batch up minor cleanups for release" 2019-06-06 23:19:12 +00:00
Zuul
25ccca4063 Merge "Deprecate openstack server migrate --host option" 2019-06-06 19:05:46 +00:00
Zuul
86d7490f77 Merge "Add changes-before attribute to server list" 2019-06-06 17:40:48 +00:00
Zuul
95626f1acb Merge "Compute: Add description support for server" 2019-06-05 03:25:46 +00:00
zhangbailin
ef1fd38815 Add changes-before attribute to server list
Closes-Bug: #1827844
Part of bp support-to-query-nova-resources-filter-by-changes-before

Change-Id: I4f28168188973730247bcbcb70ba0e70eb81e3be
2019-05-31 05:39:29 +00:00
Matt Riedemann
3057989714 Deprecate openstack server migrate --host option
Per the discussion at the Train Forum [1] this deprecates
the problematic --live option on the server migrate command
which, depending on the compute API version used, forcefully
bypasses the scheduler and also does not allow you to live
migrate a server and let the scheduler pick a host.

The --live option is replaced here with two new options:

* --live-migration: this simply tells the command you want to
  perform a live rather than cold migration; if specified with
  --live the --live-migration option takes priority.

* --host: when specified, this will request a target host for
  the live migration and will be validated by the scheduler;
  if not specified, the scheduler will pick a host. This option
  is mutually exclusive with --live.

We can build on the --host option by supporting cold migrations
with a specified host when using compute API version 2.56 or
greater but that will come in a separate change.

If the --live option is ever used we log a warning.

Note there are several related changes for this issue:

- https://review.openstack.org/#/c/628334/
- https://review.openstack.org/#/c/626949/
- https://review.openstack.org/#/c/627801/
- https://review.openstack.org/#/c/589012/
- https://review.openstack.org/#/c/460059/

This change allows us to deprecate the --live option and provide
a replacement which is backward compatible without having to use
something potentially error-prone like nargs='?'.

Closes-Bug: #1411190

[1] https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps

Change-Id: I95d3d588e4abeb6848bdccf6915f7b5da40b5d4f
2019-05-24 15:57:54 -04:00
Sean McGinnis
e76e10c0ba Remove deprecated volume commands and args
The following were deprecated over two years ago and can now be removed:

* Remove ``backup`` commands in favor of ``volume backup``
* Remove ``snapshot`` commands in favor of ``volume snapshot``
* Remove ``volume create`` options ``--project``, ``--user`` and ``--multi-attach``
* Use of an auth-key positional argument in volume transfers
* ``volume transfer request`` no longer accepts 'auth_key' as a positional arg,
  ``--auth-key`` is now required

Internal (non-user-visible)
* Rename backup.py to volume_backup.py for Volume v1 and v2, update tests

These are backwards incompatible changes and will require a major
version bump after they are merged.

Change-Id: I94aa7a9824e44f9585ffb45e5e7637b9588539b4
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-20 14:05:18 -05:00
Dean Troyer
6f1f44d422 Batch up minor cleanups for release
Change-Id: Id45788e17c5388cee54e79cab1c120cfcc8f9f62
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-20 08:41:28 -05:00
Sean McGinnis
5a0fc68a87 Remove deprecated network options
The following were deprecated for several releases and can now be
removed:

* Remove ``port create|set`` options ``--device-id`` and ``--port-id``
* Remove ``router set`` option ``--clear-routes``
* Remove ``security group rule create`` options ``--src-group`` and ``--src-ip``

These are backwards incompatible changes and will require a major
version bump after they are merged.

Change-Id: Ieae74c14f6b3e263721a3146cf76f94a9ab792f6
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-19 18:22:26 -05:00
Dean Troyer
67dadda746 Remove deprecated image commands
* Remove ``image create|set`` option ``--owner``

Change-Id: I1fabab98c8660eba6d0dd75e74544c6c9d432b9e
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-19 17:06:19 -05:00
Sean McGinnis
f9fdc296bc Remove deprecated identity commands and args
The following were deprecated over two years ago and can now be
removed/changed:

* Remove ``service create`` option ``--type``
* Remove ``role list`` options ``--project`` and ``--user``
* Remove ``user role list`` command

These are backwards incompatible changes and will require a major
version bump after they are merged.

Change-Id: I29e2fc9516dffbfd83eef0bc91e834dde99b4105
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-19 12:54:33 -05:00
Sean McGinnis
b7742b5937 Remove deprecated compute commands
The following were deprecated over two years ago and can now be removed:

* ``ip fixed add|remove`` in favor of ``server add|remove fixed ip``
* ``ip floating add|remove`` in favor of ``server add|remove floating ip``

These are backwards incompatible changes and will require a major
version bump after they are merged.

Change-Id: I10c4d32a3c0b55ad41a02afd3b14249bafcb55a9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-19 12:54:24 -05:00
Zuul
91bc0f35de Merge "Remove code migrated to osc-lib long ago" 2019-05-18 18:47:43 +00:00
Zuul
875335b610 Merge "Serialize more aggregate functional tests" 2019-05-18 18:06:03 +00:00
Dean Troyer
99c3be93c8 Serialize more aggregate functional tests
These tests are showing signs of problems running in parallel
so serialse the create/delete/list/set/unset tests.  They all
used two aggregates each anyway...

Change-Id: Iba4b52c179e6914eaeefea1da0f7eaefcdcf1f87
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-17 19:15:28 -05:00
Zuul
e90b79be4c Merge "Fix RuntimeError when showing project which has extra properties" 2019-05-17 23:07:57 +00:00
Zuul
8ee23fe917 Merge "Fix bug in endpoint group deletion" 2019-05-17 21:33:34 +00:00
Chen
c77a9621be Compute: Add description support for server
This patch adds functionality to configure server's description with:
1 server create
2 server set
3 server unset
4 server rebuild

Change-Id: Ic06d97b29e51828b29d7ac5172645c288e4ada9e
Story: 2002005
Task: 19640
2019-05-17 20:56:45 +00:00
Zuul
6c481c2dae Merge "Aggregate functional test tweak" 2019-05-17 04:35:35 +00:00
Dean Troyer
1b2595a959 Remove code migrated to osc-lib long ago
* Remove openstackclient.api.utils and use osc_lib.api.utils
* Remove openstackclient.common.clientmanager.ClientManager.auth_ref
* Remove openstackclient.common.commandmanager

Change-Id: I67e1dbc53cc0b37967c0011bcb2fc09bdef62d94
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-16 19:19:58 -05:00
Zuul
770cb70151 Merge "Update sphinx requirement." 2019-05-16 19:09:56 +00:00
Dean Troyer
bb659cf438 Aggregate functional test tweak
This seems to still be racy, lengthen the timeout to wait for
agregate creation.

Change-Id: I3601c5baee03745ae21714b9dff0e278ad016877
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-16 07:43:55 -05:00
Natal Ngétal
f179117976 Update sphinx requirement.
Sphinx 2.0 no longer works on python 2.7, start cappingit there as well.

Change-Id: I8a7d227b2f925066fc8213aa62b5756927ee263b
2019-05-15 14:13:49 +02:00
melissaml
aabc67f3a2 Rename review.openstack.org to review.opendev.org
There are many references to review.openstack.org, and while the
redirect should work, we can also go ahead and fix them.

Change-Id: I82e3797dd4c05e4944f40c950b4fafe9a5334cbf
2019-05-12 04:41:27 +08:00
Brian Haley
4b91cd4965 Stop leaving temp files after unit test runs
test_shell.CLOUD_2 is using an absolute path for a temp
file, so leaves /tmp/test_log_file around after the unit
tests are run.  Use a fixture instead so it's cleaned
automatically, which also removes the possibility of two
tests using the same file and interfering with each other.

Change-Id: If722b860be4010b91635c6d46f634da980e17152
2019-05-10 15:47:09 +00:00
Zuul
1bc44fcdc6 Merge "document the --timing option" 2019-05-10 13:12:07 +00:00
Akihiro Motoki
c44f26eb7e Use cliff formattable columns in network commands
Use cliff formattable columns not to convert complex fields
into a string when a machine readable format like JSON or YAML
is requested.

Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: I9878f327e39f56852cc0fb6e4eee9105b7141da9
2019-05-09 21:51:57 -05:00
Dean Troyer
6385d64237 Blacklist Bandit 1.6.0 due to directory exclusion bug
Bandit 1.6.0 introduces a regression[0] with the -x option, a fix
is expected to be included in 1.6.1 soon.

[0] https://github.com/PyCQA/bandit/issues/488
[1] https://github.com/PyCQA/bandit/pull/489

Change-Id: I110829ef960e3ee146f47871ef076491244bf4fa
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-05-09 16:47:46 -05:00
Zuul
ba66cdfcfa Merge "Fix --limit option in image list sub-command" 2019-05-08 23:25:16 +00:00
Jose Castro Leon
04e03b2a1f Fix bug in endpoint group deletion
There is a typo in the endpoint group deletion, due to this you
can't remove endpoint groups once assigned. I am adding also the
unit tests to avoid this kind of issues in the future

Task: 30640
Story: 2005521
Change-Id: Ie938f2c9894bb39b4c0ed1f7aa3a6a751a303058
2019-05-08 16:22:27 -05:00
Guang Yee
e6bbc995c5 document the --timing option
Change-Id: I2d13088ea026ac7288213fe808874c4a3a81313a
Story: #2005315
Task: #30863
2019-05-08 08:17:55 +00:00
Brian Haley
33a255612c Change default security group protocol to 'any'
The default protocol used to create a security rule was changed to
``tcp``, which was a regression from the neutron client.  Change it
back to ``any``, which skips sending the protocol to the API
server entirely when using the Neutron v2 API.

Users that had been creating rules without specifying a protocol
and expecting ``tcp`` need to change to use ``--protocol tcp``
explicitly.

Change-Id: Iedaa027240e00dced551513d8fa828564386b79f
Closes-bug: #1716789
2019-05-06 10:55:13 -04:00
Zuul
a71cb02ce9 Merge "Dropping the py35 testing" 2019-05-03 22:46:17 +00:00
Zuul
260bfc4159 Merge "Document that server dump create requires 2.17" 2019-05-03 20:21:13 +00:00
Adam Spiers
8c1ec6f97f Fix link to new opendev repo
The switch to an opendev URL wasn't quite right, resulting in a 404.

Change-Id: I652f093384a584a56290a9b080913392873efd9f
2019-05-01 16:50:29 -06:00
Matt Riedemann
42cd4b2e40 Document that server dump create requires 2.17
There is no indication to the user in the command
help that they have to use 2.17 or greater [1] to run
the "openstack server dump create" command. This
mentions that requirement in the help of the command.

[1] https://developer.openstack.org/api-ref/compute/#trigger-crash-dump-in-server

Change-Id: I02c06e10a26eb38ddecb70f970cfcbfad962201c
2019-05-01 18:00:17 -04:00
Zuul
70cf7ea1ce Merge "Fix docs bug link to go to storyboard rather than launchpad" 2019-04-24 13:42:15 +00:00
Ghanshyam Mann
a8309a2a85 Dropping the py35 testing
All the integration testing has been moved to
Bionic now[1] and py3.5 is not tested runtime for
Train or stable/stein[2].

As per below ML thread, we are good to drop the py35
testing now:
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005097.html

[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004647.html
[2]
https://governance.openstack.org/tc/reference/runtimes/stein.html
https://governance.openstack.org/tc/reference/runtimes/train.html

Change-Id: Ie7bcc327fd588a1ff6b2556d49017df56bc55bf8
2019-04-22 23:45:27 +00:00
Dean Troyer
0f56b7d074 Followup opendev cleanup and test jobs
* upper-constraints references need s/plain/raw/

Change-Id: I04368dc42f1a62a048ac9d11497747ef6f600515
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-04-19 23:47:02 -05:00
OpenDev Sysadmins
b3da2a6726 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
2019-04-19 19:45:05 +00:00
Matt Riedemann
8ce203f879 Fix docs bug link to go to storyboard rather than launchpad
This fixes the docs bug link generation for the normal docs
and release notes docs.

The requirement on openstackdocstheme is bumped to 1.23.2 to
pick up fix I2ed164b9b0badade702c50543ac1a5eea4d1867b.

Change-Id: I89711a391ee0fb7e40c1fbf83f950e2b582358d9
Story: #2005467
Task: #30546
2019-04-16 18:40:14 -04:00
Zuul
cac699d0d9 Merge "Tweak network segment range fiunction tests" 2019-04-15 21:56:41 +00:00
Zuul
3b5dd14b80 Merge "Before writing object data to stdout, re-open it in binary mode" 2019-04-13 03:15:46 +00:00
Dean Troyer
4f3cda730f Tweak network segment range fiunction tests
We seem to be having occasional overlaps in the ranges, as they were
identical in all tests, change each test to not overlap the others
so running in parallel is not racy.

Change-Id: I7ea467a3aa2e4a4b4a334c10ea6ba21409c46af0
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-04-12 13:52:46 -05:00
Tim Burke
415b48056d Before writing object data to stdout, re-open it in binary mode
Otherwise, you can hit TypeErrors on Python3.

Change-Id: I9a891508886feddac3982ce593bd95130392e035
Closes-Bug: 1775482
2019-04-10 14:34:40 -05:00
Zuul
ee193e67a9 Merge "Volume backup functional test tweak" 2019-04-05 17:52:57 +00:00
Dean Troyer
589026cdd4 Volume backup functional test tweak
Waiting for status in all the wrong places...

Change-Id: I531ee6e0c00b623c6fd30d40df1f1f36bf86233f
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-04-02 08:39:23 -05:00
Jim Rollenhagen
c53de3214e Ignore case in security group rule --ethertype
Currently, this only allows 'IPv4' or 'IPv6', but one can imagine a user
frequently typing e.g. 'ipv6' and getting frustrated. Allow any case,
while still keeping correct case for the choices and the value sent to
Neutron.

Change-Id: I70ce1f43d32aad01b174437d03c984a5b608b161
2019-04-01 15:56:40 -04:00
OpenStack Release Bot
c684fd926a Update master for stable/stein
Add file to the reno documentation build to show release notes for
stable/stein.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/stein.

Change-Id: I3edfae7c1c5f8268186455efc7add28dc38810fb
Sem-Ver: feature
2019-03-22 00:46:00 +00:00
Zuul
6bd9cb6359 Merge "Fix: incorrect check when no shared/private input" 2019-03-16 01:05:18 +00:00
Zuul
17a2c67de9 Merge "Fix service discovery in functional tests" 2019-03-15 15:52:51 +00:00
Zuul
25ea59e8d0 Merge "Fix: set invalid None project_id on range creation" 2019-03-15 15:52:46 +00:00
Kailun Qin
510e9a7b8e Fix: incorrect check when no shared/private input
When neither of "--shared" and "--private" is input, we should not allow
to specify "--project". Defaulting the created network segment range to
shared is expected. Therefore, "project_id" attr should only be
populated on a private range creation.

Change-Id: Iab345e1651dd8b7904ff64a20633f194d719bb84
Story: 2005206
Task: 29980
2019-03-14 01:05:21 +08:00
Glenn Van de Water
7741347041 Fix service discovery in functional tests
If a required service is not enabled then we skip the test.
The discovery is done by tests/functional/base.py:is_service_enabled
but this method is broken, credentials are not passed to the
'openstack service show' command so every call will fail and every test
that relies on it will be skipped. This commit fixed that method and
the issues that popped up when re-enabling tests.

Network segment range:
 - issue where we assumed network-segment-range extension is always
   present
 - issue where we compare integers and string representations of numbers

Subnet:
 - issue where we try to deepcopy an uncopyable object in UnsetSubnet

Change-Id: Id3cc907c1ed2a25b49cf6f4a7233e0401a02383a
Story: 2005169
Task: 29908
2019-03-13 16:16:24 +01:00
Zuul
9b8a76fd61 Merge "Delete the LB object quotas set command in openstackclient" 2019-03-13 08:48:34 +00:00
Kailun Qin
28c06d0688 Fix: set invalid None project_id on range creation
"project_id" attribute should not be set to None on shared network
segment range creation since it is not a valid string type which is
required for the API.

Change-Id: Ia2bab12e39b4bb7e05ff2acfffb851252c100651
Story: 2005205
Task: 29975
2019-03-13 01:48:46 +08:00
Zuul
c36e75d986 Merge "Add 'security_group' type support to network rbac commands" 2019-03-11 02:41:39 +00:00
Zuul
6868499ad9 Merge "Add network segment range command object" 2019-03-08 02:27:37 +00:00
Zuul
c305ac2896 Merge "Mention compute API 2.50 in openstack quota show --class" 2019-03-07 23:19:16 +00:00
Zuul
e59b9f4261 Merge "Add note about version 2.5 when listing servers using --ip6" 2019-03-07 21:05:01 +00:00
Zuul
b83c6dc26a Merge "Mention 2.51 in help for openstack server event show" 2019-03-07 21:03:53 +00:00
Matt Riedemann
626a3a021c Mention compute API 2.50 in openstack quota show --class
There is a bug in the compute API until microversion 2.50
where the server-groups and server-group-members class
quota fields aren't returned. This just mentions that
microversion in the command help text.

Change-Id: I029a614a922d642c578618c478c4d0a29a394fc2
Task: 21490
Story: 2002194
2019-03-07 14:41:09 -05:00
Kailun Qin
d52920b387 Add network segment range command object
Add network segment range command object in support of network segment
range management.

This patch set includes documentation, unit tests and functional tests
(currently skipped unit network segment range enabled in Neutron by
default) for the following new commands:
  - "os network segment range create"
  - "os network segment range delete"
  - "os network segment range list"
  - "os network segment range set"
  - "os network segment range show"

Co-authored-by: Allain Legacy <Allain.legacy@windriver.com>

[depends on removed by dtroyer as those are all +W and 
trying to pass the gate, OSC has it's freeze dealine looming]
 Depends: https://review.openstack.org/624708
 Depends: https://review.openstack.org/624709
 Depends: https://review.openstack.org/638386

Partially-implements: blueprint network-segment-range-management
Change-Id: I335692f2db5be07c1c164f09b13f1abb80b7ba33
2019-03-07 19:39:17 +00:00
Zuul
7feb9d38d0 Merge "API microversion 2.69: Handles Down Cells" 2019-03-07 08:01:45 +00:00
Zuul
f992617f79 Merge "Add support for get details of Quota" 2019-03-07 00:34:18 +00:00
Zuul
8159fc216d Merge "Add possibility to filter images using member_status" 2019-03-07 00:34:17 +00:00
Zuul
1d16eed45a Merge "Paginate over usage list to return all usages" 2019-03-06 19:37:36 +00:00
Surya Seetharaman
239b103849 API microversion 2.69: Handles Down Cells
This patch explicitly points out the change needed while
forming the detailed lists for servers. In those cases
where the server response for ``openstack server list``
has the flavor and image keys missing for the instances
in the down cell, the servers will be skipped from being
processed.

Depends-On: https://review.openstack.org/591657/
Related to blueprint handling-down-cell
Change-Id: Ibcfe9febdc45db1cb86c6e88f65976feceb01c02
2019-03-06 08:35:25 +00:00
Doug Wiegley
be7a75814c
Add 'security_group' type support to network rbac commands
Partial-Bug: #1817119
Depends-On: https://review.openstack.org/635311
Change-Id: I5f132fa54714514d8dae62df8bc494f3f6476768
2019-03-05 21:02:03 -07:00
Zuul
f5980f9508 Merge "Typo fix" 2019-03-06 01:24:18 +00:00
Zuul
303cb4735d Merge "Add --attached / --detached parameter to volume set" 2019-03-06 00:58:17 +00:00
Pavlo Shchelokovskyy
c79de8a90b Paginate over usage list to return all usages
since nova api 2.40 the os-simple-tenant-usage API supports pagination
and will by default return a number of entities configured internally in
Nova.
This means that when there are many enough projects,
the single call to usage.list() will not return usages for all projects.

This patch effectively copy-pastes the logic to paginate over usage list
results from novaclient/v2/shell.py code.

Change-Id: I1b639fe386b7b7db3223f6965495094b9d51533a
Story: #2005099
Task: #29713
2019-02-28 20:27:04 +02:00
Zuul
3599ebe933 Merge "Fix: Restore output 'VolumeBackupsRestore' object is not iterable" 2019-02-28 17:52:37 +00:00
David Rabel
e776a4f026 Add --attached / --detached parameter to volume set
As to reflect cinder reset-state --attach-status functionality,
this patch adds --attached / --detached parameter to OSC's volume set
command.

Change-Id: Ic8ee928c9ab0e579512cfb7608f63bfcc2993c7b
Closes-Bug: #1745699
2019-02-28 15:48:34 +00:00
whoami-rajat
24255ad0dd Fix: Restore output 'VolumeBackupsRestore' object is not iterable
VolumeBackupsRetore object has '_info' attribute
which contains the output data of the restore
command which should be returned instead of the
'VolumeBackupsRestore' object.

Change-Id: I64b75649c1ac9c24e05a197f7280975564b4d386
Story: 2004740
Task: 28811
2019-02-27 22:28:09 +00:00
Zuul
3d7772e34a Merge "Partially Revert "Add command to unset information from Subnet-pools"" 2019-02-27 22:15:48 +00:00
Zuul
1ea988e5c6 Merge "This fix removes an erroneous underscore found within the function named test_snapshot_delete within test_snapshot.py found in both volume v1 and v2 of python-openstackclient." 2019-02-27 22:15:46 +00:00
Zuul
462a087bfb Merge "Remove str() when setting network objects names" 2019-02-27 22:15:41 +00:00
Zuul
80ce9fb35d Merge "Fix help message of image add project" 2019-02-27 21:56:56 +00:00
Zuul
dcfa680d9d Merge "add python 3.7 unit test job" 2019-02-27 21:56:51 +00:00
Christian Schneemann
6475882fd8 Typo fix
Just a typo fix.

Change-Id: I1d1fe6eb95c0b167265b3664314d764e3c316fe2
2019-02-27 09:06:18 +01:00
whoami-rajat
d43178c3a4 Disabling c-backup service for osc-functional-devstack-tips job
Since swift isn't compatible with py3 currently and disabled for
this gate job, c-backup service will always fail configuring.
The backup related tests can be handled by other jobs having swift
enabled.
The c-backup service can be enabled along with swift services once
swift is compatible with py3.
This patch disables the the c-backup service for osc-functional-devstack-tips
gate job.

Change-Id: Ifd3a4e1a15f1365107a2a1367513e2ef79bd13cc
2019-02-26 23:48:40 +05:30
Artem Goncharov
444a40c656 Add possibility to filter images using member_status
In order to see image sharing membership it is required to additionally
pass member_status filter to API. Otherwise only those with status 'all'
will be returned. Thus adding possibility to see images shared with
project to be approved or rejected.

Change-Id: Ifd6e13e5a4ef09fbc29e76d464c93fbdbb178ae4
2019-02-26 11:13:25 +01:00
Sławek Kapłoński
75cba9d1cb Add support for get details of Quota
With passing "--detail" argument to "openstack quota list", details
about current usage should be returned.
It is currently supported by Nova and Neutron so details of
resources from those projects can be returned.

Change-Id: I48fda15b34283bb7c66ea18ed28262f48b9229fe
Related-Bug: #1716043
2019-02-24 10:41:53 +00:00
David Rabel
4d76d7539a Fix help message of image add project
Only with the admin role you can use the project name with
'image add project'. With the normal member role you have to use the
project id instead. If you try to use the name, you don't receive an
error, but it won't work.

Change-Id: I61d402b39558320502dc08905b8c3a146e5e740a
Task: 29543
Story: 2002535
2019-02-21 19:35:08 +00:00
David Rabel
55cbbbe469 Fix help message of image add project
Only with the admin role you can use the project name with
'image add project'. With the normal member role you have to
use the project id instead. If you try to use the name, you
don't receive an error, but it won't work.

Change-Id: I2d11c07a256917d12c46a7c302c5a5e8752a1df0
Task: 29543
Story: 2002535
2019-02-19 12:49:18 +01:00
ZhongShengping
fa3c5e636e add python 3.7 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.7.

See ML discussion here [1] for context.

[1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135626.html

Change-Id: Ic1d05a80d286ff95777eb30d66086ef2b57bdb7f
Story: #2004073
Task: #27438
2019-02-19 17:06:05 +08:00
Bernard Cafarelli
05521bf84c
Remove str() when setting network objects names
Most network commands use str() on name argument, which fails on python
2 with Unicode characters. This comes from parsed arguments so does not
actually need this call.

Sample command failing with current code:
openstack network create test_unicode™

Change-Id: Ie10b67864c912ee5c33e90b10c3d9705ee8307e7
Story: 2004356
Task: 27955
2019-02-13 10:43:11 +01:00
whoami-rajat
0a187905c0 Add py36 env
While running `tox` command in binoic env, we see the following
message,
ERROR: InterpreterNotFound: python3.5
It is because the default py3 version for binoic is py36.
This patch adds the env in OSC also maintaining consistency
with setup.cfg

Change-Id: I8e5cf72901cba34ad44f2b356609f85b3b0c431f
2019-02-13 12:43:20 +05:30
Jeremy Houser
811b001234 This fix removes an erroneous underscore found within the function named
test_snapshot_delete within test_snapshot.py found in both volume v1 and
v2 of python-openstackclient.

Story: 2004977
Change-Id: Iae29ba7992dcf8596f4fb4333d8bcf1889ecd7e6
2019-02-11 18:06:32 +00:00
Dean Troyer
1a0bef2b46 More state handling in volume transfer requests functional tests
Using addCleanup() for removing the pending volume transfer request
has no way to wait for the volume status to become available before
cleaning up the volume and gets racy when the tests are run with
slow performance in the volume backend.  So we pause at the end of
the test after either accepting the transfer request or explicitly
deleting it so the cleanup can delete the volume.

Change-Id: I04862069cab28bc76eeafd60ba32be646f478d86
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-02-06 15:40:25 -06:00
Radoslaw Smigielski
aaf73cbf6d Fix --limit option in image list sub-command
Client site fix of --limit option.

This bugfix makes client "image list" command working again with
"--limit" option. This option was ignored and even if user specified it,
still list of all available images was returned.

Story: 2004314
Change-Id: I30a78d65a644c9b7d23706a6637ce77bca2c2386
Depends-On: https://review.openstack.org/#/c/634776/
2019-02-04 18:52:13 +00:00
Zuul
dcff1012fd Merge "fix multiple server delete produce multiple new lines" 2019-01-16 22:39:56 +00:00
Noam Angel
7276610595 fix multiple server delete produce multiple new lines
Closes-Bug: #1809874
Change-Id: Ib988b189b41af03d3d871b660bb5b5cc090c3f30
2019-01-16 19:33:56 +00:00
Zuul
dd1118e966 Merge "Add floating IP filter to floating IP list command" 2019-01-15 07:48:25 +00:00
Johannes Kulik
b8438adbbf Add floating IP filter to floating IP list command
Add a parameter ``--floating-ip-address`` to ``floating ip list``
because it's supported by the API and also more efficient than the
current ``floating ip show``. This also works as a work-around for
pagination issues ``floating ip show`` might run into with an IP
parameter.

Change-Id: I113e3fa2495e1e86bb553c55c44f71a3f9f49d23
2019-01-14 10:27:07 +01:00
Monty Taylor
2dd5393167
Use os-cloud instead of OS env vars for functional tests
In order to support switching auth contexts, such as for registered_limits
which take a system scoped token, switch the functional tests to using
the --os-cloud command line parameter. However, honor the OS_CLOUD env var
as a way that someone can select a different cloud, including 'envvars',
to use.

Use devstack-system-admin cloud for limit tests

Keystone requires these to have system scope now.

Change-Id: Ia81eebd3e00ae986cf3ba7e3d98f3e8a1647b622
2019-01-10 14:21:03 +00:00
Zuul
2ab3396f19 Merge "trivial: remove commented-out code" 2018-12-30 14:30:28 +00:00
Zuul
7b72fb816f Merge "Support enable/disable uplink status propagation" 2018-12-24 12:00:03 +00:00
Zuul
4eab836441 Merge "More volume functional test fixes" 2018-12-21 23:59:11 +00:00
Zuul
57edf1647d Merge "Remove testr.conf as it's been replaced by stestr" 2018-12-21 01:36:49 +00:00
Zuul
279546736a Merge "Update the URL in doc" 2018-12-21 00:26:47 +00:00
Jens Harbott
aaa1060597 Add osc repo to the base job definition
The osc-functional-devstack job is to be run against devstack changes in
order to verify that the devstack-tox-functional job, which our job is
based upon, doesn't introduce a regression[0]. In order to prevent this
from failing, include our own repo as required-project.

[0] https://review.openstack.org/526115

Change-Id: I782cd51dda1477c2e3a067cd902a3d3f29490083
2018-12-20 14:46:03 +00:00
Rui Yuan Dou
7fb866af4e Remove testr.conf as it's been replaced by stestr
Change-Id: Ia596789a916b9271933c5b10f00399d83f18d44a
2018-12-20 13:55:51 +08:00
Dean Troyer
f9df3ce3cd More volume functional test fixes
Remove the use of class setup/teardown from volume transfer functional tests
as that just doesn't work too well here. Also wait for volume status before
attempting transfer request operations, some test nodes take a while to
create the volumes.

Change-Id: Ib9378ab5c973deb2aa86c9b9ed31408f3a05115a
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2018-12-18 22:32:16 -06:00
Zuul
ea2e6d6bfb Merge "Modify the help message for 'registered limit set'" 2018-12-18 07:17:25 +00:00
Zuul
5303bca361 Merge "Use devstack functional base job" 2018-12-12 16:51:26 +00:00
Zuul
235999b995 Merge "Supports router gateway IP QoS" 2018-12-12 13:07:29 +00:00
Zuul
955f22314a Merge "Replace assertEqual(True/False, expr) with assertTrue/assertFalse" 2018-12-12 04:38:19 +00:00
Zuul
6fec6d625f Merge "Don't display router's is_ha and is_distributed attributes always" 2018-12-10 20:09:24 +00:00
LIU Yulong
fd23025227 Supports router gateway IP QoS
Adds --qos-policy and --no-qos-policy to `openstack router set`:
    --qos-policy <qos-policy> Attach QoS policy to router gateway IPs
    --no-qos-policy Remove QoS policy from router gateway IPs

Adds --qos-policy to `openstack router unset`:
  --qos-policy Remove QoS policy from router gateway IPs

Partially-Implements blueprint: router-gateway-ip-qos
Closes-Bug: #1757044
Change-Id: Ifec3b2cf9bdb59513c8bcd7bd60305506a071192
2018-12-10 17:20:38 +00:00
Hongbin Lu
c82f4237e5 Support enable/disable uplink status propagation
Add options to enable/disable uplink status propagation on creating
a neutron port.

Related patches:
* neutron: https://review.openstack.org/#/c/571899/
* openstacksdk: https://review.openstack.org/#/c/586687/

Depends-On: https://review.openstack.org/#/c/586687/
Change-Id: I095a98fc5f5aee62d979a16b3cd79d91ec3b9ddb
Related-Bug: #1722720
2018-12-05 21:07:07 +00:00
sunjia
8be53a50e5 Change openstack-dev to openstack-discuss
Mailinglists have been updated. Openstack-discuss replaces openstack-dev.

Change-Id: I7c7fdfb71348f77aa6063ec99b3c4a90bde21d06
2018-12-03 22:12:42 -05:00
qingszhao
029c148b29 Add Python 3.6 classifier to setup.cfg
Change-Id: Id723040f895f06527d46755dd408dec16200c001
2018-11-30 07:13:52 +00:00
Zuul
9100e56d08 Merge "Updated the take_actions for unified limits" 2018-11-29 07:54:07 +00:00
Monty Taylor
8120cb8b55 Use devstack functional base job
We extracted some of our functional base job to the devstack repo.
Consume it.

Change-Id: I11e6f9dab935e4b2cd16228f031f7e0adb3a6c89
Depends-On: I84de60181cb88574e341ff83cd4857cce241f2dd
2018-11-22 14:40:51 +00:00
liuyamin
5bec3b7e3b Replace assertEqual(True/False, expr) with assertTrue/assertFalse
In some cases, If the result of expr is a boolen value, we shoud
use assertTrue/assertFalse to instead. Because it is clear and simple.

Change-Id: I53b345fc3915a7b0e737e9dd4d58fe09c746d61c
2018-11-14 14:50:05 +08:00
liuyamin
4f66f66b6c Fix i18n issue
This patch fix some i18n issues in the files vapi/compute_v2.py.

Change-Id: Ic4da472ca585a35ce64512cf0e72e2fe9d4c9d6e
2018-11-13 17:05:05 +08:00
Sean McGinnis
b90c780d2b
Add volume backup import/export commands
This adds commands to import and export volume backup records so they
can be imported and restored on other Cinder instances or to the
original instance if the service or database has been lost and had to be
rebuilt.

I know this is a commonly used process by some users, so it would be
good to have this functionality in osc so they do not have to switch
clients.

More details about the export and import process can be found here:

https://docs.openstack.org/cinder/latest/admin/blockstorage-volume-backups-export-import.html

Change-Id: Ic95f87b36a416a2b50cb2193fd5759ab59336975
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-11-10 02:11:04 -06:00
Vishakha Agarwal
eb06a24e4f Modify the help message for 'registered limit set'
Regsitered limit set CLI takes --service, --region and
--resource-name as param which can be updated along with
--default limit for existing registered limit.

Default limit can be updated with same value and CLI
return the success. But --service, --region and --resource-
name cannot be same as existing one. CLI return 409
for this case. Which is valid behaviour because more than
one limit with same service and same resource cannot exist.

But help message of --service, --region and --resource-name
are not much clear to tell that they cannot be passed with
same value.

This patch clarifies the help message for resigtered limit set CLI.

Reference Scenario:
*  openstack registered limit set --default-limit 91 64c2e97fbe904b888544ffdcab21989b
limit updated sucessfully

Updating limit with exsiting service and resource-name:

* openstack registered limit set --default-limit 92 --resource-name snapshot 64c2e97fbe904b888544ffdcab21989b
Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409)

*openstack registered limit set --default-limit 93 --service compute 64c2e97fbe904b888544ffdcab21989b
Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409)

*openstack registered limit set --default-limit 91 --resource-name snapshot --service glance 64c2e97fbe904b888544ffdcab21989b
Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409)

Change-Id: I9e78a6250567cd981adde96946818bb016760a49
2018-11-09 08:15:40 +05:30
Vishakha Agarwal
81fd5c995d Updated the take_actions for unified limits
When user passes --region None, the find_resource
of osc_lib calls get() of region. The get API of
region ignores the name param returning all the
regions in result. As the find_resource checks
many cases against the result returned by get API.
The output comes greater than 1, thus returning
"More than one region ID exist" which is incorrect.
However in case of region which cannot be filtered
by name we do not require to check these many cases.

The solution is to directly call the get method of
APIs and returning No resource name exist with the
xyz" on passing invaid parameter. And returning all
in case of None.

Thus created a new function get_resource which can
be used in future too by these types of API's.

Change-Id: Ib3f881d34a82af97199ce51bfbefc6f3f08599f1
Closes-bug: #1799153
2018-11-09 07:53:55 +05:30
Zuul
097b45686e Merge "Add project param in LimitList parser" 2018-11-08 23:27:05 +00:00
Zuul
51986b1eae Merge "Remove invalid 'unlock-volume' migration arg" 2018-11-08 19:11:06 +00:00
Zuul
c3a60e1173 Merge "Add --name-lookup-one-by-one option to server list" 2018-11-08 19:07:02 +00:00
Vishakha Agarwal
0d764cdb5a Add project param in LimitList parser
when doing openstack limit list --project xyz_id,
CLI raising error unrecognized arguments, whereas
in api-ref document [1], user can pass project_id
as query param.This addresses the above issue, by
adding param --project in parser of LimitList.

[1] https://developer.openstack.org/api-ref/identity/v3/index.html

Change-Id: If4644cc99a3803f61f4a688b828aeb73977fc0dd
Closes-Bug: #1798744
2018-11-08 11:19:24 -06:00
Zuul
9b1e5f052e Merge "image/v2: support multiple property filters" 2018-11-08 05:40:17 +00:00
Sven Wegener
21e4c87bde
image/v2: support multiple property filters
Change-Id: I8ba40cb8ca647ec24b80c2824bb64e84430535d4
Signed-off-by: Sven Wegener <sven.wegener@inovex.de>
2018-11-07 14:55:51 +01:00
melanie witt
013c9a4f3a Handle multiple ports in AddFloatingIP
AddFloatingIP refers to an old nova proxy API to neutron that was
deprecated in nova. The neutron API for floating IP associate requires
a port to be specified. Currently, the code is selecting the first port
if the server has multiple ports. But, an attempt to associate the
first port with a floating IP can fail if the first port is not on a
network that is attached to an external gateway.

In order to make the command work better for users who have a server
with multiple ports, we can:

  1. Select the port corresponding to the fixed_ip_address, if one was
     specified

  2. Try to associate the floating IP with each port until one of the
     attempts succeeds, else re-raise the last exception.
     (404 ExternalGatewayForFloatingIPNotFound from neutron)

This also fixes incorrect FakeFloatingIP attributes that were being set
in the TestServerAddFloatingIPNetwork unit tests, which were causing
the tests to use None as parsed args for ip-address and
--fixed-ip-address and thus bypassing code in the
'if parsed_args.fixed_ip_address:' block.

Task: 27800
Story: 2004263

Change-Id: I11fbcebf6b00f12a030b000c84dcf1d6b5e86250
2018-11-06 20:18:13 +00:00
Zuul
1894a3cb17 Merge "Add --key-name and --key-unset option for server rebuild API." 2018-11-02 19:41:24 +00:00
Zuul
594eeae2de Merge "Make use of keystoneauth service-type filtering for versions" 2018-11-02 18:48:06 +00:00
Zuul
9ab8143179 Merge "Address issues from volume backend commands" 2018-11-02 18:00:32 +00:00
Pavlo Shchelokovskyy
e782f49927 Add --name-lookup-one-by-one option to server list
usually in a big cloud there are many images and flavors,
while each given project might use only some of those.

This patch introduces '--name-lookup-one-by-one' argument to
server list command (mutually exclusive with '--no-name-lookup')

When provided (or either '--image' or '--flavor' is specified) to the
`server list` command, name resolving for
corresponding entity is now using targeted GET commands instead of
full entities list.

In some situations this can significantly speedup the execution of the
`server list` command by reducing the number of API requests performed.

Change-Id: I59cbf3f75c55e5d3747654edcc9be86ad954cf40
Story: #2002039
Task: #19682
2018-11-02 12:01:36 -05:00
lvxianguo
4c387fe94c trivial: modify spelling error of project
Change-Id: I6cf68325bc58cfd073c5fca4eb2773d108735399
2018-11-01 16:46:57 +08:00
Zuul
0a2b01fb40 Merge "Improve document 'openstack complete'" 2018-10-28 20:49:47 +00:00
Zuul
ff5c4a5e73 Merge "Update release note version reference table" 2018-10-28 20:49:46 +00:00
Sean McGinnis
f00ffebea6
Remove invalid 'unlock-volume' migration arg
There is an optional flag that can be passed in to a
volume migration to tell Cinder to 'lock' a volume so
no other process can abort the migration. This is
reflected correctly with the --lock-volume argument
flag to `openstack volume migrate`, but there is
another --unlock-volume flag that is shown in the help
text for this command that does not do anything and is
not used anywhere.

Since there is no action to "unlock" a volume, this
just causes confusion - including for Cinder developers
that know this API. To avoid confusion, this invalid
flag should just be removed from the command.

Change-Id: I5f111ed58803a1bf5d34e828341d735099247108
2018-10-26 12:02:58 -05:00
Brian Haley
dd958bc1ee Update the Neutron CLI decoder document
The floatingip-disassociate mapping had 'port' instead of
'--port', also fixed a few places where 'unset' was missing
from some of the mappings.

Trivialfix

Change-Id: I3b01db28dda674e9988176d496154fbd26e4449f
2018-10-26 10:39:47 -04:00
Zuul
0fa3c84b4f Merge "Default --nic to 'auto' if creating a server with >= 2.37" 2018-10-26 03:20:17 +00:00
Sean McGinnis
746d42430b
Update release note version reference table
The table indicating the openstackclient release at the time of the
overall OpenStack release had not been updated since Pike. This adds
release versions for Queens and Rocky.

Change-Id: Icd9a72c2460fae3d1b714b6da473564e6c709ef6
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-23 11:52:39 -05:00
Monty Taylor
dfd37a2e6e
Make use of keystoneauth service-type filtering for versions
The first version of the versions show command does client-side
service-type filtering, which while functional, causes many more API
calls than needed. Now that keystoneauth supports the filtering at the
source, use it.

Change-Id: I57c49e67f9cb285a5f5bc19ec53a42d10de9f0da
2018-10-19 07:55:41 -05:00
Robin Cernin
4173690b24 Improve document 'openstack complete'
The openstack complete command requires bash-completion package
Without the relevant package the bash completion doesn't work.

Change-Id: I47c77f3e7efe112417d2b96936fcd0cafeb9442e
Closes-Bug: #1798493
2018-10-19 09:20:37 +10:00
Zuul
02f492ae4c Merge "Handle not having cinderclient.v1 available" 2018-10-15 22:07:43 +00:00
Zuul
c19aee4c70 Merge "Allow endpoint filtering on both project and project-domain" 2018-10-12 22:41:46 +00:00
Zuul
ac9877de46 Merge "Add volume backend pool list command" 2018-10-12 22:41:43 +00:00
Zuul
5ad925b600 Merge "Add volume backend capability show command" 2018-10-12 22:41:41 +00:00
Sean McGinnis
e0615e8d69
Address issues from volume backend commands
This fixes some minor issues in release notes and the command list for
the new volume backend commands.

Also sorts the fakes used for volume unit tests to allow for multiple
command update patches to hopefully reduce the odds of merge conflicts.

Change-Id: Ic6e40f4c639368338cf085c68c17038f81da5361
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-12 15:54:02 -05:00
Sean McGinnis
651f0c38a1
Handle not having cinderclient.v1 available
The Cinder v1 API was deprecated several years ago and may be removed
from python-cinderclient in the near future. To handle the case where v1
is no longer present, this updates cinderclient initialization to work
without it and give an appropriate error if v1 is requested with a
version where it is no longer available.

Change-Id: I277d7b48b8ad4cce383ec3722f8117938378f615
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-12 14:19:51 -05:00
Sean McGinnis
9647d43bd5
Add volume backend pool list command
Adds an equivalent for "cinder get-pools" with "volume backend pool list"
and "cinder get-pools --detail" with "volume backend pool list --long".

Story: 1655624
Task: 136949

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Change-Id: I826c9946ffe11340d44ad57914f72fc2a72b6938
2018-10-09 15:56:58 -05:00
Sean McGinnis
4039d0d94f
Add volume backend capability show command
Adds and equivalend for "cinder get-capabilities" command to show the
capabilities supported by a Cinder backend.

Story: 1655624
Task: 26947

Change-Id: I38686a26cd503e45ce0102705a6632994ef10274
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-09 15:31:35 -05:00
Julie Pichon
91a2d88862 Allow endpoint filtering on both project and project-domain
The --project and --project-domain flags are currently mutually
exclusive for listing endpoints, however the --project-domain argument
is supposed to help with filtering projects with colliding names. They
should be allowed together.

Story: 2004018
Task: 27007
Change-Id: I7340e01f509e3515f07cb46f175fb603f1ce8b67
2018-10-09 13:23:49 +00:00
Fan Zhang
f82c5b85ce Add --key-name and --key-unset option for server rebuild API.
Change-Id: I6d4793a8e961080ea1d6d414cef8d6bbed0c53e7
Story: 2002609
Task: 22228
Signed-off-by: Fan Zhang <zh.f@outlook.com>
2018-10-09 14:34:44 +08:00
Ruby Loo
e3dc30fe8c Add --property option to 'server rebuild' command
Add '--property' option to the 'server rebuild' command, to provide
the ability to specify properties of the rebuilt instance.

This is equivalent to the '--meta' option of the compute's
'nova rebuild' command.

Change-Id: I25ea6622e970416090109316e1e28fab8b0b3f07
Story: #2003979
Task: #26922
2018-10-05 16:33:48 -04:00
Zuul
4e6f47e28e Merge "Add metavar for name parameter in subnet create" 2018-10-03 01:30:11 +00:00
Zuul
87719d4d76 Merge "fix tox python3 overrides" 2018-10-02 18:08:46 +00:00
Witold Bedyk
01eeed28f7 Remove python-ceilometerclient
Project is retired [1].

[1] https://github.com/openstack/python-ceilometerclient

Change-Id: Idc3a340c99c9fd79d80c90e45fd9a1c44c205218
2018-09-28 16:08:49 +02:00
Chen
a4fcae2ac2 trivial: remove commented-out code
These comments have existed from the beginning. But they seem to
be meaningless.

Change-Id: Ic38272ecfb321d77219d477634e9e29b968e7f00
2018-09-28 19:20:07 +08:00
Witold Bedyk
424ab43a0e Add monascaclient to not plugins list
Change-Id: I377a018a4e3c7b6fa44ce9323d1ee2edbd0e4728
2018-09-28 10:45:17 +02:00
Brian Haley
3c5824415f Fix some spaces in help messages
Fix some missing and not necessary trailing spaces in
the network v2 API files.  Also fixed one block indent
that was different from all its friends.

Trivialfix

Change-Id: Ic6491203c2fb9085543d69f0bb5f38e5a96039da
2018-09-27 17:54:40 -04:00
Doug Hellmann
544f0e2b3f fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I051f1c18b719a27372b626d483e47327085dd3b7
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-09-26 18:45:25 -04:00
melissaml
341333b7c3 Update the URL in doc
Change-Id: I1c0c58dada83a930fafc7141d5446c754ca5c80c
2018-09-23 23:06:48 +08:00
Wenran Xiao
01c3548dc8 Fix help message for subnetpool default-quota value
Default pre-project quota is the number of IP addresses that can be
allocated from the subnet pool. For example, with a quota of 128,
I might get a 64 addresses subnet1, and 16 addresses subnet2,
and still have room to allocate 48 more addresses in the future.

Change-Id: Ia0ba827790b190647aed990e47347560fc9e9f0c
2018-09-19 10:11:47 +08:00
M V P Nitesh
eb001733fd Now we can add description for role creation in OSC
Now user can add the description when user create's the role using OSC
``openstack role create`` command. User can add the description by adding
`--description <Description>` to OSC ``openstack role create`` command.

Co-Authored-By: Deepak Mourya<deepakmoriya7@gmail.com>
Change-Id: I858e004c3b29c687b6a39c8a1ed5fb029eb19c67
Depends-on: I230af9cc833af13064636b5d9a7ce6334c3f6e9a
Closes-Bug: #1669080
2018-09-18 08:56:11 +05:30
Nguyen Van Duc
eb4f839ec7 Replace port 35357 with 5000 for "auth_url"
Based on the change in Keystone Install Guide [1],
this patch replace port 35357 with 5000 for "auth_url".

For more details, please check similar changes which have been done
on other projects: Nova [2], Neutron [3], Cinder [4], Glance [5].

[1] https://review.openstack.org/#/c/541857
[2] https://review.openstack.org/#/c/562812
[3] https://review.openstack.org/#/c/566491
[4] https://review.openstack.org/#/c/565464
[5] https://review.openstack.org/#/c/558932

Change-Id: I4faabbb107f912c7ed1cc5d3467ea5a94197d4a0
2018-09-17 04:16:13 +00:00
Julie Pichon
1b66ad9067 Fix 'project purge' deleting wrong project's servers and volumes
Project purge would delete the servers and volumes for the project the
user is currently authenticated for, regardless of the --project flag.

Note: This change means that no server at all will be deleted if the
logged in user doesn't have the get_all_tenants permission set in the
Nova policy (default: admin_api). This doesn't appear to be an issue
with Cinder as the default rule appears to be admin_or_owner.

Change-Id: If1c54e24e1482438b81c3c32fd5fc9fdd7a7be04
Story: 1747988
Task: 13854
2018-09-14 10:23:14 +01:00
David Rabel
14ceb6307f Add metavar for name parameter in subnet create
Change-Id: I2511677006687fff3166441c51e91191492962f1
Closes-Bug: #1747731
2018-09-12 17:25:10 +02:00
Zuul
53c99a21fd Merge "osc-included image signing (using openstacksdk)" 2018-09-08 05:11:02 +00:00
Josephine Seifert
1981eb2250 osc-included image signing (using openstacksdk)
This extension adds image signing functionality to the "image create" command.
Therefore, new CLI options --sign-key-path and --sign-cert-id have been added.
This patch uses openstacksdk as the signing backend library instead of cursive.
Therefore, requirements and lower_constraints have been updated to use the
openstacksdk version 0.17 or higher.

Depends-On: Idc15b9a12d408bd4b2e096da8402c374be56f9fa
Change-Id: Ia20bc02a49c3fbeb9222e485e3396395f4ab817a
Story: 2002128
Co-Authored-By: Markus Hentsch <markus.hentsch@secustack.com>
2018-09-08 01:55:38 +00:00
Andreas Jaeger
62302ad98a Use templates for cover and lower-constraints
Use openstack-tox-cover template, this runs the cover job
in the check queue only.

Use openstack-lower-constraints-jobs template

Remove jobs that are part of the templates.

Change-Id: Id210b2f15dcba9dcf9ad75e0436995e7d5c1b62b
2018-09-07 17:05:08 +02:00
Bernard Cafarelli
a5865b1763
Partially Revert "Add command to unset information from Subnet-pools"
We do not support removing a prefix from a subnet pool, only updating
with a larger prefix (which is handled by the set command)

This reverts commit 063c722a11.

Change-Id: I11224fbdb94dc1caef42a8a64cbcebaf1dc542fe
Story: #1670230
Task: #13697
2018-09-05 10:45:37 +02:00
qingszhao
0461b7ce0c add lib-forward-testing-python3 test job
This is a mechanically generated patch to add a functional test job
running under Python 3 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I1d186a6759bd3e633661c75e62545d0d56700244
Story: #2002586
Task: #24320
2018-08-21 14:56:25 +00:00
qingszhao
67eeacdd71 add python 3.6 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I1681490fcaa52593abcbf8f935cbe1df7769f2eb
Story: #2002586
Task: #24320
2018-08-21 14:56:23 +00:00
qingszhao
d8020abbe7 switch documentation job to new PTI
This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: If0416171105673b6ed031398e41d46257fe113eb
Story: #2002586
Task: #24320
2018-08-21 14:56:19 +00:00
qingszhao
77a533f277 import zuul job settings from project-config
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I43acfa46c1df8912ae641529f3cc975c8e752480
Story: #2002586
Task: #24320
2018-08-21 14:56:17 +00:00
Zuul
c98531d05e Merge "Deprecate volume create --project and --user options" 2018-08-20 21:28:46 +00:00
Zuul
a84aa492a6 Merge "Detailed help message for QoS max-burst-kbps value" 2018-08-14 17:44:18 +00:00
Zuul
130da80eee Merge "Fix inconsistency (nit)" 2018-08-13 14:03:17 +00:00
Alan Bishop
030fd71390 Deprecate volume create --project and --user options
Cinder's volume create API does not support overriding the project_id and
user_id, and it silently igores those API inputs. Cinder always uses the
project and user info in the keystone identity associated with the API
request.

If a user specifies the --project or --user option, the volume create is
aborted and a CommandError exception is raised. This prevents a volume
from being created, but without the desired project/user values.

A user wishing to specify alternate values can still do so using identity
overrides (e.g. --os-username, --os-project-id).

Story: 2002583
Task: 22192
Change-Id: Ia9f910ea1b0e61797e8c8c463fa28e7390f15bf9
2018-08-10 10:20:34 -04:00
Chen
29ca9904fc Fix inconsistency (nit)
Word choice of description for "host-evacuate-live" is slightly
different from that in novaclient ("migrate of" instead of "migrate off").
https://github.com/openstack/python-novaclient/blob/master/doc/source/cli/nova.rst#nova-host-evacuate-live
They are supposed to be exactly the same, so use "migrate off" to
keep consistent.

Change-Id: Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d
2018-08-10 14:24:23 +08:00
Lajos Katona
5c0de6edc2 Detailed help message for QoS max-burst-kbps value
For QoS rule type bandwidth-limit the max-burst-kbps value for ovs and
linuxbridge is suggested to be 80% of the maxkbps value, let's give a
detailed help message for the CLI user.
For details see https://docs.openstack.org/neutron/queens/admin/
config-qos.html#user-workflow

Change-Id: Ia6e38ec7052b7af64880c2f4c5e242d7cb980df5
Closes-Bug: #1777866
2018-08-10 07:37:57 +02:00
Zuul
a051bda111 Merge "Add DNS support to floating IP commands" 2018-08-08 20:15:07 +00:00
Zuul
c387f83af1 Merge "Add dns-domain support to Network object" 2018-08-07 22:10:41 +00:00
Zuul
a2e1e6b25c Merge "Fix missing trailing spaces in network help messages" 2018-08-07 19:46:40 +00:00
Zuul
8e3eef2946 Merge "Fix broken gate jobs" 2018-08-07 14:45:27 +00:00
Fan Zhang
def83a0e94 Fix broken gate jobs
This patch aims at fixing the broken gate jobs because of
cinder and glance patches [1], [2], [3] and [4].

* Remove parameter `--source-replicated` to drop volume
  replication v1 support
* Address some timing issues with volume transfer requests
* Only run Image v1 tests when the test cloud has v1 available
* Get tolerant of unexpected additional attributes being
  returned in Image data

[1].https://review.openstack.org/#/c/586293/
[2].https://review.openstack.org/#/c/532503/
[3].https://review.openstack.org/#/c/533564/
[4].https://review.openstack.org/#/c/578755/

Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
Co-Authored-By: Monty Taylor <mordred@inaugust.com>
Depends-on: https://review.openstack.org/588664
Change-Id: I2a785750e92155185d3344e6116c7f5c6fdd3cbe
Signed-off-by: Fan Zhang <zh.f@outlook.com>
2018-08-07 09:32:00 +00:00
Jens Harbott
ed09f28a9d Add DNS support to floating IP commands
Add the DNS domain and name options to the ``floating ip create``
command. Also add these two columns to the output of the
``floating ip list --long`` command.

Change-Id: Id4cb18b51b252f19b87b24ec5d77183771189d17
Story: 1547736
Task: 13114
2018-08-06 08:14:48 +00:00
Brian Haley
6cb0f0f79c Fix missing trailing spaces in network help messages
Trivialfix

Change-Id: I1eeab576e7f50d858860a19c045f24a33449dc92
2018-08-03 12:29:34 -04:00
OpenStack Release Bot
2b62b6e6ec Update reno for stable/rocky
Change-Id: Ieb4130d9f9d420fb3b858b6972a1f2a896fa7fc4
2018-07-26 08:58:10 +00:00
Zuul
f77ca68d53 Merge "Release note cleanup for 3.16.0 release" 2018-07-25 20:36:33 +00:00
Zuul
c056780691 Merge "Don't sent disk_over_commit if nova api > 2.24" 2018-07-25 19:31:35 +00:00
Dean Troyer
4236d777ff Release note cleanup for 3.16.0 release
Change-Id: I64efea562117706529c4b474085f5c12939ba4d6
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2018-07-25 14:08:05 -05:00
Zuul
7ae49c5b02 Merge "Add command to show all service versions" 2018-07-25 17:57:44 +00:00
Zuul
cc037e22a6 Merge "Support --community in openstack image list" 2018-07-25 02:49:02 +00:00
Zuul
6469d86522 Merge "Implement support for project limits" 2018-07-25 00:52:42 +00:00
Zuul
d177727a6e Merge "Implement support for registered limits" 2018-07-25 00:52:41 +00:00
Zuul
e78a2e7b09 Merge "compute: host: expand kwargs in host_set() call" 2018-07-25 00:52:39 +00:00
Zuul
d838c69605 Merge "Support filtering port with IP address substring" 2018-07-25 00:42:32 +00:00
Nobuto Murata
860639a548 Support --community in openstack image list
"--community" was added to "image create" and "image set" previously,
but was missed in "image list".

Change-Id: I959fdd7f67ae62c8326659ce52389228152ec019
Story: 2001925
Task: 14453
2018-07-24 22:48:01 +00:00
Zuul
c42b8552a8 Merge "Fix error with image show when image name is None" 2018-07-24 21:45:26 +00:00
Artom Lifshitz
d6121782d3 Don't sent disk_over_commit if nova api > 2.24
In API microversion 2.25 Nova removed the disk_over_commit parameter
to the live migration server action. This patch makes sure that we
don't include it in our request if we're running with 2.25 or higher.

Story: #2002963
Task: #22966
Change-Id: I1bbdd33be96d82422a05982508e370237c3560f3
2018-07-24 11:09:27 -04:00
Zuul
00194b4e20 Merge "Do not require port argument when updating floating IP" 2018-07-24 00:53:33 +00:00
Jake Yip
b90b93e143 Fix error with image show when image name is None
Need to bump osc-lib to 1.10.0

Closes-Bug: #1736696
Depends-On: I2aab5cc1f550848bda2b90ef7ef9a60f07b88996
Change-Id: I7420204f28d36529354e5671bd88587d9b15bb06
2018-07-23 17:42:34 -05:00
Monty Taylor
9ece632f96
Add command to show all service versions
Knowing what services and what versions of those services exist on a
cloud isn't always a spectacular experience. Add a command that will use
get_all_version_data from keystoneauth to produce a report of the
available services and the version info for each service.

Depends-On: https://review.openstack.org/584944
Change-Id: I84751c175d0c5f6d857a5473d2db6d5f1b41f946
2018-07-23 16:58:30 -05:00
Lance Bragstad
735896eb1a Implement support for project limits
This commit let's users manage limits via the command line.

bp unified-limits

Change-Id: I7c44bbb60557378b66c5c43a7ba917f40dc2b633
2018-07-23 21:52:00 +00:00
Lance Bragstad
641a4faac1 Implement support for registered limits
This commit adds support for users to manage registered limits via
the command line.

bp unified-limits

Depends-On: https://review.openstack.org/#/c/574391/
Change-Id: Id8377363f7a3248b45aeeba21d2acc02684a0305
2018-07-23 21:18:50 +00:00
Monty Taylor
3dd9613b21 Pass volume snapshot size to volume create
When creating a volume from a snapshot, the size parameter is required
and type is checked. Since we have to pass something and it needs to be
a valid data type (None is not acceptable) grab the size from the
snapshot object and pass it.

Change-Id: Ie23e3d23828919234e40336b5c65b22e140d337c
2018-07-23 13:38:35 -05:00
Benoît Knecht
fc76db0def compute: host: expand kwargs in host_set() call
`host_set()` expects `status` and `maintenance_mode` as keyword
arguments, but in `SetHost.take_action()`, it is called without
expanding the keyword arguments.

So it's called as

```
host_set(host, {'status': 'enable'})
```

instead of

```
host_set(host, status='enable')
```

Change-Id: If0b37ac60091161a892bfc694fce31a988f66005
Task: 23023
2018-07-20 10:37:34 +02:00
Zuul
ee35409069 Merge "Slow down and retry aggregate create/delete to lessen race" 2018-07-13 17:57:25 +00:00
Zuul
bf52ae5a58 Merge "Fix docs from I0dc80bee3ba6ff4ec8cc3fc113b6de7807e0bf2a" 2018-07-13 15:37:54 +00:00
Zuul
e4bbc3ce4d Merge "Skip calls to glance and nova when got no servers" 2018-07-11 16:02:40 +00:00
Zuul
84755a81b5 Merge "Replace pbr autodoc with sphinxcontrib-apidoc" 2018-07-11 16:02:39 +00:00
Tuan Do Anh
70031687f9 Fix lower-constraints.txt
During the change https://review.openstack.org/#/c/573216/
neutron-vpnaas lower-constraints.txt looks out-of-date.
This commit fixes lower-constraints.txt.

Change-Id: Id9cfb463a98bdcc3c45505d8701c515549ecaa55
2018-07-11 14:09:02 +07:00
Stephen Finucane
63d741fd66 Replace pbr autodoc with sphinxcontrib-apidoc
This fixes local building of the documentation using tox, and allows the
gate to stop relying on pbr and move completely to the new docs PTI.

http://lists.openstack.org/pipermail/openstack-dev/2018-March/128594.html

Change-Id: I485acda07098a435753e91c1ca45e586de199c35
2018-07-10 17:15:26 +01:00
Zuul
d6cf027be1 Merge "Make Profile fallback go bye-bye" 2018-07-10 14:21:48 +00:00
Pavlo Shchelokovskyy
b9fab849f7 Skip calls to glance and nova when got no servers
save (potentially many) HTTP calls to Glance API for image list
and a call to Nova API for flavor list when the server list
actually returned no servers.

Change-Id: I93a56138c50b82fb4dce67a2f788107f71c5f423
Story: #2002039
Task: #19681
2018-07-09 15:07:24 +03:00
Dean Troyer
26c268a910 Slow down and retry aggregate create/delete to lessen race
Change-Id: I676894c1bfd3156313d88e6457250b9ff226118b
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2018-07-06 13:15:59 -05:00
Zuul
c5a0c3ad5d Merge "Retry floating IP tests" 2018-07-06 14:04:38 +00:00
Dean Troyer
83a9db280d Retry floating IP tests
test_server_attach_detach_floating_ip() has a test for server
add/remove floating IP that seems to be racy, add a retry loop
to let neutron and nova do their thing before calling it bad.

Change-Id: I999a0d7dae1706d746053bafb7ab4e3b791d0042
2018-07-06 10:24:16 +00:00
Hongbin Lu
4a9cb8eea8 Support filtering port with IP address substring
Change-Id: I9559f1c0a6db943705bd32aefb60d7ea7054dd1b
Related-Bug: #1718605
2018-06-29 20:15:28 +00:00
Zuul
e4b8c31cd3 Merge "Adding api_version to FakeApp" 2018-06-29 18:17:47 +00:00
Zuul
0ba5dcbc6a Merge "Display private flavors in server list" 2018-06-29 13:57:45 +00:00
Zuul
7d7a429685 Merge "Add ability to filter image list by tag" 2018-06-29 02:47:41 +00:00
Matt Riedemann
7e8c55fa1b Fix docs from I0dc80bee3ba6ff4ec8cc3fc113b6de7807e0bf2a
The CLI usage docs should mention the microversion
restriction for creating a flavor with a description
and setting a description on a flavor. Also, the release
note talks about setting the server description on the
flavor commands (wrong resource).

Change-Id: I93af3da9a0be62395a1c719fd1dcbfd2b669580d
Story: 2002196
Task:  22607
2018-06-28 14:00:49 -04:00
Zuul
3493948d13 Merge "Format port_details field of Floating IP" 2018-06-28 17:26:06 +00:00
Zuul
7b8873dc6b Merge "Compute: Add description support for flavor" 2018-06-28 17:26:03 +00:00
Adam Harwell
9edbab8c90 Add ability to filter image list by tag
Change-Id: I2e222d3e69df9d8d7cd472663caaee31bedd848c
2018-06-28 16:17:14 +00:00
wu.chunyang
ddcc25e7f3 Add release note link in README
Change-Id: I53896535dc369a499a6850b71d23feff9350e557
2018-06-28 13:27:55 +08:00
tianhui
603fe25567 Change bug url to a correct one
The url for the python-openstackclient bugs is deprecated and
needs to change it to a correct one.

Change-Id: I3762faf27fdb647dbff2e47b19d238108ef1975f
2018-06-27 07:44:53 +00:00
Zuul
4bde9af892 Merge "Network: Add tag support for security group" 2018-06-25 15:16:05 +00:00
Zuul
5d2bd2a738 Merge "compute: limit the service's force down command above 2.10" 2018-06-24 13:28:44 +00:00
Zuul
4ffb3a905a Merge "Fix subnet host_routes error" 2018-06-24 05:03:04 +00:00
Telles Nobrega
412ee7f1d8 Adding api_version to FakeApp
In order to use app.api_version['<some_service>'] we need to have the
api_version on FakeApp otherwise the test will fail.

Patch that will benefit from this:
https://review.openstack.org/#/c/572536/

Change-Id: Ibb3c548daf2a62b6c4aefb5e257372dd5c56521e
2018-06-24 03:47:23 +00:00
Sami MAKKI
08dbd154e5 Fix the role implies list command.
The code was calling an unexisting function which never existed.
The module refers now to the correct `InferenceRuleManager`. It
also allows the compatibility with the future python-keystoneclient
in which the compatibility method will be removed from the
RoleManager.

Change-Id: I08f785dc9e840da2e16915683eecfe49189c44b3
2018-06-24 02:17:02 +02:00
Dean Troyer
15a079faa6 Fix volume type functional tests
Convert functional VolumeTypeTests to not use class methods for setup.

Depends-On: https://review.openstack.org/577147
Change-Id: I855583ad1a50bf5f5046acdb85e977ab9e3c45d2
2018-06-22 10:05:28 -05:00
yanpuqing
b18e79c09b Delete the LB object quotas set command in openstackclient
Setting octavia quotas should use "openstack loadbalancer quota set", not
"openstack quota set". The vip parameter had be removed from octavia.
The patch removes '--vips', '--health-monitors', '--l7policies' parameter
in "openstack quota set" command.

Change-Id: Id0046195aa93bae62264d9de7d123cf63bd0fb7e
Task: 19657
Story: 2002016
2018-06-20 11:08:09 +00:00
tianhui
4a68ba625c Compute: Add description support for flavor
Co-Authored-By: Fan Zhang <zh.f@outlook.com>
Change-Id: I0dc80bee3ba6ff4ec8cc3fc113b6de7807e0bf2a
Story: 2002196
Task: 21681
2018-06-20 09:11:05 +00:00
He Jie Xu
956eabe967 compute: limit the service's force down command above 2.10
The force down action is added in Microversion 2.11, we should limit
the command only can be executed when the microversion is above 2.10.

Change-Id: I0a87e02e71ff025d30181fc17ebcd003a590f110
2018-06-19 12:59:03 +00:00
Huang Cheng
5bb5585aa9 Fix subnet host_routes error
When updating subnet with "no-host-route" option, set host_routes to an empty list as neutron_lib.api.validators expected.

Change-Id: I6fe039793d813758429c7a104fd40172b4f8122b
Closes-Bug: #1747101
2018-06-14 13:03:46 +00:00
yanpuqing
402c9a21b3 Do not require port argument when updating floating IP
When setting floating ip other properties, port argument is
force to use.
The patch modifies the command, when setting floating ip other
properties, like tags, no need port argument.

Change-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de
Story: 1751431
Task: 13865
2018-06-13 23:05:30 -04:00
Dongcan Ye
aaed4b315f Network: Add tag support for security group
Change-Id: Icccb23429913724c6a8bd15d4737672b47a5f13a
Closes-Bug: #1750983
2018-06-14 01:01:58 +00:00
Zuul
9766eb23e7 Merge "Fix server show for microversion 2.47" 2018-06-12 04:44:38 +00:00
Zuul
4c4c0ae2da Merge "Optimize _prep_server_detail to avoid redundant find_resource" 2018-06-12 01:14:16 +00:00
Zuul
cf078fdbc4 Merge "Use Server.to_dict() rather than Server._info" 2018-06-12 00:48:00 +00:00
Zuul
a7973d927d Merge "Remove deprecated ip floating commands" 2018-06-09 18:43:45 +00:00
Yang Youseok
71f138b172 Fix RuntimeError when showing project which has extra properties
If you use python3, items() returns iterator which is not allowed to
remove item during iteration. Fix to iterate by copied list.

Change-Id: I64c037d04e2b127d8f19f56cab65122af89a7200
Closes-Bug: 1740232
2018-06-09 13:16:34 -05:00
Zuul
e80f951f22 Merge "Add bgp commands to neutron decoder" 2018-06-09 17:11:29 +00:00
Zuul
784389d02c Merge "Fix urls in README.rst" 2018-06-09 17:11:28 +00:00
Zuul
9b31ba36ed Merge "Update role document to include system parameter" 2018-06-09 17:11:27 +00:00
Zuul
0226eb7fd9 Merge "Add system role functionality" 2018-06-09 17:11:26 +00:00
Matt Riedemann
577e2e850c Mention 2.51 in help for openstack server event show
With the 2.51 compute API microversion, non-admin users can also
see event details for a given request. This change mentions that
in the help text for "openstack server event show".

While in here, change the _info private attribute access to the
to_dict() usage.

Change-Id: I5fd487b17c4b85bd7e619112ad262ffdd3a940c8
Task: 21199
Story: 2002193
2018-06-09 09:25:59 -04:00
Matt Riedemann
da7572a5ff Fix server show for microversion 2.47
Compute API version 2.47 embeds the server's internal
flavor in the response. The original flavor id is not
preserved since it could have changed if the flavor
was deleted and re-created after the server was created,
which was the dreaded Horizon "Edit Flavor" issue.
So the flavor dict in the server response is a dict of
information about the flavor representing the server
"right now" excluding the id. The original flavor name
is shown though along with the ram/disk/vcpu etc
information.

The server list command has a similar issue which
will be fixed in a follow up change.

Change-Id: I1a92999758006d02567c542b6be8902a049899cc
Task: 13864
Story: 1751104
2018-06-08 15:52:31 -04:00
Matt Riedemann
752a2db332 Optimize _prep_server_detail to avoid redundant find_resource
When showing a server or doing a rebuild, we already have
the latest version of the server so _prep_server_detail
getting the server again is an unnecessary performance hit.

ShowServer is pretty obvious here. For RebuildServer, the
compute API actually refreshes the server before returning
it in the response, so the client already gets the latest
when the rebuild call returns.

The only other usage of _prep_server_detail that does require
a refresh is CreateServer since the POST /servers response is
a minimal version of the server object.

This adds a new refresh kwarg, backward compatible by default,
to _prep_server_detail but changes ShowServer and RebuildServer
to no longer refresh.

Change-Id: Ib1c9c424ed1cafc2dfd8be90af8de8a774bdfbf0
2018-06-08 11:46:29 -04:00
Matt Riedemann
56b3467549 Use Server.to_dict() rather than Server._info
There is a to_dict() method on the Server object from
python-novaclient which makes a deepcopy of the internal
Server._info - use this instead of accessing the _info
attribute directly.

Also, while in here, fixed a typo in _prep_server_detail.

Change-Id: I679b4489c815f8a54368ef6b23b9f77e75b4d0bc
2018-06-08 11:13:40 -04:00
Matt Riedemann
181f14319b Add note about version 2.5 when listing servers using --ip6
The --ip6 filter when listing servers as a non-admin user
only applies when also using --os-compute-api-microversion
2.5 or greater. This change simply adds a note about that in
the --ip6 option help text.

We could probably get more sophisticated by trying to determine
if the user has the admin role or not and if not, and using --ip6
without microversion >= 2.5, we could error out, but that seems
excessive at this point.

Change-Id: I665c64e0bdac04c695fa119a479df43f70b0fa62
Story: #2002184
Task: #20057
2018-06-08 10:13:10 -04:00
Lance Bragstad
aefddf3a90 Update role document to include system parameter
With the recent addition of system scope support in osc, we should
add system docs to the role documentation.

bp system-scope

Change-Id: Id77511c52ff0c36ea845e0f0fbbe3ec14818ee58
2018-06-07 15:58:40 +00:00
Chen
f904efb037 Fix urls in README.rst
1. bug tracking has been moved to storyboard
2. syntax issues
3. remove PyPI downloads since it is no longer maintained
https://packaging.python.org/guides/analyzing-pypi-package-downloads/

Change-Id: Ic57c7032af0296d666841021c19e6e56f0b3e89a
2018-06-07 22:53:00 +08:00
Harald Jensas
e8c731547d Allow setting network-segment on subnet update
To enable the possibility to migrate a non-routed network to a
routed network allow updating the segment_id of a subnet.

Change-Id: I3ebae2ff28d5d4e5373ebd1f52194f8c52071b88
Partial-Bug: bug/1692490
Depends-On: I1aee29dfb59e9769ec0f1cb1f5d2933bc5dc0dc5
2018-06-06 11:56:39 +02:00
Lance Bragstad
8bfa180430 Add system role functionality
This commit adds the necessary bits to expose system role
assignments to openstackclient via python-keystoneclient.

bp system-scope

Depends-On: Iecbcbf020a15f2bec777334c648d4477f89f3b2c
Change-Id: I261e84700b51e8715eaebdc3f8f8bc46b68542c2
2018-06-04 20:09:14 +00:00
Zuul
c18f93bafe Merge "Prevent "server migrate --wait" from hanging" 2018-06-01 21:15:44 +00:00
Zuul
134360ca0d Merge "Add cliff project link" 2018-06-01 21:00:24 +00:00
Zuul
8781d7e94b Merge "Make max_burst_kbps option as optional for bw limit QoS rule" 2018-06-01 21:00:22 +00:00
Jens Harbott
47d0d0e0c0 Fix lower-constraints.txt
This was originally generated before the compliance test was installed,
so it is now failing for every unrelated change to requirements.

Replace lower-constraints.txt with the output of running
openstack/requirements/tools/fix-lower-constraints.py .

Change-Id: I492e663622db75994bdababfa6dc81589e3fb53b
2018-05-31 07:41:06 +00:00
Sławek Kapłoński
9b6d02d5f9 Make max_burst_kbps option as optional for bw limit QoS rule
Attribute max_burst_kbps of QoS bandwidth limit rule in Neutron's
is optional in API so it should be also optional on client's side.

Change-Id: Ie085b73fa885ff12f9ac080666cf3ca6a09b632a
Related-Bug:#1770622
Task: 19658
Story: 2002017
2018-05-25 12:54:41 -07:00
Sławek Kapłoński
8db3933feb Don't display router's is_ha and is_distributed attributes always
In case when is_ha or is_distributed attribute of Neutron's router is
set to None, it means that it wasn't returned from server and should
not be displayed.
Otherwise it might be confusing for user is making
openstack router show <router_name>
call as an admin will return e.g. is_ha=True but same call done as
regular user will return False or None.
It might happen like that because returning of those attributes is
forbidden for regular users in Neutron's policy.json

Depends-On: https://review.openstack.org/567606/
Change-Id: I626b5193d9ecb308baad7b27939f9673c32b4182
Closes-Bug: #1689510
Task: 19789
Story: 2002110
2018-05-25 19:45:13 +00:00
zhang.lei
dbff17d720 Add cliff project link
Change-Id: I6a964781667aa92f4b8d364f63a25f1c76309dca
2018-05-23 09:20:23 +00:00
chenxing
819663d134 Update the content about Import Format
Following by
https://git.openstack.org/cgit/openstack-dev/hacking/tree/HACKING.rst#n71

Change-Id: I2f32d773c12d484e8c0e435a78a3fe16d0eeae03
2018-05-22 15:36:19 +08:00
Monty Taylor
f7e4d31820
Update command test for volume.v3
The default cinder version in devstack changed to v3 in
https://review.openstack.org/#/c/566747/which breaks this
test. Change the test to test what's going to happen.

Change-Id: Iff4d8b47812a86d21bf5dbdddbd642b9d63ff8fe
2018-05-18 07:12:04 -05:00
Julie Pichon
de9a6fc070 Prevent "server migrate --wait" from hanging
Migrate uses the same mechanism in the backend than Resize and so the
steps and step names are similar. Currently when using the --wait
option with 'migrate', we wait forever because the status won't get to
active until the user performs an action. This makes it return on
verify_resize status just like 'resize' does, so that the user can
perform the next manual step.

Change-Id: Ie1aeac52506bc8801f88fd6a6eb4f6094cf20050
Story: 2001994
Task: 19621
2018-05-09 18:02:14 +01:00
Hongbin Lu
46f8614da8 Format port_details field of Floating IP
Depends-On: I31e940d2986278d2fbee6fdfea4ff15f7c07ebaa
Change-Id: I115739ea253ce26e075cd3f10e719b13f18afa5b
Partial-Bug: #1723026
2018-04-27 20:29:35 +00:00
Zuul
06263bd585 Merge "Fix limits show command without Nova and Cinder" 2018-04-23 09:49:35 +00:00
Pierre Hanselmann
b8754e15e7 Add dns-domain support to Network object
Add "dns-domain" parameter to Network class. Also check
backend extensions and send an error message in case of
an argument (like dns-domain) is sent and the extension is
missing (dns-integration in this case).

Change-Id: I7303658c27d9b9f2d8381ccea0b29e96909cab54
Closes-Bug: 1633214
Partial-Bug: 1547736
2018-04-23 08:37:27 +00:00
Zuul
b59de7b849 Merge "Network: Add tag support for floating ip" 2018-04-23 08:12:25 +00:00
Zuul
fb68cccddd Merge "Fix functional job failed" 2018-04-23 04:51:18 +00:00
Tovin Seven
5a9fc91830 Trivial: Update pypi url to new url
Pypi url changed from [1] to [2]

[1] https://pypi.python.org/pypi/<package>
[2] https://pypi.org/project/<package>

Change-Id: I61f3d53737616dbbd6df725823b5335a57045dba
2018-04-20 17:23:30 +07:00
Dongcan Ye
b776f7099a Fix functional job failed
After Neutron patch I3c93818002c2d7753454547231ba08544b6fa1c0 merged,
the default value of segment description is an empty string.

This patch will determine whether the Neuron shim extension
standard-attr-segment supported.

Change-Id: I68a3c018f03e5bb53bd637844ac9d7742a765db0
2018-04-20 01:47:17 +00:00
Dongcan Ye
09a0916dae Network: Add tag support for floating ip
Change-Id: I7a500a4ff6cec2442b4050df26c0b017d9f71903
Closes-Bug: #1750985
2018-04-17 15:52:52 +00:00
Zuul
17448ad359 Merge "Clean up W503 and E402 pep8 errors" 2018-04-17 15:19:21 +00:00
Sean McGinnis
d601415259 Clean up W503 and E402 pep8 errors
pycodestyle 2.40 and later enforce these rules that were not previously
enforced. Rather than just skipping them, this cleans up the trivial
instances of these violations.

This does also include some other updates that were not triggering errors
in an attempt to keep some of the style consistent.

Change-Id: Id7c0a6b8f1f835e69d844b000e3ed751852ada63
Closes-bug: #1762803
2018-04-15 12:23:06 +09:00
Jens Harbott
d4d97f2696 Add bgp commands to neutron decoder
Help folks that need to migrate their use of the neutron CLI for
neutron-dynamic-routing commands.

Change-Id: I324608d7bbce8c55aaab122bfd8bff0ee1ccf9e3
2018-04-09 17:26:28 +00:00
Jens Harbott
30b2203dc7 Add help for nova interface-list to decoder
Running "openstack port list --server <id>" is a good replacement for
"nova interface-list <id>", add it to the decoder.

Change-Id: I656e190f4da59d9c57e9ab97d068a8a0dbd77774
2018-04-09 13:12:30 +00:00
Dongcan Ye
ea89065dab Remove deprecated ip floating commands
We had already implemented floating ip(pool) commands more
than two cycles, we can remove those deprecated commands.

Change-Id: Ib98a7403a63bb0c48c03de4c79795737de2aa84c
2018-04-08 11:37:42 +00:00
Jude Cross
24b06ef273 Fix limits show command without Nova and Cinder
This patch implements an endpoint lookup when showing limits. This
addresses the issue when showing limits without both Nova and Cinder
and will display limits if one is missing.

Change-Id: I2214b281e0206f8fe117aae52de2bf4c4e2c6525
Closes-bug: #1707960
2018-04-03 00:47:00 -07:00
Zuul
972a345014 Merge "Add support to list image members" 2018-04-02 19:05:15 +00:00
Zuul
5ed81c5a77 Merge "Add --image-property parameter in 'server create'" 2018-03-31 17:20:27 +00:00
Zuul
180d012ca7 Merge "Update help text for encryption provider" 2018-03-29 15:49:24 +00:00
Zuul
67edb39b4c Merge "Updated from global requirements" 2018-03-29 13:23:20 +00:00
Zuul
74654fadda Merge "add lower-constraints job" 2018-03-29 13:21:03 +00:00
Zuul
f21b0a073f Merge "Fix additional output encoding issues" 2018-03-29 04:23:16 +00:00
OpenStack Proposal Bot
26b1732a7c Updated from global requirements
Change-Id: I8c400b12269f00fcf9fcaac27098ca55cdc27ac4
2018-03-28 10:36:59 +00:00
Chen Hanxiao
447d5d9e34 Add --image-property parameter in 'server create'
add --image-property option, just like --image-with of novaclient did.

Change-Id: Ic1a8976559255529a8785b1b301a0307812433cb
Signed-off-by: Chen Hanxiao <chenhx@certusnet.com.cn>
2018-03-28 16:03:45 +08:00
Doug Hellmann
bf32cdf3a9 add lower-constraints job
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.

Change-Id: I4a4ca9726fab1d0cf9a33311201b7f65951a0942
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-03-25 11:27:13 -04:00
Zuul
3f99dbac34 Merge "Fix crashing "console log show"" 2018-03-23 16:29:23 +00:00
Monty Taylor
255fe686f1 Merge "Rename python-openstacksdk to openstacksdk" 2018-03-23 16:06:27 +00:00
Zuul
29d4dd7a61 Merge "neutron: add --mtu for create/set network" 2018-03-23 14:31:39 +00:00
Zuul
350b545201 Merge "Remove duplicated network attributes" 2018-03-23 14:10:42 +00:00
Monty Taylor
6168ca7a89
Rename python-openstacksdk to openstacksdk
Depends-On: https://review.openstack.org/554662
Change-Id: I6169f9e98418055c7c3ae5bc3b76b1216703cd55
2018-03-23 08:46:00 -05:00
Mohammed Naser
79577681d8 Add support to list image members
The OpenStack client presently has support to add or remove members
from an image, but no way to list image members.  This patch addreses
this issue.

Change-Id: Ie85c5de23c6beb21fd6b4c04c83ddf2a116606ef
2018-03-21 08:56:08 -04:00
npraveen35
c615bcd75e Display private flavors in server list
Update the code so that "openstack server list --all"
also displays the names of private flavors.

Change-Id: I4804fcd905eaf67b1ad9b461084eaf0caa820d2f
Closes-Bug: #1742453
2018-03-21 12:23:33 +00:00
Matt Riedemann
1008544882 Default --nic to 'auto' if creating a server with >= 2.37
Compute API version >= 2.37 requires a 'networks' value in
the server create request. The novaclient CLI defaults this
to 'auto' if not specified, but the novaclient ServerManager.create
python API binding code does not, as it wants clients to be explicit.

For the purposes of the OSC CLI, we should follow suit and if the
user is requesting OS_COMPUTE_API_VERSION>=2.37 without specific
nics, we should just default to 'auto'.

Change-Id: Ib760c55e31209223338a4086ff1f4fee88dc6959
Closes-Bug: #1750395
2018-03-21 01:44:29 +00:00
Dean Troyer
6df58b6366 Fix additional output encoding issues
This is a followup to https://review.openstack.org/#/c/541609/ that
changes most outstanding direct uses of sys.stdout to use the encoded
stdout set up by cliff.

Change-Id: I07cfc418385fc787d3b7d3c32d39676cf81bb91f
2018-03-20 15:40:23 -05:00
Zuul
6361e5e121 Merge "Correct application credential usage doc" 2018-03-16 20:28:53 +00:00
Colleen Murphy
25808affd1 Correct application credential usage doc
There is a --restricted flag to counter the --unrestricted flag. It was
documented, but the usage example had missed it. Add it for
completeness.

Change-Id: Ib4cdcacdd16bfb59e9d18714106ecda99e418812
2018-03-16 17:47:47 +01:00
Thomas Goirand
9a17356854 Fix crashing "console log show"
Because of encoding issue, the "openstack console show log" is prone to
a stack dump, as explained in the bug report.

Use the stdout handle that has already been set up by cliff's App class
with a sane default encoding.

Change-Id: I4d8b0df7f16ee0463e638bb11276220e5b92023b
Closes-Bug: 1747862
2018-03-16 11:30:51 -05:00
Brian Haley
2ed1b24c71 Fix typo in 'floating ip associate' command and doc
Assocaite -> Associate

Trivialfix

Change-Id: I432e35ddcd80ef77c865bee9a54ac2777f5b6386
2018-03-15 16:30:43 -04:00
Emilien Macchi
18563b4132 neutron: add --mtu for create/set network
Support Neutron network mtu configuration with a new argument, --mtu
that allows CLI users to set MTU for Neutron networks.

Change-Id: I93d23581c7e8c84eaf9bb3b293360036f60f456b
2018-03-15 13:50:59 +00:00
Monty Taylor
372f7caa08 Make Profile fallback go bye-bye
It's time to move on with life.

(dtroyer) This requires sdk >= 0.10.0 (0.9.19 is in
global-requirements.txt) and osc-lib >= 1.8.0 (1.8.0 is already in g-r).
Once we have sdk bumped make_client() becomes just a pass-through for
the plugin interface and existing code compatibility.

Change-Id: Ie3d7c442da4257b11140c109e9df69b629336f42
2018-03-14 10:57:13 -05:00
Zuul
e78c9bc00d Merge "Add CRUD support for application credentials" 2018-03-14 02:16:35 +00:00
Dongcan Ye
f6688986fc Remove duplicated network attributes
Change-Id: If77609d06e7d80c8da5111b8a30036b58fbfa187
2018-03-14 01:33:21 +00:00
Zuul
0dfb690e21 Merge "Cleanup error messages on failure" 2018-03-14 00:37:30 +00:00
Zuul
9ad7a140e9 Merge "Updated from global requirements" 2018-03-13 23:19:39 +00:00
Zuul
01736b4cc2 Merge "Re-implement novaclient bits removed in 10.0" 2018-03-13 19:54:09 +00:00
Dean Troyer
53e7aab7ed Re-implement novaclient bits removed in 10.0
a)

/os-floating-ips was removed in Compute API 2.36 and from novaclient's
Python API in 10.0

Add to api.computev2:
floating_ip_add()
floating_ip_remove()

Convert add floating IP command to nova-net/neutron split:
"server add floating ip"
"server remove floating ip"

b)

/os-hosts was removed in Compute API 2.43 and from novaclient's
Python API in 10.0.

Add to api.computev2:
host_list()
host_set()
host_show()

Convert host commands to use intenal api:
"host list"
"host set"
"host show"

c)

The introduction of the Network-style commands into the server group
broke cliff's autoprogram directive as it executes the get_parser() methods
without fully initializing the Command object.

NOTE: This is really three reviews squashed to get through the gate in one pass.

Depends-on: Id6de87211d6c4ea8fd14aa9203d8d5b17e9e2f04
Change-Id: I5116086f9a9e4b2b31a744bf8f4558c79f0bfe59
2018-03-13 09:10:45 -05:00
OpenStack Proposal Bot
395f640bc7 Updated from global requirements
Change-Id: Idf311a7fa08e8738bb4c70b0d84f8a4121606f56
2018-03-13 07:28:18 +00:00
Zuul
072bcac9f4 Merge "Update links in README" 2018-03-09 17:25:21 +00:00
melissaml
5a5281e755 Update links in README
Change the outdated links to the latest links in README

Change-Id: I94c781866c8b65e84708dd9f951f023a5e2913b1
2018-03-02 18:13:24 +08:00
OpenStack Proposal Bot
b10941ddf6 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ie76221736bb0fda2d7f4ee114787e5b11fc734ac
2018-03-01 07:25:50 +00:00
Matthew Treinish
e5d60b220f Cleanup error messages on failure
When test_server_commands_main_help() fails it dumps a ton of
unformatted text on an exception message. This commit attempts to clean
it up to make it easier to read.

Change-Id: I793e6337728a22302a5a87938dbec60d7f2320d8
2018-02-28 11:39:18 -05:00
Zuul
c24451e19c Merge "Add support for endpoint group commands" 2018-02-25 01:05:18 +00:00
Zuul
d6761f0936 Merge "Add project tags functionality" 2018-02-25 01:05:16 +00:00
Zuul
1b5cab40b5 Merge "Add support for "--dns-domain" argument" 2018-02-24 10:59:41 +00:00
Brianna Poulos
4b9973b779 Update help text for encryption provider
The volume encryption provider no longer uses class names.
Instead, 'luks' and 'plain' are used. This patch updates
the help text for the volume encryption provider to use
the new encryption provider format constants.

Change-Id: I2911098505a99658e04ac4008e5f3e857db81f95
2018-02-23 16:26:39 -05:00
Jose Castro Leon
1eae301c4f Add support for endpoint group commands
Implements the commands for endpoint group filter management.
Includes the CRUD management of the endpoint groups and the
association management between them and the projects that are
using this method.

Implements: blueprint keystone-endpoint-filter
Change-Id: I4265f7f8598d028191e90d76781b7b6ece6fef64
2018-02-23 20:36:04 +00:00
Tytus Kurek
4a9e84be99 Add support for "--dns-domain" argument
This patchset implements support for "--dns-domain" argument to the
following commands: "openstack port create" / "openstack port set".

Change-Id: I4bb001054b00a969b74db3bb310e567033bf589b
Depends-On: https://review.openstack.org/#/c/500660/
Closes-Bug: #1714878
Partial-Bug: #1704769
2018-02-23 20:30:37 +00:00
Gage Hugo
d32664150f Add project tags functionality
This change adds tags functionality for projects in keystone. A user
can add a single tag with "--tag", chain "--tag" to add multiple
tags, or clear tags with "--no-tag".

Change-Id: I31cfef3e76dcefe299dacb00c11bb1a10a252628
Partially-Implements: bp project-tags
2018-02-23 20:26:57 +00:00
Zuul
7505831e81 Merge "Zuul: Remove project name" 2018-02-08 00:38:33 +00:00
Monty Taylor
07014e09c9
Make osc-functional-devstack-tips actually use tips
The base job has tox_install_siblings: false - which we want. But
that means we need tox_install_siblings: true on the tips job.

While we're at it - add fetch-tox-output so that we have tox log files
in the fetched build output for easier verification of what wound up
installed.

Don't look for ResourceNotFound string in test

The string ResourceNotFound is not in the error string anymore. Look for
the text that is.

Depends-On: https://review.openstack.org/541033
Change-Id: Id6de1485bcafb41f238f3e74277094ce64a6acf4
2018-02-05 17:00:08 -06:00
James E. Blair
9f2ad36b91 Zuul: Remove project name
Zuul no longer requires the project-name for in-repo configuration.
Omitting it makes forking or renaming projects easier.

Change-Id: I92ea13e64dcdc24a8dd1fd6d17df9f771b2fc1e0
2018-02-05 12:57:55 -08:00
Zuul
25e60a4bf1 Merge "Make functional-tips job voting" 2018-01-31 22:39:04 +00:00
Colleen Murphy
375964f270 Add CRUD support for application credentials
Add support for creating, retrieving, and deleting application
credentials. Application credentials do not support updates.

In order to provide a positive user experience for the `--role` option,
this patch also includes an improvement to the
`identity.common._get_token_resource()` function that allows it to
introspect the roles list within a token. This way there is no need to
make a request to keystone to retrieve a role object, which would fail
most of the time anyway due to keystone's default policy prohibiting
unprivileged users from retrieving roles.

bp application-credentials

Change-Id: I29e03b72acd931305cbdac5a9ff666854d05c6d7
2018-01-30 21:50:01 +01:00
Zuul
0c1a73eff5 Merge "Fix tox -e venv -- reno new <slug>" 2018-01-30 03:33:33 +00:00
Monty Taylor
a742e47ecf
Use find_ip from openstacksdk
The find_ip from openstacksdk started being usable by OSC back in 0.9.15
but the local method never got replaced.

Change-Id: I18a334280e5f384f8bb96198cdad79c612a02290
2018-01-29 12:05:22 -06:00
OpenStack Proposal Bot
2ef279ab71 Updated from global requirements
Change-Id: I7febe9ca4d4c9ac5044208ff1816eab8f1d9452e
2018-01-29 00:35:35 +00:00
Matt Riedemann
8468b2a064 Fix tox -e venv -- reno new <slug>
Change I7e8c47dead1e019e8705db3ff7559dd39b1d90d9 broke
the ability to create a new release note from the venv
tox target because the reno requirement was moved from
test-requirements.txt. This fixes it.

Change-Id: Ifac83121388728fa445e0ed4433c9d981c057737
2018-01-27 20:46:32 -05:00
OpenStack Release Bot
db0c9231c0 Update reno for stable/queens
Change-Id: Iace9272b22ec8ccc8790e63c3f5e435d497c5e71
2018-01-25 13:46:13 +00:00
OpenStack Proposal Bot
fbee4eb762 Updated from global requirements
Change-Id: I7b712b41e633f7e3dc40749b5a55706cb32fecee
2018-01-24 01:31:48 +00:00
Monty Taylor
5e411fbce7
Fix use of new openstacksdk connection
We store the created conn on the instance, but we never pull it back off
if there is already one present.

Change-Id: I2d890dd206d4ddf67fa42d798e6fd2c652799785
2018-01-23 08:08:26 -06:00
Dean Troyer
a018c6d5d8
Rework Network client config for new SDK Connection
network.client.make_client() has always put a copy of it's SDK Connection
directly into ClientManager, the new-style Connection create will move
into osc-lib ClientManager, do it here too until then.

Change-Id: I1edfd19c9e73320768fb9640931fafe857c980b4
2018-01-22 16:51:03 -06:00
Zuul
1e30be92d8 Merge "Updated from global requirements" 2018-01-22 17:57:08 +00:00
Zuul
7d50e5fc9a Merge "Replace assert with condition" 2018-01-22 17:56:31 +00:00
Zuul
fba356b3e5 Merge "Check that Glance returns image data before processing it" 2018-01-22 17:56:29 +00:00
Pavlo Shchelokovskyy
ca90985f4e Replace assert with condition
a piece of code in image client has some business logic behind
assert, which can be lost when running python in optimized mode (-O).

Change-Id: I2179970df495e1215d691915c51cebe5cb4541a7
2018-01-22 12:26:17 +02:00
OpenStack Proposal Bot
951956a799 Updated from global requirements
Change-Id: I72c81c299759b883e316b450716d1528bdb06308
2018-01-19 12:49:58 +00:00
David Rabel
e8b56a37cc Corrected spelling mistake
in quotas -> in quotes

Change-Id: I3adb1ccd8f3a9c495f0b9cf688aee5c4c1e63507
2018-01-19 11:18:41 +01:00
Zuul
8822c9e8f3 Merge "Fix indentation in authentication.rst" 2018-01-18 18:53:47 +00:00
Zuul
e8dbac35f6 Merge "Updated from global requirements" 2018-01-18 14:01:17 +00:00
Zuul
9aaca5cdd4 Merge "Partially Revert "Update new documentation PTI jobs"" 2018-01-18 14:01:15 +00:00
Zuul
8acd2415eb Merge "Use Zuul v3 fetch-subunit-output" 2018-01-18 10:34:26 +00:00
OpenStack Proposal Bot
001efadbde Updated from global requirements
Change-Id: Ic5715c21e19d92c8f3d85091bfa41c28bb271c42
2018-01-18 03:30:37 +00:00
David Rabel
ab50a2ec8a Fix indentation in authentication.rst
Fix indentation in doc/source/cli/authentication.rst

Change-Id: I7d408e9d27a384903680303219f2578be0e2937e
2018-01-17 18:33:33 +01:00
Doug Hellmann
189aec9b18 Partially Revert "Update new documentation PTI jobs"
The zuul job figures out whether to run "setup.py build_sphinx" or
"build-sphinx" based on whether the project is relying on pbr's
ability to auto-generate API reference docs. Because we are relying on
that, we want local builds to use "setup.py build_sphinx".

This reverts commit 42e0037cd0.

Change-Id: Ia01188110fa9c3ccaf3d794fa3a511a6780e683e
2018-01-17 10:16:17 -05:00
Andreas Jaeger
0a2ee90204 Use Zuul v3 fetch-subunit-output
We have consolidated the fetch output roles into one
fetch-subunit-output, replace useage of old roles with new one.

Depends-On: I0cdfc66ee8b046affeb0b071fef38c21cb7a4948
Change-Id: Iae2892d9b4cd870a11579434edc9ee66bd16798c
2018-01-16 08:12:58 +01:00
OpenStack Proposal Bot
551278eb85 Updated from global requirements
Change-Id: I72311597c1b62d985282cef5e219c16cd6745b42
2018-01-16 04:32:02 +00:00
OpenStack Proposal Bot
f02f95f063 Updated from global requirements
Change-Id: I90df2e58bb83239f5b041982844516eb34cb5656
2018-01-15 11:00:35 +00:00
Zuul
8abf6bf5ba Merge "Add floating IP qos_policy actions" 2018-01-11 21:03:18 +00:00
LIU Yulong
cf91d7a2f4 Add floating IP qos_policy actions
Now we can associate a qos policy to the floating IP, and
dissociate it. The commands are:

  $ openstack floating ip create --qos-policy ...
  $ openstack floating ip set --qos-policy ...
  $ openstack floating ip set --no-qos-policy ...
  $ openstack floating ip unset --qos-policy

These commands are based on the neutron change:
I4efe9e49d268dffeb3df4de4ea1780152218633b

Partially-Implements blueprint: floating-ip-rate-limit

Change-Id: I932b32f78cc5a2b53926feaec1a0b392cf7e8b57
2018-01-11 18:10:11 +00:00
OpenStack Proposal Bot
cc47c075a0 Updated from global requirements
Change-Id: Ic85eb65f3f143fdfbf2b6fa71d7cdd6961b24c76
2018-01-09 16:21:50 +00:00
Mike Fedosin
ed1b59848f Check that Glance returns image data before processing it
Now if Glance v2 cannot find image data it returns an empty
response with 204 status code, instead of raising an error.

Glance client handles this situation and wraps the response
with a RequestIdProxy object, whose 'wrapped' attribute is
None.

But when openstack client tries to parse this object using
glanceclient's save_image util function, it fails with
"NoneType object is not iterable" message, for the
object doesn't contain any data.

This patch adds additional check to prevent such behaviour
and raises SystemExit exception if no data was returned from
the server.

Glance v1 is not affected, because it raises an error if can't
find an image data.

Change-Id: I016a60462ba586f9fa7585c2cfafffd7be38de7b
Closes-Bug: #1741223
2018-01-05 19:36:49 +01:00
Hongbin Lu
5fdd0730c8 Allow ports filtering with device_id
Right now, if a neutron port is owned by a container powered by
Kuryr, there is no way to list and filter those ports because
OSC assumed a neutron port is owned by either a server or router.
This patch adds support for that by introducing an option '--device-id'
to the 'port list' command.

Change-Id: Ib1fd27e8d843a99fb02ccabd8a12a24ac27cec9c
2018-01-03 21:11:02 +00:00
Zuul
b13a323128 Merge "Update new documentation PTI jobs" 2018-01-03 16:52:46 +00:00
Zuul
e157365d86 Merge "Allow port list to shown undefined attributes" 2017-12-31 13:00:26 +00:00
Guoqiang Ding
42e0037cd0 Update new documentation PTI jobs
For compliance with the Project Testing Interface as described in [1].
For more detailed information, please refer to [2].

[1] https://governance.openstack.org/tc/reference/project-testing-interface.html
[2] http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html

Change-Id: I7e8c47dead1e019e8705db3ff7559dd39b1d90d9
2017-12-28 16:16:28 +00:00
Chen Hanxiao
e438c34eaa flavor: clarify --swap description
--swap will add a additional storage device,
which not affect the original swap partition/device.

This patch will clarify this misleading description.

Change-Id: Ic079c069985d39cc969b97876901007a81883f57
Signed-off-by: Chen Hanxiao <chenhx@certusnet.com.cn>
2017-12-28 14:56:13 +08:00
Zuul
5e00034d8e Merge "Switch to use stestr directly" 2017-12-27 20:07:04 +00:00
Zuul
65d5d3d615 Merge "Updated from global requirements" 2017-12-27 20:06:45 +00:00
Masayuki Igawa
bafe5357c2
Switch to use stestr directly
This commit makes to use stestr instead of ostestr
directly. ostestr>1.0.0 has started to use stestr instead of
testrepository. So there is no reason to use ostestr anymore.

Change-Id: I6327d50c9f6dd19f1de24b9b51532104fb3e916e
2017-12-27 16:18:49 +09:00
Akihiro Motoki
c19d982399 Fix func tests: Ensure to pass OS_CLOUD envvar
Our functional tests depend on OS_CLOUD (or other OS_* envvars)
to retrieve authentication information.
Functional test failure is caused by the lack of OS_CLOUD envvar.
This commit updates the job playbook to pass OS_CLOUD.

Change-Id: I903ce599082cc923f02e26a2058bbfa7eb9bb2d6
2017-12-27 02:52:15 +09:00
OpenStack Proposal Bot
9c23fc8025 Updated from global requirements
Change-Id: Ieb1a29ba275784f67f0d943fab5f3b59cd9fc28e
2017-12-23 10:11:57 +00:00
Zuul
8c5f755569 Merge "Send 'changes-since' instead of 'changes_since' query parameter" 2017-12-13 02:57:49 +00:00
Zuul
21b656ca4a Merge "Add support for endpoing filter commands" 2017-12-13 02:18:43 +00:00
Daniel Speichert
116526275d Send 'changes-since' instead of 'changes_since' query parameter
Per API reference, only 'changes-since' is accepted and the variant
with underscore is ignored, making the CLI functionality broken.

[dtroyer] added release note and fixed unit tests.

Change-Id: I0c596531a8af03da17d5ce39d75b12e941403aa5
Closes-Bug: 1732216
2017-12-11 18:07:45 -06:00
Zuul
58e5abf294 Merge "Fix credentials in create, update and list." 2017-12-11 22:45:54 +00:00
Dean Troyer
1d914dd9ad Fix SDK Connection creation alternative to Profile
Do a dummy import to determine which SDK is installed (Pre/post merge).

This solves the DevStack error "Cloud defaults was not found" in -tips jobs.

Depends-On: Ia111f127fbdceac2afe20fd9d1fe032145cdd72c
Change-Id: I60c2d418dd5a393eee2cc2a5c2fdebfffdabf2d3
2017-12-07 08:10:23 -06:00
Zuul
396cde37a3 Merge "Remove a bunch of things we promised to remove in 2H 2017" 2017-12-04 22:08:50 +00:00
Dean Troyer
b0a75d739a Make functional-tips job voting
Depends-on: I57cf95763d54ad2060a4ce2af91c3ba18ca04db0
Change-Id: I6cc4421e4b55df84f494ab9bb18092dcc111baeb
2017-12-04 15:25:54 -06:00
Andreas Jaeger
0bf69a9462 Remove -U from pip install
'pip install -U' ugrades specified packages, this is not necessary
since we use constraints, remove the parameter '-U' from the line.

With tools/tox_install.sh - which a previous change of mine removed -
the -U was not harmful, but with the current set up, it might cause
upgrades, so remove it.

Change-Id: I9f818d4b78e7540498a1501be14cd63ac3e891b3
2017-12-02 19:21:22 +01:00
Zuul
5cf1190879 Merge "openstack subnet create fails when tags is None" 2017-12-02 01:35:39 +00:00
Carlos Konstanski
dab49df461 openstack subnet create fails when tags is None
In network/v2/_tag.py lines 105 and 110: obj.tags can be None, in
which case set(obj.tags) throws a NoneType exception.

Change-Id: I1e965ec947844cbf84676fab27a2261fc0c0ea49
Closes-Bug: #1735836
2017-12-01 15:17:03 -07:00
Monty Taylor
8b32b53a0f
Avoid tox_install.sh for constraints support
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.

This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.

Change-Id: Ie7c06ead39c8597ec9326f223625d1fa0d5208d1
2017-12-01 10:26:50 -06:00
Monty Taylor
01d3b42a06
Make py27 and py35 versions and template of unit-tips jobs
Make py27 and py35 versions of the tips job, and a project-template to
hold them so it's easy for other projects to use both (or more, we ever
add them) The base tox job knows how to install siblings based on
required-projects, which makes it easy to piggyback on them.

Remove the irrelevant-files sections, as these are specified in the
base openstack-tox jobs.

Using the unit-tips or functional-tips tox env is no longer neccessary.
For the gate it's actually important to not do the sibling processing by
hand in tox as the base tox job version of the logic does all the
right things to deal with constraints and whatnot. Leave them for local
developer convenience.

Leave the osc-tox-unit-tips job for now, since there are some other
repos using it. Once we switch them to the template, we can remove the
job.

Change-Id: I599b18218c10cb08e508cca3b3bbc9c88b8f809c
2017-12-01 10:26:46 -06:00
Monty Taylor
b061b9c34e
Add cliff and keystoneauth to tips jobs
Both of these can severely break openstackclient. Add them to the
required-projects list of the tips jobs. We should then add at least
osc-tox-unit-tips but maybe also osc-functional-devstack-tips to both
cliff and keystoneauth so that it's symmetrical.

Change-Id: Ie0f3e9d7e221c9cdd3c5d726148f456246186ff4
2017-12-01 10:19:34 -06:00
Dean Troyer
2c2c16ba55 Remove a bunch of things we promised to remove in 2H 2017
Change-Id: I060559fe13e354fe87551cd9dd82774bddb54640
2017-11-30 15:35:42 -06:00
Dean Troyer
3a672eae7b Release note cleanup
Change-Id: Iea05a9b696a225b41bb5bf0c52498969e32acf66
2017-11-29 16:38:44 -06:00
Zuul
ae2ae4e60e Merge "Set correct designate endpoint in docs" 2017-11-29 16:56:42 +00:00
Zane Bitter
c778c7d631 Set correct designate endpoint in docs
Change-Id: Id2ecf65f3e5afef9b6231565cac2d797650e38a7
Closes-Bug: #1726726
2017-11-28 18:16:01 -05:00
Zuul
249851ae7d Merge "Fix file mode on network-topology.rst" 2017-11-28 22:53:19 +00:00
Zuul
878410db8d Merge "Replace %r with %s on printing string variable" 2017-11-28 21:35:55 +00:00
Monty Taylor
5176951d59
Make osc-tox-unit-tips work on other repos
We want to run osc-tox-unit-tips on changes to os-client-config and
python-openstacksdk - but the tox role defaults to using
zuul.project.src_dir as the working directory. We want it to always be
the openstackclient source dir.

Change-Id: Ic7a49b79fb9141d9d0b8da40e10c85b107564edc
2017-11-26 14:50:55 -06:00
Akihiro Motoki
0626f95579 Allow port list to shown undefined attributes
At now, OSC command implementation extracts resource attributes based on
a predefined column list, so if a user specifies an unknown attribute
not defined in the column lists, such attribute will be ignored.

In case of 'port list', the neutron port defines many attributes and
it is not a good idea to show all attributes even in the long mode
from the perspective of user experience.

This commit consumes osc_lib.utils.calculate_headers_and_attrs()
function to show undefined port attributes if requested in -c option.

Closes-Bug: #1707848
Depends-On: I6c6bc3c6e3c769c96869fd76b9d9c1661280850e
Change-Id: I130a6aed41d80603698b6cab0c9a1d1dc59df743
2017-11-24 22:45:06 +00:00
Zuul
c47b1ff063 Merge "Updated from global requirements" 2017-11-21 19:54:21 +00:00
OpenStack Proposal Bot
4cff01a2be Updated from global requirements
Change-Id: I6d09649d109445bee8ec541a1366dfcf49fd6563
2017-11-21 15:52:35 +00:00
Brian Haley
cc52022447 Fix file mode on network-topology.rst
doc/source/contributor/specs/network-topology.rst was
executable, change mode to 0644.

Change-Id: I7e9c8a86ee8563f47da3f59c189b5bd5f3846344
2017-11-21 10:02:46 -05:00
Jose Castro Leon
12ee186108 Add support for endpoing filter commands
Implements the commands that allow to link and endpoint to
a project for endpoint filter management.

Implements: blueprint keystone-endpoint-filter

Change-Id: Iecf61495664fb8413d35ef69f07ea929d190d002
2017-11-21 07:58:48 +01:00
Matt Riedemann
d0917cd14b Remove hard-coded policy choices for creating a server group
The hard-coded choices for the server group policy make it impossible
to create a server group with the soft-affinity or
soft-anti-affinity policy rules which were added in compute API
microversion 2.15. This removes the hard-coded choices so that the
policy is restricted on the server side rather than the client side.

Change-Id: Ib3dc39422ac1015872d56ae2fdeddf0f29613494
Closes-Bug: #1732938
2017-11-19 18:45:28 -05:00
Zuul
ddb94ea2a4 Merge "Prepare for os-clinet-config to go away" 2017-11-17 21:44:02 +00:00
Zuul
45260c41de Merge "Add logic to handle old and new sdk constructor" 2017-11-17 21:33:29 +00:00
yangweiwei
0f749cacc2 Fix credentials in create, update and list.
Now, keystone has supported serverl auth method, like 'totp'.
Before we use this method, we should create the credential first.
And we need create it with type 'totp'. But now we cannot create
credential with this method.

Also, I think the type should not have constrains. We can create
any type in keystone project. So, we should do these actions too.
The type would be more which We cannot control.

Change-Id: Ie0482da3133fb515e4bb8e45f8c54f509589cc5e
Closes-bug: #1731848
2017-11-17 11:39:15 +08:00
Andreas Jaeger
d7f906b526 Remove setting of version/release from releasenotes
Release notes are version independent, so remove version/release
values. We've found that projects now require the service package
to be installed in order to build release notes, and this is entirely
due to the current convention of pulling in the version information.

Release notes should not need installation in order to build, so this
unnecessary version setting needs to be removed.

This is needed for new release notes publishing, see
I56909152975f731a9d2c21b2825b972195e48ee8 and the discussion starting
at
http://lists.openstack.org/pipermail/openstack-dev/2017-November/124480.html
.

Change-Id: Ia0c8d7dc346182fde095eebb82eeeb70fc1b9770
2017-11-16 20:46:56 +01:00
Dean Troyer
7d85ecaa33 Prepare for os-clinet-config to go away
We used that module in a test functional for module list, it is being absorbed
into python-openstacksdk and having it listed in this test breaks -tips jobs.

Change-Id: I98fdf5a5d1b3c6e30cb4c5f5fec3dd8e43e53145
2017-11-16 12:38:17 -06:00
Monty Taylor
80da4d6cf8
Add logic to handle old and new sdk constructor
SDK is removing Profile, but currently has compat code to support this
invocation in OSC. While the intent is to protect people from upgrade
breakage, it's python, and packaging things have a tendency to get
strange. By putting in a little belt and suspenders if block here, we
can hopefully protect folks who upgrade sdk for some reason without
upgrading python-openstackclient.

Change-Id: Id678e97a2b99dbbfc772acc8c6ba283db551723d
2017-11-16 08:09:11 -06:00
OpenStack Proposal Bot
c0f910d613 Updated from global requirements
Change-Id: I714dbe5326ed99c4edab6c63ecea4dc6a72b57e7
2017-11-16 11:25:40 +00:00
Zuul
c161a76a5f Merge "Network: Add interfaces info in router show" 2017-11-16 01:45:55 +00:00
Zuul
67c8da4499 Merge "Show detailed message of neutron exception" 2017-11-16 00:03:34 +00:00
Zuul
10ef6d5177 Merge "Add RemoveNetwork command to server" 2017-11-15 23:35:01 +00:00
ycx
e7ef9e8556 Network: Add interfaces info in router show
Add a list of interfaces info in the output of
'openstack router show'.
The information of router interface are:
IP address, subnet ID and port ID.

Co-Authored-By: Dongcan Ye <hellochosen@gmail.com>

Change-Id: I1252986122122defffe795292b83dc4e84481c7e
Closes-Bug: #1675489
2017-11-15 22:28:46 +00:00
OpenStack Proposal Bot
aafbb69cfb Updated from global requirements
Change-Id: I2c8a5132f6078609ad0d46093642a1b361115c5c
2017-11-15 01:53:52 +00:00
Hongbin Lu
8b31e2bc48 Show detailed message of neutron exception
This patch improves the error message by retrieving the more details
from the exception instance. Otherwise, the real error message won't
be displayed (unless using --debug in the command).

Change-Id: I8ba694bda86f7cc8362e301b2044d9b610dde49c
2017-11-14 23:25:52 +00:00
Hongbin Lu
809355894f Add RemoveNetwork command to server
This command will detach a server from a network. All server's
neutron ports that belongs to the specified networks will be removed.

Change-Id: I83a064ed62ab00c6f1016900b9cf30f1c15b8382
2017-11-14 00:13:08 +00:00
Hongbin Lu
7ef2867ff6 Replace %r with %s on printing string variable
Change-Id: Idd8c15255f024bba7079d3a9a29545dec0c91b58
2017-11-13 15:23:16 +00:00
OpenStack Proposal Bot
4742d4df70 Updated from global requirements
Change-Id: Icf2e8d6cca0194de127ef0dfaee5db04381b5cd1
2017-11-12 21:18:50 +00:00
Zuul
b230ba73cd Merge "Be robust on import plugin module" 2017-11-08 05:17:21 +00:00
Zuul
5311fc36fd Merge "Add python-rsdclient into plugin list" 2017-11-07 07:22:24 +00:00
Zuul
d12fd10cc1 Merge "Neutron agent delete: remove the wrong argument" 2017-11-07 06:59:54 +00:00
Zuul
c2ebe678f9 Merge "Network: Add supports rbac target-all-projects" 2017-11-07 00:20:07 +00:00
npraveen35
6c8e5177bc Neutron agent delete: remove the wrong argument
The take_action() function was calling get_agent() with the wrong
attribute, causing agent deletion to fail. It turns out calling
get_agent() isn't necessary; this removes the call entirely and moves
the 'ignore_missing' argument to the delete_agent() function.

Change-Id: Iaa3754a3be0765112f396495fa5fb2e32e6eae4e
Closes-Bug: #1711301
2017-11-06 16:31:27 +00:00
Zuul
e8a87e1478 Merge "Display Network QoS rule type details" 2017-11-06 04:04:54 +00:00
Zuul
c393472339 Merge "Rehome test units lib" 2017-11-06 00:48:32 +00:00
Sławek Kapłoński
07f0c7aa55 Display Network QoS rule type details
Neutron API now supports getting details of supported
QoS rule type.
This patch adds support for this feature to OpenStack client.

Change-Id: I74d16563ce2236a7c899f5994f1dab43ace02138
Depends-On: I448b5d4f8e4ef42eafe50d9d6c63d0be666f98fc
Related-Bug: #1686035
2017-11-05 17:52:08 -06:00
Dongcan Ye
9ca99b9919 Network: Add supports rbac target-all-projects
Add a boolean option "target-all-projects",
which allows creating rbac policy for all projects.

Change-Id: Ie3af83a1bba7dd66e83b0595bb276bf8fd105831
Closes-Bug: #1728525
Closes-Bug: #1704834
2017-11-05 01:16:48 -05:00
OpenStack Proposal Bot
7744046d6a Updated from global requirements
Change-Id: I9935e5f3eeab0e0d8a56f5983822ad96c79a7526
2017-11-03 01:07:54 +00:00
Pierre Hanselmann
a4d56e615d Rehome test units lib
Rehoming deprecated libs for the ones provided in osc-lib.

Change-Id: Idb4a27f2c8edf48909ef010e3c7a1a5c0c16efc5
2017-11-02 13:44:16 +01:00
Zuul
2c14b4b2ee Merge "Zuul job updates" 2017-11-01 04:18:41 +00:00
Zuul
a51ac0a889 Merge "Added AddNetwork command to server" 2017-10-30 04:21:41 +00:00
James E. Blair
b7388dc9e3 Zuul: add file extension to playbook path
Zuul now supports including the file extension on the playbook path
and omitting the extension is now deprecrated.  Update references
to include the extension.

Change-Id: Ia1747b6c97140b7e12972c7f7b14cb0620ead084
2017-10-29 04:39:26 -07:00
Lin Yang
5b034ef653 Add python-rsdclient into plugin list
Intel RSD is new architecture that disaggregates compute, storage,
and network resources, and provide the ability to dynamically compose
resources based on workload-specific demands [1]. The python-rsdclient
project provide specific RSD plugin to allow user to invoke RSD API
through OpenStackClient. So Added it into existing plugin list.

[1] https://www.intel.com/content/www/us/en/architecture-and-technology/rack-scale-design-overview.html

Change-Id: Ic49efddfb003c89ece6d782905b27fb46402b3ab
2017-10-27 16:00:22 -07:00
Dean Troyer
40976f0062 Add server rescue unit tests
Added to support the new options to server rescue command.

Change-Id: Ia9dca85e05488fa8d5f57cd5e8920e94b8f65c22
2017-10-27 20:19:17 +00:00
Zuul
d215982ce0 Merge "Add missing parameters on openstack server rescue" 2017-10-27 18:29:07 +00:00
Dean Troyer
90230c3766 Zuul job updates
* Add unit-tips job to run unit tests with the same project master branches
  as the functional-tips job (mostly useful for the unit.integ tests)
* Add irrelevant-files to the osc-functional-devstack-base job
* Comment out the functional-n-net job as it is horribly broken for now
  until the replacement package-installed OpenStack is ready

Change-Id: I5acdcb0a2f0f0dfe488740ae0add36366cc0ee21
2017-10-27 12:40:24 -05:00
Jose Castro Leon
fd23ebfbf3 Add missing parameters on openstack server rescue
Change-Id: I27afca9e826378dbcb7feb7528e0c65c528b04b0
Closes-Bug: #1703278
2017-10-27 14:52:04 +00:00
Hongbin Lu
e3ad82164d Added AddNetwork command to server
Currently, if users want to add another NIC to a running instance,
they need to (i) create a neutron port and (ii) add the port to the
server via teh AddPort command. It would be more convenient to have
a single command to achieve the equivalent.

Novaclient already support adding network to an instance via the
interface-attach command. This patch introduces a similar capability
in OSC.

Change-Id: Ia3e39c57ae7ecb96aae1b66adc52c289daccb6ec
2017-10-26 15:34:04 +00:00
Stephen Finucane
21212cabd5 Convert 'server' commands to use autoprogram
Convert the remaining server commands.

Change-Id: Ief84abb899be9fd60ce4d546abefc226e0ae4f81
2017-10-26 09:34:04 +00:00
Zuul
8efed05e82 Merge "Native DevStack jobs" 2017-10-25 16:34:17 +00:00
Dean Troyer
676159555f Native DevStack jobs
Convert legacy DevStack jobs to native Zuul v3 form, plus some
test-job-related docs updates.

Change-Id: Ia8c08be81605da885b9eee799fc58129305dfc41
2017-10-24 17:35:55 -05:00
Zuul
c5d3d9b318 Merge "Add wrapper around ostestr" 2017-10-23 19:26:33 +00:00
Monty Taylor
ef595fcfc4 Add wrapper around ostestr
The functional tests assume that an openrc file has been sourced. Make a
simple wrapper that will do that.

Change-Id: I42584aaebcbca99a8c922f6ff90c8bbce57bbfbb
2017-10-23 08:34:15 -05:00
Zuul
e83a0941a3 Merge "Allow creating security rules without protocol" 2017-10-21 17:20:10 +00:00
Zuul
6c0b966813 Merge "auto-generate docs for v3 identity resources" 2017-10-21 04:54:11 +00:00
Zuul
3abba6ede9 Merge "Accept 0 for --min-disk and --min-ram" 2017-10-21 00:40:48 +00:00
ShogoAdachi
4464109c77 Accept 0 for --min-disk and --min-ram
The current openstackclient implementation cannot accept 0
for --min-disk and --min-ram with the "openstack image set" command.
If theses options get set to 0, the option parser in openstackclient
wrongly interprets 0 as no option value. The 0 is valid for these
options if administrators want to make it the default(no minimum
requirements).

This patch fix the parser so that it avoids only 'None'.

Change-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3
Closes-bug: #1719499
2017-10-20 19:48:37 +00:00
Dean Troyer
161c79f703 Move more jobs in-repo
Now consume the merged openstackclient-plugin-jobs template in
openstack/openstackclient repo.

Change-Id: I60f2c8ad443c802e13de8f185647faa68e07bfe2
2017-10-19 15:53:57 -05:00
Dean Troyer
c901620a03 Attempt to de-race qos policy
We're getting about 1-in-6 failures on qos policy delete now, with the message
that the policy is in use by a network.  It shouldn't be, this is possibly
due to the small window where the policy is set as the default.  Let's
remove that and shore up the test using --share instead.

Change-Id: I8d669bd3c5c88dadd2927aee89e5ef72cf4001c4
2017-10-18 14:03:51 -05:00
Daniel Speichert
82f45d9bd2 Allow creating security rules without protocol
In order to create a rule for any protocol, the client
must not specify the protocol in the API call. This
is currently impossible because protocol defaults to TCP.

In order not to change the default behavior, a "new" protocol
name is added: "any", which makes this CLI skip sending the
protocol field altogether.

Change-Id: I58853d3745f3631007e5e9780c0c5c2526b730a3
Closes-Bug: 1712242
2017-10-17 13:36:40 -04:00
Zuul
09faba2713 Merge "Move base functional test job in-repo" 2017-10-17 14:10:51 +00:00
Dean Troyer
4733621ecb Move base functional test job in-repo
Depends-On: I26ed12133c75a69182c56b6ecf483fcdc37d98f3
Change-Id: Ib46eed6e038a502926bf92297120e2d494ef5b20
2017-10-15 23:52:55 +00:00
Ian Wienand
358544d40e Switch to $USER in post_test_hooks
As a first step to zuul migration, switch to $USER from a static
"jenkins" username.

Change-Id: I26ed12133c75a69182c56b6ecf483fcdc37d98f3
2017-10-16 10:50:13 +11:00
Jenkins
33403348a2 Merge "Optimize getting endpoint list" 2017-10-13 18:25:45 +00:00
Rodolfo Alonso Hernandez
885b1149c3 Avoid default mutable values in arguments
Mutable values shouldn't be used as default values in function
arguments [1].

[1] http://docs.python-guide.org/en/latest/writing/gotchas/

Change-Id: I3c7f915f0409c77f4c430467365eb1bcfd7757b3
2017-10-10 14:04:40 +01:00
Hongbin Lu
599fa78262 Be robust on import plugin module
On loading external plugin, OSC should be robust on importing the
plugin module so that commands from other modules can continue to
execute.

Closes-Bug: #1722008
Change-Id: Ibe716681c7f78fabee31b7ef281af2588d68ab30
2017-10-07 17:07:24 -04:00
Steve Martinelli
0d94a76d95 auto-generate docs for v3 identity resources
skipped shared v2/v3 identity resources.

Change-Id: I9e1fb5dee5506780fd79a0cbfbde059d0ccd1489
2017-10-06 00:57:04 +00:00
OpenStack Proposal Bot
a87bd58fb4 Updated from global requirements
Change-Id: I79e4ddb75c7cf7088d6f0abc79f9f07dcd165535
2017-10-05 13:51:35 +00:00
Hongbin Lu
de23ab8d75 Support creating unaddress neutron port
Introduce an option '--no-fixed-ip' on port create command.
If this option is specified and '--fixed-ip' is unspecified,
OSC will send a request to neutron with 'fixed_ips' as an empty
list, which will create an unaddress neutron port.

Note: The use cases of unaddress port was outlined in:
https://specs.openstack.org/openstack/neutron-specs/specs/liberty/unaddressed-port.html

(dtroyer: add Depends-On for Zuul v3 test)

Depends-On: I39e8e49243ab0bda631600715c971c55a34e2fd9
Change-Id: Ibe38598acbbcd0d353c952fc2a6fa67780762151
Closes-Bug: #1717829
2017-09-29 18:49:22 +00:00
Jenkins
a452c9d825 Merge "Support icmp-type and icmp-code to be set as zero" 2017-09-27 05:49:50 +00:00
Jenkins
2476a995cf Merge "Fix 'project purge' deletes ALL images problem" 2017-09-27 05:27:52 +00:00
Jenkins
2c77aba363 Merge "Add "volume service list --host" functional test case" 2017-09-26 23:15:31 +00:00
Jenkins
fe28472b74 Merge "Update the documentation link for doc migration" 2017-09-26 23:14:49 +00:00
Anton Frolov
f6f5ce03c5 Optimize getting endpoint list
Currently ListEndpoint.take_action method unconditionally iterates
over all endpoints and issue GET /v3/services/<ep.service_id>
request for each endpoint. In case of HTTPS keystone endpoint this
can take significant amout of time, and it only getting worse in
case of multiple regions.

This commit change this logic to making just two GET requests: first
it gets endpoint list, then it gets service list, searching service
in the list instead of issuing GET /v3/services/<id> request.

Change-Id: I22b61c0b45b0205a2f5a4608c2473cb7814fe3cf
Closes-Bug: 1719413
2017-09-26 14:31:07 -07:00
gvrangan
221b7052ab Support icmp-type and icmp-code to be set as zero
When icmp-type or icmp-code are set to 0, the current implementation
ignores the value, this fix will allow the value to be copied and
displayed

Change-Id: I96133a57883d22e98fcbb9fe0328d9e050472469
Signed-off-by: gvrangan <venkatrangang@hcl.com>
2017-09-26 21:00:14 +00:00
lihaijing
254dbf3294 Fix 'project purge' deletes ALL images problem
Closes-Bug: #1717130
Change-Id: I33c6fc7897dfee85d1c197a1267bde4abfa5bbd9
2017-09-26 20:49:32 +00:00
lingyongxu
41352cb375 Update the documentation link for doc migration
This patch is proposed according to the Direction 10 of doc
migration(https://etherpad.openstack.org/p/doc-migration-tracking).

Change-Id: Ieca93d77bfc5e54486312f16122cc12c5bda0934
2017-09-21 10:47:31 +00:00
OpenStack Proposal Bot
953d74b5d6 Updated from global requirements
Change-Id: I9509fb386bc28eaaeab8d27f4cfc7109ec261b73
2017-09-21 03:50:03 +00:00
Jenkins
f88d2f53ba Merge "Add functional test cases for "volume qos associate/disassociate"" 2017-09-19 12:51:14 +00:00
Jenkins
763288f605 Merge "Unroll the network qos policy functional tests" 2017-09-19 12:51:07 +00:00
Jenkins
a060ba8217 Merge "Add python-zunclient plugin" 2017-09-19 08:53:55 +00:00
lihaijing
844623ccc4 Add "volume service list --host" functional test case
Change-Id: I467252d9fc6083fb891a8701d7992f16ce42556f
2017-09-19 14:06:27 +08:00
lihaijing
edebe558ee Add functional test cases for "volume qos associate/disassociate"
Change-Id: I07b25bebb8a0ea18cdf042357be65c4ec6e1cfed
Closes-Bug: #1717874
2017-09-18 12:30:12 +00:00
Jenkins
39c00ab8b7 Merge "Useless line of code in shell.py" 2017-09-18 04:03:15 +00:00
Dean Troyer
59bba7c0d2 Unroll the network qos policy functional tests
These seem to have gotten a bit racy in the last revision, just do
it the long way now.

Change-Id: I3748b8b4f264dbfa8c991b32653682e5c86eeb4c
2017-09-17 13:52:12 -05:00
Jenkins
21542d1e6e Merge "Attempt to work around chronically failing server issues with aggregates and qos" 2017-09-16 17:44:32 +00:00
Jenkins
40a0ce5c94 Merge "Updates for stestr" 2017-09-15 23:13:49 +00:00
Hongbin Lu
e785570406 Add python-zunclient plugin
This patch adds the "appcontainer" commands to the docs and sets
up the document generation for the python-zunclient plugin

Change-Id: I58bd208e98bd059d9df03ee71dcb83779044f83a
2017-09-15 18:24:12 -04:00
Dean Troyer
949e0cb3c6 Attempt to work around chronically failing server issues with aggregates and qos
So yeah, this is not kosher for functional tests, but we're testing the
client interaction, not the raciness of Nova or Neutron.  Failure to delete
is not our problem.

Change-Id: I21043f1de0fbacee1aec63110fb12a7cff42e0a0
2017-09-15 12:34:15 -05:00
Matthew Treinish
12552cee70 Fix subunit collection in functional tests with ostestr>=1.0.0
With the release of os-testr 1.0.0 stestr is used internally and because
of that the repository dir and commands to get subunit are different.
This commit updates the post-test hook to get the subunit stream if
ostestr>=1.0.0 is used.

Change-Id: I2cce7f4780ce418398b17a5848def9072372841e
2017-09-15 10:35:53 -05:00
Dean Troyer
7274e8efe6 Updates for stestr
Change-Id: I860981f06e31abda3141a0cb4fd13a0d49080b50
2017-09-15 06:32:58 +00:00
Jenkins
f63bb18003 Merge "Updated from global requirements" 2017-09-13 18:18:45 +00:00
Jenkins
a4490b876e Merge "Fix output for subnet show" 2017-09-13 16:52:55 +00:00
OpenStack Proposal Bot
c7671dd9a4 Updated from global requirements
Change-Id: Ibeed9c623a6ef1c641c121a2b5ee75920346056f
2017-09-13 13:02:59 +00:00
Jenkins
c98ff623f2 Merge "Correct import of keystoneauth1 session" 2017-09-13 08:34:34 +00:00
OpenStack Proposal Bot
95378bb37d Updated from global requirements
Change-Id: I30be8748ef78604eb63c61e1dcf5fc5a740822aa
2017-09-13 00:15:31 +00:00
Gage Hugo
760e91abcf Correct import of keystoneauth1 session
keystoneclient.session has been long deprecated in favor of
keystoneauth1.session. This change corrects the import in the
tests to use the correct library's session.

Change-Id: Ic24ebde59e4b9eb70d6f14c1e0536f8d24f0de73
2017-09-12 22:19:32 +00:00
Dean Troyer
ce468209c4 Skip Volume v1 functional tests if v1 not present
Volume v1 is gone in Queens

Just skip it for now until DevStack does not create a v1 endpoint

Change-Id: I2aa2f78b0d5c8ac2048c922c7835e5c4574028cc
2017-09-12 19:50:15 +00:00
Jens Harbott
104d6d0e31 Fix output for subnet show
The use_default_subnet_pool column is never returned by the API, it is
only being used in the request to create a subnet. So make sure that we
do not show it when displaying a subnet.

Change-Id: Ie021149cceb8f89b779ad0f3c13ac60420509671
Related-Bug: 1668223
2017-09-12 14:21:49 +00:00
Huan Xiong
61025bf102 Useless line of code in shell.py
Shell.py contains lines to import osprofiler. This is useless
because osprofiler options support code was moved to osc-lib.

Removed it.

Change-Id: Ibec17700c87df908640848c3787d190ca66a7bcf
Closes-Bug: #1707103
2017-09-08 06:28:15 +00:00
OpenStack Proposal Bot
8f4440a6de Updated from global requirements
Change-Id: I1c5bc67d82b7a123530a7e8a6af5ca4f7faf53f0
2017-09-06 03:15:36 +00:00
OpenStack Proposal Bot
de2af66c16 Updated from global requirements
Change-Id: If52bacff8458010d2762bfac5ecea29f5fb54f01
2017-09-01 12:47:11 +00:00
Jenkins
06d470fb27 Merge "Update image cli doc and fix some typos" 2017-08-25 23:30:38 +00:00
Jenkins
c9742e8062 Merge "Convert remaining network functional tests to JSON" 2017-08-25 10:35:22 +00:00
lihaijing
ff91e26983 Update image cli doc and fix some typos
Change-Id: I0a8d095e51a96804c97612e28fac2d00aa94c638
Closes-Bug: #1711284
2017-08-25 08:08:31 +08:00
Jenkins
50099d3c72 Merge "Convert network qos functional tests to JSON" 2017-08-24 17:58:23 +00:00
Jenkins
36aec29c67 Merge "Updated from global requirements" 2017-08-24 17:14:21 +00:00
Jenkins
33d0b88f0b Merge "Convert network security group functional tests to JSON" 2017-08-24 15:43:21 +00:00
Jenkins
aa3791b4e3 Merge "flake8-import-order: Ensure to place project imports last" 2017-08-24 15:43:14 +00:00
OpenStack Proposal Bot
e62587625f Updated from global requirements
Change-Id: I45705bad68f0615dbf09d46a2a487b9fed1abb10
2017-08-24 11:48:43 +00:00
Akihiro Motoki
c1404f14b8 Convert remaining network functional tests to JSON
Change-Id: Ib7dff5506cc69549b5b1fbb8bf6e649468563dd6
2017-08-23 21:15:24 +00:00
Akihiro Motoki
fe8a50b6b1 Convert network qos functional tests to JSON
Change-Id: Ie5cde2f927ec6abb6334ea01adfb06749384ed01
2017-08-23 21:15:12 +00:00
Akihiro Motoki
95e279176b Convert network security group functional tests to JSON
Change-Id: Icb63aa0dfbce9016fb824f97915a660cf130d120
2017-08-23 21:14:47 +00:00
Jenkins
aa4cdf1dc8 Merge "Implied Roles" 2017-08-23 16:42:26 +00:00
lihaijing
d33ab499ed Fix "openstack image unset" command's help message typo
Change-Id: Ie286d9ee6054cc2126473d7e6e77bafbfd80023b
Closes-Bug: #1712473
2017-08-23 12:59:46 +08:00
Akihiro Motoki
ff85c62707 flake8-import-order: Ensure to place project imports last
To ensure project imports are placed after third party import,
we need to specify application-import-names.
Previously flake8-import-check checked only standard imports or not.

Change-Id: Iad7afa456cec7cf5b44955f1ea03c593a4c0e426
2017-08-22 21:38:07 +00:00
Harry Rybacki
8cd3e258c5 Implied Roles
Allow the user to create an inference rule between
two roles. The first, called the prior role
is the role explicitly assigned to an individual.
The second, called the implied role, is one that
the user gets implicitly. For example:

Role B implies Role A.
User X is assigned Role B.
Therefore User X also assigned Role A.

The management and maintenance of the rules is
performed in the Keystone server.

Change-Id: If547c2f16e812bc7fffd742ec37e6a26011f3185
2017-08-22 17:08:30 +00:00
Jenkins
5cc4d5b530 Merge "auto-generate object docs" 2017-08-18 19:48:08 +00:00
OpenStack Proposal Bot
05c66f5bb6 Updated from global requirements
Change-Id: I5f7fdc751e6a9078eb1eb55f5b5015a56ff668cc
2017-08-18 11:42:09 +00:00
Jenkins
82dce1458c Merge "Use flake8-import-order plugin" 2017-08-17 23:30:07 +00:00
Jenkins
44e154d2d6 Merge "Allow PD as Subnetpool during Subnet creations" 2017-08-17 23:29:49 +00:00
Steve Martinelli
4d7b4efeb5 auto-generate object docs
Change-Id: I832eade2ddab754664e5f57b9764e524e655e616
2017-08-17 16:46:31 -04:00
Akihiro Motoki
0e20212fa9 Revert "Disable karborclient until a fixed version is released"
Fixed karborclient has been released. The problem only exists
in karborclient 0.4.0 and the current version is 0.6.0.

This reverts commit 99a502b203.

Change-Id: Ie28fa1e0502792c87e68ab1c009b3349c739892b
2017-08-17 07:06:11 +00:00
Akihiro Motoki
f3bbf52b3c Use flake8-import-order plugin
In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
It enforces loose checking so it sounds good to use it.
This flake8 plugin is already used in tempest.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Setup for unit tests of hacking rules is tweaked to disable
flake8-import-order checks. This extension assumes an actual file exists
and causes hacking rule unit tests.

Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
2017-08-17 06:55:00 +00:00
Reedip
04ef8a41ac Allow PD as Subnetpool during Subnet creations
This commit now allows user to specify 'prefix_delegation'
as a Subnetpool during Subnet creation by using the new
--use-prefix-delegation option so that the IPv6
prefixes can be delegated to routers set up by the
cloud admins.

Change-Id: I67e5d81c4155db2e3c5c41ee1df77f2d77a17689
Closes-Bug: #1513894
2017-08-17 02:44:44 +00:00
OpenStack Proposal Bot
53bea90a75 Imported Translations from Zanata
For more information about this automatic import see:
http://docs.openstack.org/developer/i18n/reviewing-translation-import.html

Change-Id: I33c68188f316b533cc702e0b3ef97c854681bca1
2017-08-16 07:50:55 +00:00
Jenkins
64d6809c40 Merge "Convert network segment functional tests to JSON" 2017-08-14 16:20:22 +00:00
Dean Troyer
b30f0f3f05 Convert network segment functional tests to JSON
Change-Id: I8dc1e992d54c63c93bbe2bdd7acba61a7a6773d0
2017-08-13 07:55:21 -05:00
Jenkins
d0b0b90711 Merge "Add .htaccess for docs migration" 2017-08-11 15:43:56 +00:00
Dean Troyer
88b31fc12e Update release/stable branch table in docs
Change-Id: I0d18be4f2ed14137010693f41526a261a0acca3b
2017-08-10 16:37:09 -05:00
OpenStack Release Bot
48c7405cca Update reno for stable/pike
Change-Id: Ieea72b22a55b29283705e957a973a46f2e6c5848
2017-08-10 19:31:07 +00:00
Jenkins
06c8845a9f Merge "Add new commands for karbor osc plugin" 2017-08-09 04:50:52 +00:00
Dean Troyer
fd7b4f4912 Add .htaccess for docs migration
Change-Id: I413a6d059f4eb751ca5c8b5a9b61740ac93680b1
2017-08-07 18:07:46 -05:00
chenying
a1af3437dc Add new commands for karbor osc plugin
These command operationlog are implemented in the latest python-karborclient
project.

Change-Id: Icfafcb7cbcc5052f75b5136443935e05e1c9ec84
2017-08-07 17:30:52 +08:00
OpenStack Proposal Bot
a709c151e6 Updated from global requirements
Change-Id: I6f384b021b5ae73152192c5b4c2bab190db88251
2017-08-07 00:53:48 +00:00
yang wang
bd079e5066 Replace guildelines with guidelines
Change-Id: I9c4f15d320e2c506c16634a5a0e2fc324101189a
2017-08-04 19:06:10 +08:00
OpenStack Proposal Bot
6fdce13165 Updated from global requirements
Change-Id: Ie45d9ee68e24806b2411359068b6ec6c44dc5845
2017-07-28 21:47:55 +00:00
OpenStack Proposal Bot
25e6c31d2a Updated from global requirements
Change-Id: I7906433adde40f76eaccdab186e68e0afcbe49af
2017-07-28 05:26:04 +00:00
Jenkins
31ff012f6c Merge "network functest: Remove condition for segment test" 2017-07-28 05:04:11 +00:00
OpenStack Proposal Bot
d25f68f3ba Updated from global requirements
Change-Id: I1cba44152cf17ab3b50e5e3c423c702dbdf5039e
2017-07-27 20:33:15 +00:00
Jenkins
e22fc1fb6b Merge "Use instance variables for subnet tests" 2017-07-27 17:35:22 +00:00
Jenkins
590dc3ed01 Merge "Skip object-store functional tests when Swift is not available" 2017-07-27 15:19:03 +00:00
Akihiro Motoki
198a486413 network functest: Remove condition for segment test
Previously fucntional tests for network segment feature are skipped
as neutron 'segment' API extension was disabled in the gate.
We now enable neutron 'segment' API extension, so we can safely drop
the check for the segment extension from the test code.

Also setup code in test_network_segment is moved from setUpClass to
setUp. There is no good reason to do them in setUpClass and
having them in setUp simplifies the test code.

no user once this commit is applied.

Change-Id: I183310b94d9b6d7f4311a3859b59dc22d36440db
2017-07-27 13:49:03 +00:00
Jenkins
d010c00a15 Merge "Update the documentation link for doc migration" 2017-07-27 13:48:04 +00:00
Gary Kotton
1134249a5e Use instance variables for subnet tests
Commit 78a832441a let to random
failures of test_create_with_tags. This addresses that issue.

Change-Id: I470da7a1863a8c22257b1c27bc6d2b1c45c9cca3
2017-07-26 23:54:35 -07:00
Dean Troyer
022fdb10eb Skip object-store functional tests when Swift is not available
Specifically, in the py3 jobs Swift is not (yet) properly starting as
a py2 service, so we disabled swift in those OSC jobs and need to
skip the object-store functional tests in that case.

Change-Id: I073551c41b7636f04b3ee97dc6fe69630e207b67
2017-07-26 19:17:46 -05:00
Jenkins
86bda36963 Merge "Use *_as_ids instead *_as_list" 2017-07-26 03:58:57 +00:00
Jenkins
f67ebce530 Merge "wrong values in openstack quota show command" 2017-07-25 17:41:46 +00:00
Jenkins
80a9779601 Merge "Add optional parameter "user_id" and "type" to list credentials" 2017-07-25 17:41:39 +00:00
Jenkins
08ffd854e8 Merge "Use identity auth v3 the README examples" 2017-07-25 17:27:32 +00:00
zhanghongtao
470a1f1acf Add optional parameter "user_id" and "type" to list credentials
In keystone version 3.5, "type" optional attribute has been added
to list credentials. This patch add "user_id" and "type" optional
parameter in openstack client.

Change-Id: Ia09ee7c39204fdff2dfd7b9b606d888d007caac5
2017-07-25 09:56:50 -05:00
Akihiro Motoki
78a832441a network tag UT: avoid using mix-in test class
This is a follow-up patch on https://review.openstack.org/#/c/461195/
There is a suggestion to keep test code more straight-forward
and avoid using mix-in to reduce the code complexity.
This commit moves all logic implemented in _test_tag.py
into individual network tests.

Change-Id: I0a9f8c6cd758db9035b0fd60ce4b9bfc791b6cbd
2017-07-25 09:22:29 +00:00
Jenkins
ad21588b20 Merge "Network tag support" 2017-07-25 00:29:57 +00:00
Jenkins
770426d66c Merge "Updated from global requirements" 2017-07-24 17:28:21 +00:00
nidhimittalhada
925776565e wrong values in openstack quota show command
"openstack quota show" shows wrong value in field project
and project_id. project UUID is shown in field project.
and project is coming as None.

Corrected it.

Change-Id: I237e49858feab14ec5e5bc6d8cb79c9f6f5ea9c0
Closes-Bug: #1679906
2017-07-24 11:28:28 +05:30
Hangdong Zhang
37998ad1c2 Update the documentation link for doc migration
Change-Id: I7833e40d66abe233af5a211bcefadc141fe8e54b
2017-07-24 11:33:07 +08:00
Akihiro Motoki
57e5840710 Network tag support
Neutron tag mechanism now supports network, subnet, port,
subnetpool and router. Tag support for more resources is planned.

This commit introduces a common mixin class to implement
tag operation and individual resource consumes it.

To support tag remove, network unset command is added.

Implements blueprint neutron-client-tag
Change-Id: Iad59d052f46896d27d73c22d6d4bb3df889f2352
2017-07-23 21:54:32 +00:00
Jenkins
e889ba1524 Merge "Release note cleanup for 3.12.0" 2017-07-23 19:31:41 +00:00
OpenStack Proposal Bot
45d0809b39 Updated from global requirements
Change-Id: I68530243bdfbcf315b0be5775c08cc26faed4770
2017-07-23 19:08:42 +00:00
Dean Troyer
1f2295cf65 Release note cleanup for 3.12.0
Change-Id: I1fab42256e7b01d2efc23af686554e0325a48af6
2017-07-23 16:51:47 +00:00
OpenStack Proposal Bot
bb59353ee1 Updated from global requirements
Change-Id: Ib6c0fbfc96d79293726ce941ad4becf31ee2ee79
2017-07-23 13:52:35 +00:00
OpenStack Proposal Bot
199c13c836 Updated from global requirements
Change-Id: I09acea781d9df7c88a90c3915724b1245f2e219b
2017-07-22 16:39:06 +00:00
Jenkins
e0d7119c6d Merge "Start using 'cliff.sphinxext'" 2017-07-21 21:46:10 +00:00
Kristi Nikolla
77ff011ced Add domain parameter to Identity Provider
Identity providers are now associated with domains. This change
allows a user to specify a domain by ID or by name when creating
an identity provider. [0]

This also adds the column for Domain ID in listing.
Updating a domain for an identity provider is not supported, so
that isn't changed.

[0]. Id18b8b2fe853b97631bc990df8188ed64a6e1275

Closes-Bug: 1698390

Change-Id: Icc408e2fe88f257d5863bd3df716a777d52befcc
2017-07-21 11:28:57 -04:00
Stephen Finucane
9cfa12df2a Start using 'cliff.sphinxext'
'cliff', the command line library used by 'osc_lib' (and, thus,
'python-openstackclient') recently gained a Sphinx extension to
automatically document cliff commands. This allows us to use the
documentation we already have in code instead of duplicating it in the
documentation.

Introduce the use of this, starting with the 'server' commands. This
requires extending the descriptions for two commands to ensure no
information is lost.

Change-Id: If701af8d5a3f78f4b173ceb476dd0c163be4b6ca
2017-07-21 14:48:44 +00:00
OpenStack Proposal Bot
26ec06e281 Updated from global requirements
Change-Id: I9acdcf3a966dc7c6f92b077848d65f408fdd07eb
2017-07-21 05:07:46 +00:00
Jenkins
d04a7cf92a Merge "Clean up the changes of os.environ in functional tests" 2017-07-21 00:10:54 +00:00
Jenkins
57e7d9fdb3 Merge "Now OSC server create check keys in --nic" 2017-07-20 18:43:18 +00:00
Jenkins
64c458f0ee Merge "Minor followup to network agent docs" 2017-07-20 18:39:12 +00:00
Jenkins
813e49db93 Merge "Enable some off-by-default checks" 2017-07-20 18:08:32 +00:00
Jenkins
e954fe4eed Merge "Add support for virtio-forwarder VNIC type" 2017-07-20 17:15:53 +00:00
Rui Chen
f1d32dbe9b Clean up the changes of os.environ in functional tests
Use fixtures to restore the API version changes of os.environ
in each functional tests, aims to avoid the following test cases
failing in unexpected context.

And make sure setUpClass/tearDownClass call super class's
corresponding methods first.

Change-Id: Ie248fe9d3a9e25f1b076c9f2c363200f29a83817
Closes-Bug: #1696080
2017-07-20 16:39:32 +00:00
Jenkins
ac8cac4b63 Merge "Network L3 Router Commands for OSC" 2017-07-20 16:35:14 +00:00
Dean Troyer
b43b1f8ff2 Minor followup to network agent docs
Change-Id: I2305a22b3bac20cb25c57af68e7625b83aefef52
2017-07-20 10:29:40 -05:00
Jenkins
39673217dc Merge "Fix 'domain' filter not work well in some commands" 2017-07-20 06:16:09 +00:00
Jenkins
b9daff23b9 Merge "Fix column names for server list --no-name-lookup" 2017-07-20 05:17:53 +00:00
Jenkins
6f2d6063ff Merge "Fix dynamic names in network functional tests" 2017-07-20 05:15:03 +00:00
Jenkins
4493740171 Merge "Add server list -n and --no-name-lookup arguments" 2017-07-20 03:43:15 +00:00
Dean Troyer
8d7ee8da0e Fix dynamic names in network functional tests
Move all of the dynamic resource naming in Network functional tests into
setUpClass() methods (if they exist) rather than assigning those names
at load-time.

Change-Id: Ic550ff7d40c2b3ca5128cacccbe331790d6ae340
2017-07-19 16:33:54 -05:00
Akihiro Motoki
99a502b203 Disable karborclient until a fixed version is released
Even though a fix for bug 1705258 has been merged in
python-karborclient, it will take some time to release it and
update the upper-constraints.txt, so I think it is better to
exclude karborclient from the plugin commands doc temporarily.

Change-Id: I092b37b30df785159495c2d681162e144cfe4083
Related-Bug: #1705258
2017-07-19 16:44:33 +00:00
Jan Gutter
cf5dfa77e1 Add support for virtio-forwarder VNIC type
* This patch adds support for the virtio-forwarder VNIC type.
  * The virtio-forwarder VNIC type has been added as another option for
    setting the --vnic-type property on the "port set" and
    "port create" commands. This requests a low-latency virtio port inside
    the instance, likely backed by hardware acceleration. Currently the
    Agilio OVS external plugin provides support for this, with support from
    other vendors following soon.
  * Corresponding neutron-lib change:
    https://review.openstack.org/#/c/483530/
  * Nova spec for Agilio OVS enablement:
    https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/netronome-smartnic-enablement.html

Change-Id: Idbc8071afe95f8594b40e2f93e5411e7185f946f
Signed-off-by: Jan Gutter <jan.gutter@netronome.com>
2017-07-19 14:41:04 +02:00
jiangpch
a01bf55d20 Fix 'domain' filter not work well in some commands
The 'domain' filter not work well in commands 'project show',
'user show' and 'user set'.

Depends-On: I490900d6249f01654d4cba43bddd3e7af7928a84
Closes-Bug: #1704097
Change-Id: Ib4f47cbaba27eb56c4a41d187fee74a995e62dc7
2017-07-18 23:01:22 +00:00
Dean Troyer
2689984ba7 Fix column names for server list --no-name-lookup
When --long is not present change the 'Image Name' column to
'Image' and add the 'Flavor' column.  These columns will contain
Names unless --no-name-lookup is specified when they will contain IDs.

Change-Id: I92cfb22136aee32616894e60e9227b4da185da99
2017-07-17 16:51:10 -05:00
OpenStack Proposal Bot
db7d0723f0 Updated from global requirements
Change-Id: I32899a8110c6c4442c454e122d5ed4eedc76a938
2017-07-13 14:24:35 +00:00
Jenkins
894df67c67 Merge "Add 'data_plane_status' option to Port classes" 2017-07-13 02:44:35 +00:00
nidhimittalhada
bca8d57eb3 image-list should support filters 'name','status'
nova api support parameters like 'name', 'server', 'status',
etc in image-list(). So openstackclient should support this too.

DocImpact
Closes-Bug: #1698742
Change-Id: Ice66b409f989e6785aa3b2d42f2fdbf6e23fa0aa
2017-07-12 22:50:17 +00:00
Carlos Goncalves
1ae904a491 Add 'data_plane_status' option to Port classes
Adds 'data_plane_status' option to SetPort and UnsetPort classes.

Closes-Bug: #1684989
Change-Id: I26e23b551afb8c37e6babdea1655efb7c5c6873b
2017-07-12 22:50:09 +00:00
Akihiro Motoki
3cba09e767 Fix unit test failures related to new os-client-config and osc-lib
[breakage related to os-client-config 1.28.0]
os-client-config 1.28.0 add a check if filebased and envvars are
both used. This check causes OSC unit test failure.

OSC now instantiates OpenStackConfig twice as a workaround.
The unit test mocks _load_config_file() and it returns a config dict,
but os-client-config OpenStackConfig.__init__ updates the dict returned.
As a result, when OpenStackConfig is instantiated second time,
the mock of _load_config_file returns a modified version of the config
dict. This hits the new check in os-client-config 1.28.0.

This commit changes the mock to use side_effect rather than return_value
to ensure the original dict is used.

[breakage related to osc-lib 1.7.0]
The change in osc-lib 1.7.0 added "if" logic to avoid calling get() twice.
In tests.unit.volume.test_find_resource, kwargs is empty dict in find_resource(),
so the second call to get() is NOT called now.
Removing the second elements of side_effect addresses the unit failure.

Co-Authored-By: Rui Chen <chenrui.momo@gmail.com>
Change-Id: Ib9d14661b2755bbd6619e15c0d9023fbc9d27d70
Closes-Bug: #1703782
Closes-Bug: #1703783
2017-07-12 12:26:00 +00:00
Ankur Gupta
18c532377a Network L3 Router Commands for OSC
Implements: blueprint network-l3-commands

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: Ia24d76227e164062e89a74c1621b8acb830b26cf
2017-07-11 08:17:09 +00:00
Boris Pavlovic
2c57f7bfb2 Add server list -n and --no-name-lookup arguments
Remove translation of Image ID and Flavor ID to Image and Flavor names

In large environments amount of images can be very large (thousands)
Which requires ~hundreds of requests to Glance to get all images
(by default client request only 20 images)
As a result listing even few servers is going to take minutes

This patch allows to avoid these queries by not doing translation,
which allows one to get information about servers in seconds.

Change-Id: I4ae00e6324a41c4c79bf5b620179dae99aea5431
2017-07-10 16:20:45 -07:00
Akihiro Motoki
faf6e16120 Use openstackdocstheme in release note
In the release notes build, openstackdocstheme is specified
in the sphinx extension list, but it is actually not used.
This commit configures openstackdocstheme as suggested in
the openstackdocstheme document.

Also specifies display_toc False in html_theme_options.
This prevents openstackdocstheme to add the local TOC automatically.
OSC has several releases during a single development cycle and
it leads to a long TOC at the top of individual pages.
It loses the readability and we can see version numbers in the
left sidebar, so we can safely disable the local TOC in
the release notes.

[1] https://docs.openstack.org/openstackdocstheme/latest/

Change-Id: Iae08d309f7589bb13a1766f6fded70673ba24047
2017-07-06 17:56:01 +00:00
Jenkins
91cc731187 Merge "Allow objects to be streamed to stdout" 2017-07-06 15:24:31 +00:00
yushangbin
eb19c167ea Add the other commands for karbor osc plugin
These commands are implemented in the latest python-karborclient project.

Change-Id: I1f57656cbad8f04b26e5210043b1fa979116f053
2017-07-06 15:26:24 +08:00
Honza Pokorny
ae35a29169 Allow objects to be streamed to stdout
Change-Id: Icd8de6b2122fe77926d93da9bda08f56c3672a7a
2017-07-05 20:08:18 -03:00
Jenkins
f691b3220c Merge "Add new parameter "is_default" to Network QoS policy." 2017-07-05 20:57:58 +00:00
Jenkins
f5414fbe91 Merge "Add missing barbican commands" 2017-07-05 20:52:42 +00:00
Rodolfo Alonso Hernandez
c17819ab58 Add new parameter "is_default" to Network QoS policy.
Add a set of exclusive parameters to the Network QoS policy:
  --default: makes this policy the default policy for
             the project to which the qos policy belongs.
  --no-default: unset the property.

Closes-Bug: #1639220
Depends-On: If5ff2b00fa828f93aa089e275ddbd1ff542b79d4
Depends-On: Ibe7b7881cb190bfd5582f35b6de51a8bc21135de
Change-Id: I0269b837dc29bbd8ee2089d847cadb72d800fa30
2017-07-05 13:34:33 +00:00
Javier Pena
79b992b53b Fix man page build
https://review.openstack.org/473964 moved the man page rst from
the doc/source/man directory into doc/source/cli/man, so we need to
adjust the path in conf.py to avoid issues when running:

python setup.py build_sphinx -b man

Change-Id: I1ab09bf298beef756b233c7e17bf052f7af4de51
2017-07-04 16:54:19 +02:00
Jeremy Liu
2e83c987f1 Add missing barbican commands
Change-Id: Id5be173799cd65e80a52f01f77d1afccf089412c
2017-07-04 10:29:14 +08:00
Jenkins
52af8fbc05 Merge "Added 'openstack image set --visibility'" 2017-07-01 00:26:36 +00:00
Jenkins
fc051b145b Merge "Add python-octaviaclient plugin" 2017-06-30 21:28:33 +00:00
Jenkins
1cb08a099c Merge "Show neutron tags in OSC network show" 2017-06-30 21:21:37 +00:00
M V P Nitesh
3468ea1ca4 Added 'openstack image set --visibility'
This feature will allow image owners to share images across multiple
tenants/projects without explicitly creating members individually
through the glance API V2. “Community images” will not appear iu
user's default image listings

Change-Id: Ic02bf44cca5d6d793d68a8737d3cfe3f44407d88
Closes-Bug: #1626837
2017-06-30 20:35:01 +00:00
Jenkins
22bed5d1f0 Merge "Remove inaccurate mapping of 'host-meta' in csv" 2017-06-29 22:49:13 +00:00
Michael Johnson
2bd124731a Add python-octaviaclient plugin
This patch adds the "loadbalancer" commands to the docs and sets
up the document generation for the python-octaviaclient plugin.

Depends-On: Ib123383c5f6904b4b00831e8cc7aaa180bd4a506
Change-Id: I48939cc3653cd379a328e0a0973d075019d22b00
2017-06-29 17:21:11 +00:00
wingwj
2b7cb1559b Remove inaccurate mapping of 'host-meta' in csv
Now we don't have a similar command to 'nova host-meta' in osc,
the 'host set/unset' in osc is used to manage host properties.
Need to remove the inaccurate mapping in nova.csv.

Change-Id: I291174a29c8e3419b62d47264dedf176262a816c
Closes-Bug: #1690902
2017-06-29 16:54:59 +08:00
OpenStack Proposal Bot
ca4b9be8a2 Updated from global requirements
Change-Id: Ifc46dfac0578144329675c2c75da1e6ddfa862a3
2017-06-29 02:28:44 +00:00
Jenkins
002a9b9972 Merge "switch to openstackdocstheme" 2017-06-27 21:10:47 +00:00
OpenStack Proposal Bot
1405818b77 Updated from global requirements
Change-Id: I6ab372eddd2eafc789e4fc7e16f36d7b0f390f2b
2017-06-27 12:22:21 +00:00
Doug Hellmann
cf60df4261 switch to openstackdocstheme
Change-Id: Iee591504ba5d7506ba41a9faaa1c293a5fe2db6a
Depends-On: Ifc5512c0e2373cf3387e0e0498268eab092e52bb
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-06-26 17:01:19 -04:00
Samuel de Medeiros Queiroz
6eb1551573 Use identity auth v3 the README examples
Identity auth v3 is the default in devstack. The keystone team
advertises all deployments to migrate over to v3.

If we get our examples to use v3, that would be a great help.

Change-Id: I8bd4cbf16cd42fa1654776f19bf113e3c94e25cf
2017-06-25 15:46:24 -04:00
OpenStack Proposal Bot
c0719c36d1 Updated from global requirements
Change-Id: I115d686010bd79ea49786f46decd6ed6256f6cb9
2017-06-24 12:15:02 +00:00
Doug Hellmann
0ddda620dc update the docs URLs in the readme
Change-Id: Id1168e1003f62e08d2da338cb1b81bc2b7547bfc
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-06-23 11:57:39 +02:00
Doug Hellmann
e7807bc0ed move auto-generated api docs into contributor tree
Change-Id: I2e75d3014bd2252af8c01566c0ec6787608e3996
Depends-On: I2bd5652bb59cbd9c939931ba2e7db1b37d2b30bb
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-06-23 11:57:31 +02:00
Doug Hellmann
9599ffe65d reorganize existing documentation according to the new standard layout
Move existing content around based on the doc-migration specification.

Replace :doc: markup with :ref: to have sphinx keep track of where the
files move and generate valid hyperlinks.

Add a few toctrees and index pages for the new directories.

Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454
Change-Id: I253ee8f89d3ec40e39310c18bb87ed1d3d5de330
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-06-23 11:54:32 +02:00
blue55
20c23d8ccb Enable some off-by-default checks
Some of the available checks are disabled by default, like:
[H203] Use assertIs(Not)None to check for None

Change-Id: I59dafb62cedc5217b6e5eb6efb997a9ee3c29bbb
2017-06-23 16:31:48 +08:00
M V P Nitesh
fcafd987b0 Now OSC server create check keys in --nic
Now OSC command to create server will check all the keys in --nic
and throws an exception if the key is invalid key.

Change-Id: I5482da0ae63d6d4298aa614e4d09bb0547da9ec3
Closes-Bug: #1681411
2017-06-23 13:20:43 +05:30
Jenkins
19c8cabeca Merge "When creating a trust, send role_ids instead or role_names" 2017-06-22 19:53:03 +00:00
Jenkins
fe82f4b281 Merge "Add direction field to QoS bandwidth limit." 2017-06-22 19:02:35 +00:00
Jenkins
ef25135e7a Merge "Add project purge command to osc" 2017-06-22 18:10:37 +00:00
Jenkins
244ac70ae9 Merge "Don't show hint about vlan transparent in network set" 2017-06-22 17:10:23 +00:00
Kristi Nikolla
da53c2b334 When creating a trust, send role_ids instead or role_names
This changes create a trust to use ids instead of names because of
the possibility of roles sharing a name. Even if the user
uniquely identified a role by inputting the id, the request sent
to the identity service would used the name, therefore the command
would fail in the case that two roles share a name.

This does not change how trusts are displayed during trust list or
trust show, a name will still be shown instead of an id.

Depends-On: I38e0ac35946ee6e53128babac3ea759a380572e0

Change-Id: I5bdf89f1e288954a7f5c2704231f270bc7d196f5
Closes-Bug: 1696111
2017-06-22 17:08:01 +00:00
Rodolfo Alonso Hernandez
ccb743cf0f Add direction field to QoS bandwidth limit.
This patch enables the direction ('ingress'/'egress') field
on the QoS bandwidth limit rule object and CRUD commands.

Closes-Bug: #1614121
Depends-On: Ia13568879c2b6f80fb190ccafe7e19ca05b0c6a8
Depends-On: I90c412a5c8757b3ffe8abfc1165a70bdb8744702
Change-Id: Ic6981474f22efbf294ac11c2e0304b04494a1bbe
2017-06-22 15:59:37 +00:00
M V P Nitesh
4c2eb2bd8b Show neutron tags in OSC network show
Now tag information of the network is displayed when the user
tries to see the network details using the command
openstack network show <net-id>

Change-Id: I587d2bca37b8dbef4400db3d8ace3c81d87e2db3
Closes-Bug: #1695783
2017-06-22 12:58:18 +05:30
chenying
7653cff5e6 Add support for Karbor Plugin
The patch[1] about OSC plugin has been submitted to
karbor project. And the plan list commend has been
implemented.

With more dataprotection commands being supported,
another patch adding more commands to the docs will be
proposed later.

[1] https://review.openstack.org/#/c/473508/

Depends-On: I4dfac08fd2b04f9ac254d3aa8fdadc3a1691de0a
Change-Id: I2266525650f5c2e241373493dcd09474478c2ba6
2017-06-15 19:10:34 +08:00
Steve Martinelli
227d4c64ef Add project purge command to osc
See the initial implementation:
  https://github.com/openstack/ospurge/blob/master/ospurge/client.py

Partial-Bug: 1584596

Change-Id: I3aa86af7c85e7ca3b7f04b43e8e07125f7d956d1
2017-06-13 10:26:35 -04:00
Hong Hui Xiao
2b66c71a7c Don't show hint about vlan transparent in network set
Update this attribute is not allowed in neutron.

Change-Id: I38010b26e116246c13dbb6cc6a777d2f22f6dc30
Closes-Bug: #1691776
2017-06-12 19:20:30 +08:00
Reedip
eb793dc8c6 Add default-quota to subnet pool commands
Add --default-quota option to subnet pool create and set commands.

Setting default-quota back to None may break the current Neutron
behavior, therefore support for Unset command is not provided in
this patch.

Neutron API:
a0e0e8b668/neutron/api/v2/attributes.py (L239)

Closes-Bug: #1667294
Change-Id: Ia4e7c23a49e91a090133c729353cdb8e62bc5674
2017-06-12 02:52:28 +00:00
OpenStack Proposal Bot
e54fcd0a5c Updated from global requirements
Change-Id: Ic49fc0fcd068d03f2dad5b49e3de4d98702866dc
2017-06-10 21:48:48 +00:00
phil-hopkins-a
40adedf6cd Fix Mapping Guide Error
The mapping guide showed that the openstack command for tokek-get
issue token. It should have been token issue.

Change-Id: I233d45ab0f4229caa9a725c931f11b3374270822
Closes-Bug: 1696246
2017-06-09 14:07:26 -05:00
OpenStack Proposal Bot
f403ff9e9c Updated from global requirements
Change-Id: I273241692ee85f9d9e239c2ba7df3c683a429e98
2017-06-08 16:28:14 +00:00
Jenkins
ee59989103 Merge "volume functest: ensure snapshots deleted when volume delete" 2017-06-06 04:48:46 +00:00
Akihiro Motoki
eeb614c477 volume functest: ensure snapshots deleted when volume delete
Deleting snapshot may take time. The current volume API does not allow
to delete volumes with snapshots, so if deleting snapshot may take time,
a delete request for a parent volume will fail.
This sometimes causes functional test failures in slow environments.

wait_for_status() checks whether volume status is in error statuses
but previously the expected error status was wrong. Cinder API uses
lower case as volume status, so it did not work expectedly.

Change-Id: I095894ba39f23bf81d71351818d24dbb5ca459fb
2017-06-06 01:14:20 +00:00
OpenStack Proposal Bot
c912717e42 Updated from global requirements
Change-Id: If85aea646119bf12090074edf198f64a8719c949
2017-06-05 21:58:44 +00:00
Jenkins
c5524c80be Merge "Replace "Display Name" by "Name" in volume list" 2017-06-05 20:10:56 +00:00
OpenStack Proposal Bot
adac738f17 Updated from global requirements
Change-Id: Iad391c3f10f90cd238de99e6ca94c3de0edc986b
2017-06-02 22:07:23 +00:00
OpenStack Proposal Bot
16eedeb965 Updated from global requirements
Change-Id: I5b8daf5b9e177b368678a605997e52eff04a0999
2017-06-01 22:21:20 +00:00
Jenkins
3707717f8f Merge "To display image size in human friendly format" 2017-06-01 17:48:11 +00:00
OpenStack Proposal Bot
d034b980ab Updated from global requirements
Change-Id: Ica0de1e6a275fee4761dca1f128caf073bcfb92b
2017-05-31 16:45:37 +00:00
Vu Cong Tuan
b52bbe1eec Trivial fix typos
Change-Id: I72a1da209df38e226ec02d9dbd0142ed4020c0d2
2017-05-30 16:38:27 +07:00
Rui Chen
6aceca218a Replace "Display Name" by "Name" in volume list
Current "volume list --name" command use "display_name" as search_opts
to send to cinder API, and show the result table with "Display Name"
column title in osc, cinder list API support "name" as search opts too,
and there is "name" attribute in volume response body, so we can replace
all "Display Name" by "Name" in order to keep "volume list" command
consistent with other commands, like: server list, network list and so
on, only use "Name" attribute for all objects.

Support a mapping for volume list -c "Display Name" (Volume v1 and v2)
and volume create/show -c "display_name" (Volume v1) for minimal
backward compatibility until R release.

Change-Id: I120be0118e7bb30093b4237c5eeb69a9eedef077
Closes-Bug: #1657956
Depends-On: I1fb62219b092346ea380099811cbd082cae5bafe
2017-05-26 11:37:09 +08:00
Jenkins
b78153aec4 Merge "Add functional test for volume service" 2017-05-25 19:53:51 +00:00
Jenkins
5f41f651e5 Merge "Convert volume functional tests into JSON format" 2017-05-25 19:30:17 +00:00
Jenkins
fdb70bb49b Merge "JSON-ify image functional tests" 2017-05-24 19:17:53 +00:00
Jenkins
4a27f51446 Merge "Use _get_token_resource in role assignment list" 2017-05-24 19:17:03 +00:00
Dean Troyer
6425fc3059 JSON-ify image functional tests
Change-Id: Ica91eddfdebe68449544feb5e29113db075bf11c
2017-05-24 11:14:28 -05:00
David Rabel
0ad6b6b2e0 Use _get_token_resource in role assignment list
If project matches the project from access token,
we do not have to send an API request to /projects?name=...,
because the project ID is already known.
This API request may require additional permissions, so
we want to avoid it, if possible.

Change-Id: Ice1af8686bceea6b67229dcab7cf82eef821163e
Closes-Bug: #1658189
2017-05-23 17:16:41 +02:00
OpenStack Proposal Bot
5df961a1f7 Updated from global requirements
Change-Id: Ieb595ddda18a579990d67ca00893280347edc629
2017-05-23 11:59:47 +00:00
Jenkins
205d6e408a Merge "Refactor Extension show and list command" 2017-05-22 23:35:59 +00:00
Jenkins
3fabbe9b39 Merge "Create server with security group ID and name" 2017-05-22 23:09:02 +00:00
Jenkins
78cee3fff7 Merge "Correct the "extra spec" command openstack" 2017-05-22 22:08:59 +00:00
Jenkins
7c43c1a3c3 Merge "Convert image functional tests into JSON format" 2017-05-22 20:49:10 +00:00
Jenkins
2be3de2df4 Merge "Make block-device-mapping more stable and clear" 2017-05-22 20:41:43 +00:00
Rui Chen
45496feee6 Create server with security group ID and name
Both resource ID and name are supported to identify an object
in openstackclient to make user easy to input, for security group,
nova only support security group name in API when launch a new server,
this patch convert ID to name, then pass name to nova API, and check
the security group exist before creating server.

Change-Id: I1ed4a967fb9de3f91c8945a1ef63f6c7b6b2dfb2
Closes-Bug: #1687814
2017-05-22 20:32:01 +00:00
Ankur Gupta
acc2d106ab Refactor Extension show and list command
1.keep the column display order consist in extension list with
  and without "--long" option.
2.rework for network extentsion list, openstacksdk return object,
  so the logic should be same with other service.
3.add some unit test cases, like: extension list --network --long,
  extension list --network --compute, to cover regular use cases.
4.raise exact exception when network extension don't exist, avoid
  internal TypeError in "extension show" commands.

Change-Id: I2e23ced80d8da8aa1106b22472db850367b351ce
Closes-Bug: #1689233
2017-05-18 11:33:45 +08:00
OpenStack Proposal Bot
411cda722b Updated from global requirements
Change-Id: I32427e2a3b8012ed516ecaf23b6881eddc28cecb
2017-05-17 03:58:25 +00:00
Akihiro Motoki
332671f92a Convert image functional tests into JSON format
Change-Id: Ic8eb72e8f89e5e40cf2b7594a196bb31d38e6b04
2017-05-17 03:53:08 +00:00
Akihiro Motoki
62c793c7e4 Convert volume functional tests into JSON format
volume_type and transfer_request func tests have not been
converted into JSON func tests. This commit converts them
into JSON format.

Change-Id: I56820c4e15bda95e911e57657c1ff5437daf83ae
2017-05-17 01:50:21 +00:00
Rui Chen
7a7bb06377 Make block-device-mapping more stable and clear
The patch fix the following issues:

1. ValueError is raised if input don't contain "=". Sometimes the whole
"server create" command is very complex, it's difficult to find out root
reason directly.
2. Don't support to add block device from snapshot, like:
--block-device-mapping
vdb=0c8ae9d8-cadc-4a23-8337-4254614d277e:snapshot:1, it's supported by
novaclient, but not in osc.
3. If input "vdb=", not add any mapping information, the server will be
launched successfully, not raise error message to let use add
volume/snapshot id, just ignore "--block-device-mapping" option.
4. The help message of "block-device-mapping" option is so simple, need
to add some details about how to add <type>, <delete_on_terminate>
contains.

Change-Id: Ib7f7a654c3dc2a8272545f168b4c4ced230ce39e
Depends-On: Ib37913891bbf7a31b570404c4668c490d5ac859b
Closes-Bug: #1667266
2017-05-17 01:42:12 +00:00
caoyuan
3896d28de8 Correct the "extra spec" command openstack
Change-Id: Ia348b66a6a4340da8e9d07256a0c141792708cf6
2017-05-17 01:16:04 +08:00
OpenStack Proposal Bot
0181de38af Updated from global requirements
Change-Id: I6210e31952a6c4b6a07f5ea357500130d41dacd6
2017-05-15 00:54:47 +00:00
Jenkins
8770b6ed5c Merge "Ignore more exceptions in quota list" 2017-05-11 19:18:36 +00:00
Jenkins
96a3bae3c1 Merge "Rework floating ip functional tests" 2017-05-11 14:25:34 +00:00
Dean Troyer
e8f3103cc1 Ignore more exceptions in quota list
Additional exceptions can be thrown here, ignore additional project
lookup exceptions, but still not all.  Server failures are still
interesting, for example.

Change-Id: I9a750ae8e8efa29a36bbd1e34b50b6ace0658260
2017-05-11 08:47:37 -05:00
Dean Troyer
6f31634f17 Rework floating ip functional tests
Regualr expresstions were an interesting diversion, get rid of them
from the functional tests.  It did lead to better structure...

Change-Id: I1ff32ad7715ebd88401925ce3f6c412a66e82566
2017-05-10 09:48:38 -05:00
Jenkins
21e47e4684 Merge "Revert "Fix port command for SDK >0.9.10"" 2017-05-07 15:30:23 +00:00
Vasyl Saienko
c69304e3d3 Do not always init compute_client when doint port list
This patch ensures that compute client is initialized only when needed
(--server arg is passed) to openstack port list command. Otherwise it
leads to failures on installations without Nova.

Change-Id: I102683461daa2f7d05dd9d7a3ec72de551c65ca9
Closes-Bug: #1688194
2017-05-04 09:44:42 -05:00
Dean Troyer
07a4363e99 Skip floating ip attach functional test on nova-net
As of Ocata release Nova forces nova-network to run in a cells v1
configuration.  Floating IP and network functions currently do not
work in the gate jobs so we have to skip this.  It is known to work
tested against a Mitaka nova-net DevStack without cells.

Change-Id: I74f67ac8eb12c7a649ddcbd7979cf745fb35cc0c
2017-05-03 14:41:35 -05:00
OpenStack Proposal Bot
941e189ac1 Updated from global requirements
Change-Id: I9a60f1b0db78ed188966287939dbd8a6f82c1682
2017-05-03 12:23:14 +00:00
Jenkins
1f48605a91 Merge "Explicitly set 'builders' option" 2017-05-03 05:09:37 +00:00
Dean Troyer
d930b043ee Funcional tests: quota list
The quota list tests have a race in them where occasionally a project is
deleted in another test between the time that quota list gets a list of all
projects and it gets the quota for the projects from the service; the get
quota call fails on the non-existant project.

The quota list functional tests have been substantially re-written to
properly test the exception handling.

Change-Id: I71e6bbb5d46fcea4718a5a870f9a66a2c20fff0f
2017-05-02 14:09:16 -05:00
Dean Troyer
346ac9da62 Nova-net functional tests: aggregates
Nova-net requires a cells v1 configuration to run as of Ocata, but
aggregates and cells v1 are not golfing buddies, so don't let them
meet on the back nine.

Skip the aggregate add/remove host commands in the cells v1 config,
leave the others because they should work, just not be very useful.

And format things consistently.

Change-Id: I131d9f883cb7aca53ad82fb7d5fc6ee1c1e7d923
2017-05-02 14:09:16 -05:00
Dean Troyer
983cccb662 Functional tests: Identity v2 and DevStack
DevStack master (as of 01May2017) no longer sets up an Identity v2
admin endpoint, so we need to skip those tests going forward and cover
them via a specific leagacy job.  This does the detect-and-skip.

Change-Id: Ib9ab32b6bc84ec7d13508094ad6f83995d8d7bc1
2017-05-02 10:32:21 -05:00
OpenStack Proposal Bot
1b9cf82b42 Updated from global requirements
Change-Id: I5215bae5234dcef448c6c5b824c506f80dd1c5a8
2017-05-01 14:07:49 +00:00
Jenkins
a2b69886a4 Merge "Nova net functional tests round 3" 2017-04-29 03:44:49 +00:00
Jenkins
524b2b36ff Merge "Fix volume qos spec list" 2017-04-29 03:25:55 +00:00
Dean Troyer
2c5405ed5e Fix volume qos spec list
This has been sporadically failing in functional tests due to the way
the volume qos spec list command calls get_associations() for each spec.
When tests run in parallel occasionally a spec from another test is present
in the list returned and is deleted before the get_associations() call is
made, causing a NotFound exception.  We should just keep going when this
occurs.

* make v1 match v2
* add tests to ensure the exception is being caught and handled

Closes-Bug: #1687083
Change-Id: If2d17c1deb53d293fc2c7f0c527a4e4ef6f69976
2017-04-28 16:06:00 -05:00
Dean Troyer
190711ecd7 Nova net functional tests round 3
* network segment
* network service
* port
* router
* security group
* security group rule
* subnet
* subnet pool
* extension
  The extension tests were duplicated to have both compute and network
  extensions tests so the nova-net case will still exercise the extension
  commands.

Also clean up formatting from previous reviews to make the Network functional
tests look and act consistently.

Change-Id: I286c40572faa31ddcef595cec740da933b2defc1
2017-04-28 14:40:45 -05:00
Jenkins
efcf3b22ad Merge "Fix Nova-net netowrk commands" 2017-04-28 19:18:03 +00:00
Dean Troyer
dd7da49325 Nova net functional tests round 2
* floating ip
* ip availability
* network qos policy
* network qos rule
* network qos rule type
* network rbac

Change-Id: Id3946bdff43bfef3a1d879c058bde4792bd299c6
2017-04-28 09:46:51 -05:00
Dean Troyer
e0d1af94a1 Nova net functional tests round 1
* address scope
* network agent
* network flavor
* network flavor profile
* network meter
* network meter rule

Also create a new common network functional test class
NetworkTests to house the setting of haz_network in a single place.
The individual test skipping stays in the final classes to re-enforce
the idea that some tests work with both Nova-net and Neutron.

Change-Id: Ie3910231c6fc9e2031438c599afa904f43c874a7
2017-04-28 06:39:21 -05:00
Dean Troyer
589a65c3fe Fix Nova-net netowrk commands
In cleaning up functional tests for nova-net, I discovered some
problems in network create:
* --subnet option is required in network create command
* Switch API to use /os-networks rather than /os-tenant-networks as this
  is what we were actually using via novaclient
* Fix functional tests for nova-net
* Normalize some private function names in network/v2/network.py

Change-Id: I426b864406756d58d140575a3a45ee9aee67ce84
2017-04-27 20:36:00 +00:00
Jenkins
7b609ebd55 Merge "Fix server create with nova-net" 2017-04-27 03:06:50 +00:00
Jenkins
19a7081aa0 Merge "Fix quota functional tests for nova-net" 2017-04-27 03:03:08 +00:00
Dean Troyer
871450abcd Fix quota functional tests for nova-net
We need to skip some functional tests when testing against a nova-net cloud
so add the bits to detect that.

Also JSON-ify the quota functional tests and add the skips for nova-net.

Change-Id: Ibfeeb3f967f34c98e80271a8214cf95dc50407f1
2017-04-26 23:52:34 +00:00
Dean Troyer
bffc98e4e5 Fix server create with nova-net
A Neutron-ism slipped by in server create.

Change-Id: Id590d7f93df2a41d7bd7617459a2af159a6f8071
2017-04-26 18:49:50 -05:00
Jenkins
7939fea6e7 Merge "Updated from global requirements" 2017-04-26 23:40:25 +00:00
Jenkins
b6087cd284 Merge "Functional test for subnet_pool" 2017-04-26 23:23:01 +00:00
OpenStack Proposal Bot
b38261e84b Updated from global requirements
Change-Id: Ib3ea4225636bfa815f7cf60481d2adc07077123c
2017-04-26 19:38:28 +00:00
Jenkins
0a0bcbbda2 Merge "Remove ipdb installation in tox debug section" 2017-04-26 19:29:43 +00:00
Jenkins
a28364a37a Merge "Fix NoneType error for volume snapshot create command" 2017-04-26 19:08:11 +00:00
Jenkins
95736cebc3 Merge "SDK refactor: Set "is_admin_state_up" for network agent" 2017-04-26 18:50:35 +00:00
jiahui.qiang
d519911c43 Functional test for subnet_pool
Refactor functional tests for testing more command options.

Change-Id: I0c9c3b04dd2b79766a8fe82cbc5315c030f4784d
2017-04-26 12:51:58 -05:00
Huanxuan Ao
1c49a1f01d Fix NoneType error for volume snapshot create command
In volume snapshot command, <volume> is the same
as <snapshot-name> when --volume is not specified,
but <volume> cannot be None, so when <snapshot-name>
is not specified (<snapshot-name> is None), a NoneType
error appears.
So make <snapshot-name> no longer optional, it should
be always present.

Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f
Closes-bug: #1659894
2017-04-26 11:07:08 -05:00
Jenkins
bf1f47c1be Merge "Make test_server.py more elegant and simple" 2017-04-25 15:24:07 +00:00
Jenkins
7977f7df18 Merge "Add --network and --port to server create" 2017-04-25 13:54:46 +00:00
Dean Troyer
ef99f44462 Improve no-auth path
The commands that do not require authentication sometimes still need
to call ClientManager.is_network_endpoint_enabled() to see if Neutron
is available.  Optimize the paths a bit to skip auth when it is not
necessary; the upshot is Neutron will be assumed in these cases now.

This gets a LOT cleaner when it appears is a future osc-lib.

Change-Id: Ifaddc57dfa192bde04d0482e2cdcce111313a22a
2017-04-24 18:57:10 -05:00
Rui Chen
af435ee0a8 Remove ipdb installation in tox debug section
The lastest ipdb depends on ipython 6.0, but ipython 6.0
only can be installed in python 3.3 and above, see
http://paste.openstack.org/show/607632/ . If we try to
run "tox -e debug" in python2.7, the install error is raised
and block the function. Remove the ipdb installation, it's
not necessary, we can use pdb to replace.

Change-Id: Ib47bb5925b7a5b1d3a319b58fa219c1b57dccb93
2017-04-24 15:06:26 +08:00
David Rabel
6dc17bb1fb Make test_server.py more elegant and simple
Use only one line for mocking network resources like ports
and networks in test_server.py.

Change-Id: I451a504c3afdd365e64d66079516ec6308c206db
Depends-On: I624b1bc557a195bdf8a7c5a32dc0e72a6fa8b075
2017-04-21 13:06:20 +02:00
Huanxuan Ao
db6081fb80 Fix network list functional test
An error in network func test broke our CI,
looks like the "is_default" should be "False"
by default for now.

Change-Id: I021eb8abd9bdf55c7c06031152c107312f104b34
2017-04-19 21:47:57 +08:00
Stephen Finucane
e611aa6314 Explicitly set 'builders' option
An upcoming release of pbr will require explicitly stating which
builders are requested, rather than defaulting to html and man. Head off
any potential impact this may cause by explicitly setting this
configuration now.

Change-Id: I243ca33f5459009f9a9670ec5e0ad67b04760f35
2017-04-19 10:30:21 +01:00
Dean Troyer
107cad200a Low-level Compute v2 API: floating ip pool
api.compute.APIv2 floating ip pool function.

novaclient 8.0 is now released without support for the previously
deprecated nova-net functions, so include a new low-level REST
implementation of the removed APIs.

Also includes a handful of cleanups that the previous security group and
floating IP reviews missed.

Change-Id: I20116ec4fc1113857d8d917bfb30fa3170d05b9f
2017-04-18 08:57:34 -05:00
Jenkins
7e1350815e Merge "Clean up password prompt work-arounds" 2017-04-18 13:35:53 +00:00
Dean Troyer
b2783dc3c4 Low-level Compute v2 API: network
api.compute.APIv2 network functions.

novaclient 8.0 is now released without support for the previously
deprecated nova-net functions, so include a new low-level REST
implementation of the removed APIs.

Change-Id: If230f128e91cda44461fe93c976cac2aecec2252
2017-04-17 19:45:21 -05:00
Dean Troyer
6f473be588 Split network tests
Split up the network unit tests between compute and network APIs
into separate files in preparation for reworking the compute (nova-net)
implementations to deal with the removal of deprecated nova-net
support in novaclient 8.0.0.

No code changes are intended here, just splitting two files into four.

Change-Id: I2d001118af436f95025d2851341f8ca802e78830
2017-04-17 17:11:43 -05:00
Jenkins
b0ce95745d Merge "Low-level Compute v2 API: floating ip" 2017-04-17 21:14:05 +00:00
Jenkins
18206a9224 Merge "Low-level Compute v2 API: security group rules" 2017-04-17 19:40:34 +00:00
Jenkins
578950335f Merge "Update to tox.ini" 2017-04-17 17:44:26 +00:00
Jenkins
9a1c9cabd4 Merge "Low-level Compute v2 API: security group" 2017-04-17 17:35:33 +00:00
Jenkins
62d71aa243 Merge "Allow override of distributed router flag" 2017-04-17 15:18:20 +00:00
OpenStack Proposal Bot
b168f2d998 Updated from global requirements
Change-Id: Icd26cb6d2525ff1736923c39e9c64eb12f6d39b6
2017-04-12 04:21:53 +00:00
Dean Troyer
e6ea45b283 Low-level Compute v2 API: floating ip
api.compute.APIv2 floating ip functions.

novaclient 8.0 is now released without support for the previously
deprecated nova-net functions, so include a new low-level REST
implementation of the removed APIs.

Change-Id: Ic461b8d15e072e0534dcd73fff6857581d83c89b
2017-04-11 02:10:26 -05:00
Dean Troyer
1bf6706ad1 Low-level Compute v2 API: security group rules
api.compute.APIv2 security group rule functions.

novaclient 8.0 is now released without support for the previously
deprecated nova-net functions, so include a new low-level REST
implementation of the removed APIs.

Change-Id: Ieabd61113bc6d3562738686f52bb06aa84fca765
2017-04-11 02:08:57 -05:00
Dean Troyer
4289ddd47a Low-level Compute v2 API: security group
api.compute.APIv2 starts with security group functions.

novaclient 8.0 is now released without support for the previously
deprecated nova-net functions, so include a new low-level REST
implementation of the removed APIs.

Change-Id: Id007535f0598226a8202716232313e37fe6247f9
2017-04-11 02:08:04 -05:00
Rui Chen
a071ff91c3 Add document about renaming OS_ENDPOINT_TYPE to OS_INTERFACE
The patch https://review.openstack.org/#/c/198506/ rename option
--os-endpoint-type to --os-interface a year ago, but lots of users
switch to osc from these project specified clients, like: novaclient
and neutronclient, they used OS_ENDPOINT_TYPE and --os-endpoint-type
for long time, we should add the notes into openstackclient manpage,
let them know the gap exists, and how to make it works.

Change-Id: Ic84a60744aa4e519994a18104deae0c2b5b8b0ed
Closes-Bug: #1678144
2017-04-11 15:01:49 +08:00
Dean Troyer
09286ad858 Split floating IP tests
Split up the floating IP unit tests between compute and network APIs
into separate files in preparation for reworking the compute (nova-net)
implementations to deal with the removal of deprecated nova-net
support in novaclient 8.0.0.

No code changes are intended here, just splitting two files into four.

Change-Id: Id62148bb21e913116f9f2084c5761cfa24e8d34c
2017-04-10 18:07:00 -05:00
yangweiwei
13bba78ca5 Update to tox.ini
When do the action "tox -e pep8", result is "ValueError: No closing
quotation". Which is caused by the tox.ini. The min tox version is
1.6. In my environment, tox version is 2.2.1. If the tox version is
more than 2.3, the error will not happen.

Depends-on:  Iee7b043ac7d381dadf89d26098f69e935ed81d6b
Change-Id: Id10ddf6244e7e25e6f66c97773d426b0b4789479
2017-04-07 18:33:39 +00:00
David Rabel
8549071363 Add --network and --port to server create
--nic option is quite unhandy. It is better to have
two seperate options --network and --port to add a
network to a new server.

Change-Id: I523abdc83ca2dd4c5dd3871f8f109c2bf57c2e02
Closes-Bug: #1612898
2017-04-07 16:36:18 +02:00
OpenStack Proposal Bot
358175158d Updated from global requirements
Change-Id: I8e7362555d330613a87c095b89bb2783df03a6e3
2017-04-07 14:32:41 +00:00
Jenkins
54723427b6 Merge "Split security group tests" 2017-04-07 14:11:19 +00:00
Dean Troyer
488ca596ec Split security group tests
Split up the security group tests between compute and network APIs
into separate files in preparation for reworking the compute (nova-net)
implementations to deal with the upcoming removal of deprecated nova-net
support in novaclient 8.0.0.

No code changes are intended here, just splitting two files into four.

Change-Id: I3fbdde45f593a30de545ddd11e319a4d6f900b18
2017-04-06 12:23:25 -05:00
venkata anil
fe59e339ae Allow override of distributed router flag
When router_distributed=True is set in neutron.conf,
user can't override this and create a centralized router
through openstack client. Openstack client allows modifying
routers from distributed to centralized after creation but
not supporting centralized flag during creation. We allow
centralized and distributed flags during router creation
with this change.

Closes-bug: #1664255
Change-Id: I75f72ca695338ad8c381cfa89fbb9d8e61ee7bc5
2017-04-06 14:37:14 +00:00
Jenkins
80726b1340 Merge ""floating ip set/unset port" for OSC" 2017-04-06 01:55:24 +00:00
Jenkins
8983373e52 Merge "Add "qos-policy" option to "port create" & "port set"" 2017-04-06 01:43:44 +00:00
Dean Troyer
46b8cad4c3 Clean up password prompt work-arounds
osc-lib 1.2 is minimum and now handles the password prompting.

Change-Id: Ie11ad64796d3a89c7396b321c34947d622d1ed39
2017-04-05 13:54:08 -05:00
Jenkins
27f96a3a7a Merge "Enable to create legacy router" 2017-04-05 17:00:49 +00:00
Sindhu Devale
763c8c5670 "floating ip set/unset port" for OSC
Implements Neutron feature of floating ip associate/disassociate
into OpenStack Client.

Previously, network.find_ip() function only supported to
search floating ip by UUID. Hence, _find_floating_ip()
function is used in floating_ip.py, to search fip both by UUID
and ip_address. [1] adds the ability to find fip object using both UUID
and ip_address. This functionality however, won't be available until
the SDK is released. Hence, we continue to use _find_floating_ip()
method, which was cleaned up by [2] to remove the use of ip_cache.
Once, the SDK is released, we will remove all the usage of
_find_floating_ip() method and instead only use network.find_ip().

[1] https://review.openstack.org/#/c/449879/2
[2] https://review.openstack.org/#/c/447938/

Change-Id: I6c5222287c46ca42365917d2deae70bdb626347
Co-Authored-By: Reedip<reedip.banerjee@nectechnologies.in>
Co-Authored-By: RuiChen<chenrui.momo@gmail.com>
Closes-Bug: #1560297
2017-04-05 16:12:40 +00:00
Ha Van Tu
5ff2cfd042 Add "qos-policy" option to "port create" & "port set"
This patch adds "qos-policy" option to "port create" command,
and "qos-policy", "no-qos-policy" options to "port set" command
and "qos-policy" option to "port unset".

Change-Id: I78072e1ff0dd30a2e23a0fb833ce6ab5cf246016
Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Co-Authored-By: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2017-04-05 15:56:52 +00:00
Jenkins
65b61d3a9c Merge "Enable to specify which fixed-ip to add to a vm." 2017-04-05 02:55:11 +00:00
Jenkins
25a77f7c7c Merge "Structure FindFloatingIP() to work without ip_cache" 2017-04-04 20:31:15 +00:00
Reedip
0e42ea3ae3 Structure FindFloatingIP() to work without ip_cache
Currently we have an ip_cache returned from _find_floating_ip() which
is generally ignored as it is not always required.

This patch removes the need of ip_cache in _find_floating_ip().

Co-Authored-By: Sindhu Devale<sindhu.devale@intel.com>

Change-Id: I8b92271185f82f275fa73adad03e9dad70be70e4
2017-04-04 16:27:24 +00:00
Cedric Brandily
7f9814860a Enable to specify which fixed-ip to add to a vm.
This change enables to specify which fixed-ip will be added to a vm using:

 openstack server add fixed ip <vm> <network> --fixed-ip-address <ip>

This change uses interface_attach instead of add_fixed_ip[1] which is
less flexible and uses a deprecated API.

[1] https://review.openstack.org/384261

Closes-Bug: #1678140
Change-Id: I7fe4621439ef0d8dca080551ffaeb614c5a91174
2017-04-04 11:15:29 -05:00
Shashank Kumar Shankar
abb2498e71 Correct flavor associate/disassociate commands in Mapping Guide
This patch fixes the neutron CLI mapping for neutron flavor-associate
and flavor-disassociate since [1] got merged.

[1] - https://review.openstack.org/#/c/403907/

Change-Id: Ifd09a8b091ae89c33a06590aba935df5e22e215b
2017-04-04 15:45:46 +00:00
Jenkins
c7e7f2b730 Merge "Help/docs cleanups: marker, limit, ip-address metavars" 2017-04-04 12:32:55 +00:00
Dean Troyer
1686dc54f0 Help/docs cleanups: marker, limit, ip-address metavars
Cleanup help strings and docs for clarity and to keep things consistent:
* --limit metavar should be <num-resource> to indicate what is being counted
* --marker metavar should be <resource> or <resource-id> to indicate the
  type of value being specified
* <*-ip-address> metavars should be just <ip-address> as there is no difference
  in format between fixed and floating IPs
* Move all occurances of '(name or ID)' to end of help text

Change-Id: I2c31746ed6ded3845244e03e57d809f8bc0e6b9d
2017-04-04 03:56:19 +00:00
Jenkins
8a1f4b6592 Merge "Introduce neutron flavor associate, disassociate to OSC" 2017-04-04 02:38:59 +00:00
Jenkins
16b822b769 Merge "Release notes cleanup for 3.10.0 release" 2017-04-04 02:27:36 +00:00
Jenkins
279066b67c Merge "Change noauth strategy for plugin loading" 2017-04-03 21:50:39 +00:00
Dean Troyer
9915efdd0a Release notes cleanup for 3.10.0 release
Change-Id: Ibf2aec57c5b9a1b3c8e5e74f8524c79939fc6f94
2017-04-03 16:30:36 -05:00
Jenkins
d0f368ba0e Merge "Enable to add/remove port to/from a server" 2017-04-03 20:51:20 +00:00
Jenkins
e2cd971a03 Merge "Fix block-device-mapping when volume_size is empty" 2017-04-03 19:49:42 +00:00
Jenkins
6251d7d82a Merge "Add help commands withouth auth in functional" 2017-04-03 18:55:31 +00:00
Cedric Brandily
21510ac1a9 Enable to add/remove port to/from a server
This change enables to add/remove a specific port to/from a server using
the new commands:

 openstack server add port <vm> <port>
 openstack server remove port <vm> <port>

Closes-Bug: #1678137
Change-Id: I6ee57df089235ccc1fb9d38316bd484956b1134d
2017-04-03 20:19:40 +02:00
Shashank Kumar Shankar
b51310a4bb Introduce neutron flavor associate, disassociate to OSC
This patch introduces network flavor associate and disassociate to
OSC. The following neutron equivalent commands are implemented in OSC:

    - neutron flavor-associate
    - neutron flavor-disassociate

Change-Id: Icba4dbf7300a36353142586359059cd6784049dc
2017-04-03 17:02:03 +00:00
Rui Chen
341f07582e Add help commands withouth auth in functional
A special scenairo is that users want to check the commands
help message, but don't set authentication info at all. Add
a related functional test case to cover it.

Change-Id: I7b09701df24d6f6dfcf369f89212f72e753be6e4
2017-04-03 16:27:25 +00:00
Jens Rosenboom
61cde9c8e8 Fix block-device-mapping when volume_size is empty
The Nova API responds with an validation error when a bdm is submitted
containing an empty volume_size. So instead omit that attribute when it
is empty.

Change-Id: Iba905fca8c440a03e828c20922f3b813bba3fa3a
Closes-Bug: 1677236
2017-04-03 11:26:35 +00:00
Jenkins
b2ceb58fc3 Merge "Use Sphinx 1.5 warning-is-error" 2017-04-01 21:18:16 +00:00
Jenkins
67a4b812c6 Merge "doc: Correct Sphinx warnings" 2017-04-01 21:08:43 +00:00
Jenkins
e059adeab7 Merge "doc: Remove local fork of apidoc" 2017-04-01 21:07:29 +00:00
Cedric Brandily
53ba05325a Enable to create legacy router
Some deployments create by default HA routers, this change enables to
force the creation of a legacy router using:

 openstack router create --no-ha ...

Closes-Bug: #1675514
Change-Id: I78f7dc3640a2acfdaf085e0e387b30373e8415f1
2017-03-31 13:01:00 +00:00
Jenkins
6591154488 Merge "Remove log translations" 2017-03-31 04:22:31 +00:00
Jenkins
d72370a537 Merge "Trivial Fix" 2017-03-30 18:25:47 +00:00
Ankur Gupta
6d259e5d18 Trivial Fix
Release note fix.
Extra space looks odd when built.

TrivialFix

Change-Id: I5b5d0f66246e25fcb3619992a96558744cf943ca
2017-03-30 11:12:19 -05:00
OpenStack Proposal Bot
c49c125735 Updated from global requirements
Change-Id: Ic9a5bd518d1b2d4a7979716b9809ce236292205f
2017-03-30 00:31:55 +00:00
Jenkins
ca06a09d4d Merge "Fix volume transfers request commands" 2017-03-28 17:33:25 +00:00
Stephen Finucane
f45aa9079d Use Sphinx 1.5 warning-is-error
This will ensure doc warnings don't make their way in.

Change-Id: I9a007ad89f3a2219feb960fee858bf70c1643416
2017-03-28 16:53:58 +01:00
Stephen Finucane
70170656fd doc: Correct Sphinx warnings
- Fix option-describe typos
- Correct option and envvar markup, for commands that are using the
  reference form instead of the definition form or are marking up
  option arguments as options
- Avoid duplicate commands
- Fix some invalid docstrings
- Fix some invalid indentation
- Disable the murano plugin, which has invalid docs
- Correct issues with- and track the network-topology spec
- Include API modules in docs

Change-Id: I3d5ed5e872540fe13f3e4bd5e9335829dc9a5226
2017-03-28 16:41:54 +01:00
Stephen Finucane
9f471eede9 doc: Remove local fork of apidoc
This is unnecessary as pbr has since been fixed. It was causing a broken
build as it didn't respect the '[pbr] autodoc_tree_excludes' setting in
setup.cfg.

The 'openstackclient/volume/v3' directory is an empty module containing
only an '__init__' file). Empty modules = unhappy autodoc, thus, this
module is ignored.

Change-Id: Ie355b14c14b7badccb5c25f7c17edbc5e4b3804f
2017-03-28 16:29:19 +01:00
Dean Troyer
1c3cb0a3b5 Change noauth strategy for plugin loading
Don't do it.

os-client-config's plugin loading has been causing this pain for a long
time, removing the KSC hack-around in o-c-c unmasked this again.  So when
auth is not reuired, just don't let o-c-c do any plugin loading at all.

Ever.

Of course, this shouldn't be in OSC either, but we have to do this until
the equivalent fix lands in osc-lib, is released and makes it into the
global requirements minimum version.

Depends-on: Ie68c82f7b073012685f0513b615ab1bf00bc0c3a
Change-Id: Ifdf65f3bb90fb923947a2cbe80a881d71a3fee56
2017-03-27 19:58:40 -05:00
Jenkins
dd81ca0692 Merge "Simplify logic around option lists in port set" 2017-03-27 17:33:23 +00:00
Dean Troyer
709eac73fb Fix volume transfers request commands
* Fix volume transfer request accept to actually not crash when
  trying to call Volume API.
* Fix volume transfer request accept syntax to have only one
  positional argument, which is the ID of the resource in the command
* Change the output column order in volume transfer request list to
  have ID followed by Name then the remaining columns.

Closes-bug: 1633582
Change-Id: I5cc005f039d171cc70859f60e7fe649b09ead229
2017-03-27 12:31:42 -05:00
Ankur Gupta
c3fee25a07 Doc: Fix link in network flavors
Rendered incorrectly.

Change-Id: I206dd8affa45864e406796147665c94684e9bf4d
2017-03-24 12:19:53 -05:00
Jenkins
2a64a64046 Merge "OSC Extension Show" 2017-03-23 20:30:15 +00:00
Jenkins
5da7ddd703 Merge "docs: Don't include ChangeLog" 2017-03-23 16:51:29 +00:00
Sindhu Devale
832b2591cf OSC Extension Show
Implement Neutron feature of Extension Show into
OpenStack Client.

Change-Id: Ifecb794838cb3bf8c2466d178345349db3cd4003
Implements: blueprint extension-show
2017-03-22 16:39:19 +00:00
Jenkins
b5d707eb7b Merge "Support to add/remove multi users for "group add/remove user"" 2017-03-21 17:20:48 +00:00
yfzhao
535def3447 Remove log translations
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

Change-Id: I504de69b2e64250740ebcab432042a16f966fdbe
Closes-Bug: #1674584
2017-03-21 17:23:09 +08:00
Jenkins
2fdd4ff2f6 Merge "Fix Trivial Changes in [1]" 2017-03-21 08:29:27 +00:00
Jenkins
6329c04297 Merge "OSC Quota List" 2017-03-21 03:56:05 +00:00
Jenkins
efc570dae2 Merge "OSC Network Flavor Profile" 2017-03-21 03:32:47 +00:00
Reedip
8e2bc9cb9c Fix Trivial Changes in [1]
[1] had some trivial changes in the main code, which
are being put forward in this patch, to consider future scenarios.

[1]: I77a933f4b3ce875c63cef5b6a32aee78fd844b03

TrivialFix

Change-Id: I8e8fbb194cd319e5605f09c94ae09e952d0961b1
2017-03-21 02:43:24 +00:00
Huanxuan Ao
ef5a7caf85 Support to add/remove multi users for "group add/remove user"
Similar delete commands in OSC, we can also support add/remove
multi users for one specified group, this review implement it.

Change-Id: I8ccf99d4ee83a18778fa3ff5c0a42bc7c6ff21fb
Implements: bp support-multi-add-remove
2017-03-21 10:39:42 +08:00
Jenkins
49e866174f Merge "Enable to specify which vm fixed-ip to publish" 2017-03-21 01:55:51 +00:00
Jenkins
fe3bbf63a8 Merge "Jsonify meter and meter rule functional tests" 2017-03-21 01:50:17 +00:00
Dean Troyer
82a86d2d58 Simplify logic around option lists in port set
Use a common pattern to handle option pairs --XYZ and --no-XYZ for managing
lists of attributes. This pattern looks at the presence of the option
in parsed_args first and branches as necessary.

Some specific steps are included for the SDK Network resources to reliably
set the 'dirty' flag for changed attributes via one or both of the following:
* iterate over lists of original resource attributes to force the creation
  of a new list object
* use [].extend() rather than += to add to the existing list (substitute
  {}.update() for dicts)

Change-Id: I0c3f9a52ffe1ae2b5b230cb13d6376dd9131aaf9
2017-03-20 16:55:48 -05:00
Cedric Brandily
f5527877bb Enable to specify which vm fixed-ip to publish
This change enables to specify which vm fixed-ip will be associated to a
floating ip using:

 openstack server add floating ip <vm> <fip> --fixed-ip-address <ip>

Closes-Bug: #1624524
Change-Id: I2ddb68c5873bfed7293b0e661d1adbe111681136
2017-03-20 22:33:51 +01:00
Jenkins
3e621c9a9c Merge "Introduce Neutron DHCP agent commands to OSC" 2017-03-20 21:31:53 +00:00
Jenkins
f16513aaf2 Merge "Make MAC address of port updatable" 2017-03-20 20:53:22 +00:00
Shashank Kumar Shankar
f4fd8f6e31 Introduce Neutron DHCP agent commands to OSC
This patch introduces neutron dhcp-agent related commands to OpenStack
client.

The equivalent neutron commands implemented in OSC:

neutron: dhcp-agent-list-hosting-net
OSC: network agent list --network

neutron: dhcp-agent-network-add
OSC: network agent add network

neutron: dhcp-agent-network-remove
OSC: network agent remove network

neutron: net-list-on-dhcp-agent
OSC: network list --agent

Change-Id: I77a933f4b3ce875c63cef5b6a32aee78fd844b03
2017-03-20 15:02:09 -04:00
Jenkins
9a1efd41c8 Merge "Non-Admin can't list own projects" 2017-03-20 17:58:38 +00:00
Jenkins
97a4ac471a Merge "Add extra filtering options to qos policy list" 2017-03-20 17:58:32 +00:00
Jenkins
495d013431 Merge "Adds missing flavor information in the server list long command" 2017-03-20 17:57:38 +00:00
Stephen Finucane
be1e6ca1d8 docs: Don't include ChangeLog
The ChangeLog is built using commit message summary lines. Unfortunately
some of these contain invalid rST markup. There's no way to
retroactively fix this, so simply stop including the doc.

Change-Id: I6600c1baf142fe4c776f1ae170faa3f6a87b330c
2017-03-20 16:35:01 +00:00
Nakul Dahiwade
7ef1e9ea96 OSC Network Flavor Profile
Implement Neutron feature of Network Flavor Profile
into OpenstackClient
This patch implements the following commands:
network flavor profile create
network flavor profile delete
network flavor profile list
network flavor profile show
network flavor profile set

SDK Version needed: 0.9.9

Change-Id: Ie6fe5e53122cfb2eda8d326851d54562739a8386
Partially-Implements: blueprint neutron-client-flavors
2017-03-20 16:24:27 +00:00
Bence Romsics
f1345dc06f Make MAC address of port updatable
openstackclient does not allow the update of a port's MAC address.
However this is possible in neutron API (though by default policy
it is an admin-only operation). Allow it in openstackclient too.

Change-Id: Ibd9e0a6fbd1d0d461b8a8daee24dbb7c3f929df6
Closes-Bug: #1670707
2017-03-20 15:40:48 +00:00
adrian-turjak
49f6032b69 Non-Admin can't list own projects
Due to a default Keystone policy until Newtown,
and the use of resource_find, non-admins are unable
to list their own projects.

This patch bypasses this problem while also introducing better
UX for non-admins wishing to get their project list.

'openstack project list' retains the default of 'list all projects'
but on a forbidden error will default instead to 'list my projects'.
This way for non-admins 'list my projects' feels like the default
without breaking the expected admin default.

Adding the '--my-projects' option allows admins to easily list their
own projects or allows non-admins to be explicit and bypass the
forbidden error fallback.

Change-Id: I1021276f69fbbf28e13e17c4e567d932fce7ed8b
Closes-Bug: #1627555
2017-03-20 14:40:56 +13:00
OpenStack Proposal Bot
ad5b57fd19 Updated from global requirements
Change-Id: I5d0e7942a45e6fed6d387250734e882335fa3de4
2017-03-16 22:00:54 +00:00
Jenkins
5490654788 Merge "Refactor ServerTests and ServerEventTests functional test classes" 2017-03-16 18:48:04 +00:00
Jenkins
6d33798252 Merge "Functional test for ip_availability" 2017-03-16 16:31:42 +00:00
Jenkins
6cae88fa2b Merge "Add a validation about options for server migrate command" 2017-03-16 15:52:50 +00:00
Jenkins
c1503492cd Merge "Fix "security group list" command to display project ID properly" 2017-03-16 13:02:17 +00:00
Jenkins
3d4750cdc8 Merge "Narrow expected responses for CheckUserInGroup" 2017-03-16 13:02:02 +00:00
Jenkins
9184e19288 Merge "Add sort support to project list" 2017-03-16 13:01:56 +00:00
Jenkins
66246561d8 Merge "Switch to use cleanup method in functional test" 2017-03-16 13:01:49 +00:00
Jenkins
b6f51cdfa0 Merge "Add the bgp agent type to network agent command" 2017-03-16 08:58:49 +00:00
Colleen Murphy
853ea5ab59 Narrow expected responses for CheckUserInGroup
When checking whether a given user is in a given group, keystone will
return a 404 Not Found if all went well but the user was not in the
group. It may also return a 403 if the user and the group are in
different backends, which would also mean that the user was not in the
group[1]. Any other 400 response is a client error and any 500 response
is a server error to which the user should be alerted.

Without this patch, openstackclient treats any exception as a valid "not
found" and may end up hiding server errors. This patch reduces the
caught exceptions to 403 and 404 responses and treats everything else as
an error.

[1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group

Closes-bug: #1672634

Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f
2017-03-14 09:23:19 +01:00
lvjiawei
9fd3dba11e Add extra filtering options to qos policy list
The patch adds filtering "--project", "--project-domain",
"--share", "--no-share" options to qos policy list.

Change-Id: I5c012fb27fb952f736ddc9fbc54ef6da4d0af5e0
Partially-Implements: blueprint network-commands-options
2017-03-14 13:04:47 +08:00
Jose Castro Leon
429b43a331 Adds missing flavor information in the server list long command
Closes-Bug: #1672396

Change-Id: Ie2a664fd1c3db1b8269ea079df181f87afc702a7
2017-03-13 16:32:15 +01:00
Jenkins
4a19f6753b Merge "Fix reference in network flavor create command reference" 2017-03-12 19:49:52 +00:00
jiahui.qiang
1a5704d22e Functional test for ip_availability
Refactor ip_availability functional tests.

Change-Id: I2397bd20236e1e9e3c69177ea6afbaadf2c445ae
2017-03-10 17:11:17 +00:00
Sindhu Devale
58591d3c37 OSC Quota List
Implement Neutron feature of Quota List into
OpenStack Client.

Change-Id: Idf941acf8d00b136776b7381b877c56d82622f57
Partially-Implements: blueprint neutron-client-quota
2017-03-10 14:59:47 +00:00
Akihiro Motoki
85d598a9ac Fix reference in network flavor create command reference
network-flavor.rst
* The opening quote of :ref: should be a backquote
* Closing paranthesis was missing after the reference

network-service-provider.rst
* A blank line is required after a label definition

Change-Id: Ie5c2bedbb6e5b4337b69a7d1ea75c47366e3d627
2017-03-10 21:51:34 +09:00
Dean Troyer
498d416bdd Refactor ServerTests and ServerEventTests functional test classes
Move common bits into a compute.v2.common.ComputeTestCase class
so they are available as needed without calling into other test
classes.

Change-Id: I1afcc04ba705b0bbb85628117e7ca91080cf1895
2017-03-10 14:50:21 +08:00
Huanxuan Ao
888022f8c0 Fix "security group list" command to display project ID properly
The "Project" column of the output of
"security group list" command is blank
since the new attribute name is "project_id"
not "tenant_id" in network resource, so change
it to display project IDs properly

Change-Id: Ie2a071afac3b5a8aaa2c6f1c50d44ae06905d916
Closes-bug: #1659967
2017-03-10 10:55:58 +08:00
Jenkins
9ffcd0dca7 Merge "Fix handling the use_default_subnet_pool attribute" 2017-03-10 02:52:15 +00:00
Ankur Gupta
1e739d7aeb Trivial Fix
Improperly rendered Release Note for v3.9.0

Change-Id: Ia9b920b5a3774dd9c720fe7a39fd41aaf7be209f
2017-03-09 10:59:44 -06:00
Nakul Dahiwade
289f15a814 Jsonify meter and meter rule functional tests
Some functional tests try to parse the CLI table output
format, that cause much work on parse string by using
regular expression. Using json format in functional tests
is better and easier way, this patch reworks for meter and
meter rule related tests.

Change-Id: I1f2a95c873a4ed23dd1afa4040900a1c7704d0bf
2017-03-09 16:57:54 +00:00
Huanxuan Ao
35dc85823d Revert "Fix port command for SDK >0.9.10"
This reverts commit 8e277c64fb.

After [1] merged in osc-lib, we can Avoid 'NoneType' error
when format conversion now, So [2] in no longer needed,
we can clean it up.

Hold this until [1] released and included in the requirement
in OSC.

[1] https://review.openstack.org/#/c/434768/
[2] https://review.openstack.org/#/c/420420/

Depend-On: I649b4fc65ef7c19b8193b07f3bd59f00e6095f9f
Change-Id: I2783713102d5e6164d9617f130c2f595bd6d939e
2017-03-09 19:39:37 +08:00
Jens Rosenboom
3e6356a4d8 Fix handling the use_default_subnet_pool attribute
The attribute formerly wasn't working because it is lacking support in
the SDK. The patch to add it[1] introduced a modified spelling, so we
should be matching this here.

Also make sure that the attribute is not shown when displaying subnet
objects, as it is meant to be invisible[2].

[1] I72c0be77d96f3891748cdd69c382211dc20dbf5e
[2] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/default_subnetpools.py#n23

Change-Id: Ic125b818a6082d76a1114fe89e0b1fcf4c7356b0
Partial-Bug: 1668223
2017-03-09 08:21:13 +01:00
Jenkins
a93440023b Merge "Remove py34 tox env and pypi classifier" 2017-03-08 22:17:34 +00:00
Tom Jose Kalapura
6c1b03bf73 Add sort support to project list
Add sort support to project list by sorting items in the client side.
By default list will be sorted by name.

Change-Id: I00011406846b4003aff075eeeb88ac18fa5e2820
Closes-Bug: #1596818
2017-03-08 08:47:35 -08:00
Jenkins
37b5d0d45e Merge "command list: Move network meter appropriately" 2017-03-08 15:42:22 +00:00
Jens Rosenboom
8c6cfb518b Add the bgp agent type to network agent command
The neutron-dynamic-routing project provides an agent called
neutron-bgp-dragent with type "BGP dynamic routing agent". So we need to
add this option and can avoid using the deprecated neutron CLI e.g. in
[1].

[1] https://docs.openstack.org/ocata/networking-guide/config-bgp-dynamic-routing.html#verify-service-operation

Change-Id: I9af1e09d122806b56b966295817d8d31393e0283
Closes-Bug: 1671040
2017-03-08 14:40:23 +01:00
Jenkins
dcb2de9db2 Merge "Add "--private-key" option for "keypair create"" 2017-03-08 02:51:48 +00:00
Eric Brown
73c2a809f7 Remove py34 tox env and pypi classifier
Currently only py27 and py35 (not py34) is tested in the gate, so
py34 should no longer be part of the tox environment or part of the
PyPi classifier.

Change-Id: I155fc0e3ac06b495718d9fa3058edded738cb011
2017-03-07 14:40:27 -08:00
Akihiro Motoki
f4d3810c3e command list: Move network meter appropriately
'network meter' commands are not placed alphabetically
in the command list. It was due to the incorrect filename.

Trivial Fix

Change-Id: I7a76d3133915883cf41be8c7430def284d292d6e
2017-03-08 05:56:32 +09:00
Jenkins
054060cbef Merge "Add server event list and show commands" 2017-03-07 19:20:11 +00:00
Rui Chen
c03b9a871c Add server event list and show commands
OSC server event is similar to nova's instance action commands.

Server event is the event record that had been done on a server,
include: event type(create, delete, reboot and so on),
event result(success, error), start time, finish time and so on.
These are important information for server maintains.

Change-Id: I8111091f46a0d2755728d8f9d43cc0dfe8842d13
Closes-Bug: #1642030
2017-03-07 15:25:43 +08:00
OpenStack Proposal Bot
c0a23b89b1 Updated from global requirements
Change-Id: Ifda7ceeb278ff590cbf3d43f4eb65f895474fd4b
2017-03-07 02:05:59 +00:00
Jenkins
ead615f92d Merge "Cleanup release notes for 3.9.0 release" 2017-03-07 00:41:24 +00:00
Jenkins
6b8f5db02f Merge "Trivial Fix" 2017-03-06 23:55:40 +00:00
Jenkins
fe8c5047f8 Merge "add neutron CLI to decoder" 2017-03-06 21:50:34 +00:00
Dean Troyer
20429bd5c6 Cleanup release notes for 3.9.0 release
Change-Id: I6786fe67928d4f3d72cb4751fb70b67dccaa11e2
2017-03-06 21:49:47 +00:00
Jenkins
ca6f733f0f Merge "Trivial Fix" 2017-03-06 21:38:28 +00:00
Ankur Gupta
3907389785 Trivial Fix
Improperly rendered release note.

TrivialFix

Change-Id: I9771b84eb96edea39a5dbd6a94f2ee464da3914c
2017-03-06 14:09:32 -06:00
Steve Martinelli
b421eed868 add neutron CLI to decoder
Change-Id: I4717ffa2aa1c7bab1199728455ac7c13834d746f
2017-03-06 18:48:55 +00:00
liusheng
d07704dd25 Normalize the gnocchiclient docs entry
For now, gnocchiclient has been added in the global-requirements, we
should add gnocchiclient in test-requirements.txt and normalize the docs
entry.

Change-Id: Ide5d8262e7f7c5b1ca304fa72893ccfbf16d8ec1
2017-03-06 19:27:04 +08:00
Rui Chen
dee22d8faa Add "--private-key" option for "keypair create"
Aim to specify the private key file to save when keypair
is created. That is a convenient way to save private key
in OSC interactive mode, avoid to copy CLI output, then
paste it into file.

Change-Id: I119d2f2a3323d17ecbe3de4e27f35e1ceef6e0a5
Closes-Bug: #1549410
2017-03-06 08:34:28 +00:00
Jenkins
69b7b9b059 Merge "Support --no-property in "volume set" command" 2017-03-06 03:47:49 +00:00
Reedip
33b092fb9a Trivial Fix
Add a space in the quota error message

Change-Id: I159708b42e86f6b02f8733103a687561d550f650
2017-03-05 18:21:46 +00:00
OpenStack Proposal Bot
f97a33b971 Updated from global requirements
Change-Id: I28815dc190dba45af060b26eceb660f40bb67772
2017-03-03 22:59:10 +00:00
Anindita Das
6abd38cd46 Jsonify network flavor functional tests
Some functional tests try to parse the CLI table output format, that cause much
work on parse string by using regular expression. Using json format in
functional tests is better and easier way, this patch reworks for network
flavor related tests.

Change-Id: I2bc5675409945c9ae79ac65df2d5d10781fe595a
2017-03-02 17:10:53 +00:00
Jenkins
8bff11582d Merge "Functional test for subnet" 2017-03-02 14:38:07 +00:00
Ankur Gupta
a8ec2c94e7 Nit: Trivial doc formatting fix for network flavor
Change-Id: I6e67c0859642593bc7fdd479cac81e56d87faf09
2017-03-01 21:09:20 -06:00
Rodrigo Duarte Sousa
a98d369a39 Use *_as_ids instead *_as_list
The parents_as_list and subtree_as_list query parameters limit the
result to only parents and subtree where the user making the call has
role assignments in. Since OSC only displays the IDs, the call would be
the same as the similar *_as_ids queries, the difference is that the
later doesn't enforce the role assignments (making it more useful).

Output example by using this patch:

$ openstack project show --children root
+-------------+------------------------------+
| Field       | Value                        |
+-------------+------------------------------+
| description |                              |
| domain_id   | default                      |
| enabled     | True                         |
| id          | 123                          |
| is_domain   | False                        |
| name        | root                         |
| parent_id   | default                      |
| subtree     | {u'456': None, u'789': None} |
+-------------+------------------------------+

Change-Id: Ib7b37ae8f55190a7efcc375d5be4a2823d02d1a4
2017-03-01 23:24:11 -03:00
Jenkins
3ec0bc9179 Merge "Add Cinder v3 client support for volumes" 2017-03-01 19:10:48 +00:00
Jenkins
3816433b53 Merge "Auto allocated topology for OSC" 2017-03-01 18:03:19 +00:00
Rikimaru Honjo
7063ffb3ca Add a validation about options for server migrate command
The behavior of server migrate command are different depending on
whether user specify --live option or not.
server migrate command will call live migration API if user specify
--live option.
Ohterwise server migrate command will call migration(cold migration)
API.

Now then, "--block-migraiton" option and "--disk-overcommit" option
only affect live-migration.
But, openstackclient doesn't warn user if user specify these options
without "--live".
But, user can't recognize that specifying options are ignored.

This patch adds a validation that checks whether or not user specify
these options without "--live".

Change-Id: Ifa278abb23ecdba4b13f3742998359ac74eb7ad4
Closes-bug: #1662755
2017-03-01 17:37:39 +09:00
OpenStack Proposal Bot
1654f56f4e Updated from global requirements
Change-Id: Ief1a2faf6b9f80c5c7f3946d820f89587d44f8aa
2017-03-01 04:16:15 +00:00
Jenkins
e3a726491c Merge "Update doc/source/command-objects/image.rst" 2017-03-01 02:22:21 +00:00
David Rabel
56c981e7fb Update doc/source/command-objects/image.rst
Update doc/source/command-objects/image.rst to match
output of 'openstack help image create' again.

Forgot this in:
https://review.openstack.org/#/c/437335/

Change-Id: Ied7ed88ea79da0b778cccf19d087b5ee06edcb71
2017-02-28 21:35:56 +01:00
Jenkins
264f81f6fc Merge "Port set/unset SecGroup Bug Fix" 2017-02-27 17:18:00 +00:00
Jenkins
c6059bed4a Merge "openstack image create : --file and --volume exclude each other" 2017-02-27 05:00:57 +00:00
Jenkins
e5ee4b8ca3 Merge "Support list commands by group name keyword" 2017-02-27 03:47:11 +00:00
Ankur Gupta
9d946f0f45 Port set/unset SecGroup Bug Fix
Throwing error 'Port' object has no attribute 'security_groups'
Fix for set and unset.

Change-Id: I1a0625b5a432c7a91cf40249ce4f7c883f53d704
Closes-Bug: #1656788
2017-02-26 15:39:36 -05:00
Jens Rosenboom
f63a9f402d Fix output of ListSecurityGroupRule
The Ethertype column was always left empty because a wrong column name
was being used.

Change-Id: I7fc0f8d5eb7bac1efb234faba454dad0a45a7e6a
Closes-Bug: 1667699
2017-02-24 21:21:43 +01:00
David Rabel
4ea4f6fabb openstack image create : --file and --volume exclude each other
Added parser.add_mutually_exclusive_group() for --file and --volume
in openstack image create.

Change-Id: I4d9fc6314801d569354e5644e231ddd6c7f1853d
Closes-Bug: 1666551
2017-02-24 08:50:37 +01:00
Jenkins
1450e8ff4f Merge "Fix can not set is_default in network" 2017-02-24 04:13:38 +00:00
Jenkins
9ccf8fd067 Merge "Revert unit tests for quota commands" 2017-02-23 18:30:21 +00:00
Jenkins
12ab5f08ca Merge "minor tweaks to mapping table" 2017-02-23 18:30:01 +00:00
Jenkins
923e62196c Merge "add keystone and glance -> osc mapping" 2017-02-23 18:29:17 +00:00
jiahui.qiang
7d93db21e5 Fix can not set is_default in network
The value of is_default always be None, can not be set by
"network set" command. Allow "--default" and "--no-default"
options to be recognized when ``--external`` is not present.

Closes-bug:#1665231

Change-Id: I7a05fc7734a15994f72ca4e47997b4952f1f72f8
2017-02-23 15:51:48 +00:00
zhiyong.dai
40ec7a9c96 Support --no-property in "volume set" command
Add "--no-property" option to "volume set" command in v1 and v2
and update the test cases.

Change-Id: Id5660f23b3b2d9aa72f4c16b19ce83f3f7ed2fa4
2017-02-23 21:49:11 +08:00
Huanxuan Ao
ef2a8f4d11 Revert unit tests for quota commands
quota set and quota show command have been fixed
by [1] [2], now can revert the unit test as well

[1] https://review.openstack.org/435574
[2] https://review.openstack.org/435735

Change-Id: I3d592df6ea4e96770dac4dba91819b5c4bcb0561
2017-02-23 20:44:28 +08:00
Rui Chen
0898ebacb8 Support list commands by group name keyword
The output of current "command list" is so long, it's
very difficult for users to find out the commands
they care about.

Add "--group <group-keyword>" option to filter the commands by group
name keyword, like: --group volume, list all openstack.volume.v2
(cinder) commands

That support the scenario that users need to know the current support
commands of some OpenStack services(nova, neutron, cinder and so on) in
OSC.

Change-Id: Id673042729ad36a0cac0b81fb31a3537c24f03fc
Closes-Bug: #1666780
2017-02-23 12:13:06 +08:00
Jenkins
c8435f2d5a Merge "Show openstacksdk version info in "module list"" 2017-02-22 22:51:28 +00:00
Ankur Gupta
1169434f42 Auto allocated topology for OSC
Implementation of Auto-allocated topology into OSC.
Dependency merged and released in SDK v. 0.9.11

Partially Implements: blueprint network-auto-allocated-topology

Change-Id: I16120910893b0b26b0f7f77a184b0378448458c5
2017-02-22 15:38:16 -05:00
Steve Martinelli
aef9dacc7f minor tweaks to mapping table
- no need to prefix it with OSC
- since it's a page with a lot of content, make
  it show sub headings

Change-Id: I1aab4f71def53f1a11a8a0e0f6b7748233ff02c7
2017-02-22 14:19:38 -06:00
Steve Martinelli
4b293c57c8 add keystone and glance -> osc mapping
Change-Id: I99cd8b11a5d5fc6dc5d2f4584b837ea0f44d665a
2017-02-22 14:09:25 -06:00
Jenkins
3746fd2caf Merge "OSC Network Flavor" 2017-02-22 18:40:37 +00:00
Rui Chen
c828216e2b Fix "endpoint list" help message
OSC support to filter OpenStack endpoints by service type, name and ID,
but help message and document don't contain "type" for "--service"
option of "endpoint list" command.

Change-Id: I5c8bc28e037b4c6f96ec83525a319353f01f256a
Closes-Bug: #1666841
2017-02-22 17:56:03 +08:00
Rui Chen
10f0300f70 Show openstacksdk version info in "module list"
openstacksdk bug/1588823 exist, no good way to add __version__ for
openstack module properly, fix the issue in osc side, make openstacksdk
module information be available.

Change-Id: I27ff61792443d1aa07f31598bed3aa32f924ff40
Partial-Bug: #1662058
2017-02-22 16:40:22 +08:00
Anindita Das
edaeece7f1 OSC Network Flavor
Implements Neutron feature of Network Flavor into OpenstackClient
This patch implements the following commands:
network flavor create
network flavor delete
network flavor list
network flavor show
network flavor set

Works with openstacksdk version 0.9.8

Change-Id: I29d7a62341010a1d067a8ca93bccb7d9b8d4c425
Partially-Implements: blueprint neutron-client-flavors
Partially-Implements: blueprint network-commands-options
2017-02-22 02:45:51 +00:00
Jenkins
62938c02e0 Merge "Fix properties format for volume qos in volume v1" 2017-02-21 19:49:16 +00:00
Jenkins
7bf68577e6 Merge "Rework port functional tests on json output format" 2017-02-21 16:44:00 +00:00
Jenkins
ea08e16b08 Merge "add volume->osc mapping" 2017-02-21 16:16:33 +00:00
Jenkins
a3e1b9c31a Merge "add swift and nova to osc mapping" 2017-02-21 16:12:31 +00:00
Jenkins
35c308ebad Merge "Remove remaining uses of SDK Proxy.session" 2017-02-21 14:00:03 +00:00
Huanxuan Ao
1be6c2d92f Fix properties format for volume qos in volume v1
Notice that patch [1] fixed the error of properties
format for volume qos in volume v2, but there is the
same bug in volume v1, and the patch missed that, so
fix the problem in v1 as well

[1] https://review.openstack.org/#/c/421065/

Partial-Bug: #1656767
Change-Id: I156bf13d164dbd0d0a7ce394964176718c4ff0e5
2017-02-21 19:34:15 +08:00
Rui Chen
c7e0948a2d Rework port functional tests on json output format
Some functional tests try to parse the CLI table output
format, that cause much work on parse string by using
regular expression. Using json format in functional tests
is better and easier way, the patch rework for port related
tests.

Change-Id: I0ec997bf63da4925742848c593db09d89655ca34
2017-02-21 07:35:02 +00:00
Steve Martinelli
c9419f00f0 add volume->osc mapping
Change-Id: Ia773cf66c9949433eb5e5ab5c58b7c871c17fc22
2017-02-21 06:16:53 +00:00
Steve Martinelli
3a48183c01 add swift and nova to osc mapping
Change-Id: If3ab811868aaf8c9391a2190ff0af63b0e0ea559
2017-02-21 06:16:37 +00:00
Jenkins
bc4a3f467f Merge "TODO cleanup: osc-lib" 2017-02-21 05:40:26 +00:00
Justin A Wilson
4d5f2c3925 Add Cinder v3 client support for volumes
Initial Cinder v3 support

Change-Id: Idd5074832e80697ed0671f06d3291dfd92dbfb08
2017-02-20 20:37:36 +00:00
Jenkins
477694db49 Merge "Use public and unified method get_console_url()" 2017-02-20 19:46:15 +00:00
Jenkins
91f7451180 Merge "Remove text about OSC as a plugin requirement" 2017-02-20 18:54:55 +00:00
Dean Troyer
0719348ba1 TODO cleanup: osc-lib
osc-lib 1.3.0 is released, which contains these functions that still
need to be migrated all the way down to os-client-config.

Currently osc-lib 1.2.0 is in global-requirements so this can not be
merged yet, but is included here for testing and to be ready for when
g-r is unfrozen.

Change-Id: I7bc8ed6cf78f38bab4a718ed3e2a88641fa23f27
2017-02-20 17:35:42 +00:00
Dean Troyer
76c7ab5c85 Remove text about OSC as a plugin requirement
python-openstackclient should not be in a plugin's requirements.txt
as it will pull in the OSC dependencies that may not be desirable.

Change-Id: Id72745704ec70cab438e766dbac21a838fccb523
2017-02-20 09:37:54 -06:00
Anh Tran
1e3faf9f64 Remove unused logging import
Change-Id: I9edf4075ffea2e8d42283bd654b74cd4ab4a3638
2017-02-20 10:20:42 +07:00
Dean Troyer
73809a98ed Remove remaining uses of SDK Proxy.session
SDK commit Ie67c240e3caa5e100ce07db3862718195c894748 exposed lingering uses
of Proxy.session in OSC.  Get rid of them.

Change-Id: Icab230f1897a446cf3deb0e3d0550d24e11a0ef3
2017-02-19 15:47:20 -06:00
Jenkins
98d5641ac5 Merge "Remove quota set workaround for SDK <0.9.13" 2017-02-19 16:58:01 +00:00
Dean Troyer
74a35fb005 Finish converting server functional tests to JSON format
Change-Id: Ic9563bd86feb1f7afd403e49499205a499f0c142
2017-02-18 11:50:39 -06:00
Jenkins
83a0db0a54 Merge "Fix "server create" command failed when --nic auto or none" 2017-02-18 06:41:14 +00:00
Jenkins
bf10900c13 Merge "Functional test for router" 2017-02-18 06:25:16 +00:00
Jenkins
1b4605e4ad Merge "Add "volume host failover" command" 2017-02-18 06:25:10 +00:00
Jenkins
c88975136d Merge "Add "encryption-*" options in volume type commands" 2017-02-18 03:36:06 +00:00
Dean Troyer
b399b0406c Remove quota set workaround for SDK <0.9.13
Change-Id: I89732c49e73ac5a789fdbe19536389f7e93ac0e6
2017-02-17 13:28:48 -06:00
Dean Troyer
ef1a86a802 Fix image selection in server function tests
The image selection has been affected by Cirros image changes in DevStack,
make the logic moe robust and convert it to JSON.  The conversion for the
remainder of the file will follow.

Change-Id: I8f3318f55ed79d617c3594142f0c086e2bd1a7b1
2017-02-17 12:14:41 -06:00
Rui Chen
c051c5f090 Fix "server create" command failed when --nic auto or none
"auto" and "none" options was added into --nic argument of server create
command in patch https://review.openstack.org/#/c/412698/ , but that
don't work and raise internal error when execute command. The patch
fix that issue and add unit and functional tests.

Change-Id: Ia718c3bac0a5172a0cdbe9f0d97972a9346c1172
Co-Authored-By: Kevin_Zheng <zhengzhenyu@huawei.com>
Closes-Bug: #1663520
2017-02-15 14:25:37 +08:00
Jenkins
3b562ffa90 Merge "Handle log message interpolation by the logger in identity/" 2017-02-14 08:23:21 +00:00
Jenkins
f106b4f022 Merge "Refactor volume functional test in volume v1" 2017-02-14 08:01:03 +00:00
Jenkins
4b4194755a Merge "Handle log message interpolation by the logger in network/" 2017-02-14 03:52:43 +00:00
huangtianhua
f891b6862f Use public and unified method get_console_url()
Novaclient has provided a public and unified method
get_console_url() to get console urls of server.
This change switches to use it.

Change-Id: Ie6b9d8cfc57a6943b5d64a4064e4bdd372cd8cd3
Depends-on: I36c6209b17ef453e1c2e47841daf41f81af471dc
Closes-Bug: #1654913
2017-02-14 03:22:03 +00:00
Jenkins
f945cf7b5c Merge "Handle log message interpolation by the logger in compute/" 2017-02-14 01:28:54 +00:00
Jenkins
7aa7b3a76b Merge "Updated from global requirements" 2017-02-13 18:31:48 +00:00
Jenkins
655e73683a Merge "Overwrite/Clear Flavor property" 2017-02-13 18:19:26 +00:00
Gábor Antal
1c91e9828d Handle log message interpolation by the logger in compute/
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Change-Id: Ib7b5fb5f794026fc8a84260c4803afea321a9cf5
Closes-Bug: #1596829
2017-02-13 18:43:12 +01:00
Jenkins
10bd6a6267 Merge "Refactor availability zone functional test" 2017-02-13 17:41:20 +00:00
Jenkins
0c42c88d88 Merge "Refactor module functional test" 2017-02-13 17:27:39 +00:00
Jenkins
2cb1cee361 Merge "Modify error handling for role and group commands" 2017-02-13 17:27:33 +00:00
Jenkins
7f29e52106 Merge "Add choices for option '--policy'" 2017-02-13 17:27:30 +00:00
Jenkins
803d5b4c83 Merge "Add --fixed-ip option to the port list command" 2017-02-13 17:19:10 +00:00
Gábor Antal
c9b1c2ad96 Handle log message interpolation by the logger in network/
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
Related-Bug: #1596829

Change-Id: I17467d01420750c004fbbf2a07730fc2badd62b8
2017-02-13 18:14:34 +01:00
Jenkins
8c9fff3a82 Merge "DevRef fix for network qos policy" 2017-02-13 16:51:12 +00:00
Gábor Antal
335c8d3ef3 Handle log message interpolation by the logger in identity/
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Change-Id: I1d6588093616099a9eef0947c09e038b9e53493a
Related-Bug: #1596829
2017-02-13 17:38:30 +01:00
OpenStack Proposal Bot
ee50ca30c1 Updated from global requirements
Change-Id: Ie5af4a8ea6b499db46ad6f1d3075d867faf3a3a2
2017-02-13 15:21:11 +00:00
Reedip
6a3c7c2a68 Overwrite/Clear Flavor property
This patch adds support to overwrite/clear the flavor's
property using the new ``--no-property`` option in the
``flavor set`` command.

Change-Id: I873c96fcf223bbd638a19b908766d904a84e8431
Implements: blueprint allow-overwrite-set-options
Co-Authored By: zhiyong.dai@easystack.cn
2017-02-13 15:16:09 +00:00
Jenkins
30fdb488a8 Merge "Functional test for volume qos" 2017-02-13 14:25:55 +00:00
Jenkins
5a9b5f7cb9 Merge "Functional test for configuration" 2017-02-13 12:14:07 +00:00
Jenkins
5de97e385f Merge "Functional test for aggregate" 2017-02-13 08:51:14 +00:00
Huanxuan Ao
35b2724293 Refactor volume functional test in volume v1
There is a patch for refactor of volume funtional
test in volume v2 [1], but v1 is missing, this
change add the v1 refactor with json format.

[1]: https://review.openstack.org/#/c/417349

Change-Id: I969df3c8dbca21a62f6245e3e95680cf3cd47dc1
2017-02-13 15:59:27 +08:00
OpenStack Proposal Bot
e8eb0914ea Updated from global requirements
Change-Id: Ic337cb3e4a011938cab7ddc9ad29be0e9af83a4b
2017-02-11 17:52:00 +00:00
OpenStack Proposal Bot
df49c85007 Updated from global requirements
Change-Id: Ic3235a76147314b81290c63805118e5a8e7599a6
2017-02-10 05:59:24 +00:00
Jenkins
1c76c70d71 Merge "Fix --parents and --children options in project show" 2017-02-09 17:38:15 +00:00
Huanxuan Ao
cfd4e2a722 Modify error handling for role and group commands
if command failed, we usually raise exception,
if command success, sometimes there is not any
output (such as set, add commands)
So modify the error handling for role and group
commands.

Change-Id: I1c0f86c04dcedd9c0d725fd73f3436be9da75ee0
2017-02-09 19:49:55 +08:00
Rui Chen
4679a4c193 Fix --parents and --children options in project show
Options "--parents" and "--children" don't work in "project show"
command, fix the issue and add related unit and functional tests.

Change-Id: Id9965267a037442f1077f8e1929d0527981f643d
Closes-Bug: #1499657
2017-02-09 19:24:55 +08:00
Jenkins
46d1df0adf Merge "Functional test for agent" 2017-02-09 06:35:56 +00:00
Jenkins
2966bd0639 Merge "Functional test for server group" 2017-02-09 05:58:32 +00:00
Yan Xing'an
e0e46bca09 Add --fixed-ip option to the port list command
Add support to allow filtering ports via --fixed-ip
option to the port list command.

Change-Id: I2f728368d3046b2e6feadd0848bf6f8680e31aba
Partial-bug: #1634799
Partially-Implements: blueprint network-commands-options
2017-02-07 19:00:52 -08:00
Jenkins
e35c97a4fc Merge "Fix wrong behavior of parsing plugin service name" 2017-02-08 02:53:38 +00:00
Rui Chen
e8b6a9f7be Fix wrong behavior of parsing plugin service name
When the service name end with keyword "os", like: antiddos,
the parsing logic isn't suitable, that cause the service api
version specified by users don't work.

Change-Id: I5d6217c77d7cd2d2f360d78d8561261398b96685
Closes-Bug: #1658614
2017-02-08 00:47:22 +00:00
Rui Chen
3afd2b7ff2 Fix "module list --all" failed
KeyError cause the command "module list --all" failed,
fix it, and do refactor to filter private modules and
reduce the loop times, add related unit tests and
functional tests.

Change-Id: Icd77739502e05b5f763a04a92547497bf82d5d63
Closes-Bug: #1661814
2017-02-06 09:44:18 +08:00
Jenkins
083b115d09 Merge "TODO cleanup: OSC_Config" 2017-02-05 05:42:30 +00:00
Ankur Gupta
65ac887564 NIT: replace os with openstack in command example
Change-Id: Iac1b0ec3b715ffa0eb41fc2fe9020781d834a7a3
2017-02-03 13:51:36 -06:00
Steve Martinelli
43e37f9024 mention the final ocata osc version in releasenotes
we neglected to add the final osc version in our release note
page, it should be 3.8.1

Change-Id: I4291a09924ce8beb29c8c3aff18962a43f0241b0
2017-02-02 21:30:52 -05:00
Jenkins
b9cb26cfa3 Merge "Update reno for stable/ocata" 2017-02-02 22:10:00 +00:00
Huanxuan Ao
f8e8ace88a SDK refactor: Set "is_admin_state_up" for network agent
OpenStackSDK is >=0.9.13 now in requirement,
so we can update "is_admin_state_up" as well
for the SDK refactor

Change-Id: I02de0ebc752ce602032bbe9d73256ed376993e78
2017-02-02 11:57:45 +08:00
Dean Troyer
eea09faae2 TODO cleanup: OSC_Config
os-client-config is now at 1.22.0 in global-requirements, we can remove
this pw_func setting block as the pw_func arg to __init__() was added
in 1.21.0.

Change-Id: I5bbc3e3aae4f3e4c4333c73bba19bda65e0d8488
2017-02-01 17:31:39 -06:00
Dean Troyer
419668d178 Add mitaka release notes to master
Change-Id: I00b3abe0ac8765989a83e491f1dc53db22283bdd
2017-02-01 14:25:07 -06:00
OpenStack Release Bot
45c097c0b9 Update reno for stable/ocata
Change-Id: I91d3a23f5e449efbfe350ad633135b4d725fbbe6
2017-01-31 23:36:54 +00:00
Dean Troyer
1e3dc48c64 Add relnotes for the two recent bug fixes
Also add a functional test for network create --project

Change-Id: Idbfdf82f1ea6c84fb6a51df88e746e5ddb896b4f
2017-01-28 07:42:17 -06:00
Jenkins
a6817d0240 Merge "Fix network create --project" 2017-01-28 04:43:40 +00:00
Dean Troyer
fab4fcc397 Fix network create --project
SDK 0.9.13 needs to see project_id in the attributes, not tenant_id.

Closes-bug: 1659878
Change-Id: Iff7abe8bd00cbe087c07579596c40af8b0a73302
2017-01-27 20:05:04 -06:00
Dean Troyer
4a12280999 Fix address scope list --share
Remove the 'shared' key from the attrs passed in to the SDK with 0.9.13.

Also convert the functional tests to the JSON-style (that's how I found this).

Closes-bug: 1659993
Change-Id: I614fbce967cdd07fe7360242547dbf52e7677939
2017-01-27 19:56:44 -06:00
Jenkins
ca763793cc Merge "Updated from global requirements" 2017-01-27 01:23:19 +00:00
Jenkins
0004b828f7 Merge "Fix sphinx errors" 2017-01-26 20:57:02 +00:00
Andreas Jaeger
f58ae51ee2 Fix sphinx errors
It's :option: instead of :options:, fix typo.

Change-Id: I273d592f38db07fef7633fe833b1c0ab9e52e6a8
2017-01-26 19:52:31 +01:00
OpenStack Proposal Bot
dd7837a5e2 Updated from global requirements
Change-Id: I7d572ca8c0f2608180343e2ec9d41378cf15474f
2017-01-26 18:52:09 +00:00
Dean Troyer
16aeee4303 Cleanup for 3.8.0 release
Release notes and proofreading cleanups.

Change-Id: Iddc6a64e6ea3082aa220a2465793e6f7f2aecaa9
2017-01-26 10:41:30 -06:00
Jenkins
da2a820d2f Merge "Support "--no-property" option in volume snapshot set" 2017-01-26 06:38:31 +00:00
Jenkins
d189e807fd Merge "Add options to "server list" command" 2017-01-26 06:38:27 +00:00
Jenkins
d4c13676d1 Merge "Switch server create to block_device_mapping_v2" 2017-01-26 06:38:21 +00:00
Jenkins
029b389cf8 Merge "Adds domain specification for SetUser" 2017-01-26 03:01:10 +00:00
Nikita Gerasimov
95c8661f86 Switch server create to block_device_mapping_v2
Current compute_client.servers.create() relies on block_device_mapping
arg which is legacy[1]. "block_device_mapping" format require
device_name which is leads to hard-coded hack in --volume key handler
to KVM specific. "block_device_mapping_v2" format is more friendly
to hypervisiors.
Support of block_device_mapping_v2 appear in python-novaclient 2.16.0,
openstackclient require at least 2.29.0

Makes options --volume and --block-device-mapping work simultaneously.
Appends --block-device-mapping data even if --volume used.
After bug 1383338 only --volume was taken when both are used.

[1]http://docs.openstack.org/developer/nova/block_device_mapping.html

NOTE(dtroyer): I moved the new test_boot_from_volume() functional
test to Ie51b1c375c5940856ec76a5770df3c6bd18a3eba to test our
previous behaviour.  The only changes required to support the new
behaviour should be that the empty_volume is now attached in that test.

Change-Id: I7bac3d870dd9ca404093142f8bce22a62e49180d
Closes-Bug: 1647406
Closes-Bug: 1497845
2017-01-26 02:02:30 +00:00
Jenkins
a05e2762dc Merge "To support '--project' and '--project-domain' options" 2017-01-26 01:51:19 +00:00
Jenkins
51c418f8c3 Merge "Add server_boot_from_volume() test" 2017-01-26 01:40:14 +00:00
Jenkins
0cfb65bee7 Merge "Add server test for image and flavor lookups" 2017-01-26 01:36:11 +00:00
Jenkins
cb74397215 Merge "Fix Identity functional tests to not require OS_AUTH_URL" 2017-01-26 01:19:17 +00:00
Jenkins
55ea0e5b39 Merge "Add meter rule to OSC" 2017-01-26 01:19:10 +00:00
Jenkins
ade841fad0 Merge "Add 'allowed address pairs' option to 'port create/set/unset'" 2017-01-26 00:34:41 +00:00
zhiyong.dai
26d50be79a Support "--no-property" option in volume snapshot set
Supporting "--no-property" option will apply user a convenient
way to clean all properties of volume snapshot in a short command,
and this kind of behavior is the recommended way to devref.
The patch adds "--no-property" option in "volume snapshot set" command,
and update related test cases and devref document.

Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e
Implements: blueprint allow-overwrite-set-options
2017-01-25 17:32:58 -06:00
Jenkins
43f9370915 Merge "change assert_show_fields to not fail on new fields" 2017-01-25 23:13:35 +00:00
Jenkins
f14027867f Merge "Add --project and --project-domain option to "volume snapshot list"" 2017-01-25 22:27:39 +00:00
Jenkins
dec06aa89a Merge "Fix 'mapping set' return value" 2017-01-25 22:27:31 +00:00
Jenkins
e3f9ef956f Merge "Remove the fixed set of choices for network_type" 2017-01-25 22:26:37 +00:00
Samuel Pilla
4cb56269ad Adds domain specification for SetUser
This patch adds the ability to specify the domain context for making
changes to a user with `--domain` flag.

Example:
$ openstack user set test_user --domain test_domain --enable

Change-Id: I2b3241785c22e72e19181394acff650422299b0e
Closes-Bug: #1658147
2017-01-25 22:16:22 +00:00
jiahui.qiang
c46f9dc501 Add options to "server list" command
Add "--deleted" and "--changes-since" options to "server list" command.

Change-Id: Id94f6e5831a60b172b6cfcfca29b1d89de8db621
Closes-Bug:#1647242
2017-01-25 21:31:45 +00:00
Dean Troyer
d780e9e91f Fix Identity functional tests to not require OS_AUTH_URL
The Identity functional tests had an assumption that OS_AUTH_URL would
always be present, but when running the functional tests and only setting
OS_CLOUD (using clouds.yaml for creds) this fell down.

Change-Id: Ie589d301f866b06d9f8be8deeb953e03bc01cf09
2017-01-25 15:25:32 -06:00
Steve Martinelli
42ac82b1a4 change assert_show_fields to not fail on new fields
whenever a resource adds a field (which is allowed in our API
guidelines), OSC functional tests fail, because we validate
the resource keys to a hardcoded list.

instead, this change proposes that the logic of
assert_show_fields is flipped around, so our hardcoded list acts
as a minimum set of values that must appear in the resource.

as part of this change, some fields were remove from the constants
since they were not actually in the returned data.

also, delete unused code `assert_show_structure`.

Change-Id: I8c0f0e80ea472f9c7f93c5f1f0ae52048e6cd7da
2017-01-25 13:09:16 -08:00
Dean Troyer
5ecb353f89 Add server_boot_from_volume() test
Plucked this test out of I5529f412578c50090e70d17aa0129217bf803fed in
order to validate the current behaviour before applying that change.
It was converted to the new JSON-style.

Change-Id: Ie51b1c375c5940856ec76a5770df3c6bd18a3eba
2017-01-25 19:56:34 +00:00
Colleen Murphy
365d839a5b Fix 'mapping set' return value
Without this patch, the command 'openstack mapping set <args>' will,
upon success, print the rules for the updated mapping and exit with
return code 1 (failure). This is a problem for scripts and config
management tools that depend on the return code to validate whether the
operation was successful, since even upon success the command returns a
failing error code. Moreover, the behavior of printing the new value is
completely unlike the behavior of any of the 'set' subcommands for
other entities. This patch normalizes the 'mapping set' command by
omitting any return value in the SetMapping take_action() method. This
way the client will only exit with an error code if an exception is
raised, and not upon normal operation.

Change-Id: I610ec3b2fa7561072346d46e49cfc1ae82130e0d
2017-01-25 18:07:17 +01:00
Dean Troyer
9ada3b529d Add server test for image and flavor lookups
Review Ia66e44e530799ce6531922dcf6a84e38528c8725 changes OSC's server
commands to use the image client rather than compute clirnt (yay!)
but we never really tested any of this in functional tests.  This review
adds a simple functional test (in the new style) to watch the client
change; it passes locally for me without the client change, due to timing
we went ahead and merged that first.

Change-Id: I5529f412578c50090e70d17aa0129217bf803fed
2017-01-25 02:34:27 +00:00
OpenStack Proposal Bot
b69b539a42 Updated from global requirements
Change-Id: I7b0e46de18f10cde110e1957c12210bc3271e7f9
2017-01-25 00:55:54 +00:00
Jenkins
414c99b3aa Merge "Use image client for images instead of compute" 2017-01-25 00:12:36 +00:00
Artom Lifshitz
98f803e0f0 Use image client for images instead of compute
With the deprecation of the Nova proxy APIs in microversion 2.36 [1],
any operation that uses a microversion higher than 2.36 and works with
images will fail because the /images endpoint will return 404. This
patch updates openstackclient to query images using the image client
in places where previously the compute client was used.

[1] http://docs.openstack.org/developer/nova/api_microversion_history.html#id33

Change-Id: Ia66e44e530799ce6531922dcf6a84e38528c8725
Closes-bug: 1630161
2017-01-24 16:56:35 +00:00
Jenkins
0ef6fc0ae8 Merge "Functional tests debug support" 2017-01-24 16:44:03 +00:00
Jenkins
bfad2abf23 Merge "Fix OSC networking commands help errors" 2017-01-24 15:35:33 +00:00
Jenkins
1ef0dae8b1 Merge "Update container format choices" 2017-01-24 15:30:08 +00:00
Jenkins
11ef43da49 Merge "Functional tests - port" 2017-01-24 06:06:31 +00:00
Jenkins
c9de2d67e9 Merge "Handle 403 error on creating trust" 2017-01-24 04:16:28 +00:00
Brian Rosmaita
80c62021c8 Update container format choices
The choices for valid container formats is out of date in the
image v1 and v2 help text.  This patch adds 'ova' and 'docker'
and does some minor refactoring to align the container_format
option with the disk_format option.

Change-Id: Icdea5fab801abd651baf45cf96c920c7df79f11b
Closes-bug: #1658138
2017-01-23 23:04:49 -05:00
Hongbin Lu
5cf77bb672 Handle 403 error on creating trust
Currently, creating trust requires permission to list roles, but
non-admin users don't have permission to do that by default. This
commit adds exception handling on listing roles, and continue to
create trust if server returns 403.

Closes-Bug: #1658582
Change-Id: I4f016b76cb46ae07ef65ed54780881bbcd6210d3
2017-01-24 01:50:36 +00:00
Jenkins
30ddab2341 Merge "SDK refactor: Prepare security group commands" 2017-01-24 01:24:26 +00:00
Jenkins
0d7f27bc00 Merge "Update devref about "--no-property"" 2017-01-23 21:54:00 +00:00
Abhishek Raut
ab88573ebb SDK refactor: Prepare security group commands
Prepare the OSC "security group" commands for the SDK refactor.

Change-Id: If9918fad2474f9b4d68424f2806f0de61fd58b2e
Partially-Implements: blueprint network-command-sdk-support
2017-01-23 19:18:23 +00:00
Jenkins
d5745eaaa7 Merge "TrivialFix in helpMessage for readability" 2017-01-23 09:41:53 +00:00
Ankur Gupta
5caac0e563 Add meter rule to OSC
Implement network feature meter label rules into
OpenStack Client.

Allows for creation of rules to meter
network traffic.

Partially Implements: blueprint neutron-client-metering

Change-Id: If18c078d7e80c122583417669f820f02c84d6237
2017-01-23 00:24:35 +00:00
Rui Chen
274687d852 Update devref about "--no-property"
Update the example about "--no-property" and "--property"
to make help message order more reasonable, that help make
users aware of the processing order, and update the help
details when both "--no-property" and "--property" appear
in the same command.

Change-Id: I998cdaf2f8c881dce219581ff328a639e8e358ee
Implements: blueprint allow-overwrite-set-options
2017-01-22 06:30:35 +00:00
Rui Chen
4d9da2c40a Fix OSC networking commands help errors
OSC networking commands need to authenticate to get
service catalog, then decide to show nova-network or
neutron command help message. Fake token and fake
auth_type in prepare_to_run_command() casue os-cloud-config
use AdminToken auth plugin, but pass all the auth information
(include: username, password and so on) to it, that casue the
class initialization error. Pop the fake token and url, then
try to load auth plugin again to fix the issue.

Change-Id: I8b140f0b0a60681fc2a35a013bb0c84ff8cb9589
Closes-Bug: #1650026
2017-01-22 06:30:31 +00:00
Rui Chen
fd0ac815de Functional tests debug support
Pass OS_* options into tox debug venv in order to
debug functional tests in local, and install ipdb
to make code-debug more convenient.

Change-Id: Ib926948f2b9a52921cf7487fe16ef716481e3ceb
2017-01-22 06:30:15 +00:00
jiahui.qiang
4f4af3d67d Switch to use cleanup method in functional test
Switch the delete command in subnet and router functional tests. Because
addCleanup will also work when an assertion fails ,except the test is for
testing delete command.

Change-Id: I33634f5148c4895c7cf4d4773a9c33c8368850c7
2017-01-21 18:22:26 +08:00
Jenkins
607f31d3db Merge "Fix port command for SDK >0.9.10" 2017-01-21 06:18:14 +00:00
Jenkins
bf3f12f596 Merge "Error in the return of command 'volume qos create'" 2017-01-21 06:18:08 +00:00
Jenkins
64c509cf76 Merge "Functional test for volume snapshot" 2017-01-19 01:20:35 +00:00
Jenkins
854e515ce6 Merge "Fix functional test for creating subnet" 2017-01-18 23:53:32 +00:00
Jenkins
a61c7cbba9 Merge "Fill the missing colon" 2017-01-18 21:10:19 +00:00
Huanxuan Ao
4a8e7dbe6b Fix functional test for creating subnet
subnet create failed by some bad random
subnet range, so retry it with new random
range when the test failed.

Change-Id: If528ff419b51dd5c5232f81d4b26abae542bd820
2017-01-18 19:33:05 +00:00
jiahui.qiang
f96cff1a6d Functional test for router
Refactor functional tests for testing more command options.

Change-Id: I6200045c6228e245fc48a4d48d4b3796dede61b5
2017-01-19 01:26:08 +08:00
Jenkins
8d453e2641 Merge "Add plugin adoption for trove" 2017-01-18 03:21:47 +00:00
jiahui.qiang
b201a11b42 Functional test for subnet
Refactor functional tests for testing more command options.

Change-Id: I030652f6f3ab3dada12252599b20969f03a5df02
2017-01-18 10:52:16 +08:00
jiahui.qiang
9fd145edbf Functional test for volume qos
Refactor functional tests for testing more command options.

Change-Id: I6d5a82eb0e84f72e8da76b17c952e4daae9dbc08
2017-01-18 09:00:53 +08:00
YAMAMOTO Takashi
61a22a285a Remove the fixed set of choices for network_type
So that it can specify out-of-tree ML2 type drivers.

Closes-Bug: #1657311
Change-Id: I2445fb165b86cf5937d8aa09ba0fd5564eb1f8f4
2017-01-18 09:38:23 +09:00
Trevor McCasland
ab1f637f55 Add plugin adoption for trove
With I308a6c6f3f5ce7dbb814ec0fd8ecb1734a2f137f merged in the
python-troveclient project, trove can now say it has adopted the
plugin.

What commands that actually get implemented for this cycle, is to be
determined. Another patch adding more commands to the docs will be
proposed later when they get merged.

Change-Id: If2c2545dd5d1510cc6eece698e34ad0f8c1b970f
2017-01-17 19:26:48 +00:00
Jenkins
08ca61ba07 Merge "Fix quota set command error for SDK > 0.9.10" 2017-01-17 17:23:54 +00:00
jiahui.qiang
89d9449dcf Error in the return of command server show, create
The raw output in the command 'openstack server create'(also in show) is
used in display table directily. the item like
os-extended-volumes:volumes_attached and security_groups needs to convert.

the worry output:
  os-extended-volumes:volumes_attached | [{u'id': u'c3525de9-1cbf-4ac8-8b7a-ca295c46633b'}]
  security_groups                      | [{u'name': u'default'}]

Change-Id: Id9db251c315f989e1dc5b1b6231ab328014213e3
2017-01-17 17:49:16 +08:00
jiahui.qiang
f353253122 Error in the return of command 'volume qos create'
This patch fixed a 'volume qos create' display mistake in argument
of 'specs'[1]. For command such as:

 $ openstack volume qos create hello

 [1]https://bugs.launchpad.net/python-openstackclient/+bug/1656767
Closes-bug:#1656767

Change-Id: Ia9fce833d318d9b52b97c12cfb89e2d3c5465fbe
2017-01-17 15:19:22 +08:00
Jenkins
e853d93a04 Merge "functional test for volume" 2017-01-17 06:03:18 +00:00
Jenkins
1d9935aaa1 Merge "Update functional test for aggregate." 2017-01-17 01:22:10 +00:00
jiahui.qiang
dc3b83590a Functional test for volume snapshot
Refactor functional tests in volume snapshot.

Change-Id: I2fcc468096b3a26c83b8af1e379a62c80eb9c63e
2017-01-17 08:33:12 +08:00
zhiyong.dai
2476a26d99 Update functional test for aggregate.
Add the following functional tests :
    option: "--no-property"
    command: "aggregate set --zone",
             "aggregate add host",
             "aggregate remove host".

Change-Id: Ia9c31facb5f0f5b92b8df950fd4021b8ecc924c5
2017-01-16 20:58:33 +00:00
OpenStack Proposal Bot
603543bb71 Updated from global requirements
Change-Id: Ic8eef0aa955d747ae7edf19761f8d682cf95d63f
2017-01-16 17:28:09 +00:00
Dean Troyer
4d3cfb9142 Release 3.7.0 cleanup
Change-Id: I75d9e2473461e316086cfad8c886c6b7d22ecd5e
2017-01-15 11:01:32 -06:00
Jenkins
c7d3f4eae9 Merge "SDK refactor: Prepare network agent commands" 2017-01-15 16:12:56 +00:00
Huanxuan Ao
0340275fa9 Fix quota set command error for SDK > 0.9.10
A bug in OpenStack SDK 0.9.11 and 0.9.12 that causes
quota set command to fail. This can be removed when
the proposed SDK fix (https://review.openstack.org/#/c/419911/)
is released and in the minimum SDK version in global requirements.

Closes-Bug: #1655445
Change-Id: I63132f5f762f0120282f8b92e72512763063e3c6
2017-01-15 20:00:53 +08:00
Huanxuan Ao
b860ba0e42 SDK refactor: Prepare network agent commands
Prepare the OSC "network agent" commands for the SDK refactor.

Partially-Implements: blueprint network-command-sdk-support
Closes-bug: #1656542
Change-Id: I6745f5ffb04b009487e6cb36d1807dce9b248b4c
2017-01-15 19:29:51 +08:00
OpenStack Proposal Bot
d9361cbb70 Updated from global requirements
Change-Id: Idb49f1e126d1dab070894e2fc70c78b9984f988a
2017-01-15 09:28:59 +00:00
Jenkins
368666194b Merge "Fix quota show --default command" 2017-01-15 05:51:42 +00:00
Steve Martinelli
4c5cea46be unskip port test
seems like we fixed this one when fixing other tests but never
unskipped it.

Change-Id: Id1a3d11b581b6f72ad62a8699899b6163c3870bb
2017-01-14 18:36:28 -05:00
Jenkins
bbdf58298a Merge "Use git+file urls instead of directories" 2017-01-14 23:25:22 +00:00
Jenkins
d35374e33f Merge "Fix network functional tests for sdk 0.9.12" 2017-01-14 23:11:28 +00:00
Jenkins
1d41bb460f Merge "Fix floating IP delete and show by IP" 2017-01-14 21:25:22 +00:00
Monty Taylor
63cdf079b1 Use git+file urls instead of directories
The /opt/stack/new directories are owned by the wrong user, so python
setup.py egg_info fails because it can't create the egg_info dir.
Changing the invocation to use git+file:// urls solves the problem.

Additionally, make a correction to test collection.

Change-Id: I39da0b26417dce1a72b15dedc02d10284329307f
2017-01-14 20:40:17 +00:00
Dean Troyer
819526591e Fix quota show --default command
Work around a bug in OpenStack SDK 0.9.11 and 0.9.12 that causes
quota show --default to fail.  This can be removed when the proposed
SDK fix (https://review.openstack.org/420301) is reelased and in the
minimum SDK version in global requirements.

quota set --network is still broken, I can't fix it at the moment...

Closes-bug: 1656572
Change-Id: Ice77e14782c33e672176afbab36bba95b73d7a11
2017-01-14 13:55:19 -06:00
Steve Martinelli
a76d38119b Fix network functional tests for sdk 0.9.12
it seems the SDK returns "is_default", but doesn't actually set
it based on --default or --is-default

I already had these functioanl tests mostly converted to JSON, so I dumped
that in here too to make the is_default stuff cleaner.

Change-Id: I47ca62f57c73aa7fa984ca54742fc86b6bb837c4
2017-01-14 13:45:59 -06:00
Dean Troyer
339af2c20b Fix floating IP delete and show by IP
The floating IP delete and show commands did not work using IP addresses
as the selector, only ID.  The SDK floating_ip resource does not support
but OSC does, so we have to do it ourselves.

Now with more SDK 0.9.10 support!

Change-Id: Iea1b57cded6b16a56a06af87ab8f1fa001a3485e
Closes-bug: 1656402
2017-01-14 10:55:12 -06:00
Huanxuan Ao
b2fd8ba869 Add "encryption-*" options in volume type commands
Add "--encryption-provider", "--encryption-cipher",
"--encryption-key-size" and "--encryption-control-location"
options to "volume type set" and "volume type create" commands.
Add "--encryption-type" option to "volume type unset",
"volume type list" and "volume type show" commands.

Change-Id: I3572635d5913d971a723a62d7790ffe0f20ec39a
Implements: bp cinder-command-support
Closes-Bug: #1651117
2017-01-14 21:58:33 +08:00
Huanxuan Ao
7329e640db Fix subnet creating failure in functional test
Noticed sometimes floating ip func test failed[1].

The first mumber of the address seems like cannot
bigger than 223. So specify subnet ranges as the
random number between 0 to 233, maybe it will safer
for our functional tests.

[1]: http://logs.openstack.org/50/418650/12/check/gate-osc-dsvm-functional-ubuntu-xenial/e163f68/console.html#_2017-01-14_06_58_35_930306

Change-Id: I44a23bce851dcf2009c8d77059cf75ed80145fb0
2017-01-14 21:26:16 +08:00
Jenkins
339ab40ee6 Merge "fix functional tests for network agents" 2017-01-13 22:18:39 +00:00
Jenkins
d9f236b258 Merge "Fix security group rule list for NEtwork v2" 2017-01-13 21:05:32 +00:00
Steve Martinelli
14ff3ba19e fix functional tests for network agents
As of SDK v0.9.11 the get_agent method no longer supports
the "ignore_missing" parameter.

Change-Id: Id655bf8499ed1a102a6bf583927cf66139581ab0
2017-01-13 12:07:27 -08:00
Dean Troyer
5988ee61d8 Fix security group rule list for NEtwork v2
Fix the formatting of Port Range in the security group rule list command
for Network v2 to handle SDK changes.

Change-Id: Id954cbfaedbb74f60125ebda91f80db751759933
2017-01-13 12:00:49 -06:00
Jenkins
f8e2cf80a1 Merge "Install from /opt/stack/new instead of git.o.o" 2017-01-13 14:43:44 +00:00
Monty Taylor
64385002ea Install from /opt/stack/new instead of git.o.o
Installing directly from the git url will bypass any depends-on
processing zuul may have done on the dependent repos.

Change-Id: I3dadacf7a855cc4efad701f0a6275d6cd60efd72
2017-01-13 02:29:38 +00:00
Jenkins
1880527e60 Merge "Fix quota show output" 2017-01-13 00:05:32 +00:00
Jenkins
ff120c847d Merge "unskip network qos rule type functional test" 2017-01-12 23:44:01 +00:00
Reedip
024bd3bd66 Fix quota show output
Currently Quota Show expects dictionary to be returned
for Network client, similar to Volume and Compute clients, but
Network Object is being returned, causing the "openstack quota show"
to fail.
This patch takes care of this issue.

Depends-On: Ie0e045ff4888615d68804fd739d5b995ca11e9a1
Change-Id: Ic507997cba09fcfa84dd1151d6922f56a7c5187b
Closes-Bug:#1655537
2017-01-12 22:10:32 +00:00
Jenkins
a9af66e04b Merge "Fix image member unit tests occasional failures" 2017-01-12 19:54:46 +00:00
Steve Martinelli
511b7880ea unskip network qos rule type functional test
with the SDK at 0.9.12 the below test fails with:

'minimum_bandwidth' not in

+-----------------+
| Type            |
+-----------------+
| dscp_marking    |
| bandwidth_limit |
+-----------------+

So remove 'minimum_bandwidth' from the asserted fields.

Change-Id: I24ff691ae5a946d901afa763973305025829280b
Closes-Bug: 1653137
2017-01-12 14:16:48 -05:00
Dean Troyer
96f3c7e783 Fix image member unit tests occasional failures
Let's try just unrolling the member status tests and not getting
too fancy here.

Change-Id: I30022ebd2da6d6cf1abba424d7d7fa679285f291
2017-01-12 10:50:07 -06:00
Pavlo Shchelokovskyy
e637e9c6c8 Fix flavor create help re swap size units
nova actually expects and uses swap size in MB, while in openstackclient
currently help states that swap must be specified in GB and passes this
value to nova without changes.

Fix the help string.

Change-Id: I95f46246c072961ce77f818d80d75e6a51f728d0
Closes-Bug: #1656018
2017-01-12 18:27:14 +02:00
Rodolfo Alonso Hernandez
4b2355b3e3 Fix Network QoS rule CLI attrs parsing
Allows to set zero values in the CLI parameters for
Network QoS rule.

Change-Id: Ie0e045ff4888615d68804fd739d5b995ca11e9a1
Closes-Bug: #1655947
2017-01-12 13:21:07 +00:00
Jenkins
c8c29e8c2e Merge "Add unit test for multi volume types delete" 2017-01-12 03:13:22 +00:00
Jenkins
2fb5ac0cc4 Merge "Add support for Network QoS rule commands" 2017-01-11 23:37:00 +00:00
Jenkins
3c031bbb68 Merge "Add two consistency group commands" 2017-01-11 23:12:38 +00:00
Huanxuan Ao
28f9a9c621 Add unit test for multi volume types delete
Missing unit test for multi volume types delete
in volume v2 (v1 has been done), this patch add
it.

Change-Id: I5fe67196408157f8bdfe6399ba1e559cea3dc559
2017-01-11 22:30:04 +00:00
Jenkins
365d4c9ef8 Merge "Error handling for delete commands in identity" 2017-01-11 22:28:19 +00:00
Jenkins
08fc39e9b0 Merge "Add support for Glance 'update image members' feature" 2017-01-11 22:28:06 +00:00
Jenkins
e2f745b692 Merge "add support for running tests with master dependencies" 2017-01-11 22:27:25 +00:00
Jenkins
afba7832a6 Merge "Fix filter error in os volume list" 2017-01-11 19:01:13 +00:00
Steve Martinelli
d98b72c245 add support for running tests with master dependencies
we can create a new infra job that points to the new test hook,
which should install the master version of the SDK, osc-lib
and os-client-config.

Change-Id: Ib6391893b2302bdc514525d5ddda886fe8c60100
2017-01-11 18:56:07 +00:00
Badhmapriya Boopalan
6962cc963e To display image size in human friendly format
Include option '--human-readable' to 'image show' command.
This option displays image size in human readable format
(such as K, M, G, T,..)

Related Commit: I0ef74c2ec978483fe49156c88acf5c369a8fa5c2
Closes-Bug: #1640086
Change-Id: I28cd5702925d51303d0607ed8dccf12c56434682
2017-01-11 02:09:02 +00:00
OpenStack Proposal Bot
89b7488d2f Updated from global requirements
Change-Id: I3f06e0a50c4d8232796f2e42ce07eb40a139d1c4
2017-01-10 09:42:23 +00:00
Jenkins
b55b1d2b94 Merge "Make 'object save' fast again" 2017-01-09 22:12:26 +00:00
Rodolfo Alonso Hernandez
6b114cd98f Add support for Network QoS rule commands
Added following commands:
  - network qos rule create --type minimum-bandwidth
                                   dscp-marking
                                   limit-bandwidth
  - network qos rule delete
  - network qos rule list
  - network qos rule set
  - network qos rule show

Closes-Bug: 1609472
Depends-On: I2e8869750024a8ccbc7777b95fe8ef6e26ec0885
Depends-On: Ife549ff6499217ca65e2554be8ef86ea7866b2d8

Change-Id: Ib3e1951f0917f5f23c8d9e0a380d19da2b3af5f0
2017-01-09 18:05:30 +00:00
Jordan Pittier
1cdc1319d6 Make 'object save' fast again
'openstack object save' is critically slow to download big objects. While
we 'stream' (chunked download) the data, the default chunks_size
is 1 byte [1], which is terribly inefficient.

[1] : http://docs.python-requests.org/en/master/api/#requests.Response.iter_content

Closes-Bug: 1654645


Change-Id: I2223e5897346acd2f2c1fae638d1193cff833c19
2017-01-09 16:19:29 +00:00
Nir Magnezi
142c5faae3 Fix Octavia gate breakage caused by _get_columns()
The above mentioned function tries to extract keys() from an item which
is type class.

This patch fixes the issue by converting item to dict by using
to_dict().

Change-Id: Ida520ae9fe64171d105f486ba06eda127a24547b
Closes-Bug: #1654887
2017-01-09 16:44:08 +02:00
jiahui.qiang
07ade2266c functional test for volume
Rework functional tests to remove resource create/delete from
setupClass() and teardownClass() methods.
Add test for more command options

Change-Id: I2b6ad1fce26f04c11ed43f8d73515fde4a7d09af
2017-01-09 17:34:44 +08:00
jiahui.qiang
8e277c64fb Fix port command for SDK >0.9.10
The port functional test can not be passed in my local environment.
When 'dns_assignment' is None, the port create, show command will
fail because parameter for 'utils.format_list_of_dicts' can not be
None.

Change-Id: Iebf16fb7ca681660c2b9ee7839a0629f38c6a38a
2017-01-09 12:23:03 +08:00
jiahui.qiang
51ea68ae94 Fix filter error in os volume list
This patch fixed a bug of unable to filter volume list by '--project',
'--user' in "openstack volume list".
Modify uint test for 'volume list' to check parameter of list method.

Change-Id: I1fc4296c4c7eca0f7a803dbfd5e15e3bc0d6403f
2017-01-09 00:03:11 +08:00
Jenkins
1957690754 Merge "Functional tests - flavor" 2017-01-08 15:01:50 +00:00
Jenkins
6084538658 Merge "Remove unneeded methods from OS_Config class" 2017-01-08 15:01:42 +00:00
Jenkins
4b2ceece28 Merge "OSC Network Meter" 2017-01-08 05:55:52 +00:00
Jenkins
4811b95d1e Merge "Add options to allow filtering on agent list" 2017-01-08 03:54:19 +00:00
jiahui.qiang
27e0be0517 Add --project and --project-domain option to "volume snapshot list"
Add "--project" and "--project-domain" option to volume v2's
"volume snapshot list" command, it will filter list result by different project.

Change-Id: I7dccd6d8d9f1889fa9cb0c2d04a42d77975c645b
2017-01-07 22:21:11 +08:00
Jenkins
33602fb4f4 Merge "Fix network service provider functional test" 2017-01-07 11:11:04 +00:00
Steve Martinelli
29146ab684 add domain id to expected IdP fields, unskip tests
commit Id18b8b2fe853b97631bc990df8188ed64a6e1275 added domain IDs
to an Identity provider, our functional tests have a hard match
on what to expect when 'showing' an idp, the domain ID was missing.

Change-Id: I87a1fd762918551c533668a9aa94f7c6268b79d6
2017-01-07 00:24:52 -05:00
Steve Martinelli
a6bfea9c6f skip tests related to SDK 0912 and keystone IdP change
the gate is super wedged, i will skip tests and unskip them
as necessary.

Change-Id: Ia4469738c876ec1293f91b96dcc7d15365f4f37d
2017-01-07 00:09:32 -05:00
Dean Troyer
f825c9b81b Functional tests - flavor
* Rework functional tests to remove resource create/delete from
  setupClass() and teardownClass() methods.
* Add tests for more command options
* Use JSON output

Change-Id: Ib99ef954fe8e1170c7445940180d80b8b9c0a92c
2017-01-06 14:03:39 -06:00
Jenkins
8cf99c3866 Merge "Fix "ip availability show" command" 2017-01-06 17:58:49 +00:00
Zhou Zhihong
2e78c11c8d Add options to allow filtering on agent list
Add options to allow filtering via --agent-type
and --host on agent list

Change-Id: I1800f0777aa92a76b4b95f64f8acc18454809e81
Closes-Bug: #1641868
Partially-Implements: blueprint network-commands-options
2017-01-05 22:23:01 -08:00
Jenkins
221cb5318e Merge "Fix creating a private flavor with ID auto" 2017-01-06 05:57:35 +00:00
Huanxuan Ao
d80b1465e6 Fix network service provider functional test
SDK refactor broken network service provider
functional test, tested this command works,
but there is a error in the funtional test,
so fix it.

Change-Id: I783c58cedd39a05b665e47709b2b5321871e558b
Closes-Bug: 1653138
2017-01-06 13:37:32 +08:00
Huanxuan Ao
99aeff4967 Fix "ip availability show" command
SDK refactor broken ip availability show functional
test, We can not find a ip availability by network
name but only network ID, so we find network and
get the ID first, then find the ip availability
by the network ID.

Closes-Bug: 1653139
Change-Id: I246163fb875e2cdb9e5b091bac500a94268e8aa9
2017-01-06 12:59:41 +08:00
OpenStack Proposal Bot
4d15a2a8fc Updated from global requirements
Change-Id: Ie7b85846889a74026130c89ef37fe38bf8727ce3
2017-01-05 20:30:36 +00:00
Jens Rosenboom
d8749f9148 Fix creating a private flavor with ID auto
When a private flavor is created with ID auto (=default) and a project
is specified for it, instead of trying to add the project to the flavor
called "auto" the ID of the newly created project should be used.

Change-Id: I19f7a0ec26bd5d147f00ecba3312240e3601567e
Closes-Bug: 1654221
2017-01-05 15:58:47 +01:00
Dean Troyer
e0813cc54e Functional tests - port
* Rework functional tests to remove resource create/delete from
  setupClass() and teardownClass() methods.
* Add tests for more command options

Change-Id: Ic77df94fe5980e60c6a67cbf061b9a9dc601518f
2017-01-05 07:49:58 -06:00
Jenkins
82e69428f5 Merge "Update the description format" 2017-01-05 03:32:47 +00:00
Jenkins
b957ba8d92 Merge "Fixes image api URL endpoint for certain scenario" 2017-01-04 23:05:24 +00:00
Jordan Pittier
f055fe67c1 Add support for Glance 'update image members' feature
This patch adds 3 new options to the "image set" command: --accept,
--reject and --pending. This updates the membership status for
an image.

Closes-Bug: 1620481
Change-Id: I13b8c067aad68ece9ff636fbdd83bcb3663c91b2
2017-01-04 19:26:01 +01:00
Imtiaz Chowdhury
1bd2bf67da Fixes image api URL endpoint for certain scenario
openstackclient fails to get image list when the image api endpoint
has 'v2' substring in the URL. Instead of checking whether the api
endpoint URL terminates with '/v2', the current logic is checking
whether 'v2' appears anywhere in the endpoint string.

This issue was discovered on a production setup where certain
server names had 'v2' in their names. For example, when a hostname
is gopher.dev20.com, the image list APIs fail.

This commit updates the unit test to reflect this scenario. Without
the change in openstackclient/api/image_v2.py, all the unit tests
fail.

Co-Authored-By: sergio.carvalho@workday.com
Change-Id: I26b85afd646938272dbabe8e045b337b7df58c7d
Closes-Bug: 1652827
2017-01-04 18:14:10 +00:00
Jenkins
5750ff920e Merge "Show team and repo badges on README" 2017-01-04 17:46:42 +00:00
Dean Troyer
c6aceb78b7 Remove unneeded methods from OS_Config class
These are in the minimum required version of osc-lib (1.2.0).

A few methods remain that need to be released in osc-lib, expect them
in the 1.3.0 release soon.

Change-Id: I2333946da9a73e73377b646e4c06e99597990945
2017-01-04 11:43:30 -06:00
Jenkins
e6e3cd295c Merge "Beef up address scope functional tests" 2017-01-04 11:30:05 +00:00
Jenkins
c416aecb2f Merge "Add ":option: " in the help message" 2017-01-04 10:08:50 +00:00
Jenkins
6707957c87 Merge "Beef up network functional tests" 2017-01-04 04:46:48 +00:00
Jenkins
385b87c6f6 Merge "Beef up floating IP functional tests" 2017-01-04 04:46:03 +00:00
Huanxuan Ao
96578cb8ab Error handling for delete commands in identity
Add missing multi deletion error handling for
identity delete commands.
All delete commands in identity support
error handling now.

Change-Id: I05626dcb5e516a423d610906347b02236ba7eeaf
2017-01-03 23:30:49 +08:00
zhiyong.dai
be9e60be4b Update the description format
In network_qos_rule_type.py, network_service_provider.py, server.py and
volume_snapshot.py, the description format is using """ """.
In this patch, the former format is replaced with "_description = _( )".

Change-Id: I6863b01d3534e033df745070037ee45286745c92
2017-01-03 21:31:54 +08:00
zhiyong.dai
75f2875a6e Add ":option: " in the help message
This patch mainly adds  ":option:` `" in several help messages in the doc.
This modification will create one link which helps the readers find the relative
option quickly and conveniently in website.

Change-Id: Ia047e15c3b2064e4822ee7df7922d4774d862602
2017-01-03 12:13:10 +08:00
Ankur Gupta
0fb1378c6c OSC Network Meter
Implement Neutron feature of Metering into
OpenStack Client.

Meter Rules will be implemented in seperate
patchset.

Partially Implements: blueprint neutron-client-metering

Change-Id: Ie82d42759504cbdb1c991c5183c1f0adf59e60fe
2017-01-01 17:50:19 -06:00
Dean Troyer
3da71c819d Beef up floating IP functional tests
We need to get more thorough in our functional testing, so start by
adding tests for create options.

This also removes the parts of the setupClass() and teardownClass()
methods that do not pertain to the static prereqs for testing.

Change-Id: I0a090a8abc41613d8970343d1b67d101b4c82c65
2016-12-30 16:23:49 -06:00
Dean Troyer
241e0ec1cd Beef up address scope functional tests
We need to get more thorough in our functional testing, so start by
adding tests for all create and set options, check return values.

This also removes most of the setupClass() and teardownClass()
methods as they held common state that was subject to race conditions
when running tests in parallel.

Change-Id: Ib337f9e9d16b4183bb319b58cbe943045f365ff2
2016-12-30 15:15:29 -06:00
Dean Troyer
22cee104ed Beef up network functional tests
We need to get more thorough in our functional testing, so start by
adding tests for all create and set options, check return values.

This also removes most of the setupClass() and teardownClass()
methods as they held common state that was subject to race conditions
when running tests in parallel.

Change-Id: I4179f493cea971b7c576ffbf501330b5c57f52f3
2016-12-30 14:36:10 -06:00
licanwei
0948aa6aeb update server migrate '--wait' description
'Wait for resize to complete'
==>
'Wait for migrate to complete'

Change-Id: I0e08968c0132f0a8e1ef1ce2e6179001315372c3
2016-12-30 14:16:32 +08:00
Jenkins
f020a9ffd6 Merge "Revert "WIP: Skip broken functional tests..."" 2016-12-30 02:13:52 +00:00
Dean Troyer
13c8a1c7aa Revert "WIP: Skip broken functional tests..."
SDK 0.9.11 caused some failures, its blocked now.  Revert those breakages
that occurred in 0.9.10 -> 0.9.11.

This partially reverts commit 188e32f9e6.

Change-Id: I8b350250dbdcbf5c4599dfb55f6685c0db18bb30
2016-12-29 08:58:12 -06:00
OpenStack Proposal Bot
17a249c5dd Updated from global requirements
Change-Id: I9fbd59f515a49e881fa8927c880087e3c814c362
2016-12-28 09:16:21 +00:00
Jenkins
317cbe2c6e Merge "Fix a spelling error" 2016-12-28 03:16:01 +00:00
Jenkins
6a2fa098d0 Merge "Fix typo in release notes" 2016-12-28 03:14:18 +00:00
Jenkins
05fbd076e4 Merge "Add unit tests for usage commands in compute v2" 2016-12-26 12:13:36 +00:00
JingLiu
6929c50a13 Fix a spelling error
Change-Id: Ic14c769d99986d5c51d26fc276f4d47d6fba3265
2016-12-26 17:01:48 +08:00
Ha Van Tu
80c703702a Fix typo in release notes
This patch replace a typo "proprty" with "property".

Change-Id: Idf228afd8827e6b33d6eb657c1f3e0cb35286a45
2016-12-26 15:30:53 +07:00
Jenkins
6245a96211 Merge "Add '--type'and other options to network rbac list" 2016-12-26 03:58:45 +00:00
jiahui.qiang
7b1febf47f Add unit tests for usage commands in compute v2
Add unit tests and fakes for command below in compute v2:
usage list
usage show

Change-Id: Ie533e23375ca6b8ba4cb7e865d39fac652cc0195
2016-12-26 03:05:37 +00:00
Jenkins
1971003468 Merge "Updated from global requirements" 2016-12-24 23:02:22 +00:00
Jenkins
adc25084f4 Merge "Test-requirements.txt: Bump Hacking to 0.12" 2016-12-24 22:37:02 +00:00
Jordan Pittier
b7ad35c007 Test-requirements.txt: Bump Hacking to 0.12
We already pass all the checks.

Change-Id: I9af2eb26dfb1ecf296753dcfc505768d534929ea
2016-12-24 12:58:55 +00:00
OpenStack Proposal Bot
a3fbbd923b Updated from global requirements
Change-Id: I673f91955be4dfde1eea54b48cc7e9a554447fcd
2016-12-24 09:22:57 +00:00
Dean Troyer
188e32f9e6 WIP: Skip broken functional tests...
...so we don't have to fix them all in one review.

Do not merge this until https://review.openstack.org/#/c/414649 is merged
and funtional tests pass.

Change-Id: I4f187111d3e4d8c4a613c20a946d6b5d3562e879
2016-12-23 17:19:50 -06:00
Badhmapriya Boopalan
780ce07459 To support '--project' and '--project-domain' options
Include '--project' and '--project-domain' filtering
options to 'port list' command.

Change-Id: Ic7deae348f737c754b2f3e2113bd76d71a442400
Closes-Bug: #1648087
2016-12-23 08:43:37 +00:00
Jenkins
b829b210b0 Merge "Should support 'auto' and 'none' as network parameter when boot instances" 2016-12-23 03:50:18 +00:00
Rodolfo Alonso Hernandez
9e1e7e1c9f Add support for QoS rule type commands
Added following commands:
    - network qos rule type list

Closes-Bug: 1612194
Depends-On: Iecf7bc7acd244a842aae963993f37a64a26b43b9
Change-Id: I38af823c726ceaba9d0b45488fa48e2d93971c92
2016-12-22 16:40:14 +00:00
Rodolfo Alonso Hernandez
5084ce14b0 Update earliest-version number format in release notes
Change-Id: I67deca8d2ff1f63d272b8d5b78cb31efd6e6d4df
Closes-Bug: #1652054
2016-12-22 13:49:27 +00:00
Kevin_Zheng
ff18e3d0e9 Should support 'auto' and 'none' as network parameter when boot instances
Nova added support using 'auto' and 'none' as network parameters since
microversion 2.37:
http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/rest_api_version_history.rst#n389
we should also add support for this in OSC.

Change-Id: I6e5f616dfa48895ebd13144effe9fda7cb94c649
Closes-bug: #1651288
2016-12-22 10:01:02 +00:00
Jenkins
5d62981beb Merge "Introduce overwrite functionality in `osc router set`" 2016-12-21 22:09:50 +00:00
Jenkins
6d63085c72 Merge "Fix all missing "os to openstack" transformation" 2016-12-21 12:15:16 +00:00
Jenkins
97538604ad Merge "Modified API calls in os usage" 2016-12-21 12:15:08 +00:00
Jenkins
931eee89ab Merge "Add one test for "backup set" command" 2016-12-21 10:01:22 +00:00
Huanxuan Ao
97c0b4bf15 Fix all missing "os to openstack" transformation
Checked and fix all missing of the review:
https://review.openstack.org/#/c/412669/
https://review.openstack.org/#/c/412673/
https://review.openstack.org/#/c/412678/

Change-Id: Ice85958874121eeb574d0b4cfa58e1590b014ed6
2016-12-21 10:29:38 +08:00
guiyanxing
af7129cda3 Add '--type'and other options to network rbac list
This patch adds '--type','--action','--long' filtering options
to network rbac list command

Change-Id: I21846820ab223bb7832e89eb2d7658bbec271aec
Closes-Bug: #1648307
Partially-Implements: blueprint network-commands-options
2016-12-21 09:43:07 +08:00
ZhaoBo
3816b4b90a Fix the missing os in command in example
This patch correct the missing one 'os example'.

Change-Id: I7c2cb01082f1eff1a7a607508f166dd54a450f44
2016-12-21 00:05:46 +08:00
Jenkins
1b3f953715 Merge "change os in command example to openstack(3)" 2016-12-20 16:01:17 +00:00
Jenkins
ce0cdb058e Merge "change os in command example to openstack(2)" 2016-12-20 16:00:58 +00:00
Jenkins
898c6a316a Merge "change os in command example to openstack" 2016-12-20 16:00:50 +00:00
Jenkins
a988ca5305 Merge "Add support for clearing router gateway" 2016-12-20 13:09:12 +00:00
Nguyen Phuong An
8bcfb824c8 Add 'allowed address pairs' option to 'port create/set/unset'
This patch adds '--allowed-addres-pair' and '--no-allowed-address-pair'
options to 'port create', 'port set' and 'port unset' commands.

Partial-Bug: #1612136
Closes-Bug: #1638265
Partially-Implements: blueprint network-commands-options
Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I08d2269950467a8972a0d0110ed61f5cc7f5ca45
2016-12-20 15:16:15 +07:00
Jenkins
3ab94614c2 Merge "Add doc for Searchlight client" 2016-12-20 02:43:27 +00:00
Kevin_Zheng
446e6f2fa8 change os in command example to openstack(3)
In the current doc, the command examples are like
"os server create" but the acutal command should
be started with "openstack" instead of "os", it
is misleading to first time users.

Change-Id: Ie67c0152d8ff8b7c456f91dc8b9a9164437ee9d1
2016-12-20 09:26:15 +08:00
Kevin_Zheng
847da51dea change os in command example to openstack(2)
In the current doc, the command examples are like
"os server create" but the acutal command should
be started with "openstack" instead of "os", it
is misleading to first time users.

Change-Id: I80c96f0938cec382f2f714a500138bd5a2c81aa0
2016-12-20 09:18:55 +08:00
Kevin_Zheng
9663424c74 change os in command example to openstack
In the current doc, the command examples are like
"os server create" but the acutal command should
be started with "openstack" instead of "os", it
is misleading to first time users.

Change-Id: Ic7686257725e1aa8e4e0d65a712eff1c079927a8
2016-12-20 09:03:29 +08:00
Reedip
4a5bf8d2a5 Add support for clearing router gateway
This patch adds the support to clear the gateway information
from a router.

Change-Id: I446c556750f080a6fc21fea8f531fd71838d648a
Implements: blueprint neutron-client-advanced-router
Partially-Implements: blueprint network-commands-options
2016-12-19 17:30:19 -05:00
Reedip
25104c7d4a Introduce overwrite functionality in `osc router set`
The overwrite functionality allows user to overwrite
the routes of a specific router.

Change-Id: I8d3cfe5cab2ffbfa046371c3adcd2cf446c91cbc
partially-implements: blueprint allow-overwrite-set-options
2016-12-19 16:57:02 -05:00
Jenkins
e51a2b3b17 Merge "Add support for setting router gateway" 2016-12-19 14:31:11 +00:00
zhiyong.dai
20b0b71809 Add one test for "backup set" command
The former tests for "backup set" command miss a test for '--description'
option. In this patch, one relative test is added.

Change-Id: Ie755d56a68a666d48751ab1ad20c8edb50e69b94
2016-12-19 18:50:08 +08:00
Kevin_Zheng
194a8529d9 Add doc for Searchlight client
The doc information for python-searchlight client
is not good and this patch add some information.

Change-Id: I47da1665f5108a4d945b927c134904ab479c144d
2016-12-19 17:23:53 +08:00
zhiyong.dai
25c563d0d8 Tivial:update the description format in volume_snapshot.py
Replace the old description format with "_description = _( )"

Change-Id: I36d61621309cfceefbd1ab1b930fa94b4bad2036
2016-12-18 02:43:27 +08:00
Jenkins
a17687288b Merge "Add filtering options to the address scope list command" 2016-12-18 14:30:44 +00:00
Jenkins
cc4ede88e9 Merge "Add --default option to "volume type list"" 2016-12-18 12:20:28 +00:00
Yan Xing'an
d12aa86f7c Add filtering options to the address scope list command
Add --name, --ip-version, --project, --project-domain,
--share, --no-share options to the address scope list command.

Change-Id: I8ece8da473d07dfc21dfb5b17de47624241f0142
Closes-Bug: #1636046
Partially-Implements: blueprint network-commands-options
2016-12-18 19:46:11 +08:00
Reedip
841d9d8dbd Add support for setting router gateway
This patch adds the support to set the gateway information
for a router.

Implements: blueprint neutron-client-advanced-router
Partially-Implements: blueprint network-commands-options
Change-Id: Ifb5a4d1965cd7e75c0c8cf2cfb677e0628b699dc
Depends-On: I2bda0dd40afd64b6cecca5f64ef2326bda4fac92
2016-12-17 18:22:45 +00:00
Jenkins
3ff713fd57 Merge "Add some options to "volume create" command" 2016-12-16 08:20:03 +00:00
Jenkins
60370b46f5 Merge "SDK refactor: Prepare network commands" 2016-12-16 03:01:12 +00:00
Mikhail Feoktistov
63377f25fc Add ploop to supported disk formats
This format is used for containers for Virtuozzo hypervisor

Closes-Bug: 1650342

Change-Id: Ic79f29a1fe9ea5016d3d5520c2b06e39da01ff61
2016-12-15 12:46:55 -05:00
Sindhu Devale
22d639b0b6 SDK refactor: Prepare network commands
Prepare the OSC "network" commands for the SDK refactor.

Change-Id: I50680f6675905f2147fee94cce8c1ed9c81dac0a
Partially-Implements: blueprint network-command-sdk-support
2016-12-15 14:26:39 +00:00
Jenkins
e24deda9cf Merge "SDK Refactor: Prepare port commands" 2016-12-15 14:16:50 +00:00
OpenStack Proposal Bot
5e03b92464 Updated from global requirements
Change-Id: Id1468c3882547d908b92a598cbb53196c139cf8a
2016-12-15 03:55:33 +00:00
Jenkins
d854ff052d Merge "[TrivialFix] Fix typo error" 2016-12-15 03:32:55 +00:00
Jenkins
33cafd9b76 Merge "SDK Refactor: Prepare router commands" 2016-12-15 03:32:06 +00:00
jeckxie
74360e00f5 [TrivialFix] Fix typo error
Change-Id: Iaba9ba22de044b34b4b77f81bcdccda13af81405
2016-12-14 14:39:24 +08:00
Jenkins
112afb752b Merge "3.5.0 release note cleanup" 2016-12-14 05:22:22 +00:00
Abhishek Raut
7832ea357c SDK Refactor: Prepare port commands
Prepare the OSC "port" commands for the SDK refactor.
See [1] for details.
Also fixed a typo in the UT.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I0e37d6c04f3d8e81fdfd50ac26eea9b5a5fb2ff9
Partially-Implements: blueprint network-command-sdk-support
2016-12-13 17:06:38 -08:00
Jenkins
2cb5cf7d54 Merge "Updated from global requirements" 2016-12-13 23:38:58 +00:00
Jenkins
86cad34c5b Merge "Add "--remote-source" option to "volume snapshot create" command" 2016-12-13 22:58:16 +00:00
Dean Troyer
11a762e03c 3.5.0 release note cleanup
Change-Id: Ibe5e5a9a212ac483d0cb38bdb3a607d21f32e96d
2016-12-13 16:09:21 -06:00
OpenStack Proposal Bot
bd63da5547 Updated from global requirements
Change-Id: I1b677f708a7c598fc68891226d3ff31aa4cb731a
2016-12-13 21:49:48 +00:00
zhiyong.dai
2f2603d908 Add two consistency group commands
Add commands:
    consistency group add volume
    consistency group remove volume
in volume v2 (v2 only)

Change-Id: I70ff287d3b5df78196b8f4b9e50402c471aef284
Implements: bp cinder-command-support
Closes-Bug: #1613964
2016-12-13 15:32:04 +08:00
Yan Xing'an
083e155ae5 SDK Refactor: Prepare router commands
Prepare the OSC "router" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I2fa12943a65e3981b924e6cea9ed041682ec54b2
Partially-Implements: blueprint network-command-sdk-support
2016-12-12 19:23:27 -08:00
Huanxuan Ao
7357b24d3a Add "--remote-source" option to "volume snapshot create" command
Add "--remote-source" option to "volume snapshot create" command
to support creating snapshot from an existing remote snapshot in
volume v2 (v2 only), also add the doc, unit tests and release note.

Change-Id: I9e5fad4f0db5b44d528eb6b930edbc816e392c3a
Implements: bp cinder-command-support
Closes-Bug: #1618676
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-12-12 23:06:00 +08:00
Steve Martinelli
5bc2cf231d update plugins documentation
- remove cueclient from list of supported plugins, it seems like
  a dead project to me, see [1] for more details.
- remove the ** from watcherclient, it is now listed in global
  requirements [2].

[1] https://review.openstack.org/#/c/409497/
[2] https://github.com/openstack/requirements/blob/master/global-requirements.txt#L232

Change-Id: Ia49436ccdbdf5d84060062b57e4a6286b5906468
2016-12-11 00:28:07 -05:00
Jenkins
29587eaa66 Merge "Add extra filtering options to floating ip list" 2016-12-09 15:21:03 +00:00
Jenkins
3bc64aa198 Merge "Add unit tests for server create in computev2" 2016-12-09 12:28:20 +00:00
songminglong
47716d1ad3 Add extra filtering options to floating ip list
The patch adds filtering '--long', 'status', '--project',
'--project-domain' and '--router' options to
floating ip list command.

Closes-Bug: #1614379
Partially-Implements: blueprint network-commands-options
Change-Id: I2a02cf23845ff435927d8b481f77249915bd94dc
2016-12-09 14:23:26 +08:00
Jenkins
83cf09df28 Merge "Correct missspellings of secret" 2016-12-08 21:43:36 +00:00
Jenkins
d09fd7d832 Merge "Add '--force' option to 'volume snapshot delete' command" 2016-12-08 17:46:30 +00:00
Jenkins
f18328e5bf Merge "Trivial: update volume-qos.rst" 2016-12-08 17:45:18 +00:00
Jenkins
1925a9e5b3 Merge "Add "consistency group set" command" 2016-12-08 17:45:14 +00:00
Jenkins
5408d02de4 Merge "Fix description errors in volume fakes" 2016-12-08 17:45:06 +00:00
Jenkins
6bd1135036 Merge "Add options to "volume snapshot list" command" 2016-12-08 17:44:58 +00:00
Jenkins
b22af88a19 Merge "Adjust the code sequence in consistency_group.py" 2016-12-08 17:44:50 +00:00
Jenkins
b18dcfc4cb Merge "Add "consistency-group-snapshot" option to consistency group create" 2016-12-08 17:44:42 +00:00
Jenkins
a9be7a6c73 Merge "SDK Refactor: Prepare ip availability commands" 2016-12-08 17:40:58 +00:00
Jenkins
bd69d55050 Merge "Add "volume host set" command" 2016-12-08 17:40:46 +00:00
Jenkins
5428e09525 Merge "Remove auth_with_unscoped_saml decorator" 2016-12-08 17:40:38 +00:00
Jenkins
b8f976871a Merge "Add "dns-name" option to "os port create" and "os port set"" 2016-12-08 17:37:38 +00:00
Dougal Matthews
841616f729 Correct missspellings of secret
Change-Id: Ia00d5cf3a32f534d1c0f40d5b295610f88a777d4
2016-12-08 13:15:47 +00:00
Huanxuan Ao
bbfd8cb46b Add '--force' option to 'volume snapshot delete' command
Add '--force' option to 'volume snapshot delete' command in
volume v2 (v2 only) to allow delete in state other than error
or available.

Change-Id: Ie8991e9a630d7c7e9ac6c6870aed787bbcebacf2
Closes-Bug: #1597195
2016-12-08 17:08:58 +08:00
jiahui.qiang
035a87051c Modified API calls in os usage
We usually call v3 keystoneclient APIs for V2 OSC, this patch
modified 'tenants' to 'projects'.

Change-Id: Idbf74f098cd1386aa675c081480b89bbc11c8534
2016-12-08 03:00:45 +08:00
zhiyong.dai
6da1f97acd Trivial: update volume-qos.rst
Before the ".. describe",some codes are left out. I add them in this patch.
In addition, I change "[--property <key> ] to [--property <key> [...] ]

Change-Id: I37ae0ba53e2a2d43a4806b318c7776ff2260fd1d
2016-12-07 18:33:34 +08:00
Huanxuan Ao
3e9109bc7c Add "consistency-group-snapshot" option to consistency group create
Add "consistency-group-snapshot" option to
"consistency group create" command to support
for creating consistency group from existing
consistency group snapshot

Implements: bp cinder-command-support
Partial-Bug: #1613964
Change-Id: I54c265d38299f4973945ba99e30042bcf47859c0
2016-12-07 12:41:17 +08:00
zhiyong.dai
4dc78e4265 Add "consistency group set" command
Add "consistency group set" command in volume v2 (v2 only).

Change-Id: I53116015388b7a4b0e15813f52c1246166bb0fc1
Implements: bp cinder-command-support
Partial-Bug: #1613964
2016-12-06 17:36:25 +08:00
jiahui.qiang
d083ddb12f Add --default option to "volume type list"
Add "--default" option to volume v2's "type list"
command, it will show which volume type the volume
service has set as default.

Implements: bp cinder-command-support
Change-Id: Iae7ebc633ebe5554cc88390a84361887ec211fb2
2016-12-06 06:44:16 +08:00
Jenkins
158dbe124a Merge "Add '--project' and '--project-domain' options to os cmds" 2016-12-05 22:28:21 +00:00
Jenkins
fdf93e04e6 Merge "Revert "Remove marker and loop from "image list" command"" 2016-12-05 22:21:47 +00:00
jiahui.qiang
7e5a98bca9 Add some options to "volume create" command
Add "--bootable", "--non-bootable", "--read-only" and "--read-write" options
to "volume create" command for setting some attributes at the time of crration.

Change-Id: I71b4e9fccb4ee0ab1a90e7179d6d2d34dbbae909
Implements: bp cinder-command-support
2016-12-06 00:17:36 +08:00
Steve Martinelli
42f33435ed Revert "Remove marker and loop from "image list" command"
This reverts commit 0b6fdcbe4c.

Adapt "image list" to not loop when --marker is specified on command
line.

Update tests to work with current state of code.

Change-Id: I8af58adf8637a9e34371c6280db40935d22bc3c3
2016-12-05 10:35:00 +01:00
Colleen Murphy
5203cc9707 Remove auth_with_unscoped_saml decorator
The auth_with_unscoped_saml decorator existed to make sure the user
selected the right auth plugin before trying to call either a
'federation domain' or 'federation project' command. This is outdated,
because openstackclient now uses keystoneauth[1] and keystoneauth
removed its entrypoints for the federation plugins[2] since its
_Rescoped class no longer needs them. This patch removes the decorator
since that validation check was the only thing standing in the way of
the commands working correctly. Also removed the '*_list_wrong_auth'
tests since those only existed to test the decorator, and stopped
setting the plugin in the positive tests since the
automatically-determined token plugin should now be fine.

[1] http://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=6ae0d2e8a54fd5139e63a990ab4bdce634e73c5e
[2] http://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=d9e4d26bb86f8d48e43188b88bab9d7fe778d2c1

Change-Id: Id981739663113447a7bba8ddba81ba9394a19e07
Closes-bug: #1624115
2016-12-04 18:59:09 +00:00
Ankur Gupta
8c71a35eeb SDK Refactor: Prepare ip availability commands
Prepared the OSC "ip availability" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: Ia22e9fafec0a91ba1b0f1ce825fcaf1d8cbbbf88
Partially-Implements: blueprint network-command-sdk-support
2016-12-04 17:31:12 +00:00
zhiyong.dai
99ba4f86b0 Adjust the code sequence in consistency_group.py
Place "CreateConsistencyGroup" above "DeleteConsistencyGroup"

Change-Id: I554a8e445fee0760450b2da3b5c4a4f3b2434d60
2016-12-04 18:21:06 +08:00
judy-yu
83675e9ee0 Avoid duplicated project_id when show network resources
Project_id appear twice when show network resources. This
patch check and not append if it already has one.

Change-Id: I744988f3f52d4a744e397a6a82fefdc4c17eacbf
Closes-Bug: #1636123
Partially-Implements: blueprint duplicated-project-id
2016-12-04 18:03:33 +08:00
Nam Nguyen Hoai
df5f12b135 Add "dns-name" option to "os port create" and "os port set"
This patch added a "dns-name" option to
"os port create" and "os port set" command.

Change-Id: I360e2c9a1970e64fe17e4561d7618f860b937373
Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2016-12-03 17:08:17 +07:00
Jenkins
e05c8d7bb0 Merge "Refactor "snapshot" commands" 2016-12-03 04:30:51 +00:00
Jenkins
2fd5ca22f6 Merge "Add "consistency group show" command" 2016-12-02 22:56:23 +00:00
Jenkins
d2701116d3 Merge "Add "consistency group delete" command" 2016-12-02 21:02:40 +00:00
Jenkins
4debdc6dbb Merge "Updated from global requirements" 2016-12-02 20:45:15 +00:00
daizhiyong
1907220113 Add "consistency group show" command
Add "consistency group show" command in volume v2 (v2 only).

Change-Id: If496eba2955c0aacd52600bb6fba39690ddd90cb
Implements: bp cinder-command-support
Partial-Bug: #1613964
2016-12-02 20:45:13 +00:00
zhiyong.dai
094e5189b7 Add "consistency group delete" command
Add "consistency group delete" command in volume v2 (v2 only).

Change-Id: Ieebc2417df0d45a578d5617bad245d7863f09190
Implements: bp cinder-command-support
Partial-Bug: #1613964
2016-12-02 13:21:18 -06:00
Jenkins
12442371a8 Merge "SDK Refactor: Prepare security group rule commands" 2016-12-02 18:50:45 +00:00
Jenkins
279563e45b Merge "SDK Refactor: Prepare network rbac commands" 2016-12-02 18:50:37 +00:00
Jenkins
6977105383 Merge "SDK Refactor: Prepare network qos policy commands" 2016-12-02 18:50:29 +00:00
Jenkins
3730fe9f5f Merge "SDK Refactor: Prepare subnet commands" 2016-12-02 18:50:21 +00:00
Jenkins
7078502ea6 Merge "Sort list images by name by default" 2016-12-02 18:50:17 +00:00
Jenkins
d1f1f092c4 Merge "Add "--type" and "--retype-policy" options to "volume set" command" 2016-12-02 18:49:37 +00:00
Jenkins
2daeb30296 Merge "Add "Is Public" column in volume type list" 2016-12-02 18:32:49 +00:00
Jenkins
6f8a080f27 Merge "Remove outdated comments in volume unit test" 2016-12-02 18:29:15 +00:00
Jenkins
19ca396508 Merge "Using v2 as the default version of Glance" 2016-12-02 18:29:08 +00:00
Jenkins
5ec4290e27 Merge "Add commands for "consistency group snapshot"" 2016-12-02 18:29:01 +00:00
Jenkins
1c2b0c6b73 Merge "Add "consistency group create" command" 2016-12-02 18:28:22 +00:00
OpenStack Proposal Bot
d5b69c6269 Updated from global requirements
Change-Id: I8f9828e5e3a266a1ba52f9c09ddad4ed8d928e1b
2016-12-02 17:18:11 +00:00
Jenkins
307a847685 Merge "Correct reraising of exception" 2016-12-02 13:34:51 +00:00
Jenkins
2de45c2805 Merge "clean up image choices and help text" 2016-12-02 13:11:30 +00:00
Jenkins
c0dd8086e5 Merge "Updated from global requirements" 2016-12-02 07:11:23 +00:00
Jenkins
9b19a35bb7 Merge "Add --enable/disable-port-security option to port set and port create" 2016-12-02 05:28:21 +00:00
OpenStack Proposal Bot
2cb0f85288 Updated from global requirements
Change-Id: I807f29306f262cf5c7deceb240e0a257b96af456
2016-12-02 05:13:51 +00:00
gengchc2
40d73a0b58 Correct reraising of exception
When an exception was caught and rethrown, it should
call 'raise' without any arguments because it shows
the place where an exception occured initially instead
of place where the exception re-raised

Change-Id: I3ec3680debbfad7c06f2251396e0e8e4e3df6c50
2016-12-02 09:56:27 +08:00
Jenkins
3a509be871 Merge "Introduce overwrite functionality in `osc subnet set`" 2016-12-01 21:57:15 +00:00
Nam Nguyen Hoai
ce079d2261 Add '--project' and '--project-domain' options to os cmds
This patch added '--project' and '--project-domain' options to
filter subnets resulted by 'os subnet list',
'os floating ip create' and 'os security group list' commands.

Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I727663d49ffa6aa042fdeb60797f18bb753b0372
Closes-Bug: #1613231
Closes-Bug: #1610909
Closes-Bug: #1613629
Partially-Implements: blueprint network-commands-options
2016-12-01 14:59:10 +07:00
zhiyong.dai
9f297853ce Add functional test for volume service
Add functional test for volume service, v1 and v2

Change-Id: If226c82ef8df339e4ae63d8241e0bd15b69264d2
2016-11-30 20:55:15 +08:00
Jenkins
d6e058fa1f Merge "Add network service provider list to OSC" 2016-11-29 15:13:42 +00:00
Jenkins
155114e457 Merge "Trivial:modify one parameter" 2016-11-29 13:51:29 +00:00
Ankur Gupta
ac7d27adc6 Add network service provider list to OSC
Add network service providers commands to OSC

Change-Id: Iea8bbe460061d67e36a4346b349e07612112c732
Depends-On: Ie0be92e0717b8b13e31068276a12b5fbf784e374
2016-11-28 22:54:08 -06:00
Sindhu Devale
246f60ab13 Add --enable/disable-port-security option to port set and port create
This patch adds the currently missing options
`--enable-port-security` and `--disable-port-security`
in the `os port set` and `os port create` commands.

Partially-Implements: blueprint network-commands-options

Change-Id: I4dc11cdf32bf482a5937f5464fe8a3b418644ec3
2016-11-28 16:33:34 -06:00
jiahui.qiang
747ec5b897 Add unit tests for server create in computev2
Unit tests for server create is not completed. Some of the code in
take_action has not been tested.

Change-Id: Ifd3f42400408d3437e0bc6cd42acbb6db861b1f3
2016-11-28 23:24:22 +08:00
Jenkins
b12782726f Merge "Add QoS support to Network object." 2016-11-28 13:57:07 +00:00
zhiyong.dai
fca81526ff Trivial:modify one parameter
This patch modifies a wrong parameter to make the metavar
consistent with the optional argument.
Change-Id: I27ed30fdbc3adbc19d2f5662d6952cfe15dc52b1
2016-11-28 20:27:03 +08:00
zhiyong.dai
c286722965 Refactor availability zone functional test
Using json format output in availability zone list functional test

Change-Id: I7098b1c3bee680e47e414dcb4fa272628cdec1eb
2016-11-28 20:01:52 +08:00
Rodolfo Alonso Hernandez
4132392c2f Add QoS support to Network object.
Added "qos_policy" parameter to Network class.

Change-Id: Idc00f2792eef5b1f0910084d95cf9a8e83fe818c
Closes-Bug: 1627069
2016-11-28 09:35:00 +00:00
Reedip
abfcd7810c Introduce overwrite functionality in `osc subnet set`
The overwrite functionality allows user to overwrite
the dns-nameservers of a specific subnet.

Change-Id: I421808a3bdeb4565668f627b7929c4762cf40212
partially-implements: blueprint allow-overwrite-set-options
partially-implements: blueprint network-commands-options
2016-11-28 05:49:21 +00:00
zhiyong.dai
d7bf1592c5 Functional test for configuration
Using json format output in configuration show functional test.

Change-Id: I005b361ae70ced3f6cef77291db1d39dafb0793c
2016-11-28 02:55:00 +08:00
zhiyong.dai
7d8602c9bc Functional test for aggregate
Using json format output in aggregate functional tests.
Remove resource create/delete from setupClass() and
teardownClass() methods

Change-Id: I6494ca63bfe8a51de0f65570fddcaf38f6c42dbb
2016-11-28 02:32:48 +08:00
zhiyong.dai
3258664c7a Refactor module functional test
Combine "test_module_list_no_options" and "test_module_list_with_all_option"
into one test, and modify the test for "--all' option.

Change-Id: If4e7a73502a888c50de17ec19ef7e8d02dd23f1d
2016-11-27 21:07:34 +08:00
zhiyong.dai
26a74d4596 Add choices for option '--policy'
When creating server group, the '--policy' option is required, but
valid choice is 'affinity' or 'anti-affinity', adding multiple
policies will produce an error. This patch add choices and default
value for option '--policy', and remove the former help message.

Change-Id: I312680af384363b3e9a7de9aa1f0946643e193e2
Closes-Bug: #1662771
2016-11-27 15:32:28 +08:00
jiahui.qiang
dc1d510350 Fix description errors in volume fakes
In volumev2 fakes.py. Description of some 'get_*' methods is incorrect.
the error will mislead the user. this patch has already fixed it.

Change-Id: I048e3c2b625c7b54ab19f2b923d4970427f277ff
2016-11-27 06:18:00 +08:00
zhiyong.dai
4fafd837ef DevRef fix for network qos policy
Several help messages are not proper.
This patch will do the following work:
* Remove redundant square bracket ']'
* Modify the wrong message

Change-Id: I2f05d1dc86838dbe77169074f93e467a959d0122
2016-11-27 00:42:44 +08:00
jiahui.qiang
6ca4dc3533 Add options to "volume snapshot list" command
Add "--name", "--status" and "--volume" options
to "volume snapshot list" command for filtering results.

Change-Id: I72db1abce7701f31598deec34801a4d1f5713870
Closes-Bug:#1645252
2016-11-26 23:13:50 +08:00
Flavio Percoco
1f8485b94f Show team and repo badges on README
This patch adds the team's and repository's badges to the README file.
The motivation behind this is to communicate the project status and
features at first glance.

For more information about this effort, please read this email thread:

http://lists.openstack.org/pipermail/openstack-dev/2016-October/105562.html

To see an example of how this would look like check:

https://gist.github.com/30af7c8ad287756d38d131d1f5dceae0

Change-Id: I2d906fa0675463e21f2786d93f464c465f2bc3b1
2016-11-26 12:05:49 +01:00
zhiyong.dai
ff3566ef48 Functional test for agent
Using json format output in compute agent functional tests.
Remove resource create/delete from setupClass() and
teardownClass() methods

Change-Id: Ic7c6c268dfccca097709378c0473eb82cddf7bc6
2016-11-26 02:13:30 +08:00
jiahui.qiang
71e6d44476 Add "volume host set" command
Add "volume host set" command in volume v2 to support freeze(disable)
and thaw(enable) the specified cinder-volume host

Change-Id: Iee1604d72f9eccd9e327b0ef8d345909a733a647
Implements: bp cinder-command-support
2016-11-25 05:21:00 +08:00
OpenStack Proposal Bot
da03f6e17d Updated from global requirements
Change-Id: I517d93ce1a2fcdb6b674bd5617902c4daf078031
2016-11-24 18:50:36 +00:00
zhiyong.dai
c8ab58bf61 Functional test for server group
Rework functional tests to remove resource create/delete from
setupClass() and teardownClass() methods.

Change-Id: Ia852e48d3bcf706eefa56b03ba1f02b3fd7605cd
2016-11-24 22:50:44 +08:00
Steve Martinelli
f15352f861 clean up image choices and help text
Use choices for image set and image create commands, this aligns
with our use of choices in networking commands.

Also update the help text to match that of the networking
commands, where we iterate through the options.

Related-Bug: 1635518
Change-Id: Ib4c66b06e07f1d4e5bfe1b74053f2215cccad890
2016-11-23 22:52:33 +05:30
Huanxuan Ao
4b14f3d0cb Add "--type" and "--retype-policy" options to "volume set" command
Add "--type" and "--retype-policy" options to
"volume set" command in volume v2 (v2 only) to
support changing the volume type for a volume

Change-Id: I0153abdb967aee790586a57cef31930e32005c1b
Implements: bp cinder-command-support
2016-11-23 10:34:31 +08:00
zhiyong.dai
82b96f57db TrivialFix in helpMessage for readability
Change-Id: Ic5fae89455470585f1bd79539f99a9c04e0c68a0
2016-11-23 02:58:26 +08:00
OpenStack Proposal Bot
3a7bb859a6 Updated from global requirements
Change-Id: Iec7883cfbc38d44aa1ad39c3a2879ad400b7ebb9
2016-11-22 17:59:10 +00:00
Jenkins
5bf5de6f45 Merge "Outdated test data clean up in volume" 2016-11-22 16:03:09 +00:00
Jenkins
bf6f4bb58b Merge "Show disk format vhdx in help" 2016-11-22 15:39:47 +00:00
Huanxuan Ao
5e070c36a1 Add "Is Public" column in volume type list
I think admin users will like to see the "Is Public" column
in volume type list since they can know the volume type
is public or private, so add "Is Public" column in volume
type list

Change-Id: I3f6e297a7adf82a275debbd87d2c4da415aa1360
Closes-Bug: #1643861
2016-11-22 14:58:55 +00:00
Huanxuan Ao
b6b9a524f9 Remove outdated comments in volume unit test
Checked the volume create unit test has beed completed,
so remove the TODO.
Checked the FakeVolume class has been added in volume
v1, so remove the note.

Change-Id: I82b5f775d013e5e301bc1c18481ef516ca5baa7e
2016-11-22 20:46:29 +08:00
zhiyong.dai
3544b4d89c Fill the missing colon
This patch fills the missing colon in ip-availability.rst

Change-Id: Icc7c8cc04fdfeb00051392f560bedcde62cfcee7
2016-11-22 04:07:28 +08:00
zhiyong.dai
55195cec46 Add "volume host failover" command
Add "volume host failover" command in volume v2 (v2 only).

Change-Id: Ia39e6d20bf5c9d3096e46f3432804a240827548d
Implements: bp cinder-command-support
2016-11-21 22:56:41 +08:00
Vijendra Soni
a7a0d0c61a Sort list images by name by default
Set the default key and dir for openstack image list,
if no command line argument passed
Changing sort_key to name(old value: created_at)

Change-Id: I6c61f6e5a04824d655ccf43477afcec9652101df
Closes-Bug: #1639231
2016-11-21 20:19:53 +05:30
Abhishek Raut
c76e631a2c SDK Refactor: Prepare security group rule commands
Prepare the OSC "security group rule" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I5553e40fe90f3a26d3f462a69f1a424032479d49
Partially-Implements: blueprint network-command-sdk-support
2016-11-19 22:46:17 -08:00
Abhishek Raut
1256aee491 SDK Refactor: Prepare network rbac commands
Prepare the OSC "network rbac" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I6f25e167d7f933667173b04a4b0ad55baf3c56f2
Partially-Implements: blueprint network-command-sdk-support
2016-11-19 22:44:02 -08:00
Abhishek Raut
77ea8baafe SDK Refactor: Prepare network qos policy commands
Prepare the OSC "network qos policy" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I12dd8bda40801c26176a73646ed87aea66f09fcc
Partially-Implements: blueprint network-command-sdk-support
2016-11-19 22:42:07 -08:00
Abhishek Raut
11560a0527 SDK Refactor: Prepare subnet commands
Prepare the OSC "subnet" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Partially-Implements: blueprint network-command-sdk-support
Change-Id: I5d58b189e822b2ee61c9c95ccf909113ff59de46
2016-11-19 22:38:36 -08:00
Huanxuan Ao
3907137f58 Add commands for "consistency group snapshot"
Add commands:
    consistency group snapshot create
    consistency group snapshot delete
    consistency group snapshot list
    consistency group snapshot show
in volume v2 (v2 only)

Change-Id: Ib4115f8ff00fb5aa8194588223032657eb1346b5
Closes-Bug: #1642238
Implements: bp cinder-command-support
2016-11-19 09:20:15 +08:00
Jenkins
f4536e708d Merge "Add '--network' and other options to floating ip list" 2016-11-18 23:08:20 +00:00
Jenkins
5787d3cbae Merge "Add relnote for release 3.4.1" 2016-11-18 18:42:42 +00:00
Jenkins
9a4075334b Merge "Use project_domain_id only in password auth" 2016-11-18 18:02:35 +00:00
Dean Troyer
61cc546475 Add relnote for release 3.4.1
Change-Id: If7d0237c4ed032be9d225cd0a05972caf5946e2d
2016-11-18 11:08:40 -06:00
Boris Bobrov
e51a8d6374 Use project_domain_id only in password auth
The method being changed constructs domain-related parameters that will
further be passed to the auth plugin. If project domain is not
passed, the method sets it to the default domain.

token_endpoint does not expect any information about domain,
because it uses only a token and URL. Passing it to auth plugin causes
an exception.

Construct domain-related parameters only for specific plugins, such
as password or totp.

Change-Id: I13db3bbe31a0ed843e9f4528d37c768546e2bee9
Closes-Bug: 1642301
2016-11-18 13:52:58 +00:00
Fei Long Wang
4bce716733 Using v2 as the default version of Glance
Glance API v1 has been deprecated, so it's better to use v2 as
the default API version in openstackclient.

Closes-Bug: 1642772

Change-Id: I7d9e3228a2f3a3d0da437b7ee6f23e528de27fd3
2016-11-18 12:58:31 +00:00
Huanxuan Ao
98b9bc10d1 Add "consistency group create" command
Add "consistency group create" command in
volume v2 (v2 only).

Change-Id: I2e9affe390b1012aa18459e64d04afcdfc15e27d
Implements: bp cinder-command-support
Partial-Bug: #1613964
2016-11-17 22:07:04 +08:00
Steve Martinelli
0ef8535036 translate all command help strings
Leverage the new cliff command class attribute (_description)
to get the help of a command, this allows us to mark strings
for translation. We could not do this before since the help
was grabbed from the docstring.

This also depends on a new release of cliff and a bump to the
minimum level in osc's requirements.

Closes-Bug: 1636209
Depends-On: Id915f6aa7d95a0ff3dc6e2ceaac5decb3f3bf0da
Change-Id: I8673080bb5625e8e3c499feaefd42dfc7121e96f
2016-11-17 02:33:42 +00:00
OpenStack Proposal Bot
6eef3277f5 Updated from global requirements
Change-Id: Ie6b85f717a7fe5bce2f6a711168dba894940cde9
2016-11-16 22:16:41 +00:00
Jenkins
17c0c70e7e Merge "3.4.0 release note cleanup" 2016-11-16 17:43:42 +00:00
Jenkins
16ffc51bf6 Merge "Do proper deprecation for security group rule create" 2016-11-16 17:00:48 +00:00
Dean Troyer
ad5ae83a34 3.4.0 release note cleanup
Change-Id: I4023e80da43e0cb28150db2892f301d141d63ef8
2016-11-16 09:47:37 -06:00
Dean Troyer
0ac4370c09 Do proper deprecation for security group rule create
Review I03fd0e14e470e7272930ac2651e73263b83bd4e1 renamed the
--src-group and --src-ip options to --remote-group and --remote-ip
but did not properly deprecate the old option names.

Add deprecation warnings when the old option names are used.

Also, format the warnings using the new proposed translation guideline
for marking substrings to not be translated, such as literal names
and option names.

Change-Id: I63d085d190fc28b8637e7686016eda4efbdda1be
2016-11-16 07:53:30 -06:00
Huanxuan Ao
7684ab4a29 Outdated test data clean up in volume
Now all the volume unit tests (both v1 and v2)
are using fake classes. All the old fake data
and code can be removed.

Change-Id: Ib35ad4b6c94c42a21215e012f80f8978a74a3d18
2016-11-16 20:07:50 +08:00
Reedip
76c7a0af57 TrivialFix: Insert blank space for readability
Change-Id: Ia4612f65332d788e186c801edb98486862f98e56
2016-11-16 14:10:10 +05:30
OpenStack Proposal Bot
4cd336b128 Updated from global requirements
Change-Id: I96c212312bca547dd5a27b6af8cfabad46d6e1da
2016-11-16 00:21:32 +00:00
OpenStack Proposal Bot
0b5655fae8 Updated from global requirements
Change-Id: I1896f594f692e43e7c986594fc0afcf6a345b54e
2016-11-15 10:14:28 +00:00
songminglong
839c5f7a84 Add '--network' and other options to floating ip list
The patch adds filtering '--network', '--port',
'--fixed-ip-address' options to floating ip list command

Partial-Bug: #1614379
Change-Id: I82319d0985d9e864431097c90264a20bf88167cc
2016-11-13 10:11:03 +08:00
Jaspreet Singh Rawel
ff7fda061e Show disk format vhdx in help
Currently disk format type vhdx is missing in help.

Closes-Bug: 1635518

Change-Id: Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b
2016-11-11 12:38:37 +05:30
Jenkins
95c26cebaa Merge "network.common.NetworkAndComputeShowOne: catch HttpException" 2016-11-10 18:10:41 +00:00
Jenkins
85c26caa2e Merge "Not appropriate name sg rule attribute" 2016-11-10 18:10:34 +00:00
Jenkins
85f2afdad0 Merge "Add description field port create & port set" 2016-11-10 18:10:27 +00:00
Jenkins
518fbf0397 Merge "Support --provider-* options in the network list command" 2016-11-10 18:09:24 +00:00
Jenkins
81c0129365 Merge "Add option to allow filtering by mac-address on port list" 2016-11-10 18:09:14 +00:00
Jenkins
496dbfc52e Merge "Use FakeImage class to replace duplicated image info in volume test" 2016-11-10 18:09:07 +00:00
Jenkins
f3d3813522 Merge "Allow input the QoS policy name in network rbac create command" 2016-11-10 18:09:00 +00:00
Jenkins
c89d441008 Merge "Add direction and protocol options to os security group rule list cmd" 2016-11-10 18:08:53 +00:00
Jenkins
55ddaf7bbe Merge "Add "--read-only" and "--read-write" options in "volume set"" 2016-11-10 16:59:18 +00:00
Jordan Pittier
52279b1b04 network.common.NetworkAndComputeShowOne: catch HttpException
Problem: if a user issue the cmd 'openstack floating ip create public'
and has already maxed his quota for FIP, OSC exits with a not so useful
message:

>jordan@jordan-XPS13-9333:~ $ openstack floating ip create public
>HttpException: Conflict

This patches catch the HttpException earlier and prints a more
verbose message:

> jordan@jordan-XPS13-9333:~ $ openstack floating ip create public
> Error while executing command: Quota exceeded for resources: ['floatingip']

Change-Id: I7c87524d871d230d92f007c32e06439b34c7194a
2016-11-10 16:30:23 +01:00
Jenkins
b37ad9992b Merge "Add "volume migrate" command" 2016-11-10 14:13:28 +00:00
Jenkins
8b2f256828 Merge "Add 'description' option" 2016-11-09 20:05:56 +00:00
OpenStack Proposal Bot
a1ed375292 Updated from global requirements
Change-Id: I27e6899434ac47018a6ebd140cd326e7c6cd00d9
2016-11-09 04:24:18 +00:00
Sindhu Devale
52c4a55d43 Add 'description' option
This patch adds '--description' option to
os security group rule create cmd.

Change-Id: I604bcdeb4658d2dcc4d860a87e704e186cca5225
Partially-Implements: blueprint network-commands-options
Partially-Implements: blueprint neutron-client-descriptions
2016-11-08 21:52:41 +00:00
Jenkins
874933debd Merge "SDK refactor: Prepare floating ip commands" 2016-11-08 19:47:56 +00:00
Jenkins
6bba1f0008 Merge "SDK Refactor: Prepare subnet pool commands" 2016-11-08 19:47:49 +00:00
Jenkins
c27da0564c Merge "SDK Refactor: Prepare network segment commands" 2016-11-08 19:47:41 +00:00
Jenkins
b072edd80a Merge "SDK Refactor: Prepare address scope commands" 2016-11-08 19:10:38 +00:00
Jordan Pittier
55669b90c0 Add 'all-projects' option to 'volume backup list'
Similar to what 'volume list --all-projects' does, 'volume backup
list --all-projects' list volume backups accross all projects.

Change-Id: Id5dda9b5adc822c4ddfb2dda339946d3322858e2
2016-11-08 17:35:51 +01:00
Huanxuan Ao
e07b0e0919 Add options to "volume backup list" command
Add "--name", "--status", "--volume", "--marker" (v2 only)
and "--limit" (v2 only) options to "volume backup list" command

Change-Id: If20cb7650f2359d393ee314d9e055a8659c73009
Closes-Bug: #1612484
Closes-Bug: #1639712
2016-11-08 04:47:57 +00:00
OpenStack Proposal Bot
0e3e05098c Updated from global requirements
Change-Id: I6e4dbe7ad08d749aa153eb30887802c6fb129a13
2016-11-06 02:07:15 +00:00
judy-yu
3a915b5b5f Not appropriate name sg rule attribute
For ingress rules set ip-prefix means src-ip-
prefix, but for egress rules set ip-prefix means
dst-ip-prefix. It is not appropriate to name
src-ip directly. So as to src-group.

Change-Id: I03fd0e14e470e7272930ac2651e73263b83bd4e1
Closes-bug: #1637365
2016-11-04 17:23:46 +08:00
Sindhu Devale
86a3c7a415 SDK refactor: Prepare floating ip commands
Prepare the OSC "floating ip" commands for the SDK refactor.

Change-Id: I02052185b3ce0b053acdcf76a0f68d49e6f7e608
Partially-Implements: blueprint network-command-sdk-support
2016-11-03 14:54:11 +00:00
Huanxuan Ao
23ee2fd8f0 Refactor "snapshot" commands
1.change the command name ``snapshot create/delete/list/
show/set/unset`` to ``volume snapshot create/delete/list/
show/set/unset``.

2.change the optional parameter "--name <name>" to a
positional parameter "<snapshot-name>"; Change the
positional parameter "<volume>" to a optional
parameter "--volume <volume>"

Change-Id: If03276ecdf6f0d96893d5ecf91c2aaa64929cff3
Implements: bp backup-snapshot-renamed-for-volume-resource
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-11-03 16:15:02 +08:00
OpenStack Proposal Bot
970b0e0005 Updated from global requirements
Change-Id: I2cfff831e1ef85249bb6ec19637ac75f2ee9f899
2016-11-02 15:40:40 +00:00
Yi Zhao
84beac5994 Add filtering options --name,--enable,--disable to router list
Change-Id: I171b6be4501b02c3df66589c45177200919117db
Closes-Bug: #1637945
Partially-Implements: blueprint network-commands-options
2016-10-31 16:54:08 +08:00
Yan Xing'an
960b2658dc Support --provider-* options in the network list command
Add --provider-network-type, --provider-physical-network, --provider-segment
options into network list command.

Change-Id: I02546170211fb3e7e55d5dc7e7cdc6d387fd26e5
Closes-Bug: #1635580
Partially-Implements: blueprint network-commands-options
2016-10-27 23:37:59 -07:00
Yan Xing'an
8ca1cc6370 Add --long option and more columns to the hypervisor list command
Support --long option and more columns in output of hypervisor
list command, including 'Hypervisor Type', 'Host IP', 'State',
and 'vCPU Used', 'vCPUs', 'Memory MB Used', 'Memory MB' with
--long option.

Change-Id: I0c790c7835309dded03e230cf497168e19404537
Closes-Bug: #1637074
2016-10-27 04:33:47 -07:00
Jenkins
0b63d5d586 Merge "Rename variable to avoid shadowing of built-in name" 2016-10-25 10:44:05 +00:00
Jenkins
824ed8490f Merge "Avoid duplicated project_id when show network" 2016-10-25 10:28:31 +00:00
Jenkins
ac7b336ce3 Merge "Updated coverage configuration file" 2016-10-25 10:28:23 +00:00
Jenkins
7825e1a2c3 Merge "Adds information about private key generation for instance access" 2016-10-25 10:28:15 +00:00
Jenkins
b6a8822921 Merge "Warning for empty password set for user create/set" 2016-10-25 10:19:30 +00:00
Jenkins
2be2190115 Merge "update volume and zone commands" 2016-10-25 10:09:42 +00:00
Jenkins
ddb1ce0e12 Merge "update openstackclient page url" 2016-10-25 10:09:16 +00:00
Anne Gentle
5055074db0 Adds information about private key generation for instance access
- Also updated the help text in the command itself.

Change-Id: Ib3d4f94ef415a3f12024d0d7c000d2de20de001b
Partial-Bug: 1549410
2016-10-25 08:51:20 +02:00
Iswarya_Vakati
f4f1a51692 Updated coverage configuration file
removed unneccassary directories in .coveragerc file
  openstackclient/openstack/*

it is no longer valid, we no longer use content from oslo-incubator

Change-Id: I0b361617e855aae322009b97697dcc13a394ceba
2016-10-24 17:53:33 +05:30
judy-yu
151c161a5e Avoid duplicated project_id when show network
Project_id appear twice when show network. This
patch check and not append if it already has one.

Change-Id: I4400239f454522101b639a0412050dd60eb6a612
Closes-Bug: #1636123
Partially-Implements: blueprint duplicated-project-id
2016-10-24 17:16:48 +08:00
OpenStack Proposal Bot
be9306f1d4 Updated from global requirements
Change-Id: I76fa121b61b50403af404c8d6e5d9a390231230c
2016-10-22 01:27:27 +00:00
liujunpeng
09eb81674b update openstackclient page url
The wiki url has been deprecated.

Change-Id: I4101b357d59661dce06519f158181982c5f96db5
2016-10-21 09:00:45 +00:00
liujunpeng
586ac02058 update volume and zone commands
-add volume backup
-add zone export/import

Change-Id: Ied99ba78e9a45d323e68656ada318ed2984bdc02
2016-10-21 07:30:39 +00:00
Yan Xing'an
65a08d6af6 Improve a network testcase
Fix a typo networ to network, and add assertEqual lines.

Change-Id: I13c0c775c1d5f7a8f579d387cd9bea1bdd74aebc
2016-10-20 21:56:00 -07:00
Huanxuan Ao
292608dc08 Use FakeImage class to replace duplicated image info in volume test
FakeImage class has been added in image v1 so that
we can reuse it in volume v1 unit test to replace
the duplicated image info in volume v1 fake.

Change-Id: I0f96e568bd65e59241b57704fc2a379319a386d8
2016-10-21 10:39:06 +08:00
OpenStack Proposal Bot
e0aa1acbae Updated from global requirements
Change-Id: Iaa10a45834aef38a432c6cf84a7766252116773a
2016-10-21 00:50:36 +00:00
Yan Xing'an
e6fb658606 Correct help string of the subnet pool list options
Correct help string of subnet pool list options, from
"subnets" to "subnet pools".

Change-Id: Ic6dd6649f411748cd0c6e6b08f0451c8a0fa220f
Partially-Implements: blueprint network-commands-options
2016-10-20 06:25:58 -07:00
Huanxuan Ao
57d5f94540 Allow input the QoS policy name in network rbac create command
We could input a QoS policy ID for the "rbac_object"
parameter in "network rbac create" command but not
name before. After this change, "rbac_object" parameter
can be both QoS policy name or ID.

Change-Id: I0fd6b5b5ae410074d85475ef49e5a0a9a52bf86f
2016-10-20 12:37:40 +08:00
OpenStack Proposal Bot
fee1a31296 Updated from global requirements
Change-Id: I54c524ba67b4f481fe3e262dcc4bc6c5601608a8
2016-10-19 17:46:01 +00:00
Jenkins
cf88d03957 Merge "Reset allocation pools to [] instead of ''" 2016-10-19 14:24:15 +00:00
Yan Xing'an
a1e3056414 Add option to allow filtering by mac-address on port list
Added support to allow filtering ports via --mac-address
option to the port list command.

Change-Id: I903e443f2f9057571d46520c4cafb88d1972c0cb
Partial-bug: #1634333
Partially-Implements: blueprint network-commands-options
2016-10-19 02:50:47 -07:00
OpenStack Proposal Bot
6eff90c3d6 Updated from global requirements
Change-Id: I8345847ce7c5987de4446d5a4c2c275fc376a3bb
2016-10-19 03:58:36 +00:00
qtang
3770ad08b2 Warning for empty password set for user create/set
Raise warning when empty password set for user

Change-Id: If03516f3f1290e4c329fe3d1277dee0512de0410
Closes-Bug: #1607959
2016-10-19 03:07:54 +00:00
Carl Baldwin
d373d76d1d Reset allocation pools to [] instead of ''
the sdk expects subnet allocation pools to be reset to an empty array,
not an empty string.

Currently this results in an error message:

  "Invalid input for allocation_pools. Reason: Invalid data format
   for IP pool"

Change-Id: I7cc84b9c8e4abdbd2c91e5d591ad31f0849c1a83
Closes-Bug: #1634672
2016-10-19 00:27:49 +00:00
Kyrylo Romanenko
acc39673ab Rename variable to avoid shadowing of built-in name
Change-Id: I06e2617db1d5508723bc343072a15586af89b390
2016-10-18 19:12:23 +03:00
Huanxuan Ao
daffce3a6a Add "--read-only" and "--read-write" options in "volume set"
Add "--read-only" and "--read-write" options in "volume set"
command to set volume access mode.

Implements: bp cinder-command-support
Change-Id: I76ba85c7d3ff0eb026a9cbd794368d8b2b0d17fe
2016-10-18 14:34:05 +08:00
Huanxuan Ao
d7c8bb88e4 Add "volume migrate" command
Add "volume migrate" command in volume v1 and v2
to support migrating volume to a new host

Change-Id: Ie4e6037171a31a872006a13f9fd1e15eaa627c26
Implements: bp cinder-command-support
2016-10-18 11:48:30 +08:00
Aradhana Singh
c99ec284db Add description field port create & port set
This patchset
1. adds description field to openstack port create and
 openstack port set.
2. updates method _add_updatable_args with 4 spaces instead
 of existing 8 spaces

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: I4598e555722b1de7bc47f3a9be0fd81eacfcb572
2016-10-17 22:21:34 +00:00
Jenkins
5e3ec1b42f Merge "Fix --shared/block-migration options in server migrate command" 2016-10-17 21:43:15 +00:00
Jenkins
ed8e918519 Merge "properly format error messages for volume resizing" 2016-10-17 20:41:32 +00:00
Jenkins
528f7a76d0 Merge "Add necessary info to Floating IP list" 2016-10-17 20:30:30 +00:00
Jenkins
f03cd87aba Merge "Update the doc for Zaqar v2" 2016-10-17 12:15:14 +00:00
Jenkins
ab9cfc4dc4 Merge "Add security groups options to "port create/set/unset"" 2016-10-17 08:27:58 +00:00
Reedip
bae09c3c3f Add support make a router HA
Currently router set CLI does not provide the
support make a router highly available. The following
patch enables the same.
Checking for setting a router as HA is left on the
neutron server itself.
Partially-Implements: blueprint network-commands-options
Change-Id: I0d0548cf037a14e5ccb2f732918ee9d1f63f43b4
Closes-Bug:#1631492
2016-10-16 05:05:23 +00:00
Reedip
8f8a8448a4 Add necessary info to Floating IP list
This patch adds the Network ID and Project ID
for the listed floating IPs when Neutron is enabled
for OpenstackClient.

Change-Id: I823090f2e6d30acd72247d30956f48f4d7672a50
Closes-Bug:#1566090
2016-10-16 05:04:38 +00:00
Steve Martinelli
82af038bb0 properly format error messages for volume resizing
The error messages are tuples and not substituting variables.

Before:
$ openstack volume set vol1 --size 1
Failed to set volume size: (u'New size must be greater than %s GB', 2)

$ openstack volume set vol1 --size 1
Failed to set volume size: (u'Volume is in %s state, it must be available
before size can be extended', u'error')

After:
$ openstack volume set vol2 --size 3
Failed to set volume size: New size must be greater than 4 GB

$ openstack volume set vol2 --size 3
Failed to set volume size: Volume is in error state, it must be available
before size can be extended

Change-Id: Ide6e644b1c6d1c11a9dc2f3f53c1a1837380b8d5
2016-10-15 20:29:54 -07:00
OpenStack Proposal Bot
a58bacc619 Updated from global requirements
Change-Id: Iff006bdedb4d7eefef9fc55e7bb3c0f37abbf784
2016-10-15 00:12:29 +00:00
wangxiyuan
928fecd134 Update the doc for Zaqar v2
Zaqar v1 and v1.1 is deprecated now, and the V2 is the default API
version. Update the plugin doc for it.

Change-Id: I26db823852ba543607b250a09aae63bb439a8959
2016-10-14 15:38:17 +08:00
OpenStack Proposal Bot
3a27163628 Updated from global requirements
Change-Id: Ia68a75e6cfbcfc267d68822a04e528605701672f
2016-10-14 05:44:06 +00:00
Nam Nguyen Hoai
291b66e983 Add direction and protocol options to os security group rule list cmd
This patch added direction options (--ingress, --egress) and protocol
option (--protocol) to filter rules by os security group rule list command.

Change-Id: I56ace3f97eb927fd2a868f728c7347a29d028b67
Closes-Bug: #1613533
Partially-Implements: blueprint network-commands-options
2016-10-14 02:59:07 +00:00
OpenStack Proposal Bot
43d1646058 Updated from global requirements
Change-Id: I24283bbbc5e1717b9824ad8f62859a3053910950
2016-10-13 05:28:24 +00:00
Jenkins
fd60e579c8 Merge "Add a new column and a new option the 'os port list' cmd" 2016-10-12 22:10:40 +00:00
Jenkins
a2e520c29c Merge "Add translation markers for object commands" 2016-10-12 21:26:47 +00:00
Jenkins
93157d52c7 Merge "Redefine set/unset command devref" 2016-10-12 21:20:45 +00:00
Nam Nguyen Hoai
2c1282cecf Add a new column and a new option the 'os port list' cmd
This patch will add a new column called status to the
result of the 'os port list' command and --long option
to 'os port list' command.

Co-Authored-By: Ha Van Tu <tuhv@vn.fujitsu.com>
Change-Id: I4f942414e969687304b578ed7f003dd219c0f2f8
Closes-Bug: #1613995
Closes-Bug: #1614321
Partially-Implements: blueprint network-commands-options
2016-10-12 20:40:46 +00:00
Nguyen Phuong An
66a04abd58 Add security groups options to "port create/set/unset"
This patch adds '--security-group' and '--no-security-group'
options to "port create", "port set" and "port unset" commands.

Change-Id: Iff60d8f29227017b0a3966efca6cdecba69abcea
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2016-10-12 09:03:07 +07:00
Jenkins
1ee9333d3a Merge "fix doc information in the limit.rst" 2016-10-12 01:57:38 +00:00
Cedric Brandily
694a24c309 Fix --shared/block-migration options in server migrate command
Currently, --shared-migration and --block-migration options effects are
reversed: --block-migration requests a migration with share,
--shared-migration a block-migration.

This change corrects OSC implementation and clarifies arguments passed
to novaclient (the root cause of the bug).

Change-Id: Ib682cff0c44d3b1304670f8606907b1762d8b1e7
Closes-Bug: #1518059
2016-10-11 22:01:16 +02:00
Jenkins
0f02f7ea1e Merge "Add network support for Network QoS policies" 2016-10-11 18:14:00 +00:00
Rodolfo Alonso Hernandez
3205dad161 Add network support for Network QoS policies
Added following commands:
  - network qos policy create
  - network qos policy delete
  - network qos policy set
  - network qos policy show
  - network qos policy list

Closes-Bug: 1609037
Depends-On: I33bafeca979410d329ae10a82772ccdb48c10daa

Change-Id: I63a8f63702514ff5814481bb021e2aa9d5f3d4b1
2016-10-11 15:08:36 +00:00
Jenkins
6f60817cd4 Merge "Refactor image v1 unit tests with FakeImage class" 2016-10-11 12:42:47 +00:00
Choe, Cheng-Dae
2bbb482106 Fix router unset --route option
Fix the "--route" option one the "os route unset" command. The option
did not convert gateway to nexthop which results "Router does not contain
route" error.

Change-Id: Ia57bc7ea77ad7c6030535180a6ce42b4928c9e56
Closes-Bug: 1631471
2016-10-10 23:57:22 +09:00
Rui Chen
29f78500db Redefine set/unset command devref
Now we have some use cases about set/unset properties,
try to redefine devref to find out a best and easiest
solution to keep commands simple and clearly.

Five use cases exist in property action, "append",
"update", "remove", "clean", "override", the following
rules can cover all these use cases:

1. append   ==> "set --property new-key=value"
2. update   ==> "set --property existed-key=new-value"
3. remove   ==> "unset --property existed-key"
4. clean    ==> "set --no-property"
5. clean    ==> "unset --all-property"
6. override ==> "set --no-property --property new-key=value"

Related blueprint support-no-property-in-aggregate and
blueprint allow-overwrite-set-options.
Change-Id: If86daf6989d8e0ad0dc6e590d7636be7d5203a18
2016-10-10 09:36:47 +08:00
Huanxuan Ao
407e164c95 Refactor image v1 unit tests with FakeImage class
Add FakeImage class, and refactor the unit tests
with it in image v1.

Change-Id: I9024ca5eca5c604e7588c1d905562bf6838309f1
Implements: bp improve-image-unittest-framework
2016-10-09 16:41:00 +08:00
Dean Troyer
762f2f2c34 More 3.3.0 release notes
Plus minor doc formatting updates

Change-Id: I849794e954cdeb582f7a0b104c62ec6688ead628
2016-10-07 21:39:53 +00:00
Jenkins
12ed93e3d1 Merge "Improve output of supported API versions" 2016-10-07 17:54:07 +00:00
Kyrylo Romanenko
42f9317360 Improve output of supported API versions
Sort supported versions properly for better look.

Change-Id: I6c2f5ecc04cf14ea5bf1b214cb303fcc9783af3f
Closes-Bug: #1630962
2016-10-07 11:02:53 +00:00
Jenkins
7e7f755754 Merge "Mask passwords in debug logs for auth_config_hook" 2016-10-07 01:34:03 +00:00
Jenkins
5ba5e1e321 Merge "Enable release notes translation" 2016-10-07 00:15:22 +00:00
Jenkins
4aaa9da8c9 Merge "Document openstack complete help and usage" 2016-10-06 23:41:38 +00:00
Andreas Jaeger
d695e3b157 Enable release notes translation
Releasenote translation publishing is being prepared. 'locale_dirs'
needs to be defined in conf.py to generate translated version of the
release notes.

Note that this repository might not get translated release notes - or
no translations at all - but we add the entry here nevertheless to
prepare for it.

Change-Id: Ib265f919e176f048f6e56bde47db3d99b3dd993e
2016-10-06 20:51:51 +02:00
OpenStack Proposal Bot
55c4290403 Updated from global requirements
Change-Id: Iacadedbfcf1500ae67f7c401bf5a3e22aa07c366
2016-10-06 17:02:13 +00:00
Matt Riedemann
cd1a412408 Mask passwords in debug logs for auth_config_hook
The auth config hook can have credentials in it so
we have to mask the config before logging it. To
avoid doing the work of masking the password if we
aren't going to log it, there is a conditional put
around the actual debug statement.

Change-Id: I8e626672ec94fc837610216bccb4354dbdedca17
Closes-Bug: #1630822
2016-10-05 21:11:16 -04:00
Richard Theis
d6cc50f0da SDK Refactor: Prepare subnet pool commands
Prepare the OSC "subnet pool" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I6d8cb7a079cf115ee25d48d9175e31f0f995c502
Partially-Implements: blueprint network-command-sdk-support
2016-10-05 08:50:58 -05:00
Richard Theis
368a250321 SDK Refactor: Prepare network segment commands
Prepare the OSC "network segment" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I426ecdad0f9d95b89e80fb1c5ba81ffe5fe274c9
Partially-Implements: blueprint network-command-sdk-support
2016-10-05 07:34:20 -05:00
Richard Theis
70cb628278 SDK Refactor: Prepare address scope commands
Prepare the OSC "address scope" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I4e253e01f9b0b10452354f4e4152468090c76958
Partially-Implements: blueprint network-command-sdk-support
2016-10-05 06:36:18 -05:00
OpenStack Proposal Bot
bfeecd50fd Updated from global requirements
Change-Id: Ib5e40955446ef8edfb2e461b6284a7fdf655ea76
2016-10-05 01:36:09 +00:00
Huanxuan Ao
ea7f28fb4a Refactor qos spec unit test in volume v1
Refactor qos spec unit test with FakeQos class
in volume v1.

Change-Id: Ia76bf41a911457282b293dfaf0af311b1a9194ce
2016-10-04 23:07:51 +08:00
Jenkins
62bf9e2609 Merge "Add example in the doc when using Identity v3" 2016-09-30 15:15:58 +00:00
Jenkins
0f5fde430c Merge "Add --ha option to os router create command" 2016-09-30 14:14:23 +00:00
Nam Nguyen Hoai
e2fc436d53 Add --ha option to os router create command
This patch added --ha option which the 'os router create'
command was missed.

Change-Id: I77635fb17af32beb0d8ed9aa080ef79285719fdc
Closes-Bug: #1610161
2016-10-01 14:55:23 +07:00
Jenkins
4f81103ac1 Merge "Updated from global requirements" 2016-09-30 13:58:15 +00:00
Jenkins
8031cd25d4 Merge "Replace 'MagicMock' with 'Mock'" 2016-09-30 11:13:09 +00:00
OpenStack Proposal Bot
eadbeb3979 Updated from global requirements
Change-Id: I065a55b5fb0fdf01d47434012a4ea4ea3d67c2ba
2016-09-30 10:24:22 +00:00
Steve Martinelli
d0a0ff77a8 Document openstack complete help and usage
Currently we have no documentation for the `complete` command.

Change-Id: I9faf38341bb57a61869ddbef406a022219a7c62c
Closes-Bug: 1623860
2016-09-30 01:16:22 -04:00
Jenkins
15069ef50e Merge "Support "--no" option in aggregate set" 2016-09-29 19:22:31 +00:00
Léo GEORGEL
0ae68f55fc Add example in the doc when using Identity v3
Add example doc with user_domain_name and project_domain_name

Change-Id: I5f454fcf705c8af1f0a1b85385bd7d8587234a14
2016-09-29 10:36:26 +02:00
Jenkins
2026dee17e Merge "Remove beta label for network segment resource" 2016-09-29 04:50:25 +00:00
Jenkins
fe879b5bd1 Merge "Add and modify options for "volume create" command" 2016-09-29 02:38:37 +00:00
Jenkins
08df1d0afc Merge "Implement "consistency group list" command" 2016-09-29 02:38:12 +00:00
OpenStack Proposal Bot
f41e27ec3a Updated from global requirements
Change-Id: I0895da779013a3fc586a36d4bbd6d1daf55bde20
2016-09-28 17:33:31 +00:00
Jenkins
01caa6913c Merge "remove square backet to required parameter" 2016-09-28 17:06:49 +00:00
Jenkins
ace3603ae9 Merge "Update default nova api version to 2.1" 2016-09-28 17:06:13 +00:00
Jenkins
d0ecb8981d Merge "Add option "--name" to command "openstack object create"" 2016-09-28 16:35:04 +00:00
qtang
c9fd35a496 Update default nova api version to 2.1
Ref:https://review.openstack.org/#/c/311653/
We should use 2.1 as the default nova version now

The API_MIN_VERSION of novaclient has already changed to 2.1

Change-Id: I9ff16cf052556e5d3756f81e02a8e76e8f315df5
Closes-bug: #1588171
2016-09-28 14:02:00 +00:00
Richard Theis
256ec66f79 Remove beta label for network segment resource
With Ocata development opened, neutron network segments are no
longer beta resources.

Change-Id: I25be51c30df17c746136471b88840f64a03187b9
Partially-Implements: blueprint routed-networks
2016-09-28 08:44:34 -05:00
Huanxuan Ao
c9e0c01f67 Add and modify options for "volume create" command
1.Add mutually exclusive options into a mutually
exclusive group.
2.Add "--source-replicated", "--consistency-group",
"--hint" and "multi-attach" options
3.Make --size option to be optional under some cases

Closes-Bug: #1568005
Closes-Bug: #1627913
Implements: bp implement-cinder-features
Co-Authored-By: Roman Vasilets <rvasilets@mirantis.com>
Change-Id: I2c4c3073195d33774e477f4d7f22e383b14b41dd
2016-09-28 10:13:56 +08:00
Huanxuan Ao
8d63b8b263 Implement "consistency group list" command
Add "consistency group" object in volume v2 (v2 only)
and implement "consistency group list" command

Change-Id: Ifa90d97f4b223f9a5b00708cff07fa2c5e2635f0
Implements: bp cinder-command-support
Partial-Bug: #1613964
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-28 09:31:04 +08:00
Jenkins
81a2b9a6bc Merge "Updated from global requirements" 2016-09-27 15:53:16 +00:00
Jenkins
bc42efa8ca Merge "Add option markup in osc doc" 2016-09-27 12:20:49 +00:00
Jenkins
1fb39ab401 Merge "Remove reference to CLI Ref in osc doc" 2016-09-27 12:20:17 +00:00
OpenStack Proposal Bot
7d2d9fd84c Updated from global requirements
Change-Id: Idd9c9a1c114001a3628ec69098495f9875537ec2
2016-09-27 10:07:38 +00:00
zheng yin
c4ab086195 fix doc information in the limit.rst
I check files in compute/v2, and I find there is a mistake, then
I fix it.

Change-Id: Ic17b9d5e64e4ed8b1d8e1476c73dd6d9365167fc
2016-09-27 13:52:56 +08:00
Nguyen Phuong An
3e9749149b Replace 'MagicMock' with 'Mock'
Change-Id: I35ebb2f0c83ec4300e26a72d9217ed0208f526eb
Closes-Bug: #1475722
2016-09-27 09:52:41 +07:00
Rajasi Kulkarni
28b66459db Add translation markers for object commands
None of the help messages for the object commands
are marked for translation. This patch adds the
necessary support.

Co-Authored-By: Steve Martinelli <s.martinelli@gmail.com>
Change-Id: Ibf472d8f7d5ab6c876f60cddcab8833b28f042e0
2016-09-26 22:52:14 -04:00
Rajasi Kulkarni
78312ca9af Add option "--name" to command "openstack object create"
Option "--name" can be used to set as the object name of
the file to be uploaded in the container. Similar to option
"--object-name" in command "swift upload". Added unit test case
to ensure an exception is raised when using option "--name" for
uploading multiple objects.

Change-Id: Ied7827841f6ca1cf9d4b48e304cbe5d62eda38ab
Closes-Bug: #1607972
2016-09-26 22:42:10 -04:00
Jenkins
f19240fc29 Merge "Add default limit for container/object" 2016-09-27 02:34:08 +00:00
Jenkins
10d1c2fd4e Merge "Add warning message for --state option of set command in volume" 2016-09-26 13:19:12 +00:00
Jenkins
5ce90a8298 Merge "Add command option parameter in console-url.rst" 2016-09-26 12:44:58 +00:00
Jenkins
eb02349ff8 Merge "Align '=' for developing.rst and newton.rst" 2016-09-26 12:42:44 +00:00
zheng yin
9912fdd7ff Add default limit for container/object
Default container name length less than or equal to 256 in link[1],
as the same time,default object name length less than or equal to 1024
in link[2]. Thereforce, I check the length of container and object in take_action.
and if it's greater than 256/1024 I warn the user.

[1] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L39
[2] https://github.com/openstack/swift/blob/master/swift/common/constraints.py#L35

Change-Id: I304b77cbc464eaba041321654cc29248cbe4b9a6
2016-09-26 20:42:26 +08:00
zheng yin
34eba23c7a Add command option parameter in console-url.rst
There are  options (--rdp,--serial,--mks) in console-url.rst,
but it has no these options after "os console url show", therefore,
I add them.

Change-Id: I4fd6b14f37cb5751021b8d33d4a65dae17e4e4e5
2016-09-26 15:43:25 +08:00
OpenStack Proposal Bot
5cc3efb004 Updated from global requirements
Change-Id: I9989b7e0b6aa2062283451831d74c7852701acd2
2016-09-26 04:27:11 +00:00
Huanxuan Ao
3ebc7520a6 Add warning message for --state option of set command in volume
There are some set commands can set object state, it maybe
a danger behavor for users, so add explanation and warning
in the help message of the "--state" option to talk users
be caution when using (cinderclient have done this too)

Change-Id: I6a902887ea98879999c9972f36b1b7ef332173c3
2016-09-26 02:42:47 +00:00
guangpei.liu
4fd00f04f2 Align '=' for developing.rst and newton.rst
Change-Id: I2d9b4cbaf65a0fa1c3184f52540b90d32b906fa3
2016-09-26 09:26:56 +08:00
OpenStack Proposal Bot
567ba7bb20 Updated from global requirements
Change-Id: Id079bf205bf61f3d26dfec526c98718fe05874f6
2016-09-25 10:02:35 +00:00
zheng yin
f2f12d91f7 remove square backet to required parameter
Required parameter don't need to square backet, therefore, I remove them.

Change-Id: I36517fb782da53b3b973f70f292f25a4f6784077
2016-09-25 15:49:40 +08:00
KATO Tomoyuki
50ad04df97 Remove reference to CLI Ref in osc doc
Since we decide to unify the osc doc into the osc repo,
CLI Reference does not provide osc content.

Change-Id: I0d530143105b5411a7a38e9e9d2297a1e8c69071
2016-09-25 14:20:20 +09:00
KATO Tomoyuki
084e4fbf1b Add option markup in osc doc
To avoid unintended hyphen concatenation: "openstack –help"

Change-Id: I6e8a1c453c5964bea4adc47d167904ab8ce8abda
2016-09-25 14:15:27 +09:00
Jenkins
559215d59d Merge "Fix typo in osc doc" 2016-09-25 04:31:14 +00:00
LiuNanke
02b6d32bfb Fix typo in osc doc
Change-Id: I8df73b36378e3de88ebe6d1ec125546c83f707c7
2016-09-25 10:43:58 +08:00
Huanxuan Ao
52eaec1189 Add functional test for snapshot in volume v1
Add functional test for snapshot commands in volume v1.
Tests can always help to find or avoid bugs.

Change-Id: Ieb0ab9c763d381a6343b4c4a8a5874f3e682f24f
2016-09-25 09:30:45 +08:00
Rui Chen
6371556916 Support "--no" option in aggregate set
Supporting "--no-property" option will apply user a convenience
way to clean all properties of aggregate in a short command,
and this kind of behavior is the recommended way to devref.
The patch add "--no-property" option in "aggregate set" command,
and update related test cases and devref document.

Change-Id: I7614a23c0db05144562330dc600dbab7d003d5d8
Implements: blueprint support-no-property-in-aggregate
2016-09-24 15:59:13 +08:00
OpenStack Proposal Bot
2731fc3912 Updated from global requirements
Change-Id: Ic4aed24a86fbce3c20ab96bd98edf9e249f8d247
2016-09-23 23:53:20 +00:00
Jenkins
e90ba0dfb4 Merge "Add unit tests for backup commands in volume v1" 2016-09-23 21:36:37 +00:00
Jenkins
ab6b9dc389 Merge "Fix unset commands to pass normally when nothing specified" 2016-09-23 21:36:14 +00:00
Jenkins
578cd12dfb Merge "Add --description to Neutron commands" 2016-09-23 18:26:55 +00:00
Ankur Gupta
0981931628 Add --description to Neutron commands
Added simple option for floating ip description when creating
a floating ip.

Added option for create and set router as well.

Partially Implements: blueprint neutron-client-descriptions
Partially Implements: blueprint network-commands-options

Change-Id: Ib8cd8af449e9ff33b980017b2527a6b196894a00
2016-09-23 16:09:17 +00:00
Jenkins
b0750c76ec Merge "Use assertGreater replace assertTrue" 2016-09-23 12:33:12 +00:00
Jenkins
1fc41f3837 Merge "Introduce overwrite functionality in `osc port set`" 2016-09-23 12:33:06 +00:00
Jenkins
40cc493b78 Merge "Overwrite/Clear support for subnets" 2016-09-23 12:24:16 +00:00
Jenkins
6a733bf312 Merge "Add square bracket to option parameter" 2016-09-23 11:37:29 +00:00
Huanxuan Ao
df8ef60603 Add unit tests for backup commands in volume v1
There was not any unit tests for backup commands
in volume v1 so that sometimes some small bugs
maybe ignored, this patch add unit tests for them.

Change-Id: Ic67c1b80243f7b3d15dabd25e4e4a1b1517a8b59
2016-09-23 17:22:44 +08:00
zheng yin
2e5d6a67f6 Use assertGreater replace assertTrue
we can use assertGreater(a,b) to replace assertTrue(a>b)

Change-Id: Idd92a99bf5fd25785a47645d46bcfcad23ed870a
2016-09-23 13:49:04 +08:00
Huanxuan Ao
fd876e4cc6 Fix unset commands to pass normally when nothing specified
After I found this problem appear in "volume unset",
I checked all the volume command and also found some
same problems. This patch fix them all.
The main reason of we ignored this problem before is
there was not any tests for it. So I add tests for
"nothing unset" for them all to test and aviod this
problem.
Also, I add unit tests for all snapshot commands
in volume v1 by the way in this patch. We will
need more tests to avoid some ignored problem.

Change-Id: I46775f24643d715e168b30785b8b531c0431a55b
Partial-bug: #1588588
2016-09-23 13:20:51 +08:00
zheng yin
07dfd05dda Add square bracket to option parameter
Because option parameter is not required. I add [] to option parameter.

Change-Id: I27c14c42bf576decff90a4a290dcaad7fab00524
2016-09-23 11:14:15 +08:00
Jenkins
465a5d08e0 Merge "Align '=' for image.rst" 2016-09-22 17:58:23 +00:00
Jenkins
9440509fa0 Merge "Add "volume backup set" command in volume v2" 2016-09-22 17:57:54 +00:00
OpenStack Proposal Bot
41f7de22d6 Updated from global requirements
Change-Id: I9f23736d106b4b6fcc37b98f03387ea041c5828d
2016-09-22 13:15:54 +00:00
Jenkins
bce740d5ff Merge "Add filtering options to os network list command" 2016-09-22 12:47:38 +00:00
Jenkins
80ce3bee6f Merge "Implement "volume transfer request show/accept" command" 2016-09-22 11:19:28 +00:00
Huanxuan Ao
3ef7e29dd0 Implement "volume transfer request show/accept" command
Add "volume transfer request show" and
"volume transfer accept" commands in
volume v1 and v2. Also add the unit tests,
docs, release note and functional tests

Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>

Change-Id: I5787fc486b3401307125caa316f517b9c96a95a5
2016-09-22 17:11:53 +08:00
qtang
1d5297ca07 Align '=' for image.rst
Change-Id: Iae074a9b6f5ef91738d35e41602c234aab5bed56
2016-09-22 16:13:25 +08:00
Jenkins
5dc8151b58 Merge "Add network segment create, delete and set support" 2016-09-22 07:27:06 +00:00
Huanxuan Ao
ddf84429f2 Add "volume backup set" command in volume v2
Add "volume backup set" command in volume v2 (v2 only)
to set backup name, description and state

Change-Id: If17e8457db9a4704fb5bb9c75921ed82fd0069cf
Closes-Bug: #1613261
2016-09-22 13:55:12 +08:00
Jenkins
69c4f605ec Merge "Fix "volume unset" command pass normally when nothing specified" 2016-09-22 02:35:13 +00:00
Jenkins
0c6a46ab5c Merge "Refactor volume unit test with FakeVolume class in volume v1" 2016-09-22 02:33:59 +00:00
Ha Van Tu
9c473f475d Add filtering options to os network list command
This patch adds the following filtering options: '--name', '--internal',
'--share' and '--no-share', '--enable' and '--disable', '--project'
and '--project-domain', '--status'.

Change-Id: I7e9dd372ee572c6ee8cdba7fac3182f9dc0a137b
Partially-Implements: blueprint network-commands-options
Closes-Bug: #1578819
2016-09-22 09:33:48 +07:00
Jenkins
80d9c2a9b0 Merge "Use correct router add/remove interface methods" 2016-09-21 15:49:22 +00:00
OpenStack Proposal Bot
274e400f5a Updated from global requirements
Change-Id: I6f4e6002d66342afda1821902625b90476d193b4
2016-09-21 11:56:44 +00:00
Jenkins
813eba519a Merge "replace metavar "volume-id" with "volume" to avoid ambiguity" 2016-09-21 07:48:45 +00:00
Huanxuan Ao
bba5c9047f Fix "volume unset" command pass normally when nothing specified
When nothing specified in "volume unset" command, there
will be an error message says that the "--properties"
option is required, it is unusual behaviour, this patch
fix it and also add unit test for it.
Also, this patch add unit test for "volume show" command
by the way.

Change-Id: I5b5d587670acf0af4262b8521292455bf9f60fe5
Partial-bug: #1588588
2016-09-21 15:47:55 +08:00
rabi
47b782687f Use correct router add/remove interface methods
Use the correct openstacksdk method names.

Change-Id: I07b463753eedf41f79c6e00e9224d0f7697a1bd3
Closes-Bug: #1625954
2016-09-21 13:09:39 +05:30
Huanxuan Ao
4a8b802d6b Refactor volume unit test with FakeVolume class in volume v1
FakeVolume class has been added in the fake.py in
volume v1, this patch refactors the volume command
unit tests with the FakeVolume class.

Change-Id: Ic3c1a46d5bff9048d0095f5739ae9e5a34ca6b5b
2016-09-21 15:33:37 +08:00
Shu Yingya
b30a7b795f replace metavar "volume-id" with "volume" to avoid ambiguity
The help message of command "openstack volume show" accepts either
volume-name or volume-ID. But the metavar is "volume-id" as below.
It can easily lead to misunderstanding.

usage: openstack volume show [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>]
                             [--noindent][--prefix PREFIX]
                             <volume-id>

Change-Id: I57576ea23868b1026cf268be69b39e98a53aafd4
2016-09-21 12:33:01 +08:00
Jenkins
682c2bfb8b Merge "Remove unnecessary setUp" 2016-09-21 04:30:29 +00:00
Reedip
7f12b745ce Overwrite/Clear support for subnets
This patch adds the overwrite/clear functionality
for allocation-pool and host-routes in subnets.

Change-Id: Idfa41173d0c054c5bfb4eda8c5f614928012555a
implements: blueprint allow-overwrite-set-options
2016-09-21 04:24:47 +00:00
reedip
b38be94a5d Introduce overwrite functionality in `osc port set`
The overwrite functionality allows user to overwrite
either the binding-profile or the fixed-ips of a
specific port.

Change-Id: I8ec3d04eeaf28972ee545fcdda4d5f7bd9deb915
partially-implements: blueprint allow-overwrite-set-options
2016-09-21 04:19:28 +00:00
zhufl
6f0462732a Remove unnecessary setUp
setUp will be automatically called around each
testcase, so this is to remove setUp that doing
nothing additional than super to keep code clean.

Change-Id: I47be2be6f0e9785eb166f89d411582d6292babc1
2016-09-21 10:46:46 +08:00
Jenkins
ccd2d658d1 Merge "Fix openstack quota set/show --class not work" 2016-09-20 09:01:16 +00:00
Jenkins
43f6b95229 Merge "Add --description to Create/Set Network" 2016-09-20 06:55:29 +00:00
Jenkins
a83f3c8a71 Merge "Add 'description' option to os subnet (pool) create/set cmd" 2016-09-20 06:40:48 +00:00
Jenkins
a51406da5a Merge "Provide support to list ports by network" 2016-09-20 06:32:46 +00:00
Cao Xuan Hoang
4265002e59 Add 'description' option to os subnet (pool) create/set cmd
This patch adds '--description' option to the commands.

Change-Id: Ifc2828670c3c48a87a0493d98686a5babf9b2ae7
Closes-Bug: #1614458
Closes-Bug: #1614823
Partially-Implements: blueprint network-commands-options
2016-09-20 10:12:42 +07:00
Ankur Gupta
88be7ddd38 Add --description to Create/Set Network
Added simple option for network description to create and
set network.

Change-Id: I90ce4db4e365a56ecddb00d59f4c5aa2ebbd49a3
Partially-Implements: blueprint network-command-options
2016-09-19 19:18:17 -05:00
Dean Troyer
5ec435e706 Clean up docs and notes for 3.3.0 release
Change-Id: I432dcb5e85819d22e6b30758da80d31c9a0db654
2016-09-19 14:59:38 -05:00
Jenkins
ad56086663 Merge "router list if availability_zone ext not enabled" 2016-09-19 19:35:26 +00:00
Jenkins
44cf358a14 Merge "Add filtering options to os subnet pool list command" 2016-09-19 15:15:26 +00:00
Jenkins
6d2412b190 Merge "Add filtering options to os subnet list command" 2016-09-19 14:14:31 +00:00
Jenkins
e1cdba48f4 Merge "Fix quota-update issue in LBaaS" 2016-09-19 10:53:41 +00:00
Reedip
554607eb3d Provide support to list ports by network
The new --network option provides a list of ports
connected with the current network.

Change-Id: I6a45184887b3e65f792391cb7e91f4ad85f29e03
Partial-Bug:#1562067
Partially-Implements: blueprint network-commands-options
2016-09-19 09:25:10 +00:00
Cao Xuan Hoang
1a6ae06ad5 Add filtering options to os subnet pool list command
This patch adds the following filtering options:
'--share' and '--no-share', '--default' and '--no-default',
'--project' and '--project-domain', '--name',
'--address-scope' options to the command.

Change-Id: I7ad9ed6842c6b3475ebf316fb5b954c7f5a7d7e3
Closes-Bug: #1613926
Partially-Implements: blueprint network-commands-options
2016-09-19 16:16:06 +07:00
Jenkins
2fe7d76c00 Merge "Fix Quota Support for HMs" 2016-09-19 08:46:06 +00:00
Cao Xuan Hoang
d44782bc08 Add filtering options to os subnet list command
This patch adds the following filtering options:
'--project' and '--project-domain', '--network', '--gateway',
'--name', '--subnet-range' to the command.

Change-Id: I575739486b9548492bd00f50130181b825534226
Partially-Implements: blueprint network-commands-options
Closes-Bug: #1610883
2016-09-19 14:00:49 +07:00
Jenkins
7e990ba1e2 Merge "Doc, help and message updates for port unset" 2016-09-17 02:04:50 +00:00
Reedip
91c4509afe Fix quota-update issue in LBaaS
Currently L7Policies cannot be updated( it was missing
in implementation in neutronclient). The same has been
taken care in the current patch.

Also, currently quota doesnt support updating the members
in an LBaaS pool. This patch temporarily removes it, till
it is not confirmed that LBaaS v2 needs to support quotas
for members or not.

Change-Id: I25a54a57debb762a32a280ece8c081fc52365f0f
Closes-Bug: #1624097
2016-09-16 10:57:02 +00:00
Reedip
d3e9361796 Fix Quota Support for HMs
Health Monitors could not be updated using
the `openstack quota update` CLI.

This patch fixes the same.

Change-Id: Ic5a4fa5dce5767e40139137131114834d564f89a
Closes-Bug: #1624225
2016-09-16 12:47:55 +05:30
Cedric Brandily
e6b09eef0c Correct login name deduction in SshServer
Currently SshServer ("server ssh" command) raises an AttributeError if
no explicit login is provided because it uses an attribute which no more
exists.

Change-Id: I86f68230037d51efb41aca62e07e058733ecd67a
Closes-Bug: #1624085
2016-09-15 21:57:17 +02:00
Ukesh Kumar Vasudevan
e04e389da2 router list if availability_zone ext not enabled
when calling router list with --long OSC expects the availability_zone
field in the response, even if this extension is not loaded:

As per the document, http://developer.openstack.org/api-ref/networking/
v2/?expanded=list-routers-detail, The availability zone(s) for the router
is available when router_availability_zone extension is enabled.

Added testcase to test router list without availability zone

Change-Id: Ic9abb06140eb310b797ade8b0463a876d8bea1b8
Closes-bug: #1622565
2016-09-15 16:24:15 +05:30
Jenkins
276675f352 Merge "Support mark volume as bootable in volume set" 2016-09-14 18:48:28 +00:00
Jenkins
807ff825ef Merge "Support listing specified server's ports" 2016-09-14 17:45:21 +00:00
Jenkins
3b0e648041 Merge "Multi REST API calls error handling of "volume unset" command" 2016-09-14 17:02:04 +00:00
Jenkins
c381193214 Merge "Do not show "os-volume-type-access:is_public" property of volume type" 2016-09-14 16:55:03 +00:00
qtang
6a914d0056 Support mark volume as bootable in volume set
Add --bootable | --non-bootable option in volume set
to mark or unmark volume as bootable.

Change-Id: Ifa6c2dd1642202f55b6d50e3b8614d3513d488f6
Closes-Bug:#1535704
2016-09-14 16:35:49 +00:00
Richard Theis
7cba0ed671 Doc, help and message updates for port unset
Update port unset based on review comments in [1].

[1] https://review.openstack.org/#/c/306236/

Change-Id: Icae6e3869516f2d53f90ad46efc03f897c00b0e5
Implements: blueprint network-property-unset
2016-09-14 08:01:56 -05:00
qtang
bc222e97b1 Replace 'MagicMock' with 'Mock'
Change-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1
Closes-Bug: #1475722
2016-09-14 17:59:31 +08:00
Rui Chen
96a8ed435c Support listing specified server's ports
Add new option "--server" for "port list" command to
list all of the ports that are attached on the specified
server.

Change-Id: I8b5550ea5068405b163711303465b704b5207410
Closes-Bug: #1614385
2016-09-14 15:11:56 +08:00
qtang
2a01ede6b6 Fix openstack quota set/show --class not work
identity_client should not be used for quota class operation.
Update code to fix the qutoa class set/show issue.

Change-Id: I71c59c08a0d5da29982497f589e1efe131997f21
Closes-Bug: #1609233
2016-09-14 11:15:01 +08:00
Rui Chen
6f326acd26 Support fetching network project default quota
Neutron server and openstacksdk had supported to fetch
network project default quota, this patch add the CLI
support in openstackclient.

Change-Id: If0ef74c268c41a866c62156da0603a40ae4e6e31
Closes-Bug: #1204956
Depends-On: I6a4e2a146351dd1e7d652442511f1ef2c279da42
2016-09-13 17:23:22 +08:00
Jenkins
320ed01774 Merge "remove the old post_test_hook" 2016-09-13 08:44:49 +00:00
Jenkins
4c83d75833 Merge "Display hypervisor information without uptime" 2016-09-12 20:43:10 +00:00
Jenkins
d5a011216e Merge "Fix regular expression for uptime in hypervisor show" 2016-09-12 20:25:45 +00:00
Jenkins
ed4454c5bb Merge "Set quota "per_volume_gigabytes", "backup_gigabytes" and "backups"" 2016-09-12 17:59:36 +00:00
Jenkins
c8ecd9a497 Merge "Add functional tests for unset multiple volume type props" 2016-09-12 17:23:14 +00:00
Jenkins
d8f2fd3bcd Merge "Trivial: Rename ListTransferRequests to ListTransferRequest" 2016-09-12 17:06:08 +00:00
Jenkins
8ec1c2791a Merge "Unit tests of quota command refactor" 2016-09-12 14:17:37 +00:00
Jenkins
b5078cd9f9 Merge "remove duplicate unit test" 2016-09-12 12:45:00 +00:00
Jenkins
fb66a5b8f9 Merge "Add unit test for volume type in volume v1" 2016-09-12 04:27:43 +00:00
Rui Chen
8d59b31c72 Add functional tests for unset multiple volume type props
CinderClient bug/1596511 cause that OSC can't unset multiple
properties of volume type, obviously no functional test case
cover the part of logic in OSC, that make the issue raising,
the patch add functional test cases for this scenario.

Change-Id: I42cf9ac8cc72ccc2f1208926d8faf7b80ee2d288
Partial-Bug: #1596511
Depends-On: I60378a32cdc52aacdf869d69b246dec7eb6cdb77
2016-09-12 11:08:32 +08:00
Rui Chen
6fba7163e8 Set quota "per_volume_gigabytes", "backup_gigabytes" and "backups"
"per_volume_gigabytes", "backup_gigabytes" and "backups" items
can be shown in "openstack quota show" command, but can't be
updated by "openstack quota set". This patch fix the issue.

Change-Id: I47db5a69d4e4ef6e140f2735257c83e1fb052760
Closes-Bug: #1609767
2016-09-12 11:00:55 +08:00
Rui Chen
4e71e9da6b Unit tests of quota command refactor
Do refactor for quota command related unit tests, remove
useless code, add new tests to cover '--volume-type' and
'--class' option in "quota set" command and add the
volume quota fake object.

Change-Id: Iaf214740e98db1bfb4c739e810bac1c5ba6e9625
2016-09-12 10:54:15 +08:00
Tang Chen
1a78c76250 Trivial: Rename ListTransferRequests to ListTransferRequest
The class name should use plural.

Change-Id: I2de2489ff9aa60c2d1bf12743cbd41f2091739ca
2016-09-12 10:44:54 +08:00
Hironori Shiina
98bafda7e9 Display hypervisor information without uptime
Some virt drivers such as ironic virt driver doesn't implement a
method to get host uptime. For such drivers, hypervisor show command
displays no information although these drivers provides other host
information.

This patch fixes the command to display hypervisor information in case
where a virt driver doesn't provide host uptime by ignoring a
HTTPNotImplemented exception.

Change-Id: I7bcca5862cd9c05aadaf6192cb80aa651cd77cad
Closes-Bug: 1612065
2016-09-11 21:58:55 +09:00
Hironori Shiina
d6f99b721d Fix regular expression for uptime in hypervisor show
Hypervisor show command has a few bugs as follows.
- It doesn't trim an extra whitespace in the head of uptime
  information.
- It doesn't display uptime information when the number of user is 1.

This patch fixes the regular expression to match uptime information.

Change-Id: Ic2f7fd9a9274466717084a0886f95f78e98a9007
Closes-Bug: 1611809
2016-09-11 21:48:23 +09:00
Huanxuan Ao
9966412c2d Add unit test for volume type in volume v1
Add unit test for volume type commands
(create/delete/show/list/set/unset)
in volume v1

Change-Id: I6ff1f1c7482bd0b4bfec5b4a1496807b722fa047
2016-09-11 14:20:58 +08:00
Huanxuan Ao
d2273ecea5 Implement "volume transfer request delete" command
Add "volume transfer request delete" command in
volume v1 and v2. Also add the unit tests, docs,
release note and functional tests

Change-Id: Ic3d375bc8df3312fac53c1800d75f48376b8c91c
Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-11 14:08:27 +08:00
Huanxuan Ao
6f4acc45c6 Implement "volume transfer request create" command
Add "volume transfer request create" command in
volume v1 and v2. Also add the unit tests, docs,
release note and functional tests

Change-Id: If362df1acf214efdf6ba129cd917d33eb54e1030
Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-09-11 14:08:19 +08:00
Jenkins
30afdb9684 Merge "Error handling of multi REST API calls for "snapshot set" command" 2016-09-11 05:50:40 +00:00
Jenkins
cc5379b55c Merge "Add "--limit" and "--marker" options to "volume list" command" 2016-09-11 05:22:58 +00:00
Jenkins
f5c09fe246 Merge "Support error handling for delete commands in volume v1" 2016-09-11 05:02:35 +00:00
Huanxuan Ao
10e665a148 Error handling of multi REST API calls for "snapshot set" command
Support multi REST API calls error handling for
"snapshot set" command follow the rule in
doc/source/command-errors.rst. Also add a unit
test for testing the error handling

Change-Id: I0c6214271bc54a25b051c0a62438c3344c8b51d7
2016-09-11 11:41:05 +08:00
Huanxuan Ao
6986a32e1c Add "--limit" and "--marker" options to "volume list" command
Add ``--limit`` option to ``volume list`` command in volume v1,
add ``--limit`` and ``--marker`` options to ``volume list``
command in volume v2.

Change-Id: I327a252aa83ed84166da99cf6aa80334e0e6dd44
Partial-Bug: #1612484
2016-09-11 11:23:25 +08:00
Huanxuan Ao
af81a92c37 Support error handling for delete commands in volume v1
Some delete commands in volume v1 support multi delete
but do not support error handling, this patch fixes them,
and this patch also refactor (or add new) unit tests for
some delete commands in volume v1.

Change-Id: Ia8177698f8733cfe75ea0ff00eee8fdc0820f62e
2016-09-11 11:08:14 +08:00
Huanxuan Ao
cb6c11b0a8 Multi REST API calls error handling of "volume unset" command
Support multi REST API calls error handling for "volume unset"
command follow the rule in doc/source/command-errors.rst.
Also add a unit test for testing the error handling

Change-Id: I2de7a7bd5a7a5e39817ed5cf6952abf4afba75e4
2016-09-11 11:00:09 +08:00
Jenkins
7d3d2b0c37 Merge "Add importing file to import warnings" 2016-09-11 02:24:37 +00:00
Steve Martinelli
6adea68274 remove the old post_test_hook
Use the new location in openstackclient.tests.functional.

Depends-On: I49d54f009021d65c1ae49faf6b3f0a7acdadd7b3

Change-Id: I53b8fcc21c5f3638fd334245036c3d99bcaf9012
2016-09-10 04:58:10 +00:00
Steve Martinelli
60e815a989 remove duplicate unit test
looks like this test snuck in during the refactor:

$ diff openstackclient/tests/volume/v1/test_service.py \
  openstackclient/tests/unit/volume/v1/test_service.py

17c17
< from openstackclient.tests.volume.v1 import fakes as service_fakes
---
> from openstackclient.tests.unit.volume.v1 import fakes as service_fakes

Change-Id: I769b2d39f28cfaf65e4027c785b0ddbbefa26aea
2016-09-10 04:57:56 +00:00
Steve Martinelli
676a0e9696 unwedge the gate
since changing the infra job to call the new bash script location,
the functional tests now have a permission error:
py.error.EACCES: [Permission denied]: mkdir('/opt/stack/new/python-openstackclient/.tox',)

Change-Id: Ibe7057c99feac952d80156fb996d0193e1b0e497
2016-09-09 22:49:35 -04:00
Richard Theis
4f23a77de0 Add network segment create, delete and set support
Add network segment create, delete and set in support of routed
networks. This patch set includes documentation, unit tests and
functional tests for the following new commands:
  - "os network segment create"
  - "os network segment delete"
  - "os network segment set"
This patch set also includes support for the name and description
properties.

These new commands are currently marked as beta commands.

Change-Id: I86bc223c4adc5b5fe1b1ee5c9253e43ba52fb5ed
Depends-On: Ib194125162057fccb4e951587c2fa4ec2e2f098c
Partially-Implements: blueprint routed-networks
2016-09-09 15:19:55 -05:00
Jenkins
bee04914b8 Merge "move all functional tests to tests module" 2016-09-09 19:30:10 +00:00
Jenkins
0b203355c4 Merge "standardize release note page ordering" 2016-09-09 15:53:55 +00:00
Steve Martinelli
c14d3efe61 move all functional tests to tests module
functional tests should be grouped with other tests (unit and
integration tests). as part of this commit the "common" module
was renamed to just "base", this was done for simplicity.

the post_test_hook.sh file was also copied to the functional module
since it should live there. a separate change to the infra repo
will be made to call the new location, once that is merged we
can remove the old one (a new change will also be posted for that)

Needed-By: I49d54f009021d65c1ae49faf6b3f0a7acdadd7b3
Change-Id: Ie8c334f6223373b8e06df8bd8466500d2a2c8ede
2016-09-09 03:29:47 +00:00
Steve Martinelli
39839def2e move unit tests to new "unit" test module
this will better isolate the unit tests from the functional tests.
unfortunately, the "integration" tests had to be lumped into the
"unit" tests since we need the separation in testr.conf

Change-Id: Ifd12198c1f90e4e3c951c73bfa1884ab300d8ded
2016-09-08 15:19:50 -07:00
Jenkins
7d1a5d0854 Merge "format token expires time to prevent json loading datetime data" 2016-09-08 20:58:20 +00:00
Jenkins
b4307b1ef6 Merge "Add Subnet service-types to subnets" 2016-09-08 20:54:36 +00:00
Jenkins
085bc5255d Merge "Defer auth prompting until it is actually needed" 2016-09-08 17:40:13 +00:00
Dean Troyer
14dbfe4474 Defer auth prompting until it is actually needed
Auth option prompting happens waaaay to early in the default
os-client-config flow, we need to defer it until adter the commands
have been parsed.  This is why ClientManager.setup_auth() exists,
as it is not called until the first attempt to connect to a server
occurs.  Commands that do not require authentication never hit this.

Also, required options were not being enforced.  By doing this we handle
when no authentication info is present, we fail on missing auth-url rather
than attempt to prompt for a password (default auth is password).

Closes-Bug: 1619274
Change-Id: Ia4eae350e6904c9eb2c8507d9b3429fe52418726
2016-09-08 10:31:13 -05:00
Doug Hellmann
d1de0bac88 standardize release note page ordering
In order to support automatically updating the release notes when we
create stable branches, we want the pages to be in a standard order.
This patch updates the order to be reverse chronological, so the most
recent notes appear at the top.

Change-Id: Ib364dcc8eb31275a31c83b68d7914263b183e393
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2016-09-07 17:08:46 -04:00
Huanxuan Ao
5231ade27c Do not show "os-volume-type-access:is_public" property of volume type
"os-volume-type-access:is_public" property is the
same as "is_public" property in volume type object.
So stop showing "os-volume-type-access:is_public"
property and leave "is_public" property only.

Change-Id: Ic78a9ee69b0ab356edff18cdb4c46fc24b495d2b
Closes-Bug: #1620922
2016-09-07 16:40:54 +08:00
Jenkins
55378953e2 Merge "Clean up FakeClient classes in volume fakes" 2016-09-06 14:03:38 +00:00
Jenkins
bc1c964c40 Merge "better functional test collection" 2016-09-06 14:01:27 +00:00
Jenkins
f7f0f770af Merge "Use assertIn(A, B) instead of assertTrue(A in B )" 2016-09-06 13:53:17 +00:00
Steve Martinelli
eba1bc04f4 better functional test collection
straight up copied from glanceclient [1]

[1] https://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/functional/hooks/post_test_hook.sh

Change-Id: I9fad6d5c86831a2b872f3a61d4c7fa7383fc1266
2016-09-05 22:21:13 -07:00
Jenkins
20ad61b9d4 Merge "Add "volume service set" command" 2016-09-06 03:40:31 +00:00
Steve Martinelli
24c8b94baf format token expires time to prevent json loading datetime data
When output to shell, the token issue time is fine; however when
selecting the json formatter (via the --format json) option, an
exception is raised when formatting the dataetime data.

Rather than pass in the datetime data, we should format the data
with the ISO 8601 formatting.

Closes-Bug: 1619937
Change-Id: Iffebb2d5413fabfd283dfa94fc560fc37270f9dd
2016-09-05 17:23:42 +00:00
Doug Hellmann
3b75c9aae5 Update reno for stable/newton
Change-Id: Ice2d2eb4cc922e911c1f92020e8f5a298383f7f3
2016-09-02 15:54:49 +00:00
Bin Zhou
1626b63f56 Use assertIn(A, B) instead of assertTrue(A in B )
Developers should use assertIn(A, B) instead of assertTrue(A in B ).

TrivialFix

Change-Id: I0d7c542272315590536c427a8865e49660361e55
2016-09-02 12:48:41 +08:00
OpenStack Proposal Bot
45d3e67b98 Updated from global requirements
Change-Id: I610346bca6a1a8ff9e0ab20fec664d3aff58c44c
2016-09-01 18:50:33 +00:00
Jenkins
59404393d3 Merge "Rearrange integration tests" 2016-09-01 13:17:05 +00:00
Dean Troyer
ca15cd434b Rearrange integration tests
Move the integration tests into their final home...

* Create tests/integ to hold the integration tests
* Split tests/test_shell_integ.py into tests/integ/base.py and
  tests/integ/cli/test_shell.py
* Rename TestXXXXInteg classes to TestIntegXXXX
* Adds tests/integ/cli/test_project.py for some simple project argument tests

Change-Id: I2cdd340d1d446d61784eae35dd5aa09d40d5899d
2016-08-31 14:59:36 -05:00
OpenStack Proposal Bot
a24d6ba605 Updated from global requirements
Change-Id: I87af564cffaf44669e1efe4ca45c75a6307f1286
2016-08-31 09:14:50 +00:00
OpenStack Proposal Bot
8241f08ee1 Updated from global requirements
Change-Id: I2eedd06457425f48353e416b4d5145ce1967d57c
2016-08-30 14:53:39 +00:00
Dean Troyer
110a62f277 Add importing file to import warnings
Add the Python file doing the import to the warnings emitted by
the modules moved to osc-lib. Users will at least have a hint as
to which package is out-of-date.

Change-Id: I633b440c30b2b15cfde7a9013e30dfa39ab200bc
2016-08-30 09:21:02 -05:00
Dean Troyer
84c83fc3ae Provide fallback prompt function for current osc-lib
Leaving the pw_func uninitialize in osc-lib turned out to be a
bad idea as the test to prompt in setup_auth() doesn't check
for a callback of None.

Also, release note

Change-Id: I8f875fa8a942d02a040238359ee22c603a4e5956
2016-08-29 19:22:06 -05:00
Jenkins
c5f8f761de Merge "Fix auth prompt brokenness" 2016-08-29 21:09:58 +00:00
Dean Troyer
bec206fa0a Fix auth prompt brokenness
We start by fixing this in the already-present OSC_Config class so OSC
can move forward.  This change needs to get ported down into
os-client-config in the near future, maybe even soon enough to make the
client library freeze this week.

* Add the pw-func argument to the OSC_Config (or OpenStackConfig) __init__()
* When looping through the auth options from the KSA plugin look for any
  that have a prompt defined and do not have a value already, so ask for one.

Closes-bug: #1617384
Change-Id: Ic86d56b8a6844516292fb74513712b486fec4442
2016-08-29 11:58:49 -05:00
Jenkins
0ee74b4b27 Merge "Updated from global requirements" 2016-08-29 15:30:50 +00:00
Jenkins
c4610557a9 Merge "[docs] fix incorrect rst markups" 2016-08-29 13:17:56 +00:00
Jenkins
8fce974d2d Merge "Clean imports in code" 2016-08-29 13:13:32 +00:00
Jenkins
b42740816d Merge "Fix six typos" 2016-08-29 12:49:43 +00:00
OpenStack Proposal Bot
5b14741fcc Updated from global requirements
Change-Id: I90afe332e959ba8bbfb1f04cc84454d30a4cf4a8
2016-08-29 10:57:56 +00:00
Andreas Jaeger
9962403d3c Cleanup after install
Tox tests are run on developer machines and on long lived slaves. We
should not leave lots of directories like
/tmp/python-openstackclient-tox_install-sdnltRu lying around.

Instead delete the temporary directory after our run.

Remove also an obsolete comment.

Change-Id: I939eae82dba3287fd4e4086128ebf4609a0e0770
2016-08-28 08:48:23 +02:00
Jenkins
a08b62523f Merge "Restore default auth-type for token/endpoint" 2016-08-25 21:07:03 +00:00
Atsushi SAKAI
c97e8187fe Fix six typos
disassoiate => disassociate
nmaes       => names
mutiually   => mutually
aviod       => avoid
CLustering  => Clustering
availble    => available

Change-Id: I84545bf46acfccc9dde3e85020700edb5a8375a6
2016-08-25 19:54:24 +09:00
OpenStack Proposal Bot
2774145e44 Updated from global requirements
Change-Id: I87cd3d1aaf2d7e8706b4e89ef679c03de69cf611
2016-08-25 09:31:05 +00:00
Cao Xuan Hoang
f854b7d6ea Clean imports in code
In some part in the code we import objects.
In the Openstack style guidelines they recommend to import only modules.

http://docs.openstack.org/developer/hacking/#imports

Change-Id: I2eb35dc53f0fdb61c31022bb70293d1df8aaf482
2016-08-25 13:50:38 +07:00
OpenStack Proposal Bot
afda6f846f Updated from global requirements
Change-Id: I14eec90a7bfe8301b8698dd4337f3748c3732b78
2016-08-25 01:11:34 +00:00
Dean Troyer
188709c668 Restore default auth-type for token/endpoint
The split to osc-lib shell lost the detection of --os-token and
--os-url to set --os-auth-type token_endpoint

Closes-bug: 1615988
Change-Id: I248f776a3a7b276195c162818f41ba20760ee545
2016-08-24 16:57:56 -05:00
OpenStack Proposal Bot
3f86cc0d80 Updated from global requirements
Change-Id: I53797c068d919027c7cfadcb245ab06eb9affc9e
2016-08-24 13:35:57 +00:00
KATO Tomoyuki
50a5c2a163 [docs] fix incorrect rst markups
The incorrect md-style markups break Sphinx builds,
which do not properly generate web page.

http://docs.openstack.org/developer/python-openstackclient/plugin-commands.html

Change-Id: I36ae2cf922836cff42653283c0a683359bd91344
2016-08-24 16:38:21 +09:00
Jenkins
351bfb7915 Merge "Fix post and periodic jobs" 2016-08-23 06:27:32 +00:00
Huanxuan Ao
8f07fec3f2 Clean up FakeClient classes in volume fakes
Put FakeTransferClient and FakeServiceClient classes
into FakeVolumeClient class, I think we need not to
create FakeClient classes for every objects, we can use
only FakeVolumeClient for all volume objects. This can
reduce repetition, unified codes and make codes look
cleaner and easier.

Change-Id: I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe
2016-08-23 10:31:24 +08:00
Dean Troyer
684412ca4c Work around a version clash issue with os-client-config
Need to add the fixed_arguments arg to _validate_auth() so
os-client-config 1.19.1 and 1.20.0 can call our version properly.

Change-Id: I328e47ba2f8115e6b18bf1482fd4aa35056907a4
2016-08-22 08:29:35 -05:00
Andreas Jaeger
ea5a8dd80b Fix post and periodic jobs
The usage of zuul-cloner in tox_install breaks post and periodic jobs.
Update the script, it does not need to handle unconstrainted installs
anymore (see tox.ini). There's no need to set ZUUL_BRANCH explicitely
- it's set via the environment and branch is passed in as well.

Note that this script is needed for the edit-constraints call, add a
comment.

Change-Id: I0077c986a17d6bb92791474e03d1e77776e9382f
Closes-Bug: #1615430
2016-08-22 12:19:39 +02:00
Jenkins
cb31fda264 Merge "Updated from global requirements" 2016-08-21 03:33:12 +00:00
Jenkins
90b89acf60 Merge "Integ test cleanup" 2016-08-21 02:37:11 +00:00
OpenStack Proposal Bot
2f0d419e7c Updated from global requirements
Change-Id: Ia8340e97b90f7497244f57c7ab7e46d7a461b896
2016-08-21 00:10:10 +00:00
Brian Haley
cf9ad08ab6 Add Subnet service-types to subnets
Add '--service-type' to subnet arguments to support
Subnet service-types.

Change-Id: I215d83e4d4cf53e03fa35041c5e41a328641b3a9
Partially-implements: blueprint service-subnets
2016-08-19 11:05:33 -04:00
Jenkins
8f63da4621 Merge "Fix errors in volume set/unset image properties unit tests" 2016-08-19 02:48:08 +00:00
Jenkins
7489fa36aa Merge "Add support for domain specific roles" 2016-08-18 23:30:54 +00:00
Dean Troyer
06721ea889 Integ test cleanup
Change-Id: Ie58a7bec569421097e92a7ddf3cb164fc3f07413
2016-08-18 17:45:29 -05:00
Jenkins
8cef12ce08 Merge "Add shell integration test" 2016-08-18 22:31:08 +00:00
Jenkins
dbfc203c7b Merge "Fix up last-minute imports to use osc-lib" 2016-08-18 22:12:35 +00:00
Jenkins
a28e281a91 Merge "update requirements and test requirements" 2016-08-18 22:10:37 +00:00
Jenkins
20cd4eca59 Merge "document locale and language support tips" 2016-08-18 22:10:31 +00:00
Dean Troyer
cc3d46a47b Fix up last-minute imports to use osc-lib
Change-Id: I1ed2983cf574ebd565eeac4f8199fbc3a2e29c8e
2016-08-18 18:22:42 +00:00
Steve Martinelli
b8d6ceef86 document locale and language support tips
We have full support for various locales and languages, but often
there are hiccups when setting up a terminal to use OSC in this
manner. Document a few common questions so we don't have to
individually support each bug report.

Change-Id: I0f7c7efce3a2c00cc82ed8c67310e027b5e45a45
2016-08-18 18:08:21 +00:00
Jenkins
34f5515a32 Merge "Gate-unbreaking combo review" 2016-08-18 17:52:37 +00:00
Dean Troyer
44f6b76929 Add shell integration test
These run next to unit tests, but unlike unit tests, they test the
dependent libraries also.  This is to detect incompatible breakage
in those dependencies.  The tests provide CLI-level input and
verify the API calls being made via requests using requests_mock
so the entire stack is tested.

It is possible we want to run these separate from the unit tests.
They do not belong in the functional tests as they do not require
a functional cloud for testing.

Depends-on: I426548376fc7d3cdb36501310dafd8c44d22ae30
Change-Id: I356956fcc4ff35191a6ad6a085b75cf370434b09
2016-08-18 11:15:18 -05:00
Dean Troyer
2a1a174086 Gate-unbreaking combo review
Fix argument precedence hack
  Working around issues in os-client-config <= 1.18.0

  This is ugly because the issues in o-c-c 1.19.1 run even deeper
  than in 1.18.0, so we're going to use 1.19.0 get_one_cloud() that
  is known to work for OSC and fix o-c-c with an axe.

Remove return values for set commands
  'identity provider set' and 'service provider set' were still
  returning their show-like data, this is a fail for set commands
  now, don't know how this ever passed before...

Constraints are ready to be used for tox.ini
  Per email[1] from Andreas, we don't need to hack at install_command
  any longer.

  [1] http://openstack.markmail.org/thread/a4l7tokbotwqvuoh

Co-authorioed-by: Steve Martinelli <s.martinelli@gmail.com>
Depends-On: I49313dc7d4f44ec897de7a375f25b7ed864226f1
Change-Id: I426548376fc7d3cdb36501310dafd8c44d22ae30
2016-08-18 07:21:15 -05:00
Huanxuan Ao
81431d24a9 Add "volume service set" command
Add "volume service set" command in volume v1 and v2
(v1 is the same as v2) to disable or enable volume service.

Change-Id: Ibb2db7e93b24cb2e0d2a7c28b6fd8bcc851b8d2f
Closes-Bug: #1613597
2016-08-17 10:42:28 +08:00
Steve Martinelli
51cbe414e3 update requirements and test requirements
with the move to osc-lib we don't have to list some requirements.
removed oslo.config since it was not being used, and moved a few
to test-requirements since they are still used in examples and
unit tests.

Closes-Bug: 1593784

Change-Id: I39b610e6a49a4a346dddcedd231d9a7a81cab261
2016-08-11 00:45:56 -07:00
Jenkins
fc7a69e410 Merge "Add '--dhcp' and '--no-dhcp' options to os subnet list cmd" 2016-08-11 07:27:35 +00:00
Jenkins
c9cf6c4eb2 Merge "Rename backup commands in volume v1 and v2" 2016-08-11 04:36:52 +00:00
Jenkins
5b724fc88b Merge "Implement "network agent set" command" 2016-08-11 04:07:03 +00:00
Huanxuan Ao
95f0e3dc36 Fix errors in volume set/unset image properties unit tests
These errors may caused by copy-paste, we should specify
a fake return value for get() method but not create() method.
Create() mothod will not called in set/unset command. After
specifing the return value of get(), we can use the fake volume
in the assert.

Change-Id: I1e0df4c28ece373168788c396e9082d565e36cc7
2016-08-11 11:43:03 +08:00
Huanxuan Ao
39c5eb9e3f Rename backup commands in volume v1 and v2
Backup commands are used only in volume service now,
but "backup" is too generic, users may not know the
commands are used for volume from the commands name.
By seeing the command name, users can only see the
"backup" but do not know which object the backup
commands work for. It may confuse users. I think
rename "backup" to "volume backup" can depict resource
relation and will be helpful for users to know the
commands clearly.

So add new commands ``volume backup create/delete/
list/show/restore`` to replace the old commands
``backup create/delete/list/show/restore``. And also
deprecate old commands.

Change-Id: I4f844d9bc48573eb4d17288ce6b8a90cea00d16a
Implements: bp backup-snapshot-renamed-for-volume-resource
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
2016-08-11 09:32:10 +08:00
Henry Nash
5eb7e626b1 Add support for domain specific roles
A role entity can now be specified as domain specific.

Closes-bug: #1606105
Change-Id: I564cf3da1d61f5bfcf85be591480d2f5c8d694a0
2016-08-10 20:32:55 +00:00
Richard Theis
b3248fb0bd Fix OSC identity v3 functional tests
The OSC identity v3 functional tests are failing due to [1] which
added 'password_expires_at' to the user object. This patch set
fixes the tests by updating user object fields list to include
'password_expires_at'.

[1] https://review.openstack.org/#/c/333360/

Change-Id: Id4b060115d4270899ca0af2dc7b67ee723388e31
2016-08-10 08:51:25 -05:00
Huanxuan Ao
722be75f9c Implement "network agent set" command
Add "network agent set" command in network v2 to set network
agent properties.
Also add the unit test, doc, functional test and release note.

Change-Id: Iebaee4c60f8c6b43f538c1b82a38b93178b9ce53
Implements: bp implement-network-agents
Co-Authored-By: Michael Gugino <michael.gugino@walmart.com>
2016-08-10 15:39:44 +08:00
Cao Xuan Hoang
831546fb9e Add '--dhcp' and '--no-dhcp' options to os subnet list cmd
This patch adds '--dhcp' and '--no-dhcp' options to filter
subnets resulted by os subnet list command.

Change-Id: Ib574cc54594845bc5c5afc38bf44e3b224d33b17
Partial-Bug: #1610883
2016-08-10 08:27:03 +07:00
Cao Xuan Hoang
0b91368164 Add --ip-version filtering option to subnet.rst
When executed "openstack subnet list --help" we can see this is
supported for --ip-version filtering option.
But this option is missing in the rst document.

Change-Id: Ie5443f1da086a1ad455fbeaa848b50a0d9d4b290
Closes-Bug: #1610872
2016-08-08 15:02:06 +07:00
Jenkins
80fd9b2bd4 Merge "Support multi REST API calls error handling for "volume set" command" 2016-08-06 12:02:29 +00:00
Jenkins
3692a2a91a Merge "osc-lib: shell" 2016-08-06 08:01:52 +00:00
Huanxuan Ao
3202fefc65 Support multi REST API calls error handling for "volume set" command
Support the error handling follow the rule in
doc/source/command-errors.rst
Also add a unit test for testing the error handling

Change-Id: I98064f4b8c1dc17eb3874f7b25c827a568463c0f
2016-08-06 09:15:21 +08:00
OpenStack Proposal Bot
63f8018fe3 Updated from global requirements
Change-Id: Ic33376d005aa07d377af183ba3537c6c1ee22c21
2016-08-05 20:28:07 +00:00
Dean Troyer
6a15f90dae osc-lib: shell
Convert to using ClientManager and OpenStackShell from osc-lib.
* Change all internal uses of ClientManager private attributes that are
  now public in osc-lib's ClientManager.  Leave back-compat copies in
  place in OSC's clientManager so we don't break plugins.
* Put some work-arounds in place for changes in osc-lib that we need until
  a new release makes it through the g-r and u-c change process.
* Add a test for Unicode decoding of argv in shell.main() to parallel
  the one in osc-lib.

Change-Id: I85289740d4ca081f2aca8c9b40ec422ad25d302c
2016-08-05 13:48:55 -05:00
Jenkins
020f13e12b Merge "Implement network agents functionality" 2016-08-05 16:01:13 +00:00
Jenkins
6dd3f45e39 Merge "Show "target_project_id" attribute properly for network rbac object" 2016-08-05 13:38:32 +00:00
Jenkins
79459cac77 Merge "Document network trunk commands" 2016-08-05 12:43:31 +00:00
Michael Gugino
0736336a71 Implement network agents functionality
python-neutronclient implements the following command set:

agent-list, agent-show, agent-delete

These commands display and modify various network agents and their
information.

python-openstacksdk has supported the api calls for these commands,
but python-openstackclient does not implement these commands.

This commit adds support for the following commands:

openstack network agent list
openstack network agent show <agent>
openstack network agent delete <agent>

Change-Id: I83ede6f89c37e7bdc38d7e9e7bb9d80e94c8becc
Implements: blueprint implement-network-agents
Depends-On: I9755637f76787d5fac8ff295ae273b308fcb98d0
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
2016-08-05 16:25:33 +08:00
Huanxuan Ao
7f93d8cc88 Show "target_project_id" attribute properly for network rbac object
According to the code in SDK:
https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/rbac_policy.py#L34
we can see the conlumn of "target_tenant" should be
"targer_project_id" but not "target_project". It is
the reason why could not show the "target_project"
in OSC, so this patch fix it.

Before this change:
(openstack) network rbac show b74fd644-e057-4d44-8ae1-7ca9967ea1e1
+----------------+--------------------------------------+
| Field          | Value                                |
+----------------+--------------------------------------+
| action         | access_as_shared                     |
| id             | b74fd644-e057-4d44-8ae1-7ca9967ea1e1 |
| object_id      | 8735b57f-606a-4f65-9902-2052a6d2a66d |
| object_type    | network                              |
| project_id     | 01c0ba43101b4080a52a5f79a55c56ff     |
| target_project |                                      |
+----------------+--------------------------------------+
After this change:
(openstack) network rbac show b74fd644-e057-4d44-8ae1-7ca9967ea1e1
+-------------------+--------------------------------------+
| Field             | Value                                |
+-------------------+--------------------------------------+
| action            | access_as_shared                     |
| id                | b74fd644-e057-4d44-8ae1-7ca9967ea1e1 |
| object_id         | 8735b57f-606a-4f65-9902-2052a6d2a66d |
| object_type       | network                              |
| project_id        | 01c0ba43101b4080a52a5f79a55c56ff     |
| target_project_id | c7ab4d2ea9e1487095a8ca24ea44ef38     |
+-------------------+--------------------------------------+

Change-Id: I53df127bfc3e43288c6afecdf872e6101b94a658
Closes-Bug: #1608903
2016-08-05 10:05:58 +08:00
Jenkins
0472b9ec6d Merge "Updated from global requirements" 2016-08-05 01:29:34 +00:00
Jenkins
d6413b2765 Merge "Add support of setting volume's state" 2016-08-05 00:30:25 +00:00
Huanxuan Ao
f58be9d4dd Add unit tests for group commands in identity v3
Add unit tests for commands below in identity v3:
group create
group delete
group show
group set
group add user
group remove user
group contains user

Change-Id: I02f3b49e93582245a2749492bba1dfc4c5e0258d
2016-08-04 19:30:02 +08:00
OpenStack Proposal Bot
5479ff323a Updated from global requirements
Change-Id: I61c1841fc28a9a493ee1e5383f14515840fe4337
2016-08-04 02:41:46 +00:00
OpenStack Proposal Bot
06ea24725b Updated from global requirements
Change-Id: I202897c2d66cc9e20b3d2ef1564a37db26f88d47
2016-08-03 16:15:20 +00:00
Jenkins
a42664ccaa Merge "Implement "network rbac set" command" 2016-08-03 12:54:03 +00:00
Huanxuan Ao
ab32f37e67 Remove an outdated directory in tox.ini
The directory openstack/common from the exclude list of
flake8 in tox.ini was used to keep codes from oslo-incubator,
but oslo-incubator was retired, so don't use this directory
any more.

Change-Id: If1ea5dc167cfe4a09aad413b9eab0af807ebe603
2016-08-03 13:44:05 +08:00
Xi Yang
20ae54045c Add support of setting volume's state
OSC does not support to set volume's state, this
patch is going to add this functionality.

Closes-Bug:#1535213
Change-Id: I5bc1c7e81b8ba61c37f4bfd209fc86c5857fb050
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
2016-08-03 12:19:16 +08:00
Huanxuan Ao
fac3214581 Implement "network rbac set" command
Add "network rbac set" command which just supports
setting a target project.
Also, This patch adds the doc, unit test and functional test.
But there is a bug of showing network RBAC
https://bugs.launchpad.net/python-openstacksdk/+bug/1608903
We need to skip the functional test before this bug fixed.

Change-Id: I756f448bb333cf1098a735e57a1c5dc4edf195d4
Partially-Implements: blueprint neutron-client-rbac
2016-08-03 10:49:57 +08:00
Jenkins
eaee74bba2 Merge "Add a document for required options" 2016-08-02 18:42:13 +00:00
Huanxuan Ao
c1a040f66d Add a document for required options
Some options are required in some commands, I think we need
a document to state what should we do in this case.

Change-Id: Id345ca1790e2125b333b271b74288e1a73d39ba3
2016-08-02 19:54:30 +08:00
Huanxuan Ao
5125b6f73b Refactor identity v3 unit tests with fake class
Refactor unit tests in identity v3 for "user", "endpoint", "group"
and "service" with fake classes.

Change-Id: I57316bbf762c805f8e9ae225b394bbe58ebdd416
Partially-Implements: blueprint refactor-identity-unit-test
2016-08-02 12:36:15 +08:00
Jenkins
2a1c2b2275 Merge "Updated from global requirements" 2016-08-01 23:06:36 +00:00
Jenkins
3c4c0ce23f Merge "OS_DEFAULT_DOMAIN must be an ID" 2016-08-01 19:40:41 +00:00
OpenStack Proposal Bot
1d2c9a79df Updated from global requirements
Change-Id: Iccc0deccc66dd82b101ca4fdd099cc55325ea516
2016-08-01 18:47:35 +00:00
Jenkins
f40f3f9f2f Merge "arguments are not locale decoded into Unicode" 2016-08-01 17:37:00 +00:00
Ghe Rivero
27a55fd796 OS_DEFAULT_DOMAIN must be an ID
Fix the documentation to indicate that the value
of OS_DEFAULT_DOMAIN must be the domain ID. A
domain name is not valid here

Change-Id: Id6d42aa10ef346fa5124ef841c5ce408e34d6424
2016-08-01 15:31:00 +00:00
OpenStack Proposal Bot
19bea1ca91 Updated from global requirements
Change-Id: Ie90dc3937e1991202a9af7aa38c5e510947cb219
2016-07-30 01:24:17 +00:00
Jenkins
fe650e204b Merge "Implement network rbac create and delete commands" 2016-07-29 15:47:07 +00:00
Jenkins
b7b140df06 Merge "Pass security group id to novaclient while adding security group to server" 2016-07-29 13:21:20 +00:00
Jenkins
3b6bb4f495 Merge "Update the description of project in releasenotes." 2016-07-29 13:13:20 +00:00
Abhishek Raut
82baba0c82 Document network trunk commands
Commands were added for network trunk object as part of
change I6fe1dbd81813fae234801a61c0e3d89f9e7c791e.
This patch adds documentation for the same.

Change-Id: If89478bb4b8af08de11ad521669ba2ee91b76f69
Partial-implements: blueprint vlan-aware-vms
2016-07-28 22:25:35 -07:00
qtang
62c187df7a Update the description of project in releasenotes.
Change-Id: I1fe0e52d2e049d34666a6d94bac1d85b91a78b19
2016-07-29 11:15:31 +08:00
OpenStack Proposal Bot
62874a5307 Updated from global requirements
Change-Id: If225aca4a8b366b6657f46bc9478a88f9e9b1964
2016-07-29 02:34:59 +00:00
Rajasi Kulkarni
e26eecc12f Pass security group id to novaclient while adding security
group to server

In AddServerSecurityGroup, we currently pass the security group
name to novaclient. If multiple security groups with same name
exist, then even while passing secuity group using id to
command 'openstack server add security group <server> <group>'
it results in error 'Multiple security_group matches found'.
Added unit test case to test the command.

Change-Id: I6097eb36e1545c85209cfd767c477e10f82c6999
Closes-Bug: 1604076
2016-07-28 21:39:02 +05:30
Jenkins
3d53ae828b Merge "Allow setting quotas for server groups and server group members" 2016-07-28 13:12:07 +00:00
Huanxuan Ao
13bc3793e0 Implement network rbac create and delete commands
Add "network rbac create" and "network rbac delete" commands
and also add unit tests, functional tests, docs and release
note for them.

Change-Id: I5fd58342f2deaa9bae7717412a942a21bbd7d045
Partially-Implements: blueprint neutron-client-rbac
2016-07-28 10:23:29 +08:00
Jenkins
5f6257206e Merge "Add support for deleting volumes with associated snapshots" 2016-07-27 19:50:21 +00:00
Elena Ezhova
b50c2b6a88 Allow setting quotas for server groups and server group members
Adds support of --server-groups and --server-group-members options
to the "quota set" command.

Change-Id: I178d1e267d010be7e908adefcf3b15abdafd9da4
Closes-Bug: #1602223
2016-07-27 13:04:36 +03:00
Jenkins
97ccb65f83 Merge "Fix error for find_service() in identity" 2016-07-27 03:37:52 +00:00
wuyuting
954c28dfa2 Add support for deleting volumes with associated snapshots
OSC doesn't support deleting volumes with associated snapshots.
This patch provides support for deleting volumes with associated
snapshots by adding an optional argument.

Change-Id: I7e74f251574993ff13a38e508fd2f9debeda8d0a
Closes-Bug: #1589332
Co-Authored-By: Rui Chen <chenrui.momo@gmail.com>
2016-07-27 11:30:52 +08:00
John Dennis
756d2fac67 arguments are not locale decoded into Unicode
When the openstackclient in Python2 passes command line arguments to a
subcommand it fails to pass the arguments as text
(e.g. Unicode). Instead it passes the arguments as binary data encoded
using the current locales encoding.

An easy way to see this is trying to pass a username with a non-ASCII
character.

% openstack user delete ñew
No user with a name or ID of 'ñew' exists.

What occurs internally is when the user data is retrieved it's it
properly represented in a Unicode object. However the username pased
from the command line is still a str object encoded in the locales
encoding (typically UTF-8). A string comparison is attempted between
the encoded data from the command line and the Unicode text found in
the user representation. This seldom ends well, either the comparison
fails to match or a codec error is raised.

There is a hard and fast rule, all text data must be stored in Unicode
objects and the conversion from binary encoded text to Unicode must
occur as close to the I/O boundary as possible. Python3 enforces this
behavior automatically but in Python2 it is the programmers job to do
so.

In the past there have been attempts to fix problems deep inside
internal code by attempting to decode from UTF-8. There are two
problems with this approach. First, internal code has no way to
accurately know what encoding was used to encode the binary data. This
is way it needs to be decoded as close to the I/O source as possible
because that is the best place to know the actual encoding. Guessing
UTF-8 is at best a heuristic. Second, there must be a canonical
representation for data "inside" the program, you don't want dozens of
individual modules, classes, methods, etc. performing conversions,
instead they should be able to make the assumption in what format text
is represented in, the format for text data must be Unicode. This is
another reason to decode as close to the I/O as possible.

In Python3 the argv strings are decoded from the locales encoding by
the interpreter. By the time any Python3 code sees the argv strings
they will be Unicode. However in Python2 there must be explicit code
added to decode the argv strings into Unicode.

The conversion of sys.argv into Unicode only occurs when argv is not
passed to OpenStackShell.run(). If a caller of OpenStackShell.run()
supplies their own arg it is their responsiblity to assure they are
passing actual text objects. Consider this a requirement of the API.

Note: This patch does not contain a unittest to exercise the behavior
because it is difficult to construct a test that depends on command
invocation from a shell. The general structure of the unit tests is to
pass fake argv into OpenStackShell.run() as if it came from a
shell. Because the new code only operates when argv is not passed and
defaults to sys.argv it conflicts with the unittest design.

Change-Id: I779d260744728eae8455ff9dedb6e5c09c165559
Closes-Bug: 1603494
Signed-off-by: John Dennis <jdennis@redhat.com>
2016-07-26 18:09:20 -04:00
Jenkins
7a667d700f Merge "Use identity fake classes instead of old unit tests data" 2016-07-26 15:13:20 +00:00
Jenkins
0181709222 Merge "Use assertEqual() instead of assertDictEqual()" 2016-07-26 12:51:06 +00:00
Jenkins
6da7a127af Merge "Add options to "volume type list" command" 2016-07-26 10:53:40 +00:00
Huanxuan Ao
1b2ea91420 Use identity fake classes instead of old unit tests data
Use FakeProject, FakeDomain and FakeUser classes instead
of old test data in image, compute and volume. (This work
has done in network)

Change-Id: Ic37d5d9db98f0f2acc6c714a9646063dcbde4ff3
Partially-Implements: blueprint use-fake-project
2016-07-26 18:38:12 +08:00
Jenkins
566b8566c0 Merge "Standardize import format" 2016-07-26 07:22:27 +00:00
Jenkins
08ba2aa978 Merge "Add "--marker" and "--limit" options to "snapshot list"" 2016-07-26 07:22:21 +00:00
Jenkins
b838e9970d Merge "Unit test of credential in identityv3" 2016-07-26 07:09:45 +00:00
Dean Troyer
0bc2d83f68 Remove temporary code in ClientManager
This effectively reverts https://review.openstack.org/#/c/341618/.

Change-Id: Ic8e53e17b4a5352b0c00e39bcb5d248b057540a9
2016-07-25 14:55:33 -05:00
Tang Chen
bcaa5c2e0e Use assertEqual() instead of assertDictEqual()
In unittest2, assertDictEqual() is implemented by
using != operator to compare two dicts. So is
assertEqual() in testtools. assertEqual() in
testtools is able to handle dict, list, set and
so on. So we just call assertEqual() to make the
unit tests simpler.

Change-Id: Ice343b2ce468acae39d2ad79f7121503e3627656
2016-07-25 15:09:49 +08:00
Huanxuan Ao
e31408d2a4 Add options to "volume type list" command
Add "--public" and "--private" options to
"volume type command" in volumev2 (v2 only)
to list optional volume types

Change-Id: I8605990d62116c10d89ce192c14e550657dabee5
Closes-Bug: #1597198
2016-07-23 11:26:49 +08:00
Huanxuan Ao
61b9d9fe2d Add "--marker" and "--limit" options to "snapshot list"
Add "--marker" and "--limit" options to
"snapshot list" command in volume v2 (v2 only).

Change-Id: Ib60840b9b83dfe5e599e4037e8ec308844a9448b
Closes-Bug: #1605475
2016-07-23 10:41:28 +08:00
Huanxuan Ao
bca4571ab6 Unit test of credential in identityv3
Add missing unit tests and refactor the older tests
with fake classeds for credential in identity v3

Change-Id: I94d4f80a86806c6115178421bd481b7622065956
2016-07-23 10:02:23 +08:00
Jenkins
a8880e8b34 Merge "Add assignment list to v2 identity and deprecate alternate listing" 2016-07-23 00:04:39 +00:00
Jenkins
02e95dc8ff Merge "Rework clientmanager" 2016-07-22 22:54:05 +00:00
Henry Nash
713d92df4e Add assignment list to v2 identity and deprecate alternate listing
The current identity role list command (both v2 and v3) is
overloaded with listing roles as well as assignments (if you
provide user, group, project or domain options). This is in
addition to the v3 assignment list command designed for this
purpose.

This overloading complicates the fact that roles can now be
domain specific (i.e. have a domain attribute), so the
command 'role list --domain <domain-name' will soon become
ambigious (this is in a follow on patch).

This patch:

- Adds a v2 assignments list, with support for pulling the
user and project from the auth credentials
- For comapability, adds the same auth support to the
existing v3 assignments list
- Deprecates the use of role list and user role list to list
assignments

Change-Id: I65bafdef4f8c89e863dab101369d0d629fa818b8
Partial-Bug: 1605774
2016-07-22 21:46:29 +00:00
Jenkins
859517f657 Merge "Clarification of option name rules" 2016-07-22 21:07:58 +00:00
Dean Troyer
f38c51c1b9 Rework clientmanager
* Add compatibility for plugin v2 interface removed from osc-lib
* ClientManager.is_network_endpoint_enabled() is wrapper for
  new is_service_available()

Change-Id: I6f26ce9e4d0702f50c7949bacfbeeb0f98cddb5d
2016-07-22 20:49:18 +00:00
Jenkins
719c5d79ce Merge ""server list": "Image Name", "Image ID" columns" 2016-07-22 20:38:20 +00:00
Jenkins
d2cb96a2ef Merge "Remove execute permission on a few files" 2016-07-22 20:37:54 +00:00
Dean Troyer
75a1fcf70a Clarification of option name rules
We never specifcally said anywhere that short names are global only and why.

Change-Id: Ia2824cb7ebe7c2e1d116c0a9bc7760de24904c61
2016-07-22 12:58:28 -05:00
SongmingYan
1b878b4efd Remove execute permission on a few files
Some files have execute permission unnecessarily. Change them from
755 to 644.

Change-Id: I471ebd1c3d123ad4a7376f7f5996f53f8c2d9b0b
2016-07-22 17:38:34 +00:00
Jenkins
b59ade75e5 Merge "Support to get server rdp/serial/mks type console url" 2016-07-22 12:22:34 +00:00
sunyajing
c45b1d7b23 Fix error for find_service() in identity
if there are more than one services be found with one
name, a NoUniqueMatch exception should be raised but
we can see a NotFound Exception raised instead. It is
because in "find_service()", we use "find_resource()"
first, if "find_resource()" return a exception, we just
think it is a NotFound Exception and continue to find
by type but ignore a NoUniqueMatch exception of
"find_resource()". This patch refactor the "find_service()"
method to solve this problem.

Change-Id: Id4619092c57f276ae0698c89df0d5503b7423a4e
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
Closes-Bug:#1597296
2016-07-22 19:40:50 +08:00
shizhihui
f996138a0d Standardize import format
According to the rule in
http://docs.openstack.org/developer/hacking/#imports
I modify some irregular import format.

Change-Id: Ibf29ccaf3ddec4a956334cc3368ebee7a66e282c
2016-07-22 19:24:02 +08:00
Jenkins
831301e5d6 Merge "Add Support for showing flavor access list" 2016-07-22 09:11:42 +00:00
Swapnil Kulkarni (coolsvap)
d84393999a Remove discover from test-requirements
It's only needed for python < 2.7 which is not supported

Change-Id: If0e9fd59c47d27bc58917500c554819c6aa30b2c
2016-07-22 04:09:38 +00:00
Huanxuan Ao
b0c317ebdd Add Support for showing flavor access list
Add a attribute "access_project_id" for flavor object to
display the access project id list by using "flavor show"
command.

Change-Id: I7f0c152b816e0ca2e32e47f9b5c1aa7663d33b6d
Closes-Bug:#1575461
2016-07-22 10:20:18 +08:00
Jenkins
d20d97fd09 Merge "Set identity v3 client in networkv2 fake" 2016-07-22 00:51:48 +00:00
Jenkins
3e1d54299f Merge "Show project access for volume type" 2016-07-21 22:07:50 +00:00
Rui Chen
cf20225347 Support to get server rdp/serial/mks type console url
The patch add the support to get server rdp/serial/mks
type console url, that make osc capability equal with
current nova server side feature.

Change-Id: I3dee2531c68563725187c8251d5ea8d4c02cca0c
Closes-Bug: #1605088
2016-07-21 15:43:01 +08:00
OpenStack Proposal Bot
ba34c592a7 Updated from global requirements
Change-Id: I58e4387636739915dd90c93ce2ee6ee9522b634f
2016-07-21 04:10:27 +00:00
Jenkins
360853b51f Merge "Add unit tests for "host list" and "host show" commands" 2016-07-21 03:35:15 +00:00
Jenkins
ab18045c97 Merge "Implement rbac list and show command" 2016-07-20 16:08:36 +00:00
Jenkins
d0daf90e18 Merge "Transfer "ip floating CRUD" to "floating ip CRUD"" 2016-07-20 16:08:12 +00:00
Huanxuan Ao
e7fa8920d0 Set identity v3 client in networkv2 fake
Set identity v3 client in fake so that we needn't
set it everytime when we use it in unit test.

Change-Id: I9ed71056a357642e5aef7b670a7c85918aca59b9
2016-07-20 19:35:20 +08:00
Jenkins
412b29b972 Merge "Add port security option to network commands" 2016-07-20 10:12:40 +00:00
Sheel Rana
5e8957ef7f Show project access for volume type
OSC does not support to show project access details for
private volume types. This patch will provide support
for showing project access details for private volume types.

Closes-Bug:#1554891

Implements: bp cinder-command-support

Change-Id: I218fb07a6e69033e9f8570748eee1df8df9d6fdc
2016-07-20 16:54:58 +08:00
Tang Chen
0aa2304f38 Transfer "ip floating CRUD" to "floating ip CRUD"
This patch does the following things to transfer
"ip floating xxx" to "floating ip xxx":
* Add new command "floating ip create/delete/list/show", and doc.
* Deprecate "ip floating create/delete/list/show" command.

Change-Id: Ib071acaac81988431244e858bddafa7f93403df5
Implements: blueprint rework-ip-commands
Closes-bug: 1555990
Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
2016-07-20 13:37:48 +08:00
OpenStack Proposal Bot
07e97b1a8a Updated from global requirements
Change-Id: I5aa5e608f41e0c2d900ed35ae06db1552a71ea6e
2016-07-19 21:14:19 +00:00
Jenkins
33a40a08c2 Merge "Exchange the check order for the dhcp and no-dhcp" 2016-07-19 10:59:40 +00:00
Jenkins
ae2fd1a9ae Merge "Modify some help and error messages in ec2creds identityv2" 2016-07-19 09:26:22 +00:00
Jenkins
eb0a2f9834 Merge "Update doc for credential in indentityv3" 2016-07-19 09:21:56 +00:00
qtang
34435d9ca2 Exchange the check order for the dhcp and no-dhcp
The dhcp is setting with True by default and progress always
jump into the first if check.
So the no-dhcp option always ignored there.

Check the no-dhcp option first and then the dhcp option value
to avoid this.

Change-Id: Ide640e2cab3936d419ca62105304ff5d4a8a2074
Closes-Bug: #1602588
2016-07-19 16:35:36 +08:00
Huanxuan Ao
60639d76a7 Support bulk deletion for delete commands in identityv3
Support bulk deletion for delete commands in the list below
identity/v3/consumer
identity/v3/credential
identity/v3/domain
identity/v3/ec2creds
identity/v3/endpoint
identity/v3/federation_protocol
identity/v3/identity_provider
identity/v3/mapping
identity/v3/policy
identity/v3/region
identity/v3/service_provider
identity/v3/service

The unit test in identityv3 need to be refactored, so I add
some functional tests instead. I will add all unit tests at
one time after the refactor completed.

Change-Id: I82367570f59817b47c87b6c7bfeae95ccfe5c50e
Closes-Bug: #1592906
2016-07-19 09:49:36 +08:00
Jenkins
55c1c575d6 Merge "Added a note on how to test changes" 2016-07-18 23:03:47 +00:00
Jenkins
86e4b2a374 Merge "Unskip the tests affected by warlock 1.3.0" 2016-07-18 23:03:40 +00:00
Jenkins
3b396d2e3b Merge "Follow upper constraints for all tox targets" 2016-07-18 23:00:38 +00:00
Jenkins
5b0f87ff1f Merge "Add create_one_image_member() in FakeImage class and update test" 2016-07-18 22:54:30 +00:00
Jenkins
9fed459bf3 Merge "Allow format selection in get_opts" 2016-07-18 22:54:23 +00:00
Jenkins
6ce53fed83 Merge "Support error handling for delete commands in volumev2" 2016-07-18 22:41:07 +00:00
Jenkins
13f1aa9b81 Merge "Make set/unset commands pass normally when nothing specified in identityv3" 2016-07-18 22:15:31 +00:00
Jenkins
099c3bbd82 Merge "Add "--project" option to "volume type create" command" 2016-07-18 19:38:02 +00:00
Jenkins
ba0e1b6ef5 Merge "image list: Add Checksum column" 2016-07-18 18:38:49 +00:00
Jenkins
beaa06138e Merge "Pass security group id to novaclient" 2016-07-18 18:35:15 +00:00
Jenkins
5bd7d68ee3 Merge "Add network-topolopy support" 2016-07-18 18:34:49 +00:00
OpenStack Proposal Bot
9f6148132c Updated from global requirements
Change-Id: I74744755891f65da2c1d7b7b475230d395a3a8ee
2016-07-17 23:59:46 +00:00
Steve Martinelli
5ce351c492 Unskip the tests affected by warlock 1.3.0
1) This reverts commit 044a46ed5f
which was broken by warlock 1.3.0

Change-Id: Ia286d9394586884018c4e62cf581e39a809f5545
2016-07-17 17:02:01 +00:00
Steve Martinelli
e2a9fd29c1 Follow upper constraints for all tox targets
With the exception of releasenotes and cover, we should follow
upper constraints. The tox_install file was copied over from
python-neutronclient [1].

[1] http://git.openstack.org/cgit/openstack/python-neutronclient/tree/tools/tox_install.sh

Change-Id: I633fa149820efafd7b2acec0388fa8bc8d06c988
2016-07-17 17:01:52 +00:00
Huanxuan Ao
50dd4a1a1e Add create_one_image_member() in FakeImage class and update test
Usually we use a fake object in unit test. To match the other
test, add create_one_image_member() in FakeImage class in imagev2
to create a fake image member, delete the old data and update
the unit test of image.

Change-Id: I062a362b15db7e8bc89ec48c540d310199fd6c0b
2016-07-15 20:05:04 +08:00
Jenkins
1821f20c42 Merge "Add python-neutronclient to OSC plugins" 2016-07-15 07:22:45 +00:00
Huanxuan Ao
c0467edc64 Update doc for credential in indentityv3
Change-Id: I5f49c038a75ea67674b6d9279a6e60d6ded8d12f
2016-07-15 10:54:45 +08:00
OpenStack Proposal Bot
17dc8526ab Updated from global requirements
Change-Id: I51ce0df359d992153cbe0588c4f67d829a360032
2016-07-15 01:43:03 +00:00
Jenkins
1c745700d9 Merge "Change to plural form of object in multi delete error message in networkv2" 2016-07-14 22:41:11 +00:00
Kyrylo Romanenko
9f346c3fb6 Allow format selection in get_opts
Default is "value".

Change-Id: I244253f6cd53104a57ef12f6b14e1653c89d38bc
2016-07-14 14:09:18 +03:00
Huanxuan Ao
5e06d6a3a6 Change to plural form of object in multi delete error message in networkv2
Usually, the error message of multi delete is:
"'result' of 'total' 'objects' failed to delete"
the objects is a plural form.
To match the other multi delete error messages
in OSC, change the object in delete error message
in networkv2 to a plural form. Just add a 's' in
the message.

Change-Id: I17e0735d025bb61014db709d2639813565015b3d
2016-07-14 18:34:19 +08:00
Huanxuan Ao
9b51127ecc Support error handling for delete commands in volumev2
Some delete conmmands in volumev2 did not support
error handling, this patch add them and also add
the unit tests for bulk deletion

Change-Id: I56ade6f9c7396c78fb989547476c4d94ccd76eae
2016-07-14 17:49:26 +08:00
Jenkins
52cb503fb0 Merge "Modify compute agent set command" 2016-07-14 09:22:21 +00:00
Jenkins
bae17d9547 Merge "Add Python3.5 to setup.cfg tox.ini" 2016-07-14 08:28:37 +00:00
Jenkins
63a6789add Merge "Use FakeProject and FakeDomain classes in unit tests of networkv2" 2016-07-14 06:25:39 +00:00
Huanxuan Ao
e5a3c403e5 Make set/unset commands pass normally when nothing specified in identityv3
Change-Id: I554b41969f96b62a2c6d37024caa56b1441d5ed1
Partial-bug: #1588588
2016-07-14 14:12:30 +08:00
Jenkins
56a232c79f Merge "Change the wrong import order" 2016-07-14 05:13:09 +00:00
Jenkins
1620964cfe Merge "Remove useless dest of option in volume v1&v2" 2016-07-14 04:06:56 +00:00
Dean Troyer
067647b6a4 Temp work around for missing select_auth_plugin()
These were removed prematurely from osc-lib (by me) but the real fix in
https://review.openstack.org/329189 is having racy functional test issues
that may be related to osc-lib, so let's clear this up while we fix that...

Change-Id: I8f67466967751fdf6fd24ae1b16ccee2aec52323
2016-07-13 10:33:19 -05:00
Huanxuan Ao
e310682235 Add "--project" option to "volume type create" command
Add "--project" and "--project-domain" options to
"volume type create" command. We can use these options
to add the type access to a given project when we
create the volume type.

Change-Id: I483a6b61dae137682c3d1f7527531b40e508ba92
Closes-Bug: #1602169
2016-07-12 19:23:47 +08:00
Huanxuan Ao
f79f671338 Change the wrong import order
Change-Id: Ia48f0aae0250a5d29c0f6fa46386465e118f760f
2016-07-12 16:51:21 +08:00
Huanxuan Ao
536c0d9dea Modify some help and error messages in ec2creds identityv2
Usually we use "(s)" to show about multi deletion in
help message. In addition, I think "EC2 credentials"
is better than "EC2 keys" in the error message.

Change-Id: I6a6461291542701d87a55d9ea0ea1fda6db04601
2016-07-12 15:55:33 +08:00
Marc Abramowitz
8bbf30498e image list: Add Checksum column
The checksum could potentially be useful for spotting duplicated images or
checking if images with the same name are identical or different.

Closes-Bug: #1602073

Change-Id: Ia0c41970c846d550de14297e18bc738e847e5a3b
2016-07-11 20:31:13 -07:00
zheng yin
e40e1f6990 Add Python3.5 to setup.cfg tox.ini
Now that there is a passing gate job, we can claim support for Python 3.5
in the classifier. This patch also adds the convenience py35 venv.

Change-Id: If93af96739741584c87913ba140d0c6cee2aa10d
2016-07-12 07:20:08 +08:00
Jenkins
5a21eb2555 Merge "Add "--incremental" option to "backup create" command in volume v2" 2016-07-11 20:15:15 +00:00
Jenkins
357d7e75f3 Merge "Unskip tests caused by bug 1599333" 2016-07-11 19:40:14 +00:00
Paul Bourke
34812655a5 Add "--incremental" option to "backup create" command in volume v2
Cinder V2 API supports creating volume backup with "--incremental"
option. However, OSC doesn't support this argument. So this patch adds
the "--incremental" option to allow users to create incremental style
backups.

Change-Id: Iefac5f1a6c9ef006ad9c22d4250ae6df50504781
Closes-Bug: 1600196
2016-07-11 13:29:59 -04:00
Rajasi Kulkarni
8405db900f Pass security group id to novaclient
In RemoveServerSecurityGroup we currently pass the entire security
group object, which results in TypeError in novaclient.
Added unit test case to test command 'openstack server remove
security group -h <server> <group>'

Change-Id: I6d486403a83804c3a30d6f89d2cf7f64f09797c6
Closes-Bug: 1590883
2016-07-11 22:34:35 +05:30
Jenkins
5636d99a2b Merge "Make the doc build reproducible" 2016-07-11 16:12:54 +00:00
Jenkins
eae0dc10b9 Merge "Add missing "Volume version 2 only" message in backup.rst" 2016-07-11 16:01:41 +00:00
Thomas Goirand
393ecedc3b Make the doc build reproducible
This fixes Debian bug:
https://bugs.debian.org/826676

Change-Id: I638488448a4d6e644ab0e6deaebd65c92fa7904a
2016-07-11 14:55:12 +02:00
sunyajing
25bdf6811c Modify compute agent set command
Migrate ``compute agent set`` arguments: version, url, md5hash
to be optional.

BackwardsIncompatibleImpact

Change-Id: I092b7ed24274bafa548f0537c4586504be3a2825
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
2016-07-11 18:07:34 +08:00
Huanxuan Ao
6825263609 Use FakeProject and FakeDomain classes in unit tests of networkv2
FakeProject and FakeDomain classes have been completed
in identityv2_0 and v3, Now we can use these classes
instead of old test data in networkv2.

Change-Id: I2f698e54ff35e24ffbdcaba29da6f96eb263cc0a
Partially-Implements: blueprint use-fake-project
2016-07-11 15:07:03 +08:00
Jenkins
00a15351eb Merge "Add notes, modify notes in fakes docstring" 2016-07-11 03:44:27 +00:00
Huanxuan Ao
59c9d508ef Add missing "Volume version 2 only" message in backup.rst
Former patchs add some volume v2 only options for backup but
miss "Volume version 2 only" message. This patch adds them.

Change-Id: Id50db25617776b6ee0d0ad6b4b82bd443b940343
2016-07-11 11:19:40 +08:00
Huanxuan Ao
cd189860e5 Remove useless dest of option in volume v1&v2
some "dest" argument is useless because they are
the same as the option name. So remove them.

Change-Id: Idd37e8816cf8b0833c94a5e741fdfe56602551f9
2016-07-11 10:10:59 +08:00
Jenkins
ffa2b56713 Merge "Updated from global requirements" 2016-07-10 05:00:45 +00:00
OpenStack Proposal Bot
226766ae74 Updated from global requirements
Change-Id: I4be6137a0d6717702e495d391cd9cb404fcf26ce
2016-07-09 19:27:08 +00:00
ji-xuepeng
17f177bb71 remove unused LOG
This is to remove unused LOG to keep code clean.

Change-Id: Ic544157b19cefb4120381f3314334c60a9020baf
2016-07-09 23:23:38 +08:00
OpenStack Proposal Bot
746e1937c9 Updated from global requirements
Change-Id: Ie3f88ed6c0db05795ad6f46eb7596bb4f9ffcc13
2016-07-09 03:17:22 +00:00
zheng yin
94f654b010 Remove FakeService.get_services
FakeService.get_services is useless in other test files, so remove it

Change-Id: If90b8742be97697f285750a05896b574c45f3504
2016-07-09 05:37:55 +08:00
zheng yin
527b2030fb Add notes, modify notes in fakes docstring
Some code has no notes, then add them
Some code notes are not perfect, then improve them
Some code notes are incorrect, then modify them

Change-Id: I43f9a8663ae138bdd494bc234c1fac00c2dd6c95
2016-07-08 18:36:11 +08:00
dongwenshuai
2a5ab35793 Add network-topolopy support
Add a new api about network-topolopy in openstackclient
It is the intention for OSC to collect data from existing
REST APIs

Change-Id: I23709ee906555d773c3efeb094aef50587732a1b
Related-Bug: #1586584
Implements: bp network-topology-support
2016-07-08 00:28:32 -04:00
Steve Martinelli
9f09d8c5d4 Unskip tests caused by bug 1599333
There is now a second .get() call in osc_lib.utils.find_resources.
These tests were failing because they only mocked a single access
call to .get(). Ensure there are two calls to .get(), with the
first one raising an exception.

Change-Id: Idd2ad4a27a6db5bee633cc37a1042dbb0a57aa71
Closes-Bug: #1599333
2016-07-07 22:54:23 -04:00
Jenkins
ffb232a90e Merge "Correct reraising of exception" 2016-07-07 20:56:18 +00:00
Jenkins
2adeac2bc2 Merge "osc-lib: api.auth" 2016-07-07 19:49:06 +00:00
Jenkins
bca1851911 Merge "modify notes in the FakeHypervisorStats docstring" 2016-07-07 17:35:55 +00:00
Ryan Selden
cde07464b5 Added a note on how to test changes
It's confusing for new contributors to test the client.
Added a quick note to the README explaining how to do so.

Change-Id: I2a185f04bbec7ab01fdd2ab436a5f413f33819e7
2016-07-07 16:11:54 +00:00
qinchunhua
6f36385cb8 Correct reraising of exception
When an exception was caught and rethrown,
it should call 'raise' without any arguments
because it shows the place where an exception
occured initially instead of place where the exception re-raised.

Change-Id: I5fb6dea5da7fb6e1e2b339a713c7d37f8c99e407
2016-07-07 15:05:58 +00:00
zheng yin
cc9efea9e0 modify notes in the FakeHypervisorStats docstring
The arugments should be: count and current_workload

Change-Id: I445d1d72d1f1b86a626bb4c9512cdb8311b2ebc9
2016-07-07 14:10:32 +00:00
zhengsenyan
1e895f3286 fix one spelling mistake and two help messages
I checked all the 70 rst files in doc/source/command-objects and
found that:
 -one spelling mistake as:rescure should be rescue(server.rst)
 -two help messages:xpvnc should be xvpvnc(console-url.rst and
  console.py)

Change-Id: I6f46c79983eaf5650bd3aa0ab448c19f5c6527a9
2016-07-07 14:19:04 +08:00
Jenkins
272d193401 Merge "Deduplicate get_opts methods" 2016-07-06 15:31:42 +00:00
Jenkins
e0b63e64c1 Merge "Add "--property" option to "snapshot create" command in volumev2" 2016-07-06 15:31:39 +00:00
Jenkins
f1a27a73d6 Merge "Add '--force' option to 'backup delete' command in volumev2" 2016-07-06 14:59:53 +00:00
Marc Abramowitz
b74be57300 "server list": "Image Name", "Image ID" columns
The `Image Name` column is shown by default (i.e.: without passing `--long`). E.g.:

```
$ openstack server list
WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils
+--------------------------------------+-----------------+---------+----------------------+----------------------+
| ID                                   | Name            | Status  | Networks             | Image Name           |
+--------------------------------------+-----------------+---------+----------------------+----------------------+
| abe67035-b14f-4541-b436-e0e778ec4227 | n9anonw302mgm1  | ACTIVE  | mnky3-3000=10.3.0.55 | Koala.2016-07-01-175 |
| 8f6a2d12-2bc3-4d89-ba94-8916ce9cdf92 | n9anonw301mgm1  | ACTIVE  | mnky3-3000=10.3.0.37 | Koala.2016-07-01-175 |
| b316d6d1-67cf-4f75-94a4-4c9a2b03f6a4 | n9dobby301mgm0  | ACTIVE  | mnky3-3000=10.3.0.36 | Koala.2016-05-04-130 |
+--------------------------------------+-----------------+---------+----------------------+----------------------+
```

The `Image ID` column is only available with `--long`. E.g.:

```
$ openstack server list --long -c Name -c "Image Name" -c "Image ID"
WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils
+-----------------+----------------------+--------------------------------------+
| Name            | Image Name           | Image ID                             |
+-----------------+----------------------+--------------------------------------+
| n9anonw302mgm1  | Koala.2016-07-01-175 | f587c6fc-1df3-42cd-ac86-8cd2c995a8d9 |
| n9anonw301mgm1  | Koala.2016-07-01-175 | f587c6fc-1df3-42cd-ac86-8cd2c995a8d9 |
| n9dobby301mgm0  | Koala.2016-05-04-130 | 37ff47a6-3e51-4986-bfa5-62afbfad5dfc |
+-----------------+----------------------+--------------------------------------+
```

Closes-Bug: #1599304

Change-Id: I477995b840eb9520b285948926ebbfe1777dd86c
2016-07-06 07:11:17 -07:00
Jenkins
7f8999bf54 Merge "Transfer "ip fixed add/remove" to "server add/remove fixed ip"" 2016-07-06 13:59:32 +00:00
Jenkins
2b8213df88 Merge "Transfer "ip floating add/remove" to "server add/remove floating ip"" 2016-07-06 13:59:06 +00:00
Jenkins
8d5a0fd86e Merge "Transfer "ip floating pool list" to "floating ip pool list"" 2016-07-06 13:50:32 +00:00
Jenkins
472d4532e6 Merge "Add command to unset information from ports" 2016-07-06 13:08:04 +00:00
Huanxuan Ao
f5aef9ac36 Add '--force' option to 'backup delete' command in volumev2
Add '--force' option to 'backup delete' command in
volumev2 (v2 only) to allow delete in state other
than error or available.

Change-Id: I661ea0d465db227e374cbacdde0206fa1a6dd3d5
Closes-Bug: #1597188
2016-07-06 20:51:01 +08:00
Huanxuan Ao
3222ffc157 Add "--property" option to "snapshot create" command in volumev2
Add "--property" option to "snapshot create" command
in volumev2 (v2 only) to support adding properties to
a new snapshot.

Change-Id: Ie0e90c9ccc2ac89b3b7b0ac89751fd864aada9a4
Closes-Bug: #1597192
2016-07-06 20:46:31 +08:00
jqjiang.1@gmail.com
1b05a6dff9 fix some spelling mistakes in doc/
I check all the files under doc/ directory and find three
spelling mistakes
 - exeuction should be execution
 - Fefora should be Fedora
 - opentackclient should be openstackclient

Change-Id: If9e5d07b6558871bb3f8d55b52bf8f1d9db0897e
2016-07-06 16:09:21 +08:00
Jenkins
4ce7dd53e8 Merge "Refactor unit tests for project and domain with fake classes in identityv3" 2016-07-06 04:08:03 +00:00
Steve Martinelli
72a82b2794 skip failing tests due to bug 1599333 is fixed
latest osc-lib breaks some of the tests, skip them for now
so we can continue to merge patches that are already approved.

Change-Id: I433190e9f763bea1df3135612b281d925745f884
Related-Bug: 1599333
2016-07-05 20:24:31 -04:00
Kyrylo Romanenko
259b4a1462 Deduplicate get_opts methods
One get_opts method can work instead of
get_list_opts and get_show_opts both.
Remove mutable default value.

Change-Id: I9c5683d416f0f3ed4989abab6f152b0341e30a4f
2016-07-05 15:39:03 +00:00
Richard Theis
578065b2c8 Add python-neutronclient to OSC plugins
Neutron is transitioning its CLI to OSC. Some CLIs will reside
within python-openstackclient while others will be OSC plugins
within python-neutronclient.

Depends-On: I9a20bc7a3d8aa7b631fb0fd534fc5705c23326ce
Change-Id: I2d8d369739d1df1597201368dd2158e07c8d2baf
Related-Bug: #1521291
2016-07-05 09:37:05 -05:00
Jenkins
44d4188149 Merge "fix a few spelling mistakes" 2016-07-04 17:19:59 +00:00
Jenkins
73a0ad7cf3 Merge "Remove useless dest of option in "snapshot create" command" 2016-07-04 16:13:45 +00:00
gecong1973
6115dfe9f8 fix a few spelling mistakes
- overwriten should be overwritten
 - retrun should be return

Change-Id: I1567402f4d5c7253e6a54d8753e3f201af7e6a54
2016-07-04 15:15:23 +00:00
Huanxuan Ao
8aa00894ef Remove useless dest of option in "snapshot create" command
The option is '--force' and the default argument is
'force', so the 'dest=force' is useless and unnecessary.
This patch remove it.

Change-Id: If8fd5270e4e36b5361127f4a91bdf347f29341c2
2016-07-04 16:46:28 +08:00
Huanxuan Ao
43a07e133d Add missing '(name only)' message for keypair in computev2
In 'keypair show' command. One help message had '(name only)'
but the doc had not. And another had not '(name only)' but the
doc had. This patch Fixs them and keeps the consistent between
doc and help message.

Change-Id: Ic88219ae25a6f545a1db39e6b585e1857ae9e2e0
2016-07-04 14:45:40 +08:00
Huanxuan Ao
441e4e963a Refactor unit tests for project and domain with fake classes in identityv3
Add FakeProject and FakeDomain classes and update unit tests for
project and domain.

Change-Id: Ifeed5dcba03155daa3b7b46b34d49c333ab19135
Partially-Implements: blueprint refactor-identity-unit-test
2016-07-04 14:27:37 +08:00
Tang Chen
179ebe6d64 Transfer "ip fixed add/remove" to "server add/remove fixed ip"
This patch does the following things to transfer
"ip fixed add/remove" to "server add/remove fixed ip":
* Add new command "server add/remove fixed ip", and unit
  tests and doc.
* Deprecate "ip fixed add/remove" command.

compute/v2/fixedip.py is not removed because the arguments'
positions are different between the new and old commands.
* ip fixed add <network> <server>
  server add fixed ip <server> <network>
* ip fixed remove <ip-address> <server>
  server remove fixed ip <server> <ip-address>

Change-Id: Ica07ccf92a76c21fd5608ecaff86ff7c4d96f5a0
Implements: blueprint rework-ip-commands
Partial-bug: 1555990
Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
2016-07-04 10:41:30 +08:00
Tang Chen
d1f9ea3f75 Transfer "ip floating add/remove" to "server add/remove
floating ip"

This patch does the following things to transfer
"ip floating add/remove" to "server add/remove floating ip":
* Add new command "server add/remove floating ip", and unit
  tests and doc.
* Deprecate "ip floating add/remove" command.

compute/v2/floatingip.py is not removed because the arguments'
positions are different between the new and old commands.
* ip floating add <ip-address> <server>
  server add floating ip <server> <ip-address>
* ip floating remove <ip-address> <server>
  server remove floating ip <server> <ip-address>

Change-Id: Ic0dd22ca6fb7b7bc3e820fd5a14d7c551e7ab963
Implements: blueprint rework-ip-commands
Partial-bug: 1555990
Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
2016-07-04 10:40:59 +08:00
Tang Chen
50bd56db25 Transfer "ip floating pool list" to "floating ip pool list"
This patch does the following things to transfer
"ip floating pool list" to "floating ip pool list":

* Add a new command "floating ip pool list" to deprecate
  "ip floating pool list". The source code is in network/v2
  dir.
* Add doc for "floating ip pool list".
* Add floating ip pool unit tests.

Change-Id: Id410f4e4a96cf589a6e8def209574da71395b55f
Implements: blueprint rework-ip-commands
Partial-bug: 1555990
Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
2016-07-04 10:40:00 +08:00
Jenkins
605efe6711 Merge "Add command to unset information from Subnet-pools" 2016-07-01 15:20:18 +00:00
OpenStack Proposal Bot
8a3b5d2b50 Updated from global requirements
Change-Id: I0954807ccd7be3256627eb330a66c9fb539d639f
2016-07-01 04:24:41 +00:00
Jenkins
9c8307ea31 Merge "Add "--snapshot" option to "backup create" command in volumev2" 2016-07-01 04:08:45 +00:00
reedip
230d38fb4c Add command to unset information from ports
This patch introduces the ``port unset`` command to
clear the fixed-ip and binding:profile information
from the ports.
Implements: blueprint network-property-unset

Change-Id: I9dba309234105af477e7618a8a437b7fa3b13cd7
2016-07-01 08:40:07 +05:30
Huanxuan Ao
6364df4cbd Add "--snapshot" option to "backup create" command in volumev2
Add "--snapshot" option to "backup create" command to support
backing up a snapshot.

Change-Id: Ibecbf1902599875f422d372d529835f73211d3ec
Closes-Bug: #1597184
2016-07-01 10:06:10 +08:00
Steve Martinelli
46b14afc3f update plugin documentation
- add watcher, gnocchi and aodh
- organize sphinx docs based on alphabetical order
  of the library

Change-Id: Ibdd500da0e488ce3256320d53b3354ee7c66468a
2016-06-30 12:57:42 -04:00
Dean Troyer
d324530532 osc-lib: api.auth
Move auth plugin checking to osc-lib.

Change-Id: I673d9c2d6e8bbf724c3000459a729e831d747814
2016-06-30 08:57:59 -05:00
Jenkins
fc804a58bf Merge "Fix doc issue for "compute agent list" command" 2016-06-30 13:48:42 +00:00
Jenkins
ba6951222a Merge "Add "--property" option to "flavor create" command" 2016-06-30 10:36:55 +00:00
reedip
063c722a11 Add command to unset information from Subnet-pools
This patch introduces the ``subnet pool unset`` command to
clear the pool prefix information from the subnet-pools.

Change-Id: I84b7259d6e26e695343d41cea6d807396faaf69a
Implements: blueprint network-property-unset
2016-06-30 08:14:58 +00:00
Huanxuan Ao
3ddb973292 Fix doc issue for "compute agent list" command
"--hypervisor" is a optional argument but in the doc it
was wrong format, this patch modify it.

Change-Id: I527feff73eca5834b2fee4efb2462562581210ed
2016-06-30 12:05:30 +08:00
Jenkins
4b61efe3f9 Merge "Add "--device-owner" option to "port list"" 2016-06-29 17:28:39 +00:00
Richard Theis
92d0fbeafd Add port security option to network commands
Add the "--enable-port-security" and "--disable-port-security" options
to the "network create" and "network set" commands. This supports setting
the default port security for ports created on a network.

Change-Id: I1deb505bd77cef2e4bc3c2dbbb0c450665136f47
Implements: blueprint neutron-client
2016-06-29 10:13:18 -05:00
Jenkins
4b38753a92 Merge "Add command to unset information from Subnets" 2016-06-29 12:58:05 +00:00
Huanxuan Ao
dbed97a24d Add "--property" option to "flavor create" command
Add "--property" option to "flavor create" command to support
adding properties to a new falvor.

Change-Id: I4f06b364375d5a81584fe41122d48e9568fa712a
Closes-Bug: #1596798
2016-06-29 19:16:35 +08:00
reedip
45b026d7c8 Add command to unset information from Subnets
This patch introduces the ``subnet unset`` command to
clear the host-routes, allocation-pools and dns-nameservers
from subnets.
Implements: blueprint network-property-unset

Change-Id: I31324a2423f6d2315eed27445dfdcfe863e0b550
2016-06-29 03:22:25 +00:00
Jenkins
6920c9e839 Merge "Add command to unset information from Routers" 2016-06-28 22:29:31 +00:00
Jenkins
9422f8bdea Merge "Add "--force" option to "volume qos delete" command" 2016-06-28 18:26:03 +00:00
Jenkins
bc4acba15e Merge "Add Tox prerequisites and installation" 2016-06-28 12:57:51 +00:00
Jenkins
30bcaebd00 Merge "Make set/unset command in volume pass normally when nothing specified" 2016-06-28 08:38:51 +00:00
Jenkins
161d37b42a Merge "Add "--force" option to "backup create" command in volumev2" 2016-06-28 08:35:31 +00:00
Jenkins
21ad61ddd9 Merge "Support bulk deletion for delete commands in computev2" 2016-06-28 08:24:36 +00:00
Jenkins
1ce547103a Merge "Change "ID only" to "name or ID" for backup commands" 2016-06-28 08:24:03 +00:00
Huanxuan Ao
4e46c04f92 Add "--force" option to "volume qos delete" command
Add ``--force`` option to ``volume qos delete`` command in volume
v1 and v2 to allow users to delete in-use QoS specification(s).

Change-Id: I46036e5f55ced8b8a1be54c521f2a5c242b89160
Closes-Bug: #1596821
2016-06-28 08:12:40 +00:00
Jenkins
6eef299899 Merge "Fix typo in openstackclient/network/v2" 2016-06-28 07:39:37 +00:00
Jenkins
9e47688e5e Merge "Update Fakes.py and unit tests for commands in identity V2.0" 2016-06-27 22:34:58 +00:00
Jenkins
e38a6e3740 Merge "Modify few words and change output format for command "ip floating list"" 2016-06-27 21:56:09 +00:00
Jenkins
9ef5ffe428 Merge "Modify some unusual help messages in computev2" 2016-06-27 20:49:15 +00:00
Huanxuan Ao
af7ab03693 Support bulk deletion for delete commands in computev2
Support bulk deletion and error handling for "keypair delete"
and "service delete" commands in computev2.
Up to now, all the delete commands in computev2 support bulk
deletion.

Change-Id: I6d5c960e9716188e56615514d0921618a15a88ec
Partially-Implements: blueprint multi-argument-compute
Partial-Bug: #1592906
2016-06-27 20:39:23 +00:00
sunyajing
a9da91285f Update Fakes.py and unit tests for commands in identity V2.0
Update remaining commands:role, service, user, token.

Change-Id: I06eed60dd2f312bad6076c78b53cd07bcd4cd55c
Partially-Implements: blueprint refactor-identity-unit-test
2016-06-27 20:24:19 +00:00
zhang.xiuhua
1dce52ace8 Modify few words and change output format for command "ip floating list"
According to OpenStack Documentation, preferred word choice:
Link: http://docs.openstack.org/contributor-guide/writing-style/word-choice.html
Change from 'etc.' to 'and so on'

Change-Id: Id8a5cc99a8bba8ac7531636248edaca8f98da917
2016-06-27 19:44:28 +00:00
Steve Martinelli
044a46ed5f skip image tag tests
the command ``image set tag <tag> <image>`` is now failing
skip the test so our gate isn't broken.

Change-Id: I05e415b212e76aef62c1b0b966863573eff338e9
Partial-Bug: #1596573
2016-06-27 11:26:18 -04:00
Huanxuan Ao
1d85a3f089 Change "ID only" to "name or ID" for backup commands
Tested "find_resulce()" can find a backup by name or ID.
But some help messages and doc were "ID only", this patch
modify them.

Change-Id: I22dcc3a0b40f2bafabb6d26498158e2468037312
2016-06-27 20:00:50 +08:00
reedip
ed64788cf1 Add command to unset information from Routers
This patch introduces the ``router unset`` command to
clear the routing information from the routers.
Implements: blueprint network-property-unset

Change-Id: Iac8d32ca42fb28878805b4b58ab411b67fa6555b
2016-06-27 10:41:13 +00:00
Huanxuan Ao
fc719f998c Add "--force" option to "backup create" command in volumev2
Cinder V2 API supports creating volume backup with "--force"
option. However, OSC doesn't support this argument. So this
patch add the "--force" option to allow users to back up a
in-use volume.

Change-Id: I326f8d6172b2830da4cf1317348af50142cc5490
Closes-Bug: #1596443
2016-06-27 16:59:51 +08:00
sunyajing
0106447cff Make set/unset command in volume pass normally when nothing specified
Change-Id: Iac2d1b4ba9fa6358dc9317054af970eae8d49e84
2016-06-27 16:09:16 +08:00
Huanxuan Ao
c7b137e421 Modify some unusual help messages in computev2
Some command help messages are unusual, for example:
common help message for a list command:
"list objects"
unusual help message:
"list obejcets command"
I think we should keep help message consistent, so I modify
the unusual help messages in computev2.

Change-Id: Ic5f11eba1a4397949e85d91cc067519752e89bff
2016-06-27 15:27:34 +08:00
ting wang
6c7a30ab38 Implement rbac list and show command
1. implement "openstack network rbac list"
2. implement "openstack network rbac show"
3. also add FakeRBACPolicy to test "network rbac xxx" command
The unit test class similar to FakeRouter, which is able to
fake one or more rbac policies. It will be used by the rbac
CRUD patches.

Change-Id: I6c97bc8819698546895fd530464a2cbb347bf77d
Co-Authored-By: Huanxuan Ao <huanxuan.ao@easystack.cn>
Partially-Implements: blueprint neutron-client-rbac
Depends-On: I88f409a24947b67146c0f93ec8480834cef56d2f
2016-06-27 10:44:41 +08:00
Huanxuan Ao
5951026bf2 Add unit tests for "host list" and "host show" commands
Missing unit tests for "host list" and "host show" commands
in computev2, this patch add them.

Change-Id: Ib157920fa2267ec96d206cdf46213563a105501b
2016-06-27 09:51:29 +08:00
Jenkins
21ac9230e8 Merge "Support multi-delete for commands in identity V2" 2016-06-24 21:24:49 +00:00
Jenkins
aa066346cc Merge "Fix several flake8 code style issues in compute tests." 2016-06-24 17:17:40 +00:00
Jenkins
6dbec64dd7 Merge "Make code more compact for get_list_opts function" 2016-06-24 13:50:48 +00:00
Jenkins
08480739c7 Merge "Remove code forgotten in cb28fb55884a9be7cd70c37343181116cf000a42" 2016-06-24 13:18:31 +00:00
Jenkins
0c74857971 Merge "Fix the problem of router delete" 2016-06-24 12:24:18 +00:00
Kyrylo Romanenko
f2b73c2737 Fix several flake8 code style issues in compute tests.
Fix issues:
H402 one line docstring needs punctuation,
W503 line break before binary operator.

Change-Id: Ie93430898403f137e7b647a97a28b0d7a4ebb463
2016-06-24 14:45:19 +03:00
Kyrylo Romanenko
ca9a6daba0 Make code more compact for get_list_opts function
Do it like in get_show_opts done.

Change-Id: If6b115c35a41997627660830fb8e5d299e8fb8e9
2016-06-24 14:28:28 +03:00
Vincent Legoll
60f3cfa6ef Remove code forgotten in cb28fb5588
Change-Id: I2abc75c94c1b6450f56bfcf2d8b1135e5caa3598
Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
2016-06-24 12:18:40 +02:00
sunyajing
6df09fd377 Support multi-delete for commands in identity V2
Commands are "ec2 credentials delete", "service delete", "endpoint delete".
Also update their unit tests and functional tests.

Partial-Bug: #1592906
Change-Id: I1a0b7160b803a523646d09d030e6f112c81c4c24
2016-06-23 23:57:49 -04:00
SongmingYan
ee156b5fe3 Fix the problem of router delete
Change "Remove" to "Delete" when using it in route-interface-delete.

Change-Id: I9ebc38c787acbcb42d2f8efeee41f6cb943e4b9b
Related-bug: #1560446
2016-06-24 03:52:49 +00:00
OpenStack Proposal Bot
6828f5ce27 Updated from global requirements
Change-Id: I43d04f2cbb0543d55783252d8618ddafdda3a66c
2016-06-24 03:17:41 +00:00
Jenkins
5b144334bf Merge "Support JSON data for port binding profile" 2016-06-23 21:31:05 +00:00
Jenkins
8b70f31178 Merge "Add FakeObject classes to fakes.py, update unit tests in identity V2." 2016-06-23 20:59:27 +00:00
Jenkins
05e818ce50 Merge "Improve masking of secrets in configuration show" 2016-06-23 20:59:19 +00:00
Jenkins
a7aa9e8ca0 Merge "Improve server functional tests" 2016-06-23 20:56:07 +00:00
Jenkins
13e27c35cd Merge "use env vars to specify OS_IDENTITY_API_VERSION" 2016-06-23 20:56:00 +00:00
Jenkins
28f261eeca Merge "support multi-delete for volume-type" 2016-06-23 20:55:08 +00:00
Jenkins
b7909252a5 Merge "Use resource id when name given for identity show" 2016-06-23 17:14:02 +00:00
Jenkins
377daebaa4 Merge "Fix errors for "host set" command" 2016-06-23 15:27:37 +00:00
Jenkins
29dd2b12df Merge "Standardize logger usage of catalog in identity" 2016-06-23 15:27:06 +00:00
Richard Theis
d08cf31dc8 Improve server functional tests
Patch set [1] fixed timing issues related to the server functional
tests. As part of the review, additional enhancements were
suggested. This patch set provides those enhancements. In particular,
the functional tests will now check for the cirros256 flavor and
the cirros-*-uec image.

[1] https://review.openstack.org/#/c/313870/

Change-Id: I7fe18e26b3d09db92bbe669ffafcd16618cae383
2016-06-23 08:30:22 -05:00
Jenkins
45f355b66c Merge "Remove OSCGenericPassword plugin" 2016-06-23 13:18:49 +00:00
sunyajing
e8483c9022 Standardize logger usage of catalog in identity
Change-Id: I5307f949b3a350e41840a4a5c191ceacf1b3b291
Partially-Implements: blueprint log-usage
2016-06-23 08:22:51 +00:00
Jenkins
51fcd7c30c Merge "Refactor unit test of "compute service list" command" 2016-06-23 06:20:34 +00:00
David Rosales
337d013c94 Use resource id when name given for identity show
Currently a user is allowed to specify either a resource ID or name
when running openstack identity comands. In some cases, when a name
is specified instead of an ID, the command will return as not able
to find the resource when it in fact does exist.

The changes here are to check the client against the token on such
requests and to extract the ID of the resource specified if enough
information exists between the two. We then use the ID associated
with the resource to complete the user requests.

Change-Id: I40713b0ded42063b786dc21247e854224b9d2fe2
Closes-Bug: #1561599
2016-06-22 21:55:46 -07:00
Cao Xuan Hoang
5534e29342 Fix typo in openstackclient/network/v2
This patch adds the missing "." to some docstring/text.

Trivial fix

Change-Id: Iffb470dcce7200ddc9e439c465adc652a8322708
2016-06-23 09:37:36 +07:00
Dean Troyer
ccbb2dd1e8 Remove OSCGenericPassword plugin
The need for this has passed plus with 3.0 we can take the breakage hit,
if any.

Change-Id: Ic019842f00033d2cd67b75f036e7e817e4b7c075
2016-06-22 13:54:32 -05:00
Jenkins
fd03f5250a Merge "Fix token/endpoint auth plugin" 2016-06-22 15:51:02 +00:00
Jenkins
775b1acccd Merge "Make set/unset commands in compute/image/common return normally when nothing specified" 2016-06-22 14:37:44 +00:00
Huanxuan Ao
70f8ae7534 Refactor unit test of "compute service list" command
The unit test of "compute service list" only checked the
"Disabled Reason" columns and its data. It is not enough.
This patch change the test to check all datas in the list.

Also, this patch modify the "Id" to "ID" in this command.

Change-Id: I988fd6365f2652185dd96d9417f294eba9c31cd9
2016-06-22 19:02:39 +08:00
sunyajing
000c253d76 Add FakeObject classes to fakes.py, update unit tests in identity V2.
Clean up fakes.py , use FakeCatalog, FakeProject, FakeService,
FakeEndpoint, FakeRole classes instead, also update their unit tests.

Change-Id: I510d175ec194165b0595ebd430e8cc596d363587
Partially-Implements: blueprint refactor-identity-unit-test
2016-06-22 17:02:25 +08:00
Jenkins
de909e4afc Merge "Support bulk deletion for "flavor/aggregate delete"" 2016-06-22 06:48:50 +00:00
Huanxuan Ao
7177014fcc Fix errors for "host set" command
"Host set" command cannot work. Because:
1.Host has no 'ID' attribute, so 'ID' attribute cannot be found
in "host set" command.
2.value "True" and "Flase" are invalid in updata() method of host.
3.Some update functionalities is not supported in host API now.

This patch solves the problems 1 and 2 in OSC. But the problem 3
is a API problem and can't be solved in OSC, only XenServer driver
support to set enable/disable and maintenance host, it is a normal
problem.
After this patch the output of "host set" command is:
The requested functionality is not supported. (HTTP 501)
(Request-ID: req-14031fce-8c90-48a0-8492-dc8e3dd349f3)
Just the same as the "host-update" command in novaclient.

Change-Id: Ibe94c4d3d492d3d63355de803810edb988e1b4e9
Closes-Bug: #1594689
2016-06-22 14:20:53 +08:00
Jenkins
3c1aae9cf4 Merge "Updated from global requirements" 2016-06-21 21:08:39 +00:00
Jenkins
94534e26cf Merge "Add "--project" option to the "flavor create" command." 2016-06-21 20:15:19 +00:00
Dean Troyer
cefe715031 Fix token/endpoint auth plugin
[This is not quite reduced from the original proposed fix as some
changes have merged that complicate the switch to OSC_Config and
v2 auth broke anyway.]

Fix the --os-token --os-url breakage in the switch to ksa.

Closes-bug: 1593664
Change-Id: I3ac23234fbf647fb145c7bd151d53c5c105462bf
2016-06-21 14:54:31 -05:00
OpenStack Proposal Bot
f6a188c3e1 Updated from global requirements
Change-Id: I99fc95e55e3a8030ed9175658895335beef059c3
2016-06-21 18:05:37 +00:00
Huanxuan Ao
014835930d Add "--project" option to the "flavor create" command.
Add ``--project`` and ``--project-domain`` options to the
``flavor create`` command. We can use these options to add
the flavor access to a givin project when we create the flavor.

Change-Id: Ic1907272c1d1ae526f9c9e86f32ba06c6da147c0
2016-06-21 16:28:18 +00:00
Jenkins
a60f16b938 Merge "Refactor setting defaults for some scope parameters" 2016-06-21 15:37:45 +00:00
Jenkins
b86915aa7e Merge "Refactor check_valid_auth_options function" 2016-06-21 14:13:36 +00:00
Jenkins
6c79919a5b Merge "Make the print info support i18n" 2016-06-21 13:56:35 +00:00
Huanxuan Ao
2d7a02f2ff Fix a missing i18n support in security_group_rule.py
Change-Id: Id1459366ccf894275a11c2af840568d4fd114e18
2016-06-21 17:06:59 +08:00
Tang Chen
9c62af8a42 Make set/unset commands in compute/image/common return normally when nothing specified
After this patch, all set/unset commands will return normally
when nothing specified.

Change-Id: Id94d0329faa1a674006a9aae901f834b41917317
Close-bug: #1588588
2016-06-21 15:15:18 +08:00
Alvaro Lopez Garcia
1de4c66009 Improve masking of secrets in configuration show
The command "configuration show" tries to redact some of the secrets
that are shown on the screen. However, this failed redacting options
that were marked as secrete by the auth plugins (if any) and it redacted
other options that were not redacted at all. For example, when using
the OpenID Connect plugins, it redacted the "access_token_endpoint" as
the word "token" appears there, but it failed to redact "client_secret"
even when this option is marked as secret in the corresponding plugin.

Change-Id: Idfad4fbbe5ddcff5e729e1dcd756d0379ad31dee
2016-06-21 06:56:23 +00:00
Alvaro Lopez Garcia
099a2c38b9 Refactor setting defaults for some scope parameters
The code is setting defaults for some scope parameters, cheking if the
name ends with some specific substring (namely ending in "password")
causing failures in some plugins that end with the same string, but do
not allow those parameters (like "user_domain_id" in "v3oidcpassword").

Closes-Bug: #1582774
Change-Id: Id7036db3b783b135353d035dc4c1df7c808d6474
2016-06-21 08:55:30 +02:00
Alvaro Lopez Garcia
78ae57112c Refactor check_valid_auth_options function
The functions check_valid_auth_options() function was relying on the name
for checking the set of required options, but this could cause errors
with external auth plugins. If somebody defines an auth plugin plugin
named "footoken" the check function would check for a "token" option,
even if the plugin has not defined that option. This change tries to
improve this situation, cheking for some options only if they have been
defined in the plugin.

Change-Id: I4255f2e7d4d23449c95be957ea7b6b60983f2608
2016-06-21 08:54:36 +02:00
liyifeng
a4dd1fc714 Make the print info support i18n
When OSC failed to set a image's property, it will print
the image name and status, which is an useful info to
users. So translate this massage, and record it in log.

Change-Id: Icdff4dab17dedcb40289700c4cd278e6e62eea25
2016-06-21 13:52:51 +08:00
Huanxuan Ao
640014fa91 Support bulk deletion for "flavor/aggregate delete"
Support bulk deletion and error handling for "aggregate delete"
and "flavor delete" commands.

Change-Id: I3f6105cbeeab1c9f8cd571c63ce0e7ac3d4252b3
Partially-Implements: blueprint multi-argument-compute
Partial-Bug: #1592906
2016-06-21 11:04:13 +08:00
Jenkins
7cda2b2a06 Merge "Error handling of "router delete" command" 2016-06-20 22:24:27 +00:00
Jenkins
8c850cadcf Merge "Add "--network-segment" option to "subnet create"" 2016-06-20 21:42:52 +00:00
Richard Theis
c7fb3b3655 Add "--device-owner" option to "port list"
Add "--device-owner" option to the "port list" command to enable
listing ports based on device owner.

Change-Id: I0a538ec41800b9f842e86dceb6ca4180ef239c95
Implements: blueprint neutron-client
2016-06-20 16:32:20 -05:00
Steve Martinelli
cb28fb5588 use env vars to specify OS_IDENTITY_API_VERSION
If the default identity API version were to change
in devstack, the v2.0 tests would fail today,
resulting in a broken OSC gate.

Change-Id: Id634ea7e0fab9f3772383b5512ccac19f5119ac0
2016-06-20 17:16:20 -04:00
Richard Theis
5cc62d90b0 Support JSON data for port binding profile
Update the "--binding-profile" option on the "port create" and
"port set" commands to support both <key>=<value> and JSON input
for the port custom binding profile data. The JSON input is
sometimes needed to maintain the value type (e.g. integer) for
more advanced data.

The port custom binding profile data is unique across neutron
so a custom argparse.Action class was created instead of
writting a generic class in osc-lib.

Change-Id: I82ac6d4f95afdc866f5282fc00d390f850f54d21
Implements: blueprint neutron-client
2016-06-20 15:42:56 -05:00
Steve Martinelli
4e62e1e2e1 support multi-delete for volume-type
Added the ability to delete multiple volume types at once. Note
there are no unit tests exist for v1 volume-types, so instead
a functional test was created.

Partial-Bug: #1592906
Change-Id: I99f3f22901ab35252b91a3072b14de7d19cb17ca
2016-06-20 16:42:36 -04:00
Jenkins
f5ae23ab86 Merge "Standardize logger usage" 2016-06-20 17:26:57 +00:00
Jenkins
a99b54ef75 Merge "Fix console url show command broken in microversion case" 2016-06-20 15:51:20 +00:00
Jenkins
8c1c2f46a9 Merge "Modify help msg and docs in identity" 2016-06-20 15:51:14 +00:00
Tang Chen
047cb68493 Standardize logger usage
Use file logger for all command specific logs.

This patch also fixes some usage that doesn't
follow rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html

After this patch, all self.log and self.app.log
will be standardized to LOG().

NOTE: In shell.py, we got the log in class OpenStackShell,
      which is also known as self.app.log in other classes.
      This logger is used to record non-command-specific logs.
      So we leave it as-is.

Change-Id: I114f73ee6c7e84593d71e724bc1ad00d343c1896
Implements: blueprint log-usage
2016-06-20 15:16:51 +00:00
Jenkins
a0c07ca450 Merge "Use osc_lib in server_image.py" 2016-06-20 15:11:29 +00:00
Jenkins
40004b5d80 Merge "Add doc for logger usage" 2016-06-20 12:55:41 +00:00
Tang Chen
d67c2e8383 Use osc_lib in server_image.py
server_image.py is a newly created file. So I think
we forgot to use osc_lib in it.

Change-Id: Ieda13438662ea55b03f549108aac63c18b9af913
2016-06-20 20:02:05 +08:00
Huanxuan Ao
8b6626e9b6 Error handling of "router delete" command
"Router delete" command supports multi deletion but no error
handling. This patch add the error handling follow the rule
in doc/source/command-error.rst

Change-Id: I3376d957b4dc28d8282599dc909ecc5ed2b5f46a
2016-06-20 18:05:20 +08:00
Jenkins
ba825a4d5c Merge "Do not prompt for scope options with default scoped tokens" 2016-06-17 21:35:42 +00:00
Jenkins
b83d0200d9 Merge "Updated from global requirements" 2016-06-17 17:58:02 +00:00
Jenkins
dea859430a Merge "Modify unit tests of compute agent delete" 2016-06-17 17:31:07 +00:00
Dolph Mathews
fe0c8e955b Do not prompt for scope options with default scoped tokens
This changes the scope validation to occur after a token has already
been created.

Previous flow:

1. Validate authentication options.
2. Validate authorization options if the command requires a scope.
3. Create a token (using authentication + authorization options)
4. Run command.

This means that scope was being checked, even if a default scope was
applied in step 3 by Keystone.

New flow:

1. Validate authentication options.
2. Create token (using authentication + authorization options)
3  Validate authorization options if the command requires a scope and
   the token is not scoped.
4. Run command.

Change-Id: Idae368a11249f425b14b891fc68b4176e2b3e981
Closes-Bug: 1592062
2016-06-17 12:37:15 -04:00
OpenStack Proposal Bot
cd8d49590b Updated from global requirements
Change-Id: I2d6aadd0509f5f311d7433ea457ecf5ad6e4e64e
2016-06-17 14:20:56 +00:00
sunyajing
6dbe911800 Modify help msg and docs in identity
Migrate 'change', 'update' to 'modify',
migrate 'user to delete' to 'user(s) to delete',
migrate '(name or ID)' to '(type, name or ID)'.

Change-Id: Ie425e178bb5ddf773e6e793fcd91c78e9c4a5053
2016-06-17 09:41:39 +00:00
Jenkins
1464c8a237 Merge "Make set/unset command in identity and image pass normally when nothing specified" 2016-06-17 06:24:35 +00:00
sunyajing
8a12a39ece Make set/unset command in identity and image pass normally when nothing specified
Also update its unit tests.

Change-Id: I82b90658b0d4247cdc9a650f14aceda640a32059
Partial-bug: #1588588
2016-06-17 04:20:28 +00:00
Steve Martinelli
2740291f49 move release note to correct directory
not sure how this one release note was slotted into it's own
directory, but let's move it with the others.

Change-Id: I20eb36b1778b6fc9b5e550390962ec11dae38db4
2016-06-16 14:01:01 -04:00
Jenkins
c33a213cf1 Merge "Support bulk deletion for delete commands in networkv2" 2016-06-16 16:30:23 +00:00
Jenkins
5d23a1208a Merge "Add "--password-prompt" to user.rst" 2016-06-16 14:18:55 +00:00
Jenkins
fbef7ce825 Merge "Set up 3.x release notes" 2016-06-16 14:13:51 +00:00
Rui Chen
8cceaddaac Fix console url show command broken in microversion case
The response data of nova get_xxx_console API is changed
from "console" to "remote_console" in microversion 2.6, and nova
server side API schema verify the spice vnc type to "spice-html5",
update OSC code to apply these change so that OSC can work in
different nova microversion cases.

Change-Id: I3bb4fe057e656209d00d2bb308ac3f7f837cb03f
Closes-Bug: #1590318
2016-06-16 21:13:47 +08:00
Jenkins
b9a318156c Merge "Move server image create command to its own resource file." 2016-06-16 13:05:18 +00:00
Jenkins
ed38aa6cbc Merge "Modify doc issues about property option of aggregate" 2016-06-16 12:57:38 +00:00
Jenkins
3236d6f66b Merge "Add functional test for "aggregate unset" command" 2016-06-16 12:57:29 +00:00
Huanxuan Ao
041ea4978b Support bulk deletion for delete commands in networkv2
This patch support bulk deletion for delete commands below:
1.subnet delete
2.subnet pool delete

Up to now, all the delete commands in networkv2 support bulk deletion.

Change-Id: I63f6d1d02bad1fcc26e72b7028b53958a68ce2dc
Partially-Implements: blueprint multi-argument-network
Partial-Bug: #1592906
2016-06-16 12:46:32 +00:00
Jenkins
b5e524ac84 Merge "Fix help msg of identity endpoint" 2016-06-16 12:43:32 +00:00
sunyajing
ce98ed1e64 Add "--password-prompt" to user.rst
Change-Id: I2e86114698887a6343c248783c343f269bf4988d
2016-06-16 18:04:59 +08:00
Huanxuan Ao
15821fadf3 Modify doc issues about property option of aggregate
The formal of multi properties in most docs likes this:
[--property <key=value> [...] ]
[--property <key> [...] ]
This patch modify the formal of multi properties in
aggregate.rst.

Change-Id: I557cd51696d2721c8955c4a79f1ab85de3a0b9ce
2016-06-16 17:07:01 +08:00
Huanxuan Ao
2d4a585841 Add functional test for "aggregate unset" command
There was not functional test for "aggregate unset"
command, this patch add the test.

Change-Id: Icc8f51e863231e915b2a8cca59baaedd54a96de5
2016-06-16 16:41:25 +08:00
Tang Chen
0ac6b4fa46 Add doc for logger usage
This patch adds a doc to record rules of usage of
loggers in OSC.

Change-Id: I27a09f9abb523393031560e2310bfdd1af0b8922
Implements: blueprint log-usage
2016-06-16 16:17:37 +08:00
sunyajing
9eb77ae1de Fix help msg of identity endpoint
<service> argument of `endpoint create` command doesn't mean
`new endpoint service`, but an existent service that the new endpoint attached to.

Change-Id: I846fdb501bdea14499f42288186f375a3b2b5951
2016-06-16 09:55:10 +08:00
Dean Troyer
e7ed403712 Finish osc-lib transition for command.py
https://review.openstack.org/#/c/328318/ was the transition of
openstackclient/common/command.py to osc-lib but it was incomplete;
https://review.openstack.org/#/c/329885/ started to fix it but
was also incomplete.  Third time is charm?

Change-Id: Ib6c0266155c2155ae59067ce7b15bebca1e375e8
2016-06-15 22:50:43 +00:00
Jenkins
114eeeb023 Merge "Fix volume functional tests" 2016-06-15 19:11:07 +00:00
Jenkins
e272473afc Merge "Setup deprecate msg for command.py" 2016-06-15 17:53:37 +00:00
Jenkins
d3cd322650 Merge "Support bulk deletion for commands that exist in both network and compute." 2016-06-15 16:54:10 +00:00
Jenkins
4cc539fcc5 Merge "Support compute service force down/up" 2016-06-15 16:36:30 +00:00
Richard Theis
09b783ad3e Fix volume functional tests
The volume v2 functional tests occasionally fail with
"unrecognized arguments: --private". This appears to occur when
volume v1 and volume v2 functional tests are run at the same time
when one or more of the tests do not set OS_VOLUME_API_VERSION
appropriately.

This patch also fixes a timing issue seen when running the
tests locally due to a missing wait and moves the snapshot
test to volume v2 since it was written for v2.

Change-Id: I9c9863fe1aef81b0564920f36452c6f27211d5ba
Closes-Bug: #1589793
2016-06-15 11:36:27 -05:00
Tang Chen
ec630e033a Setup deprecate msg for command.py
This could be a miss when we use osc_lib first in OSC.
command.py has been moved to osc_lib, and should reuse
it and print a deprecate msg if the old file is used.

Change-Id: Ibc35659f6f78b8f5e3c6026db2644a876ef7c549
2016-06-15 15:24:35 +00:00
Huanxuan Ao
ca5e8e6c85 Add default IP version and fix help messages for "ip availability list"
There was not a default IP version in "ip availability list"
command, if we used this command without "--ip-version" option,
the output was different from the outputs with the option
"--ip-version 4" and "--ip-version 6" and it is not right.
This patch add default IP version (default is 4) in ``ip
availability list`` command and make this command work properly
without ``--ip-version`` option. And also fix the help message.

Change-Id: Idc08ab6eaf05946eb2ab59bfb3d4497a383d987d
Closes-Bug: #1592761
2016-06-15 20:33:09 +08:00
Huanxuan Ao
8e2f49fbf2 Support bulk deletion for commands that exist in both network and compute.
Some delete commands in networkv2 are exist in both network
and compute, They can use NetworkAndComputeDeleteclass to
supprot bulk deletion and error handling and the codes are
similar, so I change them all in this patch. The changed
commands including:
1.floating ip delete
2.security group delete
3.security group rule delete
Also, I update unit tests and docs for these commands in this patch.

Change-Id: I6c94c3d10ba579ddd9b14d17673c821e3481fd8a
Partially-Implements: blueprint multi-argument-network
2016-06-15 17:23:39 +08:00
Jenkins
0ec711c640 Merge "Add geneve provider network type" 2016-06-15 00:41:50 +00:00
Jenkins
968d8bb662 Merge "Standardize logger usage in volume" 2016-06-15 00:09:15 +00:00
Jenkins
950abf264f Merge "Fix foundation copyrights" 2016-06-14 21:50:26 +00:00
Jenkins
e6f5479dcc Merge "Remove blank line in release notes" 2016-06-14 21:50:19 +00:00
Tang Chen
0e9862be7a Standardize logger usage in volume
self.app.log is the logger in class OpenStackShell,
which should be used to record logs that have nothing
to do with any specific command.

So, use the file logger instead.

This patch also fixes some usage that doesn't follow
rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html
1. add variables to logger as an argument
2. do not wrap variables with str()

Change-Id: I248861a38a4de0412a080046aa7a6f6473c3e082
Implements: blueprint log-usage
2016-06-14 16:37:57 -05:00
Jenkins
de01b30245 Merge "Add release note for network endpoint type bugfix." 2016-06-14 20:55:47 +00:00
Jenkins
df235a00d1 Merge "Fix errors in `set/unset flavor` unit tests" 2016-06-14 19:18:21 +00:00
SamYaple
4a2924ded7 Remove blank line in release notes
The blank line was causing yamllint to fail in other projects. [1]

Related-Id: I400131bf84a4cf48a83952efa7dfac8e4954b587

[1] http://logs.openstack.org/64/329564/1/check/gate-heat-templates-pep8/e538974/console.html#_2016-06-14_17_39_02_316

Change-Id: Icfd902b6c9408ccb9a710d10d52d65efe753b77f
2016-06-14 18:48:07 +00:00
Stuart McLaren
b875f63a6f Add release note for network endpoint type bugfix.
Related-bug: 1592368
Change-Id: I9bd8c3490e72b32ba48dc9d884c101d5e50867f9
2016-06-14 17:42:42 +00:00
Huanxuan Ao
f25a3519c5 Fix missing i18n supports in api/ and shell.py
Change-Id: I28d79d7f44b27d2b600dedad2a3601180650ad83
Partial-bug: #1574965
2016-06-14 11:03:56 -05:00
Dean Troyer
6357202971 Fix foundation copyrights
The OpenStack LLC copyrights date from before OpenStack was transferred
to the foundation.  These appear to be getting copy-pasted to new files
so at least should reflect the correct entity.

Change-Id: I02953d752cb24ead6aa4ad8bfe257a48317c9f13
2016-06-14 09:49:28 -05:00
Jenkins
769baf329e Merge "Ensure endpoint type is used for network commands" 2016-06-14 14:20:47 +00:00
Jenkins
b1bd427fcc Merge "osc-lib: timing" 2016-06-14 12:37:01 +00:00
Stuart McLaren
7c603e4a67 Ensure endpoint type is used for network commands
Currently OS_ENDPOINT_TYPE and --os-interface are being ignored for
network commands. This means the public URL is always used.

Make sure that these are picked up correctly so we hit the correct
endpoint (internal/admin/etc.) for commands such as:

 $ openstack --os-interface internal network list

Change-Id: Iac05204e3056e386d84d3644b5da1a2bb322bb0a
Closes-bug: 1592368
2016-06-14 11:20:16 +00:00
Rui Chen
eccd943acc Support compute service force down/up
Aims to evacuate servers from compute host as soon as possible,
operators might set the compute service force down manually.
Novaclient support the behavior, this patch support it in OSC.

Change-Id: I22ff1c5d670c449771fdcb3f4f39cd82f428531a
Closes-Bug: #1589348
2016-06-14 17:40:09 +08:00
Tang Chen
c4b590748a Fix errors in `set/unset flavor` unit tests
1. We should assert flavor.set_keys() is called correctly
   or not called in ``set flavor`` unit tests.

2. Commit c7e6973ff5 from me
   removed test_flavor_unset_no_project which used to test
   if --project was specified as '', and assert CommandError
   was raised, which is incorrect. So I removed it. But after
   looking into the code, I think we should not remove it,
   but specify nothing after --project, and assert
   ParserException was raised. So in this patch, we fix it
   as so.

   ('--project', '') --> ('--project')
   assert CommandError --> assert ParserException

Change-Id: Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0
2016-06-14 15:32:33 +08:00
Jenkins
5b36898b2b Merge "Fix image delete multiple arguments error" 2016-06-14 07:26:58 +00:00
Jenkins
2c92b60f45 Merge "osc-lib: command" 2016-06-14 06:45:17 +00:00
Jenkins
287fe3610a Merge "osc-lib: parseractions" 2016-06-14 04:22:03 +00:00
Jenkins
5c402c1da2 Merge "osc-lib: logs" 2016-06-14 04:21:56 +00:00
Jenkins
908a36f716 Merge "Fix i18n problems for common files in identity" 2016-06-14 04:21:25 +00:00
Jenkins
e5dd054be8 Merge "Fix errors in flavor unit tests" 2016-06-14 04:21:18 +00:00
Tang Chen
304f565439 Fix i18n problems for common files in identity
Some missing parts in identity.

Change-Id: I8777b845613d7d7df36ac3c198da552e11aaad1b
Partial-bug: #1574965
2016-06-14 09:50:23 +08:00
Dean Troyer
a55eb915a0 osc-lib: timing
Change-Id: I3fe27d98efa5090e084c676f7f8e6dad0157ed21
2016-06-13 11:08:21 -05:00
Dean Troyer
9e2b8e6730 osc-lib: command
Leave command.py and test_command.py as a sanity check during the
deprecation period.

Change-Id: I24e1b755cbfbcbcaeb5273ec0c9706b82384fc85
2016-06-13 11:00:22 -05:00
Dean Troyer
be192676bd osc-lib: parseractions
Leave parseractions.py and test_parseractions.py as a sanity check during the
deprecation period.

Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83
2016-06-13 10:55:44 -05:00
Dean Troyer
59dffb9c62 osc-lib: logs
Change-Id: I2a4d40cd72cc22e97a600751ae29c2309ebed28b
2016-06-13 10:55:44 -05:00
Dean Troyer
e5e29a8fef osc-lib: utils
Use osc-lib directly for utils.

Leave openstackclient.common.utils for deprecation period.

Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
2016-06-13 10:50:44 -05:00
Dean Troyer
d20c863ebc osc-lib: exceptions
Use osc-lib directly for exceptions.

Leave openstackclient.common.exceptions for deprecation period.

Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828
2016-06-13 10:50:01 -05:00
Jenkins
17627c5595 Merge "Moving authentication from keystoneclient to keystoneauth" 2016-06-13 15:39:36 +00:00
Richard Theis
6a6b192dde Add "--network-segment" option to "subnet create"
Add "--network-segment" option to the "subnet create" command.
This is a beta command option and subject to change. Use global
option "--os-beta-command" to enable this option.

This patch set also provides a devref update for beta command
options.

Change-Id: I4d0fbe079b2a873307364c41c22ce9ba88e632e6
Partially-Implements: blueprint routed-networks
2016-06-13 10:01:48 -05:00
Jenkins
a84a90592b Merge "Use osc-lib and set up deprecation warnings" 2016-06-13 13:19:36 +00:00
Tang Chen
c7e6973ff5 Fix errors in flavor unit tests
This patch fixes the problems below:
1. flavor.unset_keys() is not checked in flavor unit tests.
   So check them in the tests.
2. test_flavor_unset_no_project makes no sense. It is OK to
   specify ``--project ''`` without raising any exception.
   It can pass because in the test, we set nither project
   nor property. So remove this test.

Change-Id: I04e537349936343b6d8c85b06bc6d0ba6bd41d6f
2016-06-13 19:19:19 +08:00
sunyajing
8c7e34d65c Fix image delete multiple arguments error
Fix image delete command, support processing multiple arguments
delete error.
Fix doc/source/command-errors.rst, make the msg format correct.

Change-Id: Icbe347fe077bc148bf71ea8f7399b0e934b7cdf9
Partially-Implements: blueprint multi-argument-image
2016-06-13 16:15:01 +08:00
Tang Chen
0695d1495e Trivial: Fix coding style in examples in doc
Now, we use i18n strings for help and log messages,
and standardize the usage of logger. So fix those
in the example in doc.

Change-Id: Ibbc051b12133699811dd35a7e77a10de50ed8e44
2016-06-13 09:40:19 +08:00
Richard Theis
56a081fa23 Add geneve provider network type
Add the "geneve" choice to the "os network create" command's
"--provider-network-type" option.

Change-Id: I7573232ec3594ec4acbfae43a8456b8c3fcd1a83
Implements: blueprint neutron-client
2016-06-10 14:47:50 -05:00
Dean Troyer
6c269efda8 Use osc-lib and set up deprecation warnings
The initial use of osc-lib is behind the compatibility/deprecation
modules that we will leave in place for a time for plugins to catch
up.

* openstackclient.common.exceptions
* openstackclient.common.utils

Module-level warnings are emitted directly on stderr since logging
has not been configured yet.

Change-Id: I79e57ce9523a20366bccaf9b949ab5906792ea0d
2016-06-10 08:35:54 -05:00
OpenStack Proposal Bot
df71ae814e Updated from global requirements
Change-Id: I729673d3c5e7f32ddf6f912d8ac5b7ca3b1cb394
2016-06-09 16:23:05 +00:00
Navid Pustchi
6ae0d2e8a5 Moving authentication from keystoneclient to keystoneauth
Currently OpenStackClient uses keystoneclient for authentication.
This change will update OpenStackClient to use keystoneauth for
authentication.

All dependant test have been updated.

Updating how auth_ref is set in the tests to use KSA fixtures had
some racy side-effects.  The user_role_list tests failed when they
picked up an auth_ref that was a fixture.  This exposed a weakness
in ListUserRole that needed to be fixed at the same time re
handling of unscoped tokens and options.

Change-Id: I4ddb2dbbb3bf2ab37494468eaf65cef9213a6e00
Closes-Bug: 1533369
2016-06-09 18:00:40 +02:00
Jenkins
ada6abb30e Merge "Make set/unset commands in network return normally when nothing specified" 2016-06-09 14:58:17 +00:00
Jenkins
087d4a3d8a Merge "Fix network" 2016-06-09 12:14:58 +00:00
OpenStack Proposal Bot
db0849e711 Updated from global requirements
Change-Id: I944891584a7479c8d8bdf545af8a6af0460f42d5
2016-06-08 22:04:01 +00:00
Jenkins
85263eaa11 Merge "Remove duplicate file logger formatter setting" 2016-06-08 15:13:57 +00:00
sunyajing
aefd2195b1 Fix network
modify ``columns, data`` to ``(columns, data)`` in network,
to keep code consistence.

Change-Id: I0522c499d1651b4ea948bebccbdfd520934e8e6a
2016-06-08 17:08:36 +08:00
Rui Chen
a4670054c6 Remove duplicate file logger formatter setting
Change-Id: Ia7851a4266fa61658c48cc894163c6afb7252750
2016-06-08 16:28:59 +08:00
Tang Chen
e3270cdfd8 Make set/unset commands in network return normally when nothing specified
set/unset commands should ends up normally instead of raising
an exception when nothing is specified to modify. The main
reason is: When nothing is specified, the command sets/unsets
nothing, which is a normal behavior, and ends up normally.
No API call fails. No error happens.

This patch also adds a releasenote for both network, and volume
commands that fix patch has been merged.

Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef
Partial-bug: #1588588
2016-06-08 14:31:17 +08:00
Huanxuan Ao
72d3ebd94c Clean up fakes.py in volumev2
All of volumev2 fake classes are completed.
Now the unit tests of volumev2 are using fake
classes so that the old codes are useless and
can be removed.

Change-Id: I502a8a0b0404975744d3b208af3e95c8692e6c47
2016-06-08 13:36:16 +08:00
Jenkins
84506a6b71 Merge "Fix compute service set command" 2016-06-08 05:03:47 +00:00
Jenkins
c272476b7b Merge "Error handling for KeyValueAction class." 2016-06-08 04:30:58 +00:00
Jenkins
4c331bd5f9 Merge "Update unit test test_extension with fake class" 2016-06-08 04:12:48 +00:00
sunyajing
565499577f Fix compute service set command
add ``Binary name`` to help msg of compute service set command.

Change-Id: I5ed3824ec5bede250ce41f187835e8901b5e11fd
2016-06-08 03:07:16 +00:00
sunyajing
3c883e9755 Modify unit tests of compute agent delete
add no-input test to ``compute agent delete`` unit tests.

Change-Id: Iee22b75c9a9431e57cb634dc28a5efa9b43b7369
2016-06-08 11:03:44 +08:00
Huanxuan Ao
cf12239773 Error handling for KeyValueAction class.
The set --property command requires that the input match
the "key=value" type, but if the type don't match, the return
value will be None, and the command still can be implemented
successfully, this may confuse the users. I think we should
raise exception if the argument type don't match "key=value".
So I make some changes in KeyValueAction class in this patch.

Change-Id: I14e64922faa7e083bc8b5e7e1cac41ef8117c224
Closes-Bug: #1589935
2016-06-08 10:15:19 +08:00
Dean Troyer
b8730114b9 Set up 3.x release notes
Give the 2.x series its own release notes page, put the 3.x notes into
the 'current' series page.  This removes the OpenStack development cycle
name from the release notes.

We follow the intermediary release model, however the association with
the common cycle release is something that we do not need to reflect in
the doc structure.  We want users to use the current version even with
older clouds, not to think they need to use a 'Mitaka' OSC with a Mitaka
cloud.

Change-Id: Idbb6844824d50e5cd0fa64871b5aa625d4d237af
2016-06-07 17:34:38 -05:00
Jenkins
817f5f3196 Merge "Fix i18n supports in commom" 2016-06-07 18:52:37 +00:00
Jenkins
7dc2e1dc08 Merge "Release note cleanups for 2.6.0" 2016-06-07 16:57:41 +00:00
Dean Troyer
d24c255e43 Release note cleanups for 2.6.0
Change-Id: I7c19cac77f1236c8241d18f2bdde83917e50fae9
2016-06-07 07:58:50 -05:00
Huanxuan Ao
b36d521ff6 Fix i18n supports in commom
I checked all the files in openstackclient/common
and fixed the missing i18n supprots.

Change-Id: Id7f76a24aae663f5832ef9bcf1bd5a6b7081af24
Partial-bug: #1574965
2016-06-07 19:56:00 +08:00
Jenkins
26d7657f1f Merge "Support error handling for "port delete" command" 2016-06-07 10:33:40 +00:00
zhang.xiuhua
a7cc5c8006 Add Tox prerequisites and installation
Change-Id: I48f4c571d1f1ae26ac930d8abad0cfbcb826ae46
2016-06-07 18:13:23 +08:00
Huanxuan Ao
0fd3a8c787 Update unit test test_extension with fake class
Add FakeExtension class in networkv2, computev2, volumev2,
identityv2_0 and update unit test test/common/test_extension.py

Change-Id: I94815de7801860edb7fa91a7d146455cab946652
2016-06-07 16:17:42 +08:00
Huanxuan Ao
eb421f6dab Support error handling for "port delete" command
"Port delete" command supported deleting multi ports
before but didn't support error handing, This patch
add the error handling following the rules in
doc/source/command-errors.rst.

Change-Id: I4ea69f2279763626d6a27cad1ca0ee99822d016d
Partially-Implements: blueprint multi-argument-network
2016-06-07 16:00:54 +08:00
Tang Chen
5293bb103e Fix i18n support problems in identity
Change-Id: I3b48d17850343051239b5b69e8b890dba32d3ac8
Partial-bug: #1574965
2016-06-07 09:37:02 +08:00
Jenkins
dd0fe3d94e Merge "Fix errors for "volume type unset" command" 2016-06-07 01:31:50 +00:00
Jenkins
3f7f1c6582 Merge "Add functional tests for IP availability" 2016-06-07 00:43:12 +00:00
Jenkins
1244d4d5fe Merge "Fix release note links to (now) external docs" 2016-06-06 22:49:03 +00:00
Jenkins
19c54b61c1 Merge "Refactor SetService --enable/disable option" 2016-06-06 21:56:55 +00:00
Jenkins
376e3379ee Merge "Make set/unset commands in volume return normally when nothing specified" 2016-06-06 21:48:12 +00:00
Manjeet Singh Bhatia
5d404ecd05 Add functional tests for IP availability
This patch adds functional tests for IP availability

Partially-Implements: blueprint neutron-ip-capacity
Change-Id: I1c1dc01801707fe8f0dc3c976e5d345d2b0db0ec
2016-06-06 17:43:57 +00:00
Dean Troyer
658dc23f26 Fix release note links to (now) external docs
Moving the old release notes into the Reno releasenots tree broke
the embedded :doc: roles.  Restore these using sphinx.ext.extlinks to
manage the URL to the OSC docs.

Add the following aliases:
* lpbug - generic Launchpad bug        :lpbug:`123456`
* oscbp - OSC blueprints               :oscbp:`Blue Print <bp-name>`
* oscdoc - OSC Docs                    :oscdoc:`Comamnd List <command-list>`

Change-Id: Iecfdd666d961c35f0ccb3b9f10df1d2620cb099f
2016-06-06 10:21:47 -05:00
Jenkins
8183e6daf7 Merge "Updated from global requirements" 2016-06-06 15:03:02 +00:00
Jenkins
50b27cc80d Merge "Add server set/unset unit test cases" 2016-06-06 13:36:51 +00:00
Jenkins
9504b7973e Merge "Add newline to strings in stdout/stderr.write()" 2016-06-06 13:06:47 +00:00
Huanxuan Ao
4bea5d37d9 Fix errors for "volume type unset" command
Normally, we can unset multi properties but the "volume type unset"
command could not, because the action "append" was missed. So I add
it and also fix the unit test and doc in this patch.

Change-Id: I20470f2b7bb2a8d7f292cea498826669c3418c77
2016-06-06 19:04:36 +08:00
Jenkins
275753bacc Merge "fix keypair help msg" 2016-06-06 08:45:13 +00:00
Jenkins
9661354979 Merge "Add network availability for osc" 2016-06-06 08:20:15 +00:00
sunyajing
5b317936cb fix keypair help msg
keypair delete and keypair show commands cannot work on keypair ID

Change-Id: I958fcd2ed184706b28d63cc9c73a8b566e86a16c
Closes-Bug:#1588701
2016-06-06 06:50:13 +00:00
Jenkins
36bbf9b365 Merge "modify server group" 2016-06-06 06:43:51 +00:00
Lu lei
54e81a9984 Add newline to strings in stdout/stderr.write()
Function stdout/stderr.write() can't break line automatically.

Change-Id: I903c2d1cc1a669adb6be5aa4eb783d3b9943e685
2016-06-06 13:54:55 +08:00
Jenkins
045622efd5 Merge "fix image unset" 2016-06-06 05:53:25 +00:00
sunyajing
6de7bf0abc modify server group
make column_headers equal to columns, to keep code consistence

Change-Id: Ia96b398ad822fc5fac3753e28709c370165bda8a
2016-06-06 11:47:59 +08:00
zheng yin
2c965b88f6 fix image unset
modify "target" to "tagret"

Change-Id: I80674b23804b26430aed13b5e6c6dc2b240771cd
2016-06-06 11:09:25 +08:00
Rui Chen
08e7801ff4 Add server set/unset unit test cases
Unit test cases don't cover compute "server set/unset" commands,
the patch add some test cases for them.

Change-Id: I440c32968bd41b948352a9764a37c9af3e68803d
2016-06-06 09:57:55 +08:00
OpenStack Proposal Bot
d4c86de0f1 Updated from global requirements
Change-Id: Ic65f591351d97d3965d86d846b5b82d95b0a3bd2
2016-06-05 16:27:02 +00:00
Jenkins
93db7f58ed Merge "Support multiple argument for compute agent delete command" 2016-06-05 04:36:26 +00:00
Jenkins
1c097b777c Merge "Add support for volume transfer request list" 2016-06-04 20:36:24 +00:00
Sheel Rana
2178cedef1 Add support for volume transfer request list
OSC does not support to list volume transfer from one user
to other user.
This patch will provide support for listning volume transfer
requests.

Closes-Bug:#1554886

Implements: bp cinder-command-support

Change-Id: Ie659bc39cb1d1e931cca7a40b2f126a067ee484c
2016-06-04 18:26:59 +00:00
Tang Chen
ac1d86c343 Refactor SetService --enable/disable option
This patch changes the following:

1. --enable/disable option should follow the rules
   in the doc below:
   http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

2. "--disable-resion" is specified but not "--disable",
   an exception is raised instead of igoring
   "--disable-reason" option.

Change-Id: I92e9234111e661bfe7119a8e19389a87c874ab0c
2016-06-04 22:42:46 +08:00
Jenkins
81718beb8f Merge "Fix wrong test in flavor unit tests" 2016-06-04 14:31:49 +00:00
Jenkins
7fb10e74ba Merge "Check port name in set port tests" 2016-06-04 14:31:43 +00:00
Jenkins
b0ed4f6bd0 Merge "Imported Translations from Zanata" 2016-06-04 14:19:16 +00:00
Tang Chen
2672e37ee2 Make set/unset commands in volume return normally when nothing specified
set/unset commands should ends up normally instead of
logging an error when nothing is specified to modify.
The main reason is: When nothing is specified, the
command sets/unsets nothing, which is a normal behavior,
and ends up normally. No API call fails. No error happens.

Change-Id: Ib03a512650e5da90aa1ef38019772448383d0d33
Partial-bug: #1588588
2016-06-04 21:29:44 +08:00
Jenkins
55a7ba890d Merge "Fix --enable options on commands" 2016-06-04 13:05:30 +00:00
OpenStack Proposal Bot
4883c2b72a Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Icda8a1c87ded27c1ba061d5692e95a1477206b92
2016-06-04 06:18:46 +00:00
Jenkins
416792f079 Merge "Fix some missing i18n support problems in compute" 2016-06-03 19:24:42 +00:00
Jenkins
f07b883d60 Merge "Modify the style of translated messages" 2016-06-03 19:16:40 +00:00
Manjeet Singh Bhatia
eab6cdebdc Add network availability for osc
This patch implements openstack client for network ip availability.

Implements: blueprint neutron-ip-capacity

Depends-On: I3b40d8edea87c068c4e8133e436511765064d5f8
Change-Id: Iffaa2e20ff495fbd205d3397e027e8141d04385e
2016-06-03 16:47:56 +00:00
Dean Troyer
eef2054109 Move server image create command to its own resource file.
Change-Id: If37e82072bd7a32b81bfb1a8bb048f018dd5b04f
2016-06-03 09:19:57 -05:00
Jackie Yuan
01ad9ab368 Modify the style of translated messages
Translated messages should not be combined with orther literal
strings to create partially translated message.
Although this change is very small, but this is the only one in
the directory VOLUME.

Change-Id: If798aacde9d5d5e8ac2edd49e75099ec255c858e
2016-06-03 17:04:42 +08:00
zhouqi
6d1dd68076 Check port name in set port tests
Change-Id: I1bf11245b107f82fedee70dacc37c4c6dc5210ea
2016-06-03 16:12:22 +08:00
Tang Chen
c95c73f8e2 Fix wrong test in flavor unit tests
In test_flavor_set_no_project(), we aimed to test a
situation like this: User specifies "--project" option,
but didn't specifies the project name or ID.

But in the source code, it becomes "--project ''".

The test could past because if project and property
are both None, the command will raise an exception.

Change-Id: I39567306debb901e8bad420fa2492f1b207efddc
2016-06-03 15:53:49 +08:00
Huanxuan Ao
95d5d9f761 Fix some missing i18n support problems in compute
Found and Fix some missing i18n support problems in compute/client.py

Change-Id: I54374f4eddafd9f80b6ccdaf8f8c30e098df105e
Partial-bug: #1574965
2016-06-03 12:15:22 +08:00
OpenStack Proposal Bot
3078540161 Updated from global requirements
Change-Id: I17243642ec7d2c4d27ba42f722f848dead2f820a
2016-06-03 03:44:52 +00:00
sunyajing
909bab1e07 Support multiple argument for compute agent delete command
Change-Id: I3b19e4914d475b86d7e8aa8d76e62a2ac811272f
Partially-Implements: blueprint multi-argument-compute
2016-06-03 02:14:36 +00:00
Dean Troyer
41f5521ee9 Update v2 endpoint show help
https://review.openstack.org/#/c/319821/ updated v2 endpoint show
and the doc, but not the v3 help.

Change-Id: Ifaa90f6266eabafb9de544199759f4ee8bcc1c83
2016-06-02 14:32:16 -05:00
Jenkins
9f65a9954c Merge "Add support for removing flavor-access" 2016-06-02 18:14:48 +00:00
Richard Theis
6f2c1734e3 Fix --enable options on commands
The --enable option on commands is ignored when the arguments are parsed.
This is related to the --enable-beta-commands option. Renaming the option
to --os-beta-command fixes the problem.

There's no need to handle backwards compatibility for the option name
change because there hasn't been an OSC release yet with beta commands.

Change-Id: I0327ba8a2058858a83e9a42e231470ed733cc834
Closes-Bug: #1588384
2016-06-02 10:07:34 -05:00
Jenkins
b349156059 Merge "Trivial: Remove duplicated line in man page" 2016-06-02 06:23:59 +00:00
Jenkins
2ded8551be Merge "Updated from global requirements" 2016-06-02 06:18:50 +00:00
Jenkins
6088d31ca9 Merge "Add FakeQos class and update unit test for qos_specs in VolumeV2" 2016-06-02 05:34:17 +00:00
Huanxuan Ao
22c60f3ac7 Add support for removing flavor-access
Add "--project" and "--project-domain" options in
"flavor unset" command to remove flavor access.

Change-Id: Ia5c5a80d9890d5af066b75b4e202647c18c7d915
Partial-Bug: #1575461
2016-06-02 12:40:43 +08:00
Tang Chen
55466d8158 Trivial: Remove duplicated line in man page
Change-Id: I3f72308e639ddcdfb0289e50f9bafd097461c896
2016-06-02 12:19:08 +08:00
OpenStack Proposal Bot
6ab1eab414 Updated from global requirements
Change-Id: I5e7045eae42c9cc6e1005134b8c589e5d1eca08d
2016-06-02 04:09:24 +00:00
Jenkins
f1f9ae850e Merge "Modify lowercase to uppercase" 2016-06-02 03:48:39 +00:00
zhang.xiuhua
478dd64822 Modify lowercase to uppercase
Change-Id: Ia59355d824ba61da824612ea0e03243b1bec4a57
2016-06-02 09:57:21 +08:00
Jenkins
a182205a94 Merge "Trivial: Fix i18n support in network/common.py" 2016-06-01 13:38:19 +00:00
OpenStack Proposal Bot
e7be9731ce Updated from global requirements
Change-Id: I04e0189527b1affabf351002d66fe857ec73a694
2016-05-31 18:56:32 +00:00
Jenkins
48ffd8cf4b Merge "include old release notes in reno" 2016-05-31 17:15:45 +00:00
Jenkins
75f6a8e8bd Merge "Fix unit test for volume commands in volumev2" 2016-05-31 13:59:02 +00:00
Jenkins
21924f55b9 Merge "Fix output and error log in server.py" 2016-05-31 13:42:14 +00:00
Jenkins
6a204b000a Merge "Do not require an scope when setting a password" 2016-05-31 13:38:30 +00:00
Tang Chen
5a3a7867a8 Trivial: Fix i18n support in network/common.py
Some missing i18n problems in network.

Change-Id: I45a09a6ada1aad5a64256c0d0a0a2b6e250df670
2016-05-31 20:31:28 +08:00
Huanxuan Ao
677dfaa925 Fix unit test for volume commands in volumev2
There are some issues in test_volume.py in volumev2,
I make three changes in this patch:

1.modified some codes that not used FakeVolume class.
2.added a fake image by FakeImage class for this test.
3.added a fake snapshot by FakeSnapshot class for this test.

Change-Id: I02ba73d3aaee95624b0e2307b255e0e485b0c3a3
2016-05-31 17:36:02 +08:00
Rui Chen
550ebac714 include old release notes in reno
Currently OSC release notes are in the OpenStack releasenote
site. There is a collection of old non-reno release notes in
our docs folder. Move the non-reno release notes to the
reno directionary.

Change-Id: Ie51fd1e1115d606e5d2739014d3720eedc8dc225
2016-05-31 16:13:16 +08:00
Jenkins
ca58ab9d09 Merge "add unit test for compute agent command" 2016-05-31 07:11:04 +00:00
sunyajing
a207fdfda6 add unit test for compute agent command
Change-Id: I966d5a3a307fcd7f4efb1267aa2896efd53be50d
2016-05-31 12:50:23 +08:00
Huanxuan Ao
dce3962ffd Add FakeQos class and update unit test for qos_specs in VolumeV2
Change-Id: I108c8d343678f3d19d1ca1f93d998c46c7c32eff
2016-05-31 11:54:49 +08:00
Jenkins
8470618611 Merge "Updated from global requirements" 2016-05-30 20:25:22 +00:00
Jenkins
4e44f1206f Merge "Add support for setting flavor-access" 2016-05-30 20:00:11 +00:00
OpenStack Proposal Bot
dfea25d70c Updated from global requirements
Change-Id: I2a70d88480db366bffc8e69d318be89625e9177c
2016-05-30 17:50:11 +00:00
Huanxuan Ao
7def236718 Fix i18n support in cinder
I checked all the cinder files and found some small issues
of i18n support.So I fix them.

Change-Id: I2df06cb9db4643bd734105664d83299726f7b4e9
Partial-bug: #1574965
2016-05-30 17:00:35 +08:00
Huanxuan Ao
c46a5597be Add support for setting flavor-access
This patch adds "--project" option in "flavor set" command to support
for setting flavor access.

Change-Id: I75b473600080d8ab1dd6ad01561c4f989ed3c3bd
Partial-Bug: #1575461
2016-05-30 16:26:09 +08:00
Jenkins
37bc7bbf91 Merge "Add network segment command object" 2016-05-30 06:20:21 +00:00
Jenkins
d532e3b5f2 Merge "Add "image unset" command" 2016-05-30 04:39:34 +00:00
Jenkins
4822bf1f53 Merge "[compute] Add server backup function" 2016-05-30 04:28:07 +00:00
Jenkins
416550fd3d Merge "Support to set server state" 2016-05-30 03:48:37 +00:00
Jenkins
6e3f717b7c Merge "Support deleting multi address scopes in networkv2" 2016-05-30 03:29:38 +00:00
Jenkins
1dfc7d4b94 Merge "Fix functest "test_server_metadata()" in test_sever.py" 2016-05-30 03:29:14 +00:00
Rui Chen
1a7284f63a Support to set server state
When a server is unexpected state, OSC don't support reset
the server to active or error state, that's supported by
novaclient, and it's an important command for operators, the
patch implement this function.

Change-Id: I3e7800feb192832b0719ef9a353945beb6bfd509
Implements: blueprint server-reset-state
2016-05-28 18:55:50 +08:00
sunyajing
3e11661074 Add "image unset" command
This patch add a command that supports
unsetting image tags and properties

Change-Id: I6f2cf45a61ff89da6664f3a34ae49fdd85d8c986
Closes-Bug:#1582968
2016-05-28 16:38:22 +08:00
Jenkins
7247707d34 Merge "Fix help message for "server group delete" command" 2016-05-28 07:58:15 +00:00
Tang Chen
97162ecd22 Fix output and error log in server.py
This patch fixes 2 problems:

1. The '\n' should be in the end of a message,
   not the beginning.

i.e.:
   The original code was:
       sys.stdout.write(_('\nError deleting server'))
   It will make the output look like this:

   [root@tangchen /]# openstack server delete aaa bbb

   Error deleting server
   Error deleting server[root@tangchen /]#

   We change it to:
       sys.stdout.write(_('Error deleting server\n'))
   Then the output will become:

   [root@tangchen /]# openstack server delete aaa bbb
   Error deleting server
   Error deleting server
   [root@tangchen /]#

   which is much better.

2. Record the error in log for those who didn't.

Change-Id: I38b00c2321014757970183205f95f026e20a8090
2016-05-28 15:46:32 +08:00
Huanxuan Ao
537f5cbe8a Support deleting multi address scopes in networkv2
This patch adds support for deleting multi address scopes by
using "address scope delete" command.

Change-Id: Ic8d3ebc17db44ca5d42c336d2c4d5633f70d4e8b
Partially-Implements: blueprint multi-argument-network
2016-05-28 13:46:38 +08:00
Huanxuan Ao
366adf98c0 Fix functest "test_server_metadata()" in test_sever.py
There is only a functional test for "server set" command
in test_server_metadata(), we also need a functional test
for "server unset" command, so I add it in this patch.

Change-Id: I23c40ac1c5adcc2563d8aa9dcb5551df695e98e3
2016-05-28 13:32:13 +08:00
Huanxuan Ao
b2a0e633eb Fix help message for "server group delete" command
"Server group delete" command supported deleting multi server
groups, but the help message was "Delete an existing server
group", so I change it in this patch.

Change-Id: I05b1a7e3f29b84b9190e7cc05c01734e3daa7a6d
2016-05-28 13:21:39 +08:00
Richard Theis
6a55e05cbf Add network segment command object
Add network segment command object in support of routed networks.
This patch set includes documentation, unit tests and functional
tests (currently skipped until segments enabled in neutron by
default) for the following new commands:
  - "os network segment list"
  - "os network segment show"

These new commands are currently marked as beta commands.

Change-Id: I1a79b48dc6820fe2a39fcceb11c8cae3bda413a0
Partially-Implements: blueprint routed-networks
2016-05-27 12:58:25 -05:00
jichenjc
460846cef2 [compute] Add server backup function
Add server backup function

There is no return value for this command per following doc
http://developer.openstack.org/api-ref-compute-v2.1.html#createBackup,
also novaclient can't be updated now due to backward compatible issue
http://lists.openstack.org/pipermail/openstack-dev/2016-March/089376.html,
so we have to get the information ourselves.

The Image tests were not using warlock images, so that needed to be fixed
before we could completely test things like --wait.

Change-Id: I30159518c4d3fdec89f15963bda641a0b03962d1
2016-05-27 11:47:25 -05:00
Sheel Rana
62ec00ff3a i18n support for leftover exception messages in volume
Change-Id: I7be168fc587cb717075095cf6e12db19b0884dda
2016-05-27 17:05:10 +05:30
Alvaro Lopez Garcia
5f950788ff Do not require an scope when setting a password
Changing the password in Keystone V3 is an unscoped operation, but we
were requiring a scope.

Change-Id: If0653ac7b59320c2cd9d42a2c73dd29c3626d389
Closes-Bug: 1543222
2016-05-27 09:12:24 +02:00
Jenkins
9da02d14ea Merge "fix endpoint show help" 2016-05-26 22:10:23 +00:00
sunyajing
9e9e4e6f59 fix endpoint show help
endpoint show command can also work on service name or type or ID option

Change-Id: I43c8df4bc093d4130cf33fd2520736ce9077dc82
2016-05-26 19:40:26 +08:00
Jenkins
0ff7d6dc69 Merge "Release notes cleanup" 2016-05-25 19:28:26 +00:00
Jenkins
0d8dab6288 Merge "keystone: fix catalog output when region is unset" 2016-05-25 18:56:14 +00:00
Jenkins
646f702958 Merge "Refactor service unit tests" 2016-05-25 15:19:58 +00:00
Julien Danjou
e44bb009d3 keystone: fix catalog output when region is unset
If no region is set in Keystone, null is deserialized as None and the
region has None has value, which triggers a type error when building the
output string.

This patch fixes that.

Change-Id: I7637dc2595655cf452f38308f99fe66ac782e16d
2016-05-25 16:13:48 +02:00
Dean Troyer
99031cf1ed Release notes cleanup
Preparing for the next release

Change-Id: Ia185063d12d4bd235170b06c3da400e93cd934da
2016-05-25 08:47:49 -05:00
Tang Chen
8ce5d90136 Refactor service unit tests
Add a FakeService class, and refactor service unit tests
to use this class.

Change-Id: I650ad83386a58205ebe42274d2bf2f508436bfa6
2016-05-25 13:06:39 +08:00
Jenkins
f97fa2e6d2 Merge "Search by user defined ID for service providers" 2016-05-25 02:44:56 +00:00
Jenkins
e45b1c63f4 Merge "Devref: Command Beta" 2016-05-25 00:08:55 +00:00
Jenkins
2402dcfc35 Merge "Refactor TestVolumeShow with FakeVolume" 2016-05-24 23:30:56 +00:00
Jenkins
478b776937 Merge "Search by user defined ID for identity providers" 2016-05-24 23:30:22 +00:00
Steve Martinelli
58094bff80 Search by user defined ID for service providers
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
Closes-Bug: 1555830
2016-05-24 18:45:58 +00:00
Jenkins
086c3ab8fa Merge "Fix i18n support for help and error messages in compute" 2016-05-24 11:54:14 +00:00
OpenStack Proposal Bot
5ae8f1b7d5 Updated from global requirements
Change-Id: Ia94ac7e112817cfcea5e446e7966bb18e8dd9afc
2016-05-24 03:16:04 +00:00
Tang Chen
5398c96e2a Fix i18n support for help and error messages in compute
Change-Id: Id6eebcb48d1b7b49b6636524506294edbc44a83f
Partial-bug: #1574965
2016-05-24 11:03:49 +08:00
Jenkins
e3f169280c Merge "i18n support for help and error messages in cinder" 2016-05-24 01:47:22 +00:00
Jenkins
062d57ff62 Merge "Add some functional tests for commands in VolumeV2" 2016-05-23 20:32:30 +00:00
Jenkins
59f8e32674 Merge "Add network support for "quota set"" 2016-05-23 20:13:35 +00:00
Jenkins
26865846bf Merge "Add FakeType class and update volumetype test in VolumeV2" 2016-05-23 19:52:34 +00:00
Jenkins
02bca14a4b Merge "Add FakeSnapshot class and update snapshot test in VolumeV2" 2016-05-23 19:52:03 +00:00
Steve Martinelli
21530d026e Search by user defined ID for identity providers
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic58df22b3445d3293a8e1c76c5da79badebf6528
Closes-Bug: 1479837
2016-05-23 15:18:11 -04:00
Sheel Rana
53e05e7c2d i18n support for help and error messages in cinder
Change-Id: I98fbc959034fe0530966291643b381855801de20
2016-05-23 18:04:36 +00:00
Jenkins
17bc850440 Merge "Add functional tests for server group in ComputeV2" 2016-05-23 07:48:30 +00:00
Huanxuan Ao
5f69894753 Add FakeType class and update volumetype test in VolumeV2
This patch adds FakeType class and update unit tests for
volume type with FakeType class

Change-Id: I86ecc68dd1a1e919f3325cd9456974a0cfadbe61
2016-05-23 14:16:39 +08:00
Huanxuan Ao
4d44a3c13f Add some functional tests for commands in VolumeV2
VolumeV2 lacked functional tests for qos specs
and volume type commands, so I add them.
These tests are quite similar to those in v1,just
three difference:
1.Importing functional.common.test instead of
functional.tests.volume.v1.common
2.Adding test_volume_type_set_unset_project()
in test_volume_type.py.
3.Adding a test for "qos unset" command in
test_qos.py

Change-Id: Ic50e8c49ef01ac967c01ec41fb3f04cd51fea9e4
2016-05-23 12:19:49 +08:00
Jenkins
f44416b750 Merge "Fix image tests to use warlock resources" 2016-05-21 23:04:50 +00:00
OpenStack Proposal Bot
6c13212725 Updated from global requirements
Change-Id: I16dd97fa5cb3d7e008c9d3c357fe31f7c081c492
2016-05-21 15:52:23 +00:00
Huanxuan Ao
dc71d16529 Add FakeSnapshot class and update snapshot test in VolumeV2
Add FakeSnapshot class and update unit tests for snapshot
commands with the FakeSnapshot class.

Change-Id: If039a48b9d5f8430cc3d041b8c7ec30af8ff0e03
2016-05-21 17:34:04 +08:00
Huanxuan Ao
e10a5979bc Add functional tests for server group in ComputeV2
Change-Id: I43a6ce3a6d976f3d1bd68c0483c929977b660f0d
2016-05-21 16:06:17 +08:00
Dean Troyer
c3d4810850 Fix image tests to use warlock resources
We have been testing (incorrectly) Image v2 using our usual
FakeResource objects, when the v2 API actually uses warlock
schema modelled resources.

Bring this to the tests (TestImageSet was already doing this)

Change-Id: Ia6ed3a8e28a8961f770c241b49d47cce9ff328d3
2016-05-20 07:07:16 -05:00
Jenkins
a68576b34b Merge "Avoid TypeError on message object additions" 2016-05-20 06:37:03 +00:00
Madhu Mohan Nelemane
a4d4e81c88 Avoid TypeError on message object additions
Change-Id: I634c1e158e93eeb55ab17fef8a0715b6678dffec
Closes-Bug: #1575787
2016-05-19 18:07:53 -07:00
Jenkins
be081ebb44 Merge "Fix i18n support for help and log.warning in image" 2016-05-19 20:19:36 +00:00
Fang Zhen
b92cf77fb5 Add network support for "quota set"
The "quota set" command support compute and volume quotas previously.
This patch add support network.

Partially-implements: blueprint neutron-client-quota
Closes-bug: 1489441

Change-Id: I9d297f52bc30614b3493f09ed15f8f1d3f8ff952
2016-05-19 20:42:59 +08:00
Xiaoyang Zhang
6c8e0dc1df Fix i18n support for help and log.warning in image
Change-Id: I6e2764aaf4b8c0efa78872646a7b3482ba044dc8
2016-05-19 20:34:46 +08:00
Jenkins
35ea7a9baa Merge "remove #noqa from i18n imports" 2016-05-19 09:08:57 +00:00
Jenkins
795656184e Merge "Pep8 environment to run on delta code only" 2016-05-18 20:39:42 +00:00
Jenkins
7a0845ec11 Merge "Add support of setting snapshot state" 2016-05-18 16:49:07 +00:00
OpenStack Proposal Bot
78c20f6f38 Updated from global requirements
Change-Id: Ib27d5b23d33a72da7b9eed8f1861de70ae586c85
2016-05-18 02:40:12 +00:00
Jenkins
c655569628 Merge "Add ip version filter to subnet list" 2016-05-17 22:28:06 +00:00
Jenkins
dcc8256982 Merge "Add FakeBackup class and updata backup unittest in volumeV2" 2016-05-17 17:20:07 +00:00
ting.wang
0fa2e8df92 Refactor TestVolumeShow with FakeVolume
In the meantime, add some static methods in FakeVolume for ease of use
and add info() method with "property" decorator in FakeResource to allow
those static methods to get fake information.

Change-Id: I98ad520f32afd529fda77a4592f645130282537f
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-volume-unittest-framework
2016-05-17 20:14:18 +08:00
Jenkins
5dfedd6445 Merge "Enhance exception handling for "network delete" command" 2016-05-17 03:04:42 +00:00
Huanxuan Ao
4956c354b2 Add FakeBackup class and updata backup unittest in volumeV2
Change-Id: I39762bedaeaaf1894f48912ca1b7d59ab50f9f78
2016-05-17 09:58:05 +08:00
Jenkins
cb068d8c68 Merge "Fix i18n support for help and error msg in network" 2016-05-16 23:33:23 +00:00
Jenkins
948c76b0a4 Merge "Support X.latest format for OS_COMPUTE_API_VERSION" 2016-05-16 22:57:28 +00:00
Jenkins
3d12ae8e03 Merge "Add VLAN Transparent option to `osc network`" 2016-05-16 22:57:25 +00:00
Jenkins
f0e64eb55a Merge "Refactor TestRemoveProjectImage with FakeImage class" 2016-05-16 22:51:21 +00:00
Jenkins
11be59db8c Merge "Added --no-route to the router set command" 2016-05-16 22:51:15 +00:00
Jenkins
22e738c751 Merge "Refactor TestImageList with FakeImage class" 2016-05-16 22:46:09 +00:00
Jenkins
91fcca271e Merge "Refactor TestAddProjectToImage with FakeImage class" 2016-05-16 22:46:02 +00:00
Jenkins
c471a97aef Merge "Fix network router type display" 2016-05-16 22:39:53 +00:00
Manjeet Singh Bhatia
668bc028d1 Add ip version filter to subnet list
This patch will add argument ip-version to command
subnet list

Change-Id: If7458d4979e53aec7e2633c4f1779c3810f9a3f1
Closes-Bug: #1581179
2016-05-16 22:37:14 +00:00
venkatamahesh
093f0ff003 Added CONTRIBUTING.rst file
Change-Id: I7edb273d36ba3536d5538029377e7b7535cfd115
2016-05-16 17:42:48 +05:30
reedip
00c149a28f Add VLAN Transparent option to `osc network`
osc network set and network create now support
--transparent-vlan|--no-transparent-vlan options
to add/remove vlan transparency from the network.

Change-Id: I845eb8f541cd32a4c4b28f929a63b205e7e31756
Closes-Bug: 1545537
2016-05-16 08:32:07 +00:00
Tang Chen
40f51c32ac Fix i18n support for help and error msg in network
Change-Id: Iab0dc489226601ac4ff123bb758f84ff16989395
2016-05-16 16:15:46 +08:00
Jenkins
6ab9e56310 Merge "Additional network protocol support" 2016-05-16 07:29:25 +00:00
ting wang
69be96ae72 Refactor TestRemoveProjectImage with FakeImage class
Change-Id: Id40ea8a3cf59738fa254da0bca4ad6551565f5de
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-image-unittest-framework
2016-05-16 13:02:44 +08:00
Hideki Saito
bc93ebfe5c Added --no-route to the router set command
Deprecated --clear-routes

Closes-Bug #1565034

Change-Id: I4a8975edc026aecd2a362fd1929c984cfab8ade6
2016-05-16 12:02:00 +09:00
OpenStack Proposal Bot
7a252128f9 Updated from global requirements
Change-Id: I61b3e84cbca369a5581aff38d65bb51af96e8baa
2016-05-15 02:57:05 +00:00
Adriano Fialho
2629fda947 Changed the nomenclature of credentials command
Removed the "s" of the "credentials command" in the documentation and renaming the file to credential.rst (instead of credentials)

Change-Id: If1df15b9a630a5452e05d14fb45e9ebb124583a7
2016-05-14 13:22:13 -03:00
Richard Theis
fd5fd924d1 Additional network protocol support
Add the following network protocol support to the
"os security group rule create" command:
  - Add "--icmp-type" and "--icmp-code" options
    for Network v2 only. These options can be used to set
    the ICMP type and code for ICMP IP protocols.
  - Change the "--proto" option to "--protocol". Using the
    "--proto" option is still supported, but is no longer
    documented and may be deprecated in a future release.
  - Add the following Network v2 IP protocols to the
    "--protocol" option: "ah", "dccp", "egp", "esp", "gre",
    "igmp", "ipv6-encap", "ipv6-frag", "ipv6-icmp",
    "ipv6-nonxt", "ipv6-opts", "ipv6-route", "ospf", "pgm",
    "rsvp", "sctp", "udplite", "vrrp" and integer
    representations [0-255].

The "os security group rule list" command now supports
displaying the ICMP type and code for security group rules
with the ICMP IP protocols.

Change-Id: Ic84bc92bc7aa5ac08f6ef91660eb6c125a200eb3
Closes-Bug: #1519512
Implements: blueprint neutron-client
2016-05-14 07:54:41 -05:00
ting.wang
2724eaac5d Refactor TestImageList with FakeImage class
Change-Id: Ia60f75f65bba4c25a0a87b570b081424f982efca
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-image-unittest-framework
2016-05-14 14:20:56 +08:00
xiexs
2b4c543cdd Refactor TestAddProjectToImage with FakeImage class
Change-Id: I6733601f12389eb744dbf0be64b7c556356b4730
Co-Authored-By: ting wang <bx_wang@outlook.com>
Implements: blueprint improve-image-unittest-framework
2016-05-14 14:17:01 +08:00
Steve Martinelli
ebcbd6ba71 remove #noqa from i18n imports
hacking checks no longer fail on `import _`

Change-Id: Idd60f0a0e71e5081691eacb39e5091ab08fcce6d
2016-05-13 13:14:02 -07:00
Jenkins
e1c53250bc Merge "Refactor TestVolumeList with FakeVolume" 2016-05-12 12:23:34 +00:00
Sheel Rana
095edbc367 Pep8 environment to run on delta code only
Currently tox -epep8 will run flake8 on whole code.
To make this fast, flake8 support is added for only
updated(delta) code.

Same can be run by "tox -efast8".

Change-Id: I9c55fed32ae3060c21ec278398e9e07fb4a0fe13
Implements: BP tox-pep8-diff-part-only
2016-05-12 00:55:10 +05:30
Jenkins
56680c83fe Merge "Add unit tests for "server show" command" 2016-05-11 13:26:55 +00:00
Jenkins
b60ff95edf Merge "Use find_resource() instead of get() in _prep_server_detail()" 2016-05-11 13:26:30 +00:00
ting.wang
553e154960 Refactor TestVolumeList with FakeVolume
Change-Id: Idbe7ee1d9688ea5937852cce1a746016bf98fa74
Co-Authored-By: xiexs <xiexs@cn.fujitsu.com>
Implements: blueprint improve-volume-unittest-framework
2016-05-11 17:25:48 +08:00
Jenkins
8632c93d24 Merge "Fix functional test for floatingip add/remove in ComputeV2" 2016-05-11 09:04:20 +00:00
Jenkins
fe02162bd3 Merge "Implement "address scope set" command" 2016-05-11 07:59:04 +00:00
Jenkins
94de0d3ebd Merge "Implement "address scope show" command" 2016-05-11 07:11:43 +00:00
Jenkins
0acb743611 Merge "Implement "address scope list" command" 2016-05-11 07:11:36 +00:00
Huanxuan Ao
0e0f314e2e Fix functional test for floatingip add/remove in ComputeV2
Updata test_server_attach_detach_floating_ip in test_server.py

Change-Id: I2963991dfafbb17431b44e2f37bb26fa4daac9aa
2016-05-11 14:58:52 +08:00
Jenkins
b503267616 Merge "Implement "address scope delete" command" 2016-05-11 06:53:56 +00:00
Jenkins
2aa99b4d50 Merge "Implement "address scope create" command" 2016-05-11 06:42:25 +00:00
Huanxuan Ao
cc78d48a28 Implement "address scope set" command
This patch add a command that supports
setting address scope properties.

Change-Id: I9c4b5068a8abb986a9dc18b167b48b924d16ff42
Closes-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
32da111c17 Implement "address scope show" command
This patch add a command that supports
showing address scope details

Change-Id: Ic0b41c1cab8c618904c7a6046d7493db5b74b430
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
aa5ff67e3f Implement "address scope list" command
This patch add a command that supports
listing address scopes

Change-Id: Id14757011560cacf28011ba51841a8e23b824f33
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
4cb5e0bc79 Implement "address scope delete" command
This patch add a command that supports
deleting a address scope

Change-Id: Ie028058c759b9511d105a530d7e89b841865e7d6
Partial-Bug: #1566269
2016-05-11 10:08:47 +08:00
Huanxuan Ao
98bee08e0f Implement "address scope create" command
This patch supports creating a new address scope,
with --ip-version,--project,--project-domain
and --share or --no-share options.

Change-Id: I37c73391a41ac239dd72d55dbc0adbebd7701f4a
Partial-Bug: #1566269
2016-05-11 10:08:35 +08:00
Tang Chen
06780dd880 Add unit tests for "server show" command
Change-Id: I6eb0c4e7d5d3e677764b253e3324720a784a110b
2016-05-11 09:33:51 +08:00
Jenkins
e0573d34eb Merge "Documentation updates" 2016-05-10 06:45:08 +00:00
OpenStack Proposal Bot
34decd83f1 Updated from global requirements
Change-Id: Id56a0313f630dd812218b9b7dfa812f185958a5d
2016-05-10 00:49:36 +00:00
Jenkins
c3acc4175b Merge "Ignore domain related config when using with keystone v2" 2016-05-09 15:52:24 +00:00
Jenkins
3f5fd2f9e1 Merge "Map server power state num to meanful string" 2016-05-09 13:36:56 +00:00
Tang Chen
d58280a279 Use find_resource() instead of get() in _prep_server_detail()
There is such a comment in test_server.py:

    # Call .get() to retrieve all of the server information
    # as findall(name=blah) and REST /details are not the same
    # and do not return flavor and image information.

This is an out of date comment. There is no function named
findall() in OSC now. So use find_resource() instead of get(),
and remove this comment.

Change-Id: I8d79afc5f341fb5caf771d905506b7f1c7a41ae8
2016-05-09 14:59:39 +08:00
Hieu LE
b8432408e6 Ignore domain related config when using with keystone v2
Currently, "/usr/bin/openstack --insecure token issue"
fails when OS_AUTH_URL and OS_IDENTITY_API_VERSION
indicate keystone v2 if OS_PROJECT_DOMAIN_NAME or
OS_USER_DOMAIN_NAME are set. This patchset ignore domain
related configs if using with keystone v2 and print warning
for each ignored config.

Change-Id: I8afbda787df7855c3f8e868b0f07cbf3b9cd97fd
Closes-bug: #1447704
2016-05-09 12:29:44 +07:00
Jenkins
4cd702c361 Merge "Fix functional test failures" 2016-05-08 19:27:50 +00:00
Richard Theis
c1dba6ab1b Fix functional test failures
There have been a lot of functional test failures for compute
and network.  I believe they are timing related in that the
test_server is sometimes booting a server with a flavor,
image and/or network created by another functional test. Such
resources are then deleted by the owning functional tests
causing various types of failures

Change-Id: Ib82edd487da46610374fb0eb5796cb98f2d3aa2c
2016-05-07 10:38:01 -05:00
Jenkins
fbd48be2ac Merge "Trivial: Remove unuseful comments for assertRaise() checking" 2016-05-07 11:35:05 +00:00
Tang Chen
809239ca1e Map server power state num to meanful string
In _prep_server_detail(), power_state is not formatted
by _format_servers_list_power_state(). So when executing
"server show" or "server create", the power state is
represented by number. This patch map the numbers to
meanful strings.

This patch also adds power_state attribute to FakeServer,
and improves unit tests for this attribute.

Change-Id: I2ec674327de4e5133b8712ba6bb53fa5ce55e3f4
2016-05-07 14:54:44 +08:00
OpenStack Proposal Bot
2244915b50 Updated from global requirements
Change-Id: Ic26729d1ce6e367d1b1cff38f6802cfed0d509ec
2016-05-06 22:22:39 +00:00
Jenkins
79039431f1 Merge "Add describe of overwrite options behavior into devref" 2016-05-06 18:49:57 +00:00
Jenkins
eb22fc7617 Merge "Spec to Implement IP Availability" 2016-05-06 18:49:30 +00:00
Jenkins
467ed54d6d Merge "Make "flavor show" command to show a private flavor properly" 2016-05-06 14:07:54 +00:00
Tang Chen
15c9576817 Trivial: Remove unuseful comments for assertRaise() checking
"Missing required args should bail here" is not understandable
and not necessary. The code is obvious enough. And some of the
comments are misused because of code copy. So remove them.

Change-Id: I031395f2c882386c7a708db5cf4eee75393dc639
2016-05-06 19:55:50 +08:00
Jenkins
5df18843b7 Merge "Ignore domain related config when using with keystone v2" 2016-05-06 10:20:16 +00:00
Tang Chen
f91685f391 Remove unnecessary type conversions in network unit tests
In some tests, when comparing the results data with the
expected ones, many unnecessary type conversions are used.
So remove them to clean up.

Change-Id: I560ca78a3ab5e7b99087bfe1667de500f92c68de
Partial-bug: #1550633
2016-05-06 03:42:27 +00:00
Hieu LE
59de9c477c Ignore domain related config when using with keystone v2
Currently, "/usr/bin/openstack --insecure token issue"
fails when OS_AUTH_URL and OS_IDENTITY_API_VERSION
indicate keystone v2 if OS_PROJECT_DOMAIN_NAME or
OS_USER_DOMAIN_NAME are set. This patchset ignore domain
related configs if using with keystone v2.

Change-Id: If7eea2ed1a4877c60d055ed0114a5e5f31e282a0
Closes-bug: #1447704
2016-05-06 03:42:15 +00:00
Richard Theis
9f3fa5ee3b Fix network router type display
The OpenStack SDK maps the network "router:external" field to
"is_router_external". However, OSC was using the incorrect
mapping, "router_external".  This caused OSC to display router
type as "Internal" for all networks.

Change-Id: Ifcd1349ab7c5881baee751936d076bf6aa058852
Closes-Bug: #1572228
2016-05-05 15:01:36 -05:00
Steve Martinelli
461a203f2d bump timeout to prevent gate failures
attempt to fix the transient gate failures by increasing the
timeout

Change-Id: I837652013f94b0d1ed3f4b40fe14ce5a47c687b6
2016-05-05 09:19:41 -07:00
Jenkins
9f91eadb2b Merge "Add a unit test for "flavor create" command" 2016-05-05 15:44:36 +00:00
Jenkins
4d85a3f0c6 Merge "Add functional tests for commands of floating ip" 2016-05-05 07:11:59 +00:00
sharat.sharma
f924fa39e1 Added "name" parameter to the help message.
In OS_IDENTITY_API_VERSION=3, the "openstack help service delete"
allows the user to remove a service based on the name of the
service. So, this patch includes name as positional argument.

Change-Id: Iae7cb0a82af3cdd4d88e0ed2eb651abf9af30fd9
Closes-Bug: #1566909
2016-05-04 12:57:07 +00:00
Huanxuan Ao
68224eafc3 Add a unit test for "flavor create" command
There was not a unit test for "flavor create" command
in the "test_flavor.py".So I add the unit test.

Change-Id: Ib1e821ea524eb33c0ba73643164228c7b83253b4
2016-05-04 18:55:49 +08:00
Jenkins
bf9b0e5ff4 Merge "Fix router set --route option" 2016-05-03 12:54:58 +00:00
Rui Chen
403e6cad5e Add describe of overwrite options behavior into devref
Update the devref to add the describe and code example about
overwrite options behavior.

Change-Id: I65e9a3a30acf8d427906096bde24fa8b4c3ac3f7
Implements: blueprint allow-overwrite-set-options
2016-05-03 03:20:33 +00:00
Michael McCune
b33ee3daf6 remove assert in favor an if/else
the assert usage in the NonNegativeAction has the potential to allow
unexpected behavior when the python is byte-compiled with optimization
turned on.

Changes
* remove assert in favor of if/else in NonNegativeAction class
* add type specifier to parser arguments for non-negative actions
* correct tests for new int based values

Change-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e
Closes-Bug: #1576375
2016-05-02 15:11:45 -04:00
Jenkins
9d7ccd9385 Merge "Fixes BadRequest when no --pool-prefix given" 2016-05-02 16:37:54 +00:00
Ankur Gupta
dc3d3ea77b Spec to Implement IP Availability
Specification to lay out new commands to be added to OSC.
New feature has been implemented and released for Neutron
and python-neutronclient to display IP usages.

Commands will display the IP usage across all networks, or
detailed IP usage specifics for a given network

Partially Implements Blueprint: neutron-ip-capacity

Change-Id: I1c25de1bd924d92a96c20d60fa24d9e966b92dcd
2016-05-02 09:47:07 -05:00
Jenkins
1ccb26b5c9 Merge "add a bandit environment to tox" 2016-05-02 14:03:29 +00:00
Huanxuan Ao
681d6dc2de Make "flavor show" command to show a private flavor properly
The "flavor show" command could not show a
private flavor by flavor name becauce it could
not find a private flavor by flavor name.
In "until.find_resource(parsed_args.flavor)",
If parsed_args.falvor is a name of a flavor,
"flavors.find(name=parsed_args.flavor)"will be
called to find a flavor.But the default value of
"is_public" is "Ture" in "flavors.find()" so that
we can only find public flavors.If we want to find
all flaovrs by flavor name,we should add
"is_public=None" in "flavors.find()".

So I tried to change
"until.find_resource(parsed_args.flavor)" to
"until.find_resource(parsed_args.flavor, is_public=None)",
but then I could not find any flavor by flavor id
because "is_public" is an unexpected argument of
"flavors.get()" in "until.find_resource()".

In this case,I think "until.find_resource()"
can not find a private flavor properly,and
we should combine "manager.get(flavor.id)" and
"manager.find(name=flavor.name, is_public=None)"
by ourselve to find a flavor.

Also,this bug affects other flavor commands like
"flavor set/unset/delete",so I fix them in this patch too.

Change-Id: I4a4ed7b0a2f522ee04d1c3270afcda7064285c39
Closes-Bug: #1575478
2016-05-02 16:47:53 +08:00
Dean Troyer
166a7b8a41 Documentation updates
* Update link to meeting information

Change-Id: I8dc6044b1faaa411e3b8d3b93fb401a480e82348
2016-04-30 09:06:58 -05:00
Daniel Gonzalez
9ec41c0397 Replace tempest-lib with tempest.lib
tempest-lib is deprecated, so replace it with tempest.lib.

Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>

Change-Id: I0495eba110bb7581623fbcf49dc63a27e9cb6d64
Closes-Bug: #1553047
2016-04-29 08:33:45 +00:00
Michael McCune
505659b0aa add a bandit environment to tox
This change is being proposed as part of the OpenStack Security Project
working session at the Austin 2016 summit. It adds support for running
the bandit[1] security linting tool against the python-openstackclient
codebase. This change adds a targetted environment for bandit and also
adds bandit as part of the pep8 job.

The bandit configuration has been tailored to exclude tests that are
currently producing warning against the codebase. These issues will be
followed up with bug reports and patches.

[1]: https://wiki.openstack.org/wiki/Security/Projects/Bandit

Depends-On: Iccd81c17e84df03d249c1012277dad9cb68c5845
Change-Id: I691829c1224557d1d239c9f665ac539d0f13c4d3
2016-04-28 14:52:33 -04:00
Jenkins
f1d14de6da Merge "Doc: Add network resource descriptions" 2016-04-28 16:46:17 +00:00
Jenkins
6bf60180a2 Merge "Fix error in flavor set/unset command" 2016-04-28 16:14:13 +00:00
Jenkins
941217a5f3 Merge "Support for volume service list" 2016-04-28 16:13:46 +00:00
Huanxuan Ao
4524b3605f Fix error in flavor set/unset command
In the "flavor set/unset" command,the "flavor" parameter
can be a name but can not be a id of a flavor.
I think we should find a flavor by using "utils.find_resource()"
in these commands.

Change-Id: I5836788f7ed18813f1ebde31bb808b7c3f932b80
Closes-Bug: #1575624
2016-04-28 19:59:53 +08:00
Huanxuan Ao
9dba843bde Add functional tests for commands of floating ip
This patch add functinal tests for commands of floating ip

Change-Id: I7f29578d0e14884f21183bfb82228d2fe7b7a029
2016-04-28 15:19:16 +08:00
Inessa Vasilevskaya
08759b853a Fixes BadRequest when no --pool-prefix given
--pool-prefix is made required on subnetpool creation.
Closes-bug: #1536479

Change-Id: I3d183e45e9b96bc08011c36f45ec2b7a9c01b627
2016-04-27 18:38:35 +03:00
Jenkins
74162fa31a Merge "Support quota show for current project" 2016-04-25 21:15:43 +00:00
Sheel Rana
4072554608 Support for volume service list
OSC does not support to list volume services.
This patch will provide support for adding volume service related
support.

Closes-bug:#1550999

Implements: bp cinder-command-support

Change-Id: I50ac14aeb96c4b8ddbf7b33e519feea0d126f752
2016-04-25 17:42:12 +00:00
Richard Theis
d0885e5d5a Doc: Add network resource descriptions
Add descriptions to the network resource command documentation.

Change-Id: I547ffb48f8950311a5ee65d6b535846f2aca0efc
2016-04-25 06:46:12 -05:00
Jenkins
a0a29df3e6 Merge "Add new share and default parms to subnet pool cmds" 2016-04-21 17:18:01 +00:00
Jenkins
d0ff8b6db2 Merge "Fixed subnet command host route output" 2016-04-21 17:17:53 +00:00
Richard Theis
1a2e12832d Devref: Command Beta
The devref proposes OSC support for beta commands.

Change-Id: I538a38be33734faf6eb69a3cb50946b2396b0c57
2016-04-21 12:14:42 -05:00
Richard Theis
27024d70af Support quota show for current project
The "os quota show" command "<project/class>" argument is now
optional. If not specified, the user's current project is used.
This allows non-admin users to show quotas for their current
project.

Change-Id: I602d4cc09c9d29ce84271eff78137f8810cb1a47
Closes-Bug: #1572733
2016-04-21 11:33:24 -05:00
Jenkins
65828f0982 Merge "Add commands of clustering service to doc" 2016-04-21 14:54:33 +00:00
Rui Chen
0d3a06db1c Fix server group document issue
The patch fix server group document typo and format issue.

Implements: blueprint nova-server-group-support
Related-Bug: #1542171

Change-Id: I3e24ddce91ecabc6be1b7be95d0f4e5a2ebe93ab
2016-04-21 14:51:45 +08:00
tengqm
518ef26895 Add commands of clustering service to doc
This patch adds the 'objects'/'resources' provided by the clustering
service (senlin) to the commands doc.

Change-Id: I028bd919f5b357d1b6e806c85e83a1a63c42839c
2016-04-21 01:20:36 -04:00
Brad Behle
48ebc49f20 Add new share and default parms to subnet pool cmds
Add the "share" and "default" parms to subnet pool create command.
Add the "default" and "no-default" parms to subnet pool set command.
Note that "share" can not be modified once subnet pool has been
created, so do not add this to the set command.

Change-Id: I1eecad69527a1cde7fb234669f4aff2be2db491e
Partial-Bug: #1544591
Partial-Bug: #1544586
2016-04-20 20:12:02 -05:00
Jenkins
38759f3edd Merge "Add "server group show" command" 2016-04-20 20:43:07 +00:00
Jenkins
e78113a5fc Merge "Fix mutable default arguments in tests" 2016-04-20 20:22:55 +00:00
Jenkins
98a0fba3c1 Merge "Update keypair tests" 2016-04-20 19:40:44 +00:00
Jenkins
f26b085f84 Merge "Add "server group list" command" 2016-04-20 18:26:44 +00:00
Jenkins
42263d779b Merge "Updated from global requirements" 2016-04-20 17:56:30 +00:00
Jenkins
eb522fbb5e Merge "Update tests for server" 2016-04-20 16:11:39 +00:00
Jenkins
8ad4af78a7 Merge "Trivial: Fix an omited i18n issue" 2016-04-20 16:08:25 +00:00
OpenStack Proposal Bot
745dc7633e Updated from global requirements
Change-Id: I8e2060cd483262c88c76b49a060aa7288fa2bbb6
2016-04-20 14:41:58 +00:00
Jenkins
cef0322fce Merge "Deduplicate CLI output parser code in test.py" 2016-04-20 13:45:14 +00:00
Richard Theis
f753bad742 Fixed subnet command host route output
Fixed the "os subnet create", "os subnet list" and
"os subnet show" command output for host routes to
improve readability and to align with the "--host-route"
option on the "os subnet create" and "os subnet set"
commands.

Change-Id: Ida69ae1a0bdb2e1648f8b5c978fc80cf1bbe752f
Closes-Bug: #1572309
2016-04-20 07:56:24 -05:00
Tang Chen
f995185c10 Trivial: Fix an omited i18n issue
Change-Id: I064ae79d31f96021dfb5d7cd16a3ace9725803f6
2016-04-20 15:21:29 +08:00
Kyrylo Romanenko
0e8c78c91a Update tests for server
Make testcases separate instances of test class.
Use setUp with addCleanup methods for every test case.
Add more descriptive docstrings for tests.

Closes-Bug: #1483422
Partial-Bug: #1566962
Change-Id: I1a16b5bad1dafd19fd7dc94794c0bd4587b7f516
2016-04-20 05:20:13 +00:00
Rui Chen
a0d79968ca Add "server group show" command
Support compute v2 "server group show" command in OSC.

Implements: blueprint nova-server-group-support
Closes-Bug: #1542171

Change-Id: I1a6d103151c704bda5b67cb9a49cc43c7d9f1d6a
2016-04-20 03:26:13 +00:00
Rui Chen
4e22728013 Add "server group list" command
Support compute v2 "server group list" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171

Change-Id: I68b80e3c4458692472af671028cd1f939736bcb8
2016-04-20 03:25:57 +00:00
Rui Chen
7458c612ed Add "server group delete" command
Support compute v2 "server group delete" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171
Related-Bug: #1563301

Change-Id: I7d792d669b147b24dc774844cfc9dbacd60d017b
2016-04-20 03:25:38 +00:00
Rui Chen
a06bb28bcc Add "server group create" command
Support compute v2 "server group create" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171

Change-Id: I96ffb07764d3adb715e048943cfee3b879c280f6
2016-04-20 03:24:58 +00:00
Rui Chen
a5a343a5a8 Support X.latest format for OS_COMPUTE_API_VERSION
OSC don't support to use "X.latest" format in order to talk with the
latest nova microversion API, that is very helpful shortcut usage to
use new nova side features, this patch implement it.

Change-Id: I87918addff1f50fbc6eb72ca82b31813330753b5
Closes-Bug: #1561838
2016-04-20 03:24:47 +00:00
Tang Chen
09c20b2b5c Fix mutable default arguments in tests
Python’s default arguments are evaluated only once
when the function is defined, not each time the
function is called. This means that if you use a
mutable default argument (like list and dict) and
mutate it, you will and have mutated that object
for all future calls to the function as well.

More details about this wrong usage here:
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments

In unit tests, most FakeXXX classes' methods take
mutable arguments with default values [] or {}.
We should change them to None.

Change-Id: Iea833b66aa1379829511ad5c6d4432b72f3488e2
Closed-bug: #1550320
2016-04-20 11:15:17 +08:00
Jenkins
4639148b1d Merge "Rename --profile to --os-profile" 2016-04-19 23:37:52 +00:00
Jenkins
6cbbcfa3da Merge "Updated from global requirements" 2016-04-19 23:02:05 +00:00
Jenkins
79abf70593 Merge "Fix client certificate/key support for Network v2 commands" 2016-04-19 20:01:25 +00:00
Jenkins
c3cc7d109d Merge "Clean up for next release" 2016-04-19 20:00:39 +00:00
Jenkins
a1633efb0f Merge "Imported Translations from Zanata" 2016-04-19 16:44:02 +00:00
Jenkins
7f20efc57c Merge "Add provider network options to osc network set" 2016-04-19 16:19:30 +00:00
Dean Troyer
530fe42589 Rename --profile to --os-profile
* The --profile global option is deprecated but will be supported
  through at least April 2017.
* Update man page

Closes-bug: #1571812
Change-Id: I2e623411a56096b4cc352f4eedbf770632ae2cc3
2016-04-19 07:50:42 -05:00
OpenStack Proposal Bot
8ab267c2eb Updated from global requirements
Change-Id: Ia35e711f1916749b156a1344ffafb4391a7a5408
2016-04-19 12:28:55 +00:00
Kyrylo Romanenko
ff62c832b5 Update keypair tests
Make testcases separate instances of test class.
Use setUp with addCleanup methods for every test case.
Add negative test cases.

Closes-Bug: #1564480
Change-Id: I5d8fd2a238e6cf0584777eb0d24dfcaed4133ee1
2016-04-19 15:10:30 +03:00
Cedric Brandily
02a46a067b Fix client certificate/key support for Network v2 commands
Currently network v2 commands don't support client certificate/key
because they were not passed to OpenStackSDK Connection which is used
by network v2 commands.

This changes corrects the integration with OpenStacKSDK to pass client
certificate/key.

Closes-Bug: #1569513
Related-Bug: #1569508
Depends-On: Ic093f8515e7b15931994e4516ebec8f4399d021e
Change-Id: Ie37e8e988ca695a09894c6c93560dacd83f17030
2016-04-19 13:00:54 +02:00
Jenkins
4d05851d4e Merge "Add options to security group rule list" 2016-04-19 09:03:19 +00:00
OpenStack Proposal Bot
2a66493ff0 Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I7e1c948a2bb7f4843cd8a58bb66fbedec79af39b
2016-04-19 06:14:07 +00:00
Kyrylo Romanenko
c95d68eaea Deduplicate CLI output parser code in test.py
Use methods from tempest-lib.cli.output_parser.

Change-Id: I0655141a0ef967675e41b1da49cf999da3382018
2016-04-19 05:20:23 +00:00
Jenkins
c9cfd569fe Merge "Initialize neutron client with region name" 2016-04-19 04:48:03 +00:00
Jenkins
a7be016b3e Merge "Updated from global requirements" 2016-04-19 04:06:00 +00:00
reedip
aa1495e241 Add provider network options to osc network set
The following patch adds the provider network options
to OSC "network set".

Change-Id: I23b617077eda25d16164172a8e280082750eaf18
Partial-Bug: #1545537
2016-04-19 11:18:13 +09:00
Dean Troyer
baf96411fe Clean up for next release
* Release notes
* Docs Table of Contents

Change-Id: I4bef26ed348923671a2b50f90606661d519b40e3
2016-04-18 14:19:27 -05:00
Richard Theis
94c9cd5c66 Add options to security group rule list
Add the following options to the 'os security group rule list'
command:
  --long: Display direction and ethertype for Network v2
  --all-projects: Display information from all projects for Compute v2

Change-Id: If8a1cbd7669cdfa6577d6d2f6fffd9e999a39a82
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-18 14:03:22 -05:00
Richard Theis
a90c824e04 Fix router set --route option
Fix the "--route" option on the "os router set" command. The
option did not properly format the new routes to set which
resulted in a "HttpException: Bad Request" error. In addition,
the output for routes was fixed to improve readability and to
align with the "--route" option on the "os router set" command.

Change-Id: I9c514153ec201e2feae32be6dd281771e3298b9c
Closes-Bug: #1564460
2016-04-18 13:35:38 -05:00
Jenkins
3f2ed7d19f Merge "Remove methods argument from vloume/v2/fakes.py" 2016-04-18 17:55:08 +00:00
Jenkins
e3a6fc27b0 Merge "Propagate AttributeErrors when lazily loading plugins" 2016-04-18 17:01:42 +00:00
Andrey Larionov
8c6b5a087a Initialize neutron client with region name
All clients except neutron are initialized with region name.
This makes unable to use network related commands of
openstackclient in multi-region configurations

Change-Id: I200dc9a2f938c3e69357f91c79810df167e4fccb
Closes-bug: 1570491
2016-04-18 19:54:58 +03:00
OpenStack Proposal Bot
f9e3d45173 Updated from global requirements
Change-Id: I12de03c42bc661a6a4e55fb70a06883e987fbc5f
2016-04-18 16:34:57 +00:00
Tang Chen
cc3a062529 Remove methods argument from vloume/v2/fakes.py
methods argument in FakeAvailabilityZone class
is not necessary. Remove it.

Change-Id: Idf136bf90bd94e7045b0d471b8e03cd843693251
2016-04-18 15:20:17 +08:00
Tang Chen
89445855ac State i18() changes and help messages improved
Add _() to wrap help message in network commands.
And also some improvement for help message.

Change-Id: Ib3e498f5976ba98c44fd4eec2d1623263b3db53e
Partial-bug: 1570924
2016-04-18 10:31:01 +08:00
Jenkins
8eade18624 Merge "Remove methods argument from FakeHypervisorStats" 2016-04-16 23:58:36 +00:00
Sheel Rana
92950b6f5f Add support for removing volume-type-access
OSC does not support to remove volume type access to project.
This feature will provide support to remove volume type access
from project.

Closes-Bug:#1554890

Implements: bp cinder-command-support

Change-Id: I029a4292da05f028e8937962cb845ec6e00b0279
2016-04-16 23:01:19 +05:30
Jenkins
e80048de09 Merge "Fix wrong attribute name and add functional test for --snapshot" 2016-04-15 21:01:10 +00:00
Jenkins
f66f989d83 Merge "Append existing information during port set" 2016-04-15 16:30:48 +00:00
Jenkins
881c836030 Merge "Add external network options to osc network set" 2016-04-15 16:26:44 +00:00
Jirayut Nimsaeng
e128370676 Fix wrong attribute name and add functional test for --snapshot
Change-Id: I91f2091ef06a55bcf5373d1beeea2dd81e9f1334
Closes-Bug: #1567895
2016-04-15 16:13:02 +00:00
Tang Chen
df3ee61be3 Remove methods argument from FakeHypervisorStats
methods argument is not necessary in FakeHypervisorStats class.
Remove it.

Change-Id: I288f71b412beb3e583e957a9fd99210bc6f3f543
2016-04-15 16:10:09 +08:00
Tim Burke
926330d372 Propagate AttributeErrors when lazily loading plugins
Previously, if an AttributeError was raised in a plugin's make_client
method, the plugin simply wouldn't be an attribute of the ClientManager,
producing tracebacks like

Traceback (most recent call last):
  File ".../openstackclient/shell.py", line 118, in run
    ret_val = super(OpenStackShell, self).run(argv)

  ...

  File ".../openstackclient/object/v1/container.py", line 150, in take_action
    data = self.app.client_manager.object_store.container_list(
  File ".../openstackclient/common/clientmanager.py", line 66, in __getattr__
    raise AttributeError(name)
AttributeError: object_store

This made writing minimal third-party auth plugins difficult, as it
obliterated the original AttributeError.

Now, AttributeErrors that are raised during plugin initialization will
be re-raised as PluginAttributeErrors, and the original traceback will
be preserved. This gives much more useful information to plugin
developers, as in

Traceback (most recent call last):
  File ".../openstackclient/shell.py", line 118, in run
    ret_val = super(OpenStackShell, self).run(argv)

  ...

  File ".../openstackclient/object/v1/container.py", line 150, in take_action
    data = self.app.client_manager.object_store.container_list(
  File ".../openstackclient/common/clientmanager.py", line 57, in __get__
    err_val, err_tb)
  File ".../openstackclient/common/clientmanager.py", line 51, in __get__
    self._handle = self.factory(instance)
  File ".../openstackclient/object/client.py", line 35, in make_client
    interface=instance._interface,
  File ".../openstackclient/common/clientmanager.py", line 258,
  in get_endpoint_for_service_type
    endpoint = self.auth_ref.service_catalog.url_for(
PluginAttributeError: 'NoneType' object has no attribute 'url_for'

Change-Id: I0eee7eba6eccc6d471a699a381185c4e76da10bd
2016-04-14 21:12:35 -07:00
reedip
67f8b898eb Add external network options to osc network set
The following patch adds the options "--external" & "--internal"
and the suboptions to "external": "--default" & "--no-default",
to "osc network set" CLI to provide the user an option to set
a network as an external network or remove the setting.

Change-Id: I3a7f2cb249bc8101cbb01322d7732e913237d6cd
Partial-Bug: #1545537
2016-04-15 00:28:09 +00:00
Jenkins
52a12e743e Merge "Add project options to security group rule create" 2016-04-14 21:45:03 +00:00
Jenkins
ef68f23de3 Merge "Add network options to security group rule create" 2016-04-14 19:55:54 +00:00
Jenkins
e1305185d3 Merge "Prefer assertEqual/assertIn over assertOutput/assertInOutput" 2016-04-14 19:55:26 +00:00
Jenkins
83fbce496a Merge "Remove fake methods code from compute network" 2016-04-14 16:47:00 +00:00
Jenkins
5b18e110a9 Merge "use correct manager for volume snapshots" 2016-04-14 13:54:20 +00:00
Tang Chen
46decfbd7a Trivial: Fix incorrect comment text
Change-Id: Ia6ec15f11a535a8de5769569d75e81094caed171
2016-04-14 17:21:53 +08:00
Tang Chen
56f9227063 Enhance exception handling for "network delete" command
This patch rework "network delete" command following the
rules in doc/source/command-errors.rst.

In "network delete" command, there are multiple REST API
calls, and we should make as many of them as possible.
And log error for each one, give a better error message.
Also return a non-zero exit code.

Change-Id: I39ae087dd7bd08d049d513abfa6c5cab2bd13b2b
Partial-Bug: #1556719
2016-04-14 13:54:14 +08:00
reedip
c92ac9d911 Append existing information during port set
Existing --fixed-ip and --binding-profile information is
currently overwritten when a user executes 'port set', but
actually that data should be appended.
This patch fixes the issue.

Closes-Bug: #1564453
Change-Id: I62500c10ccbbc68167f24e9d4fa49e85345d82c4
2016-04-14 00:48:09 +00:00
Jenkins
be6027e09b Merge "Doc: Unify repeatable option comments" 2016-04-13 21:22:50 +00:00
Jenkins
52b70a99ed Merge "Use CommandFailed exception from tempest_lib" 2016-04-13 18:43:08 +00:00
Kyrylo Romanenko
573bb6b941 Use CommandFailed exception from tempest_lib
Remove exceptions.py from functional/common.
Import exception with the same code from the tempest_lib to tests.

Change-Id: Ifaa658209c18dd608836079f57ed18fcf10fb84e
2016-04-13 19:09:07 +03:00
Jenkins
883f8208d3 Merge "Append existing information during subnet set" 2016-04-13 15:51:44 +00:00
OpenStack Proposal Bot
379fd726b6 Updated from global requirements
Change-Id: I17ae521c6d9cf2c2cf73527929984aed5fe225ca
2016-04-13 12:48:31 +00:00
Jenkins
7b7620ab84 Merge "Fix SSL/TLS verification for network commands" 2016-04-13 08:31:37 +00:00
Jenkins
1819edf733 Merge "Add --address-scope option "subnet pool create/set"" 2016-04-13 02:06:59 +00:00
Jenkins
85c47b76fb Merge "Add support for setting volume-type-access" 2016-04-12 22:27:07 +00:00
Jenkins
162c985138 Merge "Fix prefixes output for subnet pool list" 2016-04-12 22:17:43 +00:00
Richard Theis
3a4d53a93b Fix prefixes output for subnet pool list
Fixed "os subnet pool list" command to properly disply the
list of subnet pool prefixes in the "Prefixes" column. This
fix is consistent with the "os subnet pool create" and
"os subnet pool show" command output.

Change-Id: I431d85c3b7f5bf8a327500decf3a15063fc5b120
Closes-Bug: #1569480
2016-04-12 12:42:13 -05:00
Jenkins
9f75e7a33d Merge "Add Testing Ref in README.rst" 2016-04-12 12:37:32 +00:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
Tang Chen
a281ef89a5 Remove fake methods code from compute network
Network objects don't have any method needs to fake.

keys() method is only used by _get_columns() helper
to obtain all attributes of an object. But in compute
network implementation, attributes are obtained from
obj._info directly, which is a dictionary itself. So
there is no need to fake this method.

Change-Id: Ie6a46ef6a3042641e55a7002573ef501db7b60e1
2016-04-12 13:41:52 +08:00
Ankur Gupta
61a60ef926 Add Testing Ref in README.rst
Add a reference in the README directed to docs page for testing
within python-openstackclient. Avoid creating TESTING.rst due to
unneeded duplication. Updated Developer URL to correct one.

Change-Id: I40b4c949d155aea6e0e25ecd4a88797481a4d8ac
2016-04-11 11:12:37 -05:00
Jenkins
3be49a8abe Merge "Move keys() methods in each resource class to FakeResource" 2016-04-11 15:07:34 +00:00
Richard Theis
a5a9caea2b Add project options to security group rule create
Add the --project and --project-domain options to the
'os security group rule create' command. These options
are for Network v2 only.

Change-Id: Ie3e136be076f0f2c22fbe7048d1d6eaebf5aa655
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 10:05:24 -05:00
Richard Theis
3a3f33b926 Add network options to security group rule create
Add the following network options to the "os security group rule"
command:
  (1) --ingress and --egress
  (2) --ethertype
These options enable egress and IPv6 security group rules for
Network v2.

Change-Id: Ie30b5e95f94e0c087b0ce81e518de72d2dda25ad
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-04-11 09:49:21 -05:00
Jenkins
cba37d0031 Merge "Doc: Fix network command documentation issues" 2016-04-11 13:17:12 +00:00
Sheel Rana
be2d2a1b8d Add support for setting volume-type-access
OSC does not support to set volume type access to project.
This patch will provide support for adding volume type access
to existing project.

Closes-Bug:#1554889

Implements: bp cinder-command-support

Change-Id: Ie36e202bdde7de36eb263a476eb66699d82f7565
2016-04-11 12:53:15 +00:00
Tang Chen
827be8fb8c Move keys() methods in each resource class to FakeResource
FakeXXX classes in network don't need to fake any method,
except keys(). But keys() can be put in FakeResource since
it just returns all attributes in _info.

This patch moves removes all unnecessary fake methods code,
moves keys() method to FakeResource.

This patch also finds out some missing attributes in
network and router tests.

Change-Id: I799822c8715b9ac4f95b98f8350f196757d79d3e
2016-04-11 18:07:50 +08:00
Jenkins
cb8f757779 Merge "Refactor security group rule list to use SDK" 2016-04-11 03:01:13 +00:00
Jenkins
87244d051b Merge "Doc: Add missing command objects" 2016-04-11 02:18:14 +00:00
Tang Chen
b3649a54cd Add --address-scope option "subnet pool create/set"
This patch adds --address-scope option to "subnet pool create/set"
commands, and --no-address-scope option to "subnet pool set"
command to clear the address scope setting.

Change-Id: Ie2c370a50b52574fa6ec268083ad013b7544361e
Partial-Bug: #1544586
Partial-Bug: #1544591
2016-04-09 16:25:50 +08:00
Jenkins
6c73946623 Merge "Add Subnet add/remove support to router" 2016-04-09 04:52:09 +00:00
Jenkins
b70afef9d5 Merge "Add "router remove port" to osc" 2016-04-09 04:43:35 +00:00
Dean Troyer
0ea80a92f0 Fix pep8 fail that crept in
Not sure how, but this crept in via https://review.openstack.org/#/c/281691/

Change-Id: I919276ee5204277dbc5e96f4de4b98381142423a
2016-04-08 19:33:15 -05:00
Jenkins
5d2f4107b4 Merge "Add "router add port" to osc" 2016-04-08 18:24:46 +00:00
Steve Martinelli
f3f8c20a8c use correct manager for volume snapshots
the snapshot manager is volume_snapshots, not snapshots.

Closes-Bug: #1567895
Change-Id: I12c0238fc04507c97e92089fda3bec816171a973
2016-04-08 10:36:54 -04:00
Richard Theis
b5f10f43eb Fix SSL/TLS verification for network commands
The network commands ignored the --insecure and --os-cacert
options and OS_CACERT environment variable which prevented
them from properly completing SSL/TLS verification. This
resulted in the network commands failing with
"An SSL error occurred."

Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1
Closes-Bug: #1560157
2016-04-08 09:33:33 -05:00
Richard Theis
6b76860c45 Doc: Fix network command documentation issues
Fix the following network command documentation issues:
  - Fix format of subnet pool positional arguments
  - Update port set options to match help
  - Fix network command documentation for Network v2
    versus Compute v2 options and commands
  - Fix subnet command documentation errors and formatting
    problems in help text

Change-Id: I808c2a70ca62eafc9e42d6873539cdd142ffe50c
Related-Bug: #1558677
2016-04-08 08:00:17 -05:00
reedip
03d932ea0b Append existing information during subnet set
Existing values of --dns-nameserver, --allocation-pool and --houst-routes
is currently overwritten when a user executes 'port set', but
actually that data should be appended.
This patch fixes the issue.

Closes-Bug: #1564447
Change-Id: I3dba9afa68d869abb3960b55a6880401a10eebf7
2016-04-08 06:19:09 +00:00
Jenkins
9f2e7039e1 Merge "TrivialFix: Rename provider segment option" 2016-04-08 04:23:22 +00:00
reedip
a8c085fdd5 TrivialFix: Rename provider segment option
As per [1], provider-segmentation-id is changed to provider-segment
as segments may soon have a "name" support as well.

[1]: https://review.openstack.org/#/c/294422/12/doc/source/command-objects/network.rst

Change-Id: I74d4366301b41fa181faccbc12cff9530df60353
2016-04-08 01:46:06 +00:00
OpenStack Proposal Bot
3485c223ea Updated from global requirements
Change-Id: I9fe06c9739c3625abd7cb03ac97c58bb9cdbc5bd
2016-04-08 00:33:16 +00:00
Jenkins
7ad529ec24 Merge "Updated from global requirements" 2016-04-07 23:06:31 +00:00
Jenkins
10ddb2a146 Merge "Clean up release notes since 2.2.0 release" 2016-04-07 19:24:54 +00:00
OpenStack Proposal Bot
29c92f5d24 Updated from global requirements
Change-Id: I2af3dc17e6f2c4cada96f1ff08627a3b41196f4d
2016-04-07 17:33:22 +00:00
Jenkins
870fa2f2a2 Merge "Correct addCleanup use in functests" 2016-04-07 16:32:07 +00:00
Jenkins
418793edbe Merge "Make snapshot and backup name optional" 2016-04-07 16:20:49 +00:00
Dean Troyer
ad6727df88 Clean up release notes since 2.2.0 release
* Remove release notes for changes to commands that have not been released yet
* Combine notes for common command sets (ie, new port commands)
* Rename notes with bugs to the bug-NNNNN-XXXXXXX form

Change-Id: I6216aad443056ada2fe28ba533bf20a09f118e4d
2016-04-07 10:54:41 -05:00
reedip
2a9ba9db30 TrivialFix: Fix help messages for port set
Certain messages in ``port set`` were incorrect as mentioned
in [1] which are fixed in this patch.

[1]:https://review.openstack.org/#/c/300309/6/doc/source/command-objects/port.rst
TrivialFix

Change-Id: Icb8e91664fea590cd4202f80d61a82eb50b22403
2016-04-07 11:00:07 +09:00
reedip
73d15e3768 Add option to clear information from ports
This patch adds the option of "no-fixed-ip" and
"no-binding-profile" which is used to clear the
fixed-ip and binding:profile information from the
ports.

Change-Id: I946301eaf6c647bae55e4f416aa0d98e5f06e699
2016-04-07 10:59:15 +09:00
Jenkins
0edab95fd1 Merge "Support client certificate/key" 2016-04-06 21:42:56 +00:00
Jenkins
7767e5dcf7 Merge "Devref: Document OSC interfaces available to plugins" 2016-04-06 21:35:37 +00:00
Ivan Kolodyazhny
311e775c81 Make snapshot and backup name optional
Cinder does not require snapshot and backup name. These arguments are
optional.

Change-Id: I05d59efc9642205a25684bf0b77758328296d959
2016-04-06 23:25:38 +03:00
Jenkins
bd7e1d3a3e Merge "Add provider network options to osc network create" 2016-04-06 19:23:45 +00:00
Jenkins
60a91a6572 Merge "Add external network options to osc network create" 2016-04-06 19:20:56 +00:00
Cedric Brandily
b13ec98467 Prefer assertEqual/assertIn over assertOutput/assertInOutput
functional.common.tests module defines:

 * assertOutput (similar to assertEqual)
 * assertInOutput (similar to assertIn)

in order to allow the usage of assertions in testcase classmethods but
there is no reason to use them in testcase instancemethods at least
because they raise Exception instances instead of AssertionError
instances.

Change-Id: I9ffcaf9c6e6a1ff5df6ea2d79be3fb4496db4b85
2016-04-06 20:59:59 +02:00
Jenkins
523ab58fb6 Merge "Log hint when --enable present with --disable-reason" 2016-04-06 18:46:14 +00:00
Cedric Brandily
e2e9c49cd9 Correct addCleanup use in functests
This change replaces in many identity functests the pattern:

 raw_resource = create_resource(...)
 check(raw_resource)
 self.addCleanup(delete_resource, ...)
 ...

by the pattern:

 raw_resource = create_resource(...)
 self.addCleanup(delete_resource, ...)
 check(raw_resource)
 ...

which ensures that cleanup is defined and called after the test even if
check(resource) fails.

Change-Id: I4da541b7552d06eaffafda446e389bb552422cda
2016-04-06 20:43:21 +02:00
Cedric Brandily
3a8320a1d7 Support client certificate/key
This change enables to specify a client certificate/key with:
 * usual CLI options (--os-cert/--os-key)
 * usual environment variables ($OS_CERT/$OS_KEY)
 * os-client-config

Change-Id: Ibeaaa5897ae37b37c1e91f3e47076e4e8e4a8ded
Closes-Bug: #1565112
2016-04-06 20:21:19 +02:00
reedip
1b351e1695 Add provider network options to osc network create
The following patch adds the provider network options
to OSC "network create".

Change-Id: Ib8449c00ee4b4285889588f03ddd7a686ce8f987
Partial-Bug: #1545537
2016-04-06 16:52:47 +00:00
reedip
107bc5164f Add external network options to osc network create
The following patch adds the options "--external" & "--internal"
and the suboptions to "external": "--default" & "--no-default",
to "osc network create" CLI to provide the user an option to create
a network as an external network.

Change-Id: Idf73714bb94c0610ea164131140a51848908b00b
Partial-Bug: #1545537
2016-04-06 16:01:24 +00:00
Jenkins
81e37a2dce Merge "Improve tmpfile cleanup in functests" 2016-04-06 14:10:05 +00:00
Jenkins
492aa74fed Merge "Use fixtures and addCleanup instead of tearDown" 2016-04-06 14:05:18 +00:00
Jenkins
4307fe22dc Merge "Remove unused method cleanup_tmpfile" 2016-04-06 06:13:57 +00:00
Jenkins
05495d508c Merge "Fix typos in docstrings and comments" 2016-04-06 06:07:35 +00:00
Jenkins
b1b5a2acdd Merge "Add name option to 'port set'" 2016-04-06 06:02:06 +00:00
Dao Cong Tien
67a8947ea2 Fix typos in docstrings and comments
Change-Id: Ic2dc057dca87212f715970f8325956c42f62ea9f
2016-04-06 10:30:39 +07:00
Cedric Brandily
3c82c0e62e Improve tmpfile cleanup in functests
This change replaces when possible homemade temporary file management by
tempfile.NamedTemporaryFile[1][2] and defines only when needed a cleanup
for a temporary file[2].

[1] functional/tests/compute/v2/test_keypair.py
[2] functional/tests/object/v1/test_object.py

Change-Id: I728ab96381ca9f3fd1f899dd50e5ceb5e97b9397
2016-04-06 00:40:44 +02:00
Cedric Brandily
139a45bb71 Remove unused method cleanup_tmpfile
This change removes unused cleanup_tmpfile method from functests code.

Change-Id: I5d8e7edb0e50e94a5a469ce393d411b390b4db34
2016-04-06 00:40:44 +02:00
Cedric Brandily
bad21594be Use fixtures and addCleanup instead of tearDown
Nothing ensures tearDown call as tearDown is called only if test
succeeds. This change replaces tearDown use with:

* addCleanup use to stop mocks
* EnvFixture which ensures to unmock environment thanks to useFixture.

Change-Id: I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc
2016-04-05 17:57:55 +02:00
Rui Chen
4d3f996e7c Log hint when --enable present with --disable-reason
--enable and --disable-reason should be mutually exclusive in "compute
service set" command, but now when they are present at the same time,
--disable-reason would be ignored silently. Fix these and add some hints
about --disable-reason argument is ignored in this situation.

Change-Id: I43254b6bc40fcae4fd0dc3457f26fad84c267072
Closes-Bug: #1556801
2016-04-05 21:22:27 +08:00
Tang Chen
c3f6ee9570 Trivial: Rename FakehypervisorStats to FakeHypervisorStats
Change-Id: I138b1b8a3327947b8cd032d8d0c32d98548ce2ad
2016-04-05 19:43:33 +08:00
reedip
66f94dca5c Add name option to 'port set'
Port's name can be updated in NeutronClient and it is a very
good feature for a user to have the ability to rename a port.
This was missing in the openstackclient, and the same has been
added in this patch.

Change-Id: I6e712ef08ab1c0a23786c4bb6972d3e0f8f0f999
Implements: blueprint neutron-client
2016-04-05 01:35:00 +00:00
Sean Dague
97492c168f rxtx factor should be a float
The rxtx factor on compute flavors is a float in the API. OSC is
currently blocking float values.

Change-Id: Ifa9c14825f388d2821ff4b63ab8ae83fa9c8d88b
2016-04-04 16:18:31 -04:00
Hidekazu Nakamura
55b37d5e33 Don't mask authorization errors
Project show with name argument returns 'Could not find resource'
error when the user is not authorized. It should report the
authorization error instead. This patch makes that change.

Change-Id: Iac3521f8a411060b0ec9ef46c8f0e1f3551e56ae
Closes-Bug: #1511625
2016-04-01 16:44:33 -04:00
Jenkins
061037aaf1 Merge "Add default value to pool-prefix in Subnet-pool" 2016-04-01 20:38:32 +00:00
reedip
7027d915b5 Add default value to pool-prefix in Subnet-pool
If user tries to create a subnet pool without --pool-prefix,
it fails at the NeutronServer [1].
This patch tries to add a default value to the --pool-prefix
to try and resolve it.

Closes-Bug: #1564271
[1] : http://paste.openstack.org/show/492537/

Change-Id: I6cf324a5a8037048602e59c0bbfc93b40e73a74e
2016-04-01 06:51:07 +00:00
Jenkins
6db4aa24ff Merge "Devref: Options with Multiple Values" 2016-04-01 06:01:38 +00:00
Jenkins
b4c3adbd30 Merge "Follow Boolean Option rule" 2016-04-01 03:31:06 +00:00
Richard Theis
8ba257cb30 Devref: Options with Multiple Values
Add a devref for options with multiple values.

Change-Id: Ic90c2317eb6c0445d234964c5243ecc689d5f4c7
2016-03-31 08:55:56 -05:00
Richard Theis
cd96d2966f Doc: Add missing command objects
Add missing command objects that have command documentation.

Change-Id: I2a34cc632c00c7f6bcf6481e6779b79093cd6488
2016-03-31 07:27:46 -05:00
Tang Chen
a1a470693e Add --project to "subnet pool create"
This patch adds --project and --project-domain
options to "subnet pool create" command.

Change-Id: I2fe006013a194861299a9c77234a7cf988a8dad8
Partial-Bug: #1544586
2016-03-31 12:31:02 +08:00
reedip
c5c15a0135 Follow Boolean Option rule
OSC has a specific rule for handling boolean based options
in  [1]. This patch modifies the exisiting code so that it
matches the criteria that have been specified in [1].

[1]: http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

Closes-Bug: #1559418
Change-Id: I182381d5579efbc75a5d3e8a91f412398abf5c3c
2016-03-31 13:06:45 +09:00
Jenkins
f48f9398b8 Merge "Add fixed keypair create functional test" 2016-03-31 02:47:00 +00:00
Jenkins
f3b58238dd Merge "Add unit tests for compute v2 aggregate" 2016-03-30 23:23:57 +00:00
Jenkins
01b2a0c49f Merge "Add "aggregate unset" to osc" 2016-03-30 23:21:37 +00:00
Jenkins
a73926556f Merge "Fix subnet pool prefix length option" 2016-03-30 22:10:30 +00:00
Jenkins
e666a8ab74 Merge "Aggregate object should be "grouping of compute hosts"" 2016-03-30 21:41:30 +00:00
Dean Troyer
029654b9a8 Add fixed keypair create functional test
This adds a test case to exercise the --public-key option of
the 'keypair create' command.  It is a follow-on to
I7a299a542d9df543bff43d3ea1e7907fc8c5f640 that fixed a key file
read bug.

Change-Id: Id78c1c7ece02f619aca69dc397185fc426b92306
2016-03-30 15:58:42 -05:00
Richard Theis
9174bc0f02 Fix subnet pool prefix length option
Fix the --min-prefix-length, --max-prefix-length and
--default-prefix-length options for the "os subnet pool create" and
"os subnet pool set" commands. Using these options caused the
commands to fail with "HttpException: Bad Request" because unrecognized
attributes were passed to the REST API.

No release note was added since these commands are new and haven't
been released.

Change-Id: I2f765750f79dc91d6c1f5962f699fbf2ee38657a
Closes-Bug: #1564004
2016-03-30 13:28:31 -05:00
Sheel Rana
63c57eb56e Wrong param type in compute-service.rst
compute-service.rst file uses 'describe' for below
optional parameters

1. --long
2. --service <service>
3. --host <host>

This patchset changes type of these argument to option.

Change-Id: Ifd57bdf058efaeaa6cb43a7d4a60ee61ddb8de14
Closes-bug:#1563700
2016-03-30 14:45:41 +00:00
Jenkins
9e7f0cf1a5 Merge "Remove unused method 'from_response'" 2016-03-29 16:33:04 +00:00
Jenkins
8233b923f1 Merge "Docs cleanup: volume type" 2016-03-29 13:22:10 +00:00
Wenzhi Yu
848d5312ff Remove unused method 'from_response'
'openstackclient.common.exceptions.from_response' method is never called
in openstackclient code base, so we should remove it.

Change-Id: I04254a4e66863942e6c273d77bbd66ce2ce7804c
Related-Bug: #1559072
2016-03-29 17:28:24 +08:00
Rui Chen
b2e47b6228 Aggregate object should be "grouping of compute hosts"
The describe of Compute "aggregate" in command-objects and commands
documents use "a grouping of servers", but exactly that should be a
grouping of compute hosts. "server" object in OSC is a virtual machine
instance, and server group should be "grouping of servers".

Change-Id: Ib034fed15f11fc3e756985b3131a9922129ed6bf
Closes-Bug: #1563172
Related-Bug: #1542171
2016-03-29 12:01:31 +08:00
Jenkins
62a6a497bd Merge "Docs cleanup: volume command help" 2016-03-29 02:20:01 +00:00
Dean Troyer
a3a2a7e9f0 Docs cleanup: volume command help
This formats the volume command help text consistent with the rest of OSC,
adds some reference targets and some explanation text to some commands.

No functional changes have been made, only cosmetic/help output.

Change-Id: Ib86ec3ca58bdea5f33078ced3ec3583b2be0e89a
2016-03-28 18:25:58 -05:00
Jenkins
0a760e2d87 Merge "Added functional tests for 'service provider' v3 commands" 2016-03-28 20:54:59 +00:00
Dean Troyer
b4402a0468 Docs cleanup: volume type
Clean up volume type command help, add volume type show to doc, sort
command classes in v1/volume_type.py.

Change-Id: I1f8e5c047d9c08f5704fc23cfb694f23d32e3caf
2016-03-28 14:33:24 -05:00
Dean Troyer
9d65abcaa6 Docs cleanup: sort subnet commands
Change-Id: I43c0052ec5ed2e94b203a0befc4b39d3522d4e9c
2016-03-28 13:08:07 -05:00
Richard Theis
c5b58a47b0 Refactor security group rule list to use SDK
Refactored the 'os security group rule list' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

In addition, a release note was added to document the features
and fixes resulting from this refactor.

Change-Id: I24d04b720102ed1c60776e1ca67d4ca20e31b663
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-28 12:25:51 -05:00
Jenkins
5f55e99d46 Merge "Support security group name for --src-group" 2016-03-28 15:57:31 +00:00
Kristi Nikolla
add0e10026 Added functional tests for 'service provider' v3 commands
'identity provider' commands had functional tests but 'service
provider' commands did not. Added the tests in a similar way to
how it is done it test_idp.

Change-Id: Id4b24ef7d34db65c6b0260c89327ec9be683284d
2016-03-28 10:06:35 -04:00
Jenkins
d5596862b1 Merge "Refactor security group rule create to use SDK" 2016-03-28 09:16:23 +00:00
Rui Chen
e1e68809ae Add unit tests for compute v2 aggregate
This patch add the complete unit tests to cover compute v2
aggregate object.

Change-Id: Ifcf9248eabb5ca3ee5ca01c5843e96ba681c3b5a
Closes-Bug: #1560832
2016-03-26 18:43:46 +08:00
Jenkins
ef1faf7792 Merge "Subnet: Add "subnet set" command using SDK" 2016-03-25 15:47:15 +00:00
Rui Chen
4cbcd02a57 Add "aggregate unset" to osc
Support "aggregate unset" command in order to
remove the property of aggregate object in OSC.

Change-Id: I49645135586362f0fd251f5e4a4c03eff273d9e9
Closes-Bug: #1559866
2016-03-24 10:33:23 +08:00
reedip
2b95e363d3 Subnet: Add "subnet set" command using SDK
This patch adds "subnet set" command to osc using sdk.

Implements: blueprint neutron-client

Closes-bug: #1542363

Change-Id: Id3b7f4b9190b4d73ca3ae423321a65f94a6da62e
2016-03-24 02:21:40 +00:00
Tang Chen
860dbc132d [Floating IP] Neutron support for "ip floating create" command
This patch adds --subnet, --port, --floating-ip-address
and --fixed-ip-address options only. Project related options
will be added in another patch because it relates to identity
v2 and v3, which will make the unit tests too complicated in
one single patch.

Change-Id: I3cce4404a114ff128b74e4596f0e847be2846b17
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-03-24 09:07:25 +08:00
Richard Theis
2109bce85a Support security group name for --src-group
Support security group name for the "--src-group" option on the
"os security group rule create" command.

Change-Id: Ic23d0671dad77566269c9a588644c8d774368733
Closes-Bug: #1540656
2016-03-23 10:05:08 -05:00
Richard Theis
d906507962 Refactor security group rule create to use SDK
Refactored the 'os security group rule create' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2.

Change-Id: I8c6c99d5272ff5d410a449f73d198d834c5cd96e
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-23 09:56:01 -05:00
Jenkins
4b4349ee68 Merge "Fix "server unset" document issue" 2016-03-23 13:35:49 +00:00
Tang Chen
3e0e1f8c41 Trivial: Fix typo in common/limits.py
Change-Id: I3040cc69512df50459960f96b862de55804068ac
2016-03-23 16:04:21 +08:00
Rui Chen
ee621509be Fix "server unset" document issue
Fix "--property" option describe issue in "server unset"
document, and update the help message to keep consistent.

Change-Id: I68022a187e83fad6320365400ad2a1b0c8cf9a61
2016-03-23 14:45:04 +08:00
Tang Chen
41853985bb Use assert_called_once_with() instead of assert_called_with()
If one API is only called once, we'd better use assert_called_once_with()
to check the call.

Change-Id: Id05055bb90592d218826732259ed84fc366734ce
2016-03-22 10:08:51 +08:00
reedip
9e42daa577 Add Subnet add/remove support to router
The following patch adds the support for
"router add subnet" and "router remove subnet"
to the OSC as a part of migration of Neutron's
CLI commands.

Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
Change-Id: Ia3770c41026194bdb1543d4e67446f81936d44d1
2016-03-22 01:55:19 +00:00
Jenkins
98dc781e94 Merge "Remove superfluous variable assignment statements" 2016-03-21 21:33:06 +00:00
Jenkins
a48de855d0 Merge "Improve error for token issue command without auth" 2016-03-21 21:20:48 +00:00
Jenkins
59ffee26a6 Merge "Image API v2: make volume_type optional" 2016-03-21 21:20:25 +00:00
Kyrylo Romanenko
526f2f9f77 Remove superfluous variable assignment statements
wait and interval are already defaulted in the function signature

Change-Id: I66317a24f8327c464343ac13fc0126c34915eeda
2016-03-21 19:32:11 +00:00
Kyrylo Romanenko
0a65e8df70 Style fix for one line docstring according to flake8
Change-Id: I639819a5b1d8a476cdd8b340b8c339754f471048
2016-03-21 18:32:44 +02:00
reedip
8ecdc57ea6 Add "router remove port" to osc
This patch proposes the migration of port
deletion of Neutron's "router-interface-delete"
to OSC's "router remove port".

Change-Id: Ifceabce080aacac9f6410c809fcc097760e0c5ee
Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:08:16 +00:00
reedip
2e94f2803f Add "router add port" to osc
This patch proposes the migration of port addition of
Neutron's "router-interface-add" to OSC's "router add port".

Change-Id: I3a8a76d384caa32975f8e77f50f3cf3c3be13786
Closes-Bug: #1546849
Depends-On: I9783bc4ccceae3d361dce52d51483ef2187920a9
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:07:21 +00:00
OpenStack Proposal Bot
236e74d46f Updated from global requirements
Change-Id: Icaa101bded765c81774d73d84d552d41e40fec72
2016-03-20 15:47:37 +00:00
Nicolas Simonds
1d1c7a0631 Image API v2: make volume_type optional
It is perfectly valid for a Cinder volume to have a volume_type of
"none", so don't make the Image API v2 require that one be set.

Change-Id: I1a6da8d791fa0ae67cac46eec81bcbcb420729c3
Closes-Bug: #1559344
2016-03-18 16:08:30 -07:00
timothy-symanczyk
15edb2f61a Improve error for token issue command without auth
Currently when you perform the 'token issue' command with
the admin_token, the error is a nonsense python error. This
commit changes it to be user-friendly.

Change-Id: I5cc92c342e3f83e099354cd04301c7b8d8d2dabc
Closes-Bug: #1547721
2016-03-18 15:44:02 -07:00
Jenkins
f9f6abe564 Merge "Fix keypair create --public-key" 2016-03-18 20:55:57 +00:00
Jenkins
ad3af0ef69 Merge "Functional tests for openstackclient help messages" 2016-03-18 20:20:05 +00:00
Richard Theis
91eeacd89e Devref: Document OSC interfaces available to plugins
This devref documents the OSC interfaces are officially available
for plugins to implement commands and related unit tests. It also
covers requirements for plugins.

Change-Id: I68caa188e389e400fa9f5fd38f32c76cdd3e0986
2016-03-18 13:23:10 -05:00
Dean Troyer
21e414d860 Fix keypair create --public-key
Commit Id702ccaad239b916340bb17014d1ede0a28aaec9 changed the keypair
create --public-key to use io.open but incorrectly reads the file
in binary mode, which causes JSON serialization to fail.

The unit tests mock out io.ioen (the reason for adding it in the first
place actually) so any testing for this specific problem would have to
be done in functional tests...yet to come.

Closes-bug: 1559125
Change-Id: I7a299a542d9df543bff43d3ea1e7907fc8c5f640
2016-03-18 17:48:36 +00:00
Kyrylo Romanenko
89182c4825 Functional tests for openstackclient help messages
Add tests for list and description for Server commands:
 - Check server commands in main help message.
 - Check list of server-related commands only.
Commands:
  server add security group,
  server add volume,
  server create,
  server delete,
  server dump create,
  server image create,
  server list,
  server lock,
  server migrate,
  server pause,
  server reboot,
  server rebuild,
  server remove security group,
  server remove volume,
  server rescue,
  server resize,
  server resume,
  server set,
  server shelve,
  server show,
  server ssh,
  server start,
  server stop,
  server suspend,
  server unlock,
  server unpause,
  server unrescue,
  server unset,
  server unshelve.

Change-Id: Ib4bf9ab0264fb482d36cf5688c0f939bcd2cb6d8
2016-03-18 18:28:24 +02:00
reedip
3ccc4f7d06 Trivial-Fix : Add a ' to the choices documentation
Change-Id: Ic2023e91602fa23512bc5cc9c6a395f2311adb1a
2016-03-18 06:25:31 +00:00
Jenkins
1f72384f69 Merge "update docs with status of plugins" 2016-03-18 01:38:45 +00:00
Steve Martinelli
92aa981fa8 update docs with status of plugins
several other projects have joined the bandwagon, let's add them
to the list, these include:

python-ironic-inspector-client
python-muranoclient
python-senlinclient
python-tripleoclient
python-searchlightclient

Change-Id: I9165daf64bf817b9e12ee8fc27ce6e11ebe01e5e
2016-03-17 19:10:44 -04:00
Jenkins
d42bb4f7e2 Merge "Fix options in port create/set" 2016-03-17 22:58:36 +00:00
Dean Troyer
aeef568189 Fix options in port create/set
* --device-id should have been --device
* --host-id should have been --host

Old options are deprecated and retained for compatibility since they
appear in a release.

Closes-Bug: 1558677

Change-Id: Ic733523c8d57060f2cb5d420fdb1f7598e7d5e71
2016-03-17 21:00:26 +00:00
Jenkins
a60e31ad4b Merge "Add option to allow filtering by router on port list" 2016-03-17 06:05:34 +00:00
Jenkins
bc5b0846f8 Merge "[compute] Add set host command" 2016-03-17 03:06:12 +00:00
OpenStack Proposal Bot
f70d9b8768 Updated from global requirements
Change-Id: If9408d7057b7936427b4b6842318c583ebad828e
2016-03-16 19:20:30 +00:00
Jas
62a02466c3 Add option to allow filtering by router on port list
Added support to allow filtering ports via --router
option to list ports that are applicable to specific router.

Partial-bug: #1519909
Partially-implements: blueprint neutron-client

Change-Id: I6dd958603909f641735c821a62fc0d45afd5c7ec
2016-03-16 13:20:40 -05:00
root
9bafea555d Add support for deleting Image-property
OSC does not support to delete volume's image property.
This patch will provide support for deleting image property
to existing volume.

Closes-Bug:#1554879
Change-Id: I9256913948fae9e9a03fed173b826dfa918f78e9
Implements: bp cinder-command-support
2016-03-16 10:22:00 -04:00
root
4d5c5d9dcb Add support for setting Image-property
OSC does not support to set volume's image property.
This patch will provide support for adding image property
to existing volume.

Closes-Bug:#1554877

Implements: bp cinder-command-support

Change-Id: I4ff5532c228f010789b81c7587dd4a2838a90f20
2016-03-16 14:17:34 +00:00
Jenkins
d88284c86d Merge "Add project options to security group create" 2016-03-16 05:19:15 +00:00
Jenkins
add66dc132 Merge "Add incompatibility info for "ip floating list" command" 2016-03-16 05:18:57 +00:00
Jenkins
e49c3f6682 Merge "Sort commands in docs" 2016-03-14 22:27:53 +00:00
Jenkins
71796a0c4b Merge "Doc: Fix documentation errors for command object" 2016-03-14 21:11:23 +00:00
Dean Troyer
8c3138390a Sort commands in docs
No changes are intended other than sorting the sections...

* image add/remove project
* flavor set

Change-Id: I1ac240e12889227f2f470b9167904ce35609a227
2016-03-14 15:20:46 -05:00
Jenkins
006d34fc82 Merge "Support "--long" option in ListService" 2016-03-14 20:17:04 +00:00
Richard Theis
1f021427de Doc: Fix documentation errors for command object
Fix documentation errors impacting the "os ip floating",
"os subnet pool" and "os configuration show" commands.

Change-Id: Id033416df7ed06ef4b8a89e4f486fc9d546d9caf
2016-03-14 13:39:22 -05:00
Jenkins
9447a0e2c7 Merge "Add subnet functional tests" 2016-03-14 16:10:03 +00:00
Jenkins
bbdef271b7 Merge "Add "os subnet create" command using SDK" 2016-03-14 16:09:56 +00:00
Jenkins
2f6b48e039 Merge "Use assertItemsEqual() instead of assertListEqual()" 2016-03-14 16:09:49 +00:00
Jenkins
7449dae40a Merge "Fix dict.keys() compatibility for python 3" 2016-03-14 14:51:57 +00:00
Rui Chen
8664a2f8ae Support "--long" option in ListService
Add "--long" option in ListService so that compute service
disabled reason can be showed.

Change-Id: I1ace8f1c4e4efe0a1a8f6710425d73eb5db9e5e1
Closes-Bug: #1556815
2016-03-14 18:07:23 +08:00
Tang Chen
7b2e3c7d1c Use assertItemsEqual() instead of assertListEqual()
assertListEqual() is order sensitive. So we need to sort
the lists before we compare them. Use assertItemsEqual()
instead is better.

Change-Id: I9eaa98716c7401f5b099b007438acc916dae619b
2016-03-14 16:22:24 +08:00
Tang Chen
6abed7a471 Trivial: Add release note for "subnet pool create" command
Change-Id: I45c4304ca2100db9f0ef8f82ac69368f6798495d
Partial-Bug: #1544586
2016-03-14 14:49:17 +08:00
Jenkins
76081239d2 Merge "Add doc describing how to handle API errors" 2016-03-12 03:44:20 +00:00
Tang Chen
dc7e4fc15d Fix dict.keys() compatibility for python 3
In Python 2, dict.keys() will return a list.
But in Python 3, it will return an iterator.
So we need to fix all the places that assuming
dict.keys() is a list.

Change-Id: I8d1cc536377b3e5c644cfaa0892e40d0bd7c11b1
Closes-Bug: #1556350
2016-03-12 10:58:28 +08:00
Jenkins
586a038afd Merge "Fixed command list" 2016-03-11 20:48:32 +00:00
Dean Troyer
3d6b072111 Add doc describing how to handle API errors
Include the following scenarios:
* general external errors
* a command with multiple API calls

Change-Id: Ie5c4b775e11898bacf2156a34457f5397fd2c891
2016-03-11 13:35:41 -06:00
Richard Theis
a7c76878da Add project options to security group create
Add the --project and --project-domain options to the
'os security group create' command. These options are for Network v2
only.

Change-Id: I9e1667080a1a49389d51ade2e76a08b08a09870b
Closes-Bug: #1519511
Implements: blueprint neutron-client
2016-03-11 08:28:53 -06:00
Tang Chen
515cc87174 Add incompatibility info for "ip floating list" command
Commit d8abec33ad changed
the output of "ip floating list" command. But forgot to
add any backward incompatibility info.

Output of command "ip floating list" for nova network
has been changed. And it is different from the output
of neutron network.

This patch adds this incompatibility info.

Change-Id: I45858fda3b9bcc0bdf4d0891637fa7dd712872af
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-03-11 16:38:48 +08:00
Jenkins
3737c5a842 Merge "Trivial: Reorder classes in identity v3 in alphabetical order" 2016-03-11 05:44:01 +00:00
Jenkins
4856eb144a Merge "Enhance list extension unit test" 2016-03-11 04:50:26 +00:00
Jenkins
e0036756f6 Merge "Update reno for stable/mitaka" 2016-03-11 02:54:58 +00:00
Fang Zhen
4208f02a20 Enhance list extension unit test
Extension list involves identity, compute, volume and network.
Current test covers only identity and network. This patch added test
against compute and volum. Also refactored current implentation.

Change-Id: If9b36cba24c50a817a17f685801e418fb898596a
2016-03-11 10:39:15 +08:00
Tang Chen
2debde35ef Trivial: Reorder classes in identity v3 in alphabetical order
Change-Id: Iaf2e336c2415416ec69f6b974743c26509bba561
2016-03-11 10:02:25 +08:00
Jenkins
e3e2f38920 Merge "Refactor security group create to use SDK" 2016-03-11 01:33:57 +00:00
Jenkins
d4b71ea890 Merge "Refactor security group show to use SDK" 2016-03-11 01:33:50 +00:00
Doug Hellmann
ab9f80e9b9 Update reno for stable/mitaka
Change-Id: I4737774ee596bd3cf64c5deed3132afb1add3bcf
2016-03-10 23:01:40 +00:00
Brad Behle
71b8919054 Add "os subnet create" command using SDK
Implement the openstack client subnet create command using SDK
calls.

Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Partially implements: blueprint neutron-client
Closes-Bug: #1542364

Change-Id: Ia6120b8dccf2ee83dc89b3f496f7180d4dc5199a
2016-03-10 16:20:03 -06:00
Richard Theis
ea2dd8e141 Refactor security group create to use SDK
Refactored the 'os security group create' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2. The tenant_id column name was fixed to align
with the 'os security group show' command.

Change-Id: Ib29df42edcddcc73a123fff6a64743a6bfcb7fbf
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-10 10:18:52 -06:00
Richard Theis
564c8ff240 Refactor security group show to use SDK
Refactored the 'os security group show' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2. The column names remain unchanged to maintain
backwards compatibility.

Change-Id: I25233ddb8115d18b8b88affb3de13346084a339d
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-10 08:33:52 -06:00
Jenkins
4bb48c088d Merge "Add subnet pool functional tests" 2016-03-10 00:38:33 +00:00
Jenkins
c6e46aa8da Merge "[Subnet pool] Add 'subnet pool create' command support" 2016-03-10 00:38:27 +00:00
Jenkins
cf0f229cad Merge "[Subnet pool] Add 'subnet pool set' command support" 2016-03-10 00:38:09 +00:00
Richard Theis
87d90f3e53 Add subnet pool functional tests
Add functional tests for "os subnet pool" commands.

Change-Id: I51ffabcdb4d0f8608cc847aae298c8cbfd1f6a3d
Depends-On: I9150797c8cfa794d5264ad07965aa967d9a8f5bc
Depends-On: I65bd71e0f54f2f65acefbc542df67a1b1ec26397
Related-Bug: #1544586
Related-Bug: #1544587
Related-Bug: #1544589
Related-Bug: #1544590
Related-Bug: #1544591
Partially-Implements: blueprint neutron-client
2016-03-09 11:30:06 -06:00
Jenkins
f8ac17ac52 Merge "Trivial: Use 'SSH' rather than 'Ssh'" 2016-03-09 17:18:33 +00:00
Jenkins
1cef18427f Merge "Remove FakeFlavorResource class" 2016-03-09 17:18:26 +00:00
Jenkins
46f58dc173 Merge "remove py26 workaround in osc" 2016-03-09 16:40:46 +00:00
Jenkins
0713c03d47 Merge "Add port functional tests" 2016-03-09 16:39:55 +00:00
Brandon Palm
f0c3b4e69d Fixed command list
The cliff module expects an array of tuples however
the array that this function was returning was an array
of tuples that was also containing an array of values for
the commands attached to each group and the
cliff module wasn't liking it.

The output now comes out looking like:

| openstack.common | limits show |
|                  | extension list |
| openstack.baremetal.v1 | baremetal set |

Change-Id: Ifa1c149cb5c66ba27dc72bf72d7c8f2f50e42f73
Closes-Bug: 1545609
2016-03-09 16:00:39 +00:00
Stephen Finucane
13e2bb9b96 Trivial: Use 'SSH' rather than 'Ssh'
This is reflected in the '--help' screen.

Change-Id: Ic22a65ff6a56b069b37a0ea8365cce2b3f93621c
2016-03-09 14:55:55 +00:00
Jenkins
040d0c2e82 Merge "[Identity] Check return value is None in identity v3 unit tests" 2016-03-09 08:32:55 +00:00
Jenkins
c8e4a1407f Merge "Add --reason for disable service" 2016-03-09 07:12:51 +00:00
Tang Chen
237d7feca8 [Identity] Check return value is None in identity v3 unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I53eeb88316b2c20882fed97149d55cb04bcb2b2e
Closes-Bug: #1550636
2016-03-09 14:17:05 +08:00
jichenjc
b711c3a0ca Add --reason for disable service
disbale service allow a reason to be input as disable reason.
This patch add support for it.

Change-Id: I59622c3970e055ebd46bf03c33c864b6d064db28
2016-03-09 05:19:41 +00:00
Tang Chen
81930abdcb Remove FakeFlavorResource class
In unit tests, all real methods are faked. They should not
do any real operations in the tests. So, FakeFlavorResource
is not necessary. Just fake get_keys(), set_keys and unset_keys()
in FakeResource would be enough.

Change-Id: Icc3473ba9c77f4817d0edddb7ff3e1bd2946fac7
2016-03-09 10:26:15 +08:00
Xi Yang
189e4774f8 Add support of setting snapshot state
This patch is going to add the functionality of
setting snapshot state which OSC currently lacks.

Closes-Bug:#1535239
Change-Id: I2afd6567416e75ba0c70b73351cf1eb5394b3373
2016-03-09 00:13:55 +08:00
Richard Theis
9fcbd0ad4b Add port functional tests
Add functional tests for "os port" commands.

Change-Id: I162eff6abacd9ffdde369647491ae472b604c692
Depends-On: I2bea508e11290284aa64b1ab548a0bb61e7290d3
Partial-Bug: #1519909
Partially-Implements: blueprint neutron-client
2016-03-08 10:02:17 -06:00
Jas
e0d58641bb Add 'port set' command
Add CLI support for the 'port set' command

Change-Id: I2bea508e11290284aa64b1ab548a0bb61e7290d3
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-08 09:48:50 -06:00
Jenkins
9ab7740dfd Merge "Trivial: Fix incorrect comments in compute fakes.py" 2016-03-08 15:15:41 +00:00
Tang Chen
3d741d3757 [Subnet pool] Add 'subnet pool create' command support
This patch supports creating a new subnet pool,
with pool prefixes, default prefix length, minimum
prefix length, and maximum prefix length specified.

Change-Id: I9150797c8cfa794d5264ad07965aa967d9a8f5bc
Partial-Bug: #1544586
Related-to: blueprint neutron-client
2016-03-08 21:22:13 +08:00
Tang Chen
f2fb007e82 [Subnet pool] Add 'subnet pool set' command support
This patch supports setting a new name, pool prefix,
default prefix length, minimum prefix length,
and maximum prefix length for a subnet pool.

Change-Id: I65bd71e0f54f2f65acefbc542df67a1b1ec26397
Partial-Bug: #1544591
Related-to: blueprint neutron-client
2016-03-08 21:22:13 +08:00
Tang Chen
11c253ca19 Trivial: Fix incorrect comments in compute fakes.py
Change-Id: I18b1720af13b444527dda1ecab52e3cc8d8d9376
2016-03-08 20:48:58 +08:00
Steve Martinelli
3ed5d232bb remove py26 workaround in osc
we don't support py2.6, so let's remove the workarounds we have.

Change-Id: Id9c8fda065d4aceba3192b044b5c5f2124ee204f
2016-03-08 12:41:17 +00:00
Tang Chen
762c4c9bdf [Identity] Check return value is None in identity v3 unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
2016-03-08 15:58:25 +08:00
Jenkins
752705ae30 Merge "Add port list command" 2016-03-08 03:04:28 +00:00
Jas
d548942645 Add port list command
This patch adds the ability to list all created ports

Change-Id: Ie1a48c203cabc96346a4950f21b83493d58a66a5
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-07 11:17:31 -06:00
Jenkins
13a6857142 Merge "Use _get_columns() to obtain columns in network.py" 2016-03-07 16:05:01 +00:00
Jenkins
dcc27fd5d3 Merge "Test take_action() instead of run() in unit tests" 2016-03-07 16:01:17 +00:00
Tang Chen
fc24f37ae2 Trivial: Remove useless return
If a function returns nothing, do not add return in the end.

Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
2016-03-07 17:54:06 +08:00
Jenkins
8787ad2b49 Merge "Add release note for security group set refactor" 2016-03-06 09:26:14 +00:00
Jenkins
67969e438c Merge "" openstack server image create " doesn't print proper info" 2016-03-06 08:33:44 +00:00
Tang Chen
7ba73845c1 Use _get_columns() to obtain columns in network.py
Objects returned by Network v2 and Compute v2 are different.
When getting columns to display, Network v2 uses obj.keys(),
while Compute v2 uses obj._info.keys(). But both of them could
obtain the keys of the object by _get_columns().

Change-Id: I347815f2d28822a95bd6f57d429b84b7ca96e0ee
2016-03-06 09:01:42 +08:00
Richard Theis
46e86e5a4a Add release note for security group set refactor
Add a release note for [1].

[1] https://review.openstack.org/#/c/287763/

Change-Id: I30812c3ead477267dc7e3dc774c09b3435152eb9
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-05 10:18:35 -06:00
Jenkins
0b2c4b1f32 Merge "Refactor security group set to use SDK" 2016-03-05 16:08:20 +00:00
Tang Chen
eb1574281b Test take_action() instead of run() in unit tests
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
2016-03-05 17:12:42 +08:00
Jenkins
fa3a34322c Merge "[compute] Support restore server" 2016-03-04 23:41:42 +00:00
Jenkins
a61c5cc8a4 Merge "Add 'port create' command" 2016-03-04 23:39:22 +00:00
Jenkins
5c1633f505 Merge "[compute] Add unit test for keypair" 2016-03-04 23:39:16 +00:00
OpenStack Proposal Bot
3ede46d4d0 Updated from global requirements
Change-Id: Ife3956a1109ffa2faf367953cc13b8cb5f64e5c2
2016-03-04 19:42:17 +00:00
Jenkins
0bf65361f5 Merge "[Volume] Check return value is None in volume unit tests" 2016-03-04 17:55:26 +00:00
Jas
d1d4a40808 Add 'port create' command
This patch adds usage of 'port create' in CLI

Change-Id: I888af50784c3b6c7ec30552ade79f05a5e974711
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-04 10:41:26 -06:00
Richard Theis
bf2dbf3256 Add subnet functional tests
Add functional tests for "os subnet" commands.

Change-Id: Ie80763334f2fb4099b3e549256576d71cc213c07
Depends-On: Ia6120b8dccf2ee83dc89b3f496f7180d4dc5199a
Related-Bug: #1523258
Related-Bug: #1542359
Related-Bug: #1542362
Related-Bug: #1542364
Related-Bug: #1542363
Partially-Implements: blueprint neutron-client
2016-03-04 08:12:01 -06:00
OpenStack Proposal Bot
6a96ffc221 Updated from global requirements
Change-Id: I8bfe67141572a0bf406959dea83eaf1f2c30b890
2016-03-04 10:21:02 +00:00
Jenkins
d763acdf1c Merge "Add test cases to test some commands with '--wait' and fix bug" 2016-03-04 01:29:56 +00:00
OpenStack Proposal Bot
2d3ded5e9d Updated from global requirements
Change-Id: I49cfc47d791d890941dc199bd0d5fa0205b1f1ca
2016-03-03 23:16:04 +00:00
Jenkins
5e11d24df8 Merge "Fix incorrect unit test for router" 2016-03-03 22:34:47 +00:00
Mohan Muppidi
e354d17d2c " openstack server image create " doesn't print proper info
After creating a snapshot of a running instance, a print out similar
to server create is expected, but it prints out something like "_info"
which is nothing related to created image. _prep_image_detail method
is added to /compute/v2/server.py to enable the priting, while running
the test properly.

Change-Id: I4b06be959768bcdaafd9aa8df497490958bee649
Closes-Bug:1551586
2016-03-03 21:03:14 +00:00
Richard Theis
8cf28a34ab Fix test_aggregate functional test
Nova API validation changes [1] appear to have broken the
'os aggregate create' and 'nova aggregate-create' commands when
an availability zone name is not specified. This patch set updates
the test_aggregate functional test to set the availability zone
name in order to unblock the osc gate while nova investigates
the issue.

[1] https://review.openstack.org/#/c/281143/

Change-Id: I00b497be61c4bc4bc467c66c1e49b2e0636ab841
Related-Bug: #1541691
2016-03-03 12:32:09 -06:00
Tang Chen
b58dd4f17f [Volume] Check return value is None in volume unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: Idd961a5fa3db825353700837a559621d17f782c5
Partial-Bug: #1550636
2016-03-03 21:07:08 +08:00
Tang Chen
50443127c5 Fix incorrect unit test for router
Command "router show" will display router's "tenant_id" as
"project_id". But in the unit test, it checks "tenant_id",
which is incorrect.

This patch fix this problem, and add a _get_columns() helper
function to simplify the code.

Change-Id: I0087ef7dfd0130b6c47222495848c4f2b9804b1b
2016-03-03 20:50:17 +08:00
Richard Theis
bac9fb18c1 Refactor security group set to use SDK
Refactored the 'os security group set' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

This patch set also fixes a compute bug which ignores name
and description when set to an empty value.

Change-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-03 06:33:15 -06:00
Jenkins
977eb4f1a6 Merge "Trivial: Reorder unit tests in alphabetical order in volume tests" 2016-03-03 05:00:36 +00:00
OpenStack Proposal Bot
4ab66631d0 Updated from global requirements
Change-Id: Icc45c24eebbdd524254dc3200b016fe75b621b15
2016-03-02 19:23:53 +00:00
Jenkins
fc8b4cfcae Merge "[Image] Check return value is None in image unit tests." 2016-03-02 17:25:19 +00:00
Tang Chen
f2ef9f2044 Trivial: Reorder unit tests in alphabetical order in volume tests
Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
2016-03-02 16:48:16 +08:00
Tang Chen
fd53a4980f [Image] Check return value is None in image unit tests.
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.

Change-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c
Partial-Bug: #1550636
2016-03-02 16:16:37 +08:00
Tang Chen
359dfa1a06 Support "network create" command in nova network
This patch only provide network name and subnet setting for
"network create" command.

The other options, such as --project which depends on
identity v2 or v3, will make the unit tests too complicated.
So I prefer to implement them in other patches.

Change-Id: I9ec93f0af813c8fae4170c36e16bbe8f0f53cbb6
Partial-Bug: 1543672
2016-03-02 14:39:00 +08:00
ting.wang
84942bb11c Add test cases to test some commands with '--wait' and fix bug
"server image create"
"server rebuild"
"server resize"
Above 3 commands are not covered by unit test.
So add some unit tests.

Meanwhile, fix bug. Now that image name is an optional argument,
we'd better record error messages with positional arguments
instead of optional argument. So, record server name.

Change-Id: I41bc025d4824dc46f63a3213d82e1528bacbbe12
2016-03-02 09:32:27 +08:00
Jenkins
f9add0559c Merge "Devref: Options with Choices" 2016-03-01 23:51:21 +00:00
Jenkins
77f2e98466 Merge "Clean up unnecessary import of urlparse module" 2016-03-01 23:51:00 +00:00
Jenkins
594d98431c Merge "Fix regression in interactive client mode" 2016-03-01 16:13:42 +00:00
Richard Theis
fbe5dc657b Devref: Options with Choices
Add a developer reference for options with choices. This patch set
also includes RST doc formatting fixes.

Change-Id: I5fd6a699806edf1d2d95110f0b8a2b8a385028ab
2016-03-01 09:31:43 -06:00
Jenkins
15d3b6f317 Merge "Fix 'code-block' tag format issues" 2016-03-01 15:17:21 +00:00
Jenkins
2ae7072ea6 Merge "Trivial: Update image_list v2 docs" 2016-03-01 15:03:28 +00:00
Yang Hongyang
059f54eee4 Clean up unnecessary import of urlparse module
six.moves.urllib already covers the py2 and py3 compatibility issues
of urlparse module, use six.moves.urllib.parse.urlparse is enough.

Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
2016-03-01 22:06:53 +08:00
Jenkins
31ff21c511 Merge "add a checklist for creating a new plugin" 2016-03-01 13:16:21 +00:00
Yang Hongyang
8b17a1fa5b Trivial: Update image_list v2 docs
This api doc is clearly copied from v1, we should update it to reflact v2 API.
Added 'shared' param description.

Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
2016-03-01 18:48:09 +08:00
Dina Belova
8a839ad8b8 Fix regression in interactive client mode
Fix typo introduced in OSprofiler intergation commit, that
leaded to non-working interactive mode of the CLI client.

Change-Id: If5dfc90dbbe64d4665c3e33e936f0cc674738351
Closes-Bug: 1551160
2016-03-01 13:45:19 +03:00
Jenkins
11490b79f4 Merge "TrivialOrder: Rearrange Class Names" 2016-03-01 10:09:07 +00:00
Rui Chen
c832e2a771 Fix 'code-block' tag format issues
Modify 'code-block' tag format so that the following python code
could be showed exactly, and reformat the more than 79 chars of lines.

Change-Id: Ic6721e4cc8f4c7a3e4a7c7dbd63d9089180cdc33
2016-03-01 08:48:47 +00:00
Jenkins
fa998d641d Merge "Fix return value of "image set" command" 2016-03-01 08:29:33 +00:00
Jenkins
d91e104670 Merge "Make SetAggregate inherit from cliff.Command" 2016-03-01 08:29:04 +00:00
Jenkins
53812170fe Merge "Trivial: Reorder flavor op order in flavor.py" 2016-03-01 07:40:48 +00:00
Jenkins
2ecbb738ef Merge "Refactor security group list to use SDK" 2016-03-01 07:18:10 +00:00
reedip
a1f2f4af58 TrivialOrder: Rearrange Class Names
As per the comment given by Steve Martinelli in
https://review.openstack.org/#/c/278209/ , the
following patch just rearranges the classes
as per the Alphabetical order.

TrivialFix

Change-Id: Ib8f0f703df4ef7d7ee6180ff8bd8a47062ae5b0f
2016-03-01 16:11:51 +09:00
Jenkins
0dfc50ea1c Merge "fix: Exception message includes unnecessary class args" 2016-03-01 07:03:17 +00:00
Jenkins
1299319b76 Merge "Subnet: Add "subnet delete" command using SDK" 2016-03-01 07:03:10 +00:00
Steve Martinelli
3f95e2dd05 add a checklist for creating a new plugin
includes steps for both infra and osc changes.

Change-Id: I35ae2eb29cff87f5c971e64badd2927fc9a59bf4
2016-03-01 06:06:59 +00:00
Jenkins
7039cd3447 Merge "Make SetAgent inherit from cliff.Command" 2016-03-01 04:30:34 +00:00
Jenkins
3af46b1308 Merge "Trivial: Reorder unit tests in test_type.py" 2016-03-01 03:41:01 +00:00
Yang Hongyang
37c0e57d11 Trivial: Reorder flavor op order in flavor.py
Classes should be in alphabetical order.

Change-Id: I7a35c3a2dd6d36c49f0d54dec5c14609a9168bd0
2016-03-01 11:21:47 +08:00
reedip
88c92bf71a Subnet: Add "subnet delete" command using SDK
This patch adds "subnet delete" command to osc using sdk.

Change-Id: I6be27406b16909c6db2b95417355be302e218a8d
Implements: blueprint neutron-client
Closes-bug: #1542362
2016-03-01 11:26:27 +09:00
Jenkins
3372de6f3b Merge "take_action() method from command.Command shouldn't return" 2016-02-29 23:28:40 +00:00
Jas
b8d72cee27 fix: Exception message includes unnecessary class args
Fix misusages of ArgumentTypeError which causes a tuple of
class instance and error message string to be printed rather than just the
error message string itsself.

Change-Id: I0e997f86bb6603930cc92e90efcb48155f62ffb5
Closes-bug: #1551426
2016-02-29 16:06:05 -06:00
Richard Theis
842882f3cb Refactor security group list to use SDK
Refactored the 'os security group list' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

This refactor also removes the logic for displaying project names
instead of project IDs when the --all-projects option is specified.
This logic was removed because it is inconsistent with the other
network commands.

Since neutron will always display security groups across all
projects for an admin, the --all-projects option is now hidden
when neutron is enabled and the Project column is always
displayed.

Change-Id: I934a1f5084ef3c5f929d0ffd38ebf5064d799941
Partial-Bug: #1519511
Related-to: blueprint neutron-client
2016-02-29 14:46:57 -06:00
Jenkins
5310cfb8b7 Merge "Make SetSecurityGroup inherit from cliff.Command" 2016-02-29 18:38:38 +00:00
Jenkins
8a3fc6c343 Merge "Make SetFlavor and UnsetFlavor inherit from cliff.Command" 2016-02-29 18:37:44 +00:00
Jenkins
60345b7933 Merge "[Compute] Check return value is None in compute unit tests." 2016-02-29 18:37:36 +00:00
Mohan Muppidi
3d7430463c take_action() method from command.Command shouldn't return
command.Command and command.Showone are base classes implemented
in cliff framework. Showone extends Command to allow take_action()
to return data to be formatted using a user-selectable formatter.
Most of the classes which are extended from Command in
openstackclient/identity/v3/ in some cases return data or return
nothing where it is not necessary, this commit fixes most of them.

Change-Id: I84c72ea4d6680f8bdbef5449316dd9a8af8c8286
Closes-Bug: 1550892
2016-02-29 17:23:29 +00:00
Tang Chen
a253217fc2 Trivial: Reorder unit tests in test_type.py
Unit test classes should be in alphabetical order.

Change-Id: Ie741e1c170d8cc361d95d036115d0952e5108088
2016-02-29 16:58:14 +08:00
Tang Chen
61c1d985c7 Fix return value of "image set" command
"image set" command should return None. But in one path,
it returns ({}, {}). This patch fixes this.

Change-Id: I3847e661cb7e89863921a3f0a859d9b1a8077ede
2016-02-29 16:18:55 +08:00
Tang Chen
058232b999 [Compute] Check return value is None in compute unit tests.
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.

Change-Id: I953480ecff3b5beb12255d866d0e1df45f130efd
Partial-Bug: #1550636
2016-02-27 15:38:04 +08:00
Tang Chen
01c19ef0bc Router: Add --route and --clear-routes options to "router set" command
--route option is used to set routes to the router.

It is used like this:

    --route destination=subnet,gateway=ip-address

destination: destination subnet CIDR
gateway: nexthop IP address

--clear-routes is used to clear all routes on the router.

Change-Id: I97ce4871113c684b29c98cdad4dec9cc80ed20f7
Implements: blueprint neutron-client
Partial-bug: #1519503
2016-02-27 04:53:10 +08:00
Tang Chen
ada06f4dc3 Add MultiKeyValueAction to custom parser action
Class MultiKeyValueAction will be used to parse arguments like this:

--route destination=xxx,gateway=xxx --route destination=yyy,gateway=yyy

The result is a list like this:

[{destination:xxx, gateway:xxx}, {destination:yyy, gateway:yyy}]

This action also contain validation of the parameters.

Change-Id: Ie3aa8635c6a13fc2e429fe6922acd681dc7244cf
2016-02-27 03:53:32 +08:00
Tang Chen
ba826fa04f Make SetAggregate inherit from cliff.Command
set/unset comamnd classes should inherit from cliff.Command class.

Also, this patch adds functional tests for aggregate.

And also, use utils.format_dict() to format the output of the
properties dict.

Change-Id: Idb50bef8990da95666960e2414dfd7c9be234bba
Partial-bug: #1519503
Closes-Bug: 1546065
2016-02-27 03:50:47 +08:00
Jenkins
2819450be5 Merge "Add shell --profile option to trigger osprofiler from CLI" 2016-02-26 19:49:21 +00:00
Tang Chen
9c91c1df41 Make SetAgent inherit from cliff.Command
set/unset command classes should inherit from cliff.Command class.

Also, this patch adds functional tests for compute agent.

Change-Id: I25eafffd1167f82aa0d430628c22dee7516b1e19
Partial-Bug: 1546065
2016-02-27 03:48:11 +08:00
Tang Chen
859bfaf875 Make SetSecurityGroup inherit from cliff.Command
set/unset comamnd classes should inherit from cliff.Command class.

Change-Id: Ie28711ac8823dc9eb13cf83877864ca436b928bc
Partial-Bug: 1546065
2016-02-27 03:47:57 +08:00
Tang Chen
f37eda3a27 Make SetFlavor and UnsetFlavor inherit from cliff.Command
set/unset comamnd classes should inherit from cliff.Command class.

Change-Id: I54e5608ac0768d7d94b7f7d516ea1948daefdc1b
Partial-Bug: 1546065
2016-02-27 03:46:30 +08:00
Jenkins
b5b5fdd78a Merge "Add missing command/configuration object" 2016-02-26 10:37:45 +00:00
Rui Chen
b733ecf3dd Add missing command/configuration object
Add missing 'command' and 'configuration' object into
command object list, add command, module, host commands
describe in command-objects, and add 'mask' and 'unmask'
options in configuration command details, fix some format
issues by the way.

Change-Id: Iea80c7b1e413e02e49b9090b9d3cb9c59aab4c38
2016-02-26 15:20:44 +08:00
OpenStack Proposal Bot
45d6c1fb1f Updated from global requirements
Change-Id: I582644850642651c61d259e4a53f670b421dce95
2016-02-26 02:01:44 +00:00
Jenkins
277c16c8b7 Merge "Defaults are ignored with flake8" 2016-02-26 01:59:47 +00:00
Jenkins
fbc03104f6 Merge "Floating IP: Neutron support for "ip floating show" command" 2016-02-25 21:15:47 +00:00
jichenjc
ff3a1d3780 [compute] Add set host command
set host command is missing, add it as SetHost class.

Change-Id: I7acb94150718b7150598632cbebc3d85018a0d59
2016-02-26 05:05:46 +08:00
Jenkins
6176e802b3 Merge "Fixed a bunch of spacing" 2016-02-25 20:54:25 +00:00
Dina Belova
16f00833a7 Add shell --profile option to trigger osprofiler from CLI
This will allow to trigger profiling of various services that
allow it currently and which APIs support is added to openstackclient.
Cinder and Glance have osprofiler support already, Nova and Keystone
are in progress.

To use this functionality osprofiler (and its storage backend) needs
to be installed in the environment. If so, you will be able to trigger
profiling via the following command, for example:

$ openstack --profile SECRET_KEY user list

At the end of output there will be message with <trace_id>, and
to plot nice HTML graphs the following command should be used:

$ osprofiler trace show <trace_id> --html --out result.html

Related Keystone change: https://review.openstack.org/#/c/103368/
Related Nova change: https://review.openstack.org/#/c/254703/

The similar change to the keystoneclient
(https://review.openstack.org/#/c/255308/) was abandoned as new
CLI extenstions are not more accepted to python-keystoneclient.

Change-Id: I3d6ac613e5da70619d0a4781e5d066fde073b407
2016-02-25 20:13:27 +00:00
Jenkins
43957d602b Merge "Add python-searchlightclient to list of adopters." 2016-02-25 19:49:00 +00:00
Jenkins
caad923f89 Merge "update heat object and command doc" 2016-02-25 17:14:23 +00:00
Jenkins
5ff47b8ccf Merge "Add some test cases for "server list" command" 2016-02-25 14:39:34 +00:00
Mark Vanderwiel
69d5bc4e55 update heat object and command doc
Many OpenStack client heat command patches are in progress, seems like
good time to also update some of the highlevel doc.

Added new objects for orchestration and software
   openstack orchestration resource type list/show
   openstack software config create/delete/show/list
Added new action for restore
   openstack stack snapshot create/delete/list/show/restore
Added link to CLI reference for complete plugin syntax and
   details
Removed deprecated tasker client

Change-Id: I2c94a5981954edcba95f364a0f909c799f1c403b
Blueprint: heat-support-python-openstackclient
2016-02-25 00:48:15 +00:00
Jenkins
ad93e9f933 Merge "Improve tox to show coverage report on same window" 2016-02-24 14:12:28 +00:00
ting.wang
e0b6cab09b Add some test cases for "server list" command
Add some test cases that test 'server list' command when specifying flavor or image.
Because I add some attribution to fake.py, I have to change some code
in create server test. Despite all this, I think it's good for testing.

Change-Id: I714deac1f6f940b790a3c20af5f7ffa724ac44d1
2016-02-24 18:57:02 +08:00
Tang Chen
f0960f0fef Floating IP: Neutron support for "ip floating show" command
Change-Id: I30350076621c83c758927444e5f8bcc2b7d0fc74
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-02-24 17:26:13 +08:00
Jenkins
e5fe9a7071 Merge "Refactor network AZ exception handling" 2016-02-24 06:20:57 +00:00
Jenkins
1c20e502b8 Merge "Py3 replace dict.iteritems with six.iteritems" 2016-02-24 06:15:09 +00:00
ting.wang
3e08590600 Improve tox to show coverage report on same window
With this patch coverage report will be shown with the results when
tox -e cover will be run.

Change-Id: I96713a8dd5d82019631c9e48c1abd7a94e201569
2016-02-24 10:44:06 +08:00
ting.wang
e47c83d47a Py3 replace dict.iteritems with six.iteritems
All dict.iteritems in osc are replaced with six.iteritems
except this one.
So fix it to add py3 compatibility.

Change-Id: I1aa51399a36e650d262d839ce2b4ec04d3f91db2
2016-02-24 10:14:56 +08:00
OpenStack Proposal Bot
198371b0b7 Updated from global requirements
Change-Id: Ib681d0b07afdde821ab4f9a17b1333bd12739eec
2016-02-24 01:39:41 +00:00
Jenkins
58be3bcf79 Merge "Use update_parser_common() in ShowNetwork" 2016-02-23 19:53:13 +00:00
Jenkins
c2f5945ef6 Merge "Add "security group rule show" command" 2016-02-23 18:02:56 +00:00
Tom Cocozzello
3d7a26bdec Defaults are ignored with flake8
If “ignore” is not set under flake8 in the tox.ini
file there there are defaults set to be ignored.

The depended patch fixes many of the problems.

Change-Id: Ieed2fe1c4654e201d3fe6d40ef93e247ee736f8b
Doc: http://flake8.readthedocs.org/en/latest/config.html#default
Depends-On: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
Closes-Bug: #1548910
2016-02-23 11:08:36 -06:00
Brandon Palm
f49f0fead2 Fixed a bunch of spacing
Nothing too complicated here.  I fixed a bunch of spacing issues
that I saw in OSC.

Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
2016-02-23 10:38:58 -06:00
Richard Theis
dccde70c57 Add "security group rule show" command
Add the "os security group rule show" command which will use
the SDK when neutron is enabled, and use the nova client when
nova network is enabled.

Change-Id: I41efaa4468ec15e4e86d74144cc72edc25a29024
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-02-23 15:27:06 +00:00
Tang Chen
ab40add0c6 Fix wrong return value in TestDeleteFloatingIPNetwork
delete_ip() should return None, not the fake floating IP.

Change-Id: I1476189a09a94c76c90f9a3986e3ae57dc66d796
2016-02-23 20:19:14 +08:00
Tang Chen
07242fca3b Use update_parser_common() in ShowNetwork
ShowNetwork inherits from NetworkAndComputeCommand. So we should use
update_parser_common() in it, not overwrite parent's get_parser().

Change-Id: I21bb1407962344b9800fd31caee4b2582674fe24
2016-02-23 19:00:14 +08:00
Jenkins
02e5b6f41d Merge "Use instanceof instead of type" 2016-02-23 08:50:24 +00:00
jichenjc
6902a288f8 [compute] Support restore server
Server in soft-delete state can be restored, add this command.

Change-Id: Id9d7246f89ae65273505f36dcb664996534ae986
2016-02-23 13:43:37 +08:00
jichenjc
042e2b7d53 [compute] Add unit test for keypair
keypair do not have unit test, this patch adds it.

Change-Id: Id702ccaad239b916340bb17014d1ede0a28aaec9
2016-02-23 12:23:10 +08:00
Jenkins
db4d73d8c8 Merge "Add functional tests for "volume" commands v2" 2016-02-23 02:49:57 +00:00
Jenkins
37f96c2c47 Merge "Add unit tests for 'hypervisor stats' command" 2016-02-23 00:59:08 +00:00
Jenkins
7c9bb377c1 Merge "Add "os subnet show" command using SDK" 2016-02-23 00:13:44 +00:00
Brandon Palm
11a8f911af Use instanceof instead of type
Adjusted conditional statements to use instanceof when
comparing variables. Instanceof supports inheritance type
checking better than type.

Change-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c
Closes-Bug: 1548530
2016-02-22 16:23:23 -06:00
Brad Behle
112d7b0e09 Add "os subnet show" command using SDK
Implement the openstack client subnet show command using SDK
calls.  This shows the details of a specific subnet.

Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Partially implements: blueprint neutron-client
Closes-Bug: #1542359

Change-Id: Iaf18b9e44af35ca0cd61033b468e0c60cd3b05d6
2016-02-22 13:04:25 -06:00
Tang Chen
c57fc41c33 Initialize _keys in __init__() in FakeFlavorResource
_keys is defined as a class attribute in FakeFlavorResource. So when
we call set_keys() to update it, it changes. And this change may bring
trouble to the other tests afterward.

So define and initialize it in __init__() as an object attribute.

Change-Id: Ib18c03877b67e1b7c2e107f598076b928a58e4fb
Closes-bug: #1548378
2016-02-23 00:14:56 +08:00
ting.wang
8825f0d8f3 Add unit tests for 'hypervisor stats' command
'hypervisor stats show' command isn't covered by unit tests,
so add unit tests to test it.

Change-Id: Ic355230cbdd596e848191b599803dca7f27c2ffb
2016-02-22 23:36:29 +08:00
Jenkins
ba08683d90 Merge "Add unit test for "flavor show" command" 2016-02-22 03:24:56 +00:00
Jenkins
ac53fc5eb6 Merge "gitignore .idea" 2016-02-22 01:42:51 +00:00
Jenkins
a121361bac Merge "Add functional tests for "image" command v2" 2016-02-22 01:24:26 +00:00
Jenkins
b503734de0 Merge "Clean redundant argument to dict.get" 2016-02-22 01:24:20 +00:00
Jenkins
30e2643d23 Merge "Refactor: Set "project_id" for FakeXXX in a consistent style" 2016-02-21 06:16:55 +00:00
ting.wang
e2158b7ef4 Clean redundant argument to dict.get
`dict.get()` returns `None` by default, if a key wasn't found.
Removing `None` as second argument to avoid redundancy.

Change-Id: Ia82f7469cd019509bbeccbfe54b15eeedc7bb6ea
2016-02-21 13:21:31 +08:00
Jenkins
867bcb0db8 Merge "Support unscoped token request" 2016-02-21 04:31:51 +00:00
Jenkins
f4ca06cad6 Merge "Fix Mutable default argument" 2016-02-21 01:31:34 +00:00
Tang Chen
acc0297fa6 Add functional tests for "volume" commands v2
The tests for v2 "volume" commands are quite similar to v1.

This patch also map 'metadata' to 'properties', 'volume_type' to 'type'
to align to the v1 output.

Change-Id: Icf2c5463b186fc78c890ccd96453090c4a2c2eb6
Partial-bug: #1519503
2016-02-21 09:10:15 +08:00
Tang Chen
86cae7e170 Add functional tests for "image" command v2
The tests for image v2 are quite similar to the tests for v1.
The only difference things are:
1. v2 "image set" command only allows to change the disk format
   for a queued image
2. v2 "image show" command output is different from v1

Change-Id: Ieb6bec7467887aab567743153ea3181afa49537d
2016-02-21 08:25:27 +08:00
OpenStack Proposal Bot
097d35e130 Updated from global requirements
Change-Id: I387ac9f75fd542ade62869efaf173a4f8d769fe1
2016-02-20 22:00:37 +00:00
Jenkins
d01525f5e5 Merge "Trivial: Rename subnet_pool.rst to subnet-pool.rst" 2016-02-20 13:09:15 +00:00
Tang Chen
b4edbd55f2 Add unit test for "flavor show" command
Change-Id: I1591649e5b97a885707042fcccad3335ee8c7aec
2016-02-20 17:16:01 +08:00
Tang Chen
6af2883885 Refactor: Set "project_id" for FakeXXX in a consistent style
OpenStack SDK will translate "project_id" into "tenant_id" automatically
when referring to "tenant_id" attribute with the name "project_id". So
when faking an object returned fron SDK, we need to fake this behavior.

The original way is ugly. This patch turns it into a consistent style,
and give better comments.

Change-Id: I0dfb1f7552fc28eb4e7ebf5c614c9f3bde79ad80
2016-02-20 16:39:06 +08:00
ting.wang
dc5a8faddd Fix Mutable default argument
Python’s default arguments are evaluated once when the function is defined,
not each time the function is called. This means that if you use a mutable
default argument (like list and dict) and mutate it, you will and have mutated
that object for all future calls to the function as well.

more details about this wrong usage here:
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments

Change-Id: If187f16bfb305ac4fe6e4177e498a06c49c3f946
2016-02-20 16:35:11 +08:00
ting.wang
eb6da5f0ba gitignore .idea
Directory .idea  is produces by pycharm.
We'd better ignore it.

Change-Id: Ia3cbca09398caeb88dd66f89adcd0fcfff8dac4c
2016-02-20 16:25:56 +08:00
Tang Chen
53e058fabc Trivial: Rename subnet_pool.rst to subnet-pool.rst
File names under doc/source/command-objects/ are words connected
with "-". So rename subnet_pool.rst to subnet-pool.rst to keep
the consistence.

Also use "display" instead of "show" in the comment to keep the
consistence.

Change-Id: If486f6cec34b4572a8245af865267b063c1e877d
2016-02-20 15:05:59 +08:00
ting.wang
5a978b9ec1 Replace string format arguments with function parameters
There are files containing string format arguments inside logging messages.
Using logging function parameters should be preferred.

Change-Id: I15b405bf4d4715263fe1e1262982467b3d4bc1f4
Closes-Bug: #1321274
2016-02-20 14:16:25 +08:00
guang-yee
41e1bd0be6 Support unscoped token request
Make scope check optional for the "token issue" command as unscoped token is
a valid Keystone V2/V3 API.

Change-Id: Ie1cded4dbfdafd3a78c0ebdf89e3f66762509930
Closes-Bug: #1543214
2016-02-19 16:07:13 -08:00
Jenkins
ab6ba385a2 Merge "Subnet Pool: Add "subnet pool show" command" 2016-02-19 18:17:00 +00:00
Jenkins
0a8137f773 Merge "Don't use Mock.called_once_with that does not exist" 2016-02-19 17:44:56 +00:00
Jenkins
20f86465af Merge "Use assertIsNone() instead of assertEqual(None, xxx)" 2016-02-19 16:13:40 +00:00
Jenkins
61d9604f8a Merge "Subnet Pool: Add "subnet pool list" command" 2016-02-19 15:55:29 +00:00
Tang Chen
ef64a8b47d Use assertIsNone() instead of assertEqual(None, xxx)
Change-Id: Ibbd7d6d27b2ff20304e3121fbadd5d50c1836d9b
2016-02-19 17:14:08 +08:00
Tang Chen
48681af86a Don't use Mock.called_once_with that does not exist
Class mock.Mock does not exist method "called_once_with()", it just
exists method "assert_called_once_with()". "called_once_with()" does
nothing because it's a mock object.

In OSC, only one place is still using "called_once_with()". Fix it.

Change-Id: Ib890e95d775c3fc43df80fa05c82d726e78cdac8
Partial Bug: 1544522
2016-02-19 13:44:54 +08:00
Tang Chen
ca34aa1587 Floating IP: Fix "ip floating list" in neutron network
The implementation of "ip floating list" in the commit below
is incorrect:

    Change-Id: I253f66f6bc64470e1a18ffea506048eb53f67d5c

This is because the FloatingIP objects returned from Nova and
Neutron network are different. They need different handling.

This patch fixes this problem.

The output for Neutron network would be:

+--------------------------------------+---------------------+------------------+------+
| ID                                   | Floating IP Address | Fixed IP Address | Port |
+--------------------------------------+---------------------+------------------+------+
| 1976df86-e66a-4f96-81bd-c6ffee6407f1 | 172.24.4.3          | None             | None |
+--------------------------------------+---------------------+------------------+------+

The output for Neutron network would be:

+----+---------------------+------------------+-----------+--------+
| ID | Floating IP Address | Fixed IP Address | Server ID | Pool   |
+----+---------------------+------------------+-----------+--------+
|  1 | 172.24.4.1          | None             | None      | public |
+----+---------------------+------------------+-----------+--------+

Change-Id: I1295e922df695414511d9a07ca4a8e2428040064
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-02-19 11:10:53 +08:00
Tang Chen
3c8bb16513 Subnet Pool: Add "subnet pool show" command
Change-Id: I8dda7bbf1e27b0ac773f62a5cd293387da96f8df
Closes-Bug: 1544590
Implements: blueprint neutron-client
2016-02-19 11:05:28 +08:00
Tang Chen
a04012c3d5 Subnet Pool: Add "subnet pool list" command
Change-Id: I7935be2488fb728ced9680d75880870e5d315655
Closes-Bug: 1544589
Implements: blueprint neutron-client
2016-02-19 11:00:33 +08:00
Chaozhe.Chen
444fc6149d Remove unused test-requirments
WebOb is not needed in our test code.
So remove it to make less dependences.

Change-Id: I4910263449ff3d49c4ee44a6ef7a7762875fe76f
2016-02-18 22:51:04 +08:00
Jenkins
00a1dddc2a Merge "Subnet Pool: Add "subnet pool delete" command" 2016-02-18 09:58:22 +00:00
Jenkins
088f2446f2 Merge "Support "network show" command in nova network" 2016-02-18 09:03:56 +00:00
Jenkins
36b21461d9 Merge "Support "network list" command in nova network" 2016-02-18 09:03:49 +00:00
Jenkins
bb153b705a Merge "Refactor security group rule delete to use SDK" 2016-02-18 09:03:27 +00:00
Tang Chen
79fd6d3f20 Subnet Pool: Add "subnet pool delete" command
Change-Id: Ic5ba5effcaea2410421a81da8ffce7c0295179e7
Closes-Bug: 1544587
Partially implements: blueprint neutron-client
2016-02-18 08:53:39 +08:00
Jenkins
272ac55776 Merge "Return names in list role assignments" 2016-02-17 22:23:51 +00:00
Jenkins
f1ae75aa01 Merge "Add release note for "network delete" command for nova network" 2016-02-17 20:42:33 +00:00
Jenkins
713a9d7de9 Merge "Add release note for "ip floating delete/list" commands for neutron network" 2016-02-17 20:36:22 +00:00
Jenkins
f15a75428d Merge "Add "token revoke" for identity v3" 2016-02-17 20:31:07 +00:00
Jenkins
a517b1e9a6 Merge "Fix 'openstack --help' fails if clouds.yaml cannot be read" 2016-02-17 20:30:49 +00:00
Tang Chen
d9d1809907 Support "network show" command in nova network
"network show" command is not implemented in nova network.
This patch implements it.

Change-Id: I1fadd890fe36c4e3ac5c9ed389b20c5b2fff8aca
partial-Bug: 1543672
2016-02-17 17:09:51 +08:00
Tang Chen
ddc97c6dc5 Support "network list" command in nova network
"network list" command is not implemented in nova network.
This patch implements it.

The Network object in novaclient is quite different from
the one in sdk. And the output of "network list" using
Nova network is also quite different from using Neutron.

It is like this:

# openstack network list
+--------------------------------------+---------+-------------+
| ID                                   | Name    | Subnet      |
+--------------------------------------+---------+-------------+
| 96a98ec4-31f6-45f6-99e6-9384569b3bb5 | private | 10.0.0.0/24 |
+--------------------------------------+---------+-------------+

--long and --external options have not been implemented because
the attrs in Network object in novaclient is too much different.

This patch also introduces a new FakeNetwork class in compute/v2/fake.py
to fake nova network.

Change-Id: Id1fdf81fb2fa8b39f2c76b7bae37ac4fecafd0f7
Depends-On: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e
partial-Bug: 1543672
2016-02-17 17:04:43 +08:00
Tang Chen
0a3ba91d53 Add release note for "network delete" command for nova network
Change-Id: Idb8a24465e447e90315c0f614ad91bd7eabd6878
partial-Bug: 1543672
2016-02-17 17:04:32 +08:00
Tang Chen
da3d65299b Define FakeFloatingIP class in tests/compute for nova network commands
"ip floating list" command is not available for Neutron now because
the implementation is incorrect.

The FloatingIP objects returned from Nova and Neutron network are
quite different. So they need different FakeFloatingIP class to
do the tests.

This patch copies class FakeFloatingIP in tests/network to tests/compute
for Nova network tests.

Will fix the problem in "ip floating list" command and change FakeFloatingIP
in tests/network to fit Neutron network tests.

Change-Id: Ia29d257868e0f1dc6cd7cfe3819875e5913f76ec
Partial-Bug: 1519502
Partially implements: blueprint neutron-client
2016-02-16 15:14:34 +08:00
Tang Chen
5f40e1ea45 Add release note for "ip floating delete/list" commands for neutron network
Change-Id: Ic90abf106a06edf9af4fe4c8938ab92bfdd8bb42
partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-02-16 13:38:20 +08:00
Jenkins
c8753808a2 Merge "Refactor security group functional tests" 2016-02-15 20:46:51 +00:00
Jenkins
67bec569f8 Merge "Rename parameter "identifier" to "network" in network commands" 2016-02-15 17:16:30 +00:00
Jenkins
5543857381 Merge "Use assertRaises() to check if an exception is raised" 2016-02-15 17:14:42 +00:00
Hideki Saito
e5b8e08eb1 Fix 'openstack --help' fails if clouds.yaml cannot be read
'openstack --help' can display the basic information, even if
 openstack command does not have permission to read clouds.yaml.

Change-Id: I7d5255c5ce3bd60af77fc70f433ca78dc011a79f
Closes-Bug: #1541047
2016-02-14 22:08:01 +09:00
Tang Chen
324e026f57 Rename parameter "identifier" to "network" in network commands
In other commands, the name or ID of an object is just the name
of the object. For example, name or ID of a server is "server",
router is "router". So, do not use "identifier" in network commands.

Also, the parameter in doc file network.rst is not "identifier",
but "network".

Change-Id: I1ec3beefbb878a207bca280b994ca176ef04ee2d
2016-02-14 18:57:34 +08:00
Tang Chen
cfcb750a97 Use assertRaises() to check if an exception is raised
In some test cases, try/except is used to check if an exception
has been raised. We should use assertRaises() instead.

Change-Id: I15c8e757dcab77fd6f895feb018184e1eb7e617b
2016-02-14 18:43:19 +08:00
Tang Chen
27a0da65e3 Support "network delete" command in nova network
"network delete" command is not implemented in nova network.
This patch implements it.

Change-Id: I5dac1eed6eb8e67298bb446418835a6ab85c859c
Depends-On: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e
partial-Bug: 1543672
2016-02-14 17:07:17 +08:00
Tang Chen
d8abec33ad Floating IP: Neutron support for "ip floating list" command
Change-Id: I253f66f6bc64470e1a18ffea506048eb53f67d5c
partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-02-14 04:21:08 +00:00
Jude Job
6109dfcf63 Floating IP: Neutron support for "ip floating delete" command
This patch implements "ip floating delete" command for
both compute and network. Also includes unit tests.

Change-Id: Ie61f0faad65ec90f9d9956ae463412be8d963d05
partial-Bug: 1519502
Related-to: blueprint neutron-client
Co-Authored-By: Tang Chen <chen.tang@easystack.cn>
2016-02-14 04:21:00 +00:00
Jenkins
c7c672d4b3 Merge "Add quota functional tests" 2016-02-13 06:49:39 +00:00
Jenkins
6117e1c715 Merge "Identity: Fix DisplayCommandBase comments for cliff ShowOne subclass tests" 2016-02-13 06:11:39 +00:00
Jenkins
f1b11e2cf0 Merge "Identity: Fix DisplayCommandBase comments for cliff Lister subclass tests" 2016-02-13 06:11:22 +00:00
Jenkins
2dae6567c6 Merge "Identity: Fix DisplayCommandBase comments for cliff Command subclass tests" 2016-02-13 06:11:16 +00:00
Jenkins
6a61cb2540 Merge "Add NetworkAndCompute Lister and ShowOne classes" 2016-02-13 04:36:37 +00:00
Jenkins
43065bee9a Merge "Trivial: Fix a typo in test_network.py" 2016-02-13 04:36:30 +00:00
Jenkins
2650439052 Merge "Updated from global requirements" 2016-02-13 04:09:13 +00:00
Jenkins
73cabcc871 Merge "Add release note for custom logging feature" 2016-02-12 21:00:24 +00:00
Jenkins
088cb82631 Merge "Allow custom log levels for other loggers" 2016-02-12 21:00:00 +00:00
OpenStack Proposal Bot
08e045282c Updated from global requirements
Change-Id: I1583731e73699b71aa7a03ae4541e481abd6f1ea
2016-02-12 20:06:35 +00:00
Richard Theis
ea0b8f9162 Add quota functional tests
Add functional tests for "os quota" commands.

Change-Id: I0f5939bf4ce553174c9b7ce55bdb3dce0506c409
Related-Bug: #1528249
Partially-Implements: blueprint neutron-client
2016-02-12 12:52:40 -06:00
Richard Theis
04e45bbacd Add NetworkAndCompute Lister and ShowOne classes
This patch set introduces the NetworkAndComputeLister and
NetworkAndComputeShowOne classes which are related to the
NetworkAndComputeCommand class.  These classes are for commands
that must support neutron and nova network.  The new classes
allows both the parser and actions to be unique.

Change-Id: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e
Partial-Bug: #1519511
Partial-Bug: #1519512
Related-to: blueprint neutron-client
2016-02-12 07:14:32 -06:00
Jenkins
91177828d8 Merge "Trivial: Fix "abstractmethod" to "abstract method"" 2016-02-12 03:45:32 +00:00
Jenkins
0cf8b29cfe Merge "Fix identity test_role functional tests" 2016-02-12 00:54:56 +00:00
Richard Theis
7d6d23d378 Fix identity test_role functional tests
A recent keystone change [1] resulted in the domain_id field
being included when showing a role.

[1] 407eabde41

Change-Id: I344f4d727f2a16217c075ad8b8393c1e0a233c2e
Closes-Bug: #1544547
2016-02-11 07:30:56 -06:00
Tang Chen
9d57709ccc Trivial: Fix a typo in test_network.py
Change-Id: I5fe4865473ea885b54d02b5d174a632221f815c8
2016-02-11 20:02:12 +08:00
OpenStack Proposal Bot
dda45e3c39 Updated from global requirements
Change-Id: Icdee08fa079eb3646388567050643c29eac1eca8
2016-02-10 21:59:14 +00:00
Richard Theis
b3a4b8852a Refactor network AZ exception handling
Exceptions that occur while getting network availability zones
should not be masked as if the extension does not exist.

Change-Id: I07213ec6c4d83e97261b58bf8d42417c1cdfae6a
Related-Bug: #1534202
2016-02-10 13:49:30 -06:00
Richard Theis
a29c9732d7 Refactor security group rule delete to use SDK
Refactored the 'os security group rule delete' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

This patch set also introduces new FakeSecurityGroupRule classes
for testing network and compute security group rules. And fixes
were made to the network FakeSecurityGroup class.

Change-Id: I8d0917925aa464e8255defae95a2a2adfb6cfb75
Partial-Bug: #1519512
Related-to: blueprint neutron-client
2016-02-10 10:38:35 -06:00
Tang Chen
9f71b777ac Identity: Fix DisplayCommandBase comments for cliff ShowOne subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 3 in all identity tests.

Change-Id: I1f05e833cdacd30915954e4220b6e1f16ac1ed40
Closes-bug: #1477199
2016-02-10 23:11:58 +08:00
Tang Chen
d0c0cefb84 Identity: Fix DisplayCommandBase comments for cliff Lister subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 2 in all identity tests.

Change-Id: I2929ee688b1d7afc52c6ab325982bdc24c60a995
Partial-bug: #1477199
2016-02-10 22:44:29 +08:00
Tang Chen
1225ad5f7e Identity: Fix DisplayCommandBase comments for cliff Command subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 1 in all identity tests.

Change-Id: Id7180d10c050c6286b2c05cd990e2e275fbc3d38
Partial-bug: #1477199
2016-02-10 19:15:37 +08:00
Tang Chen
e1feed5221 Trivial: Fix "abstractmethod" to "abstract method"
As Richard <rtheis@us.ibm.com> has pointed out, "abstractmethod"
should be "abstract method". This is a small typo I have made
when I fix DisplayCommandBase comment bug.

Change-Id: I84f1a3158896257686a0a7efa1123eef1b85139f
Partial-bug: #1477199
2016-02-10 19:01:52 +08:00
Tang Chen
35833f7bd8 Fix DisplayCommandBase comments for cliff ShowOne subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 3 in all but identity tests. There are too many
such comments in identity tests. So fix them all in another patch.

Change-Id: I1afe4852069d25d562a9448ec2bf2cff58955052
Partial-bug: #1477199
2016-02-10 13:31:38 +08:00
lin-hua-cheng
686a269738 Add "token revoke" for identity v3
Change-Id: Ie631600d02942fe6ce035f31af46abe44e543631
Closes-bug: #1543226
2016-02-09 16:49:11 -08:00
Tang Chen
e69b88ef52 Fix DisplayCommandBase comments for cliff Lister subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 2 in all but identity tests. There are too many
such comments in identity tests. So fix them all in another patch.

Change-Id: I00f38d12f55abe20fa708f6349073da658622f8d
Partial-bug: #1477199
2016-02-09 20:28:18 +08:00
Tang Chen
43f80505cb Fix DisplayCommandBase comments for cliff Command subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
          |--> Lister
          |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 1 in all but identity tests. There are too many
such comments in identity tests. So fix them all in another patch.

Change-Id: I9849baa8141ea8af2042a69afd540b77ce6ae6bd
Partial-bug: #1477199
2016-02-09 18:27:48 +08:00
Jenkins
624c39ab1b Merge "Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests" 2016-02-08 16:21:01 +00:00
Jenkins
f781349974 Merge "Compute: Fix DisplayCommandBase comments for cliff Lister subclass tests" 2016-02-08 08:25:39 +00:00
Jenkins
124f21d0a3 Merge "Compute: Fix DisplayCommandBase comments for cliff Command subclass tests" 2016-02-08 08:25:32 +00:00
Jenkins
3d04c78cb9 Merge "Add unit tests for "hypervisor show" command" 2016-02-08 08:10:03 +00:00
Jenkins
8a250f369c Merge "Remove identity_client.projects definition in TestSecurityGroup" 2016-02-08 07:11:04 +00:00
Jenkins
f0f9b5096c Merge "Define security_group_rules mock in FakeComputev2Client" 2016-02-08 07:10:58 +00:00
Jenkins
3a93c35f34 Merge "Move security_groups mock definition to FakeComputev2Client" 2016-02-08 07:10:52 +00:00
OpenStack Proposal Bot
e3e925d2f1 Updated from global requirements
Change-Id: I14a68f0ed63f1a3e3cac7379324d58b613afdfa9
2016-02-08 02:44:02 +00:00
Jenkins
02ab0cb3c3 Merge "Add release note for recursive delete" 2016-02-07 03:16:15 +00:00
Terry Howe
cdb7637b76 Add release note for custom logging feature
Change-Id: I5471fcb33cd4488b33d2c01d857344f52f361c9d
2016-02-07 01:23:19 +00:00
Terry Howe
828f63f903 Add release note for recursive delete
Change-Id: I9c7a32d4e18f32ae1225e250d11b8e0a2d274dd7
2016-02-07 01:22:32 +00:00
Tang Chen
fc708c4991 Add unit tests for "hypervisor show" command
Change-Id: Ib75e5eb5b197e9d58fb87a595a43b8774b7b1987
2016-02-07 02:38:09 +08:00
Jenkins
4cc61e5eb9 Merge "Fix formatting in release 2.0.0 notes" 2016-02-06 17:52:40 +00:00
Jenkins
713ed598a4 Merge "Fix some release note formatting" 2016-02-06 05:41:06 +00:00
Tang Chen
23faa33b1b Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
         |--> Lister
         |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.

* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of
  columns and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple
  of columns and a tuple of data

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes
   inheriting from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class Lister in cliff. Lister.take_action()
   returns a tuple and a generator.
3. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class ShowOne in cliff. ShowOne.take_action()
   returns two tuples.

This patch finishes step 3 in compute tests.

Change-Id: I4df224ec82b5d82a3d6d3f366c0f68a7ea0d87cd
Partial-bug: #1477199
2016-02-06 10:47:56 +08:00
Tang Chen
3c67e8dd6e Compute: Fix DisplayCommandBase comments for cliff Lister subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
         |--> Lister
         |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.

* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of
  columns and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple
  of columns and a tuple of data

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes
   inheriting from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class Lister in cliff. Lister.take_action()
   returns a tuple and a generator.
3. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class ShowOne in cliff. ShowOne.take_action()
   returns two tuples.

This patch finishes step 2 in compute tests.

Change-Id: Idc54ad21eaa1371ebd601327b8d962c7039f2de0
Partial-bug: #1477199
2016-02-06 10:30:34 +08:00
Tang Chen
b9de23d906 Compute: Fix DisplayCommandBase comments for cliff Command subclass tests
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
         |--> Lister
         |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.

* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of
  columns and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple
  of columns and a tuple of data

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes
   inheriting from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class Lister in cliff. Lister.take_action()
   returns a tuple and a generator.
3. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class ShowOne in cliff. ShowOne.take_action()
   returns two tuples.

This patch finishes step 1 in compute tests.

Change-Id: I99ab42a7de69af0e5de802a1bb5aac647245a200
Partial-bug: #1477199
2016-02-06 09:34:51 +08:00
Tang Chen
90a4cf23aa Remove identity_client.projects definition in TestSecurityGroup
projects mock has been defined in FakeIdentityv2Client as
tenants, and in FakeIdentityv3Client as projects. No need
to define them again.

Change-Id: Ieb97b32d7be6bd95c8621092b218ebfd8bc5b78d
2016-02-06 08:44:05 +08:00
Tang Chen
1740218728 Define security_group_rules mock in FakeComputev2Client
security_group_rules mock should be defined in
FakeComputev2Client, and used in each test class.

Change-Id: I44bb6379b2c1b6cb277296e08e25dd4d7255c276
2016-02-06 08:43:55 +08:00
Tang Chen
553631a5d4 Move security_groups mock definition to FakeComputev2Client
All compute client related mocks should be defined in
FakeComputev2Client.

Change-Id: Ie75385af772ca23286c4cf131d3d54cc14f20a30
2016-02-06 08:43:01 +08:00
Jenkins
794c2a1738 Merge "Add functional tests for snapshots" 2016-02-05 22:50:01 +00:00
Jenkins
fb4240a4b5 Merge "Add support for triggering an crash dump" 2016-02-05 22:49:36 +00:00
Jenkins
546398c14b Merge "Add recursive object delete for containers" 2016-02-05 22:49:33 +00:00
Dean Troyer
552eded9ad Fix formatting in release 2.0.0 notes
This is a test to see if we can update release notes from previous releases.
This may not work and will be abandoned if so.

Change-Id: Id85a25c793aa403025c7e32038ea7072139700db
2016-02-05 16:25:01 -06:00
Dean Troyer
99f6795189 Fix some release note formatting
Fix the current notes that used single-backticks where
double-backticks should have been used.

Change-Id: I454e14dd084c9b706fab3255170a79765091a497
2016-02-05 15:38:59 -06:00
TerryHowe
514a168656 Add recursive object delete for containers
Change-Id: Ib291e79864c218464e842a08efd3742193ba5ff0
2016-02-05 11:18:46 -07:00
Richard Theis
a836023411 Refactor security group functional tests
Moved the functional tests for "os security group" and
"os security group rule" from the compute to the network
directory to align with the refactoring to the commands.

Change-Id: Ief6ab17775c6d7e3bef58d9fa025d9dd520b7370
Partial-Bug: #1519511
Partial-Bug: #1519512
Related-to: blueprint neutron-client
2016-02-05 09:54:58 -06:00
TerryHowe
e108719f77 Add functional tests for snapshots
Change-Id: I863583d6c8263d144d45a0443fc6af04301d23e7
2016-02-05 07:02:29 -07:00
xiexs
6b3583ab06 Add support for triggering an crash dump
The triggering crash dump feature is supported by nova [1] and
novaclient [2] now, it's time to introduce this feature into
OSC correspondingly.

[1]The change id is: I6ed777ff637254b4b79417008f9055dd19fc7405
[2]The change id is: If03b1864bbe7074c720b946fc2700bd5d07debc3

Change-Id: I5a411f283fdf0fc3c00380d069848a332c799cdd
Closes-Bug: #1538372
Co-Authored-By: Tang Chen <chen.tang@easystack.cn>
2016-02-05 21:48:41 +08:00
Tang Chen
05b18749ef Add unit tests for "hypervisor list" command
There is no unit tests for "hypervisor" command. This patch
introudces a new class FakeHypervisor to fake one or more
hypervisors, and a base class TestHypervisor. Also adds
hypervisors mock to fake compute client.

And also, this patch adds unit tests for "hypervisor list"
command.

Change-Id: I18733eae1a8f4fff72e830d9a060fb8f0f58fbf5
2016-02-05 21:40:28 +08:00
TerryHowe
b95ce714dc Allow custom log levels for other loggers
It would be convenient to be able to enable special logging for
various components that openstack uses.  The biggest thing is
the --debug prints a lot of information when often all I want to
see is the outgoing requests/responses.  To get just that logged
you would put this in your clouds.yaml:

    logging:
        keystoneclient.session: debug

Closes-Bug: #1484660
Change-Id: I15c2607e8262f10903dd831ee8622fb5d6315310
2016-02-05 11:07:50 +00:00
Jenkins
42b607edf1 Merge "Use assert_not_called() in common tests" 2016-02-04 22:56:57 +00:00
Jenkins
f4ad41761a Merge "Doc: Add optional command specs process" 2016-02-04 20:27:18 +00:00
Jenkins
b861d21d14 Merge "Refactor TestVolumeCreate to use FakeVolume" 2016-02-04 05:30:03 +00:00
Jenkins
95263a0b8c Merge "Minor typo in help text" 2016-02-04 00:43:09 +00:00
Jenkins
48697de28f Merge "Support listing network availability zones" 2016-02-04 00:40:09 +00:00
Jenkins
e4c0d8583d Merge "Allow wait_for_delete to work for all clients" 2016-02-04 00:39:47 +00:00
Jenkins
78d51125ac Merge "Fix wrong type of volume attachments in FakeVolume" 2016-02-03 22:45:49 +00:00
Dean Troyer
38ff51baef Use assert_not_called() in common tests
In https://review.openstack.org/#/c/273653/ Bryan Jones made
a point about using mock_sleep.assert_not_called() rather than
self.assertFalse(mock_sleep.called), so let's make that change
throughout these tests.

Change-Id: I826d608836955383891b303355edcca7b62faa16
2016-02-03 15:47:07 -06:00
Jenkins
7903e53971 Merge "Refactor security group delete to use SDK" 2016-02-03 21:01:31 +00:00
Jenkins
3763d75dba Merge "Network: Abstract get_body() out to be a private helper." 2016-02-03 21:01:23 +00:00
Jenkins
65f8845ea8 Merge "Add "os port show" command" 2016-02-03 21:01:17 +00:00
Jenkins
66df8d1413 Merge "Add availability zone support for router commands" 2016-02-03 21:00:48 +00:00
Jas
962389f404 Minor typo in help text
fix misspelled 'project' in router-create help text

Change-Id: I4874563c0dd7ca35ef153cf24b99e357c0c076b9
2016-02-03 14:38:04 -06:00
Jenkins
ca1eeaf207 Merge "Fix a spell typos" 2016-02-03 14:29:20 +00:00
Jenkins
0d8b986ddb Merge "Add --marker option to "image list" command" 2016-02-03 11:38:06 +00:00
Jenkins
feb71897fb Merge "Add limit option to "image list" command" 2016-02-03 11:34:25 +00:00
Jenkins
34e4e1ac3e Merge "Remove marker and loop from "image list" command" 2016-02-03 11:34:19 +00:00
venkatamahesh
65007432dc Fix a spell typos
Change-Id: I422fc8086af83efa4c04fd1951b4738404c1a1b7
2016-02-03 15:47:25 +05:30
Tang Chen
499369329c Add --marker option to "image list" command
Users could specify the last image (name or ID) of the previous page with
--marker option to control the start image of the output.

Change-Id: Idca0235ee83b1226b00c89cf3d38500fa898b7d0
Closes-Bug: #1540988
2016-02-03 14:04:50 +08:00
xiexs
5812803865 Add limit option to "image list" command
This option is quite useful if there are too many images.

Change-Id: If6a901c27c5da2d1f4412e8fa9ba3bed3b72fdd9
Co-Authored-By: Tang Chen <chen.tang@easystack.cn>
Partial-Bug: #1540988
2016-02-03 13:42:57 +08:00
Tang Chen
0b6fdcbe4c Remove marker and loop from "image list" command
Since --page-size has never worked, there is no paginate logic needs
to be implemented in "image list" command. So remove the unnecessary
loop.

And also, the marker is not necessary because --marker option has not
been implemented. Will add it back when implementing --marker option.

Change-Id: I71fea1502f92f447a49697edb52e8e82f336772f
Partial-Bug: #1540988
2016-02-03 13:42:49 +08:00
Tang Chen
e0969655ac Trivial: Reorder test class in test_volume.py into alphabetical order
TestVolumeDelete should be after TestVolumeCreate.

Change-Id: I764543a0e0723633aec6b18c2d50a01931465e6b
2016-02-03 12:04:34 +08:00
Jenkins
4b2c66447d Merge "Drop log_method decorator" 2016-02-02 21:21:30 +00:00
Tang Chen
d324aa652b Fix wrong type of volume attachments in FakeVolume
The volume attachments should be a list of dict, not a single dict.

Change-Id: I3cec62bcb3953e4f38f9d3dd23f3eb6ef984464c
2016-02-02 23:47:23 +08:00
xiexs
aba3fd9689 Refactor TestVolumeCreate to use FakeVolume
Class FakeVolume should be used in volume tests.

Change-Id: Idf7d3e2a0654cd7d7993f169c4743b1d38902f1b
Implements: blueprint improve-volume-unittest-framework
Co-Authored-By: Tang Chen <chen.tang@easystack.cn>
2016-02-02 23:21:08 +08:00
Richard Theis
580b0aff88 Refactor security group delete to use SDK
Refactored the 'os security group delete' command to use the SDK
when neutron is enabled, but continue to use the nova client when
nova network is enabled.

This patch set introduces a new NetworkAndComputeCommand class
to be used for commands that must support neutron and nova network.
The new class allows both the parser and actions to be unique.
The current DeleteSecurityGroup class is now a subclass of this
new class and has moved under the network v2 commands.

This patch set also introduces a new FakeSecurityGroup class for
testing security groups.

And finally, this patch set updates the command documentation
for security group and security group rule to indicate that
Network v2 is also used.

Change-Id: Ic21376b86b40cc6d97f360f3760ba5beed154537
Partial-Bug: #1519511
Related-to: blueprint neutron-client
2016-02-02 09:04:51 -06:00
Richard Theis
981621e984 Add "os port show" command
Add "os port show" command.

Change-Id: Id87c81640e74c60ae8f247c722c64fdadff022a2
Partial-Bug: #1519909
Partially-Implements: blueprint neutron-client
2016-02-02 08:40:05 -06:00
Richard Theis
4d332defbc Support listing network availability zones
Update the "os availability zone list" command to support listing
network availability zones along with the currently listed compute
and volume availability zones. This adds the --network option to
the command in order to only list network availability zones. By
default, all availability zones are listed. The --long option
was also updated to include a "Zone Resource" column which is
applicable to network availability zones. Example zone resources
include "network" and "router".

If the Network API does not support listing availability zones
then a warning message will be issued when the --network option
is specified.

This support requires an updated release of the SDK in order
to pull in [1].

[1] https://bugs.launchpad.net/python-openstacksdk/+bug/1532274

Change-Id: I78811d659b793d9d2111ea54665d5fe7e4887264
Closes-Bug: #1534202
2016-02-02 08:08:25 -06:00
Tang Chen
f36177ebdd Trivial: Fix wrong comment in test_image.py
Code in test_image.py has nothing to do with server.

Change-Id: Ia73d7b99effb394c5db9635fee6da350b0b1086b
2016-02-02 15:22:40 +08:00
Jenkins
e628d5202c Merge "Consume openstackclient.common.command in subnet/port" 2016-02-02 06:31:02 +00:00
Tang Chen
a83c1f0a42 Network: Abstract get_body() out to be a private helper.
get_body() is needed in each network files to construct a dict
to pass to sdk proxy. And it is also used by several functions
in each file. So define it as a file level private helper function.

The unified prototype should be:

    def _get_attrs(client_manager, parsed_args):

1. The name, in sdk, the parameter passed to proxy is named "attrs".
   And it is a private method. So let's call it _get_attrs().
2. The parameters, besides parsed_args, when we deal with project
   and project_domain, we have to make use of identity_client. So
   let's pass in the client manager.

Change-Id: Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249
2016-02-02 13:58:43 +08:00
Jenkins
ceb17e11a9 Merge "Updated from global requirements" 2016-02-02 04:07:04 +00:00
Jenkins
72fe3e25e2 Merge "Fix showing network quotas for a project" 2016-02-02 04:06:57 +00:00
Jenkins
180ba2f733 Merge "Add missing release notes" 2016-02-02 04:03:57 +00:00
Akihiro Motoki
a05d9fd9f1 Drop log_method decorator
As a result of the recent logging refactoring, log_method decorator
is no longer required. oslo.log provides a similar decorator
oslo_log.helpers.log_method_call. If a similar feature is needed,
we can use the decorator from oslo_log.

searchlightclient is the only OSC external plugin which uses this
decorator. The depending patch removes it, so we can safely drop
the decorator.

Change-Id: If3df09cf6aa0a401d9f89e8924adce851d0c6dec
Depends-On: Ib94e7ba77262a9a8cbfce71f3083c47cb1973364
2016-02-02 12:51:24 +09:00
OpenStack Proposal Bot
2548419e92 Updated from global requirements
Change-Id: I2f00e8ff1609d76c2ab20226f2b4503231fdb003
2016-02-02 02:03:31 +00:00
Akihiro Motoki
77ce1c17a0 Consume openstackclient.common.command in subnet/port
Follow-up patch of https://review.openstack.org/#/c/269613/
network/v2/subnet and port still use cliff classes directly.
This patch fixes it.

Change-Id: If9d90e5151ece7f4cf1e0d6fd2f32919865f2f2e
2016-02-02 11:03:07 +09:00
Richard Theis
5d1a93362d Fix showing network quotas for a project
The OpenStack SDK is now used for the network client. However,
the 'openstack quota show' command wasn't updated for the
client change. As a result, the command will fail to show
network quotas when a project name is specified. For example:

  $ openstack quota show admin
  'Proxy' object has no attribute 'show_quota'

This patch set fixes the command by using the OpenStack SDK
to get network quotas for a project.

Change-Id: I59a7b6780a7b80cd09e79d40d214751b25d3016e
Related-To: blueprint neutron-client
Closes-Bug: #1528249
2016-02-02 02:02:53 +00:00
Dean Troyer
cd4998ef41 Add missing release notes
Add release notes for the user-visible features added since the
2.0.0 release

Change-Id: I753a894f1a3f6eef3eef50661ee66c729a2567f4
2016-02-02 02:02:42 +00:00
Akihiro Motoki
258c1102cc log take_action parameters in a single place
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
2016-02-02 09:58:32 +09:00
Jenkins
e9ff42eee7 Merge "Revert "Skip identity v2 functional tests"" 2016-02-02 00:03:35 +00:00
Richard Theis
bca1a930f4 Revert "Skip identity v2 functional tests"
This reverts commit 5032dbc807 based on [1].

[1] https://review.openstack.org/#/c/274703/

Change-Id: Ic10ef7c37d71e452fbc4bd36e28be79d669b4e3f
2016-02-01 20:56:43 +00:00
Jenkins
a4b05b426e Merge "Add availability zone support for network commands" 2016-01-31 07:33:08 +00:00
Jenkins
973458600b Merge "Update translation setup" 2016-01-31 05:45:19 +00:00
Richard Theis
5032dbc807 Skip identity v2 functional tests
DevStack now uses identity v3 by default thus causing OSC to
only load openstack.identity.v3 commands. This prevents running
functional tests on openstack.identity.v2 commands. As a result,
this patch set skips all identity v2 functional tests to unblock
the gate.

Change-Id: I066187318be71792a966fa21226fab0d406c3758
Partial-Bug: #1539780
2016-01-29 15:45:07 -06:00
Jas
c0d2120883 Add availability zone support for router commands
This patch allows the adding of availability_zone_hints during
router create. Also allows for the display of availability_zones
during list and and show commands.

Change-Id: Ifbc5c218bc7103d28076d726212ce25321bcf7f1
Partial-bug: #1519503
Partially-implements: blueprint neutron-client
2016-01-29 09:52:02 -06:00
Akihiro Motoki
a6cd2dc136 Update translation setup
Follow new infra setup for translations, see spec
http://specs.openstack.org/openstack-infra/infra-specs/specs/translation_setup.html
for full details.

This basically renames
python-openstackclient/locale/python-openstackclient.pot to
openstackclient/locale/openstackclient.pot. For this we need to update
setup.cfg.

Update also domain name in i18n.py.

Change-Id: I89fad12f20775c8b7cd228348ff82a77488e6ab2
2016-01-29 08:18:50 +09:00
Brad Behle
67ecf4ef43 Add availability zone support for network commands
Add --availability-zone-hint parm to network create. Also add
availability_zones and availability_zone_hints to the network list and network
show commands

Change-Id: Ib4dc2e3e7897939be7bef6b25a095c8222b885bc
Partially-implements: blueprint neutron-client
2016-01-28 15:54:27 -06:00
Mark Vanderwiel
5903ffff8a Allow wait_for_delete to work for all clients
Allow the exception and error status
strings to be passed in such that other plugins can
make use of this function.

There is a comment in find_resource:
  The exception to catch here is dependent on which
  client library the manager passed in belongs to.
  Eventually this should be pulled from a common set
  of client exceptions.

Since I think that is a long ways off, this change will
work now and also work when a common exception is defined
and used.

Change-Id: Iab56cd1166028caed4f1e657e0b1ee81af3f48d8
2016-01-28 10:52:45 -06:00
OpenStack Proposal Bot
c43bdc1441 Updated from global requirements
Change-Id: If070122805497e0943918900c6d1f6a54faef37a
2016-01-28 13:41:16 +00:00
Jenkins
636b4de6df Merge "Remove the Tuskar client" 2016-01-28 00:25:14 +00:00
Jenkins
fa2242b669 Merge "Use correct terminology for subnets" 2016-01-27 23:29:05 +00:00
Tom Cocozzello
3a48989eb0 Return names in list role assignments
Utilize the new include names functionality added to
list role assignments (GET /role_assignments?include_names=True).
Which will return the names of the entities instead of their
IDs.

Change-Id: I6dc03baf61ef9354a8a259a9f17ff47ce1665ce7
Depends-On: I4aa77c08660a0cbd021502155938a46121ca76ef
Closes-Bug: #1479569
Implements: blueprint list-assignment-with-names
2016-01-27 18:13:32 +00:00
Dougal Matthews
a7e5faf22c Remove the Tuskar client
The Tuskar project is now inactive and has been archived.

Change-Id: I4c7cb50560b40ba1bc130be5bdc9446a46b09c24
2016-01-27 16:34:28 +00:00
Dean Troyer
db458d7dec Use correct terminology for subnets
OpenStack uses 'CIDR' incorrectly in many places.  We are not going
to perpetuate that usage.  The correct name here is simply 'subnet'
as the data is the network address for the subnet, in CIDR notation.

Also, some additional cleanups as suggested in comments to
https://review.openstack.org/#/c/84782

Depends-on: I3c0748074a6511ff92500516b3129886d2476eed
Change-Id: Ib44c49dc1739ce7d881432e482dd16f8928eef49
2016-01-27 09:13:46 -06:00
Jenkins
a82aa6651b Merge "Updated from global requirements" 2016-01-27 06:50:04 +00:00
Jenkins
68e3327a5a Merge "Add releasenote for 'subnet list' command support" 2016-01-27 00:36:31 +00:00
Jenkins
39330ddad7 Merge "Subnet List" 2016-01-27 00:36:11 +00:00
OpenStack Proposal Bot
291e3a7397 Updated from global requirements
Change-Id: I0bd39534777eb919810b6a1b9c8117cdcd61ff2c
2016-01-26 23:29:00 +00:00
Lingxian Kong
299c5710c5 Add releasenote for 'subnet list' command support
Change-Id: I415dfe4b752dbf9dd4d5b052e29001a7a1d0ef99
Depends-On: I3c0748074a6511ff92500516b3129886d2476eed
2016-01-25 21:30:09 +00:00
Jenkins
f76425028b Merge "Add router functional tests" 2016-01-25 21:18:41 +00:00
Richard Theis
1db40e8563 Add router functional tests
Add functional tests for the "os router" commands.

Change-Id: I99045e6e2f548ac4206afcdb61940180e609a6bc
Partial-bug: #1519503
Partially-implements: blueprint neutron-client
2016-01-25 10:28:59 -06:00
Terry Howe
ffcfff6f3e Subnet List
Subnet list command

Partially implements: blueprint neutron-client
Partial-Bug: #1523258
Change-Id: I3c0748074a6511ff92500516b3129886d2476eed
2016-01-25 21:57:54 +13:00
OpenStack Proposal Bot
c20f9a86ee Updated from global requirements
Change-Id: Iafdb2a4841ff9a9f643182f13ff1bcec47e3adb2
2016-01-23 10:35:55 +00:00
Jenkins
7b2ff8eef2 Merge "Refactor abstract columns and datalist out in image and object test cases" 2016-01-23 08:24:41 +00:00
SaiKiran
69b8cde5f1 Refactor abstract columns and datalist out in image and object
test cases

columns and datalist has been set in each test case in image
and object which is not necessary. This patch abstract it out
and remove all redundant code.

Change-Id: Ie6aa3fa27ab2a468c67da31209107517259631c2
Related-Bug: 1532384
2016-01-23 11:44:15 +05:30
Jenkins
ee78fb2f78 Merge "Support listing volume availability zones" 2016-01-22 19:23:20 +00:00
Jenkins
09be6a439a Merge "Refactor "os availability zone list"" 2016-01-22 19:22:42 +00:00
Jenkins
75caafa096 Merge "Refactor: Abstract columns and datalist out in volume test cases" 2016-01-22 08:55:38 +00:00
OpenStack Proposal Bot
59b1bb10d6 Updated from global requirements
Change-Id: I89081053923a81260111dbfefd307b80e3858caf
2016-01-22 04:09:05 +00:00
Jenkins
fe10d0faf4 Merge "Initialize activation status" 2016-01-21 22:36:15 +00:00
Jenkins
1f378a0674 Merge "Change --owner to --project in image commands" 2016-01-21 21:04:04 +00:00
Travis Tripp
4b70e607a0 Add python-searchlightclient to list of adopters.
This adds python-searchlightclient to the list of adopters.

Change-Id: Ifb6f1931c00fc735a0b0fcc830979a4d83c0527d
2016-01-21 12:06:26 -07:00
Jenkins
f51f26868c Merge "log_method: get logger from decorated method if unspecified" 2016-01-21 09:26:54 +00:00
SaiKiran
2b670afa33 Refactor abstract columns and datalist out in compute test cases
columns and datalist has been set in each test case in compute,
which is not necessary. This patch abstract it out and remove
all redundant code.

Change-Id: I5e8423722416ea31fdced4c932ed141de90028ab
Closes-Bug: #1531816
2016-01-21 04:50:29 +00:00
Jenkins
c08545cbee Merge "Set up logger of each command by metaclass" 2016-01-21 02:44:33 +00:00
Jenkins
eb36df1f82 Merge "Add support to delete the ports" 2016-01-20 16:21:53 +00:00
Akihiro Motoki
50d54bb007 log_method: get logger from decorated method if unspecified
This commit makes 'log' optional.
'log' attribute of each command class does not exist
when the class is defined because 'log' is now setup
dynamically when a class is instantiated. Instead log_method
looks for a logger from a decorating method.

compute.v2.server is changed in this commit as an example.

Change-Id: Ic4d128f8e027d3b8e6f884f31369e9085c0f0871
Partial-Bug: #1532294
2016-01-20 22:02:19 +09:00
Akihiro Motoki
0e6b86ad94 Set up logger of each command by metaclass
compute.v2.flavor is changed in this commit as an initial example.

Partial-Bug: #1532294
Change-Id: I262af6ade0ae03fbe1cd2ad198faf4ebb4ecf7ce
2016-01-20 22:02:19 +09:00
SaiKiran
604d8589ee Refactor: Abstract columns and datalist out in volume test cases
columns and datalist has been set in each test case in volume,
which is not necessary. This patch abstract it out and remove
all redundant code.

Change-Id: I3a09d5d2db86da986bdcfbf2310978ced181017d
2016-01-20 10:49:43 +05:30
SaiKiran
3168e2297d Add support to delete the ports
This patch adds "port delete" command to osc.

Change-Id: I5c92b2f573249df4e6551506584ccafb4ff290b2
Implements: blueprint neutron-client
Partial-Bug: #1519909
2016-01-20 10:29:16 +05:30
Terry Howe
4d4368bb26 Initialize activation status
activation_status throws an exception if the image set fails
because it is not initialized.

Change-Id: Iff6d5a8844eed954fb1c0bcea96118b99ac6bcf4
2016-01-19 16:15:59 -07:00
OpenStack Proposal Bot
5dbca5f56a Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I1270bace355443e5980d897f82745dd5a28628a2
2016-01-19 06:03:29 +00:00
OpenStack Proposal Bot
86fcd67468 Updated from global requirements
Change-Id: I68ad139345040dee6e5b0e8a7477acb84aa1a06b
2016-01-18 22:45:59 +00:00
Jenkins
5c31e06fde Merge "Doc: Network is supported for extension object" 2016-01-15 23:53:26 +00:00
Jenkins
aa041c5269 Merge "Make --image parameter optional in "server rebuild"" 2016-01-15 17:44:01 +00:00
Richard Theis
a3c6171726 Doc: Network is supported for extension object
Update extension object documentation to note that network
is also supported.

Change-Id: Ifcebdb4dc6bf56482700887c09d89ac64eab321c
2016-01-15 10:25:41 -06:00
Dean Troyer
cf2de9af79 Change --owner to --project in image commands
* image create and image set now use --project to specify an alternate
  project to own the image
* --owner is still silently accepted but deprecated, add warning messages
* --project and --owner are mutually exclusive to prevent precedence issues

Closes Bug: 1527833
Change-Id: Iccb1a1d9175ef9b5edcd79d294607db12641c1f0
2016-01-15 09:24:48 -06:00
Richard Theis
a8ec2ac494 Support listing volume availability zones
Update the "os availability zone list" command to support listing
volume availability zones along with the currently listed compute
availability zones. This adds a --compute and --volume option to
the command in order to select the availability zones to list. By
default, all availability zones are listed.

If the Block Storage API does not support listing availability
zones then an warning message will be issued.

Change-Id: I8159509a41bd1fb1b4e77fdbb512cf64a5ac11a9
Closes-Bug: #1532945
2016-01-14 15:47:19 -06:00
Richard Theis
84174440fc Refactor "os availability zone list"
Refactor the "os availability zone list" command to make it a common
command instead of a compute-only command. Since availability zones
are common to compute, volume and network (new), this refactoring
allows availability zone support to be added for volume and network.

In addition to the refactor, unit and functional tests were added.

Change-Id: I63e9d41d229b21cd38e5a083493042c096d65e05
Partial-Bug: #1532945
2016-01-14 11:43:31 -06:00
Jenkins
8654e3e366 Merge "Changed the abstract columns and datalists from test cases of common and Identity" 2016-01-14 16:33:16 +00:00
Jenkins
fa3077d51a Merge "Refactor network endpoint enablement checking" 2016-01-14 00:45:04 +00:00
SaiKiran
030aee6fbc Changed the abstract columns and datalists from test cases of common and Identity
columns and datalist has been set in each test case in compute,
which is not necessary. This patch abstract it out and remove
all redundant code.

Change-Id: I45a3582088161f12e60e7c933da8e7dcc0ae8e7b
Closes-Bug: #1532384
2016-01-12 17:25:33 +05:30
OpenStack Proposal Bot
bd1adaf003 Updated from global requirements
Change-Id: I3430eea5b97057caad6d211885e1402bec7c1a01
2016-01-12 05:05:59 +00:00
Jenkins
4a5a34d77c Merge "Support non-interactive user password update" 2016-01-11 19:50:00 +00:00
Guang Yee
5cbecc130e Support non-interactive user password update
Currently user password update require interactive prompting of user's
original password. This is problematic because we can't support
non-interactive applications and therefore hinders automation. This
patch make it possible by optionally accepting an
'--original-password' argument. If specified, we would use it instead
of prompting.

DocImpact

Change-Id: I2d994e8c2be949f7ae616ac1d1594fb94e1a27cd
Closes-Bug: 1531360
2016-01-11 09:27:10 -08:00
Jenkins
9317df07a2 Merge "Trivial: Remove useless string_to_bool()" 2016-01-08 06:23:32 +00:00
Jenkins
ee1a4774dd Merge "Further improve output for "os security group show"" 2016-01-07 17:35:03 +00:00
Jenkins
a80ccd8fbc Merge "Use assertTrue/False instead of assertEqual(T/F)" 2016-01-07 09:21:36 +00:00
Swapnil Kulkarni (coolsvap)
a56fc34039 Use assertTrue/False instead of assertEqual(T/F)
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I3437634329fc8ecef25082b43b5fc0e1030cdbda
Closes-Bug:#1512207
2016-01-07 12:40:09 +05:30
Einst Crazy
ee0fb4a3ba Replace assertEqual(*, None) with assertIsNone in tests
Replace assertEqual(*, None) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I8964a10ae3529e978bfab1d8140f95da4b56615c
2016-01-07 14:37:01 +08:00
Jenkins
4c05f1f0e5 Merge "Delete the unused LOG configure code" 2016-01-07 02:56:06 +00:00
OpenStack Proposal Bot
591d74945c Updated from global requirements
Change-Id: I3c50646aa9cb13eec6676452f8e3302741cf6445
2016-01-06 23:19:32 +00:00
Richard Theis
5ff660f718 Further improve output for "os security group show"
Improve the security group rules output when running the
"os security group show" command. Empty and duplicate
information for each security group rule is now removed.
This will ensure that the rules remain readable when
direction and ethertype information is returned as part
of the transition to neutron networking.

Change-Id: Ib49c27a9d7f4d5d38ceb2b0d785ddf94d88b2d89
Partial-Bug: #1519511
Related-To: blueprint neutron-client
2016-01-06 08:21:57 -06:00
zhurong
b29947449a Delete the unused LOG configure code
Delete the unused LOG configure code and import code

Change-Id: I1fb0cacfe44b6a2fd4e4b3f504b6d1dec055c5c4
2016-01-05 02:47:12 -05:00
Jenkins
401164939e Merge "Add support to list all security group rules" 2016-01-04 21:41:06 +00:00
Richard Theis
57dac0bc3a Refactor network endpoint enablement checking
Move the network endpoint enablement checking from the 'server create'
command to the common client manager. This allows future network
commands to use either nova or neutron networking based on the cloud
environment.

This patch set also includes related unit test enhancements to the
common client manager to trigger authentication on the tests.

Change-Id: Ia37e81d4fb05a1e2fceb3e5d367bda769ab8e64b
Related-Bug: #1519511
Related-to: blueprint neutron-client
2016-01-04 13:49:49 -06:00
Jenkins
774201b696 Merge "Implementation for project unset cmd for python-openstackclient." 2016-01-04 19:09:31 +00:00
Jenkins
1b916da1a0 Merge "Enabling domain lookup for project set v3 command" 2016-01-04 16:31:21 +00:00
Jenkins
5aeb831157 Merge "Use Block Storage instead of Volume" 2016-01-04 16:23:30 +00:00
Jenkins
74a0b2a190 Merge "Functional tests for security group rule" 2016-01-04 15:35:32 +00:00
Jude Job
a2a63f19bf Implementation for project unset cmd for python-openstackclient.
This patch introduces a unit test class TestProjectUnset
for testing unset cmd.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>
Change-Id: Ib4a414d2313e3d37e48d1cb3639f064231aec508
Closes-Bug: #1486597
2016-01-04 10:25:55 -05:00
Jenkins
d31c301bd3 Merge "Map some of the SDK field names" 2016-01-01 17:27:23 +00:00
Jude Job
66931c6931 Enabling domain lookup for project set v3 command
Currently the domain option for `project set` attempts to set
a new domain that owns the project. This is actually an action
that is denied by keystone server. Instead, the domain option
should be used as a lookup, to find projects that exist in the
non-default domain.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closes-Bug: #1524456

Change-Id: I30a3812184fe262667e09baa106d2275c2cbb981
2015-12-31 02:11:39 -05:00
Rushi Agrawal
eeeb9f729f Docstring should say 'default' if option is default
Change-Id: I59d83e7a0a590fa537f509f7f19940640f555679
2015-12-31 09:36:26 +05:30
Tang Chen
5f0147ad12 Trivial: Remove useless string_to_bool()
string_to_bool() is not used by anyone.
Furthermore, it is not well designed. It tries to convirt 't', '1'
to True, which could be confused.

So remove it. If we need something similar, let's make a better one.

Change-Id: Ic1f63480c806bf7bcc9f541fc806eed297ddf718
2015-12-29 10:50:44 +08:00
Jenkins
9f2ed6b03a Merge "Improve output for "os security group show"" 2015-12-28 13:54:02 +00:00
Tang Chen
8d718e9d67 Refactor: Initialize parser in setUp() in TestNonNegativeAction
Change-Id: I12846acc4450d31d19897bbdfc6846bde8c8f2ce
2015-12-28 20:01:13 +08:00
Tang Chen
f0a3b175a1 Refactor: Initialize parser in setUp() in TestKeyValueAction
No need to initialize parser in each test case. Do it in setUp().
Also remove the test_default_values case because it could be tested
in the test_good_values case.

Change-Id: Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2
2015-12-28 17:28:04 +08:00
Jenkins
f5604366f0 Merge "Trivial: Remove useless return from files in image and volume" 2015-12-28 05:37:53 +00:00
Xi Yang
8210ba7a55 Replace assertEqual(None, *) with assertIsNone(*)
This patch is going to replace assertEqual(None, *) with
assertIsNone(*) in unit test code to have more clear messages
in case of failure.

Change-Id: I6f85498347e8fc7cad5ea7afb832b9acda7daafc
2015-12-25 13:14:33 +08:00
Richard Theis
7a1a59e5bb Functional tests for security group rule
Add functional tests for the "security group rule" commands.

Change-Id: Ia03886e92632f37a3d2625df1c3fa7c2a536c564
Partial-Bug: #1519512
Related-to: blueprint neutron-client
2015-12-23 15:15:06 -06:00
Richard Theis
0e38ef8484 Improve output for "os security group show"
Improve the security group rules output when running the
"os security group show" command. Each security group rule
is now displayed on a separate line.

Current output example:
$ openstack security group show default
+-------------+------------------------- ... ---+
| Field       | Value                    ...    |
+-------------+------------------------- ... ---+
| description | Default security group   ...    |
| id          | 048a5fc3-3be1-407d-ae47-9...    |
| name        | default                  ...    |
| project_id  | 3b96bb2020c1459da76963f9e...    |
| rules       | [u"id='5d812367-9829-4340...t"] |
+-------------+------------------------- ... ---+

New output example:
+-------------+------------------------- ... ---+
| Field       | Value                    ...    |
+-------------+------------------------- ... ---+
| description | Default security group   ...    |
| id          | 048a5fc3-3be1-407d-ae47-9...    |
| name        | default                  ...    |
| project_id  | 3b96bb2020c1459da76963f9e...    |
| rules       | id='5d812367-9829-4340-95...lt' |
|             | id='ee451d1c-ade3-4975-8e...lt' |
+-------------+------------------------- ... ---+

Change-Id: I1386075310896c58a2b776e2bbec3603bd00eff1
Partial-Bug: #1519511
Related-To: blueprint neutron-client
2015-12-23 13:44:22 -06:00
Richard Theis
d1311f9742 Add all regions to cloud configuration
OCC now requires all regions to be listed in the cloud
configuration. Update the shell unit tests to list all
of the regions being tested.

Change-Id: Ic7300d1f708339701b5daadbf2c4769b239a2adb
Closes-Bug: #1528926
2015-12-23 12:48:45 -06:00
Jenkins
49bed38a89 Merge "Add owner validation for "openstack image create/set"" 2015-12-22 17:54:22 +00:00
Jenkins
a080227b07 Merge "TestServerGeneral: Add test for _prep_server_detail()" 2015-12-22 04:10:53 +00:00
Jenkins
e79860e495 Merge "TestServerGeneral: Add test for _format_servers_list_networks()" 2015-12-22 04:10:46 +00:00
OpenStack Proposal Bot
0ea5c0351b Updated from global requirements
Change-Id: I589f0463cb9696586fa3ed7ed0bb756d155cc0e5
2015-12-21 23:45:24 +00:00
xiexs
0a444fc949 Add owner validation for "openstack image create/set"
Owner validation is necessary if a new image owner
will be created/set.

Change-Id: I621774e02866bfa98a31b613deff5d7b6a962737
Closes-Bug: #1517134
2015-12-21 11:17:42 -06:00
Tang Chen
17f3685a83 TestServerGeneral: Add test for _prep_server_detail()
1. Make TestServerGeneral inherit from TestServer because
   we need to use servers_mock, image_mock and flavor_mock
   in compute_client.
2. Create a dict containing all info of a server in the
   original format, and pass it to _prep_server_detail().
3. Compare the original and formatted dict.

Change-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf
Implements: blueprint osc-unit-test-framework-improvement
2015-12-20 11:33:46 +08:00
Tang Chen
b4660fec7d TestServerGeneral: Add test for _format_servers_list_networks()
The items in a dict are in random order. So if a server is in two networks,
there may be two results after formatted.

Change-Id: I2e15d202639e3fff427935f46650a405b0e51bcc
Implements: blueprint osc-unit-test-framework-improvement
2015-12-20 11:24:12 +08:00
Jenkins
b611045639 Merge "Refactor TestImageCreate with FakeImage class" 2015-12-19 06:59:44 +00:00
Jenkins
b220f4b667 Merge "Remove list output from "compute service set"" 2015-12-18 21:40:22 +00:00
Jenkins
31b5a22db8 Merge "Add image re/deactivate commands" 2015-12-18 21:40:04 +00:00
Tang Chen
f552302b61 Trivial: Remove useless return from files in image and volume
Change-Id: I3526ecd202d0908d91305a066ad72d03cee794b5
2015-12-18 23:25:05 +08:00
Jenkins
5840dd5a77 Merge "TestServerGeneral: Add test for _format_servers_list_power_state()" 2015-12-17 21:09:46 +00:00
Jenkins
d66e666b67 Merge "Replace assertEqual(None, *) with assertIsNone in tests" 2015-12-17 19:38:09 +00:00
Tang Chen
e590597871 Trivial: Remove useless return from files in network
Change-Id: Ib871fbde7c7140eca875403332ad5ab65a7e940d
2015-12-18 18:05:41 +08:00
Richard Theis
96cc5eb354 Add support to list all security group rules
Both nova and neutron allow security group rules to be listed without
specifying the owning security group. This patch set makes the
group argument on 'os security group rule list' optional. Behavior
is unchanged when the argument is specified. When the argument is
not specified then all accessible security group rules will be listed.
The listing will include the owning security group for each rule.

Change-Id: I6914baecf70a65354e1e82dad92c6afbd32b4973
Related-Bug: #1519512
2015-12-17 12:49:13 -06:00
SaiKiran
fe7d2d12c0 Replace assertEqual(None, *) with assertIsNone in tests
In python-openstackclient some test cases using asserEqual(None, *)
instead of assertIsNone(). assertIsNone method provides clear error message.

Change-Id: I3069a6436d11efa513ae94f21ceab46c498d6e25
Closes-Bug: #1527054
2015-12-17 17:10:37 +05:30
Jenkins
251939fb36 Merge "Trivial: Remove useless return from files in compute." 2015-12-16 14:56:41 +00:00
Tang Chen
494659fbe4 Trivial: Remove useless return from files in compute.
Change-Id: I9dc6749256fcd53d292d7f658912c032e9ce9df5
2015-12-17 09:34:12 +08:00
NiallBunting
b3943d7142 Add image re/deactivate commands
This change allows admins to deactivate and reactivate their
images. Currently this has to be done with the REST api or the
glanceclient.

This change introduces `--deactivate` and `--activate` for the `image
set` command.

This requires glanceclient 1.2.0. Which got bumped here:
https://review.openstack.org/#/c/257512/

Change-Id: I476c44a0343cdc92d58ddc93fb06470242de2345
Depends-On: I2c370c6bf6ff664d94d756cc76aaa983fbdb8869
Closes-Bug: 1516661
2015-12-16 14:25:41 +00:00
Jenkins
d72f6228cf Merge "Router: Add "router show" command using SDK" 2015-12-16 09:56:11 +00:00
Tang Chen
408dc7b290 Router: Add "router show" command using SDK
This patch adds "router show" command to osc using sdk.

Change-Id: Idb0f7f0376926e97f9f70a52ef21511e7ffa9d92
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-17 09:19:40 +08:00
Tang Chen
8a805dae0c Router: Add "router set" command using SDK
This patch adds "router set" command to osc using sdk.

NOTE: Setting ha property of a router is not supported for now.
      Will suppport it in another patch.

Change-Id: I9c15249ae61a87291f0728ad1c8f0a98aa8119bf
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-17 00:20:14 +08:00
Jenkins
5a387695cc Merge "Router: Add "router set" command using SDK" 2015-12-16 09:55:08 +00:00
Jenkins
1c5528d5cb Merge "Network: Improve no option test for "network create"." 2015-12-16 07:02:06 +00:00
xiexs
556397aae7 Refactor TestImageCreate with FakeImage class
Change-Id: I0044df36bb4d761c7998dfc8aa9a86d21d81da83
Implements: blueprint improve-image-unittest-framework
2015-12-16 09:25:42 +08:00
Jenkins
5ce02deac4 Merge "when fetching object store properties use lower()" 2015-12-15 23:47:56 +00:00
OpenStack Proposal Bot
1a3068d729 Updated from global requirements
Change-Id: Ibef84b93179904c124fc493a51e4855512ddf755
2015-12-15 19:00:09 +00:00
Jenkins
b78ce592b0 Merge "Removes MANIFEST.in as it is not needed explicitely by PBR" 2015-12-15 18:36:04 +00:00
Jenkins
5736d1e00c Merge "Router: Add "router delete" command using SDK" 2015-12-15 15:42:49 +00:00
Tang Chen
3364855a22 Router: Add "router delete" command using SDK
This patch adds "router delete" command to osc using sdk.

Change-Id: I47d0ca7f7984942ffceaeb1c9ac69efd09145f40
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-16 14:14:41 +08:00
Jenkins
25666684d2 Merge "Router: Add "router create" command using SDK" 2015-12-15 15:37:36 +00:00
Tang Chen
bd0bed7467 Network: Improve no option test for "network create".
Currently, test_create_no_options() case actually takes a 'name' arg.
Rename it to test_create_default_options, and add a test_create_no_options
case taking nothing.

Change-Id: I4f9d2e8cbfa843faea641d3cc959f96894c9cd5d
2015-12-15 13:22:00 +00:00
Jenkins
d97e6c80fa Merge "Add multi deletion testcase for "openstack image delete"" 2015-12-15 07:37:48 +00:00
Jenkins
24af1bf595 Merge "Refactor TestImageDelete with FakeImage" 2015-12-15 06:39:22 +00:00
Tang Chen
6158ebb0e0 Router: Add "router create" command using SDK
This patch adds "router create" command to osc using sdk.

NOTE: Test for --project needs support for fake identity client v2 and v3.
      These tests will be added in other patches.
NOTE: external_gateway_info and routes are not supported to be passed to
      create command now. They will be supported in another tow patches.
NOTE: Creating a ha router is not supported for now. Will support it in
      another patch.

Change-Id: I7642295d27c27dd498331ae1da1c293706d8f6af
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-15 09:42:41 +08:00
Jenkins
c47aa52c43 Merge "Trivial: Improve unclear comments in test_server.py" 2015-12-14 22:47:35 +00:00
Jenkins
79e67089dd Merge "Remote security group name not displayed for rule" 2015-12-14 22:29:38 +00:00
Richard Theis
079123bb0b Remote security group name not displayed for rule
The 'security group rule list' command was updated to display the
remote security group name for a security group rule. This was done
via a new 'Remote Security Group' column. The output of the
'security group rule create' and 'security group show' commands was
also updated to include 'remote_security_group' information instead
of the raw 'group' information returned from the API layer.

Change-Id: I5f9600338c8331966d2c658109a24b502c538106
Closes-Bug: #1520003
2015-12-14 14:48:19 -05:00
Steve Martinelli
74a6a81ae9 when fetching object store properties use lower()
sometimes properties within object store concepts are stored with
mixed case depending on the client used to store said properties.

when retrieving properties to 'show' the user, always call lower()
on the property in question when comparing it to the reserved
values of the swift API.

Change-Id: I97ffc715788ca3cd021413124b6945a399465c99
Closes-Bug: 1525805
2015-12-14 12:23:44 -05:00
Richard Theis
7b110511d2 Doc: Add optional command specs process
The developer documentation has been updated to include an
optional command specs process. This process may be used
to work out the specifications for new commands, objects
and actions before their implementation.

This new process could assist in the implementation of
additional neutron support in OSC.

Change-Id: I62f7472435a9caacee0d1b4c8d35417c123b5a44
2015-12-14 08:40:30 -06:00
sonu.kumar
01ef42c8b4 Removes MANIFEST.in as it is not needed explicitely by PBR
This patch removes `MANIFEST.in` file as pbr generates a sensible
manifest from git files and some standard files and it removes
the need for an explicit `MANIFEST.in` file.

Change-Id: I78b28bf2fe60dc64cf6c3894da36f683a2e0bb30
2015-12-14 13:05:01 +05:30
Jenkins
1ee5191cec Merge "Deprecated tox -downloadcache option removed" 2015-12-13 22:12:05 +00:00
OpenStack Proposal Bot
cb81232254 Updated from global requirements
Change-Id: Ie88d50a9c1539ad24e0f8dae8ee5155ad467a0c0
2015-12-11 22:53:43 +00:00
Ondřej Nový
0a132d3256 Deprecated tox -downloadcache option removed
Caching is enabled by default from pip version 6.0

More info:
https://testrun.org/tox/latest/config.html#confval-downloadcache=path
https://pip.pypa.io/en/stable/reference/pip_install/#caching

Change-Id: I521b7cb11374f0600d1f6d4c6529e95aa29654b0
2015-12-11 23:30:31 +01:00
Jenkins
8ee3380fa2 Merge "Router: Add "router list" command using SDK" 2015-12-11 20:42:21 +00:00
Jenkins
5f7a295b52 Merge "Router: Add class FakeRouter to test "router xxx" command" 2015-12-11 20:19:17 +00:00
Jenkins
a25222cae5 Merge "Trivial: Fix parameter name typo in network.rst" 2015-12-11 19:09:50 +00:00
Tang Chen
3278b3a022 Router: Add "router list" command using SDK
Add "router list" command. It takes one "--long" option.

By default, the command will print router id, name, status,
admin state up, distributed, ha and project id.

With "--long" option, it will also print routes and
external gateway info.

Change-Id: I9d21904c41c11ee1fa107f985744878a1dc2f970
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-11 18:07:47 +00:00
Tang Chen
185412f28c Router: Add class FakeRouter to test "router xxx" command
A unit test class similar to FakeServer, which is able to fake one
or more routers. It will be used by the router CRUD patches.

Change-Id: I9b87c6c95282902c3a829da51229a35d4265a1e4
Implements: blueprint neutron-client
Partial-bug: #1519503
2015-12-11 17:52:19 +00:00
Jenkins
785caf503f Merge "Add source security group support to create rule" 2015-12-11 17:40:11 +00:00
Tang Chen
6f7c705d4a Trivial: Improve unclear comments in test_server.py
In test_server.py, there are two ImageManagers are faked:
1. the one in compute client
2. the one in image client
But the comments are the same. And so is volume.

This patch makes the comments more clear.

Change-Id: I2c52f48a7b3c005c185a4ac64abbb3e18d5fb3de
2015-12-11 17:18:28 +08:00
David Moreau Simard
a526777218 Make --image parameter optional in "server rebuild"
The command will now default to the image currently in-use by
the server, effectively making the --image parameter optional.

This commit also adds basic tests for ServerRebuild since there
wasn't any. Will add more full tests for it.

Change-Id: I733fd3ad5a825f06563c72aa430122e1a0e3b3b0
Closes-bug: #1524406
Co-Authored-By: David Moreau Simard <dms@redhat.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-11 15:34:26 +08:00
Tang Chen
4221bc282d Trivial: Fix parameter name typo in network.rst
1. "network delete" takes network name or ID, not project
2. "network set/show" takes network name or ID, not only name.
   So use network, not name.

Change-Id: I13835fea1d0151ea0cd93e250b022c9daf74b537
2015-12-11 07:31:34 +00:00
Tang Chen
2caf7b19e2 Trivial: Do not use plural format in command parameter in "network delete"
Since "network delete" could delete more than one network,
add a (s) to the doc.

And also, rename the parameter "networks" to "network".
The naming style is not using plural format in parameter.

Change-Id: Id434ea905af34457f84ea6bcb18addef5800429a
2015-12-11 19:39:36 +08:00
Jenkins
67090b77b2 Merge "The format_exc method does not take an exception" 2015-12-11 02:34:37 +00:00
Terry Howe
1cf320302b Map some of the SDK field names
The keys() method returns the keys returned from Neutron, but
the SDK maps some things like tenant_id to project_id.  This
makes the output a little prettier.

Change-Id: Ibd8c890b61ffc94021f93fc1051fcf5dabd1e9ea
2015-12-10 15:22:38 -07:00
Jenkins
823ba770e0 Merge "Fix "sevice show" cannot catch NoUniqueMatch Exception" 2015-12-10 18:37:18 +00:00
Jenkins
f2339e94b0 Merge "Add unit test for TestServerList to test --long option." 2015-12-10 18:25:40 +00:00
Jenkins
24712ba6ea Merge "Remove python-neutronclient requirement" 2015-12-10 18:23:03 +00:00
Tang Chen
a8ba54562b TestServerGeneral: Add test for _format_servers_list_power_state()
If we have tests for each helper function, then we can call them
in other tests without worrying about error.

Change-Id: I1e4273aef201fe9d8936e5c365ebb46068039892
Implements: blueprint osc-unit-test-framework-improvement
2015-12-10 17:11:41 +08:00
Richard Theis
8485a52b99 Remove python-neutronclient requirement
Now that the neutron support is using the openstacksdk
requirement, the python-neutronclient requirement can
be removed.

Change-Id: Ieefac297e136f2f2997ec41cef2673e814c75b55
Related-to: blueprint neutron-client
2015-12-09 15:50:17 -06:00
Terry Howe
f65f82e435 Fix poorly named test mocks
Change-Id: I6e2911e88fc458b39d5024a5714ed8af3f519946
2015-12-09 11:59:30 -07:00
Terry Howe
7a42174c4b Remove old code after sdk integration
We won't need this anymore.

Change-Id: Ib10be1dedb8db81f0cba6e45b8a9b0aade2ab473
2015-12-09 11:45:59 -07:00
Terry Howe
7aa6e5e36c SDK integration extensions and server create networks
Finish up the SDK integration with server create network and port
find and extension list.

Change-Id: I18dbada784d8aa92a45a937f251023ddf899c53e
2015-12-09 11:39:20 -07:00
Tang Chen
6a5be8c4c9 Add unit test for TestServerList to test --long option.
In two steps:
1. Setup all necessary attributes of a server in setUp(), including
   the ones that are not faked in FaseServer by default.
2. Run a similar process with no option test case.

The future plan is to move all these attributes to FakeServer.
But it will cause some other changes which has nothing to do with
this patch. So leave this job to do later.

Change-Id: I1134812a0ea146ef737b0f0ffbef8ca23684accd
Implements: blueprint osc-unit-test-framework-improvement
2015-12-09 19:42:52 +08:00
xiexs
50e52f355f Add multi deletion testcase for "openstack image delete"
Change-Id: I5442128a290a9ad3b9ff9919431a1ecc0c697dad
Implements: blueprint improve-image-unittest-framework
2015-12-09 17:58:11 +08:00
xiexs
d377756a62 Refactor TestImageDelete with FakeImage
Change-Id: I052a0220ca5d974824fc46ad403234e65e8173aa
Implements: blueprint improve-image-unittest-framework
2015-12-09 17:55:39 +08:00
Jenkins
ccbffb2ef9 Merge "Use FakeVolume in server test cases." 2015-12-09 04:14:56 +00:00
Jenkins
dc5bd94213 Merge "Use FakeImage in server test cases." 2015-12-09 04:14:53 +00:00
Jenkins
e4cbc4485f Merge "Remove unuseful test data in test_netwrok.py" 2015-12-09 04:14:50 +00:00
Tang Chen
55480d014c Remove unuseful test data in test_netwrok.py
Change-Id: Ibd4f8bb602acdcc3421205d9dafc8dcafb9645df
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-09 13:38:36 +08:00
Jenkins
805e8f89c9 Merge "Migrate network client to SDK." 2015-12-09 04:14:47 +00:00
Jenkins
766354990d Merge "Migrate "network show" command to use SDK." 2015-12-09 04:14:45 +00:00
Jenkins
45a330ca4e Merge "Migrate "network set" command to use SDK." 2015-12-09 04:14:41 +00:00
Jenkins
f9c7baad0e Merge "Migrate "network delete" command to use SDK." 2015-12-09 03:50:46 +00:00
Jenkins
761657c8e8 Merge "Migrate "network create" command to use SDK." 2015-12-09 03:32:08 +00:00
Tang Chen
4be716eb27 Migrate network client to SDK.
The previous patches have migrate all network commands to
the new version using sdk. This patch will remove the
temporary method, and implement a new make_client() to
create sdk network client.

And also, find() in openstackclient/network/common.py must
support sdk. The logic of this function will become much
easier than before, so this patch also removes two useless
test cases of find().

This patch will also remove the patched methods in tests.

Change-Id: Ic2f7bca073beb9757172d16f95d9b82c48cbbc12
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-09 09:30:29 +08:00
Tang Chen
2a2cb4f75d Migrate "network show" command to use SDK.
This patch makes "network show" command use sdk.

Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.

There are two same test cases in the unit tests. This
patch will remove one.

And since the output has changed, we also need to fix
function test cases.

Change-Id: I4c06b4efad2db430767bbaa882b0876df3ab483a
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-09 09:30:13 +08:00
Tang Chen
45c644d428 Migrate "network set" command to use SDK.
This patch makes "network set" command use sdk.

Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.

Change-Id: I794ac4b82d9200747298f1a9ee44611140e9b6d0
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-09 09:29:54 +08:00
Tang Chen
511e862294 Migrate "network delete" command to use SDK.
This patch makes "network delete" command use sdk.

Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.

Change-Id: I1f2c404e4b0ff6727e4c535ce543aa406f2290ce
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-09 09:29:39 +08:00
Tang Chen
0b4fb0bb66 Migrate "network create" command to use SDK.
This patch makes "network create" command use sdk.

Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.

Change-Id: I06559c675be1188747257f72f18d6b4d420d0285
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-09 09:29:26 +08:00
Min Min Ren
b98aee57c1 Fix "sevice show" cannot catch NoUniqueMatch Exception
Fix a bug for "service show" subcommand cannot cache NoUniqueMatch Exception

Change-Id: I393c5417de0fef424618b08119ddbc8fea27e114
Closes-Bug: #1524305
2015-12-09 05:47:12 +08:00
Jenkins
9bff399ff3 Merge "Integrating mistralclient with openstackclient" 2015-12-08 18:15:49 +00:00
Terry Howe
2348617606 The format_exc method does not take an exception
For py35, this call blows up.  Seems to be ignored for py27, but
even in py27, it doesn't take an exception.

https://docs.python.org/2.7/library/traceback.html
https://docs.python.org/3/library/traceback.html

Change-Id: I2602426b966045b15b96e5e41d0df6524ed05119
2015-12-08 09:23:47 -07:00
Tang Chen
56150de224 Migrate "network list" command to new version using SDK.
This patch makes "network list" command use sdk.

Since we have to keep the other commands runnable with
the old network client, we use a temporary method to
create sdk network client. And as a result, the tests
need to patch a method to fake the temporary method,
which will be removed at last.

Change-Id: I0882501cd7bb2c17917e10a6da4298f1452c9765
Implements: blueprint neutron-client
Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-08 23:24:20 +08:00
Tang Chen
85d6aeea32 Trivial: Coding style fix in test_flavor.py
Change-Id: I3dcb3c4fbd9ff9c351426ae2ad9da009208a6485
2015-12-08 13:35:51 +08:00
Tang Chen
ec79d338f7 Use FakeVolume in server test cases.
We have a class FakeVolume to fake one or more volumes. So use it in
test_server.py.

Change-Id: I735ae7f678a6799e0ae4c7c25c8083d9ebf47b09
Implements: blueprint improve-volume-unittest-framework
2015-12-08 10:36:25 +08:00
Tang Chen
a4696dce1e Use FakeImage in server test cases.
We have a class FakeImage to fake one or more images. So use it in
test_server.py.

Change-Id: I276e4ade5aecefbe66b9722c1dfbac10b3bd14b6
Implements: blueprint improve-image-unittest-framework
2015-12-08 10:05:36 +08:00
Richard Theis
566388ab1e Add source security group support to create rule
The 'security group rule create' command was updated to support a
source security group. Now either a source IP address block or source
security group can be specified when creating a rule. The default
remains the same.

Change-Id: If57de2871810caddeeaee96482eb34146968e173
Closes-Bug: #1522969
2015-12-07 12:42:10 -06:00
Tang Chen
481b711fae SDK integration: Add a temporary method to create network client using sdk.
This patch adds a temporary method to create a network client using sdk.
This method will help to migrate network commands from neutronclient to sdk
one by one. The command which is being migrated will use this temporary
method to create the sdk client, and the rest ones will use the old client.

The temporary method will finally be removed and implement the same thing
in make_client().

This patch will also add sdk to requirements file.

And adds some formatter helper functions, which will be used in class
CreateNetwork, ListNetwork and ShowNetwork.

This patch is splited from TerryHowe <terrylhowe@gmail.com> 's original patch.

Change-Id: Ie9b35747680afeb66cf6922e2c654fbca7e03569
Implements: blueprint neutron-client
Co-Authored-By: TerryHowe <terrylhowe@gmail.com>
Co-Authored-By: Tang Chen <tangchen@cn.fujitsu.com>
2015-12-07 22:44:23 +08:00
Tang Chen
6a3bc765f4 Introduce class FakeNetwork to fake one or more networks.
Introduce a new class FakeNetwork to fake one or more Network
objects so that we don't need to initialize objects once and
once again in each test case.

Change-Id: I519e5368025946a737002a2e97bc218b65a78fa2
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-07 22:44:23 +08:00
Jenkins
695500496c Merge "Use formatter in server.py for "server list" tests." 2015-12-07 03:48:48 +00:00
Tang Chen
0d7be6fbcb Use formatter in server.py for "server list" tests.
We should use the formatter in the original code to set the
expected data in each test case.

The same problem exists in other test cases, like "server create".
But data structure in TestServerCreate is different from TestServerList,
so will fix the problem in another patch.

Change-Id: I233f7a91cd4cc1e996941e26ea85490fa3290572
2015-12-07 22:16:04 +08:00
OpenStack Proposal Bot
7d01a44822 Updated from global requirements
Change-Id: I7910586e32ec248e95f7f54fe776b3603f667c49
2015-12-06 20:47:37 +00:00
Jenkins
000b3c6dea Merge "Refactor network test: Remove unusful test code." 2015-12-06 04:07:46 +00:00
Jenkins
e19d49ba08 Merge "Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork" 2015-12-06 04:04:12 +00:00
Jenkins
57c4385ef3 Merge "Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork" 2015-12-06 03:52:30 +00:00
Jenkins
19d9ccb97a Merge "Refactor TestListNetwork: Use TestNetwork in TestListNetwork" 2015-12-06 03:30:27 +00:00
Jenkins
8e4a386153 Merge "Refactor TestDeleteNetwork: Use TestNetwork in TestDeleteNetwork" 2015-12-06 03:27:43 +00:00
Jenkins
0cafffa4b2 Merge "Trivial: Import network.common as network_common in server.py" 2015-12-05 23:24:18 +00:00
Jenkins
27037a43db Merge "Refactor TestCreateNetwork: Setup identity client in setUp() in TestCreateNetworkIdentityV2" 2015-12-05 20:17:03 +00:00
Jenkins
08ba88da48 Merge "Refactor TestCreateNetwork: Setup identity client in setUp() in TestCreateNetworkIdentityV3" 2015-12-05 19:50:15 +00:00
Tang Chen
dd1ca68f56 Trivial: Import network.common as network_common in server.py
In server.py, identity.common is imported as identity_common.
But network.common is imported as common, which is confuseing.
This patch imports network.common as network_common.

Change-Id: I74295bc88b22de398ab64fe556aedaca2453d17d
2015-12-06 01:18:13 +08:00
Jenkins
26a7e8d2ef Merge "Refactor TestCreateNetwork: Setup cmd in setUp() in TestCreateNetworkIdentityV2" 2015-12-05 17:17:25 +00:00
Jenkins
92a1a27edc Merge "Refactor TestCreateNetwork: Setup cmd in setUp() in TestCreateNetworkIdentityV3" 2015-12-05 17:11:49 +00:00
Jenkins
c1e4e25991 Merge "Refactor TestCreateNetwork: Split TestCreateNetwork into two classes for identity v2 and v3" 2015-12-05 16:35:21 +00:00
Jenkins
42c5d2ee1b Merge "Refactor network test: Introduce TestNetworkv2 and TestNetwork to improve unit test of network" 2015-12-05 15:53:05 +00:00
Jenkins
e93e1493b6 Merge "Trivial: Improve doc for "server create" command" 2015-12-05 09:14:43 +00:00
Tang Chen
0bb645cb99 Refactor network test: Remove unusful test code.
openstackclient/tests/network/common.py won't be used anymore. Remove it.

Change-Id: I641f6d44852931e31ecda22261bfbc9f451446de
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
0cc1492ccd Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork
There are severail problems in TestShowNetwork:
1. NETWORK_ITEM is not used.
2. Some redundant code.
3. The param n_mock is used to fake find_attr(), but the name is confusing.
   So rename it to find_attr().

This patch fixes them.

Change-Id: I7bc909057125013fb9d215e92c61f847300f93e2
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
84cf168d1c Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork
Use TestNetwork in TestSetNetwork, and also setup test command
in setUp().

Change-Id: I4e72332fcf253407bb3d5f20aaf4be047046e146
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
697df67611 Refactor TestListNetwork: Use TestNetwork in TestListNetwork
Abstract cloumns and data out in TestListNetwork so that they
can be reused by each case.

Also rename n_mock to network_list because it is used to fake
function network_list().

Change-Id: I3f65f7bd6c587c167dc1cf8b6d34e003c6454e57
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
d1fffb2543 Refactor TestDeleteNetwork: Use TestNetwork in TestDeleteNetwork
Make TestDeleteNetwork inherit from TestNetwork, and have the same class architecture
as the other test classes.

Change-Id: I37047d7d13931b2a8f25665d6427efc05fc4f989
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
ee6855858f Refactor TestCreateNetwork: Setup identity client in setUp() in TestCreateNetworkIdentityV2
This patch setup the v2 identity client only once in setUp() for TestCreateNetworkIdentityV2.

Change-Id: I9d7a83e5e67e810a5c5f760fb9c40ce450f7dc99
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
16d07e7101 Refactor TestCreateNetwork: Setup identity client in setUp() in TestCreateNetworkIdentityV3
This patch setup the v3 identity client only once in setUp() for TestCreateNetworkIdentityV3.

Change-Id: Ia20db01af85f868a88bf905174b8556979b0a39a
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
3cc38d2844 Refactor TestCreateNetwork: Setup cmd in setUp() in TestCreateNetworkIdentityV2
This patch setup the tested command only once in setUp() for TestCreateNetworkIdentityV2.

Change-Id: I689980674c9500c0c040d27164ec61f5fcf40ee5
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
af6269d310 Refactor TestCreateNetwork: Setup cmd in setUp() in TestCreateNetworkIdentityV3
This patch setup the tested command only once in setUp() for TestCreateNetworkIdentityV3.

Change-Id: Iff5119fa24c9cc0caa72ff0e8f63e8dcac72470a
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
038334ff98 Refactor TestCreateNetwork: Split TestCreateNetwork into two classes for identity v2 and v3
In TestCreateNetwork, both Identity v2 and v3 clients are tested. As a result, we should
initialize the identity client again and again in each test function.

To reduce redundant code, this patch split TestCreateNetwork to TestCreateNetworkIdentityV2 and V3.
And then initialize the identity client only once in each of them.

Change-Id: I349fe7f827524beb541efe7dd9460c534254b80c
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Tang Chen
29b9945677 Refactor network test: Introduce TestNetworkv2 and TestNetwork to improve unit test of network
The class inherit architecture in network unit test is different from other test classes,
which leads to lots of redundant code. This patch will make it the same as the other test
classes. And it will be more convenience for the coming up refactor.

Change-Id: I6f239dd54b9401ff2bbcf7ffdeb18769a450f573
Implements: blueprint osc-network-unit-test-refactor
Related-to: blueprint neutron-client
2015-12-05 10:52:05 +08:00
Jenkins
a207c27fc8 Merge "Add --volume to Image create" 2015-12-04 10:36:45 +00:00
Jenkins
b5d1192768 Merge "Trivial: Remove unuseful doc of "network list" command." 2015-12-04 08:20:10 +00:00
Tang Chen
b4e88aa3ce Trivial: Remove unuseful doc of "network list" command.
There is actually no "--dhcp" option in "network list" command.
So remove the doc from .rst file.

Change-Id: I481b260f99be635be4de8e6780206af47cdaa7ce
2015-12-05 10:43:06 +08:00
Jenkins
2a8b5798be Merge "Introduce FakeImage class" 2015-12-04 03:51:35 +00:00
Tang Chen
ca76260bf8 Trivial: Improve doc for "server create" command
The following options of "server create" command support searching
by both name and ID. So add this info into doc.

--image, --volume, --flavor, --security.

Change-Id: I93b167da58144e5de6c9996009b7ea2449fb4cd8
2015-12-04 11:51:15 +08:00
Jenkins
ff48f92128 Merge "Updated from global requirements" 2015-12-03 21:40:48 +00:00
Jenkins
4ed9e88078 Merge "Support "server list" searching by both image name and ID." 2015-12-03 20:36:59 +00:00
Jenkins
c39b720f00 Merge "Support "server list" searching by both flavor name and ID." 2015-12-03 20:36:48 +00:00
Jenkins
5645c0e11d Merge "Add multi deletion testcase for openstack volume delete" 2015-12-03 20:31:21 +00:00
Jenkins
74283637ce Merge "Fix exception when doing volume set operation" 2015-12-03 16:15:56 +00:00
OpenStack Proposal Bot
ad17d847f8 Updated from global requirements
Change-Id: I3ca62d29df56ec45bf1fe10d920c1f9ed5f5b4f1
2015-12-03 15:07:55 +00:00
Xi Yang
197d86dffa Fix exception when doing volume set operation
The v2 SetVolume extends from show.ShowOne and returns None
after setting volume operation. It will raise an exception.
This patch is going to fix the issue by changing the parent
class of SetVolume to command.Command.

Change-Id: Iefa453fe4adad06f2a0601a052c01e74004be5b7
Closes-bug: 1521896
2015-12-03 15:25:12 +08:00
Jenkins
9bcf17bf3e Merge "Convert 2.0 release notes to reno format" 2015-12-03 01:48:29 +00:00
Jenkins
5d71ed2b9c Merge "Add reno for release notes management" 2015-12-02 23:34:26 +00:00
Tang Chen
6cea1e0463 Trivial: Reorder doc of "server shelve" command to keep alphabetic order.
Change-Id: I616154a8c958b6980233014c7ae1c4544283d72d
2015-12-04 00:21:32 +08:00
Dean Troyer
e604a726b2 Convert 2.0 release notes to reno format
Change-Id: I3706f78152c77837ba17218d68b57ac10563bfa7
2015-12-02 14:57:27 -06:00
Dean Troyer
afd1b489ff Add reno for release notes management
Change-Id: Iaaf3f9ca7cb431e41adfb2a052e01e2240a63a07
2015-12-02 14:32:07 -06:00
Jenkins
40459b25e0 Merge "Add release notes for 2.0.0" 2015-12-02 11:29:20 +00:00
xiexs
6e747629ad Add multi deletion testcase for openstack volume delete
Change-Id: Id8e6e8311e46e4c8644d41d773aeb27416ca6a7e
2015-12-02 16:02:10 +08:00
Jenkins
a97624ba29 Merge "Switch to ksa Session" 2015-12-02 04:32:46 +00:00
Jenkins
a85880cef8 Merge "Add class TestServerList to provide basic unit test for "server list" command." 2015-12-02 03:04:26 +00:00
Tang Chen
d7c3048f56 Add class TestServerList to provide basic unit test for "server list" command.
This patch provide a class to test "server list" command. Only one simplest
case in this patch.

Some of the options in "server list" are complicated. And the server object
contains lots of attributes need to be handled in specific ways. So other
test cases will be added in other patches.

Change-Id: Id9fdba8f149bd74187aa42516067dacebc6962b5
Implements: blueprint osc-unit-test-framework-improvement
2015-12-02 19:29:40 +08:00
Tang Chen
d37d27b2d6 Enable setup_servers_mock() to take attributes param.
setup_servers_mock() is now able to set methods to the fake servers.
But it cannot set attributes. This patch enable it to do so.

This will be useful in "server list" test cases.

Change-Id: Ic30d750ebe4650244707a368cdd5d622a8f1b8ed
Implements: blueprint osc-unit-test-framework-improvement
2015-12-02 19:27:06 +08:00
Jenkins
fdcb56d7c4 Merge "Enable setup_servers_mock() to take attributes param." 2015-12-02 03:04:23 +00:00
xiexs
3f7c01cae5 Introduce FakeImage class
Introduce FakeImage to improve the current image unittest framework
with following two advantages:
1. generate more than one faking images
2. all faking images generated by random

Change-Id: Ide326fa2a047ddeea478bef97000083617a0b744
Implements: blueprint improve-image-unittest-framework
2015-12-02 10:17:51 +08:00
Dean Troyer
bf090c69c2 Switch to ksa Session
* Change session imports to keystoneauth1
* Change keystoneclient.exception imports to keystoneauth1
* Change exceptions raised from internal API from keystoneclient to openstack.common

Change-Id: I046d89f561d6fe04baae53726f9749d2e7fe2056
2015-12-02 01:55:14 +00:00
Jenkins
a9a7caf934 Merge "autodocument commands from plugins using stevedore.sphinxext" 2015-12-01 23:27:08 +00:00
Steve Martinelli
51e3105468 Add release notes for 2.0.0
Change-Id: I878609870701abaef60d49813b3184f473d936bf
2015-12-01 16:13:43 -06:00
Tang Chen
106f928cb6 Support "server list" searching by both image name and ID.
Nova API only supports list servers searching by image ID.
In OSC, we can support both image name and ID by mapping
the name to ID.

This patch also fix the inconsistent doc in .py and .rst files.

Closes-Bug: 1521492

Change-Id: I70613843f82d74732bd32a457cd4a31aba57825f
2015-12-01 06:59:22 +00:00
Tang Chen
0069a01967 Support "server list" searching by both flavor name and ID.
Nova API only supports list servers searching by flavor ID.
In OSC, we can support both flavor name and ID by mapping
the name to ID.

This patch also fix the inconsistent doc in .py and .rst files.

Partial-Bug: 1521492

Change-Id: I1d1a6aa91aef4e2846745babe8382481185fa96e
2015-12-01 06:59:08 +00:00
Steve Martinelli
727792da17 autodocument commands from plugins using stevedore.sphinxext
conflicting command names are a painpoint, so is manually updating
a list. let's autodocument the commands that are being use by
existing osc supporters.

Change-Id: If37d81dfd57cc79803668b64be1ccd776e319572
2015-12-01 01:23:56 -05:00
xiexs
fad7126e79 Remove list output from "compute service set"
Replace the super class from lister.Lister to command.Command,
as no need to display the status for the "set" command.

Change-Id: Ibaf3c1e349633223fca19937bbd9060d4f9ecbda
Closes-Bug: #1517804
2015-12-01 06:18:13 +00:00
Jenkins
cb73e781e0 Merge "Introduce FakeVolume class" 2015-12-01 04:20:45 +00:00
Jenkins
b221f2ceac Merge "Add --limit option to "server list" command." 2015-12-01 03:00:52 +00:00
Tang Chen
43c11c356b Add --limit option to "server list" command.
This option will limit the total amount of items the command will list up.

Change-Id: I46af0d479d795ebb6a74585d0f76629dd940b117
2015-12-01 10:12:58 +08:00
Jenkins
fc299fd190 Merge "Updated from global requirements" 2015-12-01 02:00:56 +00:00
Tang Chen
b36b477e81 Add --marker option to "server list" command.
This option will give user a chance to display the server list
from wherever they want.

Change-Id: I92cca5e98cd473f1113a9106eb9d1f490694b1fe
2015-12-01 09:30:43 +08:00
Jenkins
bf95d74c2d Merge "Add a changelog to see all changes into tagged releases" 2015-12-01 00:42:29 +00:00
Jenkins
b4b1a84bf9 Merge "Remove LICENSE APPENDIX" 2015-12-01 00:42:26 +00:00
Jenkins
5ad7dcd899 Merge "Add unit testcases for "openstack flavor delete"" 2015-12-01 00:27:15 +00:00
Jenkins
fcc1c0d68a Merge "Consistency of the --all argument for snapshots" 2015-12-01 00:27:11 +00:00
Jenkins
e6057f088b Merge "Add project name/ID validation for "openstack quota show"" 2015-12-01 00:03:10 +00:00
Jenkins
10aa2d9b0f Merge "Add status column for "openstack image list"" 2015-11-30 23:47:15 +00:00
OpenStack Proposal Bot
cb31eb8363 Updated from global requirements
Change-Id: Ia957c7f6023e1ac976a291fd081538c90870c802
2015-11-30 16:55:12 -06:00
Steve Martinelli
43fbe569a5 Add a changelog to see all changes into tagged releases
in addition to release notes, it'll be nice to also see the
changelog that happened between releases.

Change-Id: I4548be22c377ec12f0398a248391384126506715
2015-11-30 16:30:42 -05:00
Jenkins
0cdfa62383 Merge "Remove py26 support" 2015-11-30 20:06:14 +00:00
Jenkins
e63de0db2d Merge "Add --marker option to "server list" command." 2015-11-30 18:58:14 +00:00
Lingxian Kong
aca279a983 Integrating mistralclient with openstackclient
Change-Id: Ie54d7c15366a8272eefa94c0d8d2430428bdc590
Depends-On: Ic099aaec88377a76a17700c33fed944e52ec5633
2015-12-01 00:25:36 +08:00
Jenkins
cbd4f67b04 Merge "Add testcases for compute.v2.service" 2015-11-30 13:09:59 +00:00
xiexs
eb8672978c Add testcases for compute.v2.service
Add a set of testcases to test the classes of
ListService and SetService in the compute.v2.service.
And to be consistent with cinder term, use service_binary
to represent the service binary.

Change-Id: I9fe740f07c9ce3afdba7b7cca152d614170abb96
2015-12-01 10:09:54 +08:00
Jean-Philippe Evrard
9168373b3d Consistency of the --all argument for snapshots
This change is inspired by the volume.py.
It allow the user to use openstack snapshot list --all.

Closes-Bug: #1517386

Change-Id: I72a53fcd0c5c5af539cd88b37e71b4331fa67473
2015-11-30 12:54:19 +00:00
Jenkins
12cc6347e5 Merge "Use is_public to set access of volume type" 2015-11-30 10:39:16 +00:00
Jenkins
b920245f10 Merge "Add "openstack server unshelve" into OSC" 2015-11-30 10:32:13 +00:00
Jenkins
78a7eaae0b Merge "Add command wrapper doc" 2015-11-30 10:28:28 +00:00
xiexs
31c6957362 Introduce FakeVolume class
Introduce FakeVolume to improve the current volume unittest framework
with following two advantages:
1. generate more than one faking volumes
2. all faking volumes generated by random

Change-Id: I9d56efa4fd4f03c82cd4e29622b6312566dbc453
Implements: blueprint improve-volume-unittest-framework
2015-11-30 04:23:47 -05:00
xiexs
0eecedc0b6 Add unit testcases for "openstack flavor delete"
Change-Id: If23a71c678193e5c9c91300fddd17e79f674bf82
2015-11-30 00:48:32 -05:00
xiexs
0ccd2a8108 Add project name/ID validation for "openstack quota show"
A validation is necessary to check the existence of project.
This patch is similar to Ia2d8c96527820e25b074e6486d3f39c5ad7eae60.

Change-Id: Id8895ba7a21ecad05942619a82a87c0dc68eae53
2015-11-29 22:30:04 -05:00
xiexs
342fd158e9 Add status column for "openstack image list"
Actually, the status column is useful for the user.
So, it`s better to output this info by default (or, user had
to specify the extra option, i.e. --long).

Change-Id: Id2a9f86f0de5310f8f5ff9a46bf1b7411094b519
Closes-Bug: #1519181
2015-11-29 20:37:40 -05:00
Jenkins
27869c0f3f Merge "Remove old fake flavor data." 2015-11-29 19:46:44 +00:00
Jenkins
691ca98006 Merge "Use FakeFlavor in TestServerCreate." 2015-11-29 19:46:41 +00:00
Jenkins
883278f359 Merge "User FakeFlavor in TestServerResize." 2015-11-29 15:30:53 +00:00
Jenkins
fda84a277f Merge "Use FakeFlavor in TestFlavorUnset." 2015-11-29 13:26:49 +00:00
Jenkins
d6ac1e9205 Merge "Use FakeFlavor in TestFlavorSet." 2015-11-29 12:14:58 +00:00
Jenkins
87aa46e5ca Merge "Use FakeFlavor in TestFlavorList." 2015-11-29 12:07:05 +00:00
Jenkins
c368d1b9b4 Merge "Introduce class FakeFlavor to fake one or more flavors." 2015-11-29 09:36:46 +00:00
venkatamahesh
e2d0684876 Change the home-page value in setup.cfg
Change-Id: Ib0ea7b2b6271f3fb3d0818c7fa52a51682658810
2015-11-29 02:02:57 +00:00
Tang Chen
d236a783d2 Remove old fake flavor data.
The new class FakeFlavor has been introduced to fake one or more flavors.
So use it and remove the old fake flavor data.

Change-Id: Ie3a33b36ae6e597c6a0b1d17ad13c73cf4b73bc9
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:52:03 +08:00
Tang Chen
b7f62058ad Use FakeFlavor in TestServerCreate.
Change-Id: Ib82f845258b1ad78cbc8b23d28fa42e7ccc8097a
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:52:01 +08:00
Tang Chen
c5a55d1370 User FakeFlavor in TestServerResize.
Change-Id: Iac9b4583befaa4eb79ec59c39b97c613884ef2f7
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:24:41 +08:00
Tang Chen
db516b2c96 Use FakeFlavor in TestFlavorUnset.
Change-Id: Ifbd360db39d380efd9632300367b13283ac75f54
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:14:18 +08:00
Tang Chen
dfbf41c55f Use FakeFlavor in TestFlavorSet.
Change-Id: I335298b07afb3f969c76748527dda06cb5393fa8
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:14:12 +08:00
Tang Chen
8d42da5186 Use FakeFlavor in TestFlavorList.
Change-Id: I3595877bed41bc476934ca924f1f9c8c0ad79176
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:14:04 +08:00
Tang Chen
0de260e8be Introduce class FakeFlavor to fake one or more flavors.
Change-Id: I1b20e7d50e478ce8114ca08aa455b7acad4ea7f5
Implements: blueprint improve-flavor-unit-test
2015-11-28 16:13:52 +08:00
Tang Chen
109672fecb Refactor: Move FakeFlavorResource to compute_fakes.py.
Just like FakeServer and FakeResource, FakeFlavorResource should be in compute_fakes.py.

Change-Id: I8315256fb90377605fa2190e24c9674f6aaf6efd
Implements: blueprint improve-flavor-unit-test
2015-11-28 15:25:39 +08:00
Tang Chen
f19ff68e59 Refactor: Abstract datalist out in TestFlavorList to avoid redundant code.
datalist has been set in each test case in TestFlavorList, which is not
necessary. This patch abstract it out and remove all redundant code.

Change-Id: I6f735f7d9fa29a8ab435adaef17ca559df1fdcee
Implements: blueprint improve-flavor-unit-test
2015-11-28 14:42:38 +08:00
Tang Chen
f9ca752177 Refactor: Abstract columns out in TestFlavorList to avoid redundant code.
The columns has been set in each test case of TestFlavorList, which is not
necessary. This patch abstract it out and remove all redundant code.

Change-Id: Ideb2872f073755ac251bd603fd906410ea86c4ef
Implements: blueprint improve-flavor-unit-tes
2015-11-28 14:05:20 +08:00
xiexs
af5dbf72c4 Add "openstack server unshelve" into OSC
The unshelve operation is not supported by OSC,
and this patch tries to add it.

Change-Id: Ic60a4616cb63ad21c1a3c8e02611da8bad3a8bd0
Implements: blueprint introduce-shelve-into-osc
2015-11-28 11:21:05 +08:00
Jenkins
785a1728d8 Merge "Fix a bug of "openstack volume delete"" 2015-11-27 15:22:07 +00:00
xiexs
c27f9e3c6c Fix a bug of "openstack volume delete"
While multi volumes specified for the osc "openstack volume delete",
only the last volume is deleted.
This patch tries to fix it.

Change-Id: I171b2869f85b29c88fda16eaf5bf163c55795df0
Closes-Bug: #1520541
2015-11-27 11:17:22 +00:00
Xi Yang
54b0ef3358 Use Block Storage instead of Volume
Volume is better to be replaced by Block Storage in the
doc.

Change-Id: I736669ee01c7385b6e701cb20f4334eff1c49286
2015-11-27 17:56:10 +08:00
Jenkins
8d523266fc Merge "Add unit tests for "server stop" command." 2015-11-26 20:25:55 +00:00
Tang Chen
dacd5dce28 Add unit tests for "server stop" command.
Change-Id: Idfa82f7f3aee3824aedf8b551be7942659530457
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:21:01 +08:00
Tang Chen
cfff32aed6 Add unit tests for "server start" command.
Change-Id: I19060419a17b8e081e8f51c08959f24b84e7e570
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:20:07 +08:00
Tang Chen
9f38df9208 Add unit tests for "server resume" command.
Change-Id: I8961e72b6901a52612cf62f52c02b6c2ff3dcd94
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:19:04 +08:00
Tang Chen
c176987063 Add unit tests for "server suspend" command.
Change-Id: Idfdd98fd27d97e1216abe9b14d3dea7c8f2a5a68
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:17:27 +08:00
Tang Chen
4062d59965 Add unit tests for "server unlock" command.
Change-Id: I4fbf115f925a6ffdeaec3d856d22224fa7730729
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:14:47 +08:00
Tang Chen
cb16599f10 Add unit tests for "server lock" command.
Change-Id: I0396fc4836ee918298bbe3860b7c1f42d3b97e33
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:12:55 +08:00
Tang Chen
7886fdd3de Add unit tests for "server unpause" command.
Change-Id: Ia74d9875b8aa413b84d0077d22adb75b866a5701
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:09:16 +08:00
Tang Chen
569ff3dcd8 Abstract a helper function for server.xxx() tests.
The test cases for server.xxx() are all the same, with one or more faked servers.
So use a helper function to reduce code duplicate.

Change-Id: I660c7731e2de8bf4d815b414a621d8d9ca6d5a8b
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 19:01:46 +08:00
Tang Chen
96331689f0 Add multiple servers test case to TestServerDelete.
This patch adds a multiple servers test case to class TestServerDelete.

Change-Id: I8b0c37ec2a8e7b23889e25c9004f867f2907f630
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 14:30:06 +08:00
Tang Chen
f9a41788cf Use setup_servers_mock() in the base class in TestServerDelete.
Use setup_servers_mock() in class TestServerDelete to coordinate
the test class format.

Change-Id: I1901d6b781d97820667984241f4d68764d045854
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 14:29:47 +08:00
Tang Chen
bf657ef286 Move setup_servers_mock() to class TestServer.
This function will be used in almost every test case.
So move it to the base class to avoid define it each
time a test case is added.

Change-Id: I060b54f0935b42a85042ad217d851fea649ec8d9
Implements: blueprint osc-unit-test-framework-improvement
2015-11-27 13:10:03 +08:00
Jenkins
d69906a06a Merge "Add unit tests for "server start" command." 2015-11-26 19:34:26 +00:00
Jenkins
840ffa72e2 Merge "Add unit tests for "server resume" command." 2015-11-26 19:34:22 +00:00
Jenkins
566bbb78f9 Merge "Add unit tests for "server suspend" command." 2015-11-26 19:16:47 +00:00
Jenkins
9a6672b8aa Merge "Change 'Object Store' to 'Object Storage'" 2015-11-26 18:41:06 +00:00
Jenkins
0fa9228dbc Merge "Add unit tests for "server unlock" command." 2015-11-26 16:39:02 +00:00
Jenkins
906c4923a9 Merge "Add unit tests for "server lock" command." 2015-11-26 16:34:38 +00:00
Jenkins
d2e8cc6cc9 Merge "Add unit tests for "server unpause" command." 2015-11-26 16:34:30 +00:00
Jenkins
46fe0dddff Merge "Abstract a helper function for server.xxx() tests." 2015-11-26 16:34:27 +00:00
Jenkins
dc541b1e2c Merge "Add multiple servers test case to TestServerDelete." 2015-11-26 16:34:25 +00:00
Jenkins
2217f0a6df Merge "Use setup_servers_mock() in the base class in TestServerDelete." 2015-11-26 16:34:21 +00:00
Jenkins
68e10e0bbc Merge "Move setup_servers_mock() to class TestServer." 2015-11-26 16:29:31 +00:00
Tang Chen
a2047d3f9f Trivial: Fix typo in find() in network.
Change-Id: Ic54fbb9160adefe3d025d537125e125128f75ee6
2015-11-27 16:52:56 +08:00
Tang Chen
c48afe6032 Trivial: Fix a typo.
Change-Id: I236b4f53ee23cc97900e6244ab709404cc44a4ca
2015-11-27 13:20:44 +08:00
Xi Yang
32e0ed6980 Change 'Object Store' to 'Object Storage'
Because the official documents uses 'Object Storage',
so change it in this project.

Change-Id: I87c0996b48c452b3ff619b8214676ae377e6d0af
2015-11-26 16:35:54 +08:00
Xi Yang
d1a58653ab Use is_public to set access of volume type
Currently the 'public' and 'private' keys does not work
when creating volume type, 'is_public' should be used.

Change-Id: If34a66053ea6c192882a1b9d8bbb1d3666be3f83
Closes-bug: 1520115
2015-11-26 16:30:05 +08:00
Jenkins
487fff8cdb Merge "Move FakeServer to tests.common.v2.compute.fakes" 2015-11-26 04:03:00 +00:00
Jenkins
bf273985e9 Merge "Refactor: Order of security group class names" 2015-11-25 17:09:38 +00:00
Jenkins
970554206d Merge "Add functional tests for network crud" 2015-11-25 15:43:45 +00:00
Richard Theis
74f84f32f5 Refactor: Order of security group class names
Per comment in [1], refactor the security group class names to
be in alphabetical order.

[1] https://review.openstack.org/#/c/249223

Change-Id: If28a153cdab57c0659ff5c78b276766d4043467f
2015-11-25 08:54:52 -06:00
lin-hua-cheng
b3c2668c34 Move FakeServer to tests.common.v2.compute.fakes
FakeServer should not be in tests.fakes since this should
be just for generic re-usable classes.

Change-Id: I19209952de69626dfa3caadc5d1cc69b7feadeba
2015-11-25 00:17:49 -08:00
Jenkins
c0676fe17f Merge "Trivial: Add missing doc for parameter in wait_for_delete()." 2015-11-25 04:31:45 +00:00
Tang Chen
f3c69ceeb5 Trivial: Add missing doc for parameter in wait_for_delete().
The doc of parameter manager is missing.

Change-Id: I4e99c06ab713532d73615670ada0a61462285d76
2015-11-26 10:19:01 +08:00
Jenkins
9e14c0a7ce Merge "Remove the old fake server data." 2015-11-25 02:34:24 +00:00
Jenkins
ee43f65936 Merge "Use class FakeServer in TestServerResize." 2015-11-25 02:34:15 +00:00
Jenkins
1346ae58b9 Merge "Use class FakeServer in TestServerImageCreate." 2015-11-25 02:34:13 +00:00
Jenkins
27f1876ea8 Merge "Use class FakeServer in TestServerDelete." 2015-11-25 02:34:10 +00:00
Jenkins
1f2fcb570d Merge "Use class FakeServer in TestServerCreate." 2015-11-25 01:49:20 +00:00
Jenkins
1be15a8be7 Merge "Unable to set some compute quotas" 2015-11-25 00:05:43 +00:00
Jenkins
13dfacc5ff Merge "Add "openstack server shelve" into OSC" 2015-11-24 23:23:30 +00:00
Jenkins
b42396d445 Merge "Doc: Update and add IP address" 2015-11-24 23:08:55 +00:00
TerryHowe
3dc97c0d3f Add functional tests for network crud
Change-Id: If965a7389ffa5b7ad44f53eebc2e8b918c6d2ace
2015-11-24 15:29:59 -07:00
Steve Martinelli
510a4d9674 Remove py26 support
as of mitaka, the infra team won't have the resources available to
reasonably test py26, also the oslo team is dropping py26 support
from their libraries. sine we rely on oslo for a lot of our work,
and depend on infra for our CI, we should drop py26 support too.

Change-Id: I66d168ecc755a3ea0e01d5b6344d06d9e0d1378b
Closes-Bug: 1519510
2015-11-24 17:08:04 -05:00
Jenkins
11ea5b31af Merge "Doc: Add security group and security group rule" 2015-11-24 21:21:20 +00:00
Richard Theis
325420f6d1 Doc: Update and add IP address
Fix the 'ip floating' command documentation file name.
Add missing command list documentation for the 'ip fixed'
and 'ip floating pool' commands.  In addition, update the
command description and argument help to fix minor issues
and use consistent terminology.  And finally, cleanup the
Network command object formatting.

Change-Id: I0168891bc674c9f0d4df4062f7e93f497dc8fe6f
2015-11-24 14:03:51 -06:00
Richard Theis
41133fb82e Doc: Add security group and security group rule
Add missing command list documentation for the 'security group'
and 'security group rule' commands.  In addition, update the
command description and argument help to fix minor issues and
use consistent terminology.

Change-Id: I9f4a3fbac5637289f19511874e16391d3fe27132
2015-11-24 12:49:57 -06:00
Tang Chen
bfa223f615 Enable "openstack server resume" command to take multiple servers.
Current "openstack server resume" command could only resume one server.
Improve it to be able to handle more than one servers. Also improve
the doc to reflect the new feature.

Change-Id: I726eb86bfa3df3a9911f45770e6641264dbc1e0b
Implements: blueprint cmd-with-multi-servers
2015-11-24 18:54:03 +08:00
Tang Chen
4955117dff Enable "openstack server suspend" command to take multiple servers.
Current "openstack server suspend" command could only suspend one server.
Improve it to be able to handle more than one servers. Also improve
the doc to reflect the new feature.

Change-Id: Ic0417ee28f46c9198a35744c0180342e61966b26
Implements: blueprint cmd-with-multi-servers
2015-11-24 18:47:26 +08:00
xiexs
a41a8c42af Add "openstack server shelve" into OSC
Currently, the shelve operation is not supported by OSC.
So, this patch attempts to add it into OSC.

Change-Id: I92545300bef006a069338168d2de800e8a58af69
Implements: blueprint introduce-shelve-into-osc
2015-11-24 00:40:26 -05:00
Jenkins
42a5909f6a Merge "Trivial: Fix wrong doc for wait_for_status()." 2015-11-23 06:07:37 +00:00
Tang Chen
6957fb3ee7 Trivial: Fix wrong doc for wait_for_status().
Two trivial fixes:
1. docs for parameters are not sorted correctly
2. missing doc for a parameter

Change-Id: I0cfb65e0f897c391b9b6e7225251e88855b07a56
2015-11-24 09:22:22 +08:00
OpenStack Proposal Bot
46e061785f Updated from global requirements
Change-Id: If8a37fdf90f3e97712a5d223d8e166840d036ab2
2015-11-21 16:23:01 +00:00
Tang Chen
a6291663ff Remove the old fake server data.
The old fake server framework has be replaced with the new
class FakeServer, which is stronger in:
1. faking multiple servers with random names and ids
2. faking methods in a server
3. easier to use

So remove the old fake server data, and use class FakeServer
from now on.

Change-Id: Ife8ee37a7ce14d9a3201104bce8075a918a97613
Implements: blueprint osc-unit-test-framework-improvement
2015-11-21 17:50:03 +08:00
Tang Chen
c9041622ef Use class FakeServer in TestServerResize.
There are the same problems with TestServerCreate in TestServerResize.
Use the new class FakeServer to fix them.

Change-Id: Ibde3e68a7bc55bbbf8357ba98be2559a6d0d41b6
Implements: blueprint osc-unit-test-framework-improvement
2015-11-21 17:49:54 +08:00
Tang Chen
588d73461e Use class FakeServer in TestServerImageCreate.
There are the same problems with TestServerCreate in TestServerImageCreate.
Use the new class FakeServer to fix them.

Change-Id: Ie723fa95620549f09a81ef72953f46877ef9252a
Implements: blueprint osc-unit-test-framework-improvement
2015-11-21 17:49:37 +08:00
Tang Chen
1cf5c5525b Use class FakeServer in TestServerDelete.
There are the same problems with TestServerCreate in TestServerDelete.
Use the new class FakeServer to fix them.

Change-Id: Icdcc90cc93ed1080187fb0edca885b0db56ab35d
Implements: blueprint osc-unit-test-framework-improvement
2015-11-21 17:49:03 +08:00
Tang Chen
815cd8a199 Use class FakeServer in TestServerCreate.
In the current TestServerCreate, there are several problems:

1. The fake create() returns a server with no 'networks' field.
   The new_server is used to fake the created server which is
   supposed to be returned by create(), but it has a 'networks'
   field.

   They have the same name and id, but they are actually not
   the same server.

   As a result, when checking the return value from create(),
   'networks' is not checked.

2. The fake server is not accessable in the test functions.
   So each time a test function wants to get the server name
   or id, it has to use the constants defined in compute_fakes.

   This is not good. We should make the fake server accessable
   in all test functions to ensure they actually get the same
   server.

This patch fix them both by using the new class FakeServer to
fake a server.

Change-Id: I8ffc8e233f8710034329ed33fccb2c734898ec2d
Implements: blueprint osc-unit-test-framework-improvement
2015-11-21 13:33:20 +08:00
Jenkins
4c7bbdae28 Merge "Have configuration tests support OCC" 2015-11-21 01:17:57 +00:00
Dean Troyer
5e46176540 Add command wrapper doc
This is a follow-up to I6c750730963615895f5d9953487d2d5a905885a8 that
removed a command deprecation warning wrapper.  This documents the
technique for later use.

Change-Id: Ieaa1e6b7eed4e5b037b4bfb6cf488e1290fc69f7
2015-11-20 15:23:14 -06:00
Jenkins
9ee8b4a71d Merge "Remove deprecated 'project usage list' command" 2015-11-20 21:09:20 +00:00
Tang Chen
319fc09430 Trivial: Remove doc for non-existing param in format_dict().
There is no parameter named format.

Change-Id: I286006430efb2850b978b6f2abaed87216156d12
2015-11-21 19:02:32 +08:00
Richard Theis
99498b0ab3 Unable to set some compute quotas
The OpenStackClient mapping of 'openstack quota set' arguments isn't
correct for compute quota items that have to different names.  For
example, the --injected-file-size argument is mapped to
injected_file_size, but the compute quotas item is actually
injected_file_content_bytes.  This incorrect mapping prevented the
impacted compute quota items from being set.

The problem impacts the following 'openstack quota set' arguments:
  --injected-file-size
  --injected-path-size
  --properties
  --secgroup-rules
  --secgroups

This patch set also expands the compute quota unit tests to verify
all compute quota items that can be set.

Change-Id: I0a2f241e425f4811e4ae55be183ac0c8b0805c2a
Closes-Bug: #1475831
2015-11-20 13:08:42 -06:00
NiallBunting
a7ecec2a50 Add --volume to Image create
This was previously part of the command, so added it in for backwards
compatibility. This adds the --volume command and the complimentary
--force command allowing users to create images from volumes.

It seems it may not be possible to add it to image set v2.

Change-Id: Ica36e70989f75d80959af3227f66708758fae68d
2015-11-20 17:22:07 +00:00
TerryHowe
c0cc538077 Have configuration tests support OCC
Change-Id: Ia8b0e5672e2e6cf6a37582bf231385aafda8836d
2015-11-20 10:57:36 -06:00
Jenkins
65e6c7bc63 Merge "Add unit tests for "server pause" command." 2015-11-19 21:21:52 +00:00
Tang Chen
5c0959c4fe Add unit tests for "server pause" command.
This patch adds unit tests for "server pause" command,
including one and multiple servers.

Change-Id: If5551e77d7dd4f7f48c6ee4a7f80f8313817f492
Implements: blueprint osc-unit-test-framework-improvement
2015-11-20 15:47:13 +08:00
Jenkins
cddf4c309e Merge "Introduce random server faking mechanism." 2015-11-19 21:21:48 +00:00
Jenkins
4776bf672b Merge "Enable FakeResource to fake methods." 2015-11-19 21:19:50 +00:00
Tang Chen
b1cc7fb4f6 Introduce random server faking mechanism.
This patch introduces a new server faking mechanism to support
multiple servers faking.

Server names and ids can be generated randomly, and use APIs in
class FakeServer to get one or more servers.

Change-Id: Ic54f3bf7c77294dc7dfb9acdbf4a721eb5eef6af
Implements: blueprint osc-unit-test-framework-improvement
2015-11-19 18:23:11 +08:00
Tang Chen
20bf1ef675 Enable FakeResource to fake methods.
Use MagicMock to fake a method in FakeResource. A new function:

    add_method(name, return_value)

is added to FakeResource. The caller specifies method @name and @return_value,
the function will add an attribute with @name, which is a callable MagicMock
object whose return value is @return_value.

When user access the attribute with a (), @return_value will be returned by
MagicMock, which looks like a function call.

Change-Id: I12eb876cbebab064773df7b5dd612de69bbf3f01
Implements: blueprint osc-unit-test-framework-improvement
2015-11-19 18:23:08 +08:00
Mark Vanderwiel
71e1adeaf0 Allow error status to be specified
For some apis, heat, the error status is "failed". This patch
changes the wait_for_status method to allow for the error
status to be passed in the same way as the success status.

Change-Id: I20db4051d3f5611a4b13fe23ea8798b82a40da81
2015-11-18 17:48:43 -06:00
Dean Troyer
1a8020cc1b Remove deprecated 'project usage list' command
Remove the 'project usage list' command that was deprecated in version
1.0.2 in review Ie08d4f88d71a660fca1862405351109cd0aa86b6.

Note that the removed command class is a good example of how to wrap a
command and show a deprecation message.

Change-Id: I6c750730963615895f5d9953487d2d5a905885a8
2015-11-18 15:37:55 -06:00
Atsushi SAKAI
63c9ee7dde Remove LICENSE APPENDIX
From seeing other OpenStack modules,
 APPENDIX:How to apply the Apache License to your work.
is not written.

Change-Id: I6fe0968e2281ef4f60e7c41f5621f552efc8a349
2015-11-18 13:25:56 +09:00
Jenkins
5f6f456bfd Merge "Add release notes for 1.9.0" 2015-11-17 21:56:01 +00:00
Jenkins
74d53cdd50 Merge "Enable "openstack server unlock" command to take multiple servers." 2015-11-17 02:26:15 +00:00
Steve Martinelli
471881f85e Add release notes for 1.9.0
Sum up the latest bug fixes for the latest release.

Change-Id: I4f6e9e9d5062e5ccb94f088abdc270fc40373d16
2015-11-16 19:15:21 -05:00
Jenkins
5dffc9d860 Merge "Enable "openstack server lock" command to take multiple servers." 2015-11-16 03:28:01 +00:00
Jenkins
f177160991 Merge "Enable "openstack server unpause" command to take multiple servers." 2015-11-16 02:28:41 +00:00
Jenkins
6952916c48 Merge "better format remote IDs for identity providers" 2015-11-15 01:24:47 +00:00
Jenkins
c6949c782c Merge "Improve "server list" command to have the same output as "nova list"." 2015-11-13 22:54:27 +00:00
Tang Chen
fc32b0d76b Improve "server list" command to have the same output as "nova list".
"nova list" will also output "Task State" and "Power State" by default.
This patch improves "server list" command to have the same columns, but
not by default. These two columns will be output if --long is added.

The power state is an int, so also adds a formatter helper function
to translate it to human readable string, just as "Networks" does.

Change-Id: I0530a910bec03835839a5ba7687c66d5643338f3
2015-11-14 09:38:01 +08:00
Jenkins
5243b093ca Merge "Split the vol_id from a dev mapping" 2015-11-13 16:44:44 +00:00
Tang Chen
91fbb0e136 Enable "openstack server unlock" command to take multiple servers.
Current "openstack server unlock" command could only unlock one server.
Improve it to be able to handle more than one servers. Also improve the
doc to reflect the new feature.

Change-Id: Ibf57b2021a504da950a491d63139a438087aed0b
Implements: blueprint cmd-with-multi-servers
2015-11-13 11:02:01 +08:00
Tang Chen
c1f0ad6d71 Enable "openstack server lock" command to take multiple servers.
Current "openstack server lock" command could only lock one server.
Improve it to be able to handle more than one servers. Also improve
the doc to reflect the new feature.

Change-Id: Ifcf103b1c32e6c547ac09f688b887b1c03f92b09
Implements: blueprint cmd-with-multi-servers
2015-11-13 10:36:22 +08:00
Tang Chen
90d86ef01c Enable "openstack server unpause" command to take multiple servers.
Current "openstack server unpause" command could only unpause one server.
Improve it to be able to handle more than one servers. Also improve the
doc to reflect the new feature.

Change-Id: I069ebdd6dcd121f6e55c2bf40d42197f93830e0c
Implements: blueprint cmd-with-multi-servers
2015-11-13 10:36:16 +08:00
lin-hua-cheng
51f2fda041 Add capability to update description of an IdP
Change-Id: I854067642bbfde6fdf84b22b9cc1de8afc7767c0
Closes-Bug: #1515815
2015-11-12 16:49:45 -08:00
Jenkins
6e1ad73723 Merge "validate non-ascii values for swift properties" 2015-11-12 22:38:58 +00:00
Steve Martinelli
cfd2bf5882 validate non-ascii values for swift properties
skip properties that are non-ascii values, but proceed
with properties that work. log these failed values back
to the user.

Change-Id: Iaca8909f4465a01c8aebfd290b1a322823702359
Closes-Bug: 1503898
2015-11-12 11:07:57 -06:00
Jenkins
c39708beff Merge "Trivial: Fix wrong param name in comment." 2015-11-12 07:01:34 +00:00
Tang Chen
ed82312bcb Trivial: Fix wrong param name in comment.
"volume" should be "attachments".

Change-Id: Id1e9a733e18db595d8981b5b3a7735313a346787
2015-11-13 11:44:14 +08:00
Jenkins
6a8c0f3ff6 Merge "Add project-name/-id validation for the OSC "openstack quota set"" 2015-11-12 05:01:41 +00:00
xiexs
8b23c2690c Split the vol_id from a dev mapping
Add a split into the dev mapping to get the right vol_id.

Change-Id: I1a7bf6351491b1321c5ca0fa4a27f29825400eaf
Closes-Bug: #1514394
2015-11-11 23:47:02 -05:00
Jenkins
ed0981f4d8 Merge "Fix the bug of "openstack console log show"" 2015-11-12 03:31:56 +00:00
Steve Martinelli
c079e13774 better format remote IDs for identity providers
remote-ids are a list, and we should format these values as such,
rather than python representations of lists/arrays.

Closes-Bug: 1478995

Change-Id: Ia6ced0fab2435b8cb486822c676c0dee32613abe
2015-11-12 02:56:49 +00:00
Jenkins
6611f3781b Merge "Set default network api to 2.0 instead of 2" 2015-11-12 00:08:58 +00:00
Jenkins
62b5865dce Merge "Add --owner to image create" 2015-11-12 00:03:14 +00:00
Jenkins
53fc20fa6f Merge "Fix the bug of "openstack usage show"" 2015-11-11 21:46:38 +00:00
Jenkins
46f1676dce Merge "Fix issue when displaying image_member" 2015-11-11 21:46:07 +00:00
Jenkins
daf1e09009 Merge "Add Command Options guideline doc" 2015-11-11 21:45:04 +00:00
Jenkins
0cc0b8d112 Merge "Add compute service delete" 2015-11-11 19:31:01 +00:00
Tang Chen
c396b69d37 Trivial: Fix wrong param name in comment.
"volume" should be "attachments".

Change-Id: I41c797f0c7cccb2727e9e6cd6424ea2f740624b7
2015-11-12 17:02:24 +08:00
Jenkins
4a76b4dd51 Merge "Trivial cleanup: Use plural format for "server delete" doc." 2015-11-10 03:40:18 +00:00
Tang Chen
c9756667ce Trivial cleanup: Use plural format for "server delete" doc.
Change-Id: I4dca25f1933d5925db443eca75f602a39a833413
2015-11-10 16:28:25 +08:00
Monty Taylor
441543d67f Set default network api to 2.0 instead of 2
neutronclient expects 2.0 as the version if you go through the discovery
constructor. For that reason, 2.0 is the 'correct' version to set in
config files or environment variables for if you're using things that
are not OSC. However, if you do that, OSC prints a warning that 2.0 is
not in the supported network version list.

Let's support both so that users don't get a confuse.

Change-Id: I7412519693f75fcd29f5621ce9e5a2df2da92684
2015-11-09 09:31:37 -05:00
xiexs
ea63553925 Fix the bug of "openstack console log show"
The behaviors are inconsistent while different
negative line numbers specified.

Change-Id: I2573f3e789f5603c896758971830ffc0b94c5e2b
Closes-Bug: #1512263
2015-11-09 04:22:09 -05:00
Tang Chen
a337f664d2 Enable "openstack server pause" command to take multiple servers.
Current "openstack server pause" command could only pause one server.
Improve it to be able to handle more than one servers. Also improve
the doc to reflect the new feature.

Change-Id: I809f77f0720457c9cdc1028a70b391c75885984c
Implements: blueprint cmd-with-multi-servers
2015-11-09 04:27:45 +00:00
Jenkins
6dfa304617 Merge "Allow int version numbers in the clouds.yaml" 2015-11-08 22:16:00 +00:00
Jenkins
1cf09be913 Merge "Use fake server name instead of id when testing "server_name" param." 2015-11-08 13:59:04 +00:00
Jenkins
0ab2dac8e2 Merge "Change method to get the user_id" 2015-11-08 06:31:16 +00:00
xiexs
176735f4aa Change method to get the user_id
Instead of "find_project", using "find_user" to get the user_id
while the option --user is specified for "openstack volume list"

Change-Id: Iea8472b7b8e709a8792a56575e00003a9cbdaa39
Closes-Bug: #1514145
2015-11-08 03:57:23 +00:00
Tang Chen
f8f2f4dcd3 Use fake server name instead of id when testing "server_name" param.
"server create" command takes a server name parameter. The server id is
generated by openstack.

When we intended to pass a server name to the unit tests of "server create"
command, we passed server id. It won't be any problem because the fake
server id is also a string, but we should pass a fake server name because
we have a string to fake one.

Change-Id: I9944f0ea2a6c457e4fad8215a54778bca08965ab
2015-11-07 14:39:53 +08:00
xiexs
db46666589 Fix a bug about "openstack server list --user"
Fix the bug to get the right user id.

Change-Id: Ie60a719a40654802772884ff94271b37aa061ac3
Closes-Bug: #1513701
2015-11-06 09:16:51 -05:00
NiallBunting
5ad59968ac Add --owner to image create
This adds --owner to `image create`. This is backwards compatable with v1.

Change-Id: I9e79cf880c91a1386419db729818d23dfe632179
Depends-On: I8d572a070bbb04dccdd051b8e0ad199c5754746e
2015-11-06 10:43:08 +00:00
Jenkins
8a1fb85dba Merge "Trivial: Fix wrong comment of _format_servers_list_networks()." 2015-11-05 13:37:45 +00:00
Tang Chen
45a07afd54 Trivial: Fix wrong comment of _format_servers_list_networks().
The parameter name should be 'networks'.

Change-Id: I140c3d61dccbbec40c14bd7a8f2aeac0eb24384d
2015-11-06 19:02:36 +08:00
Jenkins
f40a04c30a Merge "Add "server stop" command to osc." 2015-11-05 12:31:22 +00:00
Jenkins
334ef75d4f Merge "Add "server start" command to osc." 2015-11-05 12:23:33 +00:00
Tang Chen
7107b5536e Add "server stop" command to osc.
There is no stop command in osc. Add it.

Change-Id: Ia11a8f3b1245c884f7da442292009342d2ffde1e
Implements: blueprint cmd-with-multi-servers
2015-11-05 15:43:39 +08:00
Tang Chen
1809faaf1f Add "server start" command to osc.
There is no start command in osc. Add it.

Change-Id: Ic50f83413ab17c53396065aabb3f5a1506b52959
Implements: blueprint cmd-with-multi-servers
2015-11-05 15:43:15 +08:00
TerryHowe
2f00fcda77 Allow int version numbers in the clouds.yaml
OSC blows up if you try to use for example identity_api_version: 2
in the clouds.yaml.  It will only work with a string '2'.  This
fixes that.

Change-Id: I785d37a288126a1582464e907c7f9c9947bac27c
2015-11-04 11:20:43 -07:00
Sean Perry
c49c9df105 Import the module not the class
As requested during review 226922.

Change-Id: Ic5222141e247ce33cf5dbee66667cee3040e1cc3
2015-11-04 09:51:58 -08:00
xiexs
7d8bb331a0 Add project-name/-id validation for the OSC "openstack quota set"
The quota info would be set into DB, even though the project actually
does not exist.
This patch tried to add a validation to forbid this undesirable behavior.

Change-Id: Ia2d8c96527820e25b074e6486d3f39c5ad7eae60
Closes-Bug: #1512638
2015-11-04 10:22:46 -05:00
Jenkins
266ecf57f5 Merge "Mark arguments for 'credential' commands as required" 2015-11-04 14:33:57 +00:00
OpenStack Proposal Bot
332ec43b5f Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ibaa8ba0e2fd013b0cc48e2c4fe8737299b64ea48
2015-11-04 06:04:23 +00:00
Jenkins
d4fb5cefda Merge "Trivial clean up: do not use plural form in command arguments." 2015-11-02 10:57:02 +00:00
xiexs
9e50752321 Fix the bug of "openstack usage show"
When there is no resouce usage associated with the project,
an odd output will be displayed.
This patch tried to fix this issue.

Change-Id: I6f254c6ba37fbb760ada08e640c4938668d560dc
Closes-Bug: #1512220
2015-11-02 04:28:17 -05:00
Jenkins
cb28cd9ac0 Merge "Rename context.py to logs.py" 2015-10-30 11:02:08 +00:00
Jenkins
17ebd15a13 Merge "Allow debug to be set in configuration file" 2015-10-30 09:08:37 +00:00
Terry Howe
05800c4722 Rename context.py to logs.py
At one point this file contained the context for logging, but
the reason for its existence is now for logging.

Implements: blueprint logging-migration

Change-Id: I4ba42bbef97b09d31236ac8c01b6fb23827b8bee
2015-10-30 17:38:42 +09:00
Jenkins
039c859653 Merge "Updated from global requirements" 2015-10-30 02:57:14 +00:00
TerryHowe
bfebac8282 Allow debug to be set in configuration file
The current default value for debug in cliff is False.  Cloud
config assumes that it was set that way on the command line and
does not overlay it with the value from the configuration file.
Cliff bug:

https://bugs.launchpad.net/python-cliff/+bug/1483378

Change-Id: I66d82b489b2241dbcd1e1350e94259a54ce09de7
2015-10-30 11:16:36 +09:00
Jenkins
58d0facd68 Merge "remove url from v3 regions" 2015-10-29 02:20:56 +00:00
OpenStack Proposal Bot
53099ea2c2 Updated from global requirements
Change-Id: Iee71a3906069245cee8ec9edd68b4f22a8e006bc
2015-10-28 22:10:14 +00:00
Tang Chen
eac40beb6b Trivial clean up: Add doc for "osc server lock/unlock".
There is no doc for "server lock/unlock" in doc/source/commands.rst.

Change-Id: Ibabc260f6269a452c3de0d032839f63938bd348e
2015-10-28 19:19:47 +08:00
Tang Chen
0ee5527fa5 Trivial clean up: do not use plural form in command arguments.
It is a general rule that we don't use plural form for the name of
command arguments. But class DeleteServer() is still using "servers".
So use "server instead".

Change-Id: I2d76de14ec34b88547b9f728b41e9bd93b2a22c5
2015-10-24 11:44:40 +08:00
lin-hua-cheng
12668b3dab Fix issue when displaying image_member
image_member doesn't have a _info attribute, glanceclient returns
warlock object instead of a Resource object.

Change-Id: If6e7c4bd404454bd6cbe8c111879c1afa1380211
Closes-Bug: #1509054
2015-10-23 00:15:19 -07:00
Jenkins
d7ad229d8a Merge "Support pagination params for flavor list" 2015-10-23 00:02:54 +00:00
Dean Troyer
46fdaaba6b Add Command Options guideline doc
Add a developer guideline for command options to define the options
used across multiple commands and make them behave consistently.

Change-Id: I1dbbafe8061e10b271cd55cac056731508c52204
2015-10-21 09:20:00 -05:00
Steve Martinelli
539c39bfaf remove url from v3 regions
the parameter "url" was removed from Keystone, it was only added
for one release as part of an experimental support for adding
service providers.

BackwardsIncompatibleImpact
Closes-Bug: 1506841

Change-Id: I7a62fbf1d9bfa8e6dd8d619e98c32b9860348d2e
2015-10-21 13:21:20 +00:00
Jenkins
3ad2f85614 Merge "Change Identity API default version to 3" 2015-10-21 02:58:27 +00:00
liyingjun
9471115a9a Support pagination params for flavor list
Missing 'marker' and 'limit' params for `openstack flavor list` shell
command. It would be nice to have this when there are many flavors.

Closes-bug: #1505874
Change-Id: I088ac5d24f0d7595f5cbce14f063e296a449eb26
2015-10-21 08:24:58 +08:00
Jenkins
48e75c73ed Merge "Move session and fixtures to keystoneauth1" 2015-10-20 19:57:36 +00:00
Jenkins
69be668534 Merge "Add release notes for 1.8.0" 2015-10-19 22:48:39 +00:00
Jenkins
0f74e80c4b Merge "Follow-on for volume list - add tests, clean help" 2015-10-19 22:46:43 +00:00
Dean Troyer
db2dfa311f Add release notes for 1.8.0
Depends-On: I2181b2c48cfde2147d7d0ef135322df8a81e7ce8
Change-Id: I9bdee1b932bcefd3c802461f6f7ac6d9266110ce
2015-10-19 13:57:15 -05:00
OpenStack Proposal Bot
d3e2e35f1d Updated from global requirements
Change-Id: Ic779c64e11691b48638ebd973723da2af28d5b96
2015-10-17 02:59:01 +00:00
Jenkins
6fdc9a891f Merge "Add filtering by project/user for 'openstack volume list'" 2015-10-17 01:46:31 +00:00
Dean Troyer
195a0edeb7 Follow-on for volume list - add tests, clean help
* Add volume list tests for v1 (a copy of the v2 tests)
* Converts volume v2 tests to use Identity v3 so domains can be tested
* Add volume list (v2) tests for new options
* Re-orders volume list options (both v1 and v2) to match
* MArks the new volume list (v2) options as v2-only in doc

Change-Id: I2181b2c48cfde2147d7d0ef135322df8a81e7ce8
2015-10-16 16:08:27 -05:00
Alex Schultz
d1bc15f498 Add compute service delete
This change adds 'compute service delete <service>' to the openstack
client. This is the equivalent of 'nova service-delete <id>'

Change-Id: I69ef1cac72cbe125c2114f8e958e22350a70f367
Closes-Bug: #1503510
2015-10-16 14:01:37 +00:00
kafka
9f51ccdf8c Add filtering by project/user for 'openstack volume list'
added project, user and domain options for filtering results,
also cleaned up the order to match the docs.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closed-bug: #1483976
Change-Id: I9d955094d31d4a28e215d24f7521a11c62bee8db
2015-10-15 15:51:01 -04:00
Jenkins
cb533ef040 Merge "Add a table showing all the openstack plugin objects" 2015-10-14 21:25:10 +00:00
Jenkins
18a7d23a8a Merge "Fix up object-store show commands" 2015-10-14 20:29:07 +00:00
Jenkins
eab508fddd Merge "Mask the sensitive values in debug log" 2015-10-14 19:03:41 +00:00
Jenkins
155e8c6f1e Merge "Fix functional tests for Python 3.4" 2015-10-14 18:26:17 +00:00
OpenStack Proposal Bot
a29df98ef9 Updated from global requirements
Change-Id: Ie32abbbe6bb5ace5f1178fb266b9f1c60f625d72
2015-10-14 09:33:25 +00:00
Steve Martinelli
cbc1897b7d Move session and fixtures to keystoneauth1
in an effort to start consuming keystoneauth1, we can move our
sesssion and fixture code over to use keystoneauth1 instead of
keystoneclient.

Change-Id: Ibcbd588ce2e3d864f87ff1eb6e1c3c071a1e06f6
2015-10-14 00:46:07 -04:00
Dean Troyer
b60a9492a3 Remove cliff-tablib from requirements.txt
No longer needed

Change-Id: I07c72fd34e9a7429d6fb910e254f91e888070009
2015-10-13 14:39:37 -05:00
OpenStack Proposal Bot
2ca76810a2 Updated from global requirements
Change-Id: I400cce4dfd840bba2d4f368a5d7f057f28b435ab
2015-10-13 11:04:52 +00:00
OpenStack Proposal Bot
10ecd67802 Updated from global requirements
Change-Id: I60a7bd4cd9527cf3b54ab5d2968dff5134711bff
2015-10-13 01:02:45 +00:00
lin-hua-cheng
f0a81c284d Mask the sensitive values in debug log
Change-Id: I0eb11a648c3be21749690f079229c8e63a678e6c
Closes-Bug: #1501598
2015-10-12 16:55:48 -07:00
Jenkins
fce3a080cd Merge "Fix a typo in commands.rst" 2015-10-12 19:40:39 +00:00
Sirushti Murugesan
b12d850222 Fix functional tests for Python 3.4
* shlex.split() expects a string. Not bytes.
* decode the bytestring result of subprocess's communicate()
  to a string.

Change-Id: I209f67a91dc609b1e30cb9e683d3d6ee63d00069
2015-10-12 17:23:06 +05:30
Jenkins
a72c7d33cd Merge "Add test for role list --inherited" 2015-10-12 07:38:13 +00:00
Jenkins
7a94a56933 Merge "Fix typos in authentication.rst" 2015-10-12 07:15:45 +00:00
Steve Martinelli
1f8b814628 Fix up object-store show commands
1) Change metadata to appear under a common 'properties' key, and
use the utility to format them, this applied to object, account
and container.

2) Clean up container and object output, which were setting the
x-container-meta-owner property, but this is metadata only for
the container, so it's pointless to have, removed it.

3) Container show was showing read/write ACLs and sync stuff, but
these are not being returned by my swift by default, so I moved
these to be checks, so we don't clutter the output.

Change-Id: Ife7521fe9c2724035b06963c118bd6016ba2f5b5
2015-10-10 11:48:07 -04:00
Steve Martinelli
17f794ca08 Change Identity API default version to 3
Devstack now issues all v3 OSC commands for our CI, and since v3
has everything v2 has, we should be able to switch to v3.

Furthermore, most OSC users were initially  using OSC since they
were looking to exploit v3 keystone capabilities.

Change-Id: If7de86946f6dd0f148aa5f526155cccf90adfcc3
2015-10-09 05:25:19 +00:00
Steve Martinelli
ae82271778 Add a table showing all the openstack plugin objects
We need a spot that highlights the `objects` used by OpenStack
based `plugins`. The sooner we have this information out, the
sooner we reduce the chance of a name collision.

Change-Id: If9f07e19adea4aaa813eecdd0bce1fbfe616e306
2015-10-08 23:13:41 -04:00
Jenkins
4759a84703 Merge "Updated from global requirements" 2015-10-08 23:55:17 +00:00
Jenkins
9f23f1f13f Merge "image set should not show the resource" 2015-10-08 20:38:05 +00:00
Jenkins
72bf89cccc Merge "Evaluate --inherited in role list" 2015-10-08 20:17:08 +00:00
Jenkins
5f4892a15d Merge "Fix non-ascii issue with object commands" 2015-10-08 20:12:11 +00:00
Steve Martinelli
bd14d07809 unwedge the gate
devstack defaults to v3 and makes some janky assumptions in
the generated rc files

Change-Id: I4b0b3eb6ab2aa9be2ac4c2404b2f9655e3ed564e
2015-10-08 03:09:43 -04:00
Daisuke Fujita
2eaaf37a0d Fix a typo in commands.rst
1. "ec2 cedentials" to "ec2 credentials"

Change-Id: I9a17c0d592f9a4d6e53e6dd786cba405468a3e09
2015-10-08 10:56:23 +09:00
Daisuke Fujita
851393eb0b Fix typos in authentication.rst
1. "inital" to "initial"
2. "set of of environment variables" to "set of environment variables"

Change-Id: I7040792c1a03a9a3ac873f9a0428bfa1178fd550
2015-10-08 10:16:47 +09:00
OpenStack Proposal Bot
27465f193d Updated from global requirements
Change-Id: I30b638f4f04d0fbf4ffc2fac965306ce99faacf1
2015-10-08 00:09:09 +00:00
Dean Troyer
e523c699a2 Add test for role list --inherited
Change-Id: I216ab6c8ac903720ec67870a5171ae57a8f293aa
2015-10-07 17:37:20 -05:00
lin-hua-cheng
985b2cdd2c Fix non-ascii issue with object commands
Escape the container and object name whenever it is used
as URL.

Change-Id: I2343c1e67843ab53773b3fca6e258dc329cd9573
Closes-Bug: #1503508
2015-10-06 23:26:08 -07:00
Jenkins
262af5416b Merge "Add ID column to compute service list" 2015-10-07 03:38:33 +00:00
Jenkins
23e821a86b Merge "Add tags to image set" 2015-10-07 00:17:44 +00:00
Jenkins
f6678feea0 Merge "Clean up Image v2 image set command" 2015-10-06 21:26:33 +00:00
Alex Schultz
80e3a2dedb Add ID column to compute service list
This change adds the ID to the compute service list command so that the
ID can be leveraged by scripts trying to remove or update a specific
service.

Change-Id: I446b4c0071988133195eb2382313b3918b7ffa72
Closes-Bug: #1503430
2015-10-06 16:00:59 -05:00
Steve Martinelli
2bd82ab892 image set should not show the resource
the rest of OSC set commands do not show the resource after it has
been updated. unless the update fails then we report back a failure,
otherwise the user should assume everything went fine.

Change-Id: I2bd4188450c3853b4a1bc25f80fc9450cda32bdd
2015-10-06 20:14:54 +00:00
NiallBunting
1afb574533 Add tags to image set
This adds --tag to the v2 version of `image set`. This
is another step to compatability between the osc image api.

Added merge of tags into existing tags and handling duplicates,
and tests for same.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Change-Id: Ie800fcbf8bbc0978c54ace3278750a18023e8ce4
2015-10-06 20:14:34 +00:00
Jenkins
be1ee4181e Merge "Update the plugin docs" 2015-10-06 18:36:33 +00:00
Jenkins
e3213f66da Merge "Set object store arg order in docs" 2015-10-06 18:34:52 +00:00
Dean Troyer
201b1cee86 Clean up Image v2 image set command
Make the Image v2 image set command meet at the intersection of the v1
image set command and the v2 image create command:

* Add visibility to the deadopts list and remove the option
* Put the options in the same order as v1 image set
* Make the help text match
* Add --properties
* Move the additional options that do not appear in either v1 image set or
  v2 image create after --property as they are really pre-defined properties
* Add tests for v2 image set to match v1 and then some
* Put the SetImage class in v2/image.py in alphabetical order

Change-Id: I102b914e8ad09a014f6fdd846c5766b6c2eaadb8
2015-10-06 11:11:59 -07:00
Rudolf Vriend
7075c90053 Evaluate --inherited in role list
the --inherited option was not being passed into keystoneclient

Closes-Bug: #1502822

Change-Id: I48170dc67b23cc9b0665b1e0f38118eea952f131
2015-10-06 13:39:22 -04:00
Jenkins
e926998700 Merge "Image fix bug with --volume" 2015-10-06 15:04:31 +00:00
Jenkins
a76164f450 Merge "Add shields.io version/downloads links/badges into README.rst" 2015-10-06 15:04:27 +00:00
Dean Troyer
578a57dcc3 Set object store arg order in docs
argparse displays positional args last in the help output,
our docs should match.

Change-Id: I01e8d62cb8c1b537ea0441b8bdf8880a4c856b32
2015-10-06 08:46:31 -05:00
Steve Martinelli
5bd5366089 Update the plugin docs
There have been some changes as to the status of OSC plugins,
highlight these changes in the table.

Change-Id: Iff6520d35b34ae5d7bf88a128ebdf05f3681d643
2015-10-06 02:07:45 -04:00
Steve Martinelli
e48c7afee4 add set/unset support for objects in object store
add docs and command support to set and unset metadata of objects
that are stored in an object store (swift).

Closes-Bug: #1501945

Change-Id: If838a4b3343b6ddb97cd4bd1cb63f0ba1c1a00a1
2015-10-06 00:52:24 -04:00
Steve Martinelli
abaf711e24 add support for set/unset of container properties
include docs and commands to set and unset container properties

Partial-Bug: #1501945

Change-Id: I8d7e8cf356a2321a37ed940c4e10cae411b94dfd
2015-10-06 00:18:59 -04:00
Jenkins
bf11960d55 Merge "Updated from global requirements" 2015-10-05 22:10:51 +00:00
Jenkins
f05ecd9860 Merge "Add one parenthesis" 2015-10-05 22:10:06 +00:00
Jenkins
0bfa349ede Merge "cleanup account ids from container commands" 2015-10-05 21:54:18 +00:00
Jenkins
77689c93a5 Merge "Rename swift account commands" 2015-10-05 21:54:15 +00:00
Jenkins
a02e7c8355 Merge "Add support for showing account details" 2015-10-05 21:54:13 +00:00
Jenkins
1dc9854ac6 Merge "Add support for updating swift account properties" 2015-10-05 21:53:29 +00:00
OpenStack Proposal Bot
45f1509cd3 Updated from global requirements
Change-Id: I5b898fc5444688bde538fbccda6e3c189a66f701
2015-10-04 22:45:07 +00:00
Steve Martinelli
ecb69a4771 Rename swift account commands
rename `os account` to `os object store account`

Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>
Closes-Bug: #1501943

Change-Id: I54fdcea7a48df16f20e17605110f8d33a20f713c
2015-10-01 21:20:05 -07:00
Atsushi SAKAI
a2786fa88b Add one parenthesis
In the following help message, last parenthesis is missing.

 $ openstack --os-volume-api-version 2 help volume delete
usage: openstack volume delete [-h] [--force] <volume> [<volume> ...]

Delete volume(s)

positional arguments:
  <volume>    Volume(s) to delete (name or ID)

optional arguments:
  -h, --help  show this help message and exit
  --force     Attempt forced removal of volume(s), regardless of state
              (defaults to False

Change-Id: I45c4030abf076cba14450019c379d333eb6530d6
2015-10-02 11:56:22 +09:00
Steve Martinelli
faece91756 cleanup account ids from container commands
use a common function to determine account ID instead of different
ways - depending on the response and command

Change-Id: I95adc5dc7d5a82a2cffc570d1ded24d1fc754a11
2015-10-02 01:20:40 +00:00
Steve Martinelli
4733fd0d3c Add support for showing account details
add the command `openstack account show` that lists details
about the object store account that the user authenticated
against.

Partial-Bug: #1501943

Change-Id: I1246dafee812b63a41d43be4e3598224364a2c11
2015-10-02 01:20:06 +00:00
Steve Martinelli
a4483a0513 Add support for updating swift account properties
this patch adds support for creating/updating and removing
properties (nee: metadata) for object store accounts.

Partial-Bug: #1501943

Change-Id: I3ed70a5d8bd8920fedb79adc60cdc602261d5eef
2015-10-01 18:18:36 -07:00
Jenkins
ea54a4db1b Merge "Add tests for find_resource()" 2015-10-01 23:23:46 +00:00
Dean Troyer
97659adf53 Add tests for find_resource()
Add a couple of tests for utils.find_resource() for the odd resources
and managers without resource_class.

Change-Id: I2ed9b491d1361b5259b3a5f80b4fac787a7087c1
2015-10-01 11:46:16 -05:00
OpenStack Proposal Bot
df85380ffb Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ida5289f0229020953ec715c4a547ab030fbf75e7
2015-10-01 06:12:57 +00:00
Sean Perry
b33cdec92a Mark arguments for 'credential' commands as required
According to the [1], 'user_id', 'type', and 'blob' are all required
arguments for 'credential set' but the code treats them as optional. Set the
'required' flag and remove logic supporting missing arguments.

[1]: https://github.com/openstack/keystone-specs/blob/master/api/v3/identity-api-v3.rst#credentials-v3credentials "spec"

Change-Id: I597c9616ad744385fc6dd92379feb03daec54458
Closes-Bug: #1418837
2015-09-30 15:33:45 -07:00
Steve Martinelli
83282bc5e1 attempt to find resource by listing
add a last-ditch effort to find the resource in question by
listing all the resources and doing a simply match for name and
id. if no match is found then raise an error, if the list call
is unsuccessful, raise the same error. we have failed this city.

Closes-Bug: #1501362

Change-Id: I0d3d7002e9ac47b17b1ef1a5534406c85b1fc753
2015-09-30 09:58:44 -05:00
Steve Martinelli
05f5e043d8 Additional exception handling for find_resource
A few things here: 1) we need to check if the client class even
has a 'resource_class', in the case of glanceclient, it does not.

2) If everything fails we should print a better error message,
rather than a "find" failed, since some clients don't support find.

Change-Id: I6277322639e75b1635f9f3d159753efadbce1031
2015-09-30 09:54:28 -05:00
Steve Martinelli
e52dfce7bd Add shields.io version/downloads links/badges into README.rst
it's handy to have appear in the pypi page

Change-Id: I142da7d194d719f3b8218ad84e32e19bf0071c63
2015-09-25 00:01:49 -04:00
Jenkins
678e690648 Merge "Override the debug default and help text" 2015-09-24 21:47:33 +00:00
Steve Martinelli
0e89d08434 docs: pip install -e needs an argument
The arguments to install the development branch is incorrect, since
the -e option needs a directory to look for setup.py in.

Change-Id: Icfe402e7b79a50ddc885c7eadb6c323c27e36ef3
2015-09-24 11:50:46 -04:00
Jenkins
29aad2a9b5 Merge "Use discover_extensions for novaclient" 2015-09-23 18:18:02 +00:00
Jenkins
c71c78df92 Merge "Glance image set Resolve Fracturing" 2015-09-23 12:28:02 +00:00
NiallBunting
8faabb3bba Glance image set Resolve Fracturing
Currently `image set` uses the new api, where other parts of osc the old
api is used. This deprecates the v2 api in favour of the v1 to maintain
the same commands across osc. However the functionality now remains
there as people could now be using this functionality.

This also adds the --unprotected argument, as in the previous version if
--protected was not supplied it would just make the argument
--unprotected without the users explicit consent.

The patch also fixes the documentation for image set as it was outdated.

Change-Id: I990d20332c80165102badef7ac94ddbeb7824950
Closes-Bug: 1498092
2015-09-23 00:31:41 -04:00
Dean Troyer
b8faa8ae87 Add release notes for 1.7.0
Change-Id: I4b4d229f7c3292923c8a29d1e1182a8352688b5d
2015-09-22 10:04:57 -05:00
Jenkins
7145fa0787 Merge "Imported Translations from Zanata" 2015-09-21 22:39:35 +00:00
Jenkins
d0427808b8 Merge "Use format_list instead of format_dict when listing images" 2015-09-21 21:54:26 +00:00
Jenkins
4cb88704d9 Merge "Format an images properties and tags" 2015-09-21 21:54:22 +00:00
Jenkins
b2e72e6aee Merge "Add image create support for image v2" 2015-09-21 21:35:33 +00:00
Steve Martinelli
e0e9b2bfae Use format_list instead of format_dict when listing images
This currently breaks listing images with --long. Tags are an
array and shouldn't be formatted as a dictionary.

Change-Id: I6d1d85351b58ae4824498774673ebdc8eaa7e420
Closes-Bug: #1498150
2015-09-21 15:18:36 -04:00
Steve Martinelli
d8f7527ff2 Format an images properties and tags
Currently, these properties are each top level keys, they should
all be under a single 'properties' field. Secondly, the tags are
kept as an array, but can be shown as a comma separated string.

Change-Id: Ic769c657a86e768fee38acc40434c377de70a7bc
2015-09-21 18:53:01 +00:00
Monty Taylor
f5b50df8ea Add image create support for image v2
We have it for v1, but v2 is the future. There are two differences,
things in v2 do not go into a properties dict, and the actual image
data needs to get uploaded as a second step.

Closes-Bug: 1405562
Co-Authored-By: Niall Bunting <niall.bunting@hp.com>
Co-Authored-By: Sean Perry <sean.perry@hp.com>
Change-Id: If7b81c4a6746c8a1eb0302c96e045fb0f457d67b
2015-09-21 14:51:03 -04:00
Monty Taylor
0857da76d9 Change ignore-errors to ignore_errors
Needed for coverage 4.0

Change-Id: I38a9361df07f290ea3588996462bbbc1a6d7b8d8
2015-09-21 14:54:21 +00:00
Jenkins
2616fdb089 Merge "Set default auth plugin back to 'password'" 2015-09-21 14:40:18 +00:00
OpenStack Proposal Bot
80ae715a09 Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I2eadaa91b2a089bc54ab167a1d6e5f7fd7acb228
2015-09-21 06:09:48 +00:00
Jenkins
b288fbfb35 Merge "Remove backticks from help in role commands" 2015-09-19 07:19:39 +00:00
Jenkins
0094b1b42f Merge "Move option logging back to start if initialize_app()" 2015-09-19 04:42:46 +00:00
Hidekazu Nakamura
3f532a2b69 Remove backticks from help in role commands
the docs and code had inconsistencies with how it
references other arguments, lets just remove the
backticks from around them.

Change-Id: I43d17b07364e45387c6b9d86c2aca26eeea8ed93
2015-09-19 00:40:21 -04:00
Jenkins
33aacd9454 Merge "Updated from global requirements" 2015-09-19 03:19:54 +00:00
Jenkins
6de1af1161 Merge "Add tests for volume quota set" 2015-09-19 03:03:05 +00:00
Jenkins
0116f3abc6 Merge "Support listing users by group name" 2015-09-19 01:49:54 +00:00
Dean Troyer
d6788f7e75 Move option logging back to start if initialize_app()
The log for the options should be printed early enough to see what
is being passed in to occ.

Change-Id: I97b09bc28abcd485b6793d0223b9f8602237fd80
2015-09-18 14:29:01 -05:00
Dean Troyer
b1972fb561 Set default auth plugin back to 'password'
This was a hack that should be less needed now...

Change-Id: Id8cba87ad05b106aa36e356c0d70a568316fd327
2015-09-18 14:17:05 -05:00
OpenStack Proposal Bot
9987a95841 Updated from global requirements
Change-Id: Id0791447748e9430c995cbab87260e843e8a2819
2015-09-18 16:42:31 +00:00
NiallBunting
1afd8f62cd Image fix bug with --volume
Currently after calling the cinderclient to create an image from a volume,
it also then tries to create another image. This fails as the keyword
volume is unexpected. This add checks so the image is not created in
this case. Allowing --volume to not throw an error when it has worked.

Change-Id: I67e650eb0b8c331d86515e3e326c39a5d6dad5e1
Closes-Bug: 1497221
2015-09-18 15:29:47 +00:00
Steve Martinelli
817ab3ec0e set image api to 1 for functional tests
devstack now defaults to image api v2, but osc does not support
v2 image create. set the functional tests to use v1 for now
to unwedge the gate.

Closes-Bug: #1496337
Change-Id: Ia02ed761446b8de52c932a424b9c423691ebcceb
2015-09-16 19:33:34 +00:00
OpenStack Proposal Bot
1461c0eb17 Updated from global requirements
Change-Id: I63d1c3bdf6bdd5ff5e1c16af3ee4f095a7d659f1
2015-09-12 01:15:28 +00:00
Andrey Kurilin
9e6f99e2ab Use discover_extensions for novaclient
novaclien v2.26.0 includes `discover_extensions` method, which returns
list of all nova extensions based of version. Such method allows us to
reduce imports of novaclient's modules and construct novaclient instance
simpler.

Change-Id: Idbe3ed275fb4a7e3918b11669dcfad47b8de4fb9
2015-09-11 16:23:54 +03:00
OpenStack Proposal Bot
a936c30893 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I000bbddd938d7f83a8a85ccb7a62eb3a23f3dd46
2015-09-11 06:10:25 +00:00
Jenkins
0daa096939 Merge "Use a common decorator to log 'take_action' activation" 2015-09-11 02:43:54 +00:00
Jenkins
fa4b11a86f Merge "Add filtering by user for 'openstack server list'" 2015-09-10 20:19:43 +00:00
Jenkins
1e36b122f8 Merge "Add support for listing servers of other projects" 2015-09-10 20:18:45 +00:00
Jenkins
a591ab34c7 Merge "Use novaclient.client.Client for initialization Nova client" 2015-09-10 05:19:23 +00:00
Jenkins
c42cd80d6e Merge "Automate flavors, networks, and image get" 2015-09-09 20:23:41 +00:00
Jenkins
46696f5ed5 Merge "Create log configuration class" 2015-09-09 20:15:54 +00:00
Jenkins
cd54db8741 Merge "Optimize log formatting" 2015-09-09 20:06:27 +00:00
Jenkins
535aac6c91 Merge "Extract log level from configuration file" 2015-09-09 20:06:24 +00:00
Jenkins
67387ba9cd Merge "Move options to log level out of shell.py" 2015-09-09 19:46:28 +00:00
Andrey Kurilin
c513f05ce9 Use novaclient.client.Client for initialization Nova client
`novaclient.client.Client` is a recommended entry point for novaclient.
It supports backward-compatibility and allows Nova-folks to change
interfaces of inner versioned clients classes.

Change-Id: Iaf20714f63c307f88a451759f041ca509fbcf6f8
2015-09-09 18:00:50 +03:00
Jenkins
1a2bb48432 Merge "Move set warnings filters to logging module" 2015-09-08 22:06:02 +00:00
Jenkins
b4421e3802 Merge "Properly handle port arguments for ICMP" 2015-09-08 21:18:06 +00:00
Jenkins
24ca952eb6 Merge "Set up every time record log in file" 2015-09-08 20:22:24 +00:00
Jenkins
7f24818994 Merge "Volume v2 list does not show server name" 2015-09-08 20:16:21 +00:00
kafka
10db0df857 Add filtering by user for 'openstack server list'
Add a new option to search by user when listing servers,
include support for domain scoped users, also update
docs

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closes-Bug: #1483974
Change-Id: Ifdade6dc9ca8400fbd85f6b55793ab15ed17b97d
2015-09-08 18:36:56 +00:00
Ashish Singh
66010b41f1 Add support for listing servers of other projects
Added project and project-domain option to server list
command for listing servers based on project name or id

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Change-Id: Iaadfffe734ad8a72fa4b1eeb2222748c66f7fae0
Closes-Bug: #1488486
2015-09-08 13:27:50 -05:00
Steve Martinelli
36a9703a19 Support listing users by group name
Listing users within a group is not presently domain scoped. We
do not use the domain info at all when the group option is present.
A new --group-domain option is not needed since we cannot list
users by --project and --group, they are mutually exclusive (as
per the identity API).

Closes-Bug: 1492916
Change-Id: I50f995ee4a03c2bdb21f2b5722546ab8fe786eb6
2015-09-07 01:37:37 -05:00
Dean Troyer
3abfea083a Fix compute API version snafu
novaclient 2.27.0 introduced the API microversion discovery and client.Client
now wants an api_version argument to properly work out the correct API
version in use.  OSC needs to provide this when required.

Letting the compute client plugin do the version validity checking makes more
sense than encoding it into shell.py, so I've added a new OSC plugin interface
function check_api_version() that is called from shell.py if it exists.  If it
either does not exist or it returns False the previous version checking using
API_VERSIONS is still performed.

compute.client.check_api_version() conditionally imports the new
novaclient.api_versions module and uses it if successful.  Otherwise
check_api_version() returns False and the previous code path is resumed.

One side-effect of this is that it is now valid to use --os-compute-api-version
with any valid microversion supported by the installed python-novaclient.

Closes-Bug: #1492467
Change-Id: I4535b38a5639a03a9597bf83f6394f9bb45c2b9e
2015-09-04 16:25:55 -05:00
Dean Troyer
e6706f2526 Properly handle port arguments for ICMP
The Compute API requires 'from_port' and 'to_port' to be -1 for
ICMP security group rules.  It happily accepts them empty or None
but the resulting rules do not work.  So we force the values for
ICMP rules.

Closes-bug: #1477629
Change-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d
2015-09-03 13:06:45 -05:00
Jenkins
9210cac86a Merge "Ignore flavor and image find errors on server show" 2015-09-03 02:26:51 +00:00
Jenkins
be964cf409 Merge "Running 'limits show' returns nothing" 2015-09-02 15:20:26 +00:00
Joshua Harlow
e3c46ece4a Use a common decorator to log 'take_action' activation
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
2015-09-01 16:49:54 -07:00
Joshua Harlow
d751a21d2c Fix 'auhentication' spelling error/mistake
Change-Id: Iba58c188d2ae44170539534eea1415cf8eb65ac4
2015-09-01 15:51:58 -07:00
TerryHowe
14a714f2a2 Volume v2 list does not show server name
The volume v2 list was using the volume id rather than
the server id.

Change-Id: Ibe03d34b5b503af2d00202dabd640f796449cf9a
Closes-Bug: #1489954
2015-08-28 11:11:37 -06:00
TerryHowe
5171a427ac Ignore flavor and image find errors on server show
If there is an error finding an image or a flavor during
image show, ignore it and just print the id of the flavor
or image.  This code is also used during server create and
server rebuild, but only to display the results.

Change-Id: I5362158ab8ffc3e5a0800904d6ea15420c3a8627
Closes-bug: #1489901
2015-08-28 09:32:05 -06:00
TerryHowe
85a03945f0 Create log configuration class
Configuration of logging gets triggered twice.  The first time it
uses the CLI options when the application is started and second
it uses the configuration file after that is read.  The state of
the logging needs to be saved from the first to the second time,
so I created a class.

Implements: blueprint logging-migration

Change-Id: I7b8d1a3b6fd128e98cafd7c16009c7b694a52146
2015-08-26 10:23:53 +00:00
Steve Martinelli
f14251669f default OS_VOLUME_API_VERSION to v2
Cinder is trying to deprecate/remove support for v1, so we should,
as a client library default to v2 and keep support for v1.

Related-Bug: 1467589

Change-Id: I732448a57fc3fd06a8d82ec0f0d2ace671036ca2
2015-08-24 10:38:43 -05:00
TerryHowe
48f7f0f1bc Automate flavors, networks, and image get
Functional tests rely on some sort of configuration and
rather than configure something right now, how about it
pulls something from the middle of the available list.

Change-Id: I8147e40e5ee7393d8a8dcf1b0beb48856f28af7e
2015-08-22 17:32:54 +00:00
Jenkins
3751dbf127 Merge "additional functional tests for identity providers" 2015-08-22 04:40:13 +00:00
Steve Martinelli
59d12a63b4 unwedge the osc gate
keystone added a new property to projects, called is_domain.
our functional tests fail because we are not expecting that in
the project's 'show' command.

Change-Id: Idf05118155847e3a6002818c44b99825801ea9f4
Related-Bug: #1487600
2015-08-21 15:33:48 -05:00
Kelvin Lui
8fb19bc2a9 additional functional tests for identity providers
add tests for:

  * delete
  * set
  * list
  * show 

Change-Id: Ibe34f28d7ae77d139a6e0edf4fe04215c371c9a8
2015-08-21 16:07:58 +00:00
Jenkins
913faaa392 Merge "Adds documentation on weekly meeting" 2015-08-20 02:28:59 +00:00
Jenkins
b770ecc79a Merge "Added note to install openstackclient" 2015-08-19 22:44:59 +00:00
Kelvin Lui
1966663ced Adds documentation on weekly meeting
Change-Id: Ia51f76323800aa5397a0d8a307c1cfbdaf90ab24
2015-08-19 16:46:55 -04:00
TerryHowe
1004e06cee Update the plugin docs for designate
Change-Id: I43cee0670728ec15de461be55ffb0504a216de77
2015-08-19 11:01:26 -06:00
Asha Saravanamohan
0f837df839 Added note to install openstackclient
Change-Id: Idcd9ef4e7a10ebbd8b68e7320680f503dfc166a9
Closes-Bug: #1483384
2015-08-19 11:29:29 -04:00
TerryHowe
00eebaf5bc Override the debug default and help text
Cliff sets the default debug value to False and this makes it
impossible to override debug with OCC.  If we set the default to
None, we can override debug in clouds.yaml.  Also, OSC changes
the meaning of --debug, so modify the help text.

Change-Id: I5e6680b2286cd7f55afe4b083fae5f8a4a9567a2
Closes-Bug: #1483378
2015-08-18 17:22:34 +00:00
Major Hayden
0f0d66f3f1 Running 'limits show' returns nothing
Running limits show without --absolute or --rate returns nothing and
the user is left to figure out what they need to provide to get the
correct data back.  This patch prints an error and help output by making
at least one of the arguments required.

Change-Id: I576cf8ec0e05524ee67d46c48b56da8d44258667
2015-08-14 10:31:53 -04:00
TerryHowe
6c46355734 Optimize log formatting
There is no way to change the configuration variables we want
printed in log messages, so format them in the constructor.
This will save us from overridding the format method and
a couple cpu cycles every log message.  This change also moves
the _LOG* variables into the formatter since they aren't really
globally needed.

Change-Id: I706e9db7da3daec20332f9d1533fe665f2739dea
Implements: blueprint logging-migration
2015-08-13 22:16:10 +00:00
TerryHowe
d828429d6a Extract log level from configuration file
Extract log_level from configuration file if the level was not
overridden by the command line option.  The default command line
option is 1 and there is no command line option to set the
verbose_level to 1, so if it is 1, it has not be set.

Change-Id: I1be04367c72f83c1181f92ca4c2c83165b66995c
Implements: blueprint logging-migration
2015-08-13 22:16:03 +00:00
TerryHowe
ca9965c328 Move options to log level out of shell.py
Move the conversion of command line options to log level out
of shell.py.

Change-Id: I86cb45a85cd63927aa1c87c1eed27542981df659
Implements: blueprint logging-migration
2015-08-13 16:11:25 -06:00
TerryHowe
9c3c336391 Move set warnings filters to logging module
This is the first step in moving logging out of shell.py

Change-Id: I3dcb4e17bb4687988ddf9b793ad1a308ef89b242
Implements: blueprint logging-migration
2015-08-13 16:05:01 -06:00
OpenStack Proposal Bot
ac5e289476 Updated from global requirements
Change-Id: I302808700fe98add83069e7ed32ea329eb32cea1
2015-08-13 20:21:57 +00:00
OpenStack Proposal Bot
a6c8c8f7af Updated from global requirements
Change-Id: Ie9049726dd4ac60238cb8b2658fa8510f4b11fde
2015-08-13 09:31:11 +00:00
OpenStack Proposal Bot
e90849238c Updated from global requirements
Change-Id: Ie503f1ed6f6f91adfcf40f71053ba4fec02179f3
2015-08-13 02:19:22 +00:00
TerryHowe
b1ce0356f2 Add tests for volume quota set
Add some tests for volume quota set and get rid of TODO about
using the value instead of the key to get the attribute.

Change-Id: I57aa57951aeea65965966e63af922cda532d759d
2015-08-11 14:40:53 -06:00
Jamie Lennox
0cc1e5aa2b Use correct domain to find project
When adding a role to a group and project OSC is mistakenly using the
group_domain to find the project which will fail if the group_domain !=
project_domain.

Change-Id: I4c1bec9b3b183c755be121b91f40e026d707192b
Closes-Bug: #1483520
2015-08-11 06:49:20 +00:00
Jenkins
48531e04b8 Merge "Updated from global requirements" 2015-08-11 03:54:03 +00:00
Jenkins
439f4887f3 Merge "Add release notes for 1.6.0" 2015-08-11 03:02:57 +00:00
OpenStack Proposal Bot
14bda1762b Updated from global requirements
Change-Id: I8fbb5213701f995bad7de243fd3a54fd147eb074
2015-08-11 01:38:56 +00:00
Steve Martinelli
d0cb0d1192 Skip functional test: test_server_up
seems like test_server_up is causing intermittent issues in our
CI, skipping for now, so we can proceed with merging code.

Change-Id: Id41a78e703d7b416dfdc9a7bc95b19a8999192e3
Related-Bug: 1483422
2015-08-10 15:09:10 -07:00
Jenkins
4907ce9a7e Merge "Add developer documentation" 2015-08-10 20:22:37 +00:00
Jenkins
0f9630eeb8 Merge "Remove non-existing hacking deviations from doc" 2015-08-10 15:36:11 +00:00
Jenkins
950bde938e Merge "Updated from global requirements" 2015-08-10 05:41:47 +00:00
Jenkins
c477154392 Merge "Update plugin documentation" 2015-08-10 05:41:13 +00:00
OpenStack Proposal Bot
043fc51c51 Updated from global requirements
Change-Id: I9232c1a3069cdb29a174eb7d93f55069d2f68e54
2015-08-10 01:10:26 +00:00
Eric Brown
bc4e6c2bf0 Remove non-existing hacking deviations from doc
Commit Id38a1497019c7fe2d4ad8567f1c0c8d229951751 removed all of
the hacking rules from the ignore list.  However, the hacking doc
still refers to those previouly ignored rules.

Change-Id: I370be096d83cd5121d24bb96d8d5dc08a1c3c216
2015-08-09 13:22:48 -07:00
Steve Martinelli
a82a418a0e Update plugin documentation
Several projects have begun to make OSC plugins; we should list
the status of the major projects, so users can know if they
can expect support for that feature/project.

Change-Id: Ib3c11c8f2b90663e37578a2714d438944eb1c6f6
2015-08-08 16:25:32 -07:00
Daisuke Fujita
e23dd6de58 Set up every time record log in file
This will allow users to record logs of all their commands into
a predefined log file, in clouds.yaml. The log should have a
format similar to that of oslo.log.

Change-Id: I1b334bf429d575fc25809c9706fc0b11116be3f1
Implements: blueprint every-time-record-log-in-file
2015-08-08 10:02:46 -06:00
Jenkins
ef33132c39 Merge "Inherited info/option when listing role assignment" 2015-08-08 09:09:26 +00:00
Steve Martinelli
b8b8383867 Add release notes for 1.6.0
Change-Id: Ia96f9c31879215cb98096de327a1add308fe1a36
2015-08-08 01:47:09 -07:00
Steve Martinelli
d833d377cb Add developer documentation
OSC was missing developer docs, these are critically helpful for
new developers. Add sections related to running tests (tox,
functional and with the debugger), and generating docs locally.

implements bp: developer-documentation
Change-Id: I428d89c3e5fc335864bc4f7843506043ec332fe5
2015-08-08 08:32:03 +00:00
Steve Martinelli
51ae8c78b9 Add --inherited to the role docs
commit Id72670be8640e5c6e2490a6ef849e9ec3493b1a9 forgot to update
the docs for role.rst.

Change-Id: I97c426ea9b290fc266b34cb0bf97de56cfd098de
2015-08-07 10:03:00 -07:00
Jenkins
366d72d87e Merge "Rename command docs to remove underscores" 2015-08-07 13:08:14 +00:00
Jenkins
963acf6aa4 Merge "Alphabetize setup.cfg" 2015-08-07 13:08:08 +00:00
Jenkins
994e326c79 Merge "Fixes inherited role assignments CRUD calls" 2015-08-07 06:12:29 +00:00
Steve Martinelli
cb8590ffb3 Rename command docs to remove underscores
For consistency, use dashes instead of underscores.

Change-Id: I2da19b56952a8a9d172793ae211bdc58ddff4146
2015-08-06 22:24:22 -07:00
Samuel de Medeiros Queiroz
94a8805a9a Inherited info/option when listing role assignment
Adds inherited information when listing role
assignments. In addition, it makes possible
to list only inherited ones by adding
--inherited option.

Change-Id: Idf889603d584716da95e2c7b4880142fbd8291c4
Closes-Bug: 1370546
2015-08-06 22:21:27 -07:00
Steve Martinelli
c54d1241a0 Alphabetize setup.cfg
noticed that volume type list was out of order.

Change-Id: I965a201bc9c0fac67d01d5ee368149cac89095c9
2015-08-06 22:01:55 -07:00
Jenkins
35833c94ef Merge "Add set feature to volume type v2" 2015-08-07 05:00:18 +00:00
Jenkins
8affa0d1c3 Merge "Add list feature to volume v2" 2015-08-07 04:56:16 +00:00
heha
429ceef0c6 Add set feature to volume type v2
"volume type set" and "volume type unset" is not in the v2.

Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>

implements bp: volume-v2

Change-Id: Ia804787d76d2029726c030b43c61eac3b411f66a
2015-08-06 19:35:01 -07:00
heha
dc6fe04895 Add list feature to volume v2
"volume list" is not in the v2.

Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>

implements bp: volume-v2

Change-Id: I9f4585202f5f9ec5f4c091278fc6c4036efb1290
2015-08-06 17:02:46 -07:00
Samuel de Medeiros Queiroz
4097ec1d24 Fixes inherited role assignments CRUD calls
The paremeter to Keystone Client was passed as
'inherited', when it should be
'os_inherit_extension_inherited'.

Closes-Bug: #1482254

Change-Id: I1cb46add532223ef0b9620763b1047cc80e19ec0
2015-08-06 12:05:57 -03:00
Jenkins
d87403a7bf Merge "Fix quota set failed problem" 2015-08-06 07:34:08 +00:00
Jenkins
c5b31f3c6a Merge "Fix quota show when there is no project id" 2015-08-05 19:26:16 +00:00
TerryHowe
fd61711585 Fix quota show when there is no project id
If no id is in the response, quota show fails.

Change-Id: I9905431b006404c9ba8453eba016cec9ebe19402
Closes-Bug: #1481803
2015-08-05 09:55:29 -06:00
Robert Francis
4850728b99 Add functional test for volume type create --property
Combine test_volume_set_one_propety and
test_volume_type_set_unset_properties.

Change-Id: Ia8862a59161f6a15880b87ea305fb5bb15c31300
2015-08-05 07:25:06 -04:00
Jenkins
1f341b4a33 Merge "Imported Translations from Transifex" 2015-08-04 15:58:19 +00:00
OpenStack Proposal Bot
f44590a599 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: If738066b8f940bdc99a98352dfaadbd5ee548794
2015-08-04 06:26:16 +00:00
OpenStack Proposal Bot
eb4246fc94 Updated from global requirements
Change-Id: I4f5e05c8207e91f0da87b4bbd25f711d42016cbe
2015-08-04 00:49:08 +00:00
Jenkins
7e9c1946f2 Merge "Added a new function test for volume type set" 2015-08-03 21:46:09 +00:00
Jenkins
2039011097 Merge "Introduce functional test for Identity Provider" 2015-08-03 20:39:15 +00:00
JP Parkin
d52ecfc058 Added a new function test for volume type set
This is a new test to validate the setting of one property
for an existing volume type

Change-Id: Ia9a7d86ce9b0d8df9d64ddc1df2d443843bba5ef
2015-08-03 14:55:32 -04:00
Jenkins
4633bdb7cf Merge "Add domain scoping in 'role assignment list'" 2015-08-01 15:42:47 +00:00
Jenkins
20d32dd362 Merge "Removed unnecessary assignment of function result Joined lines together" 2015-08-01 06:11:23 +00:00
Kelvin Lui
cd98e063eb Introduce functional test for Identity Provider
Identity Provider currently doesn't have test coverage.

Change-Id: Iea2e705f9d2303f58516f08a7526135988032025
2015-08-01 01:38:20 -04:00
lin-hua-cheng
701b59f651 Add domain scoping in 'role assignment list'
Add ability to set which domain the user, group or project
belong to.

Change-Id: Idf6c7f23ab96261a73682226fb10ce5f0133924e
Closes-Bug: #1472909
2015-07-31 18:56:34 -07:00
Joe Wigglesworth
cfb99cb9b1 Removed unnecessary assignment of function result
Joined lines together

Change-Id: Iffe19c309369301137cfd52c8ea1aa988ce39f7e
2015-07-31 11:02:33 -04:00
Jenkins
bd022cb58c Merge "Added test for volume type show" 2015-07-31 08:57:30 +00:00
Jenkins
8d8440c410 Merge "Minor Documentation changes for code samples" 2015-07-30 21:22:20 +00:00
Jenkins
6787017bdc Merge "Set OS_VOLUME_API_VERSION before running functional tests" 2015-07-30 21:14:39 +00:00
Jenkins
3a6cb49200 Merge "New test for configuration show --mask" 2015-07-30 20:39:04 +00:00
Jenkins
811ed669ad Merge "add new test for configuration show unmask" 2015-07-30 20:30:57 +00:00
Yunpeng Li
235cd227bd New test for configuration show --mask
Change-Id: I56bb110d25b9f05cb1a706ecc5bbf5b6b154b240
2015-07-30 12:26:38 -07:00
Jenkins
f03eca3f05 Merge "New test for configuration show" 2015-07-30 19:16:00 +00:00
John Keenleyside
4ebeb25b23 add new test for configuration show unmask
Change-Id: Ib85bfa627f4ddee9e017f148c86a6d7d640bfba4
2015-07-30 15:07:48 -04:00
Jerry George
521b2cc5dc Minor Documentation changes for code samples
Change-Id: I2d13fe2884d9eaebd112d342041e2e219bf6a240
2015-07-30 14:41:41 -04:00
Steve Martinelli
acb1c94750 Set OS_VOLUME_API_VERSION before running functional tests
For v1 functional tests, set the env. var.

Change-Id: I6c554932bdb8f99438d4f2ae855eb16c5bb3a357
2015-07-30 11:28:31 -07:00
Kenneth Chu
d7d2b92cff Added test for volume type show
Change-Id: I05bbbdd8389f57d567b02391cbbc52448a9a2e7a
2015-07-30 13:39:43 -04:00
Radu Mateescu
149ce52614 Add functional tests for volume type list
add tests for `os volume type list`

Change-Id: Icd874b9cfac9376cc410041806fac64f1ff0c59d
2015-07-29 20:15:00 +00:00
Manuel Silveyra
4b86324ee2 New test for configuration show
Creates a new common file for configuration tests.

Change-Id: Id4c26759dfec5d508b762d0b54386f258a362971
2015-07-29 13:03:12 -07:00
Jenkins
7ee8608df3 Merge "Imported Translations from Transifex" 2015-07-29 18:05:20 +00:00
Jenkins
9c492b742d Merge "Add plugin interface version" 2015-07-29 15:46:34 +00:00
OpenStack Proposal Bot
69093cab61 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I4b1050a38ed62872ef809ef9145f0e7cd653be0d
2015-07-29 06:32:36 +00:00
OpenStack Proposal Bot
ead9a40e02 Updated from global requirements
Change-Id: Ic047055ffc7b94032e615815b162f4e830126e6e
2015-07-29 03:50:47 +00:00
jiaxi
77214c56e7 Fix quota set failed problem
When using the command: openstack quota set, the compute quota below
can't be set successfully,the value of compute quota stay unchanged,
'fixed-ips', 'floating-ips', 'injected-files', 'key-pairs'.

What's more,I add a TODO comment in the code for two reason.
1. volume quota set works fine for the moment.
2. To indicate that this issue about volume needs
   discuss and report another bug, if it's confirmed.

This bug is only about compute quota.

Change-Id: Ic1028d561f5a0030cf65ac18fc117bf01e945478
Partial-Bug: #1420104
2015-07-28 23:21:28 -04:00
Jenkins
cc6c4e5c39 Merge "Add support for volume v2 commands" 2015-07-25 03:25:57 +00:00
Amey Bhide
96afb8b1b7 Add support for volume v2 commands
Adds the following commands:
openstack volume create
openstack volume set
openstack volume unset

Implements: blueprint volume-v2
Change-Id: Icb7404815763aa88550112fb42f5200ce05c2486
2015-07-24 13:16:38 -07:00
Jenkins
55d9eba093 Merge "Do not set default versions in parsed args" 2015-07-24 19:51:30 +00:00
Jenkins
46cc7d12ad Merge "Add configuration show command" 2015-07-24 03:32:51 +00:00
TerryHowe
43942871a9 Add configuration show command
Create a `configuration show` command that displays the current
configuration of the CLI.  Different configurations can be
displayed using options such as --os-cloud.  Passwords and
tokens are redacted by default unless the --unmask
option is specified.

Closes-Bug: #1476729

Change-Id: I0792365d0c5fa526cd09c0ed88c6bb1e2cb813a7
2015-07-23 13:00:59 -06:00
Jenkins
e54a15aabb Merge "add doc for floatingip" 2015-07-23 16:14:56 +00:00
OpenStack Proposal Bot
025d38040c Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ic6d4612806a946a4f8047b501bea8ae08557fad7
2015-07-23 06:08:14 +00:00
Jenkins
b9ca72853b Merge "Fix --os-auth-plugin in auth_with_unscoped_saml" 2015-07-22 17:07:40 +00:00
Dean Troyer
15fe0fae17 Add plugin interface version
External plugins need to know which plugin interface is being
used by the host OSC.  Releases <1.6 (?) will not have a
version defined.

Plugins can add the following to their make_client() to discover
the interface version:

    _plugin_interface_version = getattr(
        instance,
        "PLUGIN_INTERFACE_VERSION",
        None,
    )

Change-Id: Ifc0f40fec5bc27f6425139984936b7f6e032a580
2015-07-22 11:06:41 -05:00
Hugh Saunders
874c921292 Fix --os-auth-plugin in auth_with_unscoped_saml
The error message refers to --os-auth-plugin which is not a valid
option. This patch changes that to --os-auth-type.

Change-Id: I02ec0b7855131180bb8c674051930ebb51cb7303
Closes-Bug: #1477083
2015-07-22 11:51:33 +01:00
chengkunye
a5b0d9ab35 add doc for floatingip
Change-Id: Ibdee50066452ed33f210e93de29eba3c0ec2e155
2015-07-22 05:08:36 -04:00
OpenStack Proposal Bot
54ff5d8758 Updated from global requirements
Change-Id: I7fc281b80342a14e11f87afb41c3abc515d8487c
2015-07-22 04:59:50 +00:00
Jenkins
317959d76e Merge "Fix yet more documentation warnings" 2015-07-22 03:49:33 +00:00
TerryHowe
d70df6a4a2 Fix yet more documentation warnings
Change-Id: I87683039601ae90531f27ebebbc4d0b1d252e846
2015-07-21 14:07:18 -06:00
Jenkins
4d9d2dbd36 Merge "Make trustee/trustor/project searchable by ID" 2015-07-21 19:46:16 +00:00
Steve Martinelli
921361b3ae Make trustee/trustor/project searchable by ID
In the previous implementation, we were always including the domain
argument, which caused a lookup by name for trustee/trustor and
project. By excluding it when not necessary, we do a search by
ID in find_resources.

Change-Id: Id756aeab522b5dccb2dc6b31d137a28514b0fdf6
Closes-Bug: 1473298
2015-07-20 20:12:50 -07:00
Jenkins
4c368d12d2 Merge "Remove requirements.txt from tox.ini" 2015-07-21 00:42:41 +00:00
Jenkins
26ea98b30e Merge "Add create and list for volume type v2" 2015-07-20 22:28:10 +00:00
Jenkins
7442c018d2 Merge "Format volume type properties when showing" 2015-07-20 21:03:29 +00:00
chengkunye
659abf4928 Add create and list for volume type v2
Volume API v2 is missing create and list features.

implements bp: volume-v2

Change-Id: I34a1ae440e9620b1c65546f4f43b369c8661250d
2015-07-20 12:59:57 -07:00
Jenkins
061e0a3670 Merge "add image member commands for image API" 2015-07-20 19:56:32 +00:00
chengkunye
7bb459837b add image member commands for image API
This commit adds the following commands:
    image project add
    image project remove

Closes-Bug: 1402420
Change-Id: I07954e9fa43a3ad6078dd939ecedf9f038299e7b
2015-07-20 10:38:42 -07:00
Jenkins
07248b3642 Merge "Fix the way auth_type default value is overriden" 2015-07-20 16:53:31 +00:00
Jenkins
457ea94478 Merge "Add functional tests server reboot" 2015-07-20 13:37:31 +00:00
Jenkins
4887fb9206 Merge "Add functional tests server IP attach and detach" 2015-07-20 13:36:40 +00:00
Javier Pena
c5b4383160 Fix the way auth_type default value is overriden
Commit 50f05448982b5fafd9d9a7783b639dd145090a0d to os-client-config
removed the default values in the _defaults dict. This makes any
call to cloud_config.set_default() before initializing the dict
fail.

The fix changes the way the auth_type default is overriden, by
doing it when cloud_config.OpenStackConfig() is executed.

Change-Id: If37d3ba303f01d4c77fd7c15a3cde9634534b64a
Closes-bug: #1473921
2015-07-20 15:29:41 +02:00
Steve Martinelli
a6d5f3f94c Format volume type properties when showing
Currently, the properties of a volume type are unformatted.
Use the formatter to keep things consistent with the way
properties are represented in OSC.

Change-Id: I81c6bd3fdbc30568c269e501c740473b2a1ffb4e
2015-07-19 17:36:34 -07:00
Steve Martinelli
11c9695e5e Rename type.py to volume_type.py
For Volume V1, we have a type.py file which should be renamed to
volume_type.py (as it's named for V2).

Change-Id: If860bbafe4a801d8b4fa06938eef20658c4fcc2c
Closes-Bug: 1475958
2015-07-19 17:02:43 -07:00
Jenkins
469ba41b51 Merge "Fix image save with API v2" 2015-07-19 23:41:17 +00:00
Jenkins
d26650b57d Merge "Removes trailing blank in trust show" 2015-07-19 23:14:31 +00:00
Jenkins
6dc136f2d7 Merge "Add volume type show for volume v1" 2015-07-19 21:26:12 +00:00
Gilles Dubreuil
00b4e38d3c Removes trailing blank in trust show
Previously a blank character at the end of the roles value would remain

Change-Id: I0961a5f9fb4b270a6055ee69898eadee315e416a
Closes-Bug: 1474707
2015-07-19 13:33:00 -07:00
Jenkins
e06efbaa9b Merge "--property should be required in os unset commands" 2015-07-19 17:32:14 +00:00
Jenkins
64334c0dc9 Merge "More minor docs fixes" 2015-07-19 16:44:19 +00:00
jiaxi
e30ebfeb17 Add volume type show for volume v1
volume type show is missing for volume V1 API.

Closes-Bug: #1475879
Change-Id: Ic8a0845ecec04146d536412463175f57ef6511ae
2015-07-19 16:17:40 +00:00
jiaxi
9c95b37832 --property should be required in os unset commands
The three commands below
  openstack volume unset
  openstack snapshot unset
  openstack volume type unset

Should have --property as a required argument,
not optional. The reason is the command will not work
without --property.

Closes-Bug: #1475872
Change-Id: Ib9e29392472db38982cc2817af2dd5055f5a01ca
2015-07-19 15:46:14 +00:00
TerryHowe
643d1d90fe More minor docs fixes
Change-Id: Ia74b8e14bacb562d9bac29221f511acbab5296df
2015-07-19 07:03:57 -06:00
TerryHowe
88c39ef48e Minor identity documentation change
Change-Id: Ib139f2376e70ebb7b5621cdad4da61c64c1f9246
2015-07-19 06:06:19 -06:00
Jenkins
b08dd6f132 Merge "Add details to the documentation." 2015-07-19 06:13:21 +00:00
TerryHowe
ea103cab1d Add functional tests server reboot
Change-Id: I1699ac826519ccc177159423c7b6727ffaf4abff
2015-07-18 15:08:46 +00:00
TerryHowe
a9f85736ef Add functional tests server IP attach and detach
Change-Id: Id87a5474e2df80c9ef84a6c554f12116302a38b3
2015-07-18 09:08:26 -06:00
Jenkins
b59d9efdb0 Merge "Add functional tests for servers that require wait" 2015-07-18 14:32:36 +00:00
Jenkins
d74023b4e8 Merge "Making --property as required when openstack flavor unset" 2015-07-18 14:32:33 +00:00
Jenkins
52bdda9bae Merge "Updated from global requirements" 2015-07-18 13:23:44 +00:00
heha
8bae138354 Add details to the documentation.
Add "or-show" to "project create" and "role create" in the documentation.

Closes-Bug: #1475485
Change-Id: I2d98766c4ddd8b2022012c4f6c5e1d4fcebfc42a
2015-07-18 12:56:39 +00:00
jiaxi
2fc800aace Making --property as required when openstack flavor unset
When using openstack flavor unset, the --property is needed,
so the --property should be a required parameter.

Close-Bug: #1474237
Change-Id: Id6913e1b263eddeb5dd44c3edb957206b68f816c
2015-07-18 08:29:54 -04:00
TerryHowe
b3335b3474 Do not set default versions in parsed args
Setting default versions in parsed args makes it so OCC
cannot tell if the argument was parsed, an environment
variable was set or it is just defaulted.  In order to
set api versions from OCC, it will have to be defaulted
after processing OCC.

Closes-Bug: #1453229
Change-Id: I4d065919397b783f3bdd4022c986c0234a7a16e6
2015-07-18 06:28:09 -06:00
TerryHowe
d79900a075 Add functional tests for servers that require wait
Change-Id: I4c85b1e303ecb99458594e7743950b0668b3bdfc
2015-07-18 12:22:45 +00:00
Jenkins
fcadb16470 Merge "Add functional tests for volume qos" 2015-07-18 12:19:04 +00:00
OpenStack Proposal Bot
ab2c1f2b82 Updated from global requirements
Change-Id: Id60bd6f5114276ca2267e71de34afa18d5c0a78f
2015-07-18 01:57:02 +00:00
Jenkins
8175ce5985 Merge "Remove unnecessary test extension mock" 2015-07-18 01:10:43 +00:00
Jenkins
154f4ed347 Merge "enhance tests for user v3" 2015-07-18 00:55:06 +00:00
Jenkins
7f5bcb5a5b Merge "add functional tests for identity v2" 2015-07-17 23:30:30 +00:00
Jenkins
f16fab739a Merge "Support multiple volume qos delete" 2015-07-17 23:10:21 +00:00
Guojian Shao
ff3dbddf59 enhance tests for user v3
Change-Id: Ib17ba0cd71068ba8d7e7665160daf3ae0735971b
Related-Bug: #1475357
2015-07-17 19:34:16 +00:00
TerryHowe
e7e8760fa6 Remove unnecessary test extension mock
The network extension test does not need this.

Change-Id: I8dd2cad759a813d7df0476afa6c56f455ddff616
2015-07-17 19:30:46 +00:00
TerryHowe
bc28adc62d Remove requirements.txt from tox.ini
From lifeless: pbr reflects the package dependencies from
requirements.txt into the sdist that tox builds.

Change-Id: I63548ec321b9c59cc935ba8179b1da5b9c90e09b
2015-07-17 11:21:02 -06:00
Guojian Shao
566987ecf1 add functional tests for identity v3
add functional tests for endpoint, region and service.

Change-Id: I504878811dc8f9fcb2295cbf7419885959d9c1f6
Implements: blueprint identity-functional-tests
2015-07-17 15:00:23 +00:00
TerryHowe
d82b1f9d73 Add functional tests for volume qos
Change-Id: I80010b56b399bc027ac864304be60a3ee53bda00
2015-07-17 14:15:16 +00:00
TerryHowe
abfb011527 Support multiple volume qos delete
Also make sure that we are using the singular qos_spec when
we should and the plural qos_specs otherwise.

Change-Id: If4bbeb6fc245d7d80dc3d7dccfe9f949e802653c
2015-07-17 14:14:56 +00:00
Jenkins
bbe71eb9a3 Merge "Rename endpoint type to interface" 2015-07-17 13:55:47 +00:00
Guojian Shao
cc522821f6 add functional tests for identity v2
add tests for endpoint and service.

Change-Id: Iec80106d6e4c310cea1c5af262d145ac1f56525e
Implements: blueprint identity-functional-tests
2015-07-17 16:56:51 +08:00
Jenkins
83edde0ec9 Merge "Drop py33 support for Liberty" 2015-07-17 06:26:15 +00:00
Jenkins
ff3af9f9d5 Merge "only return endpoints that have url" 2015-07-17 03:57:45 +00:00
Guojian Shao
7b32ec003b add --project-domain option for user v3
user v3 create/set only support --project option,
we need --project-domain to prevent collisions between
project names exist.

Change-Id: I2d62e5b9bb6df4c5c5a9542514faf2e4365bb18b
Closes-Bug: #1475357
2015-07-16 23:26:11 +08:00
Guojian Shao
7829aca704 only return endpoints that have url
Change-Id: I97a502252c0c377fce573e92b83c0122812f6f80
Closes-Bug: #1474656
2015-07-16 07:25:51 +00:00
Steve Martinelli
37c83e6231 Fix the way we call find_resource when only using ID
Change-Id: I6fb08edd5499767863e0e67f363bcd9fff3aea60
Closes-Bug: 1475127
2015-07-16 06:31:46 +00:00
David Moreau Simard
c830d96e4f Fix image save with API v2
Glanceclient v2 no longer expects the whole image
object, just the image id.

Change-Id: I8f34acfa50ca2d50eb7c9eb1dd5114c4621ad158
Closes-bug: #1475001
2015-07-15 15:41:49 -04:00
TerryHowe
36391a81a3 Rename endpoint type to interface
Change-Id: I4e21d09bc747e8210f4f79a1d6c4c7ccf2f25d1c
Closes-Bug: #1454392
2015-07-15 10:11:59 -06:00
OpenStack Proposal Bot
1af89f757c Updated from global requirements
Change-Id: I0703a48d8c95617e687eea9eea7990d778d760b5
2015-07-15 01:37:44 +00:00
Jenkins
50a5c36ef1 Merge "Remove the --dhcp option to network list" 2015-07-14 20:47:09 +00:00
Steve Martinelli
79c69e1e82 temporarily skip help tests
We're trying to change cliff for the better, by improving the UX
of the help command. But cliff tests against the tip of OSC.

Temporarily skip the tests that are failing and then update them
once the fix for cliff has been merged.

The patch in question: https://review.openstack.org/#/c/201258/

Change-Id: Ie1e7ddd66477ddf4a3bafedad12934e900ace48f
2015-07-13 22:59:15 -04:00
TerryHowe
922074b2d9 Drop py33 support for Liberty
Less is more:
https://wiki.openstack.org/wiki/Python3

Change-Id: I8a98b72f85bb29a3663c654613ac0d70fddbc1b1
2015-07-13 14:50:47 -06:00
Jenkins
963f3049c0 Merge "Fix interactive password prompt" 2015-07-13 18:58:21 +00:00
Jenkins
1ea34fc8a5 Merge "add functional tests for identity v2" 2015-07-13 17:17:06 +00:00
Jenkins
dc3ff5e000 Merge "Show which aggregate a hypervisor is member of" 2015-07-13 17:07:08 +00:00
TerryHowe
ef0cf00b33 Fix interactive password prompt
Change-Id: Ie0e7a9cd6016b5c646a111a76e8372e10602a25c
Closes-Bug: #1473862
2015-07-13 07:44:24 -06:00
OpenStack Proposal Bot
1462fb7f49 Updated from global requirements
Change-Id: Id0d62a51c35a4f7db5144dcbcde1888703fae378
2015-07-12 15:22:26 +00:00
Jenkins
fac52cc606 Merge "Remove testing of cliff command line options" 2015-07-12 14:58:32 +00:00
Jenkins
6b80efb429 Merge "Fix address parsing for server ssh command" 2015-07-12 14:40:29 +00:00
Jenkins
d96f8b532a Merge "Fixes modules index generated by Sphinx" 2015-07-12 05:07:00 +00:00
lin-hua-cheng
f807f0a66e Fix wrong mock method call
There is no assert_called() method in mock, replace it with
assert_called_with() method. The old method used to work with
mock 1.0.1 because it was a noop in magicmock.

Needs https://review.openstack.org/#/c/200583 to pass the requirements check.

https://review.openstack.org/#/c/193935/ changed the OS_* vars
we source by forcing v2password as the auth method.
change our identity v3 test setup by setting v3password

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closes-Bug: 1473454

Depends-on: I0cfab6d13e5d9e744cb302c86a2c21269923e75d

Change-Id: Id22765c7e044797e03d19ad1b103fadec2726aa2
2015-07-11 18:57:20 -04:00
Guojian Shao
e76de2c204 add functional tests for identity v2
split test_identity.py into test_user.py, test_project, etc.
To make functional tests run repeatedly without raising
duplicated error, clean up resources before exiting each test case.

Change-Id: I8f31ccbd70f1cccdab8b3720aac179e2e399486d
Implements: blueprint identity-functional-tests
2015-07-10 15:35:58 +08:00
lin-hua-cheng
89cf9f61b1 Fixes modules index generated by Sphinx
Sphinx was always using (o)penstackclient for the prefix so the index
wasn't very useful.

Change-Id: Ie9f5d7fe428142bdb8027b422e3023418b48c428
2015-07-09 21:40:31 -07:00
Jenkins
35dc2bed9e Merge "openstack catalog list always returns publicURL for internalURL and adminURL" 2015-07-09 15:58:34 +00:00
OpenStack Proposal Bot
a3f50eafa5 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I053c9518ef01e008e63833494d2b51c44d3a64a7
2015-07-09 06:11:22 +00:00
TerryHowe
f89fc1ef32 Fix address parsing for server ssh command
There seem to be three formats for the server address field
and the old code only supported the old format.  This code adds
a parser for all three formats.

Change-Id: I7f12d2c69ff70556907ea6f31a0e0bba91b68b49
Closes-Bug: #1469843
2015-07-08 15:00:51 -06:00
Martin Schuppert
7af00f833f openstack catalog list always returns publicURL for internalURL and adminURL
With this change 'openstack catalog list' returns the correspoding URL for
publicURL, internalURL and adminURL in _format_endpoints .

Change-Id: I5d946c9d70a2d3c22a7cc77067fec8e2e9aa4940
Closes-Bug: 1472629
2015-07-08 21:40:44 +02:00
TerryHowe
2d4a737160 Remove the --dhcp option to network list
The --dhcp option lists agents, not networks.  This does not make
a lot of sense.  Another command should be created to list agents.

BackwardsIncompatibleImpact
Closes-Bug: #1472613

Change-Id: I5ecfe3fc046a07eb64a4dabd41dbd99de7c2215f
2015-07-08 11:21:41 -06:00
TerryHowe
8c7920ddf0 Remove testing of cliff command line options
These options are part of cliff, let cliff test them.

Change-Id: I802c25ba80048607eef6909a21709dcda63231cc
2015-07-08 10:38:35 -06:00
Jenkins
f07f71661f Merge "add functional tests for identity v3" 2015-07-07 18:11:25 +00:00
Guojian Shao
aa3b3c1f0f add functional tests for identity v3
To make test cases more clearly, split test_identity.py
into test_user.py, test_role, etc. Add more test cases for
user, role, etc. Furthermore, to make functional tests run
repeatedly without raising duplicated error, clean up
resources before exiting each test case.

Change-Id: I1541943ad0b8d4d8d1e72822c159fda243b3d1d7
Implements: blueprint identity-functional-tests
2015-07-07 15:57:36 +08:00
Jenkins
dfa80ee9c0 Merge "Add functional tests for volume set size" 2015-07-06 18:52:17 +00:00
Jenkins
e57808d962 Merge "Add functional tests for security group CRUD" 2015-07-06 18:01:35 +00:00
Jenkins
1a45b20ba1 Merge "Add functional tests for flavor metadata" 2015-07-06 17:04:02 +00:00
Jenkins
541ec43cf0 Merge "Add flavor functional test" 2015-07-06 16:04:55 +00:00
Jenkins
8c7e6e7de6 Merge "Add functional tests for server CRUD" 2015-07-05 15:25:41 +00:00
Jenkins
ee64c2fa6b Merge "Add --os-endpoint-type cli optional argument" 2015-07-03 02:48:47 +00:00
Roxana Gherle
5521e4c504 Add --os-endpoint-type cli optional argument
User should be able to specify the endpoint type through
a CLI optional argument/ENV variable setting. We will name this new
optional argument: --os-endpoint-type (Env: OS_ENDPOINT_TYPE) and
based on the value given, the service API will use that specific
endpoint type. Possible values: public, admin, internal.

DocImpact
Closes-Bug: #1454392
Change-Id: Ife3d4e46b44c0ddcd712b1130e27e362545a9a29
2015-07-02 10:10:46 -07:00
David Moreau Simard
3bfaf79732 Show which aggregate a hypervisor is member of
This adds support for showing which host aggregates
a hypervisor is member of, if any.
It supports hypervisors with or without nova cells.

Closes-bug: #1470875
Change-Id: I0cfe4f15fa8f8ba0be3295b79cd438998893114c
2015-07-02 10:23:22 -04:00
Jenkins
d80deaba41 Merge "Move update code from image create command" 2015-07-02 14:08:05 +00:00
Marek Aufart
bd589778c2 Move update code from image create command
Openstack image create command updates existing image (with same name) by
default. That might be confusing since glance allows create multiple
images with same names and may lead to unwanted image update by image
create command.

Image update code was moved from image create action to image set action.

BackwardsIncompatibleImpact

Change-Id: I1686c6544c366262efab9e33c066d5f8a667f707
Closes-Bug: #1461817
2015-07-02 11:02:17 +02:00
Jenkins
60d1417c2f Merge "Add functional tests for image set" 2015-07-01 19:51:13 +00:00
Jenkins
50a80ab97e Merge "Add tests for 'list' and 'show' for volume qos v1" 2015-07-01 19:40:43 +00:00
TerryHowe
700048a1e0 Fix examples with cacert
Change-Id: I2a4f758ef11caf51d0c47cb5632e59245d631d3d
Closes-Bug: #1470272
2015-07-01 05:11:45 -06:00
OpenStack Proposal Bot
a7eb8b5b3f Updated from global requirements
Change-Id: Icf1e3f1292baafe7746fd8804c61ccaab592db65
2015-06-30 22:45:47 +00:00
Jenkins
730b26e349 Merge "Add support for volume API v2 QoS commands" 2015-06-30 20:43:15 +00:00
Jenkins
e3589b3fde Merge "Alphabetize tests for v1 qos_specs" 2015-06-30 16:26:21 +00:00
David Moreau Simard
974c9d5793 Add support for volume API v2 QoS commands
This commit adds the following commands:
  volume qos associate
  volume qos create
  volume qos delete
  volume qos disassociate
  volume qos list
  volume qos set
  volume qos show
  volume qos unset

Change-Id: If3c679557ac9abb0dfc75d290b96fb9c8d46c7b7
Partial-Bug: #1467967
2015-06-29 17:24:35 -04:00
David Moreau Simard
4d832e7beb Add tests for 'list' and 'show' for volume qos v1
Change-Id: I1b4d998f3ec1bd5cb8dd4c9e0d04fd3b3049e9d7
2015-06-29 17:15:31 -04:00
Jenkins
a5259fe008 Merge "Add docs for QoS specs" 2015-06-29 19:07:13 +00:00
David Moreau Simard
1051a46944 Alphabetize tests for v1 qos_specs
As a follow up of sorting the methods for volume v1
qos_specs.

Change-Id: I428167297e7110e586d139bf38fd22d321836e80
2015-06-29 12:25:30 -04:00
Steve Martinelli
862afd1e7b Add docs for QoS specs
QoS v1 was recently included in openstackclient. We should include
command object docs.

Change-Id: I891231be095324bf55eb7ee4bb86debdf7a26f05
2015-06-29 16:16:35 +00:00
Steve Martinelli
36613f9f53 No need for get_parser on QoS list
There are no arguments so there's no need to define the
get_parser function.

Change-Id: Icfa8accf6dbb7f8d1a0472926403b405da3cc611
2015-06-28 23:43:39 -04:00
Steve Martinelli
1d51eb82d0 Alphabetize QoS specs
setup.cfg and the implementation had some functions that were
not in alphabetical order. Since the rest of OSC is alphabetized,
let's stick to that.

Change-Id: Ief5d4694c7b6bc20a0898437b96305885104d45c
2015-06-28 23:42:55 -04:00
Jenkins
4c3f2ed73e Merge "Add support for volume API v1 QoS commands" 2015-06-27 15:55:48 +00:00
David Moreau Simard
7bb038c4a7 Add support for volume API v1 QoS commands
This commit adds the following commands:
  volume qos associate
  volume qos create
  volume qos delete
  volume qos disassociate
  volume qos list
  volume qos set
  volume qos show
  volume qos unset

Change-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9
Partial-Bug: #1467967
2015-06-26 23:19:08 -04:00
Guojian Shao
8899bc4162 fix confused domain argument for network create v2
we have used domain scope arguments --project-domain, --user-domain
and --group-domain in identity commands, for example, role add v3,
to prevent resources conflict from same resource name existence.
To keep with the style of identity commands, it's better to rename
--domain to --project-domain.

Closes-Bug: #1468988
Change-Id: Ic6ccb895cf9be4a3d5f0001525e3b80cd340da8b
2015-06-26 12:08:22 +08:00
Jenkins
ec31a2a12e Merge "Enables retrieval of project's parents and subtree" 2015-06-25 21:51:04 +00:00
Jenkins
2cc679ed9f Merge "Add support to inherited project role grant calls" 2015-06-24 15:26:18 +00:00
Jenkins
c307b6b484 Merge "Updated from global requirements" 2015-06-24 13:02:15 +00:00
Guojian Shao
253ba3c425 fix typo in network.rst
There is a typo for --domain argument in network create:
Owner’s domain (name or ID)",
the last character " should be removed.

Closes-Bug: #1468282
Change-Id: I81d55841e633a52f3913cf5f4a3e6626ebc1f919
2015-06-24 18:14:12 +08:00
OpenStack Proposal Bot
4f12a82679 Updated from global requirements
Change-Id: I4c5304a276b1c2b2ea98c98518217b0201a2c993
2015-06-24 00:21:41 +00:00
OpenStack Proposal Bot
af7f64eae5 Updated from global requirements
Change-Id: Ib550688f8420e8d29b594d90705ef8a89eb03018
2015-06-22 21:43:54 +00:00
Samuel de Medeiros Queiroz
ed241ef9bc Add support to inherited project role grant calls
Once inherited project role grant calls are
implemented on python-keystoneclient,
python-openstackclient also should support such
calls.
This patch add such support as well as its
related tests.

Co-Authored-By: Raildo Mascena <raildo@lsd.ufcg.edu.br>

Change-Id: Id72670be8640e5c6e2490a6ef849e9ec3493b1a9
Implements: blueprint hierarchical-multitenancy
2015-06-22 11:05:01 -03:00
OpenStack Proposal Bot
2d6bc8f4c3 Updated from global requirements
Change-Id: Ie4f93534ec504e7672c88ab02efc8747df91318c
2015-06-22 08:28:06 +00:00
Jenkins
3120a0bd2a Merge "fix typo for server create in server.rst" 2015-06-19 15:31:13 +00:00
Guojian Shao
012e6a7628 fix typo for server create in server.rst
we have <security-group-list> in server create option,
while <security-group-name> in the explanation, they
both should be <security-group-name>.

Closes-Bug: #1466742
Change-Id: I26a25f57e57d8f9e19ec9c9ccb3c2b8d5396b78d
2015-06-19 15:14:04 +08:00
Amey Bhide
ce67c3afa5 Fix typo in user.rst
Change name -> user-name

Closes-Bug: #1466738
Change-Id: I63d6b4f5ac3cacff624c2e951873aa044a699234
2015-06-18 23:47:38 -07:00
Jenkins
2eb0f7287f Merge "Update 1.4.0 release notes" 2015-06-18 20:53:14 +00:00
Jenkins
61cf3ba29e Merge "Updated from global requirements" 2015-06-18 19:56:34 +00:00
Jenkins
6147409c7d Merge "Add support for volume backup v2 command" 2015-06-18 19:53:06 +00:00
Dean Troyer
7354d600e2 Update 1.4.0 release notes
Depends-On: I5b469d19ac58bcb31ebd276e1d62b3db8ccfb5a3
Change-Id: I67daab9045852a5d23d69f9b4290e857f5137121
2015-06-18 15:05:39 -04:00
Jenkins
5e095d66b8 Merge "Refactor option handling for user|group|project domain scoping" 2015-06-17 18:43:32 +00:00
Steve Martinelli
2b0013c5c1 Refactor option handling for user|group|project domain scoping
put the common options in identity.common, this way the help is
consistent

Change-Id: I5b09cfb56fa0f8d16feb95150f216fccbe9f2b22
2015-06-17 12:38:40 -04:00
OpenStack Proposal Bot
383e12e5c5 Updated from global requirements
Change-Id: Ib17c91ef8395b1a4f490765896bffad166aa0ab6
2015-06-16 19:23:16 +00:00
Jenkins
d4893efabc Merge "Add support for volume snapshot v2 command" 2015-06-16 17:57:14 +00:00
Jenkins
8db61ac54d Merge "Add release notes for 1.5.0" 2015-06-16 17:39:54 +00:00
Jenkins
8ce1549ec2 Merge "reference corect ec2 helper function" 2015-06-16 17:39:21 +00:00
Steve Martinelli
291ba625f1 Add release notes for 1.5.0
Change-Id: Idb6941feb3c17694eb5d7dcf1189bb1a08336810
2015-06-16 11:16:52 -04:00
Steve Martinelli
258f4ca6e6 reference corect ec2 helper function
ec2creds.py was referencing a function on self, but wasn't there.
Correctly reference the right function.

Change-Id: I62f09c497be9dbb394341914388d60634e8b80c2
Closes-Bug: 1465561
2015-06-16 11:02:09 -04:00
TerryHowe
ce65164155 Add functional tests for image set
This patch includes functional tests for image set and it includes
a change to use the OSC utils.format_dict method to format the
properties.  This will give a more user friendly format to the image
commands and it gives a more consistent testable format to the
output.  Instead of:

{u'a': u'b', u'c': u'd'}

The user will see:

a=b, c=d

Change-Id: Ib396316586ffc5dbab231064d5b6dc9425507934
2015-06-16 12:34:00 +00:00
OpenStack Proposal Bot
dca47a7bf2 Updated from global requirements
Change-Id: I635a3ff9d1a90d0b1bb1e295a380eddd9d30a295
2015-06-15 03:47:16 +00:00
Jenkins
ba79c3fdfb Merge "Improve the hint message" 2015-06-14 18:41:33 +00:00
Jenkins
724abb37b8 Merge "Fix the typo in openstackclient/shell.py" 2015-06-14 17:52:27 +00:00
Dave Chen
9f69b43f5a Improve the hint message
Currently, we can get scoped token (domain scoped, project scoped)
as well as unscoped token.

When we use OSC to get a domain scoped token without explicitly set
domain information, the hint message show us we need to set a scoped
domain or project, but it miss that the parameters to be set in order
to get project or domain scoped token is not the same.

Thus, the hint message could be improved to make it more clear to
end user.

Change-Id: I94768c619b30be18737fec189ae6d81e81ba090d
2015-06-14 13:31:02 +00:00
Dave Chen
b3289601c7 Fix the typo in openstackclient/shell.py
Change-Id: Ia101f6d50ecd4a195aa93b1f289def581b0c6f38
2015-06-14 14:59:38 +08:00
TerryHowe
ebddb1005d Add functional tests for volume set size
Change-Id: Ie369c6366e1d0632ab1892fd019f5b12528c195b
2015-06-11 13:45:35 -06:00
TerryHowe
c7868451f5 Add functional tests for server CRUD
Change-Id: I77f292d47a9bea6a5b486ce513c0c19ec8c845dd
2015-06-11 18:10:03 +00:00
TerryHowe
83f5befc5e Add functional tests for flavor metadata
Change-Id: Iae7a3f61c0c9777ee2511558d8942243066a8c60
2015-06-11 08:37:35 -06:00
TerryHowe
b0ed8660b1 Add flavor functional test
Change-Id: I3166e1c3fb0f9b89cff8f083d30cb15e7196f59a
2015-06-11 08:32:56 -06:00
Steve Martinelli
ec903a1f09 Add oidc plugin for listing federation projects
the oidc plugin should be included in the list of valid federation
protocols that can leverage `federation project list`

Change-Id: I3f5c5ab262c7097273716a81618a2dcbb159dd6f
2015-06-11 03:42:07 -04:00
Steve Martinelli
aac0d588bd Skip trying to set project_domain_id if not using password
This is already fine for user_domain_id, and needs to be replicated
for project_domain_id. Also added more logging.

Change-Id: I3fa8f29edb3fc430d453bd0fc835312c0c8401f4
2015-06-11 02:43:57 -04:00
OpenStack Proposal Bot
f3725b4761 Updated from global requirements
Change-Id: I4055698d0e4492a17623836e802ac56cd869ab0a
2015-06-11 00:48:27 +00:00
OpenStack Proposal Bot
18991ab9a2 Updated from global requirements
Change-Id: I5b469d19ac58bcb31ebd276e1d62b3db8ccfb5a3
2015-06-10 21:27:27 +00:00
TerryHowe
46f61c87b8 Add functional tests for security group CRUD
Change-Id: Ib5bbd46c0454d7dbb541354d515430922569c994
2015-06-10 11:52:52 -06:00
Jenkins
deb5a9790d Merge "Include links to developer workflow documentation" 2015-06-10 00:42:33 +00:00
Jenkins
ba6c9472a5 Merge "Add functional tests for volume set and unset" 2015-06-10 00:42:16 +00:00
Jenkins
c508162d53 Merge "Imported Translations from Transifex" 2015-06-09 20:27:51 +00:00
Jenkins
bc53b05f8f Merge "Enable specifying domain for group and role commands" 2015-06-09 18:20:34 +00:00
Rodrigo Duarte Sousa
4fab606349 Enables retrieval of project's parents and subtree
Adds the possibility to retrieve a project and list its
parents and subtree in the hierarchy.

Co-Authored-By: Rodrigo Duarte <rodrigods@lsd.ufcg.edu.br>
Co-Authored-By: Samuel de Medeiros Queiroz <samuel@lsd.ufcg.edu.br>

Implements: bp hierarchical-multitenancy

Change-Id: I874f6faffc8a2db9d99f12cbe0a69c0a30c0d9df
2015-06-09 13:10:22 -03:00
OpenStack Proposal Bot
1f1ed4cf6c Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ib086dbeab7cf53a6b147d40594615e6c8bf1b6d1
2015-06-09 06:01:46 +00:00
Monty Taylor
4afd308a4f Include links to developer workflow documentation
Newcomers aren't always sure how to get started with our tools or
workflow. Lucky for them, we have documented these things. Unlucky for
them, they have no idea the docs exist.

Give them some links.

Change-Id: I6fce6fbccb8a9fe16b48845790b4cac05317ebac
2015-06-08 11:43:24 -04:00
Juan Antonio Osorio Robles
f7feef7f8d Enable specifying domain for group and role commands
Many of the commands for the group and role resources were lacking an
option to specify the specific domain groups, projects or users belong
to. This commit fixes that.

Change-Id: I461d2bcfd01ad2dea970de38ec7ad6f4a631ceb1
Closes-bug: #1446546
2015-06-08 17:05:10 +03:00
Dave Chen
7cf779004e Not use the deprecated argument
`project` argument is deprecated in keystoneclient for V3 API,
and use `default_project` instead, should use `default_project`
as the argument name in the openstackclient accordingly.

Change-Id: Ib9d70801c933a184afcdab75204393efa764fa87
Closes-Bug: #1462389
2015-06-08 10:15:24 +08:00
Jenkins
56163aa7bc Merge "Create 1.4.0 release notes" 2015-06-05 00:45:17 +00:00
Amey Bhide
2fce863411 Add support for volume backup v2 command
openstack backup create
openstack backup list
openstack backup restore

Implements: blueprint volume-v2
Change-Id: I77965730065dd44f256c46bcc43c1e6a03b63145
2015-06-04 17:34:50 -07:00
Jenkins
c9d95b41cb Merge "Updated from global requirements" 2015-06-04 23:00:54 +00:00
Jenkins
4cc7313504 Merge "add --domain argument to v3 project set" 2015-06-04 22:21:44 +00:00
Dean Troyer
b80856617f Create 1.4.0 release notes
Change-Id: I2fa7d7875518ceebbdc3936eedfe72d17c81535f
2015-06-04 16:49:12 -05:00
OpenStack Proposal Bot
43d12db709 Updated from global requirements
Change-Id: I243598ee6778297b622c8e29c78b76d8eb5a4692
2015-06-04 20:14:18 +00:00
Amey Bhide
c88b433abb Add support for volume snapshot v2 command
openstack snapshot create
openstack snapshot set
openstack snapshot unset
openstack snapshot list

Implements: blueprint volume-v2
Change-Id: Ia1d9f4426baa0099281a9931f4eec99ebe1969b1
2015-06-04 20:13:19 +00:00
Jenkins
7e067c6f4f Merge "Allow --insecure to override --os-cacert" 2015-06-04 19:27:36 +00:00
Dean Troyer
31d785ec69 Allow --insecure to override --os-cacert
Change --insecure to ignore the --os-cacert setting.  This is a change
from before where OSC followed the requests pattern of cacert taking
priority.

This logic is also introduced in os-client-config 1.3.0; we
do not require that release yet so it is duplicated here for now.
That change will come with the upcoming global options refactor.

Closes-Bug: #1447784
Change-Id: Iaa6d499ed0929c00a56dcd92a2017487c702774a
2015-06-04 09:37:46 -05:00
Jenkins
0c5f12aec0 Merge "Clean up ec2 credentials help text" 2015-06-03 23:04:27 +00:00
Jenkins
7f658c0aca Merge "Add domain support for ec2creds in v3 identity" 2015-06-03 21:08:52 +00:00
Jenkins
1fff11a9ab Merge "Add EC2 support for identity v3 API" 2015-06-03 20:20:12 +00:00
Dean Troyer
3fa0bbc7ee Clean up ec2 credentials help text
Re-sync the text in v2 and v3 help and the docs

Depends-On: If4ac5356ade8cff347bb9eb9f88d1ace82bb7275
Change-Id: Iabef2f271fcf46748295c29713fea1811dcab29c
2015-06-03 15:03:57 -05:00
TerryHowe
8d185a6a6f Add functional tests for volume set and unset
Add functional tests for volume set and unset for metadata and
resource values.

Change-Id: Ief07fc5c480608bb900d55df935b89c503609c80
2015-06-03 12:03:17 -06:00
Steve Martinelli
7665d52a0c Add domain support for ec2creds in v3 identity
A follow up work item from I52ff2020ef2fcbdc8a98280b73c6fd4a93bc8e0f
to support domain scoped users and projects for ec2creds in the
v3 identity api.

Related-Bug: 1236326

Change-Id: If4ac5356ade8cff347bb9eb9f88d1ace82bb7275
2015-06-03 15:33:36 +00:00
Jamie Lennox
15d3717e73 Add EC2 support for identity v3 API
EC2 support is provided for the v2 identity API and is available in
almost exactly the same format in the v3 API and enabled by default.

Supporting EC2 in the v3 identity API in OSC will make it much easier to
transition devstack to a v3 only state.

Closes-Bug: 1236326

Change-Id: I52ff2020ef2fcbdc8a98280b73c6fd4a93bc8e0f
2015-06-03 15:33:15 +00:00
Jenkins
aa7145e0c9 Merge "Fix security group list command" 2015-06-03 14:37:33 +00:00
Jenkins
81558d9ce3 Merge "Get rid of oslo_i18n deprecation notice" 2015-06-03 14:35:11 +00:00
OpenStack Proposal Bot
db7d4ebcfb Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I1e445ea9300686f17d3289fb026fd62b6259e0a0
2015-06-03 06:05:19 +00:00
Jens Rosenboom
bf99218292 Add a reference to the IRC channels
As the name of the associated IRC channel for this project is not
completely obvious, add a reference to the doc index page so that
it may be found easier.

Change-Id: I6cb6e2571bff73db6d983cd96fe6d03319d6577c
2015-06-03 02:53:50 +02:00
Jamie Lennox
226fc6c80a Change Credentials header to Blob from data
The payload data of credentials is the unfortunately named blob.
Currently when listing credentials the payload is excluded as OSC is
looking for a column called data which does not exist.

Change-Id: I6fa4579d7ec9ba393ede550191dbd8aa29767bf4
2015-06-02 17:10:48 -04:00
Jenkins
dff006c3f6 Merge "Rework shell tests" 2015-06-02 16:55:24 +00:00
Jenkins
c02b816a74 Merge "Add volume functional tests" 2015-06-02 16:30:51 +00:00
TerryHowe
f737160777 Get rid of oslo_i18n deprecation notice
Change-Id: I12aa58b808c05d3eb6f5efcdc84df57f54a9782e
2015-06-02 09:21:31 -06:00
TerryHowe
b2cf651100 Fix security group list command
Security group list command tries to get a project list and
this may fail with a multitude of exceptions including but
not limited to 401, 404, ConnectionRefused and EndpointNotFound.
Rather than try to capture every possibility, this patch just
catches the base class.  Converting project ids to names is
less important than having a working security group list command.

Change-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028
Closes-Bug: #1459629
2015-06-02 08:55:54 -06:00
Jenkins
a6ea6d9f94 Merge "Add image functional tests" 2015-06-02 14:49:34 +00:00
Dean Troyer
a05cbf4c99 Rework shell tests
This is the first step in reworking the shell argument handling,
clean up and add tests to ensure functionality doesn't change.

* Rework shell tests to break down global options and auth options.
* Make tests table-driven
* Remove 'os_' from 'cacert' and 'default_domain' internal option names

Change-Id: Icf69c7e84f3f44b366fe64b6bbf4e3fe958eb302
2015-06-02 09:49:17 -05:00
Jenkins
c2e8b80ee3 Merge "Ignore cover directory from git" 2015-06-02 14:32:39 +00:00
TerryHowe
746f6421d0 Add image functional tests
Change-Id: I30b219bc3393fcb197bda266125dcfb5c8780a3e
2015-06-02 05:26:25 -06:00
Jenkins
9bf24f3ae1 Merge "Set tenant options on parsed namespace" 2015-06-02 02:15:52 +00:00
TerryHowe
f9fa307809 Add volume functional tests
Change-Id: I8e12837fb22cabeabf1cde341324927cc6ee0252
2015-06-01 14:21:33 -06:00
Jenkins
4d57e9f62a Merge "Add --wait to server delete" 2015-06-01 20:07:27 +00:00
Jenkins
40634c3f2c Merge "project create is missing --parent in doc" 2015-06-01 15:29:25 +00:00
Jamie Lennox
0c9f5c25e4 Ignore cover directory from git
The cover directory holds autogenerated coverage reports that should
not be checked into git and should therefore go in the gitignore file.

Change-Id: I4f7225b5422493f99bc534d6ac622e0703781e6d
2015-06-01 17:46:02 +10:00
Jenkins
c4bc05b945 Merge "Add support for volume v2 API" 2015-05-31 05:17:38 +00:00
Jamie Lennox
3ae247fdce Set tenant options on parsed namespace
Because of the way OSC registers all plugins together we end up
with os-tenant-X parameters being saved to the project-X attribute after
parsing. If you are using the v2 plugins directly then they and os-client-config
expect the tenant_X values and will assuming no scoping information if
they are not present.

Validating options for scope will also fail in this situation, not just
because the resultant auth dictionary is missing the tenant-X
attributes, but because OSC validates that either project or domain
scope information is present.

Fix this by just always setting the v2 parameters if the v3 parameters
are present. This will have no effect on the generic or v3 case but fix
the v2 case.

Expand validation to include the tenant options so it knows that v2
plugins are scoped.

Change-Id: I8cab3e423663f801cbf2d83106c671bddc58d7e6
Closes-Bug: #1460369
2015-05-31 15:03:42 +10:00
Amey Bhide
5361652d8f Add support for volume v2 API
Added following commands for volume V2 API:
volume show
volume delete
volume type show
volume type delete
snapshot show
snapshot delete
backup show
backup delete

Implements: blueprint volume-v2
Change-Id: I68bd303c194f304ad15f899d335b72a8bf3ebe10
2015-05-30 11:26:14 -07:00
Guojian Shao
d14316a832 add domain scope arguments to v3 role add in doc
There are optional domain scope arguments --user-domain,
--group-domain and --project-domain to filter user, group
and project for command 'os role add', however, the doc
is missing them.

Closes-Bug: #1460296
Change-Id: Ie7c7707d183da042c51e98b6cd4003c89efc4032
2015-05-30 09:30:10 -04:00
Guojian Shao
01573be3f8 project create is missing --parent in doc
'project create' is missing '--parent <project>' argument in doc,
actually it is supported.

Change-Id: Id0edaab4e2b02a1f7d974d71a11c7c373e31806f
Closes-Bug: #1460256
2015-05-30 02:23:32 -04:00
Guojian Shao
542f587364 add --domain argument to v3 project set
Currently argument 'domain' is not supported by command 'os project
set', but it is required by keystone v3 update project API to match
the domain id.

Closes-Bug: #1460122
Change-Id: I1b32f67f78b369f6134a74cdf9a4811b7539d44b
2015-05-29 22:42:42 -04:00
Matt Riedemann
224d375ef4 Add --wait to server delete
This allows the server delete command to wait for the server to be
deleted (obviously).

The wait method is the same model that Tempest uses, i.e. wait for a 404
on server GET (successful deletion), fail if the server went to ERROR
status, or fail if a timeout is reached.  The default timeout of 300
seconds is also what Tempest uses.

Closes-Bug: #1460112

Change-Id: I0e66c400903e82832944d1cad61e7eb30177c3e8
2015-05-29 14:32:51 -07:00
Jenkins
d9b7d13edf Merge "Add cli tests for --verify and friends" 2015-05-29 21:03:03 +00:00
Jenkins
3ee99dc02a Merge "Use ostestr for test runs" 2015-05-29 20:47:09 +00:00
Jenkins
7d3eeb299b Merge "Small tweaks to osc plugin docs" 2015-05-29 19:59:08 +00:00
Matthew Treinish
ae29f7f459 Use ostestr for test runs
This commit switches to use ostestr for running tests. ostestr
integrates the subunit-trace output that other projects use for test
output. (in addition to some other ui niceties)

Change-Id: Ib5b5225b2a7bfb7897e1efe55181389d1ae095cb
2015-05-29 11:31:15 -04:00
Dean Troyer
2c4b87869b Add cli tests for --verify and friends
The tests that will change after the verify-always-true bug is fixed
are currently commented out.  The commented asserts show where we
want to go.

Also fixes --verify parser value

Change-Id: I891e3ead5fc3da3ed2ecba5d2befd9e910778655
2015-05-28 18:01:49 -05:00
Steve Martinelli
da083d171d Small tweaks to osc plugin docs
Change-Id: Ifbc63871e60e8ee843fdfefd8026dc4224fe4e13
2015-05-28 15:58:42 -04:00
TerryHowe
211c14c638 Fix shell tests
Personally, I think these tests should be removed, they are
testing OCC.  An internal OCC change on a private method broke
this test.

Change-Id: I760bf90ef8bd97e30be7838874337be695d45285
2015-05-28 11:01:13 -06:00
Jenkins
e8655f44f0 Merge "Create 1.3.0 release notes" 2015-05-27 21:20:48 +00:00
Jenkins
3d239eddc7 Merge "Add support for v2 image set command" 2015-05-27 20:38:00 +00:00
Jenkins
cb1da522f2 Merge "Remove checks for None dates in keypair functional tests" 2015-05-27 20:03:50 +00:00
Jenkins
dce25815d0 Merge "Remove oslo incubator config" 2015-05-27 20:03:10 +00:00
Jenkins
6e4d6923cd Merge "Remove oslo serialization requirement" 2015-05-27 20:03:06 +00:00
Dean Troyer
a15d8f681a Create 1.3.0 release notes
Change-Id: I1bd91490487b4c5eb6de7ea2aa09848b063071f1
2015-05-27 14:29:24 -05:00
Jenkins
efee80d631 Merge "Adds python-tuskarclient to list of plugins" 2015-05-27 19:20:06 +00:00
Jenkins
806b16a007 Merge "Add some comments about current plugin support" 2015-05-27 19:20:03 +00:00
Amey Bhide
ce05822a3a Add support for v2 image set command
Partial-Bug: #1405562
Change-Id: Ie30802d720a247748c45099c38450cc6c76bbc2a
2015-05-27 11:49:06 -07:00
Petr Blaho
af9275178b Adds python-tuskarclient to list of plugins
Change-Id: Ie3468d14186f69ec9203f11302b8a07dc93dcc5a
2015-05-27 16:31:41 +02:00
Jenkins
aed5af47a1 Merge "Add missing properties to image set command" 2015-05-26 22:43:49 +00:00
Steve Martinelli
575dcdfc8e Remove oslo serialization requirement
Recently oslo serialization has started to also include
python-msgpack. Since we were only using it for json support, we
should just use python's json support. Especially since it's only
used by our tests.

Change-Id: I0f8d939d6fca7608eaa3eea7ea4ca93296aaab3a
2015-05-26 17:40:01 -04:00
TerryHowe
cae03c6834 Remove oslo incubator config
I don't think we are using oslo incubator right now, if it is
needed, this file can be added back.  This will make tab
complete more pleasant as well.

Change-Id: I41957c1449f8278f23ec07bce920524caea01280
2015-05-26 14:50:26 -06:00
Amey Bhide
ba21d463de Add missing properties to image set command
Enable user to update the following image properties from OSC:
container-format, disk-format, size

Closes-Bug: #1446362
Change-Id: Id9f40f15702e8f14f0327a37fcc7d7971338c258
2015-05-25 22:49:55 -07:00
Jenkins
e72d350316 Merge "Fix client error while rescuing an instance" 2015-05-23 16:37:11 +00:00
Steve Martinelli
ab5a89493f Add some comments about current plugin support
Change-Id: Ida9ac9956c611fec783ff98a01628c3d38e7b58f
2015-05-22 17:41:51 -04:00
Terry Howe
9186885553 Remove checks for None dates in keypair functional tests
Steve made a comment about this and I agree, we should try and
keep these tests and simple as possible and this kind of thing
doesn't add much value.

Change-Id: I1eb73e5f38904ee6c74f6c7e27fc66cfe198619d
2015-05-22 13:01:40 -07:00
Jenkins
61cfebb8aa Merge "Enable specifing domains in "role add"" 2015-05-22 20:00:01 +00:00
Jenkins
7cc9632939 Merge "Fix insecure/verify options" 2015-05-22 19:57:46 +00:00
Amey Bhide
7ef9f97b95 Fix client error while rescuing an instance
Typo server._info -> server

Closes-Bug: #1457983

Change-Id: I606505d73b3aae90bac636e960275926284b4ea6
2015-05-22 10:25:57 -07:00
TerryHowe
f8bbbdce24 Add support for keypair functional tests
Change-Id: I5d4730f8229b50d2b162864c74d8eabfef6c0991
2015-05-17 15:12:28 +00:00
Terry Howe
12f1bdde2a Fix insecure/verify options
The insecure and verify options are broken so that verify always
gets set to True.  One problem was that the parsed args not
defaulted so os_cloud_config thinks there was always a command
line specified.  The other problem was getattr was called on cloud
config instead of get.

Closes-Bug: #1450855
Change-Id: Ib5f004f51a7453cc8f5a89759e2031ec42e04a30
2015-05-17 08:52:03 -06:00
TerryHowe
29f29e44d3 Use format options for functional tests
Use the format options for functional tests so we can have more
assertEquals and less assertIn.

Change-Id: I34e6c76b42964f7b596ea35e6b0354a242611cb4
2015-05-17 12:33:39 +00:00
TerryHowe
d39b9c91c4 Fix functional test gate
The functional test gate seems to be broken.  The environment
variables are not being passed through.

Change-Id: Ied1f56877e4793c5e88e59d2afb7f1a5b3868560
2015-05-15 13:25:37 -06:00
Jenkins
e9159d6f1e Merge "Updated from global requirements" 2015-05-12 17:48:38 +00:00
OpenStack Proposal Bot
0fc248c5f0 Updated from global requirements
Change-Id: I432b3224f23616a5181412f01d31d6cedcc2ff84
2015-05-12 14:35:41 +00:00
Juan Antonio Osorio Robles
3ca96ef93c Enable specifing domains in "role add"
If users, projects or groups are provided by name, there is a
possibility of the existence other users/projects/groups with the same
name in other domain.  Even though this is not a problem if the actual
ID is given instead of a name; this is mostly a usability enhancement.

So, three options were added, one for specifying the domain where the
user belongs, another one to specify the project's domain, and finally
one to specify the group's domain.

Change-Id: Iab04b0e04fa75ea5aa3723b8ea42a45f58a6cdb2
Closes-Bug: #1421328
2015-05-12 11:48:01 +03:00
Roxana Gherle
c126a2ae56 Send the correct user-agent to Keystone
When we execute an Openstack CLI command, keystone should log in
Keystone access log that the user-agent that made the request was
'python-openstackclient' instead of the default 'python-keystoneclient'.
Therefore, when we create the authentication session we
need to send the explicit user-agent.

Closes-Bug: #1453995

Change-Id: I75087fd4bb1ff1e6f2a911bc70bf8008268276bb
2015-05-11 17:00:39 -07:00
Jenkins
83d73c2143 Merge "Add os-client-config cli tests" 2015-05-11 19:52:42 +00:00
OpenStack Proposal Bot
0816cd79d4 Updated from global requirements
Change-Id: I94752657b7753d277950168f9efcea7074fb25ec
2015-05-07 23:37:29 +00:00
Jenkins
04d1fc69cf Merge "Security group rule delete broken" 2015-05-07 23:13:24 +00:00
TerryHowe
62bb88f621 Security group rule delete broken
Nova client was changed to take a rule id for security group
rule delete.

https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72

Change-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121
Closes-Bug: #1450872
2015-05-07 13:10:06 -06:00
OpenStack Proposal Bot
4ce3d1dbad Updated from global requirements
Change-Id: Ica958638a86fe3f740aaa37b3d40d57680afd103
2015-05-06 16:09:34 +00:00
Jenkins
a6deef6ef1 Merge "Don't create empty quota set requests" 2015-05-06 15:44:40 +00:00
Jenkins
4b35c2a048 Merge "Imported Translations from Transifex" 2015-05-06 15:40:57 +00:00
Jenkins
c6c1098d2e Merge "Add docs for service provider CRUD" 2015-05-06 15:40:48 +00:00
Jenkins
ec6fbe1abf Merge "Federation Service Providers CRUD operations" 2015-05-06 15:40:15 +00:00
OpenStack Proposal Bot
c0bafb46a9 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I0d706cdce7c4cb49c4bfa84d2d0ab92d591de71b
2015-05-05 06:06:24 +00:00
Jamie Lennox
179ed18c30 Don't create empty quota set requests
The way that getattr is called with the None default you will always
create a compute_kwargs dictionary with key: None values. This means
that we will always send these empty requests to the servers.

Change so that only actually changed values end up in the quota set
requests and get sent.

Change-Id: I33bc3f4e1a8013ec672e995648d27513064baf26
Closes-Bug: #1451640
2015-05-05 12:45:42 +10:00
OpenStack Proposal Bot
1f33a1eda9 Updated from global requirements
Change-Id: I1d339589a5ed94c726a6478318651b9db9765fdd
2015-05-04 20:09:15 +00:00
Dean Troyer
90705f191e Add os-client-config cli tests
Add tests for --os-cloud handling and precedence between CLI,
env vars and clouds.yaml.

Change-Id: I91d96f483d395f19ffcf74ec0187718ba01a1c41
2015-05-01 17:44:57 -05:00
Jenkins
b50ff9d3c5 Merge "Add image show tests" 2015-05-01 21:13:03 +00:00
TerryHowe
9561420a4f minor syntax error in tox.ini
Change-Id: I476ea8f2cf4370e62b6b6b15d72b97beabe6677e
2015-05-01 12:40:46 -06:00
Dean Troyer
47791a1639 Add image show tests
Image v2 uses warlock objects rather than the usua Resource objects
so we need to test for those.  This adds a subset of the Image v2
schema that should be enough to test for proper warlock image handling.

Depends-On: Ic95db2f63d9f5f37e29f0d7e048397da311fbf8c
Change-Id: Ib89cce87f110a554f40e726718e31d39b500a6ae
2015-05-01 11:12:35 -05:00
Amey Bhide
1bb4bb3baf Minor fix to openstack image show command
image show using V2 api was failing.

openstack --os-image-api-version 2 image show <image_id>
ERROR: openstack _info

Closes-Bug: #1450829
Change-Id: Ic95db2f63d9f5f37e29f0d7e048397da311fbf8c
2015-05-01 08:44:59 -07:00
Jenkins
28f65e6650 Merge "Create 1.2.0 release notes" 2015-04-30 20:07:08 +00:00
Dean Troyer
5d5054b6f5 Create 1.2.0 release notes
Change-Id: I82dcd075960d9a4ed8b89471a31a951b274de4fa
2015-04-30 12:08:04 -05:00
Lin Yang
af2a665a63 Fix tiny typo in comment message
compatability => compatibility

Change-Id: I3181fb2b83df1e2cb60a9eedf319f2ad0a487dba
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
2015-04-30 17:21:45 +08:00
Jenkins
634004f33e Merge "Add parent field to project creation" 2015-04-30 03:16:20 +00:00
Jenkins
9b9c396d8f Merge "Redo 1.1.0 release notes" 2015-04-29 16:20:14 +00:00
Jenkins
4451507cce Merge "Remove unique class names because they are scoped" 2015-04-29 06:07:34 +00:00
Jenkins
075987267b Merge "Functional tests run in many environments" 2015-04-29 05:53:09 +00:00
Dean Troyer
cf52e722c0 Minor logging/debug cleanups
This removed the rarely useful cliff command list from the debug output.

Change-Id: I48f22086733acf90e79a6ddac8712734ee2d0b60
2015-04-28 18:15:24 -05:00
Dean Troyer
b1ffbcff0b Redo 1.1.0 release notes
The 1.1.0 release went out without the release notes commit, this
fleshed out the text properly.

Change-Id: I72811689c14a89c8468077d2cc3ab531acb7563b
2015-04-28 16:45:59 -05:00
TerryHowe
75d3130ab2 Remove unique class names because they are scoped
Remove unique class names because they are module scoped.  Also,
add cleanup of the tmp file in the object test.

Change-Id: I8107a02b13ff87793ba1e56e0f0ad26890f24369
2015-04-27 13:51:39 -06:00
Juan Antonio Osorio Robles
48b52a0d40 Raise exception if no session is created
If the clientmanager is unable to create a keystone session (due to
insufficient auth parameters or something else) then the exception
caused by this shouldn't be ignored, as was the case.

On the other hand, we don't want this behaviour in the case of the
'complete' command, so this is now properly detected.

Change-Id: If4f453d23cc87900cda752e9ffbcf41ded59e26f
Closes-Bug: #1444640
2015-04-27 16:54:28 +03:00
TerryHowe
416d840dc4 Reduce parameters to base class execute
Simplify the parameters so we are just passing a command string
to the execute command in the base class.  The string is exactly
the command we are going to run.  This will make debugging
easier and make it clearer what we are actually running.

Change-Id: I0425007e1849f31d692420e38544c55b1acb86c4
2015-04-26 06:37:36 -06:00
TerryHowe
aa7e58cefb Functional tests run in many environments
Have the functional tests running with less customization and
less shell.  This change will allow the functional tests to be
run against any cloud set up in the environment.

Change-Id: I24f621fbace62273e5a0be24e7af9078c0fc8550
2015-04-25 08:42:06 -06:00
Jenkins
2c6c94be52 Merge "Remove references to venv" 2015-04-24 20:34:32 +00:00
Jenkins
4acb01360f Merge "Remove run_tests.sh" 2015-04-24 14:57:37 +00:00
Steve Martinelli
d6fa242818 Remove references to venv
Stick to using tox, remove the tools directory since it only
contained references to using venv. Also update a few other
locations that would have otherwise been incorrect.

Change-Id: I7d3e9067256ac0935f07904abcf584d898ac1d6f
2015-04-24 02:15:36 -04:00
Steve Martinelli
f815b3fe27 Add a doc that dictates backwards incompatible changes
start tracking any changes in a standard format, so users may
have a heads up about any impacts.

Change-Id: Ibc06926a53592e927d11440362cd3598e0d4b2bf
Closes-Bug: 1406470
2015-04-23 23:25:09 -04:00
Steve Martinelli
a81332fad7 Remove run_tests.sh
Use tox instead.

Change-Id: I70f96b301af129e58fd23e6a21c711bbc17940cd
2015-04-23 23:08:17 -04:00
Jenkins
00be0dfc0f Merge "Fix security group create description bug" 2015-04-23 20:05:43 +00:00
Jenkins
f6ac88333c Merge "Security group rule create fails" 2015-04-23 19:57:54 +00:00
Ramaraja Ramachandran
9b6dada8e3 Security group rule create fails
By default the --dst-port value is set to None when no --dst-port
argument is provided. By making the default value (0, 0), this allows
novaclient to proceed without any error.

Change-Id: Ibb58f5df5ed1890a8f499dd2467b12b0e79d547b
Closes-Bug: #1443963
2015-04-22 23:45:33 +00:00
Dean Troyer
11c39530f5 Fix security group create description bug
--description is optional in our CLI but the server requires it to be
non-empty.  Set a default value of the given name.

Closes-Bug: #1434172
Change-Id: I81507a77ad8d815000ff411784ae71e229c77f78
2015-04-22 18:37:31 -05:00
Jenkins
856f641582 Merge "Refactor utility to find identity resources" 2015-04-22 20:26:57 +00:00
Jenkins
166c06ab5f Merge "Adds support for container selection for backup" 2015-04-21 18:45:26 +00:00
Dag Stenstad
2ee904cb2d Adds support for container selection for backup
Changed argument from parsed_args.volume to parsed_args.container as per what
is expected in python-cinderclient.

If not defined, defaults to "backup_swift_container" in cinder.conf.

Stops there being a container for every volume you take backups off.

Change-Id: I4a34894222f71b0f207d007c32427040589406aa
Closes-Bug: 1446751
2015-04-21 18:45:54 +02:00
Dean Troyer
e4fdf6e4e5 Create 1.1.0 release notes
Change-Id: Ib5dd052ed938a844d39a61fcbea0510a2a427ab7
2015-04-21 11:10:48 -05:00
Jenkins
e288e0194c Merge "Handle the pagination for image list" 2015-04-20 20:35:02 +00:00
TerryHowe
3c7b5185ca Handle the pagination for image list
Handle the paginatiion for image list.  We were sorting the
data here, so nothing lost for the generator.

Change-Id: I2d7d4b3d5c9f650953f309c971ac53b64f6f7f77
2015-04-20 11:23:15 -06:00
Steve Martinelli
d733e457e3 Refactor utility to find identity resources
Based on the comments made in this patch:
  https://review.openstack.org/#/c/174908/2/

We should simplify and refactor the way we handle finding identity
resources.

Change-Id: I77db2e3564faa90a917082a6c6cb87269e93aebe
2015-04-20 12:40:33 -04:00
OpenStack Proposal Bot
32843844a3 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I0e7cdac01f3dc8b9368aa891e93125a5e838ae3d
2015-04-20 06:04:10 +00:00
Jenkins
46d9fa1080 Merge "Begin documenting --os-cloud" 2015-04-19 15:16:42 +00:00
Jenkins
2c6a5ca53a Merge "Update the docs for new nic options" 2015-04-19 14:23:12 +00:00
Jenkins
3f84731637 Merge "remove unnecessary conditionals" 2015-04-19 14:23:05 +00:00
Jenkins
c9d3addf2c Merge "Role operations should not require list object permission" 2015-04-19 13:55:33 +00:00
Steve Martinelli
00eeb3593c remove unnecessary conditionals
In several places we had else branches where a reasonable default
would do the job. This makes the code a mean cleaer and easier to
read.

Change-Id: I231e09aab85fd32b8300bc33c48d0899b728b96e
2015-04-19 02:41:04 -04:00
Jenkins
fd8b284164 Merge "Add --os-cloud support" 2015-04-19 06:17:31 +00:00
Jenkins
61fb68e8b3 Merge "Add support for showing limits of a specific project" 2015-04-19 06:15:08 +00:00
Steve Martinelli
e85971b1a6 Update the docs for new nic options
Change-Id: I4c8b93ede80f993eab8badfbba6bf1c530844d54
2015-04-19 01:43:40 -04:00
Dean Troyer
6e7013954d Begin documenting --os-cloud
Change-Id: Id2e98ac5601840f6d380cabcd578f1a6d6d9b245
2015-04-18 23:04:53 -05:00
Dean Troyer
5649695c65 Add --os-cloud support
This adds a new option --os-cloud that allows the configuration values
for multiple clouds to be stored in a local file and selected with
a single option.

Internal option names have had 'os_' removed to be comptible with
the options returned from OpenStackConfig().get_one_cloud().

The config file is ~/.config/openstack/clouds.yaml:

Sample
------
clouds:
  devstack:
    auth:
      auth_url: http://192.168.122.10:35357/
      project_name: demo
      username: demo
      password: 0penstack
    region_name: RegionOne
  devstack:
     auth:
       auth_url: http://192.168.122.10:35357/
       project_name: demo
       username: demo
       password: 0penstack
     region_name: RegionOne

Co-Authored-By: Monty Taylor <mordred@inaugust.com>
Change-Id: I4939acf8067e44ffe06a2e26fc28f1adf8985b7d
Depends-On: I45e2550af58aee616ca168d20a557077beeab007
2015-04-18 23:04:51 -05:00
Jenkins
a5e79d58ae Merge "Defer client imports" 2015-04-19 03:23:12 +00:00
Jenkins
98604abcda Merge "Imported Translations from Transifex" 2015-04-18 16:37:07 +00:00
Jenkins
2ea6f10691 Merge "Suppress warnings user can't fix" 2015-04-18 07:12:03 +00:00
OpenStack Proposal Bot
0e61e5f43c Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I489da64d5c1b14506dfa6619df71afa763f4b3b6
2015-04-18 06:04:12 +00:00
Jenkins
fbb7641694 Merge "Print warning on authentication error" 2015-04-18 05:27:26 +00:00
Jenkins
cb681706fa Merge "Fix session timing" 2015-04-17 20:47:55 +00:00
Steve Martinelli
6c4f81516c Re-organize functional tests
The tests should be further divded by project version, similar to
the structure of the unit tests.

Change-Id: Ied3a4204983cdd253c5602a60968c066038d88f2
2015-04-17 13:37:44 -04:00
Nathan Kinder
4c107e6f1b Role operations should not require list object permission
When using Keystone's policy.v3cloudsample.json policy file, a project admin is
supposed to be able to manage role assignments.  Unfortunately, a project admin
isn't allowed to perform these operations using python-openstackclient, as we
attempt to perform list operations for any of the object types specified (users,
groups, projects). This is done in an attempt to lookup the id of the object by
name, but we perform this list operation even when the user specifies everything
by id. This causes 403 errors.

This patch still attempts to look up the object id by name, but we catch the 403
and assume that the user specified an id if the list operation is not allowed.
This is similar to what we do with the --domain option for other commands.

Closes-bug: #1445528
Change-Id: Id95a8520e935c1092d5a22ecd8ea01f572334ac8
2015-04-17 10:14:57 -07:00
Jenkins
6ce930e846 Merge "Fix skipped image create attribute location attr" 2015-04-17 15:04:57 +00:00
TerryHowe
15bc2ccec9 Print warning on authentication error
At least print a warning on authentication error.  I have no
idea why an exception is being ignored here because if there
is no session, nothing is going to happen.  This at least will
print some useful warning:

    (.venv)terry@f350:~/python-openstackclient$ os flavor list --os-cloud pro
    WARNING: openstackclient.shell Possible error authenticating: __init__() got an unexpected keyword argument 'asdf'
    ERROR: openstack Authentication requires 'auth_url', which should be specified in 'HTTPClient'

This error was caused by having a bogus value 'asdf' in the cloud.yaml
for the cloud pro.

Change-Id: Ie08432e0464cfa86b3b3f67ca29d3b7d23d2f46f
2015-04-17 07:54:05 -06:00
Jenkins
52c4e5fa87 Merge "Uncap library requirements for liberty" 2015-04-17 12:51:03 +00:00
Marek Aufart
d363068617 Fix skipped image create attribute location attr
Image create action accepts attribute called location,
in method body is list of allowed attributes, which contain
localtion, what is typo and this attribute was not passed to
glance. Fixed.

Change-Id: I357b06b63b8aa97f7a5f587ef3fcee7a4b360ed1
Closes-Bug: #1445460
2015-04-17 14:20:37 +02:00
Jenkins
c390d89900 Merge "Better help for --nic in create server" 2015-04-17 07:04:50 +00:00
Doug Hellmann
57806064c0 Uncap library requirements for liberty
Change-Id: Ia2b0c00c5b1da19f2f6995aae3c2e0226a3fa2dc
Depends-On: Ib948b756b8e6ca47a4c9c44c48031e54b7386a06
2015-04-16 18:13:36 +00:00
Jenkins
b72f2fb7ee Merge "Add support to specify volume quotas per volume type" 2015-04-16 04:37:39 +00:00
Dean Troyer
f43c1f7655 Defer client imports
So we really weren't deferring the loading of client libs dadgummit,
do that for real where possible.  This shaves a couple of tenths off
the static import times.

Also defer as much import-time procesing as possible.  This is a little
ugly in api.auth but this also eliminates import of the auth plugins
until they are needed.

Change-Id: Ia11d4b9cf98231d37449103fc29101dc17afb009
2015-04-15 22:40:52 -05:00
Davanum Srinivas
459526e25d Better help for --nic in create server
Use the help string from python-novaclient for a better user
experience.

Closes-Bug: #1444685
Change-Id: If7b8e3f68a0c6ad82b9959f162670b5568d5d12d
2015-04-15 21:17:00 -04:00
Steve Martinelli
8bd8a8dfd7 Add support to specify volume quotas per volume type
Add a --volume-type option to quota set, this will allow users
to set quotas for volume attributes on a per volume-type basis.

for example:
  openstack quota set admin --volume-type myvol --volumes 12

Change-Id: I3ce9cf82a65d4f012b339f0e0dedb752cb132c33
Closes-Bug: 1438377
2015-04-15 01:42:00 -04:00
Steve Martinelli
caf91e69ba Add docs for service provider CRUD
This patch adds service providers to command-objects, and makes
a few changes to the help text, to align it more with the
already established identity provider resource.

Change-Id: Ibf3d2bc04bf5588d1fc9c37b8ca28c007496c021
2015-04-15 05:09:48 +00:00
Marek Denis
ba7ad20942 Federation Service Providers CRUD operations
Adds CRUD support for service providers as it's now available through
keystoneclient

Closes-Bug: 1435962
Depends-On: If802e8a47e45ae00112de3739334b4b5482d0500
Change-Id: Ic55101e50209070aa49ca2adc91c89ba754c8c68
2015-04-15 05:09:15 +00:00
Jenkins
8b44d34054 Merge "Use cliff deferred help instead of homemade one" 2015-04-14 22:14:13 +00:00
Jenkins
520cae655e Merge "Add warning message if unknown version supplied" 2015-04-14 22:05:31 +00:00
TerryHowe
a0fe37e189 Add warning message if unknown version supplied
Print a warning message if an unknown api version is supplied.
An attempt will be made to run the command anyway.

Change-Id: Idec8e88fe9621f10ec4b7eecd90708fb3730f56f
2015-04-13 16:21:50 -06:00
Dean Troyer
0d689871b4 Fix session timing
Subclass keystoneclient.session.Session to add the timing hooks to
record the elapsed time returned by requests.Response objects, including
the redirection history.  Redirects are included individually and not
rolled into the total time for the original request.

This works for all clients that use OSC's session.

Closes-Bug: #1402577
Change-Id: I9360c90c151579b89a37edb8c11c17feb15b3cb9
2015-04-07 23:53:31 -07:00
Steve Martinelli
77e3fbae1a Add support for showing limits of a specific project
Looks like the option to show limits of a specific project was
missing. This resulted in always using the authenticated project.

Change-Id: I512a05df20860ffb52af34f3b64c9eb81dae8c61
Closes-Bug: 1438379
2015-04-03 02:26:22 -04:00
Dean Troyer
ec4ef5f5ba Suppress warnings user can't fix
Requests/urllib3 started issuing warnings about certificates and SSL
that our users are unable to do anything about.  This is a very blunt
way to suppress these warnings unless --verbose or --debug is
supplied on the command line.

Being more precise in the suppression requires importing the warning
classes from urllib3 and dealing with the platforms where it has
been unvendored from requests.  Maybe in the future if there are
concerns that this mutes too much otherwise.

Change-Id: I50bb10a16222de12c5b95bfe042b92e43ea8ee7c
2015-04-02 12:59:34 -05:00
Jamie Lennox
e60bf28ae3 Use glanceclient's inbuilt images find
Glanceclient image listing was special cased as it wasn't implemented in
glanceclient directly. This is no longer the case and we should use
glanceclient's functions.

Change-Id: If8d1246f1bd97c07f9f10f5457aa32124efa0be3
2015-04-02 11:21:07 +11:00
Jenkins
d5f2c50c0f Merge "Updated from global requirements" 2015-04-01 02:00:50 +00:00
Jenkins
8ec2fdce26 Merge "Imported Translations from Transifex" 2015-03-31 18:57:49 +00:00
OpenStack Proposal Bot
f6bd2fa394 Updated from global requirements
Change-Id: I5907d473b34799f9361ad2b611868ad22db3eaf6
2015-03-31 18:38:53 +00:00
OpenStack Proposal Bot
894fe6caf6 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I24c3357026b230c335a5366035a2ff744cd79622
2015-03-31 06:05:13 +00:00
Marco Fargetta
6a9d6af225 Add support to remote_id
The federation APIs for the identity providers introduce a new parameter
for every identity provider, named remote_ids, which contains a list of
entity ID associated with. This parameter can be provided during the creation
of the identity provider and can be updated at any time. For more information
look at the blueprint:

https://blueprints.launchpad.net/keystone/+spec/idp-id-registration

This patch add the support to this new parameter in the command line by
inserting the option "--remote-id" in the following commands:

- "identity provider create"
- "identity provider set"

Additionally, the values can be read from a file, specified by
"--remote-id-file", containing an entity id per line.

Change-Id: Ie93340ee57e54128daa70d8a7bd0a9975ff7eef4
Depends-On: I12a262c55b5f6b5cc7007865edf30f14269da537
Implements: blueprint idp-id-registration
2015-03-30 11:53:17 -04:00
Jenkins
33313eac5a Merge "Add a doc about authenticating against v3" 2015-03-24 01:10:14 +00:00
Jenkins
61579a5105 Merge "Add project and domain params to network create" 2015-03-24 00:09:23 +00:00
Rodrigo Duarte
2ed0e22049 Add parent field to project creation
Adding the possibility to create projects hierarchies by adding
the parent field in the create project call.

Co-Authored-By: Victor Silva <victor@lsd.ufcg.edu.br>

Implements: bp hierarchical-multitenancy
Change-Id: I4eac4f5bc067634cc38c305dacc59ab1da63c153
2015-03-23 15:45:09 -03:00
Colleen Murphy
6c224f5acf Add project and domain params to network create
Without this patch, openstackclient has no way to specify to which
project a network belongs upon creation. Instead, it uses the project
ID that the user is authenticating with to fill the tenant_id column.
This is a problem because an admin user is unable to specify a project
for a non-admin network. To fix this and to improve feature parity with
the neutron client, this patch adds project and domain parameters to
the network create command and uses the given project name to look up
the project ID.

Neutron does not allow the project to be changed after creation, so no
such parameter has been added to the neutron set command.

Neutron calls the field 'tenant_id', but this change exposes the
parameter as '--project' to support the newer terminology.

If no project is specified, the client defaults to the previous
behavior of using the auth project.

Change-Id: Ia33ff7d599542c5b88baf2a69b063a23089a3cc4
2015-03-19 23:49:02 -07:00
Steve Martinelli
7628510182 Add a doc about authenticating against v3
i've had to explain this too many times, and paste the env. vars
i'm using to folks on irc.

Change-Id: I87677c57b309a865c1bd8ea42dc44c00d3ec0489
2015-03-19 14:02:50 -04:00
Marek Aufart
621434451f Add the ability to set and unset flavor properties
Added flavor set and unset command which allow manage flavor
properties called extra_specs.

Command flavor show output was extended with these properties.

Closes-Bug: 1434137
Change-Id: Ie469bade802de18aab9d58eda3fff46064008163
2015-03-19 13:54:19 -04:00
Cedric Brandily
8e92dfc2a5 Use cliff deferred help instead of homemade one
This change removes openstackclient homemade hack to defer help
printing in initialize_app and uses cliff (new) option to defer
help printing.

Change-Id: Ie3e94ec96254745bfef8c5ff5abc405facfe1bea
Related-Bug: #1316622
2015-03-17 23:44:53 +01:00
Jenkins
a8c44074f9 Merge "Look harder to find DevStack" 2015-03-12 03:10:54 +00:00
Jamie Lennox
a9d1e3d219 Base TokenEndpoint plugin on keystoneclient's
Keystoneclient has always provided a TokenEndpoint plugin. Unfortunately
it uses a different option name for url, so subclass the original and
replace the options.

Change-Id: I7e16b31ceb9f75f1c1f6bfb224d8f8f353d06150
2015-03-11 19:16:18 +11:00
Dean Troyer
4b867dfdb0 Create 1.0.3 release notes
Change-Id: I83dd40d0445f8676e72b87fe90b133566cfb5547
2015-03-10 09:23:41 -05:00
Jenkins
2f4cfb6cd5 Merge "Move OSC auth plugins so they can be found" 2015-03-10 05:37:41 +00:00
Jenkins
0fed88fb07 Merge "Update README" 2015-03-10 05:14:20 +00:00
Jenkins
706c51bf96 Merge "Add identity v3 catalog show" 2015-03-10 04:52:14 +00:00
Jenkins
3da6e47e5e Merge "Add identity v3 catalog list" 2015-03-10 04:07:44 +00:00
Jenkins
6edbb63594 Merge "Add ability for diplaying hypervisor statistics" 2015-03-10 03:51:26 +00:00
Dean Troyer
749920bc65 Move OSC auth plugins so they can be found
The plugin detection at the top of openstackclient.api.auth did not
detect the plugins at the bottom of that file because, surprise,
they had not been declared yet so the entry points were ignored.

Move both plugin subclasses into openstackclient.api.auth_plugin.

Fix a problem with the password callback that was otherwise made
worse with this change.

Closes-Bug: 1428912
Change-Id: Idc3b72534071e0013c8922884a8bc14137509a0f
2015-03-10 03:16:12 +00:00
TerryHowe
fa5f02eb22 Add identity v3 catalog show
Change-Id: Ia6b6c25eded43b899b3aa026227ad2859f1c67dd
2015-03-09 23:08:15 -04:00
Dean Troyer
649dbf1ede Update README
Re-orient README toward end-users

Change-Id: I4623832dde72a7ae0eeadf09429402521771dd35
2015-03-09 15:49:44 -05:00
Jenkins
8f7e0ef35e Merge "Fix catalog list when region name is absent" 2015-03-08 17:59:16 +00:00
Jenkins
0efc8668bf Merge "Fix identity v2 catalog list" 2015-03-08 17:59:09 +00:00
Jenkins
5d98bb3800 Merge "Add 'uptime' in 'hypervisor show'" 2015-03-08 14:27:49 +00:00
OpenStack Proposal Bot
0443c20e29 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I938be669e9c25b8aeaeff86f3e08adc90cf86603
2015-03-08 06:04:50 +00:00
TerryHowe
a216746627 Add identity v3 catalog list
Change-Id: Id4c1371ca28b9fd884ec75061edca700fd69886c
2015-03-07 05:57:46 -07:00
Dean Troyer
ee2ba48aa4 Fix catalog list when region name is absent
Some service catalogs in the wild have services without region names defined.
Let's be nice and stuff in a default value indicating this state.

Closes-Bug: #1429211
Change-Id: I3ebe2534dc6e3438aaeddc7757fb2db4117eae4b
2015-03-06 11:28:11 -06:00
Jenkins
b99af443a6 Merge "Raise AttributeError for unknown attributes" 2015-03-06 15:21:05 +00:00
Jenkins
707b5b022f Merge "Fix help messages" 2015-03-06 13:37:55 +00:00
lin-hua-cheng
90c4a0a24f Add ability for diplaying hypervisor statistics
Added new command 'hypervisor stats show' for displaying
the hypervisor stats over all compute nodes.

Change-Id: I4f98c69135b04d4f6cea67cd6350d5d99fb79dba
Partial-Bug: #1423748
2015-03-06 00:11:20 -08:00
lin-hua-cheng
5fddec359d Add 'uptime' in 'hypervisor show'
Fetch the 'uptime' by making a call to hypervisor-uptime.

Update the help for 'hypervisor show' to mention that it
supports by Name or Id.

Change-Id: I31060d203e87749cfc05810c2d9db42f2416051d
Partial-Bug: #1423748
2015-03-06 00:09:20 -08:00
Jamie Lennox
47977fcc32 Raise AttributeError for unknown attributes
Not returning a value is the same as returning None. In the event that
someone asks ClientManager for an attribute that doesn't exist it should
raise AttributeError in the same way as other python objects rather
than return an empty value.

Change-Id: Id0ee825e6527c831c38e3a671958ded362fb96e1
2015-03-05 23:40:26 -08:00
Jenkins
0047b022d5 Merge "Add hypervisor docs" 2015-03-06 07:40:00 +00:00
lin-hua-cheng
09665052ac Add hypervisor docs
Change-Id: I444734925316e876afcbfdeffafea9973a837022
2015-03-05 21:42:03 -08:00
Jenkins
c4cb51f5a8 Merge "Don't hack the image url" 2015-03-06 04:59:51 +00:00
Monty Taylor
59727ba2f9 Don't hack the image url
It's actually breaking usage against HP Public Cloud.

Change-Id: Ic172786c6d1272798b768078a0bcf246f8d64ca8
2015-03-05 20:58:23 -06:00
Zane Bitter
fb2a5492df Fix embarrassing typo in man page
Change-Id: Icf1fcd9f7952ebff9da0081ccb4b9272e17e7de4
2015-03-05 19:15:19 -05:00
Jenkins
5b8f18fe4b Merge "Rename --verify for server resize to avoid conflict" 2015-03-05 20:27:32 +00:00
OpenStack Proposal Bot
dc00d7c758 Updated from global requirements
Change-Id: Iadee329dc9ee5bd3b12a040c732965da43895dc4
2015-03-05 04:58:03 +00:00
TerryHowe
d05b5e14f1 Fix identity v2 catalog list
The v2 catalog list was only printing the last endpoint in
the catalog.

Change-Id: I5401a11eedb3be1513c86261329de50c8ad82720
2015-03-04 10:14:40 -07:00
Ramaraja
8e512017c4 Fix help messages
Update help message for openstack security group rule delete
Update help message for openstack security group rule list

Change-Id: I017ffd424ca25b6c62193b91068eb1ba7de6c919
Closes-Bug: #1417854
2015-03-04 09:48:40 +05:30
Dean Troyer
5d92fc0d0a Handle novaclient >2.20.0
As of 2.21.0 novaclient moved all of the v1_1 classes to v2 with a
deprecation warning.  The version-non-specific interfaces provided in
novaclient.client are insufficient to support a few specific commands in
OSC so we need to conditionally import directly from the correct classes.

Closes-Bug: #1418024
Change-Id: I864b1908737803069dc1419c9cbca391b985c932
2015-03-03 13:02:11 +00:00
Jenkins
9ce112f1a1 Merge "Fix error msg in sort_items" 2015-03-02 17:16:04 +00:00
Jenkins
b972937c82 Merge "Fix auth-required for help command" 2015-03-02 16:19:20 +00:00
Dean Troyer
505fa14cd6 Fix auth-required for help command
When we got picky with the auth arguments we broke using help without
any auth config supplied.  This rearranges things a bit to do the argument
checking when the deferred auth request to Identity occurs so commands
that do not need auth have a chance to live short but useful lives.

Closes-Bug: #1399588
Change-Id: I8ceac491cf65e25eddb62ab2713f471fe686756d
2015-02-27 17:27:17 -06:00
Jenkins
efffee2370 Merge "Revert "Skip functional tests until they are fixed"" 2015-02-27 00:19:33 +00:00
Jenkins
d30f782fbe Merge "change oslo namespace to avoid warning" 2015-02-26 22:53:37 +00:00
Terry Howe
1186cb4c9f change oslo namespace to avoid warning
Change-Id: Ieff86f841623e1ce34b79c66bc5e8b1b239fa3e9
2015-02-25 17:38:34 +00:00
OpenStack Proposal Bot
a00cc815b7 Updated from global requirements
Change-Id: I1ea40d3d9fa0c731c5c25a4dc3981c720d450c45
2015-02-24 16:21:57 +00:00
Steve Martinelli
5bbef2ebbe Revert "Skip functional tests until they are fixed"
This reverts commit 3946bf0e01.

Change-Id: Ic21137b208991c9ce738e5bf3ad5e6965b69e166
2015-02-17 02:11:17 +00:00
zhiyuan_cai
a33f14e298 Rename --verify for server resize to avoid conflict
Currently server resize command has a verify argument for user to
confirm resize operation. But this argument is also registered by
openstack client shell which is used to enable server certificate
verification. So verify argument can not be correctly passed to
server resize command.

This patch renames --verify to --confirm (nova client has a
resize-confirm command) to solve this problem.

Change-Id: I751aa3df16c3b637b82944dd350afc5cbab62120
Closes-Bug: #1416542
2015-02-16 11:00:50 +08:00
zhiyuan_cai
d13023b32a Fix error msg in sort_items
Include direction users pass in the error msg to help users know
which part of the argument is troublesome.

Change-Id: I796a85fbf40f6ddf544fb52a61f967e1914abdcc
Closes-Bug: #1420732
2015-02-11 20:35:08 +08:00
Jenkins
9400effd4b Merge "Restrict groups and users from changing domains" 2015-02-10 07:34:02 +00:00
Jenkins
b317c2442b Merge "Do not allow user to change domain of a project" 2015-02-10 07:17:33 +00:00
Jenkins
28a6acf7ee Merge "Implement trust in identity v3 api" 2015-02-10 04:48:42 +00:00
Steve Martinelli
3946bf0e01 Skip functional tests until they are fixed
Newest python-keystoneclient broke some of our tests, this patch
is just to get the gate less broken.

Change-Id: I8961c63d094e9effde73f6d4088d8626a46e1f3d
Related-Bug: #1420080
2015-02-09 22:05:51 -05:00
Steve Martinelli
07c4fa9d4b Restrict groups and users from changing domains
Similar to projects, we shouldn't allow users and groups to
change domains. The server side tosses up an error but osc
should restrict that behaviour in the first place.

Related-Bug: #1418384

Change-Id: I860291a5859c576021b18e35d1a12c32abfb6ca5
2015-02-09 15:19:11 +00:00
Steve Martinelli
dca9978205 Do not allow user to change domain of a project
Keystone Server already surfaces an error for this operation, but
we should restrict the user, and not offer --domain to be changed
for a project.

Change-Id: I48317e8accfea3c285e6ad213e75b783de8070ac
Closes-Bug: #1418384
2015-02-09 15:18:51 +00:00
Steve Martinelli
cf23fd5cf6 Implement trust in identity v3 api
Added new module in identity v3 api to handle create, read, and delete
operations of trust resources.

Co-Authored-By: Lance Bragstad <lbragstad@gmail.com>
Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Closes-Bug: #1413718
Change-Id: I2b360b141ff70d4f396466abede859a3db6644f4
2015-02-08 20:49:43 -05:00
Jenkins
6525c065a4 Merge "Add sort support to image list" 2015-02-07 18:07:54 +00:00
Jenkins
ee98cb983a Merge "Change volume create --snapshot-id to --snapshot" 2015-02-07 15:07:14 +00:00
OpenStack Proposal Bot
00988d4030 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Id788908b4cbf5de8e8b17cd30f62a4d528a4587a
2015-02-07 06:04:57 +00:00
lin-hua-cheng
60ef8b08fe Change volume create --snapshot-id to --snapshot
Keeping the option --snapshot-id hidden for backward compatibility.

Change-Id: Iefa0aed9be255a5626a9bbb7db77911ef5ca8595
Closes-Bug: #1418742
2015-02-06 16:45:08 -08:00
Jenkins
04d036875f Merge "Add network support to quota show" 2015-02-07 00:17:14 +00:00
Jenkins
09357009c1 Merge "Begin low-level API for Network v2" 2015-02-07 00:16:28 +00:00
Jenkins
863b50cb6d Merge "Adding default user_domain_id parameter only when using password auth" 2015-02-06 23:47:13 +00:00
Jenkins
5cf3929b03 Merge "Check volume status before extending size" 2015-02-06 23:36:54 +00:00
Jenkins
1cb56a6a44 Merge "Added capabilities/options to 'openstack flavor list' command to match capabilities already provided by 'nova flavor-list':" 2015-02-06 23:29:57 +00:00
lin-hua-cheng
8968bc0979 Check volume status before extending size
Added test for Volume Set as well.

Change-Id: I8e6794f67b160ca328fcafa8f1d67138b4f3becd
Closes-Bug: #1415182
2015-02-06 09:05:41 -08:00
Igor_Bolotin
4771feb7c4 Adding default user_domain_id parameter only when using
password auth

Change-Id: I31943739cc1b535cbd402c5e9245b2f7a19cfa32
Closes-Bug: #1418810
2015-02-05 21:30:44 -08:00
zhiyuan_cai
42cff38834 Add sort support to image list
Add sort support to image list by sorting items in the client side.
The parameter syntax follows this spec[1].

[1] https://review.openstack.org/#/c/145544/

Change-Id: I42b487d18f00f937db1938daa46487cea2a896ab
Closes-Bug: #1410251
2015-02-06 10:57:10 +08:00
Marcos Fermin Lobo
0cc3955f0a tenant_id to project_id in server show
The result of 'server show VM_NAME' command shows tenant_id
instead of project_id. All openstack components are moving
from 'tenant' to 'project' naming when we are talking about
openstack projects.

Change-Id: I50053b72e79e1ff3167fa573728da1a81a8e5ed8
Closes-Bug: #1417614
2015-02-04 05:43:26 +00:00
Igor_Bolotin
6d4678185d Added capabilities/options to 'openstack flavor list'
command to match capabilities already provided by
'nova flavor-list':

—public | --private | --all options allows to list
public only (default), private only or all flavors.

—long displays more field. This option also fetches
properties (extra-specs) for each flavor using separate
API call for each flavor and it’s too slow to be done by
default. However as an administrator - sometimes I need
to be able to see them for all flavors.

Removed empty “Extra Specs” column as well as "Swap" and
"RXTX Factor" from default output.

DocImpact
Closes-Bug: #1416780

Change-Id: I30cfa2c75e28daf17b936543a177c23ae1743c37
2015-02-03 07:57:20 -08:00
Jenkins
b131692007 Merge "Improving the help of the lock command." 2015-02-02 05:07:04 +00:00
Pedro Navarro
ee062922d1 Improving the help of the lock command.
The lock command allows you to block the actions
on the server for the non-admin users. Improving
the help so that api users understands better
what locking a server implies.

Change-Id: I925c946751602dc0f6bd1d31b514bc20bca585fa
Closes-Bug: #1366279
2015-02-01 13:15:49 -08:00
OpenStack Proposal Bot
6fd5fc2d27 Updated from global requirements
Change-Id: I2512e4e43f53392fe0c1f8ee4d326688e0cad9c5
2015-01-28 16:40:08 +00:00
Terry Howe
d843255bd8 Change test order to avoid incompatibliity
If py26 or py27 tests are run first, there is a incompatibility in
the .testrepository that breaks several tests.  To get around this,
you need to run the py33 tests first.  This change was made over in
the cliff project.

Before:
    (.venv)terry@brat:~/cli$ rm -rf .testrepository/
    (.venv)terry@brat:~/cli$ tox
      ...
      py26: commands succeeded
      py27: commands succeeded
    ERROR:   py33: commands failed
    ERROR:   py34: commands failed
      pep8: commands succeeded
After:
    (.venv)terry@brat:~/cli$ rm -rf .testrepository/
    (.venv)terry@brat:~/cli$ tox
      ...
      py33: commands succeeded
      py34: commands succeeded
      py26: commands succeeded
      py27: commands succeeded
      pep8: commands succeeded
      congratulations :)
    (.venv)terry@brat:~/cli$

Change-Id: Ie1717efd6827eae36683f2e7fe7ff8ec58ff4aa8
2015-01-28 05:44:37 -07:00
zhiyuan_cai
54ab9fb230 Add network support to quota show
Currently quota show only lists quotas of Nova and Cinder, we
should make it also support Neutron resources. Also, Nova and
Neutron may have conflicts in the quotas of the following
resources: floating ip, security group and security group rule.
When Neutron is enabled, we should display the quotas of the
above resouces in Neutron, not Nova.

Change-Id: I6e508d2077b6cda41ca93d81a82f39aee0ebfb4c
Closes-Bug: #1411160
2015-01-28 16:26:11 +08:00
Jenkins
a4394ebb7a Merge "Add filter to image list" 2015-01-28 05:43:09 +00:00
Jenkins
c3aad41341 Merge "Add the ability to extend volumes in osc volume set" 2015-01-28 05:11:29 +00:00
Dean Troyer
61a40343fd Add filter to image list
* Hides previously broken --page-size option
* Adds --property to image list for filtering on properties
* Adds Visibility, Protected, Owner, Properties/Tags to --long output
* Adds api.utils.simple_filter() for selecting matches out of a list
  of objects
* Adds tests for all of the above
* Updates image docs

There are additional filtering options to be added in later reviews.

Change-Id: I32feff0ad61aae749b33621c817658d7dc90c3aa
Closes-bug: 1401902
2015-01-27 19:17:35 -06:00
Jenkins
2c03f6f42f Merge "fix the wrong order of assertEqual args" 2015-01-27 19:53:44 +00:00
Steve Martinelli
4ff020006e Add the ability to extend volumes in osc volume set
Create a --size option for volume set, so the user may extend
a volume's size.

Change-Id: Ic8d3396d788a14ea1e10bf1da73edfd7f5d85070
Closes-Bug: #1413954
2015-01-27 14:16:03 -05:00
wanghong
127af151ff fix the wrong order of assertEqual args
Let's fix them thoroughly.

Change-Id: I8a1f042fb614b05c9836a49041f3883638b870b0
2015-01-27 17:02:41 +08:00
zhiyuan_cai
520b2f10cf Add 'find by name' to --nic for creating server
Add 'find by name' feature to --nic option for creating server.

Closes-Bug: #1353040
Change-Id: Idd0a30415d8360a57e33efedf2467593652683d4
2015-01-27 05:34:32 +00:00
Steve Martinelli
703a25d445 Remove ignore portion of tox.ini
In the latest hacking update a few rules were dropped, and we no
longer have to ignore these rules in our tox.ini.

Change-Id: Id38a1497019c7fe2d4ad8567f1c0c8d229951751
2015-01-26 00:21:06 +00:00
Jimmy McCrory
71e0e5332a fix object list command naming
Change-Id: I30a62c9b9eb1eeac29f32286ac18c0caed4f380d
2015-01-24 11:45:36 -08:00
Dean Troyer
748e0ab6ce Begin low-level API for Network v2
api.network.APIv2 starts with network_list() support to flush out
the skeleton of the Network API.

list_dhcp_agent() supports the --dhcp option of 'network list'

Change-Id: I9a2b90cde84eced1f2ea6a014b769e2bae668211
2015-01-22 10:06:15 -06:00
Jenkins
b02cce5678 Merge "Command docs: network" 2015-01-22 15:18:33 +00:00
Dean Troyer
20ec40e222 Command docs: network
Change-Id: Ia88b6c0ca5205fa5bfc3efa06ac7f84c4a9e5d4e
2015-01-21 17:49:43 -06:00
Jenkins
326f7e3891 Merge "Add region name for identity and volume clients" 2015-01-21 19:34:00 +00:00
Steve Martinelli
5e43120d43 Add region name for identity and volume clients
We do not take into account region names for identity and volume
clients.

Change-Id: I4263e9013226b0adc6b9ad7540d6ad3efb42e809
Co-Authored-By: Eric Helgeson <erichelgeson@gmail.com>
Related-Bug: #1405416
2015-01-21 01:52:20 -05:00
Dean Troyer
1ecf1bee2d Begin low-level API for Image v1 and v2
image list for v1 and v2:
* Add --public|--private to command parsers
* Implement local public/private filtering for v1 image_list()
* Pass public/private filter to server for v2 image_list()

Change-Id: Ie7c24ea2d1bf2b3b1b7fa342eb45fee45894634d
2015-01-20 17:01:23 -06:00
Jenkins
95fe3fda3d Merge "Create 1.0.2 release notes" 2015-01-19 20:15:02 +00:00
Jenkins
827226edfb Merge "Fix doc building errors" 2015-01-19 19:22:02 +00:00
Steve Martinelli
27b73ac55d Fix doc building errors
Addresses some of the issues that appeared when running tox -edocs

Change-Id: I31133744ee0ddefa72c6590cb381de317e65633e
2015-01-19 13:12:18 -05:00
Jenkins
c9c28dc31d Merge "Add version url config workaround" 2015-01-19 18:08:53 +00:00
Steve Martinelli
98aee9e39a Create 1.0.2 release notes
Also move the release notes to the bottom of the ToC, no need for
it to be at the top, that's prime real estate.

Change-Id: Ib3094a390a7214b320d02f77229f368aa4432c4e
2015-01-19 10:42:29 -06:00
OpenStack Proposal Bot
ab24728377 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ic0553e48357f444da72693bdfcc8bd393df7659e
2015-01-19 06:14:14 +00:00
Abhishek Chanda
052bcb279b Add missing oslo-config to requirements
openstackclient uses these oslo-config but it is not in
list of requirements. That results in a stacktrace while
using the cli.

Change-Id: I9b3c8e491ce09624524cf8b3ddcafcf5953d9ab6
2015-01-18 09:20:09 +00:00
Jenkins
b9e50a716d Merge "Add helpful messages when authN'ing with password" 2015-01-16 21:14:08 +00:00
Jenkins
ee62718dc8 Merge "Update service clist commands for v2 and v3" 2015-01-16 20:52:07 +00:00
Jenkins
655b76f649 Merge "Default user domain id and project domain id" 2015-01-16 19:30:22 +00:00
Dean Troyer
c2c3f2e0f2 Update service clist commands for v2 and v3
Changes to the 'service list' commands for Identity v2 and v3:
* Document support for --long
* Add Description to v3 output with --long
* v3 output is now (ID, Name, Type), with (Description, Enabled) added with --long
* Change v2 output to match v3 output, with the absense of Enabled.
* Update doc to match

Closes-Bug: #1411337
Change-Id: I999e3df22f61350cdeba63bbb7d01145c2ffeeaf
2015-01-16 12:59:14 -06:00
Steve Martinelli
1d75edb167 Default user domain id and project domain id
If either of OS_USER_DOMAIN_ID or OS_USER_DOMAIN_NAME are present
then we don't tinker with anything. Otherwise, we should set
the USER_DOMAIN_ID to 'OS_DEFAULT_DOMAIN', as this provides a better UX,
since the end user doesn't have to specify these arguments.

Same logic applies for OS_PROJECT_DOMAIN_ID.

Closes-Bug: #1385338

Change-Id: I8a4034c16a1dd50d269f809abab8e960d5de20f7
2015-01-16 02:52:15 -05:00
Steve Martinelli
fff4a1cd23 Add helpful messages when authN'ing with password
Setting up auth options can be complicated, and we currently don't
do any checking before we build all our auth parameters to send off
to keystoneclient. We should do some basic checking to guide new
users.

Change-Id: I9c88f1c9637b3870c151952ecc797aaf65be271a
Closes-Bug: #1400531
2015-01-16 02:41:24 -05:00
Jenkins
77097c6cd4 Merge "Imported Translations from Transifex" 2015-01-16 00:32:06 +00:00
Dean Troyer
d3b87d7795 Add version url config workaround
This subclasses KSC's generic Password plugin to allow version discovery with
default Keystone configurations that leave admin_endpoint and public_endpoint
at the default values (http://localhost:xxxx).  This patch copies the scheme
and netloc from the original auth_url into the URL returned from version
discovery if the returned netloc begins with 'localhost'.

Due to the specific nature of this review, the Keystone team is not
inclned to include it in keystoneclient so it is addressed here.

Closes-bug: #1410364
Change-Id: I877fe74d86aab3a63122a07b77d1302a007f5b30
2015-01-15 13:51:31 -06:00
Jenkins
9057cedfd4 Merge "Deprecate project usage list command" 2015-01-15 18:02:34 +00:00
Vladimir Eremin
3296781b2c Use session for neutron client
python-openstack client is now using sessions to create clients. This
patch implements creating Network client using sessions.

Related to c3c6edbe8a

Change-Id: If90ac705eb11dfc1e3abbe2ce18c3d8ccefdbdfb
Closes-Bug: 1411179
2015-01-15 10:33:39 +00:00
Jenkins
8dd8cdcdfe Merge "Check if service.name available before access" 2015-01-15 07:34:36 +00:00
Jenkins
454c19e58d Merge "Copy HIG from wiki" 2015-01-15 06:27:55 +00:00
OpenStack Proposal Bot
c451ff7096 Imported Translations from Transifex
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I1d3551aa84d490930a14937616b8bde2947fb87e
2015-01-15 06:15:07 +00:00
Dean Troyer
bc11c4d7d8 Deprecate project usage list command
Rather than pointing the 'project usage list' entry point directly to
ListUsage, this makes a ListProjectUsage subclass to alias the desired
command and still allow for changing behaviour or issuing a deprecation
messages.  This implementation simply sets a new 'deprecated' attribute
in the command class that cliff will use to skip this command when
generating help output.

The actual skipping of the command in help output is dependant on
https://review.openstack.org/147349 merging in cliff, this review will
simply have no effect on help output until a version of cliff with
that update is present.

The deprecation message printed is somewhat generic until
https://review.openstack.org/147381 is merged in cliff.
Until that is merged, the deprecation message will not have the name
of the actual command given by the user in it, but rather the text
'this command'.

Closes-bug: #1406654
Change-Id: Ie08d4f88d71a660fca1862405351109cd0aa86b6
2015-01-15 00:04:55 -06:00
Jenkins
ef8e8bc32c Merge "Copy wiki content to index page" 2015-01-15 04:05:44 +00:00
Dean Troyer
558e39aa27 Copy wiki content to index page
Copy the content from the main wiki page that is not covered
elsewhere in these docs to the index page.

Change-Id: I94b68b7a0117d08fc8aba961c6de728118ef794e
2015-01-13 22:13:58 -06:00
Dean Troyer
37eda86099 Copy HIG from wiki
This is a basic port of the Human Interface Guide from the OpenStack
wiki to our docs.  Content changes for updating, etc, will follow
in a separate review.

Change-Id: Id031cd6a27e045b249e16d00e41be24c55fb3c29
2015-01-13 17:06:41 -06:00
Jenkins
4a8a2fb27d Merge "Rework role list v2 for --user and --project" 2015-01-13 22:35:21 +00:00
Jenkins
a43d6f02c5 Merge "Updated from global requirements" 2015-01-13 07:50:09 +00:00
Jenkins
dee071528d Merge "Command doc: policy" 2015-01-13 07:45:22 +00:00
Jenkins
872e509ca5 Merge "Tweaks to the catalog doc and show command" 2015-01-13 07:45:15 +00:00
Jenkins
2525ec4e52 Merge "Fine tune some of the helps commands" 2015-01-13 07:41:47 +00:00
Steve Martinelli
c04b49ef07 Tweaks to the catalog doc and show command
Looks like providing a service id isn't working, so it the help
message was reduced to just type and name.
Added a bit more to the docs, too.

Change-Id: Id7f8b48bdf99773ad55ca7f204f3c779f84633d5
2015-01-13 05:59:38 +00:00
Steve Martinelli
019c155e9b Fine tune some of the helps commands
try and add some consistency with the show and delete commands.

replace 'show x' with 'display x'
change 'delete a y' with just 'delete y'

Change-Id: I47dfa8ee23ac5c41b355796415eb515155832f65
2015-01-13 00:58:57 -05:00
Jenkins
b36e90053b Merge "Upgrade hacking to 0.10" 2015-01-13 03:26:23 +00:00
Steve Martinelli
673e0d88ff Command doc: policy
Also tweaked a bunch of the code to not show 'blob', but 'rules'
instead.

Change-Id: I6db798d272ff416a77f169c0e912d2096fa02504
2015-01-12 21:59:44 -05:00
OpenStack Proposal Bot
fa84566dac Updated from global requirements
Change-Id: I4be717979bd4371bc544312d556934aef4f3a629
2015-01-13 00:15:54 +00:00
Jenkins
432dc2bb18 Merge "Updated from global requirements" 2015-01-12 21:12:39 +00:00
Steve Martinelli
b17c475f8a Upgrade hacking to 0.10
Also resolve the only error that was produced.

Change-Id: Ic81ab01aa0cddc15bb27419d7fec3e5a6d4ec0c7
2015-01-12 15:22:39 -05:00
Jenkins
a7a1a576e0 Merge "fix some small issues in catalog show" 2015-01-12 18:14:44 +00:00
Jenkins
e01df5eb28 Merge "Add versioning to the docs that missed it" 2015-01-12 18:14:31 +00:00
Dean Troyer
6ebbd278cf Command docs: add service
Co-Authored-By: Lin Hua Cheng <os.lcheng@gmail.com>

Change-Id: Icd39e6d769fd4c4797fcf4ef9eb97c71ed166b3b
Closes-Bug: #1404434
2015-01-12 05:22:52 +00:00
wanghong
a8f60a8aa1 fix some small issues in catalog show
I think there are three issues we should fix:
1. wrong indentation of 'continue'
2. currently, name is optional for service, but according to the
   currrent logic, if a service doesn't have name attribute we will
   select it anyway
3. we always loop all catalogs

Change-Id: I9fce66677affa396b6a12afea76e87cab9215a58
2015-01-12 12:08:43 +08:00
Steve Martinelli
ffb7832159 Rework role list v2 for --user and --project
`os user role list` does the same as v3's `os role list`.
We should rework v2's `role list` to basically call `os user role list`
under the covers.

Closes-Bug: #1409179
Change-Id: I9839f6be139d6a6a3f6bbf79957e218dd8e03fe3
2015-01-10 01:02:33 +00:00
Steve Martinelli
3b99c17894 Add versioning to the docs that missed it
Change-Id: I8cb90e0d5aca58c4992271e007af91f8cf782643
2015-01-09 19:12:18 -05:00
OpenStack Proposal Bot
80499dc5a1 Updated from global requirements
Change-Id: Iad84313636ee2f53777cdf05d60a322f7a252f27
2015-01-09 18:35:54 +00:00
Steve Martinelli
d2943d2592 Command doc: access token
Change-Id: I1b7103e28273f0a63c7d6b6003317b9e69702b05
2015-01-09 09:20:29 +00:00
Steve Martinelli
d9c217e5bc Request token authorize
Command doc and tweaks to the code

Change-Id: I8f251bf9ca77f16b01a509844e79ddde82048b0d
2015-01-09 09:20:24 +00:00
Jenkins
f8d4dd25b4 Merge "Command doc: snapshot" 2015-01-09 09:17:42 +00:00
Jenkins
c7d7866b0c Merge "Fix up snapshot command" 2015-01-09 09:17:34 +00:00
Jenkins
32c933528b Merge "Request token creation docs + tweaks" 2015-01-09 08:38:46 +00:00
Jenkins
bf964810b7 Merge "Command doc: consumer" 2015-01-09 08:38:39 +00:00
Steve Martinelli
460b530d8b Command doc: snapshot
Change-Id: Ibe5cd0a8422788762e0c52b702b7bd54e6a46813
2015-01-09 03:14:08 -05:00
Steve Martinelli
0170733270 Fix up snapshot command
Several issues with the current snapshot command were resolved:

  * --long for list was added to include volume id/name, and properties
  * changed output from metadata to properties
  * added new option to set properties with 'snapshot set'
  * added new command to unset properties with 'snapshot unset'

Change-Id: I5902cfe876cefada701d4d658a50a4282ff300d6
2015-01-09 03:04:31 -05:00
Steve Martinelli
0d7a50d384 Command doc: image
Change-Id: Ib1563b58351315dc2a44ad77882f8c834a1214c0
2015-01-09 00:16:21 -05:00
Jenkins
f38d6e7aee Merge "Allow user list to filter by project" 2015-01-08 23:07:12 +00:00
Jenkins
b7a130ff44 Merge "Command doc: federation protocol" 2015-01-08 23:07:06 +00:00
Jenkins
1dd6112501 Merge "Command doc: identity provider" 2015-01-08 23:06:59 +00:00
Jenkins
0af779a91b Merge "Command doc: mapping" 2015-01-08 23:06:13 +00:00
Jenkins
c1f28bf7ca Merge "Command doc: backup" 2015-01-08 23:04:59 +00:00
Jenkins
e252bae4c7 Merge "Fixup backup list output" 2015-01-08 23:04:51 +00:00
Steve Martinelli
6025fa83f1 Request token creation docs + tweaks
Added command docs, and changed request token to take in name or
id of a project, and also support a domain option.

Change-Id: I87363274e5b7a0c687e234f5a4bcaaf166d28840
2015-01-08 22:28:26 +00:00
Steve Martinelli
c885c72cba Command doc: consumer
Change-Id: Ie687e1d7f80810106a64204828299f9d143b8d7c
2015-01-08 17:28:09 -05:00
Jenkins
3c57603caf Merge "Command docs: volume" 2015-01-08 22:04:09 +00:00
Steve Martinelli
0ff28d5251 Allow user list to filter by project
Adds a --project filter to `os user list`, which really
calls the role assignment manager behind the scenes.

Change-Id: I57a75018f12ed3acdf8f6611b6b58bd974f91da2
Closes-Bug: #1397251
2015-01-08 16:49:17 -05:00
Steve Martinelli
a0c63dedf4 Command doc: federation protocol
Change-Id: I1289eb0caf31fca21c5c377cf13aebd1434a00ee
2015-01-08 21:41:43 +00:00
Steve Martinelli
c9cf126a83 Command doc: identity provider
Change-Id: Ie73accfaa3d45205a2521e6e61efd16142c460b2
2015-01-08 16:41:28 -05:00
Steve Martinelli
e8be3b64c1 Command doc: mapping
Also tweaked the code for `mapping set` as it was previously
using cliff Show instead of cliff Command.

Change-Id: I0ea1383a9f2dddf4b2f717b2aa16bbd60ab1720c
2015-01-08 16:39:06 -05:00
Steve Martinelli
79d0e21a45 Command doc: backup
Change-Id: Iecd4dbddea637bd6540d94b37253a9ba434c9db3
2015-01-08 21:05:19 +00:00
Steve Martinelli
55b8540374 Fixup backup list output
Name and Description were not appearing at all, and we didn't have
a --long alternative, which had a bunch of useful information.

Closes-Bug: #1408585
Change-Id: I7ca42a8d23ad60f6b9cc862799cb08a3e491b6e8
2015-01-08 21:03:47 +00:00
Jenkins
31e4f7f143 Merge "Command doc: volume type" 2015-01-08 20:55:10 +00:00
Jenkins
9477857a19 Merge "tweak the server command docs" 2015-01-08 20:50:07 +00:00
Steve Martinelli
265ca582f0 Command docs: volume
Change-Id: Id1e500d5fb19ffdeb0d1bde9e22c3143c0873d0c
2015-01-07 16:58:12 -05:00
Steve Martinelli
6b196d1a17 Update the command list
We've been making changes to the commands.rst file as we
add command docs, looks like we missed a few.

Also fixed a few typos

Change-Id: Ie93280a7e5ba37303a1984a68870b5a4fc5c6e06
2015-01-05 23:09:11 -05:00
Steve Martinelli
ca92608974 Command doc: volume type
Change-Id: I7e36daa027639d6a782043d4181c1b328335975a
2015-01-05 21:46:32 -05:00
Steve Martinelli
34975edd14 tweak the server command docs
the formatting used for the server commands is not the same as
the other command docs, this patch addresses that issue.

Change-Id: I5f31cf6a317d9eb35ec46185800fade3dd956dc4
2015-01-05 01:36:35 -05:00
Jenkins
32c15633f4 Merge "Add endpoint v3 docs" 2015-01-04 05:07:50 +00:00
zhiyuan_cai
369ae3f9f0 Check if service.name available before access
Currently v3 endpoint commands access service.name directly, while
name is not a required attribute of service. So if we associate an
endpoint to a service without name, we will get an AttributeError
executing v3 endpoint commands later. This patch addresses this
issue by checking if service.name is available before accessing it.

Change-Id: I3dd686ef02a2e21e2049a49cb55634385c2ecfaf
Closes-Bug: #1406737
2015-01-04 11:26:18 +08:00
Jenkins
cbb26724fc Merge "Command docs: group" 2015-01-03 03:24:11 +00:00
Dean Troyer
3807354cfe Command docs: group
Fix up formatting for group command docs and help

Change-Id: Icda79842d52da90d5eac2b0fdbc0d576d371378d
2015-01-03 02:09:28 +00:00
Jenkins
6698f14fdb Merge "type should be required for v2.0 service create" 2015-01-03 00:47:25 +00:00
Jenkins
2ef136f5b7 Merge "Add missing content for token commands" 2015-01-03 00:12:06 +00:00
Jenkins
79f8ce6893 Merge "Command docs: ec2 credentials" 2015-01-02 23:03:42 +00:00
Jenkins
9d5a7c7c1b Merge "Rename column to default project id for long listing v3 user" 2015-01-02 19:11:45 +00:00
Jenkins
8132072630 Merge "Add docs for usage show/list" 2015-01-02 17:54:30 +00:00
Dean Troyer
b56da8dde2 Add endpoint v3 docs
(update: change version description formats for API versioning)

Change-Id: I499ea1d80ad6ad6392468305f761e695d7261e33
2015-01-02 11:29:07 -06:00
Dean Troyer
4f7777ca0e Command docs: ec2 credentials
Add ec2 credentials docs

Change-Id: I1699d1c8e9859153557081966654646966a3268d
2015-01-02 11:01:36 -06:00
Jenkins
6c0d4b82e0 Merge "Command docs: region" 2015-01-02 09:17:00 +00:00
Jenkins
ee912035ca Merge "Command docs: domain" 2015-01-02 08:50:15 +00:00
Steve Martinelli
e7ec6bc6e4 Rename column to default project id for long listing v3 user
Previously this column was coming up as empty, since user's
have a `default project id`, not just `project id`.

Change-Id: I3d7f7eb600e9526b9c6cc2a8c5d6009b9100b1f5
2015-01-02 02:39:44 -05:00
Steve Martinelli
db6986bec6 Add missing content for token commands
Minor tweaks and added some content to token issue/revoke

Change-Id: Icdad6354f008f9c109d263e115acd10ff113695a
2015-01-02 02:33:35 -05:00
Steve Martinelli
480921d0e8 Add docs for usage show/list
Change-Id: Iaf911d69a0b63d705f8789a4640018a428b87be6
2014-12-31 14:21:48 -05:00
Dean Troyer
0720c78199 Command docs: flavor
Change-Id: Ie85ff7706ef08b70ab8ba99533465d90904cf393
2014-12-31 12:09:50 -06:00
Jenkins
e62ea50f7d Merge "Add docs for listing availability zones" 2014-12-31 16:43:18 +00:00
Dean Troyer
f18f264ed7 Command docs: domain
Change the implementation of --enable|--disable on domain create
and set commands to our usual style.

Change-Id: I10f2b96281a114fa3cf3b001394844770b2a8632
2014-12-31 10:08:51 -06:00
Dean Troyer
b5ce0f145f Command docs: region
Fix up formatting fro region command docs and help

Change-Id: Icf8c03da38b30fc69e7fe70f9c14aaa99881d320
2014-12-31 10:07:14 -06:00
Jenkins
377fd0b69c Merge "Bunch of formatting tweaks to server-image docs" 2014-12-31 09:12:06 +00:00
Steve Martinelli
caef59a4a8 Add docs for listing availability zones
Change-Id: I4c005e1d8089b46feca6cd3266f63c408648f074
2014-12-31 02:54:36 -05:00
Steve Martinelli
b81d0f4d08 Bunch of formatting tweaks to server-image docs
Change-Id: Id2dad09ea75e0615519862db007700389db8cd51
2014-12-31 01:13:50 -05:00
Jenkins
3c28436268 Merge "Rename os project usage list to os usage list" 2014-12-31 03:42:38 +00:00
Jenkins
60aec78c6f Merge "Catch exception when getting quota" 2014-12-31 02:43:43 +00:00
Jenkins
50a8377969 Merge "list availability zones for compute" 2014-12-31 01:54:05 +00:00
lin-hua-cheng
4a07e63e7e type should be required for v2.0 service create
Updated the service name to be optional, mostly matching the cli arguments
with v3 service create.
Implemented the following changes on service create:
- if only a single positional is present, it's a <type>.
  This is not currently legal so it is considered a new case.
- if --type option is present the positional is handled as <name>;
  display deprecation message
- if --name option is present the positional is handled as <type>.
  Making --type optional is new, but back-compatible
- Made --name and --type mutually exclusive.
- only '--name <service-name> <type>' shall appear in the help output

Change-Id: I8fd4adba3d8cd00d5a8cacc2c494d99d492c45a3
Closes-Bug: #1404073
2014-12-30 17:31:29 -08:00
Jenkins
5206278992 Merge "Add usage show command" 2014-12-31 00:02:11 +00:00
Jenkins
95313d0a2d Merge "Fix a few issues with 'usage list'" 2014-12-31 00:02:04 +00:00
Jenkins
694cd12cbd Merge "Command object docs: container, object" 2014-12-30 22:33:22 +00:00
Dean Troyer
d5caa6a26b Command object docs: container, object
Change-Id: Ie3df543a28cbee0cc809310a05f431c97b2c7e70
2014-12-30 16:09:54 -05:00
Jenkins
457f4c8998 Merge "Properly format 'attached to' column list when listing volumes" 2014-12-30 21:01:10 +00:00
Jenkins
8593b0a56a Merge "Allow service description to be set for KS V3" 2014-12-30 21:01:03 +00:00
Jenkins
416f4d7cef Merge "Revert some docs changes from multi-delete" 2014-12-30 21:00:55 +00:00
Jenkins
be8cac9cea Merge "add doc for domain command" 2014-12-30 17:06:07 +00:00
zhiyuan_cai
7ea5f89043 Catch exception when getting quota
Quota show command will list both the quotas of nova and cinder.
But if cinder service is not enabled, EndpointNotFound exception
will be raised and thus the command is broken. Catch this exception
so quotas of nova can be listed.

Change-Id: If2d2820675aa6a12e407d608fed846b21c953b2d
Closes-Bug: #1390507
2014-12-30 09:53:26 +08:00
Steve Martinelli
3ccf1a2606 Rename os project usage list to os usage list
There really isn't anything project specific about the command,
it should really just be `os usage list`. For at least one
development cycle we should keep the old command.

Change-Id: I4d1df801576c259b527e87369f3121b94393cfa8
2014-12-26 03:27:45 -05:00
Steve Martinelli
5761a0f0b7 Add usage show command
Should show basic usage by project id, if not specified then
use the project id the user is authN'ing with.

Change-Id: I0284a5efd84075b18e1a7117cc9f8f7fecf16274
Closes-Bug: #1400796
2014-12-26 03:25:51 -05:00
Steve Martinelli
6e3c9a3d2d Fix a few issues with 'usage list'
* Added number of servers column, was missing
* Added a new line character after the initial usage message

Change-Id: I6c4e5bda6ba9ceafa92ecf13987c56d0bbe99961
2014-12-26 03:23:10 -05:00
Jenkins
3cb8b0ca6f Merge "Compute calls ignore region selection" 2014-12-24 18:00:20 +00:00
Jenkins
26dbad5cfb Merge "add doc for role assignment command" 2014-12-24 15:15:26 +00:00
Terry Howe
1927b03cc7 Compute calls ignore region selection
Calls to compute commands ignore region selection.  The region is
not passed to the get_endpoint call.

Change-Id: I1ccfc56d7cb27a00b8982232a40ace21f2c0e9a2
Closes-Bug: 1405416
2014-12-24 06:08:19 -07:00
wanghong
e5d71221ad add doc for group command
Change-Id: Iaaa0aeb42f9f940af63863f5d09011b5f7529281
2014-12-24 14:31:12 +08:00
wanghong
e3ba13b320 add doc for role assignment command
Change-Id: I594d444b6d1ec4e72bed03394178293737f26069
2014-12-24 14:23:25 +08:00
wanghong
d240b709b9 add doc for domain command
Change-Id: I8b5575a5f27362fa375746b955e1f17a5a8b29a6
2014-12-24 11:55:27 +08:00
lin-hua-cheng
36ab944d2e Allow service description to be set for KS V3
Change-Id: Ibf84882c9a9f408268c225190436fc1a534e1017
Closes-Bug: #1404997
2014-12-23 18:06:13 -08:00
Dean Troyer
ea53cc357a Revert some docs changes from multi-delete
The headers in the doc files are the commands, not a description.

I missed thiese in the original reviews:
https://review.openstack.org/140567
https://review.openstack.org/140581

Change-Id: Iae2631f6b485e8c568ff305e5992c193f80ebe71
2014-12-23 16:31:26 -06:00
Jenkins
a24d6e7c6f Merge "add multi-delete support for compute/image/net/volume" 2014-12-23 22:23:45 +00:00
wanghong
d8f1cbd984 add multi-delete support for identity
This is part2. Add support for these objects:
identity.project(v2.0)
identity.role(v2.0)
identity.user(v2.0)
identity.project(v3)
identity.role(v3)
identity.user(v3)
identity.group(v3)

Closes-Bug: #1400597
Change-Id: I270434d657cf4ddc23c3aba2c704d6ef184b0dbc
2014-12-23 09:39:29 +08:00
wanghong
470b7e53a8 add multi-delete support for compute/image/net/volume
This is part1, add support for these objects:
compute.server
imagev1.image
imagev2.image
network.network
volume.volume
volume.backup
volume.snapshot

Closes-Bug: #1400597
Change-Id: Ice21fee85203a8a55417e0ead8b509b8fd6705c1
2014-12-23 09:31:10 +08:00
Steve Martinelli
71d9c8b5b3 Properly format 'attached to' column list when listing volumes
Previously, no data was being returned for the 'attached to' field
when listing volumes. Dig into the the returned array to format
the column.

Change-Id: Iebd79e5ddcb4a335703d9b2675aa7128995de918
Closes-Bug: #1404931
2014-12-22 13:20:41 -05:00
Jenkins
3541b0a695 Merge "Updated from global requirements" 2014-12-19 20:20:18 +00:00
Jamie Lennox
25a7c1f27f Don't import form keystoneclient.openstack.common
The keystoneclient.openstack.common directory is where we sync files
from oslo incubator. It is not a public directory and should not be
being consumed by openstackclient.

Change-Id: I011bb95c2c824e2dbc4b822ca922ae77b8d9b955
2014-12-17 18:17:56 +10:00
Steve Martinelli
381b47ff05 list availability zones for compute
Adds the command `os availability zone list`

Change-Id: I77bf52a9b84a62c3771a4838c9ea0c3af03eedb2
Closes-Bug: #1400795
2014-12-16 23:00:52 -05:00
OpenStack Proposal Bot
a4208a7201 Updated from global requirements
Change-Id: I3b1cd7aac5c9603dfaccbd4ae30d07cbf7c96da2
2014-12-12 22:21:32 +00:00
Dean Troyer
52d22359f1 Tweaks after the fact
Change-Id: Id96203de023b3b8bde1984a61c41dd9bc1711de4
2014-12-08 18:00:16 -06:00
Dean Troyer
c7a5ead8c7 Release 1.0.1
Fix 'ec2 credentials' regression

Change-Id: Ieb22f6c535ff42a14162cafc88df6099486f9afe
2014-12-08 12:40:31 -06:00
Jenkins
8b9f45c162 Merge "Followup for ec2 credentials command fix" 2014-12-06 16:50:19 +00:00
Dean Troyer
1a25cbaf8f Followup for ec2 credentials command fix
Add functional tests for 'ec2 credentials' commands.

Also fix tenant_id in output for create and show.

Change-Id: I6ba3249b67408571624709e17f8aa2ac6d80237d
2014-12-05 22:21:32 -06:00
Jenkins
95b1853396 Merge "Workflow documentation is now in infra-manual" 2014-12-06 00:15:58 +00:00
Dean Troyer
62a2083a78 Fix ec2 credentials commands for new auth
These commands were not updated for the new authentication model.

Closes-Bug: 1399757

Change-Id: I5d4beb9d1fa6914fef5e4c7b459cdd967e614b24
2014-12-05 12:54:22 -06:00
Jeremy Stanley
1dc0e2b552 Workflow documentation is now in infra-manual
Replace URLs for workflow documentation to appropriate parts of the
OpenStack Project Infrastructure Manual.

Change-Id: Id09c9bdf8804c1ed90e49606e76ffbff1d96a7c2
2014-12-05 03:30:40 +00:00
Jenkins
a977748414 Merge "1.0.0 release notes" 2014-12-04 22:52:39 +00:00
Jenkins
3f8b4d2238 Merge "Command object docs: catalog, credentials, endpoint, region, token" 2014-12-04 22:50:38 +00:00
Jenkins
8c9bf31687 Merge "Add documentation of interactive mode" 2014-12-04 22:11:58 +00:00
Jenkins
f6fc2db2ef Merge "Safely pop project parent id" 2014-12-04 22:11:51 +00:00
Dean Troyer
6a61dbc86f Command object docs: catalog, credentials, endpoint, region, token
catalog
credentials
endpoint
region
token

Change-Id: Icd7ec7fd207488b2ceb0280722aa9a684aeeac28
2014-12-04 15:45:06 -06:00
Steve Martinelli
13672123fc Safely pop project parent id
Since we don't support multitenancy yet, we should just pop the
parent id of a project. When keystoneclient supports mulittenancy
we should bring everything in at once (CRUD), and these changes
should be removed.

Change-Id: I82c7c825502124a24ccdbadf09ecb2748887ca5d
2014-12-04 15:34:02 -05:00
Dean Troyer
625a8ae42d Add documentation of interactive mode
This is a light description with some examples.

Change-Id: Iff9ad904a150f2bb7673bd4106cf26bcefec08b9
2014-12-04 15:16:05 -05:00
Steve Martinelli
f702428158 1.0.0 release notes
Release notes for our next cut of osc.

Change-Id: Ic3b0d557f2a380c4b5a05903ff7394be7b961b55
2014-12-04 14:51:05 -05:00
Dean Troyer
ac4950b46e Command object docs: server, server image
server
server image

Some cosmetic changes in the command source, sorting classes, help strings, etc.

Change-Id: I3f68dae77b9fe02bc6866684e05aeff943dd9cc3
2014-12-03 13:34:44 -06:00
Jenkins
cc54f989ec Merge "Add the ability to list projects based on a user" 2014-12-02 05:40:10 +00:00
Jenkins
2663e16389 Merge "Add support for domains when deleting identity v3 resources" 2014-12-02 00:43:03 +00:00
Jenkins
9eb757f95e Merge "Updated from global requirements" 2014-12-01 23:54:31 +00:00
Jenkins
19c01ff6a0 Merge "Command object docs: project, role, user" 2014-12-01 23:45:42 +00:00
Jenkins
1989198eac Merge "Enhance the theming for modules page" 2014-12-01 23:06:53 +00:00
Steve Martinelli
5bc768bbc2 Add the ability to list projects based on a user
Essentially performing GET /users/{user_id}/projects

Change-Id: Iae6ddfc86a856fa24fbe293ec4af52ea671390f8
Closes-Bug: #1394793
2014-12-01 22:37:08 +00:00
Steve Martinelli
4b239eea42 Add support for domains when deleting identity v3 resources
Currently, only deleting via IDs is possible for groups, projects
and users.
We should have an optional --domain argument that allows for
a name to be specified for the resource. (Since these are all
namespaced by domains).

Change-Id: I18ace3db85a3969f0b97678d432d6f8368baa9cd
2014-12-01 22:36:54 +00:00
Dean Troyer
04d30c1855 Command object docs: project, role, user
project
role
user
user role

Change-Id: I445e09a3ffb69114912ae562a9285963a636bfd1
2014-12-01 17:36:20 -05:00
Jenkins
7e6b68ded9 Merge "Command object docs: aggregate, console *, keypair" 2014-12-01 22:32:35 +00:00
Jenkins
17bf9cdf1c Merge "Begin copying wiki command list here" 2014-12-01 22:32:27 +00:00
OpenStack Proposal Bot
3ad16897bb Updated from global requirements
Change-Id: I2ae7af05f2052d8a8878e6477c8746cfdd1b74fa
2014-11-21 18:33:29 +00:00
Jenkins
a2450d85e0 Merge "Liberalize version matching a bit" 2014-11-21 14:38:14 +00:00
Dean Troyer
9eb30efbf3 Command object docs: aggregate, console *, keypair
aggregate
console log
console url
keypair

Change-Id: Iec9b8404ed5febd061a5dfd674b76aaa8aba67bc
2014-11-19 14:47:53 -06:00
Dean Troyer
254910d3ce Begin copying wiki command list here
* Sort by command objects
* Drop the comparison to the project CLIs
* Minor updates to command help to match docs

Initially include the cross-API commands to establish the structure and format.

Change-Id: I77a7b3c89e088b66aa62941e29ce0b65b532285b
2014-11-19 14:47:53 -06:00
Jenkins
ae00019c64 Merge "Fix volume create --image" 2014-11-19 17:37:14 +00:00
Jenkins
6d589ac801 Merge "add keystone v3 region object" 2014-11-19 04:18:38 +00:00
Steve Martinelli
6dc128636e Enhance the theming for modules page
Also fixes a few small docstring syntax errors

Change-Id: I85eb968e32c1191cf5d60d02deff2ab7f3291074
2014-11-18 22:07:57 -05:00
Jenkins
cb40b5da97 Merge "Add --or-show support for v3 identity resources" 2014-11-18 22:28:01 +00:00
Jenkins
be32793d23 Merge "Add authentication description doc" 2014-11-18 18:54:35 +00:00
Dean Troyer
39116bf594 Fix volume create --image
'volume create --image' should allow an image name to be used.

Closes-Bug: #1383333
Change-Id: I996d46db321eef2d75c3d19b480319f8a78c09b3
2014-11-18 09:35:08 -06:00
wanghong
6edc9b89ed add keystone v3 region object
Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>

Change-Id: Ia6f607630dbf507681733c3ab3b9b7c55de30f49
Closes-Bug: #1387932
2014-11-18 09:46:26 -05:00
OpenStack Proposal Bot
25f1c8b98a Updated from global requirements
Change-Id: Ifd9110cf94dfd2f62e59939a7be1a88e919beb36
2014-11-18 11:37:03 +00:00
Jenkins
57364804f6 Merge "Add environment variable in the os-auth-type help" 2014-11-18 09:25:21 +00:00
Steve Martinelli
79653afa7b Add --or-show support for v3 identity resources
Add --or-show for the following:
  * v3 roles
  * v3 projects
  * v3 domains
  * v3 users
  * v3 groups

Closes-Bug: #1390389
Change-Id: Id4ef043e5fda6be49a515eb3fe138c813c393ec9
2014-11-18 04:58:13 +00:00
Jenkins
3b1c308b11 Merge "Add arg to 'server image create' tests" 2014-11-18 03:47:30 +00:00
Jenkins
d827bdaaed Merge "Add additional support for --or-show" 2014-11-18 03:18:10 +00:00
Dean Troyer
0d56d0178b Add authentication description doc
This is represents the current operation

Closes-Bug: #1337422

Change-Id: I8092e7723b563647e13b6e2f0b7901a16572b6c7
2014-11-17 14:21:03 -05:00
Marek Denis
c1b376dc33 Add environment variable in the os-auth-type help
Help for option --os-auth-type doesn't specify what environment variable
configures it. This patch fixes that.

Change-Id: Id2e29e477d5ca56339bd777fb73b5af13788615b
2014-11-17 09:50:12 +00:00
Jenkins
a9670b4cf0 Merge "Add more session/api examples" 2014-11-17 06:01:32 +00:00
Jenkins
b4ca5cc9c1 Merge "Add an API example base and functional test base" 2014-11-16 17:41:33 +00:00
Dean Troyer
2b02beaa51 Liberalize version matching a bit
For class-loading purposes we can just use the major version,
so accept that. Only Identity and Compute were affected; Compute
is included just to be pedantically complete.

For command groups we also just use the major version so fix
Compute and the version option handling.

Change the internal default for Identity to a simple '2' so it
is also consistent with the rest of the world.

Then comes microversioning...

Closes-Bug: #1292638
Change-Id: Ibaf823b31caa288a83de38d2c258860b128b87d8
2014-11-16 11:37:52 -06:00
Dean Troyer
01a5ff6d32 Add more session/api examples
* examples/object_api.py - Example of using the Object_Store API
* examples/osc-lib.py - Minimal client to use ClientManager as a library

Also add matching functional tests

Change-Id: I4243a21141a821420951d4b6352d41029cdcccbc
2014-11-15 16:29:14 -06:00
Steve Martinelli
126b2c5436 Add an API example base and functional test base
Add examples/common.py, which is a basic common setup that mimics OSC's
configuration options and logging without the rest of the CLI.

Also add the functional test tooling for examples to prevent bit rot.

Co-Authored-By: Dean Troyer <dtroyer@gmail.com>
Change-Id: Ie92b675eafd93482ddc9a8ce0b0588e23ed50c35
2014-11-15 16:29:08 -06:00
Dean Troyer
be3cbd22bd Look harder to find DevStack
Change-Id: Ice5cc560513c5ada1c7a525464cd2823d5979542
2014-11-14 17:01:49 -06:00
Jenkins
f5a2811b65 Merge "Remove links from oauth consumers" 2014-11-14 22:21:18 +00:00
Jenkins
8f40259ada Merge "Remove links from federation related commands in identity v3" 2014-11-14 22:21:06 +00:00
Dean Troyer
936722d59f Add arg to 'server image create' tests
The 'protected' column was not being checked.  Also add it to
image.fakes.IMAGE.

Change-Id: Ie431e9871a7da78b5a3924bfbc51d5575d994d86
2014-11-14 16:13:01 -06:00
Steve Martinelli
7242113a8f Add additional support for --or-show
Add --or-show for the following:
  * v2 roles
  * v2 projects

Change-Id: Ibbae19cda668575b9527fbd259f1298c48b8265b
2014-11-14 16:29:57 -05:00
Jenkins
c55fdb6f6d Merge "Beef up object-store tests" 2014-11-13 22:11:43 +00:00
Steve Martinelli
3e97e1775d Remove links from oauth consumers
This should be the last of the v3 identity objects that return
a links section upon create or show.

Change-Id: I45a3b43c303bfed73950095bec8860cbea7a559c
2014-11-13 16:48:59 -05:00
Steve Martinelli
070fa5091d Remove links from federation related commands in identity v3
We should remove the 'links' portion from the returned object
for the following commands:

* create/show federation protocol
* create/show mapping
* create/show identity provider

Change-Id: I55654cce1f89de8e532f9acd8092257be33efd85
2014-11-13 16:04:49 -05:00
Jenkins
a4ef821438 Merge "cleanup files that are created for swift functional tests" 2014-11-13 17:16:27 +00:00
Jenkins
b8d8e35a27 Merge "Tests work fine with random PYTHONHASHSEED" 2014-11-12 23:19:12 +00:00
Jenkins
89f485f605 Merge "Use fixtures from keystoneclient for static data" 2014-11-12 21:54:07 +00:00
Steve Martinelli
27b0ff5cda cleanup files that are created for swift functional tests
Currently this portion of code is also being run when running
tox to debug local tests. Which is very annoying since a developer
will end up with a bunch of uuid files. Rather than creating it
once per run, we can have a setup/teardown that is handled safely.

Change-Id: I49a0bb3d14f24c54da93458d1e3b9093a1120453
2014-11-12 16:45:21 -05:00
Oleksii Chuprykov
ab89ef5876 Tests work fine with random PYTHONHASHSEED
Change-Id: Iba6fc87bbff289ae2572a7eb132f5c946dfa0956
Related-Bug: #1348818
2014-11-12 15:55:39 +02:00
Jenkins
c8ddfd8311 Merge "Swap remaining assertEqual arguments" 2014-11-10 19:01:52 +00:00
Jenkins
3001d602c5 Merge "Add --or-show option to user create" 2014-11-10 18:58:36 +00:00
OpenStack Proposal Bot
951ca3a6f3 Updated from global requirements
Change-Id: I778a0c00da51cdc52cd67d1b273d52e84d68992b
2014-11-08 14:25:05 +00:00
Dean Troyer
46f6df5f23 Swap remaining assertEqual arguments
Change-Id: I1abdebb298b93074657a7ba65a7186d814969780
2014-11-07 15:08:08 -06:00
Dean Troyer
42d0b20ebc Add --or-show option to user create
The --or-show option is added to create commands for the common case
of needing to ensure an object exists and getting its properties if
it does or creating a new one if it does not exist.

Note that if the object exists, any additional options that would
set values in a newly created object are ignored if the object
exists.

FakeResource needs the __name__ attribute to fall through utils.find_resource.

Prove the concept on v2 user create then propogate once we're happy with it...

Change-Id: I6268566514840c284e6a1d44b409a81d6699ef99
2014-11-07 12:28:42 -06:00
Colleen Murphy
59735bf10d Add cliff-tablib to requirements
cliff-tablib gives cliff the ability to format list and show output in
html, json, or yaml (http://cliff-tablib.readthedocs.org/). This patch
adds cliff-tablib to requirements.txt so that it can be installed along
with cliff.

Change-Id: I4daab97642482e6f40cd8209ff5edd9c680092c0
2014-11-07 15:48:40 +01:00
Jamie Lennox
b193793636 Use fixtures from keystoneclient for static data
We should use the fixture generation code from keystoneclient rather
than keep our own copies of the token and discovery structure.

Change-Id: I53c1d2935d1d65c39b8abea89427af2fc3edd181
2014-10-31 15:15:54 +01:00
Matthieu Huin
631ed3c802 Unscoped federated user-specific commands
A federated user can authenticate with the v3unscopedsaml plugin and
list the domains and projects she is allowed to scope to.
This patch introduces the new commands 'federation domain list' and
'federation project list'.
Note that for these commands -and plugin- to be available, the lxml
library must be installed.

Change-Id: I2707b624befcfb0a01b40a094e12fd68a3ee7773
Co-Authored-By: Florent Flament <florent.flament-ext@cloudwatt.com>
2014-10-30 17:27:28 +01:00
Dean Troyer
2c9d263611 Fix server create for boot-from-volume
* server create required --image even when booting the server from a
  volume.  Change options to require either --image or --volume to
  specify the server boot disk.  Using --volume currently uses device
  'vda' for the block mapping and ignores any other block mappings
  given in --block-device-mapping.
* server create and server show are both affected by bug 1378842 where
  an excepion was thrown when no image ID was present in the returned
  server object, which is the case for a server booted from a volume.
* Fix the remaining assertEqual() order problems in test_server.py

Closes-Bug: 1378842
Closes-Bug: 1383338
Change-Id: I5daebf4e50a765d4920088dfead95b6295af6a4d
2014-10-24 17:55:44 -05:00
Dean Troyer
8ba74451ee Adjust some logging levels
* Promote select messages to INFO so lower logging levels can be useful
* Help more modules not say so much all the time

Change-Id: I814023c1489595998ae74efe40ef439b3522ee74
2014-10-24 13:16:41 -05:00
Jenkins
d07ae4236a Merge "Close files on image create" 2014-10-24 16:16:04 +00:00
Jenkins
d140d8940f Merge "Close files on server create, add tests" 2014-10-24 16:12:06 +00:00
Jenkins
747a62494c Merge "Change --os-auth-plugin to --os-auth-type" 2014-10-24 16:11:42 +00:00
Jenkins
6a4b673e88 Merge "Update use of open() in object API" 2014-10-24 06:38:22 +00:00
Dean Troyer
f079b5b9c4 Change --os-auth-plugin to --os-auth-type
User's don't know what a plugin is.

* Internally, os_auth_type and/or auth_type represents what the
  user supplied.
* auth_plugin_name is the name of the selected plugin
* auth_plugin is the actual plugin object

Plugin selection process:
* if --os-auth-type is supplied:
  * if it matches against an available plugin, done
  * (if it can map to an availble plugin type, done; TODO in a followup)
* if --os-auth-type is not supplied:
  * if --os-url and --os-token are supplied, select 'token_endpoint'
  * if --os-username supplied, select identity_api_version + 'password'
  * if --os-token supplied, select identity_api_version + 'token'

Change-Id: Ice4535214e311ebf924087cf77f6d84d76f5f3ee
2014-10-23 15:37:44 -05:00
Dean Troyer
c91d1ca663 Beef up object-store tests
* Add object top-to-bottom tests
* Move some fakes around
* Clean up existing object tests

Change-Id: If8406da611c11bbd2b1bf5153e45b720b0eea442
2014-10-22 23:41:21 -05:00
Jenkins
7153ff41fb Merge "Include support for using oslo debugger in tests" 2014-10-22 23:29:30 +00:00
Jenkins
b5bee429a4 Merge "Clean up shell authentication" 2014-10-22 20:04:28 +00:00
Steve Martinelli
e7bba3211a Include support for using oslo debugger in tests
Simply run `tox -e debug <test_name>` to get an interactive
debugging prompt

Change-Id: I09e5b844a33c2f0fd4230f01fbc6c0aa8d752545
2014-10-22 14:29:36 -04:00
Dean Troyer
e063246b97 Clean up shell authentication
* Remove the auth option checks as the auth plugins will validate
  their own options
* Move the initialization of client_manager to the end of
  initialize_app() so it is always called.  Note that no attempts
  to actually authenticate occur until the first use of one of the
  client attributes in client_manager.  This leaves
  initialize_clientmanager() (formerly uathenticate_user()) empty
  so remove it.
* Remove interact() as the client_manager has already been created
  And there is nothing left.
* prepare_to_run_command() is reduced to trigger an authentication
  attempt for the best_effort auth commands, currently the only
  one is 'complete'.
* Add prompt_for_password() to ask the user to enter a password
  when necessary.  Passed to ClientManager in a new kward pw_func.

Bug: 1355838
Change-Id: I9fdec9144c4c84f65aed1cf91ce41fe1895089b2
2014-10-21 23:16:16 -05:00
Jenkins
5b7d3ba9dc Merge "Fix token issue after auth changeup" 2014-10-21 19:56:59 +00:00
Dean Troyer
cd368bb816 Fix token issue after auth changeup
IssueToken.take_action() was missed in updating the structure of
the ClientManager.

Also, TOKEN_WITH_TENANT_ID in v3 is just wrong...

Closes-Bug: #1383396

Change-Id: If2dd82a26af1d743ee9df73e0c1aebce497bf22e
2014-10-20 18:21:51 +00:00
wanghong
f600c0eafb only generate one clientmanager instance in interactive mode
Currently, we repeated to generate clientmanager instance when run
command in interactive mode. This should be avoided.

Change-Id: I0536a690bc173be38af08a2e4443115532041efd
Closes-Bug: #1383083
2014-10-20 15:29:53 +08:00
Dean Troyer
2166d7d3af Remove ClientManager._service_catalog
Anything that needs a service catalog can get it directly from
auth_ref.service_catalog, no need to carry the extra attribute.

ClientManager.get_endpoint_for_service_type() reamins the proper
method to get an endpoint for clients that still need one directly.

Change-Id: I809091c9c71d08f29606d7fd8b500898ff2cb8ae
2014-10-18 00:01:52 -05:00
Dean Troyer
0de67016c7 Remove now-unnecessary client creation hacks
Clients that can use ksc Session don't need the old junk to
fake auth anymore:
* compute
* volume

Clients that still need to be fed credentials can pick directly
from the auth object in clientmanager.  The _token attribute is
removed, the token can be retrieved from the auth object:

  openstackclient/tests/common/test_clientmanager.py

This change will break any plugin that relies on getting a token
from instance._token. They should be updated to use the above, or
preferable, to use keystoneclient.session.Session to create its
HTTP interface object.

Change-Id: I877a29de97a42f85f12a14c274fc003e6fba5135
2014-10-18 00:01:45 -05:00
Jenkins
68130fa921 Merge "Add plugin to support token-endpoint auth" 2014-10-17 23:27:28 +00:00
Jenkins
efc572efc1 Merge "use jsonutils in oslo.serialization instead of keystoneclient" 2014-10-17 22:33:53 +00:00
Jenkins
b40fa49809 Merge "Move plugin stuff to clientmanager" 2014-10-17 20:13:55 +00:00
wanghong
deda023314 use jsonutils in oslo.serialization instead of keystoneclient
keystoneclient/openstack/common/jsonutils.py is removed in this patch
https://review.openstack.org/#/c/128454/
Now, we should use jsonutils in oslo.serialization package.

Change-Id: I7c8e8e6d5dffa85244368fd578616c9b19f4fd21
2014-10-17 14:13:32 +08:00
Jenkins
fa9cdef874 Merge "Add 'command list' command" 2014-10-14 22:23:20 +00:00
Dean Troyer
89217a6557 Close files on server create, add tests
The files opened for the --files and --user-data options were never
closed, potentially leaking memory in a long-running client. Close
them if they are file objects.

Add a couple of basic tests for server create.

Change-Id: I1658b0caa2d6af17308149cb52196ee28266ddf2
2014-10-14 15:45:20 -05:00
Dean Troyer
ca783f4659 Close files on image create
The file opened for --file was never closed.  Close it if it is a
file object.

Change-Id: I7bd120a2413de42339771d01e8fd1894d38c3011
2014-10-14 15:37:23 -05:00
Jenkins
1d9194d4cb Merge "Put pbr and six first in requirements list" 2014-10-14 05:40:50 +00:00
Jenkins
87f5da02c3 Merge "Fix operation on clouds with availability-zones" 2014-10-14 04:11:24 +00:00
Dean Troyer
897418edca Move plugin stuff to clientmanager
The OSC plugins work by adding an object as an attribute to a
ClientManager instance.  The initialization and management of
thos plugins belongs in clientmanager.py.

At this point the only part not moved is the API version dict
initialization bcause the timing and connection to the
CommandManager initialization.  It gets refactored anyway when
API discovery becomes operational.

Change-Id: If9cb9a0c45a3a577082a5cdbb793769211f20ebb
2014-10-13 23:02:34 -05:00
Dean Troyer
bcf4b3caec Update use of open() in object API
* Switch to use io.open() for py3 compatibility and simpler testing.
* Open files in 'rb' mode to avoid translation on Windows

Previously tests simply relied on files that were present in the
repository to run tests using open().  Change the filenames to ensure
that no longer happens.

requests_mock doesn't have a way to match against the request body for
PUT/POST; an attempt to add a new Matcher to do that worked but it
needs to subclass the currently private adapter._Matcher class or
duplicate most of its functionality.

Change-Id: I8c30b41db20af8ecafe67e760e872fc08adec905
2014-10-13 10:34:11 -05:00
Jenkins
79a9331f95 Merge "Remove 'links' section from several v3 Identity objects" 2014-10-13 03:26:27 +00:00
Monty Taylor
a388ce40f4 Put pbr and six first in requirements list
Each of them have scenarios where it's important that they install
first.

Change-Id: Ia9fff6e94651693f9fa74ca676771b19144bcd8b
2014-10-12 17:10:07 -05:00
Jenkins
36212c43d8 Merge "Updated from global requirements" 2014-10-12 21:52:07 +00:00
Dean Troyer
c3c6edbe8a Add plugin to support token-endpoint auth
The ksc auth plugins do not have support for the original
token-endpoint (aka token flow) auth where the user supplies
a token (possibly the Keystone admin_token) and an API endpoint.
This is used for bootstrapping Keystone but also has other uses
when a scoped user token is provided.

The api.auth:TokenEndpoint class is required to provide the
same interface methods so all of the special-case code branches
to support token-endpoint can be removed.

Some additional cleanups related to ClientManager and creating
the Compute client also were done to streamline using sessions.

Change-Id: I1a6059afa845a591eff92567ca346c09010a93af
2014-10-12 16:48:43 -05:00
Jenkins
49c74229b4 Merge "Mark identity v2 resources for translation" 2014-10-12 18:50:27 +00:00
Jenkins
4a34e7d0e6 Merge "Update compute server messages for translation" 2014-10-12 07:30:33 +00:00
Jenkins
5fcd462ead Merge "Add translation markers for user v2 actions" 2014-10-12 07:20:09 +00:00
Jenkins
c39867f980 Merge "Fix issue token for v3" 2014-10-12 07:11:20 +00:00
Steve Martinelli
a8d4b0eebb Remove 'links' section from several v3 Identity objects
The links field in the returned objects from the v3 Identity
API aren't really useful, so let's remove them.
Managed to remove most of them from the core API.
I'll likely remove the extension/contribution (oauth/federation)
related ones in another patch.

Also in this patch the code for setting services and projects
was changed. Though not incorrect, it was not needed to copy
the entire returned object, we should just need to pass in
the fields we want to update.

Change-Id: I164ca9ad8b28fa10b291e9115ef40753e387c547
2014-10-11 22:35:12 -04:00
Steve Martinelli
1b3c7ec122 Fix issue token for v3
Currently the code is broken as it references a part of
keystoneclient that does not exist.

Change-Id: I7fbc754537fbb4acffb166b5854840acfaef1fb8
Closes-Bug: #1379871
2014-10-11 20:34:09 -04:00
OpenStack Proposal Bot
7b046f9511 Updated from global requirements
Change-Id: I2ac5b9ac545c1bb6ec6279ecbe74e3301eb07a25
2014-10-11 22:37:59 +00:00
Monty Taylor
3af547a1a6 Fix operation on clouds with availability-zones
In a cloud with AZs, you can get multiple entries back from the service
catalog - one for each AZ and then one that is AZ agnostic that's tied
to the region. If the region_name is plumbed all the way through, this
works as intended.

Change-Id: I3b365ea306e8111fc80830672ae8080a5d1dc8e0
2014-10-11 14:30:04 -07:00
Nathan Kinder
f0c57e17c9 Allow --domain to be used for identity commands without lookup
Performing create, list, or set operations for users, groups, and projects
with the --domain option attempts to look up the domain for name to ID
conversion.  In the case of an environment using Keystone domains, it is
desired to allow a domain admin to perform these operations for objects in
their domain without allowing them to list or show domains. The current
behavior prevents the domain admin from performing these operations since
they will be forbidden to perform the underlying list_domains operation.

This patch makes the domain lookup error a soft failure, and falls back
to using the passed in domain argument directly as a domain ID in the
request that it sends to Keystone.

Change-Id: I5139097f8cedc53693f6f71297518917ac72e50a
Closes-Bug: #1378565
2014-10-09 13:29:21 -07:00
Steve Martinelli
b61db3eb72 Add translation markers for user v2 actions
implements bp use_i18n

Change-Id: I86508a232c9cf88695b7982dad0b9b02eaf8b3a1
2014-10-09 14:47:19 -04:00
Steve Martinelli
364071a90b Add domain parameters to user show for Identity V3
Update `user show` for Identity V3 to account for a domain argument,
in doing so, also update `find resource` to be more flexible by
allowing **kwargs.
Also update `group show` and `project show` since they follow the
same logic as a user within a group.

Change-Id: Ib828e4dbeb0bd31164396069ce8a64c873179779
Closes-Bug: #1378165
2014-10-09 14:34:48 -04:00
Steve Martinelli
bb71df9ced Mark identity v2 resources for translation
mark v2 catalog, ec2, endpoint, project, role, service and token

Change-Id: I14a5852bfee4ca9e25130d001fdadd7778ad0996
2014-10-09 14:16:45 -04:00
Matthieu Huin
0c77a9fe8b Support for keystone auth plugins
This patch allows the user to choose which authentication plugin
to use with the CLI. The arguments needed by the auth plugins are
automatically added to the argument parser. Some examples with
the currently available authentication plugins::

  OS_USERNAME=admin OS_PROJECT_NAME=admin OS_AUTH_URL=http://keystone:5000/v2.0 \
  OS_PASSWORD=admin openstack user list

  OS_USERNAME=admin OS_PROJECT_DOMAIN_NAME=default OS_USER_DOMAIN_NAME=default \
  OS_PROJECT_NAME=admin OS_AUTH_URL=http://keystone:5000/v3 OS_PASSWORD=admin \
  OS_IDENTITY_API_VERSION=3 OS_AUTH_PLUGIN=v3password openstack project list

  OS_TOKEN=1234 OS_URL=http://service_url:35357/v2.0 \
  OS_IDENTITY_API_VERSION=2.0 openstack user list

The --os-auth-plugin option can be omitted; if so the CLI will attempt to
guess which plugin to use from the other options.

Change-Id: I330c20ddb8d96b3a4287c68b57c36c4a0f869669
Co-Authored-By: Florent Flament <florent.flament-ext@cloudwatt.com>
2014-10-09 12:34:47 +02:00
Jenkins
866965f011 Merge "Update for cliff commandmanager >=1.6.1" 2014-10-09 04:43:01 +00:00
Jenkins
8554fd24fe Merge "CRUD operations for federated protocols" 2014-10-09 03:59:33 +00:00
Jenkins
d87868720e Merge "Pass in domain and project as positional args, not kwargs" 2014-10-09 03:23:03 +00:00
Dean Troyer
d32185cb34 Add 'command list' command
* Add method to CommandManager to retrieve command names by group
* Add ListCommands

To list command groups loaded by cliff

Change-Id: I37fe2471aa2fafa8aa223159452d52b1981021d6
2014-10-08 21:57:26 -05:00
Marek Denis
14c61a0ace CRUD operations for federated protocols
Openstackclient needs to have a capability to manage federated protocols
(like saml2, openid connect, abfab). This patch allows users to
administrate such operations from the commandline.

Change-Id: I59eef2acdda60c7ec795d1bfe31e8e960b4478a1
Implements: bp/add-openstackclient-federation-crud
2014-10-08 21:12:38 -04:00
Dean Troyer
5b6c24fdb0 Update for cliff commandmanager >=1.6.1
Cliff 1.6.1 added  CommandManager.load_commands() so we can adopt it
rather than rolling our own.

Also, that second group is Greek, not Latin.  Jeez...

Change-Id: I4a63c22f37bcfd0ef5d83c2dbd08b58fda0db35c
2014-10-08 18:05:43 -05:00
Jenkins
d405b1b12d Merge "Fix issues with object related commands" 2014-10-08 22:18:50 +00:00
Jenkins
35b0bbd762 Merge "Implement CRUD operations for Mapping objects" 2014-10-08 22:17:56 +00:00
Steve Martinelli
111d43ad8f Update compute server messages for translation
Mark some of the messages from the server for translation

implements bp use_i18n

Change-Id: I503efcfb4ca3dec1c427b58ee4a85de9a241dacd
2014-10-08 15:05:22 -04:00
Marek Denis
30b0a41ce7 Implement CRUD operations for Mapping objects
Change-Id: I4b8f2e77e741cf74f50aba98ab975af7321b02c6
Implements: bp/add-openstackclient-federation-crud
2014-10-08 18:35:11 +02:00
Steve Martinelli
388bbbac2c Fix issues with object related commands
1) Can't create instance of swiftclient. Since we now create
an API instance, creating a swiftclient instance won't work.
Trying to do any object related command fails.

2) Listing objects in a container fails, we depend on the
data returned in a specific way, during the API transition
this must have slipped through.

Needs regression/funcitonal tests to mame sure this doesn't
happen again.

Change-Id: I69079a0dc9f32b84e6f9307729d3dbbba549ac5e
2014-10-06 20:04:19 -04:00
Steve Martinelli
0cb204e59b Update gitignore
add .project and .pydevproject to gitignore

Change-Id: Ic258ded80612d31bd3017fce65000b619026e844
2014-10-03 19:35:13 -04:00
Jenkins
5c8b43e891 Merge "Remove duplicate env function in shell.py" 2014-10-03 22:38:14 +00:00
Jenkins
af04ff5ba3 Merge "Create a whole slew of functional tests for identity" 2014-10-03 22:38:08 +00:00
Jenkins
89a58c65ca Merge "Add functional tests to osc" 2014-10-03 22:38:01 +00:00
Jenkins
86d258f658 Merge "Add some code-blocks to the docs" 2014-10-03 22:36:19 +00:00
Steve Martinelli
89bb5b0b85 Add some code-blocks to the docs
Add some basic highlighting for the docs

Change-Id: Ifa740856f3ef636bdf0f60f3b7d082c68062fe9b
2014-10-03 00:25:56 -04:00
Steve Martinelli
1934b1b243 Place the command to generate docs on one line
Change-Id: I99d78208c940bc6646327ee967e71187c32a159f
2014-10-03 00:09:59 -04:00
Steve Martinelli
693687e4ff Remove duplicate env function in shell.py
There already exists an env() function in utils. Let's use that
one since it's common.

Change-Id: I661984394cf0c0543b2f35bf76e3929dead54d1d
2014-10-02 23:09:34 -04:00
Steve Martinelli
d972b8364c Pass in domain and project as positional args, not kwargs
The signature for users.set in keystoneclient dictates that
domain and project be sent in, not domainId and projectId,
which are being incorrectly sent in as 'extra' data.

Closes-Bug: #1376833

Change-Id: I44df3e492f61eab2241f3758dee622417bb6f399
2014-10-02 14:32:12 -04:00
Steve Martinelli
3842960f71 Create a whole slew of functional tests for identity
Complete the remaining identity v2 and v3 functional tests

Change-Id: I193fd95e58a38caeb66d37c17cde75b983c48ca0
2014-10-01 21:33:43 -04:00
Steve Martinelli
742982af4b Add functional tests to osc
Create a script that kicks off function tests that exercise
openstackclient commands against a cloud.

If no keystone/openstack process is detected, a devstack instance
is spun up and the tests are run against that.

There is also a hook added to tox.ini so that we can run these
tests easily from a gate job.

Change-Id: I3cc8b2b800de7ca74af506d2c7e8ee481fa985f0
2014-10-01 19:46:07 -04:00
Dean Troyer
31018bf7c2 Move object-store commands to low-level API
api.object_store.APIv1 now contains the formerly top-level functions
implementing the object-store REST client. This replaces the old-style
ObjectClientv1 that is no longer necessary.

Change-Id: I7d8fea326b214481e7d6b24119bd41777c6aa968
2014-10-01 13:50:13 -04:00
Dean Troyer
e3b9b96588 Add low-level API base class
Adds the foundation of a low-level REST API client.  This is the final prep
stage in the conversion of the object-store commands from the old restapi
interface to the keystoneclient.session-based API.

* api.api.BaseAPI holds the common operations

Change-Id: I8fba980e3eb2d787344f766507a9d0dae49dcadf
2014-09-29 12:32:45 -05:00
Dean Troyer
207c8cf3ef Test top-to-bottom: object-store containers
Replicate the object-store container command tests but use requests_mock
to test the entire stack down to the requests module.

These will be useful regressions tests when the existing object-store lib
modules are moved to the low-level API object.

Change-Id: Ibf25be46156eb1009f1b66f02f2073d3913b846d
2014-09-29 00:02:32 -05:00
Jenkins
02320a5a24 Merge "Updated from global requirements" 2014-09-28 07:42:34 +00:00
Jenkins
48bb39f299 Merge "utils.find_resource does not catch right exception" 2014-09-28 07:39:19 +00:00
OpenStack Proposal Bot
3ddd4e2646 Updated from global requirements
Change-Id: I2a8250d0b01651563cfe74704ce5a9f97dd9fdf4
2014-09-25 19:08:05 +00:00
wanghong
7029cf37e2 utils.find_resource does not catch right exception
Currently, utils.find_resource catch NotFound exception defined in
openstackclient. However, different client libraries raise different
exceptions defined in thire own library.

Change-Id: Idc40428e30e59f71dbdbfa0555c0066fddc441c2
Closes-Bug: #1371924
2014-09-24 11:04:41 +08:00
Steve Martinelli
1212ddb431 Remove unused reference to keyring
There's a unnecessary reference that is not being used.

Change-Id: I5ac85d2331385e4a31970b63fd17e650f82046ca
2014-09-23 16:43:31 -04:00
wanghong
2d1225624c v3 credential set always needs --user option
Change-Id: Ieca76bb6ee2f328f4e33010623c25eb9c18e6952
Closes-Bug: #1372744
2014-09-23 14:52:44 +08:00
Oleksii Chuprykov
ffe976ce3e Use oslo.utils
Module `importutils` from common code was graduated to oslo.utils,
so it would be great if we reuse this library.
Remove unused strutils.py and gettextutils.py

Change-Id: Iaae19fc5018d83103e5f15ff76d6da686bfdf5f8
2014-09-22 13:07:31 +03:00
Jenkins
ceae0bed42 Merge "Fixing typo and improving docstring of find_domain" 2014-09-22 07:01:33 +00:00
Steve Martinelli
c8b3f23733 Change help text for image save command
Change-Id: Ib2aecb68ffa06f9ac831131944c98c49cf99c75a
Closes-Bug: #1372070
2014-09-21 12:02:11 -04:00
Victor Silva
bfff44fc17 Fixing typo and improving docstring of find_domain
This should make it easier to understand the
purpose of find_domain - I believe the reason
for which find_resource wasn't enough was not
quite clear.

Change-Id: I6a1cdfa86f52401d95c6da2cd38d7c95a140b4a1
2014-09-19 19:51:01 +00:00
OpenStack Proposal Bot
2a2c8eec26 Updated from global requirements
Change-Id: I744a629cf685760ad96d60654d081fc495024ea8
2014-09-19 08:51:38 +00:00
Jenkins
d3bee31a9d Merge "Acknowlege git.o.o as OpenStack's git server" 2014-09-19 04:31:22 +00:00
Jenkins
0ee7073170 Merge "Add service catalog commands" 2014-09-19 02:42:55 +00:00
Anita Kuno
92add18e31 Acknowlege git.o.o as OpenStack's git server
OpenStack's cannonical git server is at git.o.o this patch
updates the index.rst to reflect that.

Change-Id: I54eeea7fab2e0f64ca9f23f7c328e2ff19721a41
2014-09-18 17:06:29 -04:00
Dean Troyer
da45b34828 Add service catalog commands
'catalog list' and 'catalog show' for Identity v2

Identity v2 only so far.

Change-Id: I9df0dac3d5bb7c18f38a81bd7d29f8119462d3a5
2014-09-18 15:42:10 -05:00
Jenkins
873ece1cf7 Merge "Return current user/project for user/project show commands" 2014-09-18 09:44:48 +00:00
Jenkins
df69d3264f Merge "Add network extension list" 2014-09-18 09:41:51 +00:00
Jenkins
2306059c8e Merge "Multiple args for object and container commands" 2014-09-18 08:17:14 +00:00
Jenkins
8d37e66cb2 Merge "Add support for 'file' format objects" 2014-09-18 07:26:45 +00:00
Jenkins
cf2eb3c938 Merge "Add preliminary save container support" 2014-09-18 07:26:38 +00:00
Jenkins
0ad4c94b6c Merge "Add preliminary support for downloading objects" 2014-09-18 07:26:27 +00:00
Jenkins
ccc2fbd958 Merge "Work toward Python 3.4 support and testing" 2014-09-17 22:34:47 +00:00
Jenkins
d9a6f7fd3a Merge "Use Keystone client session.Session" 2014-09-17 07:25:28 +00:00
Dean Troyer
845de41635 Return current user/project for user/project show commands
If non-admin user attempts 'project show' or 'user show' on the currently
authenticated project or user return the information that is already in the
service catalog rather than throwing a Forbidden error.

Change-Id: Ieeb6eacf71a471e410fbd3c09e7871740547e890
2014-09-14 22:53:35 -05:00
Steve Martinelli
09a546891f Add support for 'file' format objects
Some objects can be saved as 'dirname/filename' which causes the
existing support to fail. The correct behaviour should be to
create the directories needed.

Change-Id: I71c61bc3b0f76a3e6d2703bd45508f9d6483546e
2014-09-15 01:58:00 +00:00
Steve Martinelli
505c784bad Add preliminary save container support
Save all objects from a container

implements bp: swift-client

Change-Id: I7f2437236574e212033e63d768929d813289ed05
2014-09-15 01:57:54 +00:00
Steve Martinelli
e47787e12f Add preliminary support for downloading objects
Added command and library to download a single object from swift

Change-Id: I3dc47b414ff37b526e6f633aa83ac3aa4b5be0ae
implements: bp swift-client
2014-09-15 01:57:50 +00:00
Jenkins
0ff189720e Merge "Stop using intersphinx" 2014-09-14 18:29:00 +00:00
Andreas Jaeger
c5df1826a6 Stop using intersphinx
Remove intersphinx from the docs build as it triggers network calls that
occasionally fail, and we don't really use intersphinx (links other
sphinx documents out on the internet)

This also removes the requirement for internet access during docs build.

This can cause docs jobs to fail if the project errors out on
warnings.

Change-Id: I71e941e2a639641a662a163c682eb86d51de42fb
Related-Bug: #1368910
2014-09-13 09:46:09 +02:00
OpenStack Proposal Bot
9ecc592656 Updated from global requirements
Change-Id: I9bfbb802c5ec9be048ccecda8286b33fdfc6ef8c
2014-09-11 17:20:35 +00:00
Jenkins
696c9676bc Merge "Update docs and release notes for 0.4.1 release" 2014-09-09 04:01:38 +00:00
Jenkins
6977ef8aec Merge "Network use enable/disable vs admin state up/down" 2014-09-08 17:29:37 +00:00
Dean Troyer
f7357b7fe7 Update docs and release notes for 0.4.1 release
Closes-Bug: 1365505
Change-Id: I027d263ba9980715454b034a37733c5ff23fd169
2014-09-08 11:36:33 -05:00
Dean Troyer
ae957b176e Use Keystone client session.Session
This replaces the restapi requests wrapper with the one from Keystone client so
we can take advantage of the auth plugins.

As a first step only the v2 and v3 token and password plugins are supported.
This maintainis no changes to the command options or environment variables.

The next steps will include reworking the other API client interfaces to
fully utilize the single auth session.

Blueprint: ksc-session-auth
Change-Id: I47ec63291e4c3cf36c8061299a4764f60b36ab89
2014-09-08 00:06:52 -05:00
Jenkins
3317e0abf6 Merge "Add action 'user password set' for identiy v3" 2014-09-07 15:12:18 +00:00
Jenkins
dcf658cc4e Merge "Unordered dicts and lists causes variable results" 2014-09-07 12:59:35 +00:00
Jenkins
9b3c84e9e1 Merge "Leverage openstack.common.importutils for import_class" 2014-09-07 10:51:43 +00:00
Mouad Benchchaoui
0069adef5c Add action 'user password set' for identiy v3
This new action will allow a user to change their own password by
either providing the new password as an argument (--password) or by
being prompted to enter the new password.
In both cases user will be prompted to enter their current password
as required by the v3 API.

Closes-Bug: #1337245
Change-Id: I5e1e0fd2b46a4502318da57f7cce2b236fb2d93d
2014-09-07 02:37:54 -04:00
Jenkins
0bc4377b0a Merge "Sync with oslo-incubator and add importutils" 2014-09-07 05:34:07 +00:00
Jenkins
d3502b62d6 Merge "assertEquals order wrong" 2014-09-07 05:14:07 +00:00
Terry Howe
514ecc6e96 Unordered dicts and lists causes variable results
The unordered dict and lists causes variable results.  The user
may see different results and tests can fail.  Might as well make
this more consistent.

Change-Id: I7045b40b44cbf3ee0f2ca79c6ea0d279b6d8cfe3
2014-09-06 23:55:31 -04:00
Aaron Rosen
c43854048c Leverage openstack.common.importutils for import_class
This patch drops the import_utils method from common.utils and leverages
it from openstack.common.importutils instead.

Change-Id: If7e7383aa742afe44f750f916c0d90d747793150
Closes-bug: 1365273
2014-09-06 23:36:59 -04:00
Terry Howe
b725b5017a Multiple args for object and container commands
Have object and container create and delete handle multiple
arguments.

Change-Id: I389358c13ac2d99655ca26e784e3d299286c0af3
2014-09-06 16:23:55 -06:00
Jenkins
dc9ce6d608 Merge "Change app.restapi to app.client_manager.session" 2014-09-06 21:46:40 +00:00
Jenkins
b7816f3997 Merge "add service/interface/region filter for endpoint v3" 2014-09-06 17:02:45 +00:00
Jenkins
34c8bdaf35 Merge "Fix security group list for non-admin" 2014-09-06 17:02:42 +00:00
Jenkins
8cfc8529be Merge "Fix server add security group" 2014-09-06 16:09:30 +00:00
Aaron Rosen
b1663c96e6 Sync with oslo-incubator and add importutils
From oslo-incubator commit:
    c4bfdb94c25b4488da61d77184d97f8784f21a11

Change-Id: I81d1113d113faa609ab7713a0e04667b11786247
2014-09-06 10:21:22 -05:00
Jenkins
bdf9b19abb Merge "Make Identity client load like the others" 2014-09-06 13:26:40 +00:00
Terry Howe
dc68d3f5cf assertEquals order wrong
Change-Id: I822b6ac5b8e8c3009d1ee2d647376eff84559c11
Partial-Bug: #1277104
2014-09-04 14:47:28 +00:00
Jeremy Stanley
181166f81b Work toward Python 3.4 support and testing
Change-Id: I70d8cf0971d18b9b2eb967e28cedecc897721f58
2014-09-03 19:05:47 +00:00
Dean Troyer
1ab38679b6 Make Identity client load like the others
This does a couple of things:
* Loads the Identity client module in the same manner as the other
  'base' clients (where 'base' == 'included in the OSC repo')
* Changes the entry point group name for the base clients to
  'openstack.cli.base'.  The extension group name remains the same.
* Loads the base modules first followed by the extension modules.
  This load order ensures that the extension module commands are all
  loaded _after_ the base commands, allowing extensions to now override
  the base commands.

Change-Id: I4b9ca7f1df6eb8bbe8e3f663f3065c2ed80ce20b
2014-08-28 08:29:32 -05:00
Dean Troyer
22c544a822 Fix server add security group
The group resource was being passed when only the name is needed.

Change-Id: Ia303804be4e336f9880205d931467cb831e812de
2014-08-27 17:35:30 -05:00
Dean Troyer
e19216e282 Fix security group list for non-admin
Non-admin users couldn't list security groups due to the project lookup
failure.  That shouldn't stop the listing.

Change-Id: I27f6ff4975b35d1de1c852c8d4e830b83c7dec75
2014-08-27 17:19:53 -05:00
Dean Troyer
4bbd03210f Change app.restapi to app.client_manager.session
This is step 1 toward using Keystone client's session.Session as the
primary session/requests interface in OSC.

* Move the session create into ClientManager and rename 'restapi' attribute to 'session'
* Set up ClientManager and session loggers
* Fix container and object command references to restapi/api

Change-Id: I013d81520b336c7a6422cd22c05d1d65655e64f8
2014-08-25 13:38:03 -05:00
Jenkins
1eb7aba2c9 Merge "Add i18n module to openstackclient" 2014-08-24 22:40:38 +00:00
Jenkins
97d1bbdafd Merge "Create message variables for exceptions" 2014-08-24 20:20:08 +00:00
Jenkins
75245d9553 Merge "Add oslo.i18n as a dependency" 2014-08-24 20:11:59 +00:00
Steve Martinelli
258798c7a6 Add i18n module to openstackclient
Based on the information available at:
http://docs.openstack.org/developer/oslo.i18n/usage.html

implements bp i18n

Change-Id: Ie44f95dcbf192736991f88d92773f0dc2e20fa64
2014-08-24 18:16:15 +00:00
Steve Martinelli
c2b0cec6e3 Create message variables for exceptions
Instead of inline messages, let's create variables instead, as
it's easier to find strings, and mark them for translation.

Change-Id: Ibbcfdbc59d12a0cb4af50f73043d3ff7f3c76f99
2014-08-24 18:16:07 +00:00
Steve Martinelli
eb6b3027e6 Add oslo.i18n as a dependency
Add i18n in requirements.txt

implements bp add_i18n

Change-Id: I84ecd16696593414739c52ee344b8a1c9868941a
2014-08-24 13:13:31 -05:00
Jenkins
7a8c9a7a8a Merge "add tests for identity v3 endpoint" 2014-08-23 16:42:08 +00:00
OpenStack Proposal Bot
7f8791ad48 Updated from global requirements
Change-Id: I067f2ff0c78547088500fa2831c1c5abb75864bc
2014-08-22 12:34:21 +00:00
Jenkins
fc44578f0a Merge "add tests for identity v3 domain" 2014-08-22 10:57:36 +00:00
Terry Howe
cecf1a7737 Network use enable/disable vs admin state up/down
Use --enable and --disable vs --admin-state-up/--admin-state-down

Change-Id: I90040b925cb537a8ba13d1dd609c51bb669cf149
2014-08-18 05:41:58 -06:00
wanghong
181f16da8a add service/interface/region filter for endpoint v3
Change-Id: I7eac5b2ff5f5a6f3f08b22dd3a48a5ae7e2c056b
Closes-Bug: #1281888
2014-08-18 16:41:15 +08:00
wanghong
99ad9ef92e add tests for identity v3 endpoint
Change-Id: I1479460473656ea4e2a48a976808371e840b49c1
Closes-Bug: #1348867
2014-08-14 20:17:54 +08:00
wanghong
2dc060cff3 add tests for identity v3 domain
Change-Id: I478215f62b51e6e73283f0304ea1b0736177d1b1
2014-08-14 20:11:00 +08:00
wanghong
19b8605224 a mistake in tests/identity/v3/test_role.py
Change test_service_show to test_role_show.

Change-Id: Ieef7fdeb9401b4dc28720c9ba14bf460ac171288
2014-08-12 19:36:57 +08:00
Jenkins
f0b077eb70 Merge "Add commands for object upload and delete" 2014-08-12 06:43:17 +00:00
Jenkins
0cfd0b1da7 Merge "Updated from global requirements" 2014-08-09 00:34:58 +00:00
Steve Martinelli
8af26a51c3 Add commands for object upload and delete
Add commands to upload an object to a container, and to delete
an object from a container.

Change-Id: I37c02315495bba5abe612733d1109a3d4ce256a1
implements: bp swift-client
2014-08-08 18:33:20 -04:00
Jenkins
fed6921336 Merge "test_find_resource fails if run alone" 2014-08-07 22:07:56 +00:00
Jenkins
c7176c16a9 Merge "Add container create and delete support" 2014-08-07 20:41:57 +00:00
Jenkins
b3b59c20d2 Merge "user create v2.0 depends on tenantId in response" 2014-08-07 20:26:07 +00:00
Jenkins
043572bc3f Merge "v3 endpoint set shouldn't always need service option" 2014-08-07 20:25:26 +00:00
wanghong
ddb7e18974 test_find_resource fails if run alone
Currently, we set 'NAME_ATTR' attribute for Volume and Snapshot
class in volume.client.py. When we test test_find_resource alone,
the Volume and Snapshot class do not have 'NAME_ATTR' attribute since
we do not import volume.client, which causes the tests to fail.

Change-Id: I06f727ffa8d37afe1a1191c36574887fecc7a733
Closes-Bug: #1353788
2014-08-07 13:22:25 -04:00
Steve Martinelli
b5001e4b21 Use oslosphinx to generate documentation
Rather than host different and possibly out of date versions of
static and theme files, use oslosphinx to generate the docs.

Change-Id: I7eadc8e40aa10cc26cfd6aece6efa5d13fee70b0
2014-08-05 01:31:20 -04:00
Steve Martinelli
e2ebeb7fdc user create v2.0 depends on tenantId in response
User create for v2.0 no longer always contains a tenantId in the
response. Add a guard to check for tenantId first before pop'ing it.

Change-Id: I428dbc26520bb86efad33768ce04f584217ad168
Closes-Bug: #1352119
2014-08-04 00:04:13 -04:00
OpenStack Proposal Bot
40013f3c02 Updated from global requirements
Change-Id: If62daf2539ff69323c905c12c19e041f83ef8eb2
2014-08-04 03:28:17 +00:00
wanghong
a9fb5fa102 v3 endpoint set shouldn't always need service option
Change-Id: I71aab1ee4f467dc963e7afa7fc1c82b4255ea822
Closes-Bug: #1351121
2014-08-04 02:00:21 +00:00
Steve Martinelli
be83ae763f Add container create and delete support
Add basic container create and delete support to OSC.

Change-Id: Ia104db9d7e580d33097ea33a5690998f817995d1
implements: bp swift-client
2014-08-03 03:52:04 -04:00
Steve Martinelli
75e8490e54 Cleanup README.rst
There are two harmless typos in the README.rst
'OpenStackclient' => 'OpenStack Client'
'python-*client' => the '*' is being interpreted as a link

Change-Id: Ie813e220c3c150f46edb2c93f94e8bb78bdb0013
Closes-Bug: #1350518
2014-07-31 00:53:36 -04:00
wanghong
81d11799c6 fix typo in identity/v3/endpoint.py
Change-Id: Idf57a6a988f5c0f20f3b0b19ab896642ce10d70b
2014-07-29 15:37:24 +08:00
Jenkins
02cdebb007 Merge "More make_client() logging cleanup" 2014-07-26 22:20:21 +00:00
Jenkins
7b70143695 Merge "Add more columns to image list output" 2014-07-26 22:20:19 +00:00
Terry Howe
25e0d2ab27 Add network extension list
Network extension list support

Change-Id: I013f68ef2c3329c8db59e2441dd8d4ffafd4470e
Closes-Bug: #1337685
2014-07-26 15:57:48 -06:00
Dean Troyer
b96d9d374c More make_client() logging cleanup
Change-Id: I5af4b9c52c69d6e31e6ca5f90d5880c097880a71
2014-07-26 12:22:50 -06:00
Jenkins
01f7a5f9f5 Merge "Change V2 image tests to actually run V2 image code" 2014-07-25 22:49:26 +00:00
Steve Martinelli
6e1fa8b27d Change V2 image tests to actually run V2 image code
The current tests for image do not run v2 image code, changing
that portion also made it's only test fail.
I opted to change the image delete code and not the test, since
passing the object ID is more in line with the rest of the
project code.

Change-Id: I62e13c063a5d68279dbbf31e59266db6285d73bf
2014-07-25 01:16:01 -04:00
Steve Martinelli
e1c32b8224 Add more columns to image list output
Add disk_format, container_format, size and status to image list
command. Added tests as well.

Change-Id: I8e3822c6d46d0020fc706955c026549f6c635587
Closes-Bug: #1348475
2014-07-25 01:09:59 -04:00
Jenkins
e0cf68f995 Merge "Normalize more help strings" 2014-07-24 22:09:28 +00:00
Dean Troyer
5bb6c72ef7 Normalize more help strings
Change-Id: I2b21bc904e35c1cc50da369d148e607fe3e8cf90
2014-07-24 11:22:29 -05:00
Jenkins
8c556e6943 Merge "Change object API_NAME to 'object_store'" 2014-07-24 03:55:49 +00:00
Dean Troyer
f3dbab4a6c Fix PEP8 E302 errors
Also add remaining skipped checks to HACKING

Change-Id: I0c4333ce29597e0a8a233af17c15bed2b4d0711f
2014-07-22 17:51:15 -06:00
Jenkins
4d3d287dd7 Merge "Fix IDP commands" 2014-07-22 07:21:27 +00:00
Jamie Lennox
5e7e94d59e Fix IDP commands
identity_client.identity_providers doesn't exist as a manager. These are
located at identity_client.federation.identity_providers. Fix the
routes.

Also fix passing id to .create() as a positional argument. This is not
allowed from keystoneclient it should be passed as a keyword argument.

Change-Id: I912c27fcee58b0723e27e9147def2cbd1c62c288
2014-07-21 10:04:47 +10:00
Steve Martinelli
fc044c8847 Update help text for some network commands
Add help text for network delete, network set and network show

Change-Id: I80ad5eae35f0eba2bfe19e06786c9b8ed1522046
Closes-Bug: #1343659
2014-07-17 19:20:53 -04:00
Steve Martinelli
498ddf95c6 Change object API_NAME to 'object_store'
Previously the API_NAME was 'object-store' which caused all sorts
of failures when running swift commands

Change-Id: I448ca10f7d173024313722246e63cf23fd71117c
Closes-Bug: #1343658
2014-07-17 19:17:07 -04:00
Cyril Roelandt
3cfb97e5ae Add Python 3 support
Change-Id: I65fabfc4788230b7280808ec912601c327095db0
2014-07-15 10:26:16 +02:00
Jenkins
5830007bbc Merge "Fix server resize" 2014-07-12 20:58:37 +00:00
Jenkins
bc6495c6a1 Merge "Add basic timing support" 2014-07-11 18:22:06 +00:00
Jenkins
70283744a0 Merge "Domain administrator cannot do project operations" 2014-07-09 08:18:23 +00:00
Jenkins
e8f058775e Merge "Add support to list volume extensions" 2014-07-09 06:59:39 +00:00
Jenkins
e7bfabc886 Merge "Allow network find to use alternate name" 2014-07-08 17:42:11 +00:00
Jenkins
ba15646cf8 Merge "Catch SystemExit for parse args" 2014-07-08 17:37:21 +00:00
Dean Troyer
ea2ac77a46 Fix server resize
So apparently we've never resized a server???

Fixed command args and add some tests.

Change-Id: I6c3f6fec22390e9d269b7117a42a190d2b4b80ba
2014-07-08 11:20:13 -05:00
Jenkins
69138c7912 Merge "Clean up make_client() logging" 2014-07-08 15:48:28 +00:00
Jenkins
ab5416a385 Merge "Add support to list compute extensions" 2014-07-08 15:41:37 +00:00
Dean Troyer
4844a25779 Add basic timing support
Add support for --timing options.  Use cliff via a pseudo-command
'Timing' to support multiple outputformats.

If an output format other than the default 'table' is selected
use CSV since the timing data is in list form.

Will pick up timing data for any client object that has a method
similar to novaclient's get_timings().

TODO:
* Stop instantiating all of the clientmanager client objects just
  to check for timing data.  Descriptor magic required?

Change-Id: I7f1076b7a250fba6a8b24b2ae9353a7f51b792b2
2014-07-08 02:04:00 -05:00
Dean Troyer
21bd4619ae Clean up make_client() logging
Change-Id: I0b6760a6401b50e3dfb891af75424ae89df42ebc
2014-07-08 01:44:55 -05:00
Jenkins
6575581f79 Merge "Python 3: remove a useless code to safe_encode()" 2014-07-08 01:01:01 +00:00
Jenkins
25cd4dbb54 Merge "Python 3: do not compare a list to a zip object" 2014-07-07 23:53:24 +00:00
Jenkins
ea938e8ddf Merge "Move network stuff to v2 instead of v2_0" 2014-07-07 22:53:12 +00:00
Terry Howe
b638488697 Domain administrator cannot do project operations
Domain administrator cannot do project operations because the
require access to the domain API (which they don't have).  When
attempting to find a domain for project operations, ignore errors
because the API returns nothing without indicating there is a
problem.  The domain administrators will have to use a domain id,
but they will still be able to do project operations.  If the user
does not have permission to read the domain table, they cannot
use domain names.

Change-Id: Ieed5d420022a407c8296a0bb3569d9469c89d752
Closes-Bug: #1317478
Closes-Bug: #1317485
2014-07-07 20:18:39 +00:00
Christian Berendt
dad5b10510 Replaced some UTF-8 characters with ASCII characters
Change-Id: Ic4e53b742f8691dd2dafe1a8d7fa45e4340a3c94
2014-07-07 19:52:48 +02:00
Terry Howe
fba951568c Python 3: do not compare a list to a zip object
In Python 3, zip() returns a zip object, not a list.

Change-Id: I1a472bec3e12b5ae3c3555cf690b99a57579ce83
2014-07-07 09:11:57 -06:00
Terry Howe
a065dd09e4 Allow network find to use alternate name
Add the name_attr to the network find method so it can search
for things like floating_ip_address for floating IP addresses
rather than just id.

Change-Id: I827e3745b06397a54555d1286e477bf2e05bf789
2014-07-07 06:11:58 -06:00
Terry Howe
b157dc937e Move network stuff to v2 instead of v2_0
Rename network stuff v2

Change-Id: Ia9b8feda20dfd35b0f3712b8e2419d0bf5da0acd
2014-07-07 06:08:02 -06:00
Terry Howe
79488377eb Catch SystemExit for parse args
If you have a test with parse args it fails with no error
messages.  This change throws an exception.

Change-Id: I545aba346620a352fe570d394dbd4d6bd2daa995
2014-07-06 10:02:51 -06:00
Jenkins
b3736fd9df Merge "Remove keyring support from openstackclient" 2014-07-04 19:45:30 +00:00
Steve Martinelli
9b2e264ada Add support to list volume extensions
Since cinderclient has support to list extensions, we should add
some of the logic to our list extensions command.

Change-Id: I7dc7ca325ea9b82194bba6d875e7b8dc1884d77e
Closes-Bug: #1337687
2014-07-04 14:27:16 -04:00
Cyril Roelandt
1fedd38de6 Python 3: remove a useless code to safe_encode()
The safe_encode method returns bytes, so we cannot concatenate its output with
text strings. This call does not seem needed after all, so let's just remove
it.

Change-Id: I6c18427559147d4c732ff7daa6d6006e7e5f6365
2014-07-04 10:25:53 +02:00
Steve Martinelli
270c7fe967 Add support to list compute extensions
Since novaclient has support to list extensions, we should add
some of the logic to our list extensions command.

Closes-Bug: #1337684
Change-Id: I3074225780142df265a34add03e60c0f7c64c711
2014-07-03 23:53:57 -04:00
Alex Gaynor
b8f534df01 Remove keyring support from openstackclient
* The encryption it purports to offer is completely insecure.
* It also appears to be broken.

Closes-Bug: #1319381
Change-Id: Id15ecfbbfd15f142b14c125bfd85afd5032699ac
2014-07-04 01:56:18 +00:00
Jenkins
7f59fa5943 Merge "trust authentication" 2014-07-04 00:44:51 +00:00
Jenkins
e43c0f2b9b Merge "Python 3: do not use __builtin__" 2014-07-03 17:13:53 +00:00
Matthieu Huin
5672c688d1 trust authentication
This patch enables authenticating by using a trust. The trust ID
must be set with the parameter --os-trust-id or the env variable
OS_TRUST_ID. Trusts are available for the identity v3 API.

Co-Authored-By: Florent Flament <florent.flament@cloudwatt.com>
Change-Id: Iacc389b203bbadda53ca31a7f5a9b8b6e1a1f522
2014-07-03 10:12:02 +02:00
Cyril Roelandt
169587ddbd Python 3: do not use __builtin__
Use six.moves.builtins instead, this works with both Python 2 and 3.

Change-Id: I57e7257d4f06c805f26383e0778ad104d50ea139
2014-07-03 00:27:35 +02:00
Jenkins
8e12949958 Merge "Remove backslash usage from a few tests" 2014-07-02 21:22:11 +00:00
OpenStack Proposal Bot
0ab1791439 Updated from global requirements
Change-Id: I7f7714625a6cfb6bd8e0d313d27e898e178a1efb
2014-07-02 15:47:14 +00:00
Steve Martinelli
3bdfef827c Remove backslash usage from a few tests
Noticed these in the code, figured we should stick to not using
backslashes if possible.

Change-Id: I55e5402683141e14df7c2b38883b1f3cc2a6bb6a
2014-07-02 00:00:33 -04:00
Jenkins
ddf0c16a10 Merge "Fix PEP8 E126 and E202 errors" 2014-06-27 21:41:34 +00:00
Jenkins
58583b55ca Merge "Fix PEP8 E265 errors" 2014-06-27 21:41:33 +00:00
Jenkins
63b1c06024 Merge "Fix PEP8 H405 errors" 2014-06-27 21:41:31 +00:00
Jenkins
42765a15f3 Merge "Sort/clean setup.cfg" 2014-06-27 17:48:27 +00:00
Jenkins
4bebd8ac12 Merge "Rename token classes to match command" 2014-06-27 17:48:25 +00:00
Dean Troyer
1d2cd677cf Sort/clean setup.cfg
Change-Id: I68a1073d7ef4e6610233961c4aba8c4378ee584b
2014-06-27 09:14:58 -05:00
Dean Troyer
1fca946890 Rename token classes to match command
The token create/delete commands were renamed but not the class names.
Rename them to match.

Change-Id: Icbf9c0a954ed0332fa4c99e4ee2612bb11f89e3a
2014-06-27 09:14:58 -05:00
Dean Troyer
4914a8d107 Fix PEP8 E126 and E202 errors
Do both as they are all in the same set of files that required
major re-formatting.

Change-Id: I6e8a8ce19a55105124a33c0e2487fc4b4e06d252
2014-06-27 09:12:55 -05:00
Dean Troyer
11f3654f6e Fix PEP8 E265 errors
Change-Id: Ieb9a9af1da27d3935d1a4d3cfb61b0ccb03d099a
2014-06-27 09:12:55 -05:00
Dean Troyer
a78d75f290 Fix PEP8 H405 errors
Change-Id: Id9ea03e7d88148f84bffe1b18b5b4315e6123012
2014-06-27 09:12:38 -05:00
Alex Gaynor
86e0cf70cf Fixed typos in the identity client
Change-Id: I76042110f5a008d4c097862a572448448f92a504
2014-06-26 23:05:30 -07:00
Terry Howe
8f59524c3e Network CRUD
bp/neutron
https://wiki.openstack.org/wiki/OpenStackClient/Commands#Network_2

Change-Id: I89ee083154afa544b03587e84becace36d9d522a
2014-06-24 15:00:25 -06:00
Jenkins
adf9349c40 Merge "sync oslo bits" 2014-06-23 16:02:09 +00:00
OpenStack Proposal Bot
eeebd0db8c Updated from global requirements
Change-Id: Ia54da66d13b2667375a8a85c97ced25fd97b6b25
2014-06-23 05:34:50 +00:00
Steve Martinelli
a368983705 sync oslo bits
update gettextutils.py, strutils.py, install_venv_common.py
remove iniparsers.py

oslo-incubator commit 1223cf

Change-Id: I23923d580f57ab6c12622f10d9f278c44c863feb
2014-06-20 16:18:33 -04:00
Jenkins
a732bfae49 Merge "Update docs and release notes for 0.4.0" 2014-06-20 20:05:58 +00:00
Dean Troyer
3fa5fa5ba7 Update docs and release notes for 0.4.0
Change-Id: Iad6cfe5dee63adb9e60a0ea9811217b3175eb99c
2014-06-20 12:15:52 -05:00
Jenkins
23f64a469a Merge "Complete Identity v3 list command filters" 2014-06-20 15:46:39 +00:00
OpenStack Proposal Bot
3019f11032 Updated from global requirements
Change-Id: I708fe9d2f10e53d61e67130ff41b0f92cddef64d
2014-06-20 03:38:56 +00:00
Dean Troyer
9dd3a5326c Complete Identity v3 list command filters
Complete the 'group list' and 'user list' filter options following
the refactor in https://review.openstack.org/69878

Change-Id: Ib4af417c56d4f7da4b88852f191af615cc7fa2ec
2014-06-19 13:00:02 -05:00
Jenkins
c6cc1d72d5 Merge "Refactor role list subcommand for identity v3 api" 2014-06-19 17:14:03 +00:00
Jenkins
0a491b2ac8 Merge "Change the token verb to issue/revoke" 2014-06-18 22:44:24 +00:00
Terry Howe
25d6955bb4 Change the token verb to issue/revoke
Change the token verb to issue/revoke as documented in:

https://wiki.openstack.org/wiki/OpenStackClient/Commands#token
https://wiki.openstack.org/wiki/OpenStackClient/Commands#Actions

Change-Id: I44f77f98ad3269c4f2149301c204804dcb75ac81
2014-06-18 14:58:04 -06:00
Jenkins
982b418da7 Merge "Update docs template" 2014-06-18 15:40:04 +00:00
Jenkins
ddcc668393 Merge "Add a docs job to tox.ini" 2014-06-18 15:38:49 +00:00
Jenkins
1f2189d6de Merge "Add token delete command for identity v2" 2014-06-18 15:37:40 +00:00
Steve Martinelli
deaff7274e Update docs template
To make things more consistent across all openstack projects, the
developer docs should be upgraded to the newer template used by
keystone and keystoneclient (and other projects).

I dropped in the necessary static files and themes, and updated
the config file to make the changes at build time.

Change-Id: I5a268cff3cd5af29ad712705d540b9d1d6667d56
Partial-Bug: #1331304
2014-06-18 03:47:37 +00:00
Steve Martinelli
89cbdd1ae1 Add a docs job to tox.ini
A noticed that there wasn't a docs option when running tox.
Thought it would be a good idea to add one.

Partial-Bug: #1331304
Change-Id: I5af9ff5d5986ad546146c0fa73eb98256fd00c5f
2014-06-18 03:41:42 +00:00
Terry Howe
0b2987fef3 Fix find_resource for keystone and cinder
The find_resource method had two hacks in in to support cinder
and keystone and I have removed those in favor of a monkey patch
for cinder.

The find_resource method used to attempt to UUID parse the id, but
it would do a manager.get anyway.  I changed it to skip the UUID
parsing.  This will make things run minorly faster and it supports
LDAP for keystone.

The find_resource used to attempt to use display_name=name_or_id
when finding.  This was a hack for cinder support, but it breaks
keystone because keystone totally messes up with the bogus filter
and keystone refuses to fix it.

Change-Id: I66e45a6341f704900f1d5321a0e70eac3d051665
Closes-Bug: #1306699
2014-06-17 10:24:26 -06:00
Dean Troyer
6380b8b959 Image create and set command updates and tests
Refactor image create and set commands to properly handle properties.
This is particularly tricky with exclusive booleans as in this case leaving
both choices off the command line should NOT assume a default value but
leave the existing value unchanged.

Properties were not being updated correctly in the 'image set' command.
Refactor it to use the same pattern as in other SetXxx commands.
Add tests for arg handling.

Change-Id: I123a64c9b4feecab25a3e2013cc047f55b1c9967
2014-06-16 23:30:46 -04:00
Jenkins
aba1fb2268 Merge "Refactor oauth1 code for updates" 2014-06-17 01:23:25 +00:00
Jenkins
fbb9e7aefa Merge "Clean up logging levels" 2014-06-16 21:32:31 +00:00
Jenkins
5c2d9f386b Merge "Updated from global requirements" 2014-06-15 00:17:45 +00:00
Steve Martinelli
d5aaba9d82 Refactor oauth1 code for updates
The keystoneclient code for oauth1 support has changed.
As such, we should remove the delete, list and authenticate
functions, since they are not in keystoneclient.

Also, we must now pass in the project id when creating a
request token. Additionally we must now pass in roles
when authorizing a request token.

Added functional tests to ensure output and input args
are the same.

bp add-oauth-support
Change-Id: I559c18a73ad95a0c8b7a6a95f463b78334186f61
2014-06-14 17:21:17 -04:00
Jenkins
0da5bfe428 Merge "Ignore most of the new hacking 0.9.2 rules" 2014-06-14 18:37:12 +00:00
Jenkins
99e7660d56 Merge "Add support for extension list" 2014-06-14 06:25:38 +00:00
OpenStack Proposal Bot
5805596013 Updated from global requirements
Change-Id: I44f13a22528824a8b24ffb3b0e3075e870e5ee58
2014-06-13 22:57:28 +00:00
Dean Troyer
67354f651b Clean up logging levels
The following logging levels are set according to the combination of
--verbose, --quiet and --debug options:

verbose_level   logging level       options
0               --quiet             ERROR
1               (none)              WARNING
2               --verbose           INFO
3+              --verbose --verbose DEBUG
                or --debug

Logging levels for the requests and iso8601 modules are forced to ERROR.

This is the first step in bp use-logging-not-print

The difference between '--debug' and '--verbose --verbose' is --debug triggers
cliff's exception handling and traceback display.

Change-Id: Ide2233b3316471d279260fb1e7255a6ca2072023
2014-06-13 17:15:17 -05:00
Dean Troyer
0059f045a9 Ignore most of the new hacking 0.9.2 rules
So we can update requriements.txt.  But fix a couple of easy ones:
* Fix E251 (1 occurrance)
* Fix E131 (1 occurrance)

Change-Id: I62aaa423aa6da9e9f0ca026ec586b51cc6a6df03
2014-06-13 17:06:28 -05:00
Jenkins
497a38903c Merge "Add role assignments list support to identity v3" 2014-06-13 20:56:27 +00:00
Qiu Yu
f78a3f1653 Refactor role list subcommand for identity v3 api
Currently parts of user list and group list command are actually
functioning as role listing, which is quite counter intuitive and
misleading.

This refactor change move role related logic to a single place of role
list command. It now allows role grants listing for user/group +
domain/project combinations.

If no user or group specified, it will list all roles in the system,
which is the default behaviour.

Change-Id: I4ced6df4b76f018d01000d28b4281ad9f252ffcc
2014-06-13 15:20:42 -05:00
Matt Fischer
4ae4dc35bd Add support for extension list
- Add support in the common section for extension list. This only
   supports Identity for now. Once the APIs for volume and compute
   are supported in the respective APIs, they will be added. Once
   network is added to this client, it will be added (the API already
   supports it).
 - Include extension fakes for volume and compute for pre-enablement.

Change-Id: Iebb0156a779887d2ab06488a2a27b70b56369376
Closes-Bug: #1319115
2014-06-11 13:40:30 -06:00
Jenkins
7f6a901d01 Merge "Add tests for identity endpoints" 2014-06-10 02:27:55 +00:00
Jenkins
3b925e9806 Merge "replace string format arguments with function parameters" 2014-06-10 02:27:54 +00:00
henriquetruta
58f80e4c75 Add role assignments list support to identity v3
The assignments manager and its test class were created.
Some fake stubs were also added on the fakes.py module.

The "openstack role assignment list" command was created.

Change-Id: Iae94f4fee608ea3e09ff38961ad22edc38efb89c
Implements: blueprint roles-assignment-list
Closes-Bug: 1246310
2014-05-30 15:55:24 -03:00
Jenkins
fb65652753 Merge "Fixed several typos throughout the codebase" 2014-05-28 23:05:54 +00:00
Jenkins
7ceff0eafc Merge "Fix server image create" 2014-05-28 22:05:53 +00:00
Terry Howe
d6321c0893 Add token delete command for identity v2
Identity v2 has undocumented support for token delete and
keystoneclient also has support.

Change-Id: Ib98d17958ceb88f7b63471691dee71fdb884ce2e
Closes-Bug: #1318442
2014-05-23 10:17:42 -06:00
Alex Gaynor
a8087a6c8b Fixed several typos throughout the codebase
Change-Id: I048ee857fc1215fea7f60978364894e1b5abdf66
2014-05-21 07:47:52 -07:00
Christian Berendt
3b485de6b0 replace string format arguments with function parameters
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.

Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
2014-05-20 13:49:56 +02:00
Matt Fischer
dc44ec1ddf Add tests for identity endpoints
Change-Id: If15cc74fafbbe52fa86aa353f2598aa31daf0695
Closes-Bug: #1319450
2014-05-15 12:20:30 -04:00
Dean Troyer
870e7ddbcc Change volume create --volume-type to --type
This makes it consistent with the other --type options in OSC.  Also
add a few more volume_create tests.

Change-Id: I50ef927932cabf157ecdfd6c4faa1914b4fdf413
2014-05-15 09:25:07 -05:00
Jenkins
a93851d6af Merge "Implement CRUD operations for Identity Providers" 2014-05-09 21:38:20 +00:00
Dean Troyer
da5e31dbb6 Fix server image create
The final find_resource() call errored because servers.create_image()
returns an image ID rather than an Image resource.  Reset expectations
and arguments.

Change-Id: I1b9132f66091f9df76198724156acb7a6fb2f6fe
2014-05-08 15:04:22 -05:00
Jenkins
03b9a7282b Merge "Fix help message for ip floating delete" 2014-05-07 16:40:41 +00:00
Yejia Xu
3b57117f8e Display all server log when --lines option is None
Without --lines option, `console log show xxx`
cmd will break.

Change-Id: I4027aacac245e6916c1808fd9f878fb708c8a5f0
Closes-Bug: #1316870
2014-05-07 05:15:22 +00:00
Yejia Xu
f7f8fe4e7c Fix help message for ip floating delete
Previously, the help message incorrectly had the
string "IP address to add to server". This should
probably read "IP address to delete".

Change-Id: If592b736448199f84c30e0cbc8110a0a76e2c140
Closes-Bug: #1316877
2014-05-07 05:13:41 +00:00
Jenkins
834867b8bf Merge "volume type create should display properties" 2014-05-06 06:27:28 +00:00
Terry Howe
37231b5801 volume type create should display properties
The volume type create command should properly output the
properties.  The code was doing a create on the volume type and
then setting the properties, but it was printing out the volume
object from the create.

Change-Id: I23c8a0182e77bb71903ad87c1b01ba2b62405f3b
Closes-Bug: #1303978
2014-05-05 14:21:50 -06:00
Yejia Xu
2cc3a2fdbd Skip auth in cinderclient
cinderclient can't work well with keystone v3 auth
info. We should do it in openstackclient just like
compute extension.

Closes-Bug: #1315963
Change-Id: I46f794c5315f6a9fe1d9a0e5dc7b84f067d7f792
2014-05-05 17:09:28 +00:00
OpenStack Proposal Bot
6c5f2e39e2 Updated from global requirements
Change-Id: Idde32a0bdcee8843c09a968dff69b246b5e784f7
2014-05-01 13:50:49 +00:00
Marek Denis
ef9496a4fc Implement CRUD operations for Identity Providers
Operations for:
    * adding Identity Provider
    * listing Identity Providers
    * showing Identity Provider
    * updating Identity Provider
    * deleting Identity Provider

Change-Id: I4557168309f93e4670116b5c3c0e29252ff0c40f
Implements: bp/add-openstackclient-federation-crud
2014-04-24 14:55:54 +02:00
Jenkins
c744abdbda Merge "Updated from global requirements" 2014-04-23 23:11:50 +00:00
Jenkins
2643df7405 Merge "Make endpoint commands more consistent" 2014-04-23 23:11:49 +00:00
Jenkins
845f6705bf Merge "Fix the project option to user list so it filters" 2014-04-23 23:11:48 +00:00
OpenStack Proposal Bot
dde02b8a38 Updated from global requirements
Change-Id: Ib4416938530bd1037cc4b7e84bf81475d91e6b16
2014-04-20 09:59:03 +00:00
Jenkins
8ec78a10f8 Merge "Pass arguments to v3 keystoneclient by kwarg" 2014-04-17 02:40:36 +00:00
Jenkins
3c3f212d8b Merge "Make bash comple command best effort to authorize" 2014-04-17 02:06:11 +00:00
Jenkins
398dc6c0bd Merge "In anticipation of network agents, rename compute" 2014-04-17 02:04:18 +00:00
Steve Martinelli
01db6d977f move read_blob_file_contents to utils
Thinking ahead, a few other upcoming keystone features could
benefit from reading contents from a file. Thus, moving the
function from policy to utils.

Change-Id: I713ab0e5a00c949ad996daf83b775a7c19044888
2014-04-14 22:16:59 -05:00
Jamie Lennox
022b6d95d1 Pass arguments to v3 keystoneclient by kwarg
Keystoneclient has added the positional decorator which emits a warning
if arguments aren't passed by keyword. This means we are getting
warnings in certain places in openstackclient.

Change-Id: Ic5446cd6f122cbb56fce543011386d53bc31fe18
Closes-Bug: #1302199
2014-04-04 08:09:43 +10:00
Terry Howe
e72072adc3 Fix the project option to user list so it filters
The --project option to the user list command was not implemented
* Allow users to be filted by project
* Support id or name of project with the find_resource command
* Make sure the report does not contain duplicates

Change-Id: Ic0e10cccd7749d38a7d4b80bbdc68e61a660084b
Closes-Bug: #1177255
2014-04-01 09:03:45 -06:00
Terry Howe
bea6e6ac23 Make endpoint commands more consistent
Make endpoints more consistent across create, show, etc
* Make the name option required for create
* Use a common function to fetch services by id, name or type
* Have show work by endpoint id or by service id, type or name
* Have show display all the fields by default
* Remove capability to filter queries by attribute value pairs

Change-Id: Idaa4b8d930ba859fd62de777e44a10b1ed58c79b
Partial-Bug: #1184012
2014-03-28 12:33:58 -06:00
Jenkins
ee22070473 Merge "Correct display of project/tenant id on display of credentials" 2014-03-23 18:43:24 +00:00
Chris Johnson
8117256d7d Correct display of project/tenant id on display of credentials
This change corrects the display of ec2 credentails within the
ListEC2Creds method. Added explicit headers and corrected data listt o
specify tenant_id instead of project id.

Change-Id: I2ea579082bee800d774f202bdc38e2d546e57e77
Closes-Bug: #1292337
2014-03-21 11:22:22 -04:00
Terry Howe
4900c64d09 Produce a useful error message for NoUniqueMatch
Most of the CLIs use a NoUniqueMatch, so produce a useful
error message if that happens.  Added some tests for
find_resource as well.

Change-Id: I85ba61d5f6d1be5bd336a1cc4b02501492905f33
Closes-Bug: #1293846
2014-03-17 17:32:41 -06:00
Steven Hardy
0c0803d363 identity v3 allow project list filtering by domain
The underlying keystoneclient interface allows filtering by domain,
so support it in the cli interface because it makes project list
much nicer to use in a multi-domain deployment.

Change-Id: If3f5cf1205c1e9cf314f8286a3ae81bda4456b8f
Closes-Bug: #1289513
2014-03-13 09:32:21 +00:00
Jenkins
ce63fa0121 Merge "Add ability to set key value pairs in projects" 2014-03-13 06:33:24 +00:00
OpenStack Jenkins
65f094e738 Updated from global requirements
Change-Id: I73f40a5fd569d0a5e341aabbece1885a7478d7f5
2014-03-10 21:37:10 +00:00
Jenkins
cf8506d2bd Merge "Fix 'keypair show' command output" 2014-03-10 16:40:50 +00:00
Jenkins
46322387b6 Merge "Fixed spelling error, compatability to compatibility" 2014-03-08 03:50:55 +00:00
Jenkins
3293138121 Merge "Add --volume option to image create command" 2014-03-08 03:50:54 +00:00
Jenkins
b03680aea5 Merge "Fixed Spelling errors - compatability to compatibility" 2014-03-08 00:33:11 +00:00
Jenkins
b0c0b48fdc Merge "Fixed spelling errors - occurance to occurence" 2014-03-08 00:33:10 +00:00
Dean Troyer
27ebdeb57d Fix 'keypair show' command output
The attempt to get the data dict out of the keypair resource object uses a
key 'keypair. This is incorrect, no key is required.

Closes-Bug: 1289594
Change-Id: I7887119c1d800d389cb6f63ea7847bea1e25bb52
2014-03-07 15:34:31 -06:00
Dolph Mathews
3435f188a4 add interface and url to endpoint list
endpoint list is not terribly useful without these details

Change-Id: I65b0bdf7667d73ceaad5856171678cabcde003f3
2014-03-07 11:51:15 -07:00
Alex Holden
00188f092c Fixed spelling error, compatability to compatibility
Change-Id: I72c1254666a741ffe1070cf8275af889fa323f52
2014-03-07 09:40:29 -08:00
Alex Holden
97667079dc Fixed Spelling errors - compatability to compatibility
Change-Id: I9da380cef8b798e21fd35882763bd05f5cf1e33e
2014-03-07 09:39:02 -08:00
Alex Holden
14548aa69a Fixed spelling errors - occurance to occurence
Change-Id: Ie0550a1168448d85043d9b4943edd732b1f10307
2014-03-07 09:38:05 -08:00
Terry Howe
211cd31d7a Make bash comple command best effort to authorize
If authorization fails for the complete command, generate the bash complete anyway.
* Added best_effort flag to command
* Attempts to authorize for bash complete, but if it fails, it tries anyway

Change-Id: I796258f8044f42abc6a51164d920a26f73397962
Partial-Bug: #1283550
2014-03-06 18:41:37 -07:00
Terry Howe
70e6333e7d Add ability to set key value pairs in projects
Add supporto of extra key value pairs for projects (aka tenants)
* Added option --property key=value to create and set commands
* Support for versions v2 and v3

Change-Id: I84064b8b308579d1b66c83b1ed3d1a37614ec087
Closes-Bug: #1220280
2014-03-06 14:22:17 -07:00
OpenStack Jenkins
64a33b0aa5 Updated from global requirements
Change-Id: Ic90d9682a9c15795928c0c5b64c41bd06d74243a
2014-03-05 19:30:08 +00:00
Terry Howe
e6e0dbf754 Add --volume option to image create command
Add ability to create an image from a volume.
* Added --volume command to image create
* Added --force option to image create
* Added block to access volume manager in image create
* Tests added for the volume option

Change-Id: I3910a2b5e04acd0d15dd230747ba6ebca07aa316
Closes-Bug: #1207615
2014-03-05 11:26:13 -07:00
Jenkins
808fa65210 Merge "Update release notes for 0.3.1" 2014-02-28 23:14:51 +00:00
Jenkins
9ccaacbe27 Merge "Fix format errors in nova security group rule list" 2014-02-28 01:44:48 +00:00
Dean Troyer
038269cf7f Update release notes for 0.3.1
* update README
* update man page
* fix doc errors

Change-Id: I5682654bf482289879c8ba9016e348f2b2782971
2014-02-27 17:36:28 -06:00
Terry Howe
e9015b94f9 In anticipation of network agents, rename compute
Rename the compute agents in anticipation of network agents

Change-Id: I201121915638d89dfbe46a7e0026aa4c2777e590
Closes-Bug: #1285800
2014-02-27 10:55:37 -07:00
Jenkins
b7f673cb81 Merge "Fix volume commands with multiple regions" 2014-02-26 23:18:34 +00:00
Jamie Lennox
8be3e249b6 Use cacert values when creating identity client
These were ignored when the client was created with a username and
password.

Change-Id: Id7557a5b07a41c7f79ab1a05ede385da31889940
Closes-Bug: #1284957
2014-02-26 13:29:19 +10:00
OpenStack Jenkins
125393210b Updated from global requirements
Change-Id: Icad0fcf4125b4aefac7ed8f0df5bef2c6ee64594
2014-02-23 09:31:55 +00:00
Jenkins
8fe50fc75d Merge "Fix some help strings" 2014-02-23 06:17:49 +00:00
Jenkins
034a9d158f Merge "Add ability to prompt for passwords for user create and set" 2014-02-22 06:00:18 +00:00
Terry Howe
eddab62109 Fix volume commands with multiple regions
The region_name was not passed into the the client causing volume
commands to fail if there were multiple regions.

Change-Id: I066dbbc4852f412e017daeeb16a3f186d3f91d2f
Closes-Bug: #1241177
2014-02-21 17:22:26 -07:00
Terry Howe
033f27fe4d Add ability to prompt for passwords for user create and set
* Add get_password method to the utilities
* Add --password-prompt option
* Call the get_password method if a prompt is requested
* Various tests

Change-Id: I1786ad531e2a2fbcc21b8bc86aac0ccd7985995a
Closes-Bug: 1100116
2014-02-21 14:42:22 -07:00
Andreas Jaeger
5043293156 Fix some help strings
This fixes some errors and inconsistencies I found reviewing the
help strings:
* Capitalize help strings
* Add missing space between words (in multi-line strings)
* Improve wording

Change-Id: I2fb31ab4191c330146e31c1a9651115a6657769a
2014-02-21 19:40:41 +01:00
Jenkins
8b494f08b2 Merge "Update oslo incubator bits" 2014-02-21 18:27:51 +00:00
Jenkins
2cae50c442 Merge "Rename Openstack to OpenStack" 2014-02-21 01:36:26 +00:00
Terry Howe
ada9d35cbe Fix format errors in nova security group rule list
* port range was throwing exception for None to/from ports
* ip_range didn't always have cidr causing error
* ip_protocol None at times and looked bad

Closes-Bug #1256935

Change-Id: I451a0f038a3e9646bca3f278c5d6f6d7e3097a83
2014-02-20 20:17:53 +00:00
Dean Troyer
99cea54741 Update oslo incubator bits
* update gettextutils.py, strutils.py, install_venv_common.py
* remove cfg.py, openstackkeyring

oslo-incubator commit 630d3959b9d001ca18bd2ed1cf757f2eb44a336f

Change-Id: I0ae9b9dc72ec88ed64a8c353b9c51734ee2cd24c
2014-02-20 14:09:01 -06:00
Jenkins
2958421755 Merge "Glance client no longer isa http client" 2014-02-20 20:00:59 +00:00
Cyril Roelandt
5f9e7d09cb Python 3: the content of a FakeResponse must be bytes
Encode '_content' if necessary.

Change-Id: I25c1e1cd5330f0519bf062be840045d0ef520b28
2014-02-18 00:49:10 +01:00
tanlin
d8bdd2b5ed Rename Openstack to OpenStack
Change-Id: I9e5b245141290a4b642900fbc46b98bd4f44c321
2014-02-14 09:16:20 +08:00
Jenkins
2f5e8232aa Merge "Python 3: fix a syntax error" 2014-02-11 21:36:46 +00:00
Jenkins
e068cd0d71 Merge "FakeResponse: use a default status code" 2014-02-11 21:35:55 +00:00
Jenkins
c8354b8d83 Merge "Fix misspellings in python openstackclient" 2014-02-11 18:44:30 +00:00
Cyril Roelandt
9dc3eb5b18 FakeResponse: use a default status code
When running some tests from test_restapi.py, the following error happens:

    TypeError: unorderable types: NoneType() < int()

In Python 2, comparing NoneType and integers is possible:

    >>> None < 2
    True

But in Python 3, it's not allowed. Fix this by using a default status code.

Change-Id: Ic0fad5c68f3bf2dd8a2b98423549903f982192c9
2014-02-11 17:31:37 +01:00
Jenkins
9aa207eb9d Merge "Use six.iteritems() rather than dict.iteritems()" 2014-02-11 15:41:40 +00:00
Cyril Roelandt
eaa4c3e1a6 Python 3: fix a syntax error
"raise AttributeError, name" is invalid in Python 3.

Change-Id: Id61bd3747f49c2bd810cbfeae56506e7ed9d2bd0
2014-02-11 15:44:54 +01:00
Cyril Roelandt
3a5abf743c Use six.iteritems() rather than dict.iteritems()
This is compatible with both Python 2 and 3.

Change-Id: I6fe3e9bf9ece699badbdb9933118af90642a91e9
2014-02-11 02:53:24 +01:00
Jeremy Stanley
380d78c856 Remove tox locale overrides
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.

Change-Id: I89ff5c22be053f09defb04b3ec589d74bffcae9d
Closes-Bug: #1277495
2014-02-10 03:10:52 +00:00
Terry Howe
ecc4fb330d Glance client no longer isa http client
If the client has-a http_client, then is must not be an is-a.  This has been tested with the current version of glanceclient and the master branch.

Closes-Bug: #1269821
Change-Id: I14d67eb094bfb4c2dbc07106343488298b6a9409
2014-02-07 13:43:02 -07:00
Shane Wang
8aa0b07fbc Fix misspellings in python openstackclient
Fix misspellings detected by:
* pip install misspellings
* git ls-files | grep -v locale | misspellings -f -

Change-Id: Ic0d3efa26eb9a05ce16a8319c142f5bd1ce23821
Closes-Bug: #1257295
2014-02-07 13:26:48 +08:00
Jenkins
632363328b Merge "Add token create subcommand for identity v3 api" 2014-01-31 17:28:02 +00:00
Qiu Yu
a8d828f330 Add token create subcommand for identity v3 api
Implements token create subcommand which is an equivalent of keystone
token-get command. Original "wrap" parameter for keystone token-get is
not implemented yet due to cliff Bug #1269299

This is a part of: blueprint add-identity-token-support

Change-Id: I2255021c9d1f10f757686583b1ebe40b5f3a9ecb
2014-01-29 15:59:12 +08:00
OpenStack Jenkins
0aeb357fc2 Updated from global requirements
Change-Id: I98929876d5a21a990009398d9a8259c54d893e7e
2014-01-24 22:40:56 +00:00
Jenkins
0076f694ac Merge "Fix keyring issue where there were name space problems" 2014-01-23 17:38:15 +00:00
Jenkins
cb2fd0af83 Merge "Remove copyright from empty files" 2014-01-23 17:38:15 +00:00
Terry Howe
bc2395eb47 Fix keyring issue where there were name space problems
The import of keyring conflicted with a string named keyring

Change-Id: I7416ea1cf453a126dd03dba8bc2900cad35ed2da
Closes-bug: #1271987
2014-01-23 09:37:13 -07:00
Jenkins
9e9bbad120 Merge "Remove remaining print statements" 2014-01-23 04:09:53 +00:00
Dean Troyer
350718f3bb Remove remaining print statements
I think these are the last two stragglers, including debugging lines

Change-Id: Ic3dd98480211d0f7d3cc951bec5cd54f902a101f
2014-01-22 18:53:11 -06:00
Jenkins
ebfa6698a1 Merge "Add token create subcommand for identity v2 api" 2014-01-22 08:13:42 +00:00
Alexander Ignatov
ad4367839f Remove copyright from empty files
According to policy change in HACKING:
http://docs.openstack.org/developer/hacking/#openstack-licensing
empty files should no longer contain copyright notices.

Change-Id: Iba09a00f24dfbd1cd03c1c9f70ea216788e64d93
Closes-Bug: #1262424
2014-01-20 17:28:13 +04:00
Qiu Yu
4848d3ca3a Add token create subcommand for identity v2 api
Implements token create subcommand which is an equivalent of keystone
token-get command. Original "wrap" parameter for keystone token-get is
not implemented yet due to cliff Bug #1269299

This is a part of: blueprint add-identity-token-support

Change-Id: I9e4de93306f2f5959717b5219621da03961524d8
2014-01-17 17:42:01 +08:00
Sascha Peilicke
81d33a524d Sync with global requirements
Change-Id: Ie47804617ab9a11a91efd96c7989f0207e47e120
2014-01-16 09:21:39 +01:00
Jenkins
a53ed797b7 Merge "Fix image set properties error" 2014-01-10 17:27:50 +00:00
Jenkins
b00bbaa062 Merge "Fix errant underscores" 2014-01-10 17:27:48 +00:00
Jenkins
6ad05112f4 Merge "Displaying curl commands for nova and cinder calls" 2014-01-10 17:07:12 +00:00
Dean Troyer
9e31f8ea14 Fix errant underscores
Change-Id: I71b8c8df14b85e3042220e3593a9732ee6cefe15
2014-01-09 16:54:40 -06:00
Jenkins
e821a6b97f Merge "Add support for specifying custom domains" 2014-01-08 16:40:34 +00:00
Paul Belanger
420b10ee6d Add support for specifying custom domains
Add the ability to pass user_domain_id / user_domain_name, domain_id
/ domain_name, and project_domain_id / project_domain_name to keystone.
These parameters are the first step needed to getting multi-domain
support working via the CLI.

Closes-Bug: #1198171
Change-Id: I81a8534913978ff1cce01ec02741ae477e8c5fa4
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Signed-off-by: Bo Tang <btang@cs.utsa.edu>
2014-01-07 16:50:20 -06:00
Dean Troyer
7b999d786c Fix image set properties error
Change-Id: Ia290935c8a040221caf1a46ca29a7bb2e5df1ce6
2014-01-06 09:42:40 -06:00
Florent Flament
a5e087e7a9 Displaying curl commands for nova and cinder calls
When using the -v option, displays curl equivalent commands and http
messages exchanged with the nova and cinder API servers. Displays the
same messages as those displayed with the --debug option of
python-novaclient and python-cinderclient.

Implements: blueprint curl-commands-in-debugging-messages for nova and
cinder related calls

Change-Id: Ibc8ef79d874334585b81d652b9c7df9e874fffa9
2014-01-02 11:08:53 +01:00
Terry Howe
202c3e375b Closes-Bug: #1262322 Make links clickable
Change-Id: I61302ff5274cdaa09801cb9b0dc9bfd353ac687f
2013-12-25 09:41:17 -07:00
Terry Howe
12f31eed2f Closes-Bug: #1262321
Remove the unimplemented post_process method call

Change-Id: Iaed526cc25a651008a66ad7f0050070ab2b4c595
2013-12-19 20:06:54 -07:00
Dean Troyer
de27c1b455 Release notes for 0.3.0 release
Change-Id: I6f025b745378613eb674e13dd503e57d049a3e50
2013-12-17 09:22:17 -06:00
Dean Troyer
4595ca1365 Remove mox3 requirement
mox3 is only used got py3 testing when converting tests from mox,
all OSC tests are new so we don't need it.

Change-Id: I2fae539e99143f91048c95d1e46cfbd7b0e9bdb0
2013-12-17 09:21:03 -06:00
OpenStack Jenkins
c645049c24 Updated from global requirements
Change-Id: I065a67d560efca0907da9fcaa8d5ce4712dfa2c1
2013-12-10 23:45:49 +00:00
Jenkins
facdc8704e Merge "Bring RESTApi closer to ithe imminent keystoneclient.Session" 2013-12-06 22:48:29 +00:00
Jenkins
cd870886fc Merge "Update docs for plugins and release notes" 2013-12-06 22:47:15 +00:00
Jenkins
b88a7b8ccc Merge "Add module list command" 2013-12-05 23:34:31 +00:00
Dean Troyer
4f1ebe8069 Update docs for plugins and release notes
* Fill out the existing command and man page
* Add a plugins page.
* Begin the release notes for 0.3.0

Change-Id: I4527fed28a10a9d79fc8f6c1d925a4bf0d0a7a36
2013-12-05 17:29:35 -06:00
Jenkins
e06e1a2cce Merge "Add missing requests and six requirements" 2013-12-05 17:22:34 +00:00
Sascha Peilicke
f227092a06 Add missing requests and six requirements
From global-requirements: requests>=1.1, six>=1.4.1

Change-Id: I536adc511931229a268ba81f81aef1aed59b33eb
2013-12-04 14:44:09 +01:00
Dean Troyer
a93cc3fae2 Add module list command
Lists versions of installed python modules

(Origianlly proposed as 'version list')

Change-Id: I76a51d3d6783f46ef2daa0a41626019a880a2a50
2013-12-03 17:53:55 -06:00
Dean Troyer
74a27056b3 Update OSC's CommandManager subclass
cliff.commandmanager.CommandManager gained an option, update
openstackclient.common.commandmanager.ComamndManager to match.

Also add CommandManager.get_command_groups() to return a list of the
currently loaded command groups.  I expect this to be useful in
upcoming client diagnostic commands for plugins/extensions.

If these turn out to be generally useful we'll propose them to
upstream cliff.

Change-Id: Ic15a7ca0ef975ca679e753be861be7c628b8e10c
2013-12-03 17:40:54 -06:00
Dean Troyer
f2dbe2e437 Bring RESTApi closer to ithe imminent keystoneclient.Session
Prepare to use the (soon to be) common Session from keystoneclient
* Rework RESTApi to eventually be a subclass of keystoneclient.Session

Change-Id: I68e610f8b19a3f6267a93f7bf3de54a228be68aa
2013-12-03 14:26:46 -06:00
Terry Howe
5dcc3b6164 Add return Closes-Bug: 1246356
Change-Id: I70999a91062b9c61e5f420b1ed33a45086b62fd4
2013-11-27 14:25:12 -07:00
Dean Troyer
935781fdf9 Restore Object API name 'object-store'
It's used in the service catalog, doh!

Change-Id: If8f6db49c84756fd8e58cc68910160da4cd99b5d
2013-11-25 14:46:57 -06:00
Dean Troyer
9062811d10 Expand support for command extensions
Allows client libraries to have complete access to the rest of the
OSC ClientManager.  In addition, extension libraries can define
global options (for API version options/env vars) and define
versioned API entry points similar to the in-repo commands.

The changes to ClientManager exposed some issues in the existing
object api tests that needed to be cleaned up.

Change-Id: Ic9662edf34c5dd130a2f1a69d2454adefc1f8a95
2013-11-21 01:27:10 -06:00
Jenkins
d45187a0c1 Merge "Add server image create command" 2013-11-20 06:37:25 +00:00
Jenkins
b70b1d04e4 Merge "Complete basic test infrastructure" 2013-11-20 06:37:24 +00:00
Jenkins
56fbf65941 Merge "change execute to run" 2013-11-19 17:24:30 +00:00
Jenkins
0b3d69599b Merge "Fix typo" 2013-11-19 17:24:29 +00:00
Noorul Islam K M
07bbfd5770 Fix typo
Change-Id: I7bca8b76c6746121314e688e9ed3825e04350b8d
2013-11-19 19:58:03 +05:30
Sascha Peilicke
5444641292 Support building wheels (PEP-427)
With that, building and uploading wheels to PyPI is only one "python
setup.py bdist_wheel" away.

Change-Id: I8c8565f55e7a3434e1a1972a797a6cd7dba8a581
2013-11-19 10:11:07 +01:00
Dean Troyer
200ed62054 Add server image create command
Translation of 'nova image-create', with tests!

Change-Id: I8a833aeff6f291e4774063ed235876eb2ba9c13c
2013-11-18 23:40:11 -06:00
Dean Troyer
6460f1eb35 Complete basic test infrastructure
This finally gets all of the API tests into a common framework regarding
test classes and so forth.

Change-Id: If675347129c50dcba0bfc5b6c58f5a2ca57ff46c
2013-11-18 22:11:10 -06:00
Terry Howe
98eaccc431 change execute to run
Change-Id: I23a210c8771c206df14d2713a2e72ccd92402c43
2013-11-16 05:47:32 -07:00
Joe Gordon
c946192e37 Update URL for global hacking doc and fix typos
* related to I579e7c889f3addc2cd40bce0c584bbc70bf435e2

Change-Id: I519155d0a47564ce18a9cd930378a3c4feaa7a77
2013-11-11 11:09:55 -08:00
OpenStack Jenkins
e118f216db Merge "Updated from global requirements" 2013-11-08 04:22:36 +00:00
Dean Troyer
68094619be Remove httpretty from test requirements
We don't use it...

Change-Id: I41466da5153a8bdd0e4b4dd5774a9711bff3b7f5
2013-11-07 20:57:47 -06:00
OpenStack Jenkins
6ecf5bf4e3 Updated from global requirements
Change-Id: I421ab7a5b0c0224122cc747141956bc1282f2b07
2013-11-05 09:54:51 +00:00
Dean Troyer
9137cc304d Do lookups for user, project in volume create
This required https://review.openstack.org/26323 in keystoneclient,
merged long ago...

Also adds some tests for 'volume create'

Change-Id: I55bededbc20b5dcf2833c59eb2b6b069703d8a9a
2013-10-25 12:21:41 -05:00
Dirk Mueller
1fa1330e1d Adjust to non-deprecated names in Keyring 1.6.+
Keyring 1.1 moved the concrete backend implementations into their
own modules. As we depend on 1.6.1+, we can make use of the new
name and remove the old one without deprecation-fallback.

Change-Id: I0682b13fc9f488b3f3d9fd057f712909fcd48bc4
2013-10-24 14:25:40 +02:00
OpenStack Jenkins
a1bda219a5 Updated from global requirements
Change-Id: I2a306dd8edc030d3f989e9947dec784f502b3953
2013-10-16 12:21:38 +00:00
Jenkins
29642c2c3d Merge "Sync oslo-incubator for py33 fixes" 2013-10-13 04:56:38 +00:00
Jenkins
b3fd6ad6db Merge "Add to clientmanager tests" 2013-10-13 04:56:22 +00:00
Dean Troyer
fa649f4654 Sync oslo-incubator for py33 fixes
Change-Id: I261ec6bb34b29169ba3547305deab051f85a3d4d
2013-10-11 11:59:05 -05:00
Dean Troyer
3f9c68f1c6 Add options to support TLS certificate verification
Add --os-cacert and --verify|--insecure options using the same
sematics as the other project CLIs.  --verify is included for
completeness.

Bug: 1236608

Change-Id: I8a116d790db5aa4cb17a2207efedce7cb229eba3
2013-10-07 18:17:48 -05:00
OpenStack Jenkins
bca4cf9578 Updated from global requirements
Change-Id: Ic3b5de6a54951b4f9a6449f97aa1ab9c395a2f08
2013-10-01 16:15:07 +00:00
Dean Troyer
ad59b03be6 Add object-store show commands
* Add lib.container.show_container() and lib.object.show_object()
* Add container and object show commands

Change-Id: I963d664c55b59739453345f0f353aa2eaf1bf70e
2013-09-26 13:34:11 -05:00
Dean Troyer
74f4e31389 Update release notes for 0.2.2
Change-Id: I59cbee4c147d5f849a7f07224e83ddd751212077
2013-09-20 10:57:31 -05:00
Dean Troyer
ae8d64b337 Sort entrypoints in setup.cfg
Change-Id: I72b0e069334c290cdc4d46cff0ba66d751c0edb4
2013-09-20 10:37:50 -05:00
Dean Troyer
1c4d3b320f Fix security group entrypoints
Change-Id: I0590dde67b1121523d03742ce57093f2c5bacc72
2013-09-20 10:33:15 -05:00
Dean Troyer
6fe687fdf6 Delay authentication to handle commands that do not require it
* Move the auth to OpenStackShell.prepare_to_run_command() and skip it if
  the command's auth_required == False
* Default auth_required = True for all commands
* Do authentication up-front for interactive use as
  OpenStackShell.prepare_to_run_command() is not called

Change-Id: Id330092f242af624f430d469882d15f4a22f4e37
2013-09-12 16:23:14 -05:00
Dean Troyer
8898e020fb Identity v3 tests
* Add project, user, role and service v3 tests
* Fix issues in commands with enable/disable
* Make commands and tests more consistent between versions
* Make formatting and comments more consistent

Change-Id: Id21e7a5abd7e421a7742f937861ec46b53095fc7
2013-09-09 14:58:28 -05:00
Dean Troyer
7a0a7d67ed Prepare for Identity v3 tests
* Split identity/fakes.py for v2_0 and v3
* Split identity/test_identity.py for v2_0 and v3
* Fix issues in commands with enable/disable
* Clean up v2 commands

Change-Id: I6e536b6a130fc556dbd7dcf9f2e76d939ca1bc1c
2013-09-09 14:52:50 -05:00
Dean Troyer
916bb68dfd Add to clientmanager tests
Change-Id: Iea59c494f31de9c3e1d662f89e6e2babcc8fbd61
2013-09-05 12:54:14 -05:00
Jenkins
16edd97007 Merge "Update tox.ini for new tox 1.6 config" 2013-09-05 13:06:45 +00:00
Dean Troyer
44c97cc099 Add Identity v2 role and service tests
* Add current auth info (auth_ref) to ClientManager
* Fix identity.v2_0.role.ListUserRole to get default user/project
  from ClientManager.auth_ref
* Fix identity.v2_0.role.AddRole call to roles.add_user_role()

Change-Id: Ie8bf41c491d97b0292a2b86bdc9b7580989a7f97
2013-09-04 21:37:45 +00:00
Dean Troyer
eb405a88c4 Refactor fake data for projects and users
* Move fake data structures into tests/identity/fakes.py
* Use fake clients correctly and support multiple client versions

Change-Id: Icacbb2ca740b63937bd2c4442af61b620638b53e
2013-09-04 14:48:24 -05:00
Dean Troyer
c8723ce175 Update tox.ini for new tox 1.6 config
Change-Id: I4363508f562f62b16c856bc072cdb4b37e37b418
2013-09-04 14:23:15 -05:00
Jenkins
1c495a573c Merge "Update requirements.txt and test-requirements.txt" 2013-09-04 19:20:20 +00:00
Dean Troyer
5e29928294 Update requirements.txt and test-requirements.txt
Change-Id: I9c60d1d9097d35aa7c3d44168e370a9f30fd6621
2013-09-04 13:27:26 -05:00
Dean Troyer
725e2543ef Object API commands using our REST API layer
* Add object-store API to ClientManager
* Add object-store client
* Add Object API library in openstackclient.object.v1.lib
* Add Object API {container,object} list commands
* Add library tests
* Add command tests

This should complete the Object v1 container and object list commands

Change-Id: Ib1770d45efa8871959826b85faafa1e0bcef0a03
2013-08-28 22:16:34 -05:00
Dean Troyer
17f13f7bf4 Create a new base REST API interface
* restapi module provides basic REST API support
  * uses dicts rather than Resource classes
  * JSON serialization/deserialization
  * log requests in 'curl' format
  * basic API boilerplate for create/delete/list/set/show verbs
* ignore H302 due to urllib import

Change-Id: I3cb91e44e631ee19e9f5dea19b6bac5d599d19ce
2013-08-23 12:08:32 -05:00
Jenkins
b440986e6e Merge "Re-order oauth commands and sync with keystoneclient" 2013-08-23 16:24:20 +00:00
Steve Martinelli
880323e91d Re-order oauth commands and sync with keystoneclient
1) split out token and consumer
2) sync parameters with keystoneclient

Change-Id: I2d529f0f9087f9939101e963af3d801497fc1171
2013-08-21 15:24:50 -05:00
Dean Troyer
22a6e8891e Add Identity v2 user tests
* implement Identity command tests for v2 user

Also re-work the user create and set commands for exclusive options
(--enable|--disable) to actually behave properly.  Yay tests!

Change-Id: Ie1ec2569b3d85a9d556ee70f2e8f69fd2a3c03c8
2013-08-19 15:26:51 -05:00
Dean Troyer
493339d4da Add Identity v2 project tests
* establish the the form of cliff command classes
* implement some common fake objects
* implement Identity command tests for v2 project
* fix stdout/stderr capture

Also re-work the project create and set commands for exclusive options
(--enable|--disable) to actually behave properly.  Yay tests!

Change-Id: Icbb313db544c1f8dd3c9af7709971838b5a4d115
2013-08-16 14:35:46 -05:00
Monty Taylor
93612bbf53 Updated from global requirements
Change-Id: I1687d51bddb873549163dcf488fc40cdd9edcb29

Change-Id: Ic4a43955526fcde313ad2f2afec8fafeb87f37a6
2013-08-07 18:54:34 -03:00
Dean Troyer
0507e9cf6f Add release notes in docs
Change-Id: I49dc936a37848745ce3412e810b98348558d1157
2013-08-06 12:43:22 -05:00
Monty Taylor
3a92ffa823 Sync with global requirements
Change-Id: I1969b4d74363a8d77cbb5dac661874f3bea2e96c
2013-08-03 14:58:43 -04:00
1463 changed files with 188404 additions and 11097 deletions

View file

@ -1,7 +1,7 @@
[run]
branch = True
source = openstackclient
omit = openstackclient/openstack/*
omit = openstackclient/tests/*
[report]
ignore-errors = True
ignore_errors = True

13
.git-blame-ignore-revs Normal file
View file

@ -0,0 +1,13 @@
# You can configure git to automatically use this file with the following config:
# git config --global blame.ignoreRevsFile .git-blame-ignore-revs
c5b772db76c071e493a81105c7d8c0def08b2264 # trivial: Prepare for pyupgrade pre-commit hook
ed0314ac76ae58a6621077feb742efd5c14c3a62 # Blacken everything else
ac64fdb93c32972575a4523ccb23d0279ef584f5 # Blacken openstackclient.api
a3778109d0051a25901569e7bafe54915ab25f82 # Blacken openstack.common
53476e1f73d8af172207ac7089fb85fc0221859f # Blacken openstackclient.image
c51e4ef1bc350905a04690eb019d53e68fe3d633 # Blacken openstackclient.object
af6ea07703ed1c12b86995b97a9618bfa70721ee # Blacken openstackclient.identity
1face4f48b07fbc51824980e989687adaf453f0e # Blacken openstackclient.network
1ca77acc9118b433c14e03bf9fd28f2b1639c430 # Blacken openstackclient.volume
4bbf3bd3846cb3d85e243199910de82df25d35e0 # Blacken openstackclient.compute

12
.gitignore vendored
View file

@ -7,12 +7,20 @@
*.swp
*~
.coverage
.openstackclient-venv
.idea
.stestr/
.testrepository
.tox
.venv
AUTHORS
build
ChangeLog
dist
# Doc related
doc/build
doc/source/contributor/api/
# Development environment files
.project
.pydevproject
cover
# Files created by releasenotes build
releasenotes/build

View file

@ -1,4 +1,4 @@
[gerrit]
host=review.openstack.org
host=review.opendev.org
port=29418
project=openstack/python-openstackclient.git

42
.pre-commit-config.yaml Normal file
View file

@ -0,0 +1,42 @@
---
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
hooks:
- id: trailing-whitespace
- id: mixed-line-ending
args: ['--fix', 'lf']
exclude: '.*\.(svg)$'
- id: fix-byte-order-marker
- id: check-executables-have-shebangs
- id: check-merge-conflict
- id: debug-statements
- id: check-yaml
files: .*\.(yaml|yml)$
args: ['--unsafe']
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.14.0
hooks:
- id: ruff-check
args: ['--fix', '--unsafe-fixes']
- id: ruff-format
- repo: https://opendev.org/openstack/hacking
rev: 7.0.0
hooks:
- id: hacking
additional_dependencies: []
exclude: '^(doc|releasenotes)/.*$'
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.18.2
hooks:
- id: mypy
additional_dependencies:
- types-requests
# keep this in-sync with '[tool.mypy] exclude' in 'pyproject.toml'
exclude: |
(?x)(
doc/.*
| examples/.*
| hacking/.*
| releasenotes/.*
)

4
.stestr.conf Normal file
View file

@ -0,0 +1,4 @@
[DEFAULT]
test_path=${OS_TEST_PATH:-./openstackclient/tests/unit}
top_dir=./
group_regex=([^\.]+\.)+

View file

@ -1,4 +0,0 @@
[DEFAULT]
test_command=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ . $LISTOPT $IDOPTION
test_id_option=--load-list $IDFILE
test_list_option=--list

187
.zuul.yaml Normal file
View file

@ -0,0 +1,187 @@
---
- job:
name: osc-tox-unit-tips
parent: openstack-tox
description: |
Run unit tests for OpenStackClient with master branch of important libs.
Takes advantage of the base tox job's install-siblings feature.
irrelevant-files: &common-irrelevant-files
- ^.*\.rst$
- ^doc/.*$
- ^releasenotes/.*$
- ^\.pre-commit-config\.yaml$
required-projects:
- openstack/cliff
- openstack/keystoneauth
- openstack/openstacksdk
- openstack/osc-lib
- openstack/python-openstackclient
vars:
# Set work dir to openstackclient so that if it's triggered by one of the
# other repos the tests will run in the same place
zuul_work_dir: src/opendev.org/openstack/python-openstackclient
- job:
name: osc-tox-py310-tips
parent: openstack-tox-py310
description: |
Run unit tests for OpenStackClient with master branch of important libs.
Takes advantage of the base tox job's install-siblings feature.
# The job only tests the latest and shouldn't be run on the stable branches
branches: ^master$
required-projects:
- openstack/cliff
- openstack/keystoneauth
- openstack/openstacksdk
- openstack/osc-lib
- openstack/python-openstackclient
vars:
# Set work dir to openstackclient so that if it's triggered by one of the
# other repos the tests will run in the same place
zuul_work_dir: src/opendev.org/openstack/python-openstackclient
- job:
name: osc-tox-py313-tips
parent: openstack-tox-py313
description: |
Run unit tests for OpenStackClient with master branch of important libs.
Takes advantage of the base tox job's install-siblings feature.
# The job only tests the latest and shouldn't be run on the stable branches
branches: ^master$
required-projects:
- openstack/cliff
- openstack/keystoneauth
- openstack/openstacksdk
- openstack/osc-lib
- openstack/python-openstackclient
vars:
# Set work dir to openstackclient so that if it's triggered by one of the
# other repos the tests will run in the same place
zuul_work_dir: src/opendev.org/openstack/python-openstackclient
- job:
name: osc-functional-devstack
parent: devstack-tox-functional
description: |
Run functional tests for OpenStackClient.
timeout: 7800
irrelevant-files:
- ^.*\.rst$
- ^doc/.*$
- ^releasenotes/.*$
required-projects:
- openstack/python-openstackclient
vars:
devstack_localrc:
LIBS_FROM_GIT: python-openstackclient
# NOTE(dtroyer): Functional tests need a bit more volume headroom
VOLUME_BACKING_FILE_SIZE: 20G
Q_AGENT: openvswitch
Q_ML2_TENANT_NETWORK_TYPE: vxlan
Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch
devstack_plugins:
# NOTE(amotoki): Some neutron features are enabled by devstack plugin
neutron: https://opendev.org/openstack/neutron
devstack_services:
s-account: true
s-container: true
s-object: true
s-proxy: true
# Disable OVN services
br-ex-tcpdump: false
br-int-flows: false
ovn-controller: false
ovn-northd: false
ovs-vswitchd: false
ovsdb-server: false
q-ovn-metadata-agent: false
# Neutron services
q-agt: true
q-dhcp: true
q-l3: true
q-meta: true
neutron-network-segment-range: true
neutron-segments: true
q-metering: true
q-qos: true
neutron-tag-ports-during-bulk-creation: true
neutron-conntrack-helper: true
neutron-ndp-proxy: true
q-trunk: true
osc_environment:
PYTHONUNBUFFERED: 'true'
OS_CLOUD: devstack-admin
tox_envlist: functional
zuul_work_dir: src/opendev.org/openstack/python-openstackclient
- job:
name: osc-functional-devstack-tips
parent: osc-functional-devstack
description: |
Run functional tests for OpenStackClient with master branch of important libs.
Takes advantage of the base tox job's install-siblings feature.
timeout: 7800
required-projects:
- openstack/cliff
- openstack/keystoneauth
- openstack/openstacksdk
- openstack/osc-lib
- openstack/python-openstackclient
vars:
devstack_localrc:
LIBS_FROM_GIT: python-openstackclient,openstacksdk,osc-lib,cliff
tox_envlist: functional
tox_install_siblings: true
- job:
name: osc-build-image
parent: opendev-build-docker-image
description: Build Docker images.
allowed-projects: openstack/python-openstackclient
requires:
- python-builder-3.11-bookworm-container-image
- python-base-3.11-bookworm-container-image
provides: osc-container-image
vars:
docker_images:
- context: .
tags: []
- project-template:
name: osc-tox-unit-tips
check:
jobs:
- osc-tox-py310-tips
- osc-tox-py313-tips
gate:
jobs:
- osc-tox-py310-tips
- osc-tox-py313-tips
- project:
templates:
- openstackclient-plugin-jobs
- osc-tox-unit-tips
- openstack-cover-jobs
- openstack-python3-jobs
- publish-openstack-docs-pti
- check-requirements
- release-notes-jobs-python3
check:
jobs:
- openstackclient-check-plugins:
voting: true
- osc-build-image:
voting: false
- osc-functional-devstack
- osc-functional-devstack-tips:
# The functional-tips job only tests the latest and shouldn't be run
# on the stable branches
branches: ^master$
gate:
jobs:
- osc-functional-devstack

27
CONTRIBUTING.rst Normal file
View file

@ -0,0 +1,27 @@
The source repository for this project can be found at:
https://opendev.org/openstack/python-openstackclient
Pull requests submitted through GitHub are not monitored.
To start contributing to OpenStack, follow the steps in the contribution guide
to set up and use Gerrit:
https://docs.openstack.org/contributors/code-and-documentation/quick-start.html
Bugs should be filed on Launchpad:
https://bugs.launchpad.net/python-openstackclient
Developers should also join the discussion on the mailing list, at:
https://lists.openstack.org/mailman3/lists/openstack-discuss.lists.openstack.org/
or join the IRC channel on
#openstack-sdks on OFTC (irc.oftc.net)
For more specific information about contributing to this repository, see the
openstacksdk contributor guide:
https://docs.openstack.org/openstacksdk/latest/contributor/index.html

36
Dockerfile Normal file
View file

@ -0,0 +1,36 @@
# Copyright (c) 2020 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM docker.io/opendevorg/python-builder:3.12-bookworm AS builder
COPY . /tmp/src
RUN assemble
FROM docker.io/opendevorg/python-base:3.12-bookworm
LABEL org.opencontainers.image.title="python-openstackclient"
LABEL org.opencontainers.image.description="Client for OpenStack services."
LABEL org.opencontainers.image.licenses="Apache License 2.0"
LABEL org.opencontainers.image.url="https://www.openstack.org/"
LABEL org.opencontainers.image.documentation="https://docs.openstack.org/python-openstackclient/latest/"
LABEL org.opencontainers.image.source="https://opendev.org/openstack/python-openstackclient"
COPY --from=builder /output/ /output
RUN /output/install-from-bindep
# Trigger entrypoint loading to trigger stevedore entrypoint caching
RUN openstack --help >/dev/null 2>&1
CMD ["/usr/local/bin/openstack"]

View file

@ -1,12 +1,13 @@
OpenStack Style Commandments
============================
Step 0: Read https://github.com/openstack-dev/hacking/blob/master/HACKING.rst
Step 1: Read http://www.python.org/dev/peps/pep-0008/ one more time
Step 2: Read on
- Step 1: Read the OpenStack Style Commandments
https://docs.openstack.org/hacking/latest/
- Step 2: Read on
General
-------
- thou shalt not violate causality in our time cone, or else
Docstrings
@ -27,11 +28,11 @@ Calling Methods
---------------
Deviation! When breaking up method calls due to the 79 char line length limit,
use the alternate 4 space indent. With the frist argument on the succeeding
use the alternate 4 space indent. With the first argument on the succeeding
line all arguments will then be vertically aligned. Use the same convention
used with other data structure literals and terminate the method call with
the last argument line ending with a comma and the closing paren on its own
line indented to the starting line level.
line indented to the starting line level. ::
unnecessarily_long_function_name(
'string one',
@ -39,68 +40,3 @@ line indented to the starting line level.
kwarg1=constants.ACTIVE,
kwarg2=['a', 'b', 'c'],
)
Text encoding
-------------
Note: this section clearly has not been implemented in this project yet, it is
the intention to do so.
All text within python code should be of type 'unicode'.
WRONG:
>>> s = 'foo'
>>> s
'foo'
>>> type(s)
<type 'str'>
RIGHT:
>>> u = u'foo'
>>> u
u'foo'
>>> type(u)
<type 'unicode'>
Transitions between internal unicode and external strings should always
be immediately and explicitly encoded or decoded.
All external text that is not explicitly encoded (database storage,
commandline arguments, etc.) should be presumed to be encoded as utf-8.
WRONG:
mystring = infile.readline()
myreturnstring = do_some_magic_with(mystring)
outfile.write(myreturnstring)
RIGHT:
mystring = infile.readline()
mytext = s.decode('utf-8')
returntext = do_some_magic_with(mytext)
returnstring = returntext.encode('utf-8')
outfile.write(returnstring)
Python 3.x Compatibility
------------------------
OpenStackClient strives to be Python 3.3 compatibile. Common guidelines:
* Convert print statements to functions: print statements should be converted
to an appropriate log or other output mechanism.
* Use six where applicable: x.iteritems is converted to six.iteritems(x)
for example.
Running Tests
-------------
Note: Oh boy, are we behing on writing tests. But they are coming!
The testing system is based on a combination of tox and testr. If you just
want to run the whole suite, run `tox` and all will be fine. However, if
you'd like to dig in a bit more, you might want to learn some things about
testr itself. A basic walkthrough for OpenStack can be found at
http://wiki.openstack.org/testr

26
LICENSE
View file

@ -174,29 +174,3 @@
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
END OF TERMS AND CONDITIONS
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright [yyyy] [name of copyright owner]
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

View file

@ -1,12 +0,0 @@
include AUTHORS
include ChangeLog
include LICENSE
include README.rst
recursive-include doc *
recursive-include tests *
exclude .gitignore
exclude .gitreview
global-exclude *.pyc

View file

@ -1,122 +1,229 @@
================
OpenStack Client
================
===============
OpenStackClient
===============
python-openstackclient is a unified command-line client for the OpenStack APIs.
It is a thin wrapper to the stock python-*client modules that implement the
actual REST API client actions.
.. image:: https://img.shields.io/pypi/v/python-openstackclient.svg
:target: https://pypi.org/project/python-openstackclient/
:alt: Latest Version
This is an implementation of the design goals shown in
http://wiki.openstack.org/UnifiedCLI. The primary goal is to provide
a unified shell command structure and a common language to describe
operations in OpenStack.
OpenStackClient (OSC) is a command-line client for OpenStack that brings
the command set for Compute, Identity, Image, Network, Object Store and Block
Storage APIs together in a single shell with a uniform command structure.
Support for additional service APIs is provided via plugins.
python-openstackclient is designed to add support for API extensions via a
plugin mechanism.
For release management::
* https://launchpad.net/python-openstackclient
For blueprints and feature specifications::
* https://blueprints.launchpad.net/python-openstackclient
For issue tracking::
* https://bugs.launchpad.net/python-openstackclient
Note
====
OpenStackClient is considered to be alpha release quality as of the 0.2 release;
no assurances are made at this point for ongoing compatibility in command forms
or output. We do not, however, expect any major changes at this point.
The primary goal is to provide a unified shell command structure and a common
language to describe operations in OpenStack.
Getting Started
===============
We recommend using a virtualenv to install the client. This description
uses the `install_venv.py`_ script to create the virtualenv::
OpenStack Client can be installed from PyPI using pip:
python tools/install_venv.py
source .venv/bin/activate
python setup.py develop
.. code-block:: shell
Unit tests can be ran simply by running::
python3 -m pip install python-openstackclient
run_tests.sh
You can use ``--help`` or the ``help`` command to get a list of global options
and supported commands:
The client can be called interactively by simply typing::
.. code-block:: shell
openstack
openstack --help
openstack help
Alternatively command line parameters can be called non-interactively::
You can also get help for a specific command:
openstack --help
.. code-block:: shell
openstack server create --help
openstack help server create
You can add support for additional services by installing their clients. For
example, to add support for the DNS service (designate):
.. code-block:: shell
python3 -m pip install python3-designateclient
A ``Dockerfile`` is provided for your convenience in the repository. You can
use this to build your own container images:
.. code-block:: shell
git clone https://opendev.org/openstack/python-openstackclient
cd python-openstackclient
podman build . -t example.com/myuser/openstackclient
For more information the available options and commands, refer to the `Users
Guide`__.
.. __: https://docs.openstack.org/python-openstackclient/latest/cli/index.html
Configuration
=============
The CLI is configured via environment variables and command-line
options as listed in https://wiki.openstack.org/wiki/OpenStackClient/Authentication.
OpenStack Client must be configured with authentication information in order to
communicate with a given OpenStack cloud. This configuration can be achieved
via a ``clouds.yaml`` file, a set of environment variables (often shared via an
``openrc`` file), a set of command-line options, or a combination of all three.
Your cloud provider or deployment tooling will typically provide either a
``clouds.yaml`` file or ``openrc`` file for you. If using a ``clouds.yaml``
file, OpenStack Client expects to find it in one of the following locations:
The 'password flow' variation is most commonly used::
* If set, the path indicated by the ``OS_CLIENT_CONFIG_FILE`` environment
variable
* ``.`` (the current directory)
* ``$HOME/.config/openstack``
* ``/etc/openstack``
export OS_AUTH_URL=<url-to-openstack-identity>
export OS_PROJECT_NAME=<project-name>
export OS_USERNAME=<user-name>
export OS_PASSWORD=<password> # (optional)
export OS_USE_KEYRING=true # (optional)
The options you should set will depend on the configuration of your cloud and
the authentication mechanism(s) supported. For example, consider a cloud that
supports username/password authentication. Configuration for this cloud using a
``clouds.yaml`` file would look like so:
The corresponding command-line options look very similar::
.. code-block:: yaml
--os-auth-url <url>
--os-project-name <project-name>
--os-username <user-name>
[--os-password <password>]
[--os-use-keyring]
clouds:
my-cloud:
auth:
auth_url: '<url-to-openstack-identity>'
project_name: '<project-name>'
project_domain_name: '<project-domain-name>'
username: '<username>'
user_domain_name: '<user-domain-name>'
password: '<password>' # (optional)
region_name: '<region>'
If a password is not provided above (in plaintext), you will be interactively
prompted to provide one securely. If keyring is enabled, the password entered
in the prompt is stored in keyring. From next time, the password is read from
keyring, if it is not provided above (in plaintext).
The corresponding environment variables would look very similar:
The token flow variation for authentication uses an already-aquired token
and a URL pointing directly to the service API that presumably was acquired
from the Service Catalog::
.. code-block:: shell
export OS_TOKEN=<token>
export OS_URL=<url-to-openstack-service>
export OS_AUTH_URL=<url-to-openstack-identity>
export OS_REGION_NAME=<region>
export OS_PROJECT_NAME=<project-name>
export OS_PROJECT_DOMAIN_NAME=<project-domain-name>
export OS_USERNAME=<username>
export OS_USER_DOMAIN_NAME=<user-domain-name>
export OS_PASSWORD=<password> # (optional)
The corresponding command-line options look very similar::
Likewise, the corresponding command-line options would look very similar:
--os-token <token>
--os-url <url-to-openstack-service>
::
Additional command-line options and their associated environment variables
are listed here::
openstack
--os-auth-url <url-to-openstack-identity>
--os-region <region>
--os-project-name <project-name>
--os-project-domain-name <project-domain-name>
--os-username <username>
--os-user-domain-name <user-domain-name>
[--os-password <password>]
--debug # turns on some debugging of the API conversation
--verbose | -v # Increase verbosity of output. Can be repeated.
--quiet | -q # suppress output except warnings and errors
--help | -h # show a help message and exit
.. note::
Building Documentation
======================
If a password is not provided above (in plaintext), you will be
interactively prompted to provide one securely.
This documentation is written by contributors, for contributors.
Some clouds use federated authentication. If this is the case, your
configuration will be slightly more involved. For example, to configure
username/password authentication for a federated user using a ``clouds.yaml``
file:
The source is maintained in the ``doc/source`` folder using
`reStructuredText`_ and built by `Sphinx`_
.. code-block:: yaml
.. _reStructuredText: http://docutils.sourceforge.net/rst.html
.. _Sphinx: http://sphinx.pocoo.org/
clouds:
my-cloud:
auth:
auth_url: '<url-to-openstack-identity>'
project_name: '<project-name>'
project_domain_name: '<project-domain-name>'
username: '<username-in-idp>'
user_domain_name: '<user-domain-name>'
password: '<password-in-idp>'
identity_provider: '<the-desired-idp-in-keystone>'
client_id: '<the-client-id-configured-in-the-idp>'
client_secret: '<the-client-secret-configured-in-the-idp>'
openid_scope: '<the-scopes-of-desired-attributes-to-claim-from-idp>'
protocol: '<the-protocol-used-in-the-apache2-oidc-proxy>'
access_token_type: '<the-access-token-type-used-by-your-idp>'
discovery_endpoint: '<the-well-known-endpoint-of-the-idp>'
auth_type: 'v3oidcpassword'
region_name: '<region>'
* Building Manually::
The corresponding environment variables would look very similar:
$ export DJANGO_SETTINGS_MODULE=local.local_settings
$ python doc/generate_autodoc_index.py
$ sphinx-build -b html doc/source build/sphinx/html
.. code-block:: shell
Results are in the `build/sphinx/html` directory.
export OS_PROJECT_NAME=<project-name>
export OS_PROJECT_DOMAIN_NAME=<project-domain-name>
export OS_AUTH_URL=<url-to-openstack-identity>
export OS_IDENTITY_API_VERSION=3
export OS_AUTH_TYPE=v3oidcpassword
export OS_USERNAME=<username-in-idp>
export OS_PASSWORD=<password-in-idp>
export OS_IDENTITY_PROVIDER=<the-desired-idp-in-keystone>
export OS_CLIENT_ID=<the-client-id-configured-in-the-idp>
export OS_CLIENT_SECRET=<the-client-secred-configured-in-the-idp>
export OS_OPENID_SCOPE=<the-scopes-of-desired-attributes-to-claim-from-idp>
export OS_PROTOCOL=<the-protocol-used-in-the-apache2-oidc-proxy>
export OS_ACCESS_TOKEN_TYPE=<the-access-token-type-used-by-your-idp>
export OS_DISCOVERY_ENDPOINT=<the-well-known-endpoint-of-the-idp>
Likewise, the corresponding command-line options would look very similar:
.. code-block:: shell
--os-project-name <project-name>
--os-project-domain-name <project-domain-name>
--os-auth-url <url-to-openstack-identity>
--os-identity-api-version 3
--os-auth-plugin openid
--os-auth-type v3oidcpassword
--os-username <username-in-idp>
--os-password <password-in-idp>
--os-identity-provider <the-desired-idp-in-keystone>
--os-client-id <the-client-id-configured-in-the-idp>
--os-client-secret <the-client-secred-configured-in-the-idp>
--os-openid-scope <the-scopes-of-desired-attributes-to-claim-from-idp>
--os-protocol <the-protocol-used-in-the-apache2-oidc-proxy>
--os-access-token-type <the-access-token-type-used-by-your-idp>
--os-discovery-endpoint <the-well-known-endpoint-of-the-idp>
For more information on configuring authentication, including an overview of
the many authentication mechanisms supported, refer to the `Authentication
guide`__. For more information on configuration in general, refer to the
`Configuration guide`__.
.. __: https://docs.openstack.org/python-openstackclient/latest/cli/authentication.html.
.. __: https://docs.openstack.org/python-openstackclient/latest/configuration/index.html
Contributing
============
You can clone the repository from opendev.org::
git clone https://opendev.org/openstack/python-openstackclient
cd python-openstackclient
OpenStack Client uses the same contributor process as other OpenStack projects.
For information on this process, including help on setting up you Gerrit
account and an overview of the CI process, refer to the `OpenStack Contributors
Guide`__.
For more information on contributing to OpenStack Client itself, including
guidance on how to design new commands and how to report bugs, refer to the
`Contributors Guide`__.
.. __: https://docs.openstack.org/python-openstackclient/latest/contributor/index.html
.. __: https://docs.opendev.org/opendev/infra-manual/latest/developers.html
Links
-----
* `Issue Tracker <https://bugs.launchpad.net/python-openstackclient>`_
* `Code Review <https://review.opendev.org/#/q/status:open+project:openstack/openstacksdk,n,z>`_
* `Documentation <https://docs.openstack.org/python-openstackclient/latest/>`_
* `PyPi <https://pypi.org/project/python-openstackclient>`_
* `Mailing list <https://lists.openstack.org/mailman3/lists/openstack-discuss.lists.openstack.org/>`_
* `Release Notes <https://docs.openstack.org/releasenotes/python-openstackclient>`_
* `IRC (#openstack-sdks on OFTC (irc.oftc.net)) <irc://irc.oftc.net/openstack-sdks>`_

11
bindep.txt Normal file
View file

@ -0,0 +1,11 @@
# This is a cross-platform list tracking distribution packages needed by tests;
# see https://docs.openstack.org/infra/bindep/ for additional information.
gcc [compile test]
libc6-dev [compile test platform:dpkg]
libffi-devel [platform:rpm]
libffi-dev [compile test platform:dpkg]
libssl-dev [compile test platform:dpkg]
python3-dev [compile test platform:dpkg]
python3-devel [compile test platform:rpm]
libpcre3-dev [test platform:dpkg]

27
doc/requirements.txt Normal file
View file

@ -0,0 +1,27 @@
openstackdocstheme>=2.2.1 # Apache-2.0
reno>=3.1.0 # Apache-2.0
sphinx>=2.0.0,!=2.1.0 # BSD
sphinxcontrib-apidoc>=0.2.0 # BSD
# redirect tests in docs
whereto>=0.4.0 # Apache-2.0
# Install these to generate sphinx autodocs
aodhclient>=0.9.0 # Apache-2.0
gnocchiclient>=3.3.1 # Apache-2.0
osc-placement>=1.7.0 # Apache-2.0
python-barbicanclient>=4.5.2 # Apache-2.0
python-cyborgclient>=1.2.1 # Apache-2.0
python-designateclient>=2.7.0 # Apache-2.0
python-heatclient>=1.10.0 # Apache-2.0
python-ironicclient>=2.3.0 # Apache-2.0
python-ironic-inspector-client>=1.5.0 # Apache-2.0
python-magnumclient>=2.3.0 # Apache-2.0
python-manilaclient>=2.0.0 # Apache-2.0
python-mistralclient!=3.2.0,>=3.1.0 # Apache-2.0
python-neutronclient>=6.7.0 # Apache-2.0
python-octaviaclient>=1.11.0 # Apache-2.0
python-troveclient>=3.1.0 # Apache-2.0
python-watcherclient>=2.5.0 # Apache-2.0
python-zaqarclient>=1.0.0 # Apache-2.0
python-zunclient>=3.6.0 # Apache-2.0

View file

@ -0,0 +1,16 @@
# Redirect docs from the old to new location following the Great Docs Migration of 2017
redirectmatch 301 ^/python-openstackclient/([^/]+)/command-objects/([^/.]+).html$ /python-openstackclient/$1/cli/command-objects/$2.html
redirectmatch 301 ^/python-openstackclient/([^/]+)/(authentication|backward-incompatible|command-list|commands|decoder|interactive).html$ /python-openstackclient/$1/cli/$2.html
redirectmatch 301 ^/python-openstackclient/([^/]+)/plugin-commands.html$ /python-openstackclient/$1/cli/plugin-commands/index.html
redirectmatch 301 ^/python-openstackclient/([^/]+)/specs/([^/.]+).html$ /python-openstackclient/$1/contributor/specs/$2.html
redirectmatch 301 ^/python-openstackclient/([^/]+)/(command-(beta|errors|logs|options|wrappers)|developing|humaninterfaceguide|plugins).html$ /python-openstackclient/$1/contributor/$2.html
redirectmatch 301 ^/python-openstackclient/([^/]+)/cli/plugin-commands.html$ /python-openstackclient/$1/cli/plugin-commands/index.html
# For common subcommand names:
# - identity pages were split into -v2 and -v3
# - image pages were split into -v1 and -v2
# The unversioned page is hidden but contains links to the versioned pages so links in the wild redirect somewhere sane.
redirectmatch 301 ^/python-openstackclient/([^/]+)/cli/command-objects/(ec2-credentials|endpoint|image|project|role|service|token|user).html$ /python-openstackclient/$1/cli/_hidden/$2.html

View file

@ -0,0 +1,13 @@
===============
ec2 credentials
===============
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/ec2-credentials-v2
../command-objects/ec2-credentials-v3

View file

@ -0,0 +1,13 @@
========
endpoint
========
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/endpoint-v2
../command-objects/endpoint-v3

View file

@ -0,0 +1,13 @@
=====
image
=====
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously image v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/image-v1
../command-objects/image-v2

View file

@ -0,0 +1,13 @@
=======
project
=======
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/project-v2
../command-objects/project-v3

View file

@ -0,0 +1,13 @@
====
role
====
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/role-v2
../command-objects/role-v3

View file

@ -0,0 +1,13 @@
=======
service
=======
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/service-v2
../command-objects/service-v3

View file

@ -0,0 +1,13 @@
=====
token
=====
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/token-v2
../command-objects/token-v3

View file

@ -0,0 +1,13 @@
====
user
====
.. NOTE(efried): This page is hidden from the main TOC; it's here so links in
the wild redirect somewhere sane, because previously identity v2 and v3 were
combined in a single page.
.. toctree::
:maxdepth: 2
../command-objects/user-v2
../command-objects/user-v3

View file

@ -0,0 +1,377 @@
.. _authentication:
==============
Authentication
==============
OpenStackClient leverages `python-keystoneclient`_ authentication
plugins to support a number of different authentication methods.
.. _`python-keystoneclient`: https://docs.openstack.org/python-keystoneclient/latest/using-sessions.html#sharing-authentication-plugins
Authentication Process
----------------------
The user provides some number of authentication credential options.
If an authentication type is not provided (``--os-auth-type``), the
authentication options are examined to determine if one of the default
types can be used. If no match is found an error is reported and OSC exits.
Note that the authentication call to the Identity service has not yet
occurred. It is deferred until the last possible moment in order to
reduce the number of unnecessary queries to the server, such as when further
processing detects an invalid command.
Authentication Plugins
----------------------
The Keystone client library implements the base set of plugins. Additional
plugins may be available from the Keystone project or other sources.
There are at least three authentication types that are always available:
* **Password**: A project, username and password are used to identify the
user. An optional domain may also be included. This is the most common
type and is the default any time a username is supplied. An authentication
URL for the Identity service is also required. [Required: ``--os-auth-url``,
``--os-project-name``, ``--os-username``; Optional: ``--os-password``]
* **Token**: This is slightly different from the usual token authentication
in that a token and an authentication
URL are supplied and the plugin retrieves a new token.
[Required: ``--os-auth-url``, ``--os-token``]
* **Others**: Other authentication plugins such as SAML, Kerberos, and OAuth1.0
are under development and also supported. To use them, they must be selected
by supplying the ``--os-auth-type`` option.
Detailed Process
----------------
The authentication process in OpenStackClient is all contained in and handled
by the ``ClientManager`` object.
* On import ``api.auth``:
* obtains the list of installed Keystone authentication
plugins from the ``keystoneclient.auth.plugin`` entry point.
* builds a list of authentication options from the plugins.
* The command line arguments are processed and a configuration is loaded from
:file:`clouds.yaml` if ``--os-cloud`` is provided.
* A new ``ClientManager`` is created and supplied with the set of options from the
command line, environment and/or :file:`clouds.yaml`:
* If ``--os-auth-type`` is provided and is a valid and available plugin
it is used.
* If ``--os-auth-type`` is not provided an authentication plugin
is selected based on the existing options. This is a short-circuit
evaluation, the first match wins.
* If ``--os-username`` is supplied ``password`` is selected
* If ``--os-token`` is supplied ``token`` is selected
* If no selection has been made by now exit with error
* Load the selected plugin class.
* When an operation that requires authentication is attempted ``ClientManager``
makes the actual initial request to the Identity service.
* if ``--os-auth-url`` is not supplied for any of the types except
Token/Endpoint, exit with an error.
Authenticating using Identity Server API v3
-------------------------------------------
To authenticate against an Identity Server API v3, the
``OS_IDENTITY_API_VERSION`` environment variable or
``--os-identity-api-version`` option must be changed to ``3``, instead of the
default ``2.0``. Similarly ``OS_AUTH_URL`` or ``os-auth-url`` should also be
updated.
.. code-block:: bash
$ export OS_IDENTITY_API_VERSION=3 (Defaults to 2.0)
$ export OS_AUTH_URL=http://localhost:5000/v3
Since Identity API v3 authentication is a bit more complex, there are additional
options that may be set, either as command line options or environment
variables. The most common case will be a user supplying both user name and
password, along with the project name; previously in v2.0 this would be
sufficient, but since the Identity API v3 has a ``Domain`` component, we need
to tell the client in which domain the user and project exists.
If using a user name and password to authenticate, specify either it's owning
domain name or ID.
* ``--os-user-domain-name`` or ``OS_USER_DOMAIN_NAME``
* ``--os-user-domain-id`` or ``OS_USER_DOMAIN_ID``
If using a project name as authorization scope, specify either it's owning
domain name or ID.
* ``--os-project-domain-name`` or ``OS_PROJECT_DOMAIN_NAME``
* ``--os-project-domain-id`` or ``OS_PROJECT_DOMAIN_ID``
If using a domain as authorization scope, set either it's name or ID.
* ``--os-domain-name`` or ``OS_DOMAIN_NAME``
* ``--os-domain-id`` or ``OS_DOMAIN_ID``
Note that if the user and project share the same domain, then simply setting
``--os-default-domain`` or ``OS_DEFAULT_DOMAIN`` to the domain ID is sufficient.
Thus, a minimal set of environment variables would be:
.. code-block:: bash
$ export OS_IDENTITY_API_VERSION=3
$ export OS_AUTH_URL=http://localhost:5000/v3
$ export OS_DEFAULT_DOMAIN=default
$ export OS_USERNAME=admin
$ export OS_PASSWORD=secret
$ export OS_PROJECT_NAME=admin
Federated users support
-----------------------
The OpenStackClient also allows the use of Federated users to log in.
It enables one to use the identity providers credentials such as Google or
Facebook to log in the OpenStackClient instead of using the Keystone
credentials.
This is useful in a Federated environment where one credential give access
to many applications/services that the Federation supports. To check how to
configure the OpenStackClient to allow Federated users to log in, please check
the :ref:`Authentication using federation. <manpage>`
Examples
--------
.. todo: It would be nice to add more examples here, particularly for
complicated things like oauth2
``v3password``
~~~~~~~~~~~~~~
Using ``clouds.yaml``:
.. code-block:: yaml
clouds:
demo:
auth:
auth_url: http://openstack.dev/identity
project_name: demo
project_domain_name: default
user_domain_name: default
username: demo
password: password
auth_type: v3password
or, using command line options:
.. code-block:: bash
$ openstack \
--os-auth-url "http://openstack.dev/identity" \
--os-project-name demo \
--os-project-domain-name default \
--os-user-domain-name default \
--os-auth-type=v3password \
--os-username demo \
--os-password password \
server list
or, using environment variables:
.. code-block:: bash
$ export OS_AUTH_URL="http://openstack.dev/identity"
$ export OS_PROJECT_NAME=demo
$ export OS_PROJECT_DOMAIN_NAME=default
$ export OS_AUTH_TYPE=v3password
$ export OS_USERNAME=demo
$ export OS_PASSWORD=password
$ openstack server list
.. note::
If a password is not provided, you will be prompted for one.
``v3applicationcredential``
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Using ``clouds.yaml``:
.. code-block:: yaml
clouds:
demo:
auth:
auth_url: http://openstack.dev/identity
application_credential_id: ${APP_CRED_ID}
application_credential_secret: ${APP_CRED_SECRET}
auth_type: v3applicationcredential
or, using command line options:
.. code-block:: bash
$ openstack \
--os-auth-url "http://openstack.dev/identity" \
--os-auth-type=v3applicationcredential \
--os-application-credential-id=${APP_CRED_ID} \
--os-application-credential-secret=${APP_CRED_SECRET}
server list
or, using environment variables:
.. code-block:: bash
$ export OS_AUTH_URL="http://openstack.dev/identity"
$ export OS_AUTH_TYPE=v3applicationcredential
$ export OS_APPLICATION_CREDENTIAL_ID=${APP_CRED_ID}
$ export OS_APPLICATION_CREDENTIAL_SECRET=${APP_CRED_SECRET}
$ openstack server list
.. note::
You can generate application credentials using the :program:`openstack
application credential create` command:
.. code-block:: bash
$ readarray -t lines <<< $(openstack application credential create test -f value -c id -c secret)
$ APP_CRED_ID=${lines[0]}
$ APP_CRED_SECRET=${lines[1]}
``v3token``
~~~~~~~~~~~
Using ``clouds.yaml``:
.. code-block:: yaml
clouds:
demo:
auth:
auth_url: http://openstack.dev/identity
project_name: demo
project_domain_name: default
token: ${TOKEN}
auth_type: v3token
or, using command line options:
.. code-block:: bash
$ openstack \
--os-auth-url "http://openstack.dev/identity" \
--os-project-name demo \
--os-project-domain-name default \
--os-auth-type=v3token \
--os-token ${TOKEN} \
server list
or, using environment variables:
.. code-block:: bash
$ export OS_AUTH_URL="http://openstack.dev/identity"
$ export OS_PROJECT_NAME=demo
$ export OS_PROJECT_DOMAIN_NAME=default
$ export OS_AUTH_TYPE=v3token
$ export OS_TOKEN=${TOKEN}
$ openstack server list
.. note::
You can generate tokens using the :program:`openstack token issue` command:
.. code-block:: bash
$ TOKEN=$(openstack token issue -f value -c id)
.. note::
The above examples assume you require a project-scoped token. You can omit
the project-related configuration if your user has a default project ID set.
Conversely, if requesting domain-scoped or system-scoped, you should update
these examples accordingly. If the user does not have a default project
configured and no scoping information is provided, the resulting token will
be unscoped.
``v3totp``
~~~~~~~~~~
.. note::
The TOTP mechanism is poorly suited to command line-driven API
interactions. Where the TOTP mechanism is configured for a cloud, it is
expected that it is to be used for initial authentication and to create a
token or application credential, which can then be used for future
interactions.
.. note::
The TOTP mechanism is often combined with other mechanisms to enable
Multi-Factor Authentication, or MFA. The authentication type
``v3multifactor`` is used in this case, while the ``v3totp`` authentication
type is specified alongside the other mechanisms in ``auth_methods``.
Using ``clouds.yaml``:
.. code-block:: yaml
clouds:
demo:
auth:
auth_url: http://openstack.dev/identity
project_name: demo
project_domain_name: default
user_domain_name: default
username: demo
passcode: ${PASSCODE}
auth_type: v3totp
or, using command line options:
.. code-block:: bash
$ openstack \
--os-auth-url "http://openstack.dev/identity" \
--os-project-name demo \
--os-project-domain-name default \
--os-user-domain-name default \
--os-auth-type=v3totp \
--os-username demo \
--os-passcode ${PASSCODE} \
server list
or, using environment variables:
.. code-block:: bash
$ export OS_AUTH_URL="http://openstack.dev/identity"
$ export OS_PROJECT_NAME=demo
$ export OS_PROJECT_DOMAIN_NAME=default
$ export OS_AUTH_TYPE=v3totp
$ export OS_USERNAME=demo
$ export OS_PASSCODE=${PASSCODE}
$ openstack server list
.. note::
The passcode will be generated by an authenticator application such FreeOTP
or Google Authenticator. Refer to your cloud provider's documentation for
information on how to configure an authenticator application, or to the
`Keystone documentation`__ if you are configuring this for your own cloud.
.. __: https://docs.openstack.org/keystone/latest/admin/auth-totp.html
.. note::
If a passcode is not provided, you will be prompted for one.

View file

@ -0,0 +1,392 @@
==============================
Backwards Incompatible Changes
==============================
Despite our best efforts, sometimes the OpenStackClient team may introduce a
backwards incompatible change. For user convenience we are tracking any such
changes here (as of the 1.0.0 release).
Should positional arguments for a command need to change, the OpenStackClient
team attempts to make the transition as painless as possible. Look for
deprecation warnings that indicate the new commands (or options) to use.
Commands labeled as a beta according to :ref:`command-beta` are exempt
from this backwards incompatible change handling.
Backwards Incompatible Changes
==============================
Release 4.0
-----------
1. Remove ``ip fixed add|remove`` commands.
Use ``server add|remove fixed ip`` commands instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612781
2. Remove ``ip floating add|remove`` commands.
Use ``server add|remove floating ip`` commands instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612781
3. Remove ``service create`` option ``--type``. Service type is
a positional argument.
* Removed in: 4.0
* Commit: https://review.opendev.org/612798
4. Remove ``role list`` options ``--project`` and ``--user``.
Use ``role assignment list`` options ``--project`` and ``--user`` instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612798
5. Remove ``user role list`` command.
Use ``role assignment list`` options ``--project`` and ``--user`` instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612798
6. Remove ``image create|set`` option ``--owner``.
Use ``--project`` option instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/659431
7. Remove ``port create|set`` options ``--device-id`` and ``--host-id``.
Use ``--device`` and ``--host`` instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/613644
8. Remove ``router set`` option ``--clear-routes``.
Use ``no-route`` option instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/613644
9. Remove ``security group rule create`` options ``--src-ip`` and ``--src-group``.
Use ``--remote-ip`` and ``--remote-group`` options instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/613644
10. Remove ``backup`` commands.
Use ``volume backup`` commands instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612751
11. Remove ``snapshot`` commands.
Use ``volume snapshot`` commands instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/612751
12. Remove ``volume create`` options ``--project``, ``--user``, ``--multi-attach``.
* Removed in: 4.0
* Commit: https://review.opendev.org/612751
13. Change ``volume transfer request accept`` to use new option ``--auth-key``
rather than a second positional argument.
* Removed in: 4.0
* Commit: https://review.opendev.org/612751
14. Remove 'Token/Endpoint' auth plugin support (type ``token_endpoint``).
This remained as a compatibility for the ``admin_token`` auth type to
support the ``--url`` global option. That option is also now removed,
use ``--endpoint`` instead.
* Removed in: 4.0
* Commit: https://review.opendev.org/<tbd>
Release 3.12
------------
1. Replace ``Display Name`` by ``Name`` in volume list.
Change column name ``Display Name`` to ``Name`` in ``volume list`` output.
Current ``volume list --name`` command uses ``display_name`` as search_opts
to send to cinder API, and show the result table with ``Display Name``
as column title. Replace all ``Display Name`` by ``Name`` to be consistent
with other list commands.
Support a mapping for volume list -c ``Display Name`` (Volume v1 and v2)
and volume create/show -c ``display_name`` (Volume v1) to maintain backward
compatibility until the next major release.
* In favor of: ``openstack volume list -c Name``
* As of: 3.12.0
* Removed in: n/a
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1657956
* Commit: https://review.opendev.org/#/c/423081/
Release 3.10
------------
1. The ``network create`` command now requires the ``--subnet`` option when used
with nova-network clouds.
* As of: 3.10
* Commit: https://review.opendev.org/460679
2. The positional argument ``<snapshot-name>`` of the ``volume snapshot create``
command is no longer optional.
Previously when the ``--volume`` option was
present ``<snapshot-name>`` defaulted to the ``--volume`` value. When the
``--volume`` option is not present now it defaults to the value of
``<snapshot-name>``.
* As of: 3.10
* Bug: 1659894
* Commit: https://review.opendev.org/440497
Release 3.0
-----------
1. Remove the ``osc_password`` authentication plugin.
This was the 'last-resort' plugin default that worked around an old default
Keystone configuration for the ``admin_endpoint`` and ``public_endpoint``.
* In favor of: ``password``
* As of: 3.0
* Removed in: n/a
* Bug: n/a
* Commit: https://review.opendev.org/332938
Releases Before 3.0
-------------------
1. Rename command `openstack project usage list`
The `project` part of the command was pointless.
* In favor of: `openstack usage list` instead.
* As of: 1.0.2
* Removed in: TBD
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1406654
* Commit: https://review.opendev.org/#/c/147379/
2. <type> should not be optional for command `openstack service create`
Previously, the command was `openstack service create <name> --type <type>`,
whereas now it is: `openstack service create <type> --name <name>`.
This bug also affected python-keystoneclient, and keystone.
* In favor of: making <type> a positional argument.
* As of: 1.0.2
* Removed in: TBD
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1404073
* Commit: https://review.opendev.org/#/c/143242/
3. Command `openstack security group rule delete` now requires rule id
Previously, the command was `openstack security group rule delete --proto
<proto> [--src-ip <ip-address> --dst-port <port-range>] <group>`,
whereas now it is: `openstack security group rule delete <rule>`.
* In favor of: Using `openstack security group rule delete <rule>`.
* As of: 1.2.1
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1450872
* Commit: https://review.opendev.org/#/c/179446/
4. Command `openstack image create` does not update already existing image
Previously, the image create command updated already existing image if it had
same name. It disabled possibility to create multiple images with same name
and lead to potentially unwanted update of existing images by image create
command.
Now, update code was moved from create action to set action.
* In favor of: Create multiple images with same name (as glance does).
* As of: 1.5.0
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1461817
* Commit: https://review.opendev.org/#/c/194654/
5. Command `openstack network list --dhcp` has been removed
The --dhcp option to network list is not a logical use case of listing
networks, it lists agents. Another command should be added in the future
to provide this functionality. It is highly unlikely anyone uses this
feature as we don't support any other agent commands. Use neutron
dhcp-agent-list-hosting-net command instead.
* In favor of: Create network agent list command in the future
* As of: 1.6.0
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/472613
* Commit: https://review.opendev.org/#/c/194654/
6. Plugin interface change for default API versions
Previously, the default version was set in the parsed arguments,
but this makes it impossible to tell what has been passed in at the
command line, set in an environment variable or is just the default.
Now, the module should have a DEFAULT_API_VERSION that contains the
value and it will be set after command line argument, environment
and OCC file processing.
* In favor of: DEFAULT_API_VERSION
* As of: 1.2.1
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1453229
* Commit: https://review.opendev.org/#/c/181514/
7. `image set` commands will no longer return the modified resource
Previously, modifying an image would result in the new image being displayed
to the user. To keep things consistent with other `set` commands, we will
no longer be showing the modified resource.
* In favor of: Use `set` then `show`
* As of: NA
* Removed in: NA
* Bug: NA
* Commit: NA
8. `region` commands no longer support `url`
The Keystone team removed support for the `url` attribute from the client
and server side. Changes to the `create`, `set` and `list` commands for
regions have been affected.
* In favor of: NA
* As of 1.9.0
* Removed in: NA
* Bug: https://launchpad.net/bugs/1506841
* Commit: https://review.opendev.org/#/c/236736/
9. `flavor set/unset` commands will no longer return the modified resource
Previously, modifying a flavor would result in the new flavor being displayed
to the user. To keep things consistent with other `set/unset` commands, we
will no longer be showing the modified resource.
* In favor of: Use `set/unset` then `show`
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.opendev.org/#/c/280663/
10. `security group set` commands will no longer return the modified resource
Previously, modifying a security group would result in the new security group
being displayed to the user. To keep things consistent with other `set`
commands, we will no longer be showing the modified resource.
* In favor of: Use `set` then `show`
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.opendev.org/#/c/281087/
11. `compute agent set` commands will no longer return the modified resource
Previously, modifying an agent would result in the new agent being displayed
to the user. To keep things consistent with other `set` commands, we will
no longer be showing the modified resource.
* In favor of: Use `set` then `show`
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.opendev.org/#/c/281088/
12. `<version> <url> <md5hash>` should be optional for command `openstack
compute agent set`
Previously, the command was `openstack compute agent set <id> <version> <url>
<md5hash>`, whereas now it is: `openstack compute agent set <id> --version
<version> --url <url> --md5hash <md5hash>`.
* In favor of: making <version> <url> <md5hash> optional.
* As of: NA
* Removed in: NA
* Bug: NA
* Commit: https://review.opendev.org/#/c/328819/
13. `aggregate set` commands will no longer return the modified resource
Previously, modifying an aggregate would result in the new aggregate being
displayed to the user. To keep things consistent with other `set` commands,
we will no longer be showing the modified resource.
* In favor of: Use `set` then `show`
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.opendev.org/#/c/281089/
14. Output of `ip floating list` command has changed.
When using Compute v2, the original output is:
.. code-block:: bash
# ip floating list
+----+--------+------------+----------+-------------+
| ID | Pool | IP | Fixed IP | Instance ID |
+----+--------+-----------------------+-------------+
| 1 | public | 172.24.4.1 | None | None |
+----+--------+------------+----------+-------------+
Now it changes to:
.. code-block:: bash
# ip floating list
+----+---------------------+------------------+-----------+--------+
| ID | Floating IP Address | Fixed IP Address | Server ID | Pool |
+----+---------------------+------------------+-----------+--------+
| 1 | 172.24.4.1 | None | None | public |
+----+---------------------+------------------+-----------+--------+
When using Network v2, which is different from Compute v2. The output is:
.. code-block:: bash
# ip floating list
+--------------------------------------+---------------------+------------------+------+
| ID | Floating IP Address | Fixed IP Address | Port |
+--------------------------------------+---------------------+------------------+------+
| 1976df86-e66a-4f96-81bd-c6ffee6407f1 | 172.24.4.3 | None | None |
+--------------------------------------+---------------------+------------------+------+
* In favor of: Use `ip floating list` command
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1519502
* Commit: https://review.opendev.org/#/c/277720/
For Developers
==============
If introducing a backwards incompatible change, then add the tag:
``BackwardsIncompatibleImpact`` to your git commit message, and if possible,
update this file.
To review all changes that are affected, use the following query:
https://review.opendev.org/#/q/project:openstack/python-openstackclient+AND+message:BackwardsIncompatibleImpact,n,z

View file

@ -0,0 +1,11 @@
.. _command-list:
============
Command List
============
.. toctree::
:glob:
:maxdepth: 2
command-objects/*

View file

@ -0,0 +1,19 @@
===========
access rule
===========
Identity v3
Access rules are fine-grained permissions for application credentials. An access
rule comprises of a service type, a request path, and a request method. Access
rules may only be created as attributes of application credentials, but they may
be viewed and deleted independently.
.. autoprogram-cliff:: openstack.identity.v3
:command: access rule delete
.. autoprogram-cliff:: openstack.identity.v3
:command: access rule list
.. autoprogram-cliff:: openstack.identity.v3
:command: access rule show

View file

@ -0,0 +1,10 @@
============
access token
============
An **access token** is used by the Identity service's OS-OAUTH1 extension. It
is used by the **consumer** to request new Identity API tokens on behalf of the
authorizing **user**. Applicable to Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: access token create

View file

@ -0,0 +1,12 @@
=============
address group
=============
An **address group** is a group of IPv4 or IPv6 address blocks which could be
referenced as a remote source or destination when creating a security group
rule.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: address group *

View file

@ -0,0 +1,11 @@
=============
address scope
=============
An **address scope** is a scope of IPv4 or IPv6 addresses that belongs
to a given project and may be shared between projects.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: address scope *

View file

@ -0,0 +1,11 @@
=========
aggregate
=========
Host aggregates provide a mechanism to group hosts according to certain
criteria.
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: aggregate *

View file

@ -0,0 +1,13 @@
======================
application credential
======================
Identity v3
With application credentials, a user can grant their applications limited
access to their cloud resources. Once created, users can authenticate with an
application credential by using the ``v3applicationcredential`` auth type.
.. autoprogram-cliff:: openstack.identity.v3
:command: application credential *

View file

@ -0,0 +1,11 @@
=================
availability zone
=================
An **availability zone** is a logical partition of cloud block storage,
compute and network services.
Block Storage v2, Compute v2, Network v2
.. autoprogram-cliff:: openstack.common
:command: availability zone list

View file

@ -0,0 +1,8 @@
=============
block storage
=============
Block Storage v3
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage cleanup

View file

@ -0,0 +1,8 @@
=====================
block storage cluster
=====================
Block Storage v3
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage cluster *

View file

@ -0,0 +1,8 @@
=======================
Block Storage Log Level
=======================
Block Storage v3
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage log level *

View file

@ -0,0 +1,11 @@
====================
Block Storage Manage
====================
Block Storage v3
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage volume manageable list
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage snapshot manageable list

View file

@ -0,0 +1,8 @@
=============================
block storage resource filter
=============================
Block Storage v3
.. autoprogram-cliff:: openstack.volume.v3
:command: block storage resource filter *

View file

@ -0,0 +1,9 @@
=======
catalog
=======
A **catalog** lists OpenStack services that are available on the cloud.
Applicable to Identity v2 and v3
.. autoprogram-cliff:: openstack.identity.v3
:command: catalog *

View file

@ -0,0 +1,10 @@
=======
command
=======
Internal
Installed commands in the OSC process.
.. autoprogram-cliff:: openstack.cli
:command: command *

View file

@ -0,0 +1,28 @@
========
complete
========
The ``complete`` command is inherited from the `python-cliff` library, it can
be used to generate a bash-completion script. Currently, the command will
generate a script for bash versions 3 or 4. The bash-completion script is
printed directly to standard out.
Typical usage for this command is::
openstack complete | sudo tee /etc/bash_completion.d/osc.bash_completion > /dev/null
It is highly recommended to install ``python-openstackclient`` from a package
(``apt-get`` or ``yum``). In some distributions the package ``bash-completion`` is shipped
as dependency, and the `openstack complete` command will be run as a post-install action,
however not every distribution include this dependency and you might need to install
``bash-completion`` package to enable autocomplete feature.
complete
--------
print bash completion command
.. program:: complete
.. code:: bash
openstack complete

View file

@ -0,0 +1,8 @@
=============
compute agent
=============
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: compute agent *

View file

@ -0,0 +1,8 @@
===============
compute service
===============
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: compute service *

View file

@ -0,0 +1,10 @@
=============
configuration
=============
Available for all services
.. _configuration-show:
.. autoprogram-cliff:: openstack.common
:command: configuration show

View file

@ -0,0 +1,17 @@
==========================
consistency group snapshot
==========================
Block Storage v2, v3
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group snapshot create
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group snapshot delete
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group snapshot list
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group snapshot show

View file

@ -0,0 +1,26 @@
=================
consistency group
=================
Block Storage v2, v3
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group add volume
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group create
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group delete
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group list
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group remove volume
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group set
.. autoprogram-cliff:: openstack.volume.v3
:command: consistency group show

View file

@ -0,0 +1,10 @@
==================
console connection
==================
Server console connection information
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: console connection show

View file

@ -0,0 +1,10 @@
===========
console log
===========
Server console text dump
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: console log *

View file

@ -0,0 +1,10 @@
===========
console url
===========
Server remote console URL
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: console url *

View file

@ -0,0 +1,10 @@
========
consumer
========
An **consumer** is used by the Identity service's OS-OAUTH1 extension. It
is used to create a **request token** and **access token**. Applicable to
Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: consumer *

View file

@ -0,0 +1,26 @@
=========
container
=========
A **container** defines a namespace for **objects**. Applies to Object Storage v1
.. autoprogram-cliff:: openstack.object_store.v1
:command: container create
.. autoprogram-cliff:: openstack.object_store.v1
:command: container delete
.. autoprogram-cliff:: openstack.object_store.v1
:command: container list
.. autoprogram-cliff:: openstack.object_store.v1
:command: container save
.. autoprogram-cliff:: openstack.object_store.v1
:command: container set
.. autoprogram-cliff:: openstack.object_store.v1
:command: container show
.. autoprogram-cliff:: openstack.object_store.v1
:command: container unset

View file

@ -0,0 +1,8 @@
==========
credential
==========
Identity v3
.. autoprogram-cliff:: openstack.identity.v3
:command: credential *

View file

@ -0,0 +1,11 @@
===========================
default security group rule
===========================
A **default security group rule** specifies the template of the security group
rules which will be used by neutron to create rules in every new security group.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: default security group rule *

View file

@ -0,0 +1,22 @@
======
domain
======
A **domain** is a collection of **users**, **groups**, and **projects**. Each
**group** and **project** is owned by exactly one **domain**. Applies to
Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: domain create
.. autoprogram-cliff:: openstack.identity.v3
:command: domain delete
.. autoprogram-cliff:: openstack.identity.v3
:command: domain list
.. autoprogram-cliff:: openstack.identity.v3
:command: domain set
.. autoprogram-cliff:: openstack.identity.v3
:command: domain show

View file

@ -0,0 +1,6 @@
=============================
ec2 credentials (Identity v2)
=============================
.. autoprogram-cliff:: openstack.identity.v2
:command: ec2 credentials *

View file

@ -0,0 +1,6 @@
=============================
ec2 credentials (Identity v3)
=============================
.. autoprogram-cliff:: openstack.identity.v3
:command: ec2 credentials *

View file

@ -0,0 +1,6 @@
======================
endpoint (Identity v2)
======================
.. autoprogram-cliff:: openstack.identity.v2
:command: endpoint *

View file

@ -0,0 +1,24 @@
======================
endpoint (Identity v3)
======================
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint add project
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint create
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint delete
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint list
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint remove project
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint set
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint show

View file

@ -0,0 +1,10 @@
==============
endpoint group
==============
A **endpoint group** is used to create groups of endpoints that then
can be used to filter the endpoints that are available to a project.
Applicable to Identity v3
.. autoprogram-cliff:: openstack.identity.v3
:command: endpoint group *

View file

@ -0,0 +1,10 @@
=========
extension
=========
Many OpenStack server APIs include API extensions that enable
additional functionality.
.. autoprogram-cliff:: openstack.common
:command: extension *

View file

@ -0,0 +1,11 @@
=========================
federation domain/project
=========================
Identity v3
.. autoprogram-cliff:: openstack.identity.v3
:command: federation domain *
.. autoprogram-cliff:: openstack.identity.v3
:command: federation project *

View file

@ -0,0 +1,10 @@
===================
federation protocol
===================
A **federation protocol** is used by the Identity service's OS-FEDERATION
extension. It is used by **identity providers** and **mappings**. Applicable to
Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: federation protocol *

View file

@ -0,0 +1,8 @@
======
flavor
======
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: flavor *

View file

@ -0,0 +1,8 @@
================
floating ip pool
================
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip pool *

View file

@ -0,0 +1,9 @@
===========================
floating ip port forwarding
===========================
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip port forwarding *

View file

@ -0,0 +1,26 @@
===========
floating ip
===========
Network v2
.. NOTE(efried): have to list these out one by one; 'floating ip' pulls in
... pool and ... port forwarding.
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip create
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip delete
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip list
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip set
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip show
.. autoprogram-cliff:: openstack.network.v2
:command: floating ip unset

View file

@ -0,0 +1,8 @@
=====
group
=====
Identity v3
.. autoprogram-cliff:: openstack.identity.v3
:command: group *

View file

@ -0,0 +1,10 @@
====
host
====
Compute v2
The physical computer running a hypervisor.
.. autoprogram-cliff:: openstack.compute.v2
:command: host *

View file

@ -0,0 +1,8 @@
================
hypervisor stats
================
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: hypervisor stats *

View file

@ -0,0 +1,14 @@
==========
hypervisor
==========
Compute v2
.. NOTE(efried): have to list these out one by one; 'hypervisor *' pulls in
... stats.
.. autoprogram-cliff:: openstack.compute.v2
:command: hypervisor list
.. autoprogram-cliff:: openstack.compute.v2
:command: hypervisor show

View file

@ -0,0 +1,10 @@
=================
identity provider
=================
An **identity provider** is used by the Identity service's OS-FEDERATION
extension. It is used by **federation protocols** and **mappings**. Applicable
to Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: identity provider *

View file

@ -0,0 +1,14 @@
============
image member
============
Image v2
.. autoprogram-cliff:: openstack.image.v2
:command: image add project
.. autoprogram-cliff:: openstack.image.v2
:command: image remove project
.. autoprogram-cliff:: openstack.image.v2
:command: image member list

View file

@ -0,0 +1,50 @@
=============
image metadef
=============
Image v2
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef namespace create
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef namespace delete
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef namespace list
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef namespace set
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef namespace show
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef resource type list
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object create
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object show
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object list
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object delete
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object update
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef object property show
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef property create
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef property list
.. autoprogram-cliff:: openstack.image.v2
:command: image metadef property show

View file

@ -0,0 +1,11 @@
==========
image task
==========
Image v2
.. autoprogram-cliff:: openstack.image.v2
:command: image task list
.. autoprogram-cliff:: openstack.image.v2
:command: image task show

View file

@ -0,0 +1,6 @@
========
image v1
========
.. autoprogram-cliff:: openstack.image.v1
:command: image *

View file

@ -0,0 +1,32 @@
=====
image
=====
Image v2
.. autoprogram-cliff:: openstack.image.v2
:command: image create
.. autoprogram-cliff:: openstack.image.v2
:command: image delete
.. autoprogram-cliff:: openstack.image.v2
:command: image list
.. autoprogram-cliff:: openstack.image.v2
:command: image save
.. autoprogram-cliff:: openstack.image.v2
:command: image set
.. autoprogram-cliff:: openstack.image.v2
:command: image unset
.. autoprogram-cliff:: openstack.image.v2
:command: image show
.. autoprogram-cliff:: openstack.image.v2
:command: image stage
.. autoprogram-cliff:: openstack.image.v2
:command: image import

View file

@ -0,0 +1,8 @@
============
implied role
============
Identity v3
.. autoprogram-cliff:: openstack.identity.v3
:command: implied role *

View file

@ -0,0 +1,8 @@
===============
ip availability
===============
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: ip availability *

View file

@ -0,0 +1,13 @@
=======
keypair
=======
The badly named keypair is really the public key of an OpenSSH key pair to be
used for access to created servers. You can also create a private key for
access to a created server by not passing any argument to the keypair create
command.
Compute v2
.. autoprogram-cliff:: openstack.compute.v2
:command: keypair *

View file

@ -0,0 +1,10 @@
=====
limit
=====
Identity v3
Limits are used to specify project-specific limits thresholds of resources.
.. autoprogram-cliff:: openstack.identity.v3
:command: limit *

View file

@ -0,0 +1,11 @@
======
limits
======
The Compute and Block Storage APIs have resource usage limits.
Block Storage v2, v3; Compute v2
.. autoprogram-cliff:: openstack.common
:command: limits *

View file

@ -0,0 +1,11 @@
=============================================
Local IP Associations (local_ip_associations)
=============================================
The resource lets users assign Local IPs to user Ports.
This is a sub-resource of the Local IP resource.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: local ip association *

View file

@ -0,0 +1,12 @@
=====================
Local IPs (local_ips)
=====================
Extension that allows users to create a virtual IP that can later be assigned
to multiple ports/VMs (similar to anycast IP) and is guaranteed to only be
reachable within the same physical server/node boundaries
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: local ip *

View file

@ -0,0 +1,10 @@
=======
mapping
=======
A **mapping** is used by the Identity service's OS-FEDERATION
extension. It is used by **federation protocols** and **identity providers**.
Applicable to Identity v3.
.. autoprogram-cliff:: openstack.identity.v3
:command: mapping *

View file

@ -0,0 +1,10 @@
======
module
======
Internal
Installed Python modules in the OSC process.
.. autoprogram-cliff:: openstack.cli
:command: module *

View file

@ -0,0 +1,14 @@
=============
network agent
=============
A **network agent** is an agent that handles various tasks used to
implement virtual networks. These agents include neutron-dhcp-agent,
neutron-l3-agent, neutron-metering-agent, and neutron-lbaas-agent,
among others. The agent is available when the alive status of the
agent is "True".
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network agent *

View file

@ -0,0 +1,14 @@
===============================
network auto allocated topology
===============================
An **auto allocated topology** allows admins to quickly set up external
connectivity for end-users. Only one auto allocated topology is allowed per
project. For more information on how to set up the resources required
for auto allocated topology review :neutron-doc:`the documentation
<admin/config-auto-allocation>`.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network auto allocated topology *

View file

@ -0,0 +1,15 @@
======================
network flavor profile
======================
A **network flavor profile** allows administrators to create, delete, list,
show and update network service profile, which details a framework to enable
operators to configure and users to select from different abstract
representations of a service implementation in the Networking service.
It decouples the logical configuration from its instantiation enabling
operators to create user options according to deployment needs.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor profile *

View file

@ -0,0 +1,33 @@
==============
network flavor
==============
A **network flavor** extension allows the user selection of operator-curated
flavors during resource creations. It allows administrators to create network
service flavors.
Network v2
.. NOTE(efried): have to list these out one by one; 'network flavor' pulls in
... profile *.
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor add profile
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor create
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor delete
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor list
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor remove profile
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor set
.. autoprogram-cliff:: openstack.network.v2
:command: network flavor show

View file

@ -0,0 +1,8 @@
===========================
network l3 conntrack helper
===========================
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network l3 conntrack helper *

View file

@ -0,0 +1,13 @@
==================
network meter rule
==================
A **meter rule** sets the rule for
a meter to measure traffic for a specific IP range.
The following uses **meter** and requires the L3
metering extension.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network meter rule *

View file

@ -0,0 +1,24 @@
=============
network meter
=============
A **network meter** allows operators to measure
traffic for a specific IP range. The following commands
are specific to the L3 metering extension.
Network v2
.. NOTE(efried): have to list these out one by one; 'network meter *' pulls in
... rule *.
.. autoprogram-cliff:: openstack.network.v2
:command: network meter create
.. autoprogram-cliff:: openstack.network.v2
:command: network meter delete
.. autoprogram-cliff:: openstack.network.v2
:command: network meter list
.. autoprogram-cliff:: openstack.network.v2
:command: network meter show

View file

@ -0,0 +1,11 @@
==================
network qos policy
==================
A **Network QoS policy** groups a number of Network QoS rules, applied to a
network or a port.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network qos policy *

View file

@ -0,0 +1,11 @@
=====================
network qos rule type
=====================
A **Network QoS rule type** is a specific Network QoS rule type available to be
used.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule type *

View file

@ -0,0 +1,28 @@
================
network qos rule
================
A **Network QoS rule** specifies a rule defined in a Network QoS policy; its
type is defined by the parameter 'type'. Can be assigned, within a Network QoS
policy, to a port or a network. Each Network QoS policy can contain several
rules, each of them
Network v2
.. NOTE(efried): have to list these out one by one; 'network qos rule *' pulls
network qos rule type *.
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule create
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule delete
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule list
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule set
.. autoprogram-cliff:: openstack.network.v2
:command: network qos rule show

View file

@ -0,0 +1,12 @@
============
network rbac
============
A **network rbac** is a Role-Based Access Control (RBAC) policy for
network resources. It enables both operators and users to grant access
to network resources for specific projects.
Network v2
.. autoprogram-cliff:: openstack.network.v2
:command: network rbac *

View file

@ -0,0 +1,28 @@
===============
network segment
===============
A **network segment** is an isolated Layer 2 segment within a network.
A network may contain multiple network segments. Depending on the
network configuration, Layer 2 connectivity between network segments
within a network may not be guaranteed.
Network v2
.. NOTE(efried): have to list these out one by one; 'network segment *' pulls
... range *.
.. autoprogram-cliff:: openstack.network.v2
:command: network segment create
.. autoprogram-cliff:: openstack.network.v2
:command: network segment delete
.. autoprogram-cliff:: openstack.network.v2
:command: network segment list
.. autoprogram-cliff:: openstack.network.v2
:command: network segment set
.. autoprogram-cliff:: openstack.network.v2
:command: network segment show

View file

@ -0,0 +1,13 @@
========================
network service provider
========================
A **network service provider** is a particular driver that implements a
networking service
Network v2
.. _network_service_provider_list:
.. autoprogram-cliff:: openstack.network.v2
:command: network service provider list

Some files were not shown because too many files have changed in this diff Show more